profile
viewpoint
Jeffrey 'jf' Lim jf Singapore, Singapore Full-stack Problem-Solver

jf/rbenv-gemset 601

KISS yet powerful gem / gemset management for rbenv

jf/chronic 4

"Chronic is a pure Ruby natural language date parser." + improvements, corrections, speedups, and additions

jf/fosx-label 4

Add a text label to your Firefox icons in OS X

jf/jquery-validationEngine2---VE2-- 4

VE2 is a fork of the original jquery validationEngine found at http://www.position-absolute.com/articles/jquery-form-validator-because-form-validation-is-a-mess/.

chuyeow/mongrel 3

Fork of mongrel. Removes Etag generation and mongrel_cluster does rolling restarts. See the stable_1-1 branch.

jf/memcached 3

Ruby interface to the libmemcached C client. The original branch with the original code to set/get items bigger than the 1Mb limit. If you intend to use this functionality, though, it is better to track http://github.com/chuyeow/memcached

jf/chrollusion 2

Collusion for Chrome (and Safari!) — a browser extension that lets you visualize and, optionally, block the invisible websites tracking you, based on Mozilla’s Firefox add-on Collusion <https://github.com/toolness/collusion>.

jf/feather 1

personally-managed copy of the current feather. Call it "feather-stable", or "feather-works"!!! Meant to go in concert with jf/feather-plugins.

jf/feather-plugins 1

"feather-plugins-stable". Maintained, and designed to work in concert with jf/feather.

jf/mini_magick 1

mini_magick, - with my own fixes and patches

Pull request review commenthashicorp/nomad

demo/vagrant/Vagrantfile: Update Nomad version (0.10.4 -> latest, 0.10.5)

 sudo docker --version sudo apt-get install unzip curl vim -y  echo "Installing Nomad..."-NOMAD_VERSION=0.10.4+NOMAD_VERSION=0.10.5

yup. Thanks! It's done now :)

jf

comment created time in a month

push eventjf/nomad

Jeffrey 'jf' Lim

commit sha 11bb107615ab7271642bda990291e56ddc316e61

demo/vagrant/Vagrantfile: Update Nomad version (0.10.4 -> latest 0.11.0)

view details

push time in a month

push eventjf/nomad

Michael Lange

commit sha 524e3a96f8ef1130626c61c53daece165f060074

Change CSI to Storage and mark it as beta

view details

Michael Lange

commit sha cd8c92b7d46192f88d78ba4fc14e1e60e2246917

Move beta to a tag

view details

Michael Lange

commit sha 46dca9c621e57008297b3abf28b6fd5ca2ea2b5c

Add new gutter menu tag pattern to Storybook

view details

Nick Ethier

commit sha 88438e8982b674a3d4e553e9255b99f8ac8aa18f

tr/service_hook: prevent Update from running before Poststart has finished

view details

Nick Ethier

commit sha d4a3524064297ff4c908f1870e06ebe5a02c2449

tr/service_hook: update hook fields during update when poststart hasn't finished

view details

Mahmood Ali

commit sha 67880310a10011a0ddc5a17095479ea5492a9a35

backend: support WS authentication handshake in alloc/exec The javascript Websocket API doesn't support setting custom headers (e.g. `X-Nomad-Token`). This change adds support for having an authentication handshake message: clients can set `ws_handshake` URL query parameter to true and send a single handshake message with auth token first before any other mssage. This is a backward compatible change: it does not affect nomad CLI path, as it doesn't set `ws_handshake` parameter.

view details

Mahmood Ali

commit sha cad5261ec14cce76e62a29637ac325572c932994

ui: send authentication ws handshake Have the UI send the authentication websocket handshake message.

view details

Buck Doyle

commit sha b7999b31fb4c339eba80ce7b2fa1bbf2cdcef213

Add space

view details

Buck Doyle

commit sha 4fccaaa2e39e226c954dbd1ead4ff42fea1d7772

Change to setting token directly Most tests bypass setting the token via the UI, instead choosing to set it in localStorage directly, because the acceptance tests for the token UI are sufficient to exercise that part of the UI, so this speeds up the test a bit.

view details

Buck Doyle

commit sha f1d9e878a7718bf87fce19a7e82e2b7de078d772

Remove intermediate storage variable

view details

Buck Doyle

commit sha 4fa139a2fd55e63e39d0590ca9cd873a7c12fcdc

Remove redundant assertions from token exec test This only needs to check that the token is sent, the rest of the assertions were covered by the previous test.

view details

Buck Doyle

commit sha 2afe4441b4368f545922ee51b3bd7319fa5cc3b7

Remove redundant assertions These are more things that are already covered elsewhere.

view details

Buck Doyle

commit sha dd1b2dc37dff6cb42759846bd968a0b0051e284a

Remove redundant pause

view details

Buck Doyle

commit sha c75657774ae57e749e91ea5af504735d6201deae

Remove redundant step assertion

view details

Mahmood Ali

commit sha 5562abd7bf6cc696742c1ffc56f5535c7ddfeac1

fixup! backend: support WS authentication handshake in alloc/exec

view details

Mahmood Ali

commit sha 4a92a27db774e32d179a183e43c0d9317ee9e87b

ui: explicit reference to window.localStorage

view details

Michael Lange

commit sha d74a6c971f8806d6aa9aee09ecf96176ba1285ea

Sort alphabetically, A first

view details

Michael Lange

commit sha 05d719477e57350348e22f1d904dedb1bc7520a4

Filter out volumes that don't match the chosen namespace

view details

Michael Lange

commit sha a9c57a1d1c6d9a4ce87be6651e0de7c991a50103

Annotate volume row and make the tr clickable

view details

Michael Lange

commit sha 227e5909715f771564aa77a515c948036f590134

Correctly handle the namespace query param and forbidden state

view details

push time in a month

issue commentsaltstack/salt

salt-ssh always tries to connect to reverse hostname

that if doesnt even get triggered, so this is moot.

max-arnold

comment created time in a month

issue commentsaltstack/salt

archive.extracted still fails with `UnicodeEncodeError`s

I'm on Catalina

jf

comment created time in a month

issue commentsaltstack/salt

salt-ssh always tries to connect to reverse hostname

@Ch3LL I think the problem might be somewhere else. At least on my system.

If I insert a log.error(running) in the handle_ssh method, after the for host in running: line (this would be https://github.com/saltstack/salt/blob/v2019.2.2/salt/client/ssh/init.py#L607 if you're still looking at that version; but my version is now as per detailed above), I can see that I only loop through things twice:

[ERROR   ] {'vm-aa': {'thread': <Process(Process-1, started)>}}
[ERROR   ] {'vm-aa': {'thread': <Process(Process-1, stopped[SIGSEGV])>}}

It looks like a problem in Single (?), where the thread results in a SIGSEGV. If I have an entry in /etc/hosts, I do not get the SIGSEGV

max-arnold

comment created time in a month

issue commentsaltstack/salt

salt-ssh always tries to connect to reverse hostname

To add on (why, why, why) I now discover that with the latest version of salt-ssh on the mac, whereas in the past I just needed to have a host be added to /etc/salt/roster, now I need to have a reverse entry for it in /etc/hosts as well??

Without an entry in /etc/hosts:

# salt-ssh vm-aa test.ping
[ERROR   ] Target 'vm-aa' did not return any data, probably due to an error.
vm-aa:
    Target 'vm-aa' did not return any data, probably due to an error.
Salt Version:
           Salt: 3000.1

Dependency Versions:
           cffi: 1.12.2
       cherrypy: unknown
       dateutil: 2.8.0
      docker-py: Not Installed
          gitdb: 2.0.6
      gitpython: 2.1.15
         Jinja2: 2.10.1
        libgit2: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.7
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: 2.19
       pycrypto: 3.8.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 3.5.4 (default, Mar 27 2020, 15:24:03)
   python-gnupg: 0.4.4
         PyYAML: 5.1.2
          PyZMQ: 18.0.1
          smmap: 3.0.1
        timelib: 0.2.4
        Tornado: 4.5.3
            ZMQ: 4.3.1

System Versions:
           dist:
         locale: UTF-8
        machine: x86_64
        release: 19.3.0
         system: Darwin
        version: 10.15.3 x86_64
max-arnold

comment created time in a month

issue commentsaltstack/salt

archive.extracted still fails with `UnicodeEncodeError`s

I installed it using the OS X pkg

jf

comment created time in a month

issue commenthashicorp/nomad

`make bootstrap` fails because `scripts/install-codecgen.sh` assumes a copy of github.com/ugorji/go is checked out

Thanks, @notnoop . No, my nomad repo isn't outside GOPATH. I followed the README, and checked it out to $HOME/go/src/github.com/hashicorp/nomad. And I don't have GO111MODULE=on because the README (https://github.com/hashicorp/nomad#contributing-to-nomad) doesn't mention anything like that. I've got a VM, with go1.14.1 installed in $HOME/go (which is my $GOPATH)

jf

comment created time in 2 months

issue commenthashicorp/nomad

`make bootstrap` fails because `scripts/install-codecgen.sh` assumes a copy of github.com/ugorji/go is checked out

btw, if I could tag on a follow-up question, if this is fixed, do you guys still get problems with make dev? go is reporting "inconsistent vendoring" still after my make deps fix.

jf

comment created time in 2 months

issue openedhashicorp/nomad

`make bootstrap` fails because `scripts/install-codecgen.sh` assumes a copy of github.com/ugorji/go/codec is checked out

On a fresh system, make bootstrap fails at make dev:

vagrant@node1:~/go/src/github.com/hashicorp/nomad$ make bootstrap
==> Updating build dependencies...
GO111MODULE=on go get -u github.com/kardianos/govendor
go: golang.org/x/sys upgrade => v0.0.0-20200406155108-e3b113bbe6a4
go: gopkg.in/yaml.v2 upgrade => v2.2.8
go: github.com/pkg/errors upgrade => v0.9.1
go: golang.org/x/net upgrade => v0.0.0-20200324143707-d3edc9973b7e
go: golang.org/x/tools upgrade => v0.0.0-20200406213809-066fd1390ee0
go: golang.org/x/text upgrade => v0.3.2
go: golang.org/x/crypto upgrade => v0.0.0-20200406173513-056763e48d71
go get -u github.com/hashicorp/go-bindata/go-bindata
go: found github.com/hashicorp/go-bindata/go-bindata in github.com/hashicorp/go-bindata v3.0.7+incompatible
go get -u github.com/elazarl/go-bindata-assetfs/go-bindata-assetfs
go: found github.com/elazarl/go-bindata-assetfs/go-bindata-assetfs in github.com/elazarl/go-bindata-assetfs v1.0.0
GO111MODULE=on go get -u github.com/a8m/tree/cmd/tree
go: found github.com/a8m/tree/cmd/tree in github.com/a8m/tree v0.0.0-20181222104329-6a0b80129de4
GO111MODULE=on go get -u github.com/magiconair/vendorfmt/cmd/vendorfmt
go: found github.com/magiconair/vendorfmt/cmd/vendorfmt in github.com/magiconair/vendorfmt v0.0.0-20170905193701-0fde667441eb
GO111MODULE=on go get -u gotest.tools/gotestsum
go: golang.org/x/crypto upgrade => v0.0.0-20200406173513-056763e48d71
go: github.com/spf13/pflag upgrade => v1.0.5
go: golang.org/x/net upgrade => v0.0.0-20200324143707-d3edc9973b7e
go: github.com/mattn/go-colorable upgrade => v0.1.6
go: golang.org/x/sys upgrade => v0.0.0-20200406155108-e3b113bbe6a4
go: github.com/sirupsen/logrus upgrade => v1.5.0
go: github.com/fatih/color upgrade => v1.9.0
go: github.com/mattn/go-isatty upgrade => v0.0.12
go: github.com/konsorten/go-windows-terminal-sequences upgrade => v1.0.2
go: github.com/pkg/errors upgrade => v0.9.1
go: golang.org/x/sync upgrade => v0.0.0-20200317015054-43a5402ce75a
GO111MODULE=on go get -u github.com/fatih/hclfmt
GO111MODULE=on go get -u github.com/golang/protobuf/protoc-gen-go@v1.3.4
go: found github.com/golang/protobuf/protoc-gen-go in github.com/golang/protobuf v1.3.4
Installing codec/codecgen@08f7b401aef15f3d544472dd46bf6788cdfe55bf ...
fatal: not a git repository (or any of the parent directories): .git
go: golang.org/x/tools upgrade => v0.0.0-20200406213809-066fd1390ee0
go: golang.org/x/xerrors upgrade => v0.0.0-20191204190536-9bdfabe68543
fatal: not a git repository (or any of the parent directories): .git
GNUmakefile:159: recipe for target 'deps' failed
make: *** [deps] Error 128
vagrant@node1:~/go/src/github.com/hashicorp/nomad$

I managed to trace it to scripts/install-codecgen.sh, and it looks like it assumes that you have a copy of github.com/ugorji/go/codec checked out at that specific location in your GOPATH; even if nothing else prior has checked it out there. These are the offending lines:

# Either fetch in existing git repo or use go get to clone
git -C "$(go env GOPATH)"/src/github.com/ugorji/go/codec fetch -q || go get -d -u github.com/ugorji/go/codec/codecgen
git -C "$(go env GOPATH)"/src/github.com/ugorji/go/codec checkout --quiet $GIT_TAG
go install github.com/ugorji/go/codec/codecgen

I managed to fix it by manually checking out the repo (github.com/ugorji/go) and then manually go install-ing myself... but this should be fixed. This is assuming that as per https://github.com/hashicorp/nomad/issues/2912#issuecomment-318440026, all I need is the binary, and github.com/ugorji/go doesnt really need to go under $GOPATH/src:

Hey @ethandrower,

Sorry I won't be able to give to great of advice but you do just need it in the path. By default it is installed under $GOPATH/bin. This is how go binaries get installed by default so it is worth just adding that to your path and then sourcing your bashrc/profile/etc and trying again!

Good luck!

created time in 2 months

push eventjf/nomad

James Rasell

commit sha d29f7907ba8cf76ee5fe4dadddbb1172b747763d

plugin: ensure plugin loader maps correct API version to type. The plugin loader supplies a version map to ensure the Nomad agent can support the plugins at the version they specify. The map was incorrectly mapping the driver type to the device API supported version identifier. This currently does not cause a bug as both device and driver versions are the same string. This could cause problems in the future, however, if either plugin interface were to change and require version updates.

view details

Charlie Voiselle

commit sha 2be4f413af59b6f028f401b3288a88d7f3a3b3b6

Adding link to learn track

view details

Charlie Voiselle

commit sha 0f702f48e59c667d57c123f0750c469d30b88a79

Shortening Learn CTA sentence.

view details

Mahmood Ali

commit sha e625f07b57a98ad6961a1a36908fc7c5a21f28cb

fix codegen for ugorji/go When generating ugorji/go package, we should use github.com/hashicorp/go-msgpack/codec instead. Also fix the reference for codegen_generated

view details

Mahmood Ali

commit sha 6cd6af4ebc3c32a3ae9caffa69369c9117384819

Merge pull request #7578 from hashicorp/b-fix-structs-generation fix codegen for ugorji/go

view details

James Rasell

commit sha 4b1d68019e08b8af6e231d4e44695695a9e4cf1c

Merge pull request #7558 from hashicorp/b-ensure-correct-plugin-version-mapping plugin: ensure plugin loader maps correct API version to type.

view details

Buck Doyle

commit sha 502d2734ce47c741fd6e7ab4176440e56f28e599

UI: Add localStorage persistence of exec command (#7563) This closes #7469. Trivial thanks to localStorageProperty! 🥳

view details

Seth Hoenig

commit sha 44f884eb5411647036ce0f330c147d413df06dec

docs: add documentation for proxy.expose configuration This changeset adds documentation changes for the new `proxy.expose` stanza as well as the `check.expose` parameter. The examples are centered around proposed changes for the "countdash" `dashboard-service` in [demo-consul-101](github.com/hashicorp/demo-consul-101/pull/6). The dashboard service will now serve two additonal endpoints - `/health/api` - `/metrics` which should serve nicely as expose-able paths.

view details

Tim Gross

commit sha 245a4c067a71fe69e440169c7255e676309569ff

hclfmt test fixtures (#7584)

view details

Tim Gross

commit sha ec457bf61e34382cedd1c624de90f928d7fe583e

set safe default for CSI plugin MaxVolumes (#7583)

view details

Chris Baker

commit sha f23695e07aa476b2485c4f15cef59b46e878e42c

adding raft and state_store support to track job scaling events updated ScalingEvent API to record "message string,error bool" instead of confusing "reason,error *string"

view details

Buck Doyle

commit sha 88ff339f4d5bf461229e4bff018ef108fbb12d0a

CI: add xUnit reporting for UI tests (#7585) This surfaces test failures more clearly on CircleCI by adding testem-multi-reporter to report both via the default TAP reporter as well as an xUnit reporter whose output is stored as an artefact.

view details

Mike Wickett

commit sha 389d5711dc0a7aa325f11fd0e2420ff85c30457f

website: update netlify redirects syntax

view details

Chris Baker

commit sha 10ffa7eee5597bd693eb51d8a321387d0370a81e

scaling api: more testing around the scaling events api

view details

Chris Baker

commit sha 56e5494e48646c9d6ecbb1a43221087f638b3c66

Update nomad/job_endpoint.go Co-Authored-By: Drew Bailey <2614075+drewbailey@users.noreply.github.com>

view details

Chris Baker

commit sha 026245b185548c68ceb940137c960a198624399a

Update nomad/state/state_store.go Co-Authored-By: Drew Bailey <2614075+drewbailey@users.noreply.github.com>

view details

Chris Baker

commit sha 01f0656f95a1c4d646bb71d9d4a596a86c414846

Update nomad/state/state_store.go Co-Authored-By: Drew Bailey <2614075+drewbailey@users.noreply.github.com>

view details

Seth Hoenig

commit sha 98db449208ae4ed1068abada33dba3c4fcce1e4e

connect: fix bug where absent connect.proxy stanza needs default config In some refactoring, a bug was introduced where if the connect.proxy stanza in a submitted job was nil, the default proxy configuration would not be initialized with default values, effectively breaking Connect. connect { sidecar_service {} # should work } In contrast, by setting an empty proxy stanza, the config values would be inserted correctly. connect { sidecar_service { proxy {} # workaround } } This commit restores the original behavior, where having a proxy stanza present is not required. The unit test for this case has also been corrected.

view details

Chris Baker

commit sha 742948e724f793ec3adb74c08c0eb7d104be6f87

added indices to the job scaling events, so we could properly do blocking queries on the job scaling status

view details

Chris Baker

commit sha 91a9e9cd00a630e7c4daeb5464f954488c5c0df3

Merge branch 'f-7422-scaling-events' of github.com:hashicorp/nomad into f-7422-scaling-events

view details

push time in 2 months

push eventjf/nomad

James Rasell

commit sha d29f7907ba8cf76ee5fe4dadddbb1172b747763d

plugin: ensure plugin loader maps correct API version to type. The plugin loader supplies a version map to ensure the Nomad agent can support the plugins at the version they specify. The map was incorrectly mapping the driver type to the device API supported version identifier. This currently does not cause a bug as both device and driver versions are the same string. This could cause problems in the future, however, if either plugin interface were to change and require version updates.

view details

Charlie Voiselle

commit sha 2be4f413af59b6f028f401b3288a88d7f3a3b3b6

Adding link to learn track

view details

Ben Buzbee

commit sha a3c3f7e88fbc7c94197aac0c03299911578cb3f2

Parse security_opts before sending them to docker daemon Fixes #6720 Copy the parsing function from the docker CLI. Docker daemon expects to see JSON for seccomp file not a path.

view details

Mahmood Ali

commit sha b931961053ad5e119ea8770f7bcbe38ef8a82a7a

Merge pull request #7554 from benbuzbee/benbuz/fix-seccomp-file Parse security_opts before sending them to docker daemon

view details

Charlie Voiselle

commit sha 0f702f48e59c667d57c123f0750c469d30b88a79

Shortening Learn CTA sentence.

view details

Buck Doyle

commit sha ce719b76cc1499f7054e4ddbf8609ad4d912dfbd

UI: Change exec button to not show on dead jobs (#7548) I still want to add acceptance tests for the existence of these buttons but this change makes the exec button for jobs behave similarly to the others.

view details

Buck Doyle

commit sha e2efb0c0f70968792e513585abe07a4e940b5eb9

UI: Add exec loading template (#7566) This closes #7460. Before this, there was an incongruous flash of the non-exec UI during loading.

view details

Lang Martin

commit sha bc750d8bb02da76984020e6c89f97973891d1a84

csi: add node events to report progress mounting and unmounting volumes (#7547) * nomad/structs/structs: new NodeEventSubsystemCSI * client/client: pass triggerNodeEvent in the CSIConfig * client/pluginmanager/csimanager/instance: add eventer to instanceManager * client/pluginmanager/csimanager/manager: pass triggerNodeEvent * client/pluginmanager/csimanager/volume: node event on [un]mount * nomad/structs/structs: use storage, not CSI * client/pluginmanager/csimanager/volume: use storage, not CSI * client/pluginmanager/csimanager/volume_test: eventer * client/pluginmanager/csimanager/volume: event on error * client/pluginmanager/csimanager/volume_test: check event on error * command/node_status: remove an extra space in event detail format * client/pluginmanager/csimanager/volume: use snake_case for details * client/pluginmanager/csimanager/volume_test: snake_case details

view details

Lang Martin

commit sha 5b010fab10717c7fce4ef0d58a285a4adc4f4948

csi: use node MaxVolumes during scheduling (#7565) * nomad/state/state_store: CSIVolumesByNodeID ignores namespace * scheduler/scheduler: add CSIVolumesByNodeID to the state interface * scheduler/feasible: check node MaxVolumes * nomad/csi_endpoint: no namespace inn CSIVolumesByNodeID anymore * nomad/state/state_store: avoid DenormalizeAllocationSlice * nomad/state/iterator: clean up SliceIterator Next * scheduler/feasible_test: block with MaxVolumes * nomad/state/state_store_test: fix args to CSIVolumesByNodeID

view details

Zack Smith

commit sha 32545fc04a6527826ea64efd266ae8e0f4323d18

Fix syntax error in docs Prior to this commit, the HCL syntax was invalid. This commit adds a `,` to make the example pass syntax checks.

view details

Zack Smith

commit sha fe732feb2938eaee7fd81d55092c1b161291de42

Merge pull request #7569 from acidprime/fix/syntax/codeblock [docs] Fix syntax error in docs

view details

Seth Hoenig

commit sha 69f19cc0c0c08249ed368757b1198231a3782b4f

client: use consistent name for struct receiver parameter This helps reduce the number of squiggly lines in Goland.

view details

Seth Hoenig

commit sha 2a9749c41c4e5936eba652e45017c3adb839d276

connect: enable proxy.passthrough configuration Enable configuration of HTTP and gRPC endpoints which should be exposed by the Connect sidecar proxy. This changeset is the first "non-magical" pass that lays the groundwork for enabling Consul service checks for tasks running in a network namespace because they are Connect-enabled. The changes here provide for full configuration of the connect { sidecar_service { proxy { expose { paths = [{ path = <exposed endpoint> protocol = <http or grpc> local_path_port = <local endpoint port> listener_port = <inbound mesh port> }, ... ] } } } stanza. Everything from `expose` and below is new, and partially implements the precedent set by Consul: https://www.consul.io/docs/connect/registration/service-registration.html#expose-paths-configuration-reference Combined with a task-group level network port-mapping in the form: port "exposeExample" { to = -1 } it is now possible to "punch a hole" through the network namespace to a specific HTTP or gRPC path, with the anticipated use case of creating Consul checks on Connect enabled services. A future PR may introduce more automagic behavior, where we can do things like 1) auto-fill the 'expose.path.local_path_port' with the default value of the 'service.port' value for task-group level connect-enabled services. 2) automatically generate a port-mapping 3) enable an 'expose.checks' flag which automatically creates exposed endpoints for every compatible consul service check (http/grpc checks on connect enabled services).

view details

Seth Hoenig

commit sha ee3b43e6c0418b3a062727854c93fa561105d985

jobspec: parse multi expose.path instead of explicit slice

view details

Seth Hoenig

commit sha e63f13a0da38b609ebf3c2028736e6feeae1aee3

connect: enable automatic expose paths for individual group service checks Part of #6120 Building on the support for enabling connect proxy paths in #7323, this change adds the ability to configure the 'service.check.expose' flag on group-level service check definitions for services that are connect-enabled. This is a slight deviation from the "magic" that Consul provides. With Consul, the 'expose' flag exists on the connect.proxy stanza, which will then auto-generate expose paths for every HTTP and gRPC service check associated with that connect-enabled service. A first attempt at providing similar magic for Nomad's Consul Connect integration followed that pattern exactly, as seen in #7396. However, on reviewing the PR we realized having the `expose` flag on the proxy stanza inseperably ties together the automatic path generation with every HTTP/gRPC defined on the service. This makes sense in Consul's context, because a service definition is reasonably associated with a single "task". With Nomad's group level service definitions however, there is a reasonable expectation that a service definition is more abstractly representative of multiple services within the task group. In this case, one would want to define checks of that service which concretely make HTTP or gRPC requests to different underlying tasks. Such a model is not possible with the course `proxy.expose` flag. Instead, we now have the flag made available within the check definitions themselves. By making the expose feature resolute to each check, it is possible to have some HTTP/gRPC checks which make use of the envoy exposed paths, as well as some HTTP/gRPC checks which make use of some orthongonal port-mapping to do checks on some other task (or even some other bound port of the same task) within the task group. Given this example, group "server-group" { network { mode = "bridge" port "forchecks" { to = -1 } } service { name = "myserver" port = 2000 connect { sidecar_service { } } check { name = "mycheck-myserver" type = "http" port = "forchecks" interval = "3s" timeout = "2s" method = "GET" path = "/classic/responder/health" expose = true } } } Nomad will automatically inject (via job endpoint mutator) the extrapolated expose path configuration, i.e. expose { path { path = "/classic/responder/health" protocol = "http" local_path_port = 2000 listener_port = "forchecks" } } Documentation is coming in #7440 (needs updating, doing next) Modifications to the `countdash` examples in https://github.com/hashicorp/demo-consul-101/pull/6 which will make the examples in the documentation actually runnable. Will add some e2e tests based on the above when it becomes available.

view details

Seth Hoenig

commit sha df417f71009361a7b0dc812ddaa92e843d1e238f

docs: note why check.Expose is not part of chech.Hash

view details

Seth Hoenig

commit sha b6fe1e2558598e6f5f851af4aa16924d555bc4e7

Merge pull request #7323 from hashicorp/f-connect-expose-checks connect: enable proxy.expose configuration

view details

Mahmood Ali

commit sha 81f3ff6510b2e5eaa1c5b4e2535cfd803d7d8eb7

batch updates of changelog items (#7570) * batch updates of changelog items [ci skip] * Update CHANGELOG.md Co-Authored-By: Jasmine Dahilig <jasmine@dahilig.com> * add PR to changelog * update ui changelog message * docs: note connect expose paths configuration in changelog Co-authored-by: Michael Schurter <mschurter@hashicorp.com> Co-authored-by: Jasmine Dahilig <jasmine@dahilig.com> Co-authored-by: Seth Hoenig <shoenig@hashicorp.com>

view details

Seth Hoenig

commit sha 9495ea5112561a63f39101994ffd369908b3d648

Merge pull request #7573 from hashicorp/f-connect-expose-checks-percheck merge changes for expose checks percheck

view details

Mahmood Ali

commit sha 4a0110f5e5b1ad5cc3a32b2f3bddd0a39f76dcbf

Use latest go-bindata and go-bindata-assetfs These dep tools aren't tagged properly so shouldn't be installed with go mod

view details

push time in 2 months

push eventjf/nomad

James Rasell

commit sha d29f7907ba8cf76ee5fe4dadddbb1172b747763d

plugin: ensure plugin loader maps correct API version to type. The plugin loader supplies a version map to ensure the Nomad agent can support the plugins at the version they specify. The map was incorrectly mapping the driver type to the device API supported version identifier. This currently does not cause a bug as both device and driver versions are the same string. This could cause problems in the future, however, if either plugin interface were to change and require version updates.

view details

Charlie Voiselle

commit sha 2be4f413af59b6f028f401b3288a88d7f3a3b3b6

Adding link to learn track

view details

Charlie Voiselle

commit sha 0f702f48e59c667d57c123f0750c469d30b88a79

Shortening Learn CTA sentence.

view details

James Rasell

commit sha 4b1d68019e08b8af6e231d4e44695695a9e4cf1c

Merge pull request #7558 from hashicorp/b-ensure-correct-plugin-version-mapping plugin: ensure plugin loader maps correct API version to type.

view details

Buck Doyle

commit sha 502d2734ce47c741fd6e7ab4176440e56f28e599

UI: Add localStorage persistence of exec command (#7563) This closes #7469. Trivial thanks to localStorageProperty! 🥳

view details

Seth Hoenig

commit sha 44f884eb5411647036ce0f330c147d413df06dec

docs: add documentation for proxy.expose configuration This changeset adds documentation changes for the new `proxy.expose` stanza as well as the `check.expose` parameter. The examples are centered around proposed changes for the "countdash" `dashboard-service` in [demo-consul-101](github.com/hashicorp/demo-consul-101/pull/6). The dashboard service will now serve two additonal endpoints - `/health/api` - `/metrics` which should serve nicely as expose-able paths.

view details

Tim Gross

commit sha 245a4c067a71fe69e440169c7255e676309569ff

hclfmt test fixtures (#7584)

view details

Tim Gross

commit sha ec457bf61e34382cedd1c624de90f928d7fe583e

set safe default for CSI plugin MaxVolumes (#7583)

view details

Chris Baker

commit sha f23695e07aa476b2485c4f15cef59b46e878e42c

adding raft and state_store support to track job scaling events updated ScalingEvent API to record "message string,error bool" instead of confusing "reason,error *string"

view details

Buck Doyle

commit sha 88ff339f4d5bf461229e4bff018ef108fbb12d0a

CI: add xUnit reporting for UI tests (#7585) This surfaces test failures more clearly on CircleCI by adding testem-multi-reporter to report both via the default TAP reporter as well as an xUnit reporter whose output is stored as an artefact.

view details

Mike Wickett

commit sha 389d5711dc0a7aa325f11fd0e2420ff85c30457f

website: update netlify redirects syntax

view details

Chris Baker

commit sha 10ffa7eee5597bd693eb51d8a321387d0370a81e

scaling api: more testing around the scaling events api

view details

Chris Baker

commit sha 56e5494e48646c9d6ecbb1a43221087f638b3c66

Update nomad/job_endpoint.go Co-Authored-By: Drew Bailey <2614075+drewbailey@users.noreply.github.com>

view details

Chris Baker

commit sha 026245b185548c68ceb940137c960a198624399a

Update nomad/state/state_store.go Co-Authored-By: Drew Bailey <2614075+drewbailey@users.noreply.github.com>

view details

Chris Baker

commit sha 01f0656f95a1c4d646bb71d9d4a596a86c414846

Update nomad/state/state_store.go Co-Authored-By: Drew Bailey <2614075+drewbailey@users.noreply.github.com>

view details

Seth Hoenig

commit sha 98db449208ae4ed1068abada33dba3c4fcce1e4e

connect: fix bug where absent connect.proxy stanza needs default config In some refactoring, a bug was introduced where if the connect.proxy stanza in a submitted job was nil, the default proxy configuration would not be initialized with default values, effectively breaking Connect. connect { sidecar_service {} # should work } In contrast, by setting an empty proxy stanza, the config values would be inserted correctly. connect { sidecar_service { proxy {} # workaround } } This commit restores the original behavior, where having a proxy stanza present is not required. The unit test for this case has also been corrected.

view details

Chris Baker

commit sha 742948e724f793ec3adb74c08c0eb7d104be6f87

added indices to the job scaling events, so we could properly do blocking queries on the job scaling status

view details

Chris Baker

commit sha 91a9e9cd00a630e7c4daeb5464f954488c5c0df3

Merge branch 'f-7422-scaling-events' of github.com:hashicorp/nomad into f-7422-scaling-events

view details

Seth Hoenig

commit sha 7c4e697dcc0a558dccd3491ed00ff4b0950e284e

Merge pull request #7588 from hashicorp/b-unbreak-connect-proxy-nil connect: fix bug where absent connect.proxy stanza needs default config

view details

Chris Baker

commit sha 415eafe133e72f8cfaf3d48ae51d4d15784419fd

job_endpoint: fixed bad test

view details

push time in 2 months

PR opened hashicorp/nomad

Fix/improve "job plan" messaging

I think the messaging that job plan gives you about how the index is matched needs to be fixed/improved. If anything, the "job modify index" is given, rather than "returned"; but I also opted to switch the order around so that it's more intuitive ("job modify index given" <-> "server-side version")

+7 -7

0 comment

3 changed files

pr created time in 2 months

create barnchjf/nomad

branch : fix_improve_job_plan_messaging

created branch time in 2 months

PR opened hashicorp/nomad

demo/vagrant/Vagrantfile: Update Nomad version (0.10.4 -> latest, 0.10.5)

as per subject. Thought I'd update it.

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchjf/nomad

branch : update_vagrantfile_nomad_version

created branch time in 2 months

delete branch jf/nomad

delete branch : update_vagrantfile_nomad_version

delete time in 2 months

PR closed hashicorp/nomad

demo/vagrant/Vagrantfile: Update Nomad version (0.10.4 -> latest, 0.10.5)

as per subject. Thought I'd update it.

+1 -1

2 comments

1 changed file

jf

pr closed time in 2 months

pull request commenthashicorp/nomad

demo/vagrant/Vagrantfile: Update Nomad version (0.10.4 -> latest, 0.10.5)

Sorry, gonna try with a new PR.

jf

comment created time in 2 months

push eventjf/nomad

Jeffrey 'jf' Lim

commit sha 72e4fb45afea42fd6fa85322652730d33688b55b

demo/vagrant/Vagrantfile: Update Nomad version (0.10.4 -> latest, 0.10.5)

view details

push time in 2 months

PR opened hashicorp/nomad

demo/vagrant/Vagrantfile: Update Nomad version (0.10.4 -> latest, 0.10.5)

as per subject. Thought I'd update it.

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchjf/nomad

branch : update_vagrantfile_nomad_version

created branch time in 2 months

fork jf/nomad

Nomad is an easy-to-use, flexible, and performant workload orchestrator that can deploy a mix of microservice, batch, containerized, and non-containerized applications. Nomad is easy to operate and scale and has native Consul and Vault integrations.

https://www.nomadproject.io/

fork in 2 months

issue commentsaltstack/salt

archive.extracted still fails with `UnicodeEncodeError`s

I see. Thanks for the response, @waynew . Thank you for the note about Python 2 support. I use Ubuntu 18.04 VMs, and I've had issues getting salt-ssh to work with them right out of the box, and resorted to installing python2.7-minimal for ssh to work. python3-minimal is already installed by default, but without python2.7-minimal (?) I still get problems:

$ salt-ssh -i vm-xx test.ping
[ERROR   ] ERROR: Failure deploying thin, retrying:
STDOUT:

STDERR:

RETCODE: 10
vm-new:
    ----------
    retcode:
        10
    stderr:
    stdout:
        ERROR: Python version error. Recommendation(s) follow:
        Install Python 2.6 / Python 3 Salt dependencies on the Salt SSH master
        to interact with Python 2.6 / Python 3 targets

Why should python2.7-minimal be ok, but not python3-minimal?

jf

comment created time in 2 months

pull request commentjf/rbenv-gemset

improve load times w/ fixed gemset iteration

Thanks for following up, @AprilArcus . This year? I should think so. I need to find time to review this again.

I thought I stated somewhere the version bump implementation should be up to me... but I don't see it here. If I approve this, I will want to do it without the forced version bump.

AprilArcus

comment created time in 3 months

pull request commentcloudhead/neovim-fuzzy

Fixed: Open selected files in splits with keybindings

hi @cloudhead , did you get time to review this?

nannery

comment created time in 3 months

more