profile
viewpoint

PR opened hashicorp/consul

Display a warning when rpc.enable_streaming = true is set on a client

This option has no effect when running as an agent.

+4 -0

0 comment

1 changed file

pr created time in 10 days

pull request commenthashicorp/consul

cli: Add consul intention list command (based on PR #6825)

Please let me know if I have to do something to make the Pull Request Labeler / triage (pull_request) test green. I assume you have to assign some labels?

karras

comment created time in 10 days

pull request commenthashicorp/consul

Quick note to steer consumers away from unmaintained python-consul

Never mind, I see what happened, I pushed the commit with the wrong email address.

markblackman

comment created time in 10 days

pull request commenthashicorp/consul

Quick note to steer consumers away from unmaintained python-consul

Thanks, sorry I missed the original request in #9526. I believe I have signed the CLA multiple times, yet github seems to disagree with me. Maybe it's a browser issue.

markblackman

comment created time in 10 days

issue commenthashicorp/consul

Heavily loaded Consul agents might leak file descriptors

Might be related to https://github.com/hashicorp/consul/issues/8312 and https://github.com/hashicorp/consul/issues/9462

pierresouchay

comment created time in 10 days

issue closedhashicorp/consul

can't filter nodes by using api.QueryQptions{Filter: "address == 10.10.10.10 "}


teststring := fmt.Sprintf("Address == %v", "10.10.10.10")
nodes, _, err := c.Catalog().Nodes(&api.QueryOptions{

Filter: teststring,
})

and i get the error:

2020/12/21 17:14:33 Unexpected response code: 500 (rpc error making call: Failed to create boolean expression evaluator: 1:17 (16): rule "number": Invalid number literal)
exit status 1

closed time in 10 days

king131

issue commenthashicorp/consul

can't filter nodes by using api.QueryQptions{Filter: "address == 10.10.10.10 "}

@mkeeler ok,It's work now. Thank you !

king131

comment created time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha bac369b0f41620f0ff1d8df682e70e48c1138c27

Merge pull request #9249 from hashicorp/dnephin/config-tags config: use fields to detect enterprise-only settings

view details

push time in 10 days

pull request commenthashicorp/consul

config: use fields to detect enterprise-only settings

:cherries::white_check_mark: Cherry pick of commit 7b45d0baea1d758fa4ffd0572d28481e65c22394 onto release/1.9.x succeeded!

dnephin

comment created time in 10 days

pull request commenthashicorp/consul

config: use fields to detect enterprise-only settings

:cherries: If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/307333.

dnephin

comment created time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha a9734b69c552a2162098397ef155d96484ea8d90

config: remove t.Parallel and some unused fields from tests Use go-cmp for better diffs in tests

view details

Daniel Nephin

commit sha ce1deae3c8c95b6f02b78d3f9c7cf2fbcd4cedd3

config: use LiteralConfig for flag values

view details

Daniel Nephin

commit sha 724a281e1c9302c75ff630d15a4b53e69a35167a

config: Use config fields to warn about enterprise settings It is no safe to assumes that the mapstructure keys will contain all the keys because some config can be specified with command line flags or literals. This change allows us to remove the json marshal/unmarshal cycle for command line flags, which will allow us to remove all of the hcl/json struct tags on config fields.

view details

Daniel Nephin

commit sha 7b45d0baea1d758fa4ffd0572d28481e65c22394

Merge pull request #9249 from hashicorp/dnephin/config-tags config: use fields to detect enterprise-only settings

view details

push time in 10 days

delete branch hashicorp/consul

delete branch : dnephin/config-tags

delete time in 10 days

PR merged hashicorp/consul

config: use fields to detect enterprise-only settings backport/1.9 theme/config

Now that config can come from non-file sources it is not safe to assumes that the mapstructure Metdata.Keys will contain all the keys because some config can be specified with command line flags or literals.

This change allows us to remove the json marshal/unmarshal cycle for command line flags, which will allow us to remove all of the hcl/json struct tags on config fields. That is done in #9250 which is a follow up to this PR.

This PR also does a bit of cleanup in some of the config tests to remove unused things and make the failure messages easier to understand.

+114 -170

0 comment

7 changed files

dnephin

pr closed time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha d083d4717b768237fb26b7713506eda9311558f0

api: Add a context to ServiceRegisterOpts So that operations can timeout instead of hanging forever

view details

Shengjing Zhu

commit sha b931e989b8a2b2d3905733db8927e1a4493bc9d0

sdk: read procfs instead of using sysctl command This drops the dependency of sysctl command

view details

Michael Montgomery

commit sha 5b6ac035fff5d3b020d7cb45be7226e3313badf5

Resolves #6074. Adds new option to configure HTTP Server's MaxHeaderBytes with option `-http-max-header-bytes` Adds tests for behavior

view details

Kyle Havlovitz

commit sha af34b26221f0bdb8301bd15989cf8de7c2293f6a

connect: Add logic for updating secondary DC intermediate on config set

view details

Kyle Havlovitz

commit sha 6fba82a4fa7b521af84b5967726a01332ea1e216

connect: Add CAManager for synchronizing CA operations

view details

Kyle Havlovitz

commit sha 16e95f1d7bfb638ee732badb275530967fe9434f

Reorganize some CA manager code for correctness/readability

view details

Daniel Nephin

commit sha 0ee86935f0c2786afd25add5ff7f7ee079de7c44

Remove two unused delegate methods

view details

Daniel Nephin

commit sha 3885835e8c57eb9f3d86efdb8c78d7531f13ff28

acl: remove a test-only method

view details

Kyle Havlovitz

commit sha 9be7c6401ce71a2e83187ed50181b9086dc3a361

connect: update some function comments in CA manager

view details

Kit Patella

commit sha 9e54e897d7f2f4206bcefc295e948d7260da67a2

remove stale entries and rename/define acl.resolveToken

view details

Kit Patella

commit sha 5c09dc322ea05b2e292157ef6b7acc689e597486

add telemetry and definition help entries for missing catalog and acl metrics

view details

Kyle Havlovitz

commit sha 0bfda4481f004fd40759b9afe99518dc5b37bc3a

Add CA server delegate interface for testing

view details

Michael Montgomery

commit sha 585c84e9ff2b1fd1e2858bb237ee5be7348420c9

Merge branch 'master' into 6074-allow-config-MaxHeaderBytes

view details

Pierre Souchay

commit sha 45151090c15e2a494fe01dea087e8924390f3909

[Streaming] Predictable order for results of /health/service/:serviceName to mimic memdb This ensures the result is consitent with/witout streaming Will partially fix #9239

view details

Pierre Souchay

commit sha fb91190ee24acfa8790d679fd1d9a8bfed610580

Added changelog entry for 9247

view details

Kit Patella

commit sha c6b29a8bba9868c48de43f134f75608e988c46f6

Merge pull request #9245 from hashicorp/telemetry/fix-missing-and-stale-docs Telemetry/fix missing and stale docs

view details

Kyle Havlovitz

commit sha 13c31ccfce50bb2d34d01cfdf3331690ecc4e33b

Clean up the logic in persistNewRootAndConfig

view details

Daniel Nephin

commit sha b847c035d0172cc5c2b87656089a5462e04ca0a9

logging: remove unnecessary package vars

view details

Daniel Nephin

commit sha 2dcc6966fe7b82bb81aad813fa42742e63d4784d

logging: call pruneFiles on startup To ensure that files are pruned before a new one is created. Also clean up the logic in pruneFiles

view details

Sabeen Syed

commit sha cfbefc45f0df22aa055727571446a8ee2f5e3025

Update NIA architecture image (#9180)

view details

push time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha d083d4717b768237fb26b7713506eda9311558f0

api: Add a context to ServiceRegisterOpts So that operations can timeout instead of hanging forever

view details

Shengjing Zhu

commit sha b931e989b8a2b2d3905733db8927e1a4493bc9d0

sdk: read procfs instead of using sysctl command This drops the dependency of sysctl command

view details

Michael Montgomery

commit sha 5b6ac035fff5d3b020d7cb45be7226e3313badf5

Resolves #6074. Adds new option to configure HTTP Server's MaxHeaderBytes with option `-http-max-header-bytes` Adds tests for behavior

view details

Kyle Havlovitz

commit sha af34b26221f0bdb8301bd15989cf8de7c2293f6a

connect: Add logic for updating secondary DC intermediate on config set

view details

Kyle Havlovitz

commit sha 6fba82a4fa7b521af84b5967726a01332ea1e216

connect: Add CAManager for synchronizing CA operations

view details

Kyle Havlovitz

commit sha 16e95f1d7bfb638ee732badb275530967fe9434f

Reorganize some CA manager code for correctness/readability

view details

Daniel Nephin

commit sha 0ee86935f0c2786afd25add5ff7f7ee079de7c44

Remove two unused delegate methods

view details

Daniel Nephin

commit sha 3885835e8c57eb9f3d86efdb8c78d7531f13ff28

acl: remove a test-only method

view details

Kyle Havlovitz

commit sha 9be7c6401ce71a2e83187ed50181b9086dc3a361

connect: update some function comments in CA manager

view details

Kit Patella

commit sha 9e54e897d7f2f4206bcefc295e948d7260da67a2

remove stale entries and rename/define acl.resolveToken

view details

Kit Patella

commit sha 5c09dc322ea05b2e292157ef6b7acc689e597486

add telemetry and definition help entries for missing catalog and acl metrics

view details

Kyle Havlovitz

commit sha 0bfda4481f004fd40759b9afe99518dc5b37bc3a

Add CA server delegate interface for testing

view details

Michael Montgomery

commit sha 585c84e9ff2b1fd1e2858bb237ee5be7348420c9

Merge branch 'master' into 6074-allow-config-MaxHeaderBytes

view details

Pierre Souchay

commit sha 45151090c15e2a494fe01dea087e8924390f3909

[Streaming] Predictable order for results of /health/service/:serviceName to mimic memdb This ensures the result is consitent with/witout streaming Will partially fix #9239

view details

Pierre Souchay

commit sha fb91190ee24acfa8790d679fd1d9a8bfed610580

Added changelog entry for 9247

view details

Kit Patella

commit sha c6b29a8bba9868c48de43f134f75608e988c46f6

Merge pull request #9245 from hashicorp/telemetry/fix-missing-and-stale-docs Telemetry/fix missing and stale docs

view details

Kyle Havlovitz

commit sha 13c31ccfce50bb2d34d01cfdf3331690ecc4e33b

Clean up the logic in persistNewRootAndConfig

view details

Daniel Nephin

commit sha b847c035d0172cc5c2b87656089a5462e04ca0a9

logging: remove unnecessary package vars

view details

Daniel Nephin

commit sha 2dcc6966fe7b82bb81aad813fa42742e63d4784d

logging: call pruneFiles on startup To ensure that files are pruned before a new one is created. Also clean up the logic in pruneFiles

view details

Sabeen Syed

commit sha cfbefc45f0df22aa055727571446a8ee2f5e3025

Update NIA architecture image (#9180)

view details

push time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha 724a281e1c9302c75ff630d15a4b53e69a35167a

config: Use config fields to warn about enterprise settings It is no safe to assumes that the mapstructure keys will contain all the keys because some config can be specified with command line flags or literals. This change allows us to remove the json marshal/unmarshal cycle for command line flags, which will allow us to remove all of the hcl/json struct tags on config fields.

view details

push time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha 156c14ae1412789b54cc13ccb8fe51a8d9892a89

Merge pull request #9251 from hashicorp/dnephin/config-cleanup-flags-and-opts config: move testing shims and cleanup some defaults

view details

push time in 10 days

pull request commenthashicorp/consul

config: move testing shims and cleanup some defaults

:cherries::white_check_mark: Cherry pick of commit a9285ad76af9fc6ea8a2cc233151a63e00ce6c24 onto release/1.9.x succeeded!

dnephin

comment created time in 10 days

pull request commenthashicorp/consul

config: move testing shims and cleanup some defaults

:cherries: If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/307241.

dnephin

comment created time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha b53b507c5449151b6c357a7e91eb69245744fe73

config: Use config fields to warn about enterprise settings It is no safe to assumes that the mapstructure keys will contain all the keys because some config can be specified with command line flags or literals. This change allows us to remove the json marshal/unmarshal cycle for command line flags, which will allow us to remove all of the hcl/json struct tags on config fields.

view details

push time in 10 days

pull request commenthashicorp/consul

Document how clients not on K8s can join a DC in K8s

:cherries: If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/307179.

ndhanushkodi

comment created time in 10 days

push eventhashicorp/consul

Nitya Dhanushkodi

commit sha dd81e4a1ccc12d5d93088ae045e6bf9f1ed815f9

Document how clients not on K8s can join a DC in K8s. (#9438)

view details

push time in 10 days

delete branch hashicorp/consul

delete branch : docs-external-clients

delete time in 10 days

PR merged hashicorp/consul

Document how clients not on K8s can join a DC in K8s type/docs

Documents https://github.com/hashicorp/consul-helm/pull/740.

Also resolves/helps with https://github.com/hashicorp/consul-helm/issues/743.

+129 -14

1 comment

1 changed file

ndhanushkodi

pr closed time in 10 days

pull request commenthashicorp/consul

config: move testing shims and cleanup some defaults

:cherries: If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/307147.

dnephin

comment created time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha 0a44906fe384069d31bb8ce9ed5bcdfe167ca852

config: Use LiteralSource for some defaults Using the LiteralSource makes it much easier to find default values, because an IDE reports the location of a default. With an HCL string they are harder to discover. Also removes unnecessary mapstructure.Decodes of constant values.

view details

Daniel Nephin

commit sha 78f767e78ce6f263f57434282db61565940c1007

config: move testing shims to BuilderOpts And remove the devMode field from builder. This change helps make the Builder state more explicit by moving inputs to the BuilderOps struct, leaving only fields that can change during Builder.Build on the Builder struct.

view details

Daniel Nephin

commit sha a1e4b695275d30cf47be2cdc2897f99cba65001c

config: remove unused const

view details

Daniel Nephin

commit sha a9285ad76af9fc6ea8a2cc233151a63e00ce6c24

Merge pull request #9251 from hashicorp/dnephin/config-cleanup-flags-and-opts config: move testing shims and cleanup some defaults

view details

push time in 10 days

delete branch hashicorp/consul

delete branch : dnephin/config-cleanup-flags-and-opts

delete time in 10 days

PR merged hashicorp/consul

config: move testing shims and cleanup some defaults theme/config

This is a small cleanup of config.

  • starts using LiteralSource for some of the default config sources
  • unexports some functions that don't need to be exported
  • stores a BuilderOpts on Builder, which removes the need to copy over the DevMode field, and allows us to move the testing shims onto BuilderOpts. Since these are effectively inputs to Build they seem more appropriate on BuilderOpts.
+53 -77

0 comment

7 changed files

dnephin

pr closed time in 10 days

push eventhashicorp/consul

Daniel Nephin

commit sha 223b85f89e3ba8392e4658a1956c4a7a2e924eab

Merge pull request #7583 from hashicorp/dnephin/id-printing Fix printing of ID types

view details

push time in 10 days

pull request commenthashicorp/consul

Fix printing of ID types

:cherries::white_check_mark: Cherry pick of commit eaa96d8304ed72747f695b7769bc42d5a1ea3be0 onto release/1.9.x succeeded!

dnephin

comment created time in 10 days

more