profile
viewpoint

PR opened hashicorp/consul

ui: Delete old yarn lock file

As we have now moved to a workspaced project structure, we no longer need the sub project yarn lock file. This deletes it and updates the old Makefile to look further up for the node_modules folder on installation.

We also noticed we still had a .travis.yaml file hanging around so we deleted that here also.

+1 -13648

0 comment

3 changed files

pr created time in 28 minutes

create barnchhashicorp/consul

branch : ui/chore/delete-old-yarn-lock

created branch time in 30 minutes

push eventhashicorp/consul

Kevin Pruett

commit sha 6a946ec6e432a0f304fa87a4bc344ce9ea024979

Expose `expirationDate` prop in <AlertBanner/>

view details

hashicorp-ci

commit sha 9772c12426c2b97f4f5c4095fa8f033ed246cfa0

auto-updated agent/uiserver/bindata_assetfs.go from commit 948917c6b

view details

Kim Ngo

commit sha 47009930a22d91958ebc114020a35dc19d879d88

NIA: add Terraform version compatibility (#9023)

view details

Mike Morris

commit sha bc6fcfaf755a1cd6114120605c7728f515792cf7

website: update version.js (#9034)

view details

Mike Morris

commit sha 4fdc69842d91203e737d7da055f14ee66d85a618

Merge pull request #9027 from hashicorp/release/1.8.5 Merge back release/1.8.5

view details

Mike Morris

commit sha 150ebb293d125fd27af679edea08f30bdf6f4312

Merge pull request #9028 from hashicorp/merge/release/1.8.5 changelog: update formatting from 1.8.5 release

view details

Mike Morris

commit sha 5cf9ddedf91aae6bbdd90c011094516f848283bc

changelog: update to hashicorp/sentinel@v0.16.0 in Enterprise (#8984)

view details

John Cowen

commit sha c4f027fa0d596dab1bc34d39ec3ea185ac41b874

ui: Upgrade the rest of the UI to use the new Notice component (#9035)

view details

hashicorp-ci

commit sha f585db82cf27188820bc6b8b93315b72c9109f67

auto-updated agent/uiserver/bindata_assetfs.go from commit c4f027fa0

view details

Daniel Nephin

commit sha 194c7f7ae6d787a0695296de87499096f19f7ea5

ci: upgrade gotestsum So that we are using the same version as enterprise

view details

Daniel Nephin

commit sha b25a6a8d8527f3003717314172a8f3e5a6d33c7a

Merge pull request #9038 from hashicorp/dnephin/upgrade-gotestsum ci: upgrade gotestsum

view details

Paul Banks

commit sha 52d7283cd6f56fc8d0921fca3241b2e4f3b6a828

UI metrics provider dc (#9001) * Plumb Datacenter and Namespace to metrics provider in preparation for them being usable. * Move metrics loader/status to a new component and show reason for being disabled. * Remove stray console.log * Rebuild AssetFS to resolve conflicts * Yarn upgrade * mend

view details

hashicorp-ci

commit sha 5460744a958e0b151c122362586565d5f1e544ec

auto-updated agent/uiserver/bindata_assetfs.go from commit 52d7283cd

view details

Kevin Pruett

commit sha 5637683f5dfe56c9750c26b9de16cf030ddbbd1d

Merge pull request #9021 from hashicorp/pruett.alertbanner-exp Expose `expirationDate` prop in <AlertBanner/>

view details

R.B. Boyer

commit sha d7c7858d87e45a5b68269bf2eae4a0ae423b601d

Fix even more test flakes in intentions related envoy integration tests (#9013) The key thing here is to use `curl --no-keepalive` so that envoy pre-1.15 tests will reliably use the latest listener every time. Extra: - Switched away from editing line-item intentions the legacy way. - Removed some teardown scripts, as we don't share anything between cases anyway - Removed unnecessary use of `run` in some places.

view details

John Cowen

commit sha c03f15db74e62f0b57fd8cc8c5fc407caebd88b9

ui: Install storybook

view details

Randall Morey

commit sha 22a9c4ca397f1945aaa73737e65f1c6d78d761c0

remove storybook essentials

view details

push time in an hour

PR opened hashicorp/consul

Reviewers
ui: Upgrade consul-api-double to fix datacenter mocks theme/ui

See https://github.com/hashicorp/consul-api-double/pull/49

+6 -6

0 comment

3 changed files

pr created time in an hour

push eventhashicorp/consul

John Cowen

commit sha 7dd5057b82cbde9e3860ca36f1175c401d824617

Reupgrade consul-api-double

view details

push time in an hour

created taghashicorp/consul-api-double

tag6.1.4

created time in an hour

push eventhashicorp/consul-api-double

John Cowen

commit sha 3aa1426740d12401298acda770875e748f2c46e8

Bump from 6.1.3 to 6.1.4

view details

push time in an hour

push eventhashicorp/consul-api-double

John Cowen

commit sha 0738caa9f0db82d17a245045dcb9b84ee9f961b2

Actually fixup datancenters (#49)

view details

push time in an hour

PR merged hashicorp/consul-api-double

Actually fixup datacenters

The previous PR to fix datacenters didn't take into account the commas added via map. This takes an easier to read approach to output dc1 on first iteration of the map.

+7 -4

0 comment

1 changed file

johncowen

pr closed time in an hour

PR opened hashicorp/consul-api-double

Actually fixup datacenters

The previous PR to fix datacenters didn't take into account the commas added via map. This takes an easier to read approach to output dc1 on first iteration of the map.

+7 -4

0 comment

1 changed file

pr created time in an hour

create barnchhashicorp/consul-api-double

branch : fixup-datacenters

created branch time in an hour

push eventhashicorp/consul

John Cowen

commit sha cb1aa2a28fb13fee80513d3f7975e14dd58439a3

Use root yarn lockfile

view details

push time in an hour

push eventhashicorp/consul

John Cowen

commit sha 5e8aa29bf8a0eb11cd2536ed7df852bbc994df51

Explicitly upgrade consul-api-double

view details

John Cowen

commit sha 7088ae8fea40aa3753369204f6c1950d8e59b245

yarn upgrade

view details

push time in an hour

create barnchhashicorp/consul

branch : ui/bugfix/fix-up-mocks

created branch time in an hour

PR opened hashicorp/consul

Reviewers
ui: Metrics - Don't swallow metrics errors theme/ui

Previously errors were being caught in the provider and replaced with empty data. This meant that the UI would happily keep retrying the provider thinking that it was returning valid empty data even though the proxy was erroring with 404s.

This PR instead passes any errors through to the UI where it will be handled like any other event source/blocking query errors. Anything 50x-like will retry, anything 40x-like will just stop trying.

+16 -27

0 comment

2 changed files

pr created time in 2 hours

create barnchhashicorp/consul

branch : ui/feature/dont-swallow-metrics-errors

created branch time in 2 hours

created taghashicorp/consul-api-double

tag6.1.3

created time in 2 hours

push eventhashicorp/consul-api-double

John Cowen

commit sha 5b1d5ea6aad886d42e5de7e0ad5ba99b5c5086f7

Bump from 6.1.2 to 6.1.3

view details

push time in 2 hours

Pull request review commenthashicorp/consul

ui: Topology limited access banner

+<Notice+  class="topology-limited-access-banner"

If you do think the sub foldering of this is a good idea then this class should use the same pattern (topology-notice-limited-access)

kaxcode

comment created time in 2 hours

Pull request review commenthashicorp/consul

ui: Topology limited access banner

 <div id="tags" class="tab-section">   <div role="tabpanel">+  {{#if topology.FilteredByACLs}}+    <TopologyMetrics::Banner />

Should we try and stick to the <TopologyMetrics::Notice::LimitedAccess /> pattern? I know we've not been great with sticking to patterns due to all the churn lately, but we should start to try to form patterns that we are both happy with asap so we can move forwards with them.

I think here the Banner vs Notice thing stands out to me (it's using the Notice component) and if you sub folder it, it means if we get any more types of Notices we can put them in the Topology/Notice/Name folder - do you think that sounds ok?

kaxcode

comment created time in 2 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenthashicorp/consul

ui: Remove downstream dc filter

     {{#if this.hasMetricsProvider }}       <TopologyMetrics::Series         @service={{@service.Service.Service}}-        @dc={{@dc}}-        @protocol={{@protocol}}-        @noMetricsReason={{noMetricsReason}}+        @dc={{@topology.Datacenter}}+        @protocol={{@topology.Protocol}}+        @noMetricsReason={{this.noMetricsReason}}       />       <TopologyMetrics::Stats         @endpoint='summary-for-service'         @service={{@service.Service.Service}}-        @dc={{@dc}}-        @protocol={{@protocol}}-        @noMetricsReason={{noMetricsReason}}+        @dc={{@topology.Datacenter}}+        @protocol={{@topology.Protocol}}+        @noMetricsReason={{this.noMetricsReason}}

Good spot! 👏

kaxcode

comment created time in 2 hours

PullRequestReviewEvent
PullRequestReviewEvent

create barnchhashicorp/consul

branch : ui/chore/storybook

created branch time in 18 hours

push eventhashicorp/consul-api-double

John Cowen

commit sha d6afb580447b019879c7194e2b5dbe79cc382d82

We always have at least one DC, but sometimes only one, move comma (#48)

view details

push time in 19 hours

PR merged hashicorp/consul-api-double

Correct DC comma

We always have at least one DC, but sometimes only one

+2 -2

0 comment

1 changed file

johncowen

pr closed time in 19 hours

PR opened hashicorp/consul-api-double

Reviewers
Correct DC comma

We always have at least one DC, but sometimes only one

+2 -2

0 comment

1 changed file

pr created time in 19 hours

create barnchhashicorp/consul-api-double

branch : rearrange-dc-comma

created branch time in 19 hours

push eventhashicorp/consul

John Cowen

commit sha c4f027fa0d596dab1bc34d39ec3ea185ac41b874

ui: Upgrade the rest of the UI to use the new Notice component (#9035)

view details

push time in 19 hours

delete branch hashicorp/consul

delete branch : ui/chore/notice-updates

delete time in 19 hours

PR merged hashicorp/consul

ui: Upgrade the rest of the UI to use the new Notice component theme/ui

This changes all the instances of our lightweight CSS based notice component in the UI to use a Glimmer-template only component.

This also marks more of a departure from our approach of having all our CSS components split into reusable components being used and configured separately especially for our project. We've moved everything now into the notice folder altogether in one place.

+213 -144

0 comment

20 changed files

johncowen

pr closed time in 19 hours

pull request commenthashicorp/consul

UI metrics provider dc

@banks I just tried branching off of this for the 404 work and noticed I think a yarn upgrade @hashicorp/consul-api-double is needed to bring in your changes there - if its not too late might be good to add that on this PR (it should touch yarn.lock fo you)

banks

comment created time in 19 hours

Pull request review commenthashicorp/consul

UI metrics provider dc

 func (h *Handler) renderIndex(cfg *config.RuntimeConfig, fs http.FileSystem) ([] 	// have to match the encoded double quotes around the JSON string value that 	// is there as a placeholder so the end result is an actual JSON bool not a 	// string containing "false" etc.-	re := regexp.MustCompile(`%22__RUNTIME_BOOL_[A-Za-z0-9-_]+__%22`)+	re := regexp.MustCompile(`%22__RUNTIME_(BOOL|STRING)_([A-Za-z0-9-_]+)__%22`)  	content = []byte(re.ReplaceAllStringFunc(string(content), func(str string) string {-		// Trim the prefix and __ suffix-		varName := strings.TrimSuffix(strings.TrimPrefix(str, "%22__RUNTIME_BOOL_"), "__%22")-		if v, ok := tplData[varName].(bool); ok && v {-			return "true"+		// Trim the prefix and suffix+		pair := strings.TrimSuffix(strings.TrimPrefix(str, "%22__RUNTIME_"), "__%22")+		parts := strings.SplitN(pair, "_", 2)+		switch parts[0] {+		case "BOOL":+			if v, ok := tplData[parts[1]].(bool); ok && v {+				return "true"+			}+			return "false"+		case "STRING":+			if v, ok := tplData[parts[1]].(string); ok {+				if bs, err := json.Marshal(v); err == nil {+					return url.PathEscape(string(bs))

I actually wondered why we were using javascript escape/unescape and not encodeURIComponent/decodeURIComponent as they are ever so slightly different I think. I'm assuming that as long as we used the same encode/decode on both ends things would be fine. Is the golang you are using here the equivalent of JS escape?

banks

comment created time in 19 hours

PullRequestReviewEvent

push eventhashicorp/consul

John Cowen

commit sha 28e261300393c6bacc3323f7abfb531af69c8368

Add missing notice component

view details

push time in 20 hours

PR opened hashicorp/consul

Reviewers
ui: Upgrade the rest of the UI to use the new Notice component theme/ui

This changes all the instances of our lightweight CSS based notice component in the UI to use a Glimmer-template only component.

This also marks more of a departure from our approach of having all our CSS components split into reusable components being used and configured separately especially for our project. We've moved everything now into the notice folder altogether in one place.

+198 -144

0 comment

19 changed files

pr created time in 20 hours

push eventhashicorp/consul

John Cowen

commit sha 310c3bf4e504f515db02f400026cd5599d0d4cc2

ui: Upgrade the rest of the UI to use the new Notice component

view details

push time in 21 hours

create barnchhashicorp/consul

branch : ui/chore/notice-updates

created branch time in 21 hours

push eventhashicorp/consul

John Cowen

commit sha 948917c6b0833aa85ef92aef7c109461df2cd58f

ui: Intention Custom Resource Banners (#9018)

view details

push time in a day

delete branch hashicorp/consul

delete branch : ui/feature/custom-resource-banners

delete time in a day

PR merged hashicorp/consul

ui: Intention Custom Resource Banners theme/ui

This PR adds various banners to the intentions views when the intention are added via kubernetes.

Screenshot 2020-10-23 at 13 43 11

Screenshot 2020-10-23 at 13 43 19

Screenshot 2020-10-23 at 13 58 00

+587 -382

0 comment

27 changed files

johncowen

pr closed time in a day

PullRequestReviewEvent

push eventhashicorp/consul

Kenia

commit sha 05411303b432f07a07180dad17e879a9cf641991

ui: Update Topology metrics dashboard and configuration links (#9002) * Update Topology metrics dashboard and configuration links * Fixup tests * Remove Dashboard Link from settings page * Removing use of settings Dashboard links

view details

Kenia

commit sha 92abbbacc1b795a2056951ee837404c6d15a7ccd

ui: Prevent redirect to topology url and hide Topology tab if service has no services (#9008) * Prevent redirect to topology url and hide Topology tab if service has no proxies * Remove unused computed function from topology model * Fix up tests * Remove use of Exists computed function * Add tests for hiding topology tab

view details

Kenia

commit sha 2a8a80638a5584dee4e0eb831b2136a75021ae63

ui: Fix the pointer events to view the tooltips when hovering over the icons (#9014) * Fix the pointer events to view the tooltips when hovering over the icons * Update to use class instead of id

view details

hashicorp-ci

commit sha 74b8c024e8892fec743a0c66d1dcea16497071cd

auto-updated agent/uiserver/bindata_assetfs.go from commit 2a8a80638

view details

John Cowen

commit sha 7559f64d01055f77c50910656db52452075ed021

ui: Fixup CSS for create pages (#9019)

view details

hashicorp-ci

commit sha e236a58dbaec9540be955dc22b9a89a9f9f11768

auto-updated agent/uiserver/bindata_assetfs.go from commit 7559f64d0

view details

James Light

commit sha 5b1004641856f4ef52f81f80ca054b39ad92cf52

Update managed-deprecated.mdx (#9016) fix typo / spell checker replacing w/ wrong word

view details

Alvin Huang

commit sha 0d34e2939ff2a0a5daddff6d94551e0d8c52bea5

ci: add parallelism to envoy tests (#9005) add subtest output

view details

John Cowen

commit sha eedee07e7c6699ce2a3b156737f8cf9873e55d41

ui: Initial Intention Permission Integration and acceptance testing (#9003)

view details

John Cowen

commit sha f64eedfc46d3e240d1f07a425a4c05e1340594d8

Update IntentionsRepo and give it a managedByCRDs property

view details

John Cowen

commit sha 788e6114d9411a52d00e24e90b7ac3e69b9987b1

Get rid of the search initializer and move to a simple predicate

view details

John Cowen

commit sha 9b3e8b1b9293897cfef91c95a213a95b4123ca2c

Move all filtering/sorting/searching into a new glimmer component

view details

John Cowen

commit sha 81af4de0ddbd8b68f8c6ca4d18ba54b1f60672bd

Amend the warning skin for notices

view details

John Cowen

commit sha d23a1525b60d5cfdbbbfdc78a1179540403459cc

Fixup intention test to use a component pageobject structure

view details

John Cowen

commit sha 1de00ff906161bc50a8041e18e98e484acd4de8b

Add tests for CRD banners

view details

John Cowen

commit sha 77651d9e2edfe599fa639a737ea38ea06632447c

Make a warning only appear on create

view details

John Cowen

commit sha 3854678cef1d75d42b178e465a21c763eeb16639

Fix up intention blocking query tests

view details

John Cowen

commit sha 24057b24f60ab142805d54665d3b2b2bd7528d0d

Fix up per service intentions

view details

push time in 4 days

push eventhashicorp/consul

John Cowen

commit sha eedee07e7c6699ce2a3b156737f8cf9873e55d41

ui: Initial Intention Permission Integration and acceptance testing (#9003)

view details

push time in 4 days

delete branch hashicorp/consul

delete branch : ui/chore/permission-initial-testing

delete time in 4 days

PR merged hashicorp/consul

ui: Initial Intention Permission Integration and acceptance testing theme/ui

Generally we are pretty light on component integration testing and very heavy on app-wide acceptance testing, which is something we'd like to change. So this PR does various things:

  1. Starts constructing page objects using a noun.verb pattern, which means we can perform various verbs on the same selector which means we can use this in integration testing like:
{
  form: {
    PathType: {
      scope: 'input[name="pathtype"]',
      click: clickable()
      present: isPresent()
    }
  }
}
assert.ok(PermissionsForm.PathType.present)
PermissionsForm.PathType.click();
  1. We also started adding some acceptance test steps to be able to use a similarly formatted page objects

  2. We add some very basic integration and acceptance tests to hopefully ensure that it's easy to use the same page object for both types of tests and it reads/writes nicely.

+412 -93

0 comment

21 changed files

johncowen

pr closed time in 4 days

push eventhashicorp/consul

John Cowen

commit sha 7559f64d01055f77c50910656db52452075ed021

ui: Fixup CSS for create pages (#9019)

view details

push time in 4 days

delete branch hashicorp/consul

delete branch : ui/bugfix/create-layouts

delete time in 4 days

PR merged hashicorp/consul

ui: Fixup CSS for create pages theme/ui

Since we changed our approach of globally targeting pages with CSS we missed a couple of places where we needed to refer to both create and edit pages (previously both create and edit pages where targeted using edit)

Before:

Screenshot 2020-10-23 at 14 33 56

After:

Screenshot 2020-10-23 at 14 33 33

+12 -8

0 comment

4 changed files

johncowen

pr closed time in 4 days

PullRequestReviewEvent

Pull request review commenthashicorp/consul

ui: Update Topology metrics dashboard and configuration links

 Feature: dc / services / show: Show Service     And settings from yaml     ---     consul:urls:-      service: https://consul.io?service-name={{Service.Name}}&dc={{Datacenter}}+      service: https://example.com?service-name={{Service.Name}}&dc={{Datacenter}}     ---     When I visit the service page for yaml     ---       dc: dc1       service: service-0     ----    And I see href on the dashboardAnchor like "https://consul.io?service-name=service-0&dc=dc1"+    And I see href on the dashboardAnchor like "https://example.com?service-0-with-id&dc1"

Yeah something like:

And ui_config from yaml
---
dashboard_metrics_url:
  services: http://consul.io/
---

It would be great if we could use the same cookies thing we use so we can configure it during development aswell. Sounds like this is something we can do at a later date then?

kaxcode

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened hashicorp/consul

Reviewers
ui: Fixup CSS for create pages theme/ui

Since we changed our approach of globally targeting pages with CSS we missed a couple of places where we needed to refer to both create and edit pages (previously both create and edit pages where targeted using edit)

Before:

Screenshot 2020-10-23 at 14 33 56

After:

Screenshot 2020-10-23 at 14 33 33

+12 -8

0 comment

4 changed files

pr created time in 4 days

PullRequestReviewEvent

create barnchhashicorp/consul

branch : ui/bugfix/create-layouts

created branch time in 4 days

push eventhashicorp/consul

John Cowen

commit sha 335a601cb40f644d96ce82ca25d156564d5e93d6

Fix up intention blocking query tests

view details

push time in 4 days

PR opened hashicorp/consul

Reviewers
ui: Intention Custom Resource Banners theme/ui

This PR adds various banners to the intentions views when the intention are added via kubernetes.

Screenshot 2020-10-23 at 13 43 11

Screenshot 2020-10-23 at 13 43 19

Screenshot 2020-10-23 at 13 58 00

+554 -376

0 comment

23 changed files

pr created time in 4 days

push eventhashicorp/consul

John Cowen

commit sha dc2b2fb12b6d7afbbe315f3a9d10a75094d816f2

Make a warning only appear on create

view details

push time in 4 days

create barnchhashicorp/consul

branch : ui/feature/custom-resource-banners

created branch time in 4 days

Pull request review commenthashicorp/consul

UI metrics provider dc

      *      {      *        // label should be 3 chars or fewer as an abbreviation      *        label: "SR",+     *      *        // desc describes the stat in a tooltip      *        desc: "Success Rate - the percentage of all requests that were not 5xx status",+     *      *        // value is a string allowing the provider to format it and add      *        // units as appropriate. It should be as compact as possible.      *        value: "98%",      *      }      *    ]      *  }      */-    serviceRecentSummaryStats: function(serviceName, protocol, options) {+    serviceRecentSummaryStats: function(serviceDC, namespace, serviceName, protocol, options) {

I wonder if we should just pass through an object here (and in other places) instead of individual arguments? We choose arguments over objects in the UI quite a lot, but we are free to change that there whenever we like - here in the provider interface we aren't as free to do that.

I suppose its 'document the property names' vs 'document the order of the arguments' and very bikeshed-y but thought I'd ask in case you preferred the former now there are quite a few arguments?

banks

comment created time in 4 days

Pull request review commenthashicorp/consul

UI metrics provider dc

 export default class TopologyMetrics extends Component {   @tracked upView;   @tracked upLines = [];   @tracked hasMetricsProvider = false;+  @tracked noMetricsReason = null;    constructor(owner, args) {     super(owner, args);     this.hasMetricsProvider = !!this.cfg.get().metrics_provider;++    // Disable metrics fetching if we are not in the local DC since we don't+    // currently support that for all providers.+    //+    // TODO we can make the configurable even before we have a full solution for+    // multi-DC forwarding for Prometheus so providers that are global for all+    // DCs like an external managed APM can still load in all DCs.+    if (this.env.var('CONSUL_DATACENTER_LOCAL') != this.args.dc) {+      this.noMetricsReason = 'Unable to fetch metrics for a remote datacenter';+    }+    console.log(this.env.var('CONSUL_DATACENTER_LOCAL'), this.args.dc);

Looks a stray console.log was left in?

banks

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenthashicorp/consul

ui: Fix the pointer events to view the tooltips when hovering over the icons

   </div> {{/if}}   <div id="metrics-container">-    <div>+    <div id="metrics-header">

I know it doesn't necessarily matter right now, but I think we should avoid ids unless other methods are troublesome for some reason. It would be good to form a habit of reaching for classes (or anything but ids) over id's, and I'm pretty sure a class would be just as good here.

kaxcode

comment created time in 4 days

PullRequestReviewEvent

push eventhashicorp/consul

John Cowen

commit sha 45554e4e9c962c9e353b904dd5f33c768fcfa0a8

ui: Notice component (#9011) Add simple Notice template only glimmer component

view details

push time in 4 days

delete branch hashicorp/consul

delete branch : ui/feature/notice-component

delete time in 4 days

PR merged hashicorp/consul

ui: Notice component theme/ui

We discussed the ins and outs of this PR offline.

I've also added some CSS here to get the spacing/colors exactly like the new designs for the info notice. Notably, the background color for the info panel doesn't exist in our existing color scheme so I chose the closest one to it.

Screenshot 2020-10-22 at 18 33 29

+44 -6

0 comment

6 changed files

johncowen

pr closed time in 4 days

PR opened hashicorp/consul

Reviewers
ui: Notice component theme/ui

We discussed the ins and outs of this PR offline.

I've also added some CSS here to get the spacing/colors exactly like the new designs for the info notice. Notably, the background color for the info panel doesn't exist in our existing color scheme so I chose the closest one to it.

Screenshot 2020-10-22 at 18 33 29

+44 -6

0 comment

6 changed files

pr created time in 5 days

push eventhashicorp/consul

John Cowen

commit sha 46a253a76399a6b90a96a2f79cdfef18c64d1fb0

Move rules into the layout/skin properly

view details

push time in 5 days

push eventhashicorp/consul

John Cowen

commit sha 933bd523b4de10b0e8aa28c01d78cd11a778c017

Change to use anonymous component and tweak styling for notices

view details

push time in 5 days

create barnchhashicorp/consul

branch : ui/feature/notice-component

created branch time in 5 days

Pull request review commenthashicorp/consul

ui: Prevent redirect to topology url and hide Topology tab if service has no services

 export default Model.extend({   Downstreams: attr(),   Protocol: attr(),   meta: attr(),-  Exists: computed(function() {-    return true;-  }),

Sorry ignore!

kaxcode

comment created time in 5 days

PullRequestReviewEvent

Pull request review commenthashicorp/consul

ui: Prevent redirect to topology url and hide Topology tab if service has no services

 export default Model.extend({   Downstreams: attr(),   Protocol: attr(),   meta: attr(),-  Exists: computed(function() {-    return true;-  }),

Do you still need this you refer to it further down?

kaxcode

comment created time in 5 days

PullRequestReviewEvent

Pull request review commenthashicorp/consul

ui: Update Topology metrics dashboard and configuration links

 Feature: dc / services / show: Show Service     And settings from yaml     ---     consul:urls:-      service: https://consul.io?service-name={{Service.Name}}&dc={{Datacenter}}+      service: https://example.com?service-name={{Service.Name}}&dc={{Datacenter}}     ---     When I visit the service page for yaml     ---       dc: dc1       service: service-0     ----    And I see href on the dashboardAnchor like "https://consul.io?service-name=service-0&dc=dc1"+    And I see href on the dashboardAnchor like "https://example.com?service-0-with-id&dc1"

Do you want to challenge trying to make the ui-config configurable/mockable during testing?

Whichever, the setup And settings from yaml chunk here isn't required anymore as we no longer pull this from localStorage/settings.

Actually I just noticed that this PR doesn't include taking the input field out of the settings page, we should probably include that here also.

Lemme know what you want to do.

kaxcode

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

PR opened hashicorp/consul

Reviewers
ui: Initial Intention Permission Integration and acceptance testing theme/ui

Generally we are pretty light on component integration testing and very heavy on app-wide acceptance testing, which is something we'd like to change. So this PR does various things:

  1. Starts constructing page objects using a noun.verb pattern, which means we can perform various verbs on the same selector which means we can use this in integration testing like:
{
  form: {
    PathType: {
      scope: 'input[name="pathtype"]',
      click: clickable()
      present: isPresent()
    }
  }
}
assert.ok(PermissionsForm.PathType.present)
PermissionsForm.PathType.click();
  1. We also started adding some acceptance test steps to be able to use a similarly formatted page objects

  2. We add some very basic integration and acceptance tests to hopefully ensure that it's easy to use the same page object for both types of tests and it reads/writes nicely.

+412 -93

0 comment

21 changed files

pr created time in 6 days

push eventhashicorp/consul

John Cowen

commit sha 02978487e43cf72ab865f0d9428c2c4a78aa1f95

Lint

view details

push time in 6 days

Pull request review commenthashicorp/consul

ui: Update Topology metrics dashboard and configuration links

 export default Route.extend({       items: this.data.source(         uri => uri`/${nspace}/${dc}/service-instances/for-service/${params.name}`       ),-      urls: this.settings.findBySlug('urls'),+      urls: this.config.get().dashboard_url_template,

I think this is fine for now as opposed to returning a promise, how come you changed you mind about this?

kaxcode

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

create barnchhashicorp/consul

branch : ui/chore/permission-initial-testing

created branch time in 6 days

Pull request review commenthashicorp/consul

UI metrics provider dc

 export default RepositoryService.extend({       this.error = new Error(`metrics provider not initialized: ${e}`);       // Show the user the error once for debugging their provider outside UI       // Dev.-      console.error(this.error); // eslint-disable-line no-console+      console.error(this.error);

I think you are still working on this, but I noticed you dropped an eslint ignore here, guessing it was by accident?

banks

comment created time in 6 days

PullRequestReviewEvent

Pull request review commenthashicorp/consul

UI metrics provider dc

 export default RepositoryService.extend({       this.error = new Error(`metrics provider not initialized: ${e}`);       // Show the user the error once for debugging their provider outside UI       // Dev.-      console.error(this.error); // eslint-disable-line no-console+      console.error(this.error);

I think you are still working on this, but I noticed you dropped an eslint ignore here, guessing it was by accident?

banks

comment created time in 6 days

PullRequestReviewEvent

push eventhashicorp/consul

John Cowen

commit sha 6589cbbd0dc5058c5d2702616d1bc12ce2a531ad

ui: Move to Workspaced Structure (#8994) * ui: Add the most basic workspace root in /ui * We already have a LICENSE file in the repository root * Change directory path in build scripts ui-v2 -> ui * Make yarn install flags configurable from elsewhere * Minimal workspace root makefile * Call the new docker specific target * Update yarn in the docker build image * Reconfigure the netlify target and move to the higher makefile * Move ui-v2 -> ui/packages/consul-ui * Change repo root to refleect new folder structure * Temporarily don't hoist consul-api-double * Fixup CI configuration * Fixup lint errors * Fixup Netlify target

view details

push time in 6 days

delete branch hashicorp/consul

delete branch : ui/chore/ui-workspace-root

delete time in 6 days

PR merged hashicorp/consul

ui: Move to Workspaced Structure theme/packaging theme/ui type/ci

This PR moves the ui back to the ui folder and additionally restructures our UI project under that folder into a workspace'd structure with the main project now at /ui/packages/consul-ui

Additional notes:

  1. Slight change included for the build scripts to reflect the new structure (I updated yarn in the build docker file while I was there)
  2. I fixed up a couple of linting errors from https://github.com/hashicorp/consul/pull/8989 that I figured would be easiest to do here.
  3. There are probably more small amends we could make here, but these can be done as we move forwards with this, I figured it was best to get this in first and iterate from there.
+13655 -85

0 comment

1704 changed files

johncowen

pr closed time in 6 days

PullRequestReviewEvent

PR closed hashicorp/consul

Reviewers
ui: Metrics provider - Throw generated xhr errors theme/ui

This PR replaces https://github.com/hashicorp/consul/pull/8932 and does a lot less.

Previously the metrics provider would swallow any errors and return an empty array for any errors thrown whilst retrieving data from the metrics provider.

This PR throws any HTTP errors back to the UI so we can deal with them there. This does mean that if 1 single error is thrown whilst retrieving data, then the entire retrieval will fail.

We also js formatted the provider, so it might be easier to view the changes there in df1f7ea

+352 -369

1 comment

8 changed files

johncowen

pr closed time in 7 days

pull request commenthashicorp/consul

ui: Metrics provider - Throw generated xhr errors

Closing this for the moment, we'll be coming back to re-look at this soon

johncowen

comment created time in 7 days

push eventhashicorp/consul

John Cowen

commit sha 38ee410d02864eeb8ab5adbc7ce84dd801559220

Fixup Netlify target

view details

push time in 7 days

more