push eventdenoland/deno
commit sha 92ceb8e3237c6a6e07c18bffdebf97b5ecaf8a56
Add github action for cargo publish (#3724)
push time in 8 minutes
PR merged denoland/deno
This makes two changes:
- Adds a new CI build which will do a dry-run of the publish procedure, checking that we can package the crates. This is to prevent issues like https://github.com/denoland/deno/issues/3712 from popping up again.
- Adjusts the publish-on-tag action, so that it's only done by a single worker.
pr closed time in 8 minutes
Pull request review commentdenoland/deno
fn shared_getter( // Lazily initialize the persistent external ArrayBuffer. if deno_isolate.shared_ab.is_empty() {- let data_ptr = deno_isolate.shared.bytes.as_ptr();- let data_len = deno_isolate.shared.bytes.len();- let ab = unsafe {- v8::SharedArrayBuffer::new_DEPRECATED(- scope,- data_ptr as *mut c_void,- data_len,- )- };+ let ab = v8::SharedArrayBuffer::new_with_backing_store(+ scope,+ deno_isolate.shared.get_backing_store(),+ );
👍
comment created time in an hour
issue closeddenoland/deno
crash during 'cargo publish' for cli (aka "deno" crate)
The error comes from here: https://github.com/denoland/deno/blob/v0.30.0/deno_typescript/lib.rs#L271
No idea why. Here's the log
[...]
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/streams/readable-stream-byob-reader.ts
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/repl.ts
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/format_error.ts
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/location.ts
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1165:5
stack backtrace:
0: backtrace::backtrace::libunwind::trace
at /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
1: backtrace::backtrace::trace_unsynchronized
at /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
2: std::sys_common::backtrace::_print_fmt
at src/libstd/sys_common/backtrace.rs:77
3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
at src/libstd/sys_common/backtrace.rs:61
4: core::fmt::write
at src/libcore/fmt/mod.rs:1028
5: std::io::Write::write_fmt
at src/libstd/io/mod.rs:1412
6: std::sys_common::backtrace::_print
at src/libstd/sys_common/backtrace.rs:65
7: std::sys_common::backtrace::print
at src/libstd/sys_common/backtrace.rs:50
8: std::panicking::default_hook::{{closure}}
at src/libstd/panicking.rs:188
9: std::panicking::default_hook
at src/libstd/panicking.rs:205
10: std::panicking::rust_panic_with_hook
at src/libstd/panicking.rs:464
11: std::panicking::continue_panic_fmt
at src/libstd/panicking.rs:373
12: rust_begin_unwind
at src/libstd/panicking.rs:302
13: core::panicking::panic_fmt
at src/libcore/panicking.rs:139
14: core::result::unwrap_failed
at src/libcore/result.rs:1165
15: core::result::Result<T,E>::unwrap
at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/result.rs:933
16: deno_typescript::read_file
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:256
17: deno_typescript::get_asset
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:271
18: deno_typescript::get_asset2
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:246
19: deno_typescript::ops::read_file
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/ops.rs:48
20: deno_typescript::ops::json_op::{{closure}}::{{closure}}
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/ops.rs:23
21: core::result::Result<T,E>::and_then
at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/result.rs:691
22: deno_typescript::ops::json_op::{{closure}}
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/ops.rs:21
23: deno_typescript::compiler_op::{{closure}}
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:62
24: <alloc::boxed::Box<F> as core::ops::function::Fn<A>>::call
at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/liballoc/boxed.rs:956
25: deno_core::ops::OpRegistry::call
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_core-0.30.0/ops.rs:95
26: deno_core::isolate::Isolate::dispatch_op
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_core-0.30.0/isolate.rs:496
27: deno_core::bindings::send
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_core-0.30.0/bindings.rs:440
28: core::ops::function::Fn::call
at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/ops/function.rs:69
29: rusty_v8::function::<impl rusty_v8::support::MapFnFrom<F> for extern "C" fn(*const rusty_v8::function::FunctionCallbackInfo)>::mapping::{{closure}}
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/src/function.rs:240
30: <extern "C" fn(A0) .> R as rusty_v8::support::CFnFrom<F>>::mapping::c_fn
at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/src/support.rs:398
31: Call
at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/api/api-arguments-inl.h:158
32: HandleApiCallHelper<false>
at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/builtins/builtins-api.cc:111
33: Builtin_Impl_HandleApiCall
at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/builtins/builtins-api.cc:141
34: Builtin_HandleApiCall
at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/builtins/builtins-api.cc:129
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
fatal runtime error: failed to initiate panic, error 5
closed time in an hour
ry
issue commentdenoland/deno
crash during 'cargo publish' for cli (aka "deno" crate)
Fixed in https://github.com/denoland/deno/commit/fa7f34eb8cec07f4c68ca4e9c46a983bc3e2308f
comment created time in an hour
push eventry/deno
commit sha 7966bf14c062a05b1606a62c996890571454ecc8
refactor: split worker and worker host logic (#3722) * split ops/worker.rs into ops/worker_host.rs and ops/web_worker.rs * refactor js/workers.ts and factor out js/worker_main.ts - entry point for WebWorker runtime * BREAKING CHANGE: remove support for blob: URL in Worker * BREAKING CHANGE: remove Deno namespace support and noDenoNamespace option in Worker constructor * introduce WebWorker struct which is a stripped down version of cli::Worker
commit sha 21cc9cb7a76d805fbb7b53583448aa101c294e71
Implemented alternative open mode in files (#3119) Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
commit sha 0cd605515c99458fa80cd4a1a3906f3db37a86ca
refactor: don't create new runtime for fs ops (#3730)
commit sha 5e2fd183ff1fe240ddbd864dbf1e6a0941fb4582
refactor: Rename JS entry functions (#3732)
commit sha 108294deeb0897199ebdf0af203ff8ddd457b1ef
change copyrights from 2019 to 2020 (#3733)
commit sha 159ac525ae13816fec76395b0a6e7b1ab55dee1a
Update manual.md (#3734) Updated the `Deno.bundle` description to actually use the `bundle`-function.
commit sha 229eb292f83dedbc32dc24f912841caf79a53e9c
Revert "don't include assets in binary (#3661)" Ref #3712 This reverts commit 32cbcfe4e9943a0318c497188e045d23c5f6703a.
commit sha ecd1d3abb0cae9c7cbc1330cbaa035a5786e94d7
refactor: split cli::Worker (#3735) * cli::Worker is base struct to create specialized workers * add MainWorker * add CompilerWorker * refactor WebWorker to use Worker
commit sha 9de8178c9b9bc21cc880ea81f163118408cc6c46
feat: add AsyncUnref ops (#3721) This is in order to support features like signal handlers, which shouldn't prevent the program from exiting.
commit sha 7fd50065a7d8a4c6ed1b1090703a7baaabdbd6aa
v0.30.1 This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.
commit sha fa7f34eb8cec07f4c68ca4e9c46a983bc3e2308f
Revert "Create an old program to be used in snapshot. (#3644)" Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce a revised version of this patch later once "cargo package" is working and tested. This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.
commit sha 7054621f4c9da21f13b94bf788fb879abacaa9b9
Add github action for cargo publish
push time in an hour
push eventdenoland/deno
commit sha fa7f34eb8cec07f4c68ca4e9c46a983bc3e2308f
Revert "Create an old program to be used in snapshot. (#3644)" Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce a revised version of this patch later once "cargo package" is working and tested. This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.
push time in 2 hours
PR merged denoland/deno
Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce a revised version of this patch later once "cargo package" is working and tested.
This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.
cc @kitsonk
pr closed time in 2 hours
issue commentdenoland/rusty_v8
unknown argument: '-gno-inline-line-tables'
@hayd check out https://github.com/denoland/chromium_build/commit/65d79729a
Essentially you'll want to revert that commit (or better, make it conditional), and update the build submodule in rusty_v8.
comment created time in 2 hours
Pull request review commentdenoland/deno
Revert "Create an old program to be used in snapshot. (#3644)"
pub fn get_asset(name: &str) -> Option<&'static str> { } match name { "bundle_loader.js" => Some(include_str!("bundle_loader.js")),- "lib.deno_runtime.d.ts" => {- Some(include_str!("../cli/js/lib.deno_runtime.d.ts"))
Note: this is the reason for the revert - this breaks "cargo package".
comment created time in 2 hours
issue commentdenoland/rusty_v8
unknown argument: '-gno-inline-line-tables'
@hayd I'm not sure what you mean, but deno_src is created here: https://github.com/denoland/deno/blob/7fd50065a7d8a4c6ed1b1090703a7baaabdbd6aa/.github/workflows/ci.yml#L43
comment created time in 2 hours
PR opened denoland/deno
Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce this a revised version of this patch later once "cargo package" is working and tested.
This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.
<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->
pr created time in 2 hours
PR closed denoland/deno
cc @kitsonk
pr closed time in 2 hours
pull request commentdenoland/deno
deno_typescript should not use assets outside of crate
This isn't working. I'm going to revert the oldProgram patch. We can re-introduce it later after fixing "cargo package"
comment created time in 2 hours
PR opened denoland/deno
pr created time in 3 hours
push eventdenoland/deno
commit sha 7fd50065a7d8a4c6ed1b1090703a7baaabdbd6aa
v0.30.1 This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.
push time in 4 hours
PR merged denoland/deno
This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.
Ref #3712
pr closed time in 4 hours
pull request commentdenoland/deno
@omarhoro have a look at https://github.com/denoland/deno/issues/2473
comment created time in 4 hours
issue openeddenoland/rusty_v8
`int` should not be part of the public interface
https://docs.rs/rusty_v8/0.1.1/rusty_v8/type.int.html
created time in 4 hours
PR opened denoland/deno
This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.
<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->
pr created time in 4 hours
push eventdenoland/deno_website2
commit sha 6bff71b16adce18282b948db5841544cb57ad235
fix example new line char (#203)
push time in 5 hours
push eventdenoland/deno_website2
commit sha 081af6efa1ef81335fc6359bdfe33108a74b126a
updates server example (#202)
push time in 5 hours
PR merged denoland/deno_website2
updates hello world server example by removing unnecessary text encoder
pr closed time in 5 hours
push eventdenoland/deno
commit sha 9de8178c9b9bc21cc880ea81f163118408cc6c46
feat: add AsyncUnref ops (#3721) This is in order to support features like signal handlers, which shouldn't prevent the program from exiting.
push time in 5 hours
PR merged denoland/deno
This PR is the variation of #3715. This uses AsyncOptional enum variant instead of adding the flags.
pr closed time in 5 hours
push eventkt3k/deno
commit sha 71f28b81629865b1a709d3b63af3fe1bbefe5dd7
comment
push time in 6 hours
push eventkt3k/deno
commit sha dacba75ecb945c8e1cf7ab3f6c91eb759eb93c72
fix comment style
push time in 6 hours
push eventdenoland/deno_website2
commit sha 0e9ec249737a05735354aa5d76edbb667f771287
format code (#201)
push time in 6 hours
push eventdenoland/deno_website2
commit sha 2edadf516f281be428dadfc2492acaa43ed0dcca
Sort benchmark popover data (#200) Co-authored-by: Ry Dahl <ry@tinyclouds.org>
push time in 6 hours
PR merged denoland/deno_website2
Added a .sort to alphabetize the data in the popovers
pr closed time in 6 hours
push eventdenoland/deno
commit sha 229eb292f83dedbc32dc24f912841caf79a53e9c
Revert "don't include assets in binary (#3661)" Ref #3712 This reverts commit 32cbcfe4e9943a0318c497188e045d23c5f6703a.
push time in 6 hours
PR merged denoland/deno
Maybe solves https://github.com/denoland/deno/issues/3712
pr closed time in 6 hours
push eventjmarthernandez/deno_website2
commit sha 392e3af65b233181384c71d72823a3aea4656ec0
sort by last data point
push time in 6 hours
push eventdenoland/deno
commit sha 159ac525ae13816fec76395b0a6e7b1ab55dee1a
Update manual.md (#3734) Updated the `Deno.bundle` description to actually use the `bundle`-function.
push time in 6 hours
PR merged denoland/deno
Updated the Deno.bundle description to actually use the bundle-function.
<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->
pr closed time in 6 hours
Pull request review commentdenoland/deno
impl Future for Worker { } } }+#[derive(Clone)]+pub struct MainWorker(Worker);
I also think it would be helpful to have some triple slash comments here explaining this is the Isolate one gets by default when they start a script. It does not include TS compiler, but does include "Deno" global, etc.
comment created time in 6 hours
Pull request review commentdenoland/deno
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.-use crate::fmt_errors::JSError; use crate::ops; use crate::state::ThreadSafeState;+use crate::worker::Worker; use crate::worker::WorkerChannels;-use crate::worker::WorkerReceiver; use deno_core;-use deno_core::Buf; use deno_core::ErrBox;-use deno_core::ModuleSpecifier; use deno_core::StartupData; use futures::future::FutureExt;-use futures::future::TryFutureExt;-use futures::sink::SinkExt;-use futures::task::AtomicWaker;-use std::env; use std::future::Future;+use std::ops::Deref;+use std::ops::DerefMut; use std::pin::Pin;-use std::sync::Arc;-use std::sync::Mutex; use std::task::Context; use std::task::Poll;-use tokio::sync::Mutex as AsyncMutex;-use url::Url; #[derive(Clone)]-pub struct WebWorker {- pub name: String,- pub isolate: Arc<AsyncMutex<Box<deno_core::EsIsolate>>>,- pub state: ThreadSafeState,- external_channels: Arc<Mutex<WorkerChannels>>,-}+pub struct WebWorker(Worker);
I think "WebWorker" and "Worker" are a bit confusing. A triple slash comment here could illuminate the situation.
EG
/// WebWorker is wrapper around Worker. Worker is CLI's term of an Isolate.
/// There are several types of workers: Main, Compiler, and WebWorker.
comment created time in 7 hours
push eventdenoland/deno
commit sha 108294deeb0897199ebdf0af203ff8ddd457b1ef
change copyrights from 2019 to 2020 (#3733)
push time in 7 hours
PR merged denoland/deno
This PR changes some copyright headers from 2019 to 2020.
pr closed time in 7 hours
issue commentdenoland/rusty_v8
inspector: human-readable StringBuffer, StringView
Agree - we should try to remove these derive(Debug) things a much as possible - it's a lot of extra code for little benefit. For example, it doesn't seem useful to have it on UniquePtr. It probably makes sense to have a custom impl Debug for StringBuffer tho.
comment created time in 7 hours
push eventdenoland/rusty_v8
commit sha 791cbc627ae1ddf15c3a854ad7476ac5b27ab476
Add docs about scopes to lib.rs
commit sha 3c1c52fb33bf1344cbb3dc626a74d34e41183311
v0.1.1
push time in 7 hours
PR merged denoland/rusty_v8
closes https://github.com/denoland/rusty_v8/issues/230
pr closed time in 7 hours
issue closeddenoland/rusty_v8
Add design documentation for scopes
Although the end is in sight, the design is still a bit in flux.
The general idea is that the various scope classes mediate access to the v8 Isolate and the various items on its heap (Local/Global handles, return/escape slots, etc.). At any point in time there exists only one scope object that is directly accessible, which guarantees that all interactions with the Isolate are safe.
A Scope as such is not a trait (there is currently an internal ScopeDefinition trait but that's only there to make implementation easier).
Rather, there are a number of traits that are implemented for the scopes they're applicable to, you've probably seen most of them already. The InIsolate which gives access to &mut Isolate is implemented for all scopes, ToLocal (I might rename that) is implemented for all Scopes in which new Local handles can be created and it sets the appropriate lifetime on them. InContext means that a context has been entered (I'll make sure they have a get_context() method), etc.
Furthermore, many callbacks will receive receive an appropriate Scope object as their first argument, which 'encodes' the the state the isolate is in when the callback is called. E.g. a FunctionCallbackScope implements InIsolate + InContext + (there is an active context) and ToLocal (it acts as a handlescope). HostImportModuleDynamicallyScope would also implement InIsolate + InContext plus EscapeLocal (it doesn't act like a HandleScope, but it lets you safely escape one MaybeLocal<Module> which is returned to the caller.
In a nutshell, that's it. Open TODOs are:
Add these automatic scopes to more callbacks (in progress) and get rid of the necessity to import the MapFnTo trait. Fully integrate TryCatch blocks into the scope system (currently a TryCatch works like a scope internally but it's not integrated). Add methods to some on some of the scopes like get_context() for ContextScope. Rename/reorganize/document.
closed time in 7 hours
piscisaureus
push eventry/rusty_v8
commit sha 5ff162eea77256bae94bba844c043afb64093679
Add docs about scopes to lib.rs
commit sha b3a5bc03913cd78162e5b1f297c4ac9c0ffef653
v0.1.1
push time in 7 hours
Pull request review commentdenoland/deno
[WIP] workers: new entry point for worker
fn main() { let c = PathBuf::from(env::var_os("CARGO_MANIFEST_DIR").unwrap()); let o = PathBuf::from(env::var_os("OUT_DIR").unwrap()); + let root_names = vec![c.join("js/worker_globals.ts")];+ let bundle = o.join("WORKER_SNAPSHOT.js");+ let state = deno_typescript::compile_bundle(&bundle, root_names).unwrap();+ assert!(bundle.exists());+ deno_typescript::mksnapshot_bundle(&bundle, state).unwrap();
How much bigger does it make the exe? And how much of a slow down to the build time?
comment created time in 8 hours
pull request commentdenoland/deno_website2
The issue is asking for something a bit different. I want the popup sorted by rank in the benchmark, not alphabetically.
comment created time in 8 hours
pull request commentdenoland/deno
Maybe we can also create a general Deno.unref(promiseId) that is a binding reaching into pending_ops and toggle that bool value.
I think that would be ideal
comment created time in 21 hours
push eventdenoland/deno_website2
commit sha 167675722155a7d73cd7fef73859eb734792c9d4
Add take-five (#197)
push time in 21 hours
PR merged denoland/deno_website2
Add take-five to list of third-party libs
pr closed time in 21 hours
pull request commentdenoland/rusty_v8
Make Locker also a Scope (#229)
It would be helpful if you wrote out the design in english in src/lib.rs - I guess Isolate, Locker, Context, HandleScope, EscapableHandleScope all implement a trait Scope? It would be helpful.
comment created time in a day
pull request commentdenoland/deno
Fix "cargo publish deno" by reverting asset change
Were you able to verify at all that this fixes the issue?
I really can't test it without a new release... or at least I haven't been able to figure out a way.
comment created time in a day
issue commentdenoland/deno
Writing native plugin in pure C
I don't think writing a plugin in C should be a first order goal of Deno. It likely will complicate the implementation - users can always bind to C libraries from Rust. That said, I think we should strive for simplicity in the plugin interface - and considering the C user it a good way of doing that...
comment created time in a day
Pull request review commentdenoland/deno
pub type Buf = Box<[u8]>; pub type OpAsyncFuture<E> = Pin<Box<dyn Future<Output = Result<Buf, E>> + Send>>; -pub(crate) type PendingOpFuture =+pub(crate) type PendingOpInnerFuture = Pin<Box<dyn Future<Output = Result<(OpId, Buf), CoreError>> + Send>>; +pub(crate) struct PendingOp(pub PendingOpInnerFuture, pub bool);++impl Future for PendingOp {+ type Output = Result<(OpId, Buf), CoreError>;+ fn poll(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {+ self.as_mut().0.as_mut().poll(cx)+ }+}
Is this really necessary? Seems odd.
comment created time in a day
Pull request review commentdenoland/deno
pub type Buf = Box<[u8]>; pub type OpAsyncFuture<E> = Pin<Box<dyn Future<Output = Result<Buf, E>> + Send>>; -pub(crate) type PendingOpFuture =+pub(crate) type PendingOpInnerFuture = Pin<Box<dyn Future<Output = Result<(OpId, Buf), CoreError>> + Send>>; +pub(crate) struct PendingOp(pub PendingOpInnerFuture, pub bool);++impl Future for PendingOp {+ type Output = Result<(OpId, Buf), CoreError>;+ fn poll(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {+ self.as_mut().0.as_mut().poll(cx)+ }+}++pub(crate) type PendingOpFuture = Pin<Box<PendingOp>>;+ pub type OpResult<E> = Result<Op<E>, E>; pub enum Op<E> { Sync(Buf), Async(OpAsyncFuture<E>),+ // AsyncOptional is the variation of Async, which+ // doesn't block the program exiting.+ AsyncOptional(OpAsyncFuture<E>),
Use triple slash comments here
comment created time in a day
PR opened denoland/deno
<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->
pr created time in a day
pull request commentdenoland/deno
Fix "cargo publish deno" by reverting asset change
I cannot add a test for this until we publish a new version of deno_typescript - since the currently published version contains failing code.
comment created time in a day
push eventry/deno
commit sha 4a5c0af5932602a3e86aa620de33015903b5f54a
Revert "don't include assets in binary (#3661)" Fixes #3712 This reverts commit 32cbcfe4e9943a0318c497188e045d23c5f6703a.
push time in a day
push eventry/deno
commit sha f7f19be56045a6d9ab43b4d2c3ae19363e1e986f
Revert "don't include assets in binary (#3661)" Fixes #3712 This reverts commit 32cbcfe4e9943a0318c497188e045d23c5f6703a.
push time in a day
push eventdenoland/deno_website2
commit sha 5de23c83a53b07b482270f592fc0fb344ab185c2
Case insensitive filter in RegistryIndex (#199)
push time in a day
PR merged denoland/deno_website2
Case insensitive filter in RegistryIndex
pr closed time in a day
PR opened denoland/deno
<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->
pr created time in a day
issue commentdenoland/deno
crash during 'cargo publish' for cli (aka "deno" crate)
I believe this was caused by 32cbcfe4e9943a0318c497188e045d23c5f6703a
comment created time in a day
Pull request review commentdenoland/deno
feat: plugin resource table access
pub fn op_test_async(data: &[u8], zero_copy: Option<PinnedBuf>) -> CoreOp { Op::Async(fut.boxed()) }++struct TestResource {+ pub name: String,+}++impl Drop for TestResource {+ fn drop(&mut self) {+ println!("Dropped resource: {}", self.name)+ }+}++impl Resource for TestResource {}++pub fn op_create_resource(+ state: &PluginState,+ data: &[u8],+ _zero_copy: Option<PinnedBuf>,+) -> CoreOp {+ let name = std::str::from_utf8(&data[..]).unwrap().to_string();+ let mut table = state.lock_resource_table();+ let resource = TestResource { name };+ let rid = table.add("testResource", Box::new(resource));+ Op::Sync(Box::new(rid.to_be_bytes()))+}
Creating resources is certainly a desirable thing to be able to do, but I'm bothered that internal ops access the resource table differently than plugins...
comment created time in a day
PR closed denoland/deno
Motivation
As described in #3694, it's necessary to end the program even when certain types of async ops are remaining in pending_ops list. The example of such op is op_poll_signal in #3610 (which not yet landed)
Solution
This PR enhances deno_core::Op::Async type. Now Op::Async has the flag blocks_exit along with its main future. The flag is used when checking the result of poll method of deno_core::Isolate and if the flag is false (= the op is optional), those ops are filtered out in calculation of Poll result, which means the program can exit with those optional ops still remaining.
closes #3694
pr closed time in a day
pull request commentdenoland/deno
closed in favor of https://github.com/denoland/deno/pull/3721
comment created time in a day
Pull request review commentdenoland/deno
pub type AsyncJsonOp = pub enum JsonOp { Sync(Value), Async(AsyncJsonOp),+ // AsyncOptional is the variation of Async, which+ // doesn't block the program exiting.+ AsyncOptional(AsyncJsonOp),
"Optional" isn't very descriptive. Maybe we could call it something like AsyncNoBlock ?
comment created time in a day
push eventdenoland/deno_website2
commit sha c83cb433f71654c344ffa0f5c001ca975e23ea87
Remove autoFocus for search (#198)
push time in a day
pull request commentdenoland/deno_website2
feat: Add /api/versions endpoint to worker that returns recent Deno versions
Having the latest version on the home page might be nice... but it also seems like an unnecessary extra request. shrug
comment created time in a day
push eventdenoland/deno_website2
commit sha f10aa664b4383f3841952f2eb294c0d14f287f47
Change registry menu to horizontal (#195)
push time in a day
PR merged denoland/deno_website2
This is the PR1 to change the registry menu to Horizontal, Once merged I will PR the case sensitive issue. Thanks
pr closed time in a day
push eventafinch7/deno
commit sha 0a78bfb836f520d3709a32c8a978d08d33198d83
Add Deno.symbols and move internal fields for test (#3693)
commit sha d8ad81d3fb5b4b9502ea021edfc99201538553e6
Upgrade to rusty_v8 v0.1.0 (#3691)
commit sha fe5662058e0c7767e7b2724451f9d5a3f133ffbf
feat: support individual async handler for each op (#3690)
commit sha ad6635fab50c523f5de92660956aa384ca76415d
Fix warnings on windows build (#3697)
commit sha d776ca8f2e02dea210b50b28a4e4c20f31eed1f6
fix deno_core_http_bench (#3698)
commit sha aedf8721cf7f696326bbdcb23ea6a464c55f081c
Upgrade crate deps (#3699) Remove unused tokio-executor dep
commit sha 35eb79610f4b451af1d4a9c286fd63875d28bca5
Fix compile and bundle api types (#3703)
commit sha d7203092039d3c46ca8480ff8eecf612deb2b2f6
Auto cargo-publish on tags (#3704) fix tools/cargo_publish.py
commit sha 5fa056e53be6d17ab746629ea0eaa89fe817141b
workers: minimal error handling and async module loading (#3665)
commit sha fc077cd315f3d2ea508f2aac39bc65d4ac6a5747
std/http: allow response body to be string (#3705)
commit sha 59c674fed5f72eac1c046ebb4cc0a37c836665e3
Mark various APIs in window.Deno as unstable (#3701)
commit sha 020898762fa081113608504ab5012b2b27c70668
Debug strace issue (#3706)
commit sha b2f01dcb50c68da2cab28b6bd64f4033e4ccf10e
v0.30.0
commit sha 4f1fa82d1d0458170039d4809c3879993659e560
std(yaml): correct sortKeys type (#3708)
commit sha 34b99fec8edcff7d3b667f273afea69df15e4d5e
rename dial to connect and dialTLS to connectTLS (#3710)
commit sha 23e67eb5153bd26dbae471b27dc6a21a6d283b0b
stabilize net Addr (#3709) Co-authored-by: xiaoxintang <15707971810@163.com>
commit sha 60b53fd6b6dc2af83a64c332b9f3a1926f43d631
Use globalThis to reference global scope (#3719) Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
commit sha 7f80f9db3f4c3b064b230adfec7ff958fc195da6
refactor: Improve path handling in permission checks (#3714)
commit sha e83658138bff3605bd37c2b4ae4703081d884729
Fix bug in strace parser (#3720) Co-authored-by: @kt3k
commit sha 8009834df4be9fd2e9b9453835906b6d3448f4a5
Merge branch 'master' into plugin_resources
push time in a day
push eventdenoland/rusty_v8
commit sha 6efb395fdc7049a8b8fd1c7db53bbeb57f4130af
Add Object::define_own_property() (#228) This commit introduces the NONE, READ_ONLY, DONT_ENUM and DONT_DELETE property attributes.
push time in a day
PR merged denoland/rusty_v8
Also Template::set_with_attr() and the NONE, READ_ONLY, DONT_ENUM and DONT_DELETE
property attributes.
pr closed time in a day
Pull request review commentdenoland/rusty_v8
Add Object::define_own_property()
+#[repr(C)]Maybe rename this to src/property_attribute ?
comment created time in a day
Pull request review commentdenoland/rusty_v8
Add Object::define_own_property()
impl Object { unsafe { v8__Object__CreateDataProperty(self, &*context, &*key, &*value) } } + /// Implements DefineOwnProperty.+ ///+ /// In general, CreateDataProperty will be faster, however, does not allow
We have just been copying docstrings directly, so I wouldn't worry about it.
In the future we hope to automate this somehow - maybe with some sort of smart switch/replace? But I think just having some docs is useful.
comment created time in a day