profile
viewpoint

ibmruntimes/v8ppc 90

Port of Google V8 javascript engine to PowerPC®

ibmruntimes/node 70

This repository hosts the ports of Node.js for IBM platforms not yet upstreamed to the community (i.e. z/OS port). For community support for Linux On Z, Linux on P or AIX, please visit https://github.com/nodejs/help. Visit http://ibm.biz/nodejs-zos-support for z/OS support content, including how open PMRs and buy IBM Service and Support.

ibmruntimes/v8z 40

Port of Google V8 JavaScript engine to z/OS. The Linux on Z port is maintained in the community: https://chromium.googlesource.com/v8/v8.git

nodejs/core-validate-commit 36

Validate commit messages for Node.js core

ibmruntimes/chcp 5

This library provides native bindings for Windows APIs

gireeshpunathil/report 4

diagnostic report lab material

richardlau/build 1

Better build and test infra for Node.

richardlau/core-validate-commit 1

Validate commit messages for Node.js core

richardlau/GYP 1

Generate You Projects

richardlau/llhttp 1

Port of http_parser to llparse

issue closednodejs/node-gyp

Node-gyp error while installing python binding related repo

I was trying to install from that repo It's calling pytorch(fastai)/pythob models from nodejs

  • Node Version: v12.16.1 and 6.13.4
  • Platform: Linux pardus 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2+deb10u2 (2019-11-11) x86_64 GNU/Linux -->
  • Compiler: gcc version 8.3.0 (Debian 8.3.0-6) -->
  • Module: <!-- -->

<details><summary>Verbose output (from npm or node-gyp):</summary>

> zmq@2.15.3 install /home/emrah/Code/node-python/node_modules/zmq
> node-gyp rebuild

make: Entering directory '/home/emrah/Code/node-python/node_modules/zmq/build'
  CXX(target) Release/obj.target/zmq/binding.o
In file included from ../node_modules/nan/nan.h:190,
                 from ../binding.cc:38:
../node_modules/nan/nan_maybe_43_inl.h: In function ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’:
../node_modules/nan/nan_maybe_43_inl.h:88:15: error: ‘class v8::Object’ has no member named ‘ForceSet’
   return obj->ForceSet(GetCurrentContext(), key, value, attribs);
               ^~~~~~~~
In file included from ../node_modules/nan/nan_converters.h:59,
                 from ../node_modules/nan/nan.h:195,
                 from ../binding.cc:38:
../node_modules/nan/nan_converters_43_inl.h: In static member function ‘static Nan::imp::ToFactoryBase<v8::Boolean>::return_t Nan::imp::ToFactory<v8::Boolean>::convert(v8::Local<v8::Value>)’:
../node_modules/nan/nan_converters_43_inl.h:15:45: warning: ‘v8::MaybeLocal<v8::Boolean> v8::Value::ToBoolean(v8::Local<v8::Context>) const’ is deprecated: ToBoolean can never throw. Use Local version. [-Wdeprecated-declarations]
   return val->To ## TYPE(GetCurrentContext());                                 \
                                             ^
../node_modules/nan/nan_converters_43_inl.h:18:1: note: in expansion of macro ‘X’
 X(Boolean)
 ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2664:59: note: declared here
                 V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(
                                                           ^~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../node_modules/nan/nan_converters.h:59,
                 from ../node_modules/nan/nan.h:195,
                 from ../binding.cc:38:
../node_modules/nan/nan_converters_43_inl.h: In static member function ‘static Nan::imp::ValueFactoryBase<bool>::return_t Nan::imp::ToFactory<bool>::convert(v8::Local<v8::Value>)’:
../node_modules/nan/nan_converters_43_inl.h:31:48: warning: ‘v8::Maybe<bool> v8::Value::BooleanValue(v8::Local<v8::Context>) const’ is deprecated: BooleanValue can never throw. Use Isolate version. [-Wdeprecated-declarations]
   return val->NAME ## Value(GetCurrentContext());                              \
                                                ^
../node_modules/nan/nan_converters_43_inl.h:34:1: note: in expansion of macro ‘X’
 X(bool, Boolean)
 ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2702:51: note: declared here
                 V8_WARN_UNUSED_RESULT Maybe<bool> BooleanValue(
                                                   ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../node_modules/nan/nan_new.h:189,
                 from ../node_modules/nan/nan.h:196,
                 from ../binding.cc:38:
../node_modules/nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::Function>::return_t Nan::imp::Factory<v8::Function>::New(Nan::FunctionCallback, v8::Local<v8::Value>)’:
../node_modules/nan/nan_implementation_12_inl.h:109:32: error: no matching function for call to ‘v8::Function::New(v8::Isolate*&, void (&)(const v8::FunctionCallbackInfo<v8::Value>&), v8::Local<v8::Object>&)’
                           , obj));
                                ^
In file included from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:4275:31: note: candidate: ‘static v8::MaybeLocal<v8::Function> v8::Function::New(v8::Local<v8::Context>, v8::FunctionCallback, v8::Local<v8::Value>, int, v8::ConstructorBehavior, v8::SideEffectType)’
   static MaybeLocal<Function> New(
                               ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:4275:31: note:   no known conversion for argument 1 from ‘v8::Isolate*’ to ‘v8::Local<v8::Context>’
In file included from ../node_modules/nan/nan_new.h:189,
                 from ../node_modules/nan/nan.h:196,
                 from ../binding.cc:38:
../node_modules/nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::StringObject>::return_t Nan::imp::Factory<v8::StringObject>::New(v8::Local<v8::String>)’:
../node_modules/nan/nan_implementation_12_inl.h:345:37: error: no matching function for call to ‘v8::StringObject::New(v8::Local<v8::String>&)’
   return v8::StringObject::New(value).As<v8::StringObject>();
                                     ^
In file included from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:5531:23: note: candidate: ‘static v8::Local<v8::Value> v8::StringObject::New(v8::Isolate*, v8::Local<v8::String>)’
   static Local<Value> New(Isolate* isolate, Local<String> value);
                       ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:5531:23: note:   candidate expects 2 arguments, 1 provided
In file included from ../node_modules/nan/nan_new.h:189,
                 from ../node_modules/nan/nan.h:196,
                 from ../binding.cc:38:
../node_modules/nan/nan_implementation_12_inl.h:345:58: error: expected primary-expression before ‘>’ token
   return v8::StringObject::New(value).As<v8::StringObject>();
                                                          ^
../node_modules/nan/nan_implementation_12_inl.h:345:60: error: expected primary-expression before ‘)’ token
   return v8::StringObject::New(value).As<v8::StringObject>();
                                                            ^
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)’:
../node_modules/nan/nan.h:817:60: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
         v8::Isolate::GetCurrent(), target, func, argc, argv);
                                                            ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:174:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h:817:60: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
         v8::Isolate::GetCurrent(), target, func, argc, argv);
                                                            ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:174:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*)’:
../node_modules/nan/nan.h:831:62: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
         v8::Isolate::GetCurrent(), target, symbol, argc, argv);
                                                              ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:167:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h:831:62: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
         v8::Isolate::GetCurrent(), target, symbol, argc, argv);
                                                              ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:167:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, const char*, int, v8::Local<v8::Value>*)’:
../node_modules/nan/nan.h:845:62: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, const char*, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
         v8::Isolate::GetCurrent(), target, method, argc, argv);
                                                              ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:160:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h:845:62: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, const char*, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
         v8::Isolate::GetCurrent(), target, method, argc, argv);
                                                              ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:160:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In constructor ‘Nan::Utf8String::Utf8String(v8::Local<v8::Value>)’:
../node_modules/nan/nan.h:890:53: error: no matching function for call to ‘v8::Value::ToString()’
       v8::Local<v8::String> string = from->ToString();
                                                     ^
In file included from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2668:44: note: candidate: ‘v8::MaybeLocal<v8::String> v8::Value::ToString(v8::Local<v8::Context>) const’
   V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
                                            ^~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2668:44: note:   candidate expects 1 argument, 0 provided
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2684:31: note: candidate: ‘v8::Local<v8::String> v8::Value::ToString(v8::Isolate*) const’
                 Local<String> ToString(Isolate* isolate) const);
                               ^~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2684:31: note:   candidate expects 1 argument, 0 provided
                 Local<String> ToString(Isolate* isolate) const);
                               ^~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h:900:74: error: no matching function for call to ‘v8::String::WriteUtf8(char*&, int, int, const int&)’
         length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
                                                                          ^
In file included from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2878:7: note: candidate: ‘int v8::String::WriteUtf8(v8::Isolate*, char*, int, int*, int) const’
   int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
       ^~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:2878:7: note:   no known conversion for argument 1 from ‘char*’ to ‘v8::Isolate*’
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘bool Nan::Callback::operator==(const Nan::Callback&) const’:
../node_modules/nan/nan.h:1371:61: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     v8::Local<v8::Value> a = New(handle)->Get(kCallbackIndex);
                                                             ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h:1372:67: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     v8::Local<v8::Value> b = New(other.handle)->Get(kCallbackIndex);
                                                                   ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘v8::Local<v8::Function> Nan::Callback::GetFunction() const’:
../node_modules/nan/nan.h:1403:56: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     return scope.Escape(New(handle)->Get(kCallbackIndex)
                                                        ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘bool Nan::Callback::IsEmpty() const’:
../node_modules/nan/nan.h:1409:43: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     return New(handle)->Get(kCallbackIndex)->IsUndefined();
                                           ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘v8::Local<v8::Value> Nan::Callback::Call_(v8::Isolate*, v8::Local<v8::Object>, int, v8::Local<v8::Value>*) const’:
../node_modules/nan/nan.h:1447:27: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
         Get(kCallbackIndex).As<v8::Function>();
                           ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h:1463:5: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
     ));
     ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:174:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h:1463:5: warning: ‘v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)’ is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
     ));
     ^
In file included from ../binding.cc:25:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:174:50: note: declared here
                 NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                  ^~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:93:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘void Nan::AsyncWorker::SaveToPersistent(const char*, const v8::Local<v8::Value>&)’:
../node_modules/nan/nan.h:1518:64: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     New(persistentHandle)->Set(New(key).ToLocalChecked(), value);
                                                                ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3499:22: note: declared here
                 bool Set(Local<Value> key, Local<Value> value));
                      ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘void Nan::AsyncWorker::SaveToPersistent(const v8::Local<v8::String>&, const v8::Local<v8::Value>&)’:
../node_modules/nan/nan.h:1524:42: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     New(persistentHandle)->Set(key, value);
                                          ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3499:22: note: declared here
                 bool Set(Local<Value> key, Local<Value> value));
                      ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘void Nan::AsyncWorker::SaveToPersistent(uint32_t, const v8::Local<v8::Value>&)’:
../node_modules/nan/nan.h:1530:44: warning: ‘bool v8::Object::Set(uint32_t, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     New(persistentHandle)->Set(index, value);
                                            ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3508:22: note: declared here
                 bool Set(uint32_t index, Local<Value> value));
                      ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘v8::Local<v8::Value> Nan::AsyncWorker::GetFromPersistent(const char*) const’:
../node_modules/nan/nan.h:1536:61: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
         New(persistentHandle)->Get(New(key).ToLocalChecked()));
                                                             ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3553:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘v8::Local<v8::Value> Nan::AsyncWorker::GetFromPersistent(const v8::Local<v8::String>&) const’:
../node_modules/nan/nan.h:1542:55: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     return scope.Escape(New(persistentHandle)->Get(key));
                                                       ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3553:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In member function ‘v8::Local<v8::Value> Nan::AsyncWorker::GetFromPersistent(uint32_t) const’:
../node_modules/nan/nan.h:1547:57: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     return scope.Escape(New(persistentHandle)->Get(index));
                                                         ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In function ‘void Nan::AsyncQueueWorker(Nan::AsyncWorker*)’:
../node_modules/nan/nan.h:1706:62: warning: cast between incompatible function types from ‘void (*)(uv_work_t*)’ {aka ‘void (*)(uv_work_s*)’} to ‘uv_after_work_cb’ {aka ‘void (*)(uv_work_s*, int)’} [-Wcast-function-type]
     , reinterpret_cast<uv_after_work_cb>(AsyncExecuteComplete)
                                                              ^
In file included from /usr/include/c++/8/cassert:44,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/node_object_wrap.h:26,
                 from ../node_modules/nan/nan.h:49,
                 from ../binding.cc:38:
../node_modules/nan/nan_object_wrap.h: In destructor ‘virtual Nan::ObjectWrap::~ObjectWrap()’:
../node_modules/nan/nan_object_wrap.h:24:25: error: ‘class Nan::Persistent<v8::Object>’ has no member named ‘IsNearDeath’
     assert(persistent().IsNearDeath());
                         ^~~~~~~~~~~
In file included from ../node_modules/nan/nan.h:2192,
                 from ../binding.cc:38:
../node_modules/nan/nan_object_wrap.h: In member function ‘void Nan::ObjectWrap::MakeWeak()’:
../node_modules/nan/nan_object_wrap.h:67:34: warning: ‘void v8::PersistentBase<T>::MarkIndependent() [with T = v8::Object]’ is deprecated: Weak objects are always considered independent. Use TracedGlobal when trying to use EmbedderHeapTracer. Use a strong handle when trying to keep an object alive. [-Wdeprecated-declarations]
     persistent().MarkIndependent();
                                  ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:570:22: note: declared here
       V8_INLINE void MarkIndependent());
                      ^~~~~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from /usr/include/c++/8/cassert:44,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/node_object_wrap.h:26,
                 from ../node_modules/nan/nan.h:49,
                 from ../binding.cc:38:
../node_modules/nan/nan_object_wrap.h: In static member function ‘static void Nan::ObjectWrap::WeakCallback(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)’:
../node_modules/nan/nan_object_wrap.h:124:26: error: ‘class Nan::Persistent<v8::Object>’ has no member named ‘IsNearDeath’
     assert(wrap->handle_.IsNearDeath());
                          ^~~~~~~~~~~
../binding.cc: In static member function ‘static void zmq::Socket::UV_MonitorCallback(uv_timer_t*, int)’:
../binding.cc:533:98: warning: cast between incompatible function types from ‘void (*)(uv_timer_t*, int)’ {aka ‘void (*)(uv_timer_s*, int)’} to ‘uv_timer_cb’ {aka ‘void (*)(uv_timer_s*)’} [-Wcast-function-type]
 or_handle_, reinterpret_cast<uv_timer_cb>(Socket::UV_MonitorCallback), s->timer_interval_, 0);
                                                                     ^

../binding.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE zmq::Socket::Bind(Nan::NAN_METHOD_ARGS_TYPE)’:
../binding.cc:766:37: warning: cast between incompatible function types from ‘void (*)(uv_work_t*)’ {aka ‘void (*)(uv_work_s*)’} to ‘uv_after_work_cb’ {aka ‘void (*)(uv_work_s*, int)’} [-Wcast-function-type]
                   (uv_after_work_cb)UV_BindAsyncAfter);
                                     ^~~~~~~~~~~~~~~~~
../binding.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE zmq::Socket::Unbind(Nan::NAN_METHOD_ARGS_TYPE)’:
../binding.cc:847:37: warning: cast between incompatible function types from ‘void (*)(uv_work_t*)’ {aka ‘void (*)(uv_work_s*)’} to ‘uv_after_work_cb’ {aka ‘void (*)(uv_work_s*, int)’} [-Wcast-function-type]
                   (uv_after_work_cb)UV_UnbindAsyncAfter);
                                     ^~~~~~~~~~~~~~~~~~~
../binding.cc: In destructor ‘zmq::Socket::IncomingMessage::MessageReference::~MessageReference()’:
../binding.cc:999:54: warning: throw will always call terminate() [-Wterminate]
               throw std::runtime_error(ErrorMessage());
                                                      ^
../binding.cc:999:54: note: in C++11 destructors default to noexcept
../binding.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE zmq::Socket::Monitor(Nan::NAN_METHOD_ARGS_TYPE)’:
../binding.cc:1049:103: warning: cast between incompatible function types from ‘void (*)(uv_timer_t*, int)’ {aka ‘void (*)(uv_timer_s*, int)’} to ‘uv_timer_cb’ {aka ‘void (*)(uv_timer_s*)’} [-Wcast-function-type]
 or_handle_, reinterpret_cast<uv_timer_cb>(Socket::UV_MonitorCallback), timer_interval, 0);
                                                                     ^

../binding.cc: In destructor ‘zmq::Socket::OutgoingMessage::~OutgoingMessage()’:
../binding.cc:1205:50: warning: throw will always call terminate() [-Wterminate]
           throw std::runtime_error(ErrorMessage());
                                                  ^
../binding.cc:1205:50: note: in C++11 destructors default to noexcept
../binding.cc: In constructor ‘zmq::Socket::OutgoingMessage::BufferReference::BufferReference(v8::Local<v8::Object>)’:
../binding.cc:1217:78: warning: cast between incompatible function types from ‘void (*)(uv_async_t*, int)’ {aka ‘void (*)(uv_async_s*, int)’} to ‘uv_async_cb’ {aka ‘void (*)(uv_async_s*)’} [-Wcast-function-type]
            uv_async_init(loop, &async, reinterpret_cast<uv_async_cb>(cleanup));
                                                                             ^

../binding.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE zmq::Socket::Sendv(Nan::NAN_METHOD_ARGS_TYPE)’:
../binding.cc:1285:39: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
       Local<Object> buf = batch->Get(i).As<Object>();
                                       ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
../binding.cc:1286:48: warning: ‘v8::Local<v8::Value> v8::Object::Get(uint32_t)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
       Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
                                                ^
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3557:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
                                                   ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../binding.cc:25:
../binding.cc: At global scope:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:601:43: warning: cast between incompatible function types from ‘void (*)(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)’ {aka ‘void (*)(v8::Local<v8::Object>)’} to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
       (node::addon_register_func) (regfunc),                          \
                                           ^
/home/emrah/.cache/node-gyp/12.16.1/include/node/node.h:635:3: note: in expansion of macro ‘NODE_MODULE_X’
   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
   ^~~~~~~~~~~~~
../binding.cc:1619:1: note: in expansion of macro ‘NODE_MODULE’
 NODE_MODULE(zmq, init)
 ^~~~~~~~~~~
In file included from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)]’:
/home/emrah/.cache/node-gyp/12.16.1/include/node/node_object_wrap.h:85:78:   required from here
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:10226:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]
                reinterpret_cast<Callback>(callback), type);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = Nan::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)]’:
../node_modules/nan/nan_object_wrap.h:66:61:   required from here
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:10226:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<Nan::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]
In file included from ../binding.cc:38:
../node_modules/nan/nan.h: In instantiation of ‘void Nan::imp::SetMethodAux(T, v8::Local<v8::String>, v8::Local<v8::FunctionTemplate>, ...) [with T = v8::Local<v8::Object>]’:
../node_modules/nan/nan.h:1888:20:   required from ‘void Nan::SetMethod(HandleType<T>, const char*, Nan::FunctionCallback) [with T = v8::Object; HandleType = v8::Local; Nan::FunctionCallback = void (*)(const Nan::FunctionCallbackInfo<v8::Value>&)]’
../binding.cc:1572:52:   required from here
../node_modules/nan/nan.h:1872:3: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
   recv->Set(name, GetFunction(tpl).ToLocalChecked());
   ^~~~
In file included from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8-internal.h:14,
                 from /home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:27,
                 from ../binding.cc:24:
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8.h:3499:22: note: declared here
                 bool Set(Local<Value> key, Local<Value> value));
                      ^~~
/home/emrah/.cache/node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
make: *** [zmq.target.mk:111: Release/obj.target/zmq/binding.o] Error 1
make: Leaving directory '/home/emrah/Code/node-python/node_modules/zmq/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/emrah/.nvm/versions/node/v12.16.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:311:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Linux 4.19.0-6-amd64
gyp ERR! command "/home/emrah/.nvm/versions/node/v12.16.1/bin/node" "/home/emrah/.nvm/versions/node/v12.16.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/emrah/Code/node-python/node_modules/zmq
gyp ERR! node -v v12.16.1
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok 
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! zmq@2.15.3 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the zmq@2.15.3 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/emrah/.npm/_logs/2020-02-25T16_54_17_808Z-debug.log

</details>

<!-- Any further details -->

closed time in 3 hours

emrahc

issue commentnodejs/node-gyp

Node-gyp error while installing python binding related repo

zmq hasn’t been updated for four years (https://www.npmjs.com/package/zmq) and from the errors in the logs looks like it is not compatible with currently supported versions of Node.js. https://github.com/JustinTulloss/zeromq.node#readme says that zmq has been superseded by zeromq (https://www.npmjs.com/package/zeromq).

emrahc

comment created time in 3 hours

pull request commentnodejs/node

src: include large pages source unconditionally

AFAICT the failing test suite was re-run at https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_shared_x64/18250/, just not updated in the statuses.

Yes, the containered jobs currently only post status on failure which means they don’t get cleared when a subsequent run passes. It’s on my list of things to look at.

gabrielschulhof

comment created time in a day

issue commentnodejs/build

suggestion: we enable the "stale" bot on nodejs/build

Another option is the GitHub Actions stale action: https://github.com/actions/stale

sam-github

comment created time in a day

Pull request review commentlibuv/libuv

win,fs: fix problems with passing file names to uv_fs_statfs

 static void fs__statfs(uv_fs_t* req) {                              &bytes_per_sector,                              &free_clusters,                              &total_clusters)) {-    SET_REQ_WIN32_ERROR(req, GetLastError());-    return;+    DWORD err;++    err = GetLastError();+    if (err == ERROR_DIRECTORY) {+      WCHAR* pathw;+      WCHAR* fpart;+      size_t len;+      DWORD ret;++      len = MAX_PATH + 1;+      pathw = uv__malloc(len * sizeof(*pathw));+retry:+      ret = GetFullPathNameW(req->file.pathw,

https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfullpathnamew#remarks warns that GetFullPathNameW is not thread safe

erw7

comment created time in 4 days

pull request commentnodejs/node

build: add asan check in Github action

Seems like a good idea but how long does make test take for an asan+debug build?

https://github.com/nodejs/node/pull/31902/checks?check_run_id=460428978 took 1 hr 40mins.

gengjiawen

comment created time in 4 days

issue commentlibuv/libuv

os390: OOB write on realloc failure in scandir()

cc @libuv/zos

bnoordhuis

comment created time in 4 days

PR opened nodejs/build

ansible: add container for UBI 8.1

Adds a dockerfile for UBI 8.1.

From what I can tell the ansible changes would all be to the test inventory.xml in secrets (and not here in this repo). @nodejs/build-infra do I need to cleanly shutdown all the running containers (as per https://github.com/nodejs/build/blob/97b004a672d17820976ea8eac91b4dde8a6a4697/ansible/MANUAL_STEPS.md#Docker-hosts) in a container host before re-ansibling it (once I've added the new container to the inventory)?

Refs: https://github.com/nodejs/build/issues/2176

+50 -0

0 comment

1 changed file

pr created time in 4 days

create barnchrichardlau/build

branch : ubi8

created branch time in 4 days

pull request commentlibuv/libuv

build: remove support for gyp

Also, macos looks red, though autotools could be used. So it seems the bots need to have cmake installed and the jenkins build scripts updated accordingly. I can try to look into the needed changes in ansible to add cmake, but I don't know where the jenkins build scripts are located in the nodejs/build repo.

The ansible scripts are stored in https://github.com/nodejs/build/tree/master/ansible. I'm relatively new to ansible so I can't be more specific than that at the moment (🙇).

The build scripts themselves are not stored in nodejs/build so to change the build steps the jobs themselves will need to be edited. At the moment it doesn't look like we've granted configuration permission on the libuv jobs to anyone outside of Build: e.g. https://ci.nodejs.org/job/libuv-test-commit/configure image

but we do have a policy of allowing groups to own jobs (e.g. https://github.com/nodejs/build/blob/master/GOVERNANCE.md#jenkins-job-configuration-access which talks about Working Groups but could easily apply to libuv). I suggest deciding who we would like to be able to edit the job configuration for the libuv jobs (ideally a GitHub group) and raising an issue over in nodejs/build (for audit purposes) asking for them to be given the ability to modify libuv jobs.

bnoordhuis

comment created time in 4 days

issue commentnodejs/node-gyp

Remove python 2.7 as requirement from the README.md

My bet is that this would be SemVer Major. At what stage would it intersect https://github.com/nodejs/release#nodejs-release-working-group ?

It doesn't? At least so far Release has not been involved with node-gyp.

Pomax

comment created time in 4 days

issue closednodejs/node

experimental-report feature enabled as default setting in 12.16.1 LTS

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name -->

  • Version:v12.16.1
  • Platform:Linux raspberrypi 4.19.50-v7+ #896 SMP Thu Jun 20 16:11:44 BST 2019 armv7l GNU/Linux
  • Subsystem:

What steps will reproduce the bug?

Cause out of memory condition

How often does it reproduce? Is there a required condition?

100% FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

Writing Node.js report to file: report.20200221.162310.10646.0.001.json Node.js report completed Aborted

What is the expected behavior?

Not to write Node.js report to file because the experimental-report feature is not set on the command line and not an environment variable.

<!-- If possible please provide textual output instead of screenshots. -->

What do you see instead?

<!-- If possible please provide textual output instead of screenshots. -->

Additional information

<!-- Tell us anything else you think we should know. -->

closed time in 4 days

CalebCarroll

issue commentnodejs/node

experimental-report feature enabled as default setting in 12.16.1 LTS

This is a duplicate of https://github.com/nodejs/node/issues/31576.

CalebCarroll

comment created time in 4 days

Pull request review commentnodejs/nodejs.org

correct (new) link

 There are several dependencies that Node.js relies on to work the way it does. The V8 library provides Node.js with a JavaScript engine, which Node.js controls via the V8 C++ API. V8 is maintained by Google, for use in Chrome. -* [Documentation](https://v8docs.nodesource.com/)+* [Documentation](https://v8.dev/docs)

Just an observation but the old URL and new URL are pointing at different things. The old URL was a link to V8 API documentation, which is useful to people embedding V8 (e.g. Node.js core developers) or writing addons (although N-API or using nan would be preferable to directly using the V8 API's to protect addons from breaking when the V8 API changes).

The new URL doesn't contain any of this API documentation, although there is an issue requesting it (https://github.com/v8/v8.dev/issues/234).

ahmadrasyidsalim

comment created time in 5 days

issue closednodejs/node-gyp

mac use npm install error: `make` failed with exit code: 2

mac version: 10.13.4 MacBook Pro (13-inch, 2016, Four Thunderbolt 3 Ports)

use npm install error:

gyp ERR! node -v v13.7.0 gyp ERR! node-gyp -v v5.0.5

> fibers@3.1.1 install /Users/maya/Desktop/project-a/node_modules/fibers
> node build.js || nodejs build.js

  CXX(target) Release/obj.target/fibers/src/fibers.o
../src/fibers.cc:68:2: error: no template named 'Handle'
        Handle<String> NewLatin1String(Isolate* isolate, const char* string) {
        ^
../src/fibers.cc:69:10: error: no viable conversion from returned value of type 'Local<v8::String>' to function return type 'int'
                return String::NewFromOneByte(isolate, (const uint8_t*)string, NewStringType::kNormal).ToLocalChecked();
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/fibers.cc:72:2: error: no template named 'Handle'
        Handle<String> NewLatin1Symbol(Isolate* isolate, const char* string) {
        ^
../src/fibers.cc:73:10: error: no viable conversion from returned value of type 'Local<v8::String>' to function return type 'int'
                return String::NewFromOneByte(isolate, (const uint8_t*)string, NewStringType::kNormal).ToLocalChecked();
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/fibers.cc:94:2: error: no template named 'Handle'
        Handle<Object> NewInstance(Isolate* isolate, Local<Function> fn, int argc, Local<Value> argv[]) {
        ^
../src/fibers.cc:95:10: error: no viable conversion from returned value of type 'Local<v8::Object>' to function return type 'int'
                return fn->NewInstance(isolate->GetCurrentContext(), argc, argv).ToLocalChecked();
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/fibers.cc:104:2: error: no template named 'Handle'
        Handle<Number> ToNumber(Local<Value> value) {
        ^
../src/fibers.cc:105:10: error: no viable conversion from returned value of type 'Local<v8::Number>' to function return type 'int'
                return value->ToNumber(Isolate::GetCurrent()->GetCurrentContext()).ToLocalChecked();
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/fibers.cc:114:50: error: no template named 'Handle'
        Local<Value> GetStackTrace(TryCatch* try_catch, Handle<Context> context) {
                                                        ^
../src/fibers.cc:127:39: error: no template named 'Handle'
        void fixStackLimit(Isolate* isolate, Handle<Context> context) {
                                             ^
../src/fibers.cc:149:58: error: no template named 'Handle'
        void Reset(Isolate* isolate, Persistent<T>& persistent, Handle<T> handle) {
                                                                ^
../src/fibers.cc:162:7: error: variable has incomplete type 'void'
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
             ^
../src/fibers.cc:162:26: error: use of undeclared identifier 'Handle'
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
                                ^
../src/fibers.cc:162:33: error: 'T' does not refer to a value
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
                                       ^
../src/fibers.cc:161:18: note: declared here
        template <class T>
                        ^
../src/fibers.cc:162:36: error: use of undeclared identifier 'handle'
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
                                          ^
../src/fibers.cc:162:48: error: expected '(' for function-style cast or type construction
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
                                                  ~~~ ^
../src/fibers.cc:162:59: error: expected '(' for function-style cast or type construction
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
                                                             ~~~~^
../src/fibers.cc:162:61: error: use of undeclared identifier 'val'
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
                                                                   ^
../src/fibers.cc:162:65: error: expected ';' at end of declaration
        void SetInternalPointer(Handle<T> handle, int index, void* val) {
                                                                       ^
                                                                       ;
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Release/obj.target/fibers/src/fibers.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:321:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 17.5.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
gyp ERR! cwd /Users/maya/Desktop/project-a/node_modules/fibers
gyp ERR! node -v v13.7.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok 
node-gyp exited with code: 1
Please make sure you are using a supported platform and node version. If you
would like to compile fibers on this machine please make sure you have setup your
build environment--
Windows + OS X instructions here: https://github.com/nodejs/node-gyp
Ubuntu users please run: `sudo apt-get install g++ build-essential`
RHEL users please run: `yum install gcc-c++` and `yum groupinstall 'Development Tools'` 
Alpine users please run: `sudo apk add python make g++`
sh: nodejs: command not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! fibers@3.1.1 install: `node build.js || nodejs build.js`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the fibers@3.1.1 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/maya/.npm/_logs/2020-02-20T07_30_41_347Z-debug.log

closed time in 5 days

zghbyslzf

issue commentnodejs/node-gyp

mac use npm install error: `make` failed with exit code: 2

Both of you are trying to install modules that are not compatible with Node.js 13. You will need to check with the specific modules whether there is a later version of that module than the one you are attempting to install that is compatible or downgrade to Node.js 12 (or 10 if that still doesn't work).

zghbyslzf

comment created time in 5 days

pull request commentnodejs/node

deps: switch to chromium's zlib implementation

For @nodejs/releasers this has broken builds from the source tarball and would need to land on, e.g. 12.x, with whatever fixes it.

mscdex

comment created time in 7 days

issue commentnodejs/node

v13.9.0 tarball seems to be missing `deps/zlib/contrib`

The source tarball is built by stripping out things from the source tree: https://github.com/nodejs/node/blob/0c3c0e7184c4ca625148c14d61d8e9438a1b69f2/Makefile#L1018-L1054

Up until now we exclude everything in deps/zlib/contrib: https://github.com/nodejs/node/blob/0c3c0e7184c4ca625148c14d61d8e9438a1b69f2/Makefile#L1035

but https://github.com/nodejs/node/pull/31201 has changed things. Is it just contrib/optimizations that we need to add?

mhart

comment created time in 7 days

issue commentnodejs/build

aix: add AIX7.1 build machines to CI

@richardlau If node-report is passing, can this be closed?

@sam-github Were we also going to switch 10.x to build releases on AIX 7.1? https://github.com/nodejs/build/blob/76c481610f57a822601188a372d9aae4f76dfb84/jenkins/scripts/VersionSelectorScript.groovy#L93

sam-github

comment created time in 7 days

issue openednodejs/build

node-daily-coverity failing on test-packetnet-ubuntu1604-x64-1

https://ci.nodejs.org/job/node-daily-coverity/ is failing on https://ci.nodejs.org/computer/test-packetnet-ubuntu1604-x64-1/

image

e.g. https://ci.nodejs.org/job/node-daily-coverity/1421/console

+ getconf _NPROCESSORS_ONLN
+ V=1 cov-build --dir cov-int make -j 8
/tmp/jenkins5860511461133452759.sh: 6: /tmp/jenkins5860511461133452759.sh: cov-build: not found

According to https://github.com/nodejs/build/blob/97b004a672d17820976ea8eac91b4dde8a6a4697/ansible/MANUAL_STEPS.md#jenkins-workspace installing Coverity Build Tool for Linux x64 is a manual step. I've logged into Coverity but I can't download the build tool as apparently I need admin access to at least one project: image

https://ci.nodejs.org/job/node-daily-coverity/1422/ ran on test-packetnet-ubuntu1604-x64-2 and passed.

created time in 7 days

issue commentnodejs/Release

v12.16.0 post-mortem

For future ESM backports, I suggest that we actively focus on making sure it is flagged.

Were these clean cherry-picks or manual backports? Should ESM changes always be manually backported due to the differences in requiring flags?

targos

comment created time in 7 days

issue commentnodejs/build

Tracking Jenkins changes

@rvagg I seem to remember there was a way to find the person who triggered a change. Can you remind me how? Looking in https://github.com/nodejs/jenkins-config-test/blob/master/jobs/libuv-test-commit.xml I've not found it yet.

@mhdawson that job doesn't have it! It could be a newer feature and that job hasn't been touched since that feature was added.

I edited that job 9 days ago (https://github.com/nodejs/build/issues/2170#issuecomment-583741085). Maybe Jenkins doesn't count changes to permissions when updating the last saved fields?

richardlau

comment created time in 8 days

push eventnodejs/build

Richard Lau

commit sha 76c481610f57a822601188a372d9aae4f76dfb84

doc: fix broken link in jenkins-guide.md (#2177)

view details

push time in 8 days

push eventnodejs/build

Richard Lau

commit sha fbbd1f34d57c72bf0ea642edd2fc81a286bea8bf

workflow: update job names, use checkout@v2 (#2160)

view details

push time in 8 days

PR merged nodejs/build

workflow: update job names, use checkout@v2

Renames jobs in the current GitHub Actions workflow to be more descriptive. The plan is to add a further job to lint yaml (continuation of https://github.com/nodejs/build/pull/1476 but as a workflow instead of Travis CI) but this is a standalone change.

+3 -3

0 comment

1 changed file

richardlau

pr closed time in 8 days

issue commentnodejs/Release

Move @Fishrock123 to Emeritus?

See also https://github.com/nodejs/Release/issues/499#issuecomment-548513134.

Trott

comment created time in 8 days

Pull request review commentnodejs/node

v13.9.0 proposal

 release. </tr> <tr>     <td valign="top">-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.8.0">13.8.0</a></b><br/>+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.9.0">13.9.0</a></b><br/>+<a href="doc/changelogs/CHANGELOG_V13.md#13.7.0">13.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.8.0">13.8.0</a><br/>
codebytere

comment created time in 8 days

issue commentnodejs/build

Why did download metrics drop significantly around October 2019?

We switched to serving downloads via CDN but the metrics scripts haven't been modified yet. See https://github.com/nodejs/build/pull/2025 for some background.

golopot

comment created time in 9 days

pull request commentnodejs/node

[v10.x] Backport large pages to v10.x

https://github.com/nodejs/node/pull/31547 hasn't been in a current release yet and generally we would only backport things into LTS that have been in current for two weeks.

gabrielschulhof

comment created time in 10 days

Pull request review commentnodejs/node

doc: improve doc/markdown file organization coherence

 * [Technical Steering Committee](#technical-steering-committee)   * [TSC Meetings](#tsc-meetings) * [Collaborator Nominations](#collaborator-nominations)-  * [Onboarding](#onboarding)+  * [Onboarding](#./doc/guides/onboarding)
  * [Onboarding](#onboarding)

This one shouldn't have changed as it's in the TOC.

ConorDavenport

comment created time in 11 days

pull request commentlibuv/libuv

fix: non-portable path issues

@libuv/windows

codebytere

comment created time in 11 days

issue closednodejs/Release

Release Node 12.16 on official PPA

Node 12.16 has been released on Docker, but not on the official nodesource PPA.

Because of a breaking change in Node 12.16, our CI builds are now failing, but the issue can’t be reproduced on a local development machine.

closed time in 11 days

remcohaszing

issue commentnodejs/Release

Release Node 12.16 on official PPA

You'll need to raise this in https://github.com/nodesource/distributions as the Nodesource distributions are nothing to do with us.

remcohaszing

comment created time in 11 days

issue commentnodejs/build

Add Universal Base Image (UBI) build to CI system

Do you know if you can FROM registry.access.redhat.com/ubi8:8.1 in a Dockerfile? If not then we'll have to do some extra Ansible work to pull from a custom registry.

From my preliminary experiments It appears that you can.

danbev

comment created time in 12 days

pull request commentnodejs/node

v12.16.1 proposal

If anyone knows of other 12.x regressions I'd be happy to bring them in here.

There were a couple of other regressions introduced in 12.16.0 too:

  • https://github.com/nodejs/node/issues/31752, which @addaleax is looking at but perhaps we could revert https://github.com/nodejs/node/commit/65e5a8a90cd85fc4d9036bc4b54e0905edd8b51a?
  • https://github.com/nodejs/node/issues/31249#issuecomment-585636203 which is due to https://github.com/nodejs/node/pull/30954 landing in 12.16.0. https://github.com/nodejs/node/pull/31547 should fix the regression in building but it hasn't been in a current release yet.
MylesBorins

comment created time in 12 days

issue commentnodejs/Release

ESM issue on 12.x requires a quick 12.16.1

There were a couple of other regressions introduced in 12.16.0 too:

  • https://github.com/nodejs/node/issues/31752, which @addaleax is looking at but perhaps we could revert https://github.com/nodejs/node/commit/65e5a8a90cd85fc4d9036bc4b54e0905edd8b51a?
  • https://github.com/nodejs/node/issues/31249#issuecomment-585636203 which is due to https://github.com/nodejs/node/pull/30954 landing in 12.16.0. https://github.com/nodejs/node/pull/31547 should fix the regression in building but it hasn't been in a current release yet.
MylesBorins

comment created time in 12 days

Pull request review commentnodejs/nodejs.dev

Removing duplicate Node.js framework.

 Many of those established over time as popular options. Here is a non-comprehens - [**Loopback.io**](https://loopback.io/): Makes it easy to build modern applications that require complex integrations. - [**Meteor**](https://meteor.com): An incredibly powerful full-stack framework, powering you with an isomorphic approach to building apps with JavaScript, sharing code on the client and the server. Once an off-the-shelf tool that provided everything, now integrates with frontend libs [React](https://reactjs.org/), [Vue](https://vuejs.org/), and [Angular](https://angular.io). Can be used to create mobile apps as well. - [**Micro**](https://github.com/zeit/micro): It provides a very lightweight server to create asynchronous HTTP microservices.-- [**NestJS**](https://nestjs.com/): A TypeScript based progressive Node.js framework for building enterprise-grade efficient, reliable and scalable server-side applications. - [**Next.js**](https://nextjs.org/): A framework to render server-side rendered [React](https://reactjs.org/) applications.

These look like separate projects and not duplicates.

ahtee

comment created time in 12 days

PR opened nodejs/build

doc: fix broken link in jenkins-guide.md
+1 -1

0 comment

1 changed file

pr created time in 12 days

create barnchnodejs/build

branch : richardlau/brokenlink

created branch time in 12 days

issue commentnodejs/build

Add Universal Base Image (UBI) build to CI system

@rvagg I’ll take a look at this.

danbev

comment created time in 12 days

IssuesEvent

issue closednodejs/node-gyp

node-gyp rebuild fails in macOS Catalina (10.15) - No rule to make target `node_modules/node-gyp/addon.gypi`, needed by `Makefile'.

<!-- Thank you for reporting an issue. The more information you can give us, the better the chance we can fix your problem.

This issue tracker is for issues with node-gyp, if you have an issue installing a specific module, please file an issue on that module's issue tracker (npm issues modulename). -->

  • Node Version: 10.10.0 / 6.4.1
  • Platform: Darwin Matts-MBP-3.local 19.0.0 Darwin Kernel Version 19.0.0: Fri May 24 17:36:10 PDT 2019; root:xnu-6041.0.0.111.5~1/RELEASE_X86_64 x86_64
  • Compiler: Apple clang version 11.0.0 (clang-1100.0.20.17) Target: x86_64-apple-darwin19.0.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin
  • Module: Failure occurred during better-sqlite3@5.4.0 install as part of electron-builder

<details><summary>Verbose output (from npm or node-gyp):</summary>

> electron-builder install-app-deps --arch x64

  • electron-builder version=20.26.1
  • rebuilding native production dependencies platform=darwin arch=x64
Error: /usr/local/Cellar/node/10.10.0/bin/node exited with code 1
Output:

> better-sqlite3@5.4.0 install /Users/mattcowley/WebstormProjects/MagicCap/node_modules/better-sqlite3
> node-gyp rebuild


Error output:
make: *** No rule to make target `../../../../../../../usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi', needed by `Makefile'.  Stop.
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 19.0.0
gyp ERR! command "/usr/local/Cellar/node/10.10.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/mattcowley/WebstormProjects/MagicCap/node_modules/better-sqlite3
gyp ERR! node -v v10.10.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! better-sqlite3@5.4.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the better-sqlite3@5.4.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mattcowley/.npm/_logs/2019-06-16T10_20_00_103Z-debug.log

    at ChildProcess.childProcess.once.code (/Users/mattcowley/WebstormProjects/MagicCap/node_modules/builder-util/src/util.ts:255:14)
    at Object.onceWrapper (events.js:273:13)
    at ChildProcess.emit (events.js:182:13)
    at maybeClose (internal/child_process.js:962:16)
    at Socket.stream.socket.on (internal/child_process.js:381:11)
    at Socket.emit (events.js:182:13)
    at Pipe._handle.close (net.js:606:12)
From previous event:
    at rebuild (/Users/mattcowley/WebstormProjects/MagicCap/node_modules/app-builder-lib/out/util/yarn.js:238:18)
    at /Users/mattcowley/WebstormProjects/MagicCap/node_modules/app-builder-lib/src/util/yarn.ts:20:11
From previous event:
    at installOrRebuild (/Users/mattcowley/WebstormProjects/MagicCap/node_modules/app-builder-lib/out/util/yarn.js:68:17)
    at /Users/mattcowley/WebstormProjects/MagicCap/node_modules/electron-builder/src/cli/install-app-deps.ts:56:9
    at Generator.next (<anonymous>)
    at runCallback (timers.js:694:18)
    at tryOnImmediate (timers.js:665:5)
    at processImmediate (timers.js:647:5)
From previous event:
    at installAppDeps (/Users/mattcowley/WebstormProjects/MagicCap/node_modules/electron-builder/out/cli/install-app-deps.js:174:17)
    at then (/Users/mattcowley/WebstormProjects/MagicCap/node_modules/electron-builder/src/cli/cli.ts:42:48)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! magiccap@1.1.0-b4 postinstall: `electron-builder install-app-deps --arch x64`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the magiccap@1.1.0-b4 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mattcowley/.npm/_logs/2019-06-16T10_20_00_173Z-debug.log

2019-06-16T10_20_00_103Z-debug.log

2019-06-16T10_20_00_173Z-debug.log

</details>

<!-- Any further details -->

closed time in 12 days

MattIPv4

issue commentnodejs/Release

Node.js Foundation Release WorkGroup Meeting 2020-02-13

+1 to cancel.

mhdawson

comment created time in 13 days

issue commentnodejs/help

“node-v12.12.0 (1).pkg” can’t be opened because Apple cannot check it for malicious software.

@AndrewTrapani Work is underway in https://github.com/nodejs/node/pull/31459. The main blocker now is getting a more recent version of macOS in our CI.

tomo-at-e-sign

comment created time in 13 days

issue closednodejs/node-gyp

node-gyp rebuild error

<!-- Thank you for reporting an issue. The more information you can give us, the better the chance we can fix your problem.

This issue tracker is for issues with node-gyp, if you have an issue installing a specific module, please file an issue on that module's issue tracker (npm issues modulename). -->

  • Node Version: v12.15.0
  • Platform: Linux lpgaixmgmtlx01 3.10.0-1062.9.1.el7.ppc64le
  • Compiler: gcc version 8.3.1 20190311 (Red Hat 8.3.1-3) (GCC)
  • Module: deasync

<details><summary>Verbose output (from npm or node-gyp):</summary>

gyp info it worked if it ends with ok
gyp verb cli [
gyp verb cli   '/scratch/node-v12.15.0-linux-ppc64le/bin/node',
gyp verb cli   '/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose'
gyp verb cli ]
gyp info using node-gyp@5.0.5
gyp info using node@12.15.0 | linux | ppc64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb find Python Python is not set from command line or npm configuration
gyp verb find Python Python is not set from environment variable PYTHON
gyp verb find Python checking if "python" can be used
gyp verb find Python - executing "python" to get executable path
gyp verb find Python - executable path is "/usr/bin/python"
gyp verb find Python - executing "/usr/bin/python" to get version
gyp verb find Python - version is "2.7.5"
gyp info find Python using Python version 2.7.5 found at "/usr/bin/python"
gyp verb get node dir no --target version specified, falling back to host node version: 12.15.0
gyp verb command install [ '12.15.0' ]
gyp verb install input version string "12.15.0"
gyp verb install installing version: 12.15.0
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version is already installed, need to check "installVersion"
gyp verb got "installVersion" 9
gyp verb needs "installVersion" 9
gyp verb install version is good
gyp verb get node dir target node version installed: 12.15.0
gyp verb build dir attempting to create "build" dir: /scratch/go/src/github.com/influxdata/chronograf/build
gyp verb build dir "build" dir needed to be created? /scratch/go/src/github.com/influxdata/chronograf/build
gyp verb build/config.gypi creating config file
gyp verb build/config.gypi writing out config file: /scratch/go/src/github.com/influxdata/chronograf/build/config.gypi
gyp verb config.gypi checking for gypi file: /scratch/go/src/github.com/influxdata/chronograf/config.gypi
gyp verb common.gypi checking for gypi file: /scratch/go/src/github.com/influxdata/chronograf/common.gypi
gyp verb gyp gyp format was not specified; forcing "make"
gyp info spawn /usr/bin/python
gyp info spawn args [
gyp info spawn args   '/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/scratch/go/src/github.com/influxdata/chronograf/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/root/.cache/node-gyp/12.15.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/root/.cache/node-gyp/12.15.0',
gyp info spawn args   '-Dnode_gyp_dir=/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/root/.cache/node-gyp/12.15.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/scratch/go/src/github.com/influxdata/chronograf',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp: binding.gyp not found (cwd: /scratch/go/src/github.com/influxdata/chronograf) while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack     at ChildProcess.emit (events.js:223:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 3.10.0-1062.9.1.el7.ppc64le
gyp ERR! command "/scratch/node-v12.15.0-linux-ppc64le/bin/node" "/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose"
gyp ERR! cwd /scratch/go/src/github.com/influxdata/chronograf
gyp ERR! node -v v12.15.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok


</details>

<!-- Any further details -->

root@lpgaixmgmtlx01:/scratch/go/src/github.com/influxdata/chronograf>make
cd ui && yarn --no-progress --no-emoji
yarn install v1.22.0
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.2.4: The platform "linux" is incompatible with this module.
info "fsevents@1.2.4" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
error /scratch/go/src/github.com/influxdata/chronograf/ui/node_modules/deasync: Command failed.
Exit code: 1
Command: node ./build.js
Arguments:
Directory: /scratch/go/src/github.com/influxdata/chronograf/ui/node_modules/deasync
Output:
gyp info it worked if it ends with ok
gyp info using node-gyp@5.0.5
gyp info using node@12.15.0 | linux | ppc64
gyp info find Python using Python version 2.7.5 found at "/usr/bin/python"
gyp info spawn /usr/bin/python
gyp info spawn args [
gyp info spawn args   '/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/scratch/go/src/github.com/influxdata/chronograf/ui/node_modules/deasync/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/root/.cache/node-gyp/12.15.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/root/.cache/node-gyp/12.15.0',
gyp info spawn args   '-Dnode_gyp_dir=/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/root/.cache/node-gyp/12.15.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/scratch/go/src/github.com/influxdata/chronograf/ui/node_modules/deasync',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make[1]: Entering directory '/scratch/go/src/github.com/influxdata/chronograf/ui/node_modules/deasync/build'
....
gibberish removed
....
In file included from ../src/deasync.cc:2:
/root/.cache/node-gyp/12.15.0/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)]’:
/root/.cache/node-gyp/12.15.0/include/node/node_object_wrap.h:84:78:   required from here
/root/.cache/node-gyp/12.15.0/include/node/v8.h:10004:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]
                reinterpret_cast<Callback>(callback), type);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/.cache/node-gyp/12.15.0/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = Nan::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)]’:
../../nan/nan_object_wrap.h:66:61:   required from here
/root/.cache/node-gyp/12.15.0/include/node/v8.h:10004:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<Nan::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]
make[1]: *** [deasync.target.mk:111: Release/obj.target/deasync/src/deasync.o] Error 1
make[1]: Leaving directory '/scratch/go/src/github.com/influxdata/chronograf/ui/node_modules/deasync/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:223:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 3.10.0-1062.9.1.el7.ppc64le
gyp ERR! command "/scratch/node-v12.15.0-linux-ppc64le/bin/node" "/scratch/node-v12.15.0-linux-ppc64le/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /scratch/go/src/github.com/influxdata/chronograf/ui/node_modules/deasync
gyp ERR! node -v v12.15.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok
Build failed
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
make: *** [Makefile:91: .jsdep] Error 1

closed time in 13 days

flynn1973

issue commentnodejs/node-gyp

node-gyp rebuild error

root@lpgaixmgmtlx01:/scratch/go/src/github.com/influxdata/chronograf>npm install deasync --unsafe-perm

> deasync@0.1.19 install /scratch/go/src/github.com/influxdata/chronograf/node_modules/deasync
> node ./build.js

make: Entering directory '/scratch/go/src/github.com/influxdata/chronograf/node_modules/deasync/build'
  CXX(target) Release/obj.target/deasync/src/deasync.o
  SOLINK_MODULE(target) Release/obj.target/deasync.node
  COPY Release/deasync.node
make: Leaving directory '/scratch/go/src/github.com/influxdata/chronograf/node_modules/deasync/build'
Installed in `/scratch/go/src/github.com/influxdata/chronograf/node_modules/deasync/bin/linux-ppc64-node-12/deasync.node`
npm WARN saveError ENOENT: no such file or directory, open '/scratch/go/src/github.com/influxdata/chronograf/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/scratch/go/src/github.com/influxdata/chronograf/package.json'
npm WARN chronograf No description
npm WARN chronograf No repository field.
npm WARN chronograf No README data
npm WARN chronograf No license field.

+ deasync@0.1.19
added 4 packages from 47 contributors and audited 4 packages in 1.803s
found 0 vulnerabilities

This shows that the latest deasync successfully installs on your system so you'll need to track down what is requiring deasync and why it doesn't use the latest version. In any case this isn't an issue with node-gyp.

flynn1973

comment created time in 13 days

Pull request review commentnodejs/node

feat: make fs.read params optional

 Returns an integer representing the file descriptor. For detailed information, see the documentation of the asynchronous version of this API: [`fs.open()`][]. -## `fs.read(fd, buffer, offset, length, position, callback)`+## `fs.read(fd, [buffer[, [offset[, length[, position]]]], callback)` <!-- YAML added: v0.0.2 changes:+  - version: REPLACEME+    pr-url: REPLACEME
    pr-url: https://github.com/nodejs/node/pull/31402
lholmquist

comment created time in 14 days

Pull request review commentnodejs/node

feat: make fs.read params optional

 The callback is given the three arguments, `(err, bytesRead, buffer)`. If this method is invoked as its [`util.promisify()`][]ed version, it returns a `Promise` for an `Object` with `bytesRead` and `buffer` properties. +## `fs.read(fd, options, callback)`+<!-- YAML+added: v0.0.2+changes:+  - version: REPLACEME+    pr-url: REPLACEME
    pr-url: https://github.com/nodejs/node/pull/31402
lholmquist

comment created time in 14 days

issue commentlibuv/libuv-release-tool

Suggestion: create a GitHub release after pushing each tag

I've moved this issue to the libuv-release-tool repo, as any changes to the release process would need to happen here.

This issue could probably be solved now with GitHub Actions and the create-release action.

aantron

comment created time in 14 days

issue commentnodejs/build

ci,libuv: run `make distcheck`

While editing https://ci.nodejs.org/job/libuv-test-commit-linux/ for https://github.com/nodejs/build/issues/2174 I tried replacing make check with make distcheck but this seems to introduce test failures: https://ci.nodejs.org/job/libuv-test-commit-linux/1824/

not ok 48 - fs_copyfile
# exit code 134
# Output from process `fs_copyfile`:
# Assertion failed in ../../test/test-fs-copyfile.c on line 156: r == 0
...
not ok 169 - pipe_connect_to_file
# exit code 134
# Output from process `pipe_connect_to_file`:
# Assertion failed in ../../test/test-pipe-connect-error.c on line 53: status == UV_ENOTSOCK || status == UV_ECONNREFUSED

make check passed all tests: https://ci.nodejs.org/job/libuv-test-commit-linux/1825/

bnoordhuis

comment created time in 14 days

issue commentnodejs/build

ci,libuv: decommission ubuntu1404-gyp-{32,64}

I toggled back to make distcheck and ran on libuv/libuv v1.x and that failed differently (test failures). I'll take that conversation over to https://github.com/nodejs/build/issues/1910.

bnoordhuis

comment created time in 14 days

issue commentnodejs/build

ci,libuv: decommission ubuntu1404-gyp-{32,64}

Ah thinking about It I probably should have run against libuv/libuv v1.x instead of bnoordhuis/libuv drop-gyp so I don't know if it's an issue with https://github.com/libuv/libuv/pull/2682.

bnoordhuis

comment created time in 14 days

issue commentnodejs/build

ci,libuv: decommission ubuntu1404-gyp-{32,64}

FYI while I was editing I tried replacing make check with make distcheck for https://github.com/nodejs/build/issues/1910 but almost all platforms failed https://ci.nodejs.org/job/libuv-test-commit-linux/1822/ so I changed it back.

bnoordhuis

comment created time in 14 days

issue commentnodejs/build

ci,libuv: decommission ubuntu1404-gyp-{32,64}

Done. I've taken out the gyp conditionals in the shell scripts too. Test build: https://ci.nodejs.org/job/libuv-test-commit-linux/1823/

bnoordhuis

comment created time in 14 days

issue commentnodejs/build

ci,libuv: decommission ubuntu1404-gyp-{32,64}

Gone!

FTR they're were in https://ci.nodejs.org/job/libuv-test-commit-linux/: image

Should I remove ubuntu1404-* (the non-gyp variants) too (there'd still be ubuntu1604-* left)?

bnoordhuis

comment created time in 14 days

issue commentnodejs/build

ci,libuv: http://ci.nodejs.org/downloads/zos/gyp.tar.gz?

Another reason for using the tarball on z/OS is that the z/OS port of git doesn't support https URLs: https://forum.rocketsoftware.com/t/git-and-https-repositories/482.

https://github.com/nodejs/build/blob/4058b56f9e8f33711596867c66485b2ba44bae72/ansible/roles/jenkins-worker/tasks/main.yml#L207-L209

bnoordhuis

comment created time in 14 days

issue commentnodejs/node

doc/markdown file organization lacks coherence

│   └── STYLE_GUIDE.md
> Move to guides/documentation-style.md?

and merge with tools/doc/README.md?

sam-github

comment created time in 14 days

issue commentnodejs/node-gyp

node-gyp rebuild error

In file included from ../../nan/nan_new.h:189,
                 from ../../nan/nan.h:222,
                 from ../src/deasync.cc:3:
../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::Function>::return_t Nan::imp::Factory<v8::Function>::New(Nan::FunctionCallback, v8::Local<v8::Value>)’:
../../nan/nan_implementation_12_inl.h:105:32: error: no matching function for call to ‘v8::Function::New(v8::Isolate*&, void (&)(const v8::FunctionCallbackInfo<v8::Value>&), v8::Local<v8::Object>&)’
                           , obj));
                                ^
...
In file included from /opt/rh/devtoolset-8/root/usr/include/c++/8/cassert:44,
                 from /root/.cache/node-gyp/12.15.0/include/node/node_object_wrap.h:26,
                 from ../../nan/nan.h:54,
                 from ../src/deasync.cc:3:
../../nan/nan_object_wrap.h: In destructor ‘virtual Nan::ObjectWrap::~ObjectWrap()’:
../../nan/nan_object_wrap.h:24:25: error: ‘class Nan::Persistent<v8::Object>’ has no member named ‘IsNearDeath’
     assert(persistent().IsNearDeath());
                         ^~~~~~~~~~~

These indicate the version of nan in use is too old to work with Node.js 12 (e.g. https://github.com/nodejs/nan/pull/842). It could be that you're on (or a dependency you are using is on) an old version of deasync as they switched from nan to N-API in deasync@0.1.14.

flynn1973

comment created time in 14 days

issue commentnodejs/node-gyp

node-gyp rebuild error

Can you post the gibberish removed? The warnings you left in the verbose output shouldn't normally cause the build to error out.

flynn1973

comment created time in 14 days

Pull request review commentnodejs/node

Readme updates fishrock123

 use these keys to verify a downloaded file.  Other keys used to sign some previous releases: +* **Jeremiah Senkpiel** &lt;fishrock@keybase.io&gt;+`FD3A5288F042B6850C66B31F09FE44734EB7990E`

Keep this alphabetically sorted?

Fishrock123

comment created time in 15 days

issue commentnodejs/build

ci,libuv: http://ci.nodejs.org/downloads/zos/gyp.tar.gz?

Another reason for using the tarball on z/OS is that the z/OS port of git doesn't support https URLs: https://forum.rocketsoftware.com/t/git-and-https-repositories/482.

bnoordhuis

comment created time in 15 days

Pull request review commentlibuv/libuv

doc: update gyp link

 $ ./out/cmake/uv_run_tests_a  # static library build To build with GYP, first run:  ```bash-$ git clone https://chromium.googlesource.com/external/gyp build/gyp+$ git clone https://github.com/libuv/gyp build/gyp

Chromium's copy of gyp contains patches for z/OS (e.g. https://chromium-review.googlesource.com/c/external/gyp/+/644712/) which are not in https://github.com/nodejs/node/tree/d0413ae8f92aa0591506ff115f21ec0ae2591e62/tools/gyp that was used to seed https://github.com/libuv. This isn't evident from CI as currently the a copy of gyp served from Jenkins (https://github.com/nodejs/build/issues/2172) is used.

bnoordhuis

comment created time in 15 days

pull request commentlibuv/libuv

doc: update gyp link

What is Node’s current upstream? I guess we could just use that since Node has a much larger gyp dependency than we do.

Officially it doesn't have one. There's some work to sync the copies of gyp in nodejs/node (for building Node.js) and nodejs/node-gyp (for building addon modules) (https://github.com/nodejs/node/pull/30563 and https://github.com/nodejs/node-gyp/pull/1975) but neither of those are upstream of each other either. (Somewhat related discussion in node-gyp, https://github.com/nodejs/node-gyp/issues/1791).

bnoordhuis

comment created time in 15 days

issue commentnodejs/build

ci,libuv: http://ci.nodejs.org/downloads/zos/gyp.tar.gz?

cc @nodejs/platform-s390

bnoordhuis

comment created time in 15 days

issue commentnodejs/build

ci,libuv: http://ci.nodejs.org/downloads/zos/gyp.tar.gz?

Does anyone know/remember why things are set up this way?

I have no idea why the macOS builds would be pulling down the http://ci.nodejs.org/downloads/zos/gyp.tar.gz as that's presumably a copy of gyp with patches for z/OS.

$ curl -q --head http://ci.nodejs.org/downloads/zos/gyp.tar.gz | grep Last-Modified
Last-Modified: Wed, 27 Sep 2017 21:43:14 GMT

The above last modified puts this in the timeframe when z/OS support was initially upstreamed to gyp (https://chromium-review.googlesource.com/c/external/gyp/+/644712/). As far as I'm aware none of the z/OS patches for gyp are in Node.js' tools/gyp (which is probably an indication of how often we updated gyp in Node.js), although they did make it into node-gyp (https://github.com/nodejs/node-gyp/pull/1276).

bnoordhuis

comment created time in 15 days

issue commentnodejs/build

libuv: grant CI permissions to collaborator

According to https://ci.nodejs.org/user/erw7/ @erw7 is a member of:

Groups:

  • libuv
  • libuv*Collaborators
  • libuv*windows

so should have been covered by the existing libuv entry.

bnoordhuis

comment created time in 17 days

issue commentnodejs/build

libuv: grant CI permissions to collaborator

I believe that only applies to people in the core libuv team, not @libuv/windows.

Ah right. I could add libuv*Collaborators?

bnoordhuis

comment created time in 17 days

issue commentnodejs/build

libuv: grant CI permissions to collaborator

Do they not fall under the already defined permissions for libuv?

bnoordhuis

comment created time in 17 days

issue commentnodejs/node

NodeJS 12.13.0 CentOS fail compile

Next one will be https://github.com/nodejs/node/pull/31691.

Delagen

comment created time in 17 days

Pull request review commentlibuv/libuv

aix: protect uv_exepath() from uv_set_process_title()

 TEST_IMPL(get_currentexe) {   ASSERT(buffer[0] != '\0');   ASSERT(buffer[1] == '\0'); +  /* Verify uv_exepath is not affected by uv_set_process_title(). */+  r = uv_set_process_title("foobar");+  ASSERT(r == 0);+  size = sizeof(buffer) / sizeof(buffer[0]);

With the exception of the uv_set_process_title() call these lines were copied from earlier in the test. I’ll change those as well for consistency.

richardlau

comment created time in 17 days

pull request commentnodejs/node

v12.16.0 proposal

https://github.com/nodejs/node/pull/31686 should fix one of the failing benchmarks.

MylesBorins

comment created time in 18 days

issue commentlibuv/help

Help with build error under Visual C++ 2017: project file is not generated.

If you set DEBUG_HELPER prior to running vcbuild.bat you’ll get (a lot of) extra output that may help.

boinst

comment created time in 18 days

Pull request review commentnodejs/node

doc: update security release process

  The security release process covers the steps required to plan/implement a security release. This document is copied into the description of the Next-Security Release, and used to track progess on the release. It contains-***TEXT LIKE THIS*** which will be replaced during the release process with-the information described.+Security Release, and used to track progess on the release. It contains ***TEXT+LIKE THIS*** which will be replaced during the release process with the+information described.  ## Planning -* [ ] Open an issue in the private security repo titled `Next Security Release`-  and add this planning checklist to the description.+* [ ] Open an [issue](https://github.com/nodejs-private/node-private) titled+  `Next Security Release`, and put this checklist in the description.  * [ ] Get agreement on the list of vulnerabilities to be addressed:-  * ***LINKS TO VULNS...***+  * ***H1 REPORT LINK***: ***DESCRIPTION*** (***CVE or H1 CVE request link***)+    * v10.x, v12.x: ***LINK to PR URL***+  * ...++* [ ] PR release announcements in [private](https://github.com/nodejs-private/nodejs.org-private):+  * (Use previous PRs as templates, don't forget to update the site banner, and+    the date in the slug so that it will move to the top of the blog list.)+  * [ ] pre-release: ***LINK TO PR***+  * [ ] post-release: ***LINK TO PR***  * [ ] Get agreement on the planned date for the release: ***RELEASE DATE*** -* [ ] Validate that all vulnerabilities have been assigned a CVE. Upstream deps-  such as OpenSSL and NPM will have CVEs, issues reported on H1 may have CVEs,-  otherwise allocate them by following the-  [cve_management_process](https://github.com/nodejs/node/blob/master/doc/guides/cve_management_process.md).+* [ ] Get release team volunteers for all affected lines:+  * v12.x: ***NAME of RELEASER(S)***+  * ... other lines, if multiple releasers -* [ ] Co-ordinate with the Release team members to line up one or more releasers-  to do the releases on the agreed date. Releaser: ***NAME of RELEASER(S)***+## Announcement (one week in advance of the planned release) -* [ ] Prep for the security announcements by getting agreement on drafts (use-  previously announced releases as the template):-  * pre-release: ***LINK TO COMMENT ON THIS ISSUE CONTAINING DRAFT***-  * post-release: ***LINK TO COMMENT ON THIS ISSUE CONTAINING DRAFT***+* [ ] Check that all vulnerabilities are ready for release integration:+  * PRs against all affected release lines or cherry-pick clean+  * Approved+  * Pass `make test`+  * Have CVEs+  * Described in the pre/post announcements -## Announcement (one week in advance of the planned release)+* [ ] Pre-release announcement [email][]: ***LINK TO EMAIL***+  (Get access from existing manager: Ben Noordhuis, Rod Vagg, Michael Dawson) -* [ ] Send pre-release announcement to-  https://groups.google.com/forum/#!forum/nodejs-sec.-  One of the existing managers can give access (Ben-  Noordhuis, Rod Vagg, Michael Dawson). ***LINK TO EMAIL***--* [ ] Post pre-release announcement in vulnerabilities section of Nodejs.org-  blog (https://github.com/nodejs/nodejs.org/tree/master/locale/en/blog/vulnerability).-  Use last pre-release announcement as a template (it includes blog metadata-  such as updates to the banner on the Node.js website to indicate security-  releases are coming).  Submit PR and land immediately. Text was already-  reviewed in security repo.  ***LINK TO BLOG PR AND POST***--* [ ] Open an issue in the build working repository with a notification of the

This should stay? It didn’t happen for the recent security releases and the release ended up delayed due to infra issues.

sam-github

comment created time in 18 days

pull request commentnodejs/node

test: fix test-benchmark-http

Did the same change land on all release lines? If so we should make sure this lands on those too. cc @nodejs/releasers

Trott

comment created time in 18 days

Pull request review commentnodejs/node

test,dns: add coverage for dns exception

 require('../common'); const assert = require('assert'); const { internalBinding } = require('internal/test/binding'); const cares = internalBinding('cares_wrap');-const EPERM = internalBinding('constants').os.errno.EPERM;+const EPERM = internalBinding('uv').UV_EPERM;
const { UV_EPERM } = internalBinding('uv');

or

const { UV_EPERM: EPERM } = internalBinding('uv');

?

Trott

comment created time in 18 days

Pull request review commentnodejs/node

test,dns: add coverage for dns exception

 const dnsPromises = require('dns').promises;  // Stub cares to force an error so we can test DNS error code path. // Returning a negative value means the error corresponding to the postiive-// value. (This is to distinguish system errors from Node.js errors.)+// value. (This is the convention libuv uses for reporting errors.) cares.ChannelWrap.prototype.queryA = () => -EPERM;

Since this test is already exposing internals we could use the map from the internal uv binding rather than the one from constants.

Trott

comment created time in 18 days

issue commentnodejs/build

Platform requirements for Node.js 14

@richardlau do you know why we officially support AIX7.2+, but we build on AIX7.1?

We build on AIX 7.1 because (a) we don't have many AIX release machines (is it just the one?) and (b) Node.js 10 is supported on AIX 7.1. At the time we wrote the supported AIX versions we were still releasing and testing on AIX 6.1(!) due to lack of systems.

* Replace ubuntu 16.04

We already have a full set of 18.04 OS levels in CI, do you mean remove Ubuntu 16.04?

It looks like 16.04 is LTS, supported to 2025, so no need to drop it for EOL reasons AFAICT.

Sorry, misread the support dates. I meant the release machine for linux-armv7l but if Ubuntu 16.04 is supported for the duration of Node.js 14 let's keep it as-is.

richardlau

comment created time in 18 days

issue commentnodejs/build

Platform requirements for Node.js 14

"tested on column" needs filling in but I wanted to submit this before I leave the office today.

richardlau

comment created time in 18 days

issue openednodejs/build

Platform requirements for Node.js 14

Let's try to sort out the platform requirements for Node.js 14 ahead of the release in April. Node.js 14 is scheduled to be released in April 2020 and End-of-Life in April 2023.

I'll make a start by filling in what we're currently doing for master/Node.js 13. Please help to fill in the table below, discuss questions raised and raise another other questions for discussion. We primarily need to identify what needs changes to build infra (e.g. updating the macOS release machines) so we can try to avoid a last minute rush.

cc @nodejs/platform-aix @nodejs/platform-arm @nodejs/platform-macos @nodejs/platform-ppc @nodejs/platform-s390 @nodejs/platform-smartos @nodejs/platform-windows @nodejs/releasers @nodejs/v8-update

Based on https://github.com/nodejs/node/blob/master/BUILDING.md, https://github.com/nodejs/build/blob/master/jenkins/scripts/VersionSelectorScript.groovy we have:

What we build and test on

Only current Tier 1 and Tier 2 platforms shown.

os-arch release machine tested on supported on
aix-ppc64 AIX 7.1 TL05 on PPC64BE with GCC 6 AIX >= 7.2 TL02
darwin-x64 ~macOS 10.11, Xcode Command Line Tools 10 with -mmacosx-version-min=10.10~<br/>macOS 15 ? macOS >= 10.11
linux-arm64 CentOS 7 with devtoolset-6 / GCC 6 kernel >= 4.5, glibc >= 2.17
linux-armv7l Cross-compiled on Ubuntu 16.04 x64 with custom GCC toolchain kernel >= 4.14, glibc >= 2.24
linux-ppc64le CentOS 7 with devtoolset-6 / GCC 6 >=Power 8, kernel >= 3.10.0, glibc >= 2.17
linux-s390x RHEL 7 with devtoolset-6 / GCC 6 kernel >= 3.10.0, glibc >= 2.17
linux-x64 CentOS 7 with devtoolset-6 / GCC 6 kernel >= 3.10, glibc >= 2.17
sunos-x64 SmartOS 18 with GCC 7 >= 18
win-x64 and win-x86 Windows 2012 R2 (x64) with Visual Studio 2017 >= ~Windows 7/2008 R2/2012 R2~<br/>Windows 8/2012 R2?

Questions/actions

  • [ ] macOS release machine change for notarization (probably need to change the release machine for existing versions of Node.js too)
  • [ ] Windows 7/2008 R2 are no longer supported so we should remove those from BUILDING.md
  • [ ] Python 3 (i.e. are we ready to drop support for the out of support Python 2?)
  • [ ] Replace Ubuntu 16.04?

created time in 18 days

issue commentnodejs/build

Node.js Foundation Build WorkGroup Meeting 2020-02-11

I've added the two issues re. macs (MacStadium and nearForm) to the agenda.

mhdawson

comment created time in 18 days

push eventrichardlau/libuv

Richard Lau

commit sha 309730bde032669e8c22da6b3a0adcb5dfe76401

aix,ibmi,zos: extract common search_path function Extract common code for finding a program on the current PATH.

view details

push time in 19 days

issue commentlibuv/libuv

aix: uv_set_process_title() makes uv_exepath() fail

PR: https://github.com/libuv/libuv/pull/2677

bnoordhuis

comment created time in 19 days

PR opened libuv/libuv

aix: protect uv_exepath() from uv_set_process_title()

Store a copy of the original argv[0] to protect uv_exepath() against uv_set_process_title() changing the value of argv[0].

Since uv_exepath() is in src/unix/aix-common.c. cc @dmabupt re. IBMi

Changes assume it is possible for uv_setup_args() not to be called prior to uv_exepath() being called (current documentation for uv_setup_args() says that it is "Required for getting / setting the process title.") in which case the existing code is used. Our test runner always calls uv_setup_args() prior to running any tests.

+64 -4

0 comment

5 changed files

pr created time in 19 days

push eventrichardlau/libuv

Richard Lau

commit sha eac7fd8679c55f8ba4ff503e776d66c511b45cb9

aix: protect uv_exepath() from uv_set_process_title() Store a copy of the original argv[0] to protect `uv_exepath()` against `uv_set_process_title()` changing the value of argv[0].

view details

push time in 19 days

push eventrichardlau/libuv

Richard Lau

commit sha c6ee1fb8f8dc9f26bff7fcbfb95da0b81bf81d5a

ibmi: move uv_setup_args to src/unix/ibmi.c Minor refactor to prepare for a change to `uv_exepath()` in `src/unix/aix-common.c`.

view details

Richard Lau

commit sha f2a9670fbc95ac87c599ad271340e75e2aea1547

aix: protect uv_exepath() from uv_set_process_title() Store a copy of the original argv[0] to protect `uv_exepath()` against `uv_set_process_title()` changing the value of argv[0].

view details

push time in 19 days

create barnchrichardlau/libuv

branch : aix-exepath

created branch time in 19 days

Pull request review commentnodejs/TSC

doc: add minutes for 2020-02-05

+# Node.js Technical Steering Committee (TSC) Meeting 2020-02-05++## Links++* **Recording**: https://www.youtube.com/watch?v=p5fIPf94GuY+* **GitHub Issue**: https://github.com/nodejs/TSC/issues/810+* **Minutes Google Doc**: https://docs.google.com/document/d/1OmKotKXE12zGi3sTa8EkGdM4Ocpkrgy2M8BuFhTIK_0++## Present++* Anna Henningsen @addaleax (TSC)+* Beth Griggs @BethGriggs (TSC)+* Сковорода Никита Андреевич @ChALkeR (TSC)+* Daniel Bevenius @danbev (TSC)+* James Snell @jasnell (TSC)+* Matteo Collina @mcollina (TSC)+* Michaël Zasso @targos (TSC)+* Rich Trott @Trott (TSC)+* Sam Roberts @sam-github (TSC)+* Tobias Nießen @tniessen (TSC)+* Vladimir de Turckheim (Guest)++## Agenda++### Announcements++* Nominating Ruben Bridgewater (@BridgeAR) to the TSC [#811](https://github.com/nodejs/TSC/issues/811)+  * Will be invited as an observer to the next meeting.

Opened https://github.com/nodejs/create-node-meeting-artifacts/pull/83 to add him to the invited list. Not sure if anyone other than @mhdawson can merge it.

BethGriggs

comment created time in 19 days

pull request commentnodejs/create-node-meeting-artifacts

template: add Ruben Bridgewater to TSC observers

FYI @BridgeAR

richardlau

comment created time in 19 days

PR opened nodejs/create-node-meeting-artifacts

template: add Ruben Bridgewater to TSC observers

Refs: https://github.com/nodejs/TSC/issues/811 Refs: https://github.com/nodejs/TSC/pull/814

+1 -1

0 comment

1 changed file

pr created time in 19 days

push eventrichardlau/create-node-meeting-artifacts

Richard Lau

commit sha be06801b929128744169ad118253fbf14dfc3cd0

template: add Ruben Bridgewater to TSC observers

view details

push time in 19 days

push eventrichardlau/node-1

Guy Bedford

commit sha 0f96dc266fd0cd8c1baa82ce7eb951c11b29a331

esm: import.meta.resolve with nodejs: builtins PR-URL: https://github.com/nodejs/node/pull/31032 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

ConorDavenport

commit sha d4660aba6324096198bc17772ba16fce6259967d

src: change Fill() to use ParseArrayIndex() Changed Fill() to use ParseArrayIndex() when getting start and end of buffers instead of Uint32Value, supporting buffers of greater than 2**32 Fixes: https://github.com/nodejs/node/issues/31514 Co-Authored-By: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/31591 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha d435dc47f3d303ff1669fa711a0af287a9df973a

test: unset NODE_OPTIONS for cctest The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: https://github.com/nodejs/node/issues/31585 PR-URL: https://github.com/nodejs/node/pull/31594 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

bcoe

commit sha 3f70d7720333dd0996dfd6ca21beb4a24d561e1b

fs: set path when mkdir recursive called on file PR-URL: https://github.com/nodejs/node/pull/31607 Fixes: https://github.com/nodejs/node/issues/28015 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Rusty Conover

commit sha ee9e689df2dd219084820d1adb7a97d104726794

net: track state of setNoDelay() and prevent unnecessary system calls The state of .setNoDelay() is now tracked and code will prevent repeated system calls to setsockopt() when the value has already been set to the desired value for the socket. Change and expand the appropriate test. PR-URL: https://github.com/nodejs/node/pull/31543 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 60de60a0ce21378c80353489759dc70f05156cc7

src: remove unused `Worker::child_port_` member This fixes a compiler warning introduced in 9225939528590f652e6. PR-URL: https://github.com/nodejs/node/pull/31599 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Kirill Fomichev

commit sha 018c3e8949e925efc8077801d44c2b2feb974750

perf_hooks: add property flags to GCPerformanceEntry PR-URL: https://github.com/nodejs/node/pull/29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

view details

James M Snell

commit sha 2d8febceef35bdd52624028bdee2e0d58830ae7f

fs: deprecate closing FileHandle on garbage collection Closing the FileHandle on garbage collection is a bad practice. Runtime deprecate and indicate that an error will be thrown in the future. PR-URL: https://github.com/nodejs/node/pull/28396 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha fb6df3bfac8ca38a7012eabf0563d7a799ce1acc

fs: validate the input data to be of expected types The input was not validated so far and that caused unwanted side effects. E.g., `undefined` became the string `'undefined'`. It was expected to fail or to end up as empty string. Now all input is validated to be either some type of array buffer view or a string. That way it's always clear what the user intents. PR-URL: https://github.com/nodejs/node/pull/31030 Fixes: https://github.com/nodejs/node/issues/31025 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Juan José Arboleda

commit sha afe353061b3c0543ebaa40668f27c12384e6c5d6

doc: fs.write is not longer coercing strings PR-URL: https://github.com/nodejs/node/pull/31030 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Ruben Bridgewater

commit sha f295ba5d2ce13c2a53f405d5915ad920431331be

test: refactor test-readline-interface.js This reduces the code lines required to run the tests by abstracting the constructor call. It also moves tests out of a for loop that where miss placed. PR-URL: https://github.com/nodejs/node/pull/31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 1fb4bd1fc4b970c5154159ad6734bc722052af3b

test: abstract common assertions in readline-interface test PR-URL: https://github.com/nodejs/node/pull/31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 6a6279ef2a38c17a761cc15366e615c620328587

doc: add AsyncResource + Worker pool example Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: https://github.com/nodejs/node/pull/31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Robert Nagy

commit sha 234de6f1fd90ece1edc1a12d989ab0f15a1f19b8

stream: fix finished w/ 'close' before 'finish' Emitting 'close' before 'finish' on a Writable should result in a premature close error. PR-URL: https://github.com/nodejs/node/pull/31534 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha c1da4e4aa4583c14f87c8d230ce7580f3b157ff0

src: fix inspecting `MessagePort` from `init` async hook During the `init()` async hook, the C++ object is not finished creating yet (i.e. it is an `AsyncWrap`, but not yet a `HandleWrap` or `MessagePort`). Accessing the `handle_` field is not valid in that case. However, the custom inspect function for `MessagePort`s calls `HasRef()` on the object, which would crash when the object is not fully constructed. Fix that by guarding the access of the libuv handle on that condition. PR-URL: https://github.com/nodejs/node/pull/31600 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Conor ONeill

commit sha 7e911d8b03a838e5ac6bb06c5b313533e89673ef

doc: add example to fs.promises.readdir PR-URL: https://github.com/nodejs/node/pull/31552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 907c07fa850e128c695482cd47554b5bce5e4b0c

stream: move _writableState.buffer to EOL API was deprecated back in the 0.11 days. PR-URL: https://github.com/nodejs/node/pull/31165 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

James M Snell

commit sha bffa5044c576003198ccfee5a751c23036d0744f

crypto: move pbkdf2 without digest to EOL API has been being incrementally deprecated since 6.0.0 PR-URL: https://github.com/nodejs/node/pull/31166 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha ec0dd6fa1cfa03b3983419acedb27ef95d297c82

lib: move GLOBAL and root aliases to EOL GLOBAL and root have been long deprecated. PR-URL: https://github.com/nodejs/node/pull/31167 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha ab4115f17cf2859f336b3c0588d2bf9eca0e65b8

os: move tmpDir() to EOL The tmpDir alias was deprecated in 7.0.0 PR-URL: https://github.com/nodejs/node/pull/31169 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

push time in 19 days

pull request commentnodejs/node

tools: unify make-v8.sh for ppc64le and s390x

This needs to land in all supported release lines tested on before we can reenable ccache on the centos7-ppcle machines (i.e. reland nodejs/build#1927 which was backed out because the divergent ppc64le and s390x paths through this script broke node-test-commit-v8-linux (nodejs/build#1940)).

@nodejs/releasers Any objections to me cherry-picking the commit across to the staging branches?

richardlau

comment created time in 19 days

pull request commentnodejs/node

tools: unify make-v8.sh for ppc64le and s390x

Landed in https://github.com/nodejs/node/commit/d213f21c72f77da6f66f2723b300da27740a0a90.

richardlau

comment created time in 19 days

PR merged nodejs/node

tools: unify make-v8.sh for ppc64le and s390x V8 Engine author ready lts-watch-v10.x lts-watch-v12.x ppc s390 tools

Refactor tools/make-v8.sh to minimise differences between the ppc64le and s390x paths to allow us to enable ccache on the ppc64le machines in the CI.

This needs to land in all supported release lines tested on before we can reenable ccache on the centos7-ppcle machines (i.e. reland https://github.com/nodejs/build/pull/1927 which was backed out because the divergent ppc64le and s390x paths through this script broke node-test-commit-v8-linux (https://github.com/nodejs/build/issues/1940)).

Refs: https://github.com/nodejs/build/pull/1927 Refs: https://github.com/nodejs/build/issues/1940

cc @nodejs/platform-ppc @nodejs/platform-s390

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+12 -19

3 comments

1 changed file

richardlau

pr closed time in 19 days

push eventnodejs/node

Richard Lau

commit sha d213f21c72f77da6f66f2723b300da27740a0a90

tools: unify make-v8.sh for ppc64le and s390x Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: https://github.com/nodejs/node/pull/31628 Refs: https://github.com/nodejs/build/pull/1927 Refs: https://github.com/nodejs/build/issues/1940 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

push time in 19 days

push eventrichardlau/node-1

Anna Henningsen

commit sha 60de60a0ce21378c80353489759dc70f05156cc7

src: remove unused `Worker::child_port_` member This fixes a compiler warning introduced in 9225939528590f652e6. PR-URL: https://github.com/nodejs/node/pull/31599 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Kirill Fomichev

commit sha 018c3e8949e925efc8077801d44c2b2feb974750

perf_hooks: add property flags to GCPerformanceEntry PR-URL: https://github.com/nodejs/node/pull/29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

view details

James M Snell

commit sha 2d8febceef35bdd52624028bdee2e0d58830ae7f

fs: deprecate closing FileHandle on garbage collection Closing the FileHandle on garbage collection is a bad practice. Runtime deprecate and indicate that an error will be thrown in the future. PR-URL: https://github.com/nodejs/node/pull/28396 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha fb6df3bfac8ca38a7012eabf0563d7a799ce1acc

fs: validate the input data to be of expected types The input was not validated so far and that caused unwanted side effects. E.g., `undefined` became the string `'undefined'`. It was expected to fail or to end up as empty string. Now all input is validated to be either some type of array buffer view or a string. That way it's always clear what the user intents. PR-URL: https://github.com/nodejs/node/pull/31030 Fixes: https://github.com/nodejs/node/issues/31025 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Juan José Arboleda

commit sha afe353061b3c0543ebaa40668f27c12384e6c5d6

doc: fs.write is not longer coercing strings PR-URL: https://github.com/nodejs/node/pull/31030 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Ruben Bridgewater

commit sha f295ba5d2ce13c2a53f405d5915ad920431331be

test: refactor test-readline-interface.js This reduces the code lines required to run the tests by abstracting the constructor call. It also moves tests out of a for loop that where miss placed. PR-URL: https://github.com/nodejs/node/pull/31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 1fb4bd1fc4b970c5154159ad6734bc722052af3b

test: abstract common assertions in readline-interface test PR-URL: https://github.com/nodejs/node/pull/31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 6a6279ef2a38c17a761cc15366e615c620328587

doc: add AsyncResource + Worker pool example Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: https://github.com/nodejs/node/pull/31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Robert Nagy

commit sha 234de6f1fd90ece1edc1a12d989ab0f15a1f19b8

stream: fix finished w/ 'close' before 'finish' Emitting 'close' before 'finish' on a Writable should result in a premature close error. PR-URL: https://github.com/nodejs/node/pull/31534 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha c1da4e4aa4583c14f87c8d230ce7580f3b157ff0

src: fix inspecting `MessagePort` from `init` async hook During the `init()` async hook, the C++ object is not finished creating yet (i.e. it is an `AsyncWrap`, but not yet a `HandleWrap` or `MessagePort`). Accessing the `handle_` field is not valid in that case. However, the custom inspect function for `MessagePort`s calls `HasRef()` on the object, which would crash when the object is not fully constructed. Fix that by guarding the access of the libuv handle on that condition. PR-URL: https://github.com/nodejs/node/pull/31600 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Conor ONeill

commit sha 7e911d8b03a838e5ac6bb06c5b313533e89673ef

doc: add example to fs.promises.readdir PR-URL: https://github.com/nodejs/node/pull/31552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 907c07fa850e128c695482cd47554b5bce5e4b0c

stream: move _writableState.buffer to EOL API was deprecated back in the 0.11 days. PR-URL: https://github.com/nodejs/node/pull/31165 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

James M Snell

commit sha bffa5044c576003198ccfee5a751c23036d0744f

crypto: move pbkdf2 without digest to EOL API has been being incrementally deprecated since 6.0.0 PR-URL: https://github.com/nodejs/node/pull/31166 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha ec0dd6fa1cfa03b3983419acedb27ef95d297c82

lib: move GLOBAL and root aliases to EOL GLOBAL and root have been long deprecated. PR-URL: https://github.com/nodejs/node/pull/31167 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha ab4115f17cf2859f336b3c0588d2bf9eca0e65b8

os: move tmpDir() to EOL The tmpDir alias was deprecated in 7.0.0 PR-URL: https://github.com/nodejs/node/pull/31169 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Joyee Cheung

commit sha 0effc9845f74e7351487644cbd1691196000b93e

doc: ask more questions in the bug report template Inspired by the defect report template of the V8 issue tracker PR-URL: https://github.com/nodejs/node/pull/31611 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Beth Griggs

commit sha f0f2583c912d4c7abf6fb5a9ccd380976f1ab092

2020-02-06, Version 13.8.0 (Current) This is a security release. Vulnerabilities fixed: * **CVE-2019-15606**: HTTP header values do not have trailing OWS trimmed. * **CVE-2019-15605**: HTTP request smuggling using malformed Transfer-Encoding header. * **CVE-2019-15604**: Remotely trigger an assertion on a TLS server with a malformed certificate string. Also, HTTP parsing is more strict to be more secure. Since this may cause problems in interoperability with some non-conformant HTTP implementations, it is possible to disable the strict checks with the `--insecure-http-parser` command line flag, or the `insecureHTTPParser` http option. Using the insecure HTTP parser should be avoided. PR-URL: https://github.com/nodejs-private/node-private/pull/196

view details

Beth Griggs

commit sha e65ae4278578e51761bf9253a7c68ade0f9b897c

2020-02-06, Version 12.15.0 'Erbium' (LTS) This is a security release. Vulnerabilities fixed: * **CVE-2019-15606**: HTTP header values do not have trailing OWS trimmed. * **CVE-2019-15605**: HTTP request smuggling using malformed Transfer-Encoding header. * **CVE-2019-15604**: Remotely trigger an assertion on a TLS server with a malformed certificate string. Also, HTTP parsing is more strict to be more secure. Since this may cause problems in interoperability with some non-conformant HTTP implementations, it is possible to disable the strict checks with the `--insecure-http-parser` command line flag, or the `insecureHTTPParser` http option. Using the insecure HTTP parser should be avoided. PR-URL: https://github.com/nodejs-private/node-private/pull/197

view details

Beth Griggs

commit sha d602e586bf2baf5889586bde8e072e556db2b273

2020-02-06, Version 10.19.0 'Dubnium' (LTS) This is a security release. Vulnerabilities fixed: * **CVE-2019-15606**: HTTP header values do not have trailing OWS trimmed. * **CVE-2019-15605**: HTTP request smuggling using malformed Transfer-Encoding header. * **CVE-2019-15604**: Remotely trigger an assertion on a TLS server with a malformed certificate string. Also, HTTP parsing is more strict to be more secure. Since this may cause problems in interoperability with some non-conformant HTTP implementations, it is possible to disable the strict checks with the `--insecure-http-parser` command line flag, or the `insecureHTTPParser` http option. Using the insecure HTTP parser should be avoided. PR-URL: https://github.com/nodejs-private/node-private/pull/198

view details

James M Snell

commit sha e001710219906b45bb5ac94d7e9cb4b56a83c134

meta: fix collaborator list errors in README.md Add missing `-` characters in the list. PR-URL: https://github.com/nodejs/node/pull/31655 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 19 days

Pull request review commentnodejs/node

test: add test-dns-promises-lookupService

+'use strict';++const common = require('../common');++const assert = require('assert');+const dnsPromises = require('dns').promises;++dnsPromises.lookupService('127.0.0.1', 22).then(common.mustCall((result) => {+  assert.strictEqual(result.service, 'ssh');+  assert.strictEqual(typeof result.hostname, 'string');+  assert.notStrictEqual(result.hostname.length, 0);+}));++assert.rejects(+  () => dnsPromises.lookupService('0.0.0.0', 22),+  { code: /^(?:ENOTFOUND|EAI_AGAIN)$/ }+);

Maybe use one of the reserved IP addresses (e.g. https://tools.ietf.org/html/rfc2606, https://tools.ietf.org/html/rfc5737)?

Trott

comment created time in 19 days

Pull request review commentnodejs/node

worker_threads: allow URL in Worker constructor

 class Worker extends EventEmitter {       }       argv = options.argv.map(String);     }-    if (!options.eval) {-      if (!path.isAbsolute(filename) && !/^\.\.?[\\/]/.test(filename)) {-        throw new ERR_WORKER_PATH(filename);++    let url;+    if (filename instanceof URL) {+      if (filename.protocol !== 'file:') {+        throw new ERR_WORKER_UNSUPPORTED_PROTOCOL(filename.protocol);+      }+      if (options.eval) {+        throw new ERR_INVALID_ARG_VALUE(+          'options.eval',+          options.eval,+          'must be false when \'filename\' is a URL object'+        );+      }+      url = filename;+      filename = fileURLToPath(url);+    } else {+      validateString(filename, 'filename');+      if (!options.eval) {+        if (!path.isAbsolute(filename) && !/^\.\.?[\\/]/.test(filename)) {+          throw new ERR_WORKER_PATH(filename);+        }+        filename = path.resolve(filename);       }-      filename = path.resolve(filename); +      url = options.eval ? null : pathToFileURL(filename);+    }

Reuse https://github.com/nodejs/node/blob/884e287199901853a30781a0b398e6c3e4a07eb1/lib/internal/fs/utils.js#L577-L581 for consistency (e.g. checks, errors thrown) with fs?

aduh95

comment created time in 19 days

issue commentnodejs/build

Lockdown of CI for Feb 2020 security releases

I guess we should update the guide.

BethGriggs

comment created time in 19 days

more