profile
viewpoint

ibmruntimes/v8ppc 92

Port of Google V8 javascript engine to PowerPC®

ibmruntimes/node 71

This repository hosts the ports of Node.js for IBM platforms not yet upstreamed to the community (i.e. z/OS port). For community support for Linux On Z, Linux on P or AIX, please visit https://github.com/nodejs/help. Visit http://ibm.biz/nodejs-zos-support for z/OS support content, including how open PMRs and buy IBM Service and Support.

nodejs/core-validate-commit 41

Validate commit messages for Node.js core

ibmruntimes/v8z 40

Port of Google V8 JavaScript engine to z/OS. The Linux on Z port is maintained in the community: https://chromium.googlesource.com/v8/v8.git

ibmruntimes/chcp 5

This library provides native bindings for Windows APIs

gireeshpunathil/report 4

diagnostic report lab material

IBM/nodejs-in-the-cloud 4

Node.js in the Cloud tutorial

richardlau/build 1

Better build and test infra for Node.

richardlau/core-validate-commit 1

Validate commit messages for Node.js core

richardlau/GYP 1

Generate You Projects

Pull request review commentlibuv/libuv

unix: handle src, dest same in uv_fs_copyfile()

 TEST_IMPL(fs_copyfile) {   r = uv_fs_copyfile(NULL, &req, src, src, 0, NULL);   ASSERT(r == 0);   uv_fs_req_cleanup(&req);+  /* Verify that the src file did not get truncated. */+  r = uv_fs_stat(NULL, &req, src, NULL);+  ASSERT(r == 0);+  ASSERT(req.statbuf.st_size == 12);

Use the newer macros?

cjihrig

comment created time in 18 minutes

Pull request review commentnodejs/node

doc: add release key for Ruy Adorno

 gpg --keyserver pool.sks-keyservers.net --recv-keys C82FA3AE1CBEDC6BE46B9360C43C gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273792F7D83545D gpg --keyserver pool.sks-keyservers.net --recv-keys A48C2BEE680E841632CD4E44F07496B3EB3C1762 gpg --keyserver pool.sks-keyservers.net --recv-keys B9E2F5981AA6E0CD28160D9FF13993A75599653C+gpg --keyserver pool.sks-keyservers.net --recv-keys 108F52B48DB57BB0CC439B2997B01419BD92F80A

These are in the same order as listed above so your key should be above Shelley’s.

ruyadorno

comment created time in 25 minutes

issue commentnodejs/build

junit encoding configuration incorrect?

tap2junit source is https://github.com/nodejs/tap2junit

vtjnash

comment created time in 6 hours

issue commentnodejs/node

fs.copyFile creates empty file if source and destination are the same

@iandrc I think the copyfile behaviour is mostly in libuv. If I remember correctly the macOS implementation changed at some point (https://github.com/libuv/libuv/pull/2233) in libuv (also see follow up https://github.com/libuv/libuv/pull/2578).

At the very least it sounds like we should have a test for this (either in Node.js and/or libuv).

spikeburton

comment created time in 6 hours

issue commentnodejs/node

Special treatment for package.json resolution and exports?

FWIW there was concern raised before ESM was unflagged in Node.js 12 and it was discussed in the Release WG and TSC (both meetings were recorded) prior to going ahead. It was acknowledged by people involved with the modules team that there was risk that the change could result in an observable change in behaviour.

ctavan

comment created time in 7 hours

PR opened nodejs/build

ansible: install openjdk via yum for IBM i ansible platform:ibmi

Install OpenJDK Java via the yum repository for IBM i.

WIP at the moment. Have run against test-iinthecloud-ibmi72-ppc64_be-2 but not run any builds yet. Had to pass -Djava.net.preferIPv4Stack=true to the Jenkins agent start command to get the agent to start up (otherwise the agent would fail to start with java.net.SocketException: Protocol driver not attached.). cc @ThePrez

+17 -25

0 comment

5 changed files

pr created time in 12 hours

push eventrichardlau/build

Richard Lau

commit sha b6c3488d0a64fdbc78492813c85c6946fef39a35

doc: remove node-chakracore from security matrix (#2399) The nodejs/node-chakracore team has been deleted and no longer exists. Remove from the captured normal security matrix. Refs: https://github.com/nodejs/admin/issues/526

view details

Richard Lau

commit sha bb5848a734a40d0e185c06d1698d429c0abc7c40

ansible: refactor install AdoptOpenJDK Java tasks (#2398) * ansible: refactor install AdoptOpenJDK Java tasks Replace several duplicated tasks for installing Java from builds provided by AdoptOpenJDK with a set of common tasks. Remove hardcoded Java release specific paths.

view details

Mary Marchini

commit sha 838d0ecf283f295c6d8e611a7f9d29229a546b87

docs: update .mailmap for mmarchini

view details

Mary Marchini

commit sha 0b6eceb654b71c39debe2b4cc23759583783d579

docs: update mmarchini contact info

view details

Richard Lau

commit sha 9bff7852a0180386830be4870dfaa477fa7b6b14

ansible: install openjdk via yum for IBM i Install OpenJDK Java via the yum repository for IBM i.

view details

push time in 12 hours

issue closednodejs/build

Give libuv collaborators permission to edit libuv job configuration in Jenkins

The current permissions for the libuv CI jobs looks like this: image

(I'm not aware of the history behind why there are individuals in the access table)

I would like to propose giving libuv collaborators (libuv*Collaborators) permission to configure the jobs. This would be in a similar manner to what we have documented for working groups (https://github.com/nodejs/build/blob/master/GOVERNANCE.md#jenkins-job-configuration-access) with libuv the group with the "ability to run/cancel jobs" (as currently the case) and libuv*Collaborators "ability to modify jobs".

Related is an effort to trim down libuv*Collaborators to active collaborators (https://github.com/libuv/libuv/pull/2682#issuecomment-589758303) which would reduce the number of people in the group who would be given the additional permission.

cc @nodejs/libuv

closed time in 14 hours

richardlau

issue commentnodejs/build

Give libuv collaborators permission to edit libuv job configuration in Jenkins

It doesn't sound like there's much enthusiasm for this so I'll close.

richardlau

comment created time in 14 hours

issue commentnodejs/node

Wrong behaviour of console.log in node 10

I vaguely remembered https://github.com/nodejs/node/pull/29592 (not specifics, just the general gist of it) and CTRL+F searched through https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md for console and then util. Probably not the most efficient way.

If those two PRs (or one of them) were the fix then it's highly unlikely we'd backport to 10.x.

oscaretu

comment created time in a day

Pull request review commentnodejs/node

Add EventTarget WPT test AddEventListenerOptions-once

+// Manually converted from https://github.com/web-platform-tests/wpt/blob/master/dom/events/CustomEvent.html+// in order to define the `document` ourselves++// Flags: --expose-internals++'use strict';++// eslint-disable-next-line no-unused-vars+const common = require('../common');

If this is going to be unused then this should just be

require('../common');
Ethan-Arrowood

comment created time in a day

issue commentnodejs/node

Wrong behaviour of console.log in node 10

Glancing through the changelog for 12, I'd guess https://github.com/nodejs/node/pull/25046 (explicitly marked (dont-land-on-v10.x) and/or https://github.com/nodejs/node/pull/23162 (markedsemver-major`, see also discussion in https://github.com/nodejs/node/pull/29592) could be at play.

To set some expectations, Node.js 10.x is in maintenance now, which means there are no scheduled further updates planned (it will continue to get critical security fixes up until it's End-of-Life in April 2021). If there are small, low risk changes the Release WG may allow them to land on the v10.x-staging branch.

oscaretu

comment created time in a day

issue commentnodejs/node-gyp

TODO: use local headers if available (was: Why do headers need to be downloaded?)

I think it would be desirable to have an environment variable to specify a fallback location of the node sources or the location of the tarball. Especially being able to avoid network access would be nice.

node-gyp will convert any environment variable whose name begins with npm_config_ to the equivalent option. So you should already be able to set e.g. npm_config_nodedir or npm_config_tarball.

https://github.com/nodejs/node-gyp/blob/aaf33c30296ddb71c12e2b587a5ec5add3f8ace0/lib/node-gyp.js#L136-L154

bdharrington7

comment created time in a day

pull request commentnodejs/node

doc: update fs.watch() availability for IBM i

cc @nodejs/platform-ibmi

iandrc

comment created time in 2 days

pull request commentnodejs/github-bot

chore(lite-ci): disable lite-ci

FWIW I made a small fix to the lite-ci pipeline: nodejs/node#34531 (comment)

I think we should just remove lite-ci from Jenkins. Since we started adding more Actions it doesn't bring any value to us and it ends up being one more Jenkins job to maintain (I'm not even sure if it is working, the last run took only five minutes).

I have no objections. I think the only reasons people run lite-ci is they're either not up to date with policy (just Actions are adequate for doc-only PRs) or are trying to silence git node land ... (which itself hasn't caught up with policy for doc-only PRs when it checks for CI runs).

(five minutes is plausible, the lite job only runs the linters and build/test on LinuxONE which can complete that quickly if there are no code changes and a populated ccache.)

mmarchini

comment created time in 2 days

pull request commentnodejs/Release

doc: add @ruyadorno to releasers

Should this also be in sync with people that have release keys https://github.com/nodejs/node/#release-keys

@ruyadorno Friendly reminder to PR your GPG key into the Node.js readme and docker-node as per https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers

richardlau

comment created time in 2 days

Pull request review commentnodejs/node

tools: fix C++ import checker argument expansion

 def is_valid(file_name):     return valid  if __name__ == '__main__':-  files = glob.iglob(sys.argv[1] if len(sys.argv) > 1 else 'src/*.cc')+  if len(sys.argv) > 1:+    files = []+    for pattern in sys.argv[1:]:+      files = itertools.chain(files, glob.iglob(pattern))+  else:+    files = glob.iglob('src/*.cc')   sys.exit(0 if all(map(is_valid, files)) else 1)

I think what may be happening in the CI is that all() is short circuiting and is_valid doesn't run on all of the files returned by the glob(s).

  sys.exit(0 if all(list(map(is_valid, files))) else 1)

may fix that, or there may be a more Pythonic way of ensuring we run the function against every item returned by the iterator(s) to get all the warnings printed. cc @nodejs/python

addaleax

comment created time in 2 days

push eventrichardlau/node-1

Richard Lau

commit sha 0f8778ce355a598288c85270f46e5115109001ab

fixup! temp debug

view details

push time in 2 days

push eventrichardlau/node-1

Richard Lau

commit sha 98872a987abbe4944a3a5c6e5fc901446b2cb8ac

fixup! temp debug

view details

push time in 2 days

PR opened richardlau/node-1

Checkimports

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+11 -11

0 comment

7 changed files

pr created time in 2 days

push eventrichardlau/node-1

Richard Lau

commit sha 37f2d44e8ca749a07aa8f2ff8bc28a75e8056736

temp debug

view details

push time in 2 days

push eventrichardlau/node-1

Denys Otrishko

commit sha 62198d2d17002246e317558d0fcb6342cd07135b

http2: avoid unnecessary buffer resize Refs: https://github.com/nodejs/node/pull/34315 Refs: https://github.com/nodejs/node/pull/30351 PR-URL: https://github.com/nodejs/node/pull/34480 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

James M Snell

commit sha 2fb92f4cc63d8538e6df998ad0848d74edd6085b

quic: remove extraneous unused debug property PR-URL: https://github.com/nodejs/node/pull/34498 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 06664298fa07442b5be6dbc891ea999f6c9e7d28

quic: remove no-longer relevant TODO statements PR-URL: https://github.com/nodejs/node/pull/34498 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 1f94b89309bcd56a2883cd1b0eb2db610251095e

quic: refactor ocsp to use async function rather than event/callback PR-URL: https://github.com/nodejs/node/pull/34498 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

gengjiawen

commit sha ccbd1d5efa4cc6232f2be434c9004d90ac60af72

build: add quic to github action PR-URL: https://github.com/nodejs/node/pull/34336 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

gengjiawen

commit sha 7a5fbafe960d54af88b113afd6c78d2a29420cf9

quic: fix build for macOS PR-URL: https://github.com/nodejs/node/pull/34336 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 6fd09e4f3616f5f0bb9c82b0656899bf2f79f0e7

Revert "doc: move ronkorving to emeritus" This reverts commit c5ef4389ab8bd4a67ada950158cfcf2084ef9863. Ron emailed asking to be reinstated. PR-URL: https://github.com/nodejs/node/pull/34507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Andrey Pechkurov

commit sha 53870ddeac8b115f7bba070c2fcd0f5e31ecc9da

async_hooks: optimize fast-path promise hook for ALS Remove unnecessary native-to-JS code switches in fast-path for PromiseHooks. Those switches happen even if a certain type of hook (say, before) is not installed, which may lead to sub-optimal performance in the AsyncLocalStorage scenario, i.e. when there is only an init hook. PR-URL: https://github.com/nodejs/node/pull/34512 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

unknown

commit sha fe2a7f052f65f20e3c325e7525fdab7128c2f72c

util: print External address from inspect Fixes: https://github.com/nodejs/node/issues/28250 PR-URL: https://github.com/nodejs/node/pull/34398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 6ea3bf93a4c06c6086b8546e88a4ae5a3bba5596

test: add ref comment to test-regress-GH-814 Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814.js. PR-URL: https://github.com/nodejs/node/pull/34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 8598ab8976c0a6ace6eea0857aa093c0e95c6eec

test: add ref comment to test-regress-GH-814_2 Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814_2.js. PR-URL: https://github.com/nodejs/node/pull/34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

iandrc

commit sha 4cee226eb41f2c2e3c71800facc0cbaa2f06ecb5

console: document the behavior of console.assert() Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: https://github.com/nodejs/node/issues/34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: https://github.com/nodejs/node/pull/34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Rich Trott

commit sha 360bf9b289e371a2723a7a045ae9389e41294717

doc: use sentence-case for headers in SECURITY.md Our doc style guide calls for sentence-case in headers. PR-URL: https://github.com/nodejs/node/pull/34525 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Stewart X Addison <sxa@uk.ibm.com>

view details

Anna Henningsen

commit sha b14ce72353517d51e64e12fc3fdd5153c6951302

benchmark: always throw the same Error instance Stack trace capturing currently accounts for 40 % of the benchmark running time. Always throwing the same exception object removes that overhead and lets the benchmark be more focused on what it is supposed to measure. Refs: https://github.com/nodejs/node/pull/34512#issuecomment-663977271 PR-URL: https://github.com/nodejs/node/pull/34523 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

iandrc

commit sha f93e3a39522c2ca37b8e936ecf98dc6e729cf5bc

build: toolchain.gypi and node_gyp.py cleanup Removed `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags from `tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`. Fixes: https://github.com/nodejs/node/issues/34256 PR-URL: https://github.com/nodejs/node/pull/34268 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruy Adorno

commit sha 168b22ba073ee1cbf8d0bcb4ded7ff3099335d04

2020-07-29, Version 14.7.0 (Current) Notable changes: deps: * upgrade npm to 6.14.7 (claudiahdz) https://github.com/nodejs/node/pull/34468 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) https://github.com/nodejs/node/pull/14500 doc: * add AshCripps to collaborators (AshCripps) https://github.com/nodejs/node/pull/34494 * add HarshithaKP to collaborators (Harshitha K P) https://github.com/nodejs/node/pull/34417 * add rexagod to collaborators (Pranshu Srivastava) https://github.com/nodejs/node/pull/34457 * add release key for Richard Lau (Richard Lau) https://github.com/nodejs/node/pull/34397 events: * (SEMVER-MINOR) expand NodeEventTarget functionality (Anna Henningsen) https://github.com/nodejs/node/pull/34057 src: * (SEMVER-MINOR) allow preventing SetPromiseRejectCallback (Shelley Vohr) https://github.com/nodejs/node/pull/34387 * (SEMVER-MINOR) allow setting a dir for all diagnostic output (AshCripps) https://github.com/nodejs/node/pull/33584 worker: * (SEMVER-MINOR) make MessagePort inherit from EventTarget (Anna Henningsen) https://github.com/nodejs/node/pull/34057 zlib: * switch to lazy init for zlib streams (Andrey Pechkurov) https://github.com/nodejs/node/pull/34048 PR-URL: https://github.com/nodejs/node/pull/34542

view details

Michael Dawson

commit sha 15333ad552b3e81cc325f31c9920ea7bbb07be0c

doc: clarify N-API version 1 Refs: https://github.com/nodejs/node-addon-api/issues/760 Clarify which version of 8.x in which N-API version 1 matches the shape in later versions like 10.x Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/34344 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Guy Bedford

commit sha 1fe39f0b4bad8da38e5f02542c176d5999ad3ecb

module: disable cjs snapshotting into esm loader PR-URL: https://github.com/nodejs/node/pull/34467 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

Gireesh Punathil

commit sha 4692e284e305e3ec2418f7f5005bed8d3e62ad11

lib: absorb `path` error cases Absorb low level libuv failure in the process initialization phase Fixes: https://github.com/nodejs/node/issues/33759 Refs: https://github.com/nodejs/node/issues/33759#issuecomment-663980558 PR-URL: https://github.com/nodejs/node/pull/34519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>

view details

Andrey Pechkurov

commit sha 019ea073babe6db0cf19ffc68e908de5252a1bc8

async_hooks: don't reuse resource in HttpAgent when queued PR-URL: https://github.com/nodejs/node/pull/34439 Fixes: https://github.com/nodejs/node/issues/34401 Refs: https://github.com/nodejs/node/pull/27581 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

push time in 2 days

create barnchrichardlau/node-1

branch : checkimports

created branch time in 2 days

pull request commentnodejs/node

http: reset headers timeout on headers complete

@ronag The new test this introduced appears to have failed in today's daily on AIX, FreeBSD and IBM i: https://ci.nodejs.org/job/node-daily-master/2022/

e.g. https://ci.nodejs.org/job/node-test-commit-freebsd/34779/nodes=freebsd11-x64/testReport/(root)/test/parallel_test_http_parser_timeout_reset/

Mismatched noop function calls. Expected exactly 3, actual 6.
    at Proxy.mustCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/common/index.js:331:10)
    at Server.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-http-parser-timeout-reset.js:37:42)
    at Object.onceWrapper (events.js:420:28)
    at Server.emit (events.js:314:20)
    at emitListeningNT (net.js:1322:10)
    at processTicksAndRejections (internal/process/task_queues.js:79:21)
ronag

comment created time in 2 days

issue commentnodejs/node

doc Document that IBM i does not support API fs.watch()

@dmabupt Please raise a pull request in this repository with the appropriate changes to https://github.com/nodejs/node/blob/master/doc/api/fs.md.

dmabupt

comment created time in 2 days

pull request commentnodejs/github-bot

chore(lite-ci): disable lite-ci

FWIW I made a small fix to the lite-ci pipeline: https://github.com/nodejs/node/pull/34531#issuecomment-667929763

re. citgm, I can't remember the last time I used that feature, or if it still works. (Or, for that matter, whether it triggered the job to test CITGM itself or the job to test lookup.json changes.) If we do want that feature I've a soft preference to adopting the add a label to start CI mechanism that was recently added for core.

mmarchini

comment created time in 2 days

pull request commentnodejs/node

doc: document the connection event for HTTP2 & TLS servers

@nodejs/build can you check this?

I've added a + prefix to the git ref, which should allow for non-fast forward references: https://git-scm.com/book/en/v2/Git-Internals-The-Refspec

Rerun CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4195/

pimterry

comment created time in 2 days

pull request commentnodejs/node

doc: improve maintainability and readability of collaborator list

Also related to node-core-utils: could we read the list of members from @nodejs/collaborators and @nodejs/tsc instead of relying on parsing?

I think the reason it parses the readme is to get email addresses for the commit metadata (the added Reviewed-by:).

Trott

comment created time in 3 days

pull request commentnodejs/node

doc: improve maintainability and readability of collaborator list

Additionally, make it easier to understand in raw markdown by removing the GitHub link. In the GitHub interface, that link will be provided automatically.

I don’t think that’s true?

Trott

comment created time in 3 days

Pull request review commentnodejs/node

test: add Actions annotation output

 def BuildOptions():   result.add_option('--abort-on-timeout',       help='Send SIGABRT instead of SIGTERM to kill processes that time out',       default=False, action="store_true", dest="abort_on_timeout")+  result.add_option("--actions-annotation",

Have you considered making the annotations another progress indicator rather than another option?

mmarchini

comment created time in 4 days

push eventnodejs/build

Richard Lau

commit sha bb5848a734a40d0e185c06d1698d429c0abc7c40

ansible: refactor install AdoptOpenJDK Java tasks (#2398) * ansible: refactor install AdoptOpenJDK Java tasks Replace several duplicated tasks for installing Java from builds provided by AdoptOpenJDK with a set of common tasks. Remove hardcoded Java release specific paths.

view details

push time in 4 days

PR merged nodejs/build

ansible: refactor install AdoptOpenJDK Java tasks ansible platform:aix platform:ppc

Fixes: https://github.com/nodejs/build/issues/2393

Replace several duplicated tasks for installing Java from builds provided by AdoptOpenJDK with a set of common tasks.

Remove hardcoded Java release specific paths.

Thanks to @sxa for pointing me at the AdoptOpenJDK API which these changes use to fetch the latest release for Java version being installed.

<details> <summary>An example use of the API</summary>

https://api.adoptopenjdk.net/v3/assets/feature_releases/8/ga?architecture=ppc64le&image_type=jre&jvm_impl=openj9&os=linux&project=jdk&heap_size=normal&page_size=1&sort_method=DEFAULT&sort_order=DESC&vendor=adoptopenjdk

[
    {
        "binaries": [
            {
                "architecture": "ppc64le",
                "download_count": 0,
                "heap_size": "normal",
                "image_type": "jre",
                "jvm_impl": "openj9",
                "os": "linux",
                "package": {
                    "checksum": "b1c91e757195b87d51027ea97fece00ac1adb9837b055e5f039dd45511fb3c0a",
                    "checksum_link": "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01_openj9-0.21.0/OpenJDK8U-jre_ppc64le_linux_openj9_8u265b01_openj9-0.21.0.tar.gz.sha256.txt",
                    "download_count": 0,
                    "link": "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01_openj9-0.21.0/OpenJDK8U-jre_ppc64le_linux_openj9_8u265b01_openj9-0.21.0.tar.gz",
                    "name": "OpenJDK8U-jre_ppc64le_linux_openj9_8u265b01_openj9-0.21.0.tar.gz",
                    "size": 48506506
                },
                "project": "jdk",
                "scm_ref": "openj9-0.21.0",
                "updated_at": "2020-07-29T15:39:20Z"
            }
        ],
        "download_count": 466,
        "id": "MDc6UmVsZWFzZTI5MDY1MjIz.h/htfG2PeOnElg==",
        "release_link": "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u265-b01_openj9-0.21.0",
        "release_name": "jdk8u265-b01_openj9-0.21.0",
        "release_type": "ga",
        "timestamp": "2020-07-29T10:03:22Z",
        "updated_at": "2020-07-29T10:03:22Z",
        "vendor": "adoptopenjdk",
        "version_data": {
            "build": 1,
            "major": 8,
            "minor": 0,
            "openjdk_version": "1.8.0_265-b01",
            "security": 265,
            "semver": "8.0.265+1"
        }
    }
]

</details>

I've run the updated scripts against test-ibm-aix71-ppc64_be-1, and test-osuosl-centos7-ppc64_le-1 to update the version of Java used on those. I'll wait for some feedback/reviews before updating the rest.

Updated:

  • [x] release-ibm-aix71-ppc64_be-1
  • [x] release-osuosl-centos7-ppc64_le-1
  • [x] test-ibm-aix71-ppc64_be-1
  • [x] test-ibm-aix71-ppc64_be-2
  • [x] test-osuosl-aix72-ppc64_be-2
  • [x] test-osuosl-centos7-ppc64_le-1
  • [x] test-osuosl-centos7-ppc64_le-2
+98 -77

2 comments

4 changed files

richardlau

pr closed time in 4 days

issue closednodejs/build

Update version of Java 8 on AIX and Linux on Power CI machines

Originally posted by @richardlau in https://github.com/nodejs/build/issues/2387#issuecomment-662366511:

... update the version of Java 8 that we're using -- we're currently using https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u192-b12 which is from October 2018 (https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u262-b10 is the current Java 8). https://github.com/nodejs/build/blob/9cf3680add6ee833cff9bdf855d5c9ab70c1532a/ansible/roles/java-base/tasks/main.yml#L124-L129

  • [ ] Update ansible scripts
  • [ ] Run ansible to update
    • [ ] test-ibm-aix71-ppc64_be-1
    • [ ] test-ibm-aix71-ppc64_be-2
    • [ ] test-osuosl-centos7-ppc64_le-1
    • [ ] test-osuosl-centos7-ppc64_le-2

We're currently using binaries from https://github.com/AdoptOpenJDK/openjdk8-releases/ on most of the IBM platforms in the CI (other platforms are using package managers). We've hardcoded URLs into ansible/roles/java-base/tasks/main.yml and these link directly to a specific version of Java 8.

i.e.

  • AIX https://github.com/nodejs/build/blob/9cf3680add6ee833cff9bdf855d5c9ab70c1532a/ansible/roles/java-base/tasks/main.yml#L124-L129

  • Linux on Power https://github.com/nodejs/build/blob/9cf3680add6ee833cff9bdf855d5c9ab70c1532a/ansible/roles/java-base/tasks/main.yml#L35-L39)

  • LinuxONE https://github.com/nodejs/build/blob/9cf3680add6ee833cff9bdf855d5c9ab70c1532a/ansible/roles/java-base/tasks/main.yml#L64-L68

The versions being used on AIX and Linux on Power are circa 2018 (the LinuxONE version is from January of this year so is reasonably up to date):

  • May 2018: https://github.com/AdoptOpenJDK/openjdk8-releases/releases/tag/jdk8u172-b11
  • October 2018: https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u192-b12

At this time the most recent version of Java 8 is either:

  • https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u262-b10
  • https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u262-b10_openj9-0.21.0 (if we want to switch to J9 like we have done for LinuxONE)

closed time in 4 days

richardlau

pull request commentnodejs/build

ansible: refactor install AdoptOpenJDK Java tasks

Updated the remaining hosts.

richardlau

comment created time in 4 days

delete branch richardlau/build

delete branch : update-sec-matrix

delete time in 4 days

push eventnodejs/build

Richard Lau

commit sha b6c3488d0a64fdbc78492813c85c6946fef39a35

doc: remove node-chakracore from security matrix (#2399) The nodejs/node-chakracore team has been deleted and no longer exists. Remove from the captured normal security matrix. Refs: https://github.com/nodejs/admin/issues/526

view details

push time in 4 days

PR merged nodejs/build

doc: remove node-chakracore from security matrix ci-change ci-public ci-release doc

The nodejs/node-chakracore team has been deleted and no longer exists. Remove from the captured normal security matrix.

Refs: https://github.com/nodejs/admin/issues/526

I've removed the team from the security matrix for both release and test Jenkins. This PR updates the image used in the guide for security releases.

Before: image (i.e. the existing static-assets/jenkins-authorization-normal.png but with Jenkins now showing that nodejs*chakracore was not found).

After: image

+0 -0

0 comment

1 changed file

richardlau

pr closed time in 4 days

delete branch richardlau/node-1

delete branch : checkimports

delete time in 5 days

pull request commentnodejs/node

tools: fix C++ import checker argument expansion

Unfortunately it looks like Jenkins is currently broken (https://github.com/nodejs/build/issues/2362#issuecomment-667176124 cc @nodejs/build-infra) -- would be interesting to see how the CI linter results tally.

addaleax

comment created time in 5 days

pull request commentnodejs/node

tools: fix C++ import checker argument expansion

There's still some sort of weirdness going on. The lint-cpp job from the linter workflow is failing for this PR:

Run make lint-cpp
  make lint-cpp
  shell: /bin/bash -e {0}
  env:
    PYTHON_VERSION: 3.8
    NODE_VERSION: 10.x
    pythonLocation: /opt/hostedtoolcache/Python/3.8.5/x64
Running C++ linter...
using statements aren't sorted in 'test/addons/repl-domain-abort/binding.cc'.
	Line 28: Actual: v8::Local, Expected: v8::Isolate
	Line 29: Actual: v8::Isolate, Expected: v8::Local
Makefile:1337: recipe for target 'tools/.cpplintstamp' failed
make: *** [tools/.cpplintstamp] Error 1
##[error]Process completed with exit code 2.

but I'm seeing more failures when I run against a fresh clone locally:

-bash-4.2$ ls
-bash-4.2$ git clone https://github.com/addaleax/node -b fix-cpp-import-check-weirdness --depth=1
Cloning into 'node'...
remote: Enumerating objects: 32499, done.
remote: Counting objects: 100% (32499/32499), done.
remote: Compressing objects: 100% (27110/27110), done.
remote: Total 32499 (delta 7011), reused 14193 (delta 4235), pack-reused 0
Receiving objects: 100% (32499/32499), 74.99 MiB | 2.49 MiB/s, done.
Resolving deltas: 100% (7011/7011), done.
Checking out files: 100% (32854/32854), done.
-bash-4.2$ cd node/
-bash-4.2$ git rev-parse HEAD
22c467d5ae4c505a2e61b6bcba644a72a8513ecc
-bash-4.2$ make lint-cpp
Running C++ linter...
using statements aren't sorted in 'test/addons/repl-domain-abort/binding.cc'.
        Line 28: Actual: v8::Local, Expected: v8::Isolate
        Line 29: Actual: v8::Isolate, Expected: v8::Local
File "test/addons/async-hooks-promise/binding.cc" does not use "NewStringType"
File "test/addons/dlopen-ping-pong/binding.cc" does not use "NewStringType"
using statements aren't sorted in 'test/addons/dlopen-ping-pong/binding.cc'.
        Line 19: Actual: v8::Object, Expected: v8::NewStringType
        Line 20: Actual: v8::NewStringType, Expected: v8::Object
File "test/addons/non-node-context/binding.cc" does not use "Function"
File "test/addons/non-node-context/binding.cc" does not use "FunctionTemplate"
File "test/addons/non-node-context/binding.cc" does not use "NewStringType"
File "test/addons/uv-handle-leak/binding.cc" does not use "Object"
using statements aren't sorted in 'test/cctest/test_util.cc'.
        Line 61: Actual: node::StringEqualNoCase, Expected: node::Calloc
        Line 72: Actual: node::StringEqualNoCaseN, Expected: node::Malloc
        Line 87: Actual: node::ToLower, Expected: node::MaybeStackBuffer
        Line 101: Actual: node::Malloc, Expected: node::MaybeStackBuffer
        Line 109: Actual: node::Calloc, Expected: node::SPrintF
        Line 117: Actual: node::UncheckedMalloc, Expected: node::StringEqualNoCase
        Line 125: Actual: node::UncheckedCalloc, Expected: node::StringEqualNoCaseN
        Line 134: Actual: node::MaybeStackBuffer, Expected: node::ToLower
        Line 214: Actual: node::MaybeStackBuffer, Expected: node::UncheckedCalloc
        Line 257: Actual: node::SPrintF, Expected: node::UncheckedMalloc
using statements aren't sorted in 'test/cctest/test_base64.cc'.
        Line 8: Actual: node::base64_encode, Expected: node::base64_decode
        Line 9: Actual: node::base64_decode, Expected: node::base64_encode
using statements aren't sorted in 'test/embedding/embedtest.cc'.
        Line 19: Actual: v8::Value, Expected: v8::V8
        Line 20: Actual: v8::V8, Expected: v8::Value
make: *** [tools/.cpplintstamp] Error 1
-bash-4.2$
addaleax

comment created time in 5 days

PR closed nodejs/node

tools: fix checkimports.py when passed arguments tools

Fix checkimports.py so that all passed arguments are checked instead of just the first one.

Opening as a draft to check that our actions/CI jobs fail properly now.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -1

2 comments

1 changed file

richardlau

pr closed time in 5 days

pull request commentnodejs/node

tools: fix checkimports.py when passed arguments

Close in favour of https://github.com/nodejs/node/pull/34582.

richardlau

comment created time in 5 days

push eventrichardlau/node-1

Richard Lau

commit sha e7222d1dc047824cd0f8478d936fcad4aacfba4c

temporary debug

view details

push time in 5 days

PR opened nodejs/node

tools: fix checkimports.py when passed arguments

Fix checkimports.py so that all passed arguments are checked instead of just the first one.

Opening as a draft to check that our actions/CI jobs fail properly now.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchrichardlau/node-1

branch : checkimports

created branch time in 5 days

issue commentnodejs/build

Jenkins CI host: manage available disk space

image

jbergstroem

comment created time in 5 days

issue commentnodejs/build

Jenkins CI host: manage available disk space

image

jbergstroem

comment created time in 5 days

issue commentnodejs/build

Jenkins CI host: manage available disk space

I think we may have run out of space again.

I'm seeing lots of "java.io.IOException: No space left on device" messages in the Jenkins system log (https://ci.nodejs.org/log/all).

jbergstroem

comment created time in 5 days

pull request commentnodejs/build

ansible: refactor install AdoptOpenJDK Java tasks

Updated test-osuosl-aix72-ppc64_be-2. Interestingly ansible_architecture for that host returns chrp instead of ppc64 so I've explicitly set arch for our AIX platforms to be on the safe side.

richardlau

comment created time in 5 days

push eventrichardlau/build

Richard Lau

commit sha 07e17244c169e26b6438441199e95f1f1c1da274

fixup! ansible: refactor install AdoptOpenJDK Java tasks

view details

push time in 5 days

push eventrichardlau/build

Richard Lau

commit sha 5f621a7dd8034b7aa5aa5ac613b6570ac7a7f9c3

fixup! ansible: refactor install AdoptOpenJDK Java tasks

view details

push time in 5 days

pull request commentfacebook/jest

fix: correct check for compatible `find` binary

Verified on Windows VM. Not sure how to write a test for this… I'm quite confused by why our windows tests pass without this - I doubt watchman is installed. Maybe they have some other find?

The test mock child_process so don't actually spawn. https://github.com/richardlau/jest/blob/41436be27aef1b5968d5360062e5599d206f16d8/packages/jest-haste-map/src/crawlers/tests/node.test.js#L11-L35

SimenB

comment created time in 5 days

issue commentnodejs/node-gyp

Acid test passes but `node-gyp rebuild` failing on npm installs

It looks like you're trying to use a module (jitterbuffer) that isn't compatible with Node.js 12: https://github.com/Rantanen/node-jitterbuffer/issues/15#issuecomment-619159242

Phil-Barber

comment created time in 5 days

pull request commentnodejs/node

src: fix unused namespace member in node_util

Also, let’s fast-track this. We can take care of the non-surfacing weirdnesses after that. :)

👍 to both statements.

puzpuzpuz

comment created time in 5 days

issue commentnodejs/node

Automatically Configured Path for NPM on Windows Incorrect

It's by design. On Windows that is where npm installs "global" packages (see https://docs.npmjs.com/try-the-latest-stable-version-of-npm#upgrading-on-windows). That directory is put on the path so that you can run commands installed globally (npm install -g ...) by npm.

gdynamics

comment created time in 5 days

Pull request review commentnodejs/node

doc: revise N-API versions matrix text

 listed as supporting a later version. | v13.x | v13.0.0  | v13.0.0  | v13.0.0  | v13.0.0  | v13.0.0   |           | | v14.x | v14.0.0  | v14.0.0  | v14.0.0  | v14.0.0  | v14.0.0   | v14.0.0   | -\* Indicates that the N-API version was released as experimental+\* N-API was experimental. -\*\* First version which matches version 1 in later releases. While v8.0.0-included N-API as experimental, version 1 continued to evolve until-v8.6.0 and therefore the shape of the API in earlier versions is not-truly version 1 (in hindsight we should have called it version 0).-We recommend version 3 or later.+\*\* Node.js 8.0.0 included N-API as experimental. It was released as N-API+version 1 but continued to evolve until v8.6.0. The API is different in versions

The leading v here should also be dropped for consistency with the rest of the paragraph.

Trott

comment created time in 5 days

pull request commentnodejs/node

src: fix unused namespace member in node_util

It's puzzling our CI's (neither Actions or Jenkins) didn't pick that up.

puzpuzpuz

comment created time in 5 days

Pull request review commentnodejs/node

doc: revise N-API versions matrix text

 from version 3 with some additions. This means that it is not necessary to recompile for new versions of Node.js which are listed as supporting a later version. -|       | 1        | 2        | 3        | 4        | 5         | 6         |-|-------|----------|----------|----------|----------|-----------|-----------|-| v6.x  |          |          | v6.14.2* |          |           |           |-| v8.x  | v8.6.0** | v8.10.0* | v8.11.2  | v8.16.0  |           |           |-| v9.x  | v9.0.0*  | v9.3.0*  | v9.11.0* |          |           |           |-| v10.x | v10.0.0  | v10.0.0  | v10.0.0  | v10.16.0 | v10.17.0  | v10.20.0  |-| v11.x | v11.0.0  | v11.0.0  | v11.0.0  | v11.8.0  |           |           |-| v12.x | v12.0.0  | v12.0.0  | v12.0.0  | v12.0.0  | v12.11.0  | v12.17.0  |-| v13.x | v13.0.0  | v13.0.0  | v13.0.0  | v13.0.0  | v13.0.0   |           |-| v14.x | v14.0.0  | v14.0.0  | v14.0.0  | v14.0.0  | v14.0.0   | v14.0.0   |--\* Indicates that the N-API version was released as experimental--\*\* First version which matches version 1 in later releases. While v8.0.0-included N-API as experimental, version 1 continued to evolve until-v8.6.0 and therefore the shape of the API in earlier versions is not-truly version 1 (in hindsight we should have called it version 0).-We recommend version 3 or later.+|      | 1       | 2       | 3       | 4       | 5        | 6        |+|------|---------|---------|---------|---------|----------|----------|+| 6.x  |         |         | 6.14.2* |         |          |          |

Stripping the leading v off the version numbers kind of precludes the use of the REPLACEME tag (e.g. https://github.com/nodejs/node/commit/eaa9f833098d687ad0c49f96bff0c79650b293b0), or at least means there's the possibility of an inconsistency. The release process replaces REPLACEME instances with a leading v: https://github.com/nodejs/node/blob/master/doc/guides/releases.md#step-3-update-any-replaceme-and-dep00xx-tags-in-the-docs

Trott

comment created time in 5 days

PR opened nodejs/build

doc: remove node-chakracore from security matrix

The nodejs/node-chakracore team has been deleted and no longer exists. Remove from the captured normal security matrix.

Refs: https://github.com/nodejs/admin/issues/526

I've removed the team from the security matrix for both release and test Jenkins. This PR updates the image used in the guide for security releases.

Before: image (i.e. the existing static-assets/jenkins-authorization-normal.png but with Jenkins now showing that nodejs*chakracore was not found).

+0 -0

0 comment

1 changed file

pr created time in 6 days

create barnchrichardlau/build

branch : update-sec-matrix

created branch time in 6 days

Pull request review commentnodejs/build

ansible: refactor install AdoptOpenJDK Java tasks

         name: "{{ java_package_name }}"         state: present -- name: check if java is installed AIX-  stat:-    path: /home/iojs/jdk8u192-b12-jre/bin-  register: java_exists-  when: os|startswith("aix")- - name: check if java is installed IBMi   stat:     path: /QOpenSys/QIBM/ProdData/JavaVM/jdk80/64bit/bin/java   register: java_exists   when: os|startswith("ibmi") -- name: download java AIX-  get_url:-    url: https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u192-b12/OpenJDK8U-jre_ppc64_aix_hotspot_8u192b12.tar.gz-    dest: /tmp/-  tags: java-  when: os|startswith("aix") and java_exists.stat.exists == False--- name: unarchive java AIX-  unarchive:-    src: /tmp/OpenJDK8U-jre_ppc64_aix_hotspot_8u192b12.tar.gz-    remote_src: yes-    dest: /home/iojs-  tags: java-  when: os|startswith("aix") and java_exists.stat.exists == False- - name: install webupd8 oracle java 8 extras   when: java.rc > 0 and os == "ubuntu1404" and arch != "ppc64"   package: name="{{item}}" state=present   with_items:     - ca-certificates     - oracle-java8-set-default++# Uses the AdoptOpenJDK API https://github.com/adoptopenjdk/openjdk-api-v3+# to discover the most recent release for the given adoptopenjdk_version and+# platform.+- name: fetch adoptopenjdk metadata+  register: adoptopenjdk_metadata+  uri:+    body_format: json+    return_content: yes+    status_code: 200+    url: "https://api.adoptopenjdk.net/v3/assets/feature_releases/{{ adoptopenjdk_version }}/ga?architecture={{ adoptopenjdk_arch }}&image_type=jre&jvm_impl=openj9&os={{ adoptopenjdk_os }}&project=jdk&heap_size=normal&page_size=1&sort_method=DEFAULT&sort_order=DESC&vendor=adoptopenjdk"+  when: use_adoptopenjdk == True

Also, in case there's confusion, this will be the latest Java 8 (it won't jump to, e.g. Java 11 without the variables being manually updated).

richardlau

comment created time in 6 days

Pull request review commentnodejs/build

ansible: refactor install AdoptOpenJDK Java tasks

         name: "{{ java_package_name }}"         state: present -- name: check if java is installed AIX-  stat:-    path: /home/iojs/jdk8u192-b12-jre/bin-  register: java_exists-  when: os|startswith("aix")- - name: check if java is installed IBMi   stat:     path: /QOpenSys/QIBM/ProdData/JavaVM/jdk80/64bit/bin/java   register: java_exists   when: os|startswith("ibmi") -- name: download java AIX-  get_url:-    url: https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u192-b12/OpenJDK8U-jre_ppc64_aix_hotspot_8u192b12.tar.gz-    dest: /tmp/-  tags: java-  when: os|startswith("aix") and java_exists.stat.exists == False--- name: unarchive java AIX-  unarchive:-    src: /tmp/OpenJDK8U-jre_ppc64_aix_hotspot_8u192b12.tar.gz-    remote_src: yes-    dest: /home/iojs-  tags: java-  when: os|startswith("aix") and java_exists.stat.exists == False- - name: install webupd8 oracle java 8 extras   when: java.rc > 0 and os == "ubuntu1404" and arch != "ppc64"   package: name="{{item}}" state=present   with_items:     - ca-certificates     - oracle-java8-set-default++# Uses the AdoptOpenJDK API https://github.com/adoptopenjdk/openjdk-api-v3+# to discover the most recent release for the given adoptopenjdk_version and+# platform.+- name: fetch adoptopenjdk metadata+  register: adoptopenjdk_metadata+  uri:+    body_format: json+    return_content: yes+    status_code: 200+    url: "https://api.adoptopenjdk.net/v3/assets/feature_releases/{{ adoptopenjdk_version }}/ga?architecture={{ adoptopenjdk_arch }}&image_type=jre&jvm_impl=openj9&os={{ adoptopenjdk_os }}&project=jdk&heap_size=normal&page_size=1&sort_method=DEFAULT&sort_order=DESC&vendor=adoptopenjdk"+  when: use_adoptopenjdk == True

The other platforms use package managers and will update accordingly (via the package-upgrade role). https://github.com/nodejs/build/blob/40c08e80c69dd1cafaf395046b68b2908b080658/ansible/roles/java-base/tasks/main.yml#L30-L33

Updates will only occur when someone runs the ansible playbook. I would very much like to avoid having to edit the ansible scripts every time we update Java, which is why I removed hard coded versions and paths.

richardlau

comment created time in 6 days

PR opened nodejs/build

ansible: refactor install AdoptOpenJDK Java tasks

Fixes: https://github.com/nodejs/build/issues/2393

Replace several duplicated tasks for installing Java from builds provided by AdoptOpenJDK with a set of common tasks.

Remove hardcoded Java release specific paths.

Thanks to @sxa for pointing me at the AdoptOpenJDK API which these changes use to fetch the latest release for Java version being installed.

<details> <summary>An example use of the API</summary>

https://api.adoptopenjdk.net/v3/assets/feature_releases/8/ga?architecture=ppc64le&image_type=jre&jvm_impl=openj9&os=linux&project=jdk&heap_size=normal&page_size=1&sort_method=DEFAULT&sort_order=DESC&vendor=adoptopenjdk

[
    {
        "binaries": [
            {
                "architecture": "ppc64le",
                "download_count": 0,
                "heap_size": "normal",
                "image_type": "jre",
                "jvm_impl": "openj9",
                "os": "linux",
                "package": {
                    "checksum": "b1c91e757195b87d51027ea97fece00ac1adb9837b055e5f039dd45511fb3c0a",
                    "checksum_link": "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01_openj9-0.21.0/OpenJDK8U-jre_ppc64le_linux_openj9_8u265b01_openj9-0.21.0.tar.gz.sha256.txt",
                    "download_count": 0,
                    "link": "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01_openj9-0.21.0/OpenJDK8U-jre_ppc64le_linux_openj9_8u265b01_openj9-0.21.0.tar.gz",
                    "name": "OpenJDK8U-jre_ppc64le_linux_openj9_8u265b01_openj9-0.21.0.tar.gz",
                    "size": 48506506
                },
                "project": "jdk",
                "scm_ref": "openj9-0.21.0",
                "updated_at": "2020-07-29T15:39:20Z"
            }
        ],
        "download_count": 466,
        "id": "MDc6UmVsZWFzZTI5MDY1MjIz.h/htfG2PeOnElg==",
        "release_link": "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u265-b01_openj9-0.21.0",
        "release_name": "jdk8u265-b01_openj9-0.21.0",
        "release_type": "ga",
        "timestamp": "2020-07-29T10:03:22Z",
        "updated_at": "2020-07-29T10:03:22Z",
        "vendor": "adoptopenjdk",
        "version_data": {
            "build": 1,
            "major": 8,
            "minor": 0,
            "openjdk_version": "1.8.0_265-b01",
            "security": 265,
            "semver": "8.0.265+1"
        }
    }
]

</details>

I've run the updated scripts against test-ibm-aix71-ppc64_be-1, and test-osuosl-centos7-ppc64_le-1 to update the version of Java used on those. I'll wait for some feedback/reviews before updating the rest.

Updated:

  • [ ] release-ibm-aix71-ppc64_be-1
  • [ ] release-osuosl-centos7-ppc64_le-1
  • [x] test-ibm-aix71-ppc64_be-1
  • [ ] test-ibm-aix71-ppc64_be-2
  • [ ] test-osuosl-aix72-ppc64_be-2
  • [x] test-osuosl-centos7-ppc64_le-1
  • [ ] test-osuosl-centos7-ppc64_le-2
+96 -77

0 comment

4 changed files

pr created time in 6 days

create barnchrichardlau/build

branch : java

created branch time in 6 days

Pull request review commentnodejs/TSC

doc: sync Security-Team.md GitHub teams membership

 includes a fix, documentation, an informational CVE or blog post. - [@jasnell](https://github.com/jasnell) - James M Snell - [@mcollina](https://github.com/mcollina) - Matteo Collina - [@MylesBorins](https://github.com/MylesBorins) - Myles Borins+- [@ronag](https://github.com/ronag) - Robert Nagy - [@shigeki](https://github.com/shigeki) - Shigeki Ohtsu - [@vdeturckheim](https://github.com/vdeturckheim) - Vladimir de Turckheim-- [@watson](https://github.com/watson) - Thomas Watson

but not in https://github.com/orgs/nodejs/teams/security-triage/members which is what this list syncs with.

richardlau

comment created time in 6 days

PR opened nodejs/Release

doc: add @ruyadorno to releasers

Synced README.md with ncu-team sync README.md.

+1 -0

0 comment

1 changed file

pr created time in 6 days

create barnchrichardlau/Release

branch : readme

created branch time in 6 days

push eventnodejs/Release

Bethany Nicolle Griggs

commit sha fdf3dedd03628364a7ffaebdcb48ba4766c9242d

doc: add @richardlau to releasers (#588) Refs: https://github.com/nodejs/Release/issues/585

view details

push time in 6 days

PR merged nodejs/Release

doc: add @richardlau to releasers

Refs: https://github.com/nodejs/Release/issues/585

+1 -0

2 comments

1 changed file

BethGriggs

pr closed time in 6 days

Pull request review commentnodejs/node

v14.7.0 proposal

   * [io.js](CHANGELOG_IOJS.md)   * [Archive](CHANGELOG_ARCHIVE.md) +<a id="14.7.0"></a>+## 2020-07-29, Version 14.7.0 (Current), @richardlau prepared by @ruyadorno
## 2020-07-29, Version 14.7.0 (Current), @MylesBorins prepared by @ruyadorno

Unfortunately it's going to be a bit too soon for me to promote a release as my key was only added to the readme on 20 July so by the Release WG policy I'd be first eligible to do a release on 3 Aug.

ruyadorno

comment created time in 7 days

issue commentnodejs/node

Unflag Top-Level Await?

For clarification, this is unflagging on 14.x or the next semver major?

MylesBorins

comment created time in 7 days

Pull request review commentlibuv/libuv

[build] Move to using add_subdirectory(test) to add tests and benchmarks

+# Small hack: use ${uv_test_sources} now to get the runner skeleton,+# before the actual tests are added.+# However, this won't be an issue once we start to use target_sources, and+# create a common test library target+add_executable(uv_run_benchmarks_a+  ${uv_test_sources}+  benchmark-async-pummel.c+  benchmark-async.c+  benchmark-fs-stat.c+  benchmark-getaddrinfo.c+  benchmark-loop-count.c+  benchmark-million-async.c+  benchmark-million-timers.c+  benchmark-multi-accept.c+  benchmark-ping-pongs.c+  benchmark-ping-udp.c+  benchmark-pound.c+  benchmark-pump.c+  benchmark-sizes.c+  benchmark-spawn.c+  benchmark-tcp-write-batch.c+  benchmark-thread.c+  benchmark-udp-pummel.c+  blackhole-server.c+  dns-server.c+  echo-server.c+  run-benchmarks.c+  runner.c)++target_compile_definitions(uv_run_benchmarks_a PRIVATE ${uv_defines})+target_compile_options(uv_run_benchmarks_a PRIVATE ${uv_cflags})+target_link_libraries(uv_run_benchmarks_a PRIVATE uv_a ${uv_test_libraries})++list(APPEND uv_test_sources+     blackhole-server.c+     echo-server.c+     run-tests.c+     runner.c+     test-active.c+     test-async-null-cb.c+     test-async.c+     test-barrier.c+     test-callback-order.c+     test-callback-stack.c+     test-close-fd.c+     test-close-order.c+     test-condvar.c+     test-connect-unspecified.c+     test-connection-fail.c+     test-cwd-and-chdir.c+     test-default-loop-close.c+     test-delayed-accept.c+     test-dlerror.c+     test-eintr-handling.c+     test-embed.c+     test-emfile.c+     test-env-vars.c+     test-error.c+     test-fail-always.c+     test-fork.c+     test-fs-copyfile.c+     test-fs-event.c+     test-fs-poll.c+     test-fs.c+     test-fs-readdir.c+     test-fs-fd-hash.c+     test-fs-open-flags.c+     test-get-currentexe.c+     test-get-loadavg.c+     test-get-memory.c+     test-get-passwd.c+     test-getaddrinfo.c+     test-gethostname.c+     test-getnameinfo.c+     test-getsockname.c+     test-getters-setters.c+     test-gettimeofday.c+     test-handle-fileno.c+     test-homedir.c+     test-hrtime.c+     test-idle.c+     test-idna.c+     test-ip4-addr.c+     test-ip6-addr.c+     test-ipc-heavy-traffic-deadlock-bug.c+     test-ipc-send-recv.c+     test-ipc.c+     test-loop-alive.c+     test-loop-close.c+     test-loop-configure.c+     test-loop-handles.c+     test-loop-stop.c+     test-loop-time.c+     test-multiple-listen.c+     test-mutexes.c+     test-osx-select.c+     test-pass-always.c+     test-ping-pong.c+     test-pipe-bind-error.c+     test-pipe-close-stdout-read-stdin.c+     test-pipe-connect-error.c+     test-pipe-connect-multiple.c+     test-pipe-connect-prepare.c+     test-pipe-getsockname.c+     test-pipe-pending-instances.c+     test-pipe-sendmsg.c+     test-pipe-server-close.c+     test-pipe-set-fchmod.c+     test-pipe-set-non-blocking.c+     test-platform-output.c+     test-poll-close-doesnt-corrupt-stack.c+     test-poll-close.c+     test-poll-closesocket.c+     test-poll-oob.c+     test-poll.c+     test-process-priority.c+     test-process-title-threadsafe.c+     test-process-title.c+     test-queue-foreach-delete.c+     test-random.c+     test-ref.c+     test-run-nowait.c+     test-run-once.c+     test-semaphore.c+     test-shutdown-close.c+     test-shutdown-eof.c+     test-shutdown-twice.c+     test-signal-multiple-loops.c+     test-signal-pending-on-close.c+     test-signal.c+     test-socket-buffer-size.c+     test-spawn.c+     test-stdio-over-pipes.c+     test-strscpy.c+     test-tcp-alloc-cb-fail.c+     test-tcp-bind-error.c+     test-tcp-bind6-error.c+     test-tcp-close-accept.c+     test-tcp-close-while-connecting.c+     test-tcp-close.c+     test-tcp-close-reset.c+     test-tcp-connect-error-after-write.c+     test-tcp-connect-error.c+     test-tcp-connect-timeout.c+     test-tcp-connect6-error.c+     test-tcp-create-socket-early.c+     test-tcp-flags.c+     test-tcp-oob.c+     test-tcp-open.c+     test-tcp-read-stop.c+     test-tcp-shutdown-after-write.c+     test-tcp-try-write.c+     test-tcp-try-write-error.c+     test-tcp-unexpected-read.c+     test-tcp-write-after-connect.c+     test-tcp-write-fail.c+     test-tcp-write-queue-order.c+     test-tcp-write-to-half-open-connection.c+     test-tcp-writealot.c+     test-thread-equal.c+     test-thread.c+     test-threadpool-cancel.c+     test-threadpool.c+     test-timer-again.c+     test-timer-from-check.c+     test-timer.c+     test-tmpdir.c+     test-tty-duplicate-key.c+     test-tty-escape-sequence-processing.c+     test-tty.c+     test-udp-alloc-cb-fail.c+     test-udp-bind.c+     test-udp-connect.c+     test-udp-create-socket-early.c+     test-udp-dgram-too-big.c+     test-udp-ipv6.c+     test-udp-multicast-interface.c+     test-udp-multicast-interface6.c+     test-udp-multicast-join.c+     test-udp-multicast-join6.c+     test-udp-multicast-ttl.c+     test-udp-open.c+     test-udp-options.c+     test-udp-send-and-recv.c+     test-udp-send-hang-loop.c+     test-udp-send-immediate.c+     test-udp-sendmmsg-error.c+     test-udp-send-unreachable.c+     test-udp-try-send.c+     test-uname.c+     test-walk-handles.c+     test-watcher-cross-stop.c)++add_executable(uv_run_tests ${uv_test_sources} uv_win_longpath.manifest)+target_compile_definitions(uv_run_tests+                           PRIVATE ${uv_defines} USING_UV_SHARED=1)+target_compile_options(uv_run_tests PRIVATE ${uv_cflags})+target_link_libraries(uv_run_tests uv ${uv_test_libraries})++add_test(NAME uv_test+         COMMAND uv_run_tests+         WORKING_DIRECTORY ${PROJECT_SOURCE_DIR})

I've adjusted the permissions for https://ci.nodejs.org/job/libuv-test-commit-windows-cmake/ and https://ci.nodejs.org/job/libuv-test-commit-osx-cmake/ to be more in line with what we have for the Node.js jobs, which is that we allow authenticated users (via GitHub) to view the jobs and results. So @slurps-mad-rips you should be able to view them now.

I'll have a look at the other libuv jobs in the morning.

slurps-mad-rips

comment created time in 7 days

pull request commentnodejs/node

quic: refactor clientHello

The actions failures are new warnings (treated as errors):

2020-07-28T17:59:21.1359496Z ../src/quic/node_quic_session.cc: In function ‘void node::quic::{anonymous}::QuicSessionOnCertDone(const v8::FunctionCallbackInfo<v8::Value>&)’:
2020-07-28T17:59:21.1455906Z ../src/quic/node_quic_session.cc:2732:16: error: unused variable ‘env’ [-Werror=unused-variable]
2020-07-28T17:59:21.1456744Z    Environment* env = Environment::GetCurrent(args);
2020-07-28T17:59:21.1457123Z                 ^~~
2020-07-28T17:59:21.9743160Z ../src/quic/node_quic_session.cc: In member function ‘virtual void node::quic::JSQuicSessionListener::OnClientHello(const char*, const char*)’:
2020-07-28T17:59:21.9744621Z ../src/quic/node_quic_session.cc:399:55: error: ignoring return value of ‘bool v8::MaybeLocal<T>::ToLocal(v8::Local<S>*) const [with S = v8::Array; T = v8::Array]’, declared with attribute warn_unused_result [-Werror=unused-result]
2020-07-28T17:59:21.9745989Z    session()->crypto_context()->hello_ciphers().ToLocal(&ciphers);
2020-07-28T17:59:21.9746893Z    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
2020-07-28T17:59:21.9748732Z ../src/quic/node_quic_session.cc:402:54: error: ignoring return value of ‘bool v8::MaybeLocal<T>::ToLocal(v8::Local<S>*) const [with S = v8::String; T = v8::String]’, declared with attribute warn_unused_result [-Werror=unused-result]
2020-07-28T17:59:21.9749778Z      String::NewFromUtf8(env->isolate(), alpn).ToLocal(&alpn_string);
2020-07-28T17:59:21.9749960Z      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
2020-07-28T17:59:21.9750767Z ../src/quic/node_quic_session.cc:405:61: error: ignoring return value of ‘bool v8::MaybeLocal<T>::ToLocal(v8::Local<S>*) const [with S = v8::String; T = v8::String]’, declared with attribute warn_unused_result [-Werror=unused-result]
2020-07-28T17:59:21.9751274Z      String::NewFromUtf8(env->isolate(), server_name).ToLocal(&servername);
2020-07-28T17:59:21.9751434Z      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
2020-07-28T17:59:21.9807567Z ../src/quic/node_quic_session.cc: In member function ‘virtual void node::quic::JSQuicSessionListener::OnHandshakeCompleted()’:
2020-07-28T17:59:21.9808402Z ../src/quic/node_quic_session.cc:581:55: error: ignoring return value of ‘bool v8::MaybeLocal<T>::ToLocal(v8::Local<S>*) const [with S = v8::Value; T = v8::Value]’, declared with attribute warn_unused_result [-Werror=unused-result]
2020-07-28T17:59:21.9808617Z      crypto::GetValidationErrorReason(env, err).ToLocal(&validationErrorReason);
2020-07-28T17:59:21.9808753Z      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
2020-07-28T17:59:21.9809720Z ../src/quic/node_quic_session.cc:582:53: error: ignoring return value of ‘bool v8::MaybeLocal<T>::ToLocal(v8::Local<S>*) const [with S = v8::Value; T = v8::Value]’, declared with attribute warn_unused_result [-Werror=unused-result]
2020-07-28T17:59:21.9810060Z      crypto::GetValidationErrorCode(env, err).ToLocal(&validationErrorCode);
2020-07-28T17:59:21.9810235Z      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
2020-07-28T17:59:26.2727155Z cc1plus: all warnings being treated as errors
jasnell

comment created time in 7 days

pull request commentlibuv/libuv

aix: protect uv_exepath() from uv_set_process_title()

Yes, this one is with me to address nits. This PR does address an issue on AIX but is not urgent as it doesn’t affect Node.js.

richardlau

comment created time in 7 days

issue commentnodejs/help

date convert error

We updated ICU in Node.js 12.17.0 to a more recent version (ICU 67.1). If you've previously installed full-icu with an older version of Node.js 12 you will need to reinstall full-icu as unfortunately the data is specific to the version of ICU being used.

cc @nodejs/i18n-api

JoeyBling

comment created time in 8 days

issue commentnodejs/help

Installing NPM packages with child_process

You're trying to do the same as https://github.com/nodejs/node/issues/31803, which AFAIK is not currently possible due to the internal caching.

Paultje52

comment created time in 8 days

issue commentnodejs/admin

Add `@nodejs-github-bot` to `@nodejs/collaborators`

The user page in Jenkins shows the groups the user is in as far as Jenkins is concerned, e.g. https://ci.nodejs.org/user/nodejs-github-bot/

mmarchini

comment created time in 8 days

issue commentnodejs/admin

Add `@nodejs-github-bot` to `@nodejs/collaborators`

I’m not sure. https://issues.jenkins-ci.org/browse/JENKINS-44920 suggests it should work, https://issues.jenkins-ci.org/browse/JENKINS-63051 claims it does not.

mmarchini

comment created time in 8 days

issue commentnodejs/build

Increase privilege of `github-bot` on Jenkins

If the bot is to have the same permissions as a collaborator, could it not be added to the @nodejs/collaborators team? We don’t, AFAIK, have a good method for restoring permissions after CI lockdown for security releases (https://github.com/nodejs/build/blob/master/doc/jenkins-guide.md#security-releases) other than manually reentering the entries so I would prefer not to have to add more.

mmarchini

comment created time in 8 days

PR opened nodejs/TSC

doc: sync Security-Team.md GitHub teams membership

Results of running ncu-team sync Security-Team.md from node-core-utils.

+3 -6

0 comment

1 changed file

pr created time in 9 days

create barnchrichardlau/TSC

branch : security

created branch time in 9 days

issue closednodejs/build

Add @richardlau as a new active releaser

Figured this should be a separate issue from https://github.com/nodejs/Release/issues/499 and https://github.com/nodejs/Release/pull/588 for visibility.

I'm being onboarded as a new releaser https://github.com/nodejs/Release/issues/585 and am now at the stage where I've been added to various additional GitHub teams as per https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers. This also says:

Have a single, high quality SSH key added to the "dist" user on the primary www server (see below for guidelines regarding SSH key quality). ... The public key can be shared with an existing member of the releasers team to be placed on the www server for access to the "dist" user. The private key should be kept very secure and not shared with anyone. Any actual or suspected compromise of the private key should be reported immediately and the key should be entirely removed from use.

So could someone from @nodejs/releasers please add my public ssh key (https://github.com/richardlau.keys) please?

closed time in 9 days

richardlau

issue commentnodejs/build

Add @richardlau as a new active releaser

Thank you.

richardlau

comment created time in 9 days

issue openednodejs/build

Add @richardlau as a new active releaser

Figured this should be a separate issue from https://github.com/nodejs/Release/issues/499 and https://github.com/nodejs/Release/pull/588 for visibility.

I'm being onboarded as a new releaser https://github.com/nodejs/Release/issues/585 and am now at the stage where I've been added to various additional GitHub teams as per https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers. This also says:

Have a single, high quality SSH key added to the "dist" user on the primary www server (see below for guidelines regarding SSH key quality). ... The public key can be shared with an existing member of the releasers team to be placed on the www server for access to the "dist" user. The private key should be kept very secure and not shared with anyone. Any actual or suspected compromise of the private key should be reported immediately and the key should be entirely removed from use.

So could someone from @nodejs/releasers please add my public ssh key (https://github.com/richardlau.keys) please?

created time in 9 days

pull request commentnodejs/node

doc: correct added version for --abort-on-uncaught-exception

Isn't this https://github.com/nodejs/node/pull/31360?

MarcelRaschke

comment created time in 9 days

pull request commentnodejs/Release

doc: add @richardlau to releasers

Now that @richardlau has prepared his first release, this can be merged. I'll be adding Richard to the relevant teams detailed in https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers - this includes inviting to the nodejs-private organisation.

FWIW I'm already in the nodejs-private organisation (was added when I joined the Build WG), but I believe I would be added to more teams/repositories in that organization as part of the releaser onboarding.

BethGriggs

comment created time in 9 days

issue commentnodejs/node

addons/register-signal-handler/test and abort/test-addon-register-signal-handler failed

@dmabupt It looks like the reproducibility of this is low but based on the stress runs (same test run over and over) below we've now seen this on both of the test CI machines (test-iinthecloud-ibmi72-ppc64_be-1 and test-iinthecloud-ibmi72-ppc64_be-2).

machine fails/repetitions build
test-iinthecloud-ibmi72-ppc64_be-2 0/100 https://ci.nodejs.org/job/node-stress-single-test/141/nodes=ibmi72-ppc64/
test-iinthecloud-ibmi72-ppc64_be-2 0/1000 https://ci.nodejs.org/job/node-stress-single-test/143/nodes=ibmi72-ppc64/
test-iinthecloud-ibmi72-ppc64_be-1 1/1000 https://ci.nodejs.org/job/node-stress-single-test/148/nodes=ibmi72-ppc64/
test-iinthecloud-ibmi72-ppc64_be-2 0/1000 https://ci.nodejs.org/job/node-stress-single-test/149/nodes=ibmi72-ppc64/
test-iinthecloud-ibmi72-ppc64_be-2 1/930 https://ci.nodejs.org/job/node-stress-single-test/150/nodes=ibmi72-ppc64/console
test-iinthecloud-ibmi72-ppc64_be-2 ???/1000 https://ci.nodejs.org/job/node-stress-single-test/153/nodes=ibmi72-ppc64/
richardlau

comment created time in 9 days

issue commentnodejs/node

flaky test-regress-GH-814_2

Looks like a copy-paste error with the RUN_TESTS parameter for that stress run. I've corrected it and started a rebuild: https://ci.nodejs.org/job/node-stress-single-test/152/

Trott

comment created time in 9 days

delete branch richardlau/node-1

delete branch : asan

delete time in 9 days

delete branch richardlau/node-1

delete branch : tarball

delete time in 9 days

pull request commentnodejs/node

build: speed up source tarball creation

Landed in 3e6b05e1aa.

richardlau

comment created time in 9 days

PR merged nodejs/node

build: speed up source tarball creation author ready build meta

Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary.

Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs.

This significantly cuts the time for the "build-tarball" job from the "Build from tarball" workflow from ~50mins to ~2mins.

Our release CI shouldn't be affected as the job the builds the source tarball builds the binary tarball first so will always have a built node binary to run.

image

Here's a test build on the release CI: https://ci-release.nodejs.org/job/iojs+release/6206/ Download: https://nodejs.org/download/test/v15.0.0-test20200724221167a148/

cc @nodejs/build-files

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+3 -3

2 comments

2 changed files

richardlau

pr closed time in 9 days

push eventnodejs/node

Richard Lau

commit sha 3e6b05e1aaeee8213f738450364acebf4b92128d

build: speed up source tarball creation Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: https://github.com/nodejs/node/pull/34508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

push time in 9 days

push eventrichardlau/node-1

Rich Trott

commit sha de192246bc29c43f387bc18024515cc475be152d

test: remove superfluous check in pummel/test-timers If setTimeout is not a function, this test and most other tests would fail. There is no need to check it. PR-URL: https://github.com/nodejs/node/pull/34488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Robert Nagy

commit sha e8d7fedf7cad6e612e4f2e0456e359af57608ac7

http: don't write error to socket The state of the connection is unknown at this point and writing to it can corrupt client state before it is aware of an error. PR-URL: https://github.com/nodejs/node/pull/34465 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 83ddb49d6dccaa99e87a58b85a7edd1b47f10568

src: prefer internal fields in ModuleWrap Use internal fields instead of `v8::Global`s where possible, since they generally come with lower overhead and it’s much harder to introduce memory leaks with them. PR-URL: https://github.com/nodejs/node/pull/34470 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Anna Henningsen

commit sha 6a7e3c03fcd41d8afb6a8f6dc173233e3c356ab5

src: skip weak references for memory tracking The memory tracking is supposed to represent the “keeps-alive” relations between objects for a heap dump, in order to enable developers to figure out which objects keep which other objects on the heap. Weak references do not participate in that relation. Therefore, we should not be tracking them. PR-URL: https://github.com/nodejs/node/pull/34469 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha 0679076720f93314b2c5a37143c543314eb047f3

doc: remove breaking-change-helper from onboarding-extras I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: https://github.com/nodejs/node/pull/34497 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Rich Trott

commit sha c38bb43ca464ac0857e0805eba6062bf9fb0a1fd

doc: revise onboarding-extras Revise onboarding-extras for style guide conformance and minor wording improvements. PR-URL: https://github.com/nodejs/node/pull/34496 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 31ba9a20bdc1ce6245fec8d2cc52c9d92683bb14

test: run test-benchmark-napi on arm Necessary Makefile changes have happened. This now passes in CI. PR-URL: https://github.com/nodejs/node/pull/34502 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 7c02446aa777d3994b6a950c1dcf1bf2b6e97905

doc: use sentence-case for GOVERNANCE.md headers Use sentence-case in headers per style guide. PR-URL: https://github.com/nodejs/node/pull/34503 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Richard Lau

commit sha b2c08f279a6569acaa5d81ae2c88600cf16d93e0

build: don't run test-asan workflow on non-master pushes PR-URL: https://github.com/nodejs/node/pull/34509 Refs: https://github.com/nodejs/node/pull/34464 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

claudiahdz

commit sha db54b57042570e2f926673c2d2d2daba9533f922

deps: upgrade npm to 6.14.7 PR-URL: https://github.com/nodejs/node/pull/34468 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Richard Lau

commit sha 3e6b05e1aaeee8213f738450364acebf4b92128d

build: speed up source tarball creation Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: https://github.com/nodejs/node/pull/34508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

push time in 9 days

push eventrichardlau/node-1

Rich Trott

commit sha de192246bc29c43f387bc18024515cc475be152d

test: remove superfluous check in pummel/test-timers If setTimeout is not a function, this test and most other tests would fail. There is no need to check it. PR-URL: https://github.com/nodejs/node/pull/34488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Robert Nagy

commit sha e8d7fedf7cad6e612e4f2e0456e359af57608ac7

http: don't write error to socket The state of the connection is unknown at this point and writing to it can corrupt client state before it is aware of an error. PR-URL: https://github.com/nodejs/node/pull/34465 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 83ddb49d6dccaa99e87a58b85a7edd1b47f10568

src: prefer internal fields in ModuleWrap Use internal fields instead of `v8::Global`s where possible, since they generally come with lower overhead and it’s much harder to introduce memory leaks with them. PR-URL: https://github.com/nodejs/node/pull/34470 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Anna Henningsen

commit sha 6a7e3c03fcd41d8afb6a8f6dc173233e3c356ab5

src: skip weak references for memory tracking The memory tracking is supposed to represent the “keeps-alive” relations between objects for a heap dump, in order to enable developers to figure out which objects keep which other objects on the heap. Weak references do not participate in that relation. Therefore, we should not be tracking them. PR-URL: https://github.com/nodejs/node/pull/34469 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha 0679076720f93314b2c5a37143c543314eb047f3

doc: remove breaking-change-helper from onboarding-extras I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: https://github.com/nodejs/node/pull/34497 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Rich Trott

commit sha c38bb43ca464ac0857e0805eba6062bf9fb0a1fd

doc: revise onboarding-extras Revise onboarding-extras for style guide conformance and minor wording improvements. PR-URL: https://github.com/nodejs/node/pull/34496 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 31ba9a20bdc1ce6245fec8d2cc52c9d92683bb14

test: run test-benchmark-napi on arm Necessary Makefile changes have happened. This now passes in CI. PR-URL: https://github.com/nodejs/node/pull/34502 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 7c02446aa777d3994b6a950c1dcf1bf2b6e97905

doc: use sentence-case for GOVERNANCE.md headers Use sentence-case in headers per style guide. PR-URL: https://github.com/nodejs/node/pull/34503 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Richard Lau

commit sha b2c08f279a6569acaa5d81ae2c88600cf16d93e0

build: don't run test-asan workflow on non-master pushes PR-URL: https://github.com/nodejs/node/pull/34509 Refs: https://github.com/nodejs/node/pull/34464 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

claudiahdz

commit sha db54b57042570e2f926673c2d2d2daba9533f922

deps: upgrade npm to 6.14.7 PR-URL: https://github.com/nodejs/node/pull/34468 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Richard Lau

commit sha 3e6b05e1aaeee8213f738450364acebf4b92128d

build: speed up source tarball creation Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: https://github.com/nodejs/node/pull/34508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

push time in 9 days

PR closed richardlau/node-1

Update CI.yml needs commit message fix

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+52 -103

0 comment

7 changed files

richardlau

pr closed time in 11 days

PR closed richardlau/node-1

add lint action

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+51 -5

0 comment

4 changed files

richardlau

pr closed time in 11 days

PR opened nodejs/node

build: don't run test-asan workflow on non-master pushes

Refs: https://github.com/nodejs/node/pull/34464

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -0

0 comment

1 changed file

pr created time in 11 days

create barnchrichardlau/node-1

branch : asan

created branch time in 11 days

issue commentnodejs/node

addons/register-signal-handler/test and abort/test-addon-register-signal-handler failed

Stress run on test-iinthecloud-ibmi72-ppc64_be-1: https://ci.nodejs.org/job/node-stress-single-test/148/nodes=ibmi72-ppc64/

richardlau

comment created time in 11 days

more