profile
viewpoint
Bethany Nicolle Griggs BethGriggs IBM UK United Kingdom https://twitter.com/BethGriggs_ IBM Runtimes - Node.js Developer.

BethGriggs/music-recommender-system 4

A music recommendation app with Meteor

BethGriggs/ExodusWave 1

Global visualisation of population change over time

BethGriggs/multer 1

Node.js middleware for handling `multipart/form-data`.

BethGriggs/admin 0

Facilitating joint collaboration amongst the TSC and CommComm

BethGriggs/appmetrics 0

Node Application Metrics provides a foundational infrastructure for collecting resource and performance monitoring data for Node.js-based applications.

BethGriggs/appmetrics-prometheus 0

Module for providing a /metrics endpoint using data from appmetrics for use with Prometheus

BethGriggs/assay 0

noun 1. the testing of a metal or ore to determine its ingredients and quality.

BethGriggs/bethgriggs.github.io 0

Website under construction

BethGriggs/build 0

Better build and test infra for Node.

push eventnodejs/Release

Bethany Nicolle Griggs

commit sha 4c4fa468422243fc06dbfb13206138ab3b3c1053

doc: add minutes for 2020-05-21 (#580) Fixes: https://github.com/nodejs/Release/issues/579

view details

push time in 20 hours

push eventpkgjs/wiby

Beth Griggs

commit sha 792a81ab3c3522db7564e5dd733bf1a9d3b463f0

file: initial structure

view details

Beth Griggs

commit sha 199e7e30309bc9e7a7b8399d4bc42c2b24bf0d30

lint: add standard linter

view details

Beth Griggs

commit sha 9692bfbe746096b28add21f868895b2fcf0acab5

license: add Apache-2.0 license

view details

push time in a day

PR merged pkgjs/wiby

file: initial structure

I just started this to have an initial project structure that we can iterate on and open PR's against.

To do:

  • [ ] Make the tests actually test the commands
+370 -0

0 comment

8 changed files

BethGriggs

pr closed time in a day

push eventBethGriggs/wiby

Beth Griggs

commit sha 4e2573f6169a2b7f512fa7bd7e9b06998397a5ee

license: add Apache-2.0 license

view details

push time in a day

push eventBethGriggs/wiby

Beth Griggs

commit sha 276c4906a7c043f3dc40d7fd936611b0bfcad53b

lint: add standard linter

view details

push time in a day

PR opened pkgjs/wiby

file: initial structure

I just started this to have an initial project structure that we can iterate on and open PR's against.

To do:

  • [ ] Make the tests actually test the commands
+167 -0

0 comment

7 changed files

pr created time in a day

create barnchBethGriggs/wiby

branch : tdd

created branch time in a day

fork BethGriggs/multer

Node.js middleware for handling `multipart/form-data`.

fork in a day

fork BethGriggs/express

Fast, unopinionated, minimalist web framework for node.

https://expressjs.com

fork in a day

Pull request review commentpkgjs/wiby

doc: initial flow

 1. Open a draft PR in the dependents repository that contains the patched `package.json`. 1. `wiby` will create a JSON file (`wiby-v2.1.0.json`) which contains the links of dependent PRs that have been opened.

Ah, looking back this is unclear. I was thinking that the commit/branch/tag that we run against should be injected into the filename. But, that information could be stored within the file itself.

BethGriggs

comment created time in 4 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha 45e2b0cb96dd1384a3c61969e8e531b94b2f24de

Chapter 6: initial samples

view details

Beth Griggs

commit sha 4f825bdac3c21386924c6363fbab746f4555b267

Chapter 6: updates

view details

push time in 5 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha ed914ab3f0d26e24057fe552fc83cf4d3dcecc02

Chapter 7: postgres update

view details

push time in 6 days

push eventCloudNativeJS/cloud-health-connect

greenkeeper[bot]

commit sha 84a14e26e316c572801885c5c5e37b6cffb4908f

chore(package): update @types/sinon to version 9.0.4 (#66) Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>

view details

push time in 6 days

PR merged CloudNativeJS/cloud-health-connect

Update @types/sinon to the latest version 🚀 greenkeeper

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io


The devDependency @types/sinon was updated from 9.0.3 to 9.0.4.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: types License: MIT

Find out more about this release.


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+1 -1

1 comment

1 changed file

greenkeeper[bot]

pr closed time in 6 days

PR opened nodejs/Release

doc: ncu-team sync update

Fixes: https://github.com/nodejs/Release/issues/565

Nomination has been open a while

+1 -0

0 comment

1 changed file

pr created time in 6 days

create barnchBethGriggs/Release

branch : lts-team-update

created branch time in 6 days

issue closednodejs/Release

Conflicting Youtube Stream?

Hey there, over at https://github.com/expressjs/discussions/issues/115#issuecomment-612132143 I noticed something weird during our (Express') last meeting. When we tried to go live on youtube, Zoom pointed us to an already finished livestream of yours from 2 weeks ago. I'm assuming it also updated the title to what it is now "Express TSC Meeting" https://www.youtube.com/watch?v=kE1mY_k5oW4

Opened this to bring it to y'alls attention, I don't know what steps towards fixing this would be. I think @wesleytodd might know more.

closed time in 6 days

jonchurch

issue commentnodejs/Release

Conflicting Youtube Stream?

If I recall, the problem was fixed by @mhdawson making the specific release livestream video private. I just manually uploaded the video - https://youtu.be/u8wydgW90QY.

So this can be closed I think.

jonchurch

comment created time in 6 days

issue commentnodejs/Release

Imminent issue for Morocco users (tzdata2020a)

We discussed this in the release meeting today (#580).

nodejs/node#33362 has now landed on master. The PR has also been cherry-picked on to v14.x-staging, ready to go out in the next v14.x release. Unfortunately, that is unlikely to happen before the 24th May (based on our current release schedule).

apaprocki

comment created time in 6 days

PR opened nodejs/Release

doc: add minutes for 2020-05-21

Fixes: https://github.com/nodejs/Release/issues/579

+48 -0

0 comment

1 changed file

pr created time in 6 days

create barnchBethGriggs/Release

branch : 2020-05-21-minutes

created branch time in 6 days

issue commentnodejs/package-maintenance

PkgJS Org for WG supported tooling

@wesleytodd 👋 could I please be added to pkgjs? Planning to start working on wiby with @andrewhughes101

wesleytodd

comment created time in 6 days

issue closednodejs/Release

v12.16.0 post-mortem

Trying to document what went wrong with v12.16.0 (regressions) and what could be done in the future to reduce the risks.

ESM: Package self-resolution not behind --experimental-modules flag #31754.

  • The feature initially landed with its own flag, --experimental-resolve-self (https://github.com/nodejs/node/pull/29327).
  • The flag was then removed in https://github.com/nodejs/node/pull/31002 but --experimental-conditional-exports was still required to use the feature.
  • https://github.com/nodejs/node/pull/31001 removed the --experimental-conditional-exports flag.
  • When #31002 and #31001 landed, ESM was already unflagged on master/v13.x.

v12.16.0 included a lot of changes related to ESM and because the unflagging is the only thing that we did not backport, we couldn't know exactly which code paths will work differently. For future ESM backports, I suggest that we actively focus on making sure it is flagged.

V8 WASM bug #31752

Uncovered after https://github.com/nodejs/node/pull/30909 landed in v12.16.0. The change was initially released in v13.5.0 but no issue was reported before we included it in v12.16.0.

Because this is a V8 bug that we were not aware of at the time of the release, I don't think we could have done better here, especially since the original change was supposed to fix a regression.

large pages change breaks the build in some cases #31249, #31520

Introduced by https://github.com/nodejs/node/pull/30954. The second issue was fixed on master in https://github.com/nodejs/node/pull/31547 but isn't released yet. There seems to be no fix for the first issue at the moment.

The problem here is that none of the issues were linked back to the PR that introduced them. They do not appear in the PR's timeline. To avoid this happening again, I think we need somehow to instruct collaborators to do these when a regression is found:

  • Comment on the PR with a link to the new issue
  • If the PR is not going to be reverted on master, add the backport-blocked label
  • If the PR is going to be reverted on master, add the dont-land-on label to both the original and the revert PRs.

async_hooks change causes Node process to crash #31783

Introduced in https://github.com/nodejs/node/pull/30965. That bug was only reported to us after it landed in v12.16.0 and is now fixed.

http response listener throwing does not result in emit of uncaughtException #31796

Introduced in https://github.com/nodejs/node/pull/30236. That bug was only reported to us after it landed in v12.16.0 and is now fixed.

New enumerable and nonwritable field on EventEmitter caused issues #30932

Introduced in https://github.com/nodejs/node/pull/30932. That was only reported to us after it landed in v12.16.0.

It is not obvious to me what we could have done better about the last three issues. They only affect specific cases that we did not test for and were not detected by people who use or run their tests on v13.x Current.

closed time in 6 days

targos

issue commentnodejs/Release

v12.16.0 post-mortem

I think this issue documents our post-mortem. We also discussed this in the Working Group meeting on 2020-02-27.

I think this can be closed now, please reopen if you disagree.

targos

comment created time in 6 days

issue commentnodejs/Release

Release survey

@BridgeAR, is this something you'd like to leave open for us to consider in future? We've not discussed it in a while.

BridgeAR

comment created time in 6 days

issue closednodejs/Release

Release Schedule JSON

On the package maintenance wg call today we were discussing one of our initiatives to keep users testing on up-to-date LTS lines. In this effort we wanted to standardize grammar around the lines and build tooling around it.

In that tool I loaded the schedule from where I saw it in the website repo:

https://raw.githubusercontent.com/nodejs/nodejs.org/master/source/schedule.json

But it looks like this repo

https://github.com/nodejs/Release/blob/master/schedule.json

Which is the canonical source? Can we rely on this always existing? Is there anything we need to know so we can support this long term?

closed time in 6 days

wesleytodd

issue commentnodejs/Release

Release Schedule JSON

It does not appear that there is anything further for us to do here, but please let me know if you disagree and we can reopen.

wesleytodd

comment created time in 6 days

issue closednodejs/Release

Defining a word for all current releases

In discussing with a friend, I realized that we don't have an actual word for the corpus of releases that are currently being worked on / not EOL.

Here's a sentence as an example:

Node.js versions 6, 8, 10 are the only [word] releases currently. Soon Node.js version 11 will be be too.

Both of us instinctively reached for "Active" but that's currently a word used as a part of LTS terminology.

Node.js versions 6, 8, 10 are the only active releases currently. Soon Node.js version 11 will be be too.

As far as I know, we don't have a word that defines this. I think it's a useful word to define, as I've reached for some kind of word like this several times.

Some possibilities:

  • Circulated
  • Supported
  • Operating
  • Effective

closed time in 6 days

bnb

issue commentnodejs/Release

Defining a word for all current releases

We've updated our documentation in the README to state that we will use the word 'supported':

The term 'supported release lines' will be used to refer to all release lines that are not End-of-Life.

Package Maintenance are also adopting this terminology.

bnb

comment created time in 6 days

issue commentnodejs/Release

Release automation tooling

I think this issue has gone a little stale. I think we should close this, and open individual issues for the specific pieces automation we wish to target in future.

a tool that can automatically land backport PRs with the correct metadata, similar to git node land

Was been contributed by @andrewhughes101 and @AshCripps in https://github.com/nodejs/node-core-utils/pull/383 :tada:

automatically open PRs for conflicts, that contributors can pick up and resolve

I don't think we have had (nor are chasing) consensus on this process change.

BethGriggs

comment created time in 6 days

issue commentnodejs/Release

Node.js Release WorkGroup Meeting 2020-05-21

As we've had two items added to the agenda we'll go ahead with the meeting.

@nodejs/release

mhdawson

comment created time in 6 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha d8d40e12e55d590ac7fc4730ecc6d6428192f888

Chapter 2: arrow functions

view details

push time in 6 days

push eventBethGriggs/wiby

Beth Griggs

commit sha 71a593393554d60cfd0a1435a6539555a353d06a

doc: draft wiby.json structure

view details

push time in 7 days

push eventBethGriggs/wiby

Beth Griggs

commit sha 07d2a2cd263bd6b1565bee6604fd4bf41b464214

doc: capture further details

view details

push time in 7 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha 85007a687920180f5560989d70286798d25be15f

Chapter 7: prettier

view details

push time in 7 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha a0cf6a254c681b46acecc4ee9a479f5e269eff6b

Chapter 5: prettier

view details

push time in 7 days

Pull request review commentnodejs/package-maintenance

doc: add minutes for meeting 19 May 2020

+# Node.js  Package Maintenance Team Meeting 2020-05-19
+
+## Links
+
+* **Recording**: https://www.youtube.com/watch?v=6Es9c9Qk9Qs  
+* **GitHub Issue**: https://github.com/nodejs/package-maintenance/issues/361
+
+
+## Present
+
+* Michael Dawson (@mhdawson)
+* Lucas Holmquist (@lholmquist)
+* Andrew Hughes (@andrewhughes101)
+* Dominykas
+* Tierney Cyren (@bnb)
+* Owen Buckley (@thescientist13)
+* styfle
+* Andrew Hughes
+* Glenn Hinks (@ghinks)
* Glenn Hinks (@ghinks)
* Beth Griggs (@BethGriggs)
mhdawson

comment created time in 8 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha ce759b45a7cdc0fd9bab421bbc950cf8e6af2134

Chapter 2: file watching change

view details

push time in 8 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha 6213545e5e66786338e9d8854a307aee32dd06a9

Chapter 2: converge metadata examples

view details

push time in 8 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha 1df3b4ec78687fb51e7660aef06da4d7e50f673d

Chapter 2: edits

view details

push time in 8 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha 760ead3fdab701ba59c78d91814025582c54013e

Chapter 2: change back to use prettier

view details

push time in 8 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha dc1207007829ca5407c7890c84574f3d3a6b13a9

Chapter 2: standard and review edits

view details

push time in 9 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha db27978f0b8f9bca60f8171cfaad80ad8ea3099b

Chapter 2: standard and review edits

view details

push time in 9 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha a04093bfd445a9930f3f461b5de73f950ee4702c

Chapter 2: standard and review edits

view details

push time in 9 days

issue commentnodejs/Release

Node.js Release WorkGroup Meeting 2020-05-21

Agenda is looking minimal so far, please feel free to add topics to the agenda. If no other topics are added by Wednesday I'll propose cancelling.

mhdawson

comment created time in 9 days

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha adb2130b38a36909d974c49e60d20f7c8cb60a5f

Chapter 7: initial samples

view details

push time in 11 days

Pull request review commentpkgjs/wiby

doc: initial flow

 # wiby "Will I break you" - a tool for testing dependents++# Flow++1. Define the list of dependents you want to test against in a `wiby.json`.+1. Push the release candidate branch or tag to GitHub.+1. Indicate that you want to start your dependent tests by running `wiby test` locally while on your release candidate branch.+1. `wiby` will look for your defined list of dependents to test against in `wiby.json`.+1. For each module in the `wiby.json`, retrieve their `package.json` and determine whether the module is likely to automatically be updated to the new version of your module once it is released.+    - For example, if you're creating a release candidate for `v2.1.0-rc`, and the dependent module is using the range `^1.x.x`, then we should not open a test PR.+1. Patch the `package.json` of the dependent module to point to the release candidate branch for your module.+1. Open a draft PR in the dependents repository that contains the patched `package.json`.

Yeah using forks for testing makes sense to me to avoid noise. My concern would be whether it is easy to automate the whole flow using forks? I'm sure the 'fork repository' part would be reasonable to implement. But, would it involve enabling some CI related WebHooks or settings on the forked repository? What if the module is using credentials in their Travis or Actions set up, would we need to manually define those?

Another thought - if there are CI allowances (minutes, runs), using forks moves the cost to the person or organisation running the tool. I think I agree that the person running the tool should bear the resource cost of the testing.

BethGriggs

comment created time in 12 days

Pull request review commentpkgjs/wiby

doc: initial flow

 # wiby "Will I break you" - a tool for testing dependents++# Flow++1. Define the list of dependents you want to test against in a `wiby.json`.

ah, that's a good suggestion. I think the @pkgjs/dependents module should provide the all, random 10, and most download features to return the appropriate list of modules. Then wiby can call and parse the list (maybe via an option like wiby test random). We could then either default to looking for a wiby.json or pass that in directly with a file option wiby test --file ./wiby.json. I think as long as the file structure for the list of modules is consistent we should be okay to handle that case going forwards.

BethGriggs

comment created time in 12 days

Pull request review commentpkgjs/wiby

doc: initial flow

 # wiby "Will I break you" - a tool for testing dependents++# Flow++1. Define the list of dependents you want to test against in a `wiby.json`.+1. Push the release candidate branch or tag to GitHub.+1. Indicate that you want to start your dependent tests by running `wiby test` locally while on your release candidate branch.+1. `wiby` will look for your defined list of dependents to test against in `wiby.json`.+1. For each module in the `wiby.json`, retrieve their `package.json` and determine whether the module is likely to automatically be updated to the new version of your module once it is released.+    - For example, if you're creating a release candidate for `v2.1.0-rc`, and the dependent module is using the range `^1.x.x`, then we should not open a test PR.

Ah, we did not have major releases in mind. Maybe there should be a --major option? Or --force that would not do the 'Will you be automatically updated to this version?' check. But maybe that should be the default 🤔

The motivation behind this was to try and minimize the influx of draft PRs (especially if the dependent is unlikely to pickup the new release candidate version).

Another approach could be to allow maintainers to be able to opt-in to either/both applicable range and major updates in the wiby.json(final name/format TBD). Then external dependent maintainers can PR their module and indicate whether they want to be tested against majors in the wiby.json file.

BethGriggs

comment created time in 13 days

PR opened pkgjs/wiby

doc: initial flow

Before getting started writing the tool, we should define the expected flow of operation. @andrewhughes101 and I discussed this and tried to write down the end-to-end flow.

I have PR'd this to the README so that we can get line-by-line comments. All file names and formats are up for discussion.

Open questions from our discussion

  • Should the PR would be opened in the person running its name?
    • Would the tool therefore need to have access to generate a GitHub token?
  • Do we want the draft PRs to be merged?
    • Assuming not, so opens only a draft PR.
    • Would maintainers be upset that many draft PRs get opened and never merged?
  • Do we want this tool to execute on creation of a specific branch name pattern rather than manually kicking off runs locally?
    • If so, how and where would the wiby results be presented?

ping @dominykas @wesleytodd

+14 -0

0 comment

1 changed file

pr created time in 13 days

create barnchBethGriggs/wiby

branch : initial-flow

created branch time in 13 days

fork BethGriggs/wiby

"Will I break you" - a tool for testing dependents

fork in 13 days

push eventnodejs/Release

Bethany Nicolle Griggs

commit sha f87ebdc50ba257a7fbfa1a4f37a9a73e9e311a51

doc: add minutes for 2020-05-07 (#578) Fixes: https://github.com/nodejs/Release/issues/575

view details

push time in 14 days

PR merged nodejs/Release

doc: add minutes for 2020-05-07

Fixes: https://github.com/nodejs/Release/issues/575

Let me know if I missed you off of the attendees 🙏

+66 -0

0 comment

1 changed file

BethGriggs

pr closed time in 14 days

issue closednodejs/Release

Node.js Release WorkGroup Meeting 2020-05-07

Time

UTC Thu 07-May-2020 15:00 (03:00 PM):

Timezone Date/Time
US / Pacific Thu 07-May-2020 08:00 (08:00 AM)
US / Mountain Thu 07-May-2020 09:00 (09:00 AM)
US / Central Thu 07-May-2020 10:00 (10:00 AM)
US / Eastern Thu 07-May-2020 11:00 (11:00 AM)
London Thu 07-May-2020 16:00 (04:00 PM)
Amsterdam Thu 07-May-2020 17:00 (05:00 PM)
Moscow Thu 07-May-2020 18:00 (06:00 PM)
Chennai Thu 07-May-2020 20:30 (08:30 PM)
Hangzhou Thu 07-May-2020 23:00 (11:00 PM)
Tokyo Fri 08-May-2020 00:00 (12:00 AM)
Sydney Fri 08-May-2020 01:00 (01:00 AM)

Or in your local time:

  • http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Release%20WorkGroup+Meeting+2020-05-07&iso=20200507T15
  • or http://www.wolframalpha.com/input/?i=03PM+UTC%2C+May+07%2C+2020+in+local+time

Links

Agenda

Extracted from Release-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/Release

  • Release plan - v14.x Current #567

Invited

  • Release team: @nodejs/release
  • LTS team: @nodejs/lts

Observers/Guests

Notes

The agenda comes from issues labelled with Release-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

Join URL: https://zoom.us/j/157618869

Invitees

Please use the following emoji reactions in this post to indicate your availability.

  • :+1: - Attending
  • :-1: - Not attending
  • :confused: - Not sure

closed time in 14 days

mhdawson

pull request commentnodejs/node

v12.17.0 release proposal

As @richardlau mentioned, in the release shadowing session yesterday we went through and audited all of the minors (partially as an exercise of how we vet/audit PRs).

The only two PRs we had concerns with were:

  • https://github.com/nodejs/node/pull/31814
    • The PR had linked issues that mentioned got and semantic-release breakages. It looks like got is currently skipped with CITGM so we may not detect any regressions.
    • citgm got run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/833/
  • https://github.com/nodejs/node/pull/32860 (as mentioned)

But, will defer to your judgement on those @targos

targos

comment created time in 14 days

PR opened nodejs/Release

doc: add minutes for 2020-05-07

Fixes: https://github.com/nodejs/Release/issues/575

Let me know if I missed you off of the attendees 🙏

+66 -0

0 comment

1 changed file

pr created time in 16 days

push eventBethGriggs/Release

Beth Griggs

commit sha 1d3dd2e582d11a2a767b3011875a5d5de513ca45

doc: add minutes for 2020-05-07 Fixes: https://github.com/nodejs/Release/issues/575

view details

push time in 16 days

create barnchBethGriggs/Release

branch : 2020-05-07-minutes

created branch time in 16 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

I can reproduce the issue locally, with Node built locally - both using vcbuild release and plain vcbuild. Can confirm that this is caused by 4143c74.

@bzoz, just to confirm, you're building locally with VS 2019?

nicolo-ribaudo

comment created time in 20 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

@BethGriggs It's been almost an hour and the build is still in staging. Did your test from yesterday get moved automatically?

@targos I think your first build might not be promoted due to the promotion script expecting a specific format - https://github.com/nodejs/build/issues/2309#issuecomment-620351966 My test build uploaded itself after around 30 minutes.

nicolo-ribaudo

comment created time in 22 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

@targos recent changes to our caching means it can take up to ~30minutes for a build to be available on our download server, so you may hit that.

nicolo-ribaudo

comment created time in 22 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

@mcollina I did an rc.0 build for v14.1.0 on f8789177f9 (that was prior to pulling in additional requested V8 and streams PR's IIRC). It might be worth trying - https://nodejs.org/download/rc/v14.1.0-rc.0/

I'm also thinking in some way could this be a VS 2019 vs VS 2017 issue? Just based on the release machine and @targos using VS 2019 and not being able to reproduce the issue.

Along ping @nodejs/build in case something has changed with our Windows release infrastructure recently

nicolo-ribaudo

comment created time in 22 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

For Windows builds our Release CI calls vcbuild.bat build-release x64 upload. This is building on Windows 2012 R2 (Rackspace) with Visual Studio 2019.

11:46:03 c:\ws>vcbuild.bat build-release x64 upload 
11:46:03 Looking for Python
11:46:03 Python found in C:\Python27\\python.exe
11:46:03 Looking for NASM
11:46:03 Looking for Visual Studio 2019
11:46:03 Looking for WiX installation for Visual Studio 2019...
11:46:03 calling: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\\Auxiliary\Build\vcvarsall.bat" amd64
11:46:04 **********************************************************************
11:46:04 ** Visual Studio 2019 Developer Command Prompt v16.5.4
11:46:04 ** Copyright (c) 2019 Microsoft Corporation
11:46:04 **********************************************************************
11:46:04 [vcvarsall.bat] Environment initialized for: 'x64'
11:46:04 Found MSVS version 16.0
11:46:04 configure  --with-ltcg --release-urlbase=https://nodejs.org/download/test/ "--download=all" --with-intl=full-icu --dest-cpu=x64 --tag=test202005049ffd8e7a74
11:46:11 Node.js configure: Found Python 2.7.18...
11:46:11 Warning: Missing input files:
11:46:11 tools\msvs\genfiles\node_etw_provider.rc
11:46:11 tools\msvs\genfiles\node_etw_provider.h
11:46:11 INFO: configure completed successfully
nicolo-ribaudo

comment created time in 23 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

I ran a test rebuild of the v14.1.0 release commit 9ffd8e7a74 on the Node.js infrastructure - this could rule out whether anything obscure went wrong with the published release build.

https://nodejs.org/download/test/v14.1.0-test202005049ffd8e7a74/

nicolo-ribaudo

comment created time in 23 days

pull request commentCloudNativeJS/cloud-health-connect

chore: add dependabot config

@sam-github, it's possible that the test changes were due to a TypeScript related dependency update. I cannot see what the changes were, but I think it's possibility.

npm test runs a TypeScript build, so if there's any change in the TypeScript output then npm test will cause changes in the generated files.

sam-github

comment created time in a month

push eventIBM/nodejs-in-the-cloud

Bethany Nicolle Griggs

commit sha 400760e9505472b30799071d15cb3f94cd289b47

doc: fix links

view details

push time in a month

PR opened IBM/nodejs-in-the-cloud

doc: fix links
+4 -4

0 comment

1 changed file

pr created time in a month

create barnchBethGriggs/nodejs-in-the-cloud-1

branch : fix-links

created branch time in a month

push eventIBM/nodejs-in-the-cloud

imgbot[bot]

commit sha 3a0e387da44020f5b7da9171f54c710169ed4eaf

[ImgBot] Optimize images *Total -- 2,850.50kb -> 1,912.84kb (32.89%) /images/kab-workshop-codewind-shell-commands.png -- 103.17kb -> 40.22kb (61.01%) /images/kab-workshop-codewind-template-sources.png -- 173.61kb -> 110.29kb (36.47%) /images/kab-workshop-codewind-performance-test.png -- 272.85kb -> 178.06kb (34.74%) /images/grafana_monitor.png -- 123.47kb -> 80.59kb (34.72%) /images/grafana_home.png -- 204.28kb -> 133.91kb (34.45%) /images/grafana_datasource.png -- 138.37kb -> 92.09kb (33.45%) /images/kab-workshop-codewind-performance-test-2.png -- 330.24kb -> 219.81kb (33.44%) /images/kab-workshop-codewind-performance-2.png -- 346.79kb -> 233.49kb (32.67%) /images/kab-workshop-codewind-performance.png -- 252.89kb -> 170.46kb (32.59%) /images/grafana_metric.png -- 147.66kb -> 100.38kb (32.02%) /images/prom_graph2.png -- 124.96kb -> 85.63kb (31.48%) /images/grafana_import.png -- 87.59kb -> 60.29kb (31.17%) /images/prometheus_graph.png -- 74.14kb -> 53.10kb (28.39%) /images/kab-workshop-codewind-new-nodejs.png -- 47.06kb -> 34.36kb (26.99%) /images/kab-workshop-new-project.png -- 30.00kb -> 22.17kb (26.09%) /images/kab-workshop-codewind-nodejs-running.png -- 55.10kb -> 41.29kb (25.07%) /images/kab-workshop-codewind-shell.png -- 284.80kb -> 213.56kb (25.01%) /images/kab-workshop-codewind-launch-nodejs.png -- 53.52kb -> 43.14kb (19.38%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>

view details

push time in a month

PR merged IBM/nodejs-in-the-cloud

[ImgBot] Optimize images

Beep boop. Your images are optimized!

Your image file size has been reduced by 33% 🎉

<details> <summary> Details </summary>

File Before After Percent reduction
/images/kab-workshop-codewind-shell-commands.png 103.17kb 40.22kb 61.01%
/images/kab-workshop-codewind-template-sources.png 173.61kb 110.29kb 36.47%
/images/kab-workshop-codewind-performance-test.png 272.85kb 178.06kb 34.74%
/images/grafana_monitor.png 123.47kb 80.59kb 34.72%
/images/grafana_home.png 204.28kb 133.91kb 34.45%
/images/grafana_datasource.png 138.37kb 92.09kb 33.45%
/images/kab-workshop-codewind-performance-test-2.png 330.24kb 219.81kb 33.44%
/images/kab-workshop-codewind-performance-2.png 346.79kb 233.49kb 32.67%
/images/kab-workshop-codewind-performance.png 252.89kb 170.46kb 32.59%
/images/grafana_metric.png 147.66kb 100.38kb 32.02%
/images/prom_graph2.png 124.96kb 85.63kb 31.48%
/images/grafana_import.png 87.59kb 60.29kb 31.17%
/images/prometheus_graph.png 74.14kb 53.10kb 28.39%
/images/kab-workshop-codewind-new-nodejs.png 47.06kb 34.36kb 26.99%
/images/kab-workshop-new-project.png 30.00kb 22.17kb 26.09%
/images/kab-workshop-codewind-nodejs-running.png 55.10kb 41.29kb 25.07%
/images/kab-workshop-codewind-shell.png 284.80kb 213.56kb 25.01%
/images/kab-workshop-codewind-launch-nodejs.png 53.52kb 43.14kb 19.38%
Total : 2,850.50kb 1,912.84kb 32.89%

</details>


📝docs | :octocat: repo | 🙋issues | 🏅swag | 🏪marketplace

+0 -0

0 comment

18 changed files

imgbot[bot]

pr closed time in a month

push eventIBM/nodejs-in-the-cloud

Beth Griggs

commit sha 33220e4231ec7ebe5e44b4847274d18d9b3c7a90

workshop: initial Think 2020 lab

view details

push time in a month

push eventnodejs/nodejs.org

Bethany Nicolle Griggs

commit sha 739a6110f9495ac186075a8839c3316ebc57b74d

Blog: v13.14.0 release post (#3148) Refs: https://github.com/nodejs/node/pull/33122

view details

push time in a month

PR merged nodejs/nodejs.org

Blog: v13.14.0 release post

Refs: https://github.com/nodejs/node/pull/33122

+216 -0

0 comment

1 changed file

BethGriggs

pr closed time in a month

push eventBethGriggs/nodejs.org

Bethany Nicolle Griggs

commit sha c6fac668a6580b62fe6fc3352e079cef5c5c86c1

Blog: v14.1.0 release post (#3145) Refs: https://github.com/nodejs/node/pull/33103

view details

Bethany Nicolle Griggs

commit sha 8ceacc74134ade30b33a5b31c42aa590a81e58ce

Merge branch 'master' into v13.14.0-blog

view details

push time in a month

PR opened nodejs/nodejs.org

Blog: v13.14.0 release post

Refs: https://github.com/nodejs/node/pull/33122

+216 -0

0 comment

1 changed file

pr created time in a month

create barnchBethGriggs/nodejs.org

branch : v13.14.0-blog

created branch time in a month

issue commentnodejs/Release

Release plan - v10.x Active LTS

I didn't think it was unintentional, #517 aimed to generalise our policy to the following:

Maintenance - Critical bug fixes and security updates. New features may be added at the discretion of the LTS team - typically only in cases where the new feature supports migration to later release lines.

Refs: https://github.com/nodejs/Release/pull/517#issuecomment-595450000

But with that being said, I wouldn't be against calling out the N-API exemption specifically again.

BethGriggs

comment created time in a month

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha bcf782f7dc6161b08145a552c1c73225c6f1954a

Chapter 4: initial recipe samples

view details

push time in a month

push eventBethGriggs/Node-Cookbook

Beth Griggs

commit sha 042443a11f515aa5611dc45e004f01f457bf85c0

Chapter 4: intial recipe samples

view details

push time in a month

push eventnodejs/nodejs.org

Bethany Nicolle Griggs

commit sha c6fac668a6580b62fe6fc3352e079cef5c5c86c1

Blog: v14.1.0 release post (#3145) Refs: https://github.com/nodejs/node/pull/33103

view details

push time in a month

PR merged nodejs/nodejs.org

Blog: v14.1.0 release post

Refs: https://github.com/nodejs/node/pull/33103

+187 -0

0 comment

1 changed file

BethGriggs

pr closed time in a month

delete branch nodejs/node

delete branch : v14.x-proposal

delete time in a month

delete branch nodejs/node

delete branch : v14.1.0-proposal

delete time in a month

release nodejs/node

v14.1.0

released time in a month

PR opened nodejs/nodejs.org

Blog: v14.1.0 release post

Refs: https://github.com/nodejs/node/pull/33103

+187 -0

0 comment

1 changed file

pr created time in a month

create barnchBethGriggs/nodejs.org

branch : v14.1.0-blog

created branch time in a month

created tagnodejs/node

tagv14.1.0

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

created time in a month

push eventnodejs/node

Beth Griggs

commit sha 49db211846cb984c4f8955cd1bb2c9be374311ae

2020-04-29, Version 14.1.0 (Current) Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](https://github.com/nodejs/node/pull/32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](https://github.com/nodejs/node/pull/32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](https://github.com/nodejs/node/pull/32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](https://github.com/nodejs/node/pull/33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](https://github.com/nodejs/node/pull/32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](https://github.com/nodejs/node/pull/32858) - stream: - don't emit end after close (Robert Nagy) [#33076](https://github.com/nodejs/node/pull/33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](https://github.com/nodejs/node/pull/33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](https://github.com/nodejs/node/pull/32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](https://github.com/nodejs/node/pull/32985) PR-URL: https://github.com/nodejs/node/pull/33103

view details

push time in a month

push eventnodejs/node

Beth Griggs

commit sha 9ffd8e7a7414052834bfedb0daba68d5c8363884

2020-04-29, Version 14.1.0 (Current) Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](https://github.com/nodejs/node/pull/32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](https://github.com/nodejs/node/pull/32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](https://github.com/nodejs/node/pull/32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](https://github.com/nodejs/node/pull/33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](https://github.com/nodejs/node/pull/32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](https://github.com/nodejs/node/pull/32858) - stream: - don't emit end after close (Robert Nagy) [#33076](https://github.com/nodejs/node/pull/33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](https://github.com/nodejs/node/pull/33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](https://github.com/nodejs/node/pull/32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](https://github.com/nodejs/node/pull/32985) PR-URL: https://github.com/nodejs/node/pull/33103

view details

Beth Griggs

commit sha a87dfd2c6e33a1345abaeb2ebdba0464eb09822b

Working on v14.1.1 PR-URL: https://github.com/nodejs/node/pull/33103

view details

push time in a month

push eventnodejs/node

Juan José Arboleda

commit sha 87605f0ed3c07c2825cba2182720c378b4704a3a

doc: add juanarbol as collaborator PR-URL: https://github.com/nodejs/node/pull/32906 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Michael Dawson

commit sha fc71a85c499f1ceacfdd3e037cae597a008815fb

doc: add N-API version 6 to table We missed adding version 6 to the compatibility table when we defined version 6. Add it along with the versions that we know will include version 6. PR-URL: https://github.com/nodejs/node/pull/32829 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Juan José Arboleda

commit sha ca7e0a226e0ccb86cccd80d6f2b5facb7ad32d5d

src: remove redundant v8::HeapSnapshot namespace PR-URL: https://github.com/nodejs/node/pull/32854 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Anna Henningsen

commit sha 22ccf2ba1f37ed2457d9017de85d424d20310ea6

tools: decrease timeout in test.py This fixes the following crash on Windows for me. I don't know why this I only started to see this now, but anyway, the new timeout value is still longer than a week and a half. File "tools/test.py", line 1725, in <module> sys.exit(Main()) File "tools/test.py", line 1701, in Main if RunTestCases(cases_to_run, options.progress, \ options.j, options.flaky_tests): File "tools/test.py", line 923, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 145, in Run thread.join(timeout=10000000) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1015, in join self._wait_for_tstate_lock(timeout=max(timeout, 0)) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1027, in _wait_for_tstate_lock elif lock.acquire(block, timeout): OverflowError: timeout value is too large PR-URL: https://github.com/nodejs/node/pull/32868 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

Nimit

commit sha 307e43da4d17b07a6dfbd7cc34459df32df3ef63

src: elevate v8 namespaces elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: https://github.com/nodejs/node/pull/32872 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Nimit

commit sha b12204e27e2e68f223160cec6489388b46a8616e

test: changed function to arrow function Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: https://github.com/nodejs/node/pull/32875 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha ccf6d3e5ed22c506d64ab3eac65d704e6b4af945

doc: add `tsc-agenda` to onboarding labels list PR-URL: https://github.com/nodejs/node/pull/32832 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Robert Nagy

commit sha 2ab4ebc8bf86457b0b37e224f231ee90ca75a0d3

stream: simplify Writable.end() Simplifies Writable.end() by inlining and de-duplicating code. PR-URL: https://github.com/nodejs/node/pull/32882 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Robert Nagy

commit sha 7f498125e4523bde026290142fab6626f293fd28

stream: inline unbuffered _write PR-URL: https://github.com/nodejs/node/pull/32886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Vadzim Zieńka

commit sha 36a4f54d69d7c4e5114df5be083f650dd2cfda87

stream: close iterator in Readable.from Call iterator.return() if not all of its values are consumed. Fixes: https://github.com/nodejs/node/issues/32842 PR-URL: https://github.com/nodejs/node/pull/32844 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

David Daza

commit sha b957895ff73f574b29e3ce49ed1dbb4a31124158

lib: remove unnecesary else block The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: https://github.com/nodejs/node/pull/32644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Jesus Hernandez

commit sha 03d02d74f3ba4874ee510ea9bc49b989a193396c

fs: remove unnecessary else statement PR-URL: https://github.com/nodejs/node/pull/32662 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Juan José Arboleda

commit sha f9b8988df6cd5527aa13a93fe05e443f57b7d78e

src: remove validation of unreachable code Based on https://github.com/nodejs/help/issues/2600#issuecomment-612857153 the condition (amount < 0) won't be possible. PR-URL: https://github.com/nodejs/node/pull/32818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Gabriel Schulhof

commit sha 861eb39307d68640305ad8cb456ecfa8ed25ffa3

n-api: detect deadlocks in thread-safe function We introduce status `napi_would_deadlock` to be used as a return status by `napi_call_threadsafe_function` if the call is made with `napi_tsfn_blocking` on the main thread and the queue is full. Fixes: https://github.com/nodejs/node/issues/32615 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32860 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Rich Trott

commit sha a8ed8f5d0a973f00a17a5e702cbf3c055a22508a

doc: synch SECURITY.md with website Refs: https://github.com/nodejs/nodejs.org/pull/3106#issuecomment-614258785 PR-URL: https://github.com/nodejs/node/pull/32903 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

rickyes

commit sha a133ac17eb846fbd2dcb59d4151d2150b3afa51b

perf_hooks: remove unnecessary assignment when name is undefined PR-URL: https://github.com/nodejs/node/pull/32910 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

rickyes

commit sha baa823172842754bfb5e8eb7646c6a751253c72f

fs: extract kWriteFileMaxChunkSize constant PR-URL: https://github.com/nodejs/node/pull/32640 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

雨夜带刀

commit sha 57c170c75cf3351cf14b3f93a135dfc241d53df0

doc: fix typo in zlib.md PR-URL: https://github.com/nodejs/node/pull/32901 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

karan singh virdi

commit sha 68b7c80a446662802fc3a35d50895f4f9e1ce1b9

doc: fix usage of folder and directory terms in fs.md This commit fixes the interchangeably usage of "folder" and "directory" terms in fs.md Fixes: https://github.com/nodejs/node/issues/32902 PR-URL: https://github.com/nodejs/node/pull/32919 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Andrey Pechkurov

commit sha c9ae385abf6b865a20cbbb06a862c0da28917ccc

test: mark test-child-process-fork-args as flaky on Windows PR-URL: https://github.com/nodejs/node/pull/32950 Refs: https://github.com/nodejs/node/issues/32863 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

push time in a month

PR merged nodejs/node

v14.1.0 proposal build doc meta openssl v14.x

2020-04-29, Version 14.1.0 (Current), @BethGriggs

Notable Changes

  • deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32971
  • doc: add juanarbol as collaborator (Juan José Arboleda) #32906
  • http: doc deprecate abort and improve docs (Robert Nagy) #32807
  • module: do not warn when accessing __esModule of unfinished exports (Anna Henningsen) #33048
  • n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) #32860
  • src: deprecate embedder APIs with replacements (Anna Henningsen) #32858
  • stream:
    • don't emit end after close (Robert Nagy) #33076
    • don't wait for close on legacy streams (Robert Nagy) #33058
    • pipeline should only destroy un-finished streams (Robert Nagy) #32968
  • vm: add importModuleDynamically option to compileFunction (Gus Caplan) #32985

Commits

  • [1af08e1c5e] - buffer,n-api: fix double ArrayBuffer::Detach() during cleanup (Anna Henningsen) #33039
  • [91e30e35a1] - build: fix vcbuild error for missing Visual Studio (Thomas) #32658
  • [4035cbe631] - cluster: removed unused addressType argument from constructor (Yash Ladha) #32963
  • [56f50aeff0] - deps: patch V8 to 8.1.307.31 (Michaël Zasso) #33080
  • [fad188fe23] - deps: update archs files for OpenSSL-1.1.1g (Hassaan Pasha) #32971
  • [b12f1630fc] - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32971
  • [b50333e001] - deps: V8: backport 3f8dc4b2e5ba (Ujjwal Sharma) #32993
  • [bbed1e56cd] - deps: V8: cherry-pick e1eac1b16c96 (Milad Farazmand) #32974
  • [3fed735099] - doc: fix LTS replaceme tags (Anna Henningsen) #33041
  • [343c6ac639] - doc: assign missing deprecation code (Richard Lau) #33109
  • [794b8796dd] - doc: improve WHATWG url constructor code example (Liran Tal) #32782
  • [14e559df87] - doc: make openssl maintenance position independent (Sam Roberts) #32977
  • [8a4de2ef25] - doc: improve release documentation (Michaël Zasso) #33042
  • [401ab610e7] - doc: document major finished changes in v14 (Robert Nagy) #33065
  • [a534d8282c] - doc: add documentation for transferList arg at worker threads (Juan José Arboleda) #32881
  • [f116825d56] - doc: avoid tautology in README (Ishaan Jain) #33005
  • [7e9f88e005] - doc: updated directory entry information (Eileen) #32791
  • [bf331b4e21] - doc: ignore no-literal-urls in README (Nick Schonning) #32676
  • [f92b398c76] - doc: convert bare email addresses to mailto links (Nick Schonning) #32676
  • [2bde11607d] - doc: ignore no-literal-urls in changelogs (Nick Schonning) #32676
  • [71f90234f9] - doc: add angle brackets around implicit links (Nick Schonning) #32676
  • [aec7bc754e] - doc: remove repeated word in modules.md (Prosper Opara) #32931
  • [005c2bab29] - doc: elevate diagnostic report to tier1 (Gireesh Punathil) #32732
  • [4dd3a7ddc9] - doc: set module version 83 to node 14 (Gerhard Stoebich) #32975
  • [b5b3efeb90] - doc: add more info to v14 changelog (Gus Caplan) #32979
  • [f6be140222] - doc: fix typo in security-release-process.md (Edward Elric) #32926
  • [fa710732bf] - doc: corrected ERR_SOCKET_CANNOT_SEND message (William Armiros) #32847
  • [68b7c80a44] - doc: fix usage of folder and directory terms in fs.md (karan singh virdi) #32919
  • [57c170c75c] - doc: fix typo in zlib.md (雨夜带刀) #32901
  • [a8ed8f5d0a] - doc: synch SECURITY.md with website (Rich Trott) #32903
  • [ccf6d3e5ed] - doc: add tsc-agenda to onboarding labels list (Rich Trott) #32832
  • [fc71a85c49] - doc: add N-API version 6 to table (Michael Dawson) #32829
  • [87605f0ed3] - doc: add juanarbol as collaborator (Juan José Arboleda) #32906
  • [4c643c0d42] - fs: update validateOffsetLengthRead in utils.js (daemon1024) #32896
  • [baa8231728] - fs: extract kWriteFileMaxChunkSize constant (rickyes) #32640
  • [03d02d74f3] - fs: remove unnecessary else statement (Jesus Hernandez) #32662
  • [31c797cb11] - http: doc deprecate abort and improve docs (Robert Nagy) #32807
  • [4ef91a640e] - http2: wait for secureConnect before initializing (Benjamin Coe) #32958
  • [6fc4d174b5] - http2: refactor and cleanup http2 (James M Snell) #32884
  • [4b6aa077fe] - inspector: only write coverage in fully bootstrapped Environments (Joyee Cheung) #32960
  • [737bd6205b] - lib: unnecessary const assignment for class (Yash Ladha) #32962
  • [98b30b06ff] - lib: simplify function process.emitWarning (himself65) #32992
  • [b957895ff7] - lib: remove unnecesary else block (David Daza) #32644
  • [cb4d8ce889] - module: refactor condition (Myles Borins) #32989
  • [4abc45a4b9] - module: do not warn when accessing \_\_esModule of unfinished exports (Anna Henningsen) #33048
  • [21d314e7fc] - module: exports not exported for null resolutions (Guy Bedford) #32838
  • [eaf841d585] - module: improve error for invalid package targets (Myles Borins) #32052
  • [8663fd5f88] - module: partial doc removal of --experimental-modules (Myles Borins) #32915
  • [68656cf588] - n-api: fix false assumption on napi_async_context structures (legendecas) #32928
  • [861eb39307] - (SEMVER-MINOR) n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) #32860
  • [a133ac17eb] - perf_hooks: remove unnecessary assignment when name is undefined (rickyes) #32910
  • [59b64adb79] - src: add AsyncWrapObject constructor template factory (Stephen Belanger) #33051
  • [23eda417b6] - src: do not compare against wide characters (Christopher Beeson) #32921
  • [d10c2c6968] - src: fix empty-named env var assertion failure (Christopher Beeson) #32921
  • [44c157e45d] - src: assignment to valid type (Yash Ladha) #32879
  • [d82c3c28de] - src: delete MicroTaskPolicy namespace (Juan José Arboleda) #32853
  • [bc755fc4c2] - src: fix compiler warnings in node_http2.cc (Daniel Bevenius) #33014
  • [30c2b0f798] - (SEMVER-MINOR) src: deprecate embedder APIs with replacements (Anna Henningsen) #32858
  • [95e897edfc] - src: use using NewStringType (rickyes) #32843
  • [4221b1c8c9] - src: fix null deref in AllocatedBuffer::clear (Matt Kulukundis) #32892
  • [f9b8988df6] - src: remove validation of unreachable code (Juan José Arboleda) #32818
  • [307e43da4d] - src: elevate v8 namespaces (Nimit) #32872
  • [ca7e0a226e] - src: remove redundant v8::HeapSnapshot namespace (Juan José Arboleda) #32854
  • [ae157b8ca7] - (SEMVER-MINOR) stream: don't emit end after close (Robert Nagy) #33076
  • [184e80a144] - stream: don't wait for close on legacy streams (Robert Nagy) #33058
  • [e07c4ffc39] - stream: fix sync write perf regression (Robert Nagy) #33032
  • [2bb4ac409b] - stream: avoid drain for sync streams (Robert Nagy) #32887
  • [c21f1f03c5] - stream: removes unnecessary params (Jesus Hernandez) #32936
  • [4c10b5f378] - stream: consistent punctuation (Robert Nagy) #32934
  • [1a2b3eb3a4] - stream: fix broken pipeline test (Robert Nagy) #33030
  • [7abc61f668] - stream: refactor Writable buffering (Robert Nagy) #31046
  • [180b935b58] - stream: pipeline should only destroy un-finished streams (Robert Nagy) #32968
  • [7647860000] - stream: finished should complete with read-only Duplex (Robert Nagy) #32967
  • [36a4f54d69] - stream: close iterator in Readable.from (Vadzim Zieńka) #32844
  • [7f498125e4] - stream: inline unbuffered _write (Robert Nagy) #32886
  • [2ab4ebc8bf] - stream: simplify Writable.end() (Robert Nagy) #32882
  • [11ea13f96c] - test: refactor test-async-hooks-constructor (himself65) #33063
  • [8fad112d93] - test: remove timers-blocking-callback (Jeremiah Senkpiel) #32870
  • [988c2fe287] - test: better error validations for event-capture (Adrian Estrada) #32771
  • [45e188b2e3] - test: refactor events tests for invalid listeners (Adrian Estrada) #32769
  • [b4ef06267d] - test: test-async-wrap-constructor prefer forEach (Daniel Estiven Rico Posada) #32631
  • [c9ae385abf] - test: mark test-child-process-fork-args as flaky on Windows (Andrey Pechkurov) #32950
  • [b12204e27e] - test: changed function to arrow function (Nimit) #32875
  • [323da6f251] - tls: add highWaterMark option for connect (rickyes) #32786
  • [308681307f] - tls: move getAllowUnauthorized to internal/options (James M Snell) #32917
  • [6a8e266a3b] - tools: update ESLint to 7.0.0-rc.0 (himself65) #33062
  • [fa7d969237] - tools: remove unused code in doc generation tool (Rich Trott) #32913
  • [ca5ebcfb67] - tools: fix mkcodecache when run with ASAN (Anna Henningsen) #32850
  • [22ccf2ba1f] - tools: decrease timeout in test.py (Anna Henningsen) #32868
  • [c82c08416f] - util,readline: NFC-normalize strings before getStringWidth (Anna Henningsen) #33052
  • [4143c747fc] - (SEMVER-MINOR) vm: add importModuleDynamically option to compileFunction (Gus Caplan) #32985
  • [c84d802449] - worker: fix process.env var empty key access (Christopher Beeson) #32921
+16086 -11659

20 comments

468 changed files

BethGriggs

pr closed time in a month

push eventnodejs/node

Beth Griggs

commit sha 9ffd8e7a7414052834bfedb0daba68d5c8363884

2020-04-29, Version 14.1.0 (Current) Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](https://github.com/nodejs/node/pull/32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](https://github.com/nodejs/node/pull/32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](https://github.com/nodejs/node/pull/32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](https://github.com/nodejs/node/pull/33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](https://github.com/nodejs/node/pull/32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](https://github.com/nodejs/node/pull/32858) - stream: - don't emit end after close (Robert Nagy) [#33076](https://github.com/nodejs/node/pull/33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](https://github.com/nodejs/node/pull/33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](https://github.com/nodejs/node/pull/32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](https://github.com/nodejs/node/pull/32985) PR-URL: https://github.com/nodejs/node/pull/33103

view details

push time in a month

pull request commentnodejs/node

v14.1.0 proposal

@ronag, do you know if #33133 is likely to land soon? I've seen that it is fast-tracked, but there have been changes since.

I am looking to start rerunning builds in the next hour or two.

BethGriggs

comment created time in a month

push eventnodejs/node

Robert Nagy

commit sha 184e80a1446518b6f120978f20464c3c1e28c7a5

stream: don't wait for close on legacy streams Try to detect non standard streams and don't wait for 'close' on these. In particular if we detected that destroyed is true before we expect it to be then fallback to compat behavior. Fixes: https://github.com/nodejs/node/issues/33050 PR-URL: https://github.com/nodejs/node/pull/33058 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Juan José Arboleda

commit sha a534d8282c986e2ba01d412228c9e24efe1814c6

doc: add documentation for transferList arg at worker threads Ref: https://github.com/nodejs/node/pull/32278 PR-URL: https://github.com/nodejs/node/pull/32881 Refs: https://github.com/nodejs/node/pull/32278 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Christopher Beeson

commit sha c84d802449f8b1082052ca46678861d17e06602e

worker: fix process.env var empty key access PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Christopher Beeson

commit sha d10c2c69686d774a1e654f00fd05f8f6126d476a

src: fix empty-named env var assertion failure Setting an environment variable with an empty name on Windows resulted in an assertion failure, because it was checked for an '=' sign at the beginning without verifying the length was greater than 0. Fixes: https://github.com/nodejs/node/issues/32920 Refs: https://github.com/nodejs/node/pull/27310 PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Christopher Beeson

commit sha 23eda417b66a671ad9c50378c9063345e69794ee

src: do not compare against wide characters PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Yash Ladha

commit sha 4035cbe63134dd72070341b6df2af65cef9f2bdd

cluster: removed unused addressType argument from constructor When intializing the constructor for cluster master we are heavily using a generic structure, but the effect of passing arguments that are related to shared_handle is that there is a stale argument passed. We can avoid such scenarios as all the remaining entities are being destructured from the message object. PR-URL: https://github.com/nodejs/node/pull/32963 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Anna Henningsen

commit sha 4abc45a4b9d4a6e5ad682ec85ea9f5988671392e

module: do not warn when accessing `__esModule` of unfinished exports Since this property access is performed by generated code, and not used for accessing the actual exports of a module (and because transpilers generally define it as the first key of `module.exports` when it *is* present), it should be okay to allow it. Refs: https://github.com/nodejs/node/pull/29935 Fixes: https://github.com/nodejs/node/issues/33046 PR-URL: https://github.com/nodejs/node/pull/33048 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anna Henningsen

commit sha c82c08416f6d5911695a71166219974d9e8ba347

util,readline: NFC-normalize strings before getStringWidth The assumption here is that decomposed characters render like their composed character equivalents, and that working with the former comes with a risk of over-estimating string widths given that we compute them on a per-code-point basis. The regression test added here (한글 vs 한글) is an example of that happening. PR-URL: https://github.com/nodejs/node/pull/33052 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

himself65

commit sha 11ea13f96cc0eba89be6500e96d25a73f9c3a41e

test: refactor test-async-hooks-constructor PR-URL: https://github.com/nodejs/node/pull/33063 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 401ab610e746ed69b99d5505d1e630e11ea77b17

doc: document major finished changes in v14 Added description of semver-major changes to finished in v14. PR-URL: https://github.com/nodejs/node/pull/33065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Stephen Belanger

commit sha 59b64adb79434540157dd8d13883c0cacb908d05

src: add AsyncWrapObject constructor template factory PR-URL: https://github.com/nodejs/node/pull/33051 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Michaël Zasso

commit sha 8a4de2ef255973660ab4160f6e80df6e9c228a90

doc: improve release documentation Extract the "Cherry-pick the Release Commit to master" part to its own section and be more precise about what should be done to handle conflicts. PR-URL: https://github.com/nodejs/node/pull/33042 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Myles Borins

commit sha cb4d8ce889b3c5f41d9937a750476a3d983536ec

module: refactor condition PR-URL: https://github.com/nodejs/node/pull/32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Sam Roberts

commit sha 14e559df879511597532e46356170caf9ead0ea2

doc: make openssl maintenance position independent It used to have some `cd` commands that if done literally would invalidate the subsequent commands. Modify them to be more accurate, which also simplifies pasting them directly into the console from the guide while doing an update. PR-URL: https://github.com/nodejs/node/pull/32977 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Thomas

commit sha 91e30e35a1a69f11259ee1957d6071f40b1a709c

build: fix vcbuild error for missing Visual Studio The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio. PR-URL: https://github.com/nodejs/node/pull/32658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Liran Tal

commit sha 794b8796dd7fa48aa25c22a904fd4c5427fdf057

doc: improve WHATWG url constructor code example Currently, the URL docs for the WHATWG URL spec support are somewhat lacking in their code example of how to access the new URL constructor that lives inside the core url package. PR-URL: https://github.com/nodejs/node/pull/32782 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Richard Lau

commit sha 343c6ac63909f14f614e4bd694c74e48cc79a2cd

doc: assign missing deprecation code Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33109 Refs: https://github.com/nodejs/node/pull/32807 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

legendecas

commit sha 68656cf5889aed1c8b9d79289c19f804f2fe97a3

n-api: fix false assumption on napi_async_context structures napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: https://github.com/nodejs/node/pull/32928 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

himself65

commit sha 6a8e266a3ba6cd2fae012346afc390890c1c4f8b

tools: update ESLint to 7.0.0-rc.0 PR-URL: https://github.com/nodejs/node/pull/33062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Anna Henningsen

commit sha 3fed735099333c65c5e3a1a30da391d0eca8829d

doc: fix LTS replaceme tags When cherry-picking release commits for LTS releases into master, the `REPLACEME` metadata can be taken over as well, to give users a more accurate view of what is being released on which release line. This addresses this problem for all previous LTS releases for which this has not been done. Fixes: https://github.com/nodejs/node/issues/33001 PR-URL: https://github.com/nodejs/node/pull/33041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

push time in a month

push eventnodejs/node

Robert Nagy

commit sha 184e80a1446518b6f120978f20464c3c1e28c7a5

stream: don't wait for close on legacy streams Try to detect non standard streams and don't wait for 'close' on these. In particular if we detected that destroyed is true before we expect it to be then fallback to compat behavior. Fixes: https://github.com/nodejs/node/issues/33050 PR-URL: https://github.com/nodejs/node/pull/33058 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Juan José Arboleda

commit sha a534d8282c986e2ba01d412228c9e24efe1814c6

doc: add documentation for transferList arg at worker threads Ref: https://github.com/nodejs/node/pull/32278 PR-URL: https://github.com/nodejs/node/pull/32881 Refs: https://github.com/nodejs/node/pull/32278 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Christopher Beeson

commit sha c84d802449f8b1082052ca46678861d17e06602e

worker: fix process.env var empty key access PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Christopher Beeson

commit sha d10c2c69686d774a1e654f00fd05f8f6126d476a

src: fix empty-named env var assertion failure Setting an environment variable with an empty name on Windows resulted in an assertion failure, because it was checked for an '=' sign at the beginning without verifying the length was greater than 0. Fixes: https://github.com/nodejs/node/issues/32920 Refs: https://github.com/nodejs/node/pull/27310 PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Christopher Beeson

commit sha 23eda417b66a671ad9c50378c9063345e69794ee

src: do not compare against wide characters PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Yash Ladha

commit sha 4035cbe63134dd72070341b6df2af65cef9f2bdd

cluster: removed unused addressType argument from constructor When intializing the constructor for cluster master we are heavily using a generic structure, but the effect of passing arguments that are related to shared_handle is that there is a stale argument passed. We can avoid such scenarios as all the remaining entities are being destructured from the message object. PR-URL: https://github.com/nodejs/node/pull/32963 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Anna Henningsen

commit sha 4abc45a4b9d4a6e5ad682ec85ea9f5988671392e

module: do not warn when accessing `__esModule` of unfinished exports Since this property access is performed by generated code, and not used for accessing the actual exports of a module (and because transpilers generally define it as the first key of `module.exports` when it *is* present), it should be okay to allow it. Refs: https://github.com/nodejs/node/pull/29935 Fixes: https://github.com/nodejs/node/issues/33046 PR-URL: https://github.com/nodejs/node/pull/33048 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anna Henningsen

commit sha c82c08416f6d5911695a71166219974d9e8ba347

util,readline: NFC-normalize strings before getStringWidth The assumption here is that decomposed characters render like their composed character equivalents, and that working with the former comes with a risk of over-estimating string widths given that we compute them on a per-code-point basis. The regression test added here (한글 vs 한글) is an example of that happening. PR-URL: https://github.com/nodejs/node/pull/33052 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

himself65

commit sha 11ea13f96cc0eba89be6500e96d25a73f9c3a41e

test: refactor test-async-hooks-constructor PR-URL: https://github.com/nodejs/node/pull/33063 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 401ab610e746ed69b99d5505d1e630e11ea77b17

doc: document major finished changes in v14 Added description of semver-major changes to finished in v14. PR-URL: https://github.com/nodejs/node/pull/33065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Stephen Belanger

commit sha 59b64adb79434540157dd8d13883c0cacb908d05

src: add AsyncWrapObject constructor template factory PR-URL: https://github.com/nodejs/node/pull/33051 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Michaël Zasso

commit sha 8a4de2ef255973660ab4160f6e80df6e9c228a90

doc: improve release documentation Extract the "Cherry-pick the Release Commit to master" part to its own section and be more precise about what should be done to handle conflicts. PR-URL: https://github.com/nodejs/node/pull/33042 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Myles Borins

commit sha cb4d8ce889b3c5f41d9937a750476a3d983536ec

module: refactor condition PR-URL: https://github.com/nodejs/node/pull/32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Sam Roberts

commit sha 14e559df879511597532e46356170caf9ead0ea2

doc: make openssl maintenance position independent It used to have some `cd` commands that if done literally would invalidate the subsequent commands. Modify them to be more accurate, which also simplifies pasting them directly into the console from the guide while doing an update. PR-URL: https://github.com/nodejs/node/pull/32977 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Thomas

commit sha 91e30e35a1a69f11259ee1957d6071f40b1a709c

build: fix vcbuild error for missing Visual Studio The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio. PR-URL: https://github.com/nodejs/node/pull/32658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Liran Tal

commit sha 794b8796dd7fa48aa25c22a904fd4c5427fdf057

doc: improve WHATWG url constructor code example Currently, the URL docs for the WHATWG URL spec support are somewhat lacking in their code example of how to access the new URL constructor that lives inside the core url package. PR-URL: https://github.com/nodejs/node/pull/32782 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Richard Lau

commit sha 343c6ac63909f14f614e4bd694c74e48cc79a2cd

doc: assign missing deprecation code Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33109 Refs: https://github.com/nodejs/node/pull/32807 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

legendecas

commit sha 68656cf5889aed1c8b9d79289c19f804f2fe97a3

n-api: fix false assumption on napi_async_context structures napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: https://github.com/nodejs/node/pull/32928 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

himself65

commit sha 6a8e266a3ba6cd2fae012346afc390890c1c4f8b

tools: update ESLint to 7.0.0-rc.0 PR-URL: https://github.com/nodejs/node/pull/33062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Anna Henningsen

commit sha 3fed735099333c65c5e3a1a30da391d0eca8829d

doc: fix LTS replaceme tags When cherry-picking release commits for LTS releases into master, the `REPLACEME` metadata can be taken over as well, to give users a more accurate view of what is being released on which release line. This addresses this problem for all previous LTS releases for which this has not been done. Fixes: https://github.com/nodejs/node/issues/33001 PR-URL: https://github.com/nodejs/node/pull/33041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

push time in a month

pull request commentnodejs/node

v14.1.0 proposal

Thank you for diagnosing @ronag, for this release i'll back out 3c07b17 (The next v14.x release is due next week.)

BethGriggs

comment created time in a month

pull request commentnodejs/node

v14.1.0 proposal

CITGM is showing new errors with ws on all platforms. These errors do not occur on v14.0.0. Probably related to one of the streams updates @nodejs/streams?

 4 failing
   1) createWebSocketStream
        The returned stream
          does not error if `_final()` is called while connecting:
      Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/iojs/tmp/citgm_tmp/33a3bbbc-c7fa-4116-9be7-193ba315e008/ws/test/create-websocket-stream.test.js)
       at listOnTimeout (internal/timers.js:549:17)
       at processTimers (internal/timers.js:492:7)
   2) createWebSocketStream
        The returned stream
          handles backpressure (1/3):
      Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/iojs/tmp/citgm_tmp/33a3bbbc-c7fa-4116-9be7-193ba315e008/ws/test/create-websocket-stream.test.js)
       at listOnTimeout (internal/timers.js:549:17)
       at processTimers (internal/timers.js:492:7)
   3) createWebSocketStream
        The returned stream
          handles backpressure (2/3):
      Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/iojs/tmp/citgm_tmp/33a3bbbc-c7fa-4116-9be7-193ba315e008/ws/test/create-websocket-stream.test.js)
       at listOnTimeout (internal/timers.js:549:17)
       at processTimers (internal/timers.js:492:7)
   4) createWebSocketStream
        The returned stream
          handles backpressure (3/3):
      Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/iojs/tmp/citgm_tmp/33a3bbbc-c7fa-4116-9be7-193ba315e008/ws/test/create-websocket-stream.test.js)
       at listOnTimeout (internal/timers.js:549:17)
       at processTimers (internal/timers.js:492:7)

I'll need to rerun CITGM and builds to include #33133 - which means the release may be pushed until tomorrow (no concerns pushing it to tomorrow myself).

BethGriggs

comment created time in a month

push eventnodejs/node

Robert Nagy

commit sha 7647860000f07a3ed57cc78d92a6e9e6bcc64b58

stream: finished should complete with read-only Duplex If passed a Duplex where readable or writable has been explicitly disabled then don't assume 'close' will be emitted. Fixes: https://github.com/nodejs/node/issues/32965 PR-URL: https://github.com/nodejs/node/pull/32967 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Milad Farazmand

commit sha bbed1e56cd910e0a4f55290b4fa3dbf9b6157ca7

deps: V8: cherry-pick e1eac1b16c96 Original commit message: Fix compilation error with devtoolset-8 We are compiling V8 using devtoolset-8 and it is generating a new compilation error related to String Truncation: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 and 15 bytes from a string of length 15 [-Werror=stringop-truncation] strncpy(buffer, unicode_utf8, i); Which basically means the null terminating character was not added to the end of the buffer: https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/ This CL will changes 2 uses of "strncpy" to "memcpy" as strings are being copied partially and `\n` being added at a later stage. Change-Id: I3656afb00463d70ddb8700a487a1978b793e1d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2155038 Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67277} Refs: https://github.com/v8/v8/commit/e1eac1b16c966879102c2310d7649637227eaa02 PR-URL: https://github.com/nodejs/node/pull/32974 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

view details

Robert Nagy

commit sha 180b935b5890b7ef78cc65ab0dfd469654a12344

stream: pipeline should only destroy un-finished streams This PR logically reverts https://github.com/nodejs/node/pull/31940 which has caused lots of unnecessary breakage in the ecosystem. This PR also aligns better with the actual documented behavior: `stream.pipeline()` will call `stream.destroy(err)` on all streams except: * `Readable` streams which have emitted `'end'` or `'close'`. * `Writable` streams which have emitted `'finish'` or `'close'`. The behavior introduced in https://github.com/nodejs/node/pull/31940 was much more aggressive in terms of destroying streams. This was good for avoiding potential resources leaks however breaks some common assumputions in legacy streams. Furthermore, it makes the code simpler and removes some hacks. Fixes: https://github.com/nodejs/node/issues/32954 Fixes: https://github.com/nodejs/node/issues/32955 PR-URL: https://github.com/nodejs/node/pull/32968 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com>

view details

Robert Nagy

commit sha 7abc61f668255fc8ac829a71afcbddcf02a1281c

stream: refactor Writable buffering Refactors buffering in Writable to use an array instead of a linked list. PR-URL: https://github.com/nodejs/node/pull/31046 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Robert Nagy

commit sha 1a2b3eb3a4744c2a802c3b9b7e0752e63b47099b

stream: fix broken pipeline test An unfortunate overlap between two PR that by themselves pass CI but together pass a test. https://github.com/nodejs/node/pull/32967 changes so that pipeline does not wait for 'close'. https://github.com/nodejs/node/pull/32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: https://github.com/nodejs/node/pull/33030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Daniel Estiven Rico Posada

commit sha b4ef06267d97eca0bfd734cf3be0ae31267b1716

test: test-async-wrap-constructor prefer forEach PR-URL: https://github.com/nodejs/node/pull/32631 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Nick Schonning

commit sha 71f90234f906e16bac0b1c423684a0c61c2598dd

doc: add angle brackets around implicit links PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Nick Schonning

commit sha 2bde11607d24af7f00d11bbfb10af16b9e559441

doc: ignore no-literal-urls in changelogs PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Nick Schonning

commit sha f92b398c76d8273aa8e74358ca7b8ba70ec55cd4

doc: convert bare email addresses to mailto links reflowed for line length after increased url size PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Nick Schonning

commit sha bf331b4e21f3a76c99e65c45668747aa7a3a0787

doc: ignore no-literal-urls in README Membership lists are currently formatted in a specific way for tooling PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

himself65

commit sha 98b30b06ff8ef32b70be2b4e5fcf867a41f1d45f

lib: simplify function process.emitWarning PR-URL: https://github.com/nodejs/node/pull/32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 30c2b0f79895a269dc62d769764c4ad0b11b9b1a

src: deprecate embedder APIs with replacements Implement a number of TODO comments aiming at the eventual removal of some embedder APIs that now have replacements available. PR-URL: https://github.com/nodejs/node/pull/32858 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Adrian Estrada

commit sha 45e188b2e3d64bdc8e96396e27db73209f116ae1

test: refactor events tests for invalid listeners PR-URL: https://github.com/nodejs/node/pull/32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Eileen

commit sha 7e9f88e0053010c47923656d55ff59d09baddea9

doc: updated directory entry information Fixes: https://github.com/nodejs/node/issues/25595 subdirectory updated def PR-URL: https://github.com/nodejs/node/pull/32791 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Adrian Estrada

commit sha 988c2fe287031261576aa8a11aba4e5d30459bae

test: better error validations for event-capture PR-URL: https://github.com/nodejs/node/pull/32771 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Robert Nagy

commit sha 4c10b5f3787ad473c6c4203dfd7e4dd0637346b6

stream: consistent punctuation Cleanup comments to use consistent punctuation. PR-URL: https://github.com/nodejs/node/pull/32934 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Daniel Bevenius

commit sha bc755fc4c25c64b10f647cf48950d4e067a20d99

src: fix compiler warnings in node_http2.cc Currently, the following compiler warnings are generated: ../src/node_http2.cc: In static member function ‘static int node::http2::Http2Session::OnStreamClose(nghttp2_session*, int32_t, uint32_t, void*)’: ../src/node_http2.cc:994:16: warning: variable ‘def’ set but not used [-Wunused-but-set-variable] 994 | Local<Value> def = v8::False(env->isolate()); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Ping( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2755:16: warning: unused variable ‘env’ [-Wunused-variable] 2755 | Environment* env = Environment::GetCurrent(args); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Settings( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2774:16: warning: unused variable ‘env’ [-Wunused-variable] 2774 | Environment* env = Environment::GetCurrent(args); | ^~~ This commit removes these unused variables. PR-URL: https://github.com/nodejs/node/pull/33014 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Juan José Arboleda

commit sha d82c3c28de818119334bbe6484e5faa4dbf40146

src: delete MicroTaskPolicy namespace PR-URL: https://github.com/nodejs/node/pull/32853 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Yash Ladha

commit sha 737bd6205b8b21eb0e412bdd7860e1a08dc3b45c

lib: unnecessary const assignment for class PR-URL: https://github.com/nodejs/node/pull/32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Joyee Cheung

commit sha 4b6aa077feb7b9526c059e5099f4709fa5435931

inspector: only write coverage in fully bootstrapped Environments The NODE_V8_COVERAGE folder and the source map computation are setup during pre-execution since they rely on environment variables as well as JS states. Therefore, we need to give up serialization of JS coverage profiles for Environments that have not go through pre-execution. Currently this is only possible for Environments created using the embedder API CreateEnvironment(). As a result we won't have JS coverage data for most cctests, but if that proves to be necessary we could just run lib/internal/main/environment.js for these Environments created for cctests. Fixes: https://github.com/nodejs/node/issues/32912 Refs: https://github.com/nodejs/node/commit/65e18a8e9f912dfa04a804124b6a19514bb45165 Refs: https://github.com/nodejs/node/commit/5bf43729a403b992cc90b5cdbbaaf505769d1107 https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 PR-URL: https://github.com/nodejs/node/pull/32960 Refs: https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in a month

more