profile
viewpoint
Colin Ihrig cjihrig Pittsburgh, PA node.js tsc, libuv collaborator, hapi core team member. also does things with wasm/wasi and grpc

cjihrig/credit-card 89

Credit card validation

cjihrig/grpc-server-js 53

Pure JavaScript gRPC Server

autopilotpattern/postgres 13

Implementation of the Autopilot Pattern for Postgres

cjihrig/bcrypt.wasm 11

bcrypt in WebAssembly

cjihrig/grpc-benchmarking 10

Benchmarking, but for gRPC

cjihrig/artificial 9

Inject fake HTTP request/response into an Express server

cjihrig/belly-button 8

The best source for lint

cjihrig/ghostbuster 7

A Node.js wrapper for PhantomJS

cjihrig/farmhash.wasm 3

WebAssembly implementation of Google FarmHash

cjihrig/graylogi 3

Graylog logger for hapi

delete branch cjihrig/node

delete branch : wasi-test

delete time in 2 hours

PR merged nodejs/node

test: add WASI test for file resizing test

This commit adds a WASI test to cover the following functions:

  • __wasi_fd_filestat_set_size()
  • __wasi_fd_tell()
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines
+40 -0

9 comments

3 changed files

cjihrig

pr closed time in 2 hours

push eventnodejs/node

cjihrig

commit sha 2abbaddca98d668538d8bba39502803ab050f4c3

test: add WASI test for file resizing This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: https://github.com/nodejs/node/pull/31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 2 hours

push eventcjihrig/node

Rich Trott

commit sha 62c44af5c5f2964849bba92ff90c32e867d63f83

doc: move sebdeckers to emeritus Confirmed in email with sebdeckers that they can be moved to emeritus. PR-URL: https://github.com/nodejs/node/pull/34298 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha f9402b23fd0eeae317af593498c3434e984310ae

src: add GetCipherValue function This commit extracts the code that is the same in GetCipherName, GetCipherStandardName, and GetCipherVersion into function named GetCipherValue. The motivation for this change is to improve readabilty by removing the duplicated code. PR-URL: https://github.com/nodejs/node/pull/34287 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha eabe22b73371e59838f5ff501804aca3aae9f4a9

src: use FromMaybe instead of ToLocal in GetCert PR-URL: https://github.com/nodejs/node/pull/34276 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Mateusz Krawczuk

commit sha 2e6c3e2301cb443a72c3659fffa24815b4660815

tls: make 'createSecureContext' honor more options Added options: `ticketKeys` and `sessionTimeout`, that are honored by `createServer`, that calls `createSecureContext`. This also introduces a minor code simplification. PR-URL: https://github.com/nodejs/node/pull/33974 Fixes: https://github.com/nodejs/node/issues/20908 Reviewed-By: Alba Mendez <me@alba.sh> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

view details

Michaël Zasso

commit sha 913d36d97da187a3804f6cfa96b4d24a8b7be78a

build: recommend Python 3.8 to build on Windows PR-URL: https://github.com/nodejs/node/pull/34182 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Michaël Zasso

commit sha 12478684aab233942e0d5dc24f195930c8a5e59d

deps: update V8 to 8.4.371.19 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Michaël Zasso

commit sha eba5aafae007a859986bb19238ed5d8e97b879f6

build: reset embedder string to "-node.0" PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Michaël Zasso

commit sha b7cf8234100b0527cae325b5470f03dd137e3a94

src: update NODE_MODULE_VERSION to 86 Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.4. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Refael Ackermann

commit sha 95743dcd2501f104ecce104bdc9bf91932bd4b92

deps: V8: un-cherry-pick bd019bd Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=​machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Ujjwal Sharma

commit sha b78847c99acd2f5342a1d40f422a24ab420a127f

deps: patch V8 to run on older XCode versions Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Refael Ackermann

commit sha 34d8c079886efeae41ba190559da98fbd313e3a2

deps: V8: patch register-arm64.h Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Refael Ackermann

commit sha 5682e6eed74a9c9f6b185c0e9472e08345a9d356

deps: V8: forward declaration of `Rtl*FunctionTable` This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Joao Reis

commit sha b1456e3a7bee9733720081843711cc943f031abc

deps: make v8.h compatible with VS2015 There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Michaël Zasso

commit sha 106a4f4be5e07de364083cea5b995a82044faf16

deps: V8: silence irrelevant warnings PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Matheus Marchini

commit sha edaa56bb60eac20554de807cfcd9d873081b0ab6

deps: patch V8 to run on Xcode 8 Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Michaël Zasso

commit sha 32eb50aeec5b37951efc9038972b9fd4a4426488

deps: V8: cherry-pick 9868b2aefa1a Original commit message: Fix SmartOS compilation errors This commit resolves compilation errors on SmartOS that were found while upgrading Node.js. See: https://github.com/nodejs/node/pull/32831 Change-Id: Ia2a2e028ba4f5bfd69c050cab4fb4e13af5eefd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191054 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67793} Refs: https://github.com/v8/v8/commit/9868b2aefa1af2f1a173856b5d31efa4c2ac2833 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Jiawen Geng

commit sha 87933b5885350ef417324704c203ae6da0e88593

deps: V8: fix compilation on VS2017 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Joyee Cheung

commit sha d7905fcc518d18c5719208387432aaaf4df585cd

deps: V8: backport 22014de00115 Original commit message: Reland "[snapshot] rehash JSMap and JSSet during deserialization" This is a reland of 8374feed55a5b3010f2e9593560a2d84f9f6725f. Fixed rehashing of global proxy keys by creating its identity hash early, before the deserialization of the context snapshot. Original change's description: > [snapshot] rehash JSMap and JSSet during deserialization > > To rehash JSMap and JSSet, we simply replace the backing store > with a new one created with the new hash. > > Bug: v8:9187 > Change-Id: I90c25b18b33b7bc2b6ffe1b89fe17aa5f978b517 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143983 > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67663} Bug: v8:9187, v8:10523 Change-Id: I7a0319b1d10ff07644de902fec43e7c2b1dd8da9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2212085 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#67999} Refs: https://github.com/v8/v8/commit/22014de00115dae09ae3d4a6c3a9f178d5495ef2 PR-URL: https://github.com/nodejs/node/pull/33300 Refs: https://github.com/v8/v8/commit/ea0719b8ed087d1f511e78595dcb596faa7638d0 Refs: https://github.com/v8/v8/commit/bb9f0c2b2fe920a717794f3279758846f59f7840 Refs: https://github.com/nodejs/node/issues/17058 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Stephen Belanger

commit sha e432470ed2ea5210cc4b70cedab2aaec6addfbe6

deps: V8: cherry-pick eec10a2fd8fa Original commit message: [promisehook] Add before/after hooks to thenable tasks This will allow Node.js to properly track async context in thenables. Change-Id: If441423789a78307a57ad7e645daabf551cddb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Gus Caplan <me@gus.host> Cr-Commit-Position: refs/heads/master@{#68207} Refs: https://github.com/v8/v8/commit/eec10a2fd8fa4d0e7f5e32dedbd239d938a5dd87 PR-URL: https://github.com/nodejs/node/pull/33778 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

cjihrig

commit sha 03cc3fd47834d383a9e2a72d8993390aeeddc5e2

deps: update V8 postmortem metadata script This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation for V8 8.4. PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

push time in 2 hours

PR opened nodejs/node

test: handle app already signed error

In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition.

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines
+7 -4

0 comment

1 changed file

pr created time in 13 hours

push eventcjihrig/node

cjihrig

commit sha 45522894beb5de23f48a127a3d6576405bafdbea

test: handle app already signed error In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition.

view details

push time in 14 hours

create barnchcjihrig/node

branch : macos

created branch time in 15 hours

push eventcjihrig/node

cjihrig

commit sha 85fbf7175e628fb8f892c2c0886f74e5562635f4

tools: update ESLint to 7.2.0 Update ESLint to 7.2.0 PR-URL: https://github.com/nodejs/node/pull/33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

view details

Derek Lewis

commit sha c17d2f99018ae48ed82a90a9eccc570ed1ae83c6

esm: fix loader hooks doc annotations Prior to this commit, the type annotations on the ESM loader hooks were invalid. This has been corrected and is ensured to be compatible with both the TypeScript and Closure type systems. Notes: https://www.typescriptlang.org/play/index.html?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+kArsgDZQwIrpYDyARgFYCmAxrhTwD2RXFwAeuSAAoe1ZFxE0AnpC5p4uJQEp6cJKgyYAYpSJ8CwigBMuAM0SUauAOJdcRwcjSJcu2PNxqImwsAAVkQTQCbC4AHkxIW09vXAAuSDxCUkgyAD4yemBwcXhPSURsJTNE03NhSBI3Dy8fKWoaABpIIRFxXC6be0cXJuSfLSwoSAJbaQBZHwALADpUIitIqQncyAAGZYBWCYTgYEgAZUiubuErAlwLImWpyEhTyGaMq8hPSEQaGiQACqACUADLYAaCL5oa6yPCRSA0QQkAg8RK-GyiLzEYgkDEtXDPV6vd4AQRoAHdEEoQgEgn8iD9OLxJIJZrhFtckl4sDyUulYpk8fkupSufJIJyuC83md+T5piFhNd2VKuRl8HiQsR1ddcIg2DRrobBAA3LjEkn05BMzCy14KtKQADkaEEVkcXBdHVlZAA3FMCqSzgAROxcZBS6EAOQ9lo4IR5fwBP2lUdBEKtNqZgwcTlc7jGuDatC6PVEEgGdnzIyLhK0gbIQA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520url%250A%2520*%2520%2540param%2520%257BObject%257D%2520context%2520(currently%2520empty)%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultGetFormat%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520format%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520getFormat(url%252C%2520context%252C%2520defaultGetFormat)%2520%257B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520URLs%252C%2520do%2520some%2520custom%2520logic%2520for%2520determining%2520format.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Bformat%253A%2520%253Cstring%253E%257D%252C%2520where%2520the%250A%2520%2520%2520%2520%252F%252F%2520format%2520is%2520one%2520of%2520the%2520strings%2520in%2520the%2520table%2520above.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520format%253A%2520'module'%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520URLs.%250A%2520%2520return%2520defaultGetFormat(url%252C%2520context%252C%2520defaultGetFormat)%253B%250A%257D https://www.typescriptlang.org/play/?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkfSyakVwBVAEoAZAFyQAhAAo8hUpAA+kAK5EAJtSZFq2gJQAaXn1oB7HQVwFr2GQoCCyVAE8APEuIkAfKa8ZBRWwtQAHri8HKgYmABiWrR21hS6DIgaADa4YtTYllkAbtTRgrgayETYWAoACsiWaATY1J6YmshZMj4qZAFkbMDgEfCWyLiQiNjuRLSQDEkpRJCCBcXUijT0TCwmkKG4Ebj76Zk5eeslRlhQBw6THQJCopKQALyQRNlZkBSfh2OAG47oxIPIALKIXAACwAdKgdE15Dc-JAAAxwgCsNw6wGAkAAyk1qPcbMs4Xc+PjIPFxpQSZB6Ygsr8qHRGMxkNhTpYGWhSbQNHgmpAspYSAR5gx6WtCkVfJS+NSCc4sgB3RDuGrlSorRArSwAIwAVnRJpYGJBYaSZcg4pVupBvPhfH4yErlbqqrdlcrHTJnsJxBJIAB+Kl+r7UdWQENbDm7ZD7IOvCRGOEwwRWqSRv0GWPx9k7LkZrN6Mx+sggviDPhgyHQ+GI7TIm6eDHY3GQGnOIiWG3IMnaWz2IielWQADqMKEBxZWV8kAABmdsrl8vLqMv9japsgSBoBcIarQDZAjaS0JYR7ttHDIABJFawlqRmln1qQWwAchqiG0EcVANAdZyHIoWQ0W16TQaFaBhJdQhHZYWUgUZxlwbAJ1WagKh9NcLk3DYExLPZfSjOFKMBSJKyjJDRwcGQAG1KLhajcDY6xkLHHlIB-EDBwAWno5YfwAXVo2sjBrP47hpAARPQWGtPkADkb2oOETRqO0plZJlB0obZORYLC7m9FYCI3K5NmLEzkzJI4aMgKzLi3aTwDIIA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%2520%2520conditions%253A%2520!(Array%253Cstring%253E)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257B!(Promise%253C%257B%2520url%253A%2520string%2520%257D%253E)%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257D https://www.typescriptlang.org/play/?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+kArsgDZQwIrpaaQBmA9smorgFyQ8hUpDIUAxhyK4ApgA9c9OElQZMAMUpFxuAlIoATGW0SUauAOIzcAZQ7VxMpbGTXqRbFgAKyDmgLYMgA8rNj2yI4CAIQAFDYAFigyBgCCyKgAngBClGxsMsiQAD6C+MQkxZAAqsS4ABxpmQCUogB8ZPTA4PLwXLiQiNgZ2uxaOnpEkCTWdg4yMdQ0ADSQktLyuCtGJmaWM+GOLZhQq1J4WOxcPP0UALyn6woA3CcEbJAxALK88QB0qEQDH4Yi1WpAAAy-ACsR0gwGAkDsaBkDwMBF0Ul+J0gcIR6i4gj8KIJiBoNGqACUADLYLYcQnI1aUPB+SA0DgkAjiS6FVxlGQAN3KkFw8RRYTmWJxOPhkBSNAA7ogMp4+e4BpMOAAjABWMh0kA471FKM43CwEoiMgEQSE5SKWty+WQ7Sl0rVyEmx2l0stkUgAHJfsGA0tsaIXjiOjKEQARYwFEX0gByHCMvx1njNAzJhpNhSq1Owbo9k22pnMVlsB3mixWa1kCi2xgre2rcyaLzIQA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520url%250A%2520*%2520%2540param%2520%257B%257B%2520format%253A%2520string%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultGetSource%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520source%253A%2520!(SharedArrayBuffer%2520%257C%2520string%2520%257C%2520Uint8Array)%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520getSource(url%252C%2520context%252C%2520defaultGetSource)%2520%257B%250A%2520%2520const%2520%257B%2520format%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520URLs%252C%2520do%2520some%2520custom%2520logic%2520for%2520retrieving%2520the%2520source.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Bsource%253A%2520%253Cstring%257Cbuffer%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520source%253A%2520'...'%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520URLs.%250A%2520%2520return%2520defaultGetSource(url%252C%2520context%252C%2520defaultGetSource)%253B%250A%257D https://www.typescriptlang.org/play/?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwIQAoDKAFigKYAmAgsqgJ4BCArgGZMnKQA+kAzgC7IBLAHYBzTpACqw3gA4qtAJQBfHgHsGyAMYkoMBCnRZMuyKY0AbAFw9+wkQBoTppquRpEva30GjH0SEoqmqpCvCQAHrwm+qgYmABiDEKavAIhKmQkTIgM5rwAKqhC3C5u+OpaOv6wyCS8GsVYAArIqmgC3CQAPJhqGtrWeESklNSI9Mys7FzeduJSoXJjNAoBAHxKusDgEfCuvJCI3DTJkExJKWlCkPyIxaVo5f0kuNwV2vaQwaERvJ+Z2VyBSKJVcj3eJFWxlM3z4WEgFk+Dw8AUgAF4viEwpEANxQSACJiQXAAWQ8hAAdEUyG1cKs1pAAAwUgCsUMgwGAkHKaBImKEZAEqRCFPxpk5kHirjUvMg0sQ5nMkgASgAZbj-VQyvmaBh8NqQcyqEQCTRnaVoVSCpg0Oa8Qh8t7PUWmcVcijmADu424kFq9WQ1zucoARgArEgpOVE+18h5YJ2VaxdWaiDghyZsDYu13+hpYMWuxMDSAAcgpFdLfldSjxpk2bsgABEsmwblqAHJWkgUsO+0qHRVy2PsYskbg5vOByAAnJ5Qp3UFlCGvCGfb7Yv4zrJz4GLh5PSoKPFKIA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257B!(SharedArrayBuffer%2520%257C%2520string%2520%257C%2520Uint8Array)%257D%2520source%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520url%253A%2520string%252C%250A%2520*%2520%2520%2520format%253A%2520string%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultTransformSource%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520source%253A%2520!(SharedArrayBuffer%2520%257C%2520string%2520%257C%2520Uint8Array)%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520transformSource(source%252C%2520context%252C%2520defaultTransformSource)%2520%257B%250A%2520%2520const%2520%257B%2520url%252C%2520format%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520URLs%252C%2520do%2520some%2520custom%2520logic%2520for%2520modifying%2520the%2520source.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Bsource%253A%2520%253Cstring%257Cbuffer%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520source%253A%2520'...'%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520sources.%250A%2520%2520return%2520defaultTransformSource(source%252C%2520context%252C%2520defaultTransformSource)%253B%250A%257D PR-URL: https://github.com/nodejs/node/pull/33563 Co-authored-by: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

Anna Henningsen

commit sha 8a7201b25fa2e5342b5d737742586bcd5ea1da5e

src: introduce BaseObject base FunctionTemplate PR-URL: https://github.com/nodejs/node/pull/33772 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Anna Henningsen

commit sha 57e7c63f74255e3287a11393bb4c18d0ab4e7b1d

worker: allow transferring/cloning generic BaseObjects Extend support for transferring objects à la `MessagePort` to other types of `BaseObject` subclasses, as well as implement cloning support for cases in which destructive transferring is not needed or optional. PR-URL: https://github.com/nodejs/node/pull/33772 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Anna Henningsen

commit sha 8ead0211d7ee534015a10cc99c01a14cc38cbd3a

src: add equality operators for BaseObjectPtr PR-URL: https://github.com/nodejs/node/pull/33772 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Anna Henningsen

commit sha 9129cf21ab51432675521ea158191ae3f866cafb

worker: allow passing JS wrapper objects via postMessage Enable JS wrapper objects to be used as transferable or cloneable objects in `postMessage()` calls, by having them extend a C++-backed class. This requires a few internal changes: - This commit adds the possibility for transferred objects to read/write JS values at the end of the serialization/deserialization phases. - This commit adds the possibility for transferred objects to list sub-transferables, e.g. typically the public JS wrapper class would list its C++ handle in there. - This commit adds usage of `BaseObject` in a few more places, because now during deserialization weakly held objects can also be involved, in addition to `MessagePort`s. PR-URL: https://github.com/nodejs/node/pull/33772 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Anna Henningsen

commit sha 8641d94189398063b20d5e38549bfd8f023af2d6

worker,fs: make FileHandle transferable Allow passing `FileHandle` instances in the transfer list of a `.postMessage()` call. PR-URL: https://github.com/nodejs/node/pull/33772 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Anna Henningsen

commit sha e1ad548cd4bfb996ea925584542f30c85aa3dfa1

worker: emit `'messagerror'` events for failed deserialization This is much nicer than just treating exceptions as uncaught, and enables reporting of exceptions from the internal C++ deserialization machinery. PR-URL: https://github.com/nodejs/node/pull/33772 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Daniel Bevenius

commit sha 418f5b61eb49a31a5cdc9c3c94e58b8221bf0c44

doc: move --force-context-aware option in cli.md This commit moves the --force-context-aware option so that the options list is in alphabetical order. PR-URL: https://github.com/nodejs/node/pull/33823 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha 8f7211a60a45a5fcdbe99fa5150a3c7b30c1b5ed

src: avoid unnecessary ToLocalChecked calls This commit removes two unnecessary ToLocalChecked calls in StringBytes::Encode. PR-URL: https://github.com/nodejs/node/pull/33824 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha 74d80115b64c4aa3f697ea1199be439dce9af3cc

src: remove unused vector include in string_bytes PR-URL: https://github.com/nodejs/node/pull/33824 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha 5959ae3cc18653985927bca2dfdf13c6299e0124

src: remove ref to tools/generate_code_cache.js This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md. PR-URL: https://github.com/nodejs/node/pull/33825 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha aa40bad2301751196ae61e40ed5a72a8e7f14b36

tools: remove unused vector include in mkdcodecache PR-URL: https://github.com/nodejs/node/pull/33828 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Daniel Bevenius

commit sha f645cc73185f1d690e82b01907e2c0da330a26de

tools: prevent js2c from running if nothing changed This commit updates tools/js2c.py to touch the target output file , <(SHARED_INTERMEDIATE_DIR)/node_javascript.cc, even if the content has not changed. This is to "help" the build system so that it can compare the inputs against the output to determine if the gyp action should be run. I believe the issue here is that if js2c.py is updated this can cause the action to be run as the node_javascript.cc target would be older than js2c.py. But when the target is run the timestamp for node_javascript.cc will not be updated (because we have not changed anything that would change the contents of the file) so the js2c.py prerequisite will always be passed and the target always run. Using the update in this commit one would have to touch/modify one of the js files specified in the library_files list, config.gypi, or tools/js2c.py for this action to be run again. PR-URL: https://github.com/nodejs/node/pull/33844 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha b371213d3d2b499f0392af2103cf45262e1042d3

src: add public APIs to manage v8::TracingController We added a hack for this a while ago for Electron, so let’s remove that hack and make this an official API. Refs: https://github.com/nodejs/node/pull/28724 Refs: https://github.com/nodejs/node/issues/33800 PR-URL: https://github.com/nodejs/node/pull/33850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

James M Snell

commit sha a808cb76ce1d2f18f354ced39f41f4a4e92b4ec9

test: add common/udppair utility Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier. PR-URL: https://github.com/nodejs/node/pull/33380 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Todd Short

commit sha 2c549e505e8614ad184cfdb939db2cce7df1bfe6

deps: add support for BoringSSL QUIC APIs Acquired from: https://github.com/akamai/openssl/tree/OpenSSL_1_1_1f-quic Squashed: * https://github.com/akamai/openssl/commit/2ef7c58b2cb432abd4e371322667228d7ce2637b * https://github.com/akamai/openssl/commit/3f8eda3128f52f4d14399a1a912d1fdfacd86a86 * https://github.com/akamai/openssl/commit/b37f665884be2e17e8ff4ad919138626fb13f6c9 * https://github.com/akamai/openssl/commit/6b235895a16da3c0dd36a24cf8dfbe249c6cda3c * https://github.com/akamai/openssl/commit/3a793e06a5031311ce7ce094455be87fa92b8240 PR-URL: https://github.com/nodejs/node/pull/32379 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 98c84985527b85d08a4876dd68430dff191a560e

deps: update archs files for OpenSSL-1.1.0 After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/32379 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha f96b981528da1f2fc9044211e5edf357f97dcfba

deps: details for updating openssl quic support Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32379 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 834fa8f23fbfd86b88567d87f984b4737401d354

deps: add ngtcp2 and nghttp3 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32379 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 17 hours

push eventcjihrig/node

cjihrig

commit sha a4455fa1c8e6c7d281f9849485fa307e51b8cc46

debug

view details

push time in 18 hours

push eventcjihrig/node

cjihrig

commit sha cfa468a878173f1c977c0399a31c10611d4a3797

debug

view details

push time in 18 hours

push eventcjihrig/node

cjihrig

commit sha d3a93c3bd094ce159113cb2aa0f573e29c460eed

debug

view details

push time in 18 hours

push eventcjihrig/node

cjihrig

commit sha 25220ee08b19f221b58d863e84726cc27e6183d1

debug

view details

push time in 19 hours

push eventcjihrig/node

cjihrig

commit sha 56c4a0efab4a3d18c7a16905ecee8c66792d6cda

debug

view details

push time in 19 hours

push eventcjihrig/node

cjihrig

commit sha 09bdd6a986f8a17b1e58b2197fe8372b22a2829e

debug

view details

push time in 19 hours

push eventcjihrig/node

cjihrig

commit sha 8d7ae69a235fee5953c1db9c8303d3365e452d01

debug

view details

push time in 20 hours

push eventcjihrig/node

cjihrig

commit sha eb4f9aa6ca973f96e306d8c9ddc9d67f5ba5a740

debug

view details

push time in 20 hours

push eventcjihrig/node

cjihrig

commit sha 8187e31f2451f18a35034447e87249adc6ac942e

debug

view details

push time in 20 hours

push eventcjihrig/node

cjihrig

commit sha 03c000beff7cb704cca1da14bbbd4a71a1c10988

debug

view details

push time in 21 hours

push eventcjihrig/node

cjihrig

commit sha 79fa55439beec965ac262cd664fa0882107f1fe4

debug

view details

push time in a day

push eventcjihrig/node

cjihrig

commit sha a1f4c051d0e2b9226aa4463634bd4419f281ebca

debug

view details

push time in a day

push eventcjihrig/node

cjihrig

commit sha cade5220ce3da987576a28552dd5adff66b343d5

debug

view details

push time in a day

push eventcjihrig/node

cjihrig

commit sha e36c28b6f597b57bc8d631cdbb37fa09a6a62404

debug

view details

push time in a day

push eventcjihrig/node

cjihrig

commit sha e34afbc15a96dad03bc315763622f70534e487cb

debug

view details

push time in a day

push eventcjihrig/node

Juan José Arboleda

commit sha 26477b82a5fa1db918b4969918859d28bb0d7193

doc: clarify when not to run CI on docs Collaborators won't need to run CI on documentation-only changes. PR-URL: https://github.com/nodejs/node/pull/33101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Kevin Locke

commit sha 7c36ec38f16add6ecfc1a3514514b55c5b610434

doc: add util.types.isArrayBufferView() This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Rich Trott

commit sha 8a2c65a671f0be64493dd7605abc5c95382728d0

tools: bump remark-preset-lint-node to 1.15.0 New version of remark-preset-lint-node includes prohibited string entry accidentally removed in the last version. PR-URL: https://github.com/nodejs/node/pull/33157 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Adrian Estrada

commit sha b0aba53195530a95688c9d5f274f854fd423da5c

src: remove unused v8 Message namespace PR-URL: https://github.com/nodejs/node/pull/33180 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

himself65

commit sha 53eb264cb16f5c1815d4ccfda585b462f9fac92a

doc: fix a typo in crypto.generateKeyPairSync() PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Robert Nagy

commit sha d799c0f17921797eb61088f6740b25b70d54571e

http: simplify sending header unshifting into an empty array is the same as creating a new array. PR-URL: https://github.com/nodejs/node/pull/33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Daniele Belardi

commit sha 8f87d252fa9ff071a8edf941d431b6efd6cb9727

esm: improve commonjs hint on module not found Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/nodejs/node/pull/31906 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Robert Nagy

commit sha 36b4c569eb845635480d8d3b7f3883b125445436

doc: add missing deprecation not PR-URL: https://github.com/nodejs/node/pull/33203 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

bcoe

commit sha bde5f9baf7af4efeec1a0ea1d53b70152e23428f

test: update c8 ignore comment PR-URL: https://github.com/nodejs/node/pull/33151 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Robert Nagy

commit sha 027e1c706d25be75a790eb744835a0ebdc65452f

http: ensure client request emits close If socket creation failed then an error would be emitted on the client request object, but not 'close' nor would destroyed be set to true. PR-URL: https://github.com/nodejs/node/pull/33178 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Ruben Bridgewater

commit sha c81e5f699e80fa5c0a201ae4c34e455c99e52a20

doc: mark assert.CallTracker experimental Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33124 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Julian Duque

commit sha 39ff64756bd5bc7147236b36ee9444ceddb3e6d2

test: add tests for options.fs in fs streams PR-URL: https://github.com/nodejs/node/pull/33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Nikolai Vavilov

commit sha c17dcb32533aa007dfbf507d22c28ef3c7c11c29

doc: fix style and grammer in buffer.md PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

John Leidegren

commit sha 26f150022f9b4d4709c1d4ad450c6f9e9fce8d0e

http: fixes memory retention issue with FreeList and HTTPParser Fixes: https://github.com/nodejs/node/issues/29394 Refs: https://github.com/nodejs/node/pull/33167#issuecomment-622102450 PR-URL: https://github.com/nodejs/node/pull/33190 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Myles Borins

commit sha 1ffd182264dcf02e010aae3dc88406c2db9efcfb

doc: explicitly doc package.exports is breaking If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: https://github.com/then/is-promise/issues/20 PR-URL: https://github.com/nodejs/node/pull/33074 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Michaël Zasso

commit sha f446b2058dcfaf9d4e2f6bdfe555bc4437f41acf

2020-05-05, Version 14.2.0 (Current) Notable changes: * Track function calls with `assert.CallTracker` (experimental). https://github.com/nodejs/node/pull/31982 * Added a `groupIndentation` option to the `Console` constructor. https://github.com/nodejs/node/pull/32964 PR-URL: https://github.com/nodejs/node/pull/33232

view details

Joyee Cheung

commit sha 86fdaa745572a3bec4370ac7bd05d18e6bf64c01

src: retrieve binding data from the context Instead of passing them through the data bound to function templates, store references to them in a list embedded inside the context. This makes the function templates more context-independent, and makes it possible to embed binding data in non-main contexts. Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/33139 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Richard Lau

commit sha a22991b04461a1aa8dd6e1793f26f3b9e6eaaa27

Revert "src: add aliased-buffer-overflow abort test" This reverts commit babeb58c5286c55f00e6dfc48c0b609314bcc381. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Richard Lau

commit sha 120d7076d5462f7f664ed0c92be26541e3298a24

Revert "src: add test/abort build tasks" This reverts commit e08ac095690015a8c488e05251e05feb2acc57a0. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha 1dc006ef1990d4dcb67a9521bc643638aeba248b

src: use BaseObjectPtr in StreamReq::Dispose Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379). Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33102 Refs: https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in a day

delete branch cjihrig/node

delete branch : libuv

delete time in 2 days

PR merged nodejs/node

deps: upgrade to libuv 1.38.1 author ready libuv lts-watch-v10.x lts-watch-v12.x

Notable changes:

  • A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The uv_hrtime() code on Windows has been rearranged to work around the issue.
  • On Linux, uv_loadavg() attempts to read from /proc/loadavg before falling back to calling sysinfo(). This works around a bug in LXC.
  • A deadlock in the Windows TTY code has been fixed.
  • An issue on macOS related to monotonic clocks jumping back in time has been worked around.
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+774 -148

3 comments

28 changed files

cjihrig

pr closed time in 2 days

push eventnodejs/node

cjihrig

commit sha 375166290681b209c7465d250dcd1e95543945f5

deps: upgrade to libuv 1.38.1 Notable changes: - A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The `uv_hrtime()` code on Windows has been rearranged to work around the issue. - On Linux, `uv_loadavg()` attempts to read from `/proc/loadavg` before falling back to calling `sysinfo()`. This works around a bug in LXC. - A deadlock in the Windows TTY code has been fixed. - An issue on macOS related to monotonic clocks jumping back in time has been worked around. PR-URL: https://github.com/nodejs/node/pull/34187 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

push time in 2 days

push eventcjihrig/node

Rich Trott

commit sha 9b8d317d9916dd44b2b3678df05f9daf6eb14c90

test: fix flaky test-http2-invalidheaderfield Separate test cases to avoid side effects and race conditions. Fixes: https://github.com/nodejs/node/issues/34172 PR-URL: https://github.com/nodejs/node/pull/34173 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Anna Henningsen

commit sha 1d7be3253f12c9eafaf0ecec378a657893b30852

crypto: move typechecking for timingSafeEqual into C++ This makes the function more robust against V8 inlining. Fixes: https://github.com/nodejs/node/issues/34073 PR-URL: https://github.com/nodejs/node/pull/34141 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Xu Meng

commit sha 07bbadb2c7f4f7fca41d01839b122a6e2cbb16e2

test: skip some IBM i unsupported test cases Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: https://github.com/libuv/libuv/pull/2782 PR-URL: https://github.com/nodejs/node/pull/34118 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 907829b1a47f86dff9d81168fc1c867540638a4a

doc: simply dns.ADDRCONFIG language PR-URL: https://github.com/nodejs/node/pull/34155 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 2110fadecdd6c97054dcdcbd1208818c185944ff

doc: improve triaging text in issues.md Remove a double negative and many superfluous sentences. The sentiment in the removed material is good, but we already tell people that discussion should be focused, helpful, and professional. Having two extra paragraphs greatly reduces the likelihood that people will read the material. PR-URL: https://github.com/nodejs/node/pull/34164 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

rickyes

commit sha 7f2cf0f8da83d67eac47cf3cb1b8c0a98b518831

doc: add streams to the pipeline function signature PR-URL: https://github.com/nodejs/node/pull/34153 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

rickyes

commit sha a7c6806adc5591ba782cb7c520fb983bc0e25ec1

doc: Add maxTotalSockets option to agent constructor PR-URL: https://github.com/nodejs/node/pull/34013 Refs: https://github.com/nodejs/node/pull/33617 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Derek Lewis

commit sha db3b209e7df254794873be5ac91345dee034e130

doc: clarify esm conditional exports prose This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: https://github.com/nodejs/node/pull/33886 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha ee3243fe3f29f317e910a2424eabd279dec2eb00

src: remove unused fields from IsolateData PR-URL: https://github.com/nodejs/node/pull/34139 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Denys Otrishko

commit sha b4fe76d656d51ead949f2a35c13a221616f78c4c

doc: improve async_hooks asynchronous context example * use writeFile(1) everywhere to log * prettify execution id graph * add clearer explanation for TickObject presence * add causation graph via triggerAsyncId PR-URL: https://github.com/nodejs/node/pull/33730 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

Rodion Abdurakhimov

commit sha d853145277f3070053ed89cbaa91ad9218f3e1ac

doc: fix source link margin to sub-header mark Prior to this commit, [src] link overlapped sharped (#) sub-header link PR-URL: https://github.com/nodejs/node/pull/33664 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Gabriel Schulhof

commit sha cfa3d8fec5d9f6469c8d4ef077b53e0d9007dab9

doc: fix entry for `napi_create_external_buffer` Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: https://github.com/nodejs/node/issues/33471 PR-URL: https://github.com/nodejs/node/pull/34125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anentropic

commit sha 7c9df66485e63c5b03f6344a658f8e0018a928fb

doc: clarify how to read process.stdin document more clearly that stdin will emit multiple readable events PR-URL: https://github.com/nodejs/node/pull/27350 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Saleem

commit sha 1a9d6316b8e707ba4730ba421c7d1fb960dcb288

doc: use consistent naming in stream doc Consistency of method naming referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push PR-URL: https://github.com/nodejs/node/pull/30506 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Shelley Vohr

commit sha 37fc587b4179c843efa9b17a3a0a3ce1cd52a1d0

lib: always initialize esm loader callbackMap PR-URL: https://github.com/nodejs/node/pull/34127 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host>

view details

Sam Roberts

commit sha 3f81f2a421869d83fa814868754196a10c92c73d

doc: no longer maintain a CNA structure Node.js hasn't touched the cve-management repo since the Feb 2019 security release, we've used the HackerOne CVE allocation process. Maintaining our status as a CNA is not zero cost, there is some routine adminstration that is requested (see this doc for details). As we no longer use the CVE management process, I propose removing it. If this lands, I will go through the interactions with Mitre so that Node.js is no longer a CNA and cleanup related resources (email aliases, archive the cve-management repo, whatever else I find). PR-URL: https://github.com/nodejs/node/pull/33639 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Mateusz Krawczuk

commit sha d3d4aceb96fced82710e1cdb3dfc7224f830df48

doc: add a reference to the list of OpenSSL flags. Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: https://github.com/nodejs/node/pull/34050 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Luigi Pinca

commit sha d2c8b3efc345a29ce7d72511ed73f98fa8b6ee54

doc: clarify that the ctx argument is optional Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: https://github.com/nodejs/node/issues/34085 PR-URL: https://github.com/nodejs/node/pull/34097 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Julien Poissonnier

commit sha 647babc2fdfb717081e3f77871b4a59a7a8d7a31

doc: update wording in "Two reading modes" PR-URL: https://github.com/nodejs/node/pull/34119 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 92f878129ffd1c071da2364f3444e0ffcafeb885

tools: remove lint-js.js lint-js.js was implemented before ESLint had a caching feature. It is now only used in CI. Let's remove it on the following grounds: * It results in occasional (and puzzling) yellow CI runs for node-test-linter because the tap file is corrupted somehow. Interleaved maybe? I don't know, but a simple solution is removing it and running ESLint directly. * On my local laptop, it reduces the linting from about 75 seconds to about 55 seconds. This kind of savings is not worth the added complexity and the instability noted above. PR-URL: https://github.com/nodejs/node/pull/30955 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 days

delete branch cjihrig/node

delete branch : eslint

delete time in 2 days

PR merged nodejs/node

tools: update ESLint to 7.4.0 author ready tools

Update ESLint to 7.4.0

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+815 -619

1 comment

67 changed files

cjihrig

pr closed time in 2 days

push eventnodejs/node

cjihrig

commit sha b0d4eb37c728d36f6942c878d253607e4323b66e

tools: update ESLint to 7.4.0 Update ESLint to 7.4.0 PR-URL: https://github.com/nodejs/node/pull/34205 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 2 days

push eventcjihrig/node

Rich Trott

commit sha 56dbe466fdbc598baea3bfce289bf52b97b8b8f7

doc: remove parenthetical \r\n comment in http and http2 docs The explanation that the HTTP requests include `\r\n` is true but not important or relevant in these two specific contexts. PR-URL: https://github.com/nodejs/node/pull/34178 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

James M Snell

commit sha b1750a4d533f73fd16c7c3602aebfad0381747e4

quic: continued refactoring for quic_stream/quic_session PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha b5bf5bb20f35372a81a83c830a01353925e11701

quic: refactor native object flags for better readability Use is_* and set_* pattern for native object flags to improve readability in the code. PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha f7510ca439eb17061d075cc73bef640d2ef104a4

quic: additional cleanups on the c++ side PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha f9c2245fb5122e9b617947a5b3f5623e44df88e4

quic: refactor QuicSession close/destroy flow PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 3acdd6aac74b7004a5be93d0baf7da789300a51d

quic: refactor QuicSession shared state to use AliasedStruct PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha e4d369e96e0f75786c84dacb45f0a8790615b386

quic: remove onSessionDestroy callback The QuicSession can be destroyed during garbage collection and the onSessionDestroy callback was happening in the destructor. PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 7b062ca015d5a2545c9d66992c183c325d938a23

quic: refactor qlog handling Because of the timing of qlog events emitted by ngtcp2, it becomes difficult to handle those as events on the QuicSession object because the final qlog entry is not emitted until the ngtcp2_conn is freed, which can occur when the object is being garbage collected (meaning, we a: can't call out to javascript and b: don't have an object we can use to emit the event). This refactors it into a QLogStream object that allows the qlog data to be piped out using a separate Readable stream. PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 3837d9cf1fdb620dff50ee038f85a8528222e7d9

quic: fixup lint issues PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 5a87e9b0a5830824f90b5bf3742370c167619b71

quic: cleanup timers if they haven't been already PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 1b1e9854783d51b5157ef6e95416e852e6e1a280

quic: add missing memory tracker fields PR-URL: https://github.com/nodejs/node/pull/34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha e7dadd376ec535e56faf3be75fe23549bf13abc9

doc: specify how fs.WriteStream/ReadStreams are created Alternative to https://github.com/nodejs/node/pull/33841 Co-authored-by: zombieleet <zombieleetnca@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

James M Snell

commit sha d4f69002b44c55d4db93c01d5468f79e48f46417

src: add TimerWrap utility Consolidate uv_timer_t boilerplate code into a shared utility. There are several places throughout the code where we use uv_timer_t internally (inspector, perf, quic), with some code duplication. This eliminates the duplicated code, ensures that cleanup occurs correctly, and simplifies use of the timers. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha e19a25182446032a6c9f0bedf4d063e305ddde0a

src: replace InspectorTimer with TimerWrap utility Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha 0f97d6066a9037f591d9b3f4f220448ec5c89f29

quic: use TimerWrap for idle and retransmit timers Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Rich Trott

commit sha 8a57788efebe6e55242236119190b37bdf5b9d1b

doc: move gibfahn to emeritus Asked Gibson in email if he should be moved to emeritus and he indicated it was a good idea. PR-URL: https://github.com/nodejs/node/pull/34190 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 7eb500b538a5b78650ac9d2a6c5f52353dc4c577

doc: move digitalinfinity to emeritus Had an email exchange with Hitesh where he indicated that it was a fine time to move him to emeritus. PR-URL: https://github.com/nodejs/node/pull/34191 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 654df09ae0c5e17d1b52a900a545f0664d8c7627

doc: move ERR_FEATURE_UNAVAILABLE_ON_PLATFORM to current errors ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list of errors that have never been released. It was added in 67e067eb0658281b647ff68a5a9e64ea2cfdb706 and included in every release in the 14.x line. PR-URL: https://github.com/nodejs/node/pull/34196 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Nikola Glavina

commit sha 82c435d0a08423cec36c91df7335f417ffa41122

src: fix unused namespace member C++ linter fails because of unused ArrayBuffer namespace member PR-URL: https://github.com/nodejs/node/pull/34212 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Daniel Bevenius

commit sha 67ba825037b4082d5d16f922fb9ce54516b4a869

src: fix minor comment typo in KeyObjectData PR-URL: https://github.com/nodejs/node/pull/34167 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in 2 days

delete branch cjihrig/nigel

delete branch : close

delete time in 7 days

PR opened nodejs/node

tools: update ESLint to 7.4.0

Update ESLint to 7.4.0

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+815 -619

0 comment

67 changed files

pr created time in 9 days

create barnchcjihrig/node

branch : eslint

created branch time in 9 days

pull request commentnodejs/node

deps: update V8 to 8.4

@targos the SmartOS fix is in https://github.com/cjihrig/node/commit/371831c6163f7babf01f780fb97fcce3272a00e4

targos

comment created time in 9 days

create barnchcjihrig/node

branch : v8-84

created branch time in 9 days

pull request commentlibuv/libuv-extras

Add android support showcase

I don't quite understand the vision for this repo enough to sign off on this. If this repo is just supposed to include a collection of libuv-adjacent projects, then it might be a good idea to split them up in separate directories (ie this pull request would add a top level directory, and everything else would be inside of that). It would be good to get feedback from @bnoordhuis and @saghul here.

gengjiawen

comment created time in 9 days

PR opened nodejs/node

deps: upgrade to libuv 1.38.1

Notable changes:

  • A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The uv_hrtime() code on Windows has been rearranged to work around the issue.
  • On Linux, uv_loadavg() attempts to read from /proc/loadavg before falling back to calling sysinfo(). This works around a bug in LXC.
  • A deadlock in the Windows TTY code has been fixed.
  • An issue on macOS related to monotonic clocks jumping back in time has been worked around.
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+774 -148

0 comment

28 changed files

pr created time in 10 days

push eventcjihrig/node

cjihrig

commit sha fa91034223e10c41f949ec6bc555ec2ffe893365

deps: upgrade to libuv 1.38.1 Notable changes: - A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The `uv_hrtime()` code on Windows has been rearranged to work around the issue. - On Linux, `uv_loadavg()` attempts to read from `/proc/loadavg` before falling back to calling `sysinfo()`. This works around a bug in LXC. - A deadlock in the Windows TTY code has been fixed. - An issue on macOS related to monotonic clocks jumping back in time has been worked around.

view details

push time in 10 days

push eventlibuv/libuv

cjihrig

commit sha 032f2b1251be842438bfed6e688ef874bf85254c

Now working on version 1.38.2 Fixes: https://github.com/libuv/libuv/issues/2898

view details

push time in 10 days

issue closedlibuv/libuv

Release proposal: v1.38.1

Notable changes:

  • A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The uv_hrtime() code on Windows has been rearranged to work around the issue.
  • On Linux, uv_loadavg() attempts to read from /proc/loadavg before falling back to calling sysinfo(). This works around a bug in LXC.
  • A deadlock in the Windows TTY code has been fixed.
  • An issue on macOS related to monotonic clocks jumping back in time has been worked around.

closed time in 10 days

cjihrig

push eventlibuv/libuv

cjihrig

commit sha e8b989ea1f7f9d4083511a2caec7791e9abd1871

2020.07.04, Version 1.38.1 (Stable) Changes since version 1.38.0: * test: use last matching qemu version (cjihrig) * win, util: rearrange uv_hrtime (Bartosz Sosnowski) * test: skip signal_multiple_loops test on QEMU (gengjiawen) * build: add android build to CI (gengjiawen) * test: extend fs_event_error_reporting timeout (cjihrig) * build: link libkvm on netbsd only (Alexander Tokmakov) * linux: refactor /proc file reader logic (Ben Noordhuis) * linux: read load average from /proc/loadavg (Ben Noordhuis) * android: remove patch code for below 21 (gengjiawen) * win: fix visual studio 2008 build (Arenoros) * win,tty: fix deadlock caused by inconsistent state (lander0s) * unix: use relaxed loads/stores for feature checks (Ben Noordhuis) * build: don't .gitignore m4/ax_pthread.m4 (Ben Noordhuis) * unix: fix gcc atomics feature check (Ben Noordhuis) * darwin: work around clock jumping back in time (Ben Noordhuis) * udp: fix write_queue cleanup on sendmmsg error (Santiago Gimeno) * src: build fix for Android (David Carlier)

view details

cjihrig

commit sha 5b0398262a3f760340382b2d4fac82a89bb642e6

Add SHA to ChangeLog

view details

push time in 10 days

created taglibuv/libuv

tagv1.38.1

Cross-platform asynchronous I/O

created time in 10 days

issue commentlibuv/libuv

Release proposal: v1.38.1

libuv CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1942/ I reran the osx-cmake job: https://ci.nodejs.org/job/libuv-test-commit-osx-cmake/137/. The only failure was a flaky hrtime timeout.

Node+libuv integration CI: https://ci.nodejs.org/view/libuv/job/libuv-in-node/141/. I had to run this on my own fork of Node due to required changes to the gyp file. Seems fine other than a FreeBSD infra issue.

cjihrig

comment created time in 10 days

push eventcjihrig/node

cjihrig

commit sha 5badb41501839e3e6b8e0cebd74fb9836a48699a

deps: upgrade to libuv 1.38.1 Notable changes: - A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The `uv_hrtime()` code on Windows has been rearranged to work around the issue. - On Linux, `uv_loadavg()` attempts to read from `/proc/loadavg` before falling back to calling `sysinfo()`. This works around a bug in LXC. - A deadlock in the Windows TTY code has been fixed. - An issue on macOS related to monotonic clocks jumping back in time has been worked around.

view details

push time in 10 days

create barnchcjihrig/node

branch : libuv

created branch time in 10 days

issue commenthapijs/nigel

close event emitted twice

Proposed fix with a test in https://github.com/hapijs/nigel/pull/26.

hueniverse

comment created time in 13 days

PR opened hapijs/nigel

fix duplicate 'close' events

This commit ensures that the stream only emits the 'close' event once consistently across Node 12 and 14 without version detection.

+11 -13

0 comment

2 changed files

pr created time in 13 days

create barnchcjihrig/nigel

branch : close

created branch time in 13 days

fork cjihrig/nigel

:office: Boyer–Moore–Horspool algorithms

fork in 13 days

issue commenthapijs/nigel

close event emitted twice

Is there a failing test in this repo? I ran the nigel tests locally on Node 12 and Node 14 with 1215978829bd444fca935d61bd5a6dbd6cb793bb (removing your recent fixes for this issue) and everything passed.

hueniverse

comment created time in 14 days

issue openedlibuv/libuv

Release proposal: v1.38.1

Notable changes:

  • A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The uv_hrtime() code on Windows has been rearranged to work around the issue.
  • On Linux, uv_loadavg() attempts to read from /proc/loadavg before falling back to calling sysinfo(). This works around a bug in LXC.
  • A deadlock in the Windows TTY code has been fixed.

created time in 14 days

pull request commentnodejs/node

deps: update V8 to 8.4

@targos please pull in https://github.com/cjihrig/node/commit/bf2a184f4fee02a78b1f414dbda14bd608d06d25. I'm not maintaining the postmortem metadata anymore, and if @mmarchini isn't using that test then it's just dead code. There is no point marking it flaky because it will only continue to get more broken.

targos

comment created time in 14 days

push eventcjihrig/node

Robert Nagy

commit sha eeccd52b4ef2db3219fc76737bb00c1da669aea2

net: make readable/writable start as true `net.Socket` is slightly breaking stream invariants by having readable/writable going from `false` to `true`. Streams assume that readable/writable starts out `true` and then goes to `false` through `push(null)`/`end()` after which it never goes back to `true`, e.g. once a stream is `writable == false` it is assumed it will never become `true`. This PR changes 2 things: Unless explicitly set to `false` through options: - starts as `readable`/`writable` `true` by default. - uses `push(null)`/`end()` to set `readable`/`writable` to `false`. Note that this would cause the socket to emit the `'end'`/`'finish'` events, which it did not do previously. In the case it is explicitly set to `false` through options` it is assumed to never become `true`. PR-URL: https://github.com/nodejs/node/pull/32272 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Eric Dobbertin

commit sha f92df338321ac528747ea2374dd72d95bdd1059a

doc: import clarifications with links to MDN PR-URL: https://github.com/nodejs/node/pull/31479 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Richard Lau

commit sha f467b9b5e2cddc66c875d776aa49aed236d7b0c2

build: annotate markdown lint failures in pull requests Add a problem matcher for output from remark-lint to our lint-md GitHub Actions CI workflow so that any markdown linter failures are annotated in the pull request in the web UI. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32391 Refs: https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md Refs: https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Rich Trott

commit sha 43922a55ea35c2ceb376e9c62e542ee4f696f1d0

doc: improve wording in esm.md Simplify complex sentence. Remove use of "straightforward". PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha c78d3f22560fb6d7080713c3a77b3759b088dfd0

doc: improve wording in vm.md Simplify complex sentence. Remove use of "straightforward". PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

James M Snell

commit sha d0c0e20bc2b2e122919b05697df7b4874678be3b

test: refactoring / cleanup on child-process tests PR-URL: https://github.com/nodejs/node/pull/32078 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Richard Lau

commit sha 066bdec64352278ed324a1bb680f5422e00a3aa5

doc: fix lint warning in doc/api/esm.md Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32462 Refs: https://github.com/nodejs/node/pull/31479 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Michael Dawson

commit sha f4153c2fe7b54744e2201e397e1ac8345f222432

doc: add new TSC members Refs: https://github.com/nodejs/TSC/issues/829 Refs: https://github.com/nodejs/TSC/issues/832 Refs: https://github.com/nodejs/TSC/issues/831 Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 9e3eddc75dde9df9356264b42bd30facb82583cd

stream: add pipeline test for destroy of returned stream Adds a test to ensure that destroying the returned stream of pipeline will cause a premature close error. PR-URL: https://github.com/nodejs/node/pull/32425 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Robert Nagy

commit sha 05f1df520064475a255d8956f9e1b6f4bf4c8543

stream: fix pipeline with dest in objectMode pipeline did not support destination with generator that does not return strings or buffers. PR-URL: https://github.com/nodejs/node/pull/32414 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Robert Nagy

commit sha 388cef61e8a4859b7505f7b5cf988eba27ce17b4

stream: align stream.Duplex with net.Socket stream.Duplex and net.Socket slightly differs in behavior. Especially when it comes to the case where one side never becomes readable or writable. This aligns Duplex with the behavior of Socket. PR-URL: https://github.com/nodejs/node/pull/32139 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Harshitha KP

commit sha 2fa74e3e38bb028339e48763138456b3ed10ed97

report: handle on-fatalerror better --report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. Move the flag out of Environment pointer so that this is doable. Co-authored-by: Shobhit Chittora schittora@paypal.com PR-URL: https://github.com/nodejs/node/pull/32207 Fixes: https://github.com/nodejs/node/issues/31576 Refs: https://github.com/nodejs/node/pull/29881 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Anna Henningsen

commit sha b950daf8368cb9ab7f190b74774e55b20e17dec9

src: use single ObjectTemplate for TextDecoder `ObjectTemplate`s are not garbage-collected like regular objects (for some reason). It is sufficient to create a single template anyway, so do that to address the memory leak. Fixes: https://github.com/nodejs/node/issues/32424 PR-URL: https://github.com/nodejs/node/pull/32426 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

himself65

commit sha dade90db9c64040f3bfc0ebb6d7556277e7de5a1

src: enhance C++ sprintf utility PR-URL: https://github.com/nodejs/node/pull/32385 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Rich Trott

commit sha f0a33d99ec4656b87bebb97162837047b52eb6f8

doc: simplify and correct example descriptions in net.md Instead of indicating that examples show lines to change in previous examples, present the examples as standalone items. They suffice on their own. In the first of these, it says to change "the second line" of a previous example, but if it were literally changed to the provided line, it would result in a syntax error. In the second of these, it gives the wrong line to change. All of this is unnecessary and probably makes the examples harder to follow. So simplify and treat each one as a separate example. PR-URL: https://github.com/nodejs/node/pull/32451 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

AshCripps

commit sha a621608f12988fac81d63043f4d147850d57c4c2

build: update macos deployment target to 10.13 for 14.x Update the macos deployment target to 10.13 (High Sierra) for Node 14 refs: https://github.com/nodejs/build/issues/2168 PR-URL: https://github.com/nodejs/node/pull/32454 Refs: https://github.com/nodejs/build/issues/2168 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Victor

commit sha afb5639119c91afc8c6f5c078468fe6f7775f8a2

doc: update async_hooks.md Typo `runAndReturn` -> `runSyncAndReturn` PR-URL: https://github.com/nodejs/node/pull/32382 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha bdfbbf6c68da7a413d5e7101ce135ea41e4e81f4

doc: trim wording in n-api.md text about exceptions PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Rich Trott

commit sha 7e4381318b3d4dacc6ed7c050ba8d00e3546a2f7

doc: remove unnecessary "obvious(ly)" modifiers in esm.md Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Rich Trott

commit sha 498415b4abd879a81333f48123cc31ca8f32b6f5

doc: remove extraneous sentence in events.md Since the previous sentence describes `10` as a default, and the following sentence explains how to modify that default, it is unnecessary to explain that "Obviously, not all events should be limited to just 10 listeners." PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

push time in 14 days

pull request commentnodejs/build

Proposal for major changes to (and expansion of) containerised build system

The closest thing I could find is: nodejs/node#31230

I don't think this is related.

Just looking at the output, it's not clear why link() would be failing. It would be helpful to know what errno is after the link() call. That would require updating the test's C code and regenerating the WASM file (or adding debugging statements to Node itself).

I can take a look later tonight, but I'll need some way to reproduce it. Is there a CI job I can run that I can also point at my own fork?

rvagg

comment created time in 14 days

issue commenthapijs/nigel

close event emitted twice

Untested, but would passing emitClose or autoDestroy when constructing the stream give the behavior you're looking for across versions?

hueniverse

comment created time in 14 days

push eventcjihrig/node

cjihrig

commit sha 5e6474e8e34b5fcdc9de1ad6e81ed6f92b2caac3

debug

view details

push time in a month

push eventcjihrig/node

cjihrig

commit sha 47537f779fa3b6d51bc32c3ed0c28557910cad10

debug

view details

push time in a month

push eventcjihrig/node

cjihrig

commit sha fe05fa1eb429c2360fbbb409127abb0c99e7a858

debug

view details

push time in a month

push eventcjihrig/node

cjihrig

commit sha 72b831927c6053c3408db8f6fc4a30c6fa5ec7ab

debug

view details

push time in a month

push eventcjihrig/node

cjihrig

commit sha daa38923ef2a54790924546d70879ecb55aa214e

debug

view details

push time in a month

create barnchcjihrig/node

branch : test

created branch time in a month

delete branch cjihrig/node

delete branch : eslint

delete time in a month

PR merged nodejs/node

tools: update ESLint to 7.2.0 tools

Update ESLint to 7.2.0

(The no-unused-vars rule has changed the way it reports errors. This required changing a benchmark and a test.)

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines
+311 -117

5 comments

43 changed files

cjihrig

pr closed time in a month

push eventnodejs/node

cjihrig

commit sha 85fbf7175e628fb8f892c2c0886f74e5562635f4

tools: update ESLint to 7.2.0 Update ESLint to 7.2.0 PR-URL: https://github.com/nodejs/node/pull/33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

view details

push time in a month

push eventcjihrig/node

cjihrig

commit sha 85fbf7175e628fb8f892c2c0886f74e5562635f4

tools: update ESLint to 7.2.0 Update ESLint to 7.2.0 PR-URL: https://github.com/nodejs/node/pull/33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

view details

push time in a month

push eventcjihrig/node

Joyee Cheung

commit sha 51bc55f2a2424d6eb805dace43604906ed9946a8

src: implement per-process native Debug() printer This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Joyee Cheung

commit sha 192cb7288ab608a5d17be060aa6127df1f7bbdb0

tools: use per-process native Debug() printer in mkcodecache PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 66e32ff64aef3580eb7ba592323312ae42bbb439

test: improve test-debug-usage test-debug-usage fails if run with `--trace-warnings` because the regular expression checking does not allow for the resulting stack trace from the deprecation warning. The test also only tests two parts of the three-part usage message. Improve the test so that it passes with `--trace-warnings` and verifies all three parts of the usage message. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 36ce039347e94a9a0f8239c7bc639868e496258d

doc: remove personal pronoun usage in addons.md Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha c37c21b6ef2ef13f45b99e88bf625a452c6c9c0a

doc: remove personal pronoun usage in errors.md Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha fb36266f28379fc7270a3d3e7423296e59e022b1

doc: remove personal pronoun usage in fs.md Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 73f2dbc911e16a3b50fc9a1236d9bed7d9e04d7a

doc: remove personal pronoun usage in policy.md Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Sam Roberts

commit sha 811b3a9931b658b2fc2ced2574462069abfa5aa2

src: use C++ style for struct with initializers Fixes warning on clang 11: In file included from ../../src/node_http2.cc:6: ../../src/node_http2.h:508:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage] typedef struct { ^ SessionJSFields ../../src/node_http2.h:512:33: note: type is not C-compatible due to this default member initializer uint32_t max_invalid_frames = 1000; ^~~~ ../../src/node_http2.h:514:3: note: type is given name 'SessionJSFields' for linkage purposes by this typedef declaration } SessionJSFields; ^ PR-URL: https://github.com/nodejs/node/pull/32134 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rod Vagg

commit sha 6db6af405729d47d675edc0a5e87eb2aeb39df7b

build: macOS package notarization Includes hardened-runtime patch from gdams from https://github.com/nodejs/node/issues/29216#issuecomment-546932966 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Signed-off-by: Rod Vagg <rod@vagg.org>

view details

Rod Vagg

commit sha d2f08a1bdb78655c4a3fc49825986c148d14117e

deps: update term-size with signed version PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Refs: https://github.com/sindresorhus/macos-term-size/pull/3 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Signed-off-by: Rod Vagg <rod@vagg.org>

view details

Rod Vagg

commit sha c933cbfd74a8ba3ba18a9aa30a9230bd21c0e4e0

doc: official macOS builds now on 10.15 + Xcode 11 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Signed-off-by: Rod Vagg <rod@vagg.org>

view details

Matheus Marchini

commit sha de8fab95a8525105b5611a0f815c72bb0f9c8a30

build: workaround for gclient python3 issues gclient doesn't support Python 3 yet. To workaround that problem, add an enviroment variable to override the Python version used by ./configure. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

Robert Nagy

commit sha 173d044d0976e30bc2ab0a40807ec617b0b8a55a

http: align OutgoingMessage and ClientRequest destroy Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. PR-URL: https://github.com/nodejs/node/pull/32148 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Gerhard Stoebich

commit sha 28fae8bff1949c5008b518fa24fbc5ff5c468267

doc: change worker.takeHeapSnapshot to getHeapSnapshot Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: https://github.com/nodejs/node/pull/32061 Refs: https://github.com/nodejs/node/pull/31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Denys Otrishko

commit sha 30bbeb76808e320498187f2b10d24ea4fa8aed12

test: always skip vm-timeout-escape-queuemicrotask This issue is unfixable with the current implementations of V8 and Node.js. Changes to make this fixable are unlikely to happen in the foreseeable future. The test itself is flaky and skipped. It serves as a demonstration of the issue only. PR-URL: https://github.com/nodejs/node/pull/31980 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Robert Nagy

commit sha c1b2f6afbe03841a6f0ca5fa363ceb5bcdcfe638

http: detach socket from IncomingMessage on keep-alive If the socket is not detached then a future call to res.destroy (through e.g. pipeline) would unecessarily kill the socket while its in the agent free list. PR-URL: https://github.com/nodejs/node/pull/32153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

RamanandPatil

commit sha d5674fd482249865abb24d3cbc39215d411cf444

src: elevate v8 namespace PR-URL: https://github.com/nodejs/node/pull/32041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Myles Borins

commit sha e00e77e857593caeda8fb04af14baf02faae543a

test: mark test-timers-blocking-callback flaky on osx This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32189 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Matteo Collina

commit sha d7fe5548ef27ba82fba1177297b1bc607702fb15

stream: do not swallow errors with async iterators and pipeline Before this patch, pipeline() could swallow errors by pre-emptively producing a ERR_STREAM_PREMATURE_CLOSE that was not really helpful to the user. Co-Authored-By: Robert Nagy <ronagy@icloud.com> PR-URL: https://github.com/nodejs/node/pull/32051 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Anna Henningsen

commit sha 8f61eef562f2083f0cb9dd11758065d4c8ec0c35

src: discard tasks posted to platform TaskRunner during shutdown Discard tasks silently that are posted when the Isolate is being disposed. It is not possible to avoid a race condition window between unregistering the Isolate with the platform and disposing it in which background tasks and the Isolate deinit steps themselves may lead to new tasks being posted. The only sensible action in that case is discarding the tasks. Fixes: https://github.com/nodejs/node/issues/31752 Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548 Refs: https://github.com/nodejs/node/pull/31795 Refs: https://github.com/nodejs/node/pull/30909 PR-URL: https://github.com/nodejs/node/pull/31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

push time in a month

push eventcjihrig/node

antsmartian

commit sha 08892fc0c488a4205f2880acda250af4a922aa51

stream: fix the spellings PR-URL: https://github.com/nodejs/node/pull/33635 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 55d9833ebf038f100fe14f9d75a81b082eeaf048

doc: remove default parameter value from header In the docs, we specify the default value of function parameters in the list below the header. There is one exception where we use default parameter notation. Change that instance to be like the rest of the docs instead. I rather like the default parameter notation, and I get why we didn't use it to begin with. (The notation didn't exist in JavaScript at the time.) I wouldn't mind switching to it, but that would result in big churn. That can be a separate topic of discussion. For now, though, let's get the docs consistent. PR-URL: https://github.com/nodejs/node/pull/33752 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 101e0a9d140357ac0fb532723b06d36d8cc0fe6c

doc: change "pre Node.js v0.10" to "prior to Node.js 0.10" The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: https://github.com/nodejs/node/pull/33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha eeede81c5ceadf405e22a84c921a9f06ab1ca6c2

doc: add formatting for version numbers to doc-style-guide.md PR-URL: https://github.com/nodejs/node/pull/33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 77b5e2da8feb46f6ab558e2947c52f3168e0bd6a

doc: remove "currently" from util.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha ac6739d96d5b52da8b307cc47c41a799b131dd72

doc: remove "currently" from addons.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha df30c9e6c03674a99da57cb1bf781c71f0eb0e4f

doc: remove "currently" from vm.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha e233d856862008902e701fec92026741ad898f13

doc: remove "currently" from events.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha a29d7c7ff7ed68cc7d1ba30b8ef24f64dc59df7c

doc: remove "currently" from repl.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Pranshu Srivastava

commit sha b9739b6e08fe279c239f6b0fbebf8ab6639383a1

doc: fix linting in doc-style-guide.md Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: https://github.com/nodejs/node/pull/33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

view details

Daniel Bevenius

commit sha 8a4b5c63e0b90cc036f98933c214f5b765849d44

src: use Check() instead of FromJust in environment This commit replaces FromJust() calls with Check() in places where the value that FromJust() returns is not used. PR-URL: https://github.com/nodejs/node/pull/33706 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha 0c31702405341eade38b2864c4381b0493360737

build: add LINT_CPP_FILES to checkimports check This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha 111d1e523d632c489bfe99adfb3f8c080e996d32

tools: remove unused using declarations code_cache This commit removes the reported unused using declarations from cache_builder.cc PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha 7f8e977ee04f9f67b3705b329b815825fad7116e

src,build: add --openssl-default-cipher-list This commit adds a configuration option named openssl-default-cipher-list which takes a colon separated string specifying ciphers that should be used as the default ciphers instead of the ones defined in node_constants. The motivation for this is a use case where Fedora/RHEL would like to be able to specify a default cipher in the format PROFILE=SYSTEM. This would enable Fedora/RHEL to have a system wide security level for all applications. PR-URL: https://github.com/nodejs/node/pull/33708 Refs: https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Daniel Bevenius

commit sha 813368c0371977b58f7781734c66b564fe9f92b4

src: add "missing" bash completion options Currently, when using the bash completions for node the normal completions for filenames directories do not work. For example, after finding a node completion and then wanting to use tab completion for a filename in the test directory, it is only possible to get the name of the test directory completed, followed by a space. What is expected is to be able to continue with tab completion for directories. This commit adds options to the complete command to enable default bash completions. PR-URL: https://github.com/nodejs/node/pull/33744 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

sapics

commit sha 689680a5315a51cfe347968a893c38bb60be56eb

src: simplify Reindent function in json_utils.cc PR-URL: https://github.com/nodejs/node/pull/33722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Milad Farazmand

commit sha de501d281cc96582f82dc56364a10019bb62c912

deps: V8: cherry-pick b5939c758924 Original commit message: Revert "s390: [arm] Add missing RELATIVE_CODE_TARGET iteration" This reverts commit 9d3cca1cd3ad7c6653cab1cdf111d356f33f77cd. Reason for revert: Only the test needs to be skipped on s390. Refer to this: https://crrev.com/c/1981505 Original change's description: > s390: [arm] Add missing RELATIVE_CODE_TARGET iteration > > Port b766299d2c382cc9817e73225bbebe29ce62b9d1 > Port 9592b043eed86db91a441d4bf78b7f0c8c2ce4dd > Port d915b8d668615a7d6d75cf7a61d3ca5a3d139799 > > Original Commit Message: > > Code object iteration was missing logic for RELATIVE_CODE_TARGET > reloc entries. Garbage collection could thus miss objects that were > referenced only as targets of pc-relative calls or jumps. > > RELATIVE_CODE_TARGETs are only used on arm, mips, and s390 and only > at mksnapshot-time. > > This exposed another issue in that the interpreter entry trampoline > copy we generate for profiling *did* contain relative calls in > runtime-accessible code. This is a problem, since code space on arm is, > by default, too large to be fully addressable through pc-relative > calls. This CL thus also disables the related > FLAG_interpreted_frames_native_stack feature on arm. > > objects. > > R=​jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Change-Id: Ifbcaed98d90a2730f0d6a8a7d32c621dab1ff5b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087693 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#66644} TBR=michael_dawson@ca.ibm.com,mlippautz@chromium.org,jyan@ca.ibm.com,jgruber@chromium.org,joransiu@ca.ibm.com,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id645a9def23d278235ff77f25249d2187e8105ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196521 Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67751} Refs: https://github.com/v8/v8/commit/b5939c758924f56824ca137e3bdc47bb373443e9 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Milad Farazmand

commit sha 651088c3e6b6399a3e656e397c3845b970ad7903

deps: V8: cherry-pick 4e1bf2bc92bd Original commit message: Skip InterpreterWithNativeStack on jitless mode As discussed under https://crrev.com/c/1981505, Test requires an executable CODE_SPACE and is thus incompatible with jitless mode. Change-Id: Icddad50a3484f0cfc5fb4abd7175058d50bc06d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193911 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67726} Refs: https://github.com/v8/v8/commit/4e1bf2bc92bd8560353ba2af2f171045bbecb7c7 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Brian White

commit sha 4ba90809edec189a2c4662258ef6cadb9d9620b4

events: improve arrayClone performance PR-URL: https://github.com/nodejs/node/pull/33774 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

cjihrig

commit sha 2e49010bc8f2d05f6b0eca66bd9fca08cb5745a5

doc: make events Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the events documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright libuv contributors. All rights reserved. +  * +  * Permission is hereby granted, free of charge, to any person obtaining a copy +  * of this software and associated documentation files (the "Software"), to +  * deal in the Software without restriction, including without limitation the +  * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +  * sell copies of the Software, and to permit persons to whom the Software is +  * furnished to do so, subject to the following conditions: +  * +  * The above copyright notice and this permission notice shall be included in +  * all copies or substantial portions of the Software. +  * +  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS +  * IN THE SOFTWARE. +  */ ++#include "uv.h"+#include "internal.h"++#include <sys/stat.h>++void uv_loadavg(double avg[3]) {++  avg[0] = 0.0;+  avg[1] = 0.0;+  avg[2] = 0.0;+}+++int uv_exepath(char* buffer, size_t* size) {+  ssize_t n;+  int fd = -1;++  if (buffer == NULL || size == NULL || *size == 0)+    return UV_EINVAL;++  n = *size - 1;+  if (n > 0) {+    fd = open("/proc/self/exefile", O_RDONLY);+    if (fd < 0)+      return UV__ERR(errno); +  }+  +  n = read(fd, buffer, n);+  if (n < 0 ) {+    int error = UV__ERR(errno);+    close(fd);+    return error;+  }++  close(fd);++  buffer[n] = '\0';+  *size = n;++  return 0;+}+++uint64_t uv_get_free_memory(void) {+  struct stat buf;++  if (stat("/proc", &buf) != 0)+    return UV__ERR(errno);++  return buf.st_size;+}++uint64_t uv_get_total_memory(void) {+  return 0;+}+++uint64_t uv_get_constrained_memory(void) {+  return 0;  /* Memory constraints are unknown. */+}+++int uv_resident_set_memory(size_t* rss) {+  *rss = 0;+  return UV_ENOSYS;+}+++int uv_uptime(double* uptime) {+  *uptime = 0.0;+  return UV_ENOSYS;+}+++int uv_cpu_info(uv_cpu_info_t** cpu_infos, int* count) {+  *cpu_infos = NULL;+  *count = 0;

Sorry, that was my suggestion from https://github.com/libuv/libuv/pull/2881#discussion_r438477409

mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.+ * Permission is hereby granted, free of charge, to any person obtaining a copy+ * of this software and associated documentation files (the "Software"), to+ * deal in the Software without restriction, including without limitation the+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or+ * sell copies of the Software, and to permit persons to whom the Software is+ * furnished to do so, subject to the following conditions:+ *+ * The above copyright notice and this permission notice shall be included in+ * all copies or substantial portions of the Software.+ *+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS+ * IN THE SOFTWARE.+ */++#include "uv.h"+#include "internal.h"++#include <sys/stat.h>++void uv_loadavg(double avg[3]) {++  avg[0] = 0.;+  avg[1] = 0.;+  avg[2] = 0.;+}+++int uv_exepath(char* buffer, size_t* size) {+  ssize_t n;+  int fd;++  if (buffer == NULL || size == NULL || *size == 0)+    return UV_EINVAL;+  n = *size - 1;+  if (n > 0) {+    fd = open("/proc/self/exefile", O_RDONLY);+    if(fd !=-1) {+      n = read(fd, buffer, n);

Should this read be done in a loop?

mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.+ * Permission is hereby granted, free of charge, to any person obtaining a copy+ * of this software and associated documentation files (the "Software"), to+ * deal in the Software without restriction, including without limitation the+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or+ * sell copies of the Software, and to permit persons to whom the Software is+ * furnished to do so, subject to the following conditions:+ *+ * The above copyright notice and this permission notice shall be included in+ * all copies or substantial portions of the Software.+ *+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS+ * IN THE SOFTWARE.+ */++#include "uv.h"+#include "internal.h"++#include <sys/stat.h>++void uv_loadavg(double avg[3]) {++  avg[0] = 0.;

Can you use 0.0 on these lines.

mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.+ * Permission is hereby granted, free of charge, to any person obtaining a copy+ * of this software and associated documentation files (the "Software"), to+ * deal in the Software without restriction, including without limitation the+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or+ * sell copies of the Software, and to permit persons to whom the Software is+ * furnished to do so, subject to the following conditions:+ *+ * The above copyright notice and this permission notice shall be included in+ * all copies or substantial portions of the Software.+ *+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS+ * IN THE SOFTWARE.+ */++#include "uv.h"+#include "internal.h"++#include <sys/stat.h>++void uv_loadavg(double avg[3]) {++  avg[0] = 0.;+  avg[1] = 0.;+  avg[2] = 0.;+}+++int uv_exepath(char* buffer, size_t* size) {+  ssize_t n;+  int fd;++  if (buffer == NULL || size == NULL || *size == 0)+    return UV_EINVAL;+  n = *size - 1;+  if (n > 0) {+    fd = open("/proc/self/exefile", O_RDONLY);+    if(fd !=-1) {
    if (fd != -1) {
mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.+ * Permission is hereby granted, free of charge, to any person obtaining a copy+ * of this software and associated documentation files (the "Software"), to+ * deal in the Software without restriction, including without limitation the+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or+ * sell copies of the Software, and to permit persons to whom the Software is+ * furnished to do so, subject to the following conditions:+ *+ * The above copyright notice and this permission notice shall be included in+ * all copies or substantial portions of the Software.+ *+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS+ * IN THE SOFTWARE.+ */++#include "uv.h"+#include "internal.h"++#include <sys/stat.h>++void uv_loadavg(double avg[3]) {++  avg[0] = 0.;+  avg[1] = 0.;+  avg[2] = 0.;+}+++int uv_exepath(char* buffer, size_t* size) {+  ssize_t n;+  int fd;++  if (buffer == NULL || size == NULL || *size == 0)+    return UV_EINVAL;+  n = *size - 1;+  if (n > 0) {+    fd = open("/proc/self/exefile", O_RDONLY);+    if(fd !=-1) {+      n = read(fd, buffer, n);+      close(fd);+    }+  }+  if (n == -1 || fd == -1)

It looks like fd can be accessed here without being initialized.

mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

 if(CMAKE_SYSTEM_NAME STREQUAL "SunOS")   list(APPEND uv_sources src/unix/no-proctitle.c src/unix/sunos.c) endif() + if(CMAKE_SYSTEM_NAME STREQUAL "QNX")+  list(APPEND uv_sources src/unix/posix-hrtime.c src/unix/posix-poll.c src/unix/qnx.c src/unix/bsd-ifaddrs.c src/unix/no-proctitle.c src/unix/no-fsevents.c)

Can you split this across lines like the other lists in this file.

mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.+ * Permission is hereby granted, free of charge, to any person obtaining a copy+ * of this software and associated documentation files (the "Software"), to+ * deal in the Software without restriction, including without limitation the+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or+ * sell copies of the Software, and to permit persons to whom the Software is+ * furnished to do so, subject to the following conditions:+ *+ * The above copyright notice and this permission notice shall be included in+ * all copies or substantial portions of the Software.+ *+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS+ * IN THE SOFTWARE.+ */++#include "uv.h"+#include "internal.h"++#include <sys/stat.h>++void uv_loadavg(double avg[3]) {++  avg[0] = 0.;+  avg[1] = 0.;+  avg[2] = 0.;+}+++int uv_exepath(char* buffer, size_t* size) {+  ssize_t n;+  int fd;++  if (buffer == NULL || size == NULL || *size == 0)+    return UV_EINVAL;+  n = *size - 1;+  if (n > 0) {+    fd = open("/proc/self/exefile", O_RDONLY);+    if(fd !=-1) {+      n = read(fd, buffer, n);+      close(fd);+    }+  }+  if (n == -1 || fd == -1)+    return UV__ERR(errno);++  buffer[n] = '\0';+  *size = n;++  return 0;+}+++uint64_t uv_get_free_memory(void) {+  struct stat buf;+  if (stat("/proc", &buf) != -1) { 

Can you rewrite this as:

if (stat("/proc", &buf) != 0)
  return UV__ERR(errno);

return buf.st_size;
mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

     defined(__NetBSD__) # include <sys/param.h> # include <sys/mount.h>-#elif defined(__sun) || defined(__MVS__) || defined(__NetBSD__) || defined(__HAIKU__)+#elif defined(__sun) || defined(__MVS__) || defined(__NetBSD__) || defined(__HAIKU__) || defined(__QNX__)

Can you wrap the lines at 80 characters (it looks like they had already crept past 80 characters prior to this change).

mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.

Please use this header: https://github.com/libuv/libuv/blob/2967557b6651ee10dd2f9e0b4baeff35df0ab684/src/unix/random-getrandom.c#L1-L20

mjvankampen

comment created time in a month

Pull request review commentlibuv/libuv

[QNX] platform support

+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.+ * Permission is hereby granted, free of charge, to any person obtaining a copy+ * of this software and associated documentation files (the "Software"), to+ * deal in the Software without restriction, including without limitation the+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or+ * sell copies of the Software, and to permit persons to whom the Software is+ * furnished to do so, subject to the following conditions:+ *+ * The above copyright notice and this permission notice shall be included in+ * all copies or substantial portions of the Software.+ *+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS+ * IN THE SOFTWARE.+ */++#include "uv.h"+#include "internal.h"++#include <sys/stat.h>++void uv_loadavg(double avg[3]) {++  avg[0] = 0.;+  avg[1] = 0.;+  avg[2] = 0.;+}+++int uv_exepath(char* buffer, size_t* size) {+  ssize_t n;+  int fd;++  if (buffer == NULL || size == NULL || *size == 0)+    return UV_EINVAL;+  n = *size - 1;+  if (n > 0) {+    fd = open("/proc/self/exefile", O_RDONLY);+    if(fd !=-1) {+      n = read(fd, buffer, n);+      close(fd);+    }+  }+  if (n == -1 || fd == -1)+    return UV__ERR(errno);++  buffer[n] = '\0';+  *size = n;++  return 0;+}+++uint64_t uv_get_free_memory(void) {+  struct stat buf;+  if (stat("/proc", &buf) != -1) { +    return buf.st_size;+  } else {+    return UV__ERR(errno);+  }+}++uint64_t uv_get_total_memory(void) {+  return 0;+}+++uint64_t uv_get_constrained_memory(void) {+  return 0;  /* Memory constraints are unknown. */+}+++int uv_resident_set_memory(size_t* rss) {+  return UV_ENOSYS;+}+++int uv_uptime(double* uptime) {+  return UV_ENOSYS;+}+++int uv_cpu_info(uv_cpu_info_t** cpu_infos, int* count) {+  return UV_ENOMEM;

Any particular reason for returning UV_ENOMEM instead of something like the Cygwin implementation?

mjvankampen

comment created time in a month

pull request commentnodejs/node

process: suggest --trace-warnings when printing warning

I don't have a strong opinion one way or the other, but I would not backport this unless it starts causing a lot of problems backporting other commits.

addaleax

comment created time in a month

pull request commentlibuv/libuv

win: Clang compatibility & solving SystemFunction036 undefined reference

I'd also prefer not supporting C++.

adrien-thierry

comment created time in a month

pull request commentnodejs/node

inspector: drop 'chrome-' from inspector url

Landed in 862d005e60...921f75534c. Thanks for the reviews!

cjihrig

comment created time in a month

delete branch cjihrig/node

delete branch : inspector

delete time in a month

PR merged nodejs/node

inspector: drop 'chrome-' from inspector url C++ author ready inspector

It has been reported that the V8 inspector extension can no longer connect to DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the 'chrome-devtools:' scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome.

Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+3 -4

1 comment

2 changed files

cjihrig

pr closed time in a month

push eventnodejs/node

cjihrig

commit sha fd7e40854c447234a05dc3ef0ee717cad138c681

doc: update V8 inspector example This commit updates the V8 inspector example to reflect what is currently printed to the console. PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

cjihrig

commit sha 921f75534cdc2ad6fdc61c573d18f61ca14b35da

inspector: drop 'chrome-' from inspector url It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in a month

push eventcjihrig/node

James M Snell

commit sha 74ca960aac4600953caacd5f250b11a90bd70ee7

lib: initial experimental AbortController implementation AbortController impl based very closely on: https://github.com/mysticatea/abort-controller Marked experimental. Not currently used by any of the existing promise apis. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33527 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha a8b26d72c514444e699e5dd99a38405c6a2b738a

lib: unflag AbortController It's still experimental, but make the flag non-op Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33527 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Benjamin Gruenbaum

commit sha 236237829b26c1756104b5a37797a591e8a5aba6

events: deal with no argument case PR-URL: https://github.com/nodejs/node/pull/33611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Benjamin Gruenbaum

commit sha 1969ada9824cb01c2ba46470faa5327a9c2ef263

events: set target property to null PR-URL: https://github.com/nodejs/node/pull/33615 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Benjamin Gruenbaum

commit sha bf33b61be04988d95bd2373e3b931e09d254e06b

events: support useCapture boolean PR-URL: https://github.com/nodejs/node/pull/33618 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Sagar Jadhav

commit sha 3ac50e12090a40e681cf1e9843a54ccfc102fbd5

test: changed function to arrow function Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: https://github.com/nodejs/node/pull/33711 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Michaël Zasso

commit sha e0586d0f7013095d9b0c7413121c9dc06de55826

build: output dots in "Build from tarball" action Signed-off-by: Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/33696 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Michaël Zasso

commit sha 0d08d5ae7c2e6175b268e2c17a4d835ff8f9f6ba

url: remove gopher from special schemes Refs: https://github.com/nodejs/node/issues/33315 Refs: https://github.com/whatwg/url/commit/d589670451a4da9717bad69ed5d5364f93fede33 Refs: https://github.com/whatwg/url/commit/7ae1c691c96f0d82fafa24c33aa1e8df9ffbf2bc PR-URL: https://github.com/nodejs/node/pull/33325 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 065426c90af4ae102dc66f7f801478deec368be5

tools: update remark-preset-lint-node from 1.15.0 to 1.15.1 PR-URL: https://github.com/nodejs/node/pull/33727 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha f5ed5fe06867884254fd885eca01b6ee5d21ac48

benchmark: fix async-resource benchmark In the benchmark, because it performs asynchronous operations before writing its HTTP replies, the underlying socket can be closed by the peer before the response is written. Since 28e6626ce7020, that means that attempting to `.end()` the HTTP response results in an uncaught exception, breaking the benchmark. Fix that by checking whether the response object has been destroyed or not before attempting to call `.end()`. https://github.com/nodejs/node/issues/33591 PR-URL: https://github.com/nodejs/node/pull/33642 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Gus Caplan

commit sha e983b1cece7d24f7b4776798916276d30b9e419a

deps: V8: cherry-pick 0d6debcc5f08 Original commit message: [turbofan] Fixes for integrating the fast C API This commit adds a few fixes neccessary for integrating the fast C API into Blink: - added default constructor for CFunction - removed a bogus template specialization allowing void* params - extended the public Isolate class Bug: chromium:1052746 Change-Id: I4f2ba84299920e2cc9d66ec1ed59302313db6c0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120587 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#66986} Refs: https://github.com/v8/v8/commit/0d6debcc5f08fe3c41d07686f82c9de05310519f PR-URL: https://github.com/nodejs/node/pull/33600 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Gus Caplan

commit sha d8eef83757c263672832687ac7667927a7d0c059

process: use v8 fast api calls for hrtime Refs: https://github.com/nodejs/node/issues/33374 PR-URL: https://github.com/nodejs/node/pull/33600 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

antsmartian

commit sha 08892fc0c488a4205f2880acda250af4a922aa51

stream: fix the spellings PR-URL: https://github.com/nodejs/node/pull/33635 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 55d9833ebf038f100fe14f9d75a81b082eeaf048

doc: remove default parameter value from header In the docs, we specify the default value of function parameters in the list below the header. There is one exception where we use default parameter notation. Change that instance to be like the rest of the docs instead. I rather like the default parameter notation, and I get why we didn't use it to begin with. (The notation didn't exist in JavaScript at the time.) I wouldn't mind switching to it, but that would result in big churn. That can be a separate topic of discussion. For now, though, let's get the docs consistent. PR-URL: https://github.com/nodejs/node/pull/33752 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 101e0a9d140357ac0fb532723b06d36d8cc0fe6c

doc: change "pre Node.js v0.10" to "prior to Node.js 0.10" The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: https://github.com/nodejs/node/pull/33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha eeede81c5ceadf405e22a84c921a9f06ab1ca6c2

doc: add formatting for version numbers to doc-style-guide.md PR-URL: https://github.com/nodejs/node/pull/33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 77b5e2da8feb46f6ab558e2947c52f3168e0bd6a

doc: remove "currently" from util.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha ac6739d96d5b52da8b307cc47c41a799b131dd72

doc: remove "currently" from addons.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha df30c9e6c03674a99da57cb1bf781c71f0eb0e4f

doc: remove "currently" from vm.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha e233d856862008902e701fec92026741ad898f13

doc: remove "currently" from events.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

push time in a month

delete branch cjihrig/node

delete branch : doc

delete time in a month

pull request commentnodejs/node

doc: make Extends usage consistent

Landed in 4ba90809ed...862d005e60. Thanks for the reviews!

cjihrig

comment created time in a month

PR merged nodejs/node

doc: make Extends usage consistent doc tools
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+12 -7

0 comment

4 changed files

cjihrig

pr closed time in a month

push eventnodejs/node

cjihrig

commit sha 2e49010bc8f2d05f6b0eca66bd9fca08cb5745a5

doc: make events Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the events documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 85dbd17bde1049022854581d09dc7d48fc6e6d24

doc: make perf_hooks Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the perf_hooks documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 862d005e603e8897336ee021094106c402603c2d

doc: make globals Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the globals documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in a month

push eventcjihrig/node

antsmartian

commit sha 08892fc0c488a4205f2880acda250af4a922aa51

stream: fix the spellings PR-URL: https://github.com/nodejs/node/pull/33635 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 55d9833ebf038f100fe14f9d75a81b082eeaf048

doc: remove default parameter value from header In the docs, we specify the default value of function parameters in the list below the header. There is one exception where we use default parameter notation. Change that instance to be like the rest of the docs instead. I rather like the default parameter notation, and I get why we didn't use it to begin with. (The notation didn't exist in JavaScript at the time.) I wouldn't mind switching to it, but that would result in big churn. That can be a separate topic of discussion. For now, though, let's get the docs consistent. PR-URL: https://github.com/nodejs/node/pull/33752 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 101e0a9d140357ac0fb532723b06d36d8cc0fe6c

doc: change "pre Node.js v0.10" to "prior to Node.js 0.10" The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: https://github.com/nodejs/node/pull/33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha eeede81c5ceadf405e22a84c921a9f06ab1ca6c2

doc: add formatting for version numbers to doc-style-guide.md PR-URL: https://github.com/nodejs/node/pull/33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 77b5e2da8feb46f6ab558e2947c52f3168e0bd6a

doc: remove "currently" from util.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha ac6739d96d5b52da8b307cc47c41a799b131dd72

doc: remove "currently" from addons.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha df30c9e6c03674a99da57cb1bf781c71f0eb0e4f

doc: remove "currently" from vm.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha e233d856862008902e701fec92026741ad898f13

doc: remove "currently" from events.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha a29d7c7ff7ed68cc7d1ba30b8ef24f64dc59df7c

doc: remove "currently" from repl.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Pranshu Srivastava

commit sha b9739b6e08fe279c239f6b0fbebf8ab6639383a1

doc: fix linting in doc-style-guide.md Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: https://github.com/nodejs/node/pull/33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

view details

Daniel Bevenius

commit sha 8a4b5c63e0b90cc036f98933c214f5b765849d44

src: use Check() instead of FromJust in environment This commit replaces FromJust() calls with Check() in places where the value that FromJust() returns is not used. PR-URL: https://github.com/nodejs/node/pull/33706 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha 0c31702405341eade38b2864c4381b0493360737

build: add LINT_CPP_FILES to checkimports check This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha 111d1e523d632c489bfe99adfb3f8c080e996d32

tools: remove unused using declarations code_cache This commit removes the reported unused using declarations from cache_builder.cc PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha 7f8e977ee04f9f67b3705b329b815825fad7116e

src,build: add --openssl-default-cipher-list This commit adds a configuration option named openssl-default-cipher-list which takes a colon separated string specifying ciphers that should be used as the default ciphers instead of the ones defined in node_constants. The motivation for this is a use case where Fedora/RHEL would like to be able to specify a default cipher in the format PROFILE=SYSTEM. This would enable Fedora/RHEL to have a system wide security level for all applications. PR-URL: https://github.com/nodejs/node/pull/33708 Refs: https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Daniel Bevenius

commit sha 813368c0371977b58f7781734c66b564fe9f92b4

src: add "missing" bash completion options Currently, when using the bash completions for node the normal completions for filenames directories do not work. For example, after finding a node completion and then wanting to use tab completion for a filename in the test directory, it is only possible to get the name of the test directory completed, followed by a space. What is expected is to be able to continue with tab completion for directories. This commit adds options to the complete command to enable default bash completions. PR-URL: https://github.com/nodejs/node/pull/33744 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

sapics

commit sha 689680a5315a51cfe347968a893c38bb60be56eb

src: simplify Reindent function in json_utils.cc PR-URL: https://github.com/nodejs/node/pull/33722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Milad Farazmand

commit sha de501d281cc96582f82dc56364a10019bb62c912

deps: V8: cherry-pick b5939c758924 Original commit message: Revert "s390: [arm] Add missing RELATIVE_CODE_TARGET iteration" This reverts commit 9d3cca1cd3ad7c6653cab1cdf111d356f33f77cd. Reason for revert: Only the test needs to be skipped on s390. Refer to this: https://crrev.com/c/1981505 Original change's description: > s390: [arm] Add missing RELATIVE_CODE_TARGET iteration > > Port b766299d2c382cc9817e73225bbebe29ce62b9d1 > Port 9592b043eed86db91a441d4bf78b7f0c8c2ce4dd > Port d915b8d668615a7d6d75cf7a61d3ca5a3d139799 > > Original Commit Message: > > Code object iteration was missing logic for RELATIVE_CODE_TARGET > reloc entries. Garbage collection could thus miss objects that were > referenced only as targets of pc-relative calls or jumps. > > RELATIVE_CODE_TARGETs are only used on arm, mips, and s390 and only > at mksnapshot-time. > > This exposed another issue in that the interpreter entry trampoline > copy we generate for profiling *did* contain relative calls in > runtime-accessible code. This is a problem, since code space on arm is, > by default, too large to be fully addressable through pc-relative > calls. This CL thus also disables the related > FLAG_interpreted_frames_native_stack feature on arm. > > objects. > > R=​jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Change-Id: Ifbcaed98d90a2730f0d6a8a7d32c621dab1ff5b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087693 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#66644} TBR=michael_dawson@ca.ibm.com,mlippautz@chromium.org,jyan@ca.ibm.com,jgruber@chromium.org,joransiu@ca.ibm.com,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id645a9def23d278235ff77f25249d2187e8105ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196521 Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67751} Refs: https://github.com/v8/v8/commit/b5939c758924f56824ca137e3bdc47bb373443e9 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Milad Farazmand

commit sha 651088c3e6b6399a3e656e397c3845b970ad7903

deps: V8: cherry-pick 4e1bf2bc92bd Original commit message: Skip InterpreterWithNativeStack on jitless mode As discussed under https://crrev.com/c/1981505, Test requires an executable CODE_SPACE and is thus incompatible with jitless mode. Change-Id: Icddad50a3484f0cfc5fb4abd7175058d50bc06d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193911 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67726} Refs: https://github.com/v8/v8/commit/4e1bf2bc92bd8560353ba2af2f171045bbecb7c7 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Brian White

commit sha 4ba90809edec189a2c4662258ef6cadb9d9620b4

events: improve arrayClone performance PR-URL: https://github.com/nodejs/node/pull/33774 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

cjihrig

commit sha 2e49010bc8f2d05f6b0eca66bd9fca08cb5745a5

doc: make events Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the events documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in a month

Pull request review commentlibuv/libuv

win: Clang compatibility & solving SystemFunction036 undefined reference

 int uv_fs_poll_start(uv_fs_poll_t* handle,    loop = handle->loop;   len = strlen(path);-  ctx = uv__calloc(1, sizeof(*ctx) + len);+  ctx = (struct poll_ctx *)uv__calloc(1, sizeof(*ctx) + len);

If this lands, all of the pointers should be updated so that the star leans left. For example, (struct poll_ctx*) here.

adrien-thierry

comment created time in a month

push eventcjihrig/grpc-server-js

cjihrig

commit sha 2df9c5d258a8bfac5470ac4bc995b56f17243f68

check for closed sessions in tryShutdown() Server.prototype.tryShutdown() gracefully closes all of the HTTP2 sessions still active in the server. This commit updates that logic to only try to close sessions that haven't had their 'closed' property set to true. I don't think this is necessary, but it's better to be safe at the expense of one line of code coverage.

view details

push time in a month

PR opened nodejs/node

doc: make Extends usage consistent
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+12 -7

0 comment

4 changed files

pr created time in a month

create barnchcjihrig/node

branch : doc

created branch time in a month

PR opened nodejs/node

tools: update ESLint to 7.2.0

Update ESLint to 7.2.0

(The no-unused-vars rule has changed the way it reports errors. This required changing a benchmark and a test.)

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines
+311 -117

0 comment

43 changed files

pr created time in a month

create barnchcjihrig/node

branch : eslint

created branch time in a month

Pull request review commentnodejs/node

inspector: drop 'chrome-' from inspector url

 flag instead of `--inspect`.  ```console $ node --inspect index.js-Debugger listening on 127.0.0.1:9229.-To start debugging, open the following URL in Chrome:-    chrome-devtools://devtools/bundled/js_app.html?experiments=true&v8only=true&ws=127.0.0.1:9229/dc9010dd-f8b8-4ac5-a510-c1a114ec7d29+Debugger listening on ws://127.0.0.1:9229/dc9010dd-f8b8-4ac5-a510-c1a114ec7d29

At some point, what is actually printed to the console changed. This is what is currently displayed.

cjihrig

comment created time in a month

PR opened nodejs/node

inspector: drop 'chrome-' from inspector url

It has been reported that the V8 inspector extension can no longer connect to DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the 'chrome-devtools:' scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome.

Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+3 -4

0 comment

2 changed files

pr created time in a month

push eventcjihrig/node

João Reis

commit sha cb8898c48feac55ef49b1594d7a4131e827c213e

win: block running on EOL Windows versions Windows 7 and Windows Server 2008 R2 EOL was January 14, 2020. Windows 8 EOL was January 12, 2016. Windows 2012 (not R2) is still supported and allowed to run. This clarifies that support is experimental. PR-URL: https://github.com/nodejs/node/pull/31954 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Harshitha KP

commit sha 757e2037e74fecca521c664fc8486596b306de39

src: Handle bad callback in asyc_wrap Align with the MaybeLocal<> API contract PR-URL: https://github.com/nodejs/node/pull/31946 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 616a729b3837c6152da6bb7f7c06aecbbdaa2696

test: remove common.expectsInternalAssertion Remove convenience function for internal assertions. It is only used once. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Rich Trott

commit sha b1d4c13430c92e94920f0c8c9ba1295c075c9e89

test: add coverage for FSWatcher exception Cover an previously uncovered exception possible in the internal start function for FSWatcher. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Ben Noordhuis

commit sha 9ec87815027ddf6782ab930975b86333a61ed554

crypto: make update(buf, enc) ignore encoding Make the cipher/decipher/hash/hmac update() methods ignore the input encoding when the input is a buffer. This is the documented behavior but some inputs were rejected, notably when the specified encoding is 'hex' and the buffer has an odd length (because a _string_ with an odd length is never a valid hex string.) The sign/verify update() methods work okay because they use different validation logic. Fixes: https://github.com/nodejs/node/issues/31751 PR-URL: https://github.com/nodejs/node/pull/31766 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

James M Snell

commit sha b023d61716ddc9cd97cc148bb8d237ec8d894d2b

lib: move isLegalPort to validators, refactor isLegalPort was used multiple places in the same way -- to validate the port and throw if necessary. Moved into internal/validators. PR-URL: https://github.com/nodejs/node/pull/31851 Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

James M Snell

commit sha ba462c2e1ef1edff3af03d079c8a9bed22d09e80

src: introduce node_sockaddr Introduce the SocketAddress utility class. The QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32070 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Yael Hermon

commit sha 0d8a84adca73a0fd3554c98236389f64f854ccc3

doc: update email address in authors update my personal email PR-URL: https://github.com/nodejs/node/pull/32026 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha c3c64a1034a52e58c9684a0135a2e4ce536e41ef

meta: move thefourtheye to TSC Emeritus thefourtheye has a considerable history of contributions to Node.js. They have not been active much of late, and the TSC Charter has a section about activity indicating that moving to Emeritus at this time is the thing to do. Thanks for all you've done to make Node.js fantastic, thefourtheye, and hope to see you around again soon! PR-URL: https://github.com/nodejs/node/pull/32059 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Brian White

commit sha 5cc0754090b4dc504652ea57803312c9b9f1cef0

benchmark: remove problematic tls params These very small values can cause crashes/exceptions to occur on some systems because most time is spent in V8 GC or in parts of node core that are not being tested (e.g. streams). PR-URL: https://github.com/nodejs/node/pull/31816 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha b6cd2155c3442a8c56aa6f6ffa0dc9b6a308a7b1

doc: remove em dashes Our documentation uses em dashes inconsistently. They are treated inconsistently typographically too. (For example, they are sometimes surrounded by spaces and sometimes not.) They are also often confused with ordinary hyphens such as in the CHANGELOG, where they are inadvertently mixed together in a single list. The difference is not obvious in the raw markdown but is very noticeable when rendered, appearing to be a typographical error (which it in fact is). The em dash is never needed. There are always alternatives. Remove em dashes entirely. PR-URL: https://github.com/nodejs/node/pull/32080 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

James M Snell

commit sha 434d39dd670845cafd122fadb0a75d72c1658b05

src,http2: introduce node_http_common The nghttp2 and nghttp3 (used in the QUIC implementation) share nearly identical structs for header handling. However, they differ enough that they need to be handled slightly different in each case. This PR includes some elements introduced in the QUIC PR separated out to make them independently reviewable, and updates the http2 implementation to use the shared utilities. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32069 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Andrey Pechkurov

commit sha 86ab4ee6e49681fb4a9603128af4f6fa29806183

async_hooks: fix ctx loss after nested ALS calls PR-URL: https://github.com/nodejs/node/pull/32085 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Luigi Pinca

commit sha 6f0ec79e42c07357fe33f353e65d76856d922582

http,stream: make virtual methods throw an error Make virtual methods throw an ERR_METHOD_NOT_IMPLEMENTED error instead of emitting it. The error is not recoverable and the only way to handle it is to override the method. PR-URL: https://github.com/nodejs/node/pull/31912 Refs: https://github.com/nodejs/node/pull/31818#pullrequestreview-359403469 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Alba Mendez

commit sha f69de13bfe1102ff53aa93d40045352441880704

fs: fix writeFile[Sync] for non-seekable files Completely disables the use of positioned writes at writeFile and writeFileSync, which allows it to work with non-seekable files. Fixes: https://github.com/nodejs/node/issues/31926 PR-URL: https://github.com/nodejs/node/pull/32006 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Robert Nagy

commit sha 960be159ac3b21bf8a4f8c3bca7e733d483fb7d9

stream: add comments to pipeline implementation Fixes: https://github.com/nodejs/node/issues/32039 PR-URL: https://github.com/nodejs/node/pull/32042 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

zfx

commit sha 1b3dbc9635d45c83e355d312b6114d58664b1e7a

events: fix removeListener for Symbols Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () => { }; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) => { console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn); }); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: https://github.com/nodejs/node/pull/31847 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 8700d89306cc4c1fd1a540d4b8f27a59f7b4957e

http: fix socket re-use races Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can happen several ticks later. Sockets are removed from the free list on the 'close' event. However, there is a delay between calling destroy() and 'close' being emitted. This means that it possible for a socket that has been destroyed to be re-used from the free list, causing unexpected failures. PR-URL: https://github.com/nodejs/node/pull/32000 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Jakob Kummerow

commit sha 654dbd001b797f9d38f3267edef0ef3e8110df21

test: update tests for larger Buffers V8 is about to increase the max TypedArray length to 2**32-1, which Node inherits as Buffer.kMaxLength. Some tests relied on values greater than the previous max length (2**31-1) to throw errors; this updates those tests for the new max length. PR-URL: https://github.com/nodejs/node/pull/32114 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Michaël Zasso

commit sha c49286ba8b3b8aeac1aa40abcc1da7bb4dd7cbf1

build: enable backtrace when V8 is built for PPC and S390x Refs: https://github.com/nodejs/node-v8/issues/119 PR-URL: https://github.com/nodejs/node/pull/32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in a month

more