profile
viewpoint
Colin Ihrig cjihrig Pittsburgh, PA node.js tsc, libuv collaborator, hapi core team member. also does things with wasm/wasi and grpc

cjihrig/credit-card 87

Credit card validation

cjihrig/grpc-server-js 51

Pure JavaScript gRPC Server

cjihrig/hapi-gateway 30

use hapi as a gateway to lambda functions

autopilotpattern/postgres 11

Implementation of the Autopilot Pattern for Postgres

cjihrig/grpc-benchmarking 10

Benchmarking, but for gRPC

cjihrig/artificial 9

Inject fake HTTP request/response into an Express server

cjihrig/bcrypt.wasm 8

bcrypt in WebAssembly

cjihrig/belly-button 8

The best source for lint

cjihrig/ghostbuster 7

A Node.js wrapper for PhantomJS

cjihrig/farmhash.wasm 3

WebAssembly implementation of Google FarmHash

pull request commentcjihrig/uvwasi

fix: clocks header only on windows

I dunno. I'm all for stricter flags, but not being able to import the header file from the .c file seems a bit odd. The fact that it's allowed on Windows seems even more odd. Unless I'm missing something, this doesn't seem like the best way to move forward.

codebytere

comment created time in a day

created tagcjihrig/grpc-server-js

tagv0.2.0

Pure JavaScript gRPC Server

created time in 2 days

release cjihrig/grpc-server-js

v0.2.0

released time in 2 days

push eventcjihrig/grpc-server-js

cjihrig

commit sha 1cdb209baba2be4290ff01b4ac8f760302a77d00

v0.2.0

view details

push time in 2 days

push eventcjihrig/grpc-server-js

cjihrig

commit sha 84f2450a20873fda07bbca1f2502aef71312658f

re-add ServerCredentials Re-add a ServerCredentials implementation instead of depending on @grpc/grpc-js.

view details

cjihrig

commit sha 527cd93aceaea3ef110a394426183f53648e8d7d

move @grpc/grpc-js to devDependencies Production dependency free !

view details

cjihrig

commit sha 937e5a3c8a537ce6c72a3ed2653bc89f80dc9f2a

update README with recent changes

view details

push time in 2 days

push eventcjihrig/grpc-server-js

cjihrig

commit sha ce15a30fbfb9fedcc82a8dcd4bb2c5fc0bb33e42

update @grpc/grpc-js dependency

view details

cjihrig

commit sha 2c18f7245dd7e2b246b1bed44d2be4bc16b2e9d3

add status constants As a first step toward removing the production dependency on @grpc/grpc-js, add the status constants to this module.

view details

cjihrig

commit sha 49e3690de48b759ecfd49316ea3cd57585390054

add logging and metadata support Add implementations of logging and metadata in an effort to remove the @grpc/grpc-js dependency.

view details

push time in 2 days

push eventcjihrig/uvwasi

cjihrig

commit sha 9e471628579bbb6225fa6a34f91a72a3a3e905d0

update unions Unions became tagged unions in snapsnot preview 2. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

push time in 2 days

pull request commentlibuv/libuv

build: remove support for gyp

Seems fine. We can always add people back. Maybe @ mention the people to be removed and see if they'd like to stay?

bnoordhuis

comment created time in 2 days

push eventcjihrig/uvwasi

cjihrig

commit sha 931f0ac8e1d6483f517832021a482bcf1753dec6

rename EACCES to EACCESS The WASI spec has decided to deviate from POSIX starting in snapshot preview 2. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

push time in 2 days

push eventcjihrig/uvwasi

cjihrig

commit sha 1761729f6eec8d4a60087a75f31899e81b159f72

remove CPU time clocks These clocks were removed from WASI in snapshot2. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

push time in 2 days

push eventcjihrig/uvwasi

Shelley Vohr

commit sha 42a993d264d8e6b7dd74104000cd8cd9421c2579

docs: add build instructions

view details

Shelley Vohr

commit sha 7609d610a48865491ed91ce5272cce970dbd3ec4

src: add missing clocks header include

view details

Shelley Vohr

commit sha 92f320ee7e04591dfb81f83319dcbb24a6d731b0

src: fix implicit type conversion

view details

Xu Meng

commit sha 8147750c306d1276bd40965d235b8ee778402293

ibmi: remove unsupported API posix_fadvise on IBMi PASE The API posix_fadvise is not supported on IBMi PASE

view details

cjihrig

commit sha 2fd8b0f9499d102555cb9d4971d0f09c19bfdcda

rename creat to create This was changed as part of snapshot_preview2. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

cjihrig

commit sha 1873de4115fa4be9637ce0cebb9426f20178a583

add __wasi_poll_oneoff() input validation snapshot_preview2 added the constraint that poll_oneoff() should return EINVAL if nsubscriptions is zero. Even though poll_oneoff() isn't implemented yet, this commit adds the necessary input validation. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

cjihrig

commit sha 6939709262be4df9625c5a91f3dc44c383e60c71

remove signal related APIs snapshot_preview2 dropped the signal related APIs. This means removing __wasi_proc_raise() and __wasi_signal_t, which is what this commit does. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

cjihrig

commit sha e3c85d4b737810d6f46bc55516113c2ff789b4a6

add __WASI_FILETYPE_FIFO type snapshot_preview2 added support for FIFO types. Prior to this, FIFOs were treated as sockets and unknown files. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

cjihrig

commit sha 664a847d0fe0bdb64b195c6a5f023c68a759a97e

add setup for new permissions APIs snapshot2 adds the following for working with file permissions: - A permissions data type representing read, write, execute, and "private" permissions. - path_permissions_set() which is similar to fchmodat(). - fd_permissions_set() which is similar to fchmod(). - Two new rights for calling the two new functions. - A permissions field added to the filestat type. - A permissions argument passed to path_open(). This will need to be verified against the wasi-libc once the changes land there. Based on the auto-generated WASI docs, it seems likely that existing constants will change/break. Refs: https://github.com/cjihrig/uvwasi/issues/59

view details

cjihrig

commit sha af5458e6bea46bf1e7df613253fdb4f60e973b4c

remove CPU time clocks These clocks were removed from WASI in snapshot2.

view details

push time in 2 days

pull request commentcjihrig/uvwasi

fix: clocks header only on windows

@codebytere any update on why this might be "a thing" on Electron but does not seem to be elsewhere?

codebytere

comment created time in 2 days

issue commentnodejs/admin

Additional org owned by Node.js project for package maintenance team

Sounds like a decent idea. +1 to trying it.

mhdawson

comment created time in 2 days

push eventcjihrig/grpc-server-js

cjihrig

commit sha 18f58829b1aac4a46e06038a69fd913aee6e8af0

add method name to UNIMPLEMENTED response

view details

push time in 2 days

push eventcjihrig/uvwasi

Xu Meng

commit sha 8147750c306d1276bd40965d235b8ee778402293

ibmi: remove unsupported API posix_fadvise on IBMi PASE The API posix_fadvise is not supported on IBMi PASE

view details

push time in 2 days

PR merged cjihrig/uvwasi

Reviewers
ibmi: remove unsupported API posix_fadvise on IBMi PASE

The API posix_fadvise is not supported on IBMi PASE

+5 -0

0 comment

1 changed file

dmabupt

pr closed time in 2 days

Pull request review commentlibuv/libuv

win,fs: fix problems with passing file names to uv_fs_statfs

 static void fs__statfs(uv_fs_t* req) {                              &bytes_per_sector,                              &free_clusters,                              &total_clusters)) {-    SET_REQ_WIN32_ERROR(req, GetLastError());-    return;+    DWORD err;++    err = GetLastError();+    if (err == ERROR_DIRECTORY) {+      WCHAR* pathw;+      size_t len;+      DWORD ret;++      len = MAX_PATH + 1;+      pathw = uv__malloc(len * sizeof(*pathw));+retry:+      ret = GetFullPathNameW(req->file.pathw,

When I recommended using GetFullPathNameW() in https://github.com/libuv/libuv/issues/2683#issuecomment-587255011, my thought was that we could use the last parameter (lpFilePart) to identify the file name to strip off so that we could avoid parsing the file manually.

erw7

comment created time in 2 days

create barnchkrustyrs/krusty

branch : master

created branch time in 3 days

created repositorykrustyrs/krusty

The Krusty Framework

created time in 3 days

Pull request review commentnodejs/node

vm: implement vm.measureMemory() for per-context memory measurement

 STDERR/STDOUT, and the data's length is longer than the `maxBuffer` option. `Console` was instantiated without `stdout` stream, or `Console` has a non-writable `stdout` or `stderr` stream. +<a id="ERR_CONTEXT_NOT_INITIALIZED"></a>+### `ERR_CONTEXT_NOT_INITIALIZED`++The vm context passed into the API is not yet initialized. This could happen+when an error occurs (and is caught) previously during the creation of the
when an error occurs (and is caught) during the creation of the
joyeecheung

comment created time in 4 days

issue commentlibuv/libuv

uv_fs_statfs fails for paths to files on Windows

So what if we try again in the parent directory if it fails?

I think we're suggesting the same thing.

Not sure if passing the parent instead of the root will work on all versions of windows.

I'm not sure either.

SheikhSajid

comment created time in 5 days

issue commentlibuv/libuv

uv_fs_statfs fails for paths to files on Windows

I'm not sure if there is a better way to do it on Windows, but libuv could detect the error and retry with the directory portion (GetFullPathNameW() could help there). Alternatively, we could always try to detect the directory portion first.

SheikhSajid

comment created time in 5 days

issue commentnodejs/llnode

PSA: repository tracking V8 postmortem changes

That's great. Thank you.

will create an issue every time metadata changes are detected

Just so I know where to watch... will the issues be created here, the llnode-v8-tester repo, or somewhere else?

mmarchini

comment created time in 6 days

issue commenthapijs/hapi

Post-mortem on a recent hapi logging adventure

The fact that server.log() triggers 'log' events, but request.log() triggers 'request' events.

You see this solely as a naming issue, is that right?

Yes and no. Yes, in that I would expect 'request' to be similar to 'response'. No, in that it's not an event, but an extension point.

Did you investigate the filter and channel options provided via podium? If so, where did those fall down for you?

I think my issue is more that the 'request' event does too many things - kind of an umbrella of things related to requests. It would be more straightforward if there were separate events (example names request-log and request-error) to make it much more explicit what data you're subscribing to (which you could further filter based on channel, etc.).

When you say "objects," are you referencing hapi-specific objects such as request and route objects, or arbitrary objects that users might log?

Using pino as an example, they have a collection of standard serializers for things like the request and response objects. This provides a known format for the rest of the pino ecosystem to build on.

Do you see this interplaying with event tag filters?

Sort of. Log levels are different from events though. Events can be filtered based on a string name. For log levels, the values need to map to values that can be compared in a way that makes sense. For example, doing a string compare between 'error' and 'info' doesn't make much sense for determining log level.

I think hapi-pino has solved this issue (and some of the issues mentioned above, e.g. utilizing tags for log levels) fairly well. Are you overall encouraging hapi to provide some of the functionality provided by external libraries (e.g. hapi-pino) rather than providing the very generic eventing/filtering system that it currently does? And would you advocate it be part of hapi core, or a separate module (i.e. replacing good, which is deprecated at the end of the year)?

hapi-pino is a great inspiration, but is ultimately tied to an external team, another http framework, and out of hapi's control. We were using hapi-pino until today, but because of $reasons I needed to either write a logging module that tied into hapi directly, or a pino transport. I think hapi should have an official logging solution (to replace good). I don't have an opinion about it being built into core or just under the hapijs org, but it should be The Way™ to do hapi logging.

cjihrig

comment created time in 6 days

pull request commentnodejs/node

doc,src,test: assign missing deprecation code

I don't think so. It goes along with https://github.com/nodejs/node/pull/28396, which is semver-major.

cjihrig

comment created time in 6 days

delete branch cjihrig/node

delete branch : doc

delete time in 6 days

issue openednodejs/TSC

Archival of the node-chakracore repo

TL;DR - Microsoft doesn't plan to maintain the repo anymore.

See https://github.com/nodejs/node-chakracore/issues/628 for all of the details.

I'd like to archive this repo. Is anyone opposed to doing so?

created time in 6 days

issue openedhapijs/hapi

Post-mortem on a recent hapi logging adventure

Support plan

  • which support plan is this issue covered by? (e.g. Community, Core, Plus, or Enterprise): community
  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: 12 and 13
  • module version: 19.x
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): hapi application
  • any other relevant information: related to events and logging

What problem are you trying to solve?

I was recently working on a logging module (https://github.com/cjihrig/graylogi) and ended up diving into the events and logging deeper than I otherwise have recently. This issue is documenting some of the things that I found a bit confusing, as well as some logging features that would be useful to have from the framework:

  • The 'request' event is not emitted when a new request is received. Due to its name, and the presence of the similar 'response' event, it took me a minute to realize that I needed the onRequest extension instead.
  • The fact that server.log() triggers 'log' events, but request.log() triggers 'request' events.
  • The fact that request errors also trigger 'request' events. It's nice that there are a small number of events to handle, but the flip side is that individual event handlers end up more complex than they'd otherwise need to be.

Do you have a new or modified API suggestion to solve the problem?

From a logging perspective, the following things would be great to have:

  • It would be nice if hapi either provided some logging friendly objects/methods as first class citizens, or toJSON() methods on more objects that are otherwise problematic to deal with in JSON (circular structures, Maps, etc.). I know this might be tricky, as people will always want different things in their logs.

  • Built in support for ignoring events based on path or tags would also be great. For example, ignoring everything related to /health.

  • Support for log levels, including the ability to set a default log level and a minimum log level threshold.

  • A documented log format. That would enable things like logging to stdout/stderr from hapi, and piping them to another process for more in depth handling (reformatting, shipping, etc.). This is similar to pino's concept of transports.

Sorry if it seems like I'm requesting a lot 😄

created time in 6 days

issue closednodejs/node

Wanna see my hot pics?💋💋💋

Hi!😻😻😻 Wanna see my hot pics?💋💋💋 Go to this site and find me here. ❤️❤️❤️ My nick is sexygirl662 👇👇👇

https://tinyurl.com/tza85ua

closed time in 6 days

helen773

issue closednodejs/node

Wanna see my hot pics?💋💋💋

Hi!😻😻😻 Wanna see my hot pics?💋💋💋 Go to this site and find me here. ❤️❤️❤️ My nick is sexygirl662 👇👇👇

https://tinyurl.com/ulpu2gz

closed time in 6 days

helen119

created tagcjihrig/graylogi

tagv0.1.0

Graylog logger for hapi

created time in 6 days

release cjihrig/graylogi

v0.1.0

released time in 6 days

push eventcjihrig/graylogi

Colin Ihrig

commit sha b467e1fa360efcd4c9404a827e555fd7f74d52cb

Initial commit

view details

push time in 6 days

push eventcjihrig/graylogi

Colin Ihrig

commit sha 12698826268ffee48673d0026dff03c0b2eab1c2

Initial commit

view details

push time in 6 days

create barnchcjihrig/graylogi

branch : master

created branch time in 7 days

created repositorycjihrig/graylogi

Graylog logger for hapi

created time in 7 days

pull request commentcjihrig/uvwasi

fix: clocks header only on windows

Could those errors be something Electron specific? The CI in https://github.com/cjihrig/uvwasi/pull/97 seemed OK, and it runs on Ubuntu, macOS, and Windows. There is also no #ifdef logic regarding the use of those functions (although there is inside of the functions themselves).

codebytere

comment created time in 8 days

created tagcjihrig/gelfie

tagv0.2.1

GELF client

created time in 8 days

release cjihrig/gelfie

v0.2.1

released time in 8 days

push eventcjihrig/gelfie

cjihrig

commit sha d9372b0120fceeef6a81d910f419171d4fe194be

v0.2.1

view details

push time in 8 days

push eventcjihrig/gelfie

cjihrig

commit sha c3a4e5ef3d3df97cf301f0f0497b1f9bf4687945

add documentation

view details

push time in 8 days

push eventcjihrig/gelfie

cjihrig

commit sha 3491f6898b59949051eb62e2105d898fc9639502

add documentation

view details

push time in 8 days

push eventcjihrig/node

himself65

commit sha e588ed7391fb2a92b3936e0011d6fbe0df903fc2

doc: fix a broken link in fs.md PR-URL: https://github.com/nodejs/node/pull/31373 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 7b78ff04283e735d421d7dce4433969c5a71e2e8

stream: support passing generator functions into pipeline() PR-URL: https://github.com/nodejs/node/pull/31223 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ben Noordhuis

commit sha cc0748f509140b7b42d157348300a5581db98a37

test: export public symbols in addons tests Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: https://github.com/nodejs/node/pull/28647 Refs: https://github.com/nodejs/node-gyp/pull/1828 PR-URL: https://github.com/nodejs/node/pull/28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha 7864c53629b11d69746a4fc1f041900eeb358d31

fs: unset FileHandle fd after close - Do not set the fd as a property on the native object. - Use the already-existent `GetFD()` method to pass the fd from C++ to JS. - Cache the fd in JS to avoid repeated accesses to the C++ getter. - Set the fd to `-1` after close, thus reliably making subsequent calls using the `FileHandle` return `EBADF`. Fixes: https://github.com/nodejs/node/issues/31361 PR-URL: https://github.com/nodejs/node/pull/31389 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Matheus Marchini

commit sha b3189266347fa05395860f9f6e8949e447977284

test: update postmortem test with v12 constants Ref: https://github.com/nodejs/llnode/pull/330 PR-URL: https://github.com/nodejs/node/pull/31391 Refs: https://github.com/nodejs/llnode/pull/330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gabriel Schulhof

commit sha 85592e281802f82c8e4b211a8e280b481fd65388

src: reduce large pages code duplication Declaring and initializing a `struct text_region` is common to all three implementations of the large pages mapping code. Let's make it unconditional. PR-URL: https://github.com/nodejs/node/pull/31385 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

cjihrig

commit sha 57bd715d527aba8dae56b975056961b0e429e91e

doc: fix several child_process doc typos PR-URL: https://github.com/nodejs/node/pull/31393 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Robert Nagy

commit sha 7d5a86cc05f3b8782b37c7ed438b3e994f6bd713

fs: do not emit 'close' twice if emitClose enabled fs streams have some backwards compat behavior that does not behave well if emitClose: true is passed in options. This fixes this edge case until the backwards compat is removed. PR-URL: https://github.com/nodejs/node/pull/31383 Fixes: https://github.com/nodejs/node/issues/31366 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 4f11fb6410728f5b026ea4b9b29775622dc4f849

test: add wasi test for symlink() and readlink() This test provides missing coverage for __wasi_path_symlink() and __wasi_path_readlink(). PR-URL: https://github.com/nodejs/node/pull/31403 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Harshitha KP

commit sha 343ddffc1c025e444f28dbb0ccfefc23815479d3

doc: document process.std*.fd Fixes: https://github.com/nodejs/node/issues/28386 Refs: https://github.com/nodejs/node/pull/31292 Refs: https://github.com/nodejs/help/issues/2136 PR-URL: https://github.com/nodejs/node/pull/31395 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Guy Bedford

commit sha c2c3274631fe50b7e7e8949f453e01a38f5a3695

module: fix check exports issue in cjs module loading Refs: https://github.com/nodejs/node/pull/31001#issuecomment-576353389 PR-URL: https://github.com/nodejs/node/pull/31427 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha dcba12895ad58275ba5b027c2c5110461dfebf66

test,module: add test for exports cjs loader check Refs: https://github.com/nodejs/node/pull/31001#issuecomment-576353389 PR-URL: https://github.com/nodejs/node/pull/31427 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha f0d2df41f8716670435b284e987b2fcc23221947

fs: change streams to always emit close by default Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. PR-URL: https://github.com/nodejs/node/pull/31408 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha c9e386c00fd5b1269426975d4b0f4533f66ce089

crypto: add key type 'dh' The new key type 'dh' corresponds to EVP_PKEY_DH. PR-URL: https://github.com/nodejs/node/pull/31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Tobias Nießen

commit sha 493fc429776a2dc705a2b66e4abc00149f620fc3

crypto: simplify DH groups PR-URL: https://github.com/nodejs/node/pull/31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Tobias Nießen

commit sha c6f8ea8d6578fd1f167bc943272eca5806224d2f

crypto: add DH support to generateKeyPair This allows using the generateKeyPair API for DH instead of the old stateful DH APIs. PR-URL: https://github.com/nodejs/node/pull/31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Tobias Nießen

commit sha b4f8537cdc6f894c5e90bb8bf29a90a2db1438ca

crypto: add crypto.diffieHellman Currently, Node.js has separate (stateful) APIs for DH/ECDH, and no support for ECDH-ES. This commit adds a single stateless function to compute the DH/ECDH/ECDH-ES secret based on two KeyObjects. PR-URL: https://github.com/nodejs/node/pull/31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Tobias Nießen

commit sha 3203febbb2c8f478e9895400b4a39bf947b82d04

test: skip keygen tests on arm systems test-crypto-keygen and test-crypto-dh-stateless are currently flaky on ARM CI systems due to their slow CPUs. PR-URL: https://github.com/nodejs/node/pull/31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Shelley Vohr

commit sha a484f1acf3becb0bab43af26a04908e80e66d813

2020-01-21, Version 13.7.0 (Current) Notable changes: * deps: * upgrade to libuv 1.34.1 (cjihrig) https://github.com/nodejs/node/pull/31332 * upgrade npm to 6.13.6 (Ruy Adorno) https://github.com/nodejs/node/pull/31304 * module * add API for interacting with source maps (bcoe) https://github.com/nodejs/node/pull/31132 * loader getSource, getFormat, transform hooks (Geoffrey Booth) https://github.com/nodejs/node/pull/30986 * logical conditional exports ordering (Guy Bedford) https://github.com/nodejs/node/pull/31008 * unflag conditional exports (Guy Bedford) https://github.com/nodejs/node/pull/31001 * process: * allow monitoring uncaughtException (Gerhard Stoebich) https://github.com/nodejs/node/pull/31257 * Added new collaborators: * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. https://github.com/nodejs/node/pull/31306 PR-URL: https://github.com/nodejs/node/pull/31382

view details

cjihrig

commit sha da66054e5d584bad7e5b3691f50deb1a5a8a4f53

test: improve wasi stat test This commit improved the stat test a bit by verifying that S_ISDIR() works properly. It also adds missing coverage for __wasi_path_remove_directory(). PR-URL: https://github.com/nodejs/node/pull/31413 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 8 days

Pull request review commentcjihrig/uvwasi

src: fix implicit type conversion

 uvwasi_errno_t uvwasi_fd_table_insert(uvwasi_t* uvwasi,     table->size = new_size;   } else {     /* The table is big enough, so find an empty slot for the new data. */-    index = -1;+    int valid_slot = 0;     for (i = 0; i < table->size; ++i) {       if (table->fds[i] == NULL) {+        valid_slot = 1;         index = i;         break;       }     } -    /* index should never be -1. */-    if (index == -1) {+    if (!valid_slot) {

Can you make this valid_slot == 0.

codebytere

comment created time in 8 days

pull request commentcjihrig/uvwasi

fix: clocks header only on windows

Yea, I was thinking about this last night. What is the harm with including this on non-Windows platforms?

codebytere

comment created time in 8 days

created tagcjihrig/gelfie

tagv0.2.0

GELF client

created time in 8 days

release cjihrig/gelfie

v0.2.0

released time in 8 days

push eventcjihrig/gelfie

cjihrig

commit sha 65485cc1b52ba35383e84357276de60f79b9d1b8

v0.2.0

view details

push time in 8 days

push eventcjihrig/gelfie

cjihrig

commit sha 521b0d798c982da6048002ee88a98854f011a0e8

serialization improvements - Ensure that short_message and full_message are strings. - Support custom serializers for these fields.

view details

push time in 8 days

push eventcjihrig/gelfie

cjihrig

commit sha 8641978faa8d609eb667f1de2e0c5830ace5990f

handle multiple calls to close()

view details

push time in 8 days

created tagcjihrig/gelfie

tagv0.1.0

GELF client

created time in 8 days

release cjihrig/gelfie

v0.1.0

released time in 8 days

push eventcjihrig/gelfie

Colin Ihrig

commit sha 2ff363baae45283c7855edeaa724e4dbcf92ea41

Initial commit

view details

push time in 8 days

create barnchcjihrig/gelfie

branch : master

created branch time in 8 days

created repositorycjihrig/gelfie

GELF client

created time in 8 days

Pull request review commentcjihrig/uvwasi

fix: clocks header only on windows

+#ifdef _WIN32+#include "clocks.h"+#endif /* _WIN32 */

Could you merge this with the #ifndef on line 5.

codebytere

comment created time in 8 days

MemberEvent

push eventcjihrig/uvwasi

Shelley Vohr

commit sha 7609d610a48865491ed91ce5272cce970dbd3ec4

src: add missing clocks header include

view details

push time in 9 days

PR merged cjihrig/uvwasi

src: add missing clocks header include

clocks.c was missing the associated header file, so it caused errors in Electron like the following:

Screen Shot 2020-02-14 at 3 04 17 PM

This PR rectifies that by adding the missing header.

cc @cjihrig

+1 -0

0 comment

1 changed file

codebytere

pr closed time in 9 days

push eventcjihrig/uvwasi

Shelley Vohr

commit sha 42a993d264d8e6b7dd74104000cd8cd9421c2579

docs: add build instructions

view details

push time in 9 days

PR merged cjihrig/uvwasi

docs: add build instructions

This PR adds some basic build instructions for those who may not be familiar with CMake.

Happy to move these to another location in the repo if preferred!

cc @cjihrig

+11 -0

0 comment

1 changed file

codebytere

pr closed time in 9 days

pull request commentvuejs/vuex

refactor: remove extra loops in dispatch()

I guess readability is subjective here. To me, personally, the version in this patch is more readable. It's also less code, one less loop over an array, and should consume less memory. It's up to you as the maintainers though.

cjihrig

comment created time in 10 days

Pull request review commentnodejs/llnode

meta: add policy to land PRs without approval

 with the following differences:   - There's no minimum wait time for landing a pull request. Pull requests can     land as soon as they get approved by at least one Collaborator.   - Approval must be from Collaborators who are not authors of the change.+  - If the pull request was open for three days (72 hours) without reviews, and

To counter your counter-argument, if there is a bug under this proposal, it will take 3 days to release a fix 😄. I guess any amount of waiting will be an arbitrary amount. I only recommended going with 7 days because that was the agreed upon answer to this exact same problem in core. At the end of the day, you're the one doing literally all of the work, and I'm not going to block this PR.

mmarchini

comment created time in 11 days

issue commentnodejs/TSC

Timing of TSC member addition / resignation

Does asking me to stay on then reflect poorly on the integrity of the TSC?

I think so. If any collaborator were to merge https://github.com/nodejs/node/pull/31725, would that mean @Fishrock123 is officially off of the TSC at that moment? That seems kind of silly. What if someone else on the TSC also resigned (for legitimate reasons, or just to watch the TSC squirm)?

tniessen

comment created time in 11 days

Pull request review commentnodejs/llnode

meta: add policy to land PRs without approval

 with the following differences:   - There's no minimum wait time for landing a pull request. Pull requests can     land as soon as they get approved by at least one Collaborator.   - Approval must be from Collaborators who are not authors of the change.+  - If the pull request was open for three days (72 hours) without reviews, and

Not to intentionally slow llnode down any further, but what about 7 days to match the one approval clause from https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#code-reviews.

mmarchini

comment created time in 11 days

Pull request review commentnodejs/diagnostics

doc: add minutes for meeting 2020-02-12

+# Node.js Foundation Diagnostics WorkGroup Meeting 2020-02-12++## Links++* **Recording**:  +* **GitHub Issue**: $GITHUB_ISSUE$+* **Minutes Google Doc**: $MINUTES_DOC$++## Present++* Diagnostics team: @nodejs/diagnostics+* David Anderson (@daviande)+* Matheus Marchini (@mmarchini)+* Michael Dawson (@mhdawson)+* Peter Marton (@hekike)+* Ruben Bridgewater (@BridgeAR)++## Agenda++## Announcements+ +*Extracted from **diag-agenda** labelled issues and pull requests from the+**nodejs org** prior to the meeting.++### nodejs/diagnostics++* Future of llnode [#355](https://github.com/nodejs/diagnostics/issues/355)+ * Mattheus: proposing to remove review restrictions because other maintainers +   are less active and this is blocking to make progress on important things+   like Node 12.x release. This one took months and we fell behind the LTS+   schedule. Which prevented people from using llnode on Node 12.x. Because of+   the nature of llnode it needs rabid iteration to keep it sync with V8
   the nature of llnode it needs rapid iteration to keep it sync with V8
mmarchini

comment created time in 11 days

issue commentnodejs/node-chakracore

Current Status?

+1 to archiving this if there is no response from @nodejs/node-chakracore by Monday (Feb 17), as there are also a number of security vulnerabilities reported by GitHub here every week.

jasnell

comment created time in 12 days

pull request commentnodejs/node

test: add WASI test for file resizing

Looks like the ARM 12 bots were not happy with the new test. Will need to debug.

cjihrig

comment created time in 13 days

issue commentwasm3/wasm3

[WASI] Integrate uvwasi

If you move forward with this, feel free to ping me with any questions. FWIW, the majority of the Node.js integration with uvwasi can be found in these files:

  • https://github.com/nodejs/node/blob/5b0308cd823a511098dadf9ddd5a35e3a9dbb424/src/node_wasi.cc
  • https://github.com/nodejs/node/blob/5b0308cd823a511098dadf9ddd5a35e3a9dbb424/src/node_wasi.h
vshymanskyy

comment created time in 13 days

Pull request review commentnodejs/node

doc: expand C++ README with information about exception handling

 If there is a need to catch JavaScript exceptions in C++, V8 provides the of providing the ability to shut down the program in the typical Node.js way (printing the exception + stack trace) if an exception is caught. +A `TryCatch` will catch regular JavaScript exceptions, as well as termination+exceptions such as the ones thrown by `worker.terminate()` calls.+In the latter case, the `try_catch.HasTerminated()` function will return true,
In the latter case, the `try_catch.HasTerminated()` function will return `true`,
addaleax

comment created time in 13 days

Pull request review commentnodejs/node

doc: expand C++ README with information about exception handling

 This should only be performed if it is actually sure that the operation has not failed. A lot of Node.js’s source code does **not** follow this rule, and can be brought to crash through this. +In particular, it is often not safe to assume that an operation does not throw+an exception, even if it seems like it would not do that.+The most common reasons for this are:++* Calls to functions like `object->Get(...)` or `object->Set(...)` may fail on+  most objects, if the `Object.prototype` object has been modified from userland+  code that added getters or setters.+* Calls that call *any* JavaScript code, including JavaScript code that is

Making this suggestion just because "calls that call" sounds a little off IMO.

* Calls that invoke *any* JavaScript code, including JavaScript code that is
addaleax

comment created time in 13 days

pull request commentlibuv/libuv

doc: update gyp link

FWIW, I'd be in favor of dropping gyp completely.

bnoordhuis

comment created time in 13 days

issue commentnodejs/node

Discussion: Criteria for upgrading diagnostic reporting from experimental to stable

Then would an opt-out option to disable the generation of node-report make sense with it?

I might be misunderstanding your comment, but I don't think that's necessary. --experimental-report currently enables the diagnostic report feature, but the reports should only be generated if --report-uncaught-exception, --report-on-signal, --report-on-fatalerror, etc. is used.

cjihrig

comment created time in 13 days

PR opened vuejs/vuex

refactor: remove extra loops in dispatch()

This commit replaces two chained filter()-forEach() sequences in dispatch() with single forEach()s.

+2 -4

0 comment

1 changed file

pr created time in 14 days

create barnchcjihrig/vuex

branch : each

created branch time in 14 days

fork cjihrig/vuex

🗃️ Centralized State Management for Vue.js.

https://vuex.vuejs.org

fork in 14 days

issue commentnodejs/node

Discussion: Criteria for upgrading diagnostic reporting from experimental to stable

I'm working on unflagging this. These are the changes I'm implementing:

  • Make the node_report configure option a no-op. The idea is that report will always be available moving forward.
  • Make the --experimental-report CLI flag a no-op and remove its uses in the code and docs. The experimental warning will also be removed.
  • Make the --report-on-fatalerror CLI flag experimental. It seems like most remaining issues are related to this flag and things like OOM scenarios. I don't think it's worth keeping everything else experimental because of this.

I'll follow up with semver-major changes:

  • Remove the no-op node_report configure option.
  • Remove the no-op --experimental-report CLI flag.

Is any opposed to this plan? It seems like the report feature is mostly stable at this point, and it would be great to get more people using it by unflagging.

cjihrig

comment created time in 14 days

PR merged nodejs/node

doc,src,test: assign missing deprecation code C++ author ready fs

Refs: https://github.com/nodejs/node/pull/28396

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+5 -5

2 comments

4 changed files

cjihrig

pr closed time in 14 days

push eventnodejs/node

cjihrig

commit sha 009a9c475b70d2c35a176ba20514034238024d53

doc,src,test: assign missing deprecation code PR-URL: https://github.com/nodejs/node/pull/31674 Refs: https://github.com/nodejs/node/pull/28396 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 14 days

push eventcjihrig/node

Swagat Konchada

commit sha a733c18e2854eac4afbb3d82e451b0ddac871d15

doc: add note in BUILDING.md about running `make distclean` Fixes: https://github.com/nodejs/node/issues/28675 PR-URL: https://github.com/nodejs/node/pull/31542 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha e2a3a87060af4c48b2551d20dfede33183b1931d

doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: https://github.com/nodejs/node/pull/31656 Refs: https://github.com/nodejs/node/pull/31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha a555be2e45b283a201de21350c0115680a7d4e7c

worker: improve MessagePort performance Use a JS function as the single entry point for emitting `.onmessage()` calls, avoiding the overhead of manually constructing each message event object in C++. confidence improvement accuracy (*) (**) (***) worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 *** 16.34 % ±1.16% ±1.54% ±1.99% worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 *** 24.41 % ±1.50% ±1.99% ±2.58% worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 *** 26.66 % ±1.54% ±2.05% ±2.65% worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 *** 32.72 % ±1.60% ±2.11% ±2.73% worker/messageport.js n=1000000 payload='object' *** 40.28 % ±1.48% ±1.95% ±2.52% worker/messageport.js n=1000000 payload='string' *** 76.95 % ±2.19% ±2.90% ±3.75% Also fix handling exceptions returned from `MessagePort::New`. PR-URL: https://github.com/nodejs/node/pull/31605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha 2db1c8df25db40a909a8ada75ae6da4caa34ed46

doc: update TSC name in "Release Process" PR-URL: https://github.com/nodejs/node/pull/31652 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha aee3e2bc4ca40538c9f470cbf67fed20de9f6dc0

src: various minor improvements to node_url Went hunting for possible performance improvements. Didn't find anything significant but did manage to make a number of style improvements that bring more in line with style guidelines and good pratice. PR-URL: https://github.com/nodejs/node/pull/31651 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 7df429808ca336b6aa868a9ae1ceb6117c68e7c4

doc: clarify Worker exit/message event ordering Motivated by the fact that getting this wrong has led to flaky tests in our test suite. Refs: https://github.com/nodejs/node/pull/31637 PR-URL: https://github.com/nodejs/node/pull/31642 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha d394dd78de600e89ceea02b3582435e50f249aa4

src: fix OOB reads in process.title getter The getter passed a stack-allocated, fixed-size buffer to uv_get_process_title() but neglected to check the return value. When the total length of the command line arguments exceeds the size of the buffer, libuv returns UV_ENOBUFS and doesn't modify the contents of the buffer. The getter then proceeded to return whatever garbage was on the stack at the time of the call, quite possibly reading beyond the end of the buffer. Add a GetProcessTitle() helper that reads the process title into a dynamically allocated buffer that is resized when necessary. Fixes: https://github.com/nodejs/node/issues/31631 PR-URL: https://github.com/nodejs/node/pull/31633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ben Noordhuis

commit sha 3271c40ab102841735aa55f6489fe9df2cd47fcc

src: remove fixed-size GetHumanReadableProcessName Remove the version of GetHumanReadableProcessName() that operates on a fixed-size buffer. The only remaining caller is Assert() which might get called in contexts where dynamically allocating memory isn't possible but as Assert() calls printf(), which also allocates memory when necessary, this commit is unlikely to make matters much worse. PR-URL: https://github.com/nodejs/node/pull/31633 Fixes: https://github.com/nodejs/node/issues/31631 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha f3682102dca1d24959e93de918fbb583f19ee688

src: give Http2Session JS fields their own backing store It looks like it’s virtually impossible at this point to create “fake” backing stores for objects that don’t fully own their memory allocations, like the sub-field `js_fields_` of `Http2Session`. In particular, it turns out that an `ArrayBuffer` cannot always be easily separated from its backing store in that situation through by detaching it. This commit gives the JS-exposed parts of the class its own memory allocation and its own backing store, simplifying the code a bit and fixing flakiness coming from it, at the cost of one additional layer of indirection when accessing the data. Refs: https://github.com/nodejs/node/pull/30782 Fixes: https://github.com/nodejs/node/issues/31107 PR-URL: https://github.com/nodejs/node/pull/31648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Rich Trott

commit sha 8c18e91c8afc0629a097ecb193e41eab058d02bb

process: remove undocumented `now` argument from emitWarning() process.emitWarning() "now" option is undocumented and a Boolean trap. Remove it before people start adopting it. We only need it in one place internally. Replace it with an internal-only emitWarningSync() function. PR-URL: https://github.com/nodejs/node/pull/31643 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 0279c2f28bedae92a7be3e1c67794e66432cf4b7

test: fix flaky test-inspector-connect-main-thread Previously, the test waited for a (any) message from the workers, and then attached another event listener to a specific kind of message. However, it was possible that the second listener was attached after the Worker had already exited, thus never receiving the message it was supposed to receive. (This is the race condition here – usually, the Worker thread would exit *after* the second listener was attached.) Solve this by keeping a single `'message'` event listener attached to the worker instance during its entire lifetime. Fixes: https://github.com/nodejs/node/issues/31226 PR-URL: https://github.com/nodejs/node/pull/31637 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 8a14884babdcfaaf0571c95830b3e7478c18afdb

test: fix test-benchmark-http fe3975783cc4fdba47c2e25442ca891aab31e805 added a setting to a benchmark which needs to be reflected in the test. PR-URL: https://github.com/nodejs/node/pull/31686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha 9111e02360a4bda5c5323aa3f64d36f17f692d3a

worker: reset `Isolate` stack limit after entering `Locker` It turns out that using `v8::Locker` undoes the effects of passing an explicit stack limit as part of the `Isolate`’s resource constraints. Therefore, reset the stack limit manually after entering a Locker. Refs: https://github.com/nodejs/node/pull/26049#issuecomment-580668530 PR-URL: https://github.com/nodejs/node/pull/31593 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 7a63d76a54b03884de25a1d561ab76386ff31f7a

src: remove dead code in InternalMakeCallback Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: https://github.com/nodejs/node/pull/31622 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 7cbec42178ca2919c045f1120e2318d3ceaea658

doc: simplify async_hooks overview Explain the purpose of async_hooks simply in the overview. PR-URL: https://github.com/nodejs/node/pull/31660 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 375c7649ec8a67aaf5524df762f221168716a523

build: add configure option to debug only Node.js part of the binary Building Node.js with `--debug` takes a long time and generates binaries that can be hard to work with due to their size, in particular because debug builds of V8 are large. Sometimes, it’s sufficient to build the Node.js parts with native debugging options enabled. Add an option for that. PR-URL: https://github.com/nodejs/node/pull/31644 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Yuhanun Citgez

commit sha 9c753b3dc2b465496a94d7ccffc3c9438c3ce325

src: modernized unique_ptr construction PR-URL: https://github.com/nodejs/node/pull/31654 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

view details

Robert Nagy

commit sha e559842188f541b884abff2ffad4d2d3e1b841a6

stream: make readable & writable computed This makes readable and writable automatically computed based on the stream state. Effectivly deprecating/discouraging manual management of this. Makes the properties more consistent and easier to reason about. Fixes: https://github.com/nodejs/node/issues/29377 PR-URL: https://github.com/nodejs/node/pull/31197 Refs: https://github.com/nodejs/node/issues/29377 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha d016b9d70897b7702e7862252d768ecdde89bc48

stream: finished callback for closed streams Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). PR-URL: https://github.com/nodejs/node/pull/31509 Refs: https://github.com/nodejs/node/pull/31508 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 93c4c1a273736027439d087b0a52aa33df6a2b13

doc: consolidate introductory text PR-URL: https://github.com/nodejs/node/pull/31667 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 14 days

delete branch cjihrig/node

delete branch : replaceme

delete time in 14 days

pull request commentnodejs/node

doc: update missing pr-urls

Landed in efec6811b6...a2d6f98e1a.

cjihrig

comment created time in 14 days

PR merged nodejs/node

doc: update missing pr-urls author ready deprecations doc
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+3 -3

0 comment

1 changed file

cjihrig

pr closed time in 14 days

push eventnodejs/node

cjihrig

commit sha cd0f5a239e5c0d1f6fd374741173d62d2df64340

doc: update pr-url for DEP0016 EOL Refs: https://github.com/nodejs/node/pull/31167 PR-URL: https://github.com/nodejs/node/pull/31675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

cjihrig

commit sha 17e3f3be763cb440bb315911f3e926044ddb128c

doc: update pr-url for DEP0022 EOL Refs: https://github.com/nodejs/node/pull/31169 PR-URL: https://github.com/nodejs/node/pull/31675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

cjihrig

commit sha a2d6f98e1a4b43bdd57fdfa253e3a13c6dcbe09c

doc: fix typo Refs: https://github.com/nodejs/node/pull/31169 PR-URL: https://github.com/nodejs/node/pull/31675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 14 days

push eventcjihrig/node

Swagat Konchada

commit sha a733c18e2854eac4afbb3d82e451b0ddac871d15

doc: add note in BUILDING.md about running `make distclean` Fixes: https://github.com/nodejs/node/issues/28675 PR-URL: https://github.com/nodejs/node/pull/31542 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha e2a3a87060af4c48b2551d20dfede33183b1931d

doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: https://github.com/nodejs/node/pull/31656 Refs: https://github.com/nodejs/node/pull/31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha a555be2e45b283a201de21350c0115680a7d4e7c

worker: improve MessagePort performance Use a JS function as the single entry point for emitting `.onmessage()` calls, avoiding the overhead of manually constructing each message event object in C++. confidence improvement accuracy (*) (**) (***) worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 *** 16.34 % ±1.16% ±1.54% ±1.99% worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 *** 24.41 % ±1.50% ±1.99% ±2.58% worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 *** 26.66 % ±1.54% ±2.05% ±2.65% worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 *** 32.72 % ±1.60% ±2.11% ±2.73% worker/messageport.js n=1000000 payload='object' *** 40.28 % ±1.48% ±1.95% ±2.52% worker/messageport.js n=1000000 payload='string' *** 76.95 % ±2.19% ±2.90% ±3.75% Also fix handling exceptions returned from `MessagePort::New`. PR-URL: https://github.com/nodejs/node/pull/31605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha 2db1c8df25db40a909a8ada75ae6da4caa34ed46

doc: update TSC name in "Release Process" PR-URL: https://github.com/nodejs/node/pull/31652 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha aee3e2bc4ca40538c9f470cbf67fed20de9f6dc0

src: various minor improvements to node_url Went hunting for possible performance improvements. Didn't find anything significant but did manage to make a number of style improvements that bring more in line with style guidelines and good pratice. PR-URL: https://github.com/nodejs/node/pull/31651 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 7df429808ca336b6aa868a9ae1ceb6117c68e7c4

doc: clarify Worker exit/message event ordering Motivated by the fact that getting this wrong has led to flaky tests in our test suite. Refs: https://github.com/nodejs/node/pull/31637 PR-URL: https://github.com/nodejs/node/pull/31642 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha d394dd78de600e89ceea02b3582435e50f249aa4

src: fix OOB reads in process.title getter The getter passed a stack-allocated, fixed-size buffer to uv_get_process_title() but neglected to check the return value. When the total length of the command line arguments exceeds the size of the buffer, libuv returns UV_ENOBUFS and doesn't modify the contents of the buffer. The getter then proceeded to return whatever garbage was on the stack at the time of the call, quite possibly reading beyond the end of the buffer. Add a GetProcessTitle() helper that reads the process title into a dynamically allocated buffer that is resized when necessary. Fixes: https://github.com/nodejs/node/issues/31631 PR-URL: https://github.com/nodejs/node/pull/31633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ben Noordhuis

commit sha 3271c40ab102841735aa55f6489fe9df2cd47fcc

src: remove fixed-size GetHumanReadableProcessName Remove the version of GetHumanReadableProcessName() that operates on a fixed-size buffer. The only remaining caller is Assert() which might get called in contexts where dynamically allocating memory isn't possible but as Assert() calls printf(), which also allocates memory when necessary, this commit is unlikely to make matters much worse. PR-URL: https://github.com/nodejs/node/pull/31633 Fixes: https://github.com/nodejs/node/issues/31631 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha f3682102dca1d24959e93de918fbb583f19ee688

src: give Http2Session JS fields their own backing store It looks like it’s virtually impossible at this point to create “fake” backing stores for objects that don’t fully own their memory allocations, like the sub-field `js_fields_` of `Http2Session`. In particular, it turns out that an `ArrayBuffer` cannot always be easily separated from its backing store in that situation through by detaching it. This commit gives the JS-exposed parts of the class its own memory allocation and its own backing store, simplifying the code a bit and fixing flakiness coming from it, at the cost of one additional layer of indirection when accessing the data. Refs: https://github.com/nodejs/node/pull/30782 Fixes: https://github.com/nodejs/node/issues/31107 PR-URL: https://github.com/nodejs/node/pull/31648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Rich Trott

commit sha 8c18e91c8afc0629a097ecb193e41eab058d02bb

process: remove undocumented `now` argument from emitWarning() process.emitWarning() "now" option is undocumented and a Boolean trap. Remove it before people start adopting it. We only need it in one place internally. Replace it with an internal-only emitWarningSync() function. PR-URL: https://github.com/nodejs/node/pull/31643 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 0279c2f28bedae92a7be3e1c67794e66432cf4b7

test: fix flaky test-inspector-connect-main-thread Previously, the test waited for a (any) message from the workers, and then attached another event listener to a specific kind of message. However, it was possible that the second listener was attached after the Worker had already exited, thus never receiving the message it was supposed to receive. (This is the race condition here – usually, the Worker thread would exit *after* the second listener was attached.) Solve this by keeping a single `'message'` event listener attached to the worker instance during its entire lifetime. Fixes: https://github.com/nodejs/node/issues/31226 PR-URL: https://github.com/nodejs/node/pull/31637 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 8a14884babdcfaaf0571c95830b3e7478c18afdb

test: fix test-benchmark-http fe3975783cc4fdba47c2e25442ca891aab31e805 added a setting to a benchmark which needs to be reflected in the test. PR-URL: https://github.com/nodejs/node/pull/31686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha 9111e02360a4bda5c5323aa3f64d36f17f692d3a

worker: reset `Isolate` stack limit after entering `Locker` It turns out that using `v8::Locker` undoes the effects of passing an explicit stack limit as part of the `Isolate`’s resource constraints. Therefore, reset the stack limit manually after entering a Locker. Refs: https://github.com/nodejs/node/pull/26049#issuecomment-580668530 PR-URL: https://github.com/nodejs/node/pull/31593 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 7a63d76a54b03884de25a1d561ab76386ff31f7a

src: remove dead code in InternalMakeCallback Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: https://github.com/nodejs/node/pull/31622 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 7cbec42178ca2919c045f1120e2318d3ceaea658

doc: simplify async_hooks overview Explain the purpose of async_hooks simply in the overview. PR-URL: https://github.com/nodejs/node/pull/31660 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 375c7649ec8a67aaf5524df762f221168716a523

build: add configure option to debug only Node.js part of the binary Building Node.js with `--debug` takes a long time and generates binaries that can be hard to work with due to their size, in particular because debug builds of V8 are large. Sometimes, it’s sufficient to build the Node.js parts with native debugging options enabled. Add an option for that. PR-URL: https://github.com/nodejs/node/pull/31644 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Yuhanun Citgez

commit sha 9c753b3dc2b465496a94d7ccffc3c9438c3ce325

src: modernized unique_ptr construction PR-URL: https://github.com/nodejs/node/pull/31654 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

view details

Robert Nagy

commit sha e559842188f541b884abff2ffad4d2d3e1b841a6

stream: make readable & writable computed This makes readable and writable automatically computed based on the stream state. Effectivly deprecating/discouraging manual management of this. Makes the properties more consistent and easier to reason about. Fixes: https://github.com/nodejs/node/issues/29377 PR-URL: https://github.com/nodejs/node/pull/31197 Refs: https://github.com/nodejs/node/issues/29377 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha d016b9d70897b7702e7862252d768ecdde89bc48

stream: finished callback for closed streams Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). PR-URL: https://github.com/nodejs/node/pull/31509 Refs: https://github.com/nodejs/node/pull/31508 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 93c4c1a273736027439d087b0a52aa33df6a2b13

doc: consolidate introductory text PR-URL: https://github.com/nodejs/node/pull/31667 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 14 days

pull request commentnodejs/node

readline: remove intermediate variable

It's not really feasible to replace all uses of true and false throughout the codebase, and there is nothing special about validateUint32() (in fact it's an internal API), so I've gone ahead and landed this.

cjihrig

comment created time in 14 days

delete branch cjihrig/node

delete branch : positive

delete time in 14 days

PR merged nodejs/node

readline: remove intermediate variable author ready readline

This commit removes an extra intermediate variable. This makes the call consistent with other uses of validateUint32() in the codebase.

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+1 -2

3 comments

1 changed file

cjihrig

pr closed time in 14 days

push eventnodejs/node

cjihrig

commit sha efec6811b667b6cf362d648bc599b667eebffce0

readline: remove intermediate variable This commit removes an extrea intermediate variable. This makes the call consistent with other uses of validateUint32() in the codebase. PR-URL: https://github.com/nodejs/node/pull/31676 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 14 days

push eventcjihrig/node

Swagat Konchada

commit sha a733c18e2854eac4afbb3d82e451b0ddac871d15

doc: add note in BUILDING.md about running `make distclean` Fixes: https://github.com/nodejs/node/issues/28675 PR-URL: https://github.com/nodejs/node/pull/31542 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha e2a3a87060af4c48b2551d20dfede33183b1931d

doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: https://github.com/nodejs/node/pull/31656 Refs: https://github.com/nodejs/node/pull/31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha a555be2e45b283a201de21350c0115680a7d4e7c

worker: improve MessagePort performance Use a JS function as the single entry point for emitting `.onmessage()` calls, avoiding the overhead of manually constructing each message event object in C++. confidence improvement accuracy (*) (**) (***) worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 *** 16.34 % ±1.16% ±1.54% ±1.99% worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 *** 24.41 % ±1.50% ±1.99% ±2.58% worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 *** 26.66 % ±1.54% ±2.05% ±2.65% worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 *** 32.72 % ±1.60% ±2.11% ±2.73% worker/messageport.js n=1000000 payload='object' *** 40.28 % ±1.48% ±1.95% ±2.52% worker/messageport.js n=1000000 payload='string' *** 76.95 % ±2.19% ±2.90% ±3.75% Also fix handling exceptions returned from `MessagePort::New`. PR-URL: https://github.com/nodejs/node/pull/31605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha 2db1c8df25db40a909a8ada75ae6da4caa34ed46

doc: update TSC name in "Release Process" PR-URL: https://github.com/nodejs/node/pull/31652 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha aee3e2bc4ca40538c9f470cbf67fed20de9f6dc0

src: various minor improvements to node_url Went hunting for possible performance improvements. Didn't find anything significant but did manage to make a number of style improvements that bring more in line with style guidelines and good pratice. PR-URL: https://github.com/nodejs/node/pull/31651 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 7df429808ca336b6aa868a9ae1ceb6117c68e7c4

doc: clarify Worker exit/message event ordering Motivated by the fact that getting this wrong has led to flaky tests in our test suite. Refs: https://github.com/nodejs/node/pull/31637 PR-URL: https://github.com/nodejs/node/pull/31642 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha d394dd78de600e89ceea02b3582435e50f249aa4

src: fix OOB reads in process.title getter The getter passed a stack-allocated, fixed-size buffer to uv_get_process_title() but neglected to check the return value. When the total length of the command line arguments exceeds the size of the buffer, libuv returns UV_ENOBUFS and doesn't modify the contents of the buffer. The getter then proceeded to return whatever garbage was on the stack at the time of the call, quite possibly reading beyond the end of the buffer. Add a GetProcessTitle() helper that reads the process title into a dynamically allocated buffer that is resized when necessary. Fixes: https://github.com/nodejs/node/issues/31631 PR-URL: https://github.com/nodejs/node/pull/31633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ben Noordhuis

commit sha 3271c40ab102841735aa55f6489fe9df2cd47fcc

src: remove fixed-size GetHumanReadableProcessName Remove the version of GetHumanReadableProcessName() that operates on a fixed-size buffer. The only remaining caller is Assert() which might get called in contexts where dynamically allocating memory isn't possible but as Assert() calls printf(), which also allocates memory when necessary, this commit is unlikely to make matters much worse. PR-URL: https://github.com/nodejs/node/pull/31633 Fixes: https://github.com/nodejs/node/issues/31631 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha f3682102dca1d24959e93de918fbb583f19ee688

src: give Http2Session JS fields their own backing store It looks like it’s virtually impossible at this point to create “fake” backing stores for objects that don’t fully own their memory allocations, like the sub-field `js_fields_` of `Http2Session`. In particular, it turns out that an `ArrayBuffer` cannot always be easily separated from its backing store in that situation through by detaching it. This commit gives the JS-exposed parts of the class its own memory allocation and its own backing store, simplifying the code a bit and fixing flakiness coming from it, at the cost of one additional layer of indirection when accessing the data. Refs: https://github.com/nodejs/node/pull/30782 Fixes: https://github.com/nodejs/node/issues/31107 PR-URL: https://github.com/nodejs/node/pull/31648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Rich Trott

commit sha 8c18e91c8afc0629a097ecb193e41eab058d02bb

process: remove undocumented `now` argument from emitWarning() process.emitWarning() "now" option is undocumented and a Boolean trap. Remove it before people start adopting it. We only need it in one place internally. Replace it with an internal-only emitWarningSync() function. PR-URL: https://github.com/nodejs/node/pull/31643 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 0279c2f28bedae92a7be3e1c67794e66432cf4b7

test: fix flaky test-inspector-connect-main-thread Previously, the test waited for a (any) message from the workers, and then attached another event listener to a specific kind of message. However, it was possible that the second listener was attached after the Worker had already exited, thus never receiving the message it was supposed to receive. (This is the race condition here – usually, the Worker thread would exit *after* the second listener was attached.) Solve this by keeping a single `'message'` event listener attached to the worker instance during its entire lifetime. Fixes: https://github.com/nodejs/node/issues/31226 PR-URL: https://github.com/nodejs/node/pull/31637 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 8a14884babdcfaaf0571c95830b3e7478c18afdb

test: fix test-benchmark-http fe3975783cc4fdba47c2e25442ca891aab31e805 added a setting to a benchmark which needs to be reflected in the test. PR-URL: https://github.com/nodejs/node/pull/31686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha 9111e02360a4bda5c5323aa3f64d36f17f692d3a

worker: reset `Isolate` stack limit after entering `Locker` It turns out that using `v8::Locker` undoes the effects of passing an explicit stack limit as part of the `Isolate`’s resource constraints. Therefore, reset the stack limit manually after entering a Locker. Refs: https://github.com/nodejs/node/pull/26049#issuecomment-580668530 PR-URL: https://github.com/nodejs/node/pull/31593 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 7a63d76a54b03884de25a1d561ab76386ff31f7a

src: remove dead code in InternalMakeCallback Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: https://github.com/nodejs/node/pull/31622 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 7cbec42178ca2919c045f1120e2318d3ceaea658

doc: simplify async_hooks overview Explain the purpose of async_hooks simply in the overview. PR-URL: https://github.com/nodejs/node/pull/31660 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 375c7649ec8a67aaf5524df762f221168716a523

build: add configure option to debug only Node.js part of the binary Building Node.js with `--debug` takes a long time and generates binaries that can be hard to work with due to their size, in particular because debug builds of V8 are large. Sometimes, it’s sufficient to build the Node.js parts with native debugging options enabled. Add an option for that. PR-URL: https://github.com/nodejs/node/pull/31644 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Yuhanun Citgez

commit sha 9c753b3dc2b465496a94d7ccffc3c9438c3ce325

src: modernized unique_ptr construction PR-URL: https://github.com/nodejs/node/pull/31654 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

view details

Robert Nagy

commit sha e559842188f541b884abff2ffad4d2d3e1b841a6

stream: make readable & writable computed This makes readable and writable automatically computed based on the stream state. Effectivly deprecating/discouraging manual management of this. Makes the properties more consistent and easier to reason about. Fixes: https://github.com/nodejs/node/issues/29377 PR-URL: https://github.com/nodejs/node/pull/31197 Refs: https://github.com/nodejs/node/issues/29377 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha d016b9d70897b7702e7862252d768ecdde89bc48

stream: finished callback for closed streams Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). PR-URL: https://github.com/nodejs/node/pull/31509 Refs: https://github.com/nodejs/node/pull/31508 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 93c4c1a273736027439d087b0a52aa33df6a2b13

doc: consolidate introductory text PR-URL: https://github.com/nodejs/node/pull/31667 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 14 days

PR opened nodejs/node

readline: remove intermediate variable

This commit removes an extra intermediate variable. This makes the call consistent with other uses of validateUint32() in the codebase.

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+1 -2

0 comment

1 changed file

pr created time in 16 days

create barnchcjihrig/node

branch : positive

created branch time in 16 days

PR opened nodejs/node

doc: update missing pr-urls
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+3 -3

0 comment

1 changed file

pr created time in 16 days

create barnchcjihrig/node

branch : replaceme

created branch time in 16 days

PR opened nodejs/node

doc,src,test: assign missing deprecation code

Refs: https://github.com/nodejs/node/pull/28396

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+5 -5

0 comment

4 changed files

pr created time in 16 days

create barnchcjihrig/node

branch : doc

created branch time in 16 days

pull request commentcjihrig/uvwasi

add serdes API

@tniessen just checking in - is this just waiting on Add expected serialized data to the test case? No rush, I just wanted to make sure you weren't blocked or anything.

tniessen

comment created time in 16 days

push eventcjihrig/node

ConorDavenport

commit sha 99c8c6d80ff97ac7d53e01722142ac37756aabf1

src: remove duplicate field env in CryptoJob class Removed field env from cryptojob class, replaced with function env() inherited from ThreadPoolWork PR-URL: https://github.com/nodejs/node/pull/31554 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Sam Roberts

commit sha dbaa4ca166a5da08f933ec99eee5f41b740bd13c

test: simplify test-https-simple.js It had an unused `Agent` option (no such option exists), and some code that common.must(Not)Call makes redundant. PR-URL: https://github.com/nodejs/node/pull/31584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha f7a1ef6fb51f814223e3c26fffb9d39b08f91b1b

benchmark: clean up config resolution in multiple benchmarks This removes 'to Number' casting in multiple benchmarks (which is handled by the benchmark runner) and cleans up some var usage in changed benchmarks. PR-URL: https://github.com/nodejs/node/pull/31581 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 875a4d1a58d6dec80518c9d2a05ae6107c70b066

worker: add ability to take heap snapshot from parent thread PR-URL: https://github.com/nodejs/node/pull/31569 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Guy Bedford

commit sha 0f96dc266fd0cd8c1baa82ce7eb951c11b29a331

esm: import.meta.resolve with nodejs: builtins PR-URL: https://github.com/nodejs/node/pull/31032 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

ConorDavenport

commit sha d4660aba6324096198bc17772ba16fce6259967d

src: change Fill() to use ParseArrayIndex() Changed Fill() to use ParseArrayIndex() when getting start and end of buffers instead of Uint32Value, supporting buffers of greater than 2**32 Fixes: https://github.com/nodejs/node/issues/31514 Co-Authored-By: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/31591 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha d435dc47f3d303ff1669fa711a0af287a9df973a

test: unset NODE_OPTIONS for cctest The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: https://github.com/nodejs/node/issues/31585 PR-URL: https://github.com/nodejs/node/pull/31594 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

bcoe

commit sha 3f70d7720333dd0996dfd6ca21beb4a24d561e1b

fs: set path when mkdir recursive called on file PR-URL: https://github.com/nodejs/node/pull/31607 Fixes: https://github.com/nodejs/node/issues/28015 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Rusty Conover

commit sha ee9e689df2dd219084820d1adb7a97d104726794

net: track state of setNoDelay() and prevent unnecessary system calls The state of .setNoDelay() is now tracked and code will prevent repeated system calls to setsockopt() when the value has already been set to the desired value for the socket. Change and expand the appropriate test. PR-URL: https://github.com/nodejs/node/pull/31543 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 60de60a0ce21378c80353489759dc70f05156cc7

src: remove unused `Worker::child_port_` member This fixes a compiler warning introduced in 9225939528590f652e6. PR-URL: https://github.com/nodejs/node/pull/31599 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Kirill Fomichev

commit sha 018c3e8949e925efc8077801d44c2b2feb974750

perf_hooks: add property flags to GCPerformanceEntry PR-URL: https://github.com/nodejs/node/pull/29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

view details

James M Snell

commit sha 2d8febceef35bdd52624028bdee2e0d58830ae7f

fs: deprecate closing FileHandle on garbage collection Closing the FileHandle on garbage collection is a bad practice. Runtime deprecate and indicate that an error will be thrown in the future. PR-URL: https://github.com/nodejs/node/pull/28396 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha fb6df3bfac8ca38a7012eabf0563d7a799ce1acc

fs: validate the input data to be of expected types The input was not validated so far and that caused unwanted side effects. E.g., `undefined` became the string `'undefined'`. It was expected to fail or to end up as empty string. Now all input is validated to be either some type of array buffer view or a string. That way it's always clear what the user intents. PR-URL: https://github.com/nodejs/node/pull/31030 Fixes: https://github.com/nodejs/node/issues/31025 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Juan José Arboleda

commit sha afe353061b3c0543ebaa40668f27c12384e6c5d6

doc: fs.write is not longer coercing strings PR-URL: https://github.com/nodejs/node/pull/31030 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Ruben Bridgewater

commit sha f295ba5d2ce13c2a53f405d5915ad920431331be

test: refactor test-readline-interface.js This reduces the code lines required to run the tests by abstracting the constructor call. It also moves tests out of a for loop that where miss placed. PR-URL: https://github.com/nodejs/node/pull/31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 1fb4bd1fc4b970c5154159ad6734bc722052af3b

test: abstract common assertions in readline-interface test PR-URL: https://github.com/nodejs/node/pull/31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 6a6279ef2a38c17a761cc15366e615c620328587

doc: add AsyncResource + Worker pool example Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: https://github.com/nodejs/node/pull/31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Robert Nagy

commit sha 234de6f1fd90ece1edc1a12d989ab0f15a1f19b8

stream: fix finished w/ 'close' before 'finish' Emitting 'close' before 'finish' on a Writable should result in a premature close error. PR-URL: https://github.com/nodejs/node/pull/31534 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha c1da4e4aa4583c14f87c8d230ce7580f3b157ff0

src: fix inspecting `MessagePort` from `init` async hook During the `init()` async hook, the C++ object is not finished creating yet (i.e. it is an `AsyncWrap`, but not yet a `HandleWrap` or `MessagePort`). Accessing the `handle_` field is not valid in that case. However, the custom inspect function for `MessagePort`s calls `HasRef()` on the object, which would crash when the object is not fully constructed. Fix that by guarding the access of the libuv handle on that condition. PR-URL: https://github.com/nodejs/node/pull/31600 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Conor ONeill

commit sha 7e911d8b03a838e5ac6bb06c5b313533e89673ef

doc: add example to fs.promises.readdir PR-URL: https://github.com/nodejs/node/pull/31552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 16 days

delete branch cjihrig/WASI

delete branch : patch-2

delete time in 16 days

Pull request review commentlibuv/libuv

test: skip some spawn test cases on IBMi

 static int maybe_run_test(int argc, char **argv) {     notify_parent_process();     ASSERT(sizeof(fd) == read(0, &fd, sizeof(fd)));     ASSERT(fd > 2);+# ifndef __PASE__  /* On IBMi PASE, write() returns 1 */

Is there any reason not to also assert on IBMi?

dmabupt

comment created time in 17 days

more