profile
viewpoint
Colin Ihrig cjihrig Pittsburgh, PA node.js tsc, libuv collaborator, hapi core team member. also does things with wasm/wasi and grpc

cjihrig/credit-card 87

Credit card validation

cjihrig/grpc-server-js 52

Pure JavaScript gRPC Server

autopilotpattern/postgres 11

Implementation of the Autopilot Pattern for Postgres

cjihrig/bcrypt.wasm 10

bcrypt in WebAssembly

cjihrig/grpc-benchmarking 10

Benchmarking, but for gRPC

cjihrig/artificial 9

Inject fake HTTP request/response into an Express server

cjihrig/belly-button 8

The best source for lint

cjihrig/ghostbuster 7

A Node.js wrapper for PhantomJS

cjihrig/farmhash.wasm 3

WebAssembly implementation of Google FarmHash

cjihrig/graylogi 3

Graylog logger for hapi

push eventcjihrig/grpc-server-js

cjihrig

commit sha 0d33138c7a5cb2a285ccfe1ffa2349ad3d139690

add UDS test cases

view details

push time in an hour

push eventcjihrig/grpc-server-js

cjihrig

commit sha f89478bc91ebbbf61e6ba3b603a34458e19c4ed1

add UDS test cases

view details

push time in an hour

push eventcjihrig/grpc-server-js

cjihrig

commit sha b7132d389538a038cb31f1ad90ce0056aa5bc6c6

add UDS test cases

view details

push time in an hour

push eventcjihrig/grpc-server-js

cjihrig

commit sha d1e9ddae24fdb736080bcdcc68beea69217ecca8

add UDS test cases

view details

push time in an hour

push eventcjihrig/grpc-server-js

cjihrig

commit sha d95d84c984a8ef36101d8079d1b886fbf3174d4b

add UDS test cases

view details

push time in 2 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha 4fd39333462ae7aeea730cd83dde8a8859b339ab

add windows to CI

view details

push time in 4 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha c7df72ac4bd528956c7dccd5939ba5e684765391

add windows to CI

view details

push time in 4 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha 7d369c367235f62818fb6c79f6f4f0c539803c88

drop travis, add github actions badge

view details

push time in 5 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha 5c7eb318dd8302076912996fc30f05cedafb7cd2

make resolveToListenOptions() test more debuggable Use unique unix: URLs so that failed assertions are more easy to debug.

view details

push time in 5 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha 940c5a7c348da702521391de5bb11390936c8aa9

add github actions to CI

view details

push time in 5 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha 3ce9ed576a61af2a96fc998a98f78192e81df408

add github actions to CI

view details

push time in 5 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha e859773f52dde1b9c00921cf86cc07a634f97e04

add github actions to CI

view details

push time in 5 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha fa7662c23bc4becda60a5e8c2aa5ab94204cbb83

add github actions to CI

view details

push time in 5 hours

push eventcjihrig/grpc-server-js

cjihrig

commit sha 0584a42c9a33f7f4567df8182bc97f801f0622a4

fix types file - Adjust ServiceDefinition type to match other grpc modules. - Fix syntax error.

view details

cjihrig

commit sha 704c4c53d36dac9d420dcf8403def202116d56f7

add dev-client.js to .gitignore

view details

push time in 5 hours

issue commentnodejs/node-addon-api

napi_get_own_property_names

Do the key_mode and key_filter inputs to napi_get_all_property_names() do what you need?

dherman

comment created time in 7 hours

issue commentnodejs/build

Platform requirements for Node.js 14

The discussion was focused on 14.x, but the issue of unusable binaries goes back to earlier release lines. I think it would be fine to stop producing them for the older release lines as well, but as a project, is that a change we want to make in the middle of a release line?

richardlau

comment created time in 16 hours

issue commentnodejs/build

Platform requirements for Node.js 14

We never did discuss smartos, 19.4.0 is available now and we're still chugging along on 18.

I was able to get feedback from some SmartOS people at Joyent. Upgrading to 19.4.0 in the CI would be good. However, it might make sense to stop making official releases for SmartOS. The reason is that the builds are largely unusable without bundling all of the libraries used to build the binary.

It would be great if we could keep SmartOS in the CI to prevent regressions, and instead of creating a release binary, just link from https://nodejs.org/en/download/ to https://metrics.nodejs.org/en/download/package-manager/#smartos-and-illumos for SmartOS.

richardlau

comment created time in 17 hours

Pull request review commentnodejs/node

crypto: reject non-int32 values in DiffieHellman()

 function DiffieHellman(sizeOrKey, keyEncoding, generator, genEncoding) {     );   } +  // Sizes < 0 don't make sense but they _are_ accepted (and subsequently+  // rejected with ERR_OSSL_BN_BITS_TOO_SMALL) by OpenSSL. The glue code+  // in node_crypto.cc accepts values that are IsInt32() for that reason+  // and that's why we do that here too.+  if (typeof sizeOrKey === 'number')+    validateInt32(sizeOrKey, 'sizeOrKey');

You can add 0 as a third parameter here if you want to enforce the minimum in JS.

bnoordhuis

comment created time in 18 hours

issue commentnodejs/admin

new github team: platform-ibmi

+1

sam-github

comment created time in a day

pull request commentnodejs/node

lib: change increase size of array to binary increment

If this is an issue of strength reduction, I'd expect V8 to be able to handle that. If it's about code readability, I agree with @addaleax

yashLadha

comment created time in a day

issue commentnodejs/node

IBM i PASE access to os.networkInterfaces() fails in v12.16.1 (works in v10.19.0)

also @dmabupt who seems to be the lead IBM i maintainer for Node.

AndreaRibuoli

comment created time in a day

PR closed nodejs/node

roufique.md buffer doc

rtat.net

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -0

1 comment

1 changed file

rtatnet

pr closed time in 2 days

pull request commentnodejs/node

2020-04-21, Version 14.0.0 (Current)

@BethGriggs thank you for including the umask() doc deprecation. It looks like it's still listed as DEP0XXX if I'm looking at the right commit on the v14.x-proposal branch.

BethGriggs

comment created time in 2 days

pull request commentlibuv/libuv

build,cmake: fix compilation on old MinGW

In normal cases, how many approvals do I need to get to merge? Can you just give me a rough idea?

Just one from another maintainer, although some are more qualified to sign off on certain parts of the codebase. For example, it's nice, but not necessary, to get a sign off from the @ libuv/windows team on Windows changes.

erw7

comment created time in 4 days

pull request commentgeek/traci

update dependency versions

I'd also recommend dropping hoek. It's only used for assert() and reach(). You can use the built in assert module for assertions, and the reach module, which is hoek.reach() extracted to drop all of the other hoek baggage.

cjihrig

comment created time in 5 days

PR opened geek/traci

update dependency versions

Update to the latest versions of all dependencies. This is primarily to address a security vulnerability in hoek.

Refs: https://npmjs.com/advisories/1468

(Please publish a new version)

+4 -4

0 comment

1 changed file

pr created time in 5 days

create barnchcjihrig/traci

branch : deps

created branch time in 5 days

fork cjihrig/traci

hapi open tracing plugin

fork in 5 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

+'use strict';++const {+  Error,+  SafeSet,+} = primordials;++const {+  codes: {+    ERR_UNAVAILABLE_DURING_EXIT,+  },+} = require('internal/errors');+const AssertionError = require('internal/assert/assertion_error');+const {+  validateBoolean,+  validateObject,+  validateUint32,+} = require('internal/validators');++const noop = () => {};++class CallTracker {++  #callChecks = new SafeSet()++  constructor(options = { onExit: false }) {+    validateObject(options, 'options');+    const { onExit } = options;+    validateBoolean(onExit, 'options.onExit');+    if (onExit) {+      process.on('exit', () => this.verify());

That kind of goes back to having a one line function for dealing with exit handlers that this constructor option was meant to avoid. It seems like it would be simpler to go back to having the "add exit handler" function which can return the added handler. Then, if someone wants to remove it, they can use the standard APIs for dealing with event emitters.

ConorDavenport

comment created time in 7 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

+'use strict';++const {+  Error,+  SafeSet,+} = primordials;++const {+  codes: {+    ERR_UNAVAILABLE_DURING_EXIT,+  },+} = require('internal/errors');+const AssertionError = require('internal/assert/assertion_error');+const {+  validateBoolean,+  validateObject,+  validateUint32,+} = require('internal/validators');++const noop = () => {};++class CallTracker {++  #callChecks = new SafeSet()++  constructor(options = { onExit: false }) {+    validateObject(options, 'options');+    const { onExit } = options;+    validateBoolean(onExit, 'options.onExit');+    if (onExit) {+      process.on('exit', () => this.verify());

Call removeListener().

ConorDavenport

comment created time in 7 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

+'use strict';++const {+  Error,+  SafeSet,+} = primordials;++const {+  codes: {+    ERR_UNAVAILABLE_DURING_EXIT,+  },+} = require('internal/errors');+const AssertionError = require('internal/assert/assertion_error');+const {+  validateBoolean,+  validateObject,+  validateUint32,+} = require('internal/validators');++const noop = () => {};++class CallTracker {++  #callChecks = new SafeSet()++  constructor(options = { onExit: false }) {+    validateObject(options, 'options');+    const { onExit } = options;+    validateBoolean(onExit, 'options.onExit');+    if (onExit) {+      process.on('exit', () => this.verify());

By attaching this in the constructor, there isn't a really straightforward way to remove the listener if you change your mind.

ConorDavenport

comment created time in 7 days

delete branch cjihrig/node

delete branch : nullish

delete time in 7 days

PR closed nodejs/node

wasi: replace || with ?? dont-land-on-v10.x dont-land-on-v12.x dont-land-on-v13.x wasi

The codebase is starting to run low on vars to change to let/const.

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+1 -1

5 comments

1 changed file

cjihrig

pr closed time in 7 days

pull request commentnodejs/node

wasi: replace || with ??

I'm going to close this out for now since it can't land yet.

cjihrig

comment created time in 7 days

pull request commentnodejs/node

wasi: replace || with ??

@devsnek I'm guessing a proper fix is waiting for a release of acorn with https://github.com/acornjs/acorn/pull/890?

cjihrig

comment created time in 7 days

Pull request review commentnodejs/node

src: sync access for report and openssl options

 class PerIsolateOptions : public Options {  class PerProcessOptions : public Options {  public:+  // Options shouldn't be here unless they affect the entire process scope, and+  // that should avoided when possible.+  //+  // When an option is used during process initialization, it does not need+  // protection, but any use after that will likely require synchronization+  // using the node::per_process::cli_options_mutex, typically:+  //+  //     Mutex::ScopedLock lock(node::per_process::cli_options_mutex);

Sorry, at first glance with the extra indentation it looked like code that had been commented out.

sam-github

comment created time in 7 days

pull request commentnodejs/node

wasi: replace || with ??

Looks like the CI isn't quite ready for the new syntax yet.

cjihrig

comment created time in 7 days

PR opened nodejs/node

wasi: replace || with ??

The codebase is starting to run low on vars to change to let/const.

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+1 -1

0 comment

1 changed file

pr created time in 7 days

create barnchcjihrig/node

branch : nullish

created branch time in 7 days

Pull request review commentnodejs/node

src: sync access for report and openssl options

 class PerIsolateOptions : public Options {  class PerProcessOptions : public Options {  public:+  // Options shouldn't be here unless they affect the entire process scope, and+  // that should avoided when possible.+  //+  // When an option is used during process initialization, it does not need+  // protection, but any use after that will likely require synchronization+  // using the node::per_process::cli_options_mutex, typically:+  //+  //     Mutex::ScopedLock lock(node::per_process::cli_options_mutex);

Should this be removed?

sam-github

comment created time in 7 days

pull request commentnodejs/node

util: add `maxStringLength` option to `inspect` function

I'm pretty sure the semver-major cutoff has passed, but at least this can easily be semver-minor with the right default value 😄

rosaxny

comment created time in 7 days

pull request commentnodejs/node

util: add `maxStringLength` option to `inspect` function

If the objector is unresponsive, another Collaborator may dismiss the objection.

From the collaborator guide... I don't think we strictly need to involve the TSC for that.

rosaxny

comment created time in 7 days

pull request commentnodejs/node

cli, report: move --report-on-fatalerror to stable

Asking again. https://github.com/nodejs/node/pull/32535 has landed. Is this unblocked?

cjihrig

comment created time in 7 days

delete branch cjihrig/node

delete branch : eslint

delete time in 7 days

pull request commentnodejs/node

deprecate process.umask() with no arguments

The first commit is a docs only deprecation. I see no reason why that at least couldn't go out in v14 (other than being past the semver major cutoff). All that would need to change is for DEP0XXX to be replaced with the deprecation number (I made the replacement in the second commit here).

cjihrig

comment created time in 7 days

issue commentnodejs/node

Nominating @juanarbol as a collaborator

+1

addaleax

comment created time in 7 days

Pull request review commentnodejs/TSC

doc: Add minutes for 1 April 2020

+# Node.js Technical Steering Committee (TSC) Meeting 2020-04-01
+
+## Links
+
+* **Recording**:  
+* **GitHub Issue**: https://github.com/nodejs/TSC/issues/842
+
+
+## Present
+
+
+* Anna Henningsen @addaleax (TSC)
+* Сковорода Никита Андреевич @ChALkeR (TSC)
+* Franziska Hinkelmann @fhinkel (TSC)
+* Gabriel Schulhof @gabrielschulhof (TSC)
+* Gireesh Punathil @gireeshpunathil (TSC)
+* James Snell @jasnell (TSC)
+* Joyee Cheung @joyeecheung (TSC)
+* Matheus Marchini @mmarchini (TSC)
+* Matteo Collina @mcollina (TSC)
+* Michael Dawso* Ruben Bridgewater @BridgeAR (TSC)

This line is off. And Ruben is included below as well.

mhdawson

comment created time in 8 days

pull request commentnodejs/node

tools: update ESLint to 7.0.0-alpha.3

The only remaining CI failure is:

ssh: Could not resolve hostname github.com: Name or service not known

cjihrig

comment created time in 9 days

issue commentnodejs/TSC

Archival of the node-chakracore repo

I'd personally be fine with unarchiving the repo if people plan to actively work on it. A revived effort could also live outside of the nodejs org.

cjihrig

comment created time in 9 days

pull request commentnodejs/node

deprecate process.umask() with no arguments

@BethGriggs given that this was fast-tracked through the deprecation process, are you OK with adding it to the v14 release?

cjihrig

comment created time in 9 days

delete branch cjihrig/node

delete branch : umask-doc-depr

delete time in 9 days

pull request commentnodejs/node

deprecate process.umask() with no arguments

Landed in 25a1f04cdc...60c4c2b6c5. Thanks for the reviews.

cjihrig

comment created time in 9 days

PR merged nodejs/node

deprecate process.umask() with no arguments author ready deprecations doc process semver-major

This commit introduces a documentation deprecation for calling process.umask() with no arguments.

Fixes: https://github.com/nodejs/node/issues/32321

(I have a runtime deprecation PR ready to go as well, in case we want to skip straight to that step, as this is a potential security issue.)

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+53 -0

5 comments

6 changed files

cjihrig

pr closed time in 9 days

push eventnodejs/node

cjihrig

commit sha 75ee5b2622956da74541bf3c6388cae5b5d766cf

doc: deprecate process.umask() with no arguments This commit introduces a documentation deprecation for calling process.umask() with no arguments. PR-URL: https://github.com/nodejs/node/pull/32499 Fixes: https://github.com/nodejs/node/issues/32321 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha 60c4c2b6c557efbb2f8f3a3de147baf987931d41

src: runtime deprecate process.umask() This commit runtime deprecates calling process.umask() with no arguments. PR-URL: https://github.com/nodejs/node/pull/32499 Fixes: https://github.com/nodejs/node/issues/32321 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 9 days

issue closednodejs/node

worker: file creation races with process.umask()

This code is unsafe when worker threads are active:

https://github.com/nodejs/node/blob/40b559a376ae1db031132a86a76834decf6f0c2d/src/node_process_methods.cc#L248-L249

The umask(0) call temporarily changes the process-wide umask and races with fs operations from other threads.

Test case:

'use strict';
const { Worker, isMainThread } = require('worker_threads');
const { statSync, writeFileSync, unlinkSync } = require('fs');

function pummel() {
  for (let i = 0; i < 1e4; i++) process.umask();
  setImmediate(pummel);
}

if (isMainThread) {
  process.umask(0o22);
  new Worker(__filename);
  pummel();
} else {
  const file = 'x.txt';
  for (;;) {
    writeFileSync(file, 'ok', { mode: 0o666 });
    const s = statSync(file);
    s.mode &= 0o777;
    if (0o644 !== s.mode) throw 'unexpected mode: ' + s.mode.toString(8);
    unlinkSync(file);
  }
}

Fails within a few iterations with unexpected mode: 666

process.umask() (no arg) is allowed in workers so this test case works both ways.

This bug is potentially a security issue.

closed time in 9 days

bnoordhuis

push eventcjihrig/node

cjihrig

commit sha 75ee5b2622956da74541bf3c6388cae5b5d766cf

doc: deprecate process.umask() with no arguments This commit introduces a documentation deprecation for calling process.umask() with no arguments. PR-URL: https://github.com/nodejs/node/pull/32499 Fixes: https://github.com/nodejs/node/issues/32321 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha 60c4c2b6c557efbb2f8f3a3de147baf987931d41

src: runtime deprecate process.umask() This commit runtime deprecates calling process.umask() with no arguments. PR-URL: https://github.com/nodejs/node/pull/32499 Fixes: https://github.com/nodejs/node/issues/32321 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 9 days

push eventcjihrig/node

Gabriel Schulhof

commit sha fa3fd78c8855379f4d785a5a40176e7cf604f857

src: simplify large pages mapping code * Introduce `OnScopeLeave` handler for cleaning up mmap()ed range(s). * Factor out failure scenario at the bottom of the function with `fail` label for use with `goto`. * Do not allocate temporary range (`nmem`) on FreeBSD, because it is not used. The intention is that the steps involved in re-mapping to large pages become more clearly visible. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/32396 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha a1686e00ab726f70d83241fbea53d577b94ee3a7

test: replace Map with Array in test-cluster-net-listen-ipv6only-false Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 2565442ac0215cbea398d7f0dc1faa49e9632a93

test: use Promise.all() in test-cluster-net-listen-ipv6only-false Use Promise.all() instead of countdown in test-cluster-net-listen-ipv6only-false. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

himself65

commit sha a744dad589cdfe35f322f28d199968559cd4953a

src: remove excess v8 namespace PR-URL: https://github.com/nodejs/node/pull/32191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

James M Snell

commit sha 7d3791a3a4fced7ab524cfd34ecb3b9805d86e28

fs: fixup error message for invalid options.recursive Use "options.recursive" instead of just "recursive" Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32472 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 05aa67aa21b77933033027615eb30df70338c735

console: fixup error message Use "options.inspectOptions" instead of just "inspectOptions" Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32475 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Daniel Bevenius

commit sha cd1db2db48d28db805227e7f6ade79a106d85bc6

src: fix compiler warnings in node_report_module Currently, the following compiler warnings are generated: ../src/node_report_module.cc: In function ‘void report::ShouldReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:132:16: warning: unused variable ‘env’ [-Wunused-variable] 132 | Environment* env = Environment::GetCurrent(info); | ^~~ ../src/node_report_module.cc: In function ‘void report::SetReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:138:16: warning: unused variable ‘env’ [-Wunused-variable] 138 | Environment* env = Environment::GetCurrent(info); | ^~~ This commit removes the unused variables. PR-URL: https://github.com/nodejs/node/pull/32498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha 037f8448bee5ca62ea6bd771495c59c81258ab94

build: disable -Wattributes warnings on aix Disable the following compiler warning: warning: visibility attribute not supported in this configuration; ignored [-Wattributes] This is gcc complaining about `__attribute((visibility("default"))` in static library builds. Legitimate but harmless (and uninteresting) and it drowns out more relevant warnings. PR-URL: https://github.com/nodejs/node/pull/32419 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha c0668fec2a0d08b42a981216b179875e83ba38ad

doc: add missing changes: entry for mkdir Refs: https://github.com/nodejs/node/pull/31530 PR-URL: https://github.com/nodejs/node/pull/32490 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Ling Samuel

commit sha bc28daa9f7a73ce2c21984684315cf03925ca175

doc: rename cve_management_process.md to fit doc style guide PR-URL: https://github.com/nodejs/node/pull/32456 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Bartosz Sosnowski

commit sha eb553a473bc5ff2ad1b155774553122f4e52d231

test: unflake async-hooks/test-statwatcher On Windows 2016 under high load further change events can be emitted after writing the 5 bytes is reported. Updating the mtime of the file can be reported as a separate change. This will increase the "before" count, but not the "w1HookCount" since we removed the listener. This makes the test keep the listeners until the end of the test. Fixes: https://github.com/nodejs/node/issues/21425 PR-URL: https://github.com/nodejs/node/pull/32484 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Richard Lau

commit sha 0cb0f306b6eabce5d81583446de52a5b4cacae00

test: check bundled binaries are signed on macOS For notarization on macOS all packaged binaries must be signed. Add a regression test to check that known binaries from our dependencies (at the time of this commit term-size via npm) are signed. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32522 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

himself65

commit sha 9b4306dc153c73b71cfcc58b14de04d3a53809de

test: remove a duplicated test PR-URL: https://github.com/nodejs/node/pull/32453 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

unknown

commit sha 400bc5cdc0b528a853c6b01b5b5ac993c078f9a2

http: increase default header size from 8KB to 16KB Fixes: https://github.com/nodejs/node/issues/27645 PR-URL: https://github.com/nodejs/node/pull/32520 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Filip Skokan

commit sha 154d4e573aabcb230b0774481246cc1e487abcb4

doc,crypto: clarify oaepHash option's impact PR-URL: https://github.com/nodejs/node/pull/32340 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

himself65

commit sha a2463124dad02988b5f844c83a56081ec22b2c93

src: enhance template function 'MakeUtf8String' PR-URL: https://github.com/nodejs/node/pull/32322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Ruben Bridgewater

commit sha 08c656bb7b852454da85e98640f889ce11beda46

deps: update acorn to v7.1.1 Also clean up the plugins package.json files. PR-URL: https://github.com/nodejs/node/pull/32310 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

himself65

commit sha cc8066e0d196f0180ddcfa04207de8bee69db285

doc: use uppercase on windows path PR-URL: https://github.com/nodejs/node/pull/32294 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Syohei YOSHIDA

commit sha 3822cae39cf6ad95dd2840ebb31afb6903ee33e2

doc: fix profile type of --heap-prof-name V8 CPU profile -> V8 heap profile PR-URL: https://github.com/nodejs/node/pull/32404 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Juan José Arboleda

commit sha effebf87ab01b420d1b6cbace6d64b649f2264e8

src: remove unused v8 namespace PR-URL: https://github.com/nodejs/node/pull/32375 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 9 days

push eventcjihrig/node

Ben Noordhuis

commit sha 037f8448bee5ca62ea6bd771495c59c81258ab94

build: disable -Wattributes warnings on aix Disable the following compiler warning: warning: visibility attribute not supported in this configuration; ignored [-Wattributes] This is gcc complaining about `__attribute((visibility("default"))` in static library builds. Legitimate but harmless (and uninteresting) and it drowns out more relevant warnings. PR-URL: https://github.com/nodejs/node/pull/32419 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha c0668fec2a0d08b42a981216b179875e83ba38ad

doc: add missing changes: entry for mkdir Refs: https://github.com/nodejs/node/pull/31530 PR-URL: https://github.com/nodejs/node/pull/32490 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Ling Samuel

commit sha bc28daa9f7a73ce2c21984684315cf03925ca175

doc: rename cve_management_process.md to fit doc style guide PR-URL: https://github.com/nodejs/node/pull/32456 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Bartosz Sosnowski

commit sha eb553a473bc5ff2ad1b155774553122f4e52d231

test: unflake async-hooks/test-statwatcher On Windows 2016 under high load further change events can be emitted after writing the 5 bytes is reported. Updating the mtime of the file can be reported as a separate change. This will increase the "before" count, but not the "w1HookCount" since we removed the listener. This makes the test keep the listeners until the end of the test. Fixes: https://github.com/nodejs/node/issues/21425 PR-URL: https://github.com/nodejs/node/pull/32484 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Richard Lau

commit sha 0cb0f306b6eabce5d81583446de52a5b4cacae00

test: check bundled binaries are signed on macOS For notarization on macOS all packaged binaries must be signed. Add a regression test to check that known binaries from our dependencies (at the time of this commit term-size via npm) are signed. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32522 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

himself65

commit sha 9b4306dc153c73b71cfcc58b14de04d3a53809de

test: remove a duplicated test PR-URL: https://github.com/nodejs/node/pull/32453 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

unknown

commit sha 400bc5cdc0b528a853c6b01b5b5ac993c078f9a2

http: increase default header size from 8KB to 16KB Fixes: https://github.com/nodejs/node/issues/27645 PR-URL: https://github.com/nodejs/node/pull/32520 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Filip Skokan

commit sha 154d4e573aabcb230b0774481246cc1e487abcb4

doc,crypto: clarify oaepHash option's impact PR-URL: https://github.com/nodejs/node/pull/32340 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

himself65

commit sha a2463124dad02988b5f844c83a56081ec22b2c93

src: enhance template function 'MakeUtf8String' PR-URL: https://github.com/nodejs/node/pull/32322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Ruben Bridgewater

commit sha 08c656bb7b852454da85e98640f889ce11beda46

deps: update acorn to v7.1.1 Also clean up the plugins package.json files. PR-URL: https://github.com/nodejs/node/pull/32310 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

himself65

commit sha cc8066e0d196f0180ddcfa04207de8bee69db285

doc: use uppercase on windows path PR-URL: https://github.com/nodejs/node/pull/32294 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Syohei YOSHIDA

commit sha 3822cae39cf6ad95dd2840ebb31afb6903ee33e2

doc: fix profile type of --heap-prof-name V8 CPU profile -> V8 heap profile PR-URL: https://github.com/nodejs/node/pull/32404 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Juan José Arboleda

commit sha effebf87ab01b420d1b6cbace6d64b649f2264e8

src: remove unused v8 namespace PR-URL: https://github.com/nodejs/node/pull/32375 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Harshitha KP

commit sha 768b0f54eb143329743d2696bd36327f1bad7744

src: replace handle dereference with ContainerOf this was influenced by https://github.com/nodejs/node/pull/32269 PR-URL: https://github.com/nodejs/node/pull/32298 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha c2637847b36db987123e6c10d46b4abb2a078667

test: revise test-http-response-multi-content-length Isolate the two test cases here a bit more and refactor code. PR-URL: https://github.com/nodejs/node/pull/32526 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Gabriel Schulhof

commit sha 67d5c907d2dcf338306eaa74b910096b2a686fc4

src: unify Linux and FreeBSD large pages implem dl_iterate_phdr(3) is also available for FreeBSD. This change adds the same trimming code for the start and end of the .text section as on Linux, making it work on FreeBSD, and removing the need for the additional FreeBSD-specific check. Manually tested on * https://www.osboxes.org/freebsd/#freebsd-12-1-vbox * https://www.osboxes.org/freebsd/#freebsd-11-vbox * test-digitalocean-freebsd11-x64-2 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32534 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Nitin Kumar

commit sha be2f36a51a3c11b2001bd74e03a77cf3ee920aa0

doc: fix typo in maintaining-openssl guide PR-URL: https://github.com/nodejs/node/pull/32292 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Nitin Kumar

commit sha 988f5bf6fb739950fe47ecc3c20853893ba729b0

doc: fix typo in maintaining-zlib guide PR-URL: https://github.com/nodejs/node/pull/32292 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Nitin Kumar

commit sha 575b4e368d01b0be0a5f821d4c46b5aa8ff4b528

doc: fix typo in http2 docs PR-URL: https://github.com/nodejs/node/pull/32292 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Christian Niederer

commit sha 8245a7816c8fb6e6b48f48d2fe36a3f360cf27d7

src: check for overflow when extending AliasedBufferBase When resizing an aliased_buffer check if the new size will overflow. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 9 days

pull request commentnodejs/node

cli, report: move --report-on-fatalerror to stable

Is this unblocked since https://github.com/nodejs/node/pull/32497 landed?

cjihrig

comment created time in 9 days

pull request commentnodejs/node

doc: fix return type of `crypto.getFips()`

Thanks. Still LGTM.

richardlau

comment created time in 10 days

pull request commentnodejs/node

test: replace flag expose_internals to expose-internals

There is test/parallel/test-cli-node-options.js.

juanarbol

comment created time in 11 days

pull request commentnodejs/node

test: replace flag expose_internals to expose-internals

by the way, --expose_internals flag is not documented anywhere.

It sort of is: https://nodejs.org/api/cli.html#cli_options

juanarbol

comment created time in 12 days

push eventcjihrig/node

cjihrig

commit sha 5cfe4ef09fdf827270f89caa3c44bde49fa1417f

src: runtime deprecate process.umask() This commit runtime deprecates calling process.umask() with no arguments. Refs: https://github.com/nodejs/node/issues/32321

view details

push time in 12 days

push eventcjihrig/node

Rich Trott

commit sha f0a33d99ec4656b87bebb97162837047b52eb6f8

doc: simplify and correct example descriptions in net.md Instead of indicating that examples show lines to change in previous examples, present the examples as standalone items. They suffice on their own. In the first of these, it says to change "the second line" of a previous example, but if it were literally changed to the provided line, it would result in a syntax error. In the second of these, it gives the wrong line to change. All of this is unnecessary and probably makes the examples harder to follow. So simplify and treat each one as a separate example. PR-URL: https://github.com/nodejs/node/pull/32451 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

AshCripps

commit sha a621608f12988fac81d63043f4d147850d57c4c2

build: update macos deployment target to 10.13 for 14.x Update the macos deployment target to 10.13 (High Sierra) for Node 14 refs: https://github.com/nodejs/build/issues/2168 PR-URL: https://github.com/nodejs/node/pull/32454 Refs: https://github.com/nodejs/build/issues/2168 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Victor

commit sha afb5639119c91afc8c6f5c078468fe6f7775f8a2

doc: update async_hooks.md Typo `runAndReturn` -> `runSyncAndReturn` PR-URL: https://github.com/nodejs/node/pull/32382 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha bdfbbf6c68da7a413d5e7101ce135ea41e4e81f4

doc: trim wording in n-api.md text about exceptions PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Rich Trott

commit sha 7e4381318b3d4dacc6ed7c050ba8d00e3546a2f7

doc: remove unnecessary "obvious(ly)" modifiers in esm.md Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Rich Trott

commit sha 498415b4abd879a81333f48123cc31ca8f32b6f5

doc: remove extraneous sentence in events.md Since the previous sentence describes `10` as a default, and the following sentence explains how to modify that default, it is unnecessary to explain that "Obviously, not all events should be limited to just 10 listeners." PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Ruy Adorno

commit sha b2e1a01516cbbf9dd1a90e8e0cba188db0b67062

deps: upgrade npm to 6.14.4 PR-URL: https://github.com/nodejs/node/pull/32495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Robert Nagy

commit sha 0d0f151a46b36483af15e355afc81d1693c98fb0

stream: emit 'pause' on unpipe unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: https://github.com/nodejs/node/issues/32470 PR-URL: https://github.com/nodejs/node/pull/32476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Myles Borins

commit sha 113c04c524062b3dcd642e9f9f6784346924360e

2020-03-26 Version 13.12.0 (Current) macOS package notarization and a change in builder configuration: The macOS binaries for this release, and future 13.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing on .pkg files on macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being compiled to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative impact on Node.js 13.x users with older versions of macOS. Notable changes: * build: * macOS package notarization (Rod Vagg) https://github.com/nodejs/node/pull/31459 * deps: * upgrade npm to 6.14.4 (Ruy Adorno) https://github.com/nodejs/node/pull/32495 * update to uvwasi 0.0.6 (Colin Ihrig) https://github.com/nodejs/node/pull/32309 * upgrade to libuv 1.35.0 (Colin Ihrig) https://github.com/nodejs/node/pull/32204 * lib: * add --disable-proto option to cli (Gus Caplan) https://github.com/nodejs/node/pull/32279 * node_report: * move diagnostic reports to stable (Colin Ihrig) https://github.com/nodejs/node/pull/32242 * worker: * allow URL in Worker constructor (Antoine du HAMEL) https://github.com/nodejs/node/pull/31664 * util: * use a global symbol for `util.promisify.custom` (ExE Boss) https://github.com/nodejs/node/pull/31672 PR-URL: https://github.com/nodejs/node/pull/32376

view details

unknown

commit sha cba9f2e7a2ff04619ceba1350418469049d79b1c

doc: add link to DNS definition PR-URL: https://github.com/nodejs/node/pull/32228 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Robert Nagy

commit sha 1428a92492469b7ea1ee91acd204854a615be4eb

stream: make pipeline try to wait for 'close' Pipeline uses eos which will invoke the callback on 'finish' and 'end' before all streams have been fully destroyed. Fixes: https://github.com/nodejs/node/issues/32032 PR-URL: https://github.com/nodejs/node/pull/32158 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha a0578714bf50a473563fa32bad258aad92351ba0

repl: fixup error message Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32474 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha ca19d553cf78e335da396756677bd5afb910ed2d

http: fixup options.method error message Use `options.method` instead of just `method` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32471 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Matheus Marchini

commit sha 7c66f4544abc424c0b18a05fc8ee2793b0c22014

build: drop Travis in favor of Actions GitHub Actions is running all tests already present on Travis, as well as building on more platforms (OS X and Windows). With Travis we're also getting timeouts more frequently than with Actions, which gives the false impression tests are failing (making it harder to triage PRs ready to merge). To make our config simpler, CI.yml and pythonpackage.yml got merged. The coverage is also increased by running tests on OS X. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32450 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Anna Henningsen

commit sha 1b1c2993a5bc9a64cb4d417509d2fc35a64182f4

src: cleanup DestroyParam when Environment exits Otherwise, this leaks memory if the weak callback is never called. PR-URL: https://github.com/nodejs/node/pull/32421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Xavier Stouder

commit sha 191fb3c2f29c8c5827a99258d45163b148824faf

src: check for empty maybe local Using ToLocalChecked on MaybeLocal without verifying it's empty can lead to unattempted crash. PR-URL: https://github.com/nodejs/node/pull/32339 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Juan José Arboleda

commit sha 6791ac0a472cdc968f8d97187c3a8a3d1b272341

src: clean v8 namespaces in env.cc file PR-URL: https://github.com/nodejs/node/pull/32374 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha c3204a8787452e3c3727353ab397de7ee407e5cb

test: use common.buildType in embedding test This un-breaks testing in the case of `./configure --debug-node`. PR-URL: https://github.com/nodejs/node/pull/32422 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Alba Mendez

commit sha c399e2664b9939a8b803f11062a2499293300793

doc: add mildsunrise to collaborators PR-URL: https://github.com/nodejs/node/pull/32525 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Rich Trott

commit sha 436c71db6656b6b48b8a3771c382d093c79e4d1a

test: revise test-http-client-default-headers-exist * Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: https://github.com/nodejs/node/pull/32493 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 12 days

PR opened nodejs/node

tools: update ESLint to 7.0.0-alpha.3

Update ESLint to 7.0.0-alpha.3

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+13639 -5125

0 comment

115 changed files

pr created time in 13 days

create barnchcjihrig/node

branch : eslint

created branch time in 13 days

pull request commentnodejs/node

util: add `maxStrLength` option to `inspect` function

My comment has been addressed, thanks.

rosaxny

comment created time in 14 days

issue commentlibuv/libuv

Is it okay I create a pr to add circle ci ?

Do you mean to run the CI, or something else? I'm not opposed to GitHub actions personally (I actually like them a lot), but they won't be able to fully replace Jenkins due to lack of platform support.

gengjiawen

comment created time in 14 days

push eventcjihrig/node

cjihrig

commit sha 7e63334e5482bc90d43df7723998b77a8de6f9a0

src: runtime deprecate process.umask() This commit runtime deprecates calling process.umask() with no arguments.

view details

push time in 14 days

PR opened nodejs/node

doc: deprecate process.umask() with no arguments

This commit introduces a documentation deprecation for calling process.umask() with no arguments.

Refs: https://github.com/nodejs/node/issues/32321

(I have a runtime deprecation PR ready to go as well, in case we want to skip straight to that step, as this is a potential security issue.)

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+24 -0

0 comment

2 changed files

pr created time in 15 days

create barnchcjihrig/node

branch : umask-doc-depr

created branch time in 15 days

issue commentnodejs/node

Report not generated if `--abort-on-uncaught-exception` is also given

@mmarchini I don't suppose there has been any progress here in V8? This looks like the last bug currently open against the report subsystem.

I propose that we do the following in Node:

  • Implement your patch from https://github.com/nodejs/node/issues/28414#issuecomment-505235101. I think it's fine to lose the JS stack trace in the diagnostic report if you're capturing a full core dump (assuming all other uses of the diagnostic report are not impacted).
  • Document this limitation and move on until it can be fixed.

Thoughts?

mmarchini

comment created time in 15 days

push eventcjihrig/node

cjihrig

commit sha b26a56a0f8c7a4790feb9ec7a468a69ade55ba34

cli, report: move --report-on-fatalerror to stable This commit moves the last experimental feature of diagnostic reports to stable status.

view details

push time in 15 days

PR opened nodejs/node

cli, report: move --report-on-fatalerror to stable

This commit moves the last experimental feature of diagnostic reports to stable status.

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+3 -2

0 comment

1 changed file

pr created time in 15 days

create barnchcjihrig/node

branch : report

created branch time in 15 days

pull request commentnodejs/node

src: adds report_on_fatalerror option to per_process

It seems like this can be closed, given that https://github.com/nodejs/node/pull/32207 landed. Please reopen if that is incorrect. Thanks for the PR.

shobhitchittora

comment created time in 15 days

PR closed nodejs/node

src: adds report_on_fatalerror option to per_process C++ report

Description

moving the report_on_fatalerror flag to per_process as it allows to read it's value on fatal error where env itself is null.

Fixes: https://github.com/nodejs/node/issues/29601

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+43 -28

11 comments

5 changed files

shobhitchittora

pr closed time in 15 days

push eventcjihrig/uvwasi

Xu Meng

commit sha 31b73b24bec9d9b3e8a300f30fea59b48f35da2f

ibmi: skip calling CLOCK_THREAD_CPUTIME_ID on IBMi The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE.

view details

push time in 16 days

PR merged cjihrig/uvwasi

ibmi: skip calling CLOCK_THREAD_CPUTIME_ID on IBMi

The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE.

+2 -2

0 comment

1 changed file

dmabupt

pr closed time in 16 days

pull request commentnodejs/node

test: skip a wasi test on IBMi PASE

So the c code will not be compiled to wasm automatically?

No, because the CI and users would need to have the WASI SDK installed to compile from .c to .wasm. But, beyond that, .wasm files should be platform independent I think.

dmabupt

comment created time in 17 days

pull request commentnodejs/node

test: skip a wasi test on IBMi PASE

This won't do what you think it does. You need to skip the test on IBMi from here.

dmabupt

comment created time in 17 days

Pull request review commentlibuv/libuv

unix: fix utime/futime timestamp rounding errors

 extern char *mkdtemp(char *template); /* See issue #740 on AIX < 7 */   while (0)  +/* Returns the positive fractional part of a floating-point number.+ * Garbage in, garbage out: don't pass in NaN or Infinity.+ *+ * Open-coded (sort of, it's not exactly equivalent to modf(3))+ * to avoid a dependency on libm.+ */+static double uv__frac(double x) {+  if (x < 0)+    x = -x;++  x -= (uint64_t) x;++  return x;+}+++UV_UNUSED(static struct timespec uv__to_timespec(double x)) {+  struct timespec t;++  t.tv_sec = x;+  t.tv_nsec = 1e9 * uv__frac(x);++  /* TODO(bnoordhuis) Remove this. utimesat() has nanosecond resolution but we

Out of curiosity, when can we remove this? I'm only asking because WASI wants nanosecond precision.

bnoordhuis

comment created time in 17 days

issue closednovomatic-tech/keycloak-hapi

Migrate dependencies to @hapi npm namespace

All of the official hapijs modules have moved to the @hapi namespace on npm. This repo's current package.json references boom, hapi, and yar, which are no longer maintained. Is it possible to publish a new version of keycloak-hapi that updates to the @hapi versions of those dependencies?

closed time in 17 days

cjihrig

pull request commentnodejs/node

build: fix libuv build for Android API28+

That's a good point. Maybe we should ask @bnoordhuis.

I'm inclined to say we should continue updating the gyp file in libuv until that PR actually gets merged. I'm not sure if any other libuv users are using the gyp file on Android, but I'm assuming this would fix a bug for them as well.

linroid

comment created time in 18 days

pull request commentnodejs/node

build: fix libuv build for Android API28+

Sorry, I didn't notice that this was in the nodejs repo. This change should go to libuv first.

linroid

comment created time in 18 days

Pull request review commentnodejs/node

build: fix libuv build for Android API28+

             'src/unix/random-getrandom.c',             'src/unix/random-sysctl-linux.c',             'src/unix/sysinfo-loadavg.c',+            'src/unix/random-getentropy.c'

It looks like we were using trailing commas before. Would you mind adding a comma to this new line.

linroid

comment created time in 18 days

created tagkrustyrs/nick

tagv0.0.1

Hi Everybody! - Diagnostic dumps

created time in 19 days

release krustyrs/nick

v0.0.1

released time in 19 days

push eventkrustyrs/nick

Colin Ihrig

commit sha 306b0c4c31daff9520f00d147f943182b0d23069

Initial commit

view details

push time in 19 days

push eventkrustyrs/nick

Colin Ihrig

commit sha e7fda73b57b3c4326195248570a040046b13a910

Initial commit

view details

push time in 19 days

create barnchkrustyrs/nick

branch : master

created branch time in 19 days

created repositorykrustyrs/nick

Hi Everybody! - Diagnostic dumps

created time in 19 days

CommitCommentEvent

issue commenthapijs/lab

The following leaks were detected:@@any-promise/REGISTRATION

lab checks for leaked global variables. any-promise leaks a global variable, which lab detects. You can whitelist the individual global or disable global leak checking completely. Search in https://github.com/hapijs/lab/blob/master/API.md for "leak" for the flags to use.

SalathielGenese

comment created time in 20 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

 assert.doesNotMatch = function doesNotMatch(string, regexp, message) {   internalMatch(string, regexp, message, doesNotMatch); }; +const noop = () => {};++class CallTracker {++  constructor() {+    this.callChecks = new SafeSet();+  }++  calls(fn, exact = 1) {+    if (process._exiting)+      throw new ERR_CALLS_UNAVAILABLE_DURING_EXIT();+    if (typeof fn === 'number') {+      exact = fn;+      fn = noop;+    } else if (fn === undefined) {+      fn = noop;+    }++    validateUint32(exact, 'exact', true);++    const context = {+      exact,+      actual: 0,+      // eslint-disable-next-line no-restricted-syntax+      stackTrace: new Error(),+      name: fn.name || 'calls'+    };+    this.callChecks.add(context);+    const callChecks = this.callChecks;++    return function() {+      // Increment call count+      context.actual++;+      if (context.actual === context.exact) {+        // Once function has reached its call count remove it from+        // callChecks set to prevent memory leaks+        callChecks.delete(context);+      }+      if (context.actual > context.exact) {+        // If call count exceeds exact throw an error+        const message = `Expected the ${context.name} function to be ` ++        `executed ${context.exact} time(s) but was executed ` ++        `${context.actual} time(s).`;++        throw new AssertionError({+          actual: context.actual,+          expected: context.exact,+          message,+          operator: context.name,+        });+      }

Yea, I think we should only enforce the checks from verify().

ConorDavenport

comment created time in 21 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

 try { } ``` +## Class : assert.CallTracker++### `new assert.CallTracker()`+<!-- YAML+added: REPLACEME+-->++Returns a [`CallTracker`][] object.++```js+const assert = require('assert');++const tracker = new assert.CallTracker();++function func() {}++callsfunc = tracker.calls(func);+// Callsfunc() must be called exactly 1 time before tracker.verify()++callsfunc();++process.on('exit', () => {+  tracker.verify();+  // Verifies if all tracker.calls() functions have been called exact times+});+```++### `assert.CallTracker.calls([fn][, exact])`+<!-- YAML+added: REPLACEME+-->++* `fn` {Function} **Default** A no-op function.+* `exact` {number} **Default** `1`++Returns a function that wraps `fn`. The wrapper function is expected to be+called exactly `exact` times before the process exits. If the function is+not called exactly `exact` times before [`assert.CallTracker.verify()`][] is+called, [`assert.CallTracker.verify()`][] throws an error.++```js+const assert = require('assert');++const tracker = assert.createCallTracker();+// Creates call tracker.++function func() {}++callsfunc = tracker.calls(func);+// Returns a function that wraps func() that must be called exact times+// before tracker.verify().+```++### `assert.CallTracker.verify()`+<!-- YAML+added: REPLACEME+-->++Iterates through the list of functions passed to+[`assert.CallTracker.calls()`][] and will throw an error for functions that+have not been called `exact` times.++```js+const assert = require('assert');++const tracker = assert.createCallTracker();+// Creates call tracker.++function func() {}++callsfunc = tracker.calls(func, 2);
const callsfunc = tracker.calls(func, 2);
ConorDavenport

comment created time in 21 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

 assert.doesNotMatch = function doesNotMatch(string, regexp, message) {   internalMatch(string, regexp, message, doesNotMatch); }; +const noop = () => {};++class CallTracker {++  constructor() {+    this.callChecks = new SafeSet();+  }++  calls(fn, exact = 1) {+    if (process._exiting)+      throw new ERR_CALLS_UNAVAILABLE_DURING_EXIT();+    if (typeof fn === 'number') {+      exact = fn;+      fn = noop;+    } else if (fn === undefined) {+      fn = noop;+    }++    validateUint32(exact, 'exact', true);++    const context = {+      exact,+      actual: 0,+      // eslint-disable-next-line no-restricted-syntax+      stackTrace: new Error(),+      name: fn.name || 'calls'+    };+    this.callChecks.add(context);+    const callChecks = this.callChecks;++    return function() {+      // Increment call count+      context.actual++;+      if (context.actual === context.exact) {+        // Once function has reached its call count remove it from+        // callChecks set to prevent memory leaks+        callChecks.delete(context);+      }+      if (context.actual > context.exact) {+        // If call count exceeds exact throw an error+        const message = `Expected the ${context.name} function to be ` ++        `executed ${context.exact} time(s) but was executed ` ++        `${context.actual} time(s).`;++        throw new AssertionError({+          actual: context.actual,+          expected: context.exact,+          message,+          operator: context.name,+        });+      }

What is the purpose of this block of code?

ConorDavenport

comment created time in 21 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

 try { } ``` +## Class : assert.CallTracker++### `new assert.CallTracker()`+<!-- YAML+added: REPLACEME+-->++Returns a [`CallTracker`][] object.++```js+const assert = require('assert');++const tracker = new assert.CallTracker();++function func() {}++callsfunc = tracker.calls(func);+// Callsfunc() must be called exactly 1 time before tracker.verify()++callsfunc();++process.on('exit', () => {+  tracker.verify();+  // Verifies if all tracker.calls() functions have been called exact times+});+```++### `assert.CallTracker.calls([fn][, exact])`+<!-- YAML+added: REPLACEME+-->++* `fn` {Function} **Default** A no-op function.+* `exact` {number} **Default** `1`++Returns a function that wraps `fn`. The wrapper function is expected to be+called exactly `exact` times before the process exits. If the function is+not called exactly `exact` times before [`assert.CallTracker.verify()`][] is+called, [`assert.CallTracker.verify()`][] throws an error.++```js+const assert = require('assert');++const tracker = assert.createCallTracker();+// Creates call tracker.++function func() {}++callsfunc = tracker.calls(func);+// Returns a function that wraps func() that must be called exact times+// before tracker.verify().+```++### `assert.CallTracker.verify()`+<!-- YAML+added: REPLACEME+-->++Iterates through the list of functions passed to+[`assert.CallTracker.calls()`][] and will throw an error for functions that+have not been called `exact` times.

exact isn't really defined in the context of verify().

have not been called the expected number of times.
ConorDavenport

comment created time in 21 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

 const {     ERR_INVALID_ARG_VALUE,     ERR_INVALID_RETURN_VALUE,     ERR_MISSING_ARGS,+    ERR_CALLS_UNAVAILABLE_DURING_EXIT,

The name of this error has changed in the documentation, but not the code.

ConorDavenport

comment created time in 21 days

Pull request review commentnodejs/node

lib: porting common.mustCall to assert

 try { } ``` +## Class : assert.CallTracker++### `new assert.CallTracker()`+<!-- YAML+added: REPLACEME+-->++Returns a [`CallTracker`][] object.++```js+const assert = require('assert');++const tracker = new assert.CallTracker();++function func() {}++callsfunc = tracker.calls(func);+// Callsfunc() must be called exactly 1 time before tracker.verify()++callsfunc();++process.on('exit', () => {+  tracker.verify();+  // Verifies if all tracker.calls() functions have been called exact times+});+```++### `assert.CallTracker.calls([fn][, exact])`+<!-- YAML+added: REPLACEME+-->++* `fn` {Function} **Default** A no-op function.+* `exact` {number} **Default** `1`++Returns a function that wraps `fn`. The wrapper function is expected to be+called exactly `exact` times before the process exits. If the function is+not called exactly `exact` times before [`assert.CallTracker.verify()`][] is+called, [`assert.CallTracker.verify()`][] throws an error.

The current sentence is fine, but the use of assert.CallTracker.verify() feels a bit redundant.

called, an exception is thrown.
ConorDavenport

comment created time in 21 days

more