profile
viewpoint
Myles Borins MylesBorins @GitHub New York, New York https://mylesborins.com Artist, musician, developer, and maker / @nodejs TSC / @tc39 Co-Chair

gregsramblings/google-cloud-4-words 3937

The Google Cloud Developer's Cheat Sheet

github/renaming 905

Guidance for changing the default branch name for GitHub repositories

brianloveswords/base64url 154

For encoding and decoding base64url!

monome/aleph 70

open source sound computer

jkup/one-line 10

A Node.js app where you can only contribute one line at a time

mikeal/dogpatchjs 9

Website for DogpatchJS

mikeal/jsinthepark 9

JS In The Park

AkashaThorne/ravejs 3

RaveJS Beginnings

push eventMylesBorins/ttfn-dot-git

Myles Borins

commit sha 9963f34cd51f84f3e29a7d5a7b60122ae76bf110

maybe?

view details

push time in 2 days

push eventMylesBorins/resolve

Myles Borins

commit sha c9e169083d2af3b3ba393e317d680934b8e92234

even tinier

view details

push time in 2 days

push eventMylesBorins/resolve

Myles Borins

commit sha 7b4fdb576323e60b490670fd698656349687a221

maybe?

view details

push time in 2 days

push eventMylesBorins/resolve

Myles Borins

commit sha b4754459ce99c780fa8e2373d2d95d643592136b

even smaller

view details

push time in 2 days

push eventMylesBorins/resolve

Myles Borins

commit sha 5e6b9e7e4fd4bf3b5a698e14b1d3e26f017ef1b8

even less

view details

push time in 2 days

push eventMylesBorins/resolve

Myles Borins

commit sha ebbdc7e428a3445fbe53a5ed72d27d16476a7710

even less

view details

push time in 2 days

push eventMylesBorins/resolve

Myles Borins

commit sha 3053a1c4ed427b8d4c113ee5fe0d4efd3b658c09

less

view details

push time in 2 days

push eventMylesBorins/resolve

Myles Borins

commit sha 1811c7f8ffd3f8c6b90b14ff5e7f52553b06d295

minimize package.json

view details

push time in 2 days

create barnchMylesBorins/resolve

branch : break-stuff

created branch time in 2 days

fork MylesBorins/resolve

Implements the node.js require.resolve() algorithm

fork in 2 days

push eventMylesBorins/ttfn-dot-git

Myles Borins

commit sha 071b60653853026e32c9be5b303a20fd76f9e882

maybe

view details

push time in 2 days

issue commentnpm/cli

[BUG] npm install can potentially delete .git directory

A couple notes before I vanish for the weekend. This bug is unrelated to any of the scripts being run by the package and with a bit of poking I've managed to find even stranger behavior... npm seems to be bringing folder back FROM THE DEAD

$ git clone https://github.com/browserify/resolve.git
$ cd resolve
$ git checkout v1.17.0
$ rm -rf .git
$ rm -rf test/
$ rm -rf examples/
$ git init
$ git add .
$ git commit -m "Seriously wat"
$ npm install

You will notice that not only is the .git folder blown away, but test/ and examples/ is restored... something I can't for the life of me figure out how or why is happening.

MylesBorins

comment created time in 2 days

push eventMylesBorins/ttfn-dot-git

Myles Borins

commit sha e4bec3a29581251d44375d4e2e4ec9516dbfaedc

add package lock

view details

push time in 2 days

push eventMylesBorins/ttfn-dot-git

Myles Borins

commit sha 1a16047bfea9d8b20cc25f3a980a59b79dcd8559

add path-parse

view details

push time in 2 days

push eventMylesBorins/ttfn-dot-git

Myles Borins

commit sha 2b52eb0e936bf0f8efebd47f47d9a300520abc5c

add tape

view details

push time in 2 days

push eventMylesBorins/ttfn-dot-git

Myles Borins

commit sha 3791d2f65a4925c4eb5eee68c53e5f6b3cbe72e7

add tape

view details

push time in 2 days

push eventMylesBorins/ttfn-dot-git

Myles Borins

commit sha 74aa4f560422a0fc601b321bcac4fe7b858ed29b

README

view details

push time in 2 days

create barnchMylesBorins/ttfn-dot-git

branch : main

created branch time in 2 days

created repositoryMylesBorins/ttfn-dot-git

created time in 2 days

issue openednpm/cli

[BUG] npm install can potentially delete .git directory

This behavior is only reproducible with a specific version of resolve, but it is only reproducible on npm 7. I'm pretty sure the deletion of the .git folder is an unfortunate side effect of a missing dependency causing unexpected behavior in safe-publish-latest. This behavior is happening independent of --legacy-peer-deps

Current Behavior:

npm install fails with the error Error: Cannot find module 'camelcase', bails, and the .git folder is deleted

Expected Behavior:

Modules to be installed and .git folder to not be affected.

Steps To Reproduce:

This will permanently damage the repo so please do it in a fresh install

$ git clone https://github.com/browserify/resolve.git
$ cd resolve
$ git checkout v1.17.0
$ npm install

Environment:

OSX 10.15.6 Node.js v14.6.0 npm v7.0.0-beta.2

created time in 2 days

push eventtc39/notes

Myles Borins

commit sha 97949c04ec47ef61f7a53fa42e0d24f6e0f7362b

Add Brian Douglas to delegates.txt (#64)

view details

push time in 2 days

PR merged tc39/notes

Add Brian Douglas to delegates.txt

As per onboarding docs

+1 -0

0 comment

1 changed file

MylesBorins

pr closed time in 2 days

issue openednpm/cli

[BUG] `npm view --json` with range giving incorrect results

Current Behavior:

$ npm view --json omg-i-pass@^2.0.0
{
  "_id": "omg-i-pass@2.0.0",
...
}

Only a single result is returned for 2.0.0

Expected Behavior:

$ npm view --json omg-i-pass@^2.0.0
[
 {
        "_id": "omg-i-pass@2.0.0",
  ...
  },
  {
    "_id": "omg-i-pass@2.0.1",
  }
]

npm 6 returns an array of results that satisfy the semver range.

Steps To Reproduce:

Use commands as seen above

Environment:

OSX 10.15.6 Node.js v14.6.0 npm v7.0.0-beta.2

created time in 2 days

issue openednpm/cli

[BUG] unexpected change in behavior of npm view --json of invalid version of a package

Current Behavior:

$ npm view --json lodash@0.0.0
undefined
$

Expected Behavior:

In previous versions of npm there would be no content returned

$ npm view --json lodash@0.0.0
$

Steps To Reproduce:

Run above commands

Environment:

OSX 10.15.6 Node.js v14.6.0 npm v7.0.0-beta.2

created time in 2 days

PR opened tc39/notes

Add Brian Douglas to delegates.txt

As per onboarding docs

+1 -0

0 comment

1 changed file

pr created time in 2 days

create barnchtc39/notes

branch : MylesBorins-patch-1

created branch time in 2 days

push eventMylesBorins/node-osc

Myles Borins

commit sha e256bfa02b4e60967cb4929d8ea351c19a2298f4

5.2.0

view details

push time in 3 days

created tagMylesBorins/node-osc

tagv5.2.0

Open Sound Control protocol library for Node.js

created time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 6eddd91956009a8c66a6e7a8ca03bb2b53a79898

Improve CJS code generation + generate tests (#41) Instead of generating a single bundle for CJS compat the file layout of the original ESM tree is preserved. Tests are also transpiled with rollup and then run separately.

view details

push time in 3 days

PR merged MylesBorins/node-osc

Improve CJS code generation + generate tests

Instead of generating a single bundle this will now maintain the file layout of the original ESM tree. Tests are also transpiled with rollup and then run separately.

+133 -75

0 comment

11 changed files

MylesBorins

pr closed time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 5fb398b8ddd5b8900ea85b9763426210570e994f

mebeh?

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha fdd7d276924d766a5e398cbe5f0b0735af69b0b5

phew

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha fa35e8406cb4b3dcc33c5adbcd657332979f44d7

poof

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha fa74fa41e7bb0850932351a7461e8d77439c4cef

bed time

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 642e114b0a3ec667aa455f4f89f520df730a79c2

sighhhhhh

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 71038246faac362871f517b35e206ddcf4d1a0db

sigh

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 588392d7ef1528e08fa2fb9a7e1a022e48911dab

fixup! wip: improve cjs generation

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 884ebf05aa39c3460b6962d2080a1a3eacdacb1c

fixup! wip: improve cjs generation

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha fcf3f738b1ed35cd71c54c59682de213220bb7a1

fixup! wip: improve cjs generation

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 8c7f4580282ca8da17e291ec33628b3ff7957271

fixup! wip: improve cjs generation

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 3a7d0fb4930ffe4825ff3e7ee591eb147f920192

fixup! wip: improve cjs generation

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 204513e0a96f785c96795c9ae4d6c163b17af65e

fixup! wip: improve cjs generation

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 1c37119f9f41049bd7fa4b2cdd061a297497a19f

fixup! wip: improve cjs generation

view details

push time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 6f0289ad40f0d3e8afb3c0f2e666b98c4b08b060

fixup! wip: improve cjs generation

view details

push time in 3 days

PR opened MylesBorins/node-osc

Improve CJS code generation + generate tests

Instead of generating a single bundle this will now maintain the file layout of the original ESM tree. Tests are also transpiled with rollup and then run separately.

+82 -85

0 comment

9 changed files

pr created time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 30e235f6b141e2d2298cb4d538c9dbd3c2769992

update deps

view details

Myles Borins

commit sha f5432ff0df79325898c75ad5bcdc1d8cafb850e4

bump lodash

view details

Myles Borins

commit sha cefac8bf939452594803f8c82ad6138a2658a85b

wip: improve cjs generation

view details

Myles Borins

commit sha 15baab329dfb06e2db4cb714479f327d009cdc30

fixup! wip: improve cjs generation

view details

push time in 3 days

PR closed MylesBorins/node-osc

build(deps): bump lodash from 4.17.15 to 4.17.19 dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -9

1 comment

1 changed file

dependabot[bot]

pr closed time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha f5432ff0df79325898c75ad5bcdc1d8cafb850e4

bump lodash

view details

push time in 3 days

pull request commentMylesBorins/node-osc

build(deps): bump lodash from 4.17.15 to 4.17.19

@dependabot rebase

dependabot[bot]

comment created time in 3 days

push eventMylesBorins/node-osc

Myles Borins

commit sha 30e235f6b141e2d2298cb4d538c9dbd3c2769992

update deps

view details

push time in 3 days

PR closed MylesBorins/node-osc

[WIP] lib: fix dual hazard

Refs: https://github.com/MylesBorins/node-osc/issues/36

+265 -119

3 comments

12 changed files

MylesBorins

pr closed time in 3 days

delete branch MylesBorins/node-osc

delete branch : current

delete time in 3 days

create barnchMylesBorins/node-osc

branch : main

created branch time in 3 days

created tagMylesBorins/oh-hi

tagv1.0.2

created time in 3 days

push eventMylesBorins/oh-hi

Myles Borins

commit sha bd359c595b299cb3a92dc668951cf68bbab118d3

tesssts

view details

Myles Borins

commit sha 636499e0227bbebe502c84062b5533ac842035c8

abstract greetings

view details

Myles Borins

commit sha 857b6835d1a916feae0075dd40179708aeace2d6

1.0.2

view details

push time in 3 days

pull request commentnodejs/node

module: handle Top-Level Await non-fulfills better

If no one objects I plan to land this right at the 48 hour mark so we can unblock TLA for 14.8.0

addaleax

comment created time in 3 days

pull request commentopenjs-foundation/cross-project-council

Add mmarchini as a regular member

@designMoreWeb no worries at all! These things happen.

I went ahead and force pushed master to remove the commit... @designMoreWeb would you like to take the action item of opening a new PR?

mmarchini

comment created time in 3 days

push eventopenjs-foundation/cross-project-council

push time in 3 days

pull request commentopenjs-foundation/cross-project-council

Add mmarchini as a regular member

@openjs-foundation/cpc I think that we need to revert this PR and open a new one to add @mmarchini to the CPC. To be clear I'm beyond enthusiastic to have her participate in the group, but want to ensure we are properly following our existing documented process.

FWIW if we feel the existing process is to cumbersome we can totally augment it to allow for faster turnaround

mmarchini

comment created time in 3 days

pull request commentopenjs-foundation/cross-project-council

Add mmarchini as a regular member

@designMoreWeb I appreciate the enthusiasm to land this but according to our governance this PR was supposed to be left open for at least a week before landing (among a few other pieces of due diligence)

https://github.com/openjs-foundation/cross-project-council/blob/master/GOVERNANCE.md#approving-and-onboarding-regular-members

mmarchini

comment created time in 3 days

issue commentnodejs/node-v8

Port cppgc config to gyp

/cc @nodejs/v8-update PTAL

targos

comment created time in 3 days

issue openednodejs/nodejs.dev

Change default branch name from master -> main

We are looking at making changes to repos in the org before making this change in nodejs/node.

Anyone have concerns with rolling this out on nodejs.dev?

I will personally roll everything out and ensure all automations continue to work as expected.

created time in 3 days

issue commentnodejs/node

Special treatment for package.json resolution and exports?

Also taking a quick look at Node-fetch. They introduced package.exports in 3.0.0 as a breaking change. While the does mean that the package will work on 12.16 and not on 12.17 the package itself explicitly broke that interface in a semver major change. It can undo the breakage by explicitly exporting the package.json, which @wheresrhys has opened a pull-request to fix.

This is entirely inline with what we expected could be broken, and exactly the remediation process we figured could be followed. Yes it is breaking, but it is broken by the interface of the package in a way that can be fixed without any changes in Node.js core. This is, imho, no different than a package begining to use any other Semver-Minor addition to node core, it will break older versions of the same minor that do not have that feature.

ctavan

comment created time in 3 days

pull request commentnode-fetch/node-fetch

Export package.json

Member of the Node.js modules team here. It is likely a very good idea to land this change. package.json needs to be explicitly exported.

wheresrhys

comment created time in 3 days

Pull request review commentnodejs/node

repl: improve static import error message in repl

 const tcpTests = [   {     send: `require(${JSON.stringify(moduleFilename)}).number`,     expect: '42'+  },+  {+    send: 'import comeOn from \'fhqwhgads\'',

LOLOLOL

guess this will need to come in a followup

MylesBorins

comment created time in 3 days

issue commentopenjs-foundation/cross-project-council

Setup auto-generated issues for scheduled actions (elections, etc)

We could potentially use a scheduled action for this

https://docs.github.com/en/actions/reference/events-that-trigger-workflows#scheduled-events

joesepi

comment created time in 3 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-08-06

Modules:

  • Conversations around design decisions related to file extension resolution have picked up again. At the moment there is nothing actionable
  • Discussions regarding package.exports has resulted in feedback that some developers were surprisingly broken on 12.x when they were unflagged. A discussion is being brought to the Release WG
  • Top-Level Await was unflagged on master. It is currently blocked from landing on 14.x until specific behavior around rejections is agreed upon
mhdawson

comment created time in 3 days

issue commentnodejs/node

Special treatment for package.json resolution and exports?

My personal opinion is that there is no reason to reflag.

Yes this has been somewhat disruptive I think reflagging modules at this point would be substantially more disruptive

ctavan

comment created time in 3 days

pull request commentnodejs/node

module: handle Top-Level Await non-fulfills better

@addaleax if this PR lands would you feel like the questions are resolved or are there still things we need to sort out?

addaleax

comment created time in 4 days

issue commentnodejs/build

Need to update CITGM Jenkins job to support npm flag for new peer dep behavior

@richardlau it likely will have to be implemented in CITGM. Still doing a bit of local work to figure out how to best implement

MylesBorins

comment created time in 4 days

push eventMylesBorins/oscilot

dependabot[bot]

commit sha ca063d06e92e3bde39d54ff95cf3a90479d217e2

Bump fastify from 2.13.1 to 2.15.1 Bumps [fastify](https://github.com/fastify/fastify) from 2.13.1 to 2.15.1. - [Release notes](https://github.com/fastify/fastify/releases) - [Commits](https://github.com/fastify/fastify/compare/v2.13.1...v2.15.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Myles Borins

commit sha f3da63217f453a4bfe35d25b4d75923596afd690

Merge pull request #1 from MylesBorins/dependabot/npm_and_yarn/fastify-2.15.1 Bump fastify from 2.13.1 to 2.15.1

view details

push time in 4 days

PR merged MylesBorins/oscilot

Bump fastify from 2.13.1 to 2.15.1 dependencies

Bumps fastify from 2.13.1 to 2.15.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/fastify/fastify/releases">fastify's releases</a>.</em></p> <blockquote> <h2>v2.15.1</h2> <h2>Breaking Change</h2> <p>For security reasons we changed the default in the <code>ajv</code>configuration. Unfortunately <code>allErrors: true</code> is a DoS attack vector for certain schemas. So this changed to <code>allErrors: false</code>.</p> <p>See: ajv-validator/ajv@334071a Ref: <a href="https://hackerone.com/reports/903521">https://hackerone.com/reports/903521</a></p> <h2>📚 PR:</h2> <ul> <li>Add <code>PATCH</code> to <code>body</code> validation (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2351">#2351</a>)</li> </ul> <h2>v2.15.0</h2> <p>📚 PR:</p> <ul> <li>Bind error handler to instance (v2) (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2305">#2305</a>)</li> <li>Fix custom JSON support (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2309">#2309</a>)</li> <li>On ready backport (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2296">#2296</a>)</li> </ul> <h2>v2.14.1</h2> <ul> <li>Tweak haproxy config for issue <a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2036">#2036</a> (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2270">#2270</a>) (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2271">#2271</a>)</li> <li>Fix: call preHandler on reply.callNotFound (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2256">#2256</a>) (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2264">#2264</a>)</li> <li>doc: doc example to use ajv-errors (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2254">#2254</a>)</li> <li>Log clientError as trace to avoid dev confusion (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2241">#2241</a>) (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2242">#2242</a>)</li> </ul> <h2>v2.14.0</h2> <p>📚 PR:</p> <ul> <li>Support builder-style injection (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2209">#2209</a>)</li> <li>fix <a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2214">#2214</a> (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2218">#2218</a>)</li> <li>http2: fix HEAD requests hanging (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2233">#2233</a>) (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2239">#2239</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/fastify/fastify/commit/2cfe0df1682f293becfcb435469befd0c470603e"><code>2cfe0df</code></a> Bumped v2.15.1</li> <li><a href="https://github.com/fastify/fastify/commit/74c3157ca90c3ffed9e4434f63c2017471ec970e"><code>74c3157</code></a> Disable allErrors in default Ajv config.</li> <li><a href="https://github.com/fastify/fastify/commit/854e150c0d78e7c31f4f6eca57908f9da19c379f"><code>854e150</code></a> Revert "correct typings for ready() (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2345">#2345</a>)"</li> <li><a href="https://github.com/fastify/fastify/commit/6de894352871089027a3b4b29bed3012520c4579"><code>6de8943</code></a> Add <code>PATCH</code> to <code>body</code> validation (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2351">#2351</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/65d0e5b15769f67881c37aed8d84b802adf44106"><code>65d0e5b</code></a> correct typings for ready() (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2345">#2345</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/fd94ad3bf4bb1c415a92ecf89ee6f4f038448c39"><code>fd94ad3</code></a> Bumped v2.15.0</li> <li><a href="https://github.com/fastify/fastify/commit/655f28fcc36679b4538e0120eecb1f5524325298"><code>655f28f</code></a> On ready backport (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2296">#2296</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/12fa71451237e7db202afe1235977cd34e7d8d71"><code>12fa714</code></a> Fix custom JSON support (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2309">#2309</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/39e23753240eb18d4f86af736c65e192b4071248"><code>39e2375</code></a> Bind error handler to instance (v2) (<a href="https://github-redirect.dependabot.com/fastify/fastify/issues/2305">#2305</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/6b0ffc6672fb2bf4ba8e4337958c5ee46e6e0300"><code>6b0ffc6</code></a> Bumped v2.14.1</li> <li>Additional commits viewable in <a href="https://github.com/fastify/fastify/compare/v2.13.1...v2.15.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+35 -35

0 comment

2 changed files

dependabot[bot]

pr closed time in 4 days

push eventnodejs/Release

Richard Lau

commit sha 23a3ffd4d289ad8d5e7c1b14f2a004a1cad78292

doc: add @ruyadorno to releasers Synced README.md with `ncu-team sync README.md`.

view details

push time in 4 days

PR merged nodejs/Release

doc: add @ruyadorno to releasers

Synced README.md with ncu-team sync README.md.

+1 -0

4 comments

1 changed file

richardlau

pr closed time in 4 days

pull request commentnodejs/Release

doc: add @ruyadorno to releasers

GPG key has landed on master and PR is open for docker... landing this

richardlau

comment created time in 4 days

created tagnodejs/citgm

tagv7.1.2

Canary in the Gold Mine

created time in 4 days

push eventnodejs/citgm

Myles Borins

commit sha ac43d6b7aac5545f29ecddeaf36d3edd8e42075f

7.1.2

view details

push time in 4 days

push eventMylesBorins/citgm

Myles Borins

commit sha 6ce83582e0d333461c8851e8acdd73708b8ee6ab

lookup: skip gulp on darwin Currently tracking down failures on v14.x and uncovered that `gulp` is relying on an out of date / unsupported version of `chokidar` which is itself relying on an out of date version of `fsevents`. The file watching dependency `glob-watcher` is currently broken on both 12.x and 14.x due to this. While the tests may pass on some platforms I think it may be prudent to skip gulp altogether on darwin platforms until they have fixed their dependency issues.

view details

Myles Borins

commit sha a904d560b3abdcbc7f01ba1f0fe9cd3feb632799

tools: drop v13.x from actions This version is now EOL

view details

Myles Borins

commit sha 42b34c3b381a902e3a34236e5896cc6a2fc0d02d

Revert "lookup: skip shot on v14.x" This reverts commit 24acf67c2b6ed3dce7157215998ce576a2c82650. Shot will now pass on 14.x

view details

Myles Borins

commit sha cbf67c290de4b5559c6942e1c26ca1b12573de2b

7.1.1

view details

Myles Borins

commit sha 6ab8fceff204d49c8ad93fdd67682a1de60a1740

lookup: skip watchify on darwin Watchify relies on an old version of chokidar which has an old version of fsevents, which doesn't support Node.js 12.x+ Skipping on MacOS until this is fixed upstream

view details

Myles Borins

commit sha 617086e15abfccc0df83770e7ef75ff172d6a6c1

npm-install: use --no-audit and --no-fund by default This can speed up install time by a non-trivial amount.

view details

push time in 4 days

push eventnodejs/citgm

Myles Borins

commit sha 617086e15abfccc0df83770e7ef75ff172d6a6c1

npm-install: use --no-audit and --no-fund by default This can speed up install time by a non-trivial amount.

view details

push time in 4 days

PR merged nodejs/citgm

npm-install: use --no-audit and --no-fund by default

This can speed up install time by a non-trivial amount.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below. -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] npm test passes
  • [ ] tests are included
  • [ ] documentation is changed or added
  • [ ] contribution guidelines followed here
+5 -0

2 comments

1 changed file

MylesBorins

pr closed time in 4 days

issue openednodejs/build

Need to update CITGM Jenkins job to support npm flag for new peer dep behavior

Using CITGM to test out npm 7 and need to introduce a new toggle to turn on / off the new peer dep behavior.

I'm doing some local experiments first to figure out the best way to implement this and if we need to do anything in CITGM itself

created time in 4 days

push eventtc39/proposal-import-assertions

ghpages auto deploy

commit sha 01504854eb6187d9178c24e981ae64e066ee8a40

Automated deployment: Wed Aug 5 16:58:45 UTC 2020 fa83e728d50030110135d0bc01618372636e229a

view details

push time in 4 days

pull request commentnpm/cli

pack: output generated tarball filename

Got this running locally and can confirm that it fixes CITGM

RSLGTM

isaacs

comment created time in 4 days

PR closed nodejs/node

repl: improve static import error message in repl ES Modules author ready repl

Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative.

Closes: https://github.com/nodejs/node/issues/33576

+19 -0

8 comments

2 changed files

MylesBorins

pr closed time in 4 days

pull request commentnodejs/node

repl: improve static import error message in repl

Landed in 861a54c0e126

MylesBorins

comment created time in 4 days

push eventnodejs/node

Myles Borins

commit sha 861a54c0e1265e5020348892b87f3ec8935dd9fe

repl: improve static import error message in repl Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: https://github.com/nodejs/node/issues/33576 PR-URL: https://github.com/nodejs/node/pull/33588 Fixes: https://github.com/nodejs/node/issues/33576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 4 days

issue closednodejs/node

Better error message for using static import in repl

We don't support using static import in the repl, we should give a more meaningful error message

closed time in 4 days

MylesBorins

PR closed nodejs/node

doc: add release key for Ruy Adorno doc fast-track notable-change

Add Ruy Adorno and his Release key.

Refs: nodejs/Release#597

cc @MylesBorins @nodejs/releasers

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make lint (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+3 -0

6 comments

1 changed file

ruyadorno

pr closed time in 4 days

push eventnodejs/node

Ruy Adorno

commit sha 96fd6810b697aa0ec9d090c010f25f139f3995c7

doc: add release key for Ruy Adorno Add Ruy Adorno and his Release key. Refs: https://github.com/nodejs/Release/pull/597 PR-URL: https://github.com/nodejs/node/pull/34628 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 4 days

pull request commentnodejs/node

doc: add release key for Ruy Adorno

Landed in 96fd6810b697

ruyadorno

comment created time in 4 days

issue commentnodejs/Release

Release plan - v14.x Current

We usually have done 14.x every two weeks. I don't see a need to push it personally

BethGriggs

comment created time in 4 days

pull request commentnodejs/node

doc: add release key for Ruy Adorno

fast track?

ruyadorno

comment created time in 5 days

pull request commentnodejs/node

doc: add release key for Ruy Adorno

@ruyadorno has the key been published to the keyserver?

[~]$ gpg --keyserver pool.sks-keyservers.net --recv-keys 108F52B48DB57BB0CC439B297B01419BD92F80A
gpg: keyserver receive failed: No data
ruyadorno

comment created time in 5 days

issue commentnodejs/citgm

change primary branch from master -> main

If no one objects by the end of this week I'll likely attempt to use a tool to automate changing the branch and updating the PRs.

Does anyone have a preferred tool for this?

MylesBorins

comment created time in 5 days

Pull request review commentnodejs/citgm

npm-install: use --no-audit and --no-fund by default

 function install(packageManager, context) {       `Using temp directory: "${options.env['npm_config_tmp']}"`     ); +    if (packageManager === 'npm') {+      args.push('--no-audit');

That would not work with the architecture of CITGM. Every module is un archived into it's own file in the temp dir and npm install is run in that directory being orchestrated by CITGM

MylesBorins

comment created time in 5 days

Pull request review commentnodejs/citgm

npm-install: use --no-audit and --no-fund by default

 function install(packageManager, context) {       `Using temp directory: "${options.env['npm_config_tmp']}"`     ); +    if (packageManager === 'npm') {+      args.push('--no-audit');

We would have to automate creating a .npmrc and install it at the root of every module when we extract the tarball... seems like way more work that doing this.

MylesBorins

comment created time in 5 days

pull request commentnodejs/citgm

npm-install: use --no-audit and --no-fund by default

Thanks @darcy for the suggestion

MylesBorins

comment created time in 5 days

PR opened nodejs/citgm

npm-install: use --no-audit and --no-fund by default

This can speed up install time by a non-trivial amount.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below. -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] npm test passes
  • [ ] tests are included
  • [ ] documentation is changed or added
  • [ ] contribution guidelines followed here
+5 -0

0 comment

1 changed file

pr created time in 5 days

create barnchMylesBorins/citgm

branch : no-audit-no-fund-makes-myles-a-dull-boy

created branch time in 5 days

push eventMylesBorins/i-love-this-pattern

Myles Borins

commit sha d04c3354df8affa6ab4fed5a932ac767e9a81f84

Update README.md

view details

push time in 5 days

more