profile
viewpoint
Myles Borins MylesBorins @google New York, New York https://mylesborins.com Artist, musician, developer, and maker / @nodejs TSC / @openjsf Director / DA for @googlecloud / Opinions are potentially wrong, but definitely my own

gregsramblings/google-cloud-4-words 2743

The Google Cloud Developer's Cheat Sheet

google/node-sec-roadmap 153

Some thoughts on how Node.js might respond to a changing security environment

brianloveswords/base64url 144

For encoding and decoding base64url!

GoogleCloudPlatform/wombat-dressing-room 70

proxy designed to reduce the attack surface of npm publish

GoogleCloudPlatform/nodejs-serverless-microservices-demo 68

A set of Node.js microservices to track visual changes of web pages.

monome/aleph 67

open source sound computer

GoogleCloudPlatform/nodejs-serverless-url-shortener 14

A link shortening service built on Google Cloud

jkup/one-line 10

A Node.js app where you can only contribute one line at a time

mikeal/dogpatchjs 9

Website for DogpatchJS

Pull request review commentopenjs-foundation/cross-project-council

doc: adding admin policy docs

+# OpenJS Core Working Groups++OpenJS Core Working Groups (WG) are autonomous projects created by the+[Cross Project Council (CPC)][].++Working Groups can be formed at any time but must be ratified by the CPC.+Once formed the work defined in the Working Group charter is the+responsibility of the WG rather than the CPC.++It is important that Working Groups are not formed pre-maturely. Working+Groups are not formed to *begin* a set of tasks but instead are formed+once that work is already underway and the contributors+think it would benefit from being done as an autonomous project.++If the work defined in a Working Group's charter is complete, the charter+should be revoked.++A Working Group's charter can be revoked either by consent of the Working+Group's members or by a CPC vote. Once revoked, any future work that arises+becomes the responsibility of the CPC.++## Joining a WG++To find out how to join a working group, consult the GOVERNANCE.md in+the working group's repository.++## Starting A Core Working Group++A Working Group is established by first defining a charter that can be+ratified by the CPC. A charter is a *statement of purpose*, a+*list of responsibilities* and a *list of initial membership*.++A working group needs 3 initial members. These should be individuals+already undertaking the work described in the charter.++The list of responsibilities should be specific. Once established, these+responsibilities are no longer governed by the CPC and therefore should+not be broad or subjective. The only recourse the CPC has over the working+group is to revoke the entire charter and take on the work previously+done by the working group themselves.++If the responsibilities described in the charter are currently+undertaken by another WG then the charter will additionally have to be+ratified by that WG.++You can submit the WG charter for ratification by sending+a Pull Request to this document, which adds it to the+list of current Working Groups. Once ratified the list of+members should be maintained in the Working Group's+README.++## Bootstrap Governance++Once the CPC ratifies a charter the WG inherits the following+documentation for governance, contribution, conduct and an MIT+LICENSE. The WG is free to change these documents through their own+governance process, hence the term "bootstrap."++```markdown+### *[insert WG name]* Working Group++The OpenJS *[insert WG name]* is jointly governed by a Working Group (WG)+that is responsible for high-level guidance of the project.++The WG has final authority over this project including:++* Technical direction+* Project governance and process (including this policy)+* Contribution policy+* GitHub repository hosting+* Conduct guidelines+* Maintaining the list of additional Collaborators++For the current list of WG members, see the project+[README.md](./README.md#current-project-team-members).++### Collaborators++The *[insert WG name]* GitHub repository is+maintained by the WG and additional Collaborators who are added by the+WG on an ongoing basis.++Individuals making significant and valuable contributions are made+Collaborators and given commit-access to the project. These+individuals are identified by the WG and their addition as+Collaborators is discussed during the weekly WG meeting.++_Note:_ If you make a significant contribution and are not considered+for commit-access log an issue or contact a WG member directly and it+will be brought up in the next WG meeting.++Modifications of the contents of the *[insert WG repo]* repository are made on+a collaborative basis. Anybody with a GitHub account may propose a+modification via pull request and it will be considered by the project+Collaborators. All pull requests must be reviewed and accepted by a+Collaborator with sufficient expertise who is able to take full+responsibility for the change. In the case of pull requests proposed+by an existing Collaborator, an additional Collaborator is required+for sign-off. Consensus should be sought if additional Collaborators+participate and there is disagreement around a particular+modification. See _Consensus Seeking Process_ below for further detail+on the consensus model used for governance.++Collaborators may opt to elevate significant or controversial+modifications, or modifications that have not found consensus to the+WG for discussion by assigning the ***WG-agenda*** tag to a pull+request or issue. The WG should serve as the final arbiter where+required.++For the current list of Collaborators, see the project+[README.md](./README.md#current-project-team-members).++### WG Membership++WG seats are not time-limited.  There is no fixed size of the WG.+However, the expected target is between 6 and 12, to ensure adequate+coverage of important areas of expertise, balanced with the ability to+make decisions efficiently.++There is no specific set of requirements or qualifications for WG+membership beyond these rules.++The WG may add additional members to the WG by unanimous consensus.++A WG member may be removed from the WG by voluntary resignation, or by+unanimous consensus of all other WG members.++Changes to WG membership should be posted in the agenda, and may be+suggested as any other agenda item (see "WG Meetings" below).++If an addition or removal is proposed during a meeting, and the full+WG is not in attendance to participate, then the addition or removal+is added to the agenda for the subsequent meeting.  This is to ensure+that all members are given the opportunity to participate in all+membership decisions.  If a WG member is unable to attend a meeting+where a planned membership decision is being made, then their consent+is assumed.++No more than 1/3 of the WG members may be affiliated with the same+employer.  If removal or resignation of a WG member, or a change of+employment by a WG member, creates a situation where more than 1/3 of+the WG membership shares an employer, then the situation must be+immediately remedied by the resignation or removal of one or more WG+members affiliated with the over-represented employer(s).++### WG Meetings++The WG meets weekly on a Zoom Webinar. A designated moderator+approved by the WG runs the meeting. Each meeting should be+published to YouTube.++Items are added to the WG agenda that are considered contentious or+are modifications of governance, contribution policy, WG membership,+or release process.++The intention of the agenda is not to approve or review all patches;+that should happen continuously on GitHub and be handled by the larger+group of Collaborators.++Any community member or contributor can ask that something be added to+the next meeting's agenda by logging a GitHub Issue. Any Collaborator,+WG member or the moderator can add the item to the agenda by adding+the ***WG-agenda*** tag to the issue.++Prior to each WG meeting the moderator will share the Agenda with+members of the WG. WG members can add any items they like to the+agenda at the beginning of each meeting. The moderator and the WG+cannot veto or remove items.++The WG may invite persons or representatives from certain projects to+participate in a non-voting capacity.++The moderator is responsible for summarizing the discussion of each+agenda item and sends it as a pull request after the meeting.++### Consensus Seeking Process++The WG follows a [Consensus Seeking][] decision-making model.++When an agenda item has appeared to reach a consensus the moderator+will ask "Does anyone object?" as a final call for dissent from the+consensus.++If an agenda item cannot reach a consensus a WG member can call for+either a closing vote or a vote to table the issue to the next+meeting. The call for a vote must be seconded by a majority of the WG+or else the discussion will continue. Simple majority wins.++Note that changes to WG membership require unanimous consensus.  See+"WG Membership" above.++<a id="developers-certificate-of-origin"></a>+## Developer's Certificate of Origin 1.1++*Note*: The DCO is mandatory for all OpenJS Foundation projects.++By making a contribution to this project, I certify that:++* (a) The contribution was created in whole or in part by me and I+  have the right to submit it under the open source license+  indicated in the file; or++* (b) The contribution is based upon previous work that, to the best+  of my knowledge, is covered under an appropriate open source+  license and I have the right under that license to submit that+  work with modifications, whether created in whole or in part+  by me, under the same open source license (unless I am+  permitted to submit under a different license), as indicated+  in the file; or++* (c) The contribution was provided directly to me by some other+  person who certified (a), (b) or (c) and I have not modified+  it.++* (d) I understand and agree that this project and the contribution+  are public and that a record of the contribution (including all+  personal information I submit with it, including my sign-off) is+  maintained indefinitely and may be redistributed consistent with+  this project or the open source license(s) involved.++### Moderation Policy++The [OpenJS Moderation Policy] applies to this WG.++### Code of Conduct++The [OpenJS Code of Conduct][] applies to this WG.++[OpenJS Code of Conduct]: https://github.com/openjs-foundation/cross-project-council/blob/master/CODE_OF_CONDUCT.md+[OpenJS Moderation Policy]: https://github.com/openjs-foundation/cross-project-council/blob/master/Moderation-Policy.md+```+++## Current Working Groups++*
None currently
joesepi

comment created time in 8 hours

push eventopenjs-foundation/standards

Myles Borins

commit sha c2fbc3742b7a673478f36966f16905def7887ada

governance: getting permission to attend meetings This is a basic policy for getting consensus around attending standards meetings.

view details

Myles Borins

commit sha 82ef24fdb41da46c950e786753639c146642fa1f

Update GOVERNANCE.md

view details

Myles Borins

commit sha c4fe20be86912054c67b20efba7ba00fe241b47a

Update GOVERNANCE.md Co-Authored-By: Eemeli Aro <eemeli@gmail.com>

view details

Myles Borins

commit sha bf996df8e4b89fe12b6621132b1a010a59edd5fa

Update GOVERNANCE.md Co-Authored-By: Eemeli Aro <eemeli@gmail.com>

view details

Myles Borins

commit sha 0b6338f562a1afce1e95d556acfe1b60ab3891bc

Update GOVERNANCE.md Co-Authored-By: Eemeli Aro <eemeli@gmail.com>

view details

Myles Borins

commit sha f7cb29e653319f6e79793bd7acdd91c41d1004e0

Update GOVERNANCE.md

view details

Myles Borins

commit sha 558c0b9b6e0de802cb21ee2d83b7df52a9d54734

Update GOVERNANCE.md

view details

push time in 8 hours

PR merged openjs-foundation/standards

governance: getting permission to attend meetings standards-agenda

This is a basic policy for getting consensus around attending standards meetings.

PTAL

+17 -0

5 comments

1 changed file

MylesBorins

pr closed time in 8 hours

push eventMylesBorins/standards

Myles Borins

commit sha 185632783ba7f228b3ddaa1c1b7128312d34cef6

Update GOVERNANCE.md

view details

push time in 8 hours

Pull request review commentopenjs-foundation/standards

governance: getting permission to attend meetings

 cannot veto or remove items. The moderator is responsible for summarizing the discussion of each agenda item and sends it as a pull request after the meeting. +## Attending External Standards Meetings++At various times members of the Standards team or foundation projects will attend Standards Meetings+at external organizations as a representative of the OpenJS Foundation.+If a member would like to attend a meeting as a delegate of the OpenJS Foundation+they should open an issue stating:++* The standards meeting or series of meetings they wish to attend+* The OpenJS Foundation's relationship to this standards organization+* The date and location of the meeting or meetings+* If they will be attending in person or remotely+* The estimated cost to the foundation of their participation+
* The scope of the work they plan to participate in

MylesBorins

comment created time in 8 hours

push eventMylesBorins/standards

Myles Borins

commit sha 4da1df7e084794bbb72b80ef11197de8468942c9

Update GOVERNANCE.md

view details

push time in 8 hours

Pull request review commentopenjs-foundation/standards

governance: getting permission to attend meetings

 cannot veto or remove items. The moderator is responsible for summarizing the discussion of each agenda item and sends it as a pull request after the meeting. +## Attending External Standards Meetings++At various times members of the Standards team or foundation projects will attend Standards Meetings+at external organizations as a representative of the OpenJS Foundation.+If a member would like to attend a meeting as a delegate of the OpenJS Foundation+they should open an issue stating:++* The standards meeting or series of meetings they wish to attend+* The OpenJS Foundation's relationship to this standards organization+* The date and location of the meeting or meetings+* If they will be attending in person or remotely+* The estimated cost of their particiaption
* The estimated cost to the foundation of their participation
MylesBorins

comment created time in 8 hours

push eventMylesBorins/standards

Myles Borins

commit sha 9d0705d84e9765bfb960559d5356055d54e95b6f

Update GOVERNANCE.md Co-Authored-By: Eemeli Aro <eemeli@gmail.com>

view details

push time in 8 hours

push eventMylesBorins/standards

Myles Borins

commit sha eb281bc4de2f38b51f282b8dddea590a24108d4e

Update GOVERNANCE.md

view details

push time in 8 hours

push eventMylesBorins/standards

Myles Borins

commit sha 1ce3d5b592e92a287f697412fd4b385b2871f72d

Update GOVERNANCE.md Co-Authored-By: Eemeli Aro <eemeli@gmail.com>

view details

push time in 8 hours

push eventMylesBorins/standards

Myles Borins

commit sha 21f7a0aad365561ed4bbb9727052eb610a75acff

Update GOVERNANCE.md Co-Authored-By: Eemeli Aro <eemeli@gmail.com>

view details

push time in 8 hours

issue commentnodejs/admin

Additional org owned by Node.js project for package maintenance team

Also worth mentioning I don't think there is any need to check with the cpc on this. Nodejs is chartered with governing it's project... The org / repo is an artifact of that. We have other orgs we already maintain

mhdawson

comment created time in 9 hours

issue commentnodejs/admin

Additional org owned by Node.js project for package maintenance team

Could the solution to this problem not be as simple as adding the new org / repo in the list in the readme.

Any repo / team will require their own governance... but it feels to me like just documenting it in the readme might be sufficient

mhdawson

comment created time in 10 hours

push eventMylesBorins/extra-special-modules

Myles Borins

commit sha 7f6e3a23036a8d2aedf9de301d1c9e3381b60935

moar changes

view details

push time in 21 hours

PR closed nodejs/node

src: elevate v8 namespaces C++ author ready

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+7 -5

3 comments

1 changed file

HarshithaKP

pr closed time in a day

pull request commentnodejs/node

src: elevate v8 namespaces

Landed in b70dd9d662aa

HarshithaKP

comment created time in a day

push eventnodejs/node

Harshitha KP

commit sha b70dd9d662aaf3e652219e65d8e51762842d8b80

src: elevate v8 namespaces PR-URL: https://github.com/nodejs/node/pull/31901 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in a day

push eventnodejs/node

Myles Borins

commit sha 021542080a020d1d67fa47e25338973b78d543e6

doc: update releases guide re pushing tags Currently we specify pushing the tag before updating any of the branches. This creates a potential of creating and pushing a tag on an out of sync branch, and only really when attempting to merge the release commit that things have gone out of sync. Changing the order here would minimize the possibility of this error PR-URL: https://github.com/nodejs/node/pull/31855 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

push time in a day

PR closed nodejs/node

doc: update releases guide re pushing tags author ready doc

Currently we specify pushing the tag before updating any of the branches. This creates a potential of creating and pushing a tag on an out of sync branch, and only really when attempting to merge the release commit that things have gone out of sync.

Changing the order here would minimize the possibility of this error

+20 -18

1 comment

1 changed file

MylesBorins

pr closed time in a day

pull request commentnodejs/node

doc: update releases guide re pushing tags

Landed in 021542080a02

MylesBorins

comment created time in a day

pull request commentDerekNonGeneric/loader339

Get self reference modules working

One thing to add --no-esm is a tap specific flag... Not for the nodejs runtime

On Mon, Feb 24, 2020, 7:04 AM Dilip Kr. Shukla notifications@github.com wrote:

Thanks a lot @DerekNonGeneric https://github.com/DerekNonGeneric for explaining in detail especially about significance of --no-esm.

I got it working now 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DerekNonGeneric/loader339/pull/1?email_source=notifications&email_token=AADZYV3KAKQ74KVDIHEWY43REOZVPA5CNFSM4JREVJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXRQYA#issuecomment-590288992, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZYVYPQTXNIRUDPNBNNN3REOZVPANCNFSM4JREVJUA .

MylesBorins

comment created time in 2 days

push eventMylesBorins/extra-special-modules

Myles Borins

commit sha 0fde0ab39b852e0cb401d4537b518fa1cf462648

still needs 1 - 2 more passes

view details

push time in 2 days

issue commentnodejs/nodejs.dev

Onboarding: @SauloNunes and @BenHalverson

Automation is all based on the repo not the team. I had chimed in another thread that it wasn't entirely clear why the two teams should be merged. myself and others who are not involved in the broader redesign effort are helping to maintain the nodejs.dev website but not participating in meetings or the team. Seems like an over optimization to me.

On Sun, Feb 23, 2020, 11:22 AM Tierney Cyren notifications@github.com wrote:

cc @MylesBorins https://github.com/MylesBorins - do you have context on the above?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/nodejs.dev/issues/406?email_source=notifications&email_token=AADZYV2QEZWIZLI23B5EOD3REKPDXA5CNFSM4KV2PR32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWADEI#issuecomment-590086545, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZYV73JYJYD3CF22Q6GSLREKPDXANCNFSM4KV2PR3Q .

SMotaal

comment created time in 2 days

issue commentnodejs/nodejs.dev

Merge website redesign teams

I see the discussion about merging teams and operations as orthogonal tbh.

I spun up all the existing infrastructure and am the sole admin at the moment. We can either extend access to others, or switch to another tool such as netlify which might be easier to maintain.

We could also see about the build team taking ownership of the operations.

On Sat, Feb 22, 2020, 10:47 AM Saleh Abdel Motaal notifications@github.com wrote:

@MylesBorins https://github.com/MylesBorins I think what we are trying to do as we are mostly new to the team, we're trying to size the joint to make sure where we are stepping, documenting things (@benhalverson https://github.com/benhalverson) in https://github.com/benhalverson/nodejs.dev/blob/docs/CONTRIBUTING.md — see #397 https://github.com/nodejs/nodejs.dev/pull/397.

We are basically not sure we know enough about how gcbrun and other workflow aspects are managed:

  1. Who is involved on admin aspects.
  2. What those admin aspects look like.
  3. What to do when we run into unknowns.

Obviously not asking to give access, merely to fill the void so we can see the landscape and know if and when it is time to loop others in as needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/nodejs.dev/issues/412?email_source=notifications&email_token=AADZYVZR3RDUUNKCLVL3LNLREFCKHA5CNFSM4KYTWR22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVDHZA#issuecomment-589968356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZYV6TSCS6CJHTTKAEQK3REFCKHANCNFSM4KYTWR2Q .

keywordnew

comment created time in 3 days

Pull request review commentnodejs/nodejs.dev

refactor: Enhanced Dark Mode as third-party dependency

-v8.12.0\ No newline at end of file+v8.12.0

No idea why, probably an artifact from the original proof of concept. Travis and cloud build are both using Node 10. We should do a separate pr to remove the NVM rc and perhaps update Travis / cloud build to 12

SMotaal

comment created time in 3 days

push eventMylesBorins/conference-proposals

Myles Borins

commit sha 3c7e51eceb56ff3bfcd657d27f9b6ce87bd699ea

developer fan fiction

view details

push time in 4 days

issue commentnodejs/Release

Removing python 2.7

Wasn't the true end of life delayed until April?

https://www.python.org/psf/press-release/pr20191220/

Fwiw I'm not arguing for or against this initiative, more want to ensure we have appropriate timelines.

On Fri, Feb 21, 2020, 12:04 PM Pomax notifications@github.com wrote:

With the death of Python 2.7 on January 1st of this year, tools that used to rely on it are now forced to update for Python 3. For the Node community, the most important tool in that space is node-gyp, which has thankfully already supported Python 3 for quite a few versions, but the version that is used by npm is not quite recent enough and still has python 2.7 support.

A feature request was filed https://github.com/npm/cli/issues/927 for npm to update to node-gyp 5.1.0 or higher so that any mention of python 2.7 can finally be removed from node-gyp, but some coordination is probably required to make sure that Node.js gets released with a version of npm that relies on a pure Python 3 version of node-gyp.

As such, I figured I file this issue to see what kind of path forward can be taken to make sure the obsolete Python 2.7 is no longer part of the Node ecosystem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nodejs/Release/issues/538?email_source=notifications&email_token=AADZYV65LANC2BHMRFYJRPLREACTTA5CNFSM4KZG3GMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPLM2LQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZYVZVJ22C56EHEXEWL2TREACTTANCNFSM4KZG3GMA .

Pomax

comment created time in 4 days

issue commentnodejs/nodejs.dev

Merge website redesign teams

The permissions model for gcb is based on who has access to the repo, not specific teams. So as long as the merged team maintains the permissions it will be fine.

I will point out that there are a number of folks, including myself, helping to maintain .dev but are not active in the redesign initiative. As such it might not entirely make sense to merge. But consider this a +/- 0

On Thu, Feb 20, 2020, 12:53 PM Jonathan Church notifications@github.com wrote:

FWIW Members of nodejs-dev are currently able to kick off gcbrun (that's the team I've been a member of).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/nodejs.dev/issues/412?email_source=notifications&email_token=AADZYVYIWZQC7FOSIWUZC5LRD27STA5CNFSM4KYTWR22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPNSJI#issuecomment-589224229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZYVZIXHRP56M2NJ66T63RD27STANCNFSM4KYTWR2Q .

keywordnew

comment created time in 5 days

issue commentnodejs/node

Extend default logger with configuration

So it looks like the Console Standard supports hosts extending the printer with an options object

https://console.spec.whatwg.org/#printer

If the options object is passed, and is not undefined or null, implementations may use options to apply implementation-specific formatting to the elements in args.

How the implementation prints args is up to the implementation, but implementations should separate the objects by a space or something similar, as that has become a developer expectation.

Looking at our internal implementation we are not exactly following the spec, we have a generic write to console internal function that takes the stream symbol and the string to be printed

There are four groupings of severity which would be useful information for folks wanting to create structured logs.

So we couldn't, by the spec, have folks pass the options object to the logger itself... but since the Console constructor is not spec'd, AFAICT, we should be able to add the ability to pass options to the constructor that could be used to modify the print function and remain true to the spec. These options could likely be passed either at creation time of new console objects, or potentially as a runtime flag to pass it to Node's global console Object.

It also seems like we could include a bit more data to the stream that is doing the printing without violating the spirit of the spec, potentially giving folks implementing their own stdout / stderr handlers more data about what specific console function called them.

MylesBorins

comment created time in 5 days

issue commentnodejs/modules

Node 3.9.0 blocks the use of npm scripts

Can you run node --version locally. There was never a Node.js version 3, as version three was part of the IO.js project. Currently supported versions of Node.js are 10, 12, 13.

Are you running code as CommonJS or ESM? If you are using ESM you need to include the full path to the resource you are trying to run.

There is nothing that we have done in Node.js to block npm scripts, which still are actively used across the ecosystem, and if I recall even internally in Node.js core for some of our tooling.

sla100

comment created time in 5 days

push eventMylesBorins/cleanup

Myles Borins

commit sha 2cb1d766e20c479a935e07a66a97e3fbc064d577

docker-tweaks

view details

Myles Borins

commit sha 2215c5f223f860e1abd8f7317fc4a3075afb082f

moar logs

view details

push time in 6 days

issue commentnodejs/node

--es-module-specifier-resolution=node not working from v13.0.1

@dandv we have renamed the flag, but we continue to support --es-module-specifier-resolution=node which silently aliases to --experimnetal-specifier-resolution

jaydenseric

comment created time in 6 days

issue closednodejs/Release

Rename Current release line Canary?

It's been a couple years since we've changed the names of things so I figured this might be worth discussing. My personal understanding of the "current" release line is that it gets anything on master that isn't semver-major, and there is a non-trivial chance of bugs / regressions showing up. This is imho a feature of the "current" release line. That said folks are using it in production and I've spoken to a number of people who were unaware that things are not entirely "stable" (the old name for current).

As such I feel a name like "canary" might be more appropriate.

Thoughts?

closed time in 6 days

MylesBorins

push eventMylesBorins/cleanup

Myles Borins

commit sha 7f38334dc2019ab783688ce013095d62ceef4b24

bubye

view details

push time in 7 days

push eventMylesBorins/cleanup

Myles Borins

commit sha 0e989e10bf44475e5935ce8902213a438a304908

this feelsl ike a bad idea

view details

Myles Borins

commit sha 146afd7dc977247f51496fe9861412439df44d68

update readme

view details

push time in 7 days

created tagMylesBorins/cleanup

tagv5.0.0

Snapchat for twitter

created time in 7 days

push eventMylesBorins/cleanup

Myles Borins

commit sha 68ab7e2e714d9fad92f758ddaed063d2f07f901f

omg new api

view details

push time in 7 days

create barnchMylesBorins/cleanup

branch : new-api

created branch time in 7 days

issue commentnodejs/node

esm: Make `import.meta.resolve(…)` take an options argument

@ExE-Boss the intent of the api is to make something that could also be implemented / standardized for browser use cases... so it is not using require.resolve as a reference API.

There is a discussion in the import maps proposal related to this. https://github.com/WICG/import-maps/issues/79

FWIW I'm not saying that we should or should not have an options argument, more pointing towards motivation for the existing API. Part of the reason it is behind a flag is to give us time to workshop and create something that can be cross platform

ExE-Boss

comment created time in 7 days

issue commentWICG/import-maps

Driving work on a preload spec

Apologies in advance if I am missing anything, but I am curious if there Is there any overlap between the preload spec and existing work being done in IETF for web bundles

https://wicg.github.io/webpackage/draft-yasskin-wpack-bundled-exchanges.html (a part of web package https://github.com/WICG/webpackage)

guybedford

comment created time in 7 days

PR closed nodejs/node

v12.16.1 proposal C++ meta n-api v12.x

2020-02-18, Version 12.16.1 'Erbium' (LTS), @MylesBorins

Notable changes

Node.js 12.16.0 included 6 regressions that are being fixed in this release

Accidental Unflagging of Self Resolving Modules:

12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the --experimental-modules flag. This release is being made to appropriately flag the feature.

Process Cleanup Changed Introduced WASM-Related Assertion:

A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases.

Use Largepages Runtime Option Introduced Linking Failure:

A Semver-Minor change to introduce --use-largepages as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release.

Async Hooks was Causing an Exception When Handling Errors:

Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re-land in a future Semver-Patch release if the regression is reliably fixed.

New Enumerable Read-Only Property on EventEmitter breaks @types/extend

A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the @types/extend module for extending classses as @types/extend was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re-land in a future Semver-Minor release if a non breaking way of applying it is found.

Exceptions in the HTTP parser were not emitting an uncaughtException

A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by process.on('uncaughtException') when the async_hooks after hook exists. The fix to this bug has been included in this release.

Commits

  • [51fdd759b9] - async_hooks: ensure event after been emitted on runInAsyncScope (legendecas) #31784
  • [7a1b0ac06f] - Revert "build: re-introduce --use-largepages as no-op" (Myles Borins) #31782
  • [a53eeca2a9] - Revert "build: switch realpath to pwd" (Myles Borins) #31782
  • [6d432994e6] - Revert "build: warn upon --use-largepages config option" (Myles Borins) #31782
  • [a5bc00af12] - Revert "events: allow monitoring error events" (Myles Borins)
  • [f0b2d875d9] - module: 12.x self resolve flag as experimental modules (Guy Bedford) #31757
  • [42b68a4e24] - src: inform callback scopes about exceptions in HTTP parser (Anna Henningsen) #31801
  • [065a32f064] - Revert "src: make --use-largepages a runtime option" (Myles Borins) #31782
  • [3d5beebc62] - Revert "src: make large_pages node.cc include conditional" (Myles Borins) #31782
  • [43d02e20e0] - src: keep main-thread Isolate attached to platform during Dispose (Anna Henningsen) #31795
  • [7a5954ef26] - src: fix -Winconsistent-missing-override warning (Colin Ihrig) #30549
+191 -229

29 comments

25 changed files

MylesBorins

pr closed time in 7 days

pull request commentnodejs/node

v12.16.1 proposal

landed in d3fb1680dc

MylesBorins

comment created time in 7 days

Pull request review commentnodejs/node

doc: add note about ssh key to releases

 formatting passes the lint rules on `master`. to promote the builds as the `SHASUMS256.txt` file needs to be signed with the same GPG key!** -Use `tools/release.sh` to promote and sign the build. When run, it will perform-the following actions:+Use `tools/release.sh` to promote and sign the build. Before doing this, you'll+need to ensure you've loaded the correct ssh key, or you'll see the following:++```sh+# Checking for releases ...+Enter passphrase for key '/Users/<user>/.ssh/id_rsa':+dist@direct.nodejs.org's password:+```++You can specify this at run-time if need be with:

should we add a note about loading your key via ssh-add ~/.ssh/id_rsa_${key}?

codebytere

comment created time in 7 days

Pull request review commentnodejs/node

doc: add note about ssh key to releases

 formatting passes the lint rules on `master`. to promote the builds as the `SHASUMS256.txt` file needs to be signed with the same GPG key!** -Use `tools/release.sh` to promote and sign the build. When run, it will perform-the following actions:+Use `tools/release.sh` to promote and sign the build. Before doing this, you'll+need to ensure you've loaded the correct ssh key, or you'll see the following:++```sh+# Checking for releases ...+Enter passphrase for key '/Users/<user>/.ssh/id_rsa':+dist@direct.nodejs.org's password:+```++You can specify this at run-time if need be with:+```sh+# Substitute node_id_rsa with whatever you've named the key+$ ./tools/release.sh -i ~/.ssh/node_id_rsa+```++When run, `tools/release.sh` will perform the following actions:
`tools/release.sh` will perform the following actions when run:

nit

codebytere

comment created time in 7 days

push eventnodejs/node

Shelley Vohr

commit sha 31290824de068eb4b282ab74829450b988ae225b

doc: fix notable changes for v13.9.0 PR-URL: https://github.com/nodejs/node/pull/31857 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

push time in 7 days

PR closed nodejs/node

doc: fix notable changes for v13.9.0 doc fast-track

Fixes Notable Changes for v13.9.0. They're correct in the release commit and in the blog post, but I whiffed on them here.

cc @BethGriggs

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+21 -8

2 comments

1 changed file

codebytere

pr closed time in 7 days

pull request commentnodejs/node

doc: fix notable changes for v13.9.0

Landed in 31290824de06

codebytere

comment created time in 7 days

issue openednodejs/Release

Rename Current release line Canary?

It's been a couple years since we've changed the names of things so I figured this might be worth discussing. My personal understanding of the "current" release line is that it gets anything on master that isn't semver-major, and there is a non-trivial chance of bugs / regressions showing up. This is imho a feature of the "current" release line. That said folks are using it in production and I've spoken to a number of people who were unaware that things are not entirely "stable" (the old name for current).

As such I feel a name like "canary" might be more appropriate.

Thoughts?

created time in 7 days

pull request commentnodejs/node

doc: fix notable changes for v13.9.0

fast track?

codebytere

comment created time in 7 days

push eventnodejs/node

Myles Borins

commit sha db125c561880d8b2b272fb85c7a3baa91fcec31a

doc: fix missing changelog corrections There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch. PR-URL: https://github.com/nodejs/node/pull/31854 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 7 days

PR closed nodejs/node

doc: fix missing changelog corrections doc fast-track

There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch.

+4 -4

2 comments

1 changed file

MylesBorins

pr closed time in 7 days

pull request commentnodejs/node

doc: fix missing changelog corrections

Landed in 43fb664701d7

MylesBorins

comment created time in 7 days

push eventnodejs/node

Myles Borins

commit sha 43fb664701d771c00595fa1c152cfca03b10a4fd

doc: fix missing changelog corrections There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch. PR-URL: https://github.com/nodejs/node/pull/31854 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 7 days

release nodejs/node

v12.16.1

released time in 7 days

push eventnodejs/nodejs.org

Myles Borins

commit sha e645f1ce50f645a1a72e2852b3954ec31478cd94

blog: add release post for 12.16.1 (#2963) Refs: https://github.com/nodejs/node/pull/31781

view details

push time in 7 days

PR merged nodejs/nodejs.org

blog: add release post for 12.16.1

Refs: https://github.com/nodejs/node/pull/31781

+140 -0

0 comment

1 changed file

MylesBorins

pr closed time in 7 days

create barnchMylesBorins/nodejs.org

branch : 12.16.1-release-post

created branch time in 7 days

PR opened nodejs/nodejs.org

blog: add release post for 12.16.1

Refs: https://github.com/nodejs/node/pull/31781

+140 -0

0 comment

1 changed file

pr created time in 7 days

PR opened nodejs/node

doc: update releases guide re pushing tags

Currently we specify pushing the tag before updating any of the branches. This creates a potential of creating and pushing a tag on an out of sync branch, and only really when attempting to merge the release commit that things have gone out of sync.

Changing the order here would minimize the possibility of this error

+20 -18

0 comment

1 changed file

pr created time in 7 days

create barnchMylesBorins/node

branch : update-release-instructions

created branch time in 7 days

pull request commentnodejs/node

doc: fix missing changelog corrections

Can we please fast track

MylesBorins

comment created time in 7 days

PR opened nodejs/node

doc: fix missing changelog corrections fast-track

There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch.

+4 -4

0 comment

1 changed file

pr created time in 7 days

push eventMylesBorins/node

Anna Henningsen

commit sha c0b5e6fd4b87d1e61151b77b3ec10e6650f5153b

src: use BaseObjectPtr for keeping channel alive in dns bindings PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha a489583eda4d7cebc06516834b31dc2a4cedb1b6

src: remove keep alive option from SetImmediate() This is no longer necessary now that the copyable `BaseObjectPtr` is available (as opposed to the only-movable `v8::Global`). PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 1317ac65b4f001588b86002aa22431719683beb4

src: remove HandleWrap instances from list once closed This allows keeping `BaseObjectPtr`s to `HandleWrap` instances. Previously, the pointer kept the `HandleWrap` object alive, leaving the Environment cleanup code that waits for the handle list to drain in a busy loop, because only the `HandleWrap` destructor removed the item from the list. Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 6cb8e4b12cd16ae8ed126f98458efb78312cabf6

src: mark ArrayBuffers with free callbacks as untransferable More precisely, make them untransferable if they were created through *our* APIs, because those do not follow the improved free callback mechanism that V8 uses now. All other ArrayBuffers can be transferred between threads now, the assumption being that they were created in a clean way that follows the V8 API on this. This addresses a TODO comment. Refs: https://github.com/nodejs/node/pull/30339#issuecomment-552225353 PR-URL: https://github.com/nodejs/node/pull/30475 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha e5d3c8121dd0bcc4dbf52c7b3a0521e359363a05

src: expose ArrayBuffer version of Buffer::New() This can be useful to create `Buffer` instances for already-existing `ArrayBuffer`s, e.g. ones created manually from a backing store with a free callback (of which our variant in the public API has some limitations). PR-URL: https://github.com/nodejs/node/pull/30476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Jesse O'Connor

commit sha 7cecac669f05f36016c684dcee381cf21ab188d2

doc: update http.md mention of socket This commit is addressing the problem in issue #29948. Fixes: https://github.com/nodejs/node/issues/29948 PR-URL: https://github.com/nodejs/node/pull/30155 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Jeremy Apthorp

commit sha 4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e

src: add file name to 'Module did not self-register' error PR-URL: https://github.com/nodejs/node/pull/30125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Lucas Holmquist

commit sha 535e9571f5252ea9ce6f5db12f700f73af6df055

fs: make FSStatWatcher.start private An instance of FSStatWatcher is returned when a user calls fs.watchFile, which will call the start method. A user can't create an instance of a FSStatWatcher directly. If the start method is called by a user it is a noop since the watcher has already started. This "Class" is currently undocumented. PR-URL: https://github.com/nodejs/node/pull/29971 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Robert Nagy

commit sha 9d09969f4c29b7f2bacc9cb44e210c4e269945a4

stream: always invoke end callback Ensure that the callback passed into end() is always invoke in order to avoid bug such as deadlock the user. PR-URL: https://github.com/nodejs/node/pull/29747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Sam Roberts

commit sha b0cf62b3a05cf1b207441de2ce3d33a3a57acd5f

https: add client support for TLS keylog events The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server. PR-URL: https://github.com/nodejs/node/pull/30053 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

VinceOPS

commit sha 205046af7eb6be0b4a7a785082962586ed6f1dec

lib: replace var with let and const in readline.js PR-URL: https://github.com/nodejs/node/pull/30377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

David OLIVIER

commit sha f4ea9189501743797d1ab8f5ed07027dd71f59bd

lib: replace var with let PR-URL: https://github.com/nodejs/node/pull/30381 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Sam Roberts

commit sha 80efb80f3f9dffb412aa1a41ab36c843c90c60e5

tls: cli option to enable TLS key logging to file Debugging HTTPS or TLS connections from a Node.js app with (for example) Wireshark is unreasonably difficult without the ability to get the TLS key log. In theory, the application can be modified to use the `'keylog'` event directly, but for complex apps, or apps that define there own HTTPS Agent (like npm), this is unreasonably difficult. Use of the option triggers a warning to be emitted so the user is clearly notified of what is happening and its effect. PR-URL: https://github.com/nodejs/node/pull/30055 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tobias Nießen

commit sha c63af4fea041673eb7c33f6df3c474d4537fe5eb

crypto: add support for IEEE-P1363 DSA signatures PR-URL: https://github.com/nodejs/node/pull/29292 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Marcel Laverdet

commit sha c712fb7cd6222018cf615fd0071998bde6f16da9

src: add abstract `IsolatePlatformDelegate` Adds a new abstract class for module authors and embedders to register arbitrary isolates with `node::MultiIsolatePlatform`. PR-URL: https://github.com/nodejs/node/pull/30324 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

cjihrig

commit sha 3871cc5f0c791632d2555e159873530bfdd02d4f

src: fix -Winconsistent-missing-override warning This commit addresses the following warning: ../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] v8::Maybe<bool> mark_arraybuffer_as_untransferable( ^ ../src/js_native_api_v8.h:42:27: note: overridden virtual function is here virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable( PR-URL: https://github.com/nodejs/node/pull/30549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Denys Otrishko

commit sha a30a9f8193ddd61dfadc2d5d79784b682027b319

test: clean up http-set-trailers * remove shared state of request counting from each listener by using callbacks to report test finish. This also fixes slight race condition where one of the request could finish before the other was taken into account resulting in ECONNREFUSED due to premature server.close() * slightly move code for better cohesion * fix error comment in testHttp10 'Trailer ...' -> 'No trailer ...' PR-URL: https://github.com/nodejs/node/pull/30522 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

claudiahdz

commit sha a7c7c703aff362f06ef5d49451a0f79fd289910f

deps: upgrade npm to 6.13.1 PR-URL: https://github.com/nodejs/node/pull/30533 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Luigi Pinca

commit sha f4b240f01276126b76978bb1d69cf79dd9e2cf6c

doc: fix overriding of prefix option Make the example in the "Building a debug build" section work as intended. Fixes: https://github.com/nodejs/node/issues/30477 PR-URL: https://github.com/nodejs/node/pull/30518 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Denys Otrishko

commit sha c8d00d9ed06a9983c02d7a250d96c81980e0e3a6

doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE PR-URL: https://github.com/nodejs/node/pull/30371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 7 days

push eventnodejs/node

Myles Borins

commit sha 1c2d77d3d9dd5753a96c0033265c5eeaf3531d00

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 7 days

push eventnodejs/node

cjihrig

commit sha 7a5954ef26c49f53d40a516df60800a119fb9da7

src: fix -Winconsistent-missing-override warning This commit addresses the following warning: ../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] v8::Maybe<bool> mark_arraybuffer_as_untransferable( ^ ../src/js_native_api_v8.h:42:27: note: overridden virtual function is here virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable( PR-URL: https://github.com/nodejs/node/pull/30549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Guy Bedford

commit sha f0b2d875d96d942d6d22612986dceb225317fede

module: 12.x self resolve flag as experimental modules PR-URL: https://github.com/nodejs/node/pull/31757 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 43d02e20e0f37c3494cdf950fb9586f911df3d39

src: keep main-thread Isolate attached to platform during Dispose This works around a situation in which the V8 WASM code calls into the platform while the Isolate is being disposed. This goes against the V8 API constract for `v8::Platform`. In lieu of a proper fix, it should be okay to keep the Isolate registered; the race condition fixed by 25447d82d cannot occur for the `NodeMainInstance`’s Isolate, as it is the last one to exit in any given Node.js process. This partially reverts 25447d82d. Refs: https://github.com/nodejs/node/pull/30909 Refs: https://github.com/nodejs/node/issues/31752 PR-URL: https://github.com/nodejs/node/pull/31795 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Myles Borins

commit sha 6d432994e6c3d92c9f137f54728c45bef597e93f

Revert "build: warn upon --use-largepages config option" This reverts commit f5cd6d73fdf8e56954214fd57933df37b5168c54. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha 3d5beebc62d444145b2a2436ba53e998a149b9d7

Revert "src: make large_pages node.cc include conditional" This reverts commit 5e232f5de92c2340536a5065782cad57e8fe64fb. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha a53eeca2a9c7cb009f9ea3524250064db20c31c9

Revert "build: switch realpath to pwd" This reverts commit dea40f8c522d60b96665a1681bd4f6863a6e9f19. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha 7a1b0ac06fa06c74ca20972e21c315b58e34d618

Revert "build: re-introduce --use-largepages as no-op" This reverts commit 5fcf542faa08e6f59428d60dbd385595597bcda8. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha 065a32f064ac8927e4fcdee28ecb2b64370a4a6d

Revert "src: make --use-largepages a runtime option" This reverts commit fcbd2d245ac917785cb59ff51e0f599a7886df6b. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

legendecas

commit sha 51fdd759b928ad6dbc41963d1a3a47b042e594b4

async_hooks: ensure event after been emitted on runInAsyncScope The exception handler user-defined will not automatically emit after for the async resource. Also removes a duplicated case `test-emit-after-uncaught-exception-runInAsyncScope.js` which is identical to test-emit-after-uncaught-exception.js. Refs: https://github.com/nodejs/node/pull/30965 PR-URL: https://github.com/nodejs/node/pull/31784 Fixes: https://github.com/nodejs/node/issues/31783 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Myles Borins

commit sha a5bc00af12c73ca5086578a995a2157503d67f0e

Revert "events: allow monitoring error events" This reverts commit 5cb0de948dde157f007a1bbbd9337859112a5b0f.

view details

Anna Henningsen

commit sha 42b68a4e243c863172e31f75222fbee89509c4ec

src: inform callback scopes about exceptions in HTTP parser Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61 Refs: https://github.com/nodejs/node/pull/30236 Fixes: https://github.com/nodejs/node/issues/31796 PR-URL: https://github.com/nodejs/node/pull/31801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Myles Borins

commit sha d3fb1680dccdf374c99e588d2fbe855e14da4b95

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

Myles Borins

commit sha 6b7be0f029067ddbbfffe873d71030e312df9bf9

Working on v12.16.2 PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 7 days

push eventnodejs/node

Myles Borins

commit sha d3fb1680dccdf374c99e588d2fbe855e14da4b95

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

Myles Borins

commit sha 6b7be0f029067ddbbfffe873d71030e312df9bf9

Working on v12.16.2 PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 7 days

created tagnodejs/node

tagv12.16.1

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

created time in 7 days

push eventnodejs/node

Myles Borins

commit sha 5263cc40be3ad3a0b27605e77996daa6f49bb31a

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release Accidental Unflagging of Self Resolving Modules: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. Process Cleanup Changed Introduced WASM-Related Assertion: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. Use Largepages Runtime Option Introduced Linking Failure: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. Async Hooks was Causing an Exception When Handling Errors: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re-land in a future Semver-Patch release if the regression is reliably fixed. New Enumerable Read-Only Property on EventEmitter breaks @types/extend: A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re-land in a future Semver-Minor release if a non breaking way of applying it is found. Exceptions in the HTTP parser were not emitting an uncaughtException: A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by process.on('uncaughtException') when the `async_hooks` `after` hook exists. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 8 days

push eventnodejs/node

Myles Borins

commit sha 25c179b8bf52b0181c726e53564594a91a957a07

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re-land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re-land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')` when the `async_hooks` `after` hook exists. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 8 days

push eventnodejs/node

Myles Borins

commit sha 79dc7e4fce622e6399f3f6848fa3a3741bdaf461

Update doc/changelogs/CHANGELOG_V12.md Co-Authored-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 8 days

issue closednodejs/Release

ESM issue on 12.x requires a quick 12.16.1

Hey All. It turns out the backporting of ESM to 12.x introduced a regression, specifically the "self resolution" feature is working without a flag, which is not intentional.

https://github.com/nodejs/node/issues/31754

I want to get a 12.16.1 out today if possible to fix this one problem. Any conerns?

/cc @nodejs/lts @nodejs/tsc

closed time in 8 days

MylesBorins

pull request commentnodejs/node

v12.16.1 proposal

Hey all. I've done another pass on this. There are 4 changes that have been reverted and 2 that have had patches landed to fix the bugs that were introduced. I did my best to document what happened in the notable changes section as well as how these changes can be re-landed.

We can still make other changes to this before we push it out tomorrow, but I could really use support here as I have limited time to actually do the release.

Apologies in advance for the pace of these reversions and how this release was handled, doing my best to handle in a timely fashion while traveling and being off (today is a vacation day for US).

As mentioned above a broader post-mortem here would be very useful including discussion on how we handle regressions. We should likely schedule this for the next release WG meeting

MylesBorins

comment created time in 8 days

push eventnodejs/node

Myles Borins

commit sha d3fb1680dccdf374c99e588d2fbe855e14da4b95

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 8 days

push eventnodejs/node

Myles Borins

commit sha 1990e087121552f8e5c3c05a1033d9664596c55a

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 8 days

push eventnodejs/node

Myles Borins

commit sha 9d6021ade18337b05257f1f0bc330e332f4ee8d3

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 8 days

push eventnodejs/node

Myles Borins

commit sha a5bc00af12c73ca5086578a995a2157503d67f0e

Revert "events: allow monitoring error events" This reverts commit 5cb0de948dde157f007a1bbbd9337859112a5b0f.

view details

Anna Henningsen

commit sha 42b68a4e243c863172e31f75222fbee89509c4ec

src: inform callback scopes about exceptions in HTTP parser Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61 Refs: https://github.com/nodejs/node/pull/30236 Fixes: https://github.com/nodejs/node/issues/31796 PR-URL: https://github.com/nodejs/node/pull/31801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Myles Borins

commit sha a70772f1b9ae438ddad66b948061280a9188acfc

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 8 days

pull request commentnodejs/node

src: remove AsyncScope, AsyncCallbackScope, RunNextTicksNative

As the fix is straightforward and has landed on master I've backported to 12.x and rebased out the revert.

addaleax

comment created time in 8 days

pull request commentnodejs/node

v13.9.0 proposal

If possible could we please include https://github.com/nodejs/node/pull/31801 and https://github.com/nodejs/node/pull/30965 included in this release

codebytere

comment created time in 8 days

push eventnodejs/node

Myles Borins

commit sha a5bc00af12c73ca5086578a995a2157503d67f0e

Revert "events: allow monitoring error events" This reverts commit 5cb0de948dde157f007a1bbbd9337859112a5b0f.

view details

Anna Henningsen

commit sha 42b68a4e243c863172e31f75222fbee89509c4ec

src: inform callback scopes about exceptions in HTTP parser Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61 Refs: https://github.com/nodejs/node/pull/30236 Fixes: https://github.com/nodejs/node/issues/31796 PR-URL: https://github.com/nodejs/node/pull/31801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in 8 days

push eventnodejs/node

Myles Borins

commit sha d61341ca31b299d2ee33e1df65f3b6347b6d2431

Revert "src: remove AsyncScope and AsyncCallbackScope" This reverts commit 08e55e302bb39bf491e0f71619d494f62b24428e.

view details

Myles Borins

commit sha 828377833666655adcc818bf25fd3e0daae8af4c

Revert "src: use callback scope for main script" This reverts commit ce13d438193179d1374b6c3d33d32aa81d0048c5.

view details

Myles Borins

commit sha bd05befea94f831f3ac0ca4a99231c9b63498d0d

Revert "events: allow monitoring error events" This reverts commit 5cb0de948dde157f007a1bbbd9337859112a5b0f.

view details

push time in 8 days

pull request commentnodejs/node

events: allow monitoring error events

I've reverted this from the 12.x as it created unexpected ecosystem breakages as documented above. I've added a backport requested label and this can be revisited for the next Semver-Minor release. Perhaps we could land this with some changes for 12.x as mentioned above such as making the property non-enumerable or making it an accessor in stead of a data property. Either way this should get decided on master / 13.x or in a backport PR imho.

Flarna

comment created time in 8 days

pull request commentnodejs/node

src: remove AsyncScope, AsyncCallbackScope, RunNextTicksNative

I've reverted this from the 12.x release branch as there were regressions found in https://github.com/nodejs/node/issues/31796

This will require https://github.com/nodejs/node/pull/31801 to fix the bug, this should be manually backported to include that commit once it has gone out in a 13.x release

/cc @addaleax

addaleax

comment created time in 8 days

issue closednodejs/node

conditional exports show an unexpected warning message, even though no longer behind flag

  • Version: Node v13.8.0
  • Platform: Mac OSX

What steps will reproduce the bug?

$ node --version
v13.8.0
$ npm install es-module-lexer@0.3.16
$ node -e "require('es-module-lexer')"
(node:75146) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time

How often does it reproduce? Is there a required condition?

Always on latest Node v13

What is the expected behavior?

I wouldn't expect to see any warning whatsoever.

Additional information

https://nodejs.org/api/esm.html#esm_conditional_exports

This documentation exists without any sort of experimental warning. It is not hidden behind any flag.

More confusing to users, It is a warning that is exposed by the libraries that they consume. So the user can update their dependencies (or add new ones) and start to get this warning without understanding why.

For Snowpack, we want to use this package that uses conditional exports, but are now worried about this warning message confusing our users.

/cc @guybedford

closed time in 8 days

FredKSchott

issue commentnodejs/node

conditional exports show an unexpected warning message, even though no longer behind flag

Closing as it seems like the question was answered

We have an ongoing discussion about warnings in https://github.com/nodejs/modules/issues/485 please feel free to chime in there if you have any specific comments about how we can improve things

FredKSchott

comment created time in 8 days

pull request commentnodejs/node

v12.16.1 proposal

@gabrielschulhof tbh I'm uncomfortable with backporting that change since it hasn't gone into a 13.x release yet. If there is a strong reason to push this change forward now instead of in April I'm open to discussing, but it feels like the feature was immaturely backported, especially since there were open issues that had not yet been resolved on master / 13.x.

FWIW I recognize that we did include https://github.com/nodejs/node/pull/31781/commits/51fdd759b928ad6dbc41963d1a3a47b042e594b4 prior to it going out on 13.x. My understanding is that this change was a partial revert rather than a full revert and fixes a known issue. Pointing this out to show that we can indeed be flexible here... but I am more concerned about the large pages change tbqh.

MylesBorins

comment created time in 8 days

pull request commentnodejs/node

12.x reverts

@jasnell the choice to revert was exactly because other lines were also affected. There were no fixes added here, but rather reverting the changes that introduced the regressions before the fixes landed on 13.x and master in order to respect the LTS policy. Even if it "reintroduced" regressions that were fixed by the change, that behavior is at least what is currently expected on LTS.

@bnoordhuis to the best of my knowledge, and how I've personally been working for years, the 48 hour rule does not apply to release branches. The release branches are maintained by the release / LTS team and have their own rules that govern them. In the case of this reversion PR there was an attempt to get a fix out within 24 hours of recognizing that there were regressions on 12.x. If the 48 hour rule applied it wouldn't be possible to do quick releases and imho there would be significant friction introduced to the general process. The reason to open this PR is for quick sign off as well as auditability.

FWIW, if you would like to discuss changes to current process or think it would be beneficial to revisit the existing process I think it is totally worth doing so. Opening an issue in the release repo would be a good way to move forward.

MylesBorins

comment created time in 8 days

pull request commentnodejs/node

v12.16.1 proposal

Seeing that there is another regression I think it would be prudent to delay until next Tuesday in case anything else bubbles up.

Tbh this is the most regressions that have surfaced in an LTS in a while, I think it would be good for us separately to do a post mortem on this and figure out what's up and if there are ways to avoid this happening again.

MylesBorins

comment created time in 11 days

pull request commentnodejs/node

v12.16.1 proposal

Release CI is looking good. It is just finishing up the AIX builds. Looks like the centos7 failure is the only consistent failure right now, this is new and as mentioned above appears to be infrastructure related. I've opened a bug on the build repo to track it.

I'm about to board a plane and will hopefully get this release out in the next hour or so. If I go radio silent and someone else has time to do the promotion / signing please feel free to step in.

MylesBorins

comment created time in 11 days

issue openedstefanpenner/promise.hash.helper

Latest published version to npm is missing source

Only seeing a package.json and README.md. This is breaking ember-cli in CITGM (node.js smoke test).

To reproduce

$ npm pack promise.hash.helper && tar -zxf promise.hash.helper-1.0.3.tgz && ls package/

created time in 11 days

pull request commentnodejs/node

v12.16.1 proposal

Hey All,

The release is prepped and ready to go, but we seem to be having some consistent CI failures. The do look suspiciously like infra issues. I've kicked off one last CI and fingers crossed it is green this time. If we still have consistent issues I think it might make sense to punt this release to next week so we can do more research as to avoid additional release noise.

Thoughts?

MylesBorins

comment created time in 11 days

issue openednodejs/build

Centos 7 socket hang up multiple times on 12.16.1 release

My gut is that this is an infra issue, but it does only appear to be happening with the 12.16.2 release right now :(

https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/32867/console https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/32868/console https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/32869/console

10:43:47 Error: socket hang up
10:43:47     at connResetException (internal/errors.js:604:14)
10:43:47     at TLSSocket.socketCloseListener (_http_client.js:400:25)
10:43:47     at TLSSocket.emit (events.js:333:22)
10:43:47     at net.js:668:12
10:43:47     at TCP.done (_tls_wrap.js:556:7) {
10:43:47   code: 'ECONNRESET'
10:43:47 }

created time in 11 days

push eventnodejs/node

Myles Borins

commit sha 63414180f410e5bdd8ebfd5de4ea23b21c611850

2020-02-14, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 3 regressions that are being fixed in this release Accidental Unflagging of Self Resolving Modules: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. Process Cleanup Changed Introduced WASM-Related Assertion A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. Use Largepages Runtime Option Introduced Linking Failure: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to re-land with a fix in a future Semver-Minor release. Async Hooks was Causing an Exception When Handling Errors: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 11 days

push eventnodejs/node

Anna Henningsen

commit sha 43d02e20e0f37c3494cdf950fb9586f911df3d39

src: keep main-thread Isolate attached to platform during Dispose This works around a situation in which the V8 WASM code calls into the platform while the Isolate is being disposed. This goes against the V8 API constract for `v8::Platform`. In lieu of a proper fix, it should be okay to keep the Isolate registered; the race condition fixed by 25447d82d cannot occur for the `NodeMainInstance`’s Isolate, as it is the last one to exit in any given Node.js process. This partially reverts 25447d82d. Refs: https://github.com/nodejs/node/pull/30909 Refs: https://github.com/nodejs/node/issues/31752 PR-URL: https://github.com/nodejs/node/pull/31795 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Myles Borins

commit sha 6d432994e6c3d92c9f137f54728c45bef597e93f

Revert "build: warn upon --use-largepages config option" This reverts commit f5cd6d73fdf8e56954214fd57933df37b5168c54. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha 3d5beebc62d444145b2a2436ba53e998a149b9d7

Revert "src: make large_pages node.cc include conditional" This reverts commit 5e232f5de92c2340536a5065782cad57e8fe64fb. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha a53eeca2a9c7cb009f9ea3524250064db20c31c9

Revert "build: switch realpath to pwd" This reverts commit dea40f8c522d60b96665a1681bd4f6863a6e9f19. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha 7a1b0ac06fa06c74ca20972e21c315b58e34d618

Revert "build: re-introduce --use-largepages as no-op" This reverts commit 5fcf542faa08e6f59428d60dbd385595597bcda8. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Myles Borins

commit sha 065a32f064ac8927e4fcdee28ecb2b64370a4a6d

Revert "src: make --use-largepages a runtime option" This reverts commit fcbd2d245ac917785cb59ff51e0f599a7886df6b. PR-URL: https://github.com/nodejs/node/pull/31782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

legendecas

commit sha 51fdd759b928ad6dbc41963d1a3a47b042e594b4

async_hooks: ensure event after been emitted on runInAsyncScope The exception handler user-defined will not automatically emit after for the async resource. Also removes a duplicated case `test-emit-after-uncaught-exception-runInAsyncScope.js` which is identical to test-emit-after-uncaught-exception.js. Refs: https://github.com/nodejs/node/pull/30965 PR-URL: https://github.com/nodejs/node/pull/31784 Fixes: https://github.com/nodejs/node/issues/31783 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 11 days

push eventnodejs/node

Myles Borins

commit sha b0ec89943d68107ba940a0dacd30b29b443e5de1

2020-02-14, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 3 regressions that are being fixed in this release Accidental Unflagging of Self Resolving Modules: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. Process Cleanup Changed Introduced WASM-Related Assertion A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. Use Largepages Runtime Option Introduced Linking Failure: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to re-land with a fix in a future Semver-Minor release. Async Hooks was Causing an Exception When Handling Errors: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. A regression test and fix has been landed PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 11 days

pull request commentnodejs/node

v12.16.1 proposal

Hey all PTAL. There are a couple more reverts on here, it covers all of the bugs that were introduced that were reported in the last 48 hours. Will attempt to get this out tomorrow. I'm on a flight from 1pm PT until 9pm ish ET. If I go radio silent and don't push the release it will be because of no wifi. If someone else wants to push it please go for it. I try to avoid friday releases but I feel like there are enough regressions here that we really should just get it out.

MylesBorins

comment created time in 12 days

issue closednodejs/node

v10.x branch npm dep update

Would like to update npm dep to 6.13.7 (up from 6.13.4) on the LTS v10.x branch.

It was updated in master here: https://github.com/nodejs/node/pull/31558

@BethGriggs what is the process for this?

This will fix a macOS brew specific issue (in a hosted CI enviroment at Bitrise), when npm i -g npm@<other_npm_version> fails with permission issue:

npm ERR! code EEXIST
npm ERR! syscall symlink
npm ERR! path ../../../lib/node_modules/npm/man/man1/npm-access.1
npm ERR! dest /usr/local/share/man/man1/npm-access.1
npm ERR! errno -17
npm ERR! EEXIST: file already exists, symlink '../../../lib/node_modules/npm/man/man1/npm-access.1' -> '/usr/local/share/man/man1/npm-access.1'
npm ERR! File exists: /usr/local/share/man/man1/npm-access.1

closed time in 12 days

lpusok

issue commentnodejs/node

v10.x branch npm dep update

i backported the commits to upgrade npm to 6.13.7 on the 10.x-staging release line in c6c6665e1c...7eac95981e

It should be in the next 10.x release 🎉

lpusok

comment created time in 12 days

push eventnodejs/node

Ruy Adorno

commit sha db24641fbe4fc08e93e8619e9ad148cb98baee55

deps: upgrade npm to 6.13.6 PR-URL: https://github.com/nodejs/node/pull/31304 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Michael Perrotte

commit sha 7eac95981e099796037acae24db8db3899c125bd

deps: upgrade npm to 6.13.7 PR-URL: https://github.com/nodejs/node/pull/31558 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 12 days

push eventnodejs/node

Myles Borins

commit sha e07237ce9fea9a7bdc315018994334fe1055b934

Revert "async_hooks: ensure proper handling in runInAsyncScope" This reverts commit a9fad8524cb5db21fb70614561e0418f3a10199b.

view details

Myles Borins

commit sha e0ff0283901439e229e93f3db540634e76538dc6

2020-02-14, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 3 regressions that are being fixed in this release Accidental Unflagging of Self Resolving Modules: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. Isolate Disposal Order Change Introduced WASM Assertion: A change in the order of Isolate Disposal created an assertion error in WASM usage in V8. This was not present on 13.x or higher as they use a newer version of V8. The change was reverted. A regression test and fix are being worked on and will likely be included in a future 12.x release Use Largepages Runtime Option Introduced Linking Failure: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to re-land with a fix in a future Semver-Minor release. Async Hooks was Causing an Exception When Handling Errors: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. PR-URL: https://github.com/nodejs/node/pull/31781

view details

push time in 12 days

issue commentnodejs/node

async_hooks: AsyncResource.runInAsyncScope causes Node process to crash

I've reverted this change on v12.x

https://github.com/nodejs/node/commit/e07237ce9fea9a7bdc315018994334fe1055b934

We can close this once the fix in https://github.com/nodejs/node/issues/31783 lands on master

alexandervain

comment created time in 12 days

more