profile
viewpoint
Rich Trott Trott San Francisco, CA I create software, rock operas, and pizzas. I am a member of the Node.js Technical Steering Committee and work for the University of California. he/him

nlf/precommit-hook 482

An npm installable git pre-commit hook used to lint and test your code

davidmarkclements/v8-perf 248

Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1

inikulin/dmn 95

Janitor for your node_modules

nlf/git-validate 95

A module to help you create your own git hooks

Swaagie/stackexchange 46

Node.js implementation of the stackexchange/stackoverflow API

nodejs/core-validate-commit 36

Validate commit messages for Node.js core

nodejs/make-node-meeting 8

Generate a text for a GitHub issue announcing a Node.js working group meeting

nodejs/node.js.org 4

As a community service, redirecting node.js.org to nodejs.org.

nodejs/node-meeting-agenda 2

Generate an agenda for a Node.js working group based on GitHub issue labels

issue commentnodejs/node

CI is unusable

@rvagg @tniessen One of the known_issues tests is failing (that is, passing) pretty much constantly on Raspberry Pi devices. I don't know why that started but it's very recent, probably in the last 24 hours I'd say.

tniessen

comment created time in 8 hours

issue commentnodejs/build

Introduction: I'm John. How can I help?

I have nothing concrete to add, but want to comment anyway to say, OMG, welcome, hooray, can't wait to talk more at a meeting or something like that!

jkleinsc

comment created time in 8 hours

push eventTrott/io.js

Rich Trott

commit sha 838d6042a8e046f8cc9fa6833fd3f62a795b4636

Update test/common/README.md Co-Authored-By: Anna Henningsen <github@addaleax.net>

view details

push time in 8 hours

push eventjamesmacfie/nodejs.org

dependabot-preview[bot]

commit sha 48b5933b325488cc180367aed6f67b24d9924243

build(deps-dev): bump vnu-jar from 20.1.2 to 20.2.25 (#2982) Bumps [vnu-jar](https://github.com/validator/validator) from 20.1.2 to 20.2.25. - [Release notes](https://github.com/validator/validator/releases) - [Changelog](https://github.com/validator/validator/blob/master/CHANGELOG.md) - [Commits](https://github.com/validator/validator/compare/v20.1.2...v20.2.25) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Jesse Rosenberger

commit sha fde5e8b832102cde3d26b29d92a7a0c6ceabfe36

Add v12.x to the list of releases. (#2968) Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

dependabot-preview[bot]

commit sha 97875a072c7c4a6f384b4ffac00d01b57ba10b82

build(deps): bump sass from 1.25.0 to 1.26.0 (#2981) Bumps [sass](https://github.com/sass/dart-sass) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.25.0...1.26.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

Bruno Alassia

commit sha 3be8c5be536971a52e8c9cf908cdde08c4123799

fix: Spanish Translation issue from #2836 Co-authored-by: Nick Schonning <nschonni@gmail.com>

view details

Rich Trott

commit sha f5556b700da6877b619dea0cdd1d15ac02076968

Merge branch 'master' into patch-1

view details

push time in 8 hours

push eventucsf-ckm/ucsf-history-website

Rich Trott

commit sha 86b69684b4b76b1027f8067f8b4e7080be8c5329

add 150w.html It's a prototype, not even valid HTML right now, but just to get some quick feedback, here it is.

view details

Rich Trott

commit sha eca2c83daadd6a3ab1c0e596e36b471be83dde31

Merge pull request #57 from ucsf-ckm/150w add 150w.html

view details

push time in 11 hours

PR merged ucsf-ckm/ucsf-history-website

add 150w.html

It's a prototype, not even valid HTML right now, but just to get some quick feedback, here it is.

+86 -0

0 comment

1 changed file

Trott

pr closed time in 11 hours

PR opened ucsf-ckm/ucsf-history-website

add 150w.html

It's a prototype, not even valid HTML right now, but just to get some quick feedback, here it is.

+86 -0

0 comment

1 changed file

pr created time in 11 hours

create barnchucsf-ckm/ucsf-history-website

branch : 150w

created branch time in 11 hours

push eventucsf-ckm/ucsf-history-website

push time in 11 hours

push eventucsf-ckm/ucsf-history-website

Rich Trott

commit sha 86b69684b4b76b1027f8067f8b4e7080be8c5329

add 150w.html It's a prototype, not even valid HTML right now, but just to get some quick feedback, here it is.

view details

push time in 11 hours

issue commentnodejs/nodejs.org

Language toggler code fails on 404 pages

Oh, wait, I see.

Looks like it's not failing on the live server anymore either. Weird.....

Oh, it only fails if you leave out the locale (e.g., en) in the URL.

Trott

comment created time in 13 hours

issue commentnodejs/nodejs.org

Language toggler code fails on 404 pages

The thing is that I cannot find a way to get the a 404 page locally to reproduce the issue.

Looks like it's not failing on the live server anymore either. Weird.....

Trott

comment created time in 13 hours

push eventTrott/new.nodejs.org

Luigi Pinca

commit sha 375bf7eb0b8a5650c8b902bdb35cd9d9051cb493

disable the banner

view details

dependabot-preview[bot]

commit sha 48b5933b325488cc180367aed6f67b24d9924243

build(deps-dev): bump vnu-jar from 20.1.2 to 20.2.25 (#2982) Bumps [vnu-jar](https://github.com/validator/validator) from 20.1.2 to 20.2.25. - [Release notes](https://github.com/validator/validator/releases) - [Changelog](https://github.com/validator/validator/blob/master/CHANGELOG.md) - [Commits](https://github.com/validator/validator/compare/v20.1.2...v20.2.25) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Jesse Rosenberger

commit sha fde5e8b832102cde3d26b29d92a7a0c6ceabfe36

Add v12.x to the list of releases. (#2968) Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

dependabot-preview[bot]

commit sha 97875a072c7c4a6f384b4ffac00d01b57ba10b82

build(deps): bump sass from 1.25.0 to 1.26.0 (#2981) Bumps [sass](https://github.com/sass/dart-sass) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.25.0...1.26.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

Bruno Alassia

commit sha 3be8c5be536971a52e8c9cf908cdde08c4123799

fix: Spanish Translation issue from #2836 Co-authored-by: Nick Schonning <nschonni@gmail.com>

view details

push time in 14 hours

push eventTrott/missionjs.com

dependabot[bot]

commit sha c93171871c1fa67882b1ea0ede2e94f3fbef261c

Bump rubyzip from 1.2.2 to 2.2.0 Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.2 to 2.2.0. - [Release notes](https://github.com/rubyzip/rubyzip/releases) - [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md) - [Commits](https://github.com/rubyzip/rubyzip/compare/v1.2.2...v2.2.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Rich Trott

commit sha 19a009c3c77ab0e950ed869bb8f49b64c5f1c22e

Merge pull request #7 from Trott/dependabot/bundler/rubyzip-2.2.0 Bump rubyzip from 1.2.2 to 2.2.0

view details

push time in 14 hours

PR merged Trott/missionjs.com

Bump rubyzip from 1.2.2 to 2.2.0 dependencies

Bumps rubyzip from 1.2.2 to 2.2.0. <details> <summary>Release notes</summary>

Sourced from rubyzip's releases.

v2.2.0

  • Add support for decompression plugin gems #427

v2.1.0

  • Fix (at least partially) the restore_times and restore_permissions options to Zip::File.new #413
    • Previously, neither option did anything, regardless of what it was set to. We have therefore defaulted them to false to preserve the current behavior, for the time being. If you have explicitly set either to true, it will now have an effect.
    • Fix handling of UniversalTime (mtime, atime, ctime) fields. #421
    • Previously, Zip::File did not pass the options to Zip::Entry in some cases. #423
    • Note that restore_times in this release does nothing on Windows and only restores mtime, not atime or ctime.
  • Allow Zip::File.open to take an options hash like Zip::File.new #418
  • Always print warnings with warn, instead of a mix of puts and warn #416
  • Create temporary files in the system temporary directory instead of the directory of the zip file #411
  • Drop unused tmpdir requirement #411

Tooling

  • Move CI to xenial and include jruby on JDK11 #419

v2.0.0

Security

  • Default the validate_entry_sizes option to true, so that callers can trust an entry's reported size when using extract #403
    • This option defaulted to false in 1.3.0 for backward compatibility, but it now defaults to true. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to true.

Tooling / Documentation

  • Remove test files from the gem to avoid problems with antivirus detections on the test files #405 / #384
  • Drop support for unsupported ruby versions #406

v1.3.0

Security

  • Add validate_entry_sizes option so that callers can trust an entry's reported size when using extract #403
    • This option defaults to false for backward compatibility in this release, but you are strongly encouraged to set it to true. It will default to true in rubyzip 2.0.

New Feature

  • Add add_stored method to simplify adding entries without compression #366

Tooling / Documentation

  • Add more gem metadata links #402

v1.2.4

  • Do not rewrite zip files opened with open_buffer that have not changed #360

Tooling / Documentation

  • Update example_recursive.rb in README #397
  • Hold CI at trusty for now, automatically pick the latest ruby patch version, use rbx-4 and hold jruby at 9.1 #399 </tr></table> ... (truncated) </details> <details> <summary>Changelog</summary>

Sourced from rubyzip's changelog.

2.2.0 (2020-02-01)

  • Add support for decompression plugin gems #427

2.1.0 (2020-01-25)

  • Fix (at least partially) the restore_times and restore_permissions options to Zip::File.new #413
    • Previously, neither option did anything, regardless of what it was set to. We have therefore defaulted them to false to preserve the current behavior, for the time being. If you have explicitly set either to true, it will now have an effect.
    • Fix handling of UniversalTime (mtime, atime, ctime) fields. #421
    • Previously, Zip::File did not pass the options to Zip::Entry in some cases. #423
    • Note that restore_times in this release does nothing on Windows and only restores mtime, not atime or ctime.
  • Allow Zip::File.open to take an options hash like Zip::File.new #418
  • Always print warnings with warn, instead of a mix of puts and warn #416
  • Create temporary files in the system temporary directory instead of the directory of the zip file #411
  • Drop unused tmpdir requirement #411

Tooling

  • Move CI to xenial and include jruby on JDK11 #419

2.0.0 (2019-09-25)

Security

  • Default the validate_entry_sizes option to true, so that callers can trust an entry's reported size when using extract #403
    • This option defaulted to false in 1.3.0 for backward compatibility, but it now defaults to true. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to true.

Tooling / Documentation

  • Remove test files from the gem to avoid problems with antivirus detections on the test files #405 / #384
  • Drop support for unsupported ruby versions #406

1.3.0 (2019-09-25)

Security

  • Add validate_entry_sizes option so that callers can trust an entry's reported size when using extract #403
    • This option defaults to false for backward compatibility in this release, but you are strongly encouraged to set it to true. It will default to true in rubyzip 2.0.

New Feature

  • Add add_stored method to simplify adding entries without compression #366

Tooling / Documentation

  • Add more gem metadata links #402

1.2.4 (2019-09-06)

  • Do not rewrite zip files opened with open_buffer that have not changed #360 </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • ecd641e Merge pull request #429 from rubyzip/v2-2-0
  • f42827e Bump version to 2.2.0
  • 040962a Remove unused error argument
  • 666fb8c Merge pull request #427 from jspanjers/refactor-decompressor
  • 0b9433c Add test for unsupported decompression, e.g bzip2
  • a5d068d Support Decompressor plugins
  • 2b72683 Define compression methods
  • 456bd4d Mimic IO#read return values in Decompressor#read
  • c66277d Rename Decompressor#sysread to #read
  • 00b525d Fix returned outbuf for Inflater#sysread
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 14 hours

push eventTrott/missionjs.com

dependabot[bot]

commit sha bd64e31acc62f9ae8ebade48afe679c1d04bb77a

Bump nokogiri from 1.10.4 to 1.10.8 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.10.4...v1.10.8) Signed-off-by: dependabot[bot] <support@github.com>

view details

Rich Trott

commit sha 442aa2cb3abc30aec34bdb98f45184209f82d07d

Merge pull request #6 from Trott/dependabot/bundler/nokogiri-1.10.8 Bump nokogiri from 1.10.4 to 1.10.8

view details

push time in 14 hours

PR merged Trott/missionjs.com

Bump nokogiri from 1.10.4 to 1.10.8 dependencies

Bumps nokogiri from 1.10.4 to 1.10.8. <details> <summary>Release notes</summary>

Sourced from nokogiri's releases.

1.10.8 / 2020-02-10

Security

[MRI] Pulled in upstream patch from libxml that addresses CVE-2020-7595. Full details are available in #1992. Note that this patch is not yet (as of 2020-02-10) in an upstream release of libxml.

1.10.7 / 2019-12-03

Bug

  • [MRI] Ensure the patch applied in v1.10.6 works with GNU patch. #1954

1.10.6 / 2019-12-03

Bug

  • [MRI] Fix FreeBSD installation of vendored libxml2. [#1941, #1953] (Thanks, @​nurse!)

1.10.5 / 2019-10-31

Dependencies

  • [MRI] vendored libxml2 is updated from 2.9.9 to 2.9.10
  • [MRI] vendored libxslt is updated from 1.1.33 to 1.1.34

</details> <details> <summary>Changelog</summary>

Sourced from nokogiri's changelog.

1.10.8 / 2020-02-10

Security

[MRI] Pulled in upstream patch from libxml that addresses CVE-2020-7595. Full details are available in #1992. Note that this patch is not yet (as of 2020-02-10) in an upstream release of libxml.

1.10.7 / 2019-12-03

Fixed

  • [MRI] Ensure the patch applied in v1.10.6 works with GNU patch. [#1954]

1.10.6 / 2019-12-03

Fixed

1.10.5 / 2019-10-31

Security

[MRI] Vendored libxslt upgraded to v1.1.34 which addresses three CVEs for libxslt:

  • CVE-2019-13117
  • CVE-2019-13118
  • CVE-2019-18197
  • CVE-2019-19956

More details are available at #1943.

Dependencies

  • [MRI] vendored libxml2 is updated from 2.9.9 to 2.9.10
  • [MRI] vendored libxslt is updated from 1.1.33 to 1.1.34 </details> <details> <summary>Commits</summary>
  • 6ce10d1 version bump to v1.10.8
  • 2320f5b update CHANGELOG for v1.10.8
  • 4a77fdb remove patches from the hoe Manifest
  • 570b6cb update to use rake-compiler ~1.1.0
  • 2cdb68e backport libxml2 patch for CVE-2020-7595
  • e6b3229 version bump to v1.10.7
  • 4f9d443 update CHANGELOG
  • 80e67ef Fix the patch from #1953 to work with both git and patch
  • 7cf1b85 Fix typo in generated metadata
  • d76180d add gem metadata
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 14 hours

delete branch Trott/io.js

delete branch : v

delete time in 14 hours

push eventTrott/io.js

Robert Nagy

commit sha db28739aed31b2ad6e85c497e3a836a29d13021c

stream: fix broken pipeline error propagation If the destination was an async function any error thrown from that function would be swallowed. PR-URL: https://github.com/nodejs/node/pull/31835 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Eric Eastwood

commit sha be2f3a3bf88fd728799d1917f7d82428f53183f0

doc: update assert.rejects() docs with a validation function example Spawned from my own struggle to use in https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1702#note_268452483 PR-URL: https://github.com/nodejs/node/pull/31271 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 2035e3d6cb3071dfbe142f8351cde3d883626a38

src: move BaseObject subclass dtors/ctors out of node_crypto.h Originally landed in the QUIC repo Move constructor and destructors for subclasses of `BaseObject` from node_crypto.h to node_crypto.cc. This removes the need to include base_object-inl.h when using node_crypto.h in some cases. Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/220 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: https://github.com/nodejs/node/pull/31872 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Anna Henningsen

commit sha e68d4c6f5f6086c2816ed6d870e23e824c661f92

src: allow unique_ptrs with custom deleter in memory tracker Originally landed in the QUIC repo Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: https://github.com/nodejs/node/pull/31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

James M Snell

commit sha d3715c76b5c287d900d28f472da0186322ace811

http: move OutboundMessage.prototype.flush to EOL API was deprecated long ago. Move to end of life and remove. PR-URL: https://github.com/nodejs/node/pull/31164 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Myles Borins

commit sha 021542080a020d1d67fa47e25338973b78d543e6

doc: update releases guide re pushing tags Currently we specify pushing the tag before updating any of the branches. This creates a potential of creating and pushing a tag on an out of sync branch, and only really when attempting to merge the release commit that things have gone out of sync. Changing the order here would minimize the possibility of this error PR-URL: https://github.com/nodejs/node/pull/31855 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Harshitha KP

commit sha b70dd9d662aaf3e652219e65d8e51762842d8b80

src: elevate v8 namespaces PR-URL: https://github.com/nodejs/node/pull/31901 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Sam Roberts

commit sha 5f0181a079f4dd328fb01a75daff0a128c33fc70

deps: move zlib maintenance info to guides deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Sam Roberts

commit sha 0d95eda4996e5e895b80cd68052332a102de9fd3

doc: describe how to update zlib See: - https://github.com/nodejs/node/pull/31201 PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Sam Roberts

commit sha 9a1719b541b53eae844d801a74a8b6328ad1c9fd

deps: update zlib to upstream d7f3ca9 Updated as described in doc/guides/maintaining-zlib.md. PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Gabriel Schulhof

commit sha 0dff851336ea2a3801667e5390d5821db746baae

src: include large pages source unconditionally Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. PR-URL: https://github.com/nodejs/node/pull/31904 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Daniel Bevenius

commit sha 940325042bef787e84917a27f9435d423b3f7f6d

test: add secp224k1 check in crypto-dh-stateless This commit adds a check to test-crypto-dh-statless to avoid an error if the curve secp224k1 is not present. This could occur if node was configured with shared-openssl. The use case for this was building on RHEL 8.1 which only has the following curves: $ openssl ecparam -list_curves secp224r1 : NIST/SECG curve over a 224 bit prime field secp256k1 : SECG curve over a 256 bit prime field secp384r1 : NIST/SECG curve over a 384 bit prime field secp521r1 : NIST/SECG curve over a 521 bit prime field prime256v1: X9.62/SECG curve over a 256 bit prime field PR-URL: https://github.com/nodejs/node/pull/31715 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 1f209129c7e6c3ec6628809821fc9a36deae7ec8

stream: throw invalid argument errors Logic errors that do not depend on stream state should throw instead of invoke callback and emit error. PR-URL: https://github.com/nodejs/node/pull/31831 Refs: https://github.com/nodejs/node/pull/31818 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha 914d800a23f1c7877770d62bd4061957c402c8ca

tools: add NODE_TEST_NO_INTERNET to the doc builder At the moment the doc builder tries to access the internet for CHANGELOG information and only falls back to local sources after the connection fails or a 5 second timeout. This means that the doc building could take at least 7 minutes on a machine with hijacked connection to Github for useless network attempts. This patch adds a NODE_TEST_NO_INTERNET environment variable to directly bypass these attempts so that docs can be built in reasonable time on a machine like that. PR-URL: https://github.com/nodejs/node/pull/31849 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 24aa9bda4636741e52002c9e9cbf5e0042349b8d

doc: updated YAML version representation in readline.md All other versions in YAML throughout the docs start with _v_. Fix two cases in `readline.md` that did not. PR-URL: https://github.com/nodejs/node/pull/31924 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 14 hours

PR closed nodejs/node

doc: updated YAML version representation in readline.md author ready doc readline

All other versions in YAML throughout the docs start with v. Fix two cases in readline.md that did not.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+0 -0

1 comment

0 changed file

Trott

pr closed time in 14 hours

push eventTrott/io.js

Rich Trott

commit sha 24aa9bda4636741e52002c9e9cbf5e0042349b8d

doc: updated YAML version representation in readline.md All other versions in YAML throughout the docs start with _v_. Fix two cases in `readline.md` that did not. PR-URL: https://github.com/nodejs/node/pull/31924 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 14 hours

push eventnodejs/node

Rich Trott

commit sha 24aa9bda4636741e52002c9e9cbf5e0042349b8d

doc: updated YAML version representation in readline.md All other versions in YAML throughout the docs start with _v_. Fix two cases in `readline.md` that did not. PR-URL: https://github.com/nodejs/node/pull/31924 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 14 hours

pull request commentnodejs/node

doc: updated YAML version representation in readline.md

Landed in 24aa9bda4636

Trott

comment created time in 14 hours

push eventTrott/new.nodejs.org

dependabot-preview[bot]

commit sha 48b5933b325488cc180367aed6f67b24d9924243

build(deps-dev): bump vnu-jar from 20.1.2 to 20.2.25 (#2982) Bumps [vnu-jar](https://github.com/validator/validator) from 20.1.2 to 20.2.25. - [Release notes](https://github.com/validator/validator/releases) - [Changelog](https://github.com/validator/validator/blob/master/CHANGELOG.md) - [Commits](https://github.com/validator/validator/compare/v20.1.2...v20.2.25) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Jesse Rosenberger

commit sha fde5e8b832102cde3d26b29d92a7a0c6ceabfe36

Add v12.x to the list of releases. (#2968) Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

dependabot-preview[bot]

commit sha 97875a072c7c4a6f384b4ffac00d01b57ba10b82

build(deps): bump sass from 1.25.0 to 1.26.0 (#2981) Bumps [sass](https://github.com/sass/dart-sass) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.25.0...1.26.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

Bruno Alassia

commit sha 3be8c5be536971a52e8c9cf908cdde08c4123799

fix: Spanish Translation issue from #2836 Co-authored-by: Nick Schonning <nschonni@gmail.com>

view details

Rich Trott

commit sha b4474c4c00b9416a7a3d56dec852a21c00efdb91

Merge branch 'master' into get-start

view details

push time in 14 hours

pull request commentnodejs/nodejs.org

feat: thanking contributor (#2632)

Issue for toggler code failure: https://github.com/nodejs/nodejs.org/issues/2984

KeziahMoselle

comment created time in 21 hours

issue openednodejs/nodejs.org

Language toggler code fails on 404 pages

  • URL: https://nodejs.org/fhqwhgads
  • Browser version: Chrome 79
  • Operating system: macOS Mojave

Language toggler JS code errors on 404 resulting in the thank-a-contributor feature never running, and possibly other issues. The toggler should fail gracefully on 404.

Uncaught TypeError: Cannot read property 'textContent' of null
    at main.js:20
    at main.js:35

Refs: https://github.com/nodejs/nodejs.org/pull/2635#issuecomment-590908375

@XhmikosR @tniessen

created time in 21 hours

pull request commentnodejs/node

test: Worker initialization failure test case

AIX failed in CI (and there may be others as CI isn't finished at the time of this writing) and sure enough it failed with the 1 != 0 message, so maybe we can make the error message more informative and then re-run.

HarshithaKP

comment created time in 21 hours

issue commentnodejs/build

suggestion: we enable the "stale" bot on nodejs/build

I'm +1 on at least trying this in the Build repo and seeing how it works for us.

sam-github

comment created time in 21 hours

issue closednodejs/TSC

Ability for website team to transfer issues to nodejs/help

Looks like only Write permissions are required now to allow members to transfer issues between repositories https://github.blog/changelog/2019-05-29-improvements-to-issue-transfer-permissions/ This would allow the occasional support issue that lands on nodejs/nodejs.org repo to transfer the issues to a better place rather than just closing them and asking them to open a new issue.

The TSC README indicates that that repo is delegated to Evangelism Working Group, but that repo is closed, so I'm opening the issue here.

closed time in 21 hours

nschonni

issue commentnodejs/TSC

Ability for website team to transfer issues to nodejs/help

Website team added to the help repo. (Sorry if that messes with anyone's notifications....)

nschonni

comment created time in 21 hours

issue closednodejs/node

Array.sort()

Does really return sorted returns a object with numbers as keys as strings?

Are you kidding? If this is official specification, there should be incompatible specification for server side scripting.

[Moderated/edited by @Trott to remove offensive characterization.]

closed time in a day

mnini

issue closednodejs/help

out of memory on simple graph structure...

class node {
    constructor() {
        this.giver = new giver(this)
        this.taker = new taker(this)
    }
    connecttaker(tnode) {
        this.giver.connecttaker(tnode) 
    }
    connectgiver(tnode) {
        this.taker.connectgiver(tnode) 
    }
}
class connection {
    constructor(tgiver, ttaker) {
        this.giver = tgiver
        this.taker = ttaker
        }
}
class giver {
    constructor(node) {
        this.node = node
        this.connections = []
    }
    connecttaker(ttaker) {
        this.connections.push(new connection(this, ttaker))
    }
}
class taker {
    constructor(node) {
        this.node = node
        this.connections = []
    }
    connectgiver(tgiver) {
        this.connections.push(new connection(tgiver, this))
    }
}
var nodes = []
var input = []
var layer
var n, i, ii
for(i = 0; i < 420; i++) {
    n = randomInt(1)
    input.push(n)
}
nodes.push(input)
function randomInt(up, down = 0) {
    return Math.round( ( Math.random() * (up - down) ) + down ) 
}

for(i = 1; i < 10; i++) {
    layer = []
    for(ii = 0; i < 10; ii++) {
        n = new node()
        for( iii = 0; iii < 10; iii++) {
            n.connectgiver(nodes[i-1][randomInt(nodes[i-1].lenght-1)])
        }
        layer.push(n)
    }
    nodes.push(layer)
}

console.log(nodes)

Allocates more than two gigabytes of ram, while it have just 1000 objects of connections and 100 nodes together...

I know there is workaround with array id's but I need to have every reference, therefore, I need to write really bad code trough name in object to work around this bug, if it doesn't get fixed.

I think, this code should create 10 layers of 10 nodes, of which each layer is registered as giver to later node and layer node have registered as taker... I don't really see error in code.

closed time in a day

mnini

Pull request review commentnodejs/nodejs.org

Update Docker example to use most recent LTS

 Here we will use the latest LTS (long term support) version `10` of `node` available from the [Docker Hub](https://hub.docker.com/):  ```docker-FROM node:10+FROM node:12

Need to change line 83 as well.

jamesmacfie

comment created time in a day

pull request commentnodejs/node

test: Worker initialization failure test case

Locally, this test is failing for me. The error message I'm getting is EMFILE: too many open files, uv_cwd and not Worker initialization failure: EMFILE.

HarshithaKP

comment created time in a day

Pull request review commentnodejs/node

test: Worker initialization failure test case

+'use strict';+const common = require('../common');+const assert = require('assert');+const child_process = require('child_process');++// Test that workers fail with meaningful error message+// when their initialization fails.++if (common.isWindows) {+  common.skip('ulimit does not work on Windows.');+}++// A reasonably low fd count. An empty node process+// creates around 30 fds for its internal purposes,+// so making it too low will crash the process early,+// making it too high will cause too much resource use.+const OPENFILES = 128;++// Double the open files - so that some workers fail for sure.+const WORKERCOUNT = 256;++if (process.argv[2] === 'child') {+  const { Worker } = require('worker_threads');+  for (let i = 0; i < WORKERCOUNT; ++i) {+    const worker = new Worker(+      'require(\'worker_threads\').parentPort.postMessage(2 + 2)',+      { eval: true });+    worker.on('message', (result) => {+      assert.strictEqual(result, 4);+    });+    worker.on('error', (e) => {+      assert.match(e.message, /Worker initialization failure: EMFILE/);+      assert.strictEqual(e.code, 'ERR_WORKER_INIT_FAILED');+    });+  }++} else {+  // Limit the number of open files, to force workers to fail+  let testCmd = `ulimit -n ${OPENFILES} && `;++  testCmd += `${process.execPath} ${__filename} child`;+  const cp = child_process.exec(testCmd);++  let stdout = '';+  let stderr = '';++  cp.on('exit', common.mustCall((code, signal) => {+    assert.strictEqual(code, 0);

This will result in a frustrating error message on failure:

=== release test-worker-init-failure ===                   
Path: parallel/test-worker-init-failure
assert.js:102
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 0

    at ChildProcess.<anonymous> (/Users/trott/io.js/test/parallel/test-worker-init-failure.js:48:12)
    at ChildProcess.<anonymous> (/Users/trott/io.js/test/common/index.js:362:15)
    at ChildProcess.emit (events.js:321:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}
Command: out/Release/node /Users/trott/io.js/test/parallel/test-worker-init-failure.js

That tells me that it failed, but not why. To potentially provide a more helpful message, maybe something like this?:

    assert.strictEqual(code, 0, `\nSTDERR: ${stderr}\nSTDOUT: ${stdout}\n`);

(Or maybe easier, move lines 50-53 above this assertion?

HarshithaKP

comment created time in a day

Pull request review commentnodejs/node

test: Worker initialization failure test case

+'use strict';+const common = require('../common');+const assert = require('assert');+const child_process = require('child_process');++// Test that workers fail with meaningful error message+// when their initialization fails.++if (process.argv[2] === 'child') {+  const { Worker } = require('worker_threads');+  for (let i = 0; i < 256; ++i) {+    const worker = new Worker(+      'require(\'worker_threads\').parentPort.postMessage(2 + 2)',+      { eval: true });+    worker.on('message', (result) => {+      assert.strictEqual(result, 4);+    });+    worker.on('error', (e) => {+      assert(e.message.match(/Worker initialization failure: EMFILE/));

Looks like you added a check for the return code from the child process so I guess this particular problem is resolved.

HarshithaKP

comment created time in a day

push eventTrott/io.js

Daniel Bevenius

commit sha 940325042bef787e84917a27f9435d423b3f7f6d

test: add secp224k1 check in crypto-dh-stateless This commit adds a check to test-crypto-dh-statless to avoid an error if the curve secp224k1 is not present. This could occur if node was configured with shared-openssl. The use case for this was building on RHEL 8.1 which only has the following curves: $ openssl ecparam -list_curves secp224r1 : NIST/SECG curve over a 224 bit prime field secp256k1 : SECG curve over a 256 bit prime field secp384r1 : NIST/SECG curve over a 384 bit prime field secp521r1 : NIST/SECG curve over a 521 bit prime field prime256v1: X9.62/SECG curve over a 256 bit prime field PR-URL: https://github.com/nodejs/node/pull/31715 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 1f209129c7e6c3ec6628809821fc9a36deae7ec8

stream: throw invalid argument errors Logic errors that do not depend on stream state should throw instead of invoke callback and emit error. PR-URL: https://github.com/nodejs/node/pull/31831 Refs: https://github.com/nodejs/node/pull/31818 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha 914d800a23f1c7877770d62bd4061957c402c8ca

tools: add NODE_TEST_NO_INTERNET to the doc builder At the moment the doc builder tries to access the internet for CHANGELOG information and only falls back to local sources after the connection fails or a 5 second timeout. This means that the doc building could take at least 7 minutes on a machine with hijacked connection to Github for useless network attempts. This patch adds a NODE_TEST_NO_INTERNET environment variable to directly bypass these attempts so that docs can be built in reasonable time on a machine like that. PR-URL: https://github.com/nodejs/node/pull/31849 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in a day

Pull request review commentnodejs/node

test: Worker initialization failure test case

+'use strict';+const common = require('../common');+const assert = require('assert');+const child_process = require('child_process');++// Test that workers fail with meaningful error message+// when their initialization fails.++if (process.argv[2] === 'child') {+  const { Worker } = require('worker_threads');+  for (let i = 0; i < 256; ++i) {+    const worker = new Worker(+      'require(\'worker_threads\').parentPort.postMessage(2 + 2)',+      { eval: true });+    worker.on('message', (result) => {+      assert.strictEqual(result, 4);+    });+    worker.on('error', (e) => {+      assert(e.message.match(/Worker initialization failure: EMFILE/));

Change one of the assertions in the child process so that it fails no matter what and you should see this problem (unless I've done something horribly wrong here somehow).

HarshithaKP

comment created time in a day

push eventtniessen/nodejs.org

Tierney Cyren

commit sha 3ea046cf588b1fa1a2a3a1a2dfb9e95e3212f70e

docs: tweak wording on deb, rpm, and snap section

view details

Atef Ben Ali

commit sha e795b7d7fd0568e8d74fc4a17520c502e51400d1

docs: fix typos (#2931) Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>

view details

Atef Ben Ali

commit sha 7f8cc30118ba644d812777ca503f92346e88c412

docs: fix typo & improve translation (#2932) Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>

view details

dependabot-preview[bot]

commit sha ffd026b19d089fe6b02f88485d7df674e8d5c536

build(deps-dev): bump stylelint from 13.1.0 to 13.2.0 Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.1.0 to 13.2.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](https://github.com/stylelint/stylelint/compare/13.1.0...13.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 6bf70a34d169aab2ed4dd2fbcfcddbd028ec4823

build(deps): bump postcss from 7.0.26 to 7.0.27 (#2961) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.26 to 7.0.27. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/7.0.26...7.0.27) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha c38a4dd5216841d6c404c96622877924ca266778

build(deps-dev): bump nock from 11.8.2 to 12.0.0 (#2960) Bumps [nock](https://github.com/nock/nock) from 11.8.2 to 12.0.0. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v11.8.2...v12.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Myles Borins

commit sha e645f1ce50f645a1a72e2852b3954ec31478cd94

blog: add release post for 12.16.1 (#2963) Refs: https://github.com/nodejs/node/pull/31781

view details

Shelley Vohr

commit sha 125315fe180124bc0e6a7d8ef8a3b78e933e9923

Blog: v13.9.0 release post (#2964) PR-URL: https://github.com/nodejs/node/pull/31837

view details

dependabot-preview[bot]

commit sha e1146c6dfde7af736f968f51e5f09fb6c9994b24

build(deps-dev): bump remark-preset-lint-node from 1.12.0 to 1.13.0 Bumps [remark-preset-lint-node](https://github.com/nodejs/remark-preset-lint-node) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/nodejs/remark-preset-lint-node/releases) - [Commits](https://github.com/nodejs/remark-preset-lint-node/compare/v1.12.0...v1.13.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha cd9bdf570d752172adda8c566ee182772590aa9c

build(deps-dev): bump nock from 12.0.0 to 12.0.1 Bumps [nock](https://github.com/nock/nock) from 12.0.0 to 12.0.1. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v12.0.0...v12.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha cb3fd6ab91e14614922121c5a227430293ac5e00

build(deps-dev): bump lockfile-lint from 3.0.18 to 4.0.0 (#2970) Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 3.0.18 to 4.0.0. - [Release notes](https://github.com/lirantal/lockfile-lint/releases) - [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@3.0.18...lockfile-lint@4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Michael Dawson

commit sha c5623196678d9306b8a4396a3b5820a242ae9fd5

doc: fix typos in TLS guide

view details

Luigi Pinca

commit sha 375bf7eb0b8a5650c8b902bdb35cd9d9051cb493

disable the banner

view details

dependabot-preview[bot]

commit sha 48b5933b325488cc180367aed6f67b24d9924243

build(deps-dev): bump vnu-jar from 20.1.2 to 20.2.25 (#2982) Bumps [vnu-jar](https://github.com/validator/validator) from 20.1.2 to 20.2.25. - [Release notes](https://github.com/validator/validator/releases) - [Changelog](https://github.com/validator/validator/blob/master/CHANGELOG.md) - [Commits](https://github.com/validator/validator/compare/v20.1.2...v20.2.25) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Jesse Rosenberger

commit sha fde5e8b832102cde3d26b29d92a7a0c6ceabfe36

Add v12.x to the list of releases. (#2968) Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

dependabot-preview[bot]

commit sha 97875a072c7c4a6f384b4ffac00d01b57ba10b82

build(deps): bump sass from 1.25.0 to 1.26.0 (#2981) Bumps [sass](https://github.com/sass/dart-sass) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.25.0...1.26.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

Rich Trott

commit sha fc037b5871b3edd1cd772ed03c786cdce2bb8556

Merge branch 'master' into avoid-using-node

view details

push time in a day

issue closeduniversityofcalifornia/NeXt

archive this repository?

It seems to be very inactive?

closed time in a day

Trott

issue commentuniversityofcalifornia/NeXt

archive this repository?

It seems like the website that this is for (https://ucnext.org/) doesn't exist anymore, and that this repository is entirely unmaintained other than dependabot updates. The last time anything happened here that wasn't a dependency update was September 2018. I'm going to archive the repository. It can always be unarchived.

Trott

comment created time in a day

pull request commentnodejs/node

build: only lint markdown files that have changed (POSIX-only)

Might end up having a high overhead, but did you consider creating an MD5 hash of the files instead of the timestamp? That would be cross platform compatible AFAIK

Timestamp is already implemented. I modified the existing implementation.I did not consider replacing it with a completely new implementation.

If someone wants to experiment with other implementations, that's fine, of course. I don't plan on doing that here.

Trott

comment created time in a day

push eventTrott/io.js

Sam Roberts

commit sha 5f0181a079f4dd328fb01a75daff0a128c33fc70

deps: move zlib maintenance info to guides deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Sam Roberts

commit sha 0d95eda4996e5e895b80cd68052332a102de9fd3

doc: describe how to update zlib See: - https://github.com/nodejs/node/pull/31201 PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Sam Roberts

commit sha 9a1719b541b53eae844d801a74a8b6328ad1c9fd

deps: update zlib to upstream d7f3ca9 Updated as described in doc/guides/maintaining-zlib.md. PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Gabriel Schulhof

commit sha 0dff851336ea2a3801667e5390d5821db746baae

src: include large pages source unconditionally Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. PR-URL: https://github.com/nodejs/node/pull/31904 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

push time in a day

push eventTrott/io.js

Anna Henningsen

commit sha 2035e3d6cb3071dfbe142f8351cde3d883626a38

src: move BaseObject subclass dtors/ctors out of node_crypto.h Originally landed in the QUIC repo Move constructor and destructors for subclasses of `BaseObject` from node_crypto.h to node_crypto.cc. This removes the need to include base_object-inl.h when using node_crypto.h in some cases. Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/220 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: https://github.com/nodejs/node/pull/31872 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Anna Henningsen

commit sha e68d4c6f5f6086c2816ed6d870e23e824c661f92

src: allow unique_ptrs with custom deleter in memory tracker Originally landed in the QUIC repo Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: https://github.com/nodejs/node/pull/31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

James M Snell

commit sha d3715c76b5c287d900d28f472da0186322ace811

http: move OutboundMessage.prototype.flush to EOL API was deprecated long ago. Move to end of life and remove. PR-URL: https://github.com/nodejs/node/pull/31164 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Myles Borins

commit sha 021542080a020d1d67fa47e25338973b78d543e6

doc: update releases guide re pushing tags Currently we specify pushing the tag before updating any of the branches. This creates a potential of creating and pushing a tag on an out of sync branch, and only really when attempting to merge the release commit that things have gone out of sync. Changing the order here would minimize the possibility of this error PR-URL: https://github.com/nodejs/node/pull/31855 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Harshitha KP

commit sha b70dd9d662aaf3e652219e65d8e51762842d8b80

src: elevate v8 namespaces PR-URL: https://github.com/nodejs/node/pull/31901 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 2 days

pull request commentnodejs/node

test: fix typo preventing test from running

Re-running pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12396/

Trott

comment created time in 2 days

pull request commentnodejs/node

test: fix typo preventing test from running

Also, enoughTestCpu is not documented in the README.

Now it is (in this PR).

Trott

comment created time in 2 days

push eventTrott/io.js

Rich Trott

commit sha 816b978023ec7ee08bb7b5341c21f1d09503e377

test: add documentation for common.enoughTestCpu

view details

push time in 2 days

pull request commentnodejs/node

test: fix typo preventing test from running

Also, enoughTestCpu is not documented in the README.

Trott

comment created time in 2 days

push eventTrott/io.js

Anna Henningsen

commit sha 2035e3d6cb3071dfbe142f8351cde3d883626a38

src: move BaseObject subclass dtors/ctors out of node_crypto.h Originally landed in the QUIC repo Move constructor and destructors for subclasses of `BaseObject` from node_crypto.h to node_crypto.cc. This removes the need to include base_object-inl.h when using node_crypto.h in some cases. Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/220 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: https://github.com/nodejs/node/pull/31872 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Anna Henningsen

commit sha e68d4c6f5f6086c2816ed6d870e23e824c661f92

src: allow unique_ptrs with custom deleter in memory tracker Originally landed in the QUIC repo Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: https://github.com/nodejs/node/pull/31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Rich Trott

commit sha 7691a8b157122ce7597cf041710bf2f632d67898

test: fix typo in common/index.js All tests using enoughTestCpu checks are always having the checks come back false due to a typo in common/index.js. Fix the typo.

view details

push time in 2 days

pull request commentnodejs/node

test: fix typo preventing test from running

@Trott Actually, after checking through tests it looks like we only ever use enoughTestCpu 😄. We should probably just change this in common/index.js to enoughTestCpu.

Oh, goodness, it's even enoughTestCpu in the .mjs version of common. Yeah, let's do the ergonomic thing and change it in common/index.js instead.

Trott

comment created time in 2 days

pull request commentnodejs/node

test: fix typo preventing test from running

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12391/

Trott

comment created time in 2 days

PR opened nodejs/node

test: fix typo preventing test from running

test-fs-watch-system-limit is always being skipped because of a typo.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchTrott/io.js

branch : intense

created branch time in 2 days

push eventTrott/new.nodejs.org

Luigi Pinca

commit sha 375bf7eb0b8a5650c8b902bdb35cd9d9051cb493

disable the banner

view details

Rich Trott

commit sha 7cce87866c5825c7eb8e83a781a295e3f0ebc114

Merge branch 'master' into get-start

view details

push time in 2 days

PR closed nodejs/node

doc: update assert.rejects docs with a validation function example assert author ready doc

Update assert.rejects docs with a validation function example

Spawned from my own struggle to use in https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1702#note_268452483

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+15 -0

17 comments

1 changed file

MadLittleMods

pr closed time in 2 days

pull request commentnodejs/node

doc: update assert.rejects docs with a validation function example

Landed in be2f3a3bf88fd728799d1917f7d82428f53183f0.

Thanks for the contribution and your patience! 🎉

MadLittleMods

comment created time in 2 days

push eventTrott/io.js

Robert Nagy

commit sha db28739aed31b2ad6e85c497e3a836a29d13021c

stream: fix broken pipeline error propagation If the destination was an async function any error thrown from that function would be swallowed. PR-URL: https://github.com/nodejs/node/pull/31835 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Eric Eastwood

commit sha be2f3a3bf88fd728799d1917f7d82428f53183f0

doc: update assert.rejects() docs with a validation function example Spawned from my own struggle to use in https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1702#note_268452483 PR-URL: https://github.com/nodejs/node/pull/31271 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 2 days

push eventnodejs/node

Eric Eastwood

commit sha be2f3a3bf88fd728799d1917f7d82428f53183f0

doc: update assert.rejects() docs with a validation function example Spawned from my own struggle to use in https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1702#note_268452483 PR-URL: https://github.com/nodejs/node/pull/31271 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 2 days

Pull request review commentnodejs/node

test: Worker initialization failure test case

+'use strict';+const common = require('../common');+const assert = require('assert');+const child_process = require('child_process');++// Test that workers fail with meaningful error message+// when their initialization fails.++if (process.argv[2] === 'child') {+  const { Worker } = require('worker_threads');+  for (let i = 0; i < 256; ++i) {+    const worker = new Worker(+      'require(\'worker_threads\').parentPort.postMessage(2 + 2)',+      { eval: true });+    worker.on('message', (result) => {+      assert.strictEqual(result, 4);+    });+    worker.on('error', (e) => {+      assert(e.message.match(/Worker initialization failure: EMFILE/));

This assertion fails for me but the test still passes. Errors in the child are ignored. So this test isn't working, I'm afraid.

$ ./node test/parallel/test-worker-init-failure.js 
assert.js:387
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(e.message.match(/Worker initialization failure: EMFILE/))

    at Worker.<anonymous> (/Users/trott/io.js/test/parallel/test-worker-init-failure.js:19:7)
    at Worker.emit (events.js:321:20)
    at Worker.[kOnErrorMessage] (internal/worker.js:209:10)
    at Worker.[kOnMessage] (internal/worker.js:219:37)
    at MessagePort.<anonymous> (internal/worker.js:145:57)
    at MessagePort.emit (events.js:321:20)
    at MessagePort.onmessage (internal/worker/io.js:78:8)
    at MessagePort.exports.emitMessage (internal/per_context/messageport.js:11:10) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: null,
  expected: true,
  operator: '=='
}

$ tools/test.py test/parallel/test-worker-init-failure.js 
[00:00|% 100|+   1|-   0]: Done                            
$
HarshithaKP

comment created time in 2 days

Pull request review commentnodejs/node

test: Worker initialization failure test case

+'use strict';+const common = require('../common');+const assert = require('assert');+const child_process = require('child_process');++// Test that workers fail with meaningful error message+// when their initialization fails.++if (process.argv[2] === 'child') {+  const { Worker } = require('worker_threads');+  for (let i = 0; i < 256; ++i) {+    const worker = new Worker(+      'require(\'worker_threads\').parentPort.postMessage(2 + 2)',+      { eval: true });+    worker.on('message', (result) => {+      assert.strictEqual(result, 4);+    });+    worker.on('error', (e) => {+      assert(e.message.match(/Worker initialization failure: EMFILE/));
      assert.match(e.message, /Worker initialization failure: EMFILE/);
HarshithaKP

comment created time in 2 days

Pull request review commentnodejs/node

test: Worker initialization failure test case

+'use strict';+const common = require('../common');+const assert = require('assert');+const child_process = require('child_process');++// Test that workers fail with meaningful error message+// when their initialization fails.++if (process.argv[2] === 'child') {+  const { Worker } = require('worker_threads');+  for (let i = 0; i < 256; ++i) {+    const worker = new Worker(+      'require(\'worker_threads\').parentPort.postMessage(2 + 2)',+      { eval: true });+    worker.on('message', (result) => {+      assert.strictEqual(result, 4);+    });+    worker.on('error', (e) => {+      assert(e.message.match(/Worker initialization failure: EMFILE/));+      assert.strictEqual(e.code, 'ERR_WORKER_INIT_FAILED');+    });+  }++} else {++  if (common.isWindows) {+    common.skip('ulimit does not work on Windows.');

Maybe instead of skipping the test, just skip the ulimit prefix? As written, I don't think the test won't fail if the error event never happens, so the test might still be runnable under Windows?

HarshithaKP

comment created time in 2 days

Pull request review commentnodejs/node

test: Worker initialization failure test case

+'use strict';+const common = require('../common');+const assert = require('assert');+const child_process = require('child_process');++// Test that workers fail with meaningful error message+// when their initialization fails.++if (process.argv[2] === 'child') {+  const { Worker } = require('worker_threads');+  for (let i = 0; i < 256; ++i) {+    const worker = new Worker(+      'require(\'worker_threads\').parentPort.postMessage(2 + 2)',+      { eval: true });+    worker.on('message', (result) => {+      assert.strictEqual(result, 4);+    });+    worker.on('error', (e) => {+      assert(e.message.match(/Worker initialization failure: EMFILE/));+      assert.strictEqual(e.code, 'ERR_WORKER_INIT_FAILED');+    });+  }++} else {++  if (common.isWindows) {+    common.skip('ulimit does not work on Windows.');+  }++  // Limit the number of open files, to force workers to fail+  let testCmd = 'ulimit -n 128 && ';

Any reason not to go with something much smaller than 128, like maybe 8?

HarshithaKP

comment created time in 2 days

pull request commentnodejs/node

stream: throw invalid argument errors

Oh, wait, I agree that CITGM is not an obstacle. But it does still need a second TSC approval because it's semver-major.

Looks good to me and I've added my approval, so this can land. Might not be a bad idea to leave it open for 24 hours or so just to give people one more chance to take a look, but that's not strictly required.

ronag

comment created time in 2 days

pull request commentnodejs/node

stream: throw invalid argument errors

I think this can land given that the CITGM failures seems unrelated. @Trott I'd appreciate a second opinion before landing.

Yes, I'd agree. Thanks for opening nodejs/citgm#785.

Oh, wait, I agree that CITGM is not an obstacle. But it does still need a second TSC approval because it's semver-major. @nodejs/tsc

ronag

comment created time in 2 days

pull request commentnodejs/node

stream: throw invalid argument errors

I think this can land given that the CITGM failures seems unrelated. @Trott I'd appreciate a second opinion before landing.

Yes, I'd agree. Thanks for opening https://github.com/nodejs/citgm/issues/785.

ronag

comment created time in 2 days

pull request commentnodejs/node

doc: update assert.rejects docs with a validation function example

Since the problem I'm concerned about is already there in the existing example code for assert.rejects(), I'm going to clear the request for changes and make a note for myself to figure out what (if anything) to do at a later date.

It's good that test runners do the right thing. Still, lots of packages don't use test runners and just run a test.js file directly, expecting it to fail when an AssertionError happens. I'm still uncomfortable with the idea that we have runnable code in our examples that have assertions that, if they were to fail, would print an AssertionError but exit with a non-zero status code.

MadLittleMods

comment created time in 2 days

PR opened nodejs/node

meta: move not-an-aardvark to emeritus

@not-an-aardvark confirmed in email that it's probably time for him to move to emeritus.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -2

0 comment

1 changed file

pr created time in 2 days

create barnchTrott/io.js

branch : tk

created branch time in 2 days

pull request commentnodejs/node

build: only lint markdown files that have changed (POSIX-only)

Also, in the current setting, the Makefile itself handles most of the timestamp magic. If we move it to be the timestamp of the lint-md.js file, we lose most or all of that.

Trott

comment created time in 2 days

pull request commentnodejs/node

build: only lint markdown files that have changed (POSIX-only)

I think having a separate timestamp file like we do now is preferable. If someone is having weird issues with their files not being linted (been there!) and they just want to hit a reset button and have all files re-linted (been there too!), it's easy with a timestamp file: Just remove it.

In the scenario you describe, we'd either have to "touch" all lintable files (yikes), artificially set the timestamp on lint-md.js to something in the (probably distant) past, or introduce an otherwise-unnecessary option like a -f flag or something that will then likely mean another Makefile task.

Trott

comment created time in 2 days

PR opened nodejs/node

doc: updated YAML version representation in readline.md

All other versions in YAML throughout the docs start with v. Fix two cases in readline.md that did not.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -2

0 comment

1 changed file

pr created time in 3 days

create barnchTrott/io.js

branch : v

created branch time in 3 days

push eventTrott/io.js

vdeturckheim

commit sha 9c702922cdcf830cedb92d51e5dc9f956584c3ee

async_hooks: introduce async-context API Adding AsyncLocalStorage class to async_hooks module. This API provide a simple CLS-like set of features. Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com> PR-URL: https://github.com/nodejs/node/pull/26540 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

push time in 3 days

push eventTrott/io.js

Shelley Vohr

commit sha 72b6cea25d4e43b2db63eeb32417088c5bd93307

cli: --perf-prof only works on Linux PR-URL: https://github.com/nodejs/node/pull/31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

push time in 3 days

pull request commentnodejs/node

build: only lint markdown files that have changed (POSIX-only)

On my laptop, this change saves 17 seconds on the markdown lint run when a single .md file in doc/api is edited.

$ touch doc/api/assert.md && time make lint-md
Running Markdown linter on docs...

real	0m17.836s
user	0m20.322s
sys	0m1.128s
$ git stash pop && !!
git stash pop && touch doc/api/assert.md && time make lint-md
On branch master
Your branch is up-to-date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   Makefile

no changes added to commit (use "git add" and/or "git commit -a")
Dropped refs/stash@{0} (b0765bc82f1d2948f958ebd630363f8dc67d2271)
Running Markdown linter on docs...

real	0m0.812s
user	0m0.601s
sys	0m0.218s
$
Trott

comment created time in 3 days

pull request commentnodejs/node

build: only lint markdown files that have changed (POSIX-only)

@nodejs/linting @nodejs/build-files @DerekNonGeneric

Trott

comment created time in 3 days

PR opened nodejs/node

build: only lint markdown files that have changed (POSIX-only)

Update Makefile so that only markdown files that have changed will be linted. Currently, if one file in doc/api has changed, all files in doc/api are linted.

On Windows, the lint-md task currently lints all files regardless of whether any files has changed, and that behavior is unchanged here.

A further improvement is that when tools/lint-md.js is rebuilt, the timestamp file is removed so that all files are linted again. This is because rebuilding lint-md.js can introduce new rules or modify existing rules, so re-linting everything helps make sure that accidental breakage doesn't slip by unnoticed.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+15 -19

0 comment

1 changed file

pr created time in 3 days

create barnchTrott/io.js

branch : just-the-changes

created branch time in 3 days

delete branch Trott/io.js

delete branch : port-0

delete time in 3 days

PR merged nodejs/node

test: replace instances of common.PORT in pummel tests with port "0" author ready test

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+20 -20

3 comments

8 changed files

Trott

pr closed time in 3 days

pull request commentnodejs/node

test: replace instances of common.PORT in pummel tests with port "0"

Landed in 97c8abe2c0df261aacadd5abd9cabfbeef2d5d61

Trott

comment created time in 3 days

push eventnodejs/node

Rich Trott

commit sha 97c8abe2c0df261aacadd5abd9cabfbeef2d5d61

test: remove common.PORT from assorted pummel tests Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: https://github.com/nodejs/node/pull/31897 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

push time in 3 days

push eventTrott/io.js

Shelley Vohr

commit sha ae41049a760d55b5dcc20e137a7454e7c70415c4

doc: add note about ssh key to releases PR-URL: https://github.com/nodejs/node/pull/31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Michaël Zasso

commit sha cf0096104752607c7374a7f7297139e60b03c59d

tools: sync gyp code base with node-gyp repo PR-URL: https://github.com/nodejs/node/pull/30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 2f97e973ff540d2ae7de77482c631c06cc99c313

meta: move julianduque to emeritus julianduque confirmed in email that they can be moved to emeritus. PR-URL: https://github.com/nodejs/node/pull/31863 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Vse Mozhet Byt

commit sha 2f23918ca5090417ad0e06be6ecce63553f17985

doc: update stream.pipeline() signature The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: https://github.com/nodejs/node/pull/31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Robert Nagy

commit sha 21bd6679ce150e193cacd4b1b6585928224f255a

stream: fix finished typo https://github.com/nodejs/node/pull/31509 introduced a slight typo. Fortunately this typo does not have big impact due to `isWritableFinished()`. Fixes: https://github.com/nodejs/node/pull/31509#discussion_r381809355 PR-URL: https://github.com/nodejs/node/pull/31881 Fixes: https://github.com/nodejs/node/issues/31509 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Tobias Nießen

commit sha 0e63a079e8f535e1d4f0398400c534b0b5772fa5

crypto: fix ieee-p1363 for createVerify Fixes: https://github.com/nodejs/node/issues/31866 PR-URL: https://github.com/nodejs/node/pull/31876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tobias Nießen

commit sha fa1fc6bf9f257f7365454dc7a28bb4cd4385919f

doc: fix anchor for ERR_TLS_INVALID_CONTEXT PR-URL: https://github.com/nodejs/node/pull/31915 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

simon

commit sha 341c06f0889e5295d7a7a34c3e38296bd2c4ac18

tls: expose SSL_export_keying_material Fixes: https://github.com/nodejs/node/issues/31802 PR-URL: https://github.com/nodejs/node/pull/31814 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ben Noordhuis

commit sha 793cfe54cd26e0eb881eec895df41da62a3049ed

doc,crypto: re-document oaepLabel option Erroneously removed in https://github.com/nodejs/node/pull/29516. Fixes: https://github.com/nodejs/node/issues/31810 Refs: https://github.com/nodejs/node/pull/29516 PR-URL: https://github.com/nodejs/node/pull/31825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 97c8abe2c0df261aacadd5abd9cabfbeef2d5d61

test: remove common.PORT from assorted pummel tests Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: https://github.com/nodejs/node/pull/31897 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

push time in 3 days

push eventTrott/io.js

Rich Trott

commit sha 97c8abe2c0df261aacadd5abd9cabfbeef2d5d61

test: remove common.PORT from assorted pummel tests Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: https://github.com/nodejs/node/pull/31897 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

push time in 3 days

push eventTrott/io.js

simon

commit sha 341c06f0889e5295d7a7a34c3e38296bd2c4ac18

tls: expose SSL_export_keying_material Fixes: https://github.com/nodejs/node/issues/31802 PR-URL: https://github.com/nodejs/node/pull/31814 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ben Noordhuis

commit sha 793cfe54cd26e0eb881eec895df41da62a3049ed

doc,crypto: re-document oaepLabel option Erroneously removed in https://github.com/nodejs/node/pull/29516. Fixes: https://github.com/nodejs/node/issues/31810 Refs: https://github.com/nodejs/node/pull/29516 PR-URL: https://github.com/nodejs/node/pull/31825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

push time in 3 days

issue commentnodejs/node

Getting started guide does not have paging

Is there a second page, third page, etc.? Like, it's not the Debugging getting started page. That's a terrible page 2. That would be page 35 or something. , I think the Getting Started guide is just that one slim page. Anything more robust wouldn't be particularly well-maintained anyway, which is the fundamental problem with nearly all the guides on the webiste. In https://github.com/nodejs/nodejs.org/pull/2971, I've proposed adding a link to the "other" official(-ish) introductory material at nodejs.dev, which isn't entirely free of the not-being-maintained issues is more expansive.

devanshdixit

comment created time in 3 days

push eventTrott/new.nodejs.org

Michael Dawson

commit sha c5623196678d9306b8a4396a3b5820a242ae9fd5

doc: fix typos in TLS guide

view details

Rich Trott

commit sha 5383e7a1b947526673829d5d1ff0b42c7725ddfc

Merge branch 'master' into get-start

view details

push time in 3 days

push eventTrott/io.js

Tobias Nießen

commit sha 0e63a079e8f535e1d4f0398400c534b0b5772fa5

crypto: fix ieee-p1363 for createVerify Fixes: https://github.com/nodejs/node/issues/31866 PR-URL: https://github.com/nodejs/node/pull/31876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tobias Nießen

commit sha fa1fc6bf9f257f7365454dc7a28bb4cd4385919f

doc: fix anchor for ERR_TLS_INVALID_CONTEXT PR-URL: https://github.com/nodejs/node/pull/31915 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 3 days

issue commentnodejs/node

Memory leak when using Intl.DateTimeFormat.format() and Intl.NumberFormat.format()

This has been fixed in V8 and it's not leaking memory in node v13.9. Our current workaround is to memoize those objects to keep the leak to a minimum.

Can we please get the V8 fix in node v10 and v12 as well? Thank you!

@nodejs/v8-update @nodejs/lts

helloneele

comment created time in 3 days

pull request commentnodejs/node

doc: fix anchor for ERR_TLS_INVALID_CONTEXT

Given that this fixes a rendering issue in the docs, I wouldn't mind fast-tracking this just to make sure it lands soon. Collaborators, 👍 here to approve fast-tracking.

tniessen

comment created time in 4 days

push eventTrott/io.js

Vse Mozhet Byt

commit sha 2f23918ca5090417ad0e06be6ecce63553f17985

doc: update stream.pipeline() signature The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: https://github.com/nodejs/node/pull/31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Robert Nagy

commit sha 21bd6679ce150e193cacd4b1b6585928224f255a

stream: fix finished typo https://github.com/nodejs/node/pull/31509 introduced a slight typo. Fortunately this typo does not have big impact due to `isWritableFinished()`. Fixes: https://github.com/nodejs/node/pull/31509#discussion_r381809355 PR-URL: https://github.com/nodejs/node/pull/31881 Fixes: https://github.com/nodejs/node/issues/31509 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 4 days

push eventTrott/nodejs.dev

dependabot[bot]

commit sha b47ae42554fc83d1a4ce187d9057cd68c7d6922c

build(deps): bump npm in /.github/action/result-poster (#381) Bumps [npm](https://github.com/npm/cli) from 6.11.2 to 6.13.4. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](https://github.com/npm/cli/compare/v6.11.2...v6.13.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

Rich Trott

commit sha c51f56c1ef9964bccc1df28e70c603d7f19eae03

chore: update dependencies (#379) Results of yarn upgrade gatsby. This will quell a warning in the GitHub interface.

view details

Nick Schonning

commit sha a7f83242f573ff29ff1be61e2ec00f50bf3d46b9

chore: bump remark-preset-lint-node to 1.10.1 (#356) Supress newly failing rules to be fixed separatley

view details

Brian Harrington

commit sha 4e721460e71f6ff27680e7310c11a6cc8227d41a

grammar, update times and references (#360)

view details

Masashi Hirano

commit sha a5715c4030c0a4648bd10c7bd6bc84f51116bed0

fix: Stream.Readable example (#367) Co-Authored-By: Nick Schonning <nschonni@gmail.com>

view details

kajaharish

commit sha 0b4d08c6d7f7a56726acff1dc21da11e51668936

Update index.md (#374) In the copy a buffer section, there is a mistake: buf.copy(bufcopy, 0, 2,2) //it will print nothing since the source start and source end is specified as 2 in the original code correction: buf.copy(bufcopy, 0, 0, 2) // it will print the desired output that is 'He'

view details

Brian Clark

commit sha 0edef663913781357903dae4df6ac330615d67eb

docs: correct azure documentation link (#377) Co-authored-by: Nick Schonning <nschonni@gmail.com>

view details

Saqib Ameen

commit sha 013dd75032bd88700a5ce95ef7b8e8e86a86b447

Add a note (#363) Add a note (condition) for running the `node.js` command.

view details

Nick Schonning

commit sha 9ba9304c373e39210c9612e53ae994f3f073cf0a

fix: remark-lint minor suppressed rules (#351)

view details

Aymen Naghmouchi

commit sha 9a294407d23fc53981322668dd65095a62d007ca

doc: add MEAN and Loopback (#372) Co-Authored-By: Nick Schonning <nschonni@gmail.com>

view details

dependabot[bot]

commit sha a6d48f9688fabd7a42784bdb4757ebe034f97d55

build(deps): bump handlebars in /.github/action/result-poster (#384) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 8c3e8195913a5a8a4ac7313af55dce6465b9e521

build(deps): bump handlebars from 4.1.2 to 4.5.3 (#385) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Manil Chowdhury

commit sha aa613a02bb075d9392cf636d9de39fb3d428dfb7

Notes for meeting on 2020-01-30 (#391) * Create 2020-01-30.md Thank you for taking notes, @jonchurch and @SMotaal 👍🏽 * fix: Tweak meeting minutes to fix md linting errors Co-authored-by: Jonathan Church <me@jonchurch.com>

view details

Liz Parody

commit sha 9534d9d8ad729c5953b3b23fdbd0a44fdc898e92

Update examples (#393) Updated the examples to use a more recent version of Node.js

view details

dependabot[bot]

commit sha f0c49a932cdd493d86ca2b44a71c2d95135552d9

build(deps-dev): bump codecov from 3.5.0 to 3.6.5 (#411) Bumps [codecov](https://github.com/codecov/codecov-node) from 3.5.0 to 3.6.5. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 4 days

push eventTrott/new.nodejs.org

dependabot-preview[bot]

commit sha cb3fd6ab91e14614922121c5a227430293ac5e00

build(deps-dev): bump lockfile-lint from 3.0.18 to 4.0.0 (#2970) Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 3.0.18 to 4.0.0. - [Release notes](https://github.com/lirantal/lockfile-lint/releases) - [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@3.0.18...lockfile-lint@4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Michael Dawson

commit sha c5623196678d9306b8a4396a3b5820a242ae9fd5

doc: fix typos in TLS guide

view details

push time in 4 days

push eventTrott/io.js

Rich Trott

commit sha cdac18519fd14df9ece958cf8e29b846f512656e

test: remove flaky designation for test-net-connect-options-port Closes: https://github.com/nodejs/node/issues/23207 PR-URL: https://github.com/nodejs/node/pull/31841 Fixes: https://github.com/nodejs/node/issues/23207 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 82afd85a31ab7c8f931f0bb0b23e76570aceb46d

tools: update lint-md task to lint for possessives of Node.js Add a markdown lint rule to prohibit "Node.js'" and "Node.js's". Instead, of "Node.js' module system", use "the Node.js module system". Refs: https://github.com/nodejs/node/pull/31748#issuecomment-585087745 PR-URL: https://github.com/nodejs/node/pull/31862 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Shelley Vohr

commit sha ae41049a760d55b5dcc20e137a7454e7c70415c4

doc: add note about ssh key to releases PR-URL: https://github.com/nodejs/node/pull/31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Michaël Zasso

commit sha cf0096104752607c7374a7f7297139e60b03c59d

tools: sync gyp code base with node-gyp repo PR-URL: https://github.com/nodejs/node/pull/30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 2f97e973ff540d2ae7de77482c631c06cc99c313

meta: move julianduque to emeritus julianduque confirmed in email that they can be moved to emeritus. PR-URL: https://github.com/nodejs/node/pull/31863 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha cde3551ba19d66f882090e80bde40e93fed0485e

doc: update os.tmpdir() to discuss symlink results on macOS Closes: https://github.com/nodejs/node/issues/11422

view details

push time in 4 days

push eventnodejs/nodejs.org

Michael Dawson

commit sha c5623196678d9306b8a4396a3b5820a242ae9fd5

doc: fix typos in TLS guide

view details

push time in 4 days

PR merged nodejs/nodejs.org

doc: fix typos in TLS guide
+2 -2

0 comment

1 changed file

mhdawson

pr closed time in 4 days

push eventTrott/io.js

Rich Trott

commit sha c0b90c4167dc861beaed13f6d45843aac7079b04

Update doc/api/os.md

view details

push time in 4 days

push eventTrott/io.js

Rich Trott

commit sha f62963846860b7a39c9c63536d9e64a40cbd1a99

Update doc/api/os.md

view details

push time in 4 days

Pull request review commentnodejs/node

doc: update os.tmpdir() to discuss symlink results on macOS

 changes: Returns the operating system's default directory for temporary files as a string. +On macOS, the returned path is usually a symlink. To get the resolved path, use
By default on macOS, the returned path is a symlink. To get the resolved path, use
Trott

comment created time in 4 days

Pull request review commentnodejs/node

doc: update os.tmpdir() to discuss symlink results on macOS

 changes: Returns the operating system's default directory for temporary files as a string. +On macOS, the returned path is usually a symlink. To get the resolved path, use+[`fs.realpath()`][] or [`fs.realpathSync()`][].++```js+const tmpdirPath = os.tmpdir();++// For most use cases, it does not matter whether tmpdirPath is a symlink or not+// but if you need it to be a resolved path, use fs.realpath() or

Blech, passive voice, gross, I'm going with this instead:

// but to guarantee a resolved path, use fs.realpath() or
Trott

comment created time in 4 days

more