profile
viewpoint
Rich Trott Trott San Francisco, CA I create software, rock operas, and pizzas. I am a member of the Node.js Technical Steering Committee and work for the University of California. he/him

nlf/precommit-hook 480

An npm installable git pre-commit hook used to lint and test your code

davidmarkclements/v8-perf 250

Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1

inikulin/dmn 95

Janitor for your node_modules

nlf/git-validate 95

A module to help you create your own git hooks

Swaagie/stackexchange 48

Node.js implementation of the stackexchange/stackoverflow API

nodejs/core-validate-commit 37

Validate commit messages for Node.js core

nodejs/make-node-meeting 8

Generate a text for a GitHub issue announcing a Node.js working group meeting

nodejs/node.js.org 5

As a community service, redirecting node.js.org to nodejs.org.

nodejs/node-meeting-agenda 2

Generate an agenda for a Node.js working group based on GitHub issue labels

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-05-27

Would be great to get all the strategic initiative updates in advance again! @MylesBorins @mcollina @targos @jasnell @joyeecheung @mhdawson

Initiative Champion Links
Modules [Myles Borins][MylesBorins] https://github.com/nodejs/modules
Core Promise APIs [Matteo Collina][mcollina]
V8 Currency [Michaël Zasso][targos]
QUIC / HTTP3 [James M Snell][jasnell] https://github.com/nodejs/quic
Startup performance [Joyee Cheung][joyeecheung] https://github.com/nodejs/node/issues/17058 https://github.com/nodejs/node/issues/21563
Build resources [Michael Dawson][mhdawson] https://github.com/nodejs/build/issues/1154#issuecomment-448418977
mhdawson

comment created time in 16 hours

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-05-27

Moderation team report: No moderation team activity this week. @nodejs/moderation @nodejs/tsc @nodejs/community-committee

mhdawson

comment created time in 16 hours

PR merged nodejs/TSC

doc: add minutes for meeting 21 May 2020

Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com

+83 -0

0 comment

1 changed file

mhdawson

pr closed time in 17 hours

push eventnodejs/TSC

Michael Dawson

commit sha a1e08cecab349623dd9a48efbe5e00e68afe2b72

doc: add minutes for meeting 21 May 2020 (#870) Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

view details

push time in 17 hours

push eventTrott/io.js

Michaël Zasso

commit sha dcc112b7f7e7543e57b279d95a5bbb24ef771652

2020-05-26, Version 12.17.0 'Erbium' (LTS) Notable changes: * ECMAScript Modules - `--experimental-modules` flag removal * AsyncLocalStorage API (experimental) * REPL previews * REPL reverse-i-search * REPL substring-based search * Error monitoring * Monitoring `error` events * Monitoring uncaught exceptions * File system APIs * New function: `fs.readv` * Optional parameters in `fs.read` * Console `groupIndentation` option * `maxStringLength` option for `util.inspect()` * Stable N-API release 6 * Stable diagnostic reports * Increase of the default server headers timeout * New `--trace-sigint` CLI flag * Various crypto APIs now support Diffie-Hellman secrets * Added support for the `dns.ALL` flag in `dns.lookup()` * Added a new experimental API to interact with Source Map V3 data * Added support for passing a `transferList` along with `workerData` to the `Worker` constructor PR-URL: https://github.com/nodejs/node/pull/33197

view details

Robert Nagy

commit sha 9949a2e1e3100c4ff1f228bac57c1af95cdc3e9d

test: make flaky test stricter Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: https://github.com/nodejs/node/issues/4066 PR-URL: https://github.com/nodejs/node/pull/33539 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 20 hours

push eventTrott/node-slug

Bertrand d'Aure

commit sha c25d720a1b64ab279bc7fccd50fabdd78261b5b9

fix: repair markdown layout for README file There is a duplicate line.

view details

push time in a day

push eventTrott/node-slug

Bertrand d'Aure

commit sha 574518457b33377973801e320d06d766fde9ff55

Fix markdown layout There is a duplicate line

view details

push time in a day

PR merged Trott/node-slug

Fix markdown layout

There is a duplicate line that cause issue on rendering

image

+0 -1

1 comment

1 changed file

bertrandda

pr closed time in a day

pull request commentTrott/node-slug

Fix markdown layout

Thanks for the fix!

bertrandda

comment created time in a day

push eventTrott/io.js

Derek Lewis

commit sha 549812a9a0a697dbc41d7669fba649bf37b50b83

doc: normalize Bash code block info strings Prior to this commit, Bash fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the less-obscure variant. PR-URL: https://github.com/nodejs/node/pull/33510 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Derek Lewis

commit sha 84e4425f810191f65be1b46ee466e06b9d5fe9ed

doc: normalize C code block info strings Prior to this commit, C fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the lowercase variant, which matches the others, is the typical file extension for C files, and is the CSS class used by highlight.js despite representing a minority of appearances in the doc/api/ dir. Stats: > 'C' => 181, > 'c' => 3, Refs: https://github.com/highlightjs/highlight.js/pull/2577 PR-URL: https://github.com/nodejs/node/pull/33507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Derek Lewis

commit sha 5632ff66cdfd770083a4a5223ca4348d05b1eb39

doc: normalize shell code block info strings Prior to this commit, shell fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standarize on the one with the highest frequency in the doc/api/ dir. Stats: > 'console' => 54, > 'shell' => 2, PR-URL: https://github.com/nodejs/node/pull/33486 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Ben Bucksch

commit sha 2f00ca42bff04773bd787ec70ba83027f22442eb

crypto: fix wrong error message When calling `crypto.sign()`, if the `key` parameter object is missing the `key` property, the error message is wrong. Before the fix: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received an instance of Object Expected: TypeError [ERR_INVALID_ARG_TYPE]: The "key.key property" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined This seems like a copy&paste bug. Somebody copied from the end of the function, where this is correct, to here, where it's wrong. PR-URL: https://github.com/nodejs/node/pull/33482 Fixes: https://github.com/nodejs/node/issues/33480 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

view details

Ruben Bridgewater

commit sha e24731cb70386899a746da59fcc2bb68df3545ff

util: fix inspection of class instance prototypes To achieve this, some internal custom inspect functions had to be changed. They relied upon the former behavior. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33449 Fixes: https://github.com/nodejs/node/issues/33419 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Osher

commit sha e30a65193792d76e204e4558a404b7e9d5a12f41

http: tidy up exposure of header validation PR-URL: https://github.com/nodejs/node/pull/33371 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Thomas

commit sha 5e4c025567c688f3e7bd1d253619edafafbb7fcf

build: fix makefile script on windows On Windows there is a program "find.exe" located in C:\Windows\System32, which is usually in the PATH before MSYS version of that program (required for running makefile). The Windows version of the program uses different CLI syntax, which results in errors like "File not found - *node_modules*" This commit specifies the full path to the program, which is also properly handled by MSYS on Windows. PR-URL: https://github.com/nodejs/node/pull/33136 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Eli Schwartz

commit sha b21556d28b7be3921fa99089c61a7938811e25d1

build: fix inability to detect correct python command in configure The "which" utility is not guaranteed to be installed, and if it is, its behavior is not portable. Conversely, the "command -v" shell builtin is required to exist in all POSIX 2008 compliant shells, and is thus guaranteed to work everywhere. Examples of open-source shells likely to be installed as /bin/sh on Linux, which implement the 12-year-old standard: ash, bash, busybox, dash, ksh, mksh and zsh. Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> PR-URL: https://github.com/nodejs/node/pull/32925 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

himself65

commit sha 5007611294bfcfe7af8648a69bd19d1b014c84bd

src: use const in constant args.Length() PR-URL: https://github.com/nodejs/node/pull/33555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 2 days

push eventTrott/node-slug

dependabot-preview[bot]

commit sha c28b7c606162a2db64e767de61d9d0fbd021a7f6

chore(deps-dev): bump mocha from 7.1.2 to 7.2.0 Bumps [mocha](https://github.com/mochajs/mocha) from 7.1.2 to 7.2.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v7.1.2...v7.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 2 days

PR merged Trott/node-slug

chore(deps-dev): bump mocha from 7.1.2 to 7.2.0 dependencies

Bumps mocha from 7.1.2 to 7.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mochajs/mocha/releases">mocha's releases</a>.</em></p> <blockquote> <h2>v7.2.0</h2> <h1>7.2.0 / 2020-05-22</h1> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4234">#4234</a>: Add ability to run tests in a mocha instance multiple times (<a href="https://github.com/nicojs"><strong>@nicojs</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4219">#4219</a>: Exposing filename in JSON, doc, and json-stream reporters (<a href="https://github.com/Daniel0113"><strong>@Daniel0113</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4244">#4244</a>: Add Root Hook Plugins (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <h2>:bug: Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4258">#4258</a>: Fix missing dot in name of configuration file (<a href="https://github.com/sonicdoe"><strong>@sonicdoe</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4194">#4194</a>: Check if module.paths really exists (<a href="https://github.com/ematipico"><strong>@ematipico</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4256">#4256</a>: <code>--forbid-only</code> does not recognize <code>it.only</code> when <code>before</code> crashes (<a href="https://github.com/arvidOtt"><strong>@arvidOtt</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4152">#4152</a>: Bug with multiple async done() calls (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4275">#4275</a>: Improper warnings for invalid reporters (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4288">#4288</a>: Broken hook.spec.js test for IE11 (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <h2>:book: Documentation</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4081">#4081</a>: Insufficient white space for API docs in view on mobile (<a href="https://github.com/HyunSangHan"><strong>@HyunSangHan</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4255">#4255</a>: Update mocha-docdash for UI fixes on API docs (<a href="https://github.com/craigtaub"><strong>@craigtaub</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4235">#4235</a>: Enable emoji on website; enable normal ul elements (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4272">#4272</a>: Fetch sponsors at build time, show ALL non-skeevy sponsors (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <h2>:nut_and_bolt: Other</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4249">#4249</a>: Refactoring improving encapsulation (<a href="https://github.com/arvidOtt"><strong>@arvidOtt</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4242">#4242</a>: CI add job names, add Node.js v14 to matrix (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4237">#4237</a>: Refactor validatePlugins to throw coded errors (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4236">#4236</a>: Better debug output (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mochajs/mocha/blob/master/CHANGELOG.md">mocha's changelog</a>.</em></p> <blockquote> <h1>7.2.0 / 2020-05-22</h1> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4234">#4234</a>: Add ability to run tests in a mocha instance multiple times (<a href="https://github.com/nicojs"><strong>@nicojs</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4219">#4219</a>: Exposing filename in JSON, doc, and json-stream reporters (<a href="https://github.com/Daniel0113"><strong>@Daniel0113</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4244">#4244</a>: Add Root Hook Plugins (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <h2>:bug: Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4258">#4258</a>: Fix missing dot in name of configuration file (<a href="https://github.com/sonicdoe"><strong>@sonicdoe</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4194">#4194</a>: Check if module.paths really exists (<a href="https://github.com/ematipico"><strong>@ematipico</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4256">#4256</a>: <code>--forbid-only</code> does not recognize <code>it.only</code> when <code>before</code> crashes (<a href="https://github.com/arvidOtt"><strong>@arvidOtt</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4152">#4152</a>: Bug with multiple async done() calls (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4275">#4275</a>: Improper warnings for invalid reporters (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4288">#4288</a>: Broken hook.spec.js test for IE11 (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <h2>:book: Documentation</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4081">#4081</a>: Insufficient white space for API docs in view on mobile (<a href="https://github.com/HyunSangHan"><strong>@HyunSangHan</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4255">#4255</a>: Update mocha-docdash for UI fixes on API docs (<a href="https://github.com/craigtaub"><strong>@craigtaub</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4235">#4235</a>: Enable emoji on website; enable normal ul elements (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4272">#4272</a>: Fetch sponsors at build time, show ALL non-skeevy sponsors (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <h2>:nut_and_bolt: Other</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4249">#4249</a>: Refactoring improving encapsulation (<a href="https://github.com/arvidOtt"><strong>@arvidOtt</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4242">#4242</a>: CI add job names, add Node.js v14 to matrix (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4237">#4237</a>: Refactor validatePlugins to throw coded errors (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4236">#4236</a>: Better debug output (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mochajs/mocha/commit/2aab607c8132585423bf1a40ade634bd72d39876"><code>2aab607</code></a> Release v7.2.0</li> <li><a href="https://github.com/mochajs/mocha/commit/d525345d55be9bb022053ee01bace561b1506263"><code>d525345</code></a> update CHANGELOG for v7.2.0 [ci skip]</li> <li><a href="https://github.com/mochajs/mocha/commit/c6b7b6130383edc5779ab001ab475cc3ada0c731"><code>c6b7b61</code></a> Downgrade fs-extra for v7.x release branch</li> <li><a href="https://github.com/mochajs/mocha/commit/c9677894ce195996035ce6b7c9b507433b33fa47"><code>c967789</code></a> fetch sponsors at build time, show ALL non-skeevy sponsors; closes <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4271">#4271</a> (<a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4272">#4272</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/19f1841cfa76f080c671167dcb5f218db7f3ba30"><code>19f1841</code></a> Bump linters ecma version</li> <li><a href="https://github.com/mochajs/mocha/commit/08c3124e58fb106b73a45314d679b42b88435bcc"><code>08c3124</code></a> Test spec fixes</li> <li><a href="https://github.com/mochajs/mocha/commit/1edfb70fc8bcdf86499662304111606d287c8e8a"><code>1edfb70</code></a> Fix for runnable.spec.js</li> <li><a href="https://github.com/mochajs/mocha/commit/792292a5fd88d4be4dbb2ed233f8d04a64794139"><code>792292a</code></a> multiple async done() calls result in failure; closes <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4151">#4151</a> (<a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4152">#4152</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/5fd44cce227389cb07be9518f30453e9d55980bc"><code>5fd44cc</code></a> add Root Hook Plugins</li> <li><a href="https://github.com/mochajs/mocha/commit/e07cf0f00d85442007efcec687ff5a045ea381dd"><code>e07cf0f</code></a> do not commit generated content to VCS; closes <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/3713">#3713</a> (<a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4289">#4289</a>)</li> <li>Additional commits viewable in <a href="https://github.com/mochajs/mocha/compare/v7.1.2...v7.2.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -14

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 2 days

push eventTrott/remark-lint-prohibited-strings

dependabot-preview[bot]

commit sha a9bdb131b862f0e05751104996df08fb6de17c5c

chore(deps-dev): bump tape from 5.0.0 to 5.0.1 Bumps [tape](https://github.com/substack/tape) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/substack/tape/releases) - [Commits](https://github.com/substack/tape/compare/v5.0.0...v5.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 2 days

PR merged Trott/remark-lint-prohibited-strings

chore(deps-dev): bump tape from 5.0.0 to 5.0.1 dependencies

Bumps tape from 5.0.0 to 5.0.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/substack/tape/commit/ce9a28211a2162d6615019a7d7909f9f25d7130c"><code>ce9a282</code></a> v5.0.1</li> <li><a href="https://github.com/substack/tape/commit/b7af113832ae5f3a2b379d859abf8f1513036961"><code>b7af113</code></a> Merge tag 'v4.13.3'</li> <li><a href="https://github.com/substack/tape/commit/a8612306bb8d8a292b8f1c4163e47bd27deaf470"><code>a861230</code></a> v4.13.3</li> <li><a href="https://github.com/substack/tape/commit/9676a21784a90a13e29505d86901cd1cd0c1c7db"><code>9676a21</code></a> [Dev Deps] update <code>eslint</code>, <code>falafel</code>, <code>js-yaml</code></li> <li><a href="https://github.com/substack/tape/commit/8887189c60d956f13f7b54497443bb4be2726748"><code>8887189</code></a> [Deps] update <code>minimist</code>, <code>resolve</code></li> <li><a href="https://github.com/substack/tape/commit/fb94836257b6019bb0808e10ba7334ab765501f1"><code>fb94836</code></a> [Fix] <code>createStream</code>: <code>result</code> payload is not always an object</li> <li><a href="https://github.com/substack/tape/commit/582fe0057de5f8c18eb3096bbe89915d33be084d"><code>582fe00</code></a> [Fix] <code>createStream</code>: <code>result</code> payload is not always an object (<a href="https://github-redirect.dependabot.com/substack/tape/issues/519">#519</a>)</li> <li><a href="https://github.com/substack/tape/commit/c421eb36b4f6c3c51db329e2e2f03139ffa803af"><code>c421eb3</code></a> [Dev Deps] update <code>eslint</code></li> <li><a href="https://github.com/substack/tape/commit/751e592623c17bf272f0931b83dd0d53c679872d"><code>751e592</code></a> [Fix] Update RegExp for matching stack frames to handle Promise/then scenario...</li> <li><a href="https://github.com/substack/tape/commit/470e43bbe802564a2e091d56e83dadf6481b5a3a"><code>470e43b</code></a> [Fix] Update RegExp for matching stack frames to handle Promise/then scenario</li> <li>Additional commits viewable in <a href="https://github.com/substack/tape/compare/v5.0.0...v5.0.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -12

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 2 days

push eventTrott/io.js

Kirill Shatskiy

commit sha 8f10bb2da5bcf166fa1b414055f03352bbdb8126

esm: share package.json cache between ESM and CJS loaders Refs: https://github.com/nodejs/node/issues/30674 PR-URL: https://github.com/nodejs/node/pull/33229 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

bcoe

commit sha 458677f5ef2bd35da920246bb266502ea76bb66c

errors: print original exception context When --enable-source-maps is set, the error context displayed above the stack trace now shows original source rather than transpiled. PR-URL: https://github.com/nodejs/node/pull/33491 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Daniel Bevenius

commit sha c072124814ca45e2f51afe0d5e202b0df6db9b4b

src: use MaybeLocal::FromMaybe to return exception This commit suggests using MaybeLocal::FromMaybe to return the exception string, passing in a default value (an empty Local<Value>) which will be used if the exception object is empty. PR-URL: https://github.com/nodejs/node/pull/33514 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

cjihrig

commit sha 2d2d210db7ebf554c310dc1196c44ba30976d0f0

deps: uvwasi: cherry-pick 9e75217 Original commit message: poll_oneoff: add missing uv_run() in cleanup This allows ASAN to pass. PR-URL: https://github.com/nodejs/node/pull/33521 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

cjihrig

commit sha a4e6ef7b11d4846c2aa74ae04e24846bf151b7d7

wasi: refactor and enable poll_oneoff() test This commit refactors and enables the poll_oneoff() WASI test. The refactor includes testing additional cases, as well as some platform specific checks. PR-URL: https://github.com/nodejs/node/pull/33521 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

cjihrig

commit sha 698267c01a6bbb912b76457ade9b0939315d9e65

wasi: simplify WASI memory management This commit migrates the WASI C++ code from UncheckedCalloc() to std::vectors. PR-URL: https://github.com/nodejs/node/pull/33525 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

cjihrig

commit sha e278e3176ac460fc555834cbec2406d3c7334ef6

tools: update ESLint to 7.1.0 Update ESLint to 7.1.0 PR-URL: https://github.com/nodejs/node/pull/33526 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

push time in 2 days

push eventTrott/io.js

Ruben Bridgewater

commit sha 1acc14baf9ca1cc52f001fbe0453c2a540571c21

repl: add builtinModules This adds an alias to `_builtinLibs` that is documented and should as such also be accessed publicly. It does not contain any underscored modules. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33295 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Dan Fabulich

commit sha 842a895ebff5917edded3b283049dc0f8fbe4c64

cli: support --experimental-top-level-await in NODE_OPTIONS PR-URL: https://github.com/nodejs/node/pull/33495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Bartosz Sosnowski

commit sha 4a911d46fe8f325b81e1cf39d1d62fd98788a7df

fs: unify style in preprocessSymlinkDestination Removes the else after return to match rest of the style of the function. PR-URL: https://github.com/nodejs/node/pull/33496 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Deep310

commit sha 928473f689f1bc9a2fcb1fc0c55573b4d5994735

doc: fixed a grammatical error in path.md It said, " The path.basename() methods returns the last portion....". "Methods" was wrong and it is fixed to "method". PR-URL: https://github.com/nodejs/node/pull/33489 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Dominykas Blyžė

commit sha 78eb420fed154b7729283a3d63c99fa9989ffbea

deps: V8: cherry-pick 548f6c81d424 Original commit message: [runtime] Don't track transitions for certainly detached maps Previously such maps were marked as prototype, but that has bad performance / memory characteristics if objects are used as dictionaries. Bug: b:148346655, v8:10339 Change-Id: I287c5664c8b7799a084669aaaffe3affcf73e95f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179322 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67537} Refs: https://github.com/v8/v8/commit/548f6c81d4246736a7feafd7995fdf6f24ed1149 PR-URL: https://github.com/nodejs/node/pull/33484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Derek Lewis

commit sha 9dd7557c7d934931378593aca48bb0ac08b50920

doc: normalize C++ code block info strings Prior to this commit, C++ fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standarize on the one with the highest frequency in the doc/api/ dir. Stats: > 'cpp' => 19, > 'C++' => 6, > 'c++' => 3, PR-URL: https://github.com/nodejs/node/pull/33483 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

dfabulich

commit sha c39467cb4782e559c106d3d527bb0bd87439bbaa

doc: mention --experimental-top-level-await flag PR-URL: https://github.com/nodejs/node/pull/33473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Alhadis

commit sha f14229e7040b376b4934f8d0c98520bb3ed798fc

doc: eliminate dead space in API section's sidebar This commit improves overall usability on desktop by removing the "dead" (non-interactive) regions between links in the API section's navigation. No visible changes have been made; this enhancement is purely tactile in nature. PR-URL: https://github.com/nodejs/node/pull/33469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Anna Henningsen

commit sha b18d8dde847e1bff188c6cfb2d65a96209146c2c

Revert "n-api: detect deadlocks in thread-safe function" This reverts commit d26ca06c16f497ffa5ac4845a27922d5058a9318 because it breaks running the tests in debug mode, as `v8::Isolate::GetCurrent()` is not allowed if no `Isolate` is active on the current thread. Refs: https://github.com/nodejs/node/pull/33276 Refs: https://github.com/nodejs/node/pull/32860 PR-URL: https://github.com/nodejs/node/pull/33453 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Ben Noordhuis

commit sha 9ad8b4d3934325def5949dab19667d6e5452bbdf

wasi: relax WebAssembly.Instance type check Instances coming from different VM contexts don't pass `instanceof` type checks because each context has its own copy of the built-in globals. After review of the relevant code it seems like it should be safe to relax the type check and that is what this commit does: `wasi.start()` now accepts any input that walks and quacks like a WebAssembly.Instance or WebAssembly.Memory instance. Fixes: https://github.com/nodejs/node/issues/33415 PR-URL: https://github.com/nodejs/node/pull/33431 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Derek Lewis

commit sha dc6c93c03ee68eaca48b35e0cbcbb4d48e938e3d

doc,tools: properly syntax highlight API ref docs Prior to this commit, all <pre> tags were being highlighted as JavaScript. This has been corrected to syntax highlight all languages appearing in the API reference docs. This was accomplished by using highlight.js instead of SHJS for the frontend lib. * remove SHJS JavaScript code * add highlight.js bundle * fix script tags to reflect replacement * migrate CSS to use highlight.js classes * add appropriate documentation * ensure api_assets README.md stays interal Fixes: https://github.com/nodejs/node/issues/33363 PR-URL: https://github.com/nodejs/node/pull/33442 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

view details

rickyes

commit sha c5719eb26546ad3cc6f764dfb53dd447d675dc84

net: refactor check for Windows PR-URL: https://github.com/nodejs/node/pull/33497 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Anna Henningsen

commit sha f25153333533e8d328374df658786239c4d4aff3

test: fix flaky test-trace-atomics-wait This adds a possible ordering of the trace events that was missing from the list previously. Fixes: https://github.com/nodejs/node/issues/33427 PR-URL: https://github.com/nodejs/node/pull/33428 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Antoine du HAMEL

commit sha a3f47b111499416e5d164c5957af4f504a9e3c48

doc: fix typo in pathToFileURL example PR-URL: https://github.com/nodejs/node/pull/33418 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Ben Noordhuis

commit sha 8ddb6aa88694f4a5a2a05a46f66508c683b850d2

src: remove BeforeExit callback list It obscures the fact that there is only a single BeforeExit action. Just call that statically from `EmitBeforeExit()`. PR-URL: https://github.com/nodejs/node/pull/33386 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha d85a9332508bbc39ddc011e9e5a1fd5f71a985bb

wasi,worker: handle termination exception Be careful when emitting the 'beforeExit' event. It's not allowed to call into the runtime when a termination exception is pending. Fixes: https://github.com/nodejs/node/issues/33377 PR-URL: https://github.com/nodejs/node/pull/33386 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Nikolai Vavilov

commit sha b3f14df485d89ad7866573536fe07783e516a5ae

doc: fix Buffer.from(object) documentation Only strings are supported for objects supporting `Symbol.toPrimitive`. PR-URL: https://github.com/nodejs/node/pull/33327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Adrian Estrada

commit sha 6af15ebf220e084fe285a95fa0925f7b2efe024e

benchmark: fixing http_server_for_chunky_client.js PR-URL: https://github.com/nodejs/node/pull/33271 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Antoine du HAMEL

commit sha 539c56ed2ca3222cab7829af11f40b88e17f0a1d

tools: add docserve target Spaws a webserver serving the docs. Helpful to circumvent the OS permission limitations or to access the docs form a different device on the local network. PR-URL: https://github.com/nodejs/node/pull/33221 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Nikolai Vavilov

commit sha 9cd83c761f688079efeae931cb3462b9ba6d18e3

buffer: remove hoisted variable PR-URL: https://github.com/nodejs/node/pull/33470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 3 days

pull request commentdodo/node-slug

Adding arabic support

Support for Arabic was added in v1.1.0 released over a year ago. This repository is no longer the correct repository for the package. (It's now https://github.com/Trott/node-slug.) @ElMostafaBensaid Would you be willing to close this issue? I don't have write privileges in this repository.

ElMostafaBensaid

comment created time in 3 days

push eventTrott/io.js

AshCripps

commit sha e14786f69f8a7564ea568dee5ae25a7b35522e59

test: mark test-dgram-multicast-ssmv6-multi-process flaky refs: https://github.com/nodejs/node/issues/32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file PR-URL: https://github.com/nodejs/node/pull/33498 Refs: https://github.com/nodejs/node/issues/32946 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Guy Bedford

commit sha e88d098e5083329c5afdd6bf66f69c448b9f9be2

doc: correct CommonJS self-resolve spec PR-URL: https://github.com/nodejs/node/pull/33391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

Ruben Bridgewater

commit sha 37524307fe2025659f2172bf72cf4d7365b8b911

repl: remove deprecated .rli The .rli property is just a reference to the active REPL instance and it was deprecated for a long time. To improve maintainability of the REPL this feature is removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 4ace010b538877f2005dd7976f2c9e224ce7a026

repl: remove deprecated bufferedCommand property This property is deprecated since Node.js v9.0.0 and to improve maintainability of the REPL it is now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha a1bcad8dc061301718ca6e2bd026debe64911238

repl: remove deprecated repl.parseREPLKeyword() function This removes the deprecated REPLServer.parseREPLKeyword function. It is deprecated for a long time and should not provide any benefit to users. To improve the maintainability of the REPL module, it's now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha f217b2dfb08f6c1b64ae7cc05680161eadc4545b

repl: remove deprecated repl.turnOffEditorMode() function This function is deprecated for multiple years and provides very little benefit to users. Thus, it's removed to improve the maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha a416692e93054ad66af315f41647d36611e9ad03

repl: remove deprecated repl.memory function This removes the memory function. It is deprecated for a long time while not being really helpful being exposed. Thus, it is removed to improve maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 4 days

issue commentnodejs/node

flaky test-dgram-multicast-ssmv6-multi-process on linux

Because these problems can sometimes be host-specific: The host this is failing on is test-rackspace-ubuntu1604-x64-2

sam-github

comment created time in 4 days

push eventTrott/io.js

Anna Henningsen

commit sha 6f6bf010a7bfde32f4015758ae2f2af8b45cb612

src: use symbol to store `AsyncWrap` resource Use a symbol on the bindings object to store the public resource object, rather than a `v8::Global` Persistent. This has several advantages: - It’s harder to inadvertently create memory leaks this way. The garbage collector sees the `AsyncWrap` → resource link like a regular JS property, and can collect the objects as a group, even if the resource object should happen to point back to the `AsyncWrap` object. - This will make it easier in the future to use `owner_symbol` for this purpose, which is generally the direction we should be moving the `async_hooks` API into (i.e. using more public objects instead of letting internal wires stick out). PR-URL: https://github.com/nodejs/node/pull/31745 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Anna Henningsen

commit sha b6b82cba27da9ef83bfef67cac9d3593bd72c0e2

src: use enum for refed flag on native immediates Refs: https://github.com/nodejs/node/pull/33320#discussion_r423141443 PR-URL: https://github.com/nodejs/node/pull/33444 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Anna Henningsen

commit sha c45313b3ad47d7e7aa7d204d3ac002a5bbdf3bcb

worker: perform initial port.unref() before preload modules The refcount of the internal communication port is relevant for stdio, but the `port.unref()` call effectively resets any `.ref()` calls happening during stdio operations happening before it. Therefore, do the `.unref()` call before loading preload modules, which may cause stdio operations. Fixes: https://github.com/nodejs/node/issues/31777 PR-URL: https://github.com/nodejs/node/pull/33455 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Juan José Arboleda

commit sha 39ceb6ae785e274422369e3bf6834a896e10c232

src: remove unused headers in src/util.h PR-URL: https://github.com/nodejs/node/pull/33070 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

rickyes

commit sha 49f549e064e92c1db0392994d8a4636726d38a75

fs: replace checkPosition with validateInteger PR-URL: https://github.com/nodejs/node/pull/33277 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

Daniel Bevenius

commit sha 979ec425bd62df70e8e1409917f4ebf711fe104b

src: use MaybeLocal.ToLocal instead of IsEmpty This commit suggest using MaybeLocal.ToLocal and passing in the Local<Function> fun. The motivation for doing this is that the following MaybeLocal.ToLocalChecked call can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33457 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Geoffrey Booth

commit sha 51af89fe453738262e2c10c831705a385ec78530

module: fix check for package.json at volume root Fix package.json files at the volume root so that when they contain {"type": "module"}, they behave as documented, like such a package.json file in any other folder. Fixes: https://github.com/nodejs/node/issues/33438 PR-URL: https://github.com/nodejs/node/pull/33476 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

push time in 5 days

push eventTrott/node-slug

dependabot-preview[bot]

commit sha 2a32645168688894e26cf6765a713cdcf2122097

chore(deps-dev): bump karma from 5.0.8 to 5.0.9 (#57) Bumps [karma](https://github.com/karma-runner/karma) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.0.8...v5.0.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged Trott/node-slug

chore(deps-dev): bump karma from 5.0.8 to 5.0.9 dependencies

Bumps karma from 5.0.8 to 5.0.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/karma-runner/karma/releases">karma's releases</a>.</em></p> <blockquote> <h2>v5.0.9</h2> <h2><a href="https://github.com/karma-runner/karma/compare/v5.0.8...v5.0.9">5.0.9</a> (2020-05-19)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>dependencies:</strong> update to safe version of http-proxy (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3519">#3519</a>) (<a href="https://github.com/karma-runner/karma/commit/00347bb204c8c87e1096679af4634032d6600b67">00347bb</a>), closes <a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3510">#3510</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/karma-runner/karma/blob/master/CHANGELOG.md">karma's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/karma-runner/karma/compare/v5.0.8...v5.0.9">5.0.9</a> (2020-05-19)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>dependencies:</strong> update to safe version of http-proxy (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3519">#3519</a>) (<a href="https://github.com/karma-runner/karma/commit/00347bb204c8c87e1096679af4634032d6600b67">00347bb</a>), closes <a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3510">#3510</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/karma-runner/karma/commit/1c09f1c9cf0b6f1c3fb32680b21f91fd804dfc77"><code>1c09f1c</code></a> chore(release): 5.0.9 [skip ci]</li> <li><a href="https://github.com/karma-runner/karma/commit/4d7d924d7eca56647bb31624cddb3bb433c2b7fe"><code>4d7d924</code></a> chore(docs): add semantic-release badge (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3522">#3522</a>)</li> <li><a href="https://github.com/karma-runner/karma/commit/00347bb204c8c87e1096679af4634032d6600b67"><code>00347bb</code></a> fix(dependencies): update to safe version of http-proxy (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3519">#3519</a>)</li> <li><a href="https://github.com/karma-runner/karma/commit/9d661920405336c40af8edea7dddd6e2b84c68f2"><code>9d66192</code></a> chore: increase step timeout to prevent flakiness (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3518">#3518</a>)</li> <li>See full diff in <a href="https://github.com/karma-runner/karma/compare/v5.0.8...v5.0.9">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 5 days

push eventTrott/io.js

Bradley Farias

commit sha cd4985c488870f95488e6e7a94d280f8d7b1ecd5

esm: doc & validate source values for formats PR-URL: https://github.com/nodejs/node/pull/32202 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Bartosz Sosnowski

commit sha a4e273baf43910ba9e5c66949e56b919f8614fb9

win,fs: use namespaced path in absolute symlinks Use the namespaced (with the \\?\ prefix) paths for symlink targets when the path is absolute. This allows creation of symlinks to files with long filenames. Fixes: https://github.com/nodejs/node/issues/27795 PR-URL: https://github.com/nodejs/node/pull/33351 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 6 days

push eventTrott/io.js

Ruben Bridgewater

commit sha da7be6979e3cb097a75f8cf93895deb0f1002002

doc: fix readline key binding documentation The documentation for two key bindings was not correct. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Ruben Bridgewater

commit sha 9de08f773ec4efda54ca8c9e3bc4041bade7f46f

lib: update TODO comments This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Ruben Bridgewater

commit sha 76c5dc995e7853dc871df118beaea31ced3528aa

repl: support optional chaining during autocompletion This makes sure the autocompletion is able to handle optional chaining notations. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33450 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Ruben Bridgewater

commit sha 19d9e2003ec21b247ccfbb6e0014e1a968ddbd06

repl: simplify repl autocompletion This refactors the repl autocompletion code for simplicity and readability. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33450 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

push time in 7 days

push eventTrott/new.nodejs.org

Rich Trott

commit sha 1fae1d3286fdc7a0c0037128204783ae0d5cbfad

chore: remove performance section of ES6 page Information linked is out of date. Including an ES6 page is probably something that needs to be re-thought entirely. Fixes: https://github.com/nodejs/nodejs.org/issues/3176

view details

push time in 7 days

pull request commentnodejs/nodejs.org

chore: remove performance section of ES6 page

@nodejs/website

Trott

comment created time in 7 days

push eventTrott/new.nodejs.org

Node.js Crowdin Bot

commit sha fb8e1fbecfd65b8e999ffbe5a63fc3091eee499b

New Crowdin translations (#3112) * New translations releases.md (Spanish) * New translations code-and-learn.md (Spanish) * New translations collab-summit.md (Spanish) * New translations contribute.md (Spanish) * New translations index.md (Spanish) * New translations governance.md (Russian) * New translations security.md (Russian) * New translations site.json (Russian) * New translations releases.md (Russian) * New translations resources.md (Russian) * New translations trademark.md (Russian) * New translations es6.md (Spanish) * New translations index.md (Spanish) * New translations site.json (Russian) * New translations site.json (Russian) * New translations releases.md (Spanish) * New translations index.md (Spanish) * New translations index.md (Russian) * fix: Whitespce lints * New translations es6.md (Spanish) * New translations index.md (Spanish) * New translations contribute.md (Spanish) * New translations collab-summit.md (Spanish) * New translations community.md (Russian) * New translations trademark.md (Russian) Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Alexandr Tovmach <alexandrtovmach@gmail.com>

view details

Shelley Vohr

commit sha 17b3aeca9fe4ee60b809570d4364f24b7184e60e

Blog: v14.3.0 release post (#3185) Refs: https://github.com/nodejs/node/pull/33452

view details

dependabot-preview[bot]

commit sha 520d36e02896ec503e669f154776de972f989514

build(deps-dev): bump stylelint from 13.4.0 to 13.4.1 Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.4.0 to 13.4.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](https://github.com/stylelint/stylelint/compare/13.4.0...13.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Rich Trott

commit sha 4fee626de2a6228f43d4e5665681da433cc0982a

Merge branch 'master' into de-six-speed

view details

push time in 7 days

push eventTrott/io.js

delvedor

commit sha daa65fba7d413691d55051457993405457fa2f41

http: added scheduling option to http agent In some cases, it is preferable to use a lifo scheduling strategy for the free sockets instead of default one, which is fifo. This commit introduces a scheduling option to add the ability to choose which strategy best fits your needs. PR-URL: https://github.com/nodejs/node/pull/33278 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Daniel Bevenius

commit sha ff016fbd8391883a6bb43d0a661d1baafa33ce86

lib: update executionAsyncId/triggerAsyncId comment This commit updates the comment referring to the executionAsyncId/triggerAsyncId pair being stored in a std::stack. It looks like this was changed from std::stack to AliasedFloat64Array in Commit 83e5215a4e8438a43b9f0002b7a43e2fd2dd37a4 ("async_hooks: use typed array stack as fast path"). PR-URL: https://github.com/nodejs/node/pull/33396 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 3a5158878b910a9e2d61988ef82640db2a50c0ec

util: mark classes while inspecting them This outlines the basic class setup when inspecting a class. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/32332 Fixes: https://github.com/nodejs/node/issues/32270 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Pranshu Srivastava

commit sha 08308c7111b8accc77092999ad4c8fb63807c1f4

http2: do not modify explicity set date headers Fixes: https://github.com/nodejs/node/issues/30894 Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33160 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

rickyes

commit sha 1a12b82396c6c0747f8f5c96a28d019f774e0257

fs: refactor the import of internalUtil PR-URL: https://github.com/nodejs/node/pull/33296 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Jan Krems

commit sha 6961c7f804cad26b471d5f7c4c92b0861ba19f12

deps: update node-inspect to v2.0.0 Highlights: * Remove use of `process.binding` on modern node (@addaleax) * Increase timeout for port checking (@yilmazdurmaz) * Auto-resume on start when `NODE_INSPECT_RESUME_ON_START` is set (@dolsem) Compare: https://github.com/nodejs/node-inspect/compare/v1.11.6...v2.0.0 PR-URL: https://github.com/nodejs/node/pull/33447 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Anna Henningsen

commit sha d2a6f06dce724d24b0aa3c7a2821e4757002bffc

worker: use _writev in internal communication PR-URL: https://github.com/nodejs/node/pull/33454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha 37b4717728413e174ae3d295c74a5b443ca0d901

src: remove unnecessary else in base_object-inl.h This commit removes two unnecessary else statements in base_object-inl.h. It also tries to make the if statements consistent with regards to braces. PR-URL: https://github.com/nodejs/node/pull/33413 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Shelley Vohr

commit sha 81216a349d902dfef94878de75a6fe7ed1c90d1c

doc: claim ABI version 85 for Electron 11 PR-URL: https://github.com/nodejs/node/pull/33375 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Michael Dawson

commit sha 4c4c22635927d88eccab495b34564439dbdf50c7

src: prefer make_unique In most of the code base we use make_unique instead of new unique_ptr. Update node_platform.cc to be consistent with that. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33378 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

push time in 7 days

push eventTrott/common

Jonathan Johnson

commit sha 3d93e8aef47ff3fcfa3e159938398947a941cf18

Build weekly-calendar in a CSS Grid

view details

Jonathan Johnson

commit sha f000cd84705557e6a2afa9eb2f8a649c5cbd407a

Auto scroll to first events in the day

view details

Jonathan Johnson

commit sha 1fc85b85f81779eeb08c89b0ff85eb64f698a457

Account for multiple events in the same time block When there is more than one event during that portion of a day each event is reduced and moved around depending on it's order.

view details

Jonathan Johnson

commit sha 611bcf7269e40984c4e3b5717044676bc74beed9

Extract day names from calendar grid Pulling them into their own row in the top grid allowed the calendar to scroll on it's own with fixed day headers in place.

view details

Jonathan Johnson

commit sha 61522fc49ba5322314138256bbee1f4954cbd428

Snap scroll to hours At each point in the calendar the top of the hour will be the place scrolling stops.

view details

Jonathan Johnson

commit sha c8179bb24701bad59a11ea53ad9cf0235d3d99eb

Fix alignment of hours These were off by a bit from the previous calendar grid that included the days of the week.

view details

Jonathan Johnson

commit sha 30450fc6c878bb3dbfa51a082517f26b876f445a

Remove unused css

view details

Jonathan Johnson

commit sha 1d3ce880465caa208e728ab1998f267dec9e1f53

Fix scrolling first events into view Scroll the hour of the first event in the schedule no matter where it is in the DOM. Scrolling to the hour snaps the scroll better than scrolling to the event directly.

view details

Jonathan Johnson

commit sha 6d59ab9331de0eb05cccc285310b866c5bfc5d76

Add bordered to weekly calendar Lines up hours and days much more clearly.

view details

Jonathan Johnson

commit sha 3f3b755a8f913350ed7c57eb0fe19c6c57a3ed83

Replace weekly calendar

view details

Jonathan Johnson

commit sha 05ee0fe21b236d2367fc08fc3b3242cb5f58e851

Fix same time events calculation Passing in the index creates havoc with non conflicting events later in the day. We can actually use the event object itself to discover it's position since these arrays are from the same source.

view details

Jonathan Johnson

commit sha e3d5095e505bcf4eff8c030f1de9d4955e33b73d

Less space in weekly calendar This matches with our current calendar which does not take up as much space for each hour.

view details

Jonathan Johnson

commit sha 08d341d62d5edb515f6a5512e5206621568626cf

Improve scroll to first event Going strictly by startDate doesn't work because something on Monday at 11pm will come before something on Tuesday at 6am.

view details

Jonathan Johnson

commit sha dc6277c0cdd4016754e6ddefd9160ef4644c056d

Calculate grid row in JS Applying this by class required thousands of lines of CSS most of which were never going to be used. Instead we can place events on the grid using JS.

view details

Jonathan Johnson

commit sha 8304cdd83f125b44cb0c31e23594bd445da30bc4

Fix border and spacing issues at smaller screen sizes

view details

Jonathan Johnson

commit sha 5caf15f0d3a580a59a66cb275e23582f472d699e

Improve fill calculations Calculate event conflicts for each minute of the day to determine the size of each event. This better handles events that stretch across several clusters.

view details

Jonathan Johnson

commit sha 3b87f3d723720710568d02b4b255ae71a373f745

Don't take up the whole page 100vh doesn't leave any room for other stuff on the screen.

view details

Jonathan Johnson

commit sha 3f3ba43162a874c3696c41ac638daca265204f0c

Add a border to all events This gives the appearance of a little bit of space between each event.

view details

Jonathan Johnson

commit sha 0248e2a0a04761dca7ced6624b2cf9f99770a3ba

Improve style of hour labels

view details

Jonathan Johnson

commit sha 868b591faf5cb39af786bb8764f6f0311d322ca6

Add real tests for weekly-calendar

view details

push time in 7 days

push eventTrott/cli

Kat Marchán

commit sha f91024e1135c120d78ef239bf3eaa2e2152f8fae

npm-registry-fetch@3.9.0 Make sure publishing with legacy username:password _auth works again

view details

Daijiro Wachi

commit sha a86d0970f885286c5aba495e072975837bbf3feb

doc: use const in lib/fetch-package-metadata.md (#120) PR-URL: https://github.com/npm/cli/pull/120 Credit: @watilde Reviewed-By: @aeschright

view details

Daijiro Wachi

commit sha 1305bb68bed35745b8426a132719934af1efd4d2

misc: replace ronn with marked-man (#126) PR-URL: https://github.com/npm/cli/pull/126 Credit: @watilde Reviewed-By: @aeschright

view details

Eli Doran

commit sha cb8707a3d507ada2d4e60bef5e588ebb2b88c29c

Reduce work to test if executable ends with a 'g'. (#138) PR-URL: https://github.com/npm/cli/pull/138 Credit: @elidoran Reviewed-By: @aeschright

view details

Lars Willighagen

commit sha 75dce4c8c486bda402933ec9986efd919a1e635c

test(maketest): Fix common.npm callback arguments (#144) PR-URL: https://github.com/npm/cli/pull/144 Credit: @larsgw Reviewed-By: @aeschright

view details

Tobias Koppers

commit sha 88cc4fc97f50afd60249516e1c3a1ef32ae48a9a

install/dedupe: fix hoisting of packages with peerDeps (#147) PR-URL: https://github.com/npm/cli/pull/147 Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794 Credit: @sokra Reviewed-By: @aeschright

view details

Lars Willighagen

commit sha e37c0cd071b0ce78c3712907c78c2fc1981bed8a

ls: show installed but unmet peer deps (#145) PR-URL: https://github.com/npm/cli/pull/145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

view details

Grey Baker

commit sha aa32239aed86fc5c65f02823d7bb5cb52f647bfb

doc: update package.json docs to include repository.directory details (#140) PR-URL: https://github.com/npm/cli/pull/140 Credit: @greysteil Reviewed-By: @aeschright

view details

Kat Marchán

commit sha 4cf850d2be118abce72b3cf533f13512e9844ad1

token: use figgy-config to make sure extra opts are there (#149) PR-URL: https://github.com/npm/cli/pull/149 Credit: @zkat Reviewed-By: @aeschright

view details

Audrey Eschright

commit sha ad0a1b23b45900b476d24c7e3d7f1054dec829c8

pacote@9.4.1

view details

Audrey Eschright

commit sha 7d6b7e2e62e4971fd70bad0bf301ef51610124b3

chore: add changelog for v6.8.0

view details

Audrey Eschright

commit sha 9123ee2b5df23fe10b890964dd637958fe0b2451

update AUTHORS

view details

Audrey Eschright

commit sha 87d801e9835ca798082a929dfccca7d816143f10

6.8.0-next.0

view details

Kat Marchán

commit sha 7e7a09d63db44f3972622a58d5642b27fc7141f1

access: ls-collaborators is ok with non-scoped (#151) PR-URL: https://github.com/npm/cli/pull/151 Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101 Credit: @zkat Reviewed-By: @aeschright

view details

Audrey Eschright

commit sha 580e97e95e5cef365522021ef9675aa46689953e

normalize-package-data@2.5.0

view details

Audrey Eschright

commit sha f492bb3e41517925ff82bb5e058dd539d5a7353c

npm-packlist@1.3.0

view details

Audrey Eschright

commit sha a6f62bf9e151c75e1271ec44d1f5c1548cf09518

chore: update changelog for 6.8.0

view details

Audrey Eschright

commit sha 1cc6a0346114875b9e23ff3926c839f37e147d7e

6.8.0-next.1

view details

JT Turner

commit sha bbda492d16ccef11ca899e3069d0f82034f076db

Fix issue with sub folder local references (#86) PR-URL: https://github.com/npm/cli/pull/86 Fixes: https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754 Credit: @iarna Credit: @jhecking Reviewed-By: @aeschright

view details

Audrey Eschright

commit sha 9332db67ced83270c9fe2d40c40a438b6b84ac44

chore: update changelog for 6.8.0

view details

push time in 7 days

created tagTrott/node-slug

tagv3.0.1

slugifies even utf-8 chars!

created time in 7 days

push eventTrott/node-slug

Rich Trott

commit sha 0890ccaab9a76ec2223ce3a65adc11ea8dad759d

fix: remove erroneous "bin" entry in package.json

view details

Rich Trott

commit sha b138f83814f610a3bbb7d858c303ecab2b2c0675

chore: prep changelog for 3.0.1

view details

Rich Trott

commit sha ede010cbb3a18ff38b8b8b0abf63c01a763268b3

3.0.1

view details

push time in 7 days

issue commentTrott/node-slug

Not SEO-friendly for mandarin(zh) and hindi(hi)

I just published 3.0.0, so if you upgrade, you'll have Hindi support.

sakulstra

comment created time in 7 days

push eventTrott/node-slug

Rich Trott

commit sha 9ef5df57fd84644ddf498564e3e37c43e9eac15a

chore: changelog for 3.0.0

view details

Rich Trott

commit sha c4489be4bbbf8a8401417c210f9680273f64e69a

3.0.0

view details

push time in 7 days

created tagTrott/node-slug

tagv3.0.0

slugifies even utf-8 chars!

created time in 7 days

pull request commentnodejs/node

readline: add postprocess callback

@nodejs/repl

devsnek

comment created time in 7 days

Pull request review commentnodejs/node

readline: add postprocess callback

 function completer(linePartial, callback) { } ``` +### Use of the `postprocessor` Function

Actually, nope, the way you have it now is probably better.

devsnek

comment created time in 7 days

Pull request review commentnodejs/node

readline: add postprocess callback

 function completer(linePartial, callback) { } ``` +### Use of the `postprocessor` Function
### Use of `postprocessor()`
devsnek

comment created time in 7 days

Pull request review commentnodejs/node

readline: add postprocess callback

 changes:   * `output` {stream.Writable} The [Writable][] stream to write readline data     to.   * `completer` {Function} An optional function used for Tab autocompletion.+  * `postprocessor` {Function} an optional function used to process the current
  * `postprocessor` {Function} An optional function used to process the current
devsnek

comment created time in 7 days

push eventnodejs/nodejs.org

Node.js Crowdin Bot

commit sha fb8e1fbecfd65b8e999ffbe5a63fc3091eee499b

New Crowdin translations (#3112) * New translations releases.md (Spanish) * New translations code-and-learn.md (Spanish) * New translations collab-summit.md (Spanish) * New translations contribute.md (Spanish) * New translations index.md (Spanish) * New translations governance.md (Russian) * New translations security.md (Russian) * New translations site.json (Russian) * New translations releases.md (Russian) * New translations resources.md (Russian) * New translations trademark.md (Russian) * New translations es6.md (Spanish) * New translations index.md (Spanish) * New translations site.json (Russian) * New translations site.json (Russian) * New translations releases.md (Spanish) * New translations index.md (Spanish) * New translations index.md (Russian) * fix: Whitespce lints * New translations es6.md (Spanish) * New translations index.md (Spanish) * New translations contribute.md (Spanish) * New translations collab-summit.md (Spanish) * New translations community.md (Russian) * New translations trademark.md (Russian) Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Alexandr Tovmach <alexandrtovmach@gmail.com>

view details

Shelley Vohr

commit sha 17b3aeca9fe4ee60b809570d4364f24b7184e60e

Blog: v14.3.0 release post (#3185) Refs: https://github.com/nodejs/node/pull/33452

view details

dependabot-preview[bot]

commit sha 520d36e02896ec503e669f154776de972f989514

build(deps-dev): bump stylelint from 13.4.0 to 13.4.1 Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.4.0 to 13.4.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](https://github.com/stylelint/stylelint/compare/13.4.0...13.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Rich Trott

commit sha 247340f402d1cecd1afa859c6f2b0a4d3d4cb4a9

Merge branch 'master' into canalina-gyp-guide

view details

push time in 7 days

pull request commentnodejs/nodejs.org

chore: add Catalina native dependencies guide

@Trott agreed, but at the same time I'm not sure where else we could add this link, and I think it's important for this to be linked on the website since it's quite easy for Catalina users to hit the issue. We could add it in the front page, but that might be a little too much.

Yeah, I don't have a better suggestion and I'm totally fine with this. If a better place is identified later, it can always be moved or added there as well.

mmarchini

comment created time in 7 days

push eventnodejs/nodejs.org

dependabot-preview[bot]

commit sha 520d36e02896ec503e669f154776de972f989514

build(deps-dev): bump stylelint from 13.4.0 to 13.4.1 Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.4.0 to 13.4.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](https://github.com/stylelint/stylelint/compare/13.4.0...13.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 7 days

delete branch nodejs/nodejs.org

delete branch : dependabot/npm_and_yarn/stylelint-13.4.1

delete time in 7 days

PR merged nodejs/nodejs.org

build(deps-dev): bump stylelint from 13.4.0 to 13.4.1 dependencies

Bumps stylelint from 13.4.0 to 13.4.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/stylelint/stylelint/releases">stylelint's releases</a>.</em></p> <blockquote> <h2>13.4.1</h2> <ul> <li>Fixed: <code>time-min-milliseconds</code> TypeError for <code>ignore: ["delay"]</code> and shorthand animation (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/pull/4783">#4783</a>).</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md">stylelint's changelog</a>.</em></p> <blockquote> <h2>13.4.1</h2> <ul> <li>Fixed: <code>time-min-milliseconds</code> TypeError for <code>ignore: ["delay"]</code> and shorthand animation (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/pull/4783">#4783</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/stylelint/stylelint/commit/6818c532775b05722e3c1979016bb5c0038b2ca1"><code>6818c53</code></a> 13.4.1</li> <li><a href="https://github.com/stylelint/stylelint/commit/7cf23e2969e15a6d28511fc606df0a64e2e92143"><code>7cf23e2</code></a> Prepare 13.4.1</li> <li><a href="https://github.com/stylelint/stylelint/commit/33f3633b61eb144d8a46d2ebf3281eb956dfecc8"><code>33f3633</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/stylelint/stylelint/commit/90d4fe2683b4d4367e21e9f09380d2a787c1d94a"><code>90d4fe2</code></a> Fix TypeError for shorthand animation in time-min-milliseconds (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4783">#4783</a>)</li> <li><a href="https://github.com/stylelint/stylelint/commit/f88bcd5872dcc9535e7fc942c5ed4a9268d50183"><code>f88bcd5</code></a> Docs - update WordPress URL (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4785">#4785</a>)</li> <li><a href="https://github.com/stylelint/stylelint/commit/f06fab1256f648be8cd23f7993e25d643db8d8c4"><code>f06fab1</code></a> Bump got from 11.1.3 to 11.1.4 (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4788">#4788</a>)</li> <li>See full diff in <a href="https://github.com/stylelint/stylelint/compare/13.4.0...13.4.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 7 days

push eventnodejs/nodejs.org

Shelley Vohr

commit sha 17b3aeca9fe4ee60b809570d4364f24b7184e60e

Blog: v14.3.0 release post (#3185) Refs: https://github.com/nodejs/node/pull/33452

view details

Rich Trott

commit sha 31d4180af545a2c3cdb1321c54b8db32d5a00c36

Merge branch 'master' into dependabot/npm_and_yarn/stylelint-13.4.1

view details

push time in 7 days

pull request commentnodejs/node

tools,doc: fix version picker in docs to show all available versions

You might need to watch out that that might end up in out/ and get mixed in with non-doc build artifacts.

Yeah, I was thinking I might need to create another outer directory in the build process, which can then cascade to changes in all kinds of places. :-(

Trott

comment created time in 7 days

push eventTrott/io.js

Richard Townsend

commit sha 66807e995de9a16b1cfe035f76958a178c381854

tools,gyp: add support for MSVC cross-compilation This change means that GYP can now generate two sets of projects: one exclusively for a host x64 machine and one containing a mix of x64 and Arm targets. The names of host targets are fixed up to end with _host.exe, and any actions involving them are fixed up. This allows compilation of Node on an x64 server for a Windows on Arm target. PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>

view details

Richard Townsend

commit sha 883355125766e35126006507d1d8a09c149fc71d

build,win: add support for MSVC cross-compilation * Fixes cases in icutools where commands were issued without .exe * Changes to build scripts * Add /fp:strict flag so that MSVC's floating point behaves correctly * Enables marmasm PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>

view details

Shelley Vohr

commit sha c841f516d530f31328b1f734428561d93bb14f4c

2020-05-19, Version 14.3.0 (Current) Notable changes: async_hooks: * (SEMVER-MINOR) move PromiseHook handler to JS (Stephen Belanger) https://github.com/nodejs/node/pull/32891 cli: * (SEMVER-MINOR) add `--trace-atomics-wait` flag (Anna Henningsen) https://github.com/nodejs/node/pull/33292 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) https://github.com/nodejs/node/pull/33134 http: * (SEMVER-MINOR) expose http.validate-header-name/value (osher) https://github.com/nodejs/node/pull/33119 repl: * (SEMVER-MINOR) deprecate repl._builtinLibs (Ruben Bridgewater) https://github.com/nodejs/node/pull/33294 * (SEMVER-MINOR) deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) https://github.com/nodejs/node/pull/33294 * (SEMVER-MINOR) show reference errors during preview (Ruben Bridgewater) https://github.com/nodejs/node/pull/33282 * (SEMVER-MINOR) improve repl preview (Ruben Bridgewater) https://github.com/nodejs/node/pull/33282 src: * add support for TLA (Gus Caplan) https://github.com/nodejs/node/pull/30370 PR-URL: https://github.com/nodejs/node/pull/33452

view details

Anna Henningsen

commit sha 7c755b06cee4cf3c3e3841fb891670122f50ee24

build: run full test suite in ASAN action Refs: https://github.com/nodejs/node/pull/32776 PR-URL: https://github.com/nodejs/node/pull/33170 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Daniel Bevenius

commit sha 61189d3981ef49885f8d98eef2ac0207b6e59f40

src: reduce duplication in RegisterHandleCleanups This commit suggest using a lambda for the RegisterHandlerCleanup calls in RegisterHandleCleanups. The motivation is to reduce some duplication and to make it a little easier to read as all of the calls pass in the same arguments, apart from casting the uv handle. PR-URL: https://github.com/nodejs/node/pull/33421 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 0e92ae64f01140bc527b5a02d7f154dca882ef09

worker: fix race condition in node_messaging.cc `AddToIncomingQueue()` relies on `owner_` only being modified with `mutex_` being locked, but in these two places, that didn’t happen. Modify them to use `Detach()` instead, which has the same effect as setting `owner_ = nullptr` here, but does it with proper locking. This race condition probably only shows up in practice when Node.js is compiled in debug mode, because the compiler eliminates the duplicate load in `AddToIncomingQueue()` when compiling with optimizations enabled. PR-URL: https://github.com/nodejs/node/pull/33429 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Pranshu Srivastava

commit sha ee8756760cf788a7a22091613597c03dceeb3e24

http2: comment on usage of `Object.create(null)` Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Tobias Nießen

commit sha 1786504afa068b2b6591f23799dadd4e867cc529

doc: fix typos in handle scope descriptions PR-URL: https://github.com/nodejs/node/pull/33267 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ethan Arrowood

commit sha 38f444060b0527afe5dccc44ee2db55c73c62e57

doc: add fs.open() multiple constants example PR-URL: https://github.com/nodejs/node/pull/33281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Antoine du Hamel

commit sha a82001a387afa133590420c98efb6b87ad320bfb

doc: document module.path Refs: https://github.com/nodejs/node/pull/26970 Fixes: https://github.com/nodejs/node/issues/33270 PR-URL: https://github.com/nodejs/node/pull/33323 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 8 days

pull request commentnodejs/node

tools,doc: fix version picker in docs to show all available versions

The version picker for the single page (all.html) seems to pick the non-single page (index.html) which is different from before.

Thanks. I'll take a look at that.

Trott

comment created time in 8 days

pull request commentnodejs/node

tools,doc: fix version picker in docs to show all available versions

The idea is sound but this PR currently writes the new version picker files (plural, one for each html file) into the same directory as apilinks.json (i.e. one directory up from api/) and that directory is not shared between different doc versions, e.g. https://nodejs.org/docs/latest-v14.x/ is separate from https://nodejs.org/docs/latest-v12.x/.

Argh, OK, so ../.. instead of .. and hope there aren't any symlinks....

Trott

comment created time in 8 days

push eventTrott/io.js

Joyee Cheung

commit sha 8b0bdc918ec2731db34cebc934b96e0e4ad2b1a6

doc: clarify about the Node.js-only extensions in perf_hooks - Add clarifications for Node.js-only extensions - Explain the Web Performance APIs implemented in Node.js and clarify that perf_hooks also include other non-Web APIs. - Prefix exposed interfaces with `perf_hooks.` to distinguish them from internal classes. PR-URL: https://github.com/nodejs/node/pull/33199 Refs: https://github.com/nodejs/node/issues/28635 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Shelley Vohr

commit sha ed9be3ab477e977f973504955897c23d578b276c

deps: update icu to include tzdata2020a PR-URL: https://github.com/nodejs/node/pull/33362 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>

view details

cjihrig

commit sha 227ad25cc684d3dcde82c2f370ab25d3d06364b3

deps: upgrade to libuv 1.38.0 Notable changes: - `uv_library_shutdown()` has been added. - `uv_udp_init_ex()` now accepts `UV_UDP_RECVMMSG`, although it is a no-op. - Obsolete `MAX_PATH` restrictions have been removed on Windows, and Windows is now long path aware. - Windows environment variables longer than 32,767 characters are now supported. - Linux `cpu_times` are now reported as milliseconds to match other platforms. - A memory leak resulting from `uv_loop_init()` failures has been fixed. PR-URL: https://github.com/nodejs/node/pull/33446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha 3abb52fdb683c9c9ade1b2c7d16d0f640bbaacfd

deps: update to uvwasi 0.0.9 Notable changes: - A `DEBUG()` macro and `UVWASI_DEBUG_LOG` build option have been added to improve debugging. - Path length restrictions have been removed across the codebase. - Initial support for `poll_oneoff()` has been added on all platforms. The implementation is based on `uv_poll_t`'s. - A new `uvwasi_size_t` has been introduced across the WASI system call API. This provides consistent 32-bit `size_t`'s. - The cmake test targets are now only generated if uvwasi is the root project to avoid conflicts with targets from embedders. - `uv.h` has been removed from the public headers. - A serialization/deserialization API has been added to simplify the process of working with WASM memory. This also hides many WASI <--> WASM interfacing implementation details from embedders. - A memory corruption bug on Windows related to path resolution has been fixed. PR-URL: https://github.com/nodejs/node/pull/33445 Fixes: https://github.com/nodejs/node/issues/33403 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Benjamin Gruenbaum

commit sha b51d1cfbf27529346c7134f8fc4a855229543cc2

doc: add comment about highWaterMark limit Add a comment regarding memory limits and setting highWaterMark PR-URL: https://github.com/nodejs/node/pull/33432 Reviewd-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Jonathan Buhacoff

commit sha d093e788d188d0affffebb016ef8e50fda678ab6

doc: update function description for `decipher.setAAD` According to the [NodeJS CCM example](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode], when decrypting the `plaintextLength` parameter actually refers to the ciphertext length, not the plaintext length: ``` decipher.setAAD(aad, { plaintextLength: ciphertext.length }); ``` The same can be seen in the [OpenSSL docs](https://wiki.openssl.org/index.php/EVP_Authenticated_Encryption_and_Decryption) where a call to `EVP_DecryptUpdate` passes the ciphertext length: ``` /* Provide the total ciphertext length */ if(1 != EVP_DecryptUpdate(ctx, NULL, &len, NULL, ciphertext_len)) handleErrors(); ``` This parameter probably should have been called `inputLength` or `bufferLength` instead of `plaintextLength`, so that it makes sense both when encrypting and decrypting, but at least we can correct the sentence in the documentation for now to refer to the correct value. PR-URL: https://github.com/nodejs/node/pull/33095 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 8 days

pull request commentnodejs/nodejs.org

chore: add Catalina native dependencies guide

I don't think this page is a likely place for someone to look for this information, but I don't have a better idea, so not a blocking comment by any means. Just wondering aloud in case someone else has a good idea of where to include this either additionally or instead of this location. Looks good to me as far as the change itself goes.

mmarchini

comment created time in 8 days

Pull request review commentnodejs/remark-preset-lint-node

feat: prohibit missing info string

 module.exports.plugins = [   require("remark-lint-checkbox-content-indent"),   [require("remark-lint-code-block-style"), "fenced"],   require("remark-lint-definition-spacing"),-  require("remark-lint-fenced-code-flag"),+  [require("remark-lint-fenced-code-flag"), { allowEmpty: false }],

Seems worth a shot. Start with every string we have now, and then open PRs removing ones we don't want one at a time? Like, maybe change all txt to text first (or vice versa)?

DerekNonGeneric

comment created time in 8 days

pull request commentnodejs/nodejs.org

chore: remove performance section of ES6 page

@alexandrtovmach Am I doing this right? Or do these changes need to go through Crowdin somehow?

@zeke

Trott

comment created time in 8 days

pull request commentnodejs/nodejs.org

chore: remove performance section of ES6 page

@alexandrtovmach Am I doing this right? Or do these changes need to go through Crowdin somehow?

Trott

comment created time in 8 days

PR opened nodejs/nodejs.org

chore: remove performance section of ES6 page

Information linked is out of date. Including an ES6 page is probably something that needs to be re-thought entirely.

Fixes: https://github.com/nodejs/nodejs.org/issues/3176

@fhinkel

+0 -73

0 comment

9 changed files

pr created time in 8 days

create barnchTrott/new.nodejs.org

branch : de-six-speed

created branch time in 8 days

issue commentnodejs/nodejs.org

doc: refer to not-up-to-date website: six-speed

I suspect the ES6 page should be removed entirely. It was a big and important thing when io.js forked and shortly after the merge back with Node.js. But it has been some time since it's been worth such a big call out, I think. Anyway, I'll open PR to remove the six-speed stuff. Thanks!

Ardeshir81

comment created time in 8 days

pull request commentnodejs/node

docs, errors, http, tests: fixed socket.setEncoding fatal error

@nodejs/http-parser @nodejs/http This could use some reviews.

iSkore

comment created time in 8 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-05-21

Let's hear some strategic initiative updates!

Current Initiatives

Initiative Champion Links
Modules Myles Borins https://github.com/nodejs/modules
Core Promise APIs Matteo Collina
V8 Currency Michaël Zasso
QUIC / HTTP3 James M Snell https://github.com/nodejs/quic
Startup performance Joyee Cheung https://github.com/nodejs/node/issues/17058 https://github.com/nodejs/node/issues/21563
Build resources Michael Dawson https://github.com/nodejs/build/issues/1154#issuecomment-448418977

@MylesBorins @mcollina @targos @jasnell @joyeecheung @mhdawson

mhdawson

comment created time in 8 days

issue commentnodejs/node

Inconsistent use of plaintext code fencing in docs

(Previous comment deleted. Wrong issue. Obviously. Sorry.)

zeke

comment created time in 8 days

issue commentnodejs/node

Inconsistent use of plaintext code fencing in docs

Let's hear some strategic initiative updates!

Current Initiatives

Initiative Champion Links
Modules Myles Borins https://github.com/nodejs/modules
Core Promise APIs Matteo Collina
V8 Currency Michaël Zasso
QUIC / HTTP3 James M Snell https://github.com/nodejs/quic
Startup performance Joyee Cheung https://github.com/nodejs/node/issues/17058 https://github.com/nodejs/node/issues/21563
Build resources Michael Dawson https://github.com/nodejs/build/issues/1154#issuecomment-448418977

@MylesBorins @mcollina @targos @jasnell @joyeecheung @mhdawson

zeke

comment created time in 8 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-05-21

Moderation Team Update: Some internal discussions around things we're keeping an eye on, but no moderation actions this week. @nodejs/moderation @nodejs/tsc @nodejs/community-committee

mhdawson

comment created time in 8 days

push eventnodejs/TSC

Michael Dawson

commit sha e4a8b95b2594ec4eed9ccda7dc953ef334d8f84d

doc: add minutes from meeting 14 May 2020 (#866) Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

view details

push time in 8 days

PR merged nodejs/TSC

doc: add minutes from meeting 14 May 2020

Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com

+125 -0

0 comment

1 changed file

mhdawson

pr closed time in 8 days

issue closednodejs/build

FreeBSD build timed out, failing

https://ci.nodejs.org/job/node-test-commit-freebsd/27478/nodes=freebsd11-x64/console

00:10:22 Build timed out (after 6 minutes). Marking the build as failed.
00:10:22 Build was aborted

Same thing at https://ci.nodejs.org/job/node-test-commit-freebsd/27409/nodes=freebsd11-x64/console.

Two build failures in a week is not too bad, really, but would love to know the cause and if there's potential mitigation. (Does we just need to increase the timeout and everything will be fine?)

/ping @nodejs/platform-freebsd in case someone wants to dig on on this.

closed time in 8 days

Trott

issue commentnodejs/build

FreeBSD build timed out, failing

I haven't seen this in a while, so I'll close. Feel free to re-open if I'm wrong and this is still A Thing.

Trott

comment created time in 8 days

Pull request review commentnodejs/admin

docs: update Calendar maintainers, adding Emeritus

 The currently active members of the [Social Team](./social-team.md):  - [@bnb](https://github.com/bnb) - **Tierney Cyren** -## Node.js Foundation Calendar-A calendar of The Foundation's meetings can be found at:+## Node.js Project Calendar++A calendar of the project's meetings can be found at:  https://nodejs.org/calendar  <sup>Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.</sup> -The calendar is maintained by:+All calendar maintainers have `Make changes AND manage sharing` permissions. If you would like to help maintain your team's calendar events, open a PR adding your name to the list above. Once approved, one of the calendar maintainers will add you to the calendar settings.++This list should be reviewed and pruned annually (at minimum). The calendar has a yearly recurring event on Jan 31st for this. An issue should be opened asking the calendar maintainers for their continued volunteering efforts (directly @-mention all members). After 1 week, this list should be PRed removing members that did not respond. [The calendar permissions to be updated once merged](https://support.google.com/a/answer/117596?hl=en).++### Calendar Maintainers+ <!-- sorted by GitHub handle -->-- [@amiller-gh](https://github.com/amiller-gh) - **Adam Miller**-- [@bamieh](https://github.com/bamieh) - **Ahmad Bamieh** - [@bethgriggs](https://github.com/bethgriggs) - **Beth Griggs** - [@bnb](https://github.com/bnb) - **Tierney Cyren**-- [@dshaw](https://github.com/dshaw) - **Dan Shaw** - [@gibfahn](https://github.com/gibfahn) - **Gibson Fahnestock**-- [@hackygolucky](https://github.com/hackygolucky) - **Tracy Hinds**-- [@maddhruv](https://github.com/maddhruv) - **Dhruv Jain** - [@mcollina](https://github.com/mcollina) - **Matteo Collina** - [@mhdawson](https://github.com/mhdawson) - **Michael Dawson** - [@MylesBorins](https://github.com/MylesBorins) - **Myles Borins** - [@ryanmurakami](https://github.com/ryanmurakami) - **Ryan Lewis** - [@trott](https://github.com/trott) - **Rich Trott**-- [@williamkapke](https://github.com/williamkapke) - **William Kapke** -All calendar maintainers have `Make changes AND manage sharing` permissions. If you would like to help maintain your team's calendar events, open a PR adding your name to the list above. Once approved, one of the calendar maintainers will add you to the calendar settings.+### Emeritus Calendar Mainters

If you do keep it, please correct the spelling of Maintainers. I'm still in favor of removing it. But it's fine by me to leave it in if I'm the only one who feels that way!

bnb

comment created time in 8 days

Pull request review commentnodejs/remark-preset-lint-node

feat: prohibit missing info string

 module.exports.plugins = [   require("remark-lint-checkbox-content-indent"),   [require("remark-lint-code-block-style"), "fenced"],   require("remark-lint-definition-spacing"),-  require("remark-lint-fenced-code-flag"),+  [require("remark-lint-fenced-code-flag"), { allowEmpty: false }],

According to the README for remark-lint-fenced-code-flag, the default value of allowEmpty is false. Either this is basically a no-op or I'm missing something.

DerekNonGeneric

comment created time in 8 days

PR opened nodejs/node

tools,doc: fix version picker in docs to show all available versions

Quickly slapped-together proof-of-concept but I want feedback on the general idea/approach, so here's a draft PR.

Current situation is that we hard code the version picker into the docs at build time. This results in a confusing user experience described (partially--there are other oddities not described in there, I think) in https://github.com/nodejs/node/issues/32077.

This change moves the version picker into a separate JS file that is one directory above the docs so all versions of the docs can share. Since older versions (say, version 10.x) are smart enough to detect newer relevant releases (say, version 14.x) at build time, these JS files will always be up to date.

TODO:

  • [ ] Confirm that these one-directory-up files will be moved to the web server on release. If not, then we need to add that to the release job/process.
  • [ ] Replace document.write() and render-blocking <script> tag with a non-blocking approach

@codebytere @richardlau @rvagg @nschonni @XhmikosR @alexandrtovmach

To test locally: make doc-only and then open out/doc/api/index.html in a web browser. (The resulting HTML files will work offline. No need to spin up a web server. Or at least that's my experience on macOS.)

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+39 -11

0 comment

2 changed files

pr created time in 8 days

push eventTrott/io.js

Robert Nagy

commit sha 2361b5c041893cae3f84e412b67e4978af7af3c7

stream: forward writableObjectMode Duplex did not properly forward writableObjectMode. Fixes: https://github.com/nodejs/node/issues/33388 PR-URL: https://github.com/nodejs/node/pull/33390 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Andrew Paprocki

commit sha fe1b9e09a845e24556f417553b4b434636fdd5ee

doc: document ICU time zone data update process Updates the "Maintaining ICU" document and describes the process to update an existing ICU `.dat` file with updated binary time zone data files corresponding to new IANA `tzdata` releases. Requested in nodejs/node#30211 by @srl295 PR-URL: https://github.com/nodejs/node/pull/30364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>

view details

push time in 8 days

create barnchTrott/io.js

branch : version-picker

created branch time in 8 days

push eventTrott/solr-proxy

Rich Trott

commit sha 3eea85f5049ee2572d9f2a70b1b2043b2fd11e5d

chore: CHANGELOG update for 3.0.0

view details

Rich Trott

commit sha 0c50a1d8fea2b90fc898eb467de14022e131c142

3.0.0

view details

push time in 8 days

created tagTrott/solr-proxy

tagv3.0.0

Reverse proxy to secure Solr, rejecting requests that might modify the Solr index.

created time in 8 days

push eventTrott/solr-proxy

Rich Trott

commit sha 16b4327649fa52e06287c5081e9340dae5488824

2.1.2

view details

push time in 8 days

created tagTrott/solr-proxy

tagv2.1.2

Reverse proxy to secure Solr, rejecting requests that might modify the Solr index.

created time in 8 days

delete tag Trott/solr-proxy

delete tag : v2.1.2

delete time in 8 days

created tagTrott/solr-proxy

tagv2.1.2

Reverse proxy to secure Solr, rejecting requests that might modify the Solr index.

created time in 8 days

push eventTrott/solr-proxy

Rich Trott

commit sha d15f190326ce14d0ee5cef6b015526e80b11e08a

chore: update minimist to 1.2.5

view details

push time in 8 days

push eventTrott/solr-proxy

dependabot-preview[bot]

commit sha c171eabf36cb8ced667a9d98db74a79446f0ffe7

Bump http-proxy from 1.18.0 to 1.18.1 Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Rich Trott

commit sha 23f33c985713c3c7edcbe99c7c8d00be87f427a6

Merge pull request #61 from Trott/dependabot/npm_and_yarn/http-proxy-1.18.1 Bump http-proxy from 1.18.0 to 1.18.1

view details

push time in 8 days

PR merged Trott/solr-proxy

Bump http-proxy from 1.18.0 to 1.18.1 dependencies

Bumps http-proxy from 1.18.0 to 1.18.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md">http-proxy's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/http-party/node-http-proxy/compare/1.18.0...v1.18.1">v1.18.1</a> - 2020-05-17</h2> <h3>Merged</h3> <ul> <li>Skip sending the proxyReq event when the expect header is present <a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/pull/1447"><code>#1447</code></a></li> <li>Remove node6 support, add node12 to build <a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/pull/1397"><code>#1397</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/http-party/node-http-proxy/commit/9b96cd725127a024dabebec6c7ea8c807272223d"><code>9b96cd7</code></a> 1.18.1</li> <li><a href="https://github.com/http-party/node-http-proxy/commit/335aeeba2f0c286dc89c402eeb76af47834c89a3"><code>335aeeb</code></a> Skip sending the proxyReq event when the expect header is present (<a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/issues/1447">#1447</a>)</li> <li><a href="https://github.com/http-party/node-http-proxy/commit/dba39668ba4c9ad461316e834b2d64b77e1ca88e"><code>dba3966</code></a> Remove node6 support, add node12 to build (<a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/issues/1397">#1397</a>)</li> <li>See full diff in <a href="https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+9 -9

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 8 days

push eventTrott/remark-lint-prohibited-strings

dependabot-preview[bot]

commit sha c26f09a4d117176d55153ab8279ad13d3fc7df2f

chore(deps-dev): bump vfile from 4.1.0 to 4.1.1 Bumps [vfile](https://github.com/vfile/vfile) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/vfile/vfile/releases) - [Changelog](https://github.com/vfile/vfile/blob/master/changelog.md) - [Commits](https://github.com/vfile/vfile/compare/4.1.0...4.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 8 days

PR merged Trott/remark-lint-prohibited-strings

chore(deps-dev): bump vfile from 4.1.0 to 4.1.1 dependencies

Bumps vfile from 4.1.0 to 4.1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vfile/vfile/releases">vfile's releases</a>.</em></p> <blockquote> <h2>4.1.1</h2> <ul> <li>474d324 types: use browser compatible instead of node types</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vfile/vfile/commit/f177101c6ffe80c27e8e67af05f581e683099e23"><code>f177101</code></a> 4.1.1</li> <li><a href="https://github.com/vfile/vfile/commit/5c1f295b7a2dbf40ba727b252e915f7dea3766fc"><code>5c1f295</code></a> Update dev-dependencies</li> <li><a href="https://github.com/vfile/vfile/commit/474d3249a16c7b48bc117943d35b9b1c19a88bbf"><code>474d324</code></a> types: use browser compatible instead of node types</li> <li><a href="https://github.com/vfile/vfile/commit/1f3cddeb68defd22cd5ac3d556482877140950e4"><code>1f3cdde</code></a> Change ZEIT -> Vercel</li> <li><a href="https://github.com/vfile/vfile/commit/eeeed0cf0d0606f9c9768d676f5bb33648250993"><code>eeeed0c</code></a> Update dev-dependencies</li> <li>See full diff in <a href="https://github.com/vfile/vfile/compare/4.1.0...4.1.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -3

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 8 days

push eventTrott/node-slug

dependabot-preview[bot]

commit sha d142a3e464902af89a878406ef4700cc07b4afd9

Bump karma from 5.0.7 to 5.0.8 (#56) Bumps [karma](https://github.com/karma-runner/karma) from 5.0.7 to 5.0.8. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.0.7...v5.0.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 8 days

PR merged Trott/node-slug

Bump karma from 5.0.7 to 5.0.8 dependencies

Bumps karma from 5.0.7 to 5.0.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/karma-runner/karma/releases">karma's releases</a>.</em></p> <blockquote> <h2>v5.0.8</h2> <h2><a href="https://github.com/karma-runner/karma/compare/v5.0.7...v5.0.8">5.0.8</a> (2020-05-18)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>dependencies:</strong> update and unlock socket.io dependency (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3513">#3513</a>) (<a href="https://github.com/karma-runner/karma/commit/b60391fbddcfa5f8c50b6ac6e3c8d8d845258a56">b60391f</a>)</li> <li><strong>dependencies:</strong> update to latest log4js major (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3514">#3514</a>) (<a href="https://github.com/karma-runner/karma/commit/47f1cb222ee0921defbe313b694da3288a894fec">47f1cb2</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/karma-runner/karma/blob/master/CHANGELOG.md">karma's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/karma-runner/karma/compare/v5.0.7...v5.0.8">5.0.8</a> (2020-05-18)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>dependencies:</strong> update and unlock socket.io dependency (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3513">#3513</a>) (<a href="https://github.com/karma-runner/karma/commit/b60391fbddcfa5f8c50b6ac6e3c8d8d845258a56">b60391f</a>)</li> <li><strong>dependencies:</strong> update to latest log4js major (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3514">#3514</a>) (<a href="https://github.com/karma-runner/karma/commit/47f1cb222ee0921defbe313b694da3288a894fec">47f1cb2</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/karma-runner/karma/commit/16010eb53d184dd88cbb8724b5ed566609310c0c"><code>16010eb</code></a> chore(release): 5.0.8 [skip ci]</li> <li><a href="https://github.com/karma-runner/karma/commit/a409696664868cf634f89ebd7b87e66e57cff360"><code>a409696</code></a> chore: remove unused <code>grunt lint</code> command (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3515">#3515</a>)</li> <li><a href="https://github.com/karma-runner/karma/commit/47f1cb222ee0921defbe313b694da3288a894fec"><code>47f1cb2</code></a> fix(dependencies): update to latest log4js major (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3514">#3514</a>)</li> <li><a href="https://github.com/karma-runner/karma/commit/b60391fbddcfa5f8c50b6ac6e3c8d8d845258a56"><code>b60391f</code></a> fix(dependencies): update and unlock socket.io dependency (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3513">#3513</a>)</li> <li>See full diff in <a href="https://github.com/karma-runner/karma/compare/v5.0.7...v5.0.8">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+148 -134

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 8 days

push eventTrott/new.nodejs.org

dependabot-preview[bot]

commit sha 726d99c5469cd109eb58466b56e69c79fac0b9fc

build(deps): bump postcss from 7.0.28 to 7.0.29 Bumps [postcss](https://github.com/postcss/postcss) from 7.0.28 to 7.0.29. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/7.0.28...7.0.29) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Monarch Wadia

commit sha 635cdd227aa085bd962efa7822375f7f7b6fe72c

Added Nodenv to package-manager list

view details

Monarch Wadia

commit sha b168983244c0281f5b8987e0c5a36d6e5f585898

Added Nodenv to package-manager.md TOC

view details

Rich Trott

commit sha e848109c2e0dab2e198f2f2bcf63068213dc3579

chore: remove newsletter links The newsletter has not been a thing for many months now, and the email list associated with it has not been used since December. If it ever becomes a regular active thing again, we can add it again, but unless and until that happens, it's best not to use up valuable front-page real estate directing people to it.

view details

dependabot-preview[bot]

commit sha b85ec39838fa5bf89d9888e65525430d76beab04

build(deps-dev): bump linkinator from 2.1.0 to 2.1.1 Bumps [linkinator](https://github.com/JustinBeckwith/linkinator) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/JustinBeckwith/linkinator/releases) - [Commits](https://github.com/JustinBeckwith/linkinator/compare/v2.1.0...v2.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

José J. Pérez Rivas

commit sha b45f4935fa9d16ab604a05d6e5fc27560ba61e9f

Feature: Differentiating the way to Contribute / Introductory guide for translators (#3158) * Improve position and description workflow contribute * Remove phrase innecesary * Improve titles * Update Translation reference .md file Co-authored-by: Nick Schonning <nschonni@gmail.com> * test * Hi * Update README.md Co-authored-by: Zeke Sikelianos <zeke@github.com> * Update README.md Co-authored-by: Zeke Sikelianos <zeke@github.com> * test * a * test * test * Include husky npm dependence and include git-hook for load changed files into locale folder. * Change script name * Change test from locale file * Include git hook again * Remove husky for create new pullrequest * Change version linkinator dependence for error. * Update README.md Co-authored-by: Ana Gamito <imaginarte3d@gmail.com> Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Zeke Sikelianos <zeke@github.com> Co-authored-by: Ana Gamito <imaginarte3d@gmail.com>

view details

dependabot-preview[bot]

commit sha e54c3d2ae84c7a05b5d8bce82cf0be19f79939f8

build(deps-dev): bump standard from 14.3.3 to 14.3.4 Bumps [standard](https://github.com/standard/standard) from 14.3.3 to 14.3.4. - [Release notes](https://github.com/standard/standard/releases) - [Changelog](https://github.com/standard/standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/standard/standard/compare/v14.3.3...v14.3.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

John Gee

commit sha 245dc6022e7c793e5ee57d9303762a69404f78c5

Sort entries

view details

dependabot-preview[bot]

commit sha b0d6ec896fb5386180553aeaebf5adbb961dd303

build(deps-dev): bump lockfile-lint from 4.2.2 to 4.3.3 (#3170) Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 4.2.2 to 4.3.3. - [Release notes](https://github.com/lirantal/lockfile-lint/releases) - [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@4.2.2...lockfile-lint@4.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 92fafdc3c267c706ea24801632701e4f65886dfb

build(deps): bump postcss from 7.0.29 to 7.0.30 (#3168) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.29 to 7.0.30. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/7.0.29...7.0.30) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>

view details

XhmikosR

commit sha 37ce5633a0f2a63425f67dc5dc9ee752706d3772

Update README.md (#3171) Replace Node.js Foundation with OpenJS Foundation

view details

dependabot-preview[bot]

commit sha 90a884df2d50e5be03b26e120f75f8fe12886e55

build(deps-dev): bump lockfile-lint from 4.3.3 to 4.3.5 Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 4.3.3 to 4.3.5. - [Release notes](https://github.com/lirantal/lockfile-lint/releases) - [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@4.3.3...lockfile-lint@4.3.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 167a10dd1f55c21679a76630b74f7e869c1d52b5

build(deps-dev): bump lockfile-lint from 4.3.5 to 4.3.6 (#3175) Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 4.3.5 to 4.3.6. - [Release notes](https://github.com/lirantal/lockfile-lint/releases) - [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@4.3.5...lockfile-lint@4.3.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 15bb3fa0d87c6b72d267e43d8e4cc96ab817de06

build(deps): bump autoprefixer from 9.7.6 to 9.8.0 (#3177) Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.7.6 to 9.8.0. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/9.7.6...9.8.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha a5e66c9549a1608868daadb8ea92322a44c609c1

build(deps-dev): bump stylelint from 13.3.3 to 13.4.0 (#3179) Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.3.3 to 13.4.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](https://github.com/stylelint/stylelint/compare/13.3.3...13.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 9 days

pull request commentnodejs/nodejs.dev

Merge staging into master

Maybe we can add a robots.txt so this site doesn't compete with the nodejs.org until it's time to graduate it?

benhalverson

comment created time in 9 days

issue commentTrott/node-slug

Not SEO-friendly for mandarin(zh) and hindi(hi)

Hindi is now supported out-of-the-box on master branch and will be in 3.0.0. Mandarin is (obviously) more challenging since it would add thousands of characters. Still thinking about how best to enable easy opt-in for such things.

sakulstra

comment created time in 9 days

push eventTrott/io.js

Thomas

commit sha 1c619143eb449dd021142cd40c5891cbc2edb578

errors: skip fatal error highlighting on windows Some consoles do not convert ANSI escape sequences to colors, rather display them directly to the stdout. On those consoles, libuv emulates colors by intercepting stdout stream and calling corresponding Windows API functions for setting console colors. However, fatal error are handled differently and we cannot easily highlight them. PR-URL: https://github.com/nodejs/node/pull/33132 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Antoine du HAMEL

commit sha a12a2d892fadf8d8f6c5482056b937c9e1f89df4

repl: update deprecation codes Refs: https://github.com/nodejs/node/pull/33294 PR-URL: https://github.com/nodejs/node/pull/33430 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha b477ac83e6082fe0e76fb4c640cbfe7b864bbd02

src: add promise_resolve to SetupHooks comment This commit adds promise_resolve to the list of callbacks mentioned in the comment. It also fixes a minor typo, every -> ever. PR-URL: https://github.com/nodejs/node/pull/33365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha ebffd229a10ed25bff1b1aa37a8314f0e093c689

src: remove unused misc variable This commit removes the unused 'misc' variable from one of the NodeMainInstance constructors. Another option could be to add a default argument to SetIsolateMiscHandlers but I'd like to hear what others think about that first. PR-URL: https://github.com/nodejs/node/pull/33417 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha ef1eb8d43903e7c5f671998cd3ee912a73292634

src: remove unused IsolateSettings variable PR-URL: https://github.com/nodejs/node/pull/33417 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 0e5b975873e88d9276dd8f1e1d94b8f66e741155

src: add default: case to silence compiler warning This fails compilation on at least one platform because there is no `default:` case, despite all currently possible enum values being listed. Fix that by adding a default message that won’t be used unless V8 introduces new enum values. Refs: https://github.com/nodejs/node/commit/c7eeef568ce5a3714b89689160ec85c017527364#commitcomment-39228519 PR-URL: https://github.com/nodejs/node/pull/33451 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 9 days

push eventTrott/node-slug

Rich Trott

commit sha 88fc85dc35379b3534bf7776dd52c1edb0f158e6

feat: support Devanagari for Hindi, Sanskrit, and other languages (#55)

view details

push time in 9 days

pull request commentTrott/node-slug

feat: support Devanagari for Hindi, Sanskrit, and other languages

Would appreciate review from someone more knowledgable than I am (which is to say: someone who has any amount of knowledge at all because I am almost entirely ignorant):

console.log(slug("एवोकाडो"))
// evakada

@sakulstra @atulmy

Trott

comment created time in 9 days

issue commentTrott/node-slug

Not SEO-friendly for mandarin(zh) and hindi(hi)

OK, I think I got Hindi support working acceptably in https://github.com/Trott/node-slug/pull/55. Does this seem correct or at least not entirely wrong?

console.log(slug("एवोकाडो"))
// evakada
sakulstra

comment created time in 9 days

push eventTrott/node-slug

Rich Trott

commit sha 0365d89c4697f7a242ae291855e92d8928e55fc2

feat: support Devanagari for Hindi, Sanskrit, and other languages

view details

push time in 9 days

create barnchTrott/node-slug

branch : hindi

created branch time in 9 days

issue commentTrott/node-slug

Not SEO-friendly for mandarin(zh) and hindi(hi)

I think I may be getting thrown off by the underdot and multibyte characters.

sakulstra

comment created time in 9 days

issue commentTrott/node-slug

Not SEO-friendly for mandarin(zh) and hindi(hi)

Forgive my ignorance, but I'm having trouble using https://github.com/cocur/slugify/blob/master/Resources/rules/hindi.json as a reference. It's not aligning with what I"m seeing in other resources like https://en.wikipedia.org/wiki/Devanagari_transliteration. For example, the former transliterates फ़ as Fi but the latter suggests fa. Would I be correct to guess that the latter is more standard?

sakulstra

comment created time in 9 days

push eventTrott/node-slug

Rich Trott

commit sha e5a4ae0b2b1abe913c494f9481eea41eaad306c5

chore: add browser testing (#54)

view details

push time in 9 days

PR merged Trott/node-slug

chore: add browser testing
+1167 -2

0 comment

4 changed files

Trott

pr closed time in 9 days

PR opened Trott/node-slug

chore: add browser testing
+1167 -2

0 comment

4 changed files

pr created time in 9 days

more