profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/Trott/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Rich Trott Trott San Francisco, CA I create software, rock operas, and pizzas. I am a member of the Node.js Technical Steering Committee and work for the University of California. he/him

simov/slugify 924

Slugifies a string

nlf/precommit-hook 482

An npm installable git pre-commit hook used to lint and test your code

davidmarkclements/v8-perf 271

Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1

inikulin/dmn 95

Janitor for your node_modules

nlf/git-validate 94

A module to help you create your own git hooks

Swaagie/stackexchange 52

Node.js implementation of the stackexchange/stackoverflow API

nodejs/core-validate-commit 42

Validate commit messages for Node.js core

nodejs/make-node-meeting 8

Generate a text for a GitHub issue announcing a Node.js working group meeting

nodejs/node.js.org 5

As a community service, redirecting node.js.org to nodejs.org.

PR opened nodejs/node

doc: prepare markdown file for upcoming formatting/linting

<!-- Before submitting a pull request, please read https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.

Commit message formatting guidelines: https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines

For code changes:

  1. Include tests for any bug fixes or new features.
  2. Update documentation if relevant.
  3. Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+152 -136

0 comment

4 changed files

pr created time in an hour

create barnchTrott/io.js

branch : test-md

created branch time in an hour

PR opened nodejs/node

doc: update tools .md files for upcoming lint/formatting

Looks like only one .md file in tools needs to be changed.

<!-- Before submitting a pull request, please read https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.

Commit message formatting guidelines: https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines

For code changes:

  1. Include tests for any bug fixes or new features.
  2. Update documentation if relevant.
  3. Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+6 -4

0 comment

1 changed file

pr created time in 2 hours

create barnchTrott/io.js

branch : tools-md

created branch time in 2 hours

pull request commentnodejs/node-core-utils

feat: prepare ncu for new README format

The tests are a bit flaky on Windows

OK, I'll re-run it. Thanks.

Trott

comment created time in 5 hours

pull request commentnodejs/node-core-utils

feat: prepare ncu for new README format

Do we know why the 16.x GitHub Action is failing on a seemingly-unrelated test?

Trott

comment created time in 6 hours

PR opened nodejs/node

doc: update markdown formatting for *.md files

Fix formatting that will change when run through upcoming remark preset.

<!-- Before submitting a pull request, please read https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.

Commit message formatting guidelines: https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines

For code changes:

  1. Include tests for any bug fixes or new features.
  2. Update documentation if relevant.
  3. Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+72 -40

0 comment

5 changed files

pr created time in 6 hours

push eventTrott/io.js

Rich Trott

commit sha 390f928734bd1b0df19dec9d0a51bea520b0183d

doc: update markdown formatting for *.md files Fix formatting that will change when run through upcoming remark preset.

view details

push time in 6 hours

push eventTrott/io.js

Voltrex

commit sha 40c6e838dff37d0ccbc95ef28caac13f27a5238f

dgram: tighten `address` validation in `socket.send` PR-URL: https://github.com/nodejs/node/pull/39190 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Cheng Zhao

commit sha e4852e3ff5619a7cb626f193da21f8332e887963

src: add option to disable global search paths PR-URL: https://github.com/nodejs/node/pull/39754 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Cheng Zhao

commit sha d9791d91ac10e10feac303efc3e44bd65c9ce2bf

src: add --no-global-search-paths cli option PR-URL: https://github.com/nodejs/node/pull/39754 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Antoine du Hamel

commit sha e62d4647241af0b12c72a14844fab547ce359498

lib: avoid creating a throw away object in `validateObject` PR-URL: https://github.com/nodejs/node/pull/39807 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Maledong

commit sha 8900a4663f45d047894b98875f58529f6026746e

lib: remove useless statement There's no need to set 'false' to 'isAsync' because we've declared it before. PR-URL: https://github.com/nodejs/node/pull/39983 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

view details

vipul kumar

commit sha f4292bc17b4611c8d86ee2329494a49562b6498f

doc: correct parameters in fs and stream documentation PR-URL: https://github.com/nodejs/node/pull/39984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Voltrex

commit sha 7c77db024394e94381c2d4664e1066f794dc33da

dns: refactor and use validators The logical NOT operator and validators should be used where appropriate. PR-URL: https://github.com/nodejs/node/pull/40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>

view details

Anna Henningsen

commit sha da13561fb3140e2f3b6beb8f45c3bfdf74b4b1bc

doc: clean up weird notes about reentrancy All N-API methods are reentrant, it does not make sense to talk about specific ones here. Some of these methods can run JS code, which of course can run other N-API code. For those methods, let’s note that down explicitly. PR-URL: https://github.com/nodejs/node/pull/40107 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 6ef1d7c3471382bf34c86f9751b420a7435fb381

meta: add mailmap entry for LPardue PR-URL: https://github.com/nodejs/node/pull/40129 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Michaël Zasso

commit sha 2b080cb23fac2320c84d79c76603a8a7f9b9a7bc

tools: update doc generator dependencies PR-URL: https://github.com/nodejs/node/pull/40042 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

view details

Antoine du Hamel

commit sha 3101c09d1d211cbe237f1aaded552216a474ed24

test: do not run `test-corepack-yarn-install` with no internet PR-URL: https://github.com/nodejs/node/pull/40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Guy Bedford

commit sha 64287e4d459f771d9aa03fc65441f1ddf12c2535

module: runtime deprecate trailing slash patterns PR-URL: https://github.com/nodejs/node/pull/40117 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 088c01bfdf3feec18c1bafcee0a6041992858c31

meta: update GeoffreyBooth email addresses in AUTHORS and .mailmap PR-URL: https://github.com/nodejs/node/pull/40132 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

view details

Rich Trott

commit sha 0bafe6dd219a62c5f8426e37be9807b88a62ecad

doc: fix comma splice PR-URL: https://github.com/nodejs/node/pull/40133 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Rich Trott

commit sha b0d5eecdd9dcb6f2fe569ac6fb1e3687ed49623d

tools,doc: fix misrendering of consecutive JS blocks Our markdown-to-html tool was assuming that any consecutive JS blocks were ESM vs CJS alternatives, but that is not always the case, resulting in both a confusing interface and invalid HTML. PR-URL: https://github.com/nodejs/node/pull/40146 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

view details

Artur K

commit sha 4e8f11dee3b7dcea7472058f4182ddd36b86c781

http: limit requests per connection Fixes: https://github.com/nodejs/node/issues/40071 PR-URL: https://github.com/nodejs/node/pull/40082 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

Rich Trott

commit sha 49f1c13adb03b2614e52cd958ba4625683947147

doc: update markdown formatting for *.md files Fix formatting that will change when run through upcoming remark preset.

view details

push time in 6 hours

PullRequestReviewEvent

push eventTrott/io.js

Guy Bedford

commit sha 64287e4d459f771d9aa03fc65441f1ddf12c2535

module: runtime deprecate trailing slash patterns PR-URL: https://github.com/nodejs/node/pull/40117 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 088c01bfdf3feec18c1bafcee0a6041992858c31

meta: update GeoffreyBooth email addresses in AUTHORS and .mailmap PR-URL: https://github.com/nodejs/node/pull/40132 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

view details

Rich Trott

commit sha 0bafe6dd219a62c5f8426e37be9807b88a62ecad

doc: fix comma splice PR-URL: https://github.com/nodejs/node/pull/40133 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Rich Trott

commit sha b0d5eecdd9dcb6f2fe569ac6fb1e3687ed49623d

tools,doc: fix misrendering of consecutive JS blocks Our markdown-to-html tool was assuming that any consecutive JS blocks were ESM vs CJS alternatives, but that is not always the case, resulting in both a confusing interface and invalid HTML. PR-URL: https://github.com/nodejs/node/pull/40146 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

view details

Artur K

commit sha 4e8f11dee3b7dcea7472058f4182ddd36b86c781

http: limit requests per connection Fixes: https://github.com/nodejs/node/issues/40071 PR-URL: https://github.com/nodejs/node/pull/40082 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

push time in 6 hours

pull request commentnodejs/node

meta: add mailmap entry for ralphtheninja

@ralphtheninja

Trott

comment created time in 6 hours

PR opened nodejs/node

meta: add mailmap entry for ralphtheninja

<!-- Before submitting a pull request, please read https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.

Commit message formatting guidelines: https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines

For code changes:

  1. Include tests for any bug fixes or new features.
  2. Update documentation if relevant.
  3. Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -2

0 comment

2 changed files

pr created time in 6 hours

create barnchTrott/io.js

branch : mailmap-rtn

created branch time in 6 hours

Pull request review commentnodejs/node-core-utils

feat: prepare ncu for new README format

 const TSC_TITLE = '### TSC (Technical Steering Committee)'; const TSCE_TITLE = '### TSC Emeriti'; const CL_TITLE = '### Collaborators'; const CLE_TITLE = '### Collaborator Emeriti';-const CONTACT_RE = /\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +&lt;(.+?)&gt;/mg;+const CONTACT_RE =+  /\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +(?:&lt;|<)(.+?)(?:&gt;|>)/mg;

Nice catch, @targos. Fixed.

Trott

comment created time in 7 hours

PullRequestReviewEvent

push eventTrott/node-core-utils

Rich Trott

commit sha e3507fcd734d047efac3f0ca7d6b9e5723653d54

feat: prepare ncu for new README format This accommodates both the current README format and the upcoming README format. Refs: https://github.com/nodejs/node/pull/40137

view details

Rich Trott

commit sha 3dc0d625adf54eab10df7b8ab36711eb104b48c0

fixup! feat: prepare ncu for new README format

view details

push time in 7 hours

Pull request review commentnodejs/node-core-utils

feat: prepare ncu for new README format

 const TSC_TITLE = '### TSC (Technical Steering Committee)'; const TSCE_TITLE = '### TSC Emeriti'; const CL_TITLE = '### Collaborators'; const CLE_TITLE = '### Collaborator Emeriti';-const CONTACT_RE = /\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +&lt;(.+?)&gt;/mg;+const CONTACT_RE =+  /\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +(?:&lt;|<)(.+?)(?:&gt;|>)/mg;

It doesn't work. I thought I ran it against the main branch, but I guess I didn't.

Trott

comment created time in 7 hours

PullRequestReviewEvent

push eventTrott/io.js

Antoine du Hamel

commit sha 3101c09d1d211cbe237f1aaded552216a474ed24

test: do not run `test-corepack-yarn-install` with no internet PR-URL: https://github.com/nodejs/node/pull/40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

push time in 19 hours

pull request commentsyntax-tree/mdast-util-from-markdown

Fix handling of reference links with inline code

I don't know if this is the right fix for https://github.com/remarkjs/remark/issues/850, but it fixes that issue without breaking any existing tests, so I'm hopeful....

Trott

comment created time in 20 hours

PR opened syntax-tree/mdast-util-from-markdown

Fix handling of reference links with inline code

This fixes the AST so that certain kinds of reference links are not broken when converted back to markdown.

Fixes: https://github.com/remarkjs/remark/issues/850

<!-- Please check the needed checkboxes ([ ] -> [x]). Leave the comments as they are, they won’t show on GitHub. We are excited about pull requests, but please try to limit the scope, provide a general description of the changes, and remember, it’s up to you to convince us to land it. -->

Initial checklist

  • [ ] I read the support docs <!-- https://github.com/syntax-tree/.github/blob/main/support.md -->
  • [ ] I read the contributing guide <!-- https://github.com/syntax-tree/.github/blob/main/contributing.md -->
  • [ ] I agree to follow the code of conduct <!-- https://github.com/syntax-tree/.github/blob/main/code-of-conduct.md -->
  • [ ] I searched issues and couldn’t find anything (or linked relevant results below) <!-- https://github.com/search?q=user%3Asyntax-tree&type=Issues -->
  • [ ] If applicable, I’ve added docs and tests

Description of changes

TODO

<!--do not edit: pr-->

+35 -1

0 comment

2 changed files

pr created time in 20 hours

create barnchTrott/mdast-util-from-markdown

branch : reflinks

created branch time in 20 hours

PullRequestReviewEvent

issue commentremarkjs/remark

stringify() appears to mishandle reference links with inline code

mdast-util-from-markdown seems to generate the wrong label for the link, if I'm understanding it correctly.

Trott

comment created time in 21 hours

issue commentremarkjs/remark

stringify() appears to mishandle reference links with inline code

Looks like the behavior is present in the underlying mdast-util-to-markdown and/or mdast-util-from-markdown. Should I close this and move the issue there instead?

Trott

comment created time in 21 hours

PR opened remarkjs/remark

Update test for change in upstream dependencies

<!-- Please check the needed checkboxes ([ ] -> [x]). Leave the comments as they are, they won’t show on GitHub. We are excited about pull requests, but please try to limit the scope, provide a general description of the changes, and remember, it’s up to you to convince us to land it. -->

Initial checklist

  • [x] I read the support docs <!-- https://github.com/remarkjs/.github/blob/main/support.md -->
  • [x] I read the contributing guide <!-- https://github.com/remarkjs/.github/blob/main/contributing.md -->
  • [x] I agree to follow the code of conduct <!-- https://github.com/remarkjs/.github/blob/main/code-of-conduct.md -->
  • [x] I searched issues and couldn’t find anything (or linked relevant results below) <!-- https://github.com/search?q=user%3Aremarkjs&type=Issues -->
  • [x] If applicable, I’ve added docs and tests

Description of changes

Running npm test in remark-stringify has one failing test, I believe due to a change in an upstream dependency. This change adusts the test expectation.

<!--do not edit: pr-->

+1 -1

0 comment

1 changed file

pr created time in a day

create barnchTrott/remark

branch : fixes

created branch time in a day

create barnchTrott/remark

branch : fixes

created branch time in a day