An npm installable git pre-commit hook used to lint and test your code
Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1
inikulin/dmn 95
Janitor for your node_modules
A module to help you create your own git hooks
Node.js implementation of the stackexchange/stackoverflow API
nodejs/core-validate-commit 41
Validate commit messages for Node.js core
Generate a text for a GitHub issue announcing a Node.js working group meeting
As a community service, redirecting node.js.org to nodejs.org.
Generate an agenda for a Node.js working group based on GitHub issue labels
push eventTrott/slug
commit sha d97a089a3ad4d5ba62781694653de514911c87a9
chore(deps-dev): bump mocha from 8.1.1 to 8.1.2 Bumps [mocha](https://github.com/mochajs/mocha) from 8.1.1 to 8.1.2. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v8.1.1...v8.1.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
commit sha b53af94287c1a0f4bd533da462c7b1efd4a63426
chore(deps-dev): bump mocha from 8.1.2 to 8.1.3 Bumps [mocha](https://github.com/mochajs/mocha) from 8.1.2 to 8.1.3. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v8.1.2...v8.1.3) Signed-off-by: dependabot-preview[bot] <[email protected]>
commit sha 263f65efade8ac7da990c72e64ed6d13b066790b
chore(deps-dev): bump karma from 5.1.1 to 5.2.0 Bumps [karma](https://github.com/karma-runner/karma) from 5.1.1 to 5.2.0. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.1.1...v5.2.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
commit sha bd47d5107f7837fb57bd637554f58d0bd92621de
chore(deps-dev): bump karma from 5.2.0 to 5.2.1 Bumps [karma](https://github.com/karma-runner/karma) from 5.2.0 to 5.2.1. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.2.0...v5.2.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
commit sha 3f6e7c7b2099246f634600a6ad385fbd8b3fff66
chore: update dependencies
commit sha 99b065d02c2a6552eb1c21e6edd98e0da19c7b62
chore(deps-dev): bump karma from 5.2.1 to 5.2.2 Bumps [karma](https://github.com/karma-runner/karma) from 5.2.1 to 5.2.2. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.2.1...v5.2.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
commit sha a3ed4c36304340d3fd9cefa08b334c51293c0071
Merge branch 'master' into he
push time in 8 hours
pull request commentnodejs/node-inspect
chore: align message with Node.js standard
Is there a timeline for getting this back into node? Or is it a "when convenient"?
When convenient.
Meaning: When convenient for you and other node-inspect maintainers. If you'd rather have it get into Node.js sooner than later, I'm happy to do whatever I can to make that easier if there's anything that's an obstacle.
comment created time in 8 hours
pull request commentnodejs/node-inspect
chore: align message with Node.js standard
Is there a timeline for getting this back into node? Or is it a "when convenient"?
When convenient.
comment created time in 8 hours
pull request commentnodejs/node
tls: use the most recently added matching SecureContext in default SNICallback.
@nodejs/crypto
comment created time in 8 hours
push eventTrott/io.js
commit sha 69b5aa640f9cb17938271bed76e3dd2081897d0d
doc: replace "this guide" link text with guide title
push time in 15 hours
Pull request review commentnodejs/node
doc: replace "this guide" link text with guide title
there to show the start of each command. Lines that don’t start with `$` or `>` character show the output of the previous command. -First, make sure to have downloaded and installed Node.js. See [this guide][]-for further install information.+First, make sure to have downloaded and installed Node.js. See+["Installing Node.js via package manager"][] for further install information.
No, we don't. I'll remove them.
comment created time in 15 hours
pull request commentnodejs/node
test: skip CPU-intensive test-hash-seed on low-CPU hosts
Had to bump up the timeout pretty high but it worked:
10:14:45 ok 735 pummel/test-hash-seed
10:14:45 ---
10:14:45 duration_ms: 1062.357
That does mean that we're setting up CI to take nearly 18 minutes to run a single test....
comment created time in 15 hours
push eventTrott/io.js
commit sha 59ffc5f62e9e31326cbf0eed721179f1e8e7b10b
fixup! fixup! build: add pummel tests to ci runs
push time in 21 hours
pull request commentnodejs/node
test: skip CPU-intensive test-hash-seed on low-CPU hosts
Putting this into draft mode until we see what happens with longer timeout. (That also fixes other issues where other tests were timing out in the pummel suite on Raspberry Pi.) This might not be necessary but I don't want to close it until I'm sure.
comment created time in 21 hours
pull request commentnodejs/node
test: skip CPU-intensive test-hash-seed on low-CPU hosts
I extended the timeout from 480 seconds to 960 seconds and it passed on one of the Pi3 devices, but it was close. Will likely fail on the Pi2 device, but I can extend it out further as long as Jenkins itself doesn't start interpreting the long silence as a problem...
09:26:36 ok 735 pummel/test-hash-seed
09:26:36 ---
09:26:36 duration_ms: 905.98
comment created time in 21 hours
PR opened nodejs/node
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr created time in 21 hours
push eventTrott/io.js
commit sha 4b6036a07b9767ecdb9b04f1effb5170c3f7dd4e
build,deps: add gen-openssl target This adds a new make target to generate platform dependent files for openssl on non-linux machines. The scripts we currently have in place require linux. This adds a Dockerfile that installs the necessary dependencies to be able to generate these files. Previously, it was necessary to run `make -C deps/openssl/config` on a linux machine. Now, as long as docker is installed and in your `PATH`, it is possible to run `make gen-openssl`. PR-URL: https://github.com/nodejs/node/pull/34642 Reviewed-By: James M Snell <[email protected]>
commit sha d06ff289a058ff3ae97dc87456e9129f6d792a7f
deps: add openssl support for arm64 This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in https://github.com/openssl/openssl/pull/12369 to generate the required files. PR-URL: https://github.com/nodejs/node/pull/34238 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
commit sha e3b79e3bbe635fc7f57ff3df0c99dbb8f63ce05e
build: add support for build on arm64 Ref: https://github.com/nodejs/TSC/issues/886 Ref: https://github.com/nodejs/node/issues/34043 PR-URL: https://github.com/nodejs/node/pull/34238 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
commit sha c6b96895cc74bc6bd658b4c6d5ea152d6e686d20
meta: enable wasi for CODEOWNERS PR-URL: https://github.com/nodejs/node/pull/34889 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
commit sha 565d9939684c21ea9d121eb77ced43592b73e7c3
errors: use `ErrorPrototypeToString` from `primordials` object PR-URL: https://github.com/nodejs/node/pull/34891 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
commit sha a7572d1422488231c65f1195bb6f97367e03da74
doc: fix broken markdown/display in cli.html The `<` character is interpreted as the start of an HTML tag, making the word `address` not render and the rest of the document rendered with a grey background and in italics. Use `<` instead. PR-URL: https://github.com/nodejs/node/pull/34892 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 8134c6468c1043be0b866cd9521006a83eedfa3d
doc: improve link-local text in dgram.md Minor improvements. PR-URL: https://github.com/nodejs/node/pull/34868 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 4332f738326d9a067d859ef86e78fadeb95f1b2c
tools,doc: remove "toc" anchor name The _name_ attribute is obsolete. Changing it to _id_ in the case of "toc" would result in a conflict with an existing id. However, there are no links to "#toc" in our docs. And if there were, it would be more appropriate to link to the id toc which is the toc for the individual documents. So remove the anchor name entirely. PR-URL: https://github.com/nodejs/node/pull/34893 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha cc39bdf72442aa7800d20c9a832b3aa0a069acdf
module: drop `-u` alias for `--conditions` Old versions of mocha break after https://github.com/nodejs/node/pull/34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated. PR-URL: https://github.com/nodejs/node/pull/34935 Refs: https://github.com/mochajs/mocha/issues/4417 Refs: https://github.com/nodejs/node/pull/34637 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
commit sha 9ded2942a40da0badc9e91b3658fc6a97abcb3a4
src,doc: rephrase for clarity PR-URL: https://github.com/nodejs/node/pull/34879 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 0f9650bcddc79edb2d6ed447bc0416236239c0a0
src,doc: fix grammar due to missing 'is' PR-URL: https://github.com/nodejs/node/pull/34897 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 87c43dee5302126fa370f5407a963cc8ab8ae013
src,doc: fix wording to refer to context, not environment PR-URL: https://github.com/nodejs/node/pull/34880 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 423490423264d1b7624d578a421a1bedecbc5d2e
policy: implement scopes field PR-URL: https://github.com/nodejs/node/pull/34552 Reviewed-By: James M Snell <[email protected]>
commit sha 8ec3b55e5be2f88b3e39812410910780d6aa83de
doc: add missing DEP ID for 'new crypto.Certificate()' PR-URL: https://github.com/nodejs/node/pull/34940 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
commit sha b01d314167c472237036798783eed7de96cfdfc5
doc: use consistent typography for node-addon-api Most of the instances of _node-addon-api_ are surrounded with backticks, but two aren't. Add backticks for consistency. PR-URL: https://github.com/nodejs/node/pull/34910 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 09e23b842b83ab0f2b093ea8d47821fabb47ede2
doc: provide more guidance about process.version PR-URL: https://github.com/nodejs/node/pull/34909 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
commit sha 79402c0eaaaca8daa2fe3bbbd99f66b8d956bb92
doc: fix CHANGELOG.md parsing issue PR-URL: https://github.com/nodejs/node/pull/34923 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
commit sha 3089f96ed01653aa4d5e4bba5a5db473ffe788a0
2020-08-27, Version 14.9.0 (Current) Notable changes: - build: set --v8-enable-object-print by default (Mary Marchini) [#34705](https://github.com/nodejs/node/pull/34705) - deps: - upgrade to libuv 1.39.0 (cjihrig) [#34915](https://github.com/nodejs/node/pull/34915) - upgrade npm to 6.14.8 (Ruy Adorno) [#34834](https://github.com/nodejs/node/pull/34834) - V8: cherry-pick e06ace6b5cdb (Anna Henningsen) [#34673](https://github.com/nodejs/node/pull/34673) - n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof) [#34839](https://github.com/nodejs/node/pull/34839) - tools: add debug entitlements for macOS 10.15+ (Gabriele Greco) [#34378](https://github.com/nodejs/node/pull/34378) PR-URL: https://github.com/nodejs/node/pull/34852
commit sha 0848f56cb39432090cdb99af9b8541fbc1a2849c
n-api: re-implement async env cleanup hooks * Avoid passing core `void*` and function pointers into add-on. * Document `napi_async_cleanup_hook_handle` type. * Render receipt of the handle mandatory from the point where the hook gets called. Removal of the handle remains mandatory. Fixes: https://github.com/nodejs/node/issues/34715 Signed-off-by: Gabriel Schulhof <[email protected]> Co-authored-by: Anna Henningsen <[email protected]> PR-URL: https://github.com/nodejs/node/pull/34819 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
commit sha f461a66822a807d7f6c5eb7300fd69638beee1f8
doc: make minor fixes to maintaining-openssl.md PR-URL: https://github.com/nodejs/node/pull/34926 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
push time in 21 hours
issue closednodejs/node
investigate failing permutation in test-policy-integrity
<!-- Thank you for reporting a flaky test.
Flaky tests are tests that fail occasionally in the Node.js CI, but not consistently enough to block PRs from landing, or that are failing in CI jobs or test modes that are not run for every PR.
Please fill in as much of the template below as you're able.
Test: The test that is flaky - e.g. test-fs-stat-bigint
Platform: The platform the test is flaky on - e.g. macos or linux
Console Output: A pasted console output from a failed CI job showing the whole
failure of the test
Build Links: Links to builds affected by the flaky test
If any investigation has been done, please include any information found, such as how consistently the test fails, whether the failure could be reproduced locally, when the test started failing, or anything else you think is relevant. -->
- Test: pummel/test-policy-integrity.js
- Platform: Linux
- Console Output:
08:11:16 not ok 2845 pummel/test-policy-integrity
08:11:16 ---
08:11:16 duration_ms: 16.746
08:11:16 severity: fail
08:11:16 exitcode: 1
08:11:16 stack: |-
08:11:16 permutation 118 failed
08:11:16 {
08:11:16 config: {
08:11:16 onError: 'exit',
08:11:16 shouldSucceed: true,
08:11:16 entryPath: './worker-spawner.cjs',
08:11:16 willDeletePolicy: true,
08:11:16 preloads: [],
08:11:16 parentPath: './parent.js',
08:11:16 depPath: './dep.js',
08:11:16 resources: {
08:11:16 './dep.js': {
08:11:16 body: '',
08:11:16 integrities: [
08:11:16 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=',
08:11:16 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU='
08:11:16 ]
08:11:16 },
08:11:16 './parent.js': {
08:11:16 body: '\n' +
08:11:16 ' if (!process.env.DEP_FILE) {\n' +
08:11:16 ' console.error(\n' +
08:11:16 " 'missing required DEP_FILE env to determine dependency'\n" +
08:11:16 ' );\n' +
08:11:16 ' process.exit(33);\n' +
08:11:16 ' }\n' +
08:11:16 ' require(process.env.DEP_FILE)\n' +
08:11:16 ' ',
08:11:16 integrities: [
08:11:16 'sha256-AzbH3oEA96J/+tLSqOJ+LaIt9vdOY+ikShkvKm0VutU=',
08:11:16 'sha256-R0QVSw9BUI7znwKNvt6BuzkLozhYKTtFNRSENIL5H7k='
08:11:16 ]
08:11:16 },
08:11:16 './worker-spawner.cjs': {
08:11:16 body: '\n' +
08:11:16 " const path = require('path');\n" +
08:11:16 " const { Worker } = require('worker_threads');\n" +
08:11:16 ' if (!process.env.PARENT_FILE) {\n' +
08:11:16 ' console.error(\n' +
08:11:16 " 'missing required PARENT_FILE env to determine worker entry point'\n" +
08:11:16 ' );\n' +
08:11:16 ' process.exit(33);\n' +
08:11:16 ' }\n' +
08:11:16 ' if (!process.env.DELETABLE_POLICY_FILE) {\n' +
08:11:16 ' console.error(\n' +
08:11:16 " 'missing required DELETABLE_POLICY_FILE env to check reloading'\n" +
08:11:16 ' );\n' +
08:11:16 ' process.exit(33);\n' +
08:11:16 ' }\n' +
08:11:16 ' const w = new Worker(path.resolve(process.env.PARENT_FILE));\n' +
08:11:16 " w.on('exit', (status) => process.exit(status === 0 ? 0 : 1));\n",
08:11:16 integrities: [
08:11:16 'sha256-23P4m8edtJAPTH24RJHIHMEuMVgP7QKcgWBSyj6FxPc=',
08:11:16 'sha256-XTRkNC3vxo+zvjv7CD8iapeqc7npNN7TwqRR0TOv5lg='
08:11:16 ]
08:11:16 }
08:11:16 }
08:11:16 },
08:11:16 manifest: {
08:11:16 onerror: 'exit',
08:11:16 resources: {
08:11:16 'file:///home/iojs/node-tmp/.tmp.2844/test-policy-integrity-permutation-118/dep.js': {
08:11:16 integrity: 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU= sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=',
08:11:16 dependencies: true
08:11:16 },
08:11:16 'file:///home/iojs/node-tmp/.tmp.2844/test-policy-integrity-permutation-118/parent.js': {
08:11:16 integrity: 'sha256-AzbH3oEA96J/+tLSqOJ+LaIt9vdOY+ikShkvKm0VutU= sha256-R0QVSw9BUI7znwKNvt6BuzkLozhYKTtFNRSENIL5H7k=',
08:11:16 dependencies: true
08:11:16 },
08:11:16 'file:///home/iojs/node-tmp/.tmp.2844/test-policy-integrity-permutation-118/worker-spawner.cjs': {
08:11:16 integrity: 'sha256-23P4m8edtJAPTH24RJHIHMEuMVgP7QKcgWBSyj6FxPc= sha256-XTRkNC3vxo+zvjv7CD8iapeqc7npNN7TwqRR0TOv5lg=',
08:11:16 dependencies: true
08:11:16 }
08:11:16 }
08:11:16 }
08:11:16 }
08:11:16 exit code: 1 signal: null
08:11:16 stdout:
08:11:16 stderr: (node:4190) ExperimentalWarning: Policies are experimental.
08:11:16 (Use `node --trace-warnings ...` to show where the warning was created)
08:11:16 Error [ERR_MANIFEST_ASSERT_INTEGRITY]: The content of "file:///home/iojs/node-tmp/package.json" does not match the expected integrity. The resource was not found in the policy.
08:11:16 at new NodeError (internal/errors.js:253:15)
08:11:16 at Manifest.assertIntegrity (internal/policy/manifest.js:532:19)
08:11:16 at Object.read (internal/modules/package_json_reader.js:34:16)
08:11:16 at readPackage (internal/modules/cjs/loader.js:277:36)
08:11:16 at readPackageScope (internal/modules/cjs/loader.js:310:19)
08:11:16 at shouldUseESMLoader (internal/modules/run_main.js:36:15)
08:11:16 at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:67:24)
08:11:16 at MessagePort.<anonymous> (internal/main/worker_thread.js:174:24)
08:11:16 at MessagePort.[nodejs.internal.kHybridDispatch] (internal/event_target.js:353:41)
08:11:16 at MessagePort.exports.emitMessage (internal/per_context/messageport.js:18:26)
08:11:16
08:11:16 /home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64/test/pummel/test-policy-integrity.js:186
08:11:16 throw e;
08:11:16 ^
08:11:16
08:11:16 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
08:11:16
08:11:16 1 !== 0
08:11:16
08:11:16 at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64/test/pummel/test-policy-integrity.js:169:18)
08:11:16 at ChildProcess.emit (events.js:326:20)
08:11:16 at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12) {
08:11:16 generatedMessage: true,
08:11:16 code: 'ERR_ASSERTION',
08:11:16 actual: 1,
08:11:16 expected: 0,
08:11:16 operator: 'strictEqual'
08:11:16 }
08:11:16 ...
- Build Links: https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian9-64/37140/ https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc8/37140/
closed time in 21 hours
Trott
issue commentnodejs/node
investigate failing permutation in test-policy-integrity
On the one of the two machines I was able to ssh into, the timestamps on these files are from January 2019 so I must have just missed cleaning them up the last time. I'm going to imagine it's the same for the other and work with someone on build to fix that (or figure out why my setup isn't working). Thanks!
comment created time in 21 hours
pull request commentnodejs/node
Force-pushed 5461794b12ca3f907a03396f56d5c0e070cca0b1
comment created time in a day
push eventTrott/io.js
commit sha 5461794b12ca3f907a03396f56d5c0e070cca0b1
https: set requestTimeout default to 0 Fixes: https://github.com/nodejs/node/issues/35261 PR-URL: https://github.com/nodejs/node/pull/35264 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
push time in a day
push eventnodejs/node
commit sha 5461794b12ca3f907a03396f56d5c0e070cca0b1
https: set requestTimeout default to 0 Fixes: https://github.com/nodejs/node/issues/35261 PR-URL: https://github.com/nodejs/node/pull/35264 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
push time in a day
PR closed nodejs/node
requestTimeout should be 0 by default for https just like http. The current default may cause breaking regressions in user code.
Fixes: https://github.com/nodejs/node/issues/35261
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x]
make -j4 test(UNIX), orvcbuild test(Windows) passes - [x] tests and/or benchmarks are included
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in a day
pull request commentnodejs/node
Landed in 3e06e646520533636e447d854c751668ad33fb37
comment created time in a day
push eventnodejs/node
commit sha 3e06e646520533636e447d854c751668ad33fb37
http: https requestTimeout 0 Fixes: https://github.com/nodejs/node/issues/35261 PR-URL: https://github.com/nodejs/node/pull/35264 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
push time in a day
issue closednodejs/node
Websocket connections incorrectly timing out after 2 minutes in node 14.11? Possible regression
Hi,
After upgrading to node 14.11, one of our services that is a websocket server using https://github.com/websockets/ws started mysteriously disconnecting clients every 2 minutes.
Downgrading to node 14.9 seems to fix the issue.
This line on commit https://github.com/nodejs/node/commit/753f3b247a, combined with the fact that the documentation says the default value for this is 0, and it is 0 in lib/_http_server.js, makes me suspicious. Especially given that clients are getting disconnected precisely every 2 minutes.
cc @ronag
closed time in a day
liamuk
issue commentnodejs/node
investigate failing permutation in test-policy-integrity
@Trott this is the file
file:///home/iojs/node-tmp/package.jsonsomehow being put outside the test tmpdirfile:///home/iojs/node-tmp/.tmp.2844/, probably by a different test? Do we know if that file was created recently?
Oh, that again! Hmm...OK, back in my court, I'll see what I can find out.
comment created time in a day
pull request commentnodejs/node
readline: fix key name for function keys combined with modifiers
Thanks for the contribution! 🎉
comment created time in a day
pull request commentnodejs/node
readline: fix key name for function keys combined with modifiers
Landed in 17ebd464ccdf
comment created time in a day
PR merged nodejs/node
Added proper key names for function key (e.g. <kbd>F4</kbd>) combined with modifiers (e.g. <kbd>Ctrl</kbd>).
I also added support for:
- <kbd>Alt</kbd> + <kbd>Enter</kbd>
- <kbd>Alt</kbd> + <kbd>KeypadEnter</kbd>
- <kbd>Alt</kbd> + <kbd>Backspace</kbd>
Fixes #35251
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x]
make -j4 test(UNIX), orvcbuild test(Windows) passes - [x] tests and/or benchmarks are included
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in a day
push eventnodejs/node
commit sha 17ebd464ccdf12a4fb46334ff5d7a71f0f2e70a9
readline: fix key name for function keys with modifiers Fixes: https://github.com/nodejs/node/issues/35251 PR-URL: https://github.com/nodejs/node/pull/35268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
push time in a day
issue closednodejs/node
Readline: Function keys (e.g. F1) return "undefined" key name
- Version: v14.11.0
- Platform: Linux 5.4.0-42-generic // Ubuntu 20.04 // x64
- Subsystem: readline.emitKeypressEvents (exact place in code: here)
What steps will reproduce the bug?
- Execute the code below in a terminal.
- Press <kbd>Alt</kbd>+<kbd>F3</kbd> (see Additionnal information).
const { StringDecoder } = require('string_decoder')
const { emitKeypressEvents } = require('readline')
const stdin = process.openStdin();
emitKeypressEvents(stdin);
if (stdin.isTTY) {
console.log('Standard input is a TTY');
stdin.setRawMode(true);
}
const strDecoder = new StringDecoder('utf8');
const escapeEsc = (str) => str?.replace(/\x1b/g, 'ESC');
stdin.on('keypress', (str, key) => {
// key.name === "undefined" <<<<<<<<<<<<<<<<<<<<<<<<<<<<<< HERE
console.log('KEYPRESS => data: «%o», key: %o', escapeEsc(str), key);
});
stdin.on('data', (data) => {
const str = strDecoder.write(data);
console.log('DATA => decoded: «%s», raw: %o', escapeEsc(str), data);
});
How often does it reproduce? Is there a required condition?
Every time!
What is the expected behavior?
key.name should contain the name of the function key (e.g. "f1").
See Additional information.
What do you see instead?
key.name contains "undefined" (as a string / not undefined).
See Additional information.
<em>Output after pressing <kbd>Alt</kbd> + <kbd>F3</kbd></em>
Additional information
<details> <summary id="tested-key-combos">Tested key combinations (expected/current result)</summary>
| Key combo | Expected<br>key.name |
Current<br>key.name |
Matches<br>expectation? |
|---|---|---|---|
| <kbd>Alt</kbd> + <kbd>F1</kbd> | "f1" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>F2</kbd> | "f2" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>F3</kbd> | "f3" |
"undefined" |
 |
| <kbd>Alt</kbd> + <kbd>F4</kbd> | "f4" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>F5</kbd> | "f5" |
"f5" |
 |
| <kbd>Alt</kbd> + <kbd>F6</kbd> | "f6" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>F7</kbd> | "f7" |
"f7" |
|
| <kbd>Alt</kbd> + <kbd>F8</kbd> | "f8" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>F9</kbd> | "f9" |
"f9" |
|
| <kbd>Alt</kbd> + <kbd>F10</kbd> | "f10" |
"f10" |
|
| <kbd>Alt</kbd> + <kbd>F11</kbd> | "f11" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>F12</kbd> | "f12" |
"f12" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F1</kbd> | "f1" |
"undefined" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F2</kbd> | "f2" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F3</kbd> | "f3" |
"undefined" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F4</kbd> | "f4" |
"undefined" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F5</kbd> | "f5" |
"f5" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F6</kbd> | "f6" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F7</kbd> | "f7" |
"f7" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F8</kbd> | "f8" |
"f8" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F9</kbd> | "f9" |
"f9" |
|
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F10</kbd> | "f10" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F11</kbd> | "f11" |
??? | ??? |
| <kbd>Alt</kbd> + <kbd>Shift</kbd> + <kbd>F12</kbd> | "f12" |
"f12" |
|
| <kbd>Ctrl</kbd> + <kbd>F1</kbd> | "f1" |
"undefined" |
|
| <kbd>Ctrl</kbd> + <kbd>F2</kbd> | "f2" |
??? | ??? |
| <kbd>Ctrl</kbd> + <kbd>F3</kbd> | "f3" |
"undefined" |
|
| <kbd>Ctrl</kbd> + <kbd>F4</kbd> | "f4" |
"undefined" |
|
| <kbd>Ctrl</kbd> + <kbd>F5</kbd> | "f5" |
"f5" |
|
| <kbd>Ctrl</kbd> + <kbd>F6</kbd> | "f6" |
"f6" |
|
| <kbd>Ctrl</kbd> + <kbd>F7</kbd> | "f7" |
"f7" |
|
| <kbd>Ctrl</kbd> + <kbd>F8</kbd> | "f8" |
"f8" |
|
| <kbd>Ctrl</kbd> + <kbd>F9</kbd> | "f9" |
"f9" |
|
| <kbd>Ctrl</kbd> + <kbd>F10</kbd> | "f10" |
"f10" |
|
| <kbd>Ctrl</kbd> + <kbd>F11</kbd> | "11" |
??? | ??? |
| <kbd>Ctrl</kbd> + <kbd>F12</kbd> | "f12" |
"f12" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F1</kbd> | "f1" |
"undefined" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F2</kbd> | "f2" |
??? | ??? |
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F3</kbd> | "f3" |
"undefined" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F4</kbd> | "f4" |
"undefined" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F5</kbd> | "f5" |
"f5" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F6</kbd> | "f6" |
"f6" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F7</kbd> | "f7" |
"f7" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F8</kbd> | "f8" |
"f8" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F9</kbd> | "f9" |
"f9" |
|
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F10</kbd> | "f10" |
??? | ??? |
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F11</kbd> | "11" |
??? | ??? |
| <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>F12</kbd> | "f12" |
"f12" |
|
The key combinations where the 3<sup>rd</sup> and 4<sup>th</sup> columns contain ??? could not be tested cause they were already bound to something else like <kbd>Alt</kbd> + <kbd>F4</kbd> which closes the application. </details>
closed time in a day
DrunkenPoney
push eventTrott/io.js
commit sha 17ebd464ccdf12a4fb46334ff5d7a71f0f2e70a9
readline: fix key name for function keys with modifiers Fixes: https://github.com/nodejs/node/issues/35251 PR-URL: https://github.com/nodejs/node/pull/35268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
push time in a day
push eventDrunkenPoney/node
commit sha 448834c9504b8e6bcf44716b1f512da25fee8147
doc: relax prohibition on personal pronouns Our personal pronoun prohibition is contrary to most current technical documentation style guides. The prohibition on personal pronouns comes from academic style guides. It results in an unnecessary formal tone. It encourages wordiness and the overuse of passive voice. This change to our style guide more closely aligns us with the style guides of companies like Google, IBM, and Microsoft. Google's style guide suggests avoiding first-person pronouns and suggests: "Use the second-person pronoun (_you_) whenever possible." Refs: https://developers.google.com/style/pronouns#personal-pronouns IBM's style guide also recommends second-person voice ("Use second person ('you')"). Refs: https://www.ibm.com/developerworks/library/styleguidelines/index.html Similarly, Microsoft's style guide recommends using first person sparingly and avoiding first-person plural. "In general, use second person". Refs: https://docs.microsoft.com/en-us/style-guide/grammar/person#in-general-use-second-person PR-URL: https://github.com/nodejs/node/pull/34353 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 4c5bb1a1c7263f3b3619edb4e689fa7f5e9997d0
doc: sort repl references in ASCII order PR-URL: https://github.com/nodejs/node/pull/35230 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 770ad3a52dad9aa9977fae19221c6701352c1110
doc: remove excessive formatting in dgram.md PR-URL: https://github.com/nodejs/node/pull/35234 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha a8971f87d3573ac247110e6afde0dc475fe21264
url: support non-special URLs Fixes: https://github.com/nodejs/node/issues/34899 Refs: https://github.com/whatwg/url/pull/505 Refs: https://github.com/web-platform-tests/wpt/pull/25113 PR-URL: https://github.com/nodejs/node/pull/34925 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
commit sha 62ff6912c3f8d364a616308fc2fbd301f6853a37
doc: clarify napi_property_attributes text * Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 87c433e120604b2c44b87d5f6bcd8f8e00da6af6
test: improve assertions in pummel/test-timers * Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: https://github.com/nodejs/node/pull/35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
commit sha c31ef9827e5b2edf44734bc2eac6ea0f7989e914
doc: revise stability section of values doc Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: https://github.com/nodejs/node/pull/35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 039c274dded372ec3f59b31dafa8cab75277d44f
doc: standardize on _backward_ We use _backward incompatible_ and _backwards incompatible_ with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor _backward_. PR-URL: https://github.com/nodejs/node/pull/35243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
commit sha 9c62e0e384e2ea5a45a4011f31c97be60f2a0737
stream: move to internal/streams Move all the streams constructors to internal/streams and avoid a circular dependencies between the modules. See: https://github.com/nodejs/readable-stream/issues/348 PR-URL: https://github.com/nodejs/node/pull/35239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 98768f3b5b9db2cb384e67acd96713a6ac931df7
doc: edit subpath export patterns introduction * Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: https://github.com/nodejs/node/pull/35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
commit sha 17ebd464ccdf12a4fb46334ff5d7a71f0f2e70a9
readline: fix key name for function keys with modifiers Fixes: https://github.com/nodejs/node/issues/35251 PR-URL: https://github.com/nodejs/node/pull/35268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
push time in a day
pull request commentnodejs/node
repl: standardize Control key indications
@nodejs/documentation
comment created time in a day
pull request commentnodejs/node
repl: standardize Control key indications
I'm not sure if our markdown renderer supports this but Ctrl + C would be nice. If it doesn't we can also do it manually: https://snek.dev/keyboard.html
I like a lot of things about that approach, but I am somewhat conflicted and would prefer to keep the "standardize the abbreviation we use for the Control key" separate from "figure out how we render/markup keyboard keys". I'd be happy to open a different PR for that second one, unless you want to do it.
comment created time in a day
push eventTrott/io.js
commit sha a8971f87d3573ac247110e6afde0dc475fe21264
url: support non-special URLs Fixes: https://github.com/nodejs/node/issues/34899 Refs: https://github.com/whatwg/url/pull/505 Refs: https://github.com/web-platform-tests/wpt/pull/25113 PR-URL: https://github.com/nodejs/node/pull/34925 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
commit sha 62ff6912c3f8d364a616308fc2fbd301f6853a37
doc: clarify napi_property_attributes text * Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 87c433e120604b2c44b87d5f6bcd8f8e00da6af6
test: improve assertions in pummel/test-timers * Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: https://github.com/nodejs/node/pull/35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
commit sha c31ef9827e5b2edf44734bc2eac6ea0f7989e914
doc: revise stability section of values doc Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: https://github.com/nodejs/node/pull/35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 039c274dded372ec3f59b31dafa8cab75277d44f
doc: standardize on _backward_ We use _backward incompatible_ and _backwards incompatible_ with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor _backward_. PR-URL: https://github.com/nodejs/node/pull/35243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
commit sha 9c62e0e384e2ea5a45a4011f31c97be60f2a0737
stream: move to internal/streams Move all the streams constructors to internal/streams and avoid a circular dependencies between the modules. See: https://github.com/nodejs/readable-stream/issues/348 PR-URL: https://github.com/nodejs/node/pull/35239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 98768f3b5b9db2cb384e67acd96713a6ac931df7
doc: edit subpath export patterns introduction * Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: https://github.com/nodejs/node/pull/35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
commit sha 9a1c996ebcc7bddaba2634d992e3370c21b15df2
repl: standardize Control key indications Throughout our messages and docs, we refer to the Control key in a surprisingly varied number of ways: * Control * Ctrl * Cntl * varied capitalization on the above (e.g., ctrl vs. Ctrl) Then, in key combinations: * One of the items from the previous list followed by `-` * ... or followed by `+` * ... surrounded or not by `<` and `>` * ... and inside backticks or not * ... or just `^` This is the start of standardization on the formulation recommended by the Microsoft Style Guide (e.g., **Ctrl+C**).
push time in a day
pull request commentnodejs/node
doc: edit subpath export patterns introduction
Landed in 98768f3b5b9d
comment created time in a day
PR merged nodejs/node
- Use parallel construction in the two sentences
- Backticks around package.json to match rest of file
- Add comma for readability
- Own the recommendation ("we recommend")
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in a day
push eventnodejs/node
commit sha 98768f3b5b9db2cb384e67acd96713a6ac931df7
doc: edit subpath export patterns introduction * Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: https://github.com/nodejs/node/pull/35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
push time in a day
push eventTrott/io.js
commit sha 98768f3b5b9db2cb384e67acd96713a6ac931df7
doc: edit subpath export patterns introduction * Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: https://github.com/nodejs/node/pull/35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
push time in a day
push eventTrott/io.js
commit sha ed8af4e93831d3cf21d5562e900371d796b5fa20
doc: add issue labels sections to release guide PR-URL: https://github.com/nodejs/node/pull/35224 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
commit sha a63b90e8b1e2fd35afe3f7994207da66a315fc1e
doc: update attributes used by n-api samples (#35220) Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
commit sha f4586c902a721164c8af3c0e11db859f102dfe2e
doc: clarify use of NAPI_EXPERIMENTAL We've had a few questions about APIs not being available which were related to not having specified `NAPI_EXPERIMENTAL`. Add some additional documentation to explain this common issue: Refs: https://github.com/nodejs/node-addon-api/issues/810 Signed-off-by: Michael Dawson <[email protected]> PR-URL: https://github.com/nodejs/node/pull/35195 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
commit sha 31b3202d5902e7fa105949758677ea09643d8c5f
n-api: create N-API version 7 Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: https://github.com/nodejs/node/pull/35199 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
commit sha 448834c9504b8e6bcf44716b1f512da25fee8147
doc: relax prohibition on personal pronouns Our personal pronoun prohibition is contrary to most current technical documentation style guides. The prohibition on personal pronouns comes from academic style guides. It results in an unnecessary formal tone. It encourages wordiness and the overuse of passive voice. This change to our style guide more closely aligns us with the style guides of companies like Google, IBM, and Microsoft. Google's style guide suggests avoiding first-person pronouns and suggests: "Use the second-person pronoun (_you_) whenever possible." Refs: https://developers.google.com/style/pronouns#personal-pronouns IBM's style guide also recommends second-person voice ("Use second person ('you')"). Refs: https://www.ibm.com/developerworks/library/styleguidelines/index.html Similarly, Microsoft's style guide recommends using first person sparingly and avoiding first-person plural. "In general, use second person". Refs: https://docs.microsoft.com/en-us/style-guide/grammar/person#in-general-use-second-person PR-URL: https://github.com/nodejs/node/pull/34353 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 4c5bb1a1c7263f3b3619edb4e689fa7f5e9997d0
doc: sort repl references in ASCII order PR-URL: https://github.com/nodejs/node/pull/35230 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 770ad3a52dad9aa9977fae19221c6701352c1110
doc: remove excessive formatting in dgram.md PR-URL: https://github.com/nodejs/node/pull/35234 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha a8971f87d3573ac247110e6afde0dc475fe21264
url: support non-special URLs Fixes: https://github.com/nodejs/node/issues/34899 Refs: https://github.com/whatwg/url/pull/505 Refs: https://github.com/web-platform-tests/wpt/pull/25113 PR-URL: https://github.com/nodejs/node/pull/34925 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
commit sha 62ff6912c3f8d364a616308fc2fbd301f6853a37
doc: clarify napi_property_attributes text * Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 87c433e120604b2c44b87d5f6bcd8f8e00da6af6
test: improve assertions in pummel/test-timers * Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: https://github.com/nodejs/node/pull/35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
commit sha c31ef9827e5b2edf44734bc2eac6ea0f7989e914
doc: revise stability section of values doc Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: https://github.com/nodejs/node/pull/35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 039c274dded372ec3f59b31dafa8cab75277d44f
doc: standardize on _backward_ We use _backward incompatible_ and _backwards incompatible_ with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor _backward_. PR-URL: https://github.com/nodejs/node/pull/35243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
commit sha 9c62e0e384e2ea5a45a4011f31c97be60f2a0737
stream: move to internal/streams Move all the streams constructors to internal/streams and avoid a circular dependencies between the modules. See: https://github.com/nodejs/readable-stream/issues/348 PR-URL: https://github.com/nodejs/node/pull/35239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 98768f3b5b9db2cb384e67acd96713a6ac931df7
doc: edit subpath export patterns introduction * Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: https://github.com/nodejs/node/pull/35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
push time in a day
pull request commentnodejs/node
test: skip CPU-intensive test-hash-seed on low-CPU hosts
Does this affect all Raspberry Pis? Does this become a problem if there’s an architecture-specific issue with hash seed initialization and we don’t end up knowing about it because we skip the test?
It will affects all the Raspberry Pis currently in CI, as far as I know. However, it does not affect all ARM devices in our CI.
We don't run any pummel tests on Raspberry Pi right now, so the "we don't end up knowing about it" problem is already the case, I'm afraid.
As an alternative, I could see how long the test takes to run on Pi devices and increase the pummel test timeout to that. The timeout is already 8 minutes for pummel tests on Raspberry Pis.
comment created time in a day
push eventTrott/io.js
commit sha 9c62e0e384e2ea5a45a4011f31c97be60f2a0737
stream: move to internal/streams Move all the streams constructors to internal/streams and avoid a circular dependencies between the modules. See: https://github.com/nodejs/readable-stream/issues/348 PR-URL: https://github.com/nodejs/node/pull/35239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
push time in a day
pull request commentnodejs/node
test: skip CPU-intensive test-hash-seed on low-CPU hosts
Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16478/
comment created time in 2 days
PR opened nodejs/node
The test is timing out on Raspberry Pi devices. I have to imagine test/fixtures/guess-hash-seed requires faster/more CPU.
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr created time in 2 days
issue commentnodejs/node
investigate failing permutation in test-policy-integrity
@bmeck
comment created time in 2 days
issue commentnodejs/node
investigate failing permutation in test-policy-integrity
In both cases (linked below), the failed permutation is 118.
https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian9-64/37140/ https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc8/37140/
comment created time in 2 days
issue openednodejs/node
investigate failing permutation in test-policy-integrity
<!-- Thank you for reporting a flaky test.
Flaky tests are tests that fail occasionally in the Node.js CI, but not consistently enough to block PRs from landing, or that are failing in CI jobs or test modes that are not run for every PR.
Please fill in as much of the template below as you're able.
Test: The test that is flaky - e.g. test-fs-stat-bigint
Platform: The platform the test is flaky on - e.g. macos or linux
Console Output: A pasted console output from a failed CI job showing the whole
failure of the test
Build Links: Links to builds affected by the flaky test
If any investigation has been done, please include any information found, such as how consistently the test fails, whether the failure could be reproduced locally, when the test started failing, or anything else you think is relevant. -->
- Test: pummel/test-policy-integrity.js
- Platform: Linux
- Console Output:
08:11:16 not ok 2845 pummel/test-policy-integrity
08:11:16 ---
08:11:16 duration_ms: 16.746
08:11:16 severity: fail
08:11:16 exitcode: 1
08:11:16 stack: |-
08:11:16 permutation 118 failed
08:11:16 {
08:11:16 config: {
08:11:16 onError: 'exit',
08:11:16 shouldSucceed: true,
08:11:16 entryPath: './worker-spawner.cjs',
08:11:16 willDeletePolicy: true,
08:11:16 preloads: [],
08:11:16 parentPath: './parent.js',
08:11:16 depPath: './dep.js',
08:11:16 resources: {
08:11:16 './dep.js': {
08:11:16 body: '',
08:11:16 integrities: [
08:11:16 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=',
08:11:16 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU='
08:11:16 ]
08:11:16 },
08:11:16 './parent.js': {
08:11:16 body: '\n' +
08:11:16 ' if (!process.env.DEP_FILE) {\n' +
08:11:16 ' console.error(\n' +
08:11:16 " 'missing required DEP_FILE env to determine dependency'\n" +
08:11:16 ' );\n' +
08:11:16 ' process.exit(33);\n' +
08:11:16 ' }\n' +
08:11:16 ' require(process.env.DEP_FILE)\n' +
08:11:16 ' ',
08:11:16 integrities: [
08:11:16 'sha256-AzbH3oEA96J/+tLSqOJ+LaIt9vdOY+ikShkvKm0VutU=',
08:11:16 'sha256-R0QVSw9BUI7znwKNvt6BuzkLozhYKTtFNRSENIL5H7k='
08:11:16 ]
08:11:16 },
08:11:16 './worker-spawner.cjs': {
08:11:16 body: '\n' +
08:11:16 " const path = require('path');\n" +
08:11:16 " const { Worker } = require('worker_threads');\n" +
08:11:16 ' if (!process.env.PARENT_FILE) {\n' +
08:11:16 ' console.error(\n' +
08:11:16 " 'missing required PARENT_FILE env to determine worker entry point'\n" +
08:11:16 ' );\n' +
08:11:16 ' process.exit(33);\n' +
08:11:16 ' }\n' +
08:11:16 ' if (!process.env.DELETABLE_POLICY_FILE) {\n' +
08:11:16 ' console.error(\n' +
08:11:16 " 'missing required DELETABLE_POLICY_FILE env to check reloading'\n" +
08:11:16 ' );\n' +
08:11:16 ' process.exit(33);\n' +
08:11:16 ' }\n' +
08:11:16 ' const w = new Worker(path.resolve(process.env.PARENT_FILE));\n' +
08:11:16 " w.on('exit', (status) => process.exit(status === 0 ? 0 : 1));\n",
08:11:16 integrities: [
08:11:16 'sha256-23P4m8edtJAPTH24RJHIHMEuMVgP7QKcgWBSyj6FxPc=',
08:11:16 'sha256-XTRkNC3vxo+zvjv7CD8iapeqc7npNN7TwqRR0TOv5lg='
08:11:16 ]
08:11:16 }
08:11:16 }
08:11:16 },
08:11:16 manifest: {
08:11:16 onerror: 'exit',
08:11:16 resources: {
08:11:16 'file:///home/iojs/node-tmp/.tmp.2844/test-policy-integrity-permutation-118/dep.js': {
08:11:16 integrity: 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU= sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=',
08:11:16 dependencies: true
08:11:16 },
08:11:16 'file:///home/iojs/node-tmp/.tmp.2844/test-policy-integrity-permutation-118/parent.js': {
08:11:16 integrity: 'sha256-AzbH3oEA96J/+tLSqOJ+LaIt9vdOY+ikShkvKm0VutU= sha256-R0QVSw9BUI7znwKNvt6BuzkLozhYKTtFNRSENIL5H7k=',
08:11:16 dependencies: true
08:11:16 },
08:11:16 'file:///home/iojs/node-tmp/.tmp.2844/test-policy-integrity-permutation-118/worker-spawner.cjs': {
08:11:16 integrity: 'sha256-23P4m8edtJAPTH24RJHIHMEuMVgP7QKcgWBSyj6FxPc= sha256-XTRkNC3vxo+zvjv7CD8iapeqc7npNN7TwqRR0TOv5lg=',
08:11:16 dependencies: true
08:11:16 }
08:11:16 }
08:11:16 }
08:11:16 }
08:11:16 exit code: 1 signal: null
08:11:16 stdout:
08:11:16 stderr: (node:4190) ExperimentalWarning: Policies are experimental.
08:11:16 (Use `node --trace-warnings ...` to show where the warning was created)
08:11:16 Error [ERR_MANIFEST_ASSERT_INTEGRITY]: The content of "file:///home/iojs/node-tmp/package.json" does not match the expected integrity. The resource was not found in the policy.
08:11:16 at new NodeError (internal/errors.js:253:15)
08:11:16 at Manifest.assertIntegrity (internal/policy/manifest.js:532:19)
08:11:16 at Object.read (internal/modules/package_json_reader.js:34:16)
08:11:16 at readPackage (internal/modules/cjs/loader.js:277:36)
08:11:16 at readPackageScope (internal/modules/cjs/loader.js:310:19)
08:11:16 at shouldUseESMLoader (internal/modules/run_main.js:36:15)
08:11:16 at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:67:24)
08:11:16 at MessagePort.<anonymous> (internal/main/worker_thread.js:174:24)
08:11:16 at MessagePort.[nodejs.internal.kHybridDispatch] (internal/event_target.js:353:41)
08:11:16 at MessagePort.exports.emitMessage (internal/per_context/messageport.js:18:26)
08:11:16
08:11:16 /home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64/test/pummel/test-policy-integrity.js:186
08:11:16 throw e;
08:11:16 ^
08:11:16
08:11:16 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
08:11:16
08:11:16 1 !== 0
08:11:16
08:11:16 at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64/test/pummel/test-policy-integrity.js:169:18)
08:11:16 at ChildProcess.emit (events.js:326:20)
08:11:16 at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12) {
08:11:16 generatedMessage: true,
08:11:16 code: 'ERR_ASSERTION',
08:11:16 actual: 1,
08:11:16 expected: 0,
08:11:16 operator: 'strictEqual'
08:11:16 }
08:11:16 ...
- Build Links: https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian9-64/37140/ https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc8/37140/
created time in 2 days
issue commentnodejs/node
requires - require modules securely (restricted access to fs,net, etc)
@bmeck Thoughts on whether there's work to do here, how it ought to be, whether this should be closed, etc.?
comment created time in 2 days
PR opened nodejs/node
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr created time in 2 days
PR merged nodejs/node
We use backward incompatible and backwards incompatible with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor backward.
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in 2 days
pull request commentnodejs/node
doc: standardize on _backward_
Landed in 039c274dded3
comment created time in 2 days
push eventnodejs/node
commit sha 039c274dded372ec3f59b31dafa8cab75277d44f
doc: standardize on _backward_ We use _backward incompatible_ and _backwards incompatible_ with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor _backward_. PR-URL: https://github.com/nodejs/node/pull/35243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
push time in 2 days
push eventTrott/io.js
commit sha 039c274dded372ec3f59b31dafa8cab75277d44f
doc: standardize on _backward_ We use _backward incompatible_ and _backwards incompatible_ with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor _backward_. PR-URL: https://github.com/nodejs/node/pull/35243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
push time in 2 days
push eventTrott/io.js
commit sha c24ad832bbc6476eeb90deafdebb758ecd68d0de
build: increase API requests for stale action The second attempt at getting the auto closing of issues & PRs to work as expected without hitting a maximum operations allowed error we've been seeing. Recently discovered that the mentioned error is actually self imposed by the stale action itself. It keeps track of how many outgoing GitHub API requests it performs, and if that count exceeds the configured `operations-per-run` option, it exits to avoid hitting API rate limits. Default `operations-per-run` value is set to `30`. That's a very low limit and we're not at all concerned hitting that rate limit as of now, so we're bumping `operations-per-run` to `500` with these changes. Refs https://github.com/nodejs/node/issues/35144 PR-URL: https://github.com/nodejs/node/pull/35235 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
commit sha c314c04079bbf93d786a5855d0eaaed30d36820e
test: add wasi readdir() test This commit provides coverage for __wasi_fd_readdir(). PR-URL: https://github.com/nodejs/node/pull/35202 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
commit sha 59ca56eddefc78bab87d7e8e074b3af843ab1bc3
doc: fix small grammatical issues in timers.md PR-URL: https://github.com/nodejs/node/pull/35203 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
commit sha c9506a8f3e9bc5c679151feb39198023154464ab
n-api: add more property defaults Add a default value for class method and js like property in enum napi_property_attributes. n-api currently offers only one default which is non configurable, non writable, non enumerable - like Object.defineProperty(). While this is formal correct the usual way to create properties in JS is either by defining a class or use obj.prop = value. The defaults from these variants are now backed into enum values. PR-URL: https://github.com/nodejs/node/pull/35214 Refs: https://github.com/nodejs/node-addon-api/issues/811 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
commit sha 2d868fe822af00c65c9487546e0f313ef3d04564
module: exports pattern support PR-URL: https://github.com/nodejs/node/pull/34718 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
commit sha 018a6a4ab13247958a2db3203e15e4338f87c6dc
doc: fix header level for error code PR-URL: https://github.com/nodejs/node/pull/35219 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 14e98825a1e35f17b03aab22db52bc81e3a3ec94
doc: alphabetize error list PR-URL: https://github.com/nodejs/node/pull/35219 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha ed8af4e93831d3cf21d5562e900371d796b5fa20
doc: add issue labels sections to release guide PR-URL: https://github.com/nodejs/node/pull/35224 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
commit sha a63b90e8b1e2fd35afe3f7994207da66a315fc1e
doc: update attributes used by n-api samples (#35220) Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
commit sha f4586c902a721164c8af3c0e11db859f102dfe2e
doc: clarify use of NAPI_EXPERIMENTAL We've had a few questions about APIs not being available which were related to not having specified `NAPI_EXPERIMENTAL`. Add some additional documentation to explain this common issue: Refs: https://github.com/nodejs/node-addon-api/issues/810 Signed-off-by: Michael Dawson <[email protected]> PR-URL: https://github.com/nodejs/node/pull/35195 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
commit sha 31b3202d5902e7fa105949758677ea09643d8c5f
n-api: create N-API version 7 Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: https://github.com/nodejs/node/pull/35199 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
commit sha 448834c9504b8e6bcf44716b1f512da25fee8147
doc: relax prohibition on personal pronouns Our personal pronoun prohibition is contrary to most current technical documentation style guides. The prohibition on personal pronouns comes from academic style guides. It results in an unnecessary formal tone. It encourages wordiness and the overuse of passive voice. This change to our style guide more closely aligns us with the style guides of companies like Google, IBM, and Microsoft. Google's style guide suggests avoiding first-person pronouns and suggests: "Use the second-person pronoun (_you_) whenever possible." Refs: https://developers.google.com/style/pronouns#personal-pronouns IBM's style guide also recommends second-person voice ("Use second person ('you')"). Refs: https://www.ibm.com/developerworks/library/styleguidelines/index.html Similarly, Microsoft's style guide recommends using first person sparingly and avoiding first-person plural. "In general, use second person". Refs: https://docs.microsoft.com/en-us/style-guide/grammar/person#in-general-use-second-person PR-URL: https://github.com/nodejs/node/pull/34353 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 4c5bb1a1c7263f3b3619edb4e689fa7f5e9997d0
doc: sort repl references in ASCII order PR-URL: https://github.com/nodejs/node/pull/35230 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 770ad3a52dad9aa9977fae19221c6701352c1110
doc: remove excessive formatting in dgram.md PR-URL: https://github.com/nodejs/node/pull/35234 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha a8971f87d3573ac247110e6afde0dc475fe21264
url: support non-special URLs Fixes: https://github.com/nodejs/node/issues/34899 Refs: https://github.com/whatwg/url/pull/505 Refs: https://github.com/web-platform-tests/wpt/pull/25113 PR-URL: https://github.com/nodejs/node/pull/34925 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
commit sha 62ff6912c3f8d364a616308fc2fbd301f6853a37
doc: clarify napi_property_attributes text * Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 87c433e120604b2c44b87d5f6bcd8f8e00da6af6
test: improve assertions in pummel/test-timers * Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: https://github.com/nodejs/node/pull/35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
commit sha c31ef9827e5b2edf44734bc2eac6ea0f7989e914
doc: revise stability section of values doc Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: https://github.com/nodejs/node/pull/35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 039c274dded372ec3f59b31dafa8cab75277d44f
doc: standardize on _backward_ We use _backward incompatible_ and _backwards incompatible_ with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor _backward_. PR-URL: https://github.com/nodejs/node/pull/35243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
push time in 2 days
pull request commentnodejs/node
doc: revise stability section of values doc
Landed in c31ef9827e5b
comment created time in 2 days
PR merged nodejs/node
Make the section a bit shorter and comply with minor elements of Microsoft Style Guide.
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in 2 days
push eventnodejs/node
commit sha c31ef9827e5b2edf44734bc2eac6ea0f7989e914
doc: revise stability section of values doc Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: https://github.com/nodejs/node/pull/35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
push time in 2 days
push eventTrott/io.js
commit sha c31ef9827e5b2edf44734bc2eac6ea0f7989e914
doc: revise stability section of values doc Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: https://github.com/nodejs/node/pull/35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
push time in 2 days
push eventTrott/io.js
commit sha c24ad832bbc6476eeb90deafdebb758ecd68d0de
build: increase API requests for stale action The second attempt at getting the auto closing of issues & PRs to work as expected without hitting a maximum operations allowed error we've been seeing. Recently discovered that the mentioned error is actually self imposed by the stale action itself. It keeps track of how many outgoing GitHub API requests it performs, and if that count exceeds the configured `operations-per-run` option, it exits to avoid hitting API rate limits. Default `operations-per-run` value is set to `30`. That's a very low limit and we're not at all concerned hitting that rate limit as of now, so we're bumping `operations-per-run` to `500` with these changes. Refs https://github.com/nodejs/node/issues/35144 PR-URL: https://github.com/nodejs/node/pull/35235 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
commit sha c314c04079bbf93d786a5855d0eaaed30d36820e
test: add wasi readdir() test This commit provides coverage for __wasi_fd_readdir(). PR-URL: https://github.com/nodejs/node/pull/35202 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
commit sha 59ca56eddefc78bab87d7e8e074b3af843ab1bc3
doc: fix small grammatical issues in timers.md PR-URL: https://github.com/nodejs/node/pull/35203 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
commit sha c9506a8f3e9bc5c679151feb39198023154464ab
n-api: add more property defaults Add a default value for class method and js like property in enum napi_property_attributes. n-api currently offers only one default which is non configurable, non writable, non enumerable - like Object.defineProperty(). While this is formal correct the usual way to create properties in JS is either by defining a class or use obj.prop = value. The defaults from these variants are now backed into enum values. PR-URL: https://github.com/nodejs/node/pull/35214 Refs: https://github.com/nodejs/node-addon-api/issues/811 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
commit sha 2d868fe822af00c65c9487546e0f313ef3d04564
module: exports pattern support PR-URL: https://github.com/nodejs/node/pull/34718 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
commit sha 018a6a4ab13247958a2db3203e15e4338f87c6dc
doc: fix header level for error code PR-URL: https://github.com/nodejs/node/pull/35219 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 14e98825a1e35f17b03aab22db52bc81e3a3ec94
doc: alphabetize error list PR-URL: https://github.com/nodejs/node/pull/35219 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha ed8af4e93831d3cf21d5562e900371d796b5fa20
doc: add issue labels sections to release guide PR-URL: https://github.com/nodejs/node/pull/35224 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
commit sha a63b90e8b1e2fd35afe3f7994207da66a315fc1e
doc: update attributes used by n-api samples (#35220) Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
commit sha f4586c902a721164c8af3c0e11db859f102dfe2e
doc: clarify use of NAPI_EXPERIMENTAL We've had a few questions about APIs not being available which were related to not having specified `NAPI_EXPERIMENTAL`. Add some additional documentation to explain this common issue: Refs: https://github.com/nodejs/node-addon-api/issues/810 Signed-off-by: Michael Dawson <[email protected]> PR-URL: https://github.com/nodejs/node/pull/35195 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
commit sha 31b3202d5902e7fa105949758677ea09643d8c5f
n-api: create N-API version 7 Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: https://github.com/nodejs/node/pull/35199 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
commit sha 448834c9504b8e6bcf44716b1f512da25fee8147
doc: relax prohibition on personal pronouns Our personal pronoun prohibition is contrary to most current technical documentation style guides. The prohibition on personal pronouns comes from academic style guides. It results in an unnecessary formal tone. It encourages wordiness and the overuse of passive voice. This change to our style guide more closely aligns us with the style guides of companies like Google, IBM, and Microsoft. Google's style guide suggests avoiding first-person pronouns and suggests: "Use the second-person pronoun (_you_) whenever possible." Refs: https://developers.google.com/style/pronouns#personal-pronouns IBM's style guide also recommends second-person voice ("Use second person ('you')"). Refs: https://www.ibm.com/developerworks/library/styleguidelines/index.html Similarly, Microsoft's style guide recommends using first person sparingly and avoiding first-person plural. "In general, use second person". Refs: https://docs.microsoft.com/en-us/style-guide/grammar/person#in-general-use-second-person PR-URL: https://github.com/nodejs/node/pull/34353 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 4c5bb1a1c7263f3b3619edb4e689fa7f5e9997d0
doc: sort repl references in ASCII order PR-URL: https://github.com/nodejs/node/pull/35230 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 770ad3a52dad9aa9977fae19221c6701352c1110
doc: remove excessive formatting in dgram.md PR-URL: https://github.com/nodejs/node/pull/35234 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha a8971f87d3573ac247110e6afde0dc475fe21264
url: support non-special URLs Fixes: https://github.com/nodejs/node/issues/34899 Refs: https://github.com/whatwg/url/pull/505 Refs: https://github.com/web-platform-tests/wpt/pull/25113 PR-URL: https://github.com/nodejs/node/pull/34925 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
commit sha 62ff6912c3f8d364a616308fc2fbd301f6853a37
doc: clarify napi_property_attributes text * Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 87c433e120604b2c44b87d5f6bcd8f8e00da6af6
test: improve assertions in pummel/test-timers * Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: https://github.com/nodejs/node/pull/35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
commit sha c31ef9827e5b2edf44734bc2eac6ea0f7989e914
doc: revise stability section of values doc Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: https://github.com/nodejs/node/pull/35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
push time in 2 days
PR merged nodejs/node
- Timers should not fire early. Check for that.
- Allow the wiggle-room to increase on subsequent iterations of intervals.
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x]
make -j4 test(UNIX), orvcbuild test(Windows) passes - [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in 2 days
pull request commentnodejs/node
test: improve assertions in pummel/test-timers
Landed in 87c433e12060
comment created time in 2 days
push eventnodejs/node
commit sha 87c433e120604b2c44b87d5f6bcd8f8e00da6af6
test: improve assertions in pummel/test-timers * Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: https://github.com/nodejs/node/pull/35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
push time in 2 days
push eventTrott/io.js
commit sha a8971f87d3573ac247110e6afde0dc475fe21264
url: support non-special URLs Fixes: https://github.com/nodejs/node/issues/34899 Refs: https://github.com/whatwg/url/pull/505 Refs: https://github.com/web-platform-tests/wpt/pull/25113 PR-URL: https://github.com/nodejs/node/pull/34925 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
commit sha 62ff6912c3f8d364a616308fc2fbd301f6853a37
doc: clarify napi_property_attributes text * Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha 87c433e120604b2c44b87d5f6bcd8f8e00da6af6
test: improve assertions in pummel/test-timers * Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: https://github.com/nodejs/node/pull/35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
push time in 2 days
push eventTrott/io.js
commit sha cb90248c145763502ee8fae67960d45293c9e0bf
deps: update llhttp to 2.1.2 - update llhttp to 2.1.2 - modify test to support the latest llhttp PR-URL: https://github.com/nodejs-private/node-private/pull/215 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
commit sha df08d527c2083b852d8456b88b39114f30525236
http: add requestTimeout This commits introduces a new http.Server option called requestTimeout with a default value in milliseconds of 0. If requestTimeout is set to a positive value, the server will start a new timer set to expire in requestTimeout milliseconds when a new connection is established. The timer is also set again if new requests after the first are received on the socket (this handles pipelining and keep-alive cases). The timer is cancelled when: 1. the request body is completely received by the server. 2. the response is completed. This handles the case where the application responds to the client without consuming the request body. 3. the connection is upgraded, like in the WebSocket case. If the timer expires, then the server responds with status code 408 and closes the connection. CVE-2020-8251 PR-URL: https://github.com/nodejs-private/node-private/pull/208 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Co-Authored-By: Paolo Insogna <[email protected]> Co-Authored-By: Robert Nagy <[email protected]>
commit sha 3bdac31c4b177e13a895a8541b35fa046a557174
2020-09-15, Version 10.22.1 'Dubnium' (LTS) This is a security release. Notable changes: Vulnerabilities fixed: - CVE-2020-8252: fs.realpath.native on may cause buffer overflow (Medium). PR-URL: https://github.com/nodejs-private/node-private/pull/222
commit sha 9ab5c6b96ceef1ac53729e243d5f8de8641d05ae
2020-09-15, Version 12.18.4 'Erbium' (LTS) This is a security release. Notable changes: Vulnerabilities fixed: - CVE-2020-8201: HTTP Request Smuggling due to CR-to-Hyphen conversion (High). - CVE-2020-8252: fs.realpath.native on may cause buffer overflow (Medium). PR-URL: https://github.com/nodejs-private/node-private/pull/223
commit sha 8e173836538efb95f5ac5e898f177efff681d2aa
2020-09-15, Version 14.11.0 (Current) This is a security release. Notable changes: Vulnerabilities fixed: - CVE-2020-8251: Denial of Service by resource exhaustion CWE-400 due to unfinished HTTP/1.1 requests (Critical). - CVE-2020-8201: HTTP Request Smuggling due to CR-to-Hyphen conversion (High). PR-URL: https://github.com/nodejs-private/node-private/pull/225
commit sha d24eecd7d73959872058ea5cee5cd83a9825fa13
module: use isURLInstance instead of instanceof PR-URL: https://github.com/nodejs/node/pull/34951 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
commit sha 05771279affce857e9b4d684f9afe77606b30f35
src: enable wasm trap handler on windows PR-URL: https://github.com/nodejs/node/pull/35033 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
commit sha 9cf9e4aebccd3dc946d1ccb8d3f00b31d3e6371c
fs: loosen validation to allow objects with an own toString function PR-URL: https://github.com/nodejs/node/pull/34993 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
commit sha eb9d7a437e960753a7344d7e7885e6e3df4370aa
test: update WPT harness and tests PR-URL: https://github.com/nodejs/node/pull/33770 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
commit sha 4831278a16d0cbe9e54ba89f1bf4f114aed06e69
url: remove U+0000 case in the fragment state Port of https://github.com/whatwg/url/pull/486 PR-URL: https://github.com/nodejs/node/pull/33770 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
commit sha 69ef4c2375b5110886b08957cd2305ce8aa8eb32
url: verify domain is not empty after "ToASCII" Port of https://github.com/whatwg/url/pull/497 PR-URL: https://github.com/nodejs/node/pull/33770 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
commit sha 3aab64cd5f60ff2cfb6e902846df21942c910884
doc: fix broken link in crypto.md URL that lacks a scheme gets treated as a relative URL. Add missing `https://`. PR-URL: https://github.com/nodejs/node/pull/35181 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
commit sha dfa2dada07ce5804d392f6ed0f8ff1503e530ce1
doc: fix deprecation documentation inconsistencies PR-URL: https://github.com/nodejs/node/pull/35082 Reviewed-By: Rich Trott <[email protected]>
commit sha d4aac8399247ceb57cc517cb51ccdb24696ab4b5
doc: fix missing word in dgram.md The word "cannot" is missing from this sentence PR-URL: https://github.com/nodejs/node/pull/35231 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha 524123fbf064ff64bb6fcd83485cfc27db932f68
doc: update releaser in v12.18.4 changelog PR-URL: https://github.com/nodejs/node/pull/35217 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
commit sha 18462e0c1d5f3b3a3e86b7b40fb65975f1e27381
doc: replace "you should do X" with "do X" PR-URL: https://github.com/nodejs/node/pull/35194 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
commit sha c205f672e9cf0c70ea26f87eb97342947a244e18
doc: use command-line/command line consistently Docs switch between "command line" and "command-line" with no apparent uniformity. Microsoft Style Guide prescribes "command line" as a noun and "command-line" as a modifier, which makes a lot of sense to me. Updating docs as appropriate. PR-URL: https://github.com/nodejs/node/pull/35198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
commit sha 72e20298116d24baaf05f4dd0a0c997f1138b0c2
doc: remove "end user" We use "end user" in ambiguous ways. Sometimes we mean the developer, and sometimes we mean the application user. Use "developer" where developer is meant. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/u/user-end-user PR-URL: https://github.com/nodejs/node/pull/35200 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
commit sha fe293e914c3b9a65d2024971ebbefcf8a93dc549
doc: add technical values document As part of the [next-10](https://github.com/nodejs/next-10) we found we needed to capture the project's technical values/priorities as a starting point before discussing key technologies/areas for the next 10 years of Node.js This is a first cut that the team put together. The discussion took place in a few meetings as well as this [PR](https://github.com/nodejs/next-10/pull/11). We believe the doc should live in the core node repository as it is intended to reflect the agreement of the collaborator base. I think this is a good starting point but we also acknowledge that only a small subset of the Node.js collaborators have participated/commented so far. This PR should be a good way to get additional review/input from the larger set of Node.js collaborators. Signed-off-by: Michael Dawson <[email protected]> PR-URL: https://github.com/nodejs/node/pull/35145 Reviewed-By: Christopher Hiller <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]>
commit sha c24ad832bbc6476eeb90deafdebb758ecd68d0de
build: increase API requests for stale action The second attempt at getting the auto closing of issues & PRs to work as expected without hitting a maximum operations allowed error we've been seeing. Recently discovered that the mentioned error is actually self imposed by the stale action itself. It keeps track of how many outgoing GitHub API requests it performs, and if that count exceeds the configured `operations-per-run` option, it exits to avoid hitting API rate limits. Default `operations-per-run` value is set to `30`. That's a very low limit and we're not at all concerned hitting that rate limit as of now, so we're bumping `operations-per-run` to `500` with these changes. Refs https://github.com/nodejs/node/issues/35144 PR-URL: https://github.com/nodejs/node/pull/35235 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
push time in 2 days
push eventucsf-ckm/twilio-slack
commit sha 7468e704380a2f33c317c541cbbaeab59af688f6
Bump twilio from 3.49.1 to 3.49.2 (#56) Bumps [twilio](https://github.com/twilio/twilio-node) from 3.49.1 to 3.49.2. - [Release notes](https://github.com/twilio/twilio-node/releases) - [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md) - [Commits](https://github.com/twilio/twilio-node/compare/3.49.1...3.49.2) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
push time in 2 days
PR merged ucsf-ckm/twilio-slack
Bumps twilio from 3.49.1 to 3.49.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/twilio/twilio-node/releases">twilio's releases</a>.</em></p> <blockquote> <h2>3.49.2</h2> <h2><strong>Release Notes</strong></h2> <p><strong>Library - Fix</strong></p> <ul> <li>[PR <a href="https://github-redirect.dependabot.com/twilio/twilio-node/issues/614">#614</a>](<a href="https://github-redirect.dependabot.com/twilio/twilio-node/pull/614">twilio/twilio-node#614</a>): Prevent throwing an exception on 3xx response status code. Thanks to <a href="https://github.com/Saka7">@Saka7</a>!</li> </ul> <p><strong>Conversations</strong></p> <ul> <li>Expose Configuration and Service Configuration resources</li> <li>Add Unique Name support for Conversations</li> <li>Add Services Push Notification resource</li> <li>Add Service scoped Conversation resources</li> <li>Support Identity in Users resource endpoint</li> </ul> <p><strong>Messaging</strong></p> <ul> <li>GA Deactivation List API</li> <li>Add domain cert API's(fetch, update, create) for link tracker</li> </ul> <p><strong>Numbers</strong></p> <ul> <li>Add API endpoint for Supporting Document deletion</li> </ul> <p><strong>Proxy</strong></p> <ul> <li>Updated usage of FailOnParticipantConflict param to apply only to accounts with ProxyAllowParticipantConflict account flag</li> </ul> <p><strong>Supersim</strong></p> <ul> <li>Add <code>AccountSid</code> parameter to Sim resource update request</li> <li>Add <code>ready</code> status as an available status for a Sim resource</li> </ul> <p><strong><a href="https://twilio.com/docs/libraries/reference/twilio-node/3.49.2/index.html">Docs</a></strong></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twilio/twilio-node/blob/main/CHANGES.md">twilio's changelog</a>.</em></p> <blockquote> <h2>[2020-09-16] Version 3.49.2</h2> <p><strong>Library - Fix</strong></p> <ul> <li>[PR <a href="https://github-redirect.dependabot.com/twilio/twilio-node/issues/614">#614</a>](<a href="https://github-redirect.dependabot.com/twilio/twilio-node/pull/614">twilio/twilio-node#614</a>): Prevent throwing an exception on 3xx response status code. Thanks to <a href="https://github.com/Saka7">@Saka7</a>!</li> </ul> <p><strong>Conversations</strong></p> <ul> <li>Expose Configuration and Service Configuration resources</li> <li>Add Unique Name support for Conversations</li> <li>Add Services Push Notification resource</li> <li>Add Service scoped Conversation resources</li> <li>Support Identity in Users resource endpoint</li> </ul> <p><strong>Messaging</strong></p> <ul> <li>GA Deactivation List API</li> <li>Add domain cert API's(fetch, update, create) for link tracker</li> </ul> <p><strong>Numbers</strong></p> <ul> <li>Add API endpoint for Supporting Document deletion</li> </ul> <p><strong>Proxy</strong></p> <ul> <li>Updated usage of FailOnParticipantConflict param to apply only to accounts with ProxyAllowParticipantConflict account flag</li> </ul> <p><strong>Supersim</strong></p> <ul> <li>Add <code>AccountSid</code> parameter to Sim resource update request</li> <li>Add <code>ready</code> status as an available status for a Sim resource</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twilio/twilio-node/commit/11882ccbf3bae42f89724728204a22c343651857"><code>11882cc</code></a> Release 3.49.2</li> <li><a href="https://github.com/twilio/twilio-node/commit/68e2dc8d20f4de2acdc03c78446104d9a9cc3f05"><code>68e2dc8</code></a> [Librarian] Regenerated @ 8732a669867a2ca77fc16a1e3ec17c7d68c6d6a1</li> <li><a href="https://github.com/twilio/twilio-node/commit/c0f4da7ae6ae29bb7a5817599d6d2a33cd0d3fea"><code>c0f4da7</code></a> fix: Prevent throwing an exception on 3xx response status code (<a href="https://github-redirect.dependabot.com/twilio/twilio-node/issues/614">#614</a>)</li> <li>See full diff in <a href="https://github.com/twilio/twilio-node/compare/3.49.1...3.49.2">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in your Dependabot dashboard:
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details>
pr closed time in 2 days
push eventTrott/solr-proxy
commit sha 584f96a6d61414687a089d17e957548570ac4551
Bump debug from 4.1.1 to 4.2.0 Bumps [debug](https://github.com/visionmedia/debug) from 4.1.1 to 4.2.0. - [Release notes](https://github.com/visionmedia/debug/releases) - [Commits](https://github.com/visionmedia/debug/compare/4.1.1...4.2.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
commit sha 9f96ce7d4f2a4bb4efa4a41c6785b66b3ab9fbeb
Merge pull request #71 from Trott/dependabot/npm_and_yarn/debug-4.2.0 Bump debug from 4.1.1 to 4.2.0
push time in 2 days
PR merged Trott/solr-proxy
Bumps debug from 4.1.1 to 4.2.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/visionmedia/debug/commit/80ef62a3af4df95250d77d64edfc3d0e1667e7e8"><code>80ef62a</code></a> 4.2.0</li> <li><a href="https://github.com/visionmedia/debug/commit/09914af00e4c1479db9aa160bc51cb8c7e063ca4"><code>09914af</code></a> Marks supports-color as an <em>optional</em> peer dependency</li> <li><a href="https://github.com/visionmedia/debug/commit/db306db99e7822d355724698990d335927563210"><code>db306db</code></a> Update and pin ms to 2.1.2</li> <li><a href="https://github.com/visionmedia/debug/commit/6b07f9e50a528b6b47256d876f7e77374c337333"><code>6b07f9e</code></a> Fixes: Unable to take control over selectColor <a href="https://github-redirect.dependabot.com/visionmedia/debug/issues/747">#747</a></li> <li><a href="https://github.com/visionmedia/debug/commit/0c1d5180ff9559b506c8b431b24842bed0e8a5e2"><code>0c1d518</code></a> remove dead code and fix lowercase comment (for linter)</li> <li><a href="https://github.com/visionmedia/debug/commit/4acdeedd4b532f0b5a86b35019e0bc9f081d04b4"><code>4acdeed</code></a> run linter inside of test script</li> <li><a href="https://github.com/visionmedia/debug/commit/3f4d7247c0f57085c3d8450593b22ecd7ef73886"><code>3f4d724</code></a> Add "engines" to <code>package.json</code> (<a href="https://github-redirect.dependabot.com/visionmedia/debug/issues/680">#680</a>)</li> <li><a href="https://github.com/visionmedia/debug/commit/608fca962b34e2bda841db9a4416bab6b4a62803"><code>608fca9</code></a> Update ISSUE_TEMPLATE.md</li> <li><a href="https://github.com/visionmedia/debug/commit/5c7c61dc0df0db4eb5de25707d8cd1b9be1add4f"><code>5c7c61d</code></a> fix links in issue templates</li> <li><a href="https://github.com/visionmedia/debug/commit/976f8d2afc5e2a815225ff6eca2e02f4ef0462ee"><code>976f8d2</code></a> add issue and pull request templates</li> <li>Additional commits viewable in <a href="https://github.com/visionmedia/debug/compare/4.1.1...4.2.0">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in your Dependabot dashboard:
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details>
pr closed time in 2 days
pull request commentnodejs/node
test: improve assertions in pummel/test-timers
As far as I know windows timers sometimes fire slightly earlier. At least I faced issues with flaky timer tests in an earlier project because of this. It may depend on the timeout, the windows version and the load on the machine.
I did a fast test and at least for a 16 and a 30ms timeout I saw that callback was called 0.x ms earlier then expected. I measured time using
process.hrtime()not sure if this makes a difference.
Firing less than 1ms early based on process.hrtime() seems plausible to me due to rounding errors. I'm inclined to leave this as is and then allow for 1 millisecond early if it proves to be flaky.
comment created time in 2 days
pull request commentnodejs/node
doc: update message to match actual output
This is blocked until https://github.com/nodejs/node-inspect/pull/89 lands and makes it into our deps.
comment created time in 3 days
PR opened nodejs/node
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr created time in 3 days
PR opened nodejs/node-inspect
tap@10 results in lots of audit warnings when running npm install.
tap@13 and above fails some tests as they currently exist.
Using tap@12 means no audit warnings on install and the tests still pass without modification.
pr created time in 3 days
PR opened nodejs/node-inspect
Node.js uses (or will use) Ctrl+C with no spaces. To unify the messages from inspect with other messages from the REPL and elsewhere, make that change in node-inspect too.
pr created time in 3 days
push eventTrott/node-inspect
commit sha b4d3c1a31db29223a18ddaf0bcf4db7ed39c4dea
chore: Update dependencies Update ESLint and tap to quell warnings from `npm audit` and the GitHub interface. ESLint update required some changes to other files as indentation rules are now more strictly enforced. I'm seeing tests failing locally but that was the case before I updated anything too, so hopefully this passes on Travis-CI or whatever.
commit sha af55a32c0f91c7e7214ad816313c6ea4ed2e50e2
Merge pull request #71 from Trott/update-deps chore: Update dependencies
commit sha c2ab7c246f2b1ee153b340ff3a625d00d17fea30
portIsFree timeout increased In windows, assigning a port may take a little longer than previously assumed value of 2000ms. I am using Windows 10 1903 64bit, and it takes about 3000ms to initialize a port. I increased the timeout to some higher value (9999ms) to give a little more space to Windows to initialize a port to use with the app. This patch probably solves issues #48, #54 and #70
commit sha 6f7df37507c6d52c3ccb3f81210ea0c91bba6f54
fix: Revert "chore: Update dependencies" This reverts commit b4d3c1a31db29223a18ddaf0bcf4db7ed39c4dea, as it significantly broke the test suite.
commit sha 75c3e935bd7cf338eddedbcecdd02975903e4890
Merge pull request #75 from addaleax/revert-71 fix: Revert "chore: Update dependencies"
commit sha 8077b0230008a8d09643d89945b5fb1e21964cf3
chore: Test with GitHub Actions Add a workflow to run tests with GitHub Actions.
commit sha 1e1f99f80290f4f50ac4a642f30ca04a7549ce5b
Merge pull request #78 from nodejs/workflow [WIP] chore: Test with GitHub Actions
commit sha fbec9db617d5c914573f975ded463d5411746b79
fix: Avoid using process.binding() This is deprecated and emits a warning with `--pending-deprecation`. I’m afraid I’m not familiar enough with this code to provide a test, unfortunately.
commit sha 41bf9ddba90fef21c5135f8f6686ab50c6c251ce
chore(deps-dev): bump eslint from 3.19.0 to 6.8.0 Bumps [eslint](https://github.com/eslint/eslint) from 3.19.0 to 6.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v3.19.0...v6.8.0) Signed-off-by: dependabot[bot] <[email protected]>
commit sha 6b245c7f6bf15b90aa319150d7cd9ca26a144356
Merge pull request #76 from addaleax/no-process-binding fix: Avoid using process.binding()
commit sha 8fa806b154c17404b7beddbfc61d144e2a65a28e
style: run eslint --fix
commit sha 426ed809ff2594bef45a17106b73255f93b233b7
Merge pull request #79 from nodejs/dependabot/npm_and_yarn/eslint-6.8.0 chore(deps-dev): bump eslint from 3.19.0 to 6.8.0
commit sha 8817c16a195d398c5091d71273e5661e01076904
feat: auto-resume on start breakpoint
commit sha 12530bfc603d0748f61da68a926f015c4afb987d
refactor: move resume on start logic to repl
commit sha fec399bd6e99320ba3f3162adffb8fd95f567612
Merge pull request #80 from dolsem/master feat: auto-resume on start breakpoint
commit sha ba58bb095f6318a534444851ab666f1485c27b07
Merge pull request #73 from yilmazdurmaz/timeout_fix "portIsFree" function's "timeout" parameter value increased to solve issues #48, #54 and #70
commit sha 3760bbf0ffb629fe396c0c456beafede29f3768c
test: add a test for remote debugging Refs: https://github.com/nodejs/node-inspect/issues/42
commit sha fc4a1231246dc3ad0a21d0fa9581aad58cedc6a1
Merge pull request #82 from oyyd/remote-address-test test: add a test for remote debugging
commit sha a6cb308aee62e15154a7e98d9123a74470c52a16
2.0.0
commit sha cdae28196de0f428a4034f4725502efa55525de4
docs: Add usage example for `--port` (#85)
push time in 3 days
push eventTrott/io.js
push time in 3 days
push eventTrott/io.js
commit sha 51bf656982fbca54f3c75431310fb0f9a822feb6
repl: standardize Control key indications Throughout our messages and docs, we refer to the Control key in a surprisingly varied number of ways: * Control * Ctrl * Cntl * varied capitalization on the above (e.g., ctrl vs. Ctrl) Then, in key combinations: * One of the items from the previous list followed by `-` * ... or followed by `+` * ... surrounded or not by `<` and `>` * ... and inside backticks or not * ... or just `^` This is the start of standardization on the formulation recommended by the Microsoft Style Guide (e.g., **Ctrl+C**).
push time in 3 days
PR opened nodejs/node
Throughout our messages and docs, we refer to the Control key in a surprisingly varied number of ways:
- Control
- Ctrl
- Cntl
- varied capitalization on the above (e.g., ctrl vs. Ctrl)
Then, in key combinations:
- One of the items from the previous list followed by
- - ... or followed by
+ - ... surrounded or not by
<and> - ... and inside backticks or not
- ... or just
^
This is the start of standardization on the formulation recommended by the Microsoft Style Guide (e.g., Ctrl+C).
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x]
make -j4 test(UNIX), orvcbuild test(Windows) passes - [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr created time in 3 days
Pull request review commentnodejs/node
add proxy handler "has" for "http2.Http2ServerResponse.socket" and "http2.Http2ServerRequest.socket"
function resumeStream(stream) { } const proxySocketHandler = {+ has(stream, prop) {+ const ref = stream.session !== undefined ? stream.session[kSocket] : stream;+ return (prop in stream) || (prop in ref);
Optional suggestion: The test file only covers one of these conditions, right? Does it make sense to add a test case so that both are covered?
comment created time in 3 days
issue commentnodejs/node
investigate flaky test-child-process-exec-timeout on SmartOS
@nodejs/platform-smartos @nodejs/testing @nodejs/child_process
comment created time in 3 days
issue openednodejs/node
investigate flaky test-child-process-exec-timeout on SmartOS
<!-- Thank you for reporting a flaky test.
Flaky tests are tests that fail occasionally in the Node.js CI, but not consistently enough to block PRs from landing, or that are failing in CI jobs or test modes that are not run for every PR.
Please fill in as much of the template below as you're able.
Test: The test that is flaky - e.g. test-fs-stat-bigint
Platform: The platform the test is flaky on - e.g. macos or linux
Console Output: A pasted console output from a failed CI job showing the whole
failure of the test
Build Links: Links to builds affected by the flaky test
If any investigation has been done, please include any information found, such as how consistently the test fails, whether the failure could be reproduced locally, when the test started failing, or anything else you think is relevant. -->
- Test: parallel/test-child-process-exec-timeout
- Platform: smartos
- Console Output:
not ok 150 parallel/test-child-process-exec-timeout
---
duration_ms: 2.833
severity: fail
exitcode: 1
stack: |-
/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos18-64/test/parallel/test-child-process-exec-timeout.js:20
assert.strictEqual(err.killed, true);
^
TypeError: Cannot read property 'killed' of null
at /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos18-64/test/parallel/test-child-process-exec-timeout.js:20:26
at /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos18-64/test/common/index.js:363:15
at ChildProcess.exithandler (child_process.js:299:7)
at ChildProcess.emit (events.js:326:20)
at maybeClose (internal/child_process.js:1047:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
...
- Build Links: https://ci.nodejs.org/job/node-test-commit-smartos/34883/nodes=smartos18-64/consoleText
created time in 3 days
PR merged nodejs/node
<!-- Thank you for your pull request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->
Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
<!-- Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in 3 days
pull request commentnodejs/node
doc: remove excessive formatting in dgram.md
Landed in 770ad3a52dad
comment created time in 3 days
push eventnodejs/node
commit sha 770ad3a52dad9aa9977fae19221c6701352c1110
doc: remove excessive formatting in dgram.md PR-URL: https://github.com/nodejs/node/pull/35234 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
push time in 3 days