profile
viewpoint

brson/rust 8

pursuing the trifecta

alexcrichton/cargo 0

Cargo Experiments

pull request commentrust-lang/rust

Rollup of 5 pull requests

:pushpin: Commit 210b18118e3e59ed84b87de4716b98dc4cc393bd has been approved by Dylan-DPC

<!-- @bors r=Dylan-DPC 210b18118e3e59ed84b87de4716b98dc4cc393bd --> <!-- homu: {"type":"Approved","sha":"210b18118e3e59ed84b87de4716b98dc4cc393bd","approver":"Dylan-DPC"} -->

Dylan-DPC

comment created time in 13 minutes

push eventrust-lang/rust-clippy

Yuki Okushi

commit sha f4b80394d7b2fd24b3d3a1a3eeea2e22ddc8974b

Use `Vec::with_capacity()` as possible

view details

Yuki Okushi

commit sha 06cb96ed72e09b9f850ee3e08e50df0c51e02250

Clean up imports

view details

bors

commit sha bfa334391bbdfbb30b04c2382dc0a1a674194714

Auto merge of #5191 - JohnTitor:clean-up, r=flip1995 Minor cleanup - Use `Vec::with_capacity()` as possible - Clean up imports changelog: none

view details

push time in 14 minutes

pull request commentrust-lang/rust-clippy

Minor cleanup

:hourglass: Testing commit 06cb96ed72e09b9f850ee3e08e50df0c51e02250 with merge bfa334391bbdfbb30b04c2382dc0a1a674194714... <!-- homu: {"type":"BuildStarted","head_sha":"06cb96ed72e09b9f850ee3e08e50df0c51e02250","merge_sha":"bfa334391bbdfbb30b04c2382dc0a1a674194714"} -->

JohnTitor

comment created time in 14 minutes

pull request commentrust-lang/rust-clippy

Minor cleanup

:pushpin: Commit 06cb96ed72e09b9f850ee3e08e50df0c51e02250 has been approved by flip1995

<!-- @bors r=flip1995 06cb96ed72e09b9f850ee3e08e50df0c51e02250 --> <!-- homu: {"type":"Approved","sha":"06cb96ed72e09b9f850ee3e08e50df0c51e02250","approver":"flip1995"} -->

JohnTitor

comment created time in 14 minutes

pull request commentrust-lang/rust

Clean up E0310 explanation

:pushpin: Commit 73283f1b32f2c607be6ba5d51d867f8862eca95e has been approved by Dylan-DPC

<!-- @bors r=Dylan-DPC 73283f1b32f2c607be6ba5d51d867f8862eca95e --> <!-- homu: {"type":"Approved","sha":"73283f1b32f2c607be6ba5d51d867f8862eca95e","approver":"Dylan-DPC"} -->

GuillaumeGomez

comment created time in 18 minutes

PR merged rust-lang/cargo

Rework internal errors. S-waiting-on-bors

This changes the behavior of "internal" errors, which were previously hidden and only displayed with --verbose. The changes here:

  • internal now means "a cargo bug", and is always displayed and requests that the user file a bug report.
  • Added VerboseError to signify an error that should only be displayed with --verbose. This is only used in one place, to display the rustc compiler command if the compiler exited with a normal error code (i.e. not a crash).
  • Audited the uses of internal errors, and promoted some to normal errors, as they seemed to contain useful information, but weren't necessarily bugs in cargo.
  • Added some details to some errors.
  • Sometimes the "run with --verbose" message wasn't being printed when I think it should. This happened when rustc failed while other rustc processes were running. Another case was with cargo install installing multiple packages, and one of them fails.
+215 -136

5 comments

21 changed files

ehuss

pr closed time in 21 minutes

push eventrust-lang/cargo

Eric Huss

commit sha 0d44a8267bf503645ceb5f5853abdd4cce407dc8

Rework internal errors.

view details

bors

commit sha 74f2b400d2be43da798f99f94957d359bc223988

Auto merge of #7896 - ehuss:internal-errors, r=alexcrichton Rework internal errors. This changes the behavior of "internal" errors, which were previously hidden and only displayed with `--verbose`. The changes here: - `internal` now means "a cargo bug", and is always displayed and requests that the user file a bug report. - Added `VerboseError` to signify an error that should only be displayed with `--verbose`. This is only used in one place, to display the `rustc` compiler command if the compiler exited with a normal error code (i.e. not a crash). - Audited the uses of internal errors, and promoted some to normal errors, as they seemed to contain useful information, but weren't necessarily bugs in cargo. - Added some details to some errors. - Sometimes the "run with --verbose" message wasn't being printed when I think it should. This happened when rustc failed while other rustc processes were running. Another case was with `cargo install` installing multiple packages, and one of them fails.

view details

push time in 21 minutes

pull request commentrust-lang/cargo

Rework internal errors.

:sunny: Test successful - checks-azure Approved by: alexcrichton Pushing 74f2b400d2be43da798f99f94957d359bc223988 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"alexcrichton","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/473adcf1-6656-4c7e-9337-c393e7e0431c/_build/results?buildId=21256"},"merge_sha":"74f2b400d2be43da798f99f94957d359bc223988"} -->

ehuss

comment created time in 21 minutes

pull request commentrust-lang/rust

const limit for CTFE

:umbrella: The latest upstream changes (presumably #69258) made this pull request unmergeable. Please resolve the merge conflicts.

TheSamsa

comment created time in 23 minutes

push eventrust-lang/rust

Oliver Middleton

commit sha 84f3356e0dffc36f57d9be7902822db5d362e24f

Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

LeSeulArtichaut

commit sha 2ae493a767536b0a5180c788d9ecf2b7ea8bf749

Stabilize {f32, f64}::{LOG2_10, LOG10_2}

view details

spunit262

commit sha a9b5c692d9319a993ca5dfa6e853a3f5d3f68079

Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Fisher Darling

commit sha c53693d34d83e6221dc8b93a2c4e17e66fa6f0e2

Handle recursion_limit parsing errors

view details

Esteban Küber

commit sha e5b2c66dea8e2d721612089ebfa00e0799cd5e50

Do not ICE when encountering `yield` inside `async` block

view details

Josh Stone

commit sha 3a55e8875e1c5f4b12954fc939efa76bc9da0a8c

configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Mark Rousskov

commit sha c992ab23fa14a38c5565889d52ba3a3fb6e1e831

Clean out some default-installed directories This helps us have enough disk space for our builders to be able to complete successfully. For now, the choices are ad-hoc and 'definitely not needed'. This should never fail the build, as everything our build needs should be inside Docker.

view details

Yuki Okushi

commit sha 6c4f8598b916087e2758d8c14c249ee5fa4fa0d5

Rollup merge of #67272 - fisherdarling:master, r=varkor,hellow554 recursion_limit parsing handles overflows This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`. closes #67265

view details

Yuki Okushi

commit sha ae81241eae061ee9fb2af798b109508c27f208f1

Rollup merge of #68597 - ollie27:skip_nth_last, r=Amanieu Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Yuki Okushi

commit sha 284acafe61fa76eb56ca2dddd479a2b5f9a262cd

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

Yuki Okushi

commit sha 35e7c783a26a33375b765c7b5fbb18a11cab3aff

Rollup merge of #69175 - estebank:shall-not-ice, r=petrochenkov Do not ICE when encountering `yield` inside `async` block Fix #67158.

view details

Yuki Okushi

commit sha 8b34f72b4f1a13947c1f066ccd63479da53d3e3d

Rollup merge of #69223 - spunit262:empty-string-gdb-version, r=Dylan-DPC Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Yuki Okushi

commit sha 6528b9f88799d0a4a2a09c32494b7d207880ddb8

Rollup merge of #69244 - cuviper:llvm-flags, r=Mark-Simulacrum configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Yuki Okushi

commit sha 20c483506a8e1c904f57d8775252f0f74d6de1f2

Rollup merge of #69249 - LeSeulArtichaut:stabilize-logs-consts, r=sfackler Stabilize {f32, f64}::{LOG2_10, LOG10_2} Following the decision to stabilize `LOG2_10` and `LOG10_2` in https://github.com/rust-lang/rust/issues/50540#issuecomment-536627588. Closes #50540. r? @sfackler

view details

Yuki Okushi

commit sha c1a05fbf00f4cf23e43036b2764a835ed4c3c96f

Rollup merge of #69252 - Mark-Simulacrum:disk-try, r=pietroalbini Clean out unused directories for extra disk space This cleans out some of the unused (but large) directories on our linux builders to hopefully allow them to complete without running out of disk space.

view details

bors

commit sha 6317721cd951030f1f28801c34931c3c2322bc06

Auto merge of #69258 - JohnTitor:rollup-n2hljai, r=JohnTitor Rollup of 8 pull requests Successful merges: - #67272 (recursion_limit parsing handles overflows) - #68597 (Simplify `Skip::nth` and `Skip::last` implementations) - #68767 (macOS: avoid calling pthread_self() twice) - #69175 (Do not ICE when encountering `yield` inside `async` block) - #69223 (Ignore GDB versions with broken str printing.) - #69244 (configure: set LLVM flags with a value) - #69249 (Stabilize {f32, f64}::{LOG2_10, LOG10_2}) - #69252 (Clean out unused directories for extra disk space) Failed merges: r? @ghost

view details

John Kåre Alsaker

commit sha f78b0c89f53f225d372f19201730887eca59f4ca

Split query execution into hot and cold paths

view details

John Kåre Alsaker

commit sha 4c42beead4afd6a6eb611c2b7019fd507a2e68c6

Make `try_get_cached` take closures

view details

John Kåre Alsaker

commit sha 7bdb8aa458bec1fe9be07b0f205f25498508e037

Add an abstraction for custom query caches

view details

push time in 24 minutes

pull request commentrust-lang/rust

[WIP] Add an abstraction for custom query caches

:hourglass: Trying commit dbc8f8e5864bdf4833c7bd3c3072e2bec5003007 with merge 6e4fb02185fae88af7d0774391141e0f3bfca114... <!-- homu: {"type":"TryBuildStarted","head_sha":"dbc8f8e5864bdf4833c7bd3c3072e2bec5003007","merge_sha":"6e4fb02185fae88af7d0774391141e0f3bfca114"} -->

Zoxc

comment created time in 24 minutes

push eventrust-lang/rust

Yuki Okushi

commit sha 3b431234e06962983df6e0ce17cd074c2ab380bd

Update Clippy

view details

bors

commit sha b0d5813fd7fe4696b6eb61acf473a7f7a5f9b5a0

Auto merge of #69234 - JohnTitor:clippy-up, r=JohnTitor Update Clippy Fixes #69221 r? @ghost

view details

push time in 32 minutes

pull request commentrust-lang/rust

Update Clippy

:hourglass: Testing commit 3b431234e06962983df6e0ce17cd074c2ab380bd with merge b0d5813fd7fe4696b6eb61acf473a7f7a5f9b5a0... <!-- homu: {"type":"BuildStarted","head_sha":"3b431234e06962983df6e0ce17cd074c2ab380bd","merge_sha":"b0d5813fd7fe4696b6eb61acf473a7f7a5f9b5a0"} -->

JohnTitor

comment created time in 32 minutes

PR merged rust-lang/rust

recursion_limit parsing handles overflows S-waiting-on-bors

This PR adds overflow handling to #![recursion_limit] attribute parsing. If parsing the given value results in an IntErrorKind::Overflow, then the recursion_limit is set to usize::max_value().

closes #67265

+112 -6

21 comments

10 changed files

fisherdarling

pr closed time in 32 minutes

PR merged rust-lang/rust

Simplify `Skip::nth` and `Skip::last` implementations S-waiting-on-bors

The main improvement is to make last no longer recursive.

+7 -13

4 comments

1 changed file

ollie27

pr closed time in 32 minutes

PR merged rust-lang/rust

macOS: avoid calling pthread_self() twice S-waiting-on-bors
+3 -2

9 comments

1 changed file

kubo39

pr closed time in 32 minutes

PR merged rust-lang/rust

Do not ICE when encountering `yield` inside `async` block S-waiting-on-bors T-compiler beta-nominated stable-nominated

Fix #67158.

+18 -3

5 comments

4 changed files

estebank

pr closed time in 32 minutes

PR merged rust-lang/rust

Ignore GDB versions with broken str printing. S-waiting-on-bors

https://sourceware.org/bugzilla/show_bug.cgi?id=22236

+1 -0

3 comments

1 changed file

spunit262

pr closed time in 32 minutes

PR merged rust-lang/rust

configure: set LLVM flags with a value S-waiting-on-bors

Rather than a boolean --enable-cflags etc., these options should reflect that they are for LLVM, and that they need a value. You would now use ./configure --llvm-cflags="...".

+3 -3

4 comments

1 changed file

cuviper

pr closed time in 33 minutes

PR merged rust-lang/rust

Stabilize {f32, f64}::{LOG2_10, LOG10_2} S-waiting-on-bors T-libs relnotes

Following the decision to stabilize LOG2_10 and LOG10_2 in https://github.com/rust-lang/rust/issues/50540#issuecomment-536627588.

Closes #50540. r? @sfackler

+4 -4

3 comments

2 changed files

LeSeulArtichaut

pr closed time in 33 minutes

pull request commentrust-lang/rust

Clean out unused directories for extra disk space

:hourglass: Testing commit c992ab23fa14a38c5565889d52ba3a3fb6e1e831 with merge 6317721cd951030f1f28801c34931c3c2322bc06... <!-- homu: {"type":"BuildStarted","head_sha":"c992ab23fa14a38c5565889d52ba3a3fb6e1e831","merge_sha":"6317721cd951030f1f28801c34931c3c2322bc06"} -->

Mark-Simulacrum

comment created time in 33 minutes

PR merged rust-lang/rust

Clean out unused directories for extra disk space S-waiting-on-bors

This cleans out some of the unused (but large) directories on our linux builders to hopefully allow them to complete without running out of disk space.

+19 -0

13 comments

2 changed files

Mark-Simulacrum

pr closed time in 33 minutes

PR merged rust-lang/rust

Rollup of 8 pull requests S-waiting-on-bors merged-by-bors

Successful merges:

  • #67272 (recursion_limit parsing handles overflows)
  • #68597 (Simplify Skip::nth and Skip::last implementations)
  • #68767 (macOS: avoid calling pthread_self() twice)
  • #69175 (Do not ICE when encountering yield inside async block)
  • #69223 (Ignore GDB versions with broken str printing.)
  • #69244 (configure: set LLVM flags with a value)
  • #69249 (Stabilize {f32, f64}::{LOG2_10, LOG10_2})
  • #69252 (Clean out unused directories for extra disk space)

Failed merges:

r? @ghost

+167 -31

5 comments

22 changed files

JohnTitor

pr closed time in 33 minutes

push eventrust-lang/rust

Oliver Middleton

commit sha 84f3356e0dffc36f57d9be7902822db5d362e24f

Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

LeSeulArtichaut

commit sha 2ae493a767536b0a5180c788d9ecf2b7ea8bf749

Stabilize {f32, f64}::{LOG2_10, LOG10_2}

view details

spunit262

commit sha a9b5c692d9319a993ca5dfa6e853a3f5d3f68079

Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Fisher Darling

commit sha c53693d34d83e6221dc8b93a2c4e17e66fa6f0e2

Handle recursion_limit parsing errors

view details

Esteban Küber

commit sha e5b2c66dea8e2d721612089ebfa00e0799cd5e50

Do not ICE when encountering `yield` inside `async` block

view details

Josh Stone

commit sha 3a55e8875e1c5f4b12954fc939efa76bc9da0a8c

configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Mark Rousskov

commit sha c992ab23fa14a38c5565889d52ba3a3fb6e1e831

Clean out some default-installed directories This helps us have enough disk space for our builders to be able to complete successfully. For now, the choices are ad-hoc and 'definitely not needed'. This should never fail the build, as everything our build needs should be inside Docker.

view details

Yuki Okushi

commit sha 6c4f8598b916087e2758d8c14c249ee5fa4fa0d5

Rollup merge of #67272 - fisherdarling:master, r=varkor,hellow554 recursion_limit parsing handles overflows This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`. closes #67265

view details

Yuki Okushi

commit sha ae81241eae061ee9fb2af798b109508c27f208f1

Rollup merge of #68597 - ollie27:skip_nth_last, r=Amanieu Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Yuki Okushi

commit sha 284acafe61fa76eb56ca2dddd479a2b5f9a262cd

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

Yuki Okushi

commit sha 35e7c783a26a33375b765c7b5fbb18a11cab3aff

Rollup merge of #69175 - estebank:shall-not-ice, r=petrochenkov Do not ICE when encountering `yield` inside `async` block Fix #67158.

view details

Yuki Okushi

commit sha 8b34f72b4f1a13947c1f066ccd63479da53d3e3d

Rollup merge of #69223 - spunit262:empty-string-gdb-version, r=Dylan-DPC Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Yuki Okushi

commit sha 6528b9f88799d0a4a2a09c32494b7d207880ddb8

Rollup merge of #69244 - cuviper:llvm-flags, r=Mark-Simulacrum configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Yuki Okushi

commit sha 20c483506a8e1c904f57d8775252f0f74d6de1f2

Rollup merge of #69249 - LeSeulArtichaut:stabilize-logs-consts, r=sfackler Stabilize {f32, f64}::{LOG2_10, LOG10_2} Following the decision to stabilize `LOG2_10` and `LOG10_2` in https://github.com/rust-lang/rust/issues/50540#issuecomment-536627588. Closes #50540. r? @sfackler

view details

Yuki Okushi

commit sha c1a05fbf00f4cf23e43036b2764a835ed4c3c96f

Rollup merge of #69252 - Mark-Simulacrum:disk-try, r=pietroalbini Clean out unused directories for extra disk space This cleans out some of the unused (but large) directories on our linux builders to hopefully allow them to complete without running out of disk space.

view details

bors

commit sha 6317721cd951030f1f28801c34931c3c2322bc06

Auto merge of #69258 - JohnTitor:rollup-n2hljai, r=JohnTitor Rollup of 8 pull requests Successful merges: - #67272 (recursion_limit parsing handles overflows) - #68597 (Simplify `Skip::nth` and `Skip::last` implementations) - #68767 (macOS: avoid calling pthread_self() twice) - #69175 (Do not ICE when encountering `yield` inside `async` block) - #69223 (Ignore GDB versions with broken str printing.) - #69244 (configure: set LLVM flags with a value) - #69249 (Stabilize {f32, f64}::{LOG2_10, LOG10_2}) - #69252 (Clean out unused directories for extra disk space) Failed merges: r? @ghost

view details

push time in 33 minutes

issue closedrust-lang/rust

Tracking issue for extra floating-point logarithm constants

Specifically, LOG10_2 and LOG2_10. PR: #50539

closed time in 33 minutes

clarfon

issue closedrust-lang/rust

ICE on beta and nightly as result of use of `yield` in combination with macro call in `async` block

This code

fn main() {
    async { yield print!(":C") };
}

(Playground)

produces ICE on current beta and nightly

thread 'rustc' panicked at 'src/librustc/hir/map/hir_id_validator.rs:26: 
ItemLocalIds not assigned densely in ::main[0]. Max ItemLocalId = 14, missing IDs = ["[local_id: 1, node:unknown node (hir_id=HirId { owner: DefIndex(12), local_id: 1 })]"]; seens IDs = ["(HirId { owner: DefIndex(12), local_id: 0 } fn main (hir_id=HirId { owner: DefIndex(12), local_id: 0 }))", "(HirId { owner: DefIndex(12), local_id: 13 } block { ::std::future::from_generator(|| { (/*ERROR*/) }); } (hir_id=HirId { owner: DefIndex(12), local_id: 13 }))", "(HirId { owner: DefIndex(12), local_id: 10 } expr ::std::future::from_generator (hir_id=HirId { owner: DefIndex(12), local_id: 10 }))", "(HirId { owner: DefIndex(12), local_id: 7 } path segment std (hir_id=HirId { owner: DefIndex(12), local_id: 7 }))", "(HirId { owner: DefIndex(12), local_id: 4 } expr { (/*ERROR*/) } (hir_id=HirId { owner: DefIndex(12), local_id: 4 }))", "(HirId { owner: DefIndex(12), local_id: 14 } expr { ::std::future::from_generator(|| { (/*ERROR*/) }); } (hir_id=HirId { owner: DefIndex(12), local_id: 14 }))", "(HirId { owner: DefIndex(12), local_id: 11 } expr ::std::future::from_generator(|| { (/*ERROR*/) }) (hir_id=HirId { owner: DefIndex(12), local_id: 11 }))", "(HirId { owner: DefIndex(12), local_id: 8 } path segment future (hir_id=HirId { owner: DefIndex(12), local_id: 8 }))", "(HirId { owner: DefIndex(12), local_id: 5 } expr || { (/*ERROR*/) } (hir_id=HirId { owner: DefIndex(12), local_id: 5 }))", "(HirId { owner: DefIndex(12), local_id: 2 } expr (/*ERROR*/) (hir_id=HirId { owner: DefIndex(12), local_id: 2 }))", "(HirId { owner: DefIndex(12), local_id: 12 } stmt ::std::future::from_generator(|| { (/*ERROR*/) }); (hir_id=HirId { owner: DefIndex(12), local_id: 12 }))", "(HirId { owner: DefIndex(12), local_id: 9 } path segment from_generator (hir_id=HirId { owner: DefIndex(12), local_id: 9 }))", "(HirId { owner: DefIndex(12), local_id: 6 } path segment  (hir_id=HirId { owner: DefIndex(12), local_id: 6 }))", "(HirId { owner: DefIndex(12), local_id: 3 } block { (/*ERROR*/) } (hir_id=HirId { owner: DefIndex(12), local_id: 3 }))"]', src/librustc/util/bug.rs:37:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.40.0-beta.2 (2a0ba54fa 2019-11-16) running on x86_64-apple-darwin

note: compiler flags: -C debuginfo=2 -C incremental --crate-type bin

note: some of the compiler flags provided by cargo are hidden

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0658`.
error: could not compile `rust-games`.

closed time in 33 minutes

olegnn

issue closedrust-lang/rust

Recursion limit silently ignored if it overflows a `usize`

The following code fails to compile since it exceeds the default recursion limit. Using 2056 as the recursion limit works as expected.

#![recursion_limit = "99999999999999999999999999999999999999999999999999999"]
//#![recursion_limit = "2056"]

macro_rules! explode {
    (recurse; $head:tt $($tail:tt)*) => { explode!(recurse; $($tail)*); };
    (recurse;) => {};
    
    (0; $($tt:tt)*) => { explode!(1; $($tt)* $($tt)* $($tt)*); };
    (1; $($tt:tt)*) => { explode!(2; $($tt)* $($tt)* $($tt)*); };
    (2; $($tt:tt)*) => { explode!(3; $($tt)* $($tt)* $($tt)*); };
    (3; $($tt:tt)*) => { explode!(recurse; $($tt)* $($tt)* $($tt)*); };
}

explode!(0; a b c);

This is because we don't check for integer overflow errors when parsing limits:

https://github.com/rust-lang/rust/blob/e9469a6aec2f49fa1e2ae670649f293866932253/src/librustc/middle/recursion_limit.rs#L19-L33

There's a few options here. My preference would be to silently default to usize::MAX when overflow occurs.

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START --> This issue has been assigned to @fisherdarling via this comment. <!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"fisherdarling"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->

closed time in 33 minutes

ecstatic-morse

pull request commentrust-lang/rust

Rollup of 8 pull requests

:sunny: Test successful - checks-azure Approved by: JohnTitor Pushing 6317721cd951030f1f28801c34931c3c2322bc06 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"JohnTitor","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21250"},"merge_sha":"6317721cd951030f1f28801c34931c3c2322bc06"} -->

JohnTitor

comment created time in 33 minutes

push eventrust-lang/cargo

Eric Huss

commit sha 0d44a8267bf503645ceb5f5853abdd4cce407dc8

Rework internal errors.

view details

bors

commit sha 74f2b400d2be43da798f99f94957d359bc223988

Auto merge of #7896 - ehuss:internal-errors, r=alexcrichton Rework internal errors. This changes the behavior of "internal" errors, which were previously hidden and only displayed with `--verbose`. The changes here: - `internal` now means "a cargo bug", and is always displayed and requests that the user file a bug report. - Added `VerboseError` to signify an error that should only be displayed with `--verbose`. This is only used in one place, to display the `rustc` compiler command if the compiler exited with a normal error code (i.e. not a crash). - Audited the uses of internal errors, and promoted some to normal errors, as they seemed to contain useful information, but weren't necessarily bugs in cargo. - Added some details to some errors. - Sometimes the "run with --verbose" message wasn't being printed when I think it should. This happened when rustc failed while other rustc processes were running. Another case was with `cargo install` installing multiple packages, and one of them fails.

view details

push time in 38 minutes

pull request commentrust-lang/cargo

Rework internal errors.

:hourglass: Testing commit 0d44a8267bf503645ceb5f5853abdd4cce407dc8 with merge 74f2b400d2be43da798f99f94957d359bc223988... <!-- homu: {"type":"BuildStarted","head_sha":"0d44a8267bf503645ceb5f5853abdd4cce407dc8","merge_sha":"74f2b400d2be43da798f99f94957d359bc223988"} -->

ehuss

comment created time in 38 minutes

pull request commentrust-lang/cargo

Rework internal errors.

:pushpin: Commit 0d44a8267bf503645ceb5f5853abdd4cce407dc8 has been approved by alexcrichton

<!-- @bors r=alexcrichton 0d44a8267bf503645ceb5f5853abdd4cce407dc8 --> <!-- homu: {"type":"Approved","sha":"0d44a8267bf503645ceb5f5853abdd4cce407dc8","approver":"alexcrichton"} -->

ehuss

comment created time in 38 minutes

pull request commentrust-lang/rust

Add shared script for linkchecking books.

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

ehuss

comment created time in an hour

pull request commentrust-lang/rust

Add shared script for linkchecking books.

:pushpin: Commit 4810c4712f9edc4c378142ace1b868fc2fd1eeea has been approved by alexcrichton

<!-- @bors r=alexcrichton 4810c4712f9edc4c378142ace1b868fc2fd1eeea --> <!-- homu: {"type":"Approved","sha":"4810c4712f9edc4c378142ace1b868fc2fd1eeea","approver":"alexcrichton"} -->

ehuss

comment created time in an hour

pull request commentrust-lang/rust

Revert "Remove `checked_add` in `Layout::repeat`"

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

shahn

comment created time in an hour

pull request commentrust-lang/rust

Revert "Remove `checked_add` in `Layout::repeat`"

:pushpin: Commit bdb1192510f4c765c4f89a9dd382319a35472a80 has been approved by Mark-Simulacrum

<!-- @bors r=Mark-Simulacrum bdb1192510f4c765c4f89a9dd382319a35472a80 --> <!-- homu: {"type":"Approved","sha":"bdb1192510f4c765c4f89a9dd382319a35472a80","approver":"Mark-Simulacrum"} -->

shahn

comment created time in an hour

push eventrust-lang/rust

Oliver Middleton

commit sha 84f3356e0dffc36f57d9be7902822db5d362e24f

Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

LeSeulArtichaut

commit sha 2ae493a767536b0a5180c788d9ecf2b7ea8bf749

Stabilize {f32, f64}::{LOG2_10, LOG10_2}

view details

spunit262

commit sha a9b5c692d9319a993ca5dfa6e853a3f5d3f68079

Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Fisher Darling

commit sha c53693d34d83e6221dc8b93a2c4e17e66fa6f0e2

Handle recursion_limit parsing errors

view details

Esteban Küber

commit sha e5b2c66dea8e2d721612089ebfa00e0799cd5e50

Do not ICE when encountering `yield` inside `async` block

view details

Josh Stone

commit sha 3a55e8875e1c5f4b12954fc939efa76bc9da0a8c

configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Yuki Okushi

commit sha 6c4f8598b916087e2758d8c14c249ee5fa4fa0d5

Rollup merge of #67272 - fisherdarling:master, r=varkor,hellow554 recursion_limit parsing handles overflows This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`. closes #67265

view details

Yuki Okushi

commit sha ae81241eae061ee9fb2af798b109508c27f208f1

Rollup merge of #68597 - ollie27:skip_nth_last, r=Amanieu Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Yuki Okushi

commit sha 284acafe61fa76eb56ca2dddd479a2b5f9a262cd

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

Yuki Okushi

commit sha 35e7c783a26a33375b765c7b5fbb18a11cab3aff

Rollup merge of #69175 - estebank:shall-not-ice, r=petrochenkov Do not ICE when encountering `yield` inside `async` block Fix #67158.

view details

Yuki Okushi

commit sha 8b34f72b4f1a13947c1f066ccd63479da53d3e3d

Rollup merge of #69223 - spunit262:empty-string-gdb-version, r=Dylan-DPC Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Yuki Okushi

commit sha 6528b9f88799d0a4a2a09c32494b7d207880ddb8

Rollup merge of #69244 - cuviper:llvm-flags, r=Mark-Simulacrum configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Yuki Okushi

commit sha 20c483506a8e1c904f57d8775252f0f74d6de1f2

Rollup merge of #69249 - LeSeulArtichaut:stabilize-logs-consts, r=sfackler Stabilize {f32, f64}::{LOG2_10, LOG10_2} Following the decision to stabilize `LOG2_10` and `LOG10_2` in https://github.com/rust-lang/rust/issues/50540#issuecomment-536627588. Closes #50540. r? @sfackler

view details

Yuki Okushi

commit sha c1a05fbf00f4cf23e43036b2764a835ed4c3c96f

Rollup merge of #69252 - Mark-Simulacrum:disk-try, r=pietroalbini Clean out unused directories for extra disk space This cleans out some of the unused (but large) directories on our linux builders to hopefully allow them to complete without running out of disk space.

view details

bors

commit sha 6317721cd951030f1f28801c34931c3c2322bc06

Auto merge of #69258 - JohnTitor:rollup-n2hljai, r=JohnTitor Rollup of 8 pull requests Successful merges: - #67272 (recursion_limit parsing handles overflows) - #68597 (Simplify `Skip::nth` and `Skip::last` implementations) - #68767 (macOS: avoid calling pthread_self() twice) - #69175 (Do not ICE when encountering `yield` inside `async` block) - #69223 (Ignore GDB versions with broken str printing.) - #69244 (configure: set LLVM flags with a value) - #69249 (Stabilize {f32, f64}::{LOG2_10, LOG10_2}) - #69252 (Clean out unused directories for extra disk space) Failed merges: r? @ghost

view details

push time in 4 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:hourglass: Testing commit c1a05fbf00f4cf23e43036b2764a835ed4c3c96f with merge 6317721cd951030f1f28801c34931c3c2322bc06... <!-- homu: {"type":"BuildStarted","head_sha":"c1a05fbf00f4cf23e43036b2764a835ed4c3c96f","merge_sha":"6317721cd951030f1f28801c34931c3c2322bc06"} -->

JohnTitor

comment created time in 4 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

JohnTitor

comment created time in 4 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:pushpin: Commit c1a05fbf00f4cf23e43036b2764a835ed4c3c96f has been approved by JohnTitor

<!-- @bors r=JohnTitor c1a05fbf00f4cf23e43036b2764a835ed4c3c96f --> <!-- homu: {"type":"Approved","sha":"c1a05fbf00f4cf23e43036b2764a835ed4c3c96f","approver":"JohnTitor"} -->

JohnTitor

comment created time in 4 hours

pull request commentrust-lang/rust

Miscellaneous inlining improvements

:broken_heart: Test failed - checks-azure <!-- homu: {"type":"TryBuildFailed","builder_url":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21240","builder_name":"checks-azure"} -->

nnethercote

comment created time in 5 hours

push eventrust-lang/rust

Mark Rousskov

commit sha c992ab23fa14a38c5565889d52ba3a3fb6e1e831

Clean out some default-installed directories This helps us have enough disk space for our builders to be able to complete successfully. For now, the choices are ad-hoc and 'definitely not needed'. This should never fail the build, as everything our build needs should be inside Docker.

view details

bors

commit sha 2d1a6b42b8261195b845bc597fdf5f815ad76ca3

Auto merge of #69252 - Mark-Simulacrum:disk-try, r=pietroalbini Clean out unused directories for extra disk space This cleans out some of the unused (but large) directories on our linux builders to hopefully allow them to complete without running out of disk space.

view details

push time in 5 hours

pull request commentrust-lang/rust

Clean out unused directories for extra disk space

:hourglass: Testing commit c992ab23fa14a38c5565889d52ba3a3fb6e1e831 with merge 2d1a6b42b8261195b845bc597fdf5f815ad76ca3... <!-- homu: {"type":"BuildStarted","head_sha":"c992ab23fa14a38c5565889d52ba3a3fb6e1e831","merge_sha":"2d1a6b42b8261195b845bc597fdf5f815ad76ca3"} -->

Mark-Simulacrum

comment created time in 5 hours

pull request commentrust-lang/rust

Clean out unused directories for extra disk space

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

Mark-Simulacrum

comment created time in 5 hours

pull request commentrust-lang/rust

Clean out unused directories for extra disk space

:pushpin: Commit c992ab23fa14a38c5565889d52ba3a3fb6e1e831 has been approved by pietroalbini

<!-- @bors r=pietroalbini c992ab23fa14a38c5565889d52ba3a3fb6e1e831 --> <!-- homu: {"type":"Approved","sha":"c992ab23fa14a38c5565889d52ba3a3fb6e1e831","approver":"pietroalbini"} -->

Mark-Simulacrum

comment created time in 5 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:boom: Test timed out <!-- homu: {"type":"TimedOut"} -->

JohnTitor

comment created time in 5 hours

push eventrust-lang/rust

Nicholas Nethercote

commit sha ab906179ccd6254f51f0d254479c9b211b0276b1

Always inline `run_utf8_validation`. It only has two call sites, and the one within `from_utf8` is hot within rustc itself.

view details

Nicholas Nethercote

commit sha c02d689a626d44e82f3769d8be1a842f2d211005

Inline `Symbol::decode` and `Interner::intern`.

view details

Nicholas Nethercote

commit sha e761f3af904b3c275bdebc73bb29ffc45384945d

Inline various simple `emit_*` and `read_*` methods in `Decoder`. Mostly, these are the ones whose body just contains `f(self)`.

view details

bors

commit sha 2a7a3a119ba5e0baaeb3ad15b4ed499b1055d9fe

Auto merge of #69256 - nnethercote:misc-inlining, r=<try> Miscellaneous inlining improvements These commits inline some hot functions that aren't currently inlined, for some speed wins. r? @Centril

view details

push time in 8 hours

pull request commentrust-lang/rust

Miscellaneous inlining improvements

:hourglass: Trying commit e761f3af904b3c275bdebc73bb29ffc45384945d with merge 2a7a3a119ba5e0baaeb3ad15b4ed499b1055d9fe... <!-- homu: {"type":"TryBuildStarted","head_sha":"e761f3af904b3c275bdebc73bb29ffc45384945d","merge_sha":"2a7a3a119ba5e0baaeb3ad15b4ed499b1055d9fe"} -->

nnethercote

comment created time in 8 hours

push eventrust-lang/rust

bors

commit sha cb01d05fa8a87a1e2ee7bc2b3e6d0934d3b7c38a

Auto merge of #69253 - JohnTitor:rollup-4asn252, r=JohnTitor Rollup of 8 pull requests Successful merges: - #67272 (recursion_limit parsing handles overflows) - #68597 (Simplify `Skip::nth` and `Skip::last` implementations) - #68767 (macOS: avoid calling pthread_self() twice) - #69175 (Do not ICE when encountering `yield` inside `async` block) - #69223 (Ignore GDB versions with broken str printing.) - #69244 (configure: set LLVM flags with a value) - #69249 (Stabilize {f32, f64}::{LOG2_10, LOG10_2}) - #69252 (Clean out unused directories for extra disk space) Failed merges: r? @ghost

view details

push time in 10 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:hourglass: Testing commit 125b328b87575e346c15b1aeb325545a1a6e34c3 with merge cb01d05fa8a87a1e2ee7bc2b3e6d0934d3b7c38a... <!-- homu: {"type":"BuildStarted","head_sha":"125b328b87575e346c15b1aeb325545a1a6e34c3","merge_sha":"cb01d05fa8a87a1e2ee7bc2b3e6d0934d3b7c38a"} -->

JohnTitor

comment created time in 10 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:boom: Test timed out <!-- homu: {"type":"TimedOut"} -->

JohnTitor

comment created time in 10 hours

pull request commentrust-lang/rust

Combine `HaveBeenBorrowedLocals` and `IndirectlyMutableLocals` into one dataflow analysis

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

ecstatic-morse

comment created time in 12 hours

pull request commentrust-lang/rust

Combine `HaveBeenBorrowedLocals` and `IndirectlyMutableLocals` into one dataflow analysis

:pushpin: Commit 077a93c6a9b1c8ee0e541ea484f7e13c207d50d0 has been approved by wesleywiser

<!-- @bors r=wesleywiser 077a93c6a9b1c8ee0e541ea484f7e13c207d50d0 --> <!-- homu: {"type":"Approved","sha":"077a93c6a9b1c8ee0e541ea484f7e13c207d50d0","approver":"wesleywiser"} -->

ecstatic-morse

comment created time in 12 hours

pull request commentrust-lang/rust

Always const qualify literals by type

:broken_heart: Test failed - checks-azure <!-- homu: {"type":"BuildFailed","builder_url":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21222","builder_name":"checks-azure"} -->

matthewjasper

comment created time in 14 hours

push eventrust-lang/rust

Oliver Middleton

commit sha 84f3356e0dffc36f57d9be7902822db5d362e24f

Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

LeSeulArtichaut

commit sha 2ae493a767536b0a5180c788d9ecf2b7ea8bf749

Stabilize {f32, f64}::{LOG2_10, LOG10_2}

view details

spunit262

commit sha a9b5c692d9319a993ca5dfa6e853a3f5d3f68079

Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Fisher Darling

commit sha c53693d34d83e6221dc8b93a2c4e17e66fa6f0e2

Handle recursion_limit parsing errors

view details

Esteban Küber

commit sha e5b2c66dea8e2d721612089ebfa00e0799cd5e50

Do not ICE when encountering `yield` inside `async` block

view details

Josh Stone

commit sha 3a55e8875e1c5f4b12954fc939efa76bc9da0a8c

configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Mark Rousskov

commit sha 304d1a9202e23846ff443add6b45c01a6e916c01

Clean out some default-installed directories This helps us have enough disk space for our builders to be able to complete successfully. For now, the choices are ad-hoc and 'definitely not needed'. This should never fail the build, as everything our build needs should be inside Docker.

view details

Yuki Okushi

commit sha 53502282adb8ab33b7ae91f81818d285df77dd6d

Rollup merge of #67272 - fisherdarling:master, r=varkor,hellow554 recursion_limit parsing handles overflows This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`. closes #67265

view details

Yuki Okushi

commit sha 98c4ab046b573d3b7183aca99e657dd049317d56

Rollup merge of #68597 - ollie27:skip_nth_last, r=Amanieu Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Yuki Okushi

commit sha 414355de21af7ce630569f75e6c0bf3446ae6602

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

Yuki Okushi

commit sha cdaeb237b2a012a54ccbc6ff3f4e1723602cf325

Rollup merge of #69175 - estebank:shall-not-ice, r=petrochenkov Do not ICE when encountering `yield` inside `async` block Fix #67158.

view details

Yuki Okushi

commit sha 582db6a2f3e913ca356b3dd48263869a56a79a24

Rollup merge of #69223 - spunit262:empty-string-gdb-version, r=Dylan-DPC Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Yuki Okushi

commit sha 82d711f8c14dfbc6d43be742373655f2c80335f6

Rollup merge of #69244 - cuviper:llvm-flags, r=Mark-Simulacrum configure: set LLVM flags with a value Rather than a boolean `--enable-cflags` etc., these options should reflect that they are for LLVM, and that they need a value. You would now use `./configure --llvm-cflags="..."`.

view details

Yuki Okushi

commit sha 6d2b367e6ed1df9cd82730df8221a718ffb5a20f

Rollup merge of #69249 - LeSeulArtichaut:stabilize-logs-consts, r=sfackler Stabilize {f32, f64}::{LOG2_10, LOG10_2} Following the decision to stabilize `LOG2_10` and `LOG10_2` in https://github.com/rust-lang/rust/issues/50540#issuecomment-536627588. Closes #50540. r? @sfackler

view details

Yuki Okushi

commit sha 125b328b87575e346c15b1aeb325545a1a6e34c3

Rollup merge of #69252 - Mark-Simulacrum:disk-try, r=JohnTitor Clean out unused directories for extra disk space This cleans out some of the unused (but large) directories on our linux builders to hopefully allow them to complete without running out of disk space.

view details

bors

commit sha ef1765eb74ef4abd72f199592310e79778892761

Auto merge of #69253 - JohnTitor:rollup-4asn252, r=JohnTitor Rollup of 8 pull requests Successful merges: - #67272 (recursion_limit parsing handles overflows) - #68597 (Simplify `Skip::nth` and `Skip::last` implementations) - #68767 (macOS: avoid calling pthread_self() twice) - #69175 (Do not ICE when encountering `yield` inside `async` block) - #69223 (Ignore GDB versions with broken str printing.) - #69244 (configure: set LLVM flags with a value) - #69249 (Stabilize {f32, f64}::{LOG2_10, LOG10_2}) - #69252 (Clean out unused directories for extra disk space) Failed merges: r? @ghost

view details

push time in 14 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:hourglass: Testing commit 125b328b87575e346c15b1aeb325545a1a6e34c3 with merge ef1765eb74ef4abd72f199592310e79778892761... <!-- homu: {"type":"BuildStarted","head_sha":"125b328b87575e346c15b1aeb325545a1a6e34c3","merge_sha":"ef1765eb74ef4abd72f199592310e79778892761"} -->

JohnTitor

comment created time in 14 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

JohnTitor

comment created time in 14 hours

pull request commentrust-lang/rust

Rollup of 8 pull requests

:pushpin: Commit 125b328b87575e346c15b1aeb325545a1a6e34c3 has been approved by JohnTitor

<!-- @bors r=JohnTitor 125b328b87575e346c15b1aeb325545a1a6e34c3 --> <!-- homu: {"type":"Approved","sha":"125b328b87575e346c15b1aeb325545a1a6e34c3","approver":"JohnTitor"} -->

JohnTitor

comment created time in 14 hours

pull request commentrust-lang/rust

Clean out unused directories for extra disk space

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

Mark-Simulacrum

comment created time in 14 hours

pull request commentrust-lang/rust

Clean out unused directories for extra disk space

:pushpin: Commit 304d1a9202e23846ff443add6b45c01a6e916c01 has been approved by JohnTitor

<!-- @bors r=JohnTitor 304d1a9202e23846ff443add6b45c01a6e916c01 --> <!-- homu: {"type":"Approved","sha":"304d1a9202e23846ff443add6b45c01a6e916c01","approver":"JohnTitor"} -->

Mark-Simulacrum

comment created time in 14 hours

pull request commentrust-lang/rust

Add an early-exit to `overlapping_impls`

:evergreen_tree: The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

jonas-schievink

comment created time in 14 hours

pull request commentrust-lang/rust

Add an early-exit to `overlapping_impls`

:pushpin: Commit d0bbdc3c3253e30f531bf75102a1f64a38a59e49 has been approved by estebank

<!-- @bors r=estebank d0bbdc3c3253e30f531bf75102a1f64a38a59e49 --> <!-- homu: {"type":"Approved","sha":"d0bbdc3c3253e30f531bf75102a1f64a38a59e49","approver":"estebank"} -->

jonas-schievink

comment created time in 14 hours

push eventrust-lang/rust

Mark Rousskov

commit sha dd6e41c24a3f3723bcefbc33e702a21f231c111b

Dump largest files on disk, not just in cwd.

view details

bors

commit sha 9e7396e9a26d87240c549f104f32466822ef8329

Auto merge of #69252 - Mark-Simulacrum:disk-try, r=<try> Dump largest files on disk, not just in cwd. This will try to debug the disk space issues we're seeing (and potentially become the "fix" PR). r? @ghost

view details

push time in 15 hours

pull request commentrust-lang/rust

Dump largest files on disk, not just in cwd.

:hourglass: Trying commit dd6e41c24a3f3723bcefbc33e702a21f231c111b with merge 9e7396e9a26d87240c549f104f32466822ef8329... <!-- homu: {"type":"TryBuildStarted","head_sha":"dd6e41c24a3f3723bcefbc33e702a21f231c111b","merge_sha":"9e7396e9a26d87240c549f104f32466822ef8329"} -->

Mark-Simulacrum

comment created time in 15 hours

push eventrust-lang/rust

Matthew Jasper

commit sha 0663f253757ab0d360f540e9d7bc7882db1dc8bd

Always qualify literals by type

view details

Matthew Jasper

commit sha f2980e71d936be7a39b9a472664363d93f2c7fd8

Add fast path for is_freeze

view details

bors

commit sha 3c15ab90396ca113f17259b41b7583a72e82a3a2

Auto merge of #69146 - matthewjasper:literal-qualif, r=eddyb Always const qualify literals by type r? @eddyb

view details

push time in 15 hours

pull request commentrust-lang/rust

Always const qualify literals by type

:hourglass: Testing commit f2980e71d936be7a39b9a472664363d93f2c7fd8 with merge 3c15ab90396ca113f17259b41b7583a72e82a3a2... <!-- homu: {"type":"BuildStarted","head_sha":"f2980e71d936be7a39b9a472664363d93f2c7fd8","merge_sha":"3c15ab90396ca113f17259b41b7583a72e82a3a2"} -->

matthewjasper

comment created time in 15 hours

pull request commentrust-lang/rust

Rollup of 5 pull requests

:broken_heart: Test failed - checks-azure <!-- homu: {"type":"BuildFailed","builder_url":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21214","builder_name":"checks-azure"} -->

Dylan-DPC

comment created time in 15 hours

pull request commentrust-lang/rust

Stabilize {f32, f64}::{LOG2_10, LOG10_2}

:pushpin: Commit 2ae493a767536b0a5180c788d9ecf2b7ea8bf749 has been approved by sfackler

<!-- @bors r=sfackler 2ae493a767536b0a5180c788d9ecf2b7ea8bf749 --> <!-- homu: {"type":"Approved","sha":"2ae493a767536b0a5180c788d9ecf2b7ea8bf749","approver":"sfackler"} -->

LeSeulArtichaut

comment created time in 16 hours

pull request commentrust-lang/rust

Querify object_safety_violations.

:broken_heart: Test failed - checks-azure <!-- homu: {"type":"TryBuildFailed","builder_url":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21203","builder_name":"checks-azure"} -->

cjgillot

comment created time in 17 hours

pull request commentrust-lang/rust

[WIP] Add an abstraction for custom query caches

:broken_heart: Test failed - checks-azure <!-- homu: {"type":"TryBuildFailed","builder_url":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21196","builder_name":"checks-azure"} -->

Zoxc

comment created time in 18 hours

push eventrust-lang/rust

Oliver Middleton

commit sha 84f3356e0dffc36f57d9be7902822db5d362e24f

Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

spunit262

commit sha a9b5c692d9319a993ca5dfa6e853a3f5d3f68079

Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Fisher Darling

commit sha c53693d34d83e6221dc8b93a2c4e17e66fa6f0e2

Handle recursion_limit parsing errors

view details

Esteban Küber

commit sha e5b2c66dea8e2d721612089ebfa00e0799cd5e50

Do not ICE when encountering `yield` inside `async` block

view details

Dylan DPC

commit sha 3747a48a2e60a28424791289c02da664fb9144b8

Rollup merge of #67272 - fisherdarling:master, r=varkor,hellow554 recursion_limit parsing handles overflows This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`. closes #67265

view details

Dylan DPC

commit sha 034b3340db711c5f2182552dd96c8983ec02410e

Rollup merge of #68597 - ollie27:skip_nth_last, r=Amanieu Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Dylan DPC

commit sha a70b757edfd335b7c02f8c53dc20d47dcd4a824a

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

Dylan DPC

commit sha 5ba1dd7cf76c98f5388de4daa0ea6a9959c6b6b9

Rollup merge of #69175 - estebank:shall-not-ice, r=petrochenkov Do not ICE when encountering `yield` inside `async` block Fix #67158.

view details

Dylan DPC

commit sha 386b49447e579bc95800e6ba9acb2ac41607ea1c

Rollup merge of #69223 - spunit262:empty-string-gdb-version, r=Dylan-DPC Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

bors

commit sha be0c6e6d79e248ea43c16266e5b5fe78042b72d0

Auto merge of #69235 - Dylan-DPC:rollup-1arlnmr, r=Dylan-DPC Rollup of 5 pull requests Successful merges: - #67272 (recursion_limit parsing handles overflows) - #68597 (Simplify `Skip::nth` and `Skip::last` implementations) - #68767 (macOS: avoid calling pthread_self() twice) - #69175 (Do not ICE when encountering `yield` inside `async` block) - #69223 (Ignore GDB versions with broken str printing.) Failed merges: r? @ghost

view details

push time in 18 hours

pull request commentrust-lang/rust

Rollup of 5 pull requests

:hourglass: Testing commit 386b49447e579bc95800e6ba9acb2ac41607ea1c with merge be0c6e6d79e248ea43c16266e5b5fe78042b72d0... <!-- homu: {"type":"BuildStarted","head_sha":"386b49447e579bc95800e6ba9acb2ac41607ea1c","merge_sha":"be0c6e6d79e248ea43c16266e5b5fe78042b72d0"} -->

Dylan-DPC

comment created time in 18 hours

pull request commentrust-lang/rust

Update Clippy

:broken_heart: Test failed - checks-azure <!-- homu: {"type":"BuildFailed","builder_url":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21197","builder_name":"checks-azure"} -->

JohnTitor

comment created time in 18 hours

PR merged rust-lang/rust-clippy

needless_doctest_main: False positive for async fn

Fixes #5188.


changelog: none

+1 -1

4 comments

1 changed file

jonhoo

pr closed time in 18 hours

push eventrust-lang/rust-clippy

Jon Gjengset

commit sha e2fc801ad5a858109e1f4586692f9496881b7842

needless_doctest_main: False positive for async fn Fixes #5188.

view details

bors

commit sha 0da4dd009ec28fb0e48bd10613dfb0ed5912d488

Auto merge of #5189 - jonhoo:async-fn-main-not-needless, r=llogiq needless_doctest_main: False positive for async fn Fixes #5188. --- changelog: none

view details

push time in 18 hours

issue closedrust-lang/rust-clippy

needless_doctest_main: false positive with proc-macro attribute

$ cargo clippy -V
clippy 0.0.212 (ea85b4c 2020-02-01)

The needless_doctest_main lint triggers on this code:

/// ```
/// #[tokio::main]
/// async fn main() {
///     // ...
/// }
/// ```

Where the fn main is very much not needless :)

closed time in 18 hours

jonhoo

pull request commentrust-lang/rust-clippy

needless_doctest_main: False positive for async fn

:sunny: Test successful - checks-travis, status-appveyor Approved by: llogiq Pushing 0da4dd009ec28fb0e48bd10613dfb0ed5912d488 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"llogiq","base_ref":"master","builders":{"status-appveyor":"https://ci.appveyor.com/project/rust-lang-libs/rust-clippy/builds/30864300","checks-travis":"https://travis-ci.com/rust-lang/rust-clippy/builds/149342089"},"merge_sha":"0da4dd009ec28fb0e48bd10613dfb0ed5912d488"} -->

jonhoo

comment created time in 18 hours

push eventrust-lang/rust-clippy

Jon Gjengset

commit sha e2fc801ad5a858109e1f4586692f9496881b7842

needless_doctest_main: False positive for async fn Fixes #5188.

view details

bors

commit sha 0da4dd009ec28fb0e48bd10613dfb0ed5912d488

Auto merge of #5189 - jonhoo:async-fn-main-not-needless, r=llogiq needless_doctest_main: False positive for async fn Fixes #5188. --- changelog: none

view details

push time in 19 hours

pull request commentrust-lang/rust-clippy

needless_doctest_main: False positive for async fn

:hourglass: Testing commit e2fc801ad5a858109e1f4586692f9496881b7842 with merge 0da4dd009ec28fb0e48bd10613dfb0ed5912d488... <!-- homu: {"type":"BuildStarted","head_sha":"e2fc801ad5a858109e1f4586692f9496881b7842","merge_sha":"0da4dd009ec28fb0e48bd10613dfb0ed5912d488"} -->

jonhoo

comment created time in 19 hours

pull request commentrust-lang/rust-clippy

needless_doctest_main: False positive for async fn

:pushpin: Commit e2fc801ad5a858109e1f4586692f9496881b7842 has been approved by llogiq

<!-- @bors r=llogiq e2fc801ad5a858109e1f4586692f9496881b7842 --> <!-- homu: {"type":"Approved","sha":"e2fc801ad5a858109e1f4586692f9496881b7842","approver":"llogiq"} -->

jonhoo

comment created time in 19 hours

pull request commentrust-lang/rust

parser: Simplify treatment of macro variables in `Parser::bump`

:pushpin: Commit 950845c5b1079c83e56db0ca2b4bb8fe050ee2f5 has been approved by Centril

<!-- @bors r=Centril 950845c5b1079c83e56db0ca2b4bb8fe050ee2f5 --> <!-- homu: {"type":"Approved","sha":"950845c5b1079c83e56db0ca2b4bb8fe050ee2f5","approver":"Centril"} -->

petrochenkov

comment created time in 19 hours

push eventrust-lang/rust

Camille GILLOT

commit sha 6e15faf68a2b1af57d6c94392329d148882d1650

Querify object_safety_violations.

view details

bors

commit sha 5ed36c19ab9a38b71b3346273fcacb2737750539

Auto merge of #69242 - cjgillot:object_violations, r=<try> Querify object_safety_violations. Split from #69076 r? @Zoxc

view details

push time in 20 hours

pull request commentrust-lang/rust

Querify object_safety_violations.

:hourglass: Trying commit 6e15faf68a2b1af57d6c94392329d148882d1650 with merge 5ed36c19ab9a38b71b3346273fcacb2737750539... <!-- homu: {"type":"TryBuildStarted","head_sha":"6e15faf68a2b1af57d6c94392329d148882d1650","merge_sha":"5ed36c19ab9a38b71b3346273fcacb2737750539"} -->

cjgillot

comment created time in 20 hours

pull request commentrust-lang/rust

configure: set LLVM flags with a value

:pushpin: Commit 3a55e8875e1c5f4b12954fc939efa76bc9da0a8c has been approved by Mark-Simulacrum

<!-- @bors r=Mark-Simulacrum 3a55e8875e1c5f4b12954fc939efa76bc9da0a8c --> <!-- homu: {"type":"Approved","sha":"3a55e8875e1c5f4b12954fc939efa76bc9da0a8c","approver":"Mark-Simulacrum"} -->

cuviper

comment created time in 20 hours

push eventrust-lang/rust

Yuki Okushi

commit sha 3b431234e06962983df6e0ce17cd074c2ab380bd

Update Clippy

view details

bors

commit sha bc0403758e7e6e8ff76c1a15ee202b5e3bf84fe8

Auto merge of #69234 - JohnTitor:clippy-up, r=JohnTitor Update Clippy Fixes #69221 r? @ghost

view details

push time in 21 hours

pull request commentrust-lang/rust

Update Clippy

:hourglass: Testing commit 3b431234e06962983df6e0ce17cd074c2ab380bd with merge bc0403758e7e6e8ff76c1a15ee202b5e3bf84fe8... <!-- homu: {"type":"BuildStarted","head_sha":"3b431234e06962983df6e0ce17cd074c2ab380bd","merge_sha":"bc0403758e7e6e8ff76c1a15ee202b5e3bf84fe8"} -->

JohnTitor

comment created time in 21 hours

pull request commentrust-lang/rust

Rollup of 5 pull requests

:broken_heart: Test failed - checks-azure <!-- homu: {"type":"BuildFailed","builder_url":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=21186","builder_name":"checks-azure"} -->

Dylan-DPC

comment created time in 21 hours

push eventrust-lang/rust

Mazdak Farrokhzad

commit sha cec2a9fad057f71fc640392ba3fa47602aea12f6

macro_legacy_warnings -> error

view details

bors

commit sha 0176a9eef845e7421b7e2f7ef015333a41a7c027

Auto merge of #69129 - Centril:macro-legacy-errors, r=petrochenkov Transition macro_legacy_warnings into a hard error Fixes https://github.com/rust-lang/rust/issues/67098. r? @petrochenkov

view details

John Kåre Alsaker

commit sha 9ec3df55bb1acd35cab8b85115a60e24152a7215

Split query execution into hot and cold paths

view details

John Kåre Alsaker

commit sha 34f6d37b9aa463fa994fa707ecd5b2f27b8b9fe2

Make `try_get_cached` take closures

view details

John Kåre Alsaker

commit sha 9c25987ed8a73bca814ee03a5b41093a44ce8dc3

Add an abstraction for custom query caches

view details

John Kåre Alsaker

commit sha 325c82bb0c264bd27a70202b855095aa9a7f0493

Add a `storage` query modifier to override the query cache

view details

John Kåre Alsaker

commit sha da056f53fabff643748aabaae12672c071887596

Fix the parallel compiler

view details

John Kåre Alsaker

commit sha 024aa219e4483977f1a96aaebb9c7b7ab62a7c76

Split query stats into its own file

view details

John Kåre Alsaker

commit sha 7e7eedea59392be2fae17b60a0f71798cca2ba0b

Add a stat for local DefId density

view details

John Kåre Alsaker

commit sha c4b5a1825f800879538896080b5222ef973fac9e

Fix cache hit stats

view details

John Kåre Alsaker

commit sha b42799dbd94866649031a2e8333bca2cfcc6af98

Use `LocalDenseDefIdCache` on more queries

view details

John Kåre Alsaker

commit sha f8a7bbc31fd8ead934170dde482f7619b9dcf59e

Remove `storage` attribute from queries

view details

John Kåre Alsaker

commit sha f909a9c80c9a21227c9dd45bf57f356940d30fb9

Uncomment code

view details

John Kåre Alsaker

commit sha fa03f3b25b84e71e17aa0ea2b74f9a07d9d5859f

Tune query performance

view details

John Kåre Alsaker

commit sha 4aa389382aee68afadcbf87de33ec40e909f2e64

Remove support for dep node structs

view details

John Kåre Alsaker

commit sha c1353a78aaa2d018ad6f0db5fba48b23fe84c344

Use a constructor function per dep node instead of an enum and a single function

view details

bors

commit sha 4a69da8307e5ae3d08a1152ba71ec01758860836

Auto merge of #68988 - Zoxc:query-caches, r=<try> [WIP] Add an abstraction for custom query caches r? @eddyb

view details

push time in 21 hours

pull request commentrust-lang/rust

[WIP] Add an abstraction for custom query caches

:hourglass: Trying commit c1353a78aaa2d018ad6f0db5fba48b23fe84c344 with merge 4a69da8307e5ae3d08a1152ba71ec01758860836... <!-- homu: {"type":"TryBuildStarted","head_sha":"c1353a78aaa2d018ad6f0db5fba48b23fe84c344","merge_sha":"4a69da8307e5ae3d08a1152ba71ec01758860836"} -->

Zoxc

comment created time in 21 hours

pull request commentrust-lang/rust

Do not emit note suggesting to implement operation trait to foreign type

:pushpin: Commit 2e07892c7dd71f2025b68dcf8c144d53b3560511 has been approved by estebank

<!-- @bors r=estebank 2e07892c7dd71f2025b68dcf8c144d53b3560511 --> <!-- homu: {"type":"Approved","sha":"2e07892c7dd71f2025b68dcf8c144d53b3560511","approver":"estebank"} -->

LeSeulArtichaut

comment created time in a day

pull request commentrust-lang/rust

parse: recover `mut (x @ y)` as `(mut x @ mut y)`.

:pushpin: Commit 0b1e08cb557768f168266c7bbcdcb93fcf372a66 has been approved by estebank

<!-- @bors r=estebank 0b1e08cb557768f168266c7bbcdcb93fcf372a66 --> <!-- homu: {"type":"Approved","sha":"0b1e08cb557768f168266c7bbcdcb93fcf372a66","approver":"estebank"} -->

Centril

comment created time in a day

PR merged rust-lang/crates.io

Make crate stats look more consistent S-waiting-on-review

Screenshot 2020-02-16 at 19 20 05

+7 -4

5 comments

1 changed file

azolotko

pr closed time in a day

push eventrust-lang/crates.io

Alex Zolotko

commit sha 15bbc4058a04dbf1e8989aa9ad5f87fe5565a674

Make crate stats look more consistent

view details

bors

commit sha e4b97d7a67d942019663b8c3008edcc0efa4f6e6

Auto merge of #2193 - azolotko:more-consistent-crate-row-stats, r=locks Make crate stats look more consistent <img width="1026" alt="Screenshot 2020-02-16 at 19 20 05" src="https://user-images.githubusercontent.com/110424/74610296-3d5c7a80-50f2-11ea-93cd-aa96b990f5c9.png">

view details

push time in a day

pull request commentrust-lang/crates.io

Make crate stats look more consistent

:sunny: Test successful - checks-travis Approved by: locks Pushing e4b97d7a67d942019663b8c3008edcc0efa4f6e6 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"locks","base_ref":"master","builders":{"checks-travis":"https://travis-ci.com/rust-lang/crates.io/builds/149303902"},"merge_sha":"e4b97d7a67d942019663b8c3008edcc0efa4f6e6"} -->

azolotko

comment created time in a day

push eventrust-lang/crates.io

Alex Zolotko

commit sha 15bbc4058a04dbf1e8989aa9ad5f87fe5565a674

Make crate stats look more consistent

view details

bors

commit sha e4b97d7a67d942019663b8c3008edcc0efa4f6e6

Auto merge of #2193 - azolotko:more-consistent-crate-row-stats, r=locks Make crate stats look more consistent <img width="1026" alt="Screenshot 2020-02-16 at 19 20 05" src="https://user-images.githubusercontent.com/110424/74610296-3d5c7a80-50f2-11ea-93cd-aa96b990f5c9.png">

view details

push time in a day

pull request commentrust-lang/crates.io

Make crate stats look more consistent

:hourglass: Testing commit 15bbc4058a04dbf1e8989aa9ad5f87fe5565a674 with merge e4b97d7a67d942019663b8c3008edcc0efa4f6e6... <!-- homu: {"type":"BuildStarted","head_sha":"15bbc4058a04dbf1e8989aa9ad5f87fe5565a674","merge_sha":"e4b97d7a67d942019663b8c3008edcc0efa4f6e6"} -->

azolotko

comment created time in a day

pull request commentrust-lang/crates.io

Make crate stats look more consistent

:pushpin: Commit 15bbc4058a04dbf1e8989aa9ad5f87fe5565a674 has been approved by locks

<!-- @bors r=locks 15bbc4058a04dbf1e8989aa9ad5f87fe5565a674 --> <!-- homu: {"type":"Approved","sha":"15bbc4058a04dbf1e8989aa9ad5f87fe5565a674","approver":"locks"} -->

azolotko

comment created time in a day

PR merged rust-lang/rust

Transition macro_legacy_warnings into a hard error S-waiting-on-bors merged-by-bors

Fixes https://github.com/rust-lang/rust/issues/67098.

r? @petrochenkov

+35 -97

14 comments

7 changed files

Centril

pr closed time in a day

push eventrust-lang/rust

Oliver Middleton

commit sha 84f3356e0dffc36f57d9be7902822db5d362e24f

Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

spunit262

commit sha a9b5c692d9319a993ca5dfa6e853a3f5d3f68079

Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Fisher Darling

commit sha c53693d34d83e6221dc8b93a2c4e17e66fa6f0e2

Handle recursion_limit parsing errors

view details

Esteban Küber

commit sha e5b2c66dea8e2d721612089ebfa00e0799cd5e50

Do not ICE when encountering `yield` inside `async` block

view details

Dylan DPC

commit sha 3747a48a2e60a28424791289c02da664fb9144b8

Rollup merge of #67272 - fisherdarling:master, r=varkor,hellow554 recursion_limit parsing handles overflows This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`. closes #67265

view details

Dylan DPC

commit sha 034b3340db711c5f2182552dd96c8983ec02410e

Rollup merge of #68597 - ollie27:skip_nth_last, r=Amanieu Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Dylan DPC

commit sha a70b757edfd335b7c02f8c53dc20d47dcd4a824a

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

Dylan DPC

commit sha 5ba1dd7cf76c98f5388de4daa0ea6a9959c6b6b9

Rollup merge of #69175 - estebank:shall-not-ice, r=petrochenkov Do not ICE when encountering `yield` inside `async` block Fix #67158.

view details

Dylan DPC

commit sha 386b49447e579bc95800e6ba9acb2ac41607ea1c

Rollup merge of #69223 - spunit262:empty-string-gdb-version, r=Dylan-DPC Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

bors

commit sha 096100359173be3c634ad7a01f1b64b448eac8fc

Auto merge of #69235 - Dylan-DPC:rollup-1arlnmr, r=Dylan-DPC Rollup of 5 pull requests Successful merges: - #67272 (recursion_limit parsing handles overflows) - #68597 (Simplify `Skip::nth` and `Skip::last` implementations) - #68767 (macOS: avoid calling pthread_self() twice) - #69175 (Do not ICE when encountering `yield` inside `async` block) - #69223 (Ignore GDB versions with broken str printing.) Failed merges: r? @ghost

view details

push time in a day

pull request commentrust-lang/rust

Rollup of 5 pull requests

:hourglass: Testing commit 386b49447e579bc95800e6ba9acb2ac41607ea1c with merge 096100359173be3c634ad7a01f1b64b448eac8fc... <!-- homu: {"type":"BuildStarted","head_sha":"386b49447e579bc95800e6ba9acb2ac41607ea1c","merge_sha":"096100359173be3c634ad7a01f1b64b448eac8fc"} -->

Dylan-DPC

comment created time in a day

push eventrust-lang/rust

Mazdak Farrokhzad

commit sha cec2a9fad057f71fc640392ba3fa47602aea12f6

macro_legacy_warnings -> error

view details

bors

commit sha 0176a9eef845e7421b7e2f7ef015333a41a7c027

Auto merge of #69129 - Centril:macro-legacy-errors, r=petrochenkov Transition macro_legacy_warnings into a hard error Fixes https://github.com/rust-lang/rust/issues/67098. r? @petrochenkov

view details

push time in a day

more