profile
viewpoint

rust-lang/chalk 934

An implementation and definition of the Rust trait system using a PROLOG-like logic solver

brson/rust 9

pursuing the trifecta

alexcrichton/cargo 1

Cargo Experiments

rust-lang-ci/rust 1

Empowering everyone to build reliable and efficient software.

pull request commentrust-lang/rust

Improve wording for external crate resolution error

@camelid: :key: Insufficient privileges: Not in reviewers

camelid

comment created time in 24 minutes

pull request commentrust-lang/crates.io

Update dependency ember-router-scroll to v3

:umbrella: The latest upstream changes (presumably #2852) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
renovate[bot]

comment created time in 27 minutes

PR merged rust-lang/crates.io

Update dependency ember-source to v3.21.3 S-waiting-on-review

This PR contains the following updates:

Package Type Update Change
ember-source (source) devDependencies patch 3.21.2 -> 3.21.3

Release Notes

<details> <summary>emberjs/ember.js</summary>

v3.21.3

Compare Source

  • #​19172 [BUGFIX] Ensures that tracked properties initialize property

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

8 comments

2 changed files

renovate[bot]

pr closed time in 29 minutes

push eventrust-lang/crates.io

Renovate Bot

commit sha f82e59faa3f87d46bc86b6caecd4d1f78266e9c9

Update dependency ember-source to v3.21.3

view details

bors

commit sha 7ef297bdaf9af2ac16e134eeb8edeb021dc749fe

Auto merge of #2852 - rust-lang:renovate/ember-source-3.21.x, r=Turbo87 Update dependency ember-source to v3.21.3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ember-source](https://emberjs.com/) ([source](https://togithub.com/emberjs/ember.js)) | devDependencies | patch | [`3.21.2` -> `3.21.3`](https://renovatebot.com/diffs/npm/ember-source/3.21.2/3.21.3) | --- ### Release Notes <details> <summary>emberjs/ember.js</summary> ### [`v3.21.3`](https://togithub.com/emberjs/ember.js/blob/master/CHANGELOG.md#v3213-September-30-2020) [Compare Source](https://togithub.com/emberjs/ember.js/compare/v3.21.2...v3.21.3) - [#&#8203;19172](https://togithub.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

view details

push time in 29 minutes

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.3

:sunny: Test successful - checks-travis Approved by: Turbo87 Pushing 7ef297bdaf9af2ac16e134eeb8edeb021dc749fe to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Turbo87","base_ref":"master","builders":{"checks-travis":"https://travis-ci.com/github/rust-lang/crates.io/builds/187503371"},"merge_sha":"7ef297bdaf9af2ac16e134eeb8edeb021dc749fe"} -->

renovate[bot]

comment created time in 29 minutes

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.3

:hourglass: Testing commit f82e59faa3f87d46bc86b6caecd4d1f78266e9c9 with merge 7ef297bdaf9af2ac16e134eeb8edeb021dc749fe... <!-- homu: {"type":"BuildStarted","head_sha":"f82e59faa3f87d46bc86b6caecd4d1f78266e9c9","merge_sha":"7ef297bdaf9af2ac16e134eeb8edeb021dc749fe"} -->

renovate[bot]

comment created time in an hour

push eventrust-lang/crates.io

bors

commit sha 7ef297bdaf9af2ac16e134eeb8edeb021dc749fe

Auto merge of #2852 - rust-lang:renovate/ember-source-3.21.x, r=Turbo87 Update dependency ember-source to v3.21.3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ember-source](https://emberjs.com/) ([source](https://togithub.com/emberjs/ember.js)) | devDependencies | patch | [`3.21.2` -> `3.21.3`](https://renovatebot.com/diffs/npm/ember-source/3.21.2/3.21.3) | --- ### Release Notes <details> <summary>emberjs/ember.js</summary> ### [`v3.21.3`](https://togithub.com/emberjs/ember.js/blob/master/CHANGELOG.md#v3213-September-30-2020) [Compare Source](https://togithub.com/emberjs/ember.js/compare/v3.21.2...v3.21.3) - [#&#8203;19172](https://togithub.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

view details

push time in an hour

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.3

:boom: Test timed out <!-- homu: {"type":"TimedOut"} -->

renovate[bot]

comment created time in an hour

PR merged rust-lang/rust

more tiny clippy cleanups S-waiting-on-bors

commits stand alone and can be reviewed one by one

+4 -7

8 comments

3 changed files

matthiaskrgr

pr closed time in an hour

PR merged rust-lang/rust

BTreeMap: keep an eye out on the size of the main components S-waiting-on-bors libs-impl

r? @Mark-Simulacrum

+9 -0

2 comments

1 changed file

ssomers

pr closed time in an hour

PR merged rust-lang/rust

Ensure that all LLVM components requested by tests are available on CI A-LLVM A-rustbuild A-testsuite S-waiting-on-bors T-infra

Addresses https://github.com/rust-lang/rust/pull/75064#issuecomment-667722652

I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task. I added a new variable, but any of the already existing ones defined by CI could be used instead. r? @Mark-Simulacrum

+7 -2

5 comments

2 changed files

petrochenkov

pr closed time in an hour

PR merged rust-lang/rust

library: Forward compiler-builtins "mem" feature S-waiting-on-bors

This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53

Now users will be able to do:

cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem

and correctly get the Rust implemenations for memcpy and friends.

Signed-off-by: Joe Richey joerichey@google.com

+2 -0

4 comments

2 changed files

josephlr

pr closed time in an hour

PR merged rust-lang/rust

liveness: Use Option::None to represent absent live nodes S-waiting-on-bors

No functional changes intended.

+36 -40

9 comments

1 changed file

tmiasko

pr closed time in an hour

PR merged rust-lang/rust

Add unstable book docs for `-Zunsound-mir-opts` A-mir-opt B-unstable S-waiting-on-bors T-doc

The -Zunsound-mir-opts flag was added in #76899.

+8 -0

3 comments

1 changed file

wesleywiser

pr closed time in an hour

PR merged rust-lang/rust

Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() S-waiting-on-bors

As discussed in #73894, assert! panics on failure, which is not signal-safe, and rtassert! is a suitable replacement.

Fixes #73894.

r? @Amanieu @cuviper @joshtriplett

+1 -1

3 comments

1 changed file

hyd-dev

pr closed time in an hour

PR merged rust-lang/rust

Add test for async/await combined with const-generics. A-async-await A-const-generics A-testsuite S-waiting-on-bors

Fixes #74906.

+25 -0

4 comments

1 changed file

hameerabbasi

pr closed time in an hour

PR merged rust-lang/rust

Fix typo in alloc vec comment C-cleanup S-waiting-on-bors T-doc T-libs

cc @the8472

+1 -1

3 comments

1 changed file

pickfire

pr closed time in an hour

push eventrust-lang-ci/rust

Lzu Tao

commit sha d31ca4fc8ede3b4a28abea7df57e01591ee8bb7d

Move Utf8Error to new mod

view details

Lzu Tao

commit sha 5b533fccf39501bd5ca8a436da6f2d8b5999664d

Move traits implementation of str to new mod Also move FromStr trait

view details

Lzu Tao

commit sha 5f0d724e298ee4e19bef4e863c176dd87ef6400f

Move str's impl of iterations to new mod

view details

Lzu Tao

commit sha 90c813a0f0b5042a2bbf2d9ebf27f21acdbc9f77

Move utf-8 validating helpers to new mod

view details

Lzu Tao

commit sha 653b5bf18c962a35bb6d90e13e6681446cc49878

Move functions converting bytes to str to new mod

view details

Lzu Tao

commit sha 37cd79cd323a7f1adcad66205c7855fb6c92f062

Gather all ZST structs of str together

view details

Lzu Tao

commit sha dce7248a39e7f8907cb9c5cfe719f6f63da1fa1f

Remove unneeded tidy comment

view details

bors

commit sha 9bb55dc8642d811d66a7599812009cc063577e00

Auto merge of #76325 - lzutao:split-core-str, r=Amanieu Split core/str/mod.rs to smaller files Note for reviewer: * I split to multiple commits for easier reviewing, but I could git squash them all to one if requested. * Recommend pulling this change locally and using advanced git diff viewer or this command: ```bash git show --reverse --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space master.. ``` --- I split `core/str/mod.rs` to these modules: * `converts`: Contains helper functions to convert from bytes to str. * `error`: For error structs like Utf8Error. * `iter`: For iterators of many str methods. * `traits`: For indexing operations and build in traits on str. * `validations`: For functions validating utf8 --- This name is awkward, maybe utf8.rs is better.

view details

push time in an hour

PR merged rust-lang/rust

Alloc vec use imported path S-waiting-on-bors

mem::ManuallyDrop::new -> ManuallyDrop::new

cc @the8472

+1 -1

5 comments

1 changed file

pickfire

pr closed time in an hour

pull request commentrust-lang/rust

Split core/str/mod.rs to smaller files

:hourglass: Testing commit dce7248a39e7f8907cb9c5cfe719f6f63da1fa1f with merge 9bb55dc8642d811d66a7599812009cc063577e00... <!-- homu: {"type":"BuildStarted","head_sha":"dce7248a39e7f8907cb9c5cfe719f6f63da1fa1f","merge_sha":"9bb55dc8642d811d66a7599812009cc063577e00"} -->

lzutao

comment created time in an hour

PR merged rust-lang/rust

Add test for issue #74761 S-waiting-on-bors

Adds test for and closes #74761 which previously crashed compiler.

+31 -0

3 comments

2 changed files

samlich

pr closed time in an hour

PR merged rust-lang/rust

Update books S-waiting-on-bors

rust-by-example

5 commits in 19f0a0372af497b34369cf182d9d16156cab2969..7d3ff1c12db08a847a57a054be4a7951ce532d2d 2020-08-26 09:38:48 -0300 to 2020-09-28 15:54:25 -0300

  • Prevent duplicated error information in "wrapping errors" example (rust-lang/rust-by-example#1375)
  • Avoid lifetime annotation in struct example (rust-lang/rust-by-example#1378)
  • Clone.md comment and variable name change (rust-lang/rust-by-example#1379)
  • Replace panic example with a simpler version (rust-lang/rust-by-example#1380)
  • Prefer const over static (rust-lang/rust-by-example#1381)

embedded-book

1 commits in 0cd2ca116274b915924c3a7e07c1e046b6f19b77..dd310616308e01f6cf227f46347b744aa56b77d9 2020-08-19 10:33:15 +0000 to 2020-09-26 08:54:08 +0000

  • Add instructions for ARM v8 instruction sets (rust-embedded/book#265)
+2 -2

3 comments

2 changed files

ehuss

pr closed time in an hour

push eventrust-lang/rust

Matthias Krüger

commit sha 2ad46acd7fee4e193aff3fd243ca91ca092a42aa

EarlyOtherwiseBranch::run_pass(): don't convert Place to Place (clippy::useless_conversion)

view details

Matthias Krüger

commit sha d7a5c574b1010360fd840f5dfc810f2aa782eac5

use std::mem::take(x) instead of std::mem::replace(x, Default::default()) (clippy::mem_replace_with_default)

view details

Stein Somers

commit sha 3e485d7cf59dafbc37467c3ef1acc51f26b381d9

BTreeMap: keep an eye out on the size of the main components

view details

Joe Richey

commit sha 37f795697c7d0530deb0c5c94a8f99aab587e2e4

libary: Forward compiler-builtins "mem" feature This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>

view details

Wesley Wiser

commit sha 63bb51d3ac3ec015d914e2b0792b4d5aa6e8e4a5

Add unstable book docs for `-Zunsound-mir-opts`

view details

hyd-dev

commit sha a2526b416fb4ca7874fa41a3eb595f456703d486

Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() `assert!` panics on failure, which is not signal-safe.

view details

Vadim Petrochenkov

commit sha 9340ee4380dcc9b81e0afb1ef5518730b064a78a

Ensure that all LLVM components requested by tests are available on CI

view details

Hameer Abbasi

commit sha 2c385040550fb1eb98cf14ace99129f05b1d7b3f

Add test for async/await combined with const-generics.

view details

Ivan Tham

commit sha b141e49d8702fa170953aed388eb1510622db79b

Fix typo in alloc vec comment

view details

Ivan Tham

commit sha f9b625f8e004cebdc79f891dea3fb128ec663151

Alloc vec use imported path mem::ManuallyDrop::new -> ManuallyDrop::new

view details

Eric Huss

commit sha f4d5275cbb87637daba704251c043d2b303e36d6

Update books

view details

Tomasz Miąsko

commit sha 93e3db30e9c3b8fb217743e9d06f37b12dcb8745

liveness: Use Option::None to represent absent live nodes No functional changes intended.

view details

samlich

commit sha 607d30dcfa8c40b91d0073a18c5897eee00a4cda

Add test for issue #74761

view details

Jonas Schievink

commit sha 248d6bf1e2103aaac8642aecdfcffd4259927fea

Rollup merge of #77037 - matthiaskrgr:cl42ppy, r=Dylan-DPC more tiny clippy cleanups commits stand alone and can be reviewed one by one

view details

Jonas Schievink

commit sha 7ad03dd91df96335551384f7ca220b20922e2f15

Rollup merge of #77233 - ssomers:btree_size_matters, r=Mark-Simulacrum BTreeMap: keep an eye out on the size of the main components r? @Mark-Simulacrum

view details

Jonas Schievink

commit sha a4dc8dae02ad78499c0c176227eb39071e1d0dd2

Rollup merge of #77280 - petrochenkov:llvmcomp, r=Mark-Simulacrum Ensure that all LLVM components requested by tests are available on CI Addresses https://github.com/rust-lang/rust/pull/75064#issuecomment-667722652 I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task. I added a new variable, but any of the already existing ones defined by CI could be used instead. r? @Mark-Simulacrum

view details

Jonas Schievink

commit sha 87387fd23ead4ca4d2dcc3ea6e4e6dbc925d6914

Rollup merge of #77284 - josephlr:mem, r=Mark-Simulacrum library: Forward compiler-builtins "mem" feature This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>

view details

Jonas Schievink

commit sha d4add198be2c7cc8285673ca724b330067fa2f57

Rollup merge of #77296 - tmiasko:liveness-option, r=ecstatic-morse liveness: Use Option::None to represent absent live nodes No functional changes intended.

view details

Jonas Schievink

commit sha b85081d46ac2cbfa6862487024fa3323ef95a0e3

Rollup merge of #77322 - rust-lang:wesleywiser-patch-1, r=steveklabnik Add unstable book docs for `-Zunsound-mir-opts` The `-Zunsound-mir-opts` flag was added in #76899.

view details

Jonas Schievink

commit sha c46f5784a68dbddf360b5e0d504ca77b359e1742

Rollup merge of #77328 - hyd-dev:assert-to-rtassert, r=Amanieu Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() As discussed in #73894, `assert!` panics on failure, which is not signal-safe, and `rtassert!` is a suitable replacement. Fixes #73894. r? @Amanieu @cuviper @joshtriplett

view details

push time in an hour

push eventrust-lang-ci/rust

Matthias Krüger

commit sha 2ad46acd7fee4e193aff3fd243ca91ca092a42aa

EarlyOtherwiseBranch::run_pass(): don't convert Place to Place (clippy::useless_conversion)

view details

Matthias Krüger

commit sha d7a5c574b1010360fd840f5dfc810f2aa782eac5

use std::mem::take(x) instead of std::mem::replace(x, Default::default()) (clippy::mem_replace_with_default)

view details

Stein Somers

commit sha 3e485d7cf59dafbc37467c3ef1acc51f26b381d9

BTreeMap: keep an eye out on the size of the main components

view details

Joe Richey

commit sha 37f795697c7d0530deb0c5c94a8f99aab587e2e4

libary: Forward compiler-builtins "mem" feature This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>

view details

Wesley Wiser

commit sha 63bb51d3ac3ec015d914e2b0792b4d5aa6e8e4a5

Add unstable book docs for `-Zunsound-mir-opts`

view details

hyd-dev

commit sha a2526b416fb4ca7874fa41a3eb595f456703d486

Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() `assert!` panics on failure, which is not signal-safe.

view details

Vadim Petrochenkov

commit sha 9340ee4380dcc9b81e0afb1ef5518730b064a78a

Ensure that all LLVM components requested by tests are available on CI

view details

Hameer Abbasi

commit sha 2c385040550fb1eb98cf14ace99129f05b1d7b3f

Add test for async/await combined with const-generics.

view details

Ivan Tham

commit sha b141e49d8702fa170953aed388eb1510622db79b

Fix typo in alloc vec comment

view details

Ivan Tham

commit sha f9b625f8e004cebdc79f891dea3fb128ec663151

Alloc vec use imported path mem::ManuallyDrop::new -> ManuallyDrop::new

view details

Eric Huss

commit sha f4d5275cbb87637daba704251c043d2b303e36d6

Update books

view details

Tomasz Miąsko

commit sha 93e3db30e9c3b8fb217743e9d06f37b12dcb8745

liveness: Use Option::None to represent absent live nodes No functional changes intended.

view details

samlich

commit sha 607d30dcfa8c40b91d0073a18c5897eee00a4cda

Add test for issue #74761

view details

Jonas Schievink

commit sha 248d6bf1e2103aaac8642aecdfcffd4259927fea

Rollup merge of #77037 - matthiaskrgr:cl42ppy, r=Dylan-DPC more tiny clippy cleanups commits stand alone and can be reviewed one by one

view details

Jonas Schievink

commit sha 7ad03dd91df96335551384f7ca220b20922e2f15

Rollup merge of #77233 - ssomers:btree_size_matters, r=Mark-Simulacrum BTreeMap: keep an eye out on the size of the main components r? @Mark-Simulacrum

view details

Jonas Schievink

commit sha a4dc8dae02ad78499c0c176227eb39071e1d0dd2

Rollup merge of #77280 - petrochenkov:llvmcomp, r=Mark-Simulacrum Ensure that all LLVM components requested by tests are available on CI Addresses https://github.com/rust-lang/rust/pull/75064#issuecomment-667722652 I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task. I added a new variable, but any of the already existing ones defined by CI could be used instead. r? @Mark-Simulacrum

view details

Jonas Schievink

commit sha 87387fd23ead4ca4d2dcc3ea6e4e6dbc925d6914

Rollup merge of #77284 - josephlr:mem, r=Mark-Simulacrum library: Forward compiler-builtins "mem" feature This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>

view details

Jonas Schievink

commit sha d4add198be2c7cc8285673ca724b330067fa2f57

Rollup merge of #77296 - tmiasko:liveness-option, r=ecstatic-morse liveness: Use Option::None to represent absent live nodes No functional changes intended.

view details

Jonas Schievink

commit sha b85081d46ac2cbfa6862487024fa3323ef95a0e3

Rollup merge of #77322 - rust-lang:wesleywiser-patch-1, r=steveklabnik Add unstable book docs for `-Zunsound-mir-opts` The `-Zunsound-mir-opts` flag was added in #76899.

view details

Jonas Schievink

commit sha c46f5784a68dbddf360b5e0d504ca77b359e1742

Rollup merge of #77328 - hyd-dev:assert-to-rtassert, r=Amanieu Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() As discussed in #73894, `assert!` panics on failure, which is not signal-safe, and `rtassert!` is a suitable replacement. Fixes #73894. r? @Amanieu @cuviper @joshtriplett

view details

push time in an hour

PR merged rust-lang/rust

Rollup of 12 pull requests S-waiting-on-bors merged-by-bors rollup

Successful merges:

  • #77037 (more tiny clippy cleanups)
  • #77233 (BTreeMap: keep an eye out on the size of the main components)
  • #77280 (Ensure that all LLVM components requested by tests are available on CI)
  • #77284 (library: Forward compiler-builtins "mem" feature)
  • #77296 (liveness: Use Option::None to represent absent live nodes)
  • #77322 (Add unstable book docs for -Zunsound-mir-opts)
  • #77328 (Use rtassert! instead of assert! from the child process after fork() in std::sys::unix::process::Command::spawn())
  • #77331 (Add test for async/await combined with const-generics.)
  • #77338 (Fix typo in alloc vec comment)
  • #77340 (Alloc vec use imported path)
  • #77345 (Add test for issue #74761)
  • #77348 (Update books)

Failed merges:

r? @ghost

+127 -54

4 comments

17 changed files

jonas-schievink

pr closed time in an hour

issue closedrust-lang/rust

Unconstrained lifetimes allowed with member_constraints/type_alias_impl_trait

<!-- Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples.

http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/

-->

Code

#![feature(member_constraints)]
#![feature(type_alias_impl_trait)]

pub trait A {
  type B;
  fn f(&self) -> Self::B;
}
impl<'a, 'b> A for () {
  type B = impl core::fmt::Debug;

  fn f(&self) -> Self::B {}
}

fn main() {}

Playground

Meta

<!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. -->

rustc --version --verbose:

rustc 1.47.0-nightly (5ef299eb9 2020-07-24) running on x86_64-unknown-linux-gnu

Error output

   Compiling playground v0.0.1 (/playground)
thread 'rustc' panicked at 'assertion failed: self.universal_regions.is_universal_region(shorter)', src/librustc_mir/borrow_check/type_check/free_region_relations.rs:377:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I had first seen:

thread 'rustc' panicked at 'assertion failed: self.universal_regions.is_universal_region(longer)', src/librustc_mir/borrow_check/type_check/free_region_relations.rs:379:9

Removing the second lifetime (impl<'a> A for () {) gives the correct error,

error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
 --> src/main.rs:8:6
  |
8 | impl<'a> A for () {
  |      ^^ unconstrained lifetime parameter

Additionally, disabling either type_alias_impl_trait or member_constraints still panics (and prompts to enable those features), except in stable where it prompts to enable the features, but does not panic.

Perhaps similar to #57200

<!-- Include a backtrace in the code block by setting RUST_BACKTRACE=1 in your environment. E.g. RUST_BACKTRACE=1 cargo build. --> <details><summary><strong>Backtrace</strong></summary> <p>

Compiling playground v0.0.1 (/playground)
thread 'rustc' panicked at 'assertion failed: self.universal_regions.is_universal_region(shorter)', src/librustc_mir/borrow_check/type_check/free_region_relations.rs:377:9
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1117
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1508
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:217
  10: rustc_driver::report_ice
  11: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:530
  12: std::panicking::begin_panic
  13: <rustc_mir::borrow_check::type_check::free_region_relations::UniversalRegionRelations as rustc_infer::infer::free_regions::FreeRegionRelations>::sub_free_regions
  14: rustc_infer::infer::InferCtxt::commit_if_ok
  15: rustc_mir::borrow_check::type_check::TypeChecker::eq_opaque_type_and_type
  16: rustc_mir::borrow_check::type_check::type_check
  17: rustc_mir::borrow_check::nll::compute_regions
  18: rustc_mir::borrow_check::do_mir_borrowck
  19: rustc_infer::infer::InferCtxtBuilder::enter
  20: rustc_mir::borrow_check::mir_borrowck
  21: core::ops::function::FnOnce::call_once
  22: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_borrowck>::compute
  23: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  24: rustc_data_structures::stack::ensure_sufficient_stack
  25: rustc_query_system::query::plumbing::get_query_impl
  26: rustc_typeck::collect::type_of::find_opaque_ty_constraints::ConstraintLocator::check
  27: rustc_hir::intravisit::walk_impl_item_ref
  28: rustc_hir::intravisit::walk_item
  29: rustc_typeck::collect::type_of::type_of
  30: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::type_of>::compute
  31: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  32: rustc_data_structures::stack::ensure_sufficient_stack
  33: rustc_query_system::query::plumbing::get_query_impl
  34: rustc_query_system::query::plumbing::ensure_query_impl
  35: <rustc_typeck::collect::CollectItemTypesVisitor as rustc_hir::intravisit::Visitor>::visit_item
  36: rustc_middle::hir::map::Map::visit_item_likes_in_module
  37: rustc_typeck::collect::collect_mod_item_types
  38: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::collect_mod_item_types>::compute
  39: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  40: rustc_data_structures::stack::ensure_sufficient_stack
  41: rustc_query_system::query::plumbing::get_query_impl
  42: rustc_query_system::query::plumbing::ensure_query_impl
  43: rustc_session::session::Session::track_errors
  44: rustc_typeck::check_crate
  45: rustc_interface::passes::analysis
  46: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::analysis>::compute
  47: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  48: rustc_data_structures::stack::ensure_sufficient_stack
  49: rustc_query_system::query::plumbing::get_query_impl
  50: rustc_middle::ty::context::tls::enter_global
  51: rustc_interface::queries::<impl rustc_interface::interface::Compiler>::enter
  52: rustc_span::with_source_map
  53: rustc_interface::interface::create_compiler_and_run
  54: scoped_tls::ScopedKey<T>::set
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.47.0-nightly (5ef299eb9 2020-07-24) running on x86_64-unknown-linux-gnu

note: compiler flags: -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --crate-type bin

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [mir_borrowck] borrow-checking `<() as A>::f`
#1 [type_of] computing type of `<() as A>::B::{{opaque}}#0`
#2 [collect_mod_item_types] collecting item types in top-level module
#3 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `playground`.

To learn more, run the command again with --verbose.

</p> </details>

closed time in an hour

samlich

issue closedrust-lang/rust

Async/.await and const-generics causes "Broken MIR:"

Code

The use of async/await and const generics can cause ICE (in the type checker?). Here is a minimal example which induces ICE:

#![feature(const_generics)]
#![allow(incomplete_features)]

const SIZE: usize = 16;

struct Bar<const H: usize> {}

struct Foo<const H: usize> {}

impl<const H: usize> Foo<H> {
    async fn biz(_: &[[u8; SIZE]]) -> Vec<()> {
        vec![]
    }

    pub async fn baz(&self) -> Bar<H> {
        Self::biz(&vec![]).await;
        Bar {}
    }
}

The behaviour is not triggered without the use of async/await.

The full library source.

Meta

I am running recent nightly compiler:

rustc --version --verbose:

rustc 1.47.0-nightly (6c8927b0c 2020-07-26)
binary: rustc
commit-hash: 6c8927b0cf80ceee19386026cf9d7fd4fd9d486f
commit-date: 2020-07-26
host: x86_64-unknown-linux-gnu
release: 1.47.0-nightly
LLVM version: 10.0

Error output

RUST_BACKTRACE=full cargo build
   Compiling bug v0.1.0 (/home/rot256/src/bug)
warning: constant is never used: `SIZE`
 --> src/lib.rs:4:1
   |
4 | const SIZE: usize = 16;
   | ^^^^^^^^^^^^^^^^^^^^^^^
   |
  = note: `#[warn(dead_code)]` on by default

warning: struct is never constructed: `Bar`
 --> src/lib.rs:6:8
   |
6 | struct Bar<const H: usize> {}
   |        ^^^

warning: struct is never constructed: `Foo`
 --> src/lib.rs:8:8
  |
8 | struct Foo<const H: usize> {}
   |        ^^^

warning: associated function is never used: `biz`
  --> src/lib.rs:11:14
     |
11 |     async fn biz(_: &[[u8; SIZE]]) -> Vec<()> {
     |              ^^^

warning: associated function is never used: `baz`
  --> src/lib.rs:15:18
     |
15 |     pub async fn baz(&self) -> Bar<H> {
     |                  ^^^

error: internal compiler error: src/librustc_mir/transform/generator.rs:739:13: Broken MIR: generator contains type std::vec::Vec<[u8; _]> in MIR, but typeck only knows about for<'r, 's, 't0, 't1> {std::future::ResumeTy, &'r Foo<H>, std::vec::Vec<[u8; _]>, &'s [[u8; _]], &'t0 std::vec::Vec<[u8; _]>, impl std::future::Future, ()}
  --> src/lib.rs:15:39
     |
15 |       pub async fn baz(&self) -> Bar<H> {
     |  _______________________________________^
16 | |         Self::biz(&vec![]).await;
17 | |         Bar {}
18 | |     }
     | |_____^

thread 'rustc' panicked at 'Box<Any>', /rustc/6c8927b0cf80ceee19386026cf9d7fd4fd9d486f/src/libstd/macros.rs:13:23
stack backtrace:
   0:     0x7f35c2d05215 - backtrace::backtrace::libunwind::trace::h75aedf5f78e5147f
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1:     0x7f35c2d05215 - backtrace::backtrace::trace_unsynchronized::h18fb73c9ac9ae753
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2:     0x7f35c2d05215 - std::sys_common::backtrace::_print_fmt::h65f97470ff13ec84
                               at src/libstd/sys_common/backtrace.rs:78
   3:     0x7f35c2d05215 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hee061c54ddc9f024
                               at src/libstd/sys_common/backtrace.rs:59
   4:     0x7f35c2d4141c - core::fmt::write::hfbd2baad61ed21a8
                               at src/libcore/fmt/mod.rs:1117
   5:     0x7f35c2cf6f52 - std::io::Write::write_fmt::h72f9bd227f40dc62
                               at src/libstd/io/mod.rs:1508
   6:     0x7f35c2d0a0b0 - std::sys_common::backtrace::_print::h2d2cd8fe02feb5fa
                               at src/libstd/sys_common/backtrace.rs:62
   7:     0x7f35c2d0a0b0 - std::sys_common::backtrace::print::h801b12991252ba7c
                               at src/libstd/sys_common/backtrace.rs:49
   8:     0x7f35c2d0a0b0 - std::panicking::default_hook::{{closure}}::h25fc1fbf3b63b5c8
                               at src/libstd/panicking.rs:198
   9:     0x7f35c2d09dfc - std::panicking::default_hook::h62c897957a5e0f26
                               at src/libstd/panicking.rs:217
  10:     0x7f35c348e719 - rustc_driver::report_ice::h54e3b417084b44b0
  11:     0x7f35c2d0a828 - std::panicking::rust_panic_with_hook::hb8a276f163c59810
                               at src/libstd/panicking.rs:530
  12:     0x7f35c4648a43 - std::panicking::begin_panic::h56ab19f2cedb9db6
  13:     0x7f35c46cf5ac - rustc_errors::HandlerInner::span_bug::h6725b1754e0b8350
  14:     0x7f35c46cf9f0 - rustc_errors::Handler::span_bug::h690acfedaaa39918
  15:     0x7f35c46d3ec4 - rustc_middle::util::bug::opt_span_bug_fmt::{{closure}}::h9ad20ff21dfdee15
  16:     0x7f35c46d2c2b - rustc_middle::ty::context::tls::with_opt::{{closure}}::h55dd76028893bf0b
  17:     0x7f35c46d2bd2 - rustc_middle::ty::context::tls::with_opt::ha4f5888994b68db9
  18:     0x7f35c46d3dc9 - rustc_middle::util::bug::opt_span_bug_fmt::hff1523241ff1d646
  19:     0x7f35c46d3d83 - rustc_middle::util::bug::span_bug_fmt::h6642bef07315747d
  20:     0x7f35c4677dbf - <rustc_mir::transform::generator::StateTransform as rustc_mir::transform::MirPass>::run_pass::ha0b6b0061f9616e8
  21:     0x7f35c4a076d5 - rustc_mir::transform::run_passes::h49d12d42b645883c
  22:     0x7f35c4a097ee - rustc_mir::transform::run_optimization_passes::h4808514d2a3dc8d0
  23:     0x7f35c4a09bc0 - rustc_mir::transform::inner_optimized_mir::h7bbfaea3bf718bc9
  24:     0x7f35c4a0997d - rustc_mir::transform::optimized_mir::h2c34b792ca19fc38
  25:     0x7f35c5e8e061 - rustc_middle::dep_graph::<impl rustc_query_system::dep_graph::DepKind for rustc_middle::dep_graph::dep_node::DepKind>::with_deps::h4c010a4768f0f01c
  26:     0x7f35c58f5b4f - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h1d87895a9b5e641e
  27:     0x7f35c5c846b2 - rustc_data_structures::stack::ensure_sufficient_stack::hf48d61a9d17fd483
  28:     0x7f35c5acc793 - rustc_query_system::query::plumbing::get_query_impl::hef59961961c2f14e
  29:     0x7f35c59bb801 - rustc_middle::ty::layout::LayoutCx<rustc_middle::ty::context::TyCtxt>::layout_raw_uncached::h232eb1b291401511
  30:     0x7f35c59b6cff - rustc_middle::ty::layout::layout_raw::hf9eb140d1022d561
  31:     0x7f35c59e5c21 - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::layout_raw>::compute::h9a2c6c02944bd2dd
  32:     0x7f35c5e92075 - rustc_middle::dep_graph::<impl rustc_query_system::dep_graph::DepKind for rustc_middle::dep_graph::dep_node::DepKind>::with_deps::he44c72eff6c9f466
  33:     0x7f35c590c0a0 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h7a291f01f92f5108
  34:     0x7f35c5c7762f - rustc_data_structures::stack::ensure_sufficient_stack::h353561557dc75241
  35:     0x7f35c5abd6e7 - rustc_query_system::query::plumbing::get_query_impl::hdc6080a3a10cbfb0
  36:     0x7f35c59c57f4 - <rustc_middle::ty::layout::LayoutCx<rustc_middle::ty::context::TyCtxt> as rustc_target::abi::LayoutOf>::layout_of::hdd5ae6209bb8c384
  37:     0x7f35c5f24fbe - <core::iter::adapters::ResultShunt<I,E> as core::iter::traits::iterator::Iterator>::next::h3dc9bd222e471f34
  38:     0x7f35c58b312c - <alloc::vec::Vec<T> as alloc::vec::SpecExtend<T,I>>::from_iter::h02b7a95b20eda5b5
  39:     0x7f35c5f24dbd - <core::iter::adapters::ResultShunt<I,E> as core::iter::traits::iterator::Iterator>::next::h19c51e30891d4acc
  40:     0x7f35c58d73b0 - <alloc::vec::Vec<T> as alloc::vec::SpecExtend<T,I>>::from_iter::hecfa2cc5545dc974
  41:     0x7f35c59bc2e2 - rustc_middle::ty::layout::LayoutCx<rustc_middle::ty::context::TyCtxt>::layout_raw_uncached::h232eb1b291401511
  42:     0x7f35c59b6cff - rustc_middle::ty::layout::layout_raw::hf9eb140d1022d561
  43:     0x7f35c59e5c21 - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::layout_raw>::compute::h9a2c6c02944bd2dd
  44:     0x7f35c5e92075 - rustc_middle::dep_graph::<impl rustc_query_system::dep_graph::DepKind for rustc_middle::dep_graph::dep_node::DepKind>::with_deps::he44c72eff6c9f466
  45:     0x7f35c590c0a0 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h7a291f01f92f5108
  46:     0x7f35c5c7762f - rustc_data_structures::stack::ensure_sufficient_stack::h353561557dc75241
  47:     0x7f35c5abd6e7 - rustc_query_system::query::plumbing::get_query_impl::hdc6080a3a10cbfb0
  48:     0x7f35c59c6351 - <rustc_middle::ty::layout::LayoutCx<rustc_middle::ty::query::TyCtxtAt> as rustc_target::abi::LayoutOf>::layout_of::h249f6e77b4e78581
  49:     0x7f35c470fa5e - <rustc_mir::transform::const_prop::ConstProp as rustc_mir::transform::MirPass>::run_pass::heeb6bfd954ebfdb5
  50:     0x7f35c4a076d5 - rustc_mir::transform::run_passes::h49d12d42b645883c
  51:     0x7f35c4a097ee - rustc_mir::transform::run_optimization_passes::h4808514d2a3dc8d0
  52:     0x7f35c4a09bc0 - rustc_mir::transform::inner_optimized_mir::h7bbfaea3bf718bc9
  53:     0x7f35c4a0997d - rustc_mir::transform::optimized_mir::h2c34b792ca19fc38
  54:     0x7f35c4e721e2 - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::optimized_mir>::compute::hd8f3e45025769508
  55:     0x7f35c4f44a2a - rustc_middle::dep_graph::<impl rustc_query_system::dep_graph::DepKind for rustc_middle::dep_graph::dep_node::DepKind>::with_deps::hbbb1691ceb2a7378
  56:     0x7f35c5033abc - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h2a116afb948656f3
  57:     0x7f35c4fb6de3 - rustc_data_structures::stack::ensure_sufficient_stack::h50171c7f6732d5e7
  58:     0x7f35c4fdab9a - rustc_query_system::query::plumbing::get_query_impl::h23e08d9912664785
  59:     0x7f35c4e900bd - rustc_metadata::rmeta::encoder::EncodeContext::encode_optimized_mir::h21e11081f3184770
  60:     0x7f35c4e9437b - <rustc_metadata::rmeta::encoder::EncodeContext as rustc_hir::intravisit::Visitor>::visit_item::hc5fad122cac52247
  61:     0x7f35c508fc67 - rustc_hir::hir::Crate::visit_all_item_likes::h57ce95c9da9b50ad
  62:     0x7f35c4e98da5 - rustc_metadata::rmeta::encoder::encode_metadata_impl::h2e797180c72c7de0
  63:     0x7f35c4fb437c - rustc_data_structures::sync::join::h26f229ec55e7a0f5
  64:     0x7f35c4eb2630 - rustc_metadata::rmeta::decoder::cstore_impl::<impl rustc_middle::middle::cstore::CrateStore for rustc_metadata::creader::CStore>::encode_metadata::hab1eceef04d8a455
  65:     0x7f35c5cdde50 - rustc_middle::ty::context::TyCtxt::encode_metadata::h6eaf9864b984a444
  66:     0x7f35c362e8f4 - rustc_interface::passes::start_codegen::h4cb47030bcada22e
  67:     0x7f35c36488e6 - rustc_middle::ty::context::tls::enter_global::hc8731f69dcd0bbcb
  68:     0x7f35c364445e - rustc_interface::queries::Queries::ongoing_codegen::ha8e667ca2563fa09
  69:     0x7f35c34498d3 - rustc_interface::queries::<impl rustc_interface::interface::Compiler>::enter::h3b5436b320054acc
  70:     0x7f35c34e8277 - rustc_span::with_source_map::hd3215c6d07150bbc
  71:     0x7f35c344afb6 - rustc_interface::interface::create_compiler_and_run::hc502b394ead637d1
  72:     0x7f35c347432d - scoped_tls::ScopedKey<T>::set::hb09c39dbfa5a4396
  73:     0x7f35c349a4a2 - std::sys_common::backtrace::__rust_begin_short_backtrace::h4fa4ac8c571754e6
  74:     0x7f35c345726e - core::ops::function::FnOnce::call_once{{vtable.shim}}::h23cc72206c0cf83b
  75:     0x7f35c2d18d3a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h3e41d894970cea2f
                               at /rustc/6c8927b0cf80ceee19386026cf9d7fd4fd9d486f/src/liballoc/boxed.rs:1074
  76:     0x7f35c2d18d3a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h9a318bb00b7f8871
                               at /rustc/6c8927b0cf80ceee19386026cf9d7fd4fd9d486f/src/liballoc/boxed.rs:1074
  77:     0x7f35c2d18d3a - std::sys::unix::thread::Thread::new::thread_start::hf522342530b04cb6
                               at src/libstd/sys/unix/thread.rs:87
  78:     0x7f35c2c48f27 - start_thread
                               at ./nptl/pthread_create.c:479
  79:     0x7f35c2b6831f - __clone
                               at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
  80:                0x0 - <unknown>

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.47.0-nightly (6c8927b0c 2020-07-26) running on x86_64-unknown-linux-gnu

note: compiler flags: -C embed-bitcode=no -C debuginfo=2 -C incremental --crate-type lib

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [optimized_mir] optimizing MIR for `Foo::<H>::baz::{{closure}}#0`
#1 [layout_raw] computing layout of `[static generator@src/lib.rs:15:39: 18:6 self:&Foo<H> for<'r, 's, 't0, 't1> {std::future::ResumeTy, &'r Foo<H>, std::vec::Vec<[u8; 16]>, &'s [[u8; 16]], &'t0 std::vec::Vec<[u8; 16]>, impl std::future::Future, ()}]`
#2 [layout_raw] computing layout of `std::future::from_generator::GenFuture<[static generator@src/lib.rs:15:39: 18:6 self:&Foo<H> for<'r, 's, 't0, 't1> {std::future::ResumeTy, &'r Foo<H>, std::vec::Vec<[u8; 16]>, &'s [[u8; 16]], &'t0 std::vec::Vec<[u8; 16]>, impl std::future::Future, ()}]>`
#3 [optimized_mir] optimizing MIR for `Foo::<H>::baz`
end of query stack
error: aborting due to previous error; 5 warnings emitted

error: could not compile `bug`.

To learn more, run the command again with --verbose.

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"hameerabbasi"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->

closed time in an hour

rot256

issue closedrust-lang/rust

On Unix-like OSes, std::process::Command::spawn() should not use assert! from the child process after fork()

On Unix-like OSes, std::process::Command::spawn() uses an assert! to check if the pipe I/O succeeded. If that assert! fails, it will call panic!, which is not signal-safe. It's better to use if ....is_err() { std::intrinsics::abort() } there. libc::abort() (std::process::abort()) shouldn't be used as a replacement, as, at least in glibc, it's not signal-safe<sup>[1][2]</sup>, although all of the C standard, the C++ standard, the POSIX standard, and Linux man-pages say it should be.

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=stdlib/abort.c;h=df98782dd7ea6c1476184a365bd9f3954f481a18;hb=refs/heads/master#l54 [2] https://www.gnu.org/software/libc/manual/html_node/Aborting-a-Program.html#Aborting-a-Program

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"hyd-dev"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->

closed time in an hour

hyd-dev

pull request commentrust-lang/rust

Rollup of 12 pull requests

:sunny: Test successful - checks-actions, checks-azure Approved by: jonas-schievink Pushing ef663a8a48ea6b98b43cbfaefd99316b36b16825 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"jonas-schievink","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=36940","checks-actions":"https://github.com/rust-lang-ci/rust/runs/1190508822"},"merge_sha":"ef663a8a48ea6b98b43cbfaefd99316b36b16825"} -->

jonas-schievink

comment created time in an hour

push eventrust-lang/crates.io

Renovate Bot

commit sha f82e59faa3f87d46bc86b6caecd4d1f78266e9c9

Update dependency ember-source to v3.21.3

view details

bors

commit sha 5ed9258e4fe033176a4ed4d12b52855157842b54

Auto merge of #2852 - rust-lang:renovate/ember-source-3.21.x, r=Turbo87 Update dependency ember-source to v3.21.3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ember-source](https://emberjs.com/) ([source](https://togithub.com/emberjs/ember.js)) | devDependencies | patch | [`3.21.2` -> `3.21.3`](https://renovatebot.com/diffs/npm/ember-source/3.21.2/3.21.3) | --- ### Release Notes <details> <summary>emberjs/ember.js</summary> ### [`v3.21.3`](https://togithub.com/emberjs/ember.js/blob/master/CHANGELOG.md#v3213-September-30-2020) [Compare Source](https://togithub.com/emberjs/ember.js/compare/v3.21.2...v3.21.3) - [#&#8203;19172](https://togithub.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

view details

push time in an hour

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.3

:hourglass: Testing commit f82e59faa3f87d46bc86b6caecd4d1f78266e9c9 with merge 5ed9258e4fe033176a4ed4d12b52855157842b54... <!-- homu: {"type":"BuildStarted","head_sha":"f82e59faa3f87d46bc86b6caecd4d1f78266e9c9","merge_sha":"5ed9258e4fe033176a4ed4d12b52855157842b54"} -->

renovate[bot]

comment created time in an hour

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.3

:pushpin: Commit f82e59faa3f87d46bc86b6caecd4d1f78266e9c9 has been approved by Turbo87

<!-- @bors r=Turbo87 f82e59faa3f87d46bc86b6caecd4d1f78266e9c9 --> <!-- homu: {"type":"Approved","sha":"f82e59faa3f87d46bc86b6caecd4d1f78266e9c9","approver":"Turbo87"} -->

renovate[bot]

comment created time in an hour

pull request commentrust-lang/rust

Mark inactive enum variants along "otherwise" edge as uninitialized

:sunny: Try build successful - checks-actions, checks-azure Build commit: d23533d70fe2773aabe056564e0930e7e72b70be (d23533d70fe2773aabe056564e0930e7e72b70be) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=36941","checks-actions":"https://github.com/rust-lang-ci/rust/runs/1190459454"},"merge_sha":"d23533d70fe2773aabe056564e0930e7e72b70be"} -->

ecstatic-morse

comment created time in an hour

pull request commentrust-lang/rust

Split core/str/mod.rs to smaller files

:pushpin: Commit dce7248a39e7f8907cb9c5cfe719f6f63da1fa1f has been approved by Amanieu

<!-- @bors r=Amanieu dce7248a39e7f8907cb9c5cfe719f6f63da1fa1f --> <!-- homu: {"type":"Approved","sha":"dce7248a39e7f8907cb9c5cfe719f6f63da1fa1f","approver":"Amanieu"} -->

lzutao

comment created time in 2 hours

pull request commentrust-lang/rust

Add Iterator::advance_by and DoubleEndedIterator::advance_back_by

:pushpin: Commit ecacc7534b6bf50205c37c89402565b82d95a257 has been approved by Amanieu

<!-- @bors r=Amanieu ecacc7534b6bf50205c37c89402565b82d95a257 --> <!-- homu: {"type":"Approved","sha":"ecacc7534b6bf50205c37c89402565b82d95a257","approver":"Amanieu"} -->

timvermeulen

comment created time in 2 hours

PR merged rust-lang/rust-clippy

Add lint for inline assembly syntax style preference S-waiting-on-author

changelog: Add lint for inline assembly syntax style preference

+223 -0

7 comments

6 changed files

jethrogb

pr closed time in 2 hours

push eventrust-lang/rust-clippy

Jethro Beekman

commit sha 0690f9c5d526baa593cc62b175ef5e7f2c8f4f9c

Add lint for inline assembly syntax style preference

view details

Eduardo Broto

commit sha 507561ecfcec33d4263cff17cfe953518b8c3ce6

Update tests/ui/asm_syntax.rs Use a single `only` header command in asm_syntax test

view details

bors

commit sha abce9e7c9fc0520da4556ca641cce9aee462c2fc

Auto merge of #6092 - jethrogb:jb/inline-asm-syntax-lint, r=ebroto Add lint for inline assembly syntax style preference changelog: Add lint for inline assembly syntax style preference

view details

push time in 2 hours

pull request commentrust-lang/rust-clippy

Add lint for inline assembly syntax style preference

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: ebroto Pushing abce9e7c9fc0520da4556ca641cce9aee462c2fc to master... <!-- homu: {"type":"BuildCompleted","approved_by":"ebroto","base_ref":"master","builders":{"checks-action_test":"https://github.com/rust-lang/rust-clippy/runs/1190326848","checks-action_dev_test":"https://github.com/rust-lang/rust-clippy/runs/1190260250","checks-action_remark_test":"https://github.com/rust-lang/rust-clippy/runs/1190257595"},"merge_sha":"abce9e7c9fc0520da4556ca641cce9aee462c2fc"} -->

jethrogb

comment created time in 2 hours

push eventrust-lang-ci/rust

Hugues de Valon

commit sha d255d70e7a6a84c82cc74f968f529f42dd40b8ce

Update LLVM and add Unsupported diagnostic Secure entry functions do not support if arguments are passed on the stack. An "unsupported" diagnostic will be emitted by LLVM if that is the case. This commits adds support in Rust for that diagnostic so that an error will be output if that is the case! Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 1aaafac6ffec2556a27a3c34365c685c124ee029

Add support for cmse_nonsecure_entry attribute This patch adds support for the LLVM cmse_nonsecure_entry attribute. This is a target-dependent attribute that only has sense for the thumbv8m Rust targets. You can find more information about this attribute here: https://developer.arm.com/documentation/ecm0359818/latest/ Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 2588287deffd92c4ca0b5b39f92b9cca894a3983

Add more tests and check for ABI Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

bors

commit sha 867bd42c38bac3870388765f65386b18cf1d9c5f

Auto merge of #75810 - hug-dev:cmse-nonsecure-entry, r=jonas-schievink Add support for cmse_nonsecure_entry attribute This pull request adds the `cmse_nonsecure_entry` attribute under an unstable feature. I was not sure if it was fine for me to send directly the pull-request or if I should submit a RFC first. I was told on Zulip that it was fine to do so but please close it if I need first submit a RFC or follow another process instead. The `cmse_nonsecure_entry` attribute is a LLVM attribute that will be available in LLVM 11. I plan to rebase on the [upgrade PR](https://github.com/rust-lang/rust/pull/73526) once merged to make this one compile. This attribute modifies code generation of the function as explained [here](https://developer.arm.com/documentation/ecm0359818/latest/) to make it work with the TrustZone-M hardware feature. This feature is only available on `thumbv8m` targets so I created an error for that if one tries to use this attribute for another target. I added this attribute in Rust as any other LLVM attribute are added but since this one is target-dependent I am not sure if it was the best thing to do. Please indicate me if you think of other ways, like isolating target-dependent attributes together. ---------------- Tracking issue: https://github.com/rust-lang/rust/issues/75835

view details

Dylan MacKenzie

commit sha 59a20eba50b30aba94f263b9b002fe7ad45dd5b7

Mark inactive enum variants along "otherwise" edge as uninitialized This means all enum variants whose discriminant has a dedicated outgoing edge in the `SwitchInt` terminator.

view details

Dylan MacKenzie

commit sha c6932c69f854606790c5d65b913471ad16847378

Remove unused helper function

view details

Dylan MacKenzie

commit sha e0438129233fbe7e1724b05c52f46bd2f2b89730

Bless MIR test

view details

bors

commit sha d23533d70fe2773aabe056564e0930e7e72b70be

Auto merge of #77377 - ecstatic-morse:dataflow-maybe-init-otherwise, r=<try> Mark inactive enum variants along "otherwise" edge as uninitialized This is a slight improvement on #68528 and #73879. Previously, the interface to the dataflow framework did not allow edge-specific effects along the "otherwise" edge of a `SwitchInt` terminator. #77242 fixed this. Now we can mark enum variants whose discriminant is handled in an integer-valued `SwitchInt` edge as definitely uninitialized along the "otherwise" edge. Notably, this applies within an `else` block attached to an `if let` expression. r? `@ghost`

view details

push time in 2 hours

pull request commentrust-lang/rust

Mark inactive enum variants along "otherwise" edge as uninitialized

:hourglass: Trying commit e0438129233fbe7e1724b05c52f46bd2f2b89730 with merge d23533d70fe2773aabe056564e0930e7e72b70be... <!-- homu: {"type":"TryBuildStarted","head_sha":"e0438129233fbe7e1724b05c52f46bd2f2b89730","merge_sha":"d23533d70fe2773aabe056564e0930e7e72b70be"} -->

ecstatic-morse

comment created time in 2 hours

push eventrust-lang/rust-clippy

Jethro Beekman

commit sha 0690f9c5d526baa593cc62b175ef5e7f2c8f4f9c

Add lint for inline assembly syntax style preference

view details

Eduardo Broto

commit sha 507561ecfcec33d4263cff17cfe953518b8c3ce6

Update tests/ui/asm_syntax.rs Use a single `only` header command in asm_syntax test

view details

bors

commit sha abce9e7c9fc0520da4556ca641cce9aee462c2fc

Auto merge of #6092 - jethrogb:jb/inline-asm-syntax-lint, r=ebroto Add lint for inline assembly syntax style preference changelog: Add lint for inline assembly syntax style preference

view details

push time in 2 hours

pull request commentrust-lang/rust-clippy

Add lint for inline assembly syntax style preference

:hourglass: Testing commit 507561ecfcec33d4263cff17cfe953518b8c3ce6 with merge abce9e7c9fc0520da4556ca641cce9aee462c2fc... <!-- homu: {"type":"BuildStarted","head_sha":"507561ecfcec33d4263cff17cfe953518b8c3ce6","merge_sha":"abce9e7c9fc0520da4556ca641cce9aee462c2fc"} -->

jethrogb

comment created time in 2 hours

pull request commentrust-lang/rust-clippy

Add lint for inline assembly syntax style preference

:pushpin: Commit 507561ecfcec33d4263cff17cfe953518b8c3ce6 has been approved by ebroto

<!-- @bors r=ebroto 507561ecfcec33d4263cff17cfe953518b8c3ce6 --> <!-- homu: {"type":"Approved","sha":"507561ecfcec33d4263cff17cfe953518b8c3ce6","approver":"ebroto"} -->

jethrogb

comment created time in 2 hours

pull request commentrust-lang/rust

Implement Make `handle_alloc_error` default to panic (for no_std + liballoc)

:umbrella: The latest upstream changes (presumably #75810) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
haraldh

comment created time in 3 hours

pull request commentrust-lang/rust

Fix recursive nonterminal expansion during pretty-print/reparse check

:pushpin: Commit 46d8c4bdb7318a50d9df12a7a0b0bcc8efc1846e has been approved by petrochenkov

<!-- @bors r=petrochenkov 46d8c4bdb7318a50d9df12a7a0b0bcc8efc1846e --> <!-- homu: {"type":"Approved","sha":"46d8c4bdb7318a50d9df12a7a0b0bcc8efc1846e","approver":"petrochenkov"} -->

Aaron1011

comment created time in 3 hours

PR merged rust-lang/rust

Add support for cmse_nonsecure_entry attribute A-codegen S-waiting-on-bors T-lang merged-by-bors requires-nightly

This pull request adds the cmse_nonsecure_entry attribute under an unstable feature.

I was not sure if it was fine for me to send directly the pull-request or if I should submit a RFC first. I was told on Zulip that it was fine to do so but please close it if I need first submit a RFC or follow another process instead.

The cmse_nonsecure_entry attribute is a LLVM attribute that will be available in LLVM 11. I plan to rebase on the upgrade PR once merged to make this one compile.

This attribute modifies code generation of the function as explained here to make it work with the TrustZone-M hardware feature. This feature is only available on thumbv8m targets so I created an error for that if one tries to use this attribute for another target.

I added this attribute in Rust as any other LLVM attribute are added but since this one is target-dependent I am not sure if it was the best thing to do. Please indicate me if you think of other ways, like isolating target-dependent attributes together.


Tracking issue: https://github.com/rust-lang/rust/issues/75835

+254 -1

13 comments

25 changed files

hug-dev

pr closed time in 3 hours

push eventrust-lang-ci/rust

Matthias Krüger

commit sha 2ad46acd7fee4e193aff3fd243ca91ca092a42aa

EarlyOtherwiseBranch::run_pass(): don't convert Place to Place (clippy::useless_conversion)

view details

Matthias Krüger

commit sha d7a5c574b1010360fd840f5dfc810f2aa782eac5

use std::mem::take(x) instead of std::mem::replace(x, Default::default()) (clippy::mem_replace_with_default)

view details

Stein Somers

commit sha 3e485d7cf59dafbc37467c3ef1acc51f26b381d9

BTreeMap: keep an eye out on the size of the main components

view details

Joe Richey

commit sha 37f795697c7d0530deb0c5c94a8f99aab587e2e4

libary: Forward compiler-builtins "mem" feature This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>

view details

Wesley Wiser

commit sha 63bb51d3ac3ec015d914e2b0792b4d5aa6e8e4a5

Add unstable book docs for `-Zunsound-mir-opts`

view details

hyd-dev

commit sha a2526b416fb4ca7874fa41a3eb595f456703d486

Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() `assert!` panics on failure, which is not signal-safe.

view details

Vadim Petrochenkov

commit sha 9340ee4380dcc9b81e0afb1ef5518730b064a78a

Ensure that all LLVM components requested by tests are available on CI

view details

Hameer Abbasi

commit sha 2c385040550fb1eb98cf14ace99129f05b1d7b3f

Add test for async/await combined with const-generics.

view details

Ivan Tham

commit sha b141e49d8702fa170953aed388eb1510622db79b

Fix typo in alloc vec comment

view details

Ivan Tham

commit sha f9b625f8e004cebdc79f891dea3fb128ec663151

Alloc vec use imported path mem::ManuallyDrop::new -> ManuallyDrop::new

view details

Eric Huss

commit sha f4d5275cbb87637daba704251c043d2b303e36d6

Update books

view details

Tomasz Miąsko

commit sha 93e3db30e9c3b8fb217743e9d06f37b12dcb8745

liveness: Use Option::None to represent absent live nodes No functional changes intended.

view details

samlich

commit sha 607d30dcfa8c40b91d0073a18c5897eee00a4cda

Add test for issue #74761

view details

Jonas Schievink

commit sha 248d6bf1e2103aaac8642aecdfcffd4259927fea

Rollup merge of #77037 - matthiaskrgr:cl42ppy, r=Dylan-DPC more tiny clippy cleanups commits stand alone and can be reviewed one by one

view details

Jonas Schievink

commit sha 7ad03dd91df96335551384f7ca220b20922e2f15

Rollup merge of #77233 - ssomers:btree_size_matters, r=Mark-Simulacrum BTreeMap: keep an eye out on the size of the main components r? @Mark-Simulacrum

view details

Jonas Schievink

commit sha a4dc8dae02ad78499c0c176227eb39071e1d0dd2

Rollup merge of #77280 - petrochenkov:llvmcomp, r=Mark-Simulacrum Ensure that all LLVM components requested by tests are available on CI Addresses https://github.com/rust-lang/rust/pull/75064#issuecomment-667722652 I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task. I added a new variable, but any of the already existing ones defined by CI could be used instead. r? @Mark-Simulacrum

view details

Jonas Schievink

commit sha 87387fd23ead4ca4d2dcc3ea6e4e6dbc925d6914

Rollup merge of #77284 - josephlr:mem, r=Mark-Simulacrum library: Forward compiler-builtins "mem" feature This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>

view details

Jonas Schievink

commit sha d4add198be2c7cc8285673ca724b330067fa2f57

Rollup merge of #77296 - tmiasko:liveness-option, r=ecstatic-morse liveness: Use Option::None to represent absent live nodes No functional changes intended.

view details

Jonas Schievink

commit sha b85081d46ac2cbfa6862487024fa3323ef95a0e3

Rollup merge of #77322 - rust-lang:wesleywiser-patch-1, r=steveklabnik Add unstable book docs for `-Zunsound-mir-opts` The `-Zunsound-mir-opts` flag was added in #76899.

view details

Jonas Schievink

commit sha c46f5784a68dbddf360b5e0d504ca77b359e1742

Rollup merge of #77328 - hyd-dev:assert-to-rtassert, r=Amanieu Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() As discussed in #73894, `assert!` panics on failure, which is not signal-safe, and `rtassert!` is a suitable replacement. Fixes #73894. r? @Amanieu @cuviper @joshtriplett

view details

push time in 3 hours

pull request commentrust-lang/rust

Rollup of 12 pull requests

:hourglass: Testing commit 3624a901345c9c384aa9d1e27e21d0c4cd2c85ae with merge ef663a8a48ea6b98b43cbfaefd99316b36b16825... <!-- homu: {"type":"BuildStarted","head_sha":"3624a901345c9c384aa9d1e27e21d0c4cd2c85ae","merge_sha":"ef663a8a48ea6b98b43cbfaefd99316b36b16825"} -->

jonas-schievink

comment created time in 3 hours

push eventrust-lang/rust

Hugues de Valon

commit sha d255d70e7a6a84c82cc74f968f529f42dd40b8ce

Update LLVM and add Unsupported diagnostic Secure entry functions do not support if arguments are passed on the stack. An "unsupported" diagnostic will be emitted by LLVM if that is the case. This commits adds support in Rust for that diagnostic so that an error will be output if that is the case! Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 1aaafac6ffec2556a27a3c34365c685c124ee029

Add support for cmse_nonsecure_entry attribute This patch adds support for the LLVM cmse_nonsecure_entry attribute. This is a target-dependent attribute that only has sense for the thumbv8m Rust targets. You can find more information about this attribute here: https://developer.arm.com/documentation/ecm0359818/latest/ Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 2588287deffd92c4ca0b5b39f92b9cca894a3983

Add more tests and check for ABI Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

bors

commit sha 867bd42c38bac3870388765f65386b18cf1d9c5f

Auto merge of #75810 - hug-dev:cmse-nonsecure-entry, r=jonas-schievink Add support for cmse_nonsecure_entry attribute This pull request adds the `cmse_nonsecure_entry` attribute under an unstable feature. I was not sure if it was fine for me to send directly the pull-request or if I should submit a RFC first. I was told on Zulip that it was fine to do so but please close it if I need first submit a RFC or follow another process instead. The `cmse_nonsecure_entry` attribute is a LLVM attribute that will be available in LLVM 11. I plan to rebase on the [upgrade PR](https://github.com/rust-lang/rust/pull/73526) once merged to make this one compile. This attribute modifies code generation of the function as explained [here](https://developer.arm.com/documentation/ecm0359818/latest/) to make it work with the TrustZone-M hardware feature. This feature is only available on `thumbv8m` targets so I created an error for that if one tries to use this attribute for another target. I added this attribute in Rust as any other LLVM attribute are added but since this one is target-dependent I am not sure if it was the best thing to do. Please indicate me if you think of other ways, like isolating target-dependent attributes together. ---------------- Tracking issue: https://github.com/rust-lang/rust/issues/75835

view details

push time in 3 hours

push eventrust-lang-ci/rust

Hugues de Valon

commit sha d255d70e7a6a84c82cc74f968f529f42dd40b8ce

Update LLVM and add Unsupported diagnostic Secure entry functions do not support if arguments are passed on the stack. An "unsupported" diagnostic will be emitted by LLVM if that is the case. This commits adds support in Rust for that diagnostic so that an error will be output if that is the case! Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 1aaafac6ffec2556a27a3c34365c685c124ee029

Add support for cmse_nonsecure_entry attribute This patch adds support for the LLVM cmse_nonsecure_entry attribute. This is a target-dependent attribute that only has sense for the thumbv8m Rust targets. You can find more information about this attribute here: https://developer.arm.com/documentation/ecm0359818/latest/ Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 2588287deffd92c4ca0b5b39f92b9cca894a3983

Add more tests and check for ABI Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

bors

commit sha 867bd42c38bac3870388765f65386b18cf1d9c5f

Auto merge of #75810 - hug-dev:cmse-nonsecure-entry, r=jonas-schievink Add support for cmse_nonsecure_entry attribute This pull request adds the `cmse_nonsecure_entry` attribute under an unstable feature. I was not sure if it was fine for me to send directly the pull-request or if I should submit a RFC first. I was told on Zulip that it was fine to do so but please close it if I need first submit a RFC or follow another process instead. The `cmse_nonsecure_entry` attribute is a LLVM attribute that will be available in LLVM 11. I plan to rebase on the [upgrade PR](https://github.com/rust-lang/rust/pull/73526) once merged to make this one compile. This attribute modifies code generation of the function as explained [here](https://developer.arm.com/documentation/ecm0359818/latest/) to make it work with the TrustZone-M hardware feature. This feature is only available on `thumbv8m` targets so I created an error for that if one tries to use this attribute for another target. I added this attribute in Rust as any other LLVM attribute are added but since this one is target-dependent I am not sure if it was the best thing to do. Please indicate me if you think of other ways, like isolating target-dependent attributes together. ---------------- Tracking issue: https://github.com/rust-lang/rust/issues/75835

view details

push time in 3 hours

pull request commentrust-lang/rust

Add support for cmse_nonsecure_entry attribute

:sunny: Test successful - checks-actions, checks-azure Approved by: jonas-schievink Pushing 867bd42c38bac3870388765f65386b18cf1d9c5f to master... <!-- homu: {"type":"BuildCompleted","approved_by":"jonas-schievink","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=36938","checks-actions":"https://github.com/rust-lang-ci/rust/runs/1190032753"},"merge_sha":"867bd42c38bac3870388765f65386b18cf1d9c5f"} -->

hug-dev

comment created time in 3 hours

pull request commentrust-lang/rust

[DO NOT MERGE] Measure cost of per function section

:sunny: Try build successful - checks-actions, checks-azure Build commit: 7aa1ca89673ff9147df9467391cd50b2eb496016 (7aa1ca89673ff9147df9467391cd50b2eb496016) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=36939","checks-actions":"https://github.com/rust-lang-ci/rust/runs/1189774852"},"merge_sha":"7aa1ca89673ff9147df9467391cd50b2eb496016"} -->

bjorn3

comment created time in 4 hours

pull request commentrust-lang/rust

References to ZSTs may be at arbitrary aligned addresses

:pushpin: Commit ce6c25da5887dcdb446b56892ace1d2463a743f3 has been approved by RalfJung

<!-- @bors r=RalfJung ce6c25da5887dcdb446b56892ace1d2463a743f3 --> <!-- homu: {"type":"Approved","sha":"ce6c25da5887dcdb446b56892ace1d2463a743f3","approver":"RalfJung"} -->

oli-obk

comment created time in 5 hours

pull request commentrust-lang/rust

Defer Apple SDKROOT detection to link time.

:pushpin: Commit 7420d7a98044ea1bf727ab369cbc77232dd99694 has been approved by petrochenkov

<!-- @bors r=petrochenkov 7420d7a98044ea1bf727ab369cbc77232dd99694 --> <!-- homu: {"type":"Approved","sha":"7420d7a98044ea1bf727ab369cbc77232dd99694","approver":"petrochenkov"} -->

ehuss

comment created time in 5 hours

push eventrust-lang-ci/rust

bjorn3

commit sha 71f63d0b6899474df633764d7c830bc7999bf11a

[DO NOT MERGE] Measure cost of function section I was experimenting with using per function sections instead of a single `.text` section in cg_clif to see if it reduced binary size. It brings the size down for the test I used from 26MB to 15MB like the output of cg_llvm in debug mode. When I measured the linker time the result was a lot less positive: ~0.4s turned into ~0.7s. That is a 75% slowdown. It would be interesting to know what the cost is for cg_llvm over the full rustc-perf benchmark suite.

view details

Joshua Nelson

commit sha d537067c97531af7f8343f75fafb4d6b9e79eaaf

Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`.

view details

bors

commit sha d92d28e523bf056ab4eb752510ec52fe4f1c6311

Auto merge of #77298 - jyn514:bootstrap-config, r=Mark-Simulacrum Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`. Fixes https://github.com/rust-lang/rust/issues/77293 r? `@Mark-Simulacrum` cc `@davidtwco`

view details

bjorn3

commit sha 6d1124e261b588c3f8b814f2d5886e5263155526

Only enable -ffunction-sections in release mode

view details

bors

commit sha 7aa1ca89673ff9147df9467391cd50b2eb496016

Auto merge of #77051 - bjorn3:patch-3, r=<try> [DO NOT MERGE] Measure cost of per function section I was experimenting with using per function sections instead of a single `.text` section in cg_clif to see if it reduced binary size. It brings the size down for the test I used from 26MB to 15MB like the output of cg_llvm in debug mode. When I measured the linker time the result was a lot less positive: ~0.4s turned into ~0.7s. That is a 75% slowdown. It would be interesting to know what the cost is for cg_llvm over the full rustc-perf benchmark suite. Can someone start a perf run for me?

view details

push time in 5 hours

pull request commentrust-lang/rust

[DO NOT MERGE] Measure cost of per function section

:hourglass: Trying commit 6d1124e261b588c3f8b814f2d5886e5263155526 with merge 7aa1ca89673ff9147df9467391cd50b2eb496016... <!-- homu: {"type":"TryBuildStarted","head_sha":"6d1124e261b588c3f8b814f2d5886e5263155526","merge_sha":"7aa1ca89673ff9147df9467391cd50b2eb496016"} -->

bjorn3

comment created time in 5 hours

pull request commentrust-lang/rust

Remove trailing space in error message

:pushpin: Commit b2ce3e53446173b56607b5a8ad8d9c4b3565d5da has been approved by varkor

<!-- @bors r=varkor b2ce3e53446173b56607b5a8ad8d9c4b3565d5da --> <!-- homu: {"type":"Approved","sha":"b2ce3e53446173b56607b5a8ad8d9c4b3565d5da","approver":"varkor"} -->

camelid

comment created time in 5 hours

pull request commentrust-lang/rust

Rollup of 12 pull requests

:pushpin: Commit 3624a901345c9c384aa9d1e27e21d0c4cd2c85ae has been approved by jonas-schievink

<!-- @bors r=jonas-schievink 3624a901345c9c384aa9d1e27e21d0c4cd2c85ae --> <!-- homu: {"type":"Approved","sha":"3624a901345c9c384aa9d1e27e21d0c4cd2c85ae","approver":"jonas-schievink"} -->

jonas-schievink

comment created time in 5 hours

push eventrust-lang-ci/rust

Hugues de Valon

commit sha d255d70e7a6a84c82cc74f968f529f42dd40b8ce

Update LLVM and add Unsupported diagnostic Secure entry functions do not support if arguments are passed on the stack. An "unsupported" diagnostic will be emitted by LLVM if that is the case. This commits adds support in Rust for that diagnostic so that an error will be output if that is the case! Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 1aaafac6ffec2556a27a3c34365c685c124ee029

Add support for cmse_nonsecure_entry attribute This patch adds support for the LLVM cmse_nonsecure_entry attribute. This is a target-dependent attribute that only has sense for the thumbv8m Rust targets. You can find more information about this attribute here: https://developer.arm.com/documentation/ecm0359818/latest/ Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

Hugues de Valon

commit sha 2588287deffd92c4ca0b5b39f92b9cca894a3983

Add more tests and check for ABI Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

view details

bors

commit sha 867bd42c38bac3870388765f65386b18cf1d9c5f

Auto merge of #75810 - hug-dev:cmse-nonsecure-entry, r=jonas-schievink Add support for cmse_nonsecure_entry attribute This pull request adds the `cmse_nonsecure_entry` attribute under an unstable feature. I was not sure if it was fine for me to send directly the pull-request or if I should submit a RFC first. I was told on Zulip that it was fine to do so but please close it if I need first submit a RFC or follow another process instead. The `cmse_nonsecure_entry` attribute is a LLVM attribute that will be available in LLVM 11. I plan to rebase on the [upgrade PR](https://github.com/rust-lang/rust/pull/73526) once merged to make this one compile. This attribute modifies code generation of the function as explained [here](https://developer.arm.com/documentation/ecm0359818/latest/) to make it work with the TrustZone-M hardware feature. This feature is only available on `thumbv8m` targets so I created an error for that if one tries to use this attribute for another target. I added this attribute in Rust as any other LLVM attribute are added but since this one is target-dependent I am not sure if it was the best thing to do. Please indicate me if you think of other ways, like isolating target-dependent attributes together. ---------------- Tracking issue: https://github.com/rust-lang/rust/issues/75835

view details

push time in 5 hours

pull request commentrust-lang/rust

Add support for cmse_nonsecure_entry attribute

:hourglass: Testing commit 2588287deffd92c4ca0b5b39f92b9cca894a3983 with merge 867bd42c38bac3870388765f65386b18cf1d9c5f... <!-- homu: {"type":"BuildStarted","head_sha":"2588287deffd92c4ca0b5b39f92b9cca894a3983","merge_sha":"867bd42c38bac3870388765f65386b18cf1d9c5f"} -->

hug-dev

comment created time in 5 hours

pull request commentrust-lang/rust

Implement Make `handle_alloc_error` default to panic (for no_std + liballoc)

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/1189511713","builder_name":"checks-actions"} -->

haraldh

comment created time in 5 hours

pull request commentrust-lang/rust

Add support for cmse_nonsecure_entry attribute

:pushpin: Commit 2588287deffd92c4ca0b5b39f92b9cca894a3983 has been approved by jonas-schievink

<!-- @bors r=jonas-schievink 2588287deffd92c4ca0b5b39f92b9cca894a3983 --> <!-- homu: {"type":"Approved","sha":"2588287deffd92c4ca0b5b39f92b9cca894a3983","approver":"jonas-schievink"} -->

hug-dev

comment created time in 6 hours

push eventrust-lang-ci/rust

Harald Hoyer

commit sha 30924f000ddbac2d7632329348599e19659685a9

Implement Make `handle_alloc_error` default to panic (for no_std + liballoc) Related: https://github.com/rust-lang/rust/issues/66741 Guarded with `#![feature(default_alloc_error_handler)]` a default `alloc_error_handler` is called, if a custom allocator is used and no other custom `#[alloc_error_handler]` is defined. The panic message does not contain the size anymore, because it would pull in the fmt machinery, which would blow up the code size significantly.

view details

bors

commit sha 3861fe8470350afeb786bf69e3ed641c3725bd27

Auto merge of #76448 - haraldh:default_alloc_error_handler_reduced, r=Amanieu Implement Make `handle_alloc_error` default to panic (for no_std + liballoc) Related: https://github.com/rust-lang/rust/issues/66741 Guarded with `#![feature(default_alloc_error_handler)]` a default `alloc_error_handler` is called, if a custom allocator is used and no other custom `#[alloc_error_handler]` is defined.

view details

push time in 6 hours

pull request commentrust-lang/rust

Implement Make `handle_alloc_error` default to panic (for no_std + liballoc)

:hourglass: Testing commit 30924f000ddbac2d7632329348599e19659685a9 with merge 3861fe8470350afeb786bf69e3ed641c3725bd27... <!-- homu: {"type":"BuildStarted","head_sha":"30924f000ddbac2d7632329348599e19659685a9","merge_sha":"3861fe8470350afeb786bf69e3ed641c3725bd27"} -->

haraldh

comment created time in 6 hours

pull request commentrust-lang/rust

Rollup of 16 pull requests

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/1189325077","builder_name":"checks-actions"} -->

jonas-schievink

comment created time in 6 hours

push eventrust-lang-ci/rust

Matthias Krüger

commit sha 2ad46acd7fee4e193aff3fd243ca91ca092a42aa

EarlyOtherwiseBranch::run_pass(): don't convert Place to Place (clippy::useless_conversion)

view details

Matthias Krüger

commit sha d7a5c574b1010360fd840f5dfc810f2aa782eac5

use std::mem::take(x) instead of std::mem::replace(x, Default::default()) (clippy::mem_replace_with_default)

view details

kadmin

commit sha 6d0390c7d77852618dc6ce894cdf7e2bef01c2ca

Add regression test

view details

Stein Somers

commit sha 3e485d7cf59dafbc37467c3ef1acc51f26b381d9

BTreeMap: keep an eye out on the size of the main components

view details

Joe Richey

commit sha 37f795697c7d0530deb0c5c94a8f99aab587e2e4

libary: Forward compiler-builtins "mem" feature This fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>

view details

Bastian Kauschke

commit sha db5b70f193dcc08476ec1bef8dc1863d508eea1e

move candidate_from_obligation_no_cache

view details

Wesley Wiser

commit sha 63bb51d3ac3ec015d914e2b0792b4d5aa6e8e4a5

Add unstable book docs for `-Zunsound-mir-opts`

view details

Aaron Hill

commit sha c6107c53d72250d8c1d41f161ce54648bef4d9d2

Don't fire `const_item_mutation` lint on writes through a pointer Fixes #77321

view details

hyd-dev

commit sha a2526b416fb4ca7874fa41a3eb595f456703d486

Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() `assert!` panics on failure, which is not signal-safe.

view details

Vadim Petrochenkov

commit sha 9340ee4380dcc9b81e0afb1ef5518730b064a78a

Ensure that all LLVM components requested by tests are available on CI

view details

Hameer Abbasi

commit sha 2c385040550fb1eb98cf14ace99129f05b1d7b3f

Add test for async/await combined with const-generics.

view details

Ivan Tham

commit sha b141e49d8702fa170953aed388eb1510622db79b

Fix typo in alloc vec comment

view details

Ivan Tham

commit sha f9b625f8e004cebdc79f891dea3fb128ec663151

Alloc vec use imported path mem::ManuallyDrop::new -> ManuallyDrop::new

view details

Eric Huss

commit sha f4d5275cbb87637daba704251c043d2b303e36d6

Update books

view details

Tomasz Miąsko

commit sha 93e3db30e9c3b8fb217743e9d06f37b12dcb8745

liveness: Use Option::None to represent absent live nodes No functional changes intended.

view details

samlich

commit sha 607d30dcfa8c40b91d0073a18c5897eee00a4cda

Add test for issue #74761

view details

varkor

commit sha 609786dbd8b07599a2bc6618c777f859d7a01451

Validate `rustc_args_required_const`

view details

Jonas Schievink

commit sha 5c203266d27178f65099267930e3b5aeb6d7737b

Rollup merge of #76257 - JulianKnodt:i75777, r=Dylan-DPC Add regression test This adds a regression test for #75777, effectively closing it since it is solved on nightly and beta.

view details

Jonas Schievink

commit sha 277da4b3db901c6fb7e963d54228128eb09fb035

Rollup merge of #77037 - matthiaskrgr:cl42ppy, r=Dylan-DPC more tiny clippy cleanups commits stand alone and can be reviewed one by one

view details

Jonas Schievink

commit sha d2f3329f7767b9f801dbf9f014cf94ab4cf1f4fa

Rollup merge of #77233 - ssomers:btree_size_matters, r=Mark-Simulacrum BTreeMap: keep an eye out on the size of the main components r? @Mark-Simulacrum

view details

push time in 7 hours

pull request commentrust-lang/rust

Rollup of 16 pull requests

:hourglass: Testing commit 71e4b21b1f7ac749d17bcbbd18d2f518b81fb0b1 with merge 614d8eb7a357215e07685f5d0118d08ceb77ed24... <!-- homu: {"type":"BuildStarted","head_sha":"71e4b21b1f7ac749d17bcbbd18d2f518b81fb0b1","merge_sha":"614d8eb7a357215e07685f5d0118d08ceb77ed24"} -->

jonas-schievink

comment created time in 7 hours

PR merged rust-lang/hashbrown

fix: Only instantiate RawTable's reserve functions once

...per key-value.

Each of the previous closures would cause an entirely new reserve/resize function to be instantiated. By using this trick (which std uses for iterator adaptors), we always get a single instantiatiation per key (modulo the insert_with_hasher method).

+63 -32

4 comments

1 changed file

Marwes

pr closed time in 7 hours

push eventrust-lang/hashbrown

Markus Westerlind

commit sha b7830cf7b065b41af54fb97f8a72081ac98219b9

fix: Only instantiate RawTable's reserve functions once ...per key-value. Each of the previous closures would cause an entirely new reserve/resize function to be instantiated. By using this trick (which std uses for iterator adaptors), we always get a single instantiatiation per key (modulo the insert_with_hasher method).

view details

Markus Westerlind

commit sha 63832ed4e38ac29c24d6396d91076b0ebf55f8d5

Don't instantiate get functions twice either

view details

Markus Westerlind

commit sha d8463d03efd0fc2b8ccb0b5db135cc7f5b5cd3f7

Address review comments

view details

Markus Westerlind

commit sha 5e11d32570c1e0f708864a0285527dfb5f0ada44

nits

view details

bors

commit sha adf06c2e7f3371ffdbff04388d3894978fdf2bf4

Auto merge of #204 - Marwes:less_ir, r=Amanieu fix: Only instantiate RawTable's reserve functions once ...per key-value. Each of the previous closures would cause an entirely new reserve/resize function to be instantiated. By using this trick (which std uses for iterator adaptors), we always get a single instantiatiation per key (modulo the insert_with_hasher method).

view details

push time in 7 hours

pull request commentrust-lang/hashbrown

fix: Only instantiate RawTable's reserve functions once

:sunny: Test successful - checks-travis Approved by: Amanieu Pushing adf06c2e7f3371ffdbff04388d3894978fdf2bf4 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Amanieu","base_ref":"master","builders":{"checks-travis":"https://travis-ci.com/github/rust-lang/hashbrown/builds/187451555"},"merge_sha":"adf06c2e7f3371ffdbff04388d3894978fdf2bf4"} -->

Marwes

comment created time in 7 hours

push eventrust-lang/rust

Joshua Nelson

commit sha d537067c97531af7f8343f75fafb4d6b9e79eaaf

Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`.

view details

bors

commit sha d92d28e523bf056ab4eb752510ec52fe4f1c6311

Auto merge of #77298 - jyn514:bootstrap-config, r=Mark-Simulacrum Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`. Fixes https://github.com/rust-lang/rust/issues/77293 r? `@Mark-Simulacrum` cc `@davidtwco`

view details

push time in 7 hours

PR merged rust-lang/rust

Don't warn if the config file is somewhere other than `config.toml` A-rustbuild C-bug S-waiting-on-bors merged-by-bors

Previously, config.config was always hardcoded as "config.toml". I thought that it was being overridden with the actual value later, but it turns out flags.config was being completely discarded. This keeps config.config in sync with flags.config.

Fixes https://github.com/rust-lang/rust/issues/77293 r? @Mark-Simulacrum cc @davidtwco

+7 -5

4 comments

1 changed file

jyn514

pr closed time in 7 hours

pull request commentrust-lang/rust

Don't warn if the config file is somewhere other than `config.toml`

:sunny: Test successful - checks-actions, checks-azure Approved by: Mark-Simulacrum Pushing d92d28e523bf056ab4eb752510ec52fe4f1c6311 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Mark-Simulacrum","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=36934","checks-actions":"https://github.com/rust-lang-ci/rust/runs/1189126054"},"merge_sha":"d92d28e523bf056ab4eb752510ec52fe4f1c6311"} -->

jyn514

comment created time in 7 hours

issue closedrust-lang/rust

warning for missing `config.toml` doesn't consider `$RUST_BOOTSTRAP_CONFIG`

If a config.toml is provided via $RUST_BOOTSTRAP_CONFIG, not by having a config.toml in the working directory, then warning: you have not made a 'config.toml' is printed incorrectly.

cc @jyn514

closed time in 7 hours

davidtwco

push eventrust-lang-ci/rust

Joshua Nelson

commit sha d537067c97531af7f8343f75fafb4d6b9e79eaaf

Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`.

view details

bors

commit sha d92d28e523bf056ab4eb752510ec52fe4f1c6311

Auto merge of #77298 - jyn514:bootstrap-config, r=Mark-Simulacrum Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`. Fixes https://github.com/rust-lang/rust/issues/77293 r? `@Mark-Simulacrum` cc `@davidtwco`

view details

push time in 7 hours

push eventrust-lang/hashbrown

Josh Stone

commit sha 20cdb93a347c893b2c941b1da82b1f6ef7820f9e

Add more safe methods to RawTable These methods combine lookup and bucket operations so the caller doesn't have to deal with unsafe bucket methods. - `get`: `find` and `as_ref` - `get_mut`: `find` and `as_mut` - `insert_entry`: `insert` and `as_mut` - `remove_entry`: `find` and `remove` - `erase_entry`: `find` and `erase`

view details

Muhammad Mominul Huque

commit sha 35f7b47c0a75d72a90b657844eec2b2712426495

Add MSRV in the README.md This adds an MSRV badge in the `README.md` similar to the [`regex` project](https://github.com/rust-lang/regex/blob/master/README.md). I got the MSRV from the `CHANGELOG.md`

view details

Amanieu d'Antras

commit sha 298f675147b90dfda842c964755ad5b97622be23

Merge pull request #203 from mominul/patch-1 Add MSRV in the README.md

view details

Amanieu d'Antras

commit sha d2b5aec2f11d7d5301685a4a141ae6e6bb2b9342

Merge pull request #202 from cuviper/safer-raw-access Add more safe methods to RawTable

view details

Amanieu d'Antras

commit sha 34c11891e13fa3c0d08b0540e869aace9d347c26

Version 0.9.1

view details

Markus Westerlind

commit sha b7830cf7b065b41af54fb97f8a72081ac98219b9

fix: Only instantiate RawTable's reserve functions once ...per key-value. Each of the previous closures would cause an entirely new reserve/resize function to be instantiated. By using this trick (which std uses for iterator adaptors), we always get a single instantiatiation per key (modulo the insert_with_hasher method).

view details

Markus Westerlind

commit sha 63832ed4e38ac29c24d6396d91076b0ebf55f8d5

Don't instantiate get functions twice either

view details

Markus Westerlind

commit sha d8463d03efd0fc2b8ccb0b5db135cc7f5b5cd3f7

Address review comments

view details

Markus Westerlind

commit sha 5e11d32570c1e0f708864a0285527dfb5f0ada44

nits

view details

bors

commit sha adf06c2e7f3371ffdbff04388d3894978fdf2bf4

Auto merge of #204 - Marwes:less_ir, r=Amanieu fix: Only instantiate RawTable's reserve functions once ...per key-value. Each of the previous closures would cause an entirely new reserve/resize function to be instantiated. By using this trick (which std uses for iterator adaptors), we always get a single instantiatiation per key (modulo the insert_with_hasher method).

view details

push time in 7 hours

pull request commentrust-lang/hashbrown

fix: Only instantiate RawTable's reserve functions once

:hourglass: Testing commit 5e11d32570c1e0f708864a0285527dfb5f0ada44 with merge adf06c2e7f3371ffdbff04388d3894978fdf2bf4... <!-- homu: {"type":"BuildStarted","head_sha":"5e11d32570c1e0f708864a0285527dfb5f0ada44","merge_sha":"adf06c2e7f3371ffdbff04388d3894978fdf2bf4"} -->

Marwes

comment created time in 7 hours

pull request commentrust-lang/hashbrown

fix: Only instantiate RawTable's reserve functions once

:pushpin: Commit 5e11d32570c1e0f708864a0285527dfb5f0ada44 has been approved by Amanieu

<!-- @bors r=Amanieu 5e11d32570c1e0f708864a0285527dfb5f0ada44 --> <!-- homu: {"type":"Approved","sha":"5e11d32570c1e0f708864a0285527dfb5f0ada44","approver":"Amanieu"} -->

Marwes

comment created time in 7 hours

pull request commentrust-lang/rust

Implement Make `handle_alloc_error` default to panic (for no_std + liballoc)

:pushpin: Commit 30924f000ddbac2d7632329348599e19659685a9 has been approved by Amanieu

<!-- @bors r=Amanieu 30924f000ddbac2d7632329348599e19659685a9 --> <!-- homu: {"type":"Approved","sha":"30924f000ddbac2d7632329348599e19659685a9","approver":"Amanieu"} -->

haraldh

comment created time in 7 hours

push eventrust-lang-ci/rust

Tomasz Miąsko

commit sha 924e8aaaf21653ffb1775a0ed9be219ee377370b

Liveness analysis for everybody Perform liveness analysis for every body instead of limiting it to fns.

view details

bors

commit sha 939cc3e445db1eaf8b3834984e274f8c2267d9c5

Auto merge of #77281 - tmiasko:liveness-everybody, r=oli-obk Liveness analysis for everybody Perform liveness analysis for every body instead of limiting it to fns. Fixes #77169.

view details

Jonas Schievink

commit sha 36365b35ee72d8cfde7949f55517832878a754c0

validate: storage must be allocated on local use

view details

bors

commit sha d952cf6887b310e5009157bddd5894b5f54cb31b

Auto merge of #77369 - jonas-schievink:validate-storage-liveness, r=<try> validate: storage must be allocated on local use This extends the MIR validator to check that locals are only used when their backing storage is currently allocated via `StorageLive`. The result of this is that miscompilations such as https://github.com/rust-lang/rust/issues/77359 are caught and turned into ICEs. The PR currently fails tests because miscompilations such as https://github.com/rust-lang/rust/issues/77359 are caught and turned into ICEs. I have confirmed that tests pass (even with `-Zvalidate-mir`) once `SimplifyArmIdentity` is turned into a no-op (except mir-opt tests, of course).

view details

push time in 7 hours

pull request commentrust-lang/rust

validate: storage must be allocated on local use

:hourglass: Trying commit 36365b35ee72d8cfde7949f55517832878a754c0 with merge d952cf6887b310e5009157bddd5894b5f54cb31b... <!-- homu: {"type":"TryBuildStarted","head_sha":"36365b35ee72d8cfde7949f55517832878a754c0","merge_sha":"d952cf6887b310e5009157bddd5894b5f54cb31b"} -->

jonas-schievink

comment created time in 7 hours

push eventrust-lang/crates.io

Tobias Bieniek

commit sha 71888c7abd67c8fe300e177c9406d9fb2b48b891

Use `fill: currentColor` in `flag` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha c8ca9fcd658c3c64ed6151e85be951545e724d33

Use `fill: currentColor` in `button-download` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha 58a7ba3feb321e59649fd99601294d23881e6cc7

Use `fill: currentColor` in `copy` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha cb03d16b5e264ce17d5c0a7f2748a2e8111b7f24

Use `fill: currentColor` in `download-clear-back` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha d53537a191a5d603e26ab3955afd587abb4cf5b6

Merge identical `download-clear-back` and `button-download` icons

view details

Tobias Bieniek

commit sha 0107d9010b9e0dc0c3323119606e0031af836f43

Use `fill: currentColor` in `sort` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

bors

commit sha 971814e0cc680db96830483bd1ed4c47f1c02f22

Auto merge of #2847 - Turbo87:icons, r=locks Use more `fill="currentColor"` in our SVG icons similar to https://github.com/rust-lang/crates.io/pull/2842 r? `@locks`

view details

push time in 7 hours

PR merged rust-lang/crates.io

Use more `fill="currentColor"` in our SVG icons A-frontend S-waiting-on-review

similar to https://github.com/rust-lang/crates.io/pull/2842

r? @locks

+54 -53

8 comments

16 changed files

Turbo87

pr closed time in 7 hours

pull request commentrust-lang/crates.io

Use more `fill="currentColor"` in our SVG icons

:sunny: Test successful - checks-travis Approved by: locks Pushing 971814e0cc680db96830483bd1ed4c47f1c02f22 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"locks","base_ref":"master","builders":{"checks-travis":"https://travis-ci.com/github/rust-lang/crates.io/builds/187447418"},"merge_sha":"971814e0cc680db96830483bd1ed4c47f1c02f22"} -->

Turbo87

comment created time in 7 hours

pull request commentrust-lang/crates.io

Update dependency ember-router-scroll to v3

:umbrella: The latest upstream changes (presumably #2849) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
renovate[bot]

comment created time in 8 hours

push eventrust-lang/crates.io

Tobias Bieniek

commit sha 71888c7abd67c8fe300e177c9406d9fb2b48b891

Use `fill: currentColor` in `flag` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha c8ca9fcd658c3c64ed6151e85be951545e724d33

Use `fill: currentColor` in `button-download` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha 58a7ba3feb321e59649fd99601294d23881e6cc7

Use `fill: currentColor` in `copy` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha cb03d16b5e264ce17d5c0a7f2748a2e8111b7f24

Use `fill: currentColor` in `download-clear-back` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

Tobias Bieniek

commit sha d53537a191a5d603e26ab3955afd587abb4cf5b6

Merge identical `download-clear-back` and `button-download` icons

view details

Tobias Bieniek

commit sha 0107d9010b9e0dc0c3323119606e0031af836f43

Use `fill: currentColor` in `sort` icon This makes the icon better reusable and makes it easier to introduce e.g. hover states

view details

bors

commit sha 971814e0cc680db96830483bd1ed4c47f1c02f22

Auto merge of #2847 - Turbo87:icons, r=locks Use more `fill="currentColor"` in our SVG icons similar to https://github.com/rust-lang/crates.io/pull/2842 r? `@locks`

view details

push time in 8 hours

pull request commentrust-lang/crates.io

Use more `fill="currentColor"` in our SVG icons

:hourglass: Testing commit 0107d9010b9e0dc0c3323119606e0031af836f43 with merge 971814e0cc680db96830483bd1ed4c47f1c02f22... <!-- homu: {"type":"BuildStarted","head_sha":"0107d9010b9e0dc0c3323119606e0031af836f43","merge_sha":"971814e0cc680db96830483bd1ed4c47f1c02f22"} -->

Turbo87

comment created time in 8 hours

PR merged rust-lang/crates.io

Update dependency ember-source to v3.21.2 S-waiting-on-review

This PR contains the following updates:

Package Type Update Change
ember-source (source) devDependencies patch 3.21.1 -> 3.21.2

Release Notes

<details> <summary>emberjs/ember.js</summary>

v3.21.2

Compare Source

  • #​19138 [BUGFIX] Fix tag cycles in query parameters
  • #​19164 [BUGFIX] Entangles custom EmberArray implementations when accessed with Ember.get

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

5 comments

2 changed files

renovate[bot]

pr closed time in 8 hours

push eventrust-lang/crates.io

Renovate Bot

commit sha 68496fefdbd7f001aeb87a6c05a8462736cc4268

Update dependency ember-source to v3.21.2

view details

bors

commit sha 5193118ac0366c8a239fa699d1cb0b304496ef79

Auto merge of #2849 - rust-lang:renovate/ember-source-3.21.x, r=Turbo87 Update dependency ember-source to v3.21.2 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ember-source](https://emberjs.com/) ([source](https://togithub.com/emberjs/ember.js)) | devDependencies | patch | [`3.21.1` -> `3.21.2`](https://renovatebot.com/diffs/npm/ember-source/3.21.1/3.21.2) | --- ### Release Notes <details> <summary>emberjs/ember.js</summary> ### [`v3.21.2`](https://togithub.com/emberjs/ember.js/blob/master/CHANGELOG.md#v3212-September-30-2020) [Compare Source](https://togithub.com/emberjs/ember.js/compare/v3.21.1...v3.21.2) - [#&#8203;19138](https://togithub.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters - [#&#8203;19164](https://togithub.com/emberjs/ember.js/pull/19164) [BUGFIX] Entangles custom EmberArray implementations when accessed with `Ember.get` </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

view details

push time in 8 hours

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.2

:sunny: Test successful - checks-travis Approved by: Turbo87 Pushing 5193118ac0366c8a239fa699d1cb0b304496ef79 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Turbo87","base_ref":"master","builders":{"checks-travis":"https://travis-ci.com/github/rust-lang/crates.io/builds/187444990"},"merge_sha":"5193118ac0366c8a239fa699d1cb0b304496ef79"} -->

renovate[bot]

comment created time in 8 hours

pull request commentrust-lang/crates.io

Use more `fill="currentColor"` in our SVG icons

:pushpin: Commit 0107d9010b9e0dc0c3323119606e0031af836f43 has been approved by locks

<!-- @bors r=locks 0107d9010b9e0dc0c3323119606e0031af836f43 --> <!-- homu: {"type":"Approved","sha":"0107d9010b9e0dc0c3323119606e0031af836f43","approver":"locks"} -->

Turbo87

comment created time in 8 hours

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.2

:hourglass: Testing commit 68496fefdbd7f001aeb87a6c05a8462736cc4268 with merge 5193118ac0366c8a239fa699d1cb0b304496ef79... <!-- homu: {"type":"BuildStarted","head_sha":"68496fefdbd7f001aeb87a6c05a8462736cc4268","merge_sha":"5193118ac0366c8a239fa699d1cb0b304496ef79"} -->

renovate[bot]

comment created time in 8 hours

push eventrust-lang/crates.io

Renovate Bot

commit sha 68496fefdbd7f001aeb87a6c05a8462736cc4268

Update dependency ember-source to v3.21.2

view details

bors

commit sha 5193118ac0366c8a239fa699d1cb0b304496ef79

Auto merge of #2849 - rust-lang:renovate/ember-source-3.21.x, r=Turbo87 Update dependency ember-source to v3.21.2 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ember-source](https://emberjs.com/) ([source](https://togithub.com/emberjs/ember.js)) | devDependencies | patch | [`3.21.1` -> `3.21.2`](https://renovatebot.com/diffs/npm/ember-source/3.21.1/3.21.2) | --- ### Release Notes <details> <summary>emberjs/ember.js</summary> ### [`v3.21.2`](https://togithub.com/emberjs/ember.js/blob/master/CHANGELOG.md#v3212-September-30-2020) [Compare Source](https://togithub.com/emberjs/ember.js/compare/v3.21.1...v3.21.2) - [#&#8203;19138](https://togithub.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters - [#&#8203;19164](https://togithub.com/emberjs/ember.js/pull/19164) [BUGFIX] Entangles custom EmberArray implementations when accessed with `Ember.get` </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

view details

push time in 8 hours

pull request commentrust-lang/crates.io

Update dependency ember-source to v3.21.2

:pushpin: Commit 68496fefdbd7f001aeb87a6c05a8462736cc4268 has been approved by Turbo87

<!-- @bors r=Turbo87 68496fefdbd7f001aeb87a6c05a8462736cc4268 --> <!-- homu: {"type":"Approved","sha":"68496fefdbd7f001aeb87a6c05a8462736cc4268","approver":"Turbo87"} -->

renovate[bot]

comment created time in 8 hours

pull request commentrust-lang/rust

Rollup of 16 pull requests

:pushpin: Commit 71e4b21b1f7ac749d17bcbbd18d2f518b81fb0b1 has been approved by jonas-schievink

<!-- @bors r=jonas-schievink 71e4b21b1f7ac749d17bcbbd18d2f518b81fb0b1 --> <!-- homu: {"type":"Approved","sha":"71e4b21b1f7ac749d17bcbbd18d2f518b81fb0b1","approver":"jonas-schievink"} -->

jonas-schievink

comment created time in 8 hours

pull request commentrust-lang/rust

Rollup of 11 pull requests

:pushpin: Commit 8e35ff0bd775158073a1c77a42388b8fa36a2f74 has been approved by Dylan-DPC

<!-- @bors r=Dylan-DPC 8e35ff0bd775158073a1c77a42388b8fa36a2f74 --> <!-- homu: {"type":"Approved","sha":"8e35ff0bd775158073a1c77a42388b8fa36a2f74","approver":"Dylan-DPC"} -->

Dylan-DPC

comment created time in 8 hours

pull request commentrust-lang/rust

Rollup of 9 pull requests

:umbrella: The latest upstream changes (presumably #77281) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
Dylan-DPC

comment created time in 9 hours

PR merged rust-lang/rust

Liveness analysis for everybody S-waiting-on-bors merged-by-bors

Perform liveness analysis for every body instead of limiting it to fns.

Fixes #77169.

+174 -42

12 comments

8 changed files

tmiasko

pr closed time in 9 hours

pull request commentrust-lang/rust

Don't warn if the config file is somewhere other than `config.toml`

:hourglass: Testing commit d537067c97531af7f8343f75fafb4d6b9e79eaaf with merge d92d28e523bf056ab4eb752510ec52fe4f1c6311... <!-- homu: {"type":"BuildStarted","head_sha":"d537067c97531af7f8343f75fafb4d6b9e79eaaf","merge_sha":"d92d28e523bf056ab4eb752510ec52fe4f1c6311"} -->

jyn514

comment created time in 9 hours

push eventrust-lang-ci/rust

Joshua Nelson

commit sha d537067c97531af7f8343f75fafb4d6b9e79eaaf

Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`.

view details

bors

commit sha d92d28e523bf056ab4eb752510ec52fe4f1c6311

Auto merge of #77298 - jyn514:bootstrap-config, r=Mark-Simulacrum Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`. Fixes https://github.com/rust-lang/rust/issues/77293 r? `@Mark-Simulacrum` cc `@davidtwco`

view details

push time in 9 hours

more