profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/camelid/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Noah Lev camelid Rust compiler contributor and compiler enthusiast.

camelid/rust 1

Empowering everyone to build reliable and efficient software.

camelid/backtrace-rs 0

Backtraces in Rust

camelid/blog.rust-lang.org 0

The Rust Programming Language Blog

camelid/blog.servo.org 0

The Servo blog

camelid/browser-compat-data 0

This repository contains compatibility data for Web technologies as displayed on MDN

camelid/cargo 0

The Rust package manager

camelid/cargo-bisect-rustc 0

Bisects rustc, either nightlies or CI artifacts

camelid/chalk 0

An implementation and definition of the Rust trait system using a PROLOG-like logic solver

camelid/colophon 0

Scrape open-access articles, filter to a particular topic, and import to your library's catalog.

camelid/crates.io 0

Source code for crates.io

push eventcamelid/rust-clippy

bors

commit sha fb27517e01e34acf21bbf6273822169f54a53987

Auto merge of #6878 - flip1995:authors, r=Manishearth Set Clippy authors to "The Rust Clippy Developers" Clippy has grown enough, that putting specific people in the "authors" field isn't warranted anymore. As a heads-up: `@Manishearth` `@llogiq` `@birkenfeld` `@mcarton` `@oli-obk` `@phansch` `@matthiaskrgr` your names will be removed from one or more of the `Cargo.toml` files of Clippy. This of course does not mean that we value your previous work on Clippy any less :heart: As per our discussion in today's meeting: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Meeting.202021-03-09/near/229502514 changelog: none

view details

bstrie

commit sha 7406c12885b9ecc55755178e79eedd065a46229f

Deprecate items that accidentally weren't deprecated Fixes #82080

view details

bors

commit sha 36a27ecaacad74f69b21a12bc66b826f11f2d44e

Auto merge of #79519 - cjgillot:noattr, r=wesleywiser Store HIR attributes in a side table Same idea as #72015 but for attributes. The objective is to reduce incr-comp invalidations due to modified attributes. Notably, those due to modified doc comments. Implementation: - collect attributes during AST->HIR lowering, in `LocalDefId -> ItemLocalId -> &[Attributes]` nested tables; - access the attributes through a `hir_owner_attrs` query; - local refactorings to use this access; - remove `attrs` from HIR data structures one-by-one. Change in behaviour: - the HIR visitor traverses all attributes at once instead of parent-by-parent; - attribute arrays are sometimes duplicated: for statements and variant constructors; - as a consequence, attributes are marked as used after unused-attribute lint emission to avoid duplicate lints. ~~Current bug: the lint level is not correctly applied in `std::backtrace_rs`, triggering an unused attribute warning on `#![no_std]`. I welcome suggestions.~~

view details

bors

commit sha a1e25a957ed616e2ed4deae80967925bb25554af

Auto merge of #6794 - camsteffen:needless-borrowed-ref, r=flip1995 Improve needless_borrowed_ref docs changelog: none I think "borrowed ref" is a confusing description for this lint. Destructuring a reference is the opposite of borrowing. So I updated the wording throughout the docs. Unfortunately this nit applies to the name of the lint itself, but I won't bother changing that. One motivation for these changes is to clarify the difference between this lint and `needless_borrow` (they are actually quite different). Let me know if I need to clarify anything or if you disagree with any changes.

view details

bors

commit sha 8222d48cde5e01edb9b7ecacf964abc843f8a8cc

Auto merge of #6814 - hyd-dev:issue-6486, r=flip1995 Fix false positives on procedural macros of `missing_inline_in_public_items` lint Fixes #6486. changelog: Fix false positives on procedural macros of `missing_inline_in_public_items` lint.

view details

flip1995

commit sha 78c740e2f38c64db96124ed62c2c51dee5de9b70

Merge remote-tracking branch 'upstream/master' into rustup

view details

flip1995

commit sha ae6be4f36182722e7a3b021868ee913f1a97200e

Bump nightly version => 2021-03-11

view details

flip1995

commit sha 9c1dd0c22721029dc47e5fe73d85670abab9adfc

Fix remaining dogfood errors (internal lints)

view details

bors

commit sha 99afc6e6ac2ce874c4fed32c083f1e160f533015

Auto merge of #6881 - flip1995:rustup, r=flip1995 Rustup changelog: none

view details

Takayuki Maeda

commit sha f0f07accbce24adb5706eeb4e14e0e1c6b2b973b

move expect_used, filter_next, get_unwrap, ok_expect and unwrap_used to their own modules

view details

Takayuki Maeda

commit sha 483bac2dc0a47df87141a98df1d470b25cd2eda3

move skip_while_next to its own module

view details

Takayuki Maeda

commit sha 110dac7f58257a0186daf13688aa8b02fba67bdb

move option_as_ref_deref to its own module

view details

Takayuki Maeda

commit sha 60a053725e5c5c3a78e3d0918ca00e9e98324a95

move suspicious_map to its own module

view details

Takayuki Maeda

commit sha 8623b331eebfa097bb33dff1df5efa324e6a780a

move filetype_is_file to its own module

view details

Takayuki Maeda

commit sha 35147d4cf342ee479d50afcb70aceab4ea506c2d

move uninit_assumed_init to its own module

view details

Takayuki Maeda

commit sha 45ee914df0c1d1a6a15272bd6833023dd4185b9b

move iter_cloned_collect to its own module

view details

Takayuki Maeda

commit sha 6376da70be18d6cb9dbe22b5a661896cf916bc51

replace `lints` and `lint` with `check`

view details

Takayuki Maeda

commit sha 9b0a42b67d66cb79bdd09379d0b0e7959fc1505a

move zst_offset to its own module

view details

Takayuki Maeda

commit sha db91d9cf9a620cc258ab84a152a9333351ac166e

move map_collect_result_unit to its own module

view details

Takayuki Maeda

commit sha 3fe099ba8d2f6f4d085e7480f020f9f87e6b39e8

move iter_next_slice to its own module

view details

push time in 3 days

issue openedrust-lang/rust

Parser incorrectly suggests adding semicolon after function in impl

This also ICEs, but that's a separate issue: #87635. The MCVE here is also from that issue.

I think this issue is also caused by #87436, based on looking at the changes in the test output from that PR. That PR seems to have changed the parser to emit an expected `;`, found ... error regardless of what token was actually expected.

Code

Playground

struct Foo {}

impl Foo {
    pub fn bar()
}

fn main() {}

Nightly error

error: expected `;`, found `}`
 --> src/main.rs:4:17
  |
4 |     pub fn bar()
  |                 ^ help: add `;` here
5 | }
  | - unexpected token

thread 'rustc' panicked at 'internal error: entered unreachable code', compiler/rustc_parse/src/parser/item.rs:1723:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.56.0-nightly (492723897 2021-07-29) running on x86_64-unknown-linux-gnu

note: compiler flags: -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --crate-type bin

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
end of query stack
error: could not compile `playground` due to previous error

Beta error

error: expected one of `->`, `;`, `where`, or `{`, found `}`
 --> src/main.rs:5:1
  |
4 |     pub fn bar()
  |            ---  - expected one of `->`, `;`, `where`, or `{`
  |            |
  |            while parsing this `fn`
5 | }
  | ^ unexpected token

error: associated function in `impl` without body
 --> src/main.rs:4:5
  |
4 |     pub fn bar()
  |     ^^^^^^^^^^^-
  |                |
  |                help: provide a definition for the function: `{ <body> }`

error: could not compile `playground` due to 2 previous errors

Meta

Regressed in nightly 1.56.0.

created time in 3 days

delete branch camelid/rust-forge

delete branch : update-triage-blocked-inactive

delete time in 4 days

issue openedrust-lang/rust

rustdoc: Section icon covers part of enum variant name when hovered

This is a regression from 1.53.0 to 1.54.0. It's likely that the display of other parts of the docs has regressed in a similar way as well (e.g., struct fields), but I haven't checked those.

More broadly, the way the variant looks when hovered has changed as well. I am unsure if that part of the change was intentional; to me it seems like a regression.

1.54.0 (incorrect)

image

1.53.0 (correct)

image

created time in 4 days

pull request commentrust-lang/rust

Add doctests for HashMap's into_values and into_keys methods

Should this PR be marked as closing #87591?

ccqpein

comment created time in 4 days

pull request commentrust-lang/rust

Use more precise span for E0282 in cast expressions

r? @davidtwco

FabianWolff

comment created time in 4 days

pull request commentrust-lang/rust

Remove unnecessary trailing whitespace from error messages

r? @JohnTitor

@FabianWolff: could you fix the merge conflicts? Once you've fixed them, you should be able to mark your PR as ready for review with @rustbot ready. Thanks!

@rustbot author

FabianWolff

comment created time in 4 days

push eventcamelid/rust-team

Oli Scherer

commit sha 682b92bb712ee80303df482971bbffa34697cabc

Add @fee1-dead to wg-const-eval They are working on const_trait_impl

view details

Pietro Albini

commit sha a736c6904860b42e7d5b4557eabdddf983688379

Merge pull request #609 from oli-obk/patch-2 Add @fee1-dead to wg-const-eval

view details

push time in 4 days

pull request commentrust-lang/rust-forge

Update Triage Procedure from deletion of S-blocked-closed and S-inactive-closed

@pietroalbini could you merge this PR? Thanks!

camelid

comment created time in 4 days

push eventcamelid/rust

Jon Gjengset

commit sha 3b2b5b2914d40aa011d189bfe546084cdee53dbe

Remove P: Unpin bound on impl Future for Pin The `Unpin` bound was originally added in #56939 following the recommendation of @withoutboats in https://github.com/rust-lang/rust/issues/55766#issue-378417538 That comment does not give explicit justification for why the bound should be added. The relevant context was: > [ ] Remove `impl<P> Unpin for Pin<P>` > > This impl is not justified by our standard justification for unpin > impls: there is no pointer direction between `Pin<P>` and `P`. Its > usefulness is covered by the impls for pointers themselves. > > This futures impl (link to the impl changed in this PR) will need to > change to add a `P: Unpin` bound. The decision to remove the unconditional impl of `Unpin for Pin` is sound (these days there is just an auto-impl for when `P: Unpin`). But, I think the decision to also add the `Unpin` bound for `impl Future` may have been unnecessary. Or if that's not the case, I'd be very interested to have the argument for why written down somewhere. The bound _appears_ to not be needed, since the presence of a `Pin<P>` should indicate that it's safe to project to `Pin<&mut P::Target>` just like for `Pin::as_mut`.

view details

Jon Gjengset

commit sha ac658e106653a5aa048eec158b66c9e0485b952b

Merge branch 'master' into no-unpin-in-pin-future-impl

view details

Jon Gjengset

commit sha b5e5a182caa6efb7359978a6ff596f403cb4c099

Update library/core/src/pin.rs Co-authored-by: Ralf Jung <post@ralfj.de>

view details

Jon Gjengset

commit sha cf402921222bd6b3152c6ed55c7039887d12a4c0

Link tracking issue for pin_deref_mut

view details

Thomas Otto

commit sha e8f57c3ac4d57988e610ef6645d867ea76e8f25d

No longer suggest inserting or appending an underscore changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names

view details

xFrednet

commit sha 2ac21889bcc0634eabd1ff36491042fd0dae003f

Use diagnostic items for `BinaryHeap`, `BTreeMap`, `BTreeSet`, `HashMap`, `HashSet`, `Borrow`, `Default`

view details

xFrednet

commit sha 6030428fd22912afeeaecfcc0220e979c2ffeb0a

Use diagnostic items for `Into`, `IntoIterator`, `LinkedList`, `ptr::null`, `prt::null_mut`

view details

xFrednet

commit sha 6ce6b29527f05e2b0fa09009053d5095f4d38aa1

Use diagnostic items for `intrinsics::transmute`, `TryInto`

view details

xFrednet

commit sha ecf85f4bdc319f9d9d853d1fff68a8a25e64c7a8

Use diagnostic items for `Vec`, `VecDeque` and connected refactorings

view details

Michael Howell

commit sha f882c363e2ff2ab7b0a3cf8e95b88e0909e68230

fix(clippy): add missing allow(dyn_drop)

view details

flip1995

commit sha 884ef4c287480704e0176930347563410eb8907f

Merge commit '4c41a222ca5d1325fb4b6709395bd06e766cc042' into clippyup

view details

bors

commit sha 610381455cb78a31695b94bc45ee580cf0cd7b38

Auto merge of #7221 - th1000s:keyword_, r=giraffate similar_names: No longer suggest inserting or appending an underscore changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names

view details

Richard Cobbe

commit sha 9b7521314705fdfcc3f459a2f7d09090ad39b05c

Add docs for raw-dylib to unstable book

view details

F3real

commit sha 24ec35a90433b40fcca4272dce27c107f7be51d9

Enhance needless continue to detect loop {continue;}

view details

Richard Cobbe

commit sha 3061b9bda8ac136396d5f938ed05e0d25a16e0f0

Ignore example in automation

view details

Richard Cobbe

commit sha 8e84e4d8e1af2e87e37156b28020e110714e1a29

Fix ignore annotation

view details

inquisitivecrystal

commit sha e7fe2dfef253c462699783e7b2b297827f7440a7

Use hashbrown's `extend_reserve()` in `HashMap`

view details

F3real

commit sha 9d6127cdb0bead8f3a19440e9029edc9bf2e9a25

Emit needless_continue warning if loop ends on continue

view details

F3real

commit sha c3452f3bd261e029b361c94ba8ed3bb909fde5fb

Lint on continue expression without semi-colon

view details

Camelid

commit sha c3a03ae5b715cdfd4739a530c1b8adde0bb3360a

Combine two loops in `check_match` Suggested by Nadrieril in https://github.com/rust-lang/rust/pull/79051#discussion_r548778186.

view details

push time in 4 days

Pull request review commentrust-lang/rust

Fix ICE in `improper_ctypes_definitions` lint with all-ZST transparent types

 impl<'a, 'tcx> ImproperCTypesVisitor<'a, 'tcx> {         use FfiResult::*;          if def.repr.transparent() {-            // Can assume that only one field is not a ZST, so only check+            // Can assume that at most one field is not a ZST, so only check             // that field's type for FFI-safety.             if let Some(field) = transparent_newtype_field(self.cx.tcx, variant) {                 self.check_field_type_for_ffi(cache, field, substs)             } else {-                bug!("malformed transparent type");+                // All fields are ZSTs+                FfiSafe

I'm not sure if this is the correct behavior; in the implementation I had started, I initially went with FfiSafe but then switched to FfiUnsafe. The reason is that according to the issue where the new behavior was discussed (https://github.com/rust-lang/rust/issues/77841#issuecomment-716575747) [emphasis mine],

That's a good point. So here is a proposed set of rules:

  • A repr(transparent) type T must meet the following rules:

    • It may have any number of 1-ZST fields
    • In addition, it may have at most one other field of type U

If that other field is present, then T behaves like type U for ABI purposes. Otherwise, T consists only of 1-ZST types, and it behaves like (), which is the "canonical" 1-ZST.

and () is currently FFI-unsafe:

warning: `extern` block uses type `()`, which is not FFI-safe
 --> src/lib.rs:2:18
  |
2 |     fn good17(p: ());
  |                  ^^ not FFI-safe
  |
  = note: `#[warn(improper_ctypes)]` on by default
  = help: consider using a struct instead
  = note: tuples have unspecified layout

There's also this later comment in that thread (https://github.com/rust-lang/rust/issues/77841#issuecomment-716698421):

Hmm, the lint considers () an improper_ctype. But then an empty struct is UB(!?) in C, so I guess there isn't a canonical ABI for this.

FabianWolff

comment created time in 4 days

Pull request review commentrust-lang/rust

Fix ICE in `improper_ctypes_definitions` lint with all-ZST transparent types

+// Regression test for the ICE described in #87496.++// check-pass

Hmm, for some reason there doesn't seem to be a .stderr file being generated? Yet CI is passing...

FabianWolff

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch camelid/rust

delete branch : check_match-combine-loop

delete time in 6 days

push eventcamelid/rust

Joshua Nelson

commit sha 23bbd65d968ef385fa7a7cd90ea8252bd78081b1

Remove unstable `--pretty` flag It doesn't do anything `--unpretty` doesn't, and due to a bug, also didn't show up in `--help`. I don't think there's any reason to keep it around, I haven't seen anyone using it.

view details

marcusdunn

commit sha ef65e091dbf4063c019d3429789f3a0d0c73d098

added unstable-book entry for bindings_after_at

view details

marcusdunn

commit sha 2d74cd255d599436675b2f67ad3ad1956dc9f02a

made doc entry more consistant with others

view details

marcusdunn

commit sha 751ddb7eb2d585c39d4461a333c9b3408114fcfa

updated the feature-gate listing

view details

marcusdunn

commit sha b908905b3defa075d08661dc5916219a870b4856

changeded bindings_after_at from active to accepted

view details

marcusdunn

commit sha a32d2b43a2ac802a3fc4c601e07828a4eace89a8

removed uses of feature gate

view details

marcusdunn

commit sha 21dee3cbf843d1d897da6ace5143f5a14d475dbe

removed conditional check on bindings_after_at and resulting dead code

view details

marcusdunn

commit sha a49a6827afeaaeca48f36d1fd0ac4c07de053602

removed more uses of feature gate

view details

marcusdunn

commit sha a11c8e7ff348fa5747b7a06390d95254627f8e0e

replaced feature-gate use with cfg_attr

view details

marcusdunn

commit sha 2d82b4a2b7ea6612b937dc4457f73409cd967e5d

removed entry for bindings after at in unstable book

view details

marcusdunn

commit sha 43d8854b560d4ad6750c2057e922f20b47221b8b

removed unneeded brackets on import

view details

marcusdunn

commit sha efc5714e59608b6f9f50481aca41a3ffa6160ea4

updated line #'s on ui tests and removed feature flag test

view details

marcusdunn

commit sha 5f9e33f680a4e8caac9f02bb0908d031a2dbaca0

removed ref to bindings_after_at

view details

marcusdunn

commit sha c2af4cb9a3ce0c6a5ea9c52ac8988715842db4d7

added back bindings_after_at as a cfg_attr

view details

Erin Power

commit sha b0897ff2ee8346def3414c588fb7ae140efe0208

Update RELEASES.md for 1.54.0

view details

XAMPPRocky

commit sha 6d4161bb16c9333212bbd137db4d9a59d2f9aef4

Update RELEASES.md Co-authored-by: Michael <5672750+mibac138@users.noreply.github.com>

view details

XAMPPRocky

commit sha 283080ee9c418b2f4af67cb18f574286f3d402d2

Update RELEASES.md Co-authored-by: Joshua Nelson <jyn514@gmail.com>

view details

XAMPPRocky

commit sha 2c489be26e52221ee60b95cf1da7e85265460cec

Update RELEASES.md Co-authored-by: Jeff Parsons <jeff@parsons.io>

view details

XAMPPRocky

commit sha 3b16b6ee3c6c1d9e3c2430ca997a9f6fe195aefd

Update RELEASES.md

view details

Esteban Küber

commit sha 8ea53624c9a2c4aa6bd207dd25b8d2b19610c99f

Avoid ICE on type error recovery Fix #86756

view details

push time in 6 days

issue commentrust-lang/rust

ICE: compiler/rustc_lint/src/types.rs:859:17: malformed transparent type

Hmm, I don't think this is actually a regression. The MCVE trigger an error on stable and beta:

error[E0690]: transparent struct needs exactly one non-zero-sized field, but has 0
 --> src/lib.rs:2:1
  |
2 | struct TransparentCustomZst(());
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ needs exactly one non-zero-sized field, but has 0

error: aborting due to previous error

and it seems like the requirements for repr(transparent) were relaxed by #86279 such that this code should compile successfully on nightly.

chengniansun

comment created time in 6 days

issue commentrust-lang/triagebot

The first time that a PR receives the "waiting-on-author" label, leave a comment explaining how the author can use rustbot to change the label back to "waiting-on-review"

We can also have triagebot add a status to the github checks (e.g., like github actions) when the work is waiting on author as failing/pending. I don't think we should leave a comment which generates notifications and increases likelihood for "N hidden items" in github, but am open to alternatives.

Hmm, it seems confusing to me to use CI to communicate things other than the status of the code itself.

bstrie

comment created time in 7 days

delete branch camelid/rust

delete branch : flatten-nested-format

delete time in 7 days

delete branch camelid/rust

delete branch : rm-union-structhead

delete time in 7 days

pull request commentrust-lang/rust

feature gate `doc(primitive)`

Given that we're probably not doing 2, I think my personal preference is to do 3 and then feature-gate after a couple of release cycles. But I'm open to other options.

jyn514

comment created time in 7 days

pull request commentrust-lang/rust

feature gate `doc(primitive)`

My preference is for 2, but I would also be happy with 1 or 3. I don't think we should silently change the behavior.

This PR currently implements 1.

I noticed you marked this PR as ready for review, but doesn't it need to be updated to use option 3 (since 2 isn't feasible)?

jyn514

comment created time in 7 days

pull request commentrust-lang/rust

feature gate `doc(primitive)`

FYI, you have a merge conflict in the feature gates file :)

jyn514

comment created time in 7 days

pull request commentrust-lang/rust

feature gate `doc(primitive)`

doc(primitive) is an attribute recognized by rustdoc which adds documentation for the built-in primitive types, such as usize and (). It has been stable since Rust 1.0.

It might be worth mentioning that it was meant for internal use only.

jyn514

comment created time in 7 days

pull request commentrust-lang/rust

[do not merge] feature gate doc(primitive)

That said, I like @Manishearth's suggestion of making this a future-incompat warning and a no-op at the same time.

That sounds like a good approach to me as well.

jyn514

comment created time in 7 days

push eventcamelid/mdBook

Alexandru Macovei

commit sha beec17e55d2a1ddf8dc052c546b88f90b935e7c0

Add ability to generate shell completions via clap

view details

josh rotenberg

commit sha e5e10c681a98249fd433825dfdcbd69b014f00a1

add init flags add init flags update init command in guide

view details

kana

commit sha 27b1e05c87359c332a9bd857fed1bdd73016040c

MyPaths are not required and fail Inputting paths are not necessary and will break ci, we can just leave paths out. We also changed 'master' to main since anyone reading this is probably going to be making mains

view details

josh rotenberg

commit sha 5dec8508c7421f7579aae321cb3d08739313d836

clarify the library path documentation

view details

josh rotenberg

commit sha 9fd2509c0daca077da95a31ad782b43152a1c663

fix link

view details

Frits Stegmann

commit sha 7932e13512b31271b94f8c4dedb2cc11226d1ce7

Update renderers.md I was doing some work on the epub plugin repo and when trying to build an epub I came across what looked like some broken references.

view details

Eric Huss

commit sha e33192753d144dd3ba24f0f7ffb2b1ae2671de1a

Merge pull request #1591 from fritsstegmann/patch-1 Update renderers.md

view details

Eric Huss

commit sha b3c0b013501b43468852f4fb648e7a80495f8cd4

Merge pull request #1586 from joshrotenberg/fix_library_path_doc Clarify the library path documentation

view details

josh rotenberg

commit sha 86d390032be3afc8ea5306962fb51ea723890cf3

drop short flags

view details

kana

commit sha 00473d842017c0a3ac2f5cfecc3b08b53a8c9618

Add comments to edit in case of custom book path

view details

kana

commit sha a8926d5392fe546659cd42c0808100d169b93cdb

Update continuous-integration.md

view details

josh rotenberg

commit sha 8ec0bf6e30545defd9e81f1775740b03df2da544

ignore now takes a value

view details

josh rotenberg

commit sha 8024b08f93bb3bcb4e94f6ced0d335169c604016

format

view details

josh rotenberg

commit sha b87c231fc3347d98bbc03cac536c050239a7abe0

first pass at 2021 support

view details

josh rotenberg

commit sha c06f450e7df4912eaba5f5399778b45599e58ae6

add edition2021 as an option

view details

josh rotenberg

commit sha ebdab38a3228bddeb8b2c28116112d681bb91ac6

remove debugging

view details

Eric Huss

commit sha b5715117372a66c3a48d10708b9471e7d67da3ea

Merge pull request #1596 from joshrotenberg/rust_edition_2021_support Rust Edition 2021 Support

view details

Eric Huss

commit sha 96b6f02834d1393174e434661aeb43b1a5acda70

Merge pull request #1425 from alexmaco/completions Add ability to generate shell completions via clap

view details

Eric Huss

commit sha 3976c9d8f02b311c756a7f729c422558cda9462d

Merge pull request #1576 from kana4/master MyPaths are not required and fail

view details

Eric Huss

commit sha c3a1e41ed72b469d7694d3df2e84e13238f9c2e1

Update CLI docs for flag name change.

view details

push time in 7 days

Pull request review commentrust-lang/rust

Add support for tuple struct field documentation

 impl Clean<Variant> for hir::VariantData<'_> {     fn clean(&self, cx: &mut DocContext<'_>) -> Variant {         match self {             hir::VariantData::Struct(..) => Variant::Struct(self.clean(cx)),-            hir::VariantData::Tuple(..) => {-                Variant::Tuple(self.fields().iter().map(|x| x.ty.clean(cx)).collect())-            }+            hir::VariantData::Tuple(..) => Variant::Struct(self.clean(cx)),

Hmm. Where is it used, and why did you change this code from Tuple to Struct?

GuillaumeGomez

comment created time in 7 days

PullRequestReviewEvent

delete branch camelid/rust

delete branch : better-recursive-alias-error

delete time in 7 days

create barnchcamelid/rust

branch : better-recursive-alias-error

created branch time in 7 days