profile
viewpoint
Dylan DPC Dylan-DPC Berlin Rustacean

crev-dev/cargo-crev 1110

A cryptographically verifiable code review system for the cargo (Rust) package manager.

AeroRust/Welcome 62

Welcome to the (Unofficial) Rust 🦀 + Aerospace 🚀 working group 🙌

AeroRust/awesome-space 46

List of awesome resources for Aerospace and Rust

AeroRust/WorkingGroup 32

Issues tracker for udeas, ongoing work, looking for mentors, mentors available, everything is in here!

chrispecoraro/mega-make 10

"php artisan make:all" for Laravel 5.5+

Dylan-DPC/cargo-doctor 7

Checks if all links mentioned in cargo docs of a crate are healthy

Dylan-DPC/cargo-caldera 2

Crater for packages that runs the new version on every reverse dependency

Dylan-DPC/clim-rs 2

CLI Menus

Dylan-DPC/acl 0

Dynamically configurable access control for laravel

PR opened rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #76454 (UI to unit test for those using Cell/RefCell/UnsafeCell)
  • #76474 (Add option to pass a custom codegen backend from a driver)
  • #76711 (diag: improve closure/generic parameter mismatch)
  • #77170 (Remove #[rustc_allow_const_fn_ptr] and add #![feature(const_fn_fn_ptr_basics)])
  • #77194 (Add doc alias for iterator fold)
  • #77253 (Resolve crate in intra-doc links properly across crates)
  • #77274 (Liveness refactoring continued)
  • #77289 (Change AllocRef::by_ref to take &self instead of &mut self)
  • #77292 (Prefer asm! in std - all in sgx module)

Failed merges:

r? @ghost

+1182 -1069

0 comment

84 changed files

pr created time in 6 hours

push eventDylan-DPC/rust

Lzu Tao

commit sha d4772014d97d9d1e1da4a8228fee2dd969f56e0f

Prefer asm! in std - all in sgx module

view details

Dylan DPC

commit sha f1500831809682d02e7b8e9fded0cb9cbdb29573

Rollup merge of #77292 - lzutao:std_asm, r=Amanieu Prefer asm! in std - all in sgx module Similar to the change in #76669 but all `llvm_asm!` is gate in x86/x86_64 target. Godbolt: - https://rust.godbolt.org/z/h7nG1h - https://rust.godbolt.org/z/xx39hW r? @ghost

view details

push time in 6 hours

push eventDylan-DPC/rust

Tim Diekmann

commit sha c22d896b9b1754b04e1dfbec14f056b374f35b62

Change `AllocRef::by_ref` to take `&self` instead of `&mut self`

view details

Dylan DPC

commit sha a063e5e4d9effd90b6ac8be01a49219262e2c4e0

Rollup merge of #77289 - TimDiekmann:alloc-ref-by-ref, r=Amanieu Change `AllocRef::by_ref` to take `&self` instead of `&mut self` r? @Amanieu

view details

push time in 6 hours

push eventDylan-DPC/rust

Tomasz Miąsko

commit sha e3319e7d1678b011de6af5b99caa4343ce8c4286

liveness: Move body_owner field from IrMaps to Liveness The Liveness struct is the only user of body_owner field. Move the field there.

view details

Tomasz Miąsko

commit sha e0db21dc7e4c8ab897ff07dcf0cce293db6ff4da

liveness: Use upvars instead of FnKind to check for closures Avoiding FnKind will make it easier to run liveness analysis on all bodies in the future, not just fn-like things.

view details

Tomasz Miąsko

commit sha b629ffd96bd4c882322833f6cde8c41b115894f9

liveness: Use visit_param to add variables corresponding to params

view details

Tomasz Miąsko

commit sha 536b51aca016b4744596f16a2e502b76e9490664

liveness: Store upvars_mentioned inside Liveness struct

view details

Tomasz Miąsko

commit sha 33dde94d33f4200f1931d3ad0a28d798f807f27c

liveness: Inline visitor implementation for IrMaps

view details

Tomasz Miąsko

commit sha 063d5e9d8bdf9f0b26817265ca90e246bb20e379

liveness: Test interaction with automatically_derived attribute

view details

Dylan DPC

commit sha c789c5e854d35a4882682d72ae24cb3363c07bbb

Rollup merge of #77274 - tmiasko:liveness-cnd, r=lcnr Liveness refactoring continued * Move body_owner field from IrMaps to Liveness (the only user of the field). * Use upvars instead of FnKind to check for closures (avoids FnKind, will be useful when checking all bodies, not just fns). * Use visit_param to add variables corresponding to params. * Store upvars_mentioned inside Liveness struct. * Inline visitor implementation for IrMaps, avoiding unnecessary indirection. * Test interaction with automatically_derived attribute (not covered by any of existing tests). No functional changes intended.

view details

push time in 7 hours

create barnchDylan-DPC/rust

branch : rollup-9ic1kdr

created branch time in 7 hours

push eventDylan-DPC/rust

Joshua Nelson

commit sha 8437d7b1d30b62b0ada5afd21ba4f9e32635bf31

Resolve `crate` properly across crates

view details

Joshua Nelson

commit sha 406584621a4e2d3752b2444c5bed2218447f0bfe

Use relative links instead of intra-doc links Previously, `BTreeMap` tried to link to `crate::collections`, intending for the link to go to `std/collections/index.html`. But `BTreeMap` is defined in `alloc`, so after the fix in the previous commit, the links instead went to `alloc/collections/index.html`, which has almost no information. This changes it to link to `index.html`, which only works when viewing from `std::collections::BTreeMap`, the most common place to visit the docs. Fixing it to work from anywhere would require the docs for `std::collections` to be duplicated in `alloc::collections`, which in turn would require HashMap to be `alloc` for intra-doc links to work (https://github.com/rust-lang/rust/issues/74481).

view details

Dylan DPC

commit sha 275096e0a948bc9590c9d6dc0d6d6a89bb52d4eb

Rollup merge of #77253 - jyn514:crate-link, r=Manishearth Resolve `crate` in intra-doc links properly across crates Closes https://github.com/rust-lang/rust/issues/77193; see https://github.com/rust-lang/rust/issues/77193#issuecomment-699065946 for an explanation of what's going on here. ~~This also fixes the BTreeMap docs that have been broken for a while; see the description on the second commit for why and how.~~ Nope, see the second commit for why the link had to be changed. r? @Manishearth cc @dylni @dylni note that this doesn't solve your original problem - now _both_ `with_code` and `crate::with_code` will be broken links. However this will fix a lot of other broken links (in particular I think https://docs.rs/sqlx/0.4.0-beta.1/sqlx/query/struct.Query.html is because of this bug). I'll open another issue for resolving additional docs in the new scope.

view details

push time in 7 hours

push eventDylan-DPC/rust

Ivan Tham

commit sha 1994cee61a4aea9dc46bb3d0323c8290621eda33

Add alias for iterator fold fold is known in python and javascript as reduce, not sure about inject but it was written in doc there.

view details

Ivan Tham

commit sha ea0065ad4f96153539476e2f3df83bae96018ede

Reposition iterator doc alias reduce before inline

view details

Dylan DPC

commit sha 62f7d56f43f12d306d5da034bf3250d2a32f41b0

Rollup merge of #77194 - pickfire:patch-7, r=withoutboats Add doc alias for iterator fold fold is known in python and javascript as reduce, not sure about inject but it was written in doc there. This was my first confusion when coming into rust, I somehow cannot find where is reduce, sometimes I still forget that it is known as `fold`.

view details

push time in 7 hours

push eventDylan-DPC/rust

Dylan MacKenzie

commit sha 1ff143191c62bc7cfa17da99dac59a871f39a462

Add a feature gate for basic function pointer use in `const fn`

view details

Dylan MacKenzie

commit sha 3cbd17fcc6c5c816b59c1816008b0d4ae3ef2982

Remove `rustc_allow_const_fn_ptr` This was a hack to work around the lack of an escape hatch for the "min `const fn`" checks in const-stable functions. Now that we have co-opted `allow_internal_unstable` for this purpose, we no longer need the bespoke attribute.

view details

Dylan MacKenzie

commit sha e2622b915a15c06bdedc5e1278f6fb92cdaa03fa

Update tests with new feature gate

view details

Dylan MacKenzie

commit sha 54d3329c95c9ee0b7dbafd787fb90914ef8a98e8

Bless tests

view details

Dylan MacKenzie

commit sha 368502cc1d9bbbd8388be548f7ce5cd79f0d24da

Mark `min_const_fn_fn_ptr` test as gate test

view details

Dylan MacKenzie

commit sha 807260be9fae2612b66bffaadf6e7a7b0b216cdc

Remove feature gate test for `rustc_allow_const_fn_ptr`

view details

Dylan DPC

commit sha a823d7afe1499c9c7d971f3060a8c6df87393a17

Rollup merge of #77170 - ecstatic-morse:const-fn-ptr, r=oli-obk Remove `#[rustc_allow_const_fn_ptr]` and add `#![feature(const_fn_fn_ptr_basics)]` `rustc_allow_const_fn_ptr` was a hack to work around the lack of an escape hatch for the "min `const fn`" checks in const-stable functions. Now that we have co-opted `allow_internal_unstable` for this purpose, we no longer need a bespoke attribute. Now this functionality is gated under `const_fn_fn_ptr_basics` (how concise!), and `#[allow_internal_unstable(const_fn_fn_ptr_basics)]` replaces `#[rustc_allow_const_fn_ptr]`. `const_fn_fn_ptr_basics` allows function pointer types to appear in the arguments and locals of a `const fn` as well as function pointer casts to be performed inside a `const fn`. Both of these were allowed in constants and statics already. Notably, this does **not** allow users to invoke function pointers in a const context. Presumably, we will use a nicer name for that (`const_fn_ptr`?). r? @oli-obk

view details

push time in 7 hours

push eventDylan-DPC/rust

David Wood

commit sha 01f65afa4adff6dfbea84621e6851c028aaa7159

diag: improve closure/generic parameter mismatch This commit improves the diagnostic when a type parameter is expected and a closure is found, noting that each closure has a distinct type and therefore could not always match the caller-chosen type of the parameter. Signed-off-by: David Wood <david@davidtw.co>

view details

Dylan DPC

commit sha 62ab064d2135b67fa5bd78757c014f10c976521f

Rollup merge of #76711 - davidtwco:issue-51154-param-closure, r=estebank diag: improve closure/generic parameter mismatch Fixes #51154. This PR improves the diagnostic when a type parameter is expected and a closure is found, noting that each closure has a distinct type and therefore could not always match the caller-chosen type of the parameter. r? @estebank

view details

push time in 7 hours

push eventDylan-DPC/rust

bjorn3

commit sha 71bc62b9f696ae83ef1713bd96054c92cda9f27f

Add option to pass a custom codegen backend from a driver

view details

Dylan DPC

commit sha ea274a3788ee73793161a4bef98bb5a8f75dc2a2

Rollup merge of #76474 - bjorn3:driver_selected_codegen, r=oli-obk Add option to pass a custom codegen backend from a driver This allows the driver to pass information to the codegen backend. For example the headcrab debugger may in the future want to use cg_clif to JIT code to be injected in the debuggee. This would PR make it possible to tell cg_clif which symbol can be found at which address and to tell it to inject the JITed code into the right process. This PR may also help with https://github.com/rust-lang/miri/pull/1540 by allowing miri to provide a codegen backend that only emits metadata and doesn't perform any codegen. cc @nbaksalyar (headcrab) cc @RalfJung (miri)

view details

push time in 7 hours

push eventDylan-DPC/rust

Alexis Bourget

commit sha 8aae1eee94f481bd955cff473deae1f03c313451

Move cell exterior test into library unit tests

view details

Alexis Bourget

commit sha f69c5aa428efdbc01685c3d06e63fedd3120e8e5

Move more tests using Cell to unit tests

view details

Alexis Bourget

commit sha af44a2a857618150b180dabe9c3383a3911b3640

move 'cell does not clone' test

view details

Alexis Bourget

commit sha fc152cd67e0b6d3f11f49eae43183d03a3b8bf17

move 'test zip ...' tests

view details

Alexis Bourget

commit sha 85b2d9bf6f2b04ae8996050b2fb276bd58cd92de

fmt

view details

Alexis Bourget

commit sha 949c96660c32ff9b19a639b4be607938c2262653

move format! interface tests

view details

Alexis Bourget

commit sha ed52c7bb7516f12f74704e20457d5046378a49fc

Move deref-lval test

view details

Alexis Bourget

commit sha ac39debeba2b63a39a3833e2d7451f0b1f95b5f2

Move panic safety traits tests

view details

Alexis Bourget

commit sha 8904921c1d6b3636f4352f9dd6d4875132b89998

Move array cycle test

view details

Alexis Bourget

commit sha 275eed7eb1d45e8173b932e2abfdae2201d2cf62

Move vec-slice-drop test

view details

Alexis Bourget

commit sha 6bc0357dadd9d41a8166d4c2ab8a27c0bb8150d3

Move vec-cycle test

view details

Alexis Bourget

commit sha f6a4189d05f8bc7091450289f7285819ebdd3c62

Move vec-cycle-wrapped test

view details

Alexis Bourget

commit sha 5be843fc54f80817c88438efa097a4ba81d4aa9e

Move format-ref-cell test

view details

Alexis Bourget

commit sha a61b9638bbbb48f9c2fde0ccbbcf03e64494ea0f

review: fix nits and move panic safety tests to the correct place

view details

Dylan DPC

commit sha 4bb2369ac356624cdc27cf0e81695b3eeb706aa4

Rollup merge of #76454 - poliorcetics:ui-to-unit-test-1, r=matklad UI to unit test for those using Cell/RefCell/UnsafeCell Helps with #76268. I'm working on all files using `Cell` and moving them to unit tests when possible. r? @matklad

view details

push time in 7 hours

pull request commentrust-lang/rust

Update chalk to 0.29.0

r? @Dylan-DPC

@bors r+

vandenheuvel

comment created time in a day

pull request commentrust-lang/rust

Remove duplicate comment

r? @Dylan-DPC

@bors r+ rollup

bugadani

comment created time in a day

pull request commentrust-lang/rust

unix: Extend UnixStream and UnixDatagram to send and receive file descriptors

@bors r=Amanieu

LinkTed

comment created time in 2 days

pull request commentrust-lang/rust

Add missing code examples on HashMap types

@bors r+ rollup

GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Add missing code examples on slice iter types

@bors r+ rollup

GuillaumeGomez

comment created time in 3 days

PR closed rust-lang/rust

Add PartialEq and PartialOrd for NonZeroInt to Int S-waiting-on-author T-libs needs-fcp

Propose adding PartialEq and PartialOrd to the NonZeroInt types to compare to their inner types. Seems like a pretty obvious change, but I'm obviously open to any feedback or suggestions.

I'd also like to implement PartialEq<NonZeroInt> for Int, but I wasn't sure what the implications were for implementing traits on primitive types like that.

Retry of #70855

+75 -0

28 comments

2 changed files

Lucretiel

pr closed time in 3 days

pull request commentrust-lang/rust

Add PartialEq and PartialOrd for NonZeroInt to Int

@Lucretiel Thanks for the contribution. Sadly I have to close this due to inactivity. If you wish and feel like you have the time to contribute, you can open a new PR with the change and we can take it from there.

Lucretiel

comment created time in 3 days

pull request commentrust-lang/rust

Resurrect #70477: "Use the niche optimization if other variant are small enough"

let's do a perf run first:

@bors try @rust-timer queue

erikdesjardins

comment created time in 3 days

pull request commentrust-lang/rust

Stabilize `std::path::Prefix::is_verbatim` as const

r? @Amanieu

CDirkx

comment created time in 3 days

PR closed rust-lang/rust

Optimize span metadata encoding for the local, non-dummy case S-waiting-on-author

There are three types of Spans that we may end up encoding:

  1. Non-dummy local span (SourceFile comes from our local crate)
  2. Non-dummy foreign span (SourceFile comes from a foreign crate)
  3. Dummy span

In the overwhelming majority of cases, we will be encoding a non-dummy local span. Currently, this requires us to first check for TAG_INVALID_SPAN, and then check for TAG_VALID_SPAN_LOCAL.

This commit optimizes span encoding to only require a single check in the non-dummy local case:

  • We now unconditionally encode a CrateNum instead of a tag value. While a CrateNum is encoded as a u32, local spans have a CrateNum of LOCAL_CRATE (0), which our variable-length encoding scheme will encode in a single byte.
  • Dummy spans are serialized like any other local span. This means that we can no longer encode them in a single byte, but dummy spans should be rare enough that this doesn't matter.

Additionally, we now preserve the SyntaxContext for spans with a dummy location (Span.is_dummy() == true).

+173 -183

18 comments

11 changed files

Aaron1011

pr closed time in 3 days

pull request commentrust-lang/rust

Optimize span metadata encoding for the local, non-dummy case

Closing this due to inactivity. If you find the cause of it, better to open a new pull request and we can take it from there. Thanks

Aaron1011

comment created time in 3 days

Pull request review commentrust-lang/rust

Add doc alias for pointer primitive

 mod prim_char {} #[stable(feature = "rust1", since = "1.0.0")] mod prim_unit {} +#[doc(alias = "ptr")]+#[doc(alias = "pointer")]

@pickfire would advise not using reviews to ask for clarity on stuff in the PR. It can be misleading to triagists and other reviewers

GuillaumeGomez

comment created time in 3 days

PullRequestReviewEvent

pull request commentrust-lang/rust

Add regression test

@bors r+ rollup

JulianKnodt

comment created time in 3 days

pull request commentrust-lang/rust

Add missing examples for Fd traits

r? @jyn514

GuillaumeGomez

comment created time in 3 days

PR closed rust-lang/rust

Rollup of 11 pull requests S-waiting-on-review rollup

Successful merges:

  • #76631 (Add x.py setup)
  • #76955 (Refactor and fix intra-doc link diagnostics, and fix links to primitives)
  • #76973 (Unstably allow assume intrinsic in const contexts)
  • #77086 (Include libunwind in the rust-src component.)
  • #77097 (Make [].as_[mut_]ptr_range() (unstably) const.)
  • #77106 (clarify that changelog-seen = 1 goes to the beginning of config.toml)
  • #77120 (Add --keep-stage-std to x.py for keeping only standard library artifacts)
  • #77127 (Update mdBook)
  • #77129 (Update cargo)
  • #77155 (remove enum name from ImplSource variants)
  • #77176 (Removing erroneous semicolon in transmute documentation)

Failed merges:

r? @ghost

+663 -424

5 comments

43 changed files

RalfJung

pr closed time in 3 days

pull request commentrust-lang/rust

Rollup of 11 pull requests

Failed spuriously but let's wait for the existing rollup=never to finish first and then I'll create a newer rollup depending on how the tree looks

RalfJung

comment created time in 3 days

pull request commentrust-lang/rust

Add missing examples for Fd traits

this is failing on the CI

GuillaumeGomez

comment created time in 4 days

pull request commentrust-lang/rust

Separate unsized fn params from unsized locals

@spastorino since you have the headstart, you can proceed not a problem

JohnTitor

comment created time in 4 days

delete branch Dylan-DPC/rust

delete branch : rollup-hckt0gq

delete time in 4 days

PR closed rust-lang/rust

Rollup of 12 pull requests S-waiting-on-review rollup

Successful merges:

  • #74430 (Stabilize intra-doc links)
  • #76304 (Make delegation methods of std::net::IpAddr unstably const)
  • #76748 (Fix underflow when calculating the number of no-op jumps folded)
  • #76920 (ICEs should print the top of the query stack)
  • #76978 (Documented From impls in std/sync/mpsc/mod.rs)
  • #77028 (Move MiniSet to data_structures)
  • #77044 (Liballoc bench vec use mem take not replace)
  • #77050 (Typo fix: "satsify" -> "satisfy")
  • #77066 (Fix dest prop miscompilation around references)
  • #77086 (Include libunwind in the rust-src component.)
  • #77097 (Make [].as_[mut_]ptr_range() (unstably) const.)
  • #77106 (clarify that changelog-seen = 1 goes to the beginning of config.toml)

Failed merges:

  • #77037 (more tiny clippy cleanups)
  • #77049 (const_evaluatable_checked: extend predicate collection)

r? @ghost

+460 -333

4 comments

43 changed files

Dylan-DPC

pr closed time in 4 days

pull request commentrust-lang/rust

Stabilize the Wake trait

@dtolnay this is ready for review

yoshuawuyts

comment created time in 4 days

pull request commentrust-lang/rust

Rollup of 12 pull requests

@bors r+ rollup=never p=5

Dylan-DPC

comment created time in 5 days

PR opened rust-lang/rust

Rollup of 12 pull requests

Successful merges:

  • #74430 (Stabilize intra-doc links)
  • #76304 (Make delegation methods of std::net::IpAddr unstably const)
  • #76748 (Fix underflow when calculating the number of no-op jumps folded)
  • #76920 (ICEs should print the top of the query stack)
  • #76978 (Documented From impls in std/sync/mpsc/mod.rs)
  • #77028 (Move MiniSet to data_structures)
  • #77044 (Liballoc bench vec use mem take not replace)
  • #77050 (Typo fix: "satsify" -> "satisfy")
  • #77066 (Fix dest prop miscompilation around references)
  • #77086 (Include libunwind in the rust-src component.)
  • #77097 (Make [].as_[mut_]ptr_range() (unstably) const.)
  • #77106 (clarify that changelog-seen = 1 goes to the beginning of config.toml)

Failed merges:

  • #77037 (more tiny clippy cleanups)
  • #77049 (const_evaluatable_checked: extend predicate collection)

r? @ghost

+460 -333

0 comment

43 changed files

pr created time in 5 days

push eventDylan-DPC/rust

Matthias Krüger

commit sha b5d47bfa3aafb8fcb8c60d93fea45207c7ea5c7b

clarify that `changelog-seen = 1` goes to the beginning of config.toml Fixes #77105

view details

Dylan DPC

commit sha feb6392b7686912aa669a2d819bf5dc07f710bed

Rollup merge of #77106 - matthiaskrgr:changelog_seen, r=Mark-Simulacrum clarify that `changelog-seen = 1` goes to the beginning of config.toml Fixes #77105

view details

push time in 5 days

push eventDylan-DPC/rust

Mara Bos

commit sha 631c6883502144fdb8ac754c9ef1f74111fd3222

Make [].as_[mut_]ptr_range() (unstably) const.

view details

Dylan DPC

commit sha 55728202435d173c2244c023e508e901a3e1627e

Rollup merge of #77097 - fusion-engineering-forks:slice-ptr-range-const-fn, r=oli-obk Make [].as_[mut_]ptr_range() (unstably) const. Gated behind `const_ptr_offset`, as suggested by https://github.com/rust-lang/rust/issues/65807#issuecomment-697229404 This also marks `[].as_mut_ptr()` as const, because it's used by `as_mut_ptr_range`. I gated it behind the same feature, because I figured it's not worth adding a separate tracking issue for const `as_mut_ptr`.

view details

push time in 5 days

push eventDylan-DPC/rust

Eric Huss

commit sha 9f27f3796d3487411ab035803a0757d69040649c

Include libunwind in the rust-src component.

view details

Dylan DPC

commit sha 9a85615821478c3591ea7d34d1d409626dc5ea00

Rollup merge of #77086 - ehuss:src-libunwind, r=Mark-Simulacrum Include libunwind in the rust-src component. Some targets, such as musl, need the libunwind source to build the unwind crate (referenced [here](https://github.com/rust-lang/rust/blob/0da58007451a154da2480160429e1604a1f5f0ec/library/unwind/build.rs#L142)). Fixes rust-lang/wg-cargo-std-aware#59

view details

push time in 5 days

push eventDylan-DPC/rust

Jonas Schievink

commit sha 4b6a4821b71221a46576100a5ab3fc92011fad16

Fix dest prop miscompilation around references

view details

Jonas Schievink

commit sha 928a29fd41b5757ff183ee0befa410f12f955f7c

Bless mir-opt tests

view details

Dylan DPC

commit sha 1a66e27a55dc63a6a4a5304744aebbf561f9a04c

Rollup merge of #77066 - jonas-schievink:dest-prop-borrow, r=oli-obk Fix dest prop miscompilation around references Closes https://github.com/rust-lang/rust/issues/77002

view details

push time in 5 days

push eventDylan-DPC/rust

follower

commit sha 0082d201f1ea8ce106f1c71562d5f2d0d2e35513

Typo fix: "satsify" -> "satisfy"

view details

Dylan DPC

commit sha 7075433abc48dfa13c13dc2e900514bf8b8a3101

Rollup merge of #77050 - follower:patch-1, r=oli-obk Typo fix: "satsify" -> "satisfy"

view details

push time in 5 days

push eventDylan-DPC/rust

Ivan Tham

commit sha 4a6bc77a0160a4540dea03e39642c373ca9f2a69

Liballoc bench vec use mem take not replace

view details

Dylan DPC

commit sha af24b834940ca6db3b41baa52a4a5df7181b615a

Rollup merge of #77044 - pickfire:patch-4, r=jyn514 Liballoc bench vec use mem take not replace

view details

push time in 5 days

push eventDylan-DPC/rust

Andreas Jonson

commit sha 6586c37beca21869f698ef2de10d1df7be7e7879

Move MiniSet to data_structures remove the need for T to be copy from MiniSet as was done for MiniMap

view details

Dylan DPC

commit sha 63ea0cf239e3407558ad0da0df91c3f3836aab21

Rollup merge of #77028 - andjo403:mini, r=matthewjasper Move MiniSet to data_structures remove the need for T to be copy from MiniSet as was done for MiniMap MiniMap and MiniSet was added by https://github.com/rust-lang/rust/pull/72412 think that this can be used in https://github.com/rust-lang/rust/pull/68828

view details

push time in 5 days

push eventDylan-DPC/rust

Erik Hofmayer

commit sha 3f0f40904c18bce9915b5fe2a1d017f3906c0d26

Documented From impls in std/sync/mpsc/mod.rs

view details

Erik Hofmayer

commit sha 16eee2a04a4c3a93d398728d7a0c05a8afb6ca94

Applied review comments

view details

Dylan DPC

commit sha bd7f3f1dc402f52e8eafe7f01a97aec71e29d505

Rollup merge of #76978 - duckymirror:mpsc-from-doc, r=jyn514 Documented From impls in std/sync/mpsc/mod.rs This is for #51430. r? @steveklabnik

view details

push time in 5 days

push eventDylan-DPC/rust

hosseind75

commit sha 5fd6301bcd2d7a9260a5d5ca3f5abcc05830761b

ICEs should print the top of the query stack

view details

hosseind75

commit sha 132c9efbcbe6b63e36fb53fc95beaed6627ecc2d

run full query stack print just when RUST_BACKTRACE is set

view details

hosseind75

commit sha 767e84a834d21eb8acc063f5f89753f4d467f589

change approach and run ui tests

view details

hosseind75

commit sha 339181a5d94384d57e5681fbcffe9492264b5025

show a message when we are showing limited slice of query stack

view details

hosseind75

commit sha 51c32f443ded5b264feb7e6d2bf9efc0b04e180a

fix invalid-punct-ident-1 test

view details

hosseind75

commit sha d8af4b38489ce4ba3fef615da2fbc5dd6bac2d28

add filter regexes to load-panic-backtraces test

view details

hosseind75

commit sha cdd3126666d827a11735a4ab31da74b1de160fbf

fix show we're just showing... message instead of the end of query stack message when RUST_BACKTRACE=0

view details

Dylan DPC

commit sha 0e4149dadbd49f184164c867150f451167d2ed8b

Rollup merge of #76920 - hosseind75:ICEs_should_always_print_the_top_of_the_query_stack, r=oli-obk ICEs should print the top of the query stack see #76920 r? @oli-obk

view details

push time in 5 days

push eventDylan-DPC/rust

Tomasz Miąsko

commit sha ff1a9e406bfccefedb6c4f2cabc0c4d59ac947d4

Fix underflow when calculating the number of no-op jumps folded When removing unwinds to no-op blocks and folding jumps to no-op blocks, remove the unwind target first. Otherwise we cannot determine if target has been already folded or not. Previous implementation incorrectly assumed that all resume targets had been folded already, occasionally resulting in an underflow: remove_noop_landing_pads: removed 18446744073709551613 jumps and 3 landing pads

view details

Dylan DPC

commit sha 8836966c1c32031abdf4bc2ba3240f68344b35b4

Rollup merge of #76748 - tmiasko:no-op-jumps, r=matthewjasper Fix underflow when calculating the number of no-op jumps folded When removing unwinds to no-op blocks and folding jumps to no-op blocks, remove the unwind target first. Otherwise we cannot determine if target has been already folded or not. Previous implementation incorrectly assumed that all resume targets had been folded already, occasionally resulting in an underflow: ``` remove_noop_landing_pads: removed 18446744073709551613 jumps and 3 landing pads ```

view details

push time in 5 days

push eventDylan-DPC/rust

Christiaan Dirkx

commit sha 947536fca06e6dc6c3a3dd4ff1f66fc5080e9cbb

Make delegation methods of `std::net::IpAddr` unstable const Make the following methods of `std::net::IpAddr` unstable const under the `const_ip` feature: - `is_unspecified` - `is_loopback` - `is_global` - `is_multicast` Also adds a test for these methods in a const context. Possible because these methods delegate to the inner `Ipv4Addr` or `Ipv6Addr`, which were made const, and the recent stabilization of const control flow. Part of #76205

view details

Dylan DPC

commit sha 4893b4f869068b398cd0a60a54b6131135f030ee

Rollup merge of #76304 - CDirkx:const-ip, r=ecstatic-morse Make delegation methods of `std::net::IpAddr` unstably const Make the following methods of `std::net::IpAddr` unstable const under the `const_ip` feature: - `is_unspecified` - `is_loopback` - `is_global` - `is_multicast` Also adds a test for these methods in a const context. Possible because these methods delegate to the inner `Ipv4Addr` or `Ipv6Addr`, which were made const ([PR#76205](https://github.com/rust-lang/rust/pull/76142) and [PR#76206](https://github.com/rust-lang/rust/pull/76206)), and the recent stabilization of const control flow. Part of #76205 r? @ecstatic-morse

view details

push time in 5 days

push eventDylan-DPC/rust

Manish Goregaokar

commit sha c100e726c10fe9d212a58a5494126409e7d0e10b

Stabilize intra-doc links

view details

Manish Goregaokar

commit sha 63d5beec43ff7721928821cd83f9790188b03276

Move intra-doc-links documentation out of unstable section

view details

Manish Goregaokar

commit sha bc06674774e6457046e41a48dc3e8be8c5496f11

Mention super/crate/self in docs

view details

Manish Goregaokar

commit sha f072e4a7322e8e2b16410e3225e1afc15d132e36

Mention URL fragments

view details

Manish Goregaokar

commit sha 2a98409634ec38547d03512898192b5bdce15f3d

Fill out docs on intra-doc resolution failure lint

view details

Manish Goregaokar

commit sha 4e0eb0b73ba2defaf0f3c2152e9daa5c18d1603f

Update src/doc/rustdoc/src/linking-to-items-by-name.md Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Manish Goregaokar

commit sha 175e30539d5ee9364a26f89f8a03a60b53690684

Update src/doc/rustdoc/src/linking-to-items-by-name.md Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Manish Goregaokar

commit sha 51c1351f7b9366a295dce5d63c2fd387170d5c34

Resolve some conflicts

view details

Manish Goregaokar

commit sha 6f1fa2b16376f586285453045788519df527a1b2

Fix lint name in docs

view details

Manish Goregaokar

commit sha 792b2ea5812a06fe3d362ae36025998af66199ee

Update src/doc/rustdoc/src/lints.md Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Manish Goregaokar

commit sha 6928041c0a992093a7752ae3c04090caebcd4515

Update src/doc/rustdoc/src/linking-to-items-by-name.md Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Dylan DPC

commit sha c7d68ed2f6dac2157e3c65e4c195150fa1dea526

Rollup merge of #74430 - Manishearth:stabilize-intra-doc, r=Manishearth Stabilize intra-doc links Fixes https://github.com/rust-lang/rust/issues/43466 Thanks to the great work of @jyn514 in getting the [cross-crate reexport issue](https://github.com/rust-lang/rust/issues/65983) in intra-rustdoc links fixed, I think we're now in a position to stabilize this feature. The tracking issue currently has two unresolved issues: - <s>behavior around doc(hidden): This is fixed in https://github.com/rust-lang/rust/pull/73365, which is just waiting for CI and should land tomorrow. It's also a pretty niche bug so while I expect it to land soon I don't think we need to block stabilization on it anyway.</s> - Non-identifier primitive types like slices: This was not a part of the original RFC anyway, and is a pretty niche use case The feature itself, sans https://github.com/rust-lang/rust/issues/65983, has been shipped on nightly for three years now, with people using it on docs.rs. https://github.com/rust-lang/rust/issues/65983 itself is not an overwhelmingly central bit of functionality; the reason we elected to block stabilization on it was that back in 2017 it was not possible to fix the issue without some major refactorings of resolve, and we did not want to stabilize something that had such a potentially unfixable bug. Given that we've fixed it, I see no reason to delay stabilization on this long awaited feature. It's possible that the latest patches have problems, however we _have_ done crater runs of some of the crucial parts. Furthermore, that's what the release trains are for, we will have a solid three months to let it ride the trains before it actually hits the stable compiler. r? @rust-lang/rustdoc

view details

push time in 5 days

create barnchDylan-DPC/rust

branch : rollup-hckt0gq

created branch time in 5 days

PR closed rust-lang/rust

Separate unsized fn params from unsized locals S-waiting-on-author T-compiler

Taking over #72029 in favor of https://github.com/rust-lang/rust/pull/72029#issuecomment-658941301. Fixes #71694, closes #72029

r? @pnkfelix cc @RalfJung @spastorino

+280 -162

11 comments

57 changed files

JohnTitor

pr closed time in 5 days

pull request commentrust-lang/rust

Separate unsized fn params from unsized locals

I'm currently reworking this, I should have a PR up in a few days.

JohnTitor

comment created time in 5 days

pull request commentrust-lang/rust

Update mdBook

r? @Dylan-DPC

@bors r+

camelid

comment created time in 5 days

pull request commentrust-lang/rust

more tiny clippy cleanups

@bors r+ rollup

matthiaskrgr

comment created time in 5 days

pull request commentrust-lang/rust

Rollup of 9 pull requests

@bors rollup=never :P

Dylan-DPC

comment created time in 5 days

IssuesEvent

issue commentrust-lang/rust

Support for converting OpenOptions to c_int on UNIX

Reopening this because it is being reverted in #77090

withoutboats

comment created time in 5 days

pull request commentrust-lang/rust

Rollup of 9 pull requests

@bors r+ rollup

Dylan-DPC

comment created time in 5 days

PR opened rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #76898 (Record tcx.def_span instead of item.span in crate metadata)
  • #76939 (emit errors during AbstractConst building)
  • #76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.)
  • #76993 (Changing the alloc() to accept &self instead of &mut self)
  • #76994 (fix small typo in docs and comments)
  • #77017 (Add missing examples on Vec iter types)
  • #77042 (Improve documentation for ToSocketAddrs)
  • #77047 (Miri: more informative deallocation error messages)
  • #77055 (Add #[track_caller] to more panicking Cell functions)

Failed merges:

r? @ghost

+552 -199

0 comment

42 changed files

pr created time in 5 days

push eventDylan-DPC/rust

est31

commit sha 05c3a2b07dc66fabc874181ce1eebea192cb4b56

Add #[track_caller] to more panicking Cell functions Continuation of #74526 Adds the #[track_caller] attribute to almost all panicking Cell functions. The ones that borrow two Cells in their function body are spared, because the panic location helps pinpoint which of the two borrows failed. You'd need to have full debuginfo and backtraces enabled together with column info in order to be able to discern the cases. Column info is only available on non-Windows platforms.

view details

Dylan DPC

commit sha c3c03f2f05f3144c2c24ff10fc6d1cca49a5f0be

Rollup merge of #77055 - est31:more_track_caller, r=Mark-Simulacrum Add #[track_caller] to more panicking Cell functions Continuation of #74526 Adds the #[track_caller] attribute to almost all panicking Cell functions. The ones that borrow two Cells in their function body are spared, because the panic location helps pinpoint which of the two borrows failed. You'd need to have full debuginfo and backtraces enabled together with column info in order to be able to discern the cases. Column info in debuginfo is only available on non-Windows platforms.

view details

push time in 5 days

push eventDylan-DPC/rust

Ralf Jung

commit sha 731113b8eeef206ff27b77cb9f0dc49e2762a1b4

Miri: more informative deallocation error messages

view details

Dylan DPC

commit sha f8dec3d0549beddcae22bc14c49a0778b50334ea

Rollup merge of #77047 - RalfJung:miri-dealloc, r=oli-obk Miri: more informative deallocation error messages Make sure we show the affected AllocId. r? @oli-obk

view details

push time in 5 days

push eventDylan-DPC/rust

Imbolc

commit sha 2a40b6366245ddb38f4562da0b4f665f4d0e45d9

Update addr.rs I little clarification

view details

Imbolc

commit sha 5ab714fdfe00db1dbac1adf2f56a850768d478b4

Update library/std/src/net/addr.rs Co-authored-by: Ivan Tham <pickfire@riseup.net>

view details

Imbolc

commit sha 4622ceb5e02a717afd2380bc416b0a19897731ee

Update library/std/src/net/addr.rs Co-authored-by: Ivan Tham <pickfire@riseup.net>

view details

Dylan DPC

commit sha 049ba0c6f01fee9978acaf9caefdc3bfcd5ddc9b

Rollup merge of #77042 - imbolc:patch-2, r=kennytm Improve documentation for ToSocketAddrs I little clarification

view details

push time in 5 days

push eventDylan-DPC/rust

Mara Bos

commit sha db74e1f1e3e5c7497bb9af68814497c8df1fd0b8

Add cfg(target_has_atomic_equal_alignment). This is needed for Atomic::from_mut.

view details

Mara Bos

commit sha 9e3f94dabc334586d669f3aba0bded607ac782fc

Don't unwrap but report a fatal error for TargetDataLayout::parse.

view details

Mara Bos

commit sha af56ad7633668a790353f17440586e97b4e6a99b

Add feature gate ui test for cfg(target_has_atomic_load_store).

view details

Mara Bos

commit sha 54fdf54e06e3287958d906d2fb1b905b778d5e38

Add feature gate ui test for cfg(target_has_atomic_equal_alignment).

view details

Mara Bos

commit sha 668225d157d91e5c55a02aa7abc1b65ec9690ffa

Revert "Revert adding Atomic::from_mut." This reverts commit 5ef1db3622c373883571868cbdafbfbd568cddcb.

view details

Mara Bos

commit sha 7a04ff6c33c8bc9b8b1012e12a9920df52956e2f

Gate Atomic::from_mut on cfg(target_has_atomic_equal_alignment). Instead of a few hardcoded cfg(target_arch = ..) like before.

view details

Mara Bos

commit sha 5d6f1a1e32de4936e5b269b04781b2737f6d410b

Move `use align_of` in atomic.rs into the places where it is used.

view details

Mara Bos

commit sha bcc1d56917fe061071ebc539b5d2e304a44a7b00

Test that AtomicU64::from_mut is not available on x86 linux.

view details

Dylan DPC

commit sha eaaf5d7e38b1ee2306cac1ccbcbf3b18bdc6235c

Rollup merge of #76965 - fusion-engineering-forks:fix-atomic-from-mut, r=Amanieu Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut. Fixes some platform-specific problems with #74532 by using the actual alignment of the types instead of hardcoding a few `target_arch`s. r? @RalfJung

view details

push time in 5 days

push eventDylan-DPC/rust

blitzerr

commit sha d9d02fa168016b5b5b2033a2964a723f447f94b0

Changing the alloc() to accept &self instead of &mut self

view details

blitzerr

commit sha 7e443a1ffc587858c16aeac1dda3d2dffce0ff5f

Added feature flag to use cell_update

view details

blitzerr

commit sha 219003bd2ee6778333cf92405c6ea8591ecc8816

replaced cell::update with cell::[g|s]et

view details

blitzerr

commit sha 3ffd403c6b97f181c189a8eb5fbd30e3e7a95b43

removing &mut self for other methods of AllocRef

view details

blitzerr

commit sha 14736ca20b2e5f60981743c6ee2dfa62db818767

fixing the custom.rs

view details

blitzerr

commit sha 985dff9e7ed1fd7896b071eaf637fd531a690e91

fixing the test failure

view details

blitzerr

commit sha 2b19b14cecbcdd173e29a801baff71e31cae7331

a few more &mut self -> self changes

view details

Dylan DPC

commit sha a40d79c9fb185d6eb85f9a9c41dd9e203b2820a0

Rollup merge of #76993 - blitzerr:alloc-ref, r=Amanieu Changing the alloc() to accept &self instead of &mut self Fixes: [#55](https://github.com/rust-lang/wg-allocators/issues/55) This is the first cut. It only makes the change for `alloc` method.

view details

push time in 5 days

create barnchDylan-DPC/rust

branch : rollup-2jfrg3u

created branch time in 5 days

push eventDylan-DPC/rust

Bastian Kauschke

commit sha d4039c55c9ef392261aeaba6c14ae81f5098139a

wip emit errors during AbstractConst building

view details

Bastian Kauschke

commit sha 30cbc9729654c66b9f54779d18f023e47112cdf2

words

view details

Bastian Kauschke

commit sha 7a02ebd828c8d9c68e8e972326ede8696fb3f6b7

bless tests

view details

Bastian Kauschke

commit sha 9a493ced748e2e3e7390fc6f28640d23cb90e67b

add test for closures in abstract consts

view details

Bastian Kauschke

commit sha 2f893e458a20a159fcf93a9a5b0435ae3ed0a67e

review

view details

Dylan DPC

commit sha 98e5ee7df02c7812441ac31338819cb3f788f4f9

Rollup merge of #76939 - lcnr:const-evaluatable-cont, r=oli-obk emit errors during AbstractConst building There changes are currently still untested, so I don't expect this to pass CI :laughing: It seems to me like this is the direction we want to go in, though we didn't have too much of a discussion about this. r? @oli-obk

view details

push time in 5 days

push eventDylan-DPC/rust

Aaron Hill

commit sha e734733a9e931cbbe26cfccbdf9849faef8e5125

Record `tcx.def_span` instead of `item.span` in crate metadata This was missed in PR #75465. As a result, a few places have been using the full body span of functions, instead of just the header span.

view details

Dylan DPC

commit sha a22eb31668e949fb392c417547d2f5da5fbbcc19

Rollup merge of #76898 - Aaron1011:fix/item-def-span, r=oli-obk Record `tcx.def_span` instead of `item.span` in crate metadata This was missed in PR #75465. As a result, a few places have been using the full body span of functions, instead of just the header span.

view details

push time in 5 days

push eventDylan-DPC/rust

Guillaume Gomez

commit sha 143557ec56124c246d6cf4c37398e657f84536e1

Add missing examples on Vec iter types

view details

Dylan DPC

commit sha b76343643dddfa17de98f5aa7ad3d24ef4b62f7b

Rollup merge of #77017 - GuillaumeGomez:vec-missing-examples-iter, r=Dylan-DPC Add missing examples on Vec iter types r? @Dylan-DPC

view details

push time in 5 days

push eventDylan-DPC/rust

yuk1ty

commit sha 16047d46a10813a25e956e659b8861cc67c20cd2

fix typo in docs and comments

view details

Dylan DPC

commit sha bcdbe79f0c3597849eb12617b9df4aab860a8ccf

Rollup merge of #76994 - yuk1ty:fix-small-typo, r=estebank fix small typo in docs and comments Fixed `the the` to `the`, as far as I found.

view details

push time in 5 days

push eventrust-lang/mdBook

Camelid

commit sha b77942d3c8e2d62648536b317e426b5ef404d9bf

Rename `book-example` to `guide` (#1336) `book-example` is a bit of a strange name given that it's not just an example.

view details

push time in 6 days

PR merged rust-lang/mdBook

Rename `book-example` to `guide`

Closes #1319.

book-example is a bit of a strange name given that it's not just an example.

+12 -12

1 comment

35 changed files

camelid

pr closed time in 6 days

issue closedrust-lang/mdBook

Rename `book-example` to `guide`?

I know it functions as both, but it's not just "hello, world". What do you think?

closed time in 6 days

camelid

pull request commentrust-lang/mdBook

Rename `book-example` to `guide`

Thanks for the PR :)

camelid

comment created time in 6 days

PR closed rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #76864 (Don't download/sync llvm-project submodule if download-ci-llvm is set)
  • #76898 (Record tcx.def_span instead of item.span in crate metadata)
  • #76899 ([mir-opt] Introduce a new flag to enable experimental/unsound mir opts)
  • #76939 (emit errors during AbstractConst building)
  • #76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.)
  • #77044 (Liballoc bench vec use mem take not replace)
  • #77047 (Miri: more informative deallocation error messages)
  • #77050 (Typo fix: "satsify" -> "satisfy")
  • #77055 (Add #[track_caller] to more panicking Cell functions)

Failed merges:

r? @ghost

+691 -319

1 comment

42 changed files

Dylan-DPC

pr closed time in 6 days

pull request commentrust-lang/rust

Add missing examples on Vec iter types

@bors r+ rollup

GuillaumeGomez

comment created time in 6 days

pull request commentrust-lang/rust

[mir-opt] Introduce a new flag to enable experimental/unsound mir opts

failed in rollup CI

@bors r-

wesleywiser

comment created time in 6 days

delete branch Dylan-DPC/rust

delete branch : rollup-mv82a5m

delete time in 6 days

pull request commentrust-lang/mdBook

Conditionally show compile warnings when running code

1 — This may be the first time that anyone has ever actually asked about using an endpoint before doing so!

:joy:

xiaochuanyu

comment created time in 6 days

issue commentclap-rs/clap

Update to structopt 0.3 master

@CreepySkeleton is there a good reason to demean other repositories? this is against the Code of Conduct of Clap and the CLI-WG organisation.

CreepySkeleton

comment created time in 6 days

push eventDylan-DPC/rust

est31

commit sha 05c3a2b07dc66fabc874181ce1eebea192cb4b56

Add #[track_caller] to more panicking Cell functions Continuation of #74526 Adds the #[track_caller] attribute to almost all panicking Cell functions. The ones that borrow two Cells in their function body are spared, because the panic location helps pinpoint which of the two borrows failed. You'd need to have full debuginfo and backtraces enabled together with column info in order to be able to discern the cases. Column info is only available on non-Windows platforms.

view details

Dylan DPC

commit sha ab76650a19cb703503c5f239dbacd26bd3a261f4

Rollup merge of #77055 - est31:more_track_caller, r=Mark-Simulacrum Add #[track_caller] to more panicking Cell functions Continuation of #74526 Adds the #[track_caller] attribute to almost all panicking Cell functions. The ones that borrow two Cells in their function body are spared, because the panic location helps pinpoint which of the two borrows failed. You'd need to have full debuginfo and backtraces enabled together with column info in order to be able to discern the cases. Column info in debuginfo is only available on non-Windows platforms.

view details

push time in 6 days

PR opened rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #76864 (Don't download/sync llvm-project submodule if download-ci-llvm is set)
  • #76898 (Record tcx.def_span instead of item.span in crate metadata)
  • #76899 ([mir-opt] Introduce a new flag to enable experimental/unsound mir opts)
  • #76939 (emit errors during AbstractConst building)
  • #76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.)
  • #77044 (Liballoc bench vec use mem take not replace)
  • #77047 (Miri: more informative deallocation error messages)
  • #77050 (Typo fix: "satsify" -> "satisfy")
  • #77055 (Add #[track_caller] to more panicking Cell functions)

Failed merges:

r? @ghost

+691 -319

0 comment

42 changed files

pr created time in 6 days

push eventDylan-DPC/rust

follower

commit sha 0082d201f1ea8ce106f1c71562d5f2d0d2e35513

Typo fix: "satsify" -> "satisfy"

view details

Dylan DPC

commit sha 97ef2b5289fcf002a850c2590d9a0eb27ad824da

Rollup merge of #77050 - follower:patch-1, r=oli-obk Typo fix: "satsify" -> "satisfy"

view details

push time in 6 days

push eventDylan-DPC/rust

Ralf Jung

commit sha 731113b8eeef206ff27b77cb9f0dc49e2762a1b4

Miri: more informative deallocation error messages

view details

Dylan DPC

commit sha f60a8cf17ef45ba98e08781c0cd400358a8bf4a9

Rollup merge of #77047 - RalfJung:miri-dealloc, r=oli-obk Miri: more informative deallocation error messages Make sure we show the affected AllocId. r? @oli-obk

view details

push time in 6 days

push eventDylan-DPC/rust

Ivan Tham

commit sha 4a6bc77a0160a4540dea03e39642c373ca9f2a69

Liballoc bench vec use mem take not replace

view details

Dylan DPC

commit sha a66e104399528502b8c390b57406d0bec98859c1

Rollup merge of #77044 - pickfire:patch-4, r=jyn514 Liballoc bench vec use mem take not replace

view details

push time in 6 days

push eventDylan-DPC/rust

Mara Bos

commit sha db74e1f1e3e5c7497bb9af68814497c8df1fd0b8

Add cfg(target_has_atomic_equal_alignment). This is needed for Atomic::from_mut.

view details

Mara Bos

commit sha 9e3f94dabc334586d669f3aba0bded607ac782fc

Don't unwrap but report a fatal error for TargetDataLayout::parse.

view details

Mara Bos

commit sha af56ad7633668a790353f17440586e97b4e6a99b

Add feature gate ui test for cfg(target_has_atomic_load_store).

view details

Mara Bos

commit sha 54fdf54e06e3287958d906d2fb1b905b778d5e38

Add feature gate ui test for cfg(target_has_atomic_equal_alignment).

view details

Mara Bos

commit sha 668225d157d91e5c55a02aa7abc1b65ec9690ffa

Revert "Revert adding Atomic::from_mut." This reverts commit 5ef1db3622c373883571868cbdafbfbd568cddcb.

view details

Mara Bos

commit sha 7a04ff6c33c8bc9b8b1012e12a9920df52956e2f

Gate Atomic::from_mut on cfg(target_has_atomic_equal_alignment). Instead of a few hardcoded cfg(target_arch = ..) like before.

view details

Mara Bos

commit sha 5d6f1a1e32de4936e5b269b04781b2737f6d410b

Move `use align_of` in atomic.rs into the places where it is used.

view details

Mara Bos

commit sha bcc1d56917fe061071ebc539b5d2e304a44a7b00

Test that AtomicU64::from_mut is not available on x86 linux.

view details

Dylan DPC

commit sha ca93c3e082172e551e3b9f86c99f8e6ad759ae8c

Rollup merge of #76965 - fusion-engineering-forks:fix-atomic-from-mut, r=Amanieu Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut. Fixes some platform-specific problems with #74532 by using the actual alignment of the types instead of hardcoding a few `target_arch`s. r? @RalfJung

view details

push time in 6 days

push eventDylan-DPC/rust

Bastian Kauschke

commit sha d4039c55c9ef392261aeaba6c14ae81f5098139a

wip emit errors during AbstractConst building

view details

Bastian Kauschke

commit sha 30cbc9729654c66b9f54779d18f023e47112cdf2

words

view details

Bastian Kauschke

commit sha 7a02ebd828c8d9c68e8e972326ede8696fb3f6b7

bless tests

view details

Bastian Kauschke

commit sha 9a493ced748e2e3e7390fc6f28640d23cb90e67b

add test for closures in abstract consts

view details

Bastian Kauschke

commit sha 2f893e458a20a159fcf93a9a5b0435ae3ed0a67e

review

view details

Dylan DPC

commit sha 1f8002da20303d5fae1b20430486d335254b8c64

Rollup merge of #76939 - lcnr:const-evaluatable-cont, r=oli-obk emit errors during AbstractConst building There changes are currently still untested, so I don't expect this to pass CI :laughing: It seems to me like this is the direction we want to go in, though we didn't have too much of a discussion about this. r? @oli-obk

view details

push time in 6 days

push eventDylan-DPC/rust

Wesley Wiser

commit sha eb3eb8547696c984a47157ebfe9dd35d292ef2d7

[mir-opt] Introduce a new flag to enable experimental/unsound mir opts

view details

Wesley Wiser

commit sha 3498511d357e4dd5ed339dd893c6cb70ac5d7bbc

Remove unnecessary -Zunsound-mir-opts uses in tests

view details

Dylan DPC

commit sha aa2dcb3a00cb1e26445e9431c94ae69eea013cc3

Rollup merge of #76899 - wesleywiser:experimental_unsound_mir_opts_flag, r=oli-obk [mir-opt] Introduce a new flag to enable experimental/unsound mir opts This implements part of https://github.com/rust-lang/compiler-team/issues/319. The exact name of this flag was not decided as part of that MCP and some people expressed that it should include "unsound" in some way. I've chosen to use `enable-experimental-unsound-mir-opts` as the name. While long, I don't think that matters too much as really it will only be used by some mir-opt tests. If you object or have a better name, please leave a comment! r? @oli-obk cc @rust-lang/wg-mir-opt @RalfJung

view details

push time in 6 days

create barnchDylan-DPC/rust

branch : rollup-1pycdg8

created branch time in 6 days

push eventDylan-DPC/rust

Aaron Hill

commit sha e734733a9e931cbbe26cfccbdf9849faef8e5125

Record `tcx.def_span` instead of `item.span` in crate metadata This was missed in PR #75465. As a result, a few places have been using the full body span of functions, instead of just the header span.

view details

Dylan DPC

commit sha 0b0a98af63ed28a05100b29a1eb6d2f5d3a3279e

Rollup merge of #76898 - Aaron1011:fix/item-def-span, r=oli-obk Record `tcx.def_span` instead of `item.span` in crate metadata This was missed in PR #75465. As a result, a few places have been using the full body span of functions, instead of just the header span.

view details

push time in 6 days

push eventDylan-DPC/rust

est31

commit sha f05b47ccdfa63f8b4b9fb47a9aa92381801d3ff1

Don't download/sync llvm-project submodule if download-ci-llvm is set llvm-project takes > 1GB storage space and a long time to download. It's better to not download it unless needed.

view details

Dylan DPC

commit sha 3ee08ff77e1ac2ff179539032339846d13eb193a

Rollup merge of #76864 - est31:downloaded_llvm_no_clone_sources, r=Mark-Simulacrum Don't download/sync llvm-project submodule if download-ci-llvm is set llvm-project takes > 1GB storage space and a long time to download. It's better to not download it unless needed.

view details

push time in 6 days

PR closed rust-lang/rust

Rollup of 13 pull requests S-waiting-on-review rollup

Successful merges:

  • #76131 (Don't use zip to compare iterators during pretty-print hack)
  • #76150 (Don't recommend ManuallyDrop to customize drop order)
  • #76275 (Implementation of Write for some immutable ref structs)
  • #76489 (Add explanation for E0756)
  • #76581 (do not ICE on bound variables, return TooGeneric instead)
  • #76626 (Add a changelog for x.py and nag contributors until they read it)
  • #76655 (Make some methods of Pin unstable const)
  • #76659 (SimplifyComparisonIntegral: fix miscompilation)
  • #76673 (MIR pass to remove unneeded drops on types not needing drop)
  • #76783 (Only get ImplKind::Impl once)
  • #76799 (Fix cross compiling dist/build invocations)
  • #76888 (use if let instead of single match arm expressions)
  • #77022 (Reduce boilerplate for BytePos and CharPos)

Failed merges:

r? @ghost

+993 -272

5 comments

53 changed files

Dylan-DPC

pr closed time in 6 days

pull request commentrust-lang/rust

more tiny clippy cleanups

r? @Dylan-DPC

ui tests need to be updated

matthiaskrgr

comment created time in 7 days

pull request commentrust-lang/rust

Rollup of 13 pull requests

@bors r+ rollup=never p=5

Dylan-DPC

comment created time in 7 days

Pull request review commentrust-lang/rust

Add missing examples on Vec iter types

 where /// /// This `struct` is created by the `into_iter` method on [`Vec`] (provided /// by the [`IntoIterator`] trait).+///+/// # Example+///+/// ```+/// let v = vec![0, 1, 2];+/// let iter = v.into_iter();

Not sure what value it adds to the example, Given it's a vector it's assumed to be items of the same type or I missed something?

GuillaumeGomez

comment created time in 7 days

PullRequestReviewEvent

PR opened rust-lang/rust

Rollup of 13 pull requests

Successful merges:

  • #76131 (Don't use zip to compare iterators during pretty-print hack)
  • #76150 (Don't recommend ManuallyDrop to customize drop order)
  • #76275 (Implementation of Write for some immutable ref structs)
  • #76489 (Add explanation for E0756)
  • #76581 (do not ICE on bound variables, return TooGeneric instead)
  • #76626 (Add a changelog for x.py and nag contributors until they read it)
  • #76655 (Make some methods of Pin unstable const)
  • #76659 (SimplifyComparisonIntegral: fix miscompilation)
  • #76673 (MIR pass to remove unneeded drops on types not needing drop)
  • #76783 (Only get ImplKind::Impl once)
  • #76799 (Fix cross compiling dist/build invocations)
  • #76888 (use if let instead of single match arm expressions)
  • #77022 (Reduce boilerplate for BytePos and CharPos)

Failed merges:

r? @ghost

+993 -272

0 comment

53 changed files

pr created time in 7 days

push eventDylan-DPC/rust

James Whaley

commit sha b4b4a2f0927d2d1d838da1e128472ff8bf64e98b

Reduce boilerplate for BytePos and CharPos

view details

James Whaley

commit sha 9a1f1777d3602b267c78229e1d5de68fe7eab57a

Remove cast to usize for BytePos and CharPos The case shouldn't be necessary and implicitly truncating BytePos is not desirable.

view details

Dylan DPC

commit sha b441d26f4607b4e01b04c6d6e593dc89b24c5fad

Rollup merge of #77022 - Juici:master, r=lcnr Reduce boilerplate for BytePos and CharPos Reduces boilerplate code for BytePos and CharPos by using a macro to implement shared traits.

view details

push time in 7 days

push eventDylan-DPC/rust

Matthias Krüger

commit sha c690c82ad42a15417996a087ef072fd2d8c2fe3a

use if let instead of single match arm expressions to compact code and reduce nesting (clippy::single_match)

view details

Dylan DPC

commit sha 42b330322f69a531ce4ebd0f8aca1394c164cd9f

Rollup merge of #76888 - matthiaskrgr:clippy_single_match_2, r=Dylan-DPC use if let instead of single match arm expressions use if let instead of single match arm expressions to compact code and reduce nesting (clippy::single_match)

view details

push time in 7 days

push eventDylan-DPC/rust

Mark Rousskov

commit sha 7e24136996fd412ba2890952d5f0ddffb3cb7370

Pass --target to lint docs Otherwise, we may not have a standard library built for the native "host" target of the rustc being run.

view details

Mark Rousskov

commit sha bd4e0af0b54afc91903c282740e25ee6135224c8

Build rustdoc for cross-compiled targets This isn't an issue for most folks who use x.py dist, which will directly depend on this. But for x.py build, if we don't properly set target here rustdoc will not be built. Currently, there is not a default-on step for generating a rustc for a given target either, so we will fail to build a rustc as well.

view details

Mark Rousskov

commit sha 363aff0a9d0b85285b7501cb04dd8263d29d273a

Add test for x.py build cross-compilation

view details

Dylan DPC

commit sha a282d1e4cb859fcd47cd3dba3bee4bf3997669d6

Rollup merge of #76799 - Mark-Simulacrum:fix-cross-compile-dist, r=alexcrichton Fix cross compiling dist/build invocations I am uncertain why the first commit is not affecting CI. I suspect it's because we pass --disable-docs on most of our cross-compilation builders. The second commit doesn't affect CI because CI runs x.py dist, not x.py build. Both commits are standalone; together they should resolve #76733. The first commit doesn't really fix that issue but rather just fixes cross-compiled x.py dist, resolving a bug introduced in #76549.

view details

push time in 7 days

create barnchDylan-DPC/rust

branch : rollup-mv82a5m

created branch time in 7 days

push eventDylan-DPC/rust

Lzu Tao

commit sha eede953c283c7bbe903a0e8abb44c923baf5cfac

Only get ImplKind::Impl once

view details

Dylan DPC

commit sha 5e460511ffb547d418c8103f41426932c91d607f

Rollup merge of #76783 - lzutao:rd_impl_kind, r=GuillaumeGomez Only get ImplKind::Impl once With this, the code panics in one place instead of two.

view details

push time in 7 days

push eventDylan-DPC/rust

Simon Vandel Sillesen

commit sha 40a5dc8860dad243b56e75ca19a0863d5e0571b8

MIR pass to remove unneeded drops on types not needing drop This is heavily dependent on MIR inlining running to actually see the drop statement

view details

Simon Vandel Sillesen

commit sha e6942ae7515747b490bf1dd3fa292637fc6952e4

Suggestion from review Co-authored-by: Andreas Jonson <andjo403@users.noreply.github.com>

view details

Simon Vandel Sillesen

commit sha 9b61fbcd5dd64441b27071ea19e8970af55e9126

Get LocalDefId from source instead of passing in

view details

Simon Vandel Sillesen

commit sha d3724553adf988fadc548182573d80f4885a4e1c

The optimization should also apply for DropAndReplace

view details

Simon Vandel Sillesen

commit sha 1b2da2efb2793e12200674814aca0880608f3ae1

cleanup cfg after optimization

view details

Simon Vandel Sillesen

commit sha dfb9f3aa254ea7bdcaa8a0f1c9850674ad6198c9

rebless after rebase

view details

Dylan DPC

commit sha 0e5bcbab34795443b7810bb582efef562ab5f1d6

Rollup merge of #76673 - simonvandel:remove-unneeded-drops, r=oli-obk MIR pass to remove unneeded drops on types not needing drop This is heavily dependent on MIR inlining running to actually see the drop statement. Do we want to special case replacing a call to std::mem::drop with a goto aswell?

view details

push time in 7 days

more