profile
viewpoint
Dylan DPC Dylan-DPC Berlin Rustacean

crev-dev/cargo-crev 1008

A cryptographically verifiable code review system for the cargo (Rust) package manager.

AeroRust/Welcome 56

Welcome to the (Unofficial) Rust 🦀 + Aerospace 🚀 working group 🙌

AeroRust/awesome-space 39

List of awesome resources for Aerospace and Rust

AeroRust/WorkingGroup 26

Issues tracker for udeas, ongoing work, looking for mentors, mentors available, everything is in here!

chrispecoraro/mega-make 10

"php artisan make:all" for Laravel 5.5+

Dylan-DPC/cargo-doctor 7

Checks if all links mentioned in cargo docs of a crate are healthy

Dylan-DPC/const-ft 2

Macro for wrapping const fn in a feature gate

Dylan-DPC/cargo-caldera 1

Crater for packages that runs the new version on every reverse dependency

Dylan-DPC/clim-rs 1

CLI Menus

Dylan-DPC/acl 0

Dynamically configurable access control for laravel

pull request commentrust-lang/rust

Update cargo

@bors r+ rollup=never

ehuss

comment created time in 7 hours

pull request commentrust-lang/rust

Use the parking_lot locking primitives

Yes @faern understandable. But even if kept open and it is ready to be merged, it will increase the number of conflicts this has with other prs.

faern

comment created time in 8 hours

pull request commentrust-lang/rust

Rollup of 5 pull requests

@bors r+ rollup=never p=5

Dylan-DPC

comment created time in 14 hours

PR opened rust-lang/rust

Rollup of 5 pull requests

Successful merges:

  • #69181 (Change const eval to just return the value )
  • #69192 (Add more regression tests)
  • #69200 (Fix printing of Yield terminator)
  • #69205 (Allow whitespaces in revision flags)
  • #69233 (Clean up E0310 explanation)

Failed merges:

r? @ghost

+358 -137

0 comment

37 changed files

pr created time in 14 hours

push eventDylan-DPC/rust

Guillaume Gomez

commit sha 73283f1b32f2c607be6ba5d51d867f8862eca95e

Clean up E0310 explanation

view details

Dylan DPC

commit sha 210b18118e3e59ed84b87de4716b98dc4cc393bd

Rollup merge of #69233 - GuillaumeGomez:cleanup-e0310, r=Dylan-DPC Clean up E0310 explanation r? @Dylan-DPC

view details

push time in 14 hours

push eventDylan-DPC/rust

Yuki Okushi

commit sha d1a7ae7d1659dae412dde2eadeaf1cf7c9d87570

Allow whitespaces in revision flags

view details

Dylan DPC

commit sha bea18c767388da316dfcb0c7d248f206e3a88eb7

Rollup merge of #69205 - JohnTitor:allow-whitespaces, r=Mark-Simulacrum Allow whitespaces in revision flags Allow whitespaces in revision flags, like `// [foo]`. Fixes #69183

view details

push time in 14 hours

push eventDylan-DPC/rust

Jonas Schievink

commit sha 759526e513f28443b845b63176f15424686d0254

Fix printing of `Yield` terminator

view details

Jonas Schievink

commit sha bb482ebf2870bae6e1b69822f1c7d7d9d4b33103

suspend -> yield

view details

Dylan DPC

commit sha 8b93e67c3282da8c9707f78aae0c118bb41341ef

Rollup merge of #69200 - jonas-schievink:yield-print, r=eddyb,Zoxc Fix printing of `Yield` terminator Addresses the bug found in https://github.com/rust-lang/rust/issues/69039#issuecomment-586633495

view details

push time in 14 hours

push eventDylan-DPC/rust

Yuki Okushi

commit sha 6351bfd182267133409c5174decdff2071f90454

Add test for issue-39618

view details

Yuki Okushi

commit sha f32447d54138e9f42ba5a729550603573913397f

Add test for issue-51798

view details

Yuki Okushi

commit sha ecb8bf069e0a32d8c76884786a5a0b1ea7ccf8d9

Add test for issue-62894

view details

Yuki Okushi

commit sha 426dcf0da03b4287991e378c50ddb0718960941b

Add test for issue-63952

view details

Yuki Okushi

commit sha 9478503315795401ce037fbca87bf1dbf82f8d31

Add test for issue-68653

view details

Yuki Okushi

commit sha 2f39ec24b20bc1ef09c7810f8210ea48bb5a3d29

Add FIXME note

view details

Dylan DPC

commit sha d1f175b2ad2625eba5333a7557a91a03704c68b6

Rollup merge of #69192 - JohnTitor:add-tests, r=Centril Add more regression tests Closes #39618 Closes #51798 Closes #62894 Closes #63952 Closes #68653 r? @Centril

view details

push time in 14 hours

create barnchDylan-DPC/rust

branch : rollup-m6dt9cn

created branch time in 14 hours

push eventDylan-DPC/rust

Ben Lewis

commit sha c423a8649c0bac16fd4d1b9cbea657e4245bb5ac

Change const eval to return `ConstValue`, instead of `Const` as the type inside it shouldn't be used.

view details

Ben Lewis

commit sha c7aadcfa567f363e302ac797a4805668eb7bc77c

Change `const_field` and `const_caller_location` to return `ConstValue` instead of `Const` as the type in the returned const isn't needed.

view details

Ben Lewis

commit sha 99a864be39d551362bc29bb76ac06d639afedb42

Fix emulate intrinsics return type.

view details

Ben Lewis

commit sha 821f4a9dfb38dab30df861d3c19788b2e7ed0d95

Monomorphize const type during codegen.

view details

Ben Lewis

commit sha 774a029e9629a461355c9e9cb423820e9936dc65

Code review changes.

view details

Ben Lewis

commit sha 8904bddec5abea92c88e5c991925c08a3df5faf3

Determine type of intrinsics instead of assuming the destination type is the same.

view details

Dylan DPC

commit sha 391e7e26ae05a37c03300f60f6345c0006a5a62c

Rollup merge of #69181 - skinny121:const-eval-return, r=oli-obk Change const eval to just return the value As discussed in https://github.com/rust-lang/rust/pull/68505#discussion_r370956535, the type of consts shouldn't be returned from const eval queries. r? @eddyb cc @nikomatsakis

view details

push time in 14 hours

pull request commentrust-lang/rust

Clean up E0310 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 14 hours

PR closed rust-lang/rust

Rollup of 5 pull requests S-waiting-on-review rollup

Successful merges:

  • #67272 (recursion_limit parsing handles overflows)
  • #68597 (Simplify Skip::nth and Skip::last implementations)
  • #68767 (macOS: avoid calling pthread_self() twice)
  • #69175 (Do not ICE when encountering yield inside async block)
  • #69223 (Ignore GDB versions with broken str printing.)

Failed merges:

r? @ghost

+141 -24

7 comments

17 changed files

Dylan-DPC

pr closed time in 17 hours

pull request commentrust-lang/rust

Use the parking_lot locking primitives

Everyone. The author, reviewers, triagists

faern

comment created time in a day

push eventrust-lang/mdBook

Sergey Pedan

commit sha 0da7ba4abeb0bbb26112183f1e252ee4d39d630f

Corrects inner/outer space in sidebar <li>s (#1137)

view details

push time in a day

PR merged rust-lang/mdBook

Corrects inner/outer space in sidebar <li>s

A multiline element (<p>, <li>, a block of text etc.) has inner space (space between its lines). That space should be smaller than that element's outer margin (distance to another element).

explanation

+5 -0

0 comment

1 changed file

sergeypedan

pr closed time in a day

pull request commentrust-lang/rust

Rollup of 5 pull requests

@bors retry

Dylan-DPC

comment created time in a day

pull request commentrust-lang/rust

Update Clippy

@bors rollup=never

JohnTitor

comment created time in 2 days

pull request commentrust-lang/rust

Rollup of 5 pull requests

@bors r+ p=5 rollup=never

Dylan-DPC

comment created time in 2 days

create barnchDylan-DPC/rust

branch : rollup-1arlnmr

created branch time in 2 days

PR opened rust-lang/rust

Rollup of 5 pull requests

Successful merges:

  • #67272 (recursion_limit parsing handles overflows)
  • #68597 (Simplify Skip::nth and Skip::last implementations)
  • #68767 (macOS: avoid calling pthread_self() twice)
  • #69175 (Do not ICE when encountering yield inside async block)
  • #69223 (Ignore GDB versions with broken str printing.)

Failed merges:

r? @ghost

+141 -24

0 comment

17 changed files

pr created time in 2 days

push eventDylan-DPC/rust

spunit262

commit sha a9b5c692d9319a993ca5dfa6e853a3f5d3f68079

Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

Dylan DPC

commit sha 386b49447e579bc95800e6ba9acb2ac41607ea1c

Rollup merge of #69223 - spunit262:empty-string-gdb-version, r=Dylan-DPC Ignore GDB versions with broken str printing. https://sourceware.org/bugzilla/show_bug.cgi?id=22236

view details

push time in 2 days

push eventDylan-DPC/rust

Esteban Küber

commit sha e5b2c66dea8e2d721612089ebfa00e0799cd5e50

Do not ICE when encountering `yield` inside `async` block

view details

Dylan DPC

commit sha 5ba1dd7cf76c98f5388de4daa0ea6a9959c6b6b9

Rollup merge of #69175 - estebank:shall-not-ice, r=petrochenkov Do not ICE when encountering `yield` inside `async` block Fix #67158.

view details

push time in 2 days

push eventDylan-DPC/rust

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

Dylan DPC

commit sha a70b757edfd335b7c02f8c53dc20d47dcd4a824a

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

push time in 2 days

push eventDylan-DPC/rust

Oliver Middleton

commit sha 84f3356e0dffc36f57d9be7902822db5d362e24f

Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

Dylan DPC

commit sha 034b3340db711c5f2182552dd96c8983ec02410e

Rollup merge of #68597 - ollie27:skip_nth_last, r=Amanieu Simplify `Skip::nth` and `Skip::last` implementations The main improvement is to make `last` no longer recursive.

view details

push time in 2 days

push eventDylan-DPC/rust

Fisher Darling

commit sha c53693d34d83e6221dc8b93a2c4e17e66fa6f0e2

Handle recursion_limit parsing errors

view details

Dylan DPC

commit sha 3747a48a2e60a28424791289c02da664fb9144b8

Rollup merge of #67272 - fisherdarling:master, r=varkor,hellow554 recursion_limit parsing handles overflows This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`. closes #67265

view details

push time in 2 days

Pull request review commentrust-lang/rust

Clean up E0310 explanation

 struct Foo<T> { } ``` +Type parameters in type definitions have lifetimes associated with them that+represent how long the data stored within them is guaranteed to be live. This
represent how long the data stored within them is guaranteed to live. This
GuillaumeGomez

comment created time in 2 days

Pull request review commentrust-lang/rust

Clean up E0310 explanation

-Types in type definitions have lifetimes associated with them that represent-how long the data stored within them is guaranteed to be live. This lifetime-must be as long as the data needs to be alive, and missing the constraint that-denotes this will cause this error.+A parameter type is missing a lifetime constraint or has a lifetime that+doesn't live long enough.
does not live long enough.
GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Ignore GDB versions with broken str printing.

@bors r+ rollup

spunit262

comment created time in 2 days

pull request commentrust-lang/rust

Rollup of 6 pull requests

@bors r+ rollup=never p=6

Dylan-DPC

comment created time in 2 days

PR opened rust-lang/rust

Rollup of 6 pull requests

Successful merges:

  • #68495 (Updating str.chars docs to mention crates.io.)
  • #68701 (Improve #Safety of various methods in core::ptr)
  • #68767 (macOS: avoid calling pthread_self() twice)
  • #69186 ([tiny] parser: macro_rules is a weak keyword)
  • #69188 (Clean up E0309 explanation)
  • #69208 (debug_assert a few more raw pointer methods)

Failed merges:

r? @ghost

+58 -27

0 comment

9 changed files

pr created time in 2 days

push eventDylan-DPC/rust

Ralf Jung

commit sha bec5d37ee19c33bec96ed235f0197317d3728e0a

debug_assert a few more raw pointer methods

view details

Dylan DPC

commit sha b0052c4a1ad79dff462814148cb6a37fa2a48690

Rollup merge of #69208 - RalfJung:debug-assert, r=Mark-Simulacrum debug_assert a few more raw pointer methods Fixes https://github.com/rust-lang/rust/issues/53871

view details

push time in 2 days

push eventDylan-DPC/rust

Guillaume Gomez

commit sha cadf9efad123a62472cad45f22569747cc599256

Clean up E0309 explanation

view details

Dylan DPC

commit sha 5c96c06b32585537694a48954f160c602ff0d655

Rollup merge of #69188 - GuillaumeGomez:clean-up-e0309, r=Dylan-DPC Clean up E0309 explanation r? @Dylan-DPC

view details

push time in 2 days

push eventDylan-DPC/rust

Vadim Petrochenkov

commit sha dcad07af8aa831344fd3be353c71379854637c21

parser: `macro_rules` is a weak keyword

view details

Dylan DPC

commit sha 3b7747762de7ae43e5bf3d90bb1665cc72dd4eb5

Rollup merge of #69186 - petrochenkov:kwrules, r=Centril [tiny] parser: `macro_rules` is a weak keyword r? @Centril

view details

push time in 2 days

push eventDylan-DPC/rust

Hiroki Noda

commit sha 67068f35dd41409c8e79710f1335cc9dc64f1860

macOS: avoid calling pthread_self() twice

view details

Dylan DPC

commit sha 0ee11770b65c7a0f8327b8963b82eb526a7c9af2

Rollup merge of #68767 - kubo39:patch-macos, r=shepmaster macOS: avoid calling pthread_self() twice

view details

push time in 2 days

push eventDylan-DPC/rust

Amos Onn

commit sha 302b9e4b540cc352e75d3de6f803a99147107a50

Improve #Safety in various methods in core::ptr s/for reads and writes/for both ...

view details

Amos Onn

commit sha 351782d30aaa6e15204e17ecdd51ac1e712685cf

Improve #Safety of core::ptr::replace Added missing condition: `dst` must be readable

view details

Amos Onn

commit sha 40ca16794456e9b1520bba6d887a176395f127f0

Improve #Safety in various methods in core::ptr For all methods which read a value of type T, `read`, `read_unaligned`, `read_volatile` and `replace`, added missing constraint: The value they point to must be properly initialized

view details

Amos Onn

commit sha 943e65396d7bc7b91bcc30407d323d06f4b20a22

Improve #Safety of core::ptr::drop_in_place Added missing conditions: - Valid for writes - Valid for destructing

view details

Dylan DPC

commit sha c1cda01825ffc91d4e52656cbc718475f00c0cab

Rollup merge of #68701 - amosonn:patch-2, r=RalfJung Improve #Safety of various methods in core::ptr For `read`, `read_unaligned`,`read_volatile`, `replace`, and `drop_in_place`: - The value they point to must be properly initialized For `replace`, additionally: - The pointer must be readable

view details

push time in 2 days

push eventDylan-DPC/rust

Steven Degutis

commit sha ac19dffd1eaea34c3861324c2588f9cb1f1489f5

Updating str.chars docs to mention crates.io. This might spare someone else a little time searching the stdlib for unicode/grapheme support.

view details

Dylan DPC

commit sha 78deb9333eeb8b99c2e5b3a5c757361b5812c1f2

Rollup merge of #68495 - sdegutis:patch-1, r=Mark-Simulacrum Updating str.chars docs to mention crates.io. This might spare someone else a little time searching the stdlib for unicode/grapheme support.

view details

push time in 2 days

create barnchDylan-DPC/rust

branch : rollup-zy3ttg5

created branch time in 2 days

pull request commentrust-lang/rust

Simplify `Skip::nth` and `Skip::last` implementations

r? @kodrAus

ollie27

comment created time in 3 days

pull request commentrust-lang/rust

Use `ResultsCursor` for `elaborate_drops`

@bors p=1

ecstatic-morse

comment created time in 3 days

PR closed rust-lang/rust

Rollup of 5 pull requests S-waiting-on-review

Successful merges:

  • #69120 (Don't give invalid suggestion on desugared span.)
  • #69156 (Use ResultsCursor for elaborate_drops)
  • #69158 (Don't print block exit state in dataflow graphviz if unchanged)
  • #69179 (Rename FunctionRetTy to FnRetTy)
  • #69186 ([tiny] parser: macro_rules is a weak keyword)

Failed merges:

r? @ghost

+243 -278

6 comments

51 changed files

Dylan-DPC

pr closed time in 3 days

pull request commentrust-lang/rust

On privacy error caused by private reexport, use spans to show the `use` chain

@estebank this is unblocked now

estebank

comment created time in 3 days

pull request commentrust-lang/rust

Use the parking_lot locking primitives

@faern how about closing this PR and reopening it once the parking lot issues are settled? Would probably be easier that way

faern

comment created time in 3 days

pull request commentrust-lang/rust

Add `IntoIterator` impl for arrays by value (`for [T; N]`)

r? @Amanieu

LukasKalbertodt

comment created time in 3 days

pull request commentrust-lang/rust

Rollup of 5 pull requests

@bors r+ rollup=never p=6

Dylan-DPC

comment created time in 3 days

PR opened rust-lang/rust

Rollup of 5 pull requests

Successful merges:

  • #69120 (Don't give invalid suggestion on desugared span.)
  • #69156 (Use ResultsCursor for elaborate_drops)
  • #69158 (Don't print block exit state in dataflow graphviz if unchanged)
  • #69179 (Rename FunctionRetTy to FnRetTy)
  • #69186 ([tiny] parser: macro_rules is a weak keyword)

Failed merges:

r? @ghost

+243 -278

0 comment

51 changed files

pr created time in 3 days

push eventDylan-DPC/rust

Vadim Petrochenkov

commit sha dcad07af8aa831344fd3be353c71379854637c21

parser: `macro_rules` is a weak keyword

view details

Dylan DPC

commit sha 5f6432bc8d62a08ea2627a4ddb89f935e9c91585

Rollup merge of #69186 - petrochenkov:kwrules, r=Centril [tiny] parser: `macro_rules` is a weak keyword r? @Centril

view details

push time in 3 days

push eventDylan-DPC/rust

Yuki Okushi

commit sha 5c962c71971ff4a1bc45df803f08b7e91bc81bdd

Rename `FunctionRetTy` to `FnRetTy`

view details

Dylan DPC

commit sha e68bebaf3fcaed36ee493501ad802576be77075b

Rollup merge of #69179 - JohnTitor:rename-to-fnretty, r=Centril Rename `FunctionRetTy` to `FnRetTy` As per FIXME comment r? @Centril

view details

push time in 3 days

push eventDylan-DPC/rust

Dylan MacKenzie

commit sha 5c473a059e26614b65414cfb8cf75c283cda5a87

Don't print block exit state if unchanged

view details

Dylan DPC

commit sha 1034f9636559b30973e11904ddfc44481757e6b9

Rollup merge of #69158 - ecstatic-morse:graphviz-diff, r=matthewjasper Don't print block exit state in dataflow graphviz if unchanged A small quality-of-life improvement I was using while working on #68528. It's pretty common to have a lot of zero-statement basic blocks, especially before a `SimplifyCfg` pass is run. When the dataflow state was dense, these blocks could take up a lot of vertical space since the full flow state was printed on both entry and exit. After this PR, we only print a block's exit state if it differs from that block's entry state. Take a look at the two basic blocks on the left. Before: ![image](https://user-images.githubusercontent.com/29463364/74505395-e2d1dd00-4eab-11ea-8006-ec8f0dc9d1b6.png) After: ![image](https://user-images.githubusercontent.com/29463364/74505277-98506080-4eab-11ea-8d95-5190bc378331.png)

view details

push time in 3 days

push eventDylan-DPC/rust

Dylan MacKenzie

commit sha 95186201724a087bacafc74317722314f203cfdc

Use `ResultsCursor` for `elaborate_drops` The old code hard-coded the transfer function for the initialized places analyses.

view details

Dylan MacKenzie

commit sha f0260ae196b62f27c64738d52519efb424724915

Use `seek_before` instead of `seek_after`

view details

Dylan MacKenzie

commit sha 2aa39350d3dde13f5e82f24d42a51cbfe92f723e

Use more descriptive name to get `InitializationData` state

view details

Dylan MacKenzie

commit sha 26451d007e7482f0c4cdae152a972f4e7c8bf970

Print flow state in debug messages for `find_dead_unwinds`

view details

Dylan DPC

commit sha 4b95dc7993e22f2f884caf0be6ec629dd55f9f8d

Rollup merge of #69156 - ecstatic-morse:unified-dataflow-impls2, r=eddyb Use `ResultsCursor` for `elaborate_drops` Some cleanup after #68241. The old code was using a custom cursor-like struct called `InitializationData`.

view details

push time in 3 days

push eventDylan-DPC/rust

spunit262

commit sha 30d4f1b78d997fb555388cb8ebea474ffb85794c

Don't give invalid suggestion on desugared span.

view details

Dylan DPC

commit sha b44269c83adc5c16603b61b111768a8c85c5aa92

Rollup merge of #69120 - spunit262:invalid-sugar-suggest, r=matthewjasper Don't give invalid suggestion on desugared span.

view details

push time in 3 days

create barnchDylan-DPC/rust

branch : rollup-7lx4ajs

created branch time in 3 days

pull request commentrust-lang/rust

Clean up E0309 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 3 days

pull request commentuuid-rs/uuid

Fix unspecified direct object in README

bors: r+

cedric-h

comment created time in 4 days

pull request commentrust-lang/rust

Rollup of 6 pull requests

@bors r+ rollup=never p=6

Dylan-DPC

comment created time in 4 days

PR opened rust-lang/rust

Rollup of 6 pull requests

Successful merges:

  • #64069 (Added From<Vec<NonZeroU8>> for CString)
  • #66721 (implement LowerExp and UpperExp for integers)
  • #69106 (Fix std::fs::copy on WASI target)
  • #69154 (Avoid calling fn_sig on closures)
  • #69166 (Check has_typeck_tables before calling typeck_tables_of)
  • #69180 (Suggest a comma if a struct initializer field fails to parse)

Failed merges:

r? @ghost

+387 -7

0 comment

14 changed files

pr created time in 4 days

push eventDylan-DPC/rust

Aaron Hill

commit sha 98757f14d0242e6dcae258df8aeb7e17580702ef

Suggest a comma if a struct initializer field fails to parse Currently, we emit a "try adding a comma" suggestion if a comma is missing in a struct definition. However, we emit no such suggestion if a comma is missing in a struct initializer. This commit adds a "try adding a comma" suggestion when we don't find a comma during the parsing of a struct initializer field. The change to `src/test/ui/parser/removed-syntax-with-1.stderr` isn't great, but I don't see a good way of avoiding it.

view details

Dylan DPC

commit sha e9db0613acb2dfdb6a892873d59d0626b20c6cc8

Rollup merge of #69180 - Aaron1011:feature/comma-struct-init, r=petrochenkov Suggest a comma if a struct initializer field fails to parse Currently, we emit a "try adding a comma" suggestion if a comma is missing in a struct definition. However, we emit no such suggestion if a comma is missing in a struct initializer. This commit adds a "try adding a comma" suggestion when we don't find a comma during the parsing of a struct initializer field. The change to `src/test/ui/parser/removed-syntax-with-1.stderr` isn't great, but I don't see a good way of avoiding it.

view details

push time in 4 days

push eventDylan-DPC/rust

Yuki Okushi

commit sha be92200af7ac732063500a96890ed0354dcc490b

Check `has_typeck_tables` before calling `typeck_tables_of`

view details

Dylan DPC

commit sha 09d6a657b1396d8ed9ce052df4a45d4ef47fa608

Rollup merge of #69166 - JohnTitor:ice-const-enum, r=matthewjasper Check `has_typeck_tables` before calling `typeck_tables_of` Fixes #68684 r? @matthewjasper

view details

push time in 4 days

push eventDylan-DPC/rust

Yuki Okushi

commit sha 47aa2b5bfd35d3e094b55a1a2841698f2765e419

Avoid calling `fn_sig` on closures

view details

Dylan DPC

commit sha c115ad927a2dc24400de60dc280a9e7029b9bd44

Rollup merge of #69154 - JohnTitor:fix-macro-ices, r=petrochenkov Avoid calling `fn_sig` on closures Fixes #68060 r? @petrochenkov

view details

push time in 4 days

push eventDylan-DPC/rust

Ingvar Stepanyan

commit sha 8fb8bb4b3ff25570a7a9b105c1a569bb2307f25f

Fix std::fs::copy on WASI target Previously `std::fs::copy` on wasm32-wasi would reuse code from the `sys_common` module and would successfully copy contents of the file just to fail right before closing it. This was happening because `sys_common::copy` tries to copy permissions of the file, but permissions are not a thing in WASI (at least yet) and `set_permissions` is implemented as an unconditional runtime error. This change instead adds a custom working implementation of `std::fs::copy` (like Rust already has on some other targets) that doesn't try to call `set_permissions` and is essentially a thin wrapper around `std::io::copy`. Fixes #68560.

view details

Dylan DPC

commit sha 728be34ebc716aa90cc525b42282d6c9f461b67b

Rollup merge of #69106 - RReverser:wasi-fs-copy, r=KodrAus Fix std::fs::copy on WASI target Previously `std::fs::copy` on wasm32-wasi would reuse code from the `sys_common` module and would successfully copy contents of the file just to fail right before closing it. This was happening because `sys_common::copy` tries to copy permissions of the file, but permissions are not a thing in WASI (at least yet) and `set_permissions` is implemented as an unconditional runtime error. This change instead adds a custom working implementation of `std::fs::copy` (like Rust already has on some other targets) that doesn't try to call `set_permissions` and is essentially a thin wrapper around `std::io::copy`. Fixes #68560.

view details

push time in 4 days

push eventDylan-DPC/rust

Max Blachman

commit sha a8fe47d1756df0fb68f6ed2edd2cedfb3cc66d7c

implement LowerExp and UpperExp for integers

view details

Dylan DPC

commit sha afea30dc27b781e4a9843d7b39b0aa32426c1df1

Rollup merge of #66721 - maxbla:exp-format-integers, r=KodrAus implement LowerExp and UpperExp for integers Addresses https://github.com/rust-lang/rust/issues/39479 This implementation is heavily based on the preexisting `macro_rules! impl_Display` in the same file. I don't like the liberal use of unsafe in that macro and would like to modify it so `unsafe` is only present where necessary. What is Rust's policy on doing such modifications? Also, I couldn't figure out where to put tests, can I have some help with that?

view details

push time in 4 days

create barnchDylan-DPC/rust

branch : rollup-ifsa9fx

created branch time in 4 days

push eventDylan-DPC/rust

Daniel Henry-Mantilla

commit sha 60274a95fef57a18113f7c48be68be31ece860eb

Added From<Vec<NonZeroU8>> for CString Updated tracking issue number Added safeguards for transmute_vec potentially being factored out elsewhere Clarified comment about avoiding mem::forget Removed unneeded unstable guard Added back a stability annotation for CI Minor documentation improvements Thanks to @Centril's code review Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com> Improved layout checks, type annotations and removed unaccurate comment Removed unnecessary check on array layout Adapt the stability annotation to the new 1.41 milestone Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com> Simplify the implementation. Use `Vec::into_raw_parts` instead of a manual implementation of `Vec::transmute`. If `Vec::into_raw_parts` uses `NonNull` instead, then the code here will need to be adjusted to take it into account (issue #65816) Reduce the whitespace of safety comments

view details

Dylan DPC

commit sha d28b35812fe6e72c8a499dee73e6687816fe829a

Rollup merge of #64069 - danielhenrymantilla:feature/cstring_from_vec_of_nonzerou8, r=KodrAus Added From<Vec<NonZeroU8>> for CString Added a `From<Vec<NonZeroU8>>` `impl` for `CString` # Rationale - `CString::from_vec_unchecked` is a subtle function, that makes `unsafe` code harder to audit when the generated `Vec`'s creation is non-trivial. This `impl` allows to write safer `unsafe` code thanks to the very explicit semantics of the `Vec<NonZeroU8>` type. - One such situation is when trying to `.read()` a `CString`, see issue #59229. - this lead to a PR: #59314, that was closed for being too specific / narrow (it only targetted being able to `.read()` a `CString`, when this pattern could have been generalized). - the issue suggested another route, based on `From<Vec<NonZeroU8>>`, which is indeed a less general and more concise code pattern. - quoting @shnatsel: - > For me the main thing about making this safe is simplifying auditing - people have spent like an hour looking at just this one unsafe block in libflate because it's not clear what exactly is unchecked, so you have to look it up when auditing anyway. This has distracted us from much more serious memory safety issues the library had. Having this trivial impl in stdlib would turn this into safe code with compiler more or less guaranteeing that it's fine, and save anyone auditing the code a whole lot of time.

view details

push time in 4 days

pull request commentrust-lang/rust

implement LowerExp and UpperExp for integers

Not yet xD

We don't do merges here so it will be nice if you could revert the merge and rebase instead.

maxbla

comment created time in 4 days

pull request commentrust-lang/rust

Add `take_...` functions to slices

@cramertj any updates

cramertj

comment created time in 4 days

issue commentclap-rs/clap

[Feature request] Default values for an argument with multiple values

Yeah go ahead. I like the idea of having the slice as a parameter

tprodanov

comment created time in 5 days

pull request commentrust-lang/rust

Update pulldown-cmark dependency

@bors r+

GuillaumeGomez

comment created time in 5 days

pull request commentrust-lang/rust

Update books.

@bors r+ rollup=never p=1

ehuss

comment created time in 5 days

pull request commentrust-lang/rust

Construct query job latches on-demand

@bors p=1

Zoxc

comment created time in 5 days

Pull request review commentclap-rs/clap

Update issue templates

+---+name: Bug report+about: An issue with clap, clap_derive or clap_generate+title: ''+labels: 'T: bug'+assignees: ''++---++<!--+Please use the following template to assist with creating an issue and to ensure a speedy resolution. If an area is not applicable, feel free to delete the area or mark with `N/A`+-->++### Rust Version++Use the output of `rustc -V`++### Affected Version of `clap*`++Can be found in Cargo.lock or Cargo.toml of your project (i.e. `grep clap Cargo.lock`). PLEASE DO NOT PUT "latest" HERE, use precise version. Put `master` (or other branch) if you're using the repo directly. ++### Expected Behavior Summary++When I do like *this*, *that* is happening and I think it shouldn't.++### Actual Behavior Summary++I think *this* should happen instead.++### Steps to reproduce the issue++1. Write *this* code '...'+2. Run `cargo run` '....'+3. See error++### Additional context

Is this blocking / is this high priority would be nice (explained below as well)

CreepySkeleton

comment created time in 5 days

Pull request review commentclap-rs/clap

Update issue templates

+---+name: Documentation issue+about: An issue with our docs, like typo, something's missing, incorrect docs, etc...+title: ''+labels: 'C: docs'

Same as below (sorry xD)

CreepySkeleton

comment created time in 5 days

Pull request review commentclap-rs/clap

Update issue templates

+---+name: Bug report+about: An issue with clap, clap_derive or clap_generate+title: ''+labels: 'T: bug'

Same as below

CreepySkeleton

comment created time in 5 days

Pull request review commentclap-rs/clap

Update issue templates

+---

I am not sure we need this. We should encourage people to use the forums (discord / zulip / u.r.l.o / Reddit) instead for faster chances of solution.

CreepySkeleton

comment created time in 5 days

Pull request review commentclap-rs/clap

Update issue templates

+---+name: Feature request+about: Suggest an idea for this project+title: ''+labels: 'T: new feature'+assignees: ''++---++### Describe your use case++Describe the problem you're trying to solve. This is not mandatory and we *do* consider features without a specific use case, but real problems have priority.++Also, please follow your explanation with a snippet of code, if applicable. ++### Describe the solution you'd like++Please explain what the wanted solution should look like. You **strongly encouraged** to attach a snippet of (pseudo)code.++### Alternatives, if applicable++A clear and concise description of any alternative solutions or features you've managed to come up with.++### Additional context

Would like an added "is this blocking" or "is this a high priority" option

CreepySkeleton

comment created time in 5 days

Pull request review commentclap-rs/clap

Update issue templates

+---+name: Bug report+about: An issue with clap, clap_derive or clap_generate+title: ''+labels: 'T: bug'+assignees: ''++---++<!--+Please use the following template to assist with creating an issue and to ensure a speedy resolution. If an area is not applicable, feel free to delete the area or mark with `N/A`+-->++### Rust Version++Use the output of `rustc -V`++### Affected Version of `clap*`++Can be found in Cargo.lock or Cargo.toml of your project (i.e. `grep clap Cargo.lock`). PLEASE DO NOT PUT "latest" HERE, use precise version. Put `master` (or other branch) if you're using the repo directly. ++### Expected Behavior Summary+

Looks like the descriptions are interchanged. This should be for actual behaviour

CreepySkeleton

comment created time in 5 days

Pull request review commentclap-rs/clap

Update issue templates

+---+name: Feature request+about: Suggest an idea for this project+title: ''+labels: 'T: new feature'

This should be for us to decide not the author

CreepySkeleton

comment created time in 5 days

pull request commentrust-lang/rust

Rollup of 9 pull requests

@bors r+ p=9 rollup=never

Dylan-DPC

comment created time in 5 days

push eventDylan-DPC/rust

Mark Mansi

commit sha 23cb749bbb5c57e85a89b72a76299df1aef464e7

don't error on network failures

view details

Dylan DPC

commit sha 7704e590ece52ef265e0ca16bce1180930b69330

Rollup merge of #69141 - mark-i-m:proper-linkcheck-2, r=Dylan-DPC Don't error on network failures This should further reduce spurious failures. r? @JohnTitor and/or @ehuss

view details

push time in 5 days

PR opened rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #68728 (parse: merge fn syntax + cleanup item parsing)
  • #68938 (fix lifetime shadowing check in GATs)
  • #69057 (expand: misc cleanups and simplifications)
  • #69108 (Use HirId in TraitCandidate.)
  • #69125 (Add comment to SGX entry code)
  • #69126 (miri: fix exact_div)
  • #69127 (Enable use after scope detection in the new LLVM pass manager)
  • #69135 (Spelling error "represening" to "representing")
  • #69141 (Don't error on network failures)

Failed merges:

r? @ghost

+754 -866

0 comment

62 changed files

pr created time in 5 days

push eventDylan-DPC/rust

Drew Ripberger

commit sha 026dec550002356ea52a0800db5de0f361631f56

Spelling error "represening" to "representing"

view details

Dylan DPC

commit sha 0bdf568ce4a9772aab0ae0cff9ba2774b02e8b3d

Rollup merge of #69135 - drewrip:drewrip-spelling, r=jonas-schievink Spelling error "represening" to "representing" Small spelling mistake I noticed when looking through the Rust lexer.

view details

push time in 5 days

push eventDylan-DPC/rust

Tomasz Miąsko

commit sha 91b4a24219f33b7ad28b5ba147d50bc160c6f56c

Enable use after scope detection in the new LLVM pass manager Implementation of 08a1c566a792dcf9657d293155f7ada87746bb65 for the new LLVM pass manager, support for which landed in the meantime.

view details

Dylan DPC

commit sha a8a2c141ecc66274690a81e692ea982eb557e7ec

Rollup merge of #69127 - tmiasko:new-pass-manager-use-after-scope, r=nikic Enable use after scope detection in the new LLVM pass manager Implementation of 08a1c566a792dcf9657d293155f7ada87746bb65 for the new LLVM pass manager, support for which landed in the meantime.

view details

push time in 5 days

push eventDylan-DPC/rust

Ralf Jung

commit sha 10f342abae4e9aafb02c3adaaa050f43eb0e2dd0

miri: fix exact_div

view details

Dylan DPC

commit sha c8343b8653cdb0fb6cabf588ddee2fef07635b35

Rollup merge of #69126 - RalfJung:exact-div, r=oli-obk miri: fix exact_div Turns out `exact_div` was relying on the broken behavior of `Rem` for `int_min % -1` that was fixed in https://github.com/rust-lang/rust/pull/69002. This PR fixes `exact_div`. Inside rustc, `exact_div` is only used in a single place where the divisor is always positive (in `ptr_offset_from`), so we cannot test the fix in rustc. The Miri test suite covers this through the `exact_div` intrinsic, though (and it is how I found out). One step to https://github.com/rust-lang/rust/issues/69117 (then we also need to address build failures introduced by https://github.com/rust-lang/rust/pull/68969) r? @oli-obk

view details

push time in 5 days

push eventDylan-DPC/rust

Jethro Beekman

commit sha 57a62f5335c1e8178802d00dfac94212726ee240

Add comment to SGX entry code

view details

Dylan DPC

commit sha 8e2772c0fdab55695d0a607f50e7deaa329e7189

Rollup merge of #69125 - jethrogb:jb/cleanup-sgx-entry, r=Dylan-DPC Add comment to SGX entry code Meant to force push this to be included in #69040, but forgot r? @nagisa

view details

push time in 5 days

push eventDylan-DPC/rust

Camille GILLOT

commit sha 4706c38e17349793b2713947f81cfa1fd1f75ba3

Use HirId in TraitCandidate.

view details

Camille GILLOT

commit sha 2a899e2a2f3eb442af7637f3b9fce529f8441978

Make TraitCandidate generic.

view details

Dylan DPC

commit sha b5ee867b509f990891d780210eb9d3cd394eb3e8

Rollup merge of #69108 - cjgillot:trait_candidate, r=Zoxc Use HirId in TraitCandidate. I had to duplicate the `TraitMap` type to hold `NodeId`s until AST->HIR lowering is done. r? @Zoxc

view details

push time in 5 days

push eventDylan-DPC/rust

Mazdak Farrokhzad

commit sha 4f17dce4dc722e56d5d5069e7317feb17c1de5cc

StripUnconfigured::in_cfg: simplify with slice patterns

view details

Mazdak Farrokhzad

commit sha b8b32a9be341761c3927843c27042febbe8ea39a

simplify config::features

view details

Mazdak Farrokhzad

commit sha 64ea295fe92236e5e5162722f5242f5837af7ee1

expand: extract error_derive_forbidden_on_non_adt

view details

Mazdak Farrokhzad

commit sha acad03342412961536641d53628d7ccaa189279b

expand: extract error_recursion_limit_reached

view details

Mazdak Farrokhzad

commit sha 7518492315346ac3821ad9264e08721a571742c8

expand: extract error_wrong_fragment_kind

view details

Mazdak Farrokhzad

commit sha fcce5fa6e7ba67db63674dc7369125875c7f39a2

expand: simplify classify_*

view details

Mazdak Farrokhzad

commit sha dc6bd6a12347f27c937c19adfda542f694fb61c5

expand: simplify flat_map_item

view details

Mazdak Farrokhzad

commit sha ec434500157c47143a9b5600a7e34522c49f4e8e

expand: simplify flat_map_item wrt. inline module detection

view details

Dylan DPC

commit sha fc51170af5425853dc28997b39f91755b3c386c4

Rollup merge of #69057 - Centril:clean-expand, r=petrochenkov expand: misc cleanups and simplifications Some work I did while trying to understand expand for the purposes of https://github.com/rust-lang/rust/issues/64197. r? @petrochenkov

view details

push time in 5 days

push eventDylan-DPC/rust

Mikhail Babenko

commit sha 953f6ecb6adc37b4f8e52102c1e7ca86cc5bc92c

fix lifetime shadowing check in GATs

view details

Dylan DPC

commit sha 998daf36b9b71549af6606fac8a30c39c21d9218

Rollup merge of #68938 - Areredify:gat_lifetime_shadowing, r=estebank fix lifetime shadowing check in GATs closes #67512

view details

push time in 5 days

create barnchDylan-DPC/rust

branch : rollup-apt6zjj

created branch time in 5 days

push eventDylan-DPC/rust

Mazdak Farrokhzad

commit sha 9fed2d587c9d9f28003e23255b863897bd22a8b2

parser: extract common foreign item code for each kind

view details

Mazdak Farrokhzad

commit sha 7737d0ffdef6f3d7395e80291e3143522f46b95b

parser: unify item list parsing. as a consequence, `trait X { #![attr] }` becomes legal.

view details

Mazdak Farrokhzad

commit sha 511dfdb8b3d8c6d395b1b5a205c3464ae802509f

parser: extract `recover_missing_kw_before_item`

view details

Mazdak Farrokhzad

commit sha 73d5970cdc304c874cd6d7d594f3abb7317f1519

parser: introduce `parse_item_kind` as central `ItemInfo` logic. this also extracts macro item parsers.

view details

Mazdak Farrokhzad

commit sha 20ba6875e695dd985ba7f8974cc10c665f687670

parser_item_mod: avoid cloning outer attributes

view details

Mazdak Farrokhzad

commit sha c2026030b5d761a83d62c7e198057b119addcfd1

parser: remove `Option<Vec<Attribute>>` in `ItemInfo`.

view details

Mazdak Farrokhzad

commit sha fd64b3bcdfcc844b9b25318106917937f7b17b94

parser: make `eat_macro_def` redundant.

view details

Mazdak Farrokhzad

commit sha 15e07a6a11bc5ed86e33403eb4b7d718d1636855

parser: fuse `trait` parsing & layer with `is_path_start_item`

view details

Mazdak Farrokhzad

commit sha 46d3ef58a8a184b5a76098b2ac0e66792a6def25

parser: extract `recover_const_mut`.

view details

Mazdak Farrokhzad

commit sha aaaf0ba072815d275820d8ac85ece6eeb9182321

parser: misc small item related improvements & cleanups.

view details

Mazdak Farrokhzad

commit sha ad72c3abb9a7f9746d6ccc381e69ba88fb15b5cd

parser: inline parse_assoc_macro_invoc

view details

Dylan DPC

commit sha 89f5dcfb4316891fafb34d211b7bebc4cf8638d0

Rollup merge of #68728 - Centril:towards-fn-merge, r=petrochenkov parse: merge `fn` syntax + cleanup item parsing Here we continue the work in https://github.com/rust-lang/rust/pull/67131 in particular to merge the grammars of `fn` items in various positions. A list of *language level* changes (as sanctioned by the language team in https://github.com/rust-lang/rust/issues/65041#issuecomment-538105286 and https://github.com/rust-lang/rust/pull/67131): - `self` parameters are now *syntactically* allowed as the first parameter irrespective of item context (and in function pointers). Instead, semantic validation (`ast_validation`) is used. - Syntactically, `fn` items in `extern { ... }` blocks can now have bodies (`fn foo() { ... }` as opposed to `fn foo();`). As above, we use semantic restrictions instead. - Syntactically, `fn` items in free contexts (directly in a file or a module) can now be without bodies (`fn foo();` as opposed to `fn foo() { ... }`. As above, we use semantic restrictions instead, including for non-ident parameter patterns. - `const extern fn` feature gating is now done post-expansion such that we do not have conditional compatibilities of function qualifiers *in parsing*. - The `FnFrontMatter` grammar becomes: ```rust Extern = "extern" StringLit ; FnQual = "const"? "async"? "unsafe"? Extern? ; FnFrontMatter = FnQual "fn" ; ``` That is, all item contexts now *syntactically* allow `const async unsafe extern "C" fn` and use semantic restrictions to rule out combinations previously prevented syntactically. The semantic restrictions include in particular: - `fn`s in `extern { ... }` can have no qualifiers. - `const` and `async` cannot be combined. - To fuse the list-of-items parsing in the 4 contexts that items are allowed, we now must permit inner attributes (`#![attr]`) inside `trait Foo { ... }` definitions. That is, we now allow e.g. `trait Foo { #![attr] }`. This was probably an oversight due to not using a uniform parsing mechanism, which we now do have (`fn parse_item_list`). The semantic support (including e.g. for linting) falls out directly from the attributes infrastructure. To ensure this, we include a test for lints. Put together, these grammar changes allow us to substantially reduce the complexity of item parsing and its grammar. There are however some other non-language improvements that allow the compression to take place. A list of *compiler-internal* changes (in particular noting the parser-external data-structure changes): - We use `enum AllowPlus/RecoverQPath/AllowCVariadic { Yes, No }` in `parser/ty.rs` instead of passing around 3 different `bool`s. I felt this was necessary as it was becoming mentally taxing to track which-is-which. - `fn visit_trait_item` and `fn visit_impl_item` are merged into `fn visit_assoc_item` which now is passed an `AssocCtxt` to check which one it is. - We change `FnKind` to: ```rust pub enum FnKind<'a> { Fn(FnCtxt, Ident, &'a FnSig, &'a Visibility, Option<&'a Block>), Closure(&'a FnDecl, &'a Expr), } ``` with: ```rust pub enum FnCtxt { Free, Foreign, Assoc(AssocCtxt), } ``` This is then taken advantage of in tweaking the various semantic restrictions as well as in pretty printing. - In `ItemKind::Fn`, we change `P<Block>` to `Option<P<Block>>`. - In `ForeignItemKind::Fn`, we change `P<FnDecl>` to `FnSig` and `P<Block>` to `Option<P<Block>>`. - We change `ast::{Unsafety, Spanned<Constness>}>` into `enum ast::{Unsafe, Const} { Yes(Span), No }` respectively. This change in formulation allow us to exclude `Span` in the case of `No`, which facilitates parsing. Moreover, we also add a `Span` to `IsAsync` which is renamed to `Async`. The new `Span`s in `Unsafety` and `Async` are then taken advantage of for better diagnostics. A reason this change was made is to have a more uniform and clear naming scheme. The HIR keeps the structures in AST (with those definitions moved into HIR) for now to avoid regressing perf. - Various cleanups, bug fixes, and diagnostics improvements are made along the way. It is probably best to understand those via the diffs. I would recommend reviewing this commit-by-commit with whitespace changes hidden. r? @estebank @petrochenkov

view details

push time in 5 days

pull request commentrust-lang/rust

Don't error on network failures

@bors r+ rollup

mark-i-m

comment created time in 5 days

Pull request review commentrust-lang/rust

clean up E0308 explanation

-This error occurs when the compiler was unable to infer the concrete type of a-variable. It can occur for several cases, the most common of which is a-mismatch in the expected type that the compiler inferred for a variable's-initializing expression, and the actual type explicitly assigned to the-variable.+Expected type didn't match the received type.
Expected type did not match the received type.
GuillaumeGomez

comment created time in 5 days

pull request commentrust-lang/rust

Fix bugs in Peekable and Flatten when using non-fused iterators

r? @Amanieu

timvermeulen

comment created time in 6 days

pull request commentrust-lang/rust

Add comment to SGX entry code

@bors r+ rollup

jethrogb

comment created time in 6 days

pull request commentrust-lang/rust

Rollup of 9 pull requests

@bors r+ rollup=never p=9

Dylan-DPC

comment created time in 6 days

PR opened rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #67642 (Relax bounds on HashMap/HashSet)
  • #68848 (Hasten macro parsing)
  • #69008 (Properly use parent generics for opaque types)
  • #69048 (Suggestion when encountering assoc types from hrtb)
  • #69049 (Optimize image sizes)
  • #69050 (Micro-optimize the heck out of LEB128 reading and writing.)
  • #69068 (Make the SGX arg cleanup implementation a NOP)
  • #69082 (When expecting BoxFuture and using async {}, suggest Box::pin)
  • #69104 (bootstrap: Configure cmake when building sanitizer runtimes)

Failed merges:

r? @ghost

+584 -253

0 comment

36 changed files

pr created time in 6 days

push eventDylan-DPC/rust

Tomasz Miąsko

commit sha 33e2c1d863f53f5224db5abd40c6a84879051ef2

bootstrap: Configure cmake when building sanitizer runtimes

view details

Dylan DPC

commit sha 1ddf2504fdeb26bce320c8198c2e594b22efd71a

Rollup merge of #69104 - tmiasko:configure-cmake, r=Mark-Simulacrum bootstrap: Configure cmake when building sanitizer runtimes Configure cmake before building sanitizer runtimes in similar way it is already configured elsewhere, to ensure that they are built with expected compiler flags. Previously this step has been intentionally omitted since sanitizer runtimes are built as universal binaries on Darwin targets, which in turn are unsupported by sccache which is also configured there. To avoid the issue everything but the compiler launcher is configured. Helps with #68863.

view details

push time in 6 days

push eventDylan-DPC/rust

Esteban Küber

commit sha c39b04ea851b821359534b540c0babb97de24122

When expecting `BoxFuture` and using `async {}`, suggest `Box::pin`

view details

Esteban Küber

commit sha a852fb74131af7473bafb03d0f3994a0e9f597d5

Remove std lib `Span` from expected boxed future test

view details

Esteban Küber

commit sha 80cdb0af7dd27471e1e4a4362e2473a9331a5fdd

Account for `Box::new(impl Future)` and emit help `use Box::pin`

view details

Esteban Küber

commit sha c376fc001772200e2de8d7a610a5b67dcf642432

Account for `Pin::new(_)` and `Pin::new(Box::new(_))` when `Box::pin(_)` would be applicable

view details

Esteban Küber

commit sha 248f5a4046ab5a90189f37c305c759b7cde8acb3

Add trait `Self` filtering to `rustc_on_unimplemented`

view details

Dylan DPC

commit sha ec5bf15c5d1b5969908251017f1e61d2f2961a87

Rollup merge of #69082 - estebank:boxfuture-box-pin, r=tmandry When expecting `BoxFuture` and using `async {}`, suggest `Box::pin` Fix #68197, cc #69083.

view details

push time in 6 days

push eventDylan-DPC/rust

Dario Gonzalez

commit sha 1f6fb338a5f775745595d32b61c1862887c948f9

make the sgx arg cleanup implementation a no op

view details

Dylan DPC

commit sha 2501a10670c331ad5fb51c64c6d991a9a66f8f31

Rollup merge of #69068 - Goirad:make-sgx-arg-cleanup-nop, r=jethrogb,nagisa Make the SGX arg cleanup implementation a NOP fixes #64304 cc @jethrogb

view details

push time in 6 days

push eventDylan-DPC/rust

Nicholas Nethercote

commit sha ad7802f9d45b884dad58931c7a8bec91d196ad0e

Micro-optimize the heck out of LEB128 reading and writing. This commit makes the following writing improvements: - Removes the unnecessary `write_to_vec` function. - Reduces the number of conditions per loop from 2 to 1. - Avoids a mask and a shift on the final byte. And the following reading improvements: - Removes an unnecessary type annotation. - Fixes a dangerous unchecked slice access. Imagine a slice `[0x80]` -- the current code will read past the end of the slice some number of bytes. The bounds check at the end will subsequently trigger, unless something bad (like a crash) happens first. The cost of doing bounds check in the loop body is negligible. - Avoids a mask on the final byte. And the following improvements for both reading and writing: - Changes `for` to `loop` for the loops, avoiding an unnecessary condition on each iteration. This also removes the need for `leb128_size`. All of these changes give significant perf wins, up to 5%.

view details

Dylan DPC

commit sha a50a8967552d886a91b20fcd33310ad0f28857fd

Rollup merge of #69050 - nnethercote:micro-optimize-leb128, r=michaelwoerister Micro-optimize the heck out of LEB128 reading and writing. This commit makes the following writing improvements: - Removes the unnecessary `write_to_vec` function. - Reduces the number of conditions per loop from 2 to 1. - Avoids a mask and a shift on the final byte. And the following reading improvements: - Removes an unnecessary type annotation. - Fixes a dangerous unchecked slice access. Imagine a slice `[0x80]` -- the current code will read past the end of the slice some number of bytes. The bounds check at the end will subsequently trigger, unless something bad (like a crash) happens first. The cost of doing bounds check in the loop body is negligible. - Avoids a mask on the final byte. And the following improvements for both reading and writing: - Changes `for` to `loop` for the loops, avoiding an unnecessary condition on each iteration. This also removes the need for `leb128_size`. All of these changes give significant perf wins, up to 5%. r? @michaelwoerister

view details

push time in 6 days

push eventDylan-DPC/rust

ImgBotApp

commit sha c18476e231058b8dd8528ca98b0b51ff14b729be

[ImgBot] Optimize images *Total -- 10.65kb -> 8.44kb (20.82%) /src/etc/installer/gfx/rust-logo.png -- 5.71kb -> 3.82kb (33.11%) /src/librustdoc/html/static/down-arrow.svg -- 0.63kb -> 0.50kb (20.44%) /src/librustdoc/html/static/wheel.svg -- 3.86kb -> 3.68kb (4.66%) /src/librustdoc/html/static/brush.svg -- 0.47kb -> 0.44kb (4.61%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

view details

Dylan DPC

commit sha 53a790c58a9fb055b58ae471a6e57ece81c55b50

Rollup merge of #69049 - pthariensflame:improvement/imgbot, r=GuillaumeGomez Optimize image sizes This was done by [ImgBot](https://imgbot.net/) on my own fork, which I then immediately merged and turned into this manual pull request. Below is reproduced [ImgBot's own message](https://github.com/pthariensflame/rust/pull/3#issue-373452394) on the content of this PR. r? @steveklabnik since this is a documentation PR, I guess. --- > ## Beep boop. Your images are optimized! > > Your image file size has been reduced by **21%** 🎉 > > <details> > <summary> > Details > </summary> > > | File | Before | After | Percent reduction | > |:--|:--|:--|:--| > | /src/etc/installer/gfx/rust-logo.png | 5.71kb | 3.82kb | 33.11% | > | /src/librustdoc/html/static/down-arrow.svg | 0.63kb | 0.50kb | 20.44% | > | /src/librustdoc/html/static/wheel.svg | 3.86kb | 3.68kb | 4.66% | > | /src/librustdoc/html/static/brush.svg | 0.47kb | 0.44kb | 4.61% | > | | | | | > | **Total :** | **10.65kb** | **8.44kb** | **20.82%** | > </details> > > --- > > [📝docs](https://imgbot.net/docs) | [:octocat: repo](https://github.com/dabutvin/ImgBot) | [🙋issues](https://github.com/dabutvin/ImgBot/issues) | [🏅swag](https://goo.gl/forms/1GX7wlhGEX8nkhGO2) | [🏪marketplace](https://github.com/marketplace/imgbot)

view details

push time in 6 days

push eventDylan-DPC/rust

Esteban Küber

commit sha 24be307b53931a9824829f63aa65fa5c6042ed21

Suggestion when encountering assoc types from hrtb When encountering E0212, detect whether this is a representable case or not, i.e. if it's happening on an `fn` or on an ADT. If the former, provide a structured suggestion, otherwise note that this can't be represented in Rust.

view details

Esteban Küber

commit sha bde96776a199064dec3c825ca5ada8f90e1e12d4

Suggest named lifetime in ADT with hrtb

view details

Dylan DPC

commit sha 8d00adf28943db3361d1d425bafc21584b238eaa

Rollup merge of #69048 - estebank:hrlt-assoc, r=nagisa Suggestion when encountering assoc types from hrtb When encountering E0212, detect whether this is a representable case or not, i.e. if it's happening on an `fn` or on an ADT. If the former, provide a structured suggestion, otherwise note that this can't be represented in Rust. Fix #69000.

view details

push time in 6 days

more