profile
viewpoint
Guillaume Gomez GuillaumeGomez Paris https://blog.guillaume-gomez.fr Opensource lover. Rustdoc team leader, member of the rust language tool, documentation and docs.rs teams, member of the GNOME foundation.

gtk-rs/gtk4 46

GTK 4 bindings and wrappers for Rust (Development)

gtk-rs/webkit2gtk-rs 32

WebKit2 bindings and wrappers for Rust

gtk-rs/sourceview 17

sourceview binding for Rust

gtk-rs/gtk-test 13

Testing GTK UI

gtk-rs/javascriptcore-rs 8

JavaScriptCore bindings and wrappers for Rust

gtk-rs/examples4 6

GTK 4 Rust examples (development)

gtk-rs/pangocairo 6

Bindings for the pangocairo library

gtk-rs/gdk4 5

GDK 4 bindings and wrappers for Rust (Development)

GuillaumeGomez/ban-ssh-ips 5

Little script to read failed auths and ban their IPs

GuillaumeGomez/audio-video-metadata 4

A crate to parse audio and video metadatas

delete branch GuillaumeGomez/rust

delete branch : clean-e0317

delete time in 17 hours

delete branch QwantResearch/idunn

delete branch : python3.8

delete time in 17 hours

delete branch gtk-rs/examples

delete branch : close

delete time in 18 hours

push eventgtk-rs/examples

Guillaume Gomez

commit sha 2cdefa326552ef3f197c0f800ef2fd20fd98b21d

Replace destroy calls with close

view details

Guillaume Gomez

commit sha 2bfbb83d658383a9f7edeffcb727a2e9db442e7d

Merge pull request #296 from gtk-rs/close Replace destroy calls with close

view details

push time in 18 hours

PR merged gtk-rs/examples

Replace destroy calls with close

Part of https://github.com/gtk-rs/gtk/pull/958

cc @EPashkin @sdroege

+13 -13

1 comment

8 changed files

GuillaumeGomez

pr closed time in 18 hours

Pull request review commentQwantResearch/docker_mimir

Update load_addresses task to use the new global importer

 es: http://es:9200 run_on_docker_compose: true  osm:-  url: https://download.geofabrik.de/europe/luxembourg-latest.osm.pbf+  url: https://download.geofabrik.de/europe/belgium-latest.osm.pbf

Oh crap, didn't realised I committed it...

GuillaumeGomez

comment created time in 19 hours

Pull request review commentQwantResearch/docker_mimir

Update load_addresses task to use the new global importer

 def load_addresses(ctx, files=[]):         logging.info("no addresses to import")         return +    output_csv = "output.csv"++    options = []     if addr_config.get("bano", {}).get("file"):-        logging.info("importing bano addresses")-        conf = ctx.addresses.bano-        additional_params = _get_cli_param(conf.get("nb_threads"), "--nb-threads")-        additional_params += _get_cli_param(conf.get("nb_shards"), "--nb-shards")-        additional_params += _get_cli_param(conf.get("nb_replicas"), "--nb-replicas")-        run_rust_binary(-            ctx,-            "mimir",-            "bano2mimir",-            files,-            "--input {ctx.addresses.bano.file} \-            --connection-string {ctx.es} \-            {additional_params} \-            --dataset {ctx.dataset}".format(-                ctx=ctx, additional_params=additional_params-            ),-        )+        options.append("--bano")+        options.append(ctx.addresses.bano.file)     if addr_config.get("oa", {}).get("file"):-        logging.info("importing oa addresses")-        conf = ctx.addresses.oa-        additional_params = _get_cli_param(conf.get("nb_threads"), "--nb-threads")-        additional_params += _get_cli_param(conf.get("nb_shards"), "--nb-shards")-        additional_params += _get_cli_param(conf.get("nb_replicas"), "--nb-replicas")-        # TODO take multiples oa files ?-        run_rust_binary(-            ctx,-            "mimir",-            "openaddresses2mimir",-            files,-            "--input {ctx.addresses.oa.file} \-            --connection-string {ctx.es} \-            {additional_params} \-            --dataset {ctx.dataset}".format(-                ctx=ctx, additional_params=additional_params-            ),-        )+        options.append("--openaddress")+        options.append(ctx.addresses.oa.file)+    if addr_config.get("osm", False) is True and ctx.get("osm", {}).get("file"):

It's not about being "safer" but comparing a returned value explicitly. :)

GuillaumeGomez

comment created time in 19 hours

Pull request review commentQwantResearch/docker_mimir

Update load_addresses task to use the new global importer

 addresses:     nb_threads: # number of threads to use #   nb_shards:  # control the number of shards of the ES index #   nb_replicas:  # control the number of replicas of the ES index+  osm: true

It was actually for testing that I made this change. But I think we could keep it minus adding a comment on about what it's used for.

GuillaumeGomez

comment created time in 19 hours

pull request commentstratis-storage/stratisd

Store StaticHeader::pool_uuid and StaticHeader::dev_uuid into a new StratisIdentifiers type

Format, my arch enemy! Updated haha.

GuillaumeGomez

comment created time in 19 hours

push eventGuillaumeGomez/stratisd

Guillaume Gomez

commit sha 5735826b3b0c9a301c0edf0c07e71cc64d9279c3

Store StaticHeader::pool_uuid and StaticHeader::dev_uuid into a new StratisIdentifiers type

view details

push time in 19 hours

PR opened gtk-rs/checker

Gir file option

cc @sdroege

+45 -7

0 comment

2 changed files

pr created time in 19 hours

create barnchgtk-rs/checker

branch : gir-file-option

created branch time in 19 hours

PR opened rust-lang/rust

Clean up E0321 and E0322

r? @Dylan-DPC

+13 -1

0 comment

2 changed files

pr created time in 20 hours

create barnchGuillaumeGomez/rust

branch : clean-up-e0321-e0322

created branch time in 20 hours

pull request commentgtk-rs/gtk

Mark Widget::destroy as unsafe

Updated and waiting for https://github.com/gtk-rs/examples/pull/296 now.

GuillaumeGomez

comment created time in 20 hours

push eventGuillaumeGomez/gtk

Guillaume Gomez

commit sha 043fe4280292bdaa565d1dd95c50d38fb8be3c5c

Mark Widget::destroy as unsafe

view details

push time in 20 hours

PR opened gtk-rs/examples

Replace destroy calls with close

Part of https://github.com/gtk-rs/gtk/pull/958

cc @EPashkin @sdroege

+13 -13

0 comment

8 changed files

pr created time in 20 hours

create barnchgtk-rs/examples

branch : close

created branch time in 20 hours

issue closedgtk-rs/gdk

Window function set_titlebar generate gtk-CRITICAL error messages when moving window

Line 41 in sourcefile mainwindow.rs enables moving window by pressing mousebutton over the headerbar in the window. When running the program in shell and moving the window I get this message:

gtk_container_propagate_draw: assertion '_gtk_widget_get_parent (child) == GTK_WIDGET (container)' failed

https://developer.gnome.org/gtk3/stable/GtkHeaderBar.html (using headerbar with set_titlebar) For these reasons, GtkHeaderBar is the natural choice for use as the custom titlebar widget of a GtkWindow (see gtk_window_set_titlebar()), as it gives features typical of titlebars while allowing the addition of child widgets.

https://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-set-titlebar (set-titlebar api) In gtk refrences it seems that set-titlebar should accept any type of GtkWidget

I am new to rust, gtk, open source and linux programming so excuse stupid misstakes I have made.

example code below moving_window_error.zip

closed time in a day

Weboholics

Pull request review commentgtk-rs/gtk-rs.github.io

Fix docs links

 marked accordingly and need someone to pick them up. We've realized that we can't take the documentation from an LGPL licensed library and just slip it into an MIT-licensed one. Consequently we had to move almost all doc comments into a [separate repo][doc-comments]. We will keep-maintaining [online documentation](http://gtk-rs.org/docs/) and+maintaining [online documentation](http://gtk-rs.org/docs-src/) and

I think it was to make the difference with the documentation stronger.

GuillaumeGomez

comment created time in a day

delete branch GuillaumeGomez/gtk

delete branch : ci-improvement

delete time in a day

push eventgtk-rs/gtk

Guillaume Gomez

commit sha e04c7ca5c8526ea1f832ebb5748e6776f2e70a1a

Add checks for missing manual traits

view details

Guillaume Gomez

commit sha c6a6357beb6f8153bcaa7628637803ee9dfb890a

Add missing manual trait

view details

Guillaume Gomez

commit sha 759b9cd607382eb81f6e93785119334e8d781cc2

Remove unused file

view details

Guillaume Gomez

commit sha 86c878aef87893c8dfbee7ebff4accd455c54f4c

Merge pull request #956 from GuillaumeGomez/ci-improvement Ci improvement

view details

push time in a day

PR merged gtk-rs/gtk

Ci improvement

cc @EPashkin @sdroege

+8 -20

2 comments

3 changed files

GuillaumeGomez

pr closed time in a day

issue commentgtk-rs/checker

Add support for specifying Gir.toml filename

You'll be forced to give the gir files and the folders, even if it's .. :)

sdroege

comment created time in a day

push eventgtk-rs/gtk

tsahyt

commit sha 531bb2ca4caf0b32d6b6c40c90397f4f95701164

Add subclass support for Fixed (#955) Add subclass support for Fixed

view details

push time in a day

PR merged gtk-rs/gtk

Add subclass support for Fixed
+19 -0

5 comments

2 changed files

tsahyt

pr closed time in a day

pull request commentgtk-rs/gtk

Add subclass support for Fixed

Thanks!

tsahyt

comment created time in a day

pull request commentopenvenues/libpostal

Remove global initializers

Most people will use the bindings and not the C functions directly. For them, it won't change much things but it'll remove all possible data races for sure. So I'd prefer to stand on my position: it's a bad for a good.

GuillaumeGomez

comment created time in a day

pull request commentstratis-storage/stratisd

Store StaticHeader::pool_uuid and StaticHeader::dev_uuid into a new StratisIdentifiers type

I'm relying on the CI here, sorry. ^^'

Updated otherwise!

GuillaumeGomez

comment created time in a day

push eventGuillaumeGomez/stratisd

Guillaume Gomez

commit sha a0ea8988b98f6977bc128f008d209e622a24092f

Store StaticHeader::pool_uuid and StaticHeader::dev_uuid into a new StratisIdentifiers type

view details

push time in a day

push eventGuillaumeGomez/stratisd

John Baublitz

commit sha b8305a5c8b74053883820bad9be2d74988bb652f

Require at least one blockdev for initialization actions Currently we do not check that initialization actions like creating a pool or initializing the cache are provided at least one blockdev. Given that blockdevs are required for these actions, this PR adds a check at the top level of the engine to return a helpful error message if no blockdevs are given.

view details

mulkieran

commit sha 521bf3a786a2c61e87e791f713b5a3f97b331cca

Merge pull request #1828 from jbaublitz/issue-stratisd-1304 Require at least one blockdev for initialization actions

view details

Guillaume Gomez

commit sha 6572f6416bd697f2d48659556feaabf0cba83afc

Store StaticHeader::pool_uuid and StaticHeader::dev_uuid into a new StratisIdentifiers type

view details

push time in a day

PR opened gtk-rs/gtk

Mark Widget::destroy as unsafe

Part of #957.

cc @sdroege @EPashkin

+12 -8

0 comment

3 changed files

pr created time in a day

create barnchGuillaumeGomez/gtk

branch : unsafe-destroy

created branch time in a day

push eventGuillaumeGomez/gtk

Guillaume Gomez

commit sha 759b9cd607382eb81f6e93785119334e8d781cc2

Remove unused file

view details

push time in a day

issue commentgtk-rs/gtk

Widget::destroy() should be marked unsafe

Starting to send the gtk PR first.

sdroege

comment created time in a day

PR opened gtk-rs/gtk-rs.github.io

Fix docs links

Part of https://github.com/gtk-rs/gtk/issues/954

+3 -3

0 comment

2 changed files

pr created time in a day

create barnchgtk-rs/gtk-rs.github.io

branch : docs-links

created branch time in a day

issue commentgtk-rs/gtk

Confusing documentation

How did you arrive on http://gtk-rs.org/docs/ btw? I can't find any link to it. It seems like an old version of https://gtk-rs.org/docs-rs/ ...

ZelphirKaltstahl

comment created time in a day

issue commentgtk-rs/gtk

Confusing documentation

No clue either. It's the first time we came across this specific issue so it'd be difficult to generalize it in order to make a tutorial for it... In the meantime, I'll update the docs as I said. It could be part of the discussions in next hackfest as well...

ZelphirKaltstahl

comment created time in 2 days

PR opened gtk-rs/gtk-rs.github.io

Point to gnome installation page instead of ours

As discussed:

cc @sdroege

+4 -162

0 comment

3 changed files

pr created time in 2 days

create barnchgtk-rs/gtk-rs.github.io

branch : gnome-installation-page

created branch time in 2 days

issue commentrust-lang/project-localisation

Support translating the stdlib docs

Modify rustdoc so that it can spit out json files (one per module) mapping paths to their docs. It needs to avoid duplication; i.e. if something is reexported there should only be one json entry

I started a few months ago the multiple output work on rustdoc. It's crate based but I'd assume it wouldn't be too much work to allow it to be module based as well. For now it's paused until I get enough time to finish it.

Modify rustdoc so that it can consume such json files and use those docs instead

In here I have a few questions: would it be through options or through tags? (Or maybe both?)

In any case, it'll take some time. I don't have PTO in the next months so I don't think the json output will be finished anytime soon.

Manishearth

comment created time in 2 days

PR opened gtk-rs/gtk

Ci improvement

cc @EPashkin @sdroege

+8 -1

0 comment

2 changed files

pr created time in 2 days

create barnchGuillaumeGomez/gtk

branch : ci-improvement

created branch time in 2 days

delete branch gtk-rs/checker

delete branch : current-crate

delete time in 2 days

push eventgtk-rs/checker

Guillaume Gomez

commit sha 2eb2bda9f7de4ba3d84eaf1e6b6be6447a084911

Only take into account traits for objects in the current crate

view details

Guillaume Gomez

commit sha a22d054683c20aff3728169eb1e9b58d84d0be30

Merge pull request #5 from gtk-rs/current-crate Only take into account traits for objects in the current crate

view details

push time in 2 days

create barnchgtk-rs/checker

branch : current-crate

created branch time in 2 days

issue openedgtk-rs/checker

Add checker for license header

No need for a separate binary, just the same one is fine.

created time in 2 days

Pull request review commentgtk-rs/gtk

Add subclass support for Fixed

+use glib::subclass::prelude::*;

Please add the header we use in other files here as well.

tsahyt

comment created time in 2 days

delete branch gtk-rs/checker

delete branch : fmt

delete time in 2 days

push eventgtk-rs/checker

Guillaume Gomez

commit sha cfdc555bc761f92156d253490a8753fb711d4901

Improve README

view details

Guillaume Gomez

commit sha 285676b6a5e288a95af25485fc9bd30a197035cb

Merge pull request #3 from gtk-rs/fmt Improve README

view details

push time in 2 days

PR merged gtk-rs/checker

Improve README
+20 -1

0 comment

1 changed file

GuillaumeGomez

pr closed time in 2 days

PR opened gtk-rs/checker

Improve README
+20 -1

0 comment

1 changed file

pr created time in 2 days

create barnchgtk-rs/checker

branch : fmt

created branch time in 2 days

delete branch gtk-rs/checker

delete branch : fmt

delete time in 2 days

push eventgtk-rs/checker

Guillaume Gomez

commit sha 5a9ca745860ea6cd0e79c25ca251fd064b7c8831

fmt

view details

Guillaume Gomez

commit sha cf6729e81b04b7fec08718f449bc6e5b0ff7526a

Merge pull request #2 from gtk-rs/fmt fmt

view details

push time in 2 days

PR opened gtk-rs/checker

fmt
+9 -8

0 comment

1 changed file

pr created time in 2 days

create barnchgtk-rs/checker

branch : fmt

created branch time in 2 days

delete branch gtk-rs/checker

delete branch : missing-manual-traits

delete time in 2 days

push eventgtk-rs/checker

Guillaume Gomez

commit sha 425152a62547345a2f0e02baba9f664e3237d8e3

Start of missing manual traits checker

view details

Guillaume Gomez

commit sha 1c01042c4905e607e3958e69508cfdc32c4221e2

Merge pull request #1 from gtk-rs/missing-manual-traits Start of missing manual traits checker

view details

push time in 2 days

PR opened gtk-rs/checker

Start of missing manual traits checker
+209 -0

0 comment

6 changed files

pr created time in 2 days

push eventgtk-rs/checker

Guillaume Gomez

commit sha 425152a62547345a2f0e02baba9f664e3237d8e3

Start of missing manual traits checker

view details

push time in 2 days

pull request commentrust-lang/rust

Add lint when no doc is present at the crate-level

I guess I badly explained... Let's try again! :)

So, the idea behind this lint is to help newcomers using rustdoc when they haven't documenting much (or nothing). This lint will be enabled at a warning level by default so it'll appear every time. It is different from missing_docs lint in this regard because this new one isn't intend to look for missing docs but to give a starting point for people who don't know where to start to document their code.

GuillaumeGomez

comment created time in 2 days

issue commentrust-lang/rust

Rustdoc: prioritize matches with same casing in search results

Well, people seem more favorable to it so feel free to send a PR.

Kinrany

comment created time in 2 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 1b342f70dfb999e19026979f28a76952dcc216f4

Clean up E0317 explanation

view details

push time in 2 days

pull request commentrust-lang/rust

Clean up E0317 explanation

Updated!

GuillaumeGomez

comment created time in 2 days

Pull request review commentQwantResearch/idunn

Upgrade from Python 3.6 to Python 3.8

 The main endpoints are:  ## Running -- The dependencies are managed with [Pipenv](https://github.com/pypa/pipenv).-- To run the api you need to do:+### Requirements++   - Python 3.8+   - [Pipenv](https://github.com/pypa/pipenv), to manage dependencies and virtualenv++

Please remove this empty line.

amatissart

comment created time in 2 days

Pull request review commentQwantResearch/addresses-importer

More readable logs

 pub fn get_time() -> String { #[macro_export] macro_rules! tprint {     ($($arg:tt)*) => {{-        use tools::get_time;-        println!("[{}] {}", get_time(), format!($($arg)*));+        print!("[{}] ", $crate::get_time());+        print!($($arg)*);

Some debate could be done on the fact that calling twice some I/O function for one operation is pretty bad. :)

remi-dupre

comment created time in 2 days

push eventgtk-rs/checker

Guillaume Gomez

commit sha 8179952dd1304b8d4d7ef2e4b40dc36b137ac879

Start of missing manual traits checker

view details

push time in 2 days

PR opened rust-lang/rust

Clean up E0317 explanation

r? @Dylan-DPC

+23 -7

0 comment

1 changed file

pr created time in 2 days

create barnchGuillaumeGomez/rust

branch : clean-e0317

created branch time in 2 days

delete branch QwantResearch/addresses-importer

delete branch : stable-push

delete time in 2 days

push eventQwantResearch/addresses-importer

Guillaume Gomez

commit sha f5ee799c6f37513b4586c2f582bd94b11f81f512

Only push build and push docker image on the stable version

view details

Guillaume Gomez

commit sha 7a16d93603d63aef7e0ab2b7c5a82040a810f57f

Merge pull request #40 from QwantResearch/stable-push Only push build and push docker image on the stable version

view details

push time in 2 days

create barnchQwantResearch/addresses-importer

branch : stable-push

created branch time in 2 days

issue commentgtk-rs/gtk-rs.github.io

Request for additional information

More documentation always make sense.

windelbouwman

comment created time in 2 days

create barnchgtk-rs/checker

branch : missing-manual-traits

created branch time in 2 days

create barnchgtk-rs/checker

branch : master

created branch time in 2 days

created repositorygtk-rs/checker

Repository which contains various scripts to run for CI

created time in 2 days

delete branch QwantResearch/addresses-importer

delete branch : auto-docker-build

delete time in 3 days

push eventQwantResearch/addresses-importer

Guillaume Gomez

commit sha fab5d0146738f3924b7517746696afd10e673f0a

Add automatic docker build/push when master branch is updated

view details

Guillaume Gomez

commit sha adb8f82c7abcaeca76130134114e8e704fd6e3ee

Merge pull request #38 from QwantResearch/auto-docker-build Add automatic docker build/push when master branch is updated

view details

push time in 3 days

issue commentgtk-rs/gio

Add check to ensure that no manual_trait is forgotten

Oh I see! Then definitely!

GuillaumeGomez

comment created time in 3 days

issue commentgtk-rs/gio

Add check to ensure that no manual_trait is forgotten

No. Beyond the problem that I'd prefer having a centralized check repository or something along the line, the gir repository is referred to as a sub-repository. Therefore, if we update a check, we'd need to send a commit to all repository to update the reference, which I'd prefer to avoid if possible.

Also, I didn't understand what you wanted to say when talking about the assert_initialized! macro...

GuillaumeGomez

comment created time in 3 days

issue openedgtk-rs/gio

Add check to ensure that no manual_trait is forgotten

We should put this check into an independent repository to be sure that we won't have to copy/paste it in all repositories every time.

What do you think @EPashkin @sdroege ?

created time in 3 days

pull request commentgtk-rs/gio

Fix/extend DataInputStream code

@EPashkin Great catch! We should definitely add a check to be sure we don't forget it.

I'll open an issue about it.

sdroege

comment created time in 3 days

push eventQwantResearch/addresses-importer

Guillaume Gomez

commit sha fab5d0146738f3924b7517746696afd10e673f0a

Add automatic docker build/push when master branch is updated

view details

push time in 3 days

pull request commentgtk-rs/gio

Fix/extend DataInputStream code

Sorry, I already looked at it but I can't provide a full review and be sure it's working. :-/ Do you have some precise points you want to highlight so I can agree that they are working as expected?

sdroege

comment created time in 3 days

create barnchQwantResearch/addresses-importer

branch : auto-docker-build

created branch time in 3 days

delete branch QwantResearch/addresses-importer

delete branch : dockerfile

delete time in 3 days

push eventQwantResearch/addresses-importer

Guillaume Gomez

commit sha 5fb71976c6b55c21cd3355cfd74d9fe310700b80

Add dockerfile

view details

Guillaume Gomez

commit sha 82bf030f4e5af2180ab40ec757a51771fb047a22

Merge pull request #34 from QwantResearch/dockerfile Add dockerfile

view details

push time in 3 days

pull request commentQwantResearch/erdapfel

Fix windows doc

It seems like you included commits from #551.

xem

comment created time in 3 days

pull request commentQwantResearch/erdapfel

Fix windows doc

There are also changes on JS/CSS files, is it linked to this PR?

xem

comment created time in 3 days

more