duplicate of https://github.com/rust-lang/rust/issues/77993

Clippy already has a lint for panic!("{}") https://rust-lang.github.io/rust-clippy/master/index.html#panic_params (not sure about assert! though..)

Cargo-bisetc-rustc points to 93deabce03dc10a80244f5da3e3819452744da2a / https://github.com/rust-lang/rust/pull/77873

Reduced code from another project that also triggers this ICE:

async fn test() -> Result<(), Box<dyn std::error::Error>> {
    macro!();
    Ok(())
}

<!-- Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples.

http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/

-->

Code

code is ./compiler/rustc_middle/src/hir/place.rs @ 7f587168102498a488abf608a86c7fdfa62fb7bb

<code>

Meta

<!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. -->

rustc --version --verbose:

rustc 1.49.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-unknown-linux-gnu
release: 1.49.0-dev
LLVM version: 11.0

Error output

error[E0432]: unresolved import `crate::ty`
 --> ./compiler/rustc_middle/src/hir/place.rs:1:5
  |
1 | use crate::ty;
  |     ^^^^^^^--
  |     |      |
  |     |      help: a similar name exists in the module: `Ty`
  |     no `ty` in the root

error[E0433]: failed to resolve: maybe a missing crate `rustc_target`?
 --> ./compiler/rustc_middle/src/hir/place.rs:5:5
  |
5 | use rustc_target::abi::VariantIdx;
  |     ^^^^^^^^^^^^ maybe a missing crate `rustc_target`?

error[E0432]: unresolved import `rustc_hir`
 --> ./compiler/rustc_middle/src/hir/place.rs:4:5
  |
4 | use rustc_hir::HirId;
  |     ^^^^^^^^^ maybe a missing crate `rustc_hir`?

error: cannot find derive macro `TyEncodable` in this scope
 --> ./compiler/rustc_middle/src/hir/place.rs:7:51
  |
7 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
  |                                                   ^^^^^^^^^^^

error: cannot find derive macro `TyDecodable` in this scope
 --> ./compiler/rustc_middle/src/hir/place.rs:7:64
  |
7 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
  |                                                                ^^^^^^^^^^^

error: cannot find derive macro `HashStable` in this scope
 --> ./compiler/rustc_middle/src/hir/place.rs:7:77
  |
7 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
  |                                                                             ^^^^^^^^^^

error: cannot find derive macro `TyEncodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:19:51
   |
19 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                   ^^^^^^^^^^^

error: cannot find derive macro `TyDecodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:19:64
   |
19 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                                ^^^^^^^^^^^

error: cannot find derive macro `HashStable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:19:77
   |
19 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                                             ^^^^^^^^^^

error: cannot find derive macro `TyEncodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:39:51
   |
39 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                   ^^^^^^^^^^^

error: cannot find derive macro `TyDecodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:39:64
   |
39 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                                ^^^^^^^^^^^

error: cannot find derive macro `HashStable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:39:77
   |
39 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                                             ^^^^^^^^^^

error: cannot find derive macro `TyEncodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:51:45
   |
51 | #[derive(Clone, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                             ^^^^^^^^^^^

error: cannot find derive macro `TyDecodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:51:58
   |
51 | #[derive(Clone, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                          ^^^^^^^^^^^

error: cannot find derive macro `HashStable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:51:71
   |
51 | #[derive(Clone, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                                       ^^^^^^^^^^

error: cannot find derive macro `TyEncodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:64:45
   |
64 | #[derive(Clone, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                             ^^^^^^^^^^^

error: cannot find derive macro `TyDecodable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:64:58
   |
64 | #[derive(Clone, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                          ^^^^^^^^^^^

error: cannot find derive macro `HashStable` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:64:71
   |
64 | #[derive(Clone, Debug, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable)]
   |                                                                       ^^^^^^^^^^

error[E0412]: cannot find type `VariantIdx` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:28:16
   |
28 |     Field(u32, VariantIdx),
   |                ^^^^^^^^^^ not found in this scope

error[E0412]: cannot find type `Ty` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:42:13
   |
42 |     pub ty: Ty<'tcx>,
   |             ^^ not found in this scope

error[E0412]: cannot find type `Ty` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:54:18
   |
54 |     pub base_ty: Ty<'tcx>,
   |                  ^^ not found in this scope

error[E0412]: cannot find type `Ty` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:76:18
   |
76 |         base_ty: Ty<'tcx>,
   |                  ^^ not found in this scope

error[E0412]: cannot find type `Ty` in this scope
  --> ./compiler/rustc_middle/src/hir/place.rs:94:53
   |
94 |     pub fn deref_tys(&self) -> impl Iterator<Item = Ty<'tcx>> + '_ {
   |                                                     ^^ not found in this scope

error[E0412]: cannot find type `Ty` in this scope
   --> ./compiler/rustc_middle/src/hir/place.rs:105:25
    |
105 |     pub fn ty(&self) -> Ty<'tcx> {
    |                         ^^ not found in this scope

error[E0412]: cannot find type `Ty` in this scope
   --> ./compiler/rustc_middle/src/hir/place.rs:111:68
    |
111 |     pub fn ty_before_projection(&self, projection_index: usize) -> Ty<'tcx> {
    |                                                                    ^^ not found in this scope

error[E0601]: `main` function not found in crate `place`
   --> ./compiler/rustc_middle/src/hir/place.rs:1:1
    |
1   | / use crate::ty;
2   | | use crate::ty::Ty;
3   | |
4   | | use rustc_hir::HirId;
...   |
114 | |     }
115 | | }
    | |_^ consider adding a `main` function to `./compiler/rustc_middle/src/hir/place.rs`

error: internal compiler error: compiler/rustc_middle/src/ty/sty.rs:2124:18: tuple_fields called on non-tuple

thread 'rustc' panicked at 'Box<Any>', compiler/rustc_errors/src/lib.rs:945:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-dev running on x86_64-unknown-linux-gnu

error: aborting due to 27 previous errors

Some errors have detailed explanations: E0412, E0432, E0433, E0601.
For more information about an error, try `rustc --explain E0412`.

<!-- Include a backtrace in the code block by setting RUST_BACKTRACE=1 in your environment. E.g. RUST_BACKTRACE=1 cargo build. --> <details><summary><strong>Backtrace</strong></summary> <p>

error: internal compiler error: compiler/rustc_middle/src/ty/sty.rs:2124:18: tuple_fields called on non-tuple

thread 'rustc' panicked at 'Box<Any>', compiler/rustc_errors/src/lib.rs:945:9
stack backtrace:
   0:     0x7f93bc5e04bd - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h1b767c39a5e95889
   1:     0x7f93bc65385f - core::fmt::write::h171574b7e83e4159
   2:     0x7f93bc5db6b5 - std::io::Write::write_fmt::h367f0713939149e7
   3:     0x7f93bc5bb2dd - std::panicking::default_hook::{{closure}}::h8d2944ffa3ea5b5c
   4:     0x7f93bc5bafe3 - std::panicking::default_hook::h417561cd3584a74e
   5:     0x7f93bd5adad8 - rustc_driver::report_ice::h7f907413f380ab0c
   6:     0x7f93bc5bba44 - std::panicking::rust_panic_with_hook::h177ff2dd6f6c5a3a
   7:     0x7f93c037a48d - std::panicking::begin_panic::{{closure}}::h41c30b7d59c1ab83
   8:     0x7f93c037a366 - std::sys_common::backtrace::__rust_end_short_backtrace::h9b4b887fe950ed7b
   9:     0x7f93c037a45f - std::panicking::begin_panic::h2d5e952ff02cd303
  10:     0x7f93c035f280 - rustc_errors::HandlerInner::bug::h54226bb6464c1bbe
  11:     0x7f93c035dd80 - rustc_errors::Handler::bug::h9c85e7413fc614bd
  12:     0x7f93bfd1a744 - rustc_middle::util::bug::opt_span_bug_fmt::{{closure}}::hc8c879fae76cec68
  13:     0x7f93bfd03beb - rustc_middle::ty::context::tls::with_opt::{{closure}}::h1ee402a0368750e9
  14:     0x7f93bfd03b3a - rustc_middle::ty::context::tls::with_opt::h0b6e4a7db95180c0
  15:     0x7f93bfd1a669 - rustc_middle::util::bug::opt_span_bug_fmt::h9e8f475e44875520
  16:     0x7f93bfd1a5de - rustc_middle::util::bug::bug_fmt::hb53735ed1a0e40a3
  17:     0x7f93bfff9fe6 - rustc_middle::ty::sty::<impl rustc_middle::ty::TyS>::tuple_fields::hb1ebf2fff134a3a7
  18:     0x7f93bdf7b632 - <rustc_trait_selection::opaque_types::ConstrainOpaqueTypeRegionVisitor<OP> as rustc_middle::ty::fold::TypeVisitor>::visit_ty::h01e7fbbc634050bd
  19:     0x7f93bdf4381b - rustc_middle::ty::fold::TypeFoldable::visit_with::h89367421b2d9b62d
  20:     0x7f93bdf7b68b - <rustc_trait_selection::opaque_types::ConstrainOpaqueTypeRegionVisitor<OP> as rustc_middle::ty::fold::TypeVisitor>::visit_ty::h01e7fbbc634050bd
  21:     0x7f93be0e49b4 - <rustc_infer::infer::InferCtxt as rustc_trait_selection::opaque_types::InferCtxtExt>::constrain_opaque_types::h030521a243b98e15
  22:     0x7f93be0131be - rustc_typeck::check::regionck::RegionCtxt::visit_fn_body::ha1d50d9c7b0b26de
  23:     0x7f93be24bbf5 - rustc_hir::intravisit::walk_expr::hd9b61c2e865b355d
  24:     0x7f93be013f05 - <rustc_typeck::check::regionck::RegionCtxt as rustc_hir::intravisit::Visitor>::visit_expr::h5d9582afe4a90429
  25:     0x7f93be24ba0d - rustc_hir::intravisit::walk_expr::hd9b61c2e865b355d
  26:     0x7f93be013f05 - <rustc_typeck::check::regionck::RegionCtxt as rustc_hir::intravisit::Visitor>::visit_expr::h5d9582afe4a90429
  27:     0x7f93be013f05 - <rustc_typeck::check::regionck::RegionCtxt as rustc_hir::intravisit::Visitor>::visit_expr::h5d9582afe4a90429
  28:     0x7f93be01316d - rustc_typeck::check::regionck::RegionCtxt::visit_fn_body::ha1d50d9c7b0b26de
  29:     0x7f93be2c2314 - rustc_typeck::check::regionck::<impl rustc_typeck::check::fn_ctxt::FnCtxt>::regionck_fn::h962b154ec40bba78
  30:     0x7f93be087dc4 - rustc_infer::infer::InferCtxtBuilder::enter::h0bfbb1500ae865a9
  31:     0x7f93be2c5deb - rustc_typeck::check::typeck::hb09642c9af5e80c9
  32:     0x7f93c01d3a85 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h57f4225023d78b56
  33:     0x7f93bfb90344 - rustc_data_structures::stack::ensure_sufficient_stack::h71466b197f75449b
  34:     0x7f93c00ab2c3 - rustc_query_system::query::plumbing::get_query_impl::h9360744ca1554fcf
  35:     0x7f93bfcf71c7 - rustc_middle::ty::context::TyCtxt::typeck_opt_const_arg::h2d84bcba4b6a916a
  36:     0x7f93be6f6b88 - rustc_mir_build::thir::cx::Cx::new::hccb17ee027ff76f8
  37:     0x7f93be649728 - rustc_infer::infer::InferCtxtBuilder::enter::hb2e57772975e2b6a
  38:     0x7f93be6c9843 - rustc_mir_build::build::mir_built::h67c74896e86647aa
  39:     0x7f93be9af671 - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_built>::compute::hab082082a34c2a66
  40:     0x7f93be80d592 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h4f2d7a4f42060b81
  41:     0x7f93be7c3651 - rustc_middle::ty::query::plumbing::<impl rustc_query_system::query::QueryContext for rustc_middle::ty::context::TyCtxt>::start_query::{{closure}}::{{closure}}::{{closure}}::hb3cb65dbe2e759d9
  42:     0x7f93beb1c85c - rustc_query_system::query::plumbing::get_query_impl::h605fe8d0d7bd6b92
  43:     0x7f93bea9ee8f - rustc_mir::transform::check_unsafety::unsafety_check_result::hb95b5ba5b034d78c
  44:     0x7f93be9c7dd5 - core::ops::function::FnOnce::call_once::h6e90cec670018759
  45:     0x7f93be7ba9ae - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::unsafety_check_result>::compute::h152644ff7a03cdd3
  46:     0x7f93be807967 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h280484e180fb4db4
  47:     0x7f93be7c693f - rustc_middle::ty::query::plumbing::<impl rustc_query_system::query::QueryContext for rustc_middle::ty::context::TyCtxt>::start_query::{{closure}}::{{closure}}::{{closure}}::he829055f694efc53
  48:     0x7f93beafe7f8 - rustc_query_system::query::plumbing::get_query_impl::h41c1bf045ca18433
  49:     0x7f93beb9f55d - rustc_query_system::query::plumbing::ensure_query_impl::h86c0638fa615d35e
  50:     0x7f93be97c255 - rustc_mir::transform::mir_const::hdeb59516dc5aaff7
  51:     0x7f93be7b9611 - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_const>::compute::h71b8dfe9e2067e93
  52:     0x7f93be80d592 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h4f2d7a4f42060b81
  53:     0x7f93be7c3651 - rustc_middle::ty::query::plumbing::<impl rustc_query_system::query::QueryContext for rustc_middle::ty::context::TyCtxt>::start_query::{{closure}}::{{closure}}::{{closure}}::hb3cb65dbe2e759d9
  54:     0x7f93beb1c85c - rustc_query_system::query::plumbing::get_query_impl::h605fe8d0d7bd6b92
  55:     0x7f93be97f418 - rustc_mir::transform::mir_promoted::he979c564ee05d4ea
  56:     0x7f93be9afb51 - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_promoted>::compute::h092e01bedcd3549c
  57:     0x7f93be81186e - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h979aaf5f3b5750e4
  58:     0x7f93be7c3997 - rustc_middle::ty::query::plumbing::<impl rustc_query_system::query::QueryContext for rustc_middle::ty::context::TyCtxt>::start_query::{{closure}}::{{closure}}::{{closure}}::hba4807a6a5016e2c
  59:     0x7f93beb9ce35 - rustc_query_system::query::plumbing::get_query_impl::hfeddd0a9eec98c42
  60:     0x7f93bea75c94 - rustc_mir::borrow_check::mir_borrowck::h7c6e60de406657c1
  61:     0x7f93be9c7ea5 - core::ops::function::FnOnce::call_once::h73be7b98bfa4558f
  62:     0x7f93be145abe - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_borrowck>::compute::h3da8bb2f97c9a422
  63:     0x7f93bdf8af82 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h44ec7da1ac743b22
  64:     0x7f93bdf57b5f - rustc_middle::ty::query::plumbing::<impl rustc_query_system::query::QueryContext for rustc_middle::ty::context::TyCtxt>::start_query::{{closure}}::{{closure}}::{{closure}}::h779a44164ac87397
  65:     0x7f93be1b72cd - rustc_query_system::query::plumbing::get_query_impl::had8ea137560d0ac3
  66:     0x7f93be2c9ec5 - rustc_typeck::collect::type_of::type_of::h044fbee69942caec
  67:     0x7f93be14550f - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::type_of>::compute::h997915d7c4a1b6ad
  68:     0x7f93bdf94513 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::hc90b97085c9ce79e
  69:     0x7f93bdf59d85 - rustc_middle::ty::query::plumbing::<impl rustc_query_system::query::QueryContext for rustc_middle::ty::context::TyCtxt>::start_query::{{closure}}::{{closure}}::{{closure}}::haadc1467f2e67bc8
  70:     0x7f93be16b6cd - rustc_query_system::query::plumbing::get_query_impl::h2c99a7423ad0a9fb
  71:     0x7f93be26c498 - rustc_typeck::check::check::check_item_type::hcc025041b3995db8
  72:     0x7f93bdf6ad69 - rustc_middle::hir::map::Map::visit_item_likes_in_module::h90978f22ba1ebf3d
  73:     0x7f93be2759fd - rustc_typeck::check::check::check_mod_item_types::h74b4e4a96dd67240
  74:     0x7f93bdf5117e - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::check_mod_item_types>::compute::h2799a561a93c2553
  75:     0x7f93bdf87b52 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h2a25f28c9bf78af6
  76:     0x7f93bdfa4594 - rustc_data_structures::stack::ensure_sufficient_stack::ha0c669f9d949c5f8
  77:     0x7f93be16e0be - rustc_query_system::query::plumbing::get_query_impl::h2f050535db18ce4a
  78:     0x7f93be1f8f3e - rustc_query_system::query::plumbing::ensure_query_impl::h96e25221e74cb65c
  79:     0x7f93be042380 - rustc_typeck::check_crate::h2f3d09a5c21b8584
  80:     0x7f93bd8ff030 - rustc_interface::passes::analysis::h81d211764a272d26
  81:     0x7f93bd544522 - rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::analysis>::compute::h1a58c8624477b89e
  82:     0x7f93bd5585b2 - rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl::h62cc43b86c88c41d
  83:     0x7f93bd54471f - rustc_middle::ty::query::plumbing::<impl rustc_query_system::query::QueryContext for rustc_middle::ty::context::TyCtxt>::start_query::{{closure}}::{{closure}}::{{closure}}::h1a866b1492cf42e8
  84:     0x7f93bd6c94d1 - rustc_query_system::query::plumbing::get_query_impl::hcbdd933478ab0e9e
  85:     0x7f93bd5610ff - std::sys_common::backtrace::__rust_begin_short_backtrace::h724ca6f06aa5850a
  86:     0x7f93bd6d274e - core::ops::function::FnOnce::call_once{{vtable.shim}}::hff6c249ae73bdeba
  87:     0x7f93bc5c270a - std::sys::unix::thread::Thread::new::thread_start::h92d814023fa5e376
  88:     0x7f93b91053e9 - start_thread
  89:     0x7f93bc3ca293 - __GI___clone
  90:                0x0 - <unknown>

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-dev running on x86_64-unknown-linux-gnu

query stack during panic:
#0 [typeck] type-checking `Place::<'tcx>::deref_tys`
#1 [mir_built] building MIR for `Place::<'tcx>::deref_tys`
#2 [unsafety_check_result] unsafety-checking `Place::<'tcx>::deref_tys`
#3 [mir_const] processing MIR for `Place::<'tcx>::deref_tys`
#4 [mir_promoted] processing `Place::<'tcx>::deref_tys`
#5 [mir_borrowck] borrow-checking `Place::<'tcx>::deref_tys`
#6 [type_of] computing type of `Place<'tcx>::deref_tys::{opaque#0}`
#7 [check_mod_item_types] checking item types in top-level module
#8 [analysis] running analysis passes on this crate
end of query stack
error: aborting due to 27 previous errors

Some errors have detailed explanations: E0412, E0432, E0433, E0601.
For more information about an error, try `rustc --explain E0412`.

</p> </details>

Yeah, looks like RUSTFLAGS="-Aclippy::needless_return" cargo clippy no longer throws errors! :tada:

Looks like this works fine now. Feel free to close, unless you want to add some sort of test for this to RA.

Seems to be working, indeed. Thanks!

In the last 2(?) weeks I saw this error happening A LOT, mostly while compiling rustc.

sccache: error: Server startup failed: Address already in use (os error 98)
error: could not compile `rustc_symbol_mangling`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
sccache: error: Server startup failed: Address already in use (os error 98)
sccache: error: Server startup failed: Address already in use (os error 98)

This did not happen previously and it's quite annoying.

I tried this code:

#![warn(clippy::same_functions_in_if_condition)]
pub fn main() {
    let os = if cfg!(target_os = "macos") {
        "macos"
    } else if cfg!(target_os = "windows") {
        "windows"
    } else {
        "linux"
    };

    println!("{}", os);
}

This will boil down to something like ... if false { "macos" } else if false { "windows" } else { "linux" } on linux, the lint should probably just ignore exprs that originate from macros?

current warning:

warning: this `if` has the same function call as a previous `if`
 --> src/main.rs:5:15
  |
5 |     } else if cfg!(target_os = "windows") {
  |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
note: the lint level is defined here
 --> src/main.rs:1:9
  |
1 | #![warn(clippy::same_functions_in_if_condition)]
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: same as this
 --> src/main.rs:3:17
  |
3 |     let os = if cfg!(target_os = "macos") {
  |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_functions_in_if_condition
  = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

Meta

clippy 0.0.212 (8dae8cd 2020-10-12)

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/taking.20a.20break

I don't have the capacity to work a lot on clippy right now.

This will make contributing to the project easier because the utilities will work for most everyone out of the box.

I didn't know if I had to make a changelog entry for this, but if I do, feel free mention that in a review. Thanks!

The crash is repro'able in stable now.

<!-- Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples.

http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/

--> interestingly this one only crashes with -Zmir-opt-level=2 AND --emit mir

Code

./src/test/ui/issues/issue-37725.rs

// build-pass
#![allow(dead_code)]
trait Foo {
    fn foo(&self);
}

fn foo<'a>(s: &'a mut ()) where &'a mut (): Foo {
    s.foo();
}
fn main() {}

Meta

<!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. -->

rustc --version --verbose:

rustc 1.49.0-nightly (98edd1fbf 2020-10-06)
binary: rustc
commit-hash: 98edd1fbf8a68977a2a7c1312eb1ebff80515a92
commit-date: 2020-10-06
host: x86_64-unknown-linux-gnu
release: 1.49.0-nightly
LLVM version: 11.0

Error output

error: internal compiler error: Encountered error `Unimplemented` selecting `Binder(<&mut () as Foo>)` during codegen
  |
  = note: delayed at compiler/rustc_trait_selection/src/traits/codegen/mod.rs:65:32

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-nightly (98edd1fbf 2020-10-06) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z mir-opt-level=2

<!-- Include a backtrace in the code block by setting RUST_BACKTRACE=1 in your environment. E.g. RUST_BACKTRACE=1 cargo build. --> <details><summary><strong>Backtrace</strong></summary> <p>

error: internal compiler error: Encountered error `Unimplemented` selecting `Binder(<&mut () as Foo>)` during codegen
  |
  = note: delayed at compiler/rustc_trait_selection/src/traits/codegen/mod.rs:65:32

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
stack backtrace:
   0:     0x7fdf59d2b0b0 - std::backtrace_rs::backtrace::libunwind::trace::h622bab51c72c4e69
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/../../backtrace/src/backtrace/libunwind.rs:96
   1:     0x7fdf59d2b0b0 - std::backtrace_rs::backtrace::trace_unsynchronized::h7e820b882ebd41ee
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/../../backtrace/src/backtrace/mod.rs:66
   2:     0x7fdf59d2b0b0 - std::sys_common::backtrace::_print_fmt::h64d46258114db92f
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:79
   3:     0x7fdf59d2b0b0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h47111d0c1b5f0da5
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:58
   4:     0x7fdf59d9a07c - core::fmt::write::h1857a60b204f1b6a
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/core/src/fmt/mod.rs:1080
   5:     0x7fdf59d1d052 - std::io::Write::write_fmt::h4604516fed3e5731
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/io/mod.rs:1516
   6:     0x7fdf59d2fe7d - std::sys_common::backtrace::_print::h785e7a78d5ef272c
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:61
   7:     0x7fdf59d2fe7d - std::sys_common::backtrace::print::h108047ac5c4555d5
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:48
   8:     0x7fdf59d2fe7d - std::panicking::default_hook::{{closure}}::h1d0c271f0d087ebf
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:208
   9:     0x7fdf59d2fb28 - std::panicking::default_hook::h692753e26f11b7b7
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:227
  10:     0x7fdf5a5bd3e8 - rustc_driver::report_ice::h767ab601e5f63209
  11:     0x7fdf59d306c6 - std::panicking::rust_panic_with_hook::h74ddc20305301cd9
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:581
  12:     0x7fdf59d30249 - std::panicking::begin_panic_handler::{{closure}}::h1a9ca6427ceee1d0
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:484
  13:     0x7fdf59d2b54c - std::sys_common::backtrace::__rust_end_short_backtrace::h97e27b7ab754adde
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:153
  14:     0x7fdf59d30209 - rust_begin_unwind
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:483
  15:     0x7fdf59d301bb - std::panicking::begin_panic_fmt::h45d0f154d1dd3395
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:437
  16:     0x7fdf5d5d9281 - rustc_errors::HandlerInner::flush_delayed::h4e44ea29efc5a508
  17:     0x7fdf5d5d5be1 - <rustc_errors::HandlerInner as core::ops::drop::Drop>::drop::hc2218eb325dc8425
  18:     0x7fdf5a60ad76 - core::ptr::drop_in_place::he652386dc31d9e30
  19:     0x7fdf5a60cbc6 - <alloc::rc::Rc<T> as core::ops::drop::Drop>::drop::h60c7e2432b201062
  20:     0x7fdf5a5e66fd - core::ptr::drop_in_place::h2f4d4236293b18c7
  21:     0x7fdf5a5e0dea - rustc_span::with_source_map::h23e56868796f6dc3
  22:     0x7fdf5a615ed2 - rustc_interface::interface::create_compiler_and_run::h9a8debbb19483b80
  23:     0x7fdf5a5f4d0a - scoped_tls::ScopedKey<T>::set::hacc47b1cdb25a215
  24:     0x7fdf5a618611 - std::sys_common::backtrace::__rust_begin_short_backtrace::h3d5db7946c19f316
  25:     0x7fdf5a59618e - core::ops::function::FnOnce::call_once{{vtable.shim}}::he1a30fa4d30a2178
  26:     0x7fdf59d3efda - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h588ce842808b3fd0
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/alloc/src/boxed.rs:1042
  27:     0x7fdf59d3efda - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h46bc655f05471a92
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/alloc/src/boxed.rs:1042
  28:     0x7fdf59d3efda - std::sys::unix::thread::Thread::new::thread_start::hb4b79d379b730058
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys/unix/thread.rs:87
  29:     0x7fdf59c3b3e9 - start_thread
  30:     0x7fdf59b58293 - __GI___clone
  31:                0x0 - <unknown>

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-nightly (98edd1fbf 2020-10-06) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z mir-opt-level=2

query stack during panic:
end of query stack

</p> </details>

oops, dupe of #73021

<!-- Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples.

http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/

--> interestingly this one only crashes with -Zmir-opt-level=2 AND --emit mir

Code

./src/test/ui/issues/issue-37725.rs

// build-pass
#![allow(dead_code)]
trait Foo {
    fn foo(&self);
}

fn foo<'a>(s: &'a mut ()) where &'a mut (): Foo {
    s.foo();
}
fn main() {}

Meta

<!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. -->

rustc --version --verbose:

rustc 1.49.0-nightly (98edd1fbf 2020-10-06)
binary: rustc
commit-hash: 98edd1fbf8a68977a2a7c1312eb1ebff80515a92
commit-date: 2020-10-06
host: x86_64-unknown-linux-gnu
release: 1.49.0-nightly
LLVM version: 11.0

Error output

error: internal compiler error: Encountered error `Unimplemented` selecting `Binder(<&mut () as Foo>)` during codegen
  |
  = note: delayed at compiler/rustc_trait_selection/src/traits/codegen/mod.rs:65:32

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-nightly (98edd1fbf 2020-10-06) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z mir-opt-level=2

<!-- Include a backtrace in the code block by setting RUST_BACKTRACE=1 in your environment. E.g. RUST_BACKTRACE=1 cargo build. --> <details><summary><strong>Backtrace</strong></summary> <p>

error: internal compiler error: Encountered error `Unimplemented` selecting `Binder(<&mut () as Foo>)` during codegen
  |
  = note: delayed at compiler/rustc_trait_selection/src/traits/codegen/mod.rs:65:32

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
stack backtrace:
   0:     0x7fdf59d2b0b0 - std::backtrace_rs::backtrace::libunwind::trace::h622bab51c72c4e69
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/../../backtrace/src/backtrace/libunwind.rs:96
   1:     0x7fdf59d2b0b0 - std::backtrace_rs::backtrace::trace_unsynchronized::h7e820b882ebd41ee
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/../../backtrace/src/backtrace/mod.rs:66
   2:     0x7fdf59d2b0b0 - std::sys_common::backtrace::_print_fmt::h64d46258114db92f
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:79
   3:     0x7fdf59d2b0b0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h47111d0c1b5f0da5
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:58
   4:     0x7fdf59d9a07c - core::fmt::write::h1857a60b204f1b6a
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/core/src/fmt/mod.rs:1080
   5:     0x7fdf59d1d052 - std::io::Write::write_fmt::h4604516fed3e5731
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/io/mod.rs:1516
   6:     0x7fdf59d2fe7d - std::sys_common::backtrace::_print::h785e7a78d5ef272c
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:61
   7:     0x7fdf59d2fe7d - std::sys_common::backtrace::print::h108047ac5c4555d5
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:48
   8:     0x7fdf59d2fe7d - std::panicking::default_hook::{{closure}}::h1d0c271f0d087ebf
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:208
   9:     0x7fdf59d2fb28 - std::panicking::default_hook::h692753e26f11b7b7
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:227
  10:     0x7fdf5a5bd3e8 - rustc_driver::report_ice::h767ab601e5f63209
  11:     0x7fdf59d306c6 - std::panicking::rust_panic_with_hook::h74ddc20305301cd9
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:581
  12:     0x7fdf59d30249 - std::panicking::begin_panic_handler::{{closure}}::h1a9ca6427ceee1d0
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:484
  13:     0x7fdf59d2b54c - std::sys_common::backtrace::__rust_end_short_backtrace::h97e27b7ab754adde
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:153
  14:     0x7fdf59d30209 - rust_begin_unwind
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:483
  15:     0x7fdf59d301bb - std::panicking::begin_panic_fmt::h45d0f154d1dd3395
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:437
  16:     0x7fdf5d5d9281 - rustc_errors::HandlerInner::flush_delayed::h4e44ea29efc5a508
  17:     0x7fdf5d5d5be1 - <rustc_errors::HandlerInner as core::ops::drop::Drop>::drop::hc2218eb325dc8425
  18:     0x7fdf5a60ad76 - core::ptr::drop_in_place::he652386dc31d9e30
  19:     0x7fdf5a60cbc6 - <alloc::rc::Rc<T> as core::ops::drop::Drop>::drop::h60c7e2432b201062
  20:     0x7fdf5a5e66fd - core::ptr::drop_in_place::h2f4d4236293b18c7
  21:     0x7fdf5a5e0dea - rustc_span::with_source_map::h23e56868796f6dc3
  22:     0x7fdf5a615ed2 - rustc_interface::interface::create_compiler_and_run::h9a8debbb19483b80
  23:     0x7fdf5a5f4d0a - scoped_tls::ScopedKey<T>::set::hacc47b1cdb25a215
  24:     0x7fdf5a618611 - std::sys_common::backtrace::__rust_begin_short_backtrace::h3d5db7946c19f316
  25:     0x7fdf5a59618e - core::ops::function::FnOnce::call_once{{vtable.shim}}::he1a30fa4d30a2178
  26:     0x7fdf59d3efda - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h588ce842808b3fd0
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/alloc/src/boxed.rs:1042
  27:     0x7fdf59d3efda - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h46bc655f05471a92
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/alloc/src/boxed.rs:1042
  28:     0x7fdf59d3efda - std::sys::unix::thread::Thread::new::thread_start::hb4b79d379b730058
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys/unix/thread.rs:87
  29:     0x7fdf59c3b3e9 - start_thread
  30:     0x7fdf59b58293 - __GI___clone
  31:                0x0 - <unknown>

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-nightly (98edd1fbf 2020-10-06) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z mir-opt-level=2

query stack during panic:
end of query stack

</p> </details>

<!-- Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples.

http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/

-->

Code

./src/test/ui/issues/issue-50865-private-impl-trait/auxiliary/lib.rs

#![crate_type = "lib"]

pub fn bar<P>( // Error won't happen if "bar" is not generic
    _baz: P,
) {
    hide_foo()();
}

fn hide_foo() -> impl Fn() { // Error won't happen if "iterate" hasn't impl Trait or has generics
    foo
}

fn foo() { // Error won't happen if "foo" isn't used in "iterate" or has generics
}

Meta

<!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. -->

rustc --version --verbose:

rustc 1.49.0-nightly (98edd1fbf 2020-10-06)
binary: rustc
commit-hash: 98edd1fbf8a68977a2a7c1312eb1ebff80515a92
commit-date: 2020-10-06
host: x86_64-unknown-linux-gnu
release: 1.49.0-nightly
LLVM version: 11.0

Error output

error: internal compiler error: Encountered error `Unimplemented` selecting `Binder(<impl std::ops::Fn<()> as std::ops::Fn<()>>)` during codegen
  |
  = note: delayed at compiler/rustc_trait_selection/src/traits/codegen/mod.rs:65:32

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-nightly (98edd1fbf 2020-10-06) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z mir-opt-level=2

<!-- Include a backtrace in the code block by setting RUST_BACKTRACE=1 in your environment. E.g. RUST_BACKTRACE=1 cargo build. --> <details><summary><strong>Backtrace</strong></summary> <p>

error: internal compiler error: Encountered error `Unimplemented` selecting `Binder(<impl std::ops::Fn<()> as std::ops::Fn<()>>)` during codegen
  |
  = note: delayed at compiler/rustc_trait_selection/src/traits/codegen/mod.rs:65:32

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
stack backtrace:
   0:     0x7f0f02a6f0b0 - std::backtrace_rs::backtrace::libunwind::trace::h622bab51c72c4e69
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/../../backtrace/src/backtrace/libunwind.rs:96
   1:     0x7f0f02a6f0b0 - std::backtrace_rs::backtrace::trace_unsynchronized::h7e820b882ebd41ee
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/../../backtrace/src/backtrace/mod.rs:66
   2:     0x7f0f02a6f0b0 - std::sys_common::backtrace::_print_fmt::h64d46258114db92f
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:79
   3:     0x7f0f02a6f0b0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h47111d0c1b5f0da5
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:58
   4:     0x7f0f02ade07c - core::fmt::write::h1857a60b204f1b6a
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/core/src/fmt/mod.rs:1080
   5:     0x7f0f02a61052 - std::io::Write::write_fmt::h4604516fed3e5731
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/io/mod.rs:1516
   6:     0x7f0f02a73e7d - std::sys_common::backtrace::_print::h785e7a78d5ef272c
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:61
   7:     0x7f0f02a73e7d - std::sys_common::backtrace::print::h108047ac5c4555d5
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:48
   8:     0x7f0f02a73e7d - std::panicking::default_hook::{{closure}}::h1d0c271f0d087ebf
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:208
   9:     0x7f0f02a73b28 - std::panicking::default_hook::h692753e26f11b7b7
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:227
  10:     0x7f0f033013e8 - rustc_driver::report_ice::h767ab601e5f63209
  11:     0x7f0f02a746c6 - std::panicking::rust_panic_with_hook::h74ddc20305301cd9
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:581
  12:     0x7f0f02a74249 - std::panicking::begin_panic_handler::{{closure}}::h1a9ca6427ceee1d0
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:484
  13:     0x7f0f02a6f54c - std::sys_common::backtrace::__rust_end_short_backtrace::h97e27b7ab754adde
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys_common/backtrace.rs:153
  14:     0x7f0f02a74209 - rust_begin_unwind
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:483
  15:     0x7f0f02a741bb - std::panicking::begin_panic_fmt::h45d0f154d1dd3395
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/panicking.rs:437
  16:     0x7f0f0631d281 - rustc_errors::HandlerInner::flush_delayed::h4e44ea29efc5a508
  17:     0x7f0f06319be1 - <rustc_errors::HandlerInner as core::ops::drop::Drop>::drop::hc2218eb325dc8425
  18:     0x7f0f0334ed76 - core::ptr::drop_in_place::he652386dc31d9e30
  19:     0x7f0f03350bc6 - <alloc::rc::Rc<T> as core::ops::drop::Drop>::drop::h60c7e2432b201062
  20:     0x7f0f0332a6fd - core::ptr::drop_in_place::h2f4d4236293b18c7
  21:     0x7f0f03324dea - rustc_span::with_source_map::h23e56868796f6dc3
  22:     0x7f0f03359ed2 - rustc_interface::interface::create_compiler_and_run::h9a8debbb19483b80
  23:     0x7f0f03338d0a - scoped_tls::ScopedKey<T>::set::hacc47b1cdb25a215
  24:     0x7f0f0335c611 - std::sys_common::backtrace::__rust_begin_short_backtrace::h3d5db7946c19f316
  25:     0x7f0f032da18e - core::ops::function::FnOnce::call_once{{vtable.shim}}::he1a30fa4d30a2178
  26:     0x7f0f02a82fda - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h588ce842808b3fd0
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/alloc/src/boxed.rs:1042
  27:     0x7f0f02a82fda - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h46bc655f05471a92
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/alloc/src/boxed.rs:1042
  28:     0x7f0f02a82fda - std::sys::unix::thread::Thread::new::thread_start::hb4b79d379b730058
                               at /rustc/98edd1fbf8a68977a2a7c1312eb1ebff80515a92/library/std/src/sys/unix/thread.rs:87
  29:     0x7f0f0297f3e9 - start_thread
  30:     0x7f0f0289c293 - __GI___clone
  31:                0x0 - <unknown>

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.49.0-nightly (98edd1fbf 2020-10-06) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z mir-opt-level=2

query stack during panic:
end of query stack

</p> </details>

Change dependency from dirs to dirs-next in manifest files and modify usage of dirs library to use dirs-next library.

The reddit post about the change states that dirs-next is a drop in replacement. I could have just aliased dirs-next to dirs in Cargo.toml, but I actually changed the usage from dirs to dirs-next.

- let mut cache_dir: Option<PathBuf> = dirs::cache_dir();
+ let mut cache_dir: Option<PathBuf> = dirs_next::cache_dir();

The link to the github repo of the project needs to be updated as well.

Hi! So, the stuff about the registry indices is inside src/cache. I tried to split up everything so that there is a "Supercache" (this is similar to the ~/.cargo/registry/cache directory) and a "subcache" which represents a single registry (such as ~/.cargo/registry/cache/github.com-1ecc6299db9ec823, the default crates.io registry, or an alternative registry (~/.cargo/registry/cache/dl.cloudsmith.io-0aaaba6a806079f8).

You can find the supercache and subcache traits here: https://github.com/matthiaskrgr/cargo-cache/blob/master/src/cache/caches.rs

All the subcache-structs should have a name field which is derived from the registry-directory name. IIRC it will be "github.com" for the default crates.io registry and dl.cloudsmith.io for my cloudsmith test registry.

For removing only from a specified registry I would add a new --registry= cmdline flag to specify a registry to remove. (this could also be a comma-seperated list of registries to remove, like --registry="github.com,cloudsmith"). Then --autoclean, --autoclean-expensive, --keep-duplicate-crates, --remove-dir, --remove-if-younger/older-thanas well as the clean-unref and the trim subcommands need to be tweaked to touch specified registries if the --registry flag was passed.

The commandline/clap interface is mostly defined here https://github.com/matthiaskrgr/cargo-cache/blob/master/src/cli.rs, most of the conditional logic happens in main.rs though.

The most tricky part will be to find all the places where stuff is being removed (git grep remove_) and add some kind of filter that keeps certain registries alive.

For example --autoclean is implemented here: https://github.com/matthiaskrgr/cargo-cache/blob/master/src/main.rs#L386

currently it just blindly removes ~/.cargo/registry/src and ~/.cargo/git/checkouts. We can ignore the .git repo, but we need to restrict it here to only remove a the specified registry.

the cargo_cache is just a struct holding directory paths, we would actually need the Cache here which is registry_sources_caches variable. We need to bring the SubCache trait into scope and then we can access the registries one by one via registry_sources_caches.caches().iter().for_each(|x| println!("{}", x.name())); (the .caches() returns a vec of Paths, each path is the directory of a subcache aka a registry.) This will print the names of each registry that is found. You can add .filter() to only match wanted registries and the pass these along for removal: Concept diff:

diff --git a/src/main.rs b/src/main.rs
index 1329460..9c1f7da 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -74,6 +74,7 @@ cfg_if::cfg_if! {

         // use
         use crate::cache::caches::{Cache, RegistrySuperCache};
+        use crate::cache::caches::RegistrySubCache;
         use clap::value_t;
         use std::process;
         use std::time::SystemTime;
@@ -384,26 +385,28 @@ fn main() {
     }

     if config.is_present("autoclean") || config.is_present("autoclean-expensive") {
-        // clean the registry sources and git checkouts
-        let reg_srcs = &cargo_cache.registry_sources;
+        // clean the registry sources and git checkoutsname
+        //  let reg_srcs  = &cargo_cache.registry_sources;
         let git_checkouts = &cargo_cache.git_checkouts;

+        // collect the registries to remove,
+        let mut paths_to_be_removed: Vec<&std::path::PathBuf> = registry_sources_caches
+            .caches()
+            .iter()
+            /*.filter( only match wanted registries )*/
+            .map(|subcache| subcache.path())
+            .collect();
+
+        paths_to_be_removed.push(git_checkouts);
+
         // depending on the size of the cache and the system (SSD, HDD...) this can take a few seconds.
         println!("\nClearing cache...");

-        for dir in &[reg_srcs, git_checkouts] {
-            let size = cumulative_dir_size(dir);
-            if dir.is_dir() {
-                remove_file(
-                    dir,
-                    config.is_present("dry-run"),
-                    &mut size_changed,
-                    None,
-                    &DryRunMessage::Default,
-                    Some(size.dir_size),
-                );
-            }
+        for dir in paths_to_be_removed {
+            println!("removing: {:?}", dir.display());
+            /* remove */
         }
+        return;
     }

     if config.is_present("keep-duplicate-crates") {

It would make sense to also have a command which lists all registries and their names cargo cache --list-registries? at some point. Oh and currently the function that tries to figure out the name of a cache/registry removes the hash from the git repo (git grep "fn get_cache_name"). In order to disambiguate between different registries on the same host, it should probably be modified to not throw away the hash.

I hope this helps and is not too confusing, feel free to bombard me with questions. :sweat_smile: :D

Thanks! @bors r+

Hmm, it seems the rustfmt commit 5e667d326f929a0770c1e56cd0a921dfb16400e2 has not yet landed inside the rustfmt submodule of the rustc repo.

Argh, apparently editing a comment that contains @bors try will retrigger bors, sorry :/

Making this a variable and using the var inside the format!() is clearer imo.

This could be the same as the lint message: "use of disallowed method call"

lint messages should not be capitalized

I bors will try on windows, too? @bors try

Ah good point! I added the fix.

How urgent is this, should this be included in https://github.com/rust-lang/rust/pull/77144 ? (pr was not approved yet)

Ok :+1:

@bors r+

Just making sure I understood correctly; The changes that are being reverted here were based on the assumption that const fns were always evaluated at compiletime BUT this is wrong because they are only evaluated at compile time if called from a const context (such as const var bindings)?

Thanks! @bors r+

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

Fixes #77105

Apparently the script wants it at the beginning of the toml file, the warning message should says so :roll_eyes:

warning: x.py has made several changes recently you may want to look at
help: consider looking at the changes in `src/bootstrap/CHANGELOG.md`
note: to silence this warning, add `changelog-seen = 1` to `config.toml`

So I skipped through the changelog and added changelog-seen = 1 to the end of my config toml but this broke x.py:

failed to parse TOML configuration 'config.toml': unknown fieldchangelog-seen, expected one ofsign-folder,gpg-password-file,upload-addr,src-tarball,missing-toolsfor keydistat line 522 column 1

Still crashes after llvm update in https://github.com/rust-lang/rust/pull/77063

Alright, I removed changes from the pr. Sprinkling the rustc code with clippy allow attributes is probably something most people would object though.

Shouldn't we keep some tests where the counters are incremented at the start of the loop?

Hm. To me true & !false is easier to understand than true > false.

<!-- Thank you for filing a bug report! 🐛 Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. -->

I tried this code:

pub fn main() {
    let mut i = 0;
    let v = vec!["a", "b", "c"];
    for x in &v {
        i += 1;
        println!("{}", i)
    }
}

explicit_counter_loop will trigger here and suggest to use .iter().enumerate(). The problem is that we increment BEFORE using (and not at the end of the loop) so the first iteration will print 1 and not 0 as it would with .enumerate(). This newly suggested code is off by one as can be seen here:

pub fn main() {
    let mut i = 0;
    let v = vec!["a", "b", "c"];
    for (x, _) in v.iter().enumerate() {
        i += 1;
        println!("i is {} but x is {}", i, x)
    }
}

i is 1 but x is 0
i is 2 but x is 1
i is 3 but x is 2

clippy 0.0.212 (fb1dc34 2020-09-21)

oh right! Thanks.

The assembly is the same, (one of the functions even gets removed in the example because its identical to the other one) https://godbolt.org/z/czfczr

commits stand alone and can be reviewed one by one

In this code we first create the mut range bound, and mutate it in another loop which means the loop that actually uses the range is executed several times with different bounds (even if it is true that inside the usage of the range, changing the index has no effect on the inner loop.

fn main() {
    let mut i = 3;
    while i < 1000 { // this invalidates the lint warning
        for x in i..9 { // this will be unaffected by the i+=4 but we modify i AND LOOP AGAIN!
            i += 4; // lint warns about this
        }

        if i > 12 {
            return;
        }
    }
}

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=30343889f1b8be663adb15c2d8184c2a

The lint should probably only fire if range bound variable and the range bounds usage are in the same scope?

Meta

clippy 0.0.212 (1fd5b9d 2020-09-20)

Hm, right now, ra is broke for me anyway, see https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Fixing.20sysroot.20loading

Mhh, it seems that 76856 did not help, RA does not automatically find rustc sources in clippy, at least when I tried. cc https://github.com/rust-analyzer/rust-analyzer/issues/3517 I found compiler sources at ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/rustc-src/rust/compiler.

We could perhaps use that (and use master toolchain sources) instead of some kind of path to a local repo at least...

I made it a separate lint because this way users could disable push_str and insert_str independently but it's probably better to just make it one lint since the patterns are so similar.

ah, well I did include the other pr in this one to avoid merge conflicts later down the road

r? @lcnr

r? @Dylan-DPC

Still crashing (obviously on nightly, beta and stable by now...).

warning: variant is never constructed: `Some`
 --> src/main.rs:5:5
  |
5 |     Some(*const T), // Can also use PhantomData<T>
  |     ^^^^^^^^^^^^^^
  |
  = note: `#[warn(dead_code)]` on by default

warning: Error finalizing incremental compilation session directory `/tmp/a/target/debug/incremental/a-3ibewktm5f4s7/s-frdnn34p4t-5wozmt-working`: No such file or directory (os error 2)

warning: 2 warnings emitted

error: internal compiler error: broken MIR in DefId(0:6 ~ a[e6bb]::foo[0]) (NoSolution): could not prove TraitPredicate(<[O<B>] as std::cmp::PartialEq>)
  |
  = note: delayed at compiler/rustc_mir/src/borrow_check/type_check/mod.rs:258:27

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
stack backtrace:
   0:     0x7fb253922b30 - std::backtrace_rs::backtrace::libunwind::trace::he85dfb3ae4206056
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/../../backtrace/src/backtrace/libunwind.rs:96
   1:     0x7fb253922b30 - std::backtrace_rs::backtrace::trace_unsynchronized::h1ad28094d7b00c21
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/../../backtrace/src/backtrace/mod.rs:66
   2:     0x7fb253922b30 - std::sys_common::backtrace::_print_fmt::h901b54610713cd21
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/sys_common/backtrace.rs:79
   3:     0x7fb253922b30 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hb0ad78ee1571f7e0
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/sys_common/backtrace.rs:58
   4:     0x7fb253990e7c - core::fmt::write::h1857a60b204f1b6a
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/core/src/fmt/mod.rs:1080
   5:     0x7fb253914f07 - std::io::Write::write_fmt::hf7b7d7b243f84a36
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/io/mod.rs:1517
   6:     0x7fb253927880 - std::sys_common::backtrace::_print::hd093978a5287b8ff
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/sys_common/backtrace.rs:61
   7:     0x7fb253927880 - std::sys_common::backtrace::print::h20f46787581d56d7
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/sys_common/backtrace.rs:48
   8:     0x7fb253927880 - std::panicking::default_hook::{{closure}}::h486cbb4b82ffc357
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/panicking.rs:208
   9:     0x7fb253927538 - std::panicking::default_hook::h4190c9e3edd4d591
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/panicking.rs:227
  10:     0x7fb2541bb8d4 - rustc_driver::report_ice::h0baa69c9fa359ad1
  11:     0x7fb2539280b6 - std::panicking::rust_panic_with_hook::h72e78719cdda225c
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/panicking.rs:581
  12:     0x7fb253927c39 - std::panicking::begin_panic_handler::{{closure}}::h8bd07dbd34150a96
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/panicking.rs:484
  13:     0x7fb253922fbc - std::sys_common::backtrace::__rust_end_short_backtrace::hdb6b3066ad29028a
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/sys_common/backtrace.rs:153
  14:     0x7fb253927bf9 - rust_begin_unwind
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/panicking.rs:483
  15:     0x7fb253927bab - std::panicking::begin_panic_fmt::hc19e75fd2b7bc39b
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/panicking.rs:437
  16:     0x7fb2572fd471 - rustc_errors::HandlerInner::flush_delayed::hc01570dc9a0301e8
  17:     0x7fb2572f9dd1 - <rustc_errors::HandlerInner as core::ops::drop::Drop>::drop::h2fa2449267c97abc
  18:     0x7fb2541df306 - core::ptr::drop_in_place::h3ccf454d686c35e3
  19:     0x7fb2541e9d36 - <alloc::rc::Rc<T> as core::ops::drop::Drop>::drop::h9871ec79020d3d08
  20:     0x7fb2541cdb4d - core::ptr::drop_in_place::h37be4f3688653901
  21:     0x7fb2541bfd31 - rustc_span::with_source_map::he9a81669cd160b82
  22:     0x7fb2541eebd8 - rustc_interface::interface::create_compiler_and_run::h06c2389085f2a79e
  23:     0x7fb2541c02aa - rustc_span::with_session_globals::h3a06e50e1db00721
  24:     0x7fb2541f148d - std::sys_common::backtrace::__rust_begin_short_backtrace::h6f73648415d0d9ce
  25:     0x7fb2541621ce - core::ops::function::FnOnce::call_once{{vtable.shim}}::h213be4bbd07cfb62
  26:     0x7fb25393796a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h1080dfe0ef616bdf
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/alloc/src/boxed.rs:1042
  27:     0x7fb25393796a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hd2747e1f2d5cec32
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/alloc/src/boxed.rs:1042
  28:     0x7fb25393796a - std::sys::unix::thread::Thread::new::thread_start::hd0f336b4ef6808a7
                               at /rustc/f68e08933d8f519a9655934fedebbc509661b219/library/std/src/sys/unix/thread.rs:87
  29:     0x7fb2538343e9 - start_thread
  30:     0x7fb253751293 - __GI___clone
  31:                0x0 - <unknown>

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.48.0-nightly (f68e08933 2020-09-19) running on x86_64-unknown-linux-gnu

note: compiler flags: -C embed-bitcode=no -C debuginfo=2 -C incremental --crate-type bin

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
end of query stack
error: could not compile `a`
```

Looks like this introduced some perf regressions https://perf.rust-lang.org/compare.html?start=10b3595ba6a4c658c9dea105488fc562c815e434&end=5e449b9adff463455743291b0c1f76feec092992&stat=instructions:u

Mmh, looks like a test is failing: https://github.com/rust-lang/rust-clippy/pull/6069/checks?check_run_id=1139967161#step:10:138

public functions should not be linted, so the example code should not be pub fns :)

a test function that always Err or None might be useful as well.

How similar is this to clippys needless_borrow lint? https://rust-lang.github.io/rust-clippy/master/#needless_borrow

This one is actually needed

error[E0308]: mismatched types
   --> compiler/rustc_mir_build/src/build/block.rs:99:70
    |
99  |                     let ignores_expr_result = matches!(pattern.kind, PatKind::Wild);
    |                                                        ------------  ^^^^^^^^^^^^^ expected struct `std::boxed::Box`, found enum `thir::pattern::PatKind`
    |                                                        |
    |                                                        this expression has type `std::boxed::Box<thir::pattern::PatKind<'_>>`
    |
   ::: compiler/rustc_mir_build/src/thir/pattern/mod.rs:121:5
    |
121 |     Wild,
    |     ---- unit variant defined here
    |
    = note: expected struct `std::boxed::Box<thir::pattern::PatKind<'_>>`
                 found enum `thir::pattern::PatKind<'_>`

```

use if let instead of single match arm expressions to compact code and reduce nesting (clippy::single_match)