profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/JohnTitor/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Yuki Okushi JohnTitor @Huawei Japan https://www.2k36.org Japanese codewriting ninja | Working for @rust-lang, @actix, etc. | he/they

actix/actix-extras 258

A collection of additional crates supporting the actix and actix-web frameworks.

actix/actix-web-httpauth 76

Moved to actix-extras repo.

JohnTitor/2k36.org 1

My profile + blog.

JohnTitor/.github-rustasync 0

Community health files

JohnTitor/actix 0

Actor framework for Rust

JohnTitor/actix-amqp 0

AMQP 1.0 Server framework

JohnTitor/actix-derive 0

Derive macro for actix framework

JohnTitor/actix-extras 0

A collection of additional crates supporting the actix and actix-web frameworks.

delete branch JohnTitor/rust

delete branch : tait-tests

delete time in 9 hours

delete branch JohnTitor/rust

delete branch : rollup-yq24nq5

delete time in 9 hours

pull request commentrust-lang/libc

Add SYS_fcntl to aarch64 android

Thanks! @bors r+

flxo

comment created time in 20 hours

PullRequestReviewEvent

pull request commentrust-lang/libc

android system prop api update.

@bors r+

devnexen

comment created time in 20 hours

pull request commentrust-lang/rust

Add a hint that the expressions produce a value

@bors r=estebank

JohnTitor

comment created time in 20 hours

Pull request review commentrust-lang/rust

Add a hint that the expressions produce a value

 impl<'tcx> LateLintPass<'tcx> for UnusedResults {          if let Some(must_use_op) = must_use_op {             cx.struct_span_lint(UNUSED_MUST_USE, expr.span, |lint| {-                lint.build(&format!("unused {} that must be used", must_use_op)).emit()+                let mut lint = lint.build(&format!("unused {} that must be used", must_use_op));+                lint.note(&format!("the {} produces a value", must_use_op));+                if let Ok(snippet) = cx.sess().source_map().span_to_snippet(expr.span) {+                    lint.span_suggestion(+                        expr.span,+                        "use `let _ = ...` to ignore it",+                        format!("let _ = {}", snippet),+                        Applicability::MachineApplicable,+                    )+                    .emit()+                }

Thanks! Applied it with changing expr.span to expr.span.shrink_to_lo().

JohnTitor

comment created time in 20 hours

PullRequestReviewEvent

push eventJohnTitor/rust

Fabian Wolff

commit sha 74d1bd21c78765712612afdd5eab3efa00757064

Use more precise span for E0282 in cast expressions

view details

phlopsi

commit sha 3e82dca65c226324580db910b2609e8dce1850ac

Optimize fmt::PadAdapter::wrap

view details

Thomas Otto

commit sha e8f57c3ac4d57988e610ef6645d867ea76e8f25d

No longer suggest inserting or appending an underscore changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names

view details

xFrednet

commit sha 2ac21889bcc0634eabd1ff36491042fd0dae003f

Use diagnostic items for `BinaryHeap`, `BTreeMap`, `BTreeSet`, `HashMap`, `HashSet`, `Borrow`, `Default`

view details

xFrednet

commit sha 6030428fd22912afeeaecfcc0220e979c2ffeb0a

Use diagnostic items for `Into`, `IntoIterator`, `LinkedList`, `ptr::null`, `prt::null_mut`

view details

xFrednet

commit sha 6ce6b29527f05e2b0fa09009053d5095f4d38aa1

Use diagnostic items for `intrinsics::transmute`, `TryInto`

view details

xFrednet

commit sha ecf85f4bdc319f9d9d853d1fff68a8a25e64c7a8

Use diagnostic items for `Vec`, `VecDeque` and connected refactorings

view details

Michael Howell

commit sha f882c363e2ff2ab7b0a3cf8e95b88e0909e68230

fix(clippy): add missing allow(dyn_drop)

view details

flip1995

commit sha 884ef4c287480704e0176930347563410eb8907f

Merge commit '4c41a222ca5d1325fb4b6709395bd06e766cc042' into clippyup

view details

bors

commit sha 610381455cb78a31695b94bc45ee580cf0cd7b38

Auto merge of #7221 - th1000s:keyword_, r=giraffate similar_names: No longer suggest inserting or appending an underscore changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names

view details

F3real

commit sha 24ec35a90433b40fcca4272dce27c107f7be51d9

Enhance needless continue to detect loop {continue;}

view details

F3real

commit sha 9d6127cdb0bead8f3a19440e9029edc9bf2e9a25

Emit needless_continue warning if loop ends on continue

view details

F3real

commit sha c3452f3bd261e029b361c94ba8ed3bb909fde5fb

Lint on continue expression without semi-colon

view details

xFrednet

commit sha 544c462d255e23c99d99c5ed67a7b16bf61eb563

Documented constant expression evaluation for `repeat_once`

view details

F3real

commit sha 045dbb52d5bc3d97d30234c69a9c556f7d779732

Clean up unnecessary unwraps

view details

chaz-kiker

commit sha 1b8fc8f13d9f3874ae88c482807c24c2218e4179

update clippy ui test 'future_not_send.stderr' to match the new diagnostic messages

view details

Cameron Steffen

commit sha ea97a5a5d789b0bf4e4ae984e04280e5c5847b82

Add clippy_utils and if_chain to extern crate list

view details

Cameron Steffen

commit sha afe5962d380d9c2caf5e5edb1aa3251ce2ec064d

clippy::author improvements

view details

bors

commit sha ea69a9d10a0c55160a3981dfae11b7197b50c11d

Auto merge of #7482 - xFrednet:7306-document-repeat-once-fp, r=giraffate Documented constant expression evaluation for `repeat_once` Documents the fact that the `repeat_once` lint evaluates constant expressions --- closes: #7306 changelog: none (I don't think it's worth a change log entry, as nothing has really changed) r? `@giraffate` as you've implemented the lint and were part of the discussion in the issue :upside_down_face:

view details

kadmin

commit sha 00faed9f0cb0129dc39d3f6ea769df35c68a4d05

Add generic arg infer

view details

push time in 20 hours

PR opened rust-lang/rust

Fix a parser ICE on invalid `fn` body

Fixes #87635 A better fix would add a check for fn body on expected_one_of_not_found but I haven't come up with a graceful way. Any idea? r? @oli-obk @estebank

+29 -3

0 comment

3 changed files

pr created time in 21 hours

create barnchJohnTitor/rust

branch : fix-parser-ice

created branch time in 21 hours

push eventJohnTitor/rust

Fabian Wolff

commit sha 74d1bd21c78765712612afdd5eab3efa00757064

Use more precise span for E0282 in cast expressions

view details

phlopsi

commit sha 3e82dca65c226324580db910b2609e8dce1850ac

Optimize fmt::PadAdapter::wrap

view details

Thomas Otto

commit sha e8f57c3ac4d57988e610ef6645d867ea76e8f25d

No longer suggest inserting or appending an underscore changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names

view details

xFrednet

commit sha 2ac21889bcc0634eabd1ff36491042fd0dae003f

Use diagnostic items for `BinaryHeap`, `BTreeMap`, `BTreeSet`, `HashMap`, `HashSet`, `Borrow`, `Default`

view details

xFrednet

commit sha 6030428fd22912afeeaecfcc0220e979c2ffeb0a

Use diagnostic items for `Into`, `IntoIterator`, `LinkedList`, `ptr::null`, `prt::null_mut`

view details

xFrednet

commit sha 6ce6b29527f05e2b0fa09009053d5095f4d38aa1

Use diagnostic items for `intrinsics::transmute`, `TryInto`

view details

xFrednet

commit sha ecf85f4bdc319f9d9d853d1fff68a8a25e64c7a8

Use diagnostic items for `Vec`, `VecDeque` and connected refactorings

view details

Michael Howell

commit sha f882c363e2ff2ab7b0a3cf8e95b88e0909e68230

fix(clippy): add missing allow(dyn_drop)

view details

flip1995

commit sha 884ef4c287480704e0176930347563410eb8907f

Merge commit '4c41a222ca5d1325fb4b6709395bd06e766cc042' into clippyup

view details

bors

commit sha 610381455cb78a31695b94bc45ee580cf0cd7b38

Auto merge of #7221 - th1000s:keyword_, r=giraffate similar_names: No longer suggest inserting or appending an underscore changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names

view details

F3real

commit sha 24ec35a90433b40fcca4272dce27c107f7be51d9

Enhance needless continue to detect loop {continue;}

view details

F3real

commit sha 9d6127cdb0bead8f3a19440e9029edc9bf2e9a25

Emit needless_continue warning if loop ends on continue

view details

F3real

commit sha c3452f3bd261e029b361c94ba8ed3bb909fde5fb

Lint on continue expression without semi-colon

view details

xFrednet

commit sha 544c462d255e23c99d99c5ed67a7b16bf61eb563

Documented constant expression evaluation for `repeat_once`

view details

F3real

commit sha 045dbb52d5bc3d97d30234c69a9c556f7d779732

Clean up unnecessary unwraps

view details

chaz-kiker

commit sha 1b8fc8f13d9f3874ae88c482807c24c2218e4179

update clippy ui test 'future_not_send.stderr' to match the new diagnostic messages

view details

Cameron Steffen

commit sha ea97a5a5d789b0bf4e4ae984e04280e5c5847b82

Add clippy_utils and if_chain to extern crate list

view details

Cameron Steffen

commit sha afe5962d380d9c2caf5e5edb1aa3251ce2ec064d

clippy::author improvements

view details

bors

commit sha ea69a9d10a0c55160a3981dfae11b7197b50c11d

Auto merge of #7482 - xFrednet:7306-document-repeat-once-fp, r=giraffate Documented constant expression evaluation for `repeat_once` Documents the fact that the `repeat_once` lint evaluates constant expressions --- closes: #7306 changelog: none (I don't think it's worth a change log entry, as nothing has really changed) r? `@giraffate` as you've implemented the lint and were part of the discussion in the issue :upside_down_face:

view details

kadmin

commit sha 00faed9f0cb0129dc39d3f6ea769df35c68a4d05

Add generic arg infer

view details

push time in a day

pull request commentrust-lang/rust

Lint missing Abi in ast validation instead of lowering.

Failed in rollup: https://github.com/rust-lang/rust/pull/87639#issuecomment-890096488 Seems we should rebase and bless tests? @bors r-

cjgillot

comment created time in a day

delete branch JohnTitor/rust

delete branch : rollup-8puev3l

delete time in a day

PR closed rust-lang/rust

Rollup of 9 pull requests S-waiting-on-bors rollup

Successful merges:

  • #87114 (Lint missing Abi in ast validation instead of lowering.)
  • #87385 (Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default)
  • #87547 (Add missing examples for NonNull)
  • #87557 (Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic)
  • #87559 (Tweak borrowing suggestion in for loop)
  • #87596 (Add warning when whitespace is not skipped after an escaped newline)
  • #87606 (Add some TAIT-related regression tests)
  • #87609 (Add docs about performance and Iterator::map to [T; N]::map)
  • #87616 (Fix missing word in rustdoc book)

Failed merges:

r? @ghost @rustbot modify labels: rollup <!-- homu-ignore:start --> Create a similar rollup <!-- homu-ignore:end -->

+626 -143

3 comments

48 changed files

JohnTitor

pr closed time in a day

pull request commentrust-lang/rust

Rollup of 9 pull requests

@bors r+ p=9 rollup=never

JohnTitor

comment created time in a day

PR opened rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #86072 (Cross compiling rustc_llvm on Darwin requires zlib.)
  • #87385 (Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default)
  • #87547 (Add missing examples for NonNull)
  • #87557 (Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic)
  • #87559 (Tweak borrowing suggestion in for loop)
  • #87596 (Add warning when whitespace is not skipped after an escaped newline)
  • #87606 (Add some TAIT-related regression tests)
  • #87609 (Add docs about performance and Iterator::map to [T; N]::map)
  • #87616 (Fix missing word in rustdoc book)

Failed merges:

r? @ghost @rustbot modify labels: rollup <!-- homu-ignore:start --> Create a similar rollup <!-- homu-ignore:end -->

+577 -94

0 comment

43 changed files

pr created time in a day

push eventJohnTitor/rust

Wilfred Hughes

commit sha c2a365d3d4b5c067adfe8462a749e0c40746617a

Fix missing word in comment

view details

Yuki Okushi

commit sha 8d5291c7cdc0b593fdfb35293b372506447f72cd

Rollup merge of #87616 - Wilfred:patch-1, r=jyn514 Fix missing word in rustdoc book

view details

push time in a day

push eventJohnTitor/rust

Lukas Kalbertodt

commit sha 5cc7702bde47716c66734c488432850fab1a83dd

Add docs about performance and `Iterator::map` to `[T; N]::map`

view details

Yuki Okushi

commit sha f4dfb76ea1f1312c6602a0ab24ec64f976c0a281

Rollup merge of #87609 - LukasKalbertodt:improve-array-map-docs, r=m-ou-se Add docs about performance and `Iterator::map` to `[T; N]::map` This suboptimal code gen for some usages of array::map got a bit of attention by multiple people throughout the community. Some cases: - https://github.com/rust-lang/rust/issues/75243#issuecomment-866051086 - https://github.com/rust-lang/rust/issues/75243#issuecomment-874732134 - https://www.reddit.com/r/rust/comments/oeqqf7/unexpected_high_stack_usage/ My *guess* is that this gets the attention it gets because in JavaScript (and potentially other languages), a `map` function on arrays is very commonly used since in those languages, arrays basically take the role of Rust's iterator. I considered explicitly naming JavaScript in the first paragraph I added, but I couldn't find precedence of mentioning other languages in standard library doc, so I didn't add it. When array::map was stabilized, we still wanted to add docs, but that somehow did not happen in time. So here we are. Not sure if this sounds crazy but maybe it is worth considering beta backporting this? Only if it's not a lot of work, of course! But yeah, stabilized array::map is already in beta and if this problem is really as big as it sometimes seems, might be worth having the docs in place when 1.55 is released. CC ``@CryZe`` r? ``@m-ou-se`` (since you were involved in that discussion and the stabilization)

view details

push time in a day

push eventJohnTitor/rust

Yuki Okushi

commit sha 5b5391e283e591520235d7aafd6f1f0aa3b6ce22

Add some TAIT-related regression tests

view details

Yuki Okushi

commit sha 2bdc54fb4570a8bb82019bb00049feefdf8ac585

Rollup merge of #87606 - JohnTitor:tait-tests, r=oli-obk Add some TAIT-related regression tests Closes #74280, closes #77179. r? ``@oli-obk``

view details

push time in a day

push eventJohnTitor/rust

Anton Golov

commit sha 5d59b4412e71298e6e44b55afbfaa9dd86aee590

Add warning when whitespace is not skipped after an escaped newline.

view details

Yuki Okushi

commit sha aa9e6aa8ad96888eb63e391a9d40373283c189b2

Rollup merge of #87596 - jesyspa:issue-87318-hidden-whitespace, r=estebank Add warning when whitespace is not skipped after an escaped newline Fixes issue #87318, also simplifies issue #87319. * Add support to the lexer to emit warnings as well as errors. * Emit a warning when a string literal contains an escaped newline, but when (some of) the whitespace on the next line is not skipped due to it being non-ASCII.

view details

push time in a day

push eventJohnTitor/rust

Esteban Küber

commit sha 17b2f92e44b65caa5e057c51560336311caf2fb4

Tweak borrowing suggestion in `for` loop

view details

Yuki Okushi

commit sha 5e2655d27fdd523285856f8bdacbccdc07b4fc6c

Rollup merge of #87559 - estebank:consider-borrowing, r=oli-obk Tweak borrowing suggestion in `for` loop

view details

push time in a day

push eventJohnTitor/rust

Ryan Levick

commit sha 578fcbdb3c4cb893f5bd1d884788d60e2a2b6786

Fix error with suggestion for how to disambiguate associated function when struct is generic

view details

Yuki Okushi

commit sha fb27c4cc70bc4b1f01847ca95933849152b4df80

Rollup merge of #87557 - rylev:fix-invalid-prelude-collision-error, r=nikomatsakis Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic Fixes #86940 The test cases and associated issue should make it clear what specifically this is meant to fix. The fix is slightly hacky in that we check against the literal source code of the call site for the presence of `<` in order to determine if the user has included the generics for the struct (meaning we don't need to include them for them). r? ``@nikomatsakis``

view details

push time in a day

push eventJohnTitor/rust

Guillaume Gomez

commit sha 1bbe6188d255a2466fba7220db80536bf7d12672

Add missing examples for NonNull

view details

Yuki Okushi

commit sha f7a2a2281548c90214c18c6cb65030b70b58df7b

Rollup merge of #87547 - GuillaumeGomez:nonnull-examples, r=kennytm Add missing examples for NonNull

view details

push time in a day

push eventJohnTitor/rust

Aaron Hill

commit sha 886dea2bcdad68cadc13ea84e42df0c94179f79a

Make `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` warn by default

view details

Aaron Hill

commit sha cf167c9c9c0576472b67f5498a074bc697c9af23

Only emit lint for local macros

view details

Aaron Hill

commit sha 6954f9d4f21837e145b4aa629262a62b5f21fa8f

Update stderr

view details

Aaron Hill

commit sha e70ce57f306c730c7a949942671cd525e281f2ec

Remove unnecessary trailing semicolons from clippy tests

view details

Yuki Okushi

commit sha f6bc738433a1a5b5ae36524535fed22c4c06b66e

Rollup merge of #87385 - Aaron1011:final-enable-semi, r=petrochenkov Make `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` warn by default This PR makes the `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` lint warn by default. To avoid showing a large number of un-actionable warnings to users, we only enable the lint for macros defined in the same crate. This ensures that users will be able to fix the warning by simply removing a semicolon. In the future, I'd like to enable this lint unconditionally, and eventually make it into a hard error in a future edition. This PR is a step towards that goal.

view details

push time in a day

push eventJohnTitor/rust

Marcus Calhoun-Lopez

commit sha 956fd10660e836ac4602527f7297aa68b24eca17

Cross compiling rustc_llvm on Darwin requires zlib.

view details

Yuki Okushi

commit sha 9391d5520478bd98276f8424b62a09b63e98037b

Rollup merge of #86072 - MarcusCalhoun-Lopez:llvm_cross, r=nagisa Cross compiling rustc_llvm on Darwin requires zlib.

view details

push time in a day

create barnchJohnTitor/rust

branch : rollup-yq24nq5

created branch time in a day

issue commentrust-lang/rust

ICE on nightly 1.56.0 (2021-07-29) when missing semicolon or function body in impl block

Regressed since #87480, I think #87436 is the cause.

dataphract

comment created time in a day

pull request commentrust-lang/rust

Rollup of 9 pull requests

@bors r+ p=9 rollup=never

JohnTitor

comment created time in a day

PR opened rust-lang/rust

Rollup of 9 pull requests

Successful merges:

  • #87114 (Lint missing Abi in ast validation instead of lowering.)
  • #87385 (Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default)
  • #87547 (Add missing examples for NonNull)
  • #87557 (Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic)
  • #87559 (Tweak borrowing suggestion in for loop)
  • #87596 (Add warning when whitespace is not skipped after an escaped newline)
  • #87606 (Add some TAIT-related regression tests)
  • #87609 (Add docs about performance and Iterator::map to [T; N]::map)
  • #87616 (Fix missing word in rustdoc book)

Failed merges:

r? @ghost @rustbot modify labels: rollup <!-- homu-ignore:start --> Create a similar rollup <!-- homu-ignore:end -->

+626 -143

0 comment

48 changed files

pr created time in a day