profile
viewpoint

gluon-lang/gluon 1974

A static, type inferred and embeddable language written in Rust.

Marwes/combine 787

A parser combinator library for Rust

brendanzab/codespan 212

Beautiful diagnostic reporting for text-based programming languages.

alexcrichton/tokio-signal 89

Unix signal handling for tokio

Marwes/combine-language 60

A crate which defines parsers for common programming language constructs using https://github.com/Marwes/combine

gluon-lang/gluon_language-server 31

Language server providing completion for gluon

distil/rust_lua_ffi 19

Automatic Rust and Lua glue code generation for seamless FFI interop

gluon-lang/gluon-lang.org 10

The gluon-lang.org website.

Jim-Holmstroem/RunRustFromLua 3

Rust functions called from Lua (LuaJIT) FFI

push eventMarwes/rust

Joshua Nelson

commit sha 62722735fb62c2f93656a012c29310155de35467

impl From<[T; N]> for Vec<T>

view details

Joshua Nelson

commit sha daeb8ece8c930174baa874aa3f2f278fbec9637d

fix error compiling stage2 Co-Authored-By: lzutao <taolzu@gmail.com>

view details

Joshua Nelson

commit sha f267d9dc191debfef74cc211dbca3d286b51f761

limit From impl to LengthAtMost32 Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

view details

Joshua Nelson

commit sha e3d5eaf2bba89db8359393ac7656db19cb421fb5

add ui-tests

view details

Joshua Nelson

commit sha ba46b61bbcd0d2860105c429cf73254c388e9118

bless UI tests

view details

Joshua Nelson

commit sha 96794d86f127dd409760765a64a36c07d9ed585f

fix test failure

view details

Joshua Nelson

commit sha 1ac4a461425b7a2e29aeb3c2b2cae944f8cbcc77

make the impl a little prettier

view details

Joshua Nelson

commit sha 8212584c9ecdbd91736fc7a480fe3b7409b73477

Bump release cutoff

view details

Joshua Nelson

commit sha 3477e67a92878adae48b975915cb7a5c21026cd4

Allow vec.rs to be over 3000 lines :(

view details

Tomasz Miąsko

commit sha 7fdc3efb7ad6e9f73110f8e2e01120cd022b5fc9

Add copy bound to atomic intrinsics

view details

Tomasz Miąsko

commit sha ec853b6b60e9cbe7b07458f9c33f0bb3f52e0776

Add copy bound to numeric intrinsics

view details

Wim Looman

commit sha 6fe7867ea6f5f912346d75459499fca88f6ae563

Add Result<Result<T, E>, E>::flatten -> Result<T, E>

view details

Vadim Petrochenkov

commit sha 733230530522d9f535b95d5bc304b11a94e2239c

Remove attribute `#[structural_match]` and any references to it

view details

Ana-Maria Mihalache

commit sha 50d2c3abd59af8cbed7e001b5b4e2f6a9a011112

Rename TyLayout to TyAndLayout.

view details

Stein Somers

commit sha e92d740b3586de0d0b476257b3539847f2db21e3

BTreeMap testing: introduce symbolic constants and refer to height consistently.

view details

bors

commit sha 8045865873f7cdbb864d0f66ef5ecb0d3ad847b2

Auto merge of #70370 - petrochenkov:nosmatch, r=Centril Remove attribute `#[structural_match]` and any references to it A small remaining part of https://github.com/rust-lang/rust/issues/63438.

view details

Mazdak Farrokhzad

commit sha c51fcb5f3847cc70de316db0b4c46f23fc8d0d35

Rollup merge of #68692 - jyn514:vec-from-array, r=LukasKalbertodt impl From<[T; N]> for Vec<T> Closes https://github.com/rust-lang/rust/issues/67963

view details

Mazdak Farrokhzad

commit sha 873bf46dc1677f24724cf2009703cf5c2a69a07a

Rollup merge of #70101 - tmiasko:intrinsics-copy, r=eddyb Add copy bound to atomic & numeric intrinsics

view details

Mazdak Farrokhzad

commit sha f31e56309a769dcef456ce419a81500801b247ef

Rollup merge of #70506 - ssomers:btreemap_testing_consts, r=RalfJung BTreeMap testing: introduce symbolic constants and use height consistently Doesn't change what or how much is tested, except for some exact integer types, just for convenience and because `node::CAPACITY` is a usize. r? @RalfJung

view details

bors

commit sha 8ab82b87af4f20b6c0a481e050517103d50263e9

Auto merge of #70525 - Centril:rollup-vj3esv3, r=Centril Rollup of 3 pull requests Successful merges: - #68692 (impl From<[T; N]> for Vec<T>) - #70101 (Add copy bound to atomic & numeric intrinsics) - #70506 (BTreeMap testing: introduce symbolic constants and use height consistently) Failed merges: r? @ghost

view details

push time in 2 days

pull request commentrust-lang/rust

perf: Unify the undo log of all snapshot types

Rebased, but it still needs the ena PR to be merged and released.

Marwes

comment created time in 2 days

push eventMarwes/rust

12101111

commit sha 7ca1b2f504a77fd6d82c981242c577dae05f0b9e

Don't use static crt by default when build proc-macro.

view details

12101111

commit sha 7996df992fba0b7e09215843fcfabc0c53828c57

Run format.

view details

12101111

commit sha 89aebbdd7b6cea56284d53ab5aff5e62f1e67b67

Only run this test on musl

view details

12101111

commit sha 84349cc56492d70b37ec288f6f3e887858635fa4

Remove trailing whitespace.

view details

Ralf Jung

commit sha 22ee27b266814485fe9ab7da4b539348cb994045

update backtrace crate

view details

Yuki Okushi

commit sha d6a17b598f0e82535fc38c8455aed9571f44aaa2

Move tidy check to mingw-check

view details

Tomasz Miąsko

commit sha 726d5185e00d37ad7bd24aac4f05bf9fd34765be

bootstrap: Use hash to determine if sanitizers needs to be rebuilt * Rebuild sanitizers runtimes when LLVM submodule commit changes. * When rebuilding LLVM / sanitizers, remove the stamp file before starting the build process to invalidate previous build output.

view details

Markus Westerlind

commit sha c6f1215d925561021eec296d9e88aa0305d0a18d

perf(dep_graph): Avoid allocating a set on when the number reads are small `reserve_and_rehash` takes up 1.4% of the runtime on the `packed-simd` benchmark which I believe is due to the number of reads are very low in many cases (see https://github.com/rust-lang/rust/pull/50565 for instance). This avoids allocating the set until we start allocating the `reads` `SmallVec` but it is possible that a lower limit might be better (not tested since the improvement will be hard to spot either way).

view details

Arkadiusz Piekarz

commit sha b90edfcc9e1c4ff547b012c41ba2d55974794a7e

Fix sequence of Type and Trait in optin-builtin-traits in Unstable Book

view details

Kornel

commit sha 8de1ec9ce0a53b8ad9987e923e833c82fda05603

Make error message clearer about creating new module

view details

Jonas Schievink

commit sha 425e7e5596c0ab6555fa75292d38863280d4a3d7

Don't insert panic when generator can not return

view details

Jonas Schievink

commit sha 5ac41a1a8d28493c7aa927ae49c664b9b9dce476

Don't insert panic when generator can not unwind

view details

Markus Westerlind

commit sha 4168c25b0f8aadcfe38c8bdae7cc51c22c2f45d1

refactor: Add an alias for the SmallVec in dep_graph

view details

Jonas Schievink

commit sha 46aeef6e655a85087f82bb0d1f94a97e83009218

Poison generators when any terminator unwinds This didn't cause issues before since generator types were always considered to "need drop", leading to unwind paths (including a `Resume` block) always getting generated.

view details

Jonas Schievink

commit sha 8d9f633f4d78777487010ae119454dc9674e42ee

Change index for SwitchInt case The indices do not matter here, and this fixes an index out of bounds panic when compiling a generator that can unwind but not return.

view details

Jonas Schievink

commit sha 2cbccced0856260c6acafabecb3030465dff28c2

Add test for unnecessary panic branches

view details

12101111

commit sha dbed65afaede1a819c5a7319685721339b61733b

Simplify checking of crt_static_feature()

view details

Guillaume Gomez

commit sha 57f1bb15b3f0d2fdd737804c7b7821fe1b40e256

clean up E0308 explanation

view details

Guillaume Gomez

commit sha 64460a12af8786a1859279d2944fd2fc67a3a159

Update tests

view details

Jonas Schievink

commit sha cb58de81654d92074a4abdbf90400f35f6a0062f

Apply suggestions from code review Co-Authored-By: bjorn3 <bjorn3@users.noreply.github.com>

view details

push time in 3 days

push eventMarwes/gluon

Etherian

commit sha 8c45b56c0eeb40ba9bcb4798f02dd0f580e125cc

initial new-parser commit

view details

Etherian

commit sha 03f31ceb768ded3b2b391d693909146d44cb77f6

files that should have been in the previous commit

view details

Etherian

commit sha 8d7f579e2faabf597acaafe7d8257a9be35390da

(std): undoing parser-related changes

view details

Etherian

commit sha 88e260c3baabfba759790409a8a6a713cdfec99e

style(std): clean up statet, lazyt, transformer

view details

Etherian

commit sha 1a7b01fd3b523d6eea1f694a5e7a3e5a8142abf6

Merge branch 'master' into statet

view details

Etherian

commit sha 3e0081cf3f87ae6995c763612eac4f0a52ab2f1f

style(std): rename functions in statet to snake case

view details

Etherian

commit sha a00c6ce5b8bf0ecfc570b66f41b5f0e2821d928e

style(std): remove extraneous parameters in statet.glu

view details

Etherian

commit sha aceae12075992372592c2b1a3408ce3ed2be6a6b

style(std): remove extraneous implicit parameter bindings in statet and lazyt

view details

Etherian

commit sha 0e9d7bc43845338e966eca5115378ddc46e0803e

fix(std): export wrap_monad from transformer.glu

view details

Etherian

commit sha 1adbc73264bd318d9a658e23522827ca9d6228be

test(std): add partially-finished StateT tests

view details

Markus Westerlind

commit sha 5f43862c422e533123bb68506ef3fcaf3a7ba814

refactor: Move the standard library modules to their own rust module

view details

Markus Westerlind

commit sha b561c8d61dda20ca71fb03cc36ca317cc139c458

feat: Add std.env

view details

bors[bot]

commit sha b7dd3d64a4616ef9f6c25a13275294f7f7156ab1

Merge #711 711: Add std.env r=Marwes a=Marwes Closes #701 Co-authored-by: Markus Westerlind <marwes91@gmail.com>

view details

Markus Westerlind

commit sha 170f4673a225f1e50d6e4ea84d020c563e3f1fc8

perf: Avoid creating function types unnecessarily

view details

bors[bot]

commit sha 81ebabe1b6825b3e954bc43aeec2d4c8f0fd6fa4

Merge #712 712: perf: Avoid creating function types unnecessarily r=Marwes a=Marwes Co-authored-by: Markus Westerlind <marwes91@gmail.com>

view details

Markus Westerlind

commit sha d1fef9688a3c8d379df0837ee18a4ff8f79c91ae

fix: Handle newtypes with a public field Fixes #713

view details

bors[bot]

commit sha 3c3dbd6495e1b3a3e47c9feffc474a75b26959a4

Merge #714 714: fix: Handle newtypes with a public field r=Marwes a=Marwes Fixes #713 Co-authored-by: Markus Westerlind <marwes91@gmail.com>

view details

Etherian

commit sha 5d8864f99fc25c606816bab7584f55a71e755648

fix(std): cleaned up statet.glu exports

view details

Etherian

commit sha 73ce047d82c67da4e309d8079966ebd7f4e423d1

test(std): fix and add to StateT tests

view details

Markus Westerlind

commit sha 1d12644e133220a30cb57a5e6b22afd925c50592

doc(book): Add GADTs to syntax and semantics

view details

push time in 3 days

push eventgluon-lang/gluon-lang.org

Markus Westerlind

commit sha de38761cf7cd2db63a7420620f83e6c4ab5f4389

Cargo update

view details

push time in 4 days

pull request commentrust-lang-nursery/ena

feat: Allow the UndoLog to be supplied separately

@nikomatsakis Anything else I can do to move this forward?

Marwes

comment created time in 5 days

push eventMarwes/gluon

Markus Westerlind

commit sha 1ad9148dcfaef03b79dd9cb5c2d9b6f42aa0e631

a

view details

push time in 5 days

issue closedgluon-lang/gluon

How to use Thread::run_expr_async()?

It seems like your documentation doesn't cover Thread::run_expr_async(). I try to call the VM asynchronously within tokio event loop not to block it and get an abscure compilation error:

use gluon::{self, ThreadExt};

/// An executor error.
pub enum Error {
    GluonError(gluon::Error),
}

/// A command executor.
pub struct Executor {
    thread: gluon::RootedThread,
}

impl Executor {
    /// Creates a new Executor instance.
    pub fn new() -> Executor {
        let mut thread = gluon::Thread::new();
        thread.run_io(true);
        Executor { thread: thread }
    }

    /// Executes a given Gluon script.
    pub async fn execute(&mut self, script: &str) -> Result<(), Error> {
        let res = self.thread.run_expr_async::<()>("test", &script).await;
        match res {
            Ok(()) => Ok(()),
            Err(err) => Err(Error::GluonError(err)),
        }
    }
}

error[E0277]: the trait bound `dyn futures::future::Future<Item = ((), gluon_base::types::ArcType), Error = gluon::Error> + std::marker::Send: std::marker::Unpin` is not satisfied
  --> crawler/src/executor/mod.rs:23:19
   |
23 |         let res = self.thread.run_expr_async::<()>("test", &script).await;
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::marker::Unpin` is not implemented for `dyn futures::future::Future<Item = ((), gluon_base::types::ArcType), Error = gluon::Error> + std::marker::Send`
   |
   = note: required because of the requirements on the impl of `std::future::Future` for `std::boxed::Box<dyn futures::future::Future<Item = ((), gluon_base::types::ArcType), Error = gluon::Error> + std::marker::Send>`

I suspect I don't get the semantics of this call. Can you explain where I am wrong here? We definitely need some documentaion covering this, especially now, when async/await has been stabilized.

UPDATE Actually I need the VM to call my async functions written in Rust. I.e. it's not a problem that pure in-VM execution will block the event loop, but I need Gluon to unblock it when calling my async functions.

closed time in 5 days

ababo

issue closedgluon-lang/gluon

Thread::get_global() fails to lookup a function.

Here is the minimal reproducable snippet:

use gluon::{new_vm, vm::api::FunctionRef, ThreadExt};

#[tokio::main]
async fn main() -> Result<(), ()> {
    let vm = new_vm();

    let text = r#"
        let fib n =
            if n #Int< 2
            then 1
            else fib (n #Int- 1) #Int+ fib (n #Int- 2)
        fib
    "#;

    vm.load_script("test", text).unwrap();

    vm.get_global::<FunctionRef<fn(u64) -> u64>>("fib").unwrap();

    Ok(())
}

I get the following stack trace:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UndefinedBinding("fib")', src/libcore/result.rs:1188:5
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::result::unwrap_failed
   9: core::result::Result<T,E>::unwrap
             at ./home/buildozer/aports/community/rust/src/rustc-1.41.0-src/src/libcore/result.rs:956
  10: crawler::main::{{closure}}
             at crawler/src/main.rs:17
  11: <std::future::GenFuture<T> as core::future::future::Future>::poll
             at ./home/buildozer/aports/community/rust/src/rustc-1.41.0-src/src/libstd/future.rs:43
  12: tokio::runtime::enter::Enter::block_on
             at ./root/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.11/src/runtime/enter.rs:100
  13: tokio::runtime::thread_pool::ThreadPool::block_on
             at ./root/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.11/src/runtime/thread_pool/mod.rs:93
  14: tokio::runtime::Runtime::block_on::{{closure}}
             at ./root/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.11/src/runtime/mod.rs:413
  15: tokio::runtime::context::enter
             at ./root/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.11/src/runtime/context.rs:72
  16: tokio::runtime::handle::Handle::enter
             at ./root/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.11/src/runtime/handle.rs:34
  17: tokio::runtime::Runtime::block_on
             at ./root/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.11/src/runtime/mod.rs:408
  18: crawler::main
             at crawler/src/main.rs:3
  19: std::rt::lang_start::{{closure}}
             at ./home/buildozer/aports/community/rust/src/rustc-1.41.0-src/src/libstd/rt.rs:67
  20: std::panicking::try::do_call
  21: __rust_maybe_catch_panic
  22: std::rt::lang_start_internal
  23: std::rt::lang_start
             at ./home/buildozer/aports/community/rust/src/rustc-1.41.0-src/src/libstd/rt.rs:67
  24: main
  25: <unknown>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Can it be linked with the fact that I run the code with tokio?

closed time in 5 days

ababo

push eventMarwes/gluon

Markus Westerlind

commit sha 62ed9dd051d3d741964af3cff86dc5b67381e7c3

refactor: Move the parser benchmark to gluon_parser

view details

Markus Westerlind

commit sha 2744f88571cf6866a62051ad56c91f4b0f9946e3

Add an arena for the AST

view details

Markus Westerlind

commit sha da78929ad331f0a9cfcc93e9a3dc3e27a724c320

Update error_handling tests

view details

Markus Westerlind

commit sha bba3da08faf590e344466e74bcc867a2d465b6d5

Allocate patterns on an arena

view details

Markus Westerlind

commit sha b01c181bd6073f201c36033e3704bfb077e73657

Put more things in the AST arena

view details

Markus Westerlind

commit sha 48d9a0c9e0672ac17dd968b8f7f6979a74b0aad3

Unbox the parser

view details

Markus Westerlind

commit sha 7b6a3111ebdc3c4dac15676164424f996b79b700

Put Do expressions on an arena to shrink Expr's size

view details

Markus Westerlind

commit sha a44e312cbcf43f52f2507f56bdab80c043ff9bb9

Add Alternative and Argument to the arenas

view details

Markus Westerlind

commit sha af945c4ad177839aa881d88aefa199b0c9f79aac

perf: Allocate all temporaries into the same Vec

view details

Markus Westerlind

commit sha 0cfb52c871e80272a087311f230c11a5ad218c39

perf: Avoid hashing symbols twice

view details

Markus Westerlind

commit sha 5acd21e93ca45856203f056ceac5389822601e64

Reuse the Vec for FieldExpr

view details

Markus Westerlind

commit sha 539a272b8e732c895d80cda80d722d458179b4bf

a

view details

Markus Westerlind

commit sha 9fd63de66a9b39a1d47493fbfcb1cc657c6573e3

Update nighly on travis

view details

Markus Westerlind

commit sha 3d3b1da37f473ea097a97a51ecf85ddfcc323e8c

Don't pass --test to benches

view details

Markus Westerlind

commit sha ce1120c8269608ab85e608443ca14e5ad2e9e679

Allocate AstType on an arena

view details

Markus Westerlind

commit sha 99bec692c6307c671cb173e476776facc6fa67bc

refactor: Add T: TypePtr for Type<Id, T>

view details

Markus Westerlind

commit sha cb458706dd6831d452344ccf74b44251a703bd8c

Allocate application type arguments on an arena

view details

Markus Westerlind

commit sha be0838a6605ed488fafceaab6951e2d0698d6fc5

Refactor

view details

Markus Westerlind

commit sha c51ebefd85d4b51106063144cfb15456cce83f7d

Allow generics in forall to be put in an arena

view details

Markus Westerlind

commit sha f164ac822b74ad42a92c79ea8c3b5cc02f9c158c

refactor: Add TypeAlloc to avoid retyping TypePtr bounds

view details

push time in 5 days

issue commentmitsuhiko/redis-rs

asyn op error: must be called from the context of Tokio runtime

I think you may have forgotten to call enable_io on your runtime https://docs.rs/tokio/0.2.13/tokio/runtime/struct.Builder.html#method.enable_io . Otherwise there is no reactor running.

runnerSnail

comment created time in 7 days

pull request commentmitsuhiko/redis-rs

Created a method for consuming the connection and generating a stream…

Triggering the missing documentation warning on CI

engylemure

comment created time in 8 days

pull request commentgluon-lang/gluon

Cargo.toml: add keywords

Thanks!

bors r+

ngirard

comment created time in 8 days

pull request commentgluon-lang/gluon

perf: Avoid some unnecessary allocations

bors r+

Marwes

comment created time in 10 days

pull request commentgluon-lang/gluon

perf: Avoid some unnecessary allocations

bors r+

Marwes

comment created time in 11 days

PR opened gluon-lang/gluon

perf: Avoid some unnecessary allocations
+64 -34

0 comment

5 changed files

pr created time in 11 days

push eventMarwes/gluon

Markus Westerlind

commit sha 089bae4c4578d36163ec9a84ee83bbfc6e41ab04

perf: Avoid some unnecessary allocations

view details

push time in 11 days

pull request commentgluon-lang/gluon

perf: Allocate the AST on arenas

bors r+

Marwes

comment created time in 11 days

push eventMarwes/gluon

Markus Westerlind

commit sha be0838a6605ed488fafceaab6951e2d0698d6fc5

Refactor

view details

Markus Westerlind

commit sha c51ebefd85d4b51106063144cfb15456cce83f7d

Allow generics in forall to be put in an arena

view details

Markus Westerlind

commit sha f164ac822b74ad42a92c79ea8c3b5cc02f9c158c

refactor: Add TypeAlloc to avoid retyping TypePtr bounds

view details

Markus Westerlind

commit sha f70ca38446529fe034444824b04a45307ae1157a

Allocate type fields on an arena

view details

Markus Westerlind

commit sha 3c4fde1b465e5edde077eb324eba670797c29d35

Restrict TypeExt so fewer bounds are needed

view details

Markus Westerlind

commit sha a37d8e63b3aeb155d85bc6aece93a13836837e90

Allocate type fields on an arena

view details

Markus Westerlind

commit sha 75fb8840001f3e4d17ada88077b111024d673cf9

perf: Shrink the size of Pattern

view details

Markus Westerlind

commit sha e54dd0f65698f1a1ba0219beebb3c40e386b5b71

Remove an unnecessary macro in the parser

view details

Markus Westerlind

commit sha 0ec2e6078a946be7bbd530b7603e2493fba573ea

Fixup the rest of the crates

view details

Markus Westerlind

commit sha 17d415eff3e22077d6861cc0194cac69ce3dbda5

Simplify some expression names

view details

push time in 11 days

issue commentlalrpop/lalrpop

Output triggers the clippy double_parens warning

Do you use 0.18.1? I fixed some instances like this in #506 .

ndmitchell

comment created time in 11 days

pull request commentrust-lang-nursery/ena

feat: Allow the UndoLog to be supplied separately

is there any kind of write-up explaining the way this stuff is meant to be used?

Added a test showing a simple version, otherwise there is just https://github.com/rust-lang/rust/pull/69464

Marwes

comment created time in 12 days

push eventMarwes/ena

Markus Westerlind

commit sha fac8c2de85ab31d681556a0425fa2ee88307aa38

test: Check the unified undo log addition

view details

push time in 12 days

push eventMarwes/ena

Markus Westerlind

commit sha 5ae2cfa1d733c7a595f92b989eb6adf5ccaed7b6

docL Document the undo_log module

view details

push time in 12 days

pull request commentMarwes/combine

fix char module name in example

Thanks!

metadave

comment created time in 13 days

push eventMarwes/combine

Dave Parfitt

commit sha 00376c7f3276c59beb253d785dfc5ba6d2de1b56

fix char module name in example

view details

Markus Westerlind

commit sha 6a68f61060dd631e47d8e3fa8c5420821300233d

Merge pull request #286 from metadave/dp_fix_readme_example fix char module name in example

view details

push time in 13 days

PR merged Marwes/combine

fix char module name in example

Copy/pasting the example from the readme yields this error:

error[E0432]: unresolved import `combine::char`
 --> src/main.rs:3:14
  |
3 | use combine::char::{letter, space};
  |              ^^^^ could not find `char` in `combine`
+1 -1

0 comment

1 changed file

metadave

pr closed time in 13 days

push eventMarwes/gluon

Markus Westerlind

commit sha cb458706dd6831d452344ccf74b44251a703bd8c

Allocate application type arguments on an arena

view details

push time in 14 days

issue openedrust-lang/rust

Overflow evaluating the requirement

<!-- Thank you for filing a bug report! 🐛 Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. -->

I tried this code:

pub trait TypePtr {
    type Types;
}

impl<'ast> TypePtr for AstType<'ast> {
    type Types = Vec<Self>;
}

pub struct AstType<'ast> {
    _typ: &'ast mut Type<AstType<'ast>>,
}

pub enum Type<T: TypePtr> {
    App(T::Types),
}

fn assert_send<T: Send>() {}

fn main() {
    assert_send::<AstType>();
}

I expected the code to compile, or at least fail with a better error message.

Instead, this happened: rustc fails with a seemingly infinite loop when evaluating the Send requirement.

error[E0275]: overflow evaluating the requirement `Type<AstType<'_>>: std::marker::Send`
  --> ../test.rs:20:5
   |
17 | fn assert_send<T: Send>() {}
   |    -----------    ---- required by this bound in `assert_send`
...
20 |     assert_send::<AstType>();
   |     ^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: consider adding a `#![recursion_limit="256"]` attribute to your crate (`test`)
   = note: required because of the requirements on the impl of `std::marker::Send` for `&mut Type<AstType<'_>>`
   = note: required because it appears within the type `AstType<'_>`
   = note: required because of the requirements on the impl of `std::marker::Send` for `std::ptr::Unique<AstType<'_>>`
   = note: required because it appears within the type `alloc::raw_vec::RawVec<AstType<'_>>`
   = note: required because it appears within the type `std::vec::Vec<AstType<'_>>`
   = note: required because it appears within the type `Type<AstType<'_>>`
   = note: required because of the requirements on the impl of `std::marker::Send` for `&mut Type<AstType<'_>>`
   = note: required because it appears within the type `AstType<'_>`
   = note: required because of the requirements on the impl of `std::marker::Send` for `std::ptr::Unique<AstType<'_>>`

Meta

rustc --version --verbose:

rustc 1.43.0-nightly (7cdbc87a4 2020-03-14)
binary: rustc
commit-hash: 7cdbc87a49b0b705a41a004a6d486b0952521ae7
commit-date: 2020-03-14
host: x86_64-pc-windows-msvc
release: 1.43.0-nightly
LLVM version: 9.0

created time in 14 days

issue commentmitsuhiko/redis-rs

Async connection deadlocks with multiple runtime instances

tokio::time::delay_for(Duration::from_secs(999)).await;

Yields the current task which allows the outer runtime to run. If you add a prinln! in the inner Runtime you can see that zadd runs as expected.

After that it does take 999 seconds due to the delay_for but then it shutsdown as expected (lower the time to ~5 seconds to see it easily).

You may need to run the test with cargo test -- --nocapture to see the print.

nazar-pc

comment created time in 14 days

issue commentmitsuhiko/redis-rs

Async connection deadlocks with multiple runtime instances

The connection is tied to a runtime (https://github.com/tokio-rs/mio/). You can still use it from another runtime but only as long as the runtime that it is created still runs.

In this example it is unable to since the join call blocks the entire runtime.

nazar-pc

comment created time in 14 days

issue commentmitsuhiko/redis-rs

Async connection deadlocks with multiple runtime instances

You aren't doing await though in the example jojn_handle.join().unwrap(); blocks the entire thread which in turn blocks the outer runtime and eventloop which drives the redis connection.

nazar-pc

comment created time in 14 days

issue commentmitsuhiko/redis-rs

Async connection deadlocks with multiple runtime instances

You are blocking the outer runtime when you join the thread. Since it won't make progress on other tasks (such as the driver task for the redis connection). The inner runtime will end up being blocked.

nazar-pc

comment created time in 15 days

issue commentrust-lang/rust

Exponential trait selection when compiling a crate using combine 4

Seeing what looks like this issue in futures heavy code as well. Root issue is that there are just too many obligations generated, nothing can be done to ObligationForest itself to speed this up, I think. Selection just need to generated fewer obligations, or at least they must be memoized better.

Marwes

comment created time in 15 days

push eventMarwes/gluon

Markus Westerlind

commit sha 99bec692c6307c671cb173e476776facc6fa67bc

refactor: Add T: TypePtr for Type<Id, T>

view details

Markus Westerlind

commit sha e14ea70c0f9f907e84dd22d8c4e5a1b293930603

Allocate application type arguments on an arena

view details

push time in 15 days

push eventMarwes/gluon

Markus Westerlind

commit sha ce1120c8269608ab85e608443ca14e5ad2e9e679

Allocate AstType on an arena

view details

push time in 15 days

push eventMarwes/rust

Markus Westerlind

commit sha 8d5783d3addfea50f72bcdc2691a40fbe5fcec19

rebase

view details

push time in 15 days

push eventMarwes/rust

Sebastian Imlay

commit sha 35c4aae99ece980c7c594940724f0728fcccf226

Added tvOS as a backend

view details

Linus Färnstrand

commit sha 271ba5a3ea59f25ebc7ba3b9a2e620a833e50b33

Stabilize assoc_int_consts

view details

Linus Färnstrand

commit sha 35298349c3efd75cd8050f9f23e4bf1409d96118

Add "soft deprecation" notice to old min/max_value() docs

view details

Linus Färnstrand

commit sha 97bdd31b0eab51d0a51b8746123f910cd868dff3

Add "soft deprecation" notice to old MIN/MAX docs

view details

Linus Färnstrand

commit sha fd71fbe8d51dc291f87fdb6beb12e174a304bd0c

Remove reference from integer docs to their modules

view details

Linus Färnstrand

commit sha cf255c6dc1a9c41bf8e98865d85f8577ce8d2056

Use new preferred consts in int docs

view details

Linus Färnstrand

commit sha 5e17f31d94a0e2f1e69d5c4bd5171cf48ff9e5b0

Replace min/max_value() with MIN/MAX in integer docs

view details

Linus Färnstrand

commit sha 847a0dd845dbc74b4d49adf873c585519e356b4e

Remove uint_macros that was identical to int_macros

view details

Linus Färnstrand

commit sha c67de2570f881a0601f15c7c15e1fb9a26f2d3bf

Add notice about using new consts in new code on float modules

view details

Linus Färnstrand

commit sha 086927480be716a14f9c68954d417b544066184b

Add notice about using new consts in new code on int modules

view details

Linus Färnstrand

commit sha 83191c2da6da6c13466f7f30568cdea02c761ca0

Update float documentation to use associated consts

view details

Linus Färnstrand

commit sha b2dc6187699d99436f6183218d928be09d439578

Add usage recommendation to old float constants

view details

spunit262

commit sha 30d4f1b78d997fb555388cb8ebea474ffb85794c

Don't give invalid suggestion on desugared span.

view details

Markus Westerlind

commit sha 851a701f90081fbc83fa151e9f272cea2a990779

Reuse a Vec in mir simplification

view details

Markus Westerlind

commit sha dec8166abc6675627819723b10301e395f3876d5

Use Vec::append

view details

Markus Westerlind

commit sha 33513fad8089956adcbb5b9803f56de1a8e94b57

Avoid an intermediate Vec in mir simplify

view details

Markus Westerlind

commit sha 2440998666cb9fe5f35c1de9ef44849b71870fc3

perf(mir): Reserve enough space for the merged blocks before appending

view details

Sebastian Imlay

commit sha a2661695e8953199a746895e2e65225a9922753b

Merge branch 'master' of github.com:rust-lang/rust into add-tvSO-target

view details

Sebastian Imlay

commit sha 6b17330ef4f9a97bd539b55edb4e7ccdb6c00133

Merged apple_tvos_base and apple_ios_base into apple_sdk_base.

view details

David Ross

commit sha 940f65782cc5df7fecad27b38cc25b6d1eeaf2e8

Parse & reject postfix operators after casts This adds parsing for expressions like 'x as Ty[0]' which will immediately error out, but still give the rest of the parser a valid parse tree to continue.

view details

push time in 15 days

push eventgluon-lang/gluon-lang.org

Markus Westerlind

commit sha 536a8a0babdaef179e6135bfe7ce2701a74be3b0

Update gluon_master

view details

push time in 16 days

push eventMarwes/gluon

Markus Westerlind

commit sha 3d3b1da37f473ea097a97a51ecf85ddfcc323e8c

Don't pass --test to benches

view details

push time in 16 days

push eventMarwes/gluon

Markus Westerlind

commit sha 2744f88571cf6866a62051ad56c91f4b0f9946e3

Add an arena for the AST

view details

Markus Westerlind

commit sha da78929ad331f0a9cfcc93e9a3dc3e27a724c320

Update error_handling tests

view details

Markus Westerlind

commit sha bba3da08faf590e344466e74bcc867a2d465b6d5

Allocate patterns on an arena

view details

Markus Westerlind

commit sha b01c181bd6073f201c36033e3704bfb077e73657

Put more things in the AST arena

view details

Markus Westerlind

commit sha 48d9a0c9e0672ac17dd968b8f7f6979a74b0aad3

Unbox the parser

view details

Markus Westerlind

commit sha 7b6a3111ebdc3c4dac15676164424f996b79b700

Put Do expressions on an arena to shrink Expr's size

view details

Markus Westerlind

commit sha a44e312cbcf43f52f2507f56bdab80c043ff9bb9

Add Alternative and Argument to the arenas

view details

Markus Westerlind

commit sha af945c4ad177839aa881d88aefa199b0c9f79aac

perf: Allocate all temporaries into the same Vec

view details

Markus Westerlind

commit sha 0cfb52c871e80272a087311f230c11a5ad218c39

perf: Avoid hashing symbols twice

view details

Markus Westerlind

commit sha 5acd21e93ca45856203f056ceac5389822601e64

Reuse the Vec for FieldExpr

view details

Markus Westerlind

commit sha 539a272b8e732c895d80cda80d722d458179b4bf

a

view details

Markus Westerlind

commit sha 9fd63de66a9b39a1d47493fbfcb1cc657c6573e3

Update nighly on travis

view details

push time in 16 days

push eventMarwes/gluon

Markus Westerlind

commit sha 3e49e85a12c064c39292d944447bdfa2130d1d37

Fix benchmarks

view details

Markus Westerlind

commit sha f8936675ce23b3cd531e54f51cad773a7dc40de0

a

view details

push time in 16 days

PR opened gluon-lang/gluon

perf: Allocate the AST on arenas

Doesn't give a huge performance increase since there are other things that still need improving. Still, the allocations were replaced are fundamental, so doing nothing would mean that eventually this would be necessary (for maximum performance).

+3574 -2295

0 comment

75 changed files

pr created time in 16 days

create barnchMarwes/gluon

branch : ast_arena_2

created branch time in 16 days

push eventgluon-lang/gluon-lang.org

Markus Westerlind

commit sha a10a2ce6216ff08af12610f049eafac258fabccc

Update to rust 1.41.1

view details

push time in 18 days

push eventgluon-lang/lsp-types

Jeremy Kolb

commit sha 97701bc98b2c75f2e8071c7db5f8c01ecf01148f

base64 0.12.0

view details

Markus Westerlind

commit sha d03211c01e5412164fad00bf8bf9d9fa475c6c34

Merge pull request #151 from kjeremy/bump-base64 base64 0.12.0

view details

push time in 19 days

PR merged gluon-lang/lsp-types

base64 0.12.0
+1 -1

0 comment

1 changed file

kjeremy

pr closed time in 19 days

push eventgluon-lang/lsp-types

Jeremy Kolb

commit sha 95b5a46eae4519cb3d0f7d775b85478ea6d41e0d

Serialize tokens with a slice Pointed out by clippy

view details

Markus Westerlind

commit sha b34eff127b8dd31e5d9765a54f84a9e09c144d49

Merge pull request #152 from kjeremy/ser-token-slice Serialize tokens with a slice

view details

push time in 19 days

PR merged gluon-lang/lsp-types

Serialize tokens with a slice

Pointed out by clippy

+1 -1

0 comment

1 changed file

kjeremy

pr closed time in 19 days

pull request commentbrendanzab/codespan

Avoid rendering multiple source lines when labels are on one line

Something, something "we are in the future now", I think :) .

While it isn't perfect I would say it is not really worse than the current way of rendering either even. So if it brings us closer to something like rustc's rendering it may still be worth merging as an incremental step.

brendanzab

comment created time in 20 days

delete branch Marwes/rust

delete branch : allocations_mir

delete time in 20 days

delete branch Marwes/rust-rdkafka

delete branch : forget

delete time in 20 days

issue commentfede1024/rust-rdkafka

Memory keeps growing

I ran the app through valgrind and didn't find anything. No idea how to get heap profiles out of production at this point.

llitz

comment created time in 20 days

pull request commentfede1024/rust-rdkafka

refactor: Remove the need for mem::forget in some cases

Only meant it improves the code a bit, it has no practical effect :)

Marwes

comment created time in 20 days

PR opened fede1024/rust-rdkafka

refactor: Remove the need for mem::forget in some cases

Looked into if there was an obvious fix for #220 but nothing so far. Still this improves things a bit.

+10 -18

0 comment

2 changed files

pr created time in 21 days

create barnchMarwes/rust-rdkafka

branch : forget

created branch time in 21 days

issue commentbrendanzab/codespan

Optional file names

Yeah, <stdin> or <repl> would be what I'd use as well.

brendanzab

comment created time in 21 days

issue commentfede1024/rust-rdkafka

Memory keeps growing

Also seeing memory leaks in an application that contains a kafka producer. Might very well be something else causing it but the existence of this issue makes kafka the most likely candidate

llitz

comment created time in 21 days

pull request commentbrendanzab/codespan

Start using a version range for lsp-types

It would be useful to run a check build in travis with the min and max versions for the range. Either with the unstable min versions flag or by setting it explicitly cargo update --precise lsp-types:0.70

brendanzab

comment created time in 21 days

push eventlalrpop/lalrpop

Markus Westerlind

commit sha 8f73c9dcfbbb09d8647d7a3d32aeca48e0b52c97

feat: Use FnMut/FnOnce in ParseErrors map functions

view details

Markus Westerlind

commit sha 165cf03bd17b872ee3226d9bc23658b58c174f3a

cargo fmt

view details

Markus Westerlind

commit sha a07f90289fd4393e2a5df607e53d0b2647211cfb

cargo fix --edition --all

view details

Markus Westerlind

commit sha 037a37264c17cdfe42d4e422f301e54d41e7280e

doc: Add the lexer feature to the examples The lexer feature bled into the examples due to `lalrpop-test` already specifying it. Fixes #513

view details

Markus Westerlind

commit sha 8a96e9646b3d00c2226349efed832c4c25631c53

Merge pull request #514 from Marwes/fn_mut Miscanellous cleanup

view details

push time in 21 days

pull request commentmitsuhiko/redis-rs

Add asynchronous PubSub support

Thanks!

evdokimovs

comment created time in 21 days

push eventmitsuhiko/redis-rs

Semen Evdokimov

commit sha cf93995a774d391f4832184911a1920330ff6ed7

Add asynchronous PubSub

view details

Semen Evdokimov

commit sha a8e542a0e53c9c4a41a7b434767ee7156233eda9

Refactor, add docs

view details

Semen Evdokimov

commit sha c3ff9e4a3d43b90efc04fe303a9805582dbe6235

Add tests for PubSub

view details

Semen Evdokimov

commit sha 94bfa024e40e205889b650c4c339bc5c4f1221b8

Add PubSub example

view details

alexlapa

commit sha 8e9ff26224015b4cc9763c9ecf70f153abbdb774

minor doc improvements

view details

Semen Evdokimov

commit sha 68a2bde2446238aaa9fc6495ed82e90f1a026e7b

Fix send_bytes flushing and tests

view details

Semen Evdokimov

commit sha b65c4ae8830ed43dfb9c831c55d710a8be4bbaea

Merge branch 'async-pubsub' of github.com:evdokimovs/redis-rs into async-pubsub

view details

Semen Evdokimov

commit sha b90ae29146cf2f5ff4adc81673f4304ce9ff1164

Merge branch 'master' into async-pubsub

view details

Semen Evdokimov

commit sha 9654565d18a26ac7292377c5f2d330e74b0d1436

Fix function naming

view details

Semen Evdokimov

commit sha 32f29939926874d89089e2c9480549b0c2f3cd9d

Use pipeline in 'clear_active_subscriptions'

view details

Semen Evdokimov

commit sha 67a50e0fae9f875e4407c878c7febf2ab26a6100

Merge branch 'master' into async-pubsub

view details

Semen Evdokimov

commit sha be4b5668994fd316771e0c861c8322a7599f7dc1

Merge branch 'master' of github.com:mitsuhiko/redis-rs into async-pubsub

view details

Semen Evdokimov

commit sha 39eba5d024361a5db2a752d0624f3c7e0da56364

Rustfmt

view details

Markus Westerlind

commit sha 1ea0bd0c2e7b450eb5279995142fd64e5db0fa69

Merge pull request #287 from evdokimovs/async-pubsub Add asynchronous PubSub support

view details

push time in 21 days

PR merged mitsuhiko/redis-rs

Add asynchronous PubSub support

Resolves #183

This PR adds asynchronous support for the PubSub mechanism of Redis.

redis::aio::Connection::into_pubsub requires Connection owning because we don't have ability to asynchronously exit from PubSub mode in the Drop implementation of redis::aio::PubSub.

As alternative we can add PubSub::close method which will asynchronously exit from PubSub mode and implement synchronous exit from PubSub (if Connection is in this mode) on redis::aio::PubSub dropping for guarantee that Connection will not stuck in PubSub mode, but it look weird because implicit blocking in asynchronous code is unexpected behavior and many users may forget to call PubSub::close method.

Also, you can look at tokio-postgres implementation of asynchronous API with futures::channel::mpsc channels. This implementation will allow to asynchronously exit from PubSub mode in Drop implementation of redis::aio::PubSub. But it requires more global changes than I have proposed.

Currently, while redis::aio::PubSub::on_message's Stream is stored somewhere, redis::aio::PubSub::subscribe-like function wouldn't be available because they all requires mutable PubSub. Theoretically, this can be fixed by splitting TcpStream / UnixStream into a read part and a write part.

+313 -27

1 comment

5 changed files

evdokimovs

pr closed time in 21 days

issue closedmitsuhiko/redis-rs

Plans to add async pubsub?

It seems that pubsub is not implemented in the async version. Is it planned to be and would be it hard to add? I'll try to add it but wanted to know if it's being worked on or if there are specific difficulties to do so?

closed time in 21 days

mdenchev

delete branch Marwes/lalrpop

delete branch : fn_mut

delete time in 21 days

issue closedlalrpop/lalrpop

Latest release seems to break tutorial and most other documentation

When following the latest versions of LALRPOP, compilation fails with an error about missing lexer feature. This seems to be a breaking change introduce in the 1.18.0 release, but the LALRPOP book as well as the tutorials seem to be broken as a result.

It is very hard to figure out how to use this library when the documentation is wrong.

closed time in 21 days

liljencrantz

PR merged lalrpop/lalrpop

Miscanellous cleanup
+412 -414

0 comment

99 changed files

Marwes

pr closed time in 21 days

issue openedlalrpop/lalrpop

Update the crates and generated code to rust 2018

The rust code in the .lalrpop files are still on rust 2015 and need to be manually updated since cargo fix won't work on those files.

We should also update the generated code to emit 2018 idiomatic code (see #2018 )

created time in 21 days

PR opened lalrpop/lalrpop

Miscanellous cleanup
+412 -414

0 comment

99 changed files

pr created time in 21 days

create barnchMarwes/lalrpop

branch : fn_mut

created branch time in 21 days

pull request commentrust-lang/rust

perf: Use `for_each` in `Vec::extend`

This could use another perf run with the latest changes. I suspect it won't be enough to remedy the compile time regressions though.

https://github.com/rust-lang/rust/pull/68046#issuecomment-591101494

If the perf run still shows an unacceptable regression I don't see a way to land this right now. Perhaps with MIR optimizations acting on the generic functions it could be optimized enough before getting to LLVM to make it possible, but otherwise the overhead is fairly fundamental to the change.

Marwes

comment created time in 23 days

delete branch Marwes/rust

delete branch : refactor

delete time in 23 days

issue commentgluon-lang/lsp-types

Consider making types non_exhaustive

In Cargo.toml you can do lsp-types = "0.70>=,<0.81". Since codespan-lsp doesn't construct any types that has changed recently it should work with a wide range of versions. Still forces one to update the maximum version every now and then but that can be released as non-breaking versions.

Marwes

comment created time in 23 days

issue closedgluon-lang/lsp-types

Consider making types non_exhaustive

The need to make a breaking release every time a new field is added to a type causes a lot of churn in dependent crates (see for instance https://github.com/brendanzab/codespan/issues/124).

We could reduce this significantly (perhaps completely) by making all enums and structs non exhaustive through adding an extra variant to all enums and an extra field to all structs which is not meant to be referred to directly.

pub enum Enum {
    A,
    B(String),

    #[doc(hidden)]
    _NonExhaustive,
}

#[derive(Default)]
pub struct Struct {
    pub a: i32,
    pub b: String,

    #[doc(hidden)]
    #[serde(skip)]
    pub _non_exhaustive: (),
}

Uses of any enums would then need to add a catch all case on each match which errors on unknown variants and use Struct { a, b, .. } when matching on structs. Further, constructing any struct would require Default::default() + functional record update which is perhaps the biggest ergonomic loss.

Struct {
    a: 1,
    b: "".into()
    .. Default::default(),
}

I haven't decided yet if I think being able to move to 1.0 is worth the ergonomic loss but I wanted to float the idea here.

@Xanewok @matklad @brendanzab @autozimu (more?)

closed time in 24 days

Marwes

issue commentgluon-lang/lsp-types

Consider making types non_exhaustive

I looked it this a bit, but there are types which have fields without a sensible default so we can't use Default + functional record update (FRU).

Avoiding churn could perhaps be avoided by crates specifying a version range instead. Still forces some churn, but it would only be for crates like codespan and not downstream users of codespan (@brendanzab )

Marwes

comment created time in 24 days

issue commentgluon-lang/lsp-types

Converting a an Url to a PathBuf and back to Url won't give the same result

Is there something actionable on the crate side? You should be able to normalize the Url before using it as a key for the map. Maybe we could do this when deserializing but that seems potentially surprising also.

icsaszar

comment created time in 24 days

Pull request review commentrust-lang/rust

Refactorings to method/probe.rs and CrateId

 pub struct SourceFile {     /// Set to `None` if the `SourceFile` was imported from an external crate.     pub unmapped_path: Option<FileName>,     /// Indicates which crate this `SourceFile` was imported from.-    pub crate_of_origin: u32,+    pub crate_of_origin: Option<CrateId>,

Removed that commit since it would just cause conflicts

Marwes

comment created time in 24 days

push eventMarwes/rust

push time in 24 days

Pull request review commentrust-lang/rust

Refactorings to method/probe.rs and CrateId

 impl Decodable for SourceFile {                 name_was_remapped,                 unmapped_path: None,                 // `crate_of_origin` has to be set by the importer.-                // This value matches up with `rustc_hir::def_id::INVALID_CRATE`.

INVALID_CRATE appears to have been removed at some point. Figured an option would be more appropriate now.

Marwes

comment created time in 24 days

PR opened rust-lang/rust

Refactorings to method/probe.rs and CrateId

A couple of refactorings done while looking into performance improvements in method resolution.

+72 -99

0 comment

8 changed files

pr created time in 24 days

pull request commentrust-lang/rust

perf(dep_graph): Avoid allocating a set on when the number reads are …

An improvement, though it didn't affect packed-simd as I expected. It seems that the cost there is due to reallocting large sets.

Marwes

comment created time in 24 days

push eventMarwes/rust

Markus Westerlind

commit sha 4168c25b0f8aadcfe38c8bdae7cc51c22c2f45d1

refactor: Add an alias for the SmallVec in dep_graph

view details

push time in 24 days

create barnchMarwes/rust

branch : refactor

created branch time in 24 days

created taggluon-lang/lsp-types

tagvv0.73.0

Types for communicating with a language server

created time in 25 days

push eventgluon-lang/lsp-types

Markus Westerlind

commit sha cd00a5e96a6787fc71bc677dfd9fc21867ecc2fb

(cargo-release) version 0.73.0

view details

push time in 25 days

push eventgluon-lang/lsp-types

Eyal Kalderon

commit sha bf1f7f73d4a2e0ed01ae7d7d004e3f64099fb97e

Fix SelectionRangeRequest::Result type

view details

Markus Westerlind

commit sha 5117d3cf454b040c05f75747fee81787754c1dd0

Merge pull request #149 from ebkalderon/fix-selection-range-return-type Fix SelectionRangeRequest::Result type

view details

push time in 25 days

PR merged gluon-lang/lsp-types

Fix SelectionRangeRequest::Result type

Fixed

  • Change SelectionRangeRequest::Result associated type from Vec<SelectionRange> to Option<Vec<SelectionRange>>.

According to the specification, the textDocument/selectionRange response result type is SelectionRange[] | null.

This means that the correct result type should be Option<Vec<SelectionRange>>.

+1 -1

0 comment

1 changed file

ebkalderon

pr closed time in 25 days

push eventgluon-lang/lsp-types

Eyal Kalderon

commit sha 21acd65bb488ae9a9839f5b7e83a79e004566366

Use DocumentLinkCapabilities in TextDocumentClientCapabilities

view details

Markus Westerlind

commit sha 67069274c487510ca8fb43f68bd74dbf4246f4d6

Merge pull request #148 from ebkalderon/use-document-link-capabilities Use DocumentLinkCapabilities in TextDocumentClientCapabilities

view details

push time in 25 days

PR merged gluon-lang/lsp-types

Use DocumentLinkCapabilities in TextDocumentClientCapabilities

Fixed

  • Use DocumentLinkCapabilities in TextDocumentClientCapabilities.

The previous version of the code used GenericCapability instead, and the DocumentLinkCapabilities type was defined but unused. This should fix support for textDocument/documentLink tooltip support for LSP version 3.15.0.

+1 -1

1 comment

1 changed file

ebkalderon

pr closed time in 25 days

pull request commentMarwes/redis-cluster-async

Fix eval and evalsha with keys

Released as 0.3.0

jensenn

comment created time in 25 days

push eventMarwes/redis-cluster-async

Markus Westerlind

commit sha 2e0655b70a115fac5a7a8ced64673aaef33df3f5

(cargo-release) version 0.3.0

view details

push time in 25 days

push eventMarwes/redis-cluster-async

Neil Jensen

commit sha e2eb859c0c10d55817a5952d60ca2c485a1d4d00

Use redis 0.15

view details

Neil Jensen

commit sha bf4febc4559764ba3eedd2b9ae32aefedf539df0

Handle slot calculation for EVAL and EVALSHA

view details

jensenn

commit sha d10da466dc7a8882e8f7e0da3f1e21fa3ee2c2cf

remove unnecessary lifetime Co-Authored-By: Markus Westerlind <marwes91@gmail.com>

view details

Markus Westerlind

commit sha 3e212079207e67ba23ccd678529a4150600d1369

Merge pull request #2 from jensenn/fix-eval-evalsha-with-keys Fix eval and evalsha with keys

view details

push time in 25 days

PR merged Marwes/redis-cluster-async

Fix eval and evalsha with keys

I was able to get eval and evalsha working, however, I was unable to use the Script() method of executing a lua script. The reason is that it uses SCRIPT LOAD, which must be sent to all masters. I did create a unittest for that which is #[ignore].

Also included is update to use redis-rs version 0.15

+77 -10

1 comment

5 changed files

jensenn

pr closed time in 25 days

pull request commentrust-lang/rust

perf: Buffer stderr when writing json errors/warnings

Each write! involves multiple syscalls since writing out JSON performs no buffering (each {, [ is a separate syscall).

So there is a still a good amount of benefit.

Marwes

comment created time in 25 days

PR opened rust-lang/rust

perf(dep_graph): Avoid allocating a set on when the number reads are …

…small

reserve_and_rehash takes up 1.4% of the runtime on the packed-simd benchmark which I believe is due to the number of reads are very low in many cases (see https://github.com/rust-lang/rust/pull/50565 for instance).

This avoids allocating the set until we start allocating the reads SmallVec but it is possible that a lower limit might be better (not tested since the improvement will be hard to spot either way).

+17 -2

0 comment

1 changed file

pr created time in 25 days

create barnchMarwes/rust

branch : dep_graph

created branch time in 25 days

Pull request review commentMarwes/redis-cluster-async

Fix eval and evalsha with keys

 impl<C> CmdArg<C> {     }      fn slot(&self) -> Option<u16> {-        fn slot_for_command(cmd: &Cmd) -> Option<u16> {-            cmd.args_iter().nth(1).and_then(|arg| match arg {-                redis::Arg::Simple(key) => Some(slot_for_key(key)),-                redis::Arg::Cursor => None, // FIXME ???+        fn get_cmd_arg<'a>(cmd: &'a Cmd, arg_num: usize) -> Option<&'a [u8]> {
        fn get_cmd_arg(cmd: &Cmd, arg_num: usize) -> Option<&[u8]> {
jensenn

comment created time in a month

push eventMarwes/redis-cluster-async

Markus Westerlind

commit sha b01192fdf34a6fb4a82b9e6ea09b96323ea1a494

Update to checkout@v2

view details

push time in a month

pull request commentrust-lang/rust

perf: Unify the undo log of all snapshot types

I believe this should be marked as waiting for review? I don't think there is anything else for me to do here at this stage?

Marwes

comment created time in a month

issue commentsalsa-rs/salsa

Gracefully handling cycle errors

Not yet, something to be added eventually however.

lpil

comment created time in a month

issue commentsalsa-rs/salsa

Gracefully handling cycle errors

https://github.com/salsa-rs/salsa/pull/147 implements an approach which I use in https://github.com/gluon-lang/gluon exactly to cope with import cycles.

lpil

comment created time in a month

more