profile
viewpoint
David Wood davidtwco @codeplaysoftware Edinburgh, Scotland https://davidtw.co

davidtwco/dotfiles 7

@davidtwco does dotfiles. Configurations for vim, tmux, zsh, bash, git, gpg and more.

davidtwco/ansi-c-exercises 6

@davidtwco does exercises from the C Programming Language, Second Edition by Brian Kernighan and Dennis Ritchie.

davidtwco/personal-website 2

@davidtwco's personal website containing projects and writings, built using Metalsmith and Gulp, hosted on Netlify.

autokrator-uog/user-interface 1

React-based frontend for the financial platform, works with the BfaF to provide a user-friendly live interface to accounts, balances and transactions.

autokrator-uog/accounts-service 0

DEPRECATED: Java-based microservice for managing financial accounts, balances and acception/rejection of transactions.

autokrator-uog/actix-web 0

Actix web framework - fork with minor changes for use with Autokrator project.

autokrator-uog/backend 0

UI Backend (or BfaF/Backend-for-a-frontend) acts as a gateway between the user interface and the microservices, providing a unified API for interacting with the core services.

autokrator-uog/core 0

Autokrator application for Team Project 3 course at the University of Glasgow.

autokrator-uog/demo 0

Full financial platform orchestration and management for use in presenting demos.

autokrator-uog/jackie 0

Jackie is the reporting service that allows querying of Couchbase to extract information about past events.

Pull request review commentNixOS/nixpkgs

snipe-it: init at 4.8.0 + module

+diff --git a/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php b/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php+index 04f0e4a..2a99071 100644+--- a/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php++++ b/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php+@@ -115,10 +115,14 @@ class Kernel implements KernelContract++             $response = $this->sendRequestThroughRouter($request);+         } catch (Exception $e) {++            die("{$e->getMessage()} {$e->getTraceAsString()}");

I disable this patch by default because I agree, we would not want to leak call traces like this.

However, if Laravel fails to bootstrap itself (due to a syntax error in the configuration file, or missing PHP extension, or incorrect database credentials) then that manifests itself as an exception that only says class "Log" not found, which is really painful to debug.

This patch implements the solution from this blog post.

There are lots of bug reports like laravel/framework#11724 where users are struggling to work out why their application is failing - this is more problematic when writing a Nix package for a Laravel app because we're necessarily patching and doing strange things that will cause these sorts of failures until the package is correct.

davidtwco

comment created time in 21 minutes

Pull request review commentNixOS/nixpkgs

snipe-it: init at 4.8.0 + module

+diff --git a/app/Http/Controllers/AccessoriesController.php b/app/Http/Controllers/AccessoriesController.php+index 36e8a9921..7c20e2431 100755+--- a/app/Http/Controllers/AccessoriesController.php++++ b/app/Http/Controllers/AccessoriesController.php+@@ -85,7 +85,7 @@ class AccessoriesController extends Controller+         $accessory->qty                     = request('qty');+         $accessory->user_id                 = Auth::user()->id;+         $accessory->supplier_id             = request('supplier_id');+-        $accessory = $request->handleImages($accessory,600, public_path().'/uploads/accessories');++        $accessory = $request->handleImages($accessory,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/accessories');+ + +         // Was the accessory created?+@@ -146,7 +146,7 @@ class AccessoriesController extends Controller+         $accessory->qty                     = request('qty');+         $accessory->supplier_id             = request('supplier_id');+ +-        $accessory = $request->handleImages($accessory,600, public_path().'/uploads/accessories');++        $accessory = $request->handleImages($accessory,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/accessories');+ + +         // Was the accessory updated?+diff --git a/app/Http/Controllers/Api/AssetModelsController.php b/app/Http/Controllers/Api/AssetModelsController.php+index 08a2cd68d..e601896b4 100644+--- a/app/Http/Controllers/Api/AssetModelsController.php++++ b/app/Http/Controllers/Api/AssetModelsController.php+@@ -180,7 +180,7 @@ class AssetModelsController extends Controller+ +         if ($assetmodel->image) {+             try  {+-                unlink(public_path().'/uploads/models/'.$assetmodel->image);++                unlink(getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/models/' . $assetmodel->image);+             } catch (\Exception $e) {+                 \Log::info($e);+             }+diff --git a/app/Http/Controllers/AssetModelsController.php b/app/Http/Controllers/AssetModelsController.php+index 7c3531e47..0156b7f30 100755+--- a/app/Http/Controllers/AssetModelsController.php++++ b/app/Http/Controllers/AssetModelsController.php+@@ -90,7 +90,7 @@ class AssetModelsController extends Controller+             $model->fieldset_id = e($request->input('custom_fieldset'));+         }+ +-        $model = $request->handleImages($model,600, public_path().'/uploads/models');++        $model = $request->handleImages($model,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/models');+ +             // Was it created?+         if ($model->save()) {+@@ -166,7 +166,7 @@ class AssetModelsController extends Controller+             }+         }+ +-        $model = $request->handleImages($model,600, public_path().'/uploads/models');++        $model = $request->handleImages($model,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/models');+ +         if ($model->save()) {+             return redirect()->route("models.index")->with('success', trans('admin/models/message.update.success'));+@@ -198,7 +198,7 @@ class AssetModelsController extends Controller+ +         if ($model->image) {+             try  {+-                unlink(public_path().'/uploads/models/'.$model->image);++                unlink(getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/models/'.$model->image);+             } catch (\Exception $e) {+                 \Log::info($e);+             }+@@ -388,7 +388,7 @@ class AssetModelsController extends Controller+         }+ + +-        +++         if (count($update_array) > 0) {+             AssetModel::whereIn('id', $models_raw_array)->update($update_array);+             return redirect()->route('models.index')+diff --git a/app/Http/Controllers/AssetsController.php b/app/Http/Controllers/AssetsController.php+index fe8c2b4d0..261ae7d93 100755+--- a/app/Http/Controllers/AssetsController.php++++ b/app/Http/Controllers/AssetsController.php+@@ -156,12 +156,12 @@ class AssetsController extends Controller+ +             $file_name = str_random(25).".".$extension;+ +-            $directory= public_path('uploads/assets/');++            $directory= getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/assets/';+             // Check if the uploads directory exists.  If not, try to create it.+             if (!file_exists($directory)) {+                 mkdir($directory, 0755, true);+             }+-            $path = public_path('uploads/assets/'.$file_name);++            $path = getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/assets/' . $file_name;+             try {+                 Image::make($image)->resize(800, 800, function ($constraint) {+                     $constraint->aspectRatio();+@@ -323,7 +323,7 @@ class AssetsController extends Controller+ +         if ($request->filled('image_delete')) {+             try {+-                unlink(public_path().'/uploads/assets/'.$asset->image);++                unlink(getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/assets/' . $asset->image);+                 $asset->image = '';+             } catch (\Exception $e) {+                 \Log::info($e);+@@ -350,14 +350,14 @@ class AssetsController extends Controller+             $extension = substr($header, strpos($header, '/')+1);+             $image = substr($image, strpos($image, ',')+1);+ +-            $directory= public_path('uploads/assets/');++            $directory= getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/assets/';+             // Check if the uploads directory exists.  If not, try to create it.+             if (!file_exists($directory)) {+                 mkdir($directory, 0755, true);+             }+ +             $file_name = str_random(25).".".$extension;+-            $path = public_path('uploads/assets/'.$file_name);++            $path = getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/assets/' . $file_name;+             try {+                 Image::make($image)->resize(800, 800, function ($constraint) {+                     $constraint->aspectRatio();+@@ -471,7 +471,7 @@ class AssetsController extends Controller+             $asset = Asset::withTrashed()->find($assetId);+             if ($asset) {+                 $size = Helper::barcodeDimensions($settings->barcode_type);+-                $qr_file = public_path().'/uploads/barcodes/qr-'.str_slug($asset->asset_tag).'-'.str_slug($asset->id).'.png';++                $qr_file = getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/barcodes/qr-' . str_slug($asset->asset_tag) . '-' . str_slug($asset->id) . '.png';+ +                 if (isset($asset->id, $asset->asset_tag)) {+                     if (file_exists($qr_file)) {+@@ -502,7 +502,7 @@ class AssetsController extends Controller+     {+         $settings = Setting::getSettings();+         $asset = Asset::find($assetId);+-        $barcode_file = public_path().'/uploads/barcodes/'.str_slug($settings->alt_barcode).'-'.str_slug($asset->asset_tag).'.png';++        $barcode_file = getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/barcodes/' . str_slug($settings->alt_barcode) . '-' . str_slug($asset->asset_tag) . '.png';+ +         if (isset($asset->id, $asset->asset_tag)) {+             if (file_exists($barcode_file)) {+diff --git a/app/Http/Controllers/CategoriesController.php b/app/Http/Controllers/CategoriesController.php+index f57ec2b4c..9f5213df5 100755+--- a/app/Http/Controllers/CategoriesController.php++++ b/app/Http/Controllers/CategoriesController.php+@@ -83,7 +83,7 @@ class CategoriesController extends Controller+         $category->checkin_email        = $request->input('checkin_email', '0');+         $category->user_id              = Auth::id();+ +-        $category = $request->handleImages($category,600, public_path().'/uploads/categories');++        $category = $request->handleImages($category,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/categories');+ +         if ($category->save()) {+             return redirect()->route('categories.index')->with('success', trans('admin/categories/message.create.success'));+@@ -147,7 +147,7 @@ class CategoriesController extends Controller+             $category->image = null;+         }+ +-        $category = $request->handleImages($category,600, public_path().'/uploads/categories');++        $category = $request->handleImages($category,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/categories');+ +         if ($category->save()) {+             // Redirect to the new category page+diff --git a/app/Http/Controllers/CompaniesController.php b/app/Http/Controllers/CompaniesController.php+index 637f11b1d..d94e0e0b7 100644+--- a/app/Http/Controllers/CompaniesController.php++++ b/app/Http/Controllers/CompaniesController.php+@@ -63,7 +63,7 @@ final class CompaniesController extends Controller+         $company = new Company;+         $company->name = $request->input('name');+ +-        $company = $request->handleImages($company,600, public_path().'/uploads/companies');++        $company = $request->handleImages($company,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/companies');+ +         if ($company->save()) {+             return redirect()->route('companies.index')+@@ -117,7 +117,7 @@ final class CompaniesController extends Controller+             $company->image = null;+         }+ +-        $company = $request->handleImages($company,600, public_path().'/uploads/companies');++        $company = $request->handleImages($company,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/companies');+ + +         if ($company->save()) {+diff --git a/app/Http/Controllers/ComponentsController.php b/app/Http/Controllers/ComponentsController.php+index f4106b420..c2b0a068d 100644+--- a/app/Http/Controllers/ComponentsController.php++++ b/app/Http/Controllers/ComponentsController.php+@@ -91,7 +91,7 @@ class ComponentsController extends Controller+         $component->user_id                = Auth::id();+ + +-        $component = $request->handleImages($component,600, public_path().'/uploads/components');++        $component = $request->handleImages($component,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/components');+ +         if ($component->save()) {+             return redirect()->route('components.index')->with('success', trans('admin/components/message.create.success'));+@@ -155,7 +155,7 @@ class ComponentsController extends Controller+         $component->purchase_cost          = request('purchase_cost');+         $component->qty                    = Input::get('qty');+ +-        $component = $request->handleImages($component,600, public_path().'/uploads/components');++        $component = $request->handleImages($component,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/components');+ +         if ($component->save()) {+             return redirect()->route('components.index')->with('success', trans('admin/components/message.update.success'));+diff --git a/app/Http/Controllers/ConsumablesController.php b/app/Http/Controllers/ConsumablesController.php+index afe36a6e4..41ac86a57 100644+--- a/app/Http/Controllers/ConsumablesController.php++++ b/app/Http/Controllers/ConsumablesController.php+@@ -87,7 +87,7 @@ class ConsumablesController extends Controller+         $consumable->user_id                = Auth::id();+ + +-        $consumable = $request->handleImages($consumable,600, public_path().'/uploads/components');++        $consumable = $request->handleImages($consumable,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/components');+ + +         if ($consumable->save()) {+@@ -153,7 +153,7 @@ class ConsumablesController extends Controller+         if ($request->file('image')) {+             $image = $request->file('image');+             $file_name = str_random(25).".".$image->getClientOriginalExtension();+-            $path = public_path('uploads/consumables/'.$file_name);++            $path = getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/consumables/'.$file_name;+             Image::make($image->getRealPath())->resize(800, null, function ($constraint) {+                 $constraint->aspectRatio();+                 $constraint->upsize();+diff --git a/app/Http/Controllers/DepartmentsController.php b/app/Http/Controllers/DepartmentsController.php+index 965c98b4f..8a1c54473 100644+--- a/app/Http/Controllers/DepartmentsController.php++++ b/app/Http/Controllers/DepartmentsController.php+@@ -53,7 +53,7 @@ class DepartmentsController extends Controller+         $department->user_id = Auth::user()->id;+         $department->manager_id = ($request->filled('manager_id' ) ? $request->input('manager_id') : null);+ +-        $department = $request->handleImages($department,600, public_path().'/uploads/departments');++        $department = $request->handleImages($department,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/departments');+ +         if ($department->save()) {+             return redirect()->route("departments.index")->with('success', trans('admin/departments/message.create.success'));+@@ -155,7 +155,7 @@ class DepartmentsController extends Controller+         $department->fill($request->all());+         $department->manager_id = ($request->filled('manager_id' ) ? $request->input('manager_id') : null);+ +-        $department = $request->handleImages($department,600, public_path().'/uploads/departments');++        $department = $request->handleImages($department,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/departments');+ +         if ($department->save()) {+             return redirect()->route("departments.index")->with('success', trans('admin/departments/message.update.success'));+diff --git a/app/Http/Controllers/LocationsController.php b/app/Http/Controllers/LocationsController.php+index d31b8a13b..81e46b16e 100755+--- a/app/Http/Controllers/LocationsController.php++++ b/app/Http/Controllers/LocationsController.php+@@ -88,7 +88,7 @@ class LocationsController extends Controller+         $location->manager_id       = $request->input('manager_id');+         $location->user_id          = Auth::id();+ +-        $location = $request->handleImages($location,600, public_path().'/uploads/locations');++        $location = $request->handleImages($location,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/locations');+ +         if ($location->save()) {+             return redirect()->route("locations.index")->with('success', trans('admin/locations/message.create.success'));+@@ -153,7 +153,7 @@ class LocationsController extends Controller+         $location->zip          = $request->input('zip');+         $location->ldap_ou      = $request->input('ldap_ou');+         $location->manager_id   = $request->input('manager_id');+-        $location = $request->handleImages($location,600, public_path().'/uploads/locations');++        $location = $request->handleImages($location,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/locations');+ + +         if ($location->save()) {+diff --git a/app/Http/Controllers/ManufacturersController.php b/app/Http/Controllers/ManufacturersController.php+index fdcfe6903..07d6667b2 100755+--- a/app/Http/Controllers/ManufacturersController.php++++ b/app/Http/Controllers/ManufacturersController.php+@@ -75,7 +75,7 @@ class ManufacturersController extends Controller+         $manufacturer->support_url     = $request->input('support_url');+         $manufacturer->support_phone    = $request->input('support_phone');+         $manufacturer->support_email    = $request->input('support_email');+-        $manufacturer = $request->handleImages($manufacturer,600, public_path().'/uploads/manufacturers');++        $manufacturer = $request->handleImages($manufacturer,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/manufacturers');+ + + +@@ -131,13 +131,13 @@ class ManufacturersController extends Controller+         $manufacturer->support_url     = $request->input('support_url');+         $manufacturer->support_phone    = $request->input('support_phone');+         $manufacturer->support_email    = $request->input('support_email');+-        +++         // Set the model's image property to null if the image is being deleted+         if ($request->input('image_delete') == 1) {+             $manufacturer->image = null;+         }+ +-        $manufacturer = $request->handleImages($manufacturer,600, public_path().'/uploads/manufacturers');++        $manufacturer = $request->handleImages($manufacturer,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/manufacturers');+ + + +@@ -171,7 +171,7 @@ class ManufacturersController extends Controller+ +         if ($manufacturer->image) {+             try  {+-                unlink(public_path().'/uploads/manufacturers/'.$manufacturer->image);++                unlink(getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/manufacturers/'.$manufacturer->image);+             } catch (\Exception $e) {+                 \Log::info($e);+             }+@@ -234,7 +234,7 @@ class ManufacturersController extends Controller+ +     }+ +-   +++ + + }+diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php+index a255aa34b..488da26d8 100755+--- a/app/Http/Controllers/ProfileController.php++++ b/app/Http/Controllers/ProfileController.php+@@ -68,7 +68,7 @@ class ProfileController extends Controller+         if (Input::file('avatar')) {+             $image = Input::file('avatar');+             $file_name = str_slug($user->first_name."-".$user->last_name).".".$image->getClientOriginalExtension();+-            $path = public_path('uploads/avatars/'.$file_name);++            $path = getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/avatars/' .$file_name;+             Image::make($image->getRealPath())->resize(84, 84)->save($path);+             $user->avatar = $file_name;+         }+diff --git a/app/Http/Controllers/SettingsController.php b/app/Http/Controllers/SettingsController.php+index 7eecd5476..24b2e36ac 100755+--- a/app/Http/Controllers/SettingsController.php++++ b/app/Http/Controllers/SettingsController.php+@@ -425,7 +425,7 @@ class SettingsController extends Controller+             if (!config('app.lock_passwords')) {+                 $image = $request->file('image');+                 $file_name = "logo.".$image->getClientOriginalExtension();+-                $path = public_path('uploads');++                $path = getenv('SNIPEIT_PUBLIC_UPLOADS_DIR');+                 if ($image->getClientOriginalExtension()!='svg') {+ +                     Image::make($image->getRealPath())->resize(null, 150, function ($constraint) {+diff --git a/app/Http/Controllers/SuppliersController.php b/app/Http/Controllers/SuppliersController.php+index bc7934abc..da5d86e31 100755+--- a/app/Http/Controllers/SuppliersController.php++++ b/app/Http/Controllers/SuppliersController.php+@@ -78,7 +78,7 @@ class SuppliersController extends Controller+         $supplier->notes                = request('notes');+         $supplier->url                  = $supplier->addhttp(request('url'));+         $supplier->user_id              = Auth::id();+-        $supplier = $request->handleImages($supplier,600, public_path().'/uploads/suppliers');++        $supplier = $request->handleImages($supplier,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/suppliers');+ + +         if ($supplier->save()) {+@@ -136,7 +136,7 @@ class SuppliersController extends Controller+         $supplier->email                = request('email');+         $supplier->url                  = $supplier->addhttp(request('url'));+         $supplier->notes                = request('notes');+-        $supplier = $request->handleImages($supplier,600, public_path().'/uploads/suppliers');++        $supplier = $request->handleImages($supplier,600, getenv('SNIPEIT_PUBLIC_UPLOADS_DIR').'/suppliers');+ +         if ($supplier->save()) {+             return redirect()->route('suppliers.index')->with('success', trans('admin/suppliers/message.update.success'));+diff --git a/app/Providers/SettingsServiceProvider.php b/app/Providers/SettingsServiceProvider.php+index 7577b94f5..e64db8bb0 100644+--- a/app/Providers/SettingsServiceProvider.php++++ b/app/Providers/SettingsServiceProvider.php+@@ -41,7 +41,7 @@ class SettingsServiceProvider extends ServiceProvider+          */+         // Model paths and URLs+         \App::singleton('models_upload_path', function(){+-            return public_path('/uploads/models/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/models/';+         });+ +         \App::singleton('models_upload_url', function(){+@@ -50,7 +50,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Categories+         \App::singleton('categories_upload_path', function(){+-            return public_path('/uploads/categories/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/categories/';+         });+ +         \App::singleton('categories_upload_url', function(){+@@ -59,7 +59,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Locations+         \App::singleton('locations_upload_path', function(){+-            return public_path('/uploads/locations/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/locations/';+         });+ +         \App::singleton('locations_upload_url', function(){+@@ -68,7 +68,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Users+         \App::singleton('users_upload_path', function(){+-            return public_path('/uploads/users/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/users/';+         });+ +         \App::singleton('users_upload_url', function(){+@@ -77,7 +77,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Manufacturers+         \App::singleton('manufacturers_upload_path', function(){+-            return public_path('/uploads/manufacturers/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/manufacturers/';+         });+ +         \App::singleton('manufacturers_upload_url', function(){+@@ -86,7 +86,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Suppliers+         \App::singleton('suppliers_upload_path', function(){+-            return public_path('/uploads/suppliers/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/suppliers/';+         });+ +         \App::singleton('suppliers_upload_url', function(){+@@ -95,7 +95,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Departments+         \App::singleton('departments_upload_path', function(){+-            return public_path('/uploads/departments/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/departments/';+         });+ +         \App::singleton('departments_upload_url', function(){+@@ -104,7 +104,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Company paths and URLs+         \App::singleton('companies_upload_path', function(){+-            return public_path('/uploads/companies/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/companies/';+         });+ +         \App::singleton('companies_upload_url', function(){+@@ -113,7 +113,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Accessories paths and URLs+         \App::singleton('accessories_upload_path', function(){+-            return public_path('/uploads/accessories/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/accessories/';+         });+ +         \App::singleton('accessories_upload_url', function(){+@@ -122,7 +122,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Consumables paths and URLs+         \App::singleton('consumables_upload_path', function(){+-            return public_path('/uploads/consumables/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/consumables/';+         });+ +         \App::singleton('consumables_upload_url', function(){+@@ -132,7 +132,7 @@ class SettingsServiceProvider extends ServiceProvider+ +         // Components paths and URLs+         \App::singleton('components_upload_path', function(){+-            return public_path('/uploads/components/');++            return getenv('SNIPEIT_PUBLIC_UPLOADS_DIR') . '/components/';

I can't patch public_path because it's only the uploads subdirectory of the public path that needs to be changed.

davidtwco

comment created time in 26 minutes

startedellbrid/krabs

started time in 28 minutes

PR opened NixOS/nixpkgs

mdcat: 0.15.0 -> 0.15.1

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Update mdcat to v0.15.1.

cc @bhipple (this removes legacyCargoFetcher = true)

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
+3 -6

0 comment

1 changed file

pr created time in 2 days

create barnchdavidtwco/nixpkgs

branch : mdcat-0.15.1

created branch time in 2 days

push eventdavidtwco/nixpkgs

danbst

commit sha 92a015d35d0450708438f68466027707b18188bd

nixos/postgresql: support 0750 for data directory This is rework of part of https://github.com/NixOS/nixpkgs/pull/46670. My usecase was to be able to inspect PG datadir as wheel user. PG11 now allows starting server with 0750 mask for data dir. `groupAccess = true` now does this automatically. The only thing you have to do is to set group ownership. For PG10 and below, I've described a hack how this can be done. Before this PR hack was impossible. The hack isn't ideal, because there is short period of time when dir mode is 0700, so I didn't want to make it official. Test/example is present too.

view details

danbst

commit sha 7e4e37fff4cd97cc7fed26c9e1060761ed1379a7

postgresql: allow changing initidb arguments via module system Closes https://github.com/NixOS/nixpkgs/issues/18829 + some cleanups

view details

danbst

commit sha b643e0aee32a1c12ee48da3d62895e4f8f77af79

addressed review comments and some fixes

view details

danbst

commit sha e54ad9812bf4f91782cde477f405e015ee5cbdbc

whoops

view details

danbst

commit sha 363ba3f40371f5c016aecf07bf62f3a33f755f29

change groupAccess to tristate, to not force `chmod` on dataDir. Making mask either 0700 or 0750 is too restrictive..

view details

danbst

commit sha d9ff157ee44d978aebed6f6a9c7d4de05d5576ad

WIP

view details

Troels Henriksen

commit sha a0b154765dbb9aa8a7cb91e78ee7f1ecd6d37134

libclc: 2017-11-29 -> 2019-06-09

view details

R. RyanTM

commit sha 34733fed5156a1f02efbe6d0f6d11871a26766b6

fwts: 19.09.00 -> 19.11.00

view details

R. RyanTM

commit sha 36b1b61ed12c9c1fb85b3617e27d80473ba429ee

mkp224o: 1.3.0 -> 1.4.0

view details

Edmund Wu

commit sha 0ba8b3b67bb516b5d7cc65e22c9e305b5cc58e54

buildsrht: 0.48.0 -> 0.52.5

view details

Edmund Wu

commit sha 72fb1992ef308c163bca2ae954ef34b721cb4618

dispatchsrht: 0.12.3 -> 0.13.3

view details

Edmund Wu

commit sha 0b6cb53f5f8db6310adfb4231c5510fd075ecf25

gitsrht: 0.35.6 -> 0.43.3

view details

Edmund Wu

commit sha 85ff8f9f94f504082d8eb796331c6b1a40a76e2e

hgsrht: 0.16.2 -> 0.21.1

view details

Edmund Wu

commit sha ef17a5092cf2021b30f998bf0210398b0972e97a

listssrht: 0.38.3 -> 0.40.3

view details

Edmund Wu

commit sha cce0d7ee57d758171b03d67e24ac3e6e7d1ca7b0

mansrht: 0.13.5 -> 0.14.1

view details

Edmund Wu

commit sha 8ded6650a715f3c503ff04a9897aa5d8457f16f2

metasrht: 0.37.0 -> 0.41.10

view details

Edmund Wu

commit sha 9ec305a493725bf54d0ba8b0c05ca02583301359

pastesrht: 0.7.3 -> 0.9.2

view details

Edmund Wu

commit sha 0282a909f74ccc7abb9ff7c07a8836d6ab47b8bb

todosrht: 0.51.13 -> 0.55.3

view details

Edmund Wu

commit sha 7845e281258d7978cc5b81c08807cb8bcc9cf29f

scmsrht: 0.16.0 -> 0.18.1

view details

Edmund Wu

commit sha 9401dcc3607b0368553dee39921f2bee279d141c

buildsrht: fix build

view details

push time in 2 days

startedmaharmstone/quibble

started time in 4 days

pull request commentrust-lang/rust

Fix extra subslice lowering

@bors r+

Centril

comment created time in 4 days

startedgnab/remark

started time in 4 days

startednvzqz/static-assertions-rs

started time in 5 days

startedforiequal0/git-trim

started time in 5 days

PR opened NixOS/nixpkgs

Reviewers
snipe-it: init at 4.8.0 + module

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Adds a package for Snipe IT.

cc @aanderse (after discussion on Discord)

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
+956 -0

0 comment

9 changed files

pr created time in 5 days

create barnchdavidtwco/nixpkgs

branch : snipe-it-init

created branch time in 5 days

pull request commentNixOS/nixpkgs

starship: 0.35.1 -> 0.36.0

Can also confirm with nixpkgs-review.

bbigras

comment created time in 5 days

push eventdavidtwco/nixpkgs

volth

commit sha 7ca47f270f51958435cd416a2280447d3e6bf63e

[cpan2nix] perlPackages.MojoliciousPluginOpenAPI: 2.20 -> 2.21

view details

volth

commit sha 7ca8787cac1691011d766ca8af3b8e08a6bd0ba0

[cpan2nix] perlPackages.CGICompile: 0.22 -> 0.23

view details

volth

commit sha b529c0257bf4753a148dce404b3a05cd2044695e

[cpan2nix] perlPackages.InlineC: cleanup

view details

volth

commit sha 9927dad0a8f45a94d1965d1e71f34fda8eabd281

[cpan2nix] perlPackages.PerlCritic: 1.136 -> 1.138

view details

volth

commit sha 9035530c130bf2e3914953046561eeaaadf80476

[cpan2nix] perlPackages.Swim: cleanup

view details

volth

commit sha 14be4c7f929cd2855ae98cb051f68ddea2569577

[cpan2nix] perlPackages.PodElemental: 0.103004 -> 0.103005

view details

volth

commit sha 81283d17f338f50b4a28e8bbe5d7bd06de9029d1

[cpan2nix] perlPackages.TaskFreecellSolverTesting: cleanup

view details

volth

commit sha 11860881c2ee55ebed592e60defb8866e13c4aed

[cpan2nix] perlPackages.CatalystRuntime: 5.90124 -> 5.90126

view details

volth

commit sha 331185ccd0c59b8e2c4df2fd577f393011617ba2

perlPackages.TimeDate: remote needless patch

view details

volth

commit sha c444a455a3175e122bd1ad5b121fe8753d30f5a9

[cpan2nix] perlPackages.XMLLibXSLT: 1.97 -> 1.99

view details

volth

commit sha e1bee5fe67345eaa921037a26fe8744c201f0d85

[cpan2nix] perlPackages.BCOW: 0.001 -> 0.002

view details

volth

commit sha 24b765cfeb849959d356bf4435fdc97113e225f2

[cpan2nix] perlPackages.ModuleBuild: 0.4229 -> 0.4231

view details

volth

commit sha 3f4fdf84e2a30691706cb54195f01dd0a1b1fc9b

[cpan2nix] perlPackages.PathTiny: 0.110 -> 0.112

view details

volth

commit sha 88080912cd95e9a07fa4597f175fada56c589850

[cpan2nix] perlPackages.CDB_File: 1.01 -> 1.02

view details

volth

commit sha c9dbc24a18c42925441ada036be74f3935d82efa

[cpan2nix] perlPackages.TypeTiny: 1.008003 -> 1.008005

view details

volth

commit sha e439f1350ba1a8279c09c902cc4b286ffd98ad03

[cpan2nix] perlPackages.Test2Suite: 0.000127 -> 0.000128

view details

volth

commit sha 7800c38aa42cd928c979622cc12b1d7e543f17fd

[cpan2nix] perlPackages.SerealDecoder: 4.007 -> 4.008

view details

volth

commit sha 07d15f31751037c69d277b0d6fc683e46344ed0c

[cpan2nix] perlPackages.SerealEncoder: 4.007 -> 4.008

view details

volth

commit sha 4e88446638ac651e640eadbc588c957fbab91169

[cpan2nix] perlPackages.Sereal: 4.007 -> 4.008

view details

volth

commit sha f10092596e78878347ba8106633e36d9a06817c2

[cpan2nix] perlPackages.AlienBuild: 1.96 -> 1.98

view details

push time in 5 days

pull request commentrust-lang/rust

Use generator resume arguments in the async/await lowering

r? @tmandry

jonas-schievink

comment created time in 7 days

pull request commentrust-lang/rust

Don't run coherence twice for future-compat lints

@bors r+

jonas-schievink

comment created time in 7 days

startedelast0ny/shared_memory-rs

started time in 7 days

startedSOF3/include-flate

started time in 7 days

startedMichael-F-Bryan/include_dir

started time in 7 days

startedtilpner/includedir

started time in 7 days

startedrust-lang/rust-log-analyzer

started time in 7 days

startedEdu4rdSHL/findomain

started time in 7 days

startedoreboot/oreboot

started time in 7 days

pull request commentrust-lang/rust

Use `dyn Trait` more in tests

r? @eddyb

Centril

comment created time in 8 days

startedValveSoftware/openvr

started time in 9 days

issue commentNixOS/nixpkgs

`services.phpfpm.pools.<name>.phpEnv` values are not quoted

I suspect that you’re right and that it wouldn’t be feasible to quote all strings, my reading of the format suggests that numbers, PHP constants, INI constants, expressions and references should be unquoted. It’s unclear which of these are valid to provide to env[...] = directives (numbers certainly could be handled like I suggest booleans are) so it probably isn’t feasible to quote every string - updating the documentation is probably the best we can do.

davidtwco

comment created time in 10 days

issue commentNixOS/nixpkgs

`services.phpfpm.pools.<name>.phpEnv` values are not quoted

I think it would be more intuitive if phpEnv.myval accepted strings or booleans. phpEnv.myval = true; would not be quoted in the generated configuration, but all string values would be.

davidtwco

comment created time in 10 days

issue commentNixOS/nixpkgs

`services.phpfpm.pools.<name>.phpEnv` values are not quoted

In fact, it appears as if the default php.ini file starts with a comment that explains the format somewhat.

davidtwco

comment created time in 10 days

issue commentNixOS/nixpkgs

`services.phpfpm.pools.<name>.phpEnv` values are not quoted

@aanderse I don’t, I’ve not used php-fpm much and only discovered this through experimentation.

Perhaps usage of —test (manpage) could be added to validate the configurations, like the nginx module does?

davidtwco

comment created time in 10 days

issue openedNixOS/nixpkgs

`services.phpfpm.pools.<name>.phpEnv` values are not quoted

Describe the bug services.phpfpm.pools.<name>.phpEnv values do not require quotation to be parsed correctly by php-fpm, but if the value contains a = or is true/false (and perhaps other values, then the file fails to parse).

To Reproduce Steps to reproduce the behavior:

  1. Use the following NixOS configuration:
services.phpfpm.pools.foo.phpEnv."bar" = "true";
  1. Observe that phpfpm-bar.service fails to start.
  2. Observe that manually quoting "true" fixes the issue.

Expected behavior phpfpm module appropriately quotes values provided to phpEnv.

Metadata Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

  • system: "x86_64-linux"
  • host os: Linux 4.19.88, NixOS, 19.09.1549.45ea6092203 (Loris)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.3
  • channels(root): "nixos-19.09.1549.45ea6092203"
  • channels(david): ""
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: services.phpfpm

created time in 11 days

push eventdavidtwco/nixpkgs

Jan Malakhovski

commit sha 0017a06717bb18706ac3cb99432034caad0c8b91

nixos/systemd: add an option to suppress system units

view details

R. RyanTM

commit sha 59b948e672b9a83e6e61320888aae75065707148

appstream-glib: 0.7.15 -> 0.7.16 Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/appstream-glib/versions

view details

Thomas Tuegel

commit sha 1af6bdd48f21e120cb4539617d468eefb07c4f90

plasma5: 5.16.5 -> 5.17.5

view details

Thomas Tuegel

commit sha 35f0c972fa53af44413c7e0d1198fcc28fbdaa69

kwin: Update patches for 5.17.5

view details

Thomas Tuegel

commit sha 84ddb3da35d053e23ab05bc59f687779a1519734

plasma-workspace: Update patches for 5.17.5

view details

Thomas Tuegel

commit sha 48bcb6dc8fe8cbecb26eb5a5d3d39c1cc0719c5e

milou: kitemmodels buildInput

view details

Thomas Tuegel

commit sha 7497244541511506f231fe7035417e445a5f3ee1

kscreen: kcmutils buildInput

view details

Thomas Tuegel

commit sha b17818ae1ce76f40c7893764df75e9451e7d010a

TODO White screen in SDDM

view details

Thomas Tuegel

commit sha 9b85a399fd130b5ca0d40cbef026d1bc73d220ea

nixos/plasma5: startkde -> startplasma-x11

view details

Thomas Tuegel

commit sha 9db1c1e0b8eae0fbb6d5128d21ac10624681a9d7

TODO Missing cursor on desktop

view details

Thomas Tuegel

commit sha 91fcbe482566babef0665bc5cc04467ecfb57bac

kwayland-integration: kguiaddons buildInput

view details

Thomas Tuegel

commit sha 7de452a5223799b2e9c9f870b76fe822249010a5

plasma-browser-integration: kpurpose kfilemetadata buildInputs

view details

Thomas Tuegel

commit sha 33dfefad146e46d84a10977c5855caf9a987a086

nixos/plasma5: install plasma-browser-integration

view details

Aaron Andersen

commit sha 5b5856f6fb74dd759a8f516291beb496cfb8ffcd

nixos/httpd: add http2 option

view details

Edmund Wu

commit sha 9a031427eb049b13ce91dabed01eb15036914cbc

vscode-extensions.ms-python.python: 2019.10.44104 -> 2020.1.58038

view details

Edmund Wu

commit sha 1d87488d082b8db650214530a7c19bb691582fb7

vscode-extensions.ms-vscode.cpptools: 0.26.1 -> 0.26.3

view details

Nikolay Korotkiy

commit sha a1caeda72cf45ed1d3ea08619c4afa8889664638

viking: 1.7 -> 1.8

view details

Thomas Tuegel

commit sha 27fc6620e9f99991bbaae78e15c5a0626af39e12

plasma5.plasma-workspace: Fix path to SDDM theme background image

view details

Jan Tojnar

commit sha 4be1d742b79c5dec19e6d58e391efd8b1619e398

libxmlb: 0.1.13 → 0.1.14 https://github.com/hughsie/libxmlb/commit/412a991890f895e45fc771aa9aa7d6c55a1505d7

view details

Jan Tojnar

commit sha 0ecc8367771abace34d6708670f5497d46b72709

fwupd: 1.3.3 → 1.3.7 Changelogs: * https://github.com/fwupd/fwupd/commit/342a38b43283108f92aa6eb18073073c2b20828b * https://github.com/fwupd/fwupd/commit/713d20f79fa0e460c02f109d68f3ad5e825e6298 * https://github.com/fwupd/fwupd/commit/1ac566bc09bf63505e01f8b7fc839592b8591f7d * https://github.com/fwupd/fwupd/commit/ca3cdaef43971c170d911cc85f6ae3746cd64833 Notably: * libfwupdplugin was factored out of the binary, introducing irreconcilable dependency cycle between `out` and `lib` outputs.

view details

push time in 11 days

startedkata-containers/kata-containers

started time in 12 days

startedsharkdp/shell-functools

started time in 12 days

delete branch davidtwco/nixpkgs

delete branch : cc-wrapper/expose-cc-wrapper-script

delete time in 12 days

delete branch davidtwco/nixpkgs

delete branch : starship-0.21.0

delete time in 12 days

delete branch davidtwco/nixpkgs

delete branch : diffr-tests

delete time in 12 days

PR opened NixOS/nixpkgs

Reviewers
jirafeau: init at 4.1.1 + module

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Adds a package for Jirafeau and a module for configuring and running Jirafeau.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
+229 -0

0 comment

6 changed files

pr created time in 12 days

create barnchdavidtwco/nixpkgs

branch : jirafeau-init

created branch time in 12 days

pull request commentNixOS/nixpkgs

starship: 0.33.1 -> 0.34.1

Please try with v0.35.0 which should fix the problem.

v0.35.1 has also been released.

filalex77

comment created time in 12 days

push eventdavidtwco/nixpkgs

Marek Mahut

commit sha 3baa12f28691bb5120e2599939d31033a5ed3a26

litecoin: support qt5

view details

Marek Mahut

commit sha 910c73e062dc14917753df23e017c3ee6f1a37f3

litecoin: add zmq support

view details

Jörg Thalheim

commit sha 43f117537f37c687ce4e539cf64caab76c9ca3ff

Merge pull request #78426 from Mic92/tmpfiles nixos/systemd: add all systemd tmpfiles files

view details

Franz Pletz

commit sha ec1c46e2e587e5b4b793aa93359318b22985d5ab

Merge pull request #78499 from r-ryantm/auto-update/dero dero: 0.11.6 -> 0.11.7

view details

Franz Pletz

commit sha c5d06b022b22d0e542ce2ffd0fe092317758fb03

spdx-license-list-data: init at 3.7

view details

Franz Pletz

commit sha 8c6f35a60713a7831f2729fb974eb1f65a4d79ec

platformio: 4.0.3 -> 4.1.0

view details

cw

commit sha e3863ab2691a34cb3868aca6a35caf97115a83c3

elixir_1_10: init at 1.10.0 Set elixir_1_10 as default elixir version. Removed elixir_1_5 as support has faded out now.

view details

R. RyanTM

commit sha 14e24dd06291dbcbc0b34b2a865ad9486b83487d

ncmpc: 0.36 -> 0.37

view details

foxit64

commit sha bec01d82700a3b3a80c5d7f0b90bfd5db4bdad4d

telegraf 1.12.1 -> 1.13.2

view details

jobojeha

commit sha f4e87eb2da2a8af92d9af3a9aeefa8024455d998

paraview: prefix PYTHONPATH --prefix gives the possibility to add additional python modules to path

view details

wucke13

commit sha f18604531390273733757ec36097699c469a9ab5

foxtrotgps: init at 1.2.2

view details

R. RyanTM

commit sha 59143980310f7823a07157bd7ca31cd871675241

mpd_clientlib: 2.17 -> 2.18

view details

R. RyanTM

commit sha e838bebc78591ba474889a329714cdd57bb04938

cjdns: 20.4 -> 20.5

view details

Robert Scott

commit sha 5e7dc6248f88883c6356869b39a3103ec6e01870

samba: 4.10.11 -> 4.11.3

view details

Robert Scott

commit sha 6e61548dd1414ee487a2780019b874bd6ec82665

samba: remove no-longer-necessary darwin test hack test is skipped automatically now

view details

Pascal Bach

commit sha 00610756df9a235f2de907a18cd8fded638d24e0

samba: 4.11.3 -> 4.11.5 This is a security release in order to address the following defects: - CVE-2019-14902: Replication of ACLs set to inherit down a subtree on AD Directory not automatic. - CVE-2019-14907: Crash after failed character conversion at log level 3 or above. - CVE-2019-19344: Use after free during DNS zone scavenging in Samba AD DC.

view details

Niklas Hambüchen

commit sha 6f1095b0bacc2d71da7f5b548d450fcccc8d0efa

Merge pull request #78574 from bachp/samba-4.11.5 samba: 4.10.11 -> 4.11.5

view details

Niklas Hambüchen

commit sha 34c4d3b6278dc6f933cc57f8149a1908b108eba1

Merge pull request #78580 from r-ryantm/auto-update/gparted gparted: 1.0.0 -> 1.1.0

view details

Niklas Hambüchen

commit sha b949937fd19a377c904f2dbe602745a9ad6060ec

libimobiledevice: 2019-11-29 -> 2020-01-20

view details

Niklas Hambüchen

commit sha 58480f5c9098382bb7a5f3f52693062404ce9aeb

Merge pull request #78577 from leo60228/idevicerestore-2019-12-26 libirecovery: 2019-01-28 -> 2020-01-14, idevicerestore: 2019-02-14 -> 2019-12-26

view details

push time in 12 days

startedaep/zz

started time in 13 days

pull request commentNixOS/nixpkgs

wooting: init wootility, wooting-udev-rules and module

@matthewbauer Is there anything I can do to help see this land?

davidtwco

comment created time in 13 days

push eventdavidtwco/veritas

David Wood

commit sha 8a73caa5f01fd1d3b448163ecc90e2bdb2690d9d

Don't use nix shell name in prompts, avoids truncation.

view details

push time in 14 days

startedAGWA/git-crypt

started time in 14 days

push eventdavidtwco/veritas

David Wood

commit sha 2e7a18433e208306a420d6f2200d3e776235b7ea

Install git-crypt.

view details

push time in 14 days

push eventdavidtwco/veritas

David Wood

commit sha d6180410179a54282f4deb25e43c93a2f7b1ee91

Correct capitalization of comments.

view details

push time in 14 days

issue closedLibreVR/Revive

Link with Oculus account that has 2-factor authentication

Is there a supported mechanism for linking an Oculus account (after the 2.0.0 release) which has two-factor authentication enabled? I attempted a login with the account username and email, with the password and the password concatenated with the current two factor code. Thanks!

closed time in 15 days

davidtwco

issue commentLibreVR/Revive

Link with Oculus account that has 2-factor authentication

And I assume it gives you an incorrect password message even if you don't add the 2FA token?

That’s correct, yes.

Unfortunately I don't think there's a way for Revive to support 2FA, you'll need to ensure you have a secure password and turn off 2FA.

That’s a shame, thanks for checking. I’ll close this issue.

davidtwco

comment created time in 15 days

issue commentLibreVR/Revive

Link with Oculus account that has 2-factor authentication

I attempted a login with the account username and email, with the password and the password concatenated with the current two factor code.

Wait, does that actually work?

No, it definitely didn’t, but I’ve seen other services do this so thought it was worth a try.

davidtwco

comment created time in 16 days

issue openedLibreVR/Revive

Link with Oculus account that has 2-factor authentication

Is there a supported mechanism for linking an Oculus account (after the 2.0.0 release) which has two-factor authentication enabled? I attempted a login with the account username and email, with the password and the password concatenated with the current two factor code. Thanks!

created time in 16 days

pull request commentrust-lang/rust

Add support for enabling the LLVM time-trace feature

@bors r+

wesleywiser

comment created time in 16 days

pull request commentrust-lang/rust

Fix ICE with save-analysis

@bors r+

JohnTitor

comment created time in 16 days

push eventdavidtwco/veritas

David Wood

commit sha 6c36f57c5949b37819ab50e628a30b1a312dca05

Add ddrecuse package.

view details

push time in 17 days

startedBookStackApp/BookStack

started time in 18 days

startedgoogle/OpenSK

started time in 18 days

push eventdavidtwco/veritas

David Wood

commit sha 2cf2d21b897570f9bbe6837c0986c0636afb1f3f

Upgrade Plex to 1.18.5-2309

view details

push time in 19 days

push eventdavidtwco/veritas

David Wood

commit sha f5eefeec1578fce8dfc3a8f6a49f05cf2115d576

Upgrade pinned nixpkg versions.

view details

push time in 19 days

Pull request review commentrust-lang/rust

Minimum lint levels for C-future-compatibility issues: take two

 impl<'a> LintLevelsBuilder<'a> {         BuilderPush { prev: prev, changed: prev != self.cur }     } +    /// If we have e.g. `#[allow($some_future_compat_lint)]` this will have+    /// no effect as `min_level > Allow`. We want to tell the user about this.+    fn lint_higher_minimum_attr_lint(+        &self,+        lint: &'static Lint,+        level: Level,+        src: &LintSource,+        specs: &FxHashMap<LintId, (Level, LintSource)>,+    ) {+        let min_level = lint.min_level;+        if min_level <= level {+            return;+        }++        if let LintSource::Node(name, _, span, _) = src {+            // Get the `unused_attributes` lint specs:+            let unused = builtin::UNUSED_ATTRIBUTES;+            let (lvl, src) = self.sets.get_lint_level(unused, self.cur, Some(&specs), &self.sess);++            // Construct base diagnostic for `unused_attributes`:+            let level_str = level.as_str();+            let msg = format!("#[{}({})] has no effect", level_str, name);+            let multi_span = Some((*span).into());+            let mut err = struct_lint_level(self.sess, unused, lvl, src, multi_span, &msg);++            // Add notes about minimum levels and what the user should do here:+            err.note(&format!("the minimum lint level for `{}` is `{}`", name, min_level.as_str()))+                .note(&format!("the lint level cannot be reduced to `{}`", level_str))+                .help(&format!("remove the #[{}({})] directive", level_str, name));

I can't see any tests that show this help message - was wondering if it could be a suggestion?

Aaron1011

comment created time in 19 days

Pull request review commentrust-lang/rust

Minimum lint levels for C-future-compatibility issues: take two

 pub enum LintSource {     Default,      /// Lint level was set by an attribute.-    Node(Symbol, Span, Option<Symbol> /* RFC 2383 reason */),+    Node(Symbol, Option<Level>, Span, Option<Symbol> /* RFC 2383 reason */),

Perhaps this (and the CommandLine variant) should be made into struct variants with named fields for clarity?

Aaron1011

comment created time in 19 days

push eventdavidtwco/veritas

David Wood

commit sha 43e6905cb44a13d95bf8f96cc01f84ea25cd4170

Enable cifs filesystem support.

view details

push time in 25 days

Pull request review commentrust-lang/rust

Suggest borrowing `Vec<NonCopy>` in for loop

 impl<'a, 'tcx> MirBorrowckCtxt<'a, 'tcx> {                     format!("{}.as_ref()", snippet),                     Applicability::MaybeIncorrect,                 );+            } else if span.is_desugaring(DesugaringKind::ForLoop)+                && move_ty.starts_with("std::vec::Vec")

If it isn't too difficult to do, I think it would be nice to see these move_ty.starts_with checks replaced with diagnostic items.

estebank

comment created time in a month

pull request commentrust-lang/rust

Selectively disable sanitizer instrumentation

@davidtwco do you feel up for reviewing this, or should we reassign? (I could take it, in theory)

Oops, I missed the follow up comments after being nominated for discussion.

r? @nikomatsakis

tmiasko

comment created time in a month

push eventdavidtwco/veritas

David Wood

commit sha 2513fa3c48de447fd5274ae9b449675f476a89fb

Fix another nixops-dns comment.

view details

push time in a month

push eventdavidtwco/veritas

David Wood

commit sha e8bb21c13c235f19ebc48cd1e1ac266c57adf6c8

Update nixops-dns comment.

view details

push time in a month

push eventdavidtwco/veritas

David Wood

commit sha 8d07f50ee8ade012ab5b46d75b2cb641ff1fe96a

Move `trustedInterfaces` configuration to virtualisation profile.

view details

David Wood

commit sha 0943f89aa26be82c4ee9faca73256da1a921fcc5

Move/comment some configuration options.

view details

David Wood

commit sha 421a87307fe708d5effcd768e6fab31d17836962

Fallback to Cloudflare DNS, not Google.

view details

David Wood

commit sha 1a309dd567b46f2d5ea3d29fd380c9beb2b1cbe5

Use full VirtualBox on dtw-volkov.

view details

David Wood

commit sha 811302625710f5ba8523d0914aa16cb145b835d7

Configure nixops-dns.

view details

push time in a month

startedriker-rs/riker

started time in a month

startedlikebike/fasteval

started time in a month

startedactix-support/letter

started time in a month

delete branch davidtwco/letter

delete branch : add-davidtwco

delete time in a month

PR opened actix-support/letter

Add David Wood
+1 -0

0 comment

1 changed file

pr created time in a month

create barnchdavidtwco/letter

branch : add-davidtwco

created branch time in a month

push eventdavidtwco/personal-website

David Wood

commit sha 355dfdec1bfbdd17d0c66de2b41dcdbb0156f8a9

Add new OSS contribution.

view details

push time in a month

delete branch davidtwco/nixpkgs

delete branch : computecpp-init

delete time in a month

push eventdavidtwco/veritas

David Wood

commit sha 9adb04ebe69d9497699373c58bdb4cbe22be8e39

Allow configuring if VirtualBox is headless. Signed-off-by: David Wood <david.wood@codeplay.com>

view details

David Wood

commit sha a0db71d69f55f0922d93a7b2fe69a66262d7067a

Remove computecpp-fork from sources.

view details

push time in a month

push eventdavidtwco/nixpkgs

nyanloutre

commit sha b092c4618aedbb34837f37abc387e499cf98700e

usb-modeswitch: fix configurable patch

view details

Marijan Petričević

commit sha 61c61f80e58b24c969f0ea1d0d069e70ddc37be3

nixos/test: added verbose output for failed tests

view details

R. RyanTM

commit sha 9789c3d63618e6d86d4057b6e37e3eab31fad624

cpp-utilities: 5.0.1 -> 5.1.0

view details

R. RyanTM

commit sha a4c0b61fe21f156874c774a31acc735140635e41

pwndbg: 2019.01.25 -> 2019.12.09

view details

Frank Doepper

commit sha 7b920bc35bb5e6cdf59bfb5def80fbc23c38c7df

zfsnap: init at 2.0.0-beta3 Co-authored-by: Silvan Mosberger <contact@infinisil.com>

view details

R. RyanTM

commit sha 2f3701e2ab29c75f4eec6c7c019da4f391de0f43

syncthingtray: 0.10.4 -> 0.10.5

view details

Jörg Thalheim

commit sha 15dbf5221f59d9a8dbb0fa2473e22d4e3621cbc6

pwndbg: 2019.01.25 -> 2019.12.09 (#77896) pwndbg: 2019.01.25 -> 2019.12.09

view details

David Wood

commit sha 853372bfaf55cae11cd96b4aeb599e09ab5068f5

computecpp: init at 1.2.0 Signed-off-by: David Wood <david.wood@codeplay.com>

view details

Will Dietz

commit sha 8572179033b9f12edbb8e6e9f3f23a607bc7cef6

xlayoutdisplay: 1.1.0 -> 1.1.1

view details

Silvan Mosberger

commit sha 0866527ec13bbc6790c45adc61e25293f8fa609c

zfsnap: init at 2.0.0-beta3 (#70234) zfsnap: init at 2.0.0-beta3

view details

Florian Klink

commit sha ed0b5b613360fc2634b7da2a055ef428789874b3

Merge pull request #77662 from marijanp/verbose-python-test-driver nixos/test: added verbose output for failed tests

view details

Will Dietz

commit sha f38e103411a24f472357bcd8c0508077a19163e7

elfinfo: 0.7.6 -> 1.0.1

view details

Erik Arvstedt

commit sha e6fad86853d5e500e2dd1bfc31bea187034ac426

tesseract: 4.1.0 -> 4.1.1

view details

Jörg Thalheim

commit sha b4d4f83e1feb96518fb8ae55c70202ef0a42deb9

Merge pull request #75946 from davidtwco/computecpp-init computecpp: init at 1.2.0

view details

Ryan Mulligan

commit sha 98ca8ee97ded58e53c7a97c7f9be270021884200

Merge pull request #77871 from r-ryantm/auto-update/cpp-utilities cpp-utilities: 5.0.1 -> 5.1.0

view details

Ryan Mulligan

commit sha d3ab403a1fa47f2dc11bd6bdeb1b7aa6aecbd6b3

Merge pull request #77907 from r-ryantm/auto-update/syncthingtray syncthingtray: 0.10.4 -> 0.10.5

view details

Peter Hoeg

commit sha 9290d1f4cb44130fb1895fa6dc64a44609ab4632

Merge pull request #77695 from nyanloutre/usb-modeswitch usb-modeswitch: fix configurable patch

view details

push time in a month

pull request commentNixOS/nixpkgs

computecpp: init at 1.2.0

@Mic92 I've updated the commit to fix that issue.

davidtwco

comment created time in a month

push eventdavidtwco/nixpkgs

David Wood

commit sha 853372bfaf55cae11cd96b4aeb599e09ab5068f5

computecpp: init at 1.2.0 Signed-off-by: David Wood <david.wood@codeplay.com>

view details

push time in a month

push eventdavidtwco/nixpkgs

Janne Heß

commit sha f110d2f30801a32333f24ef5c436622bd5fbcb3e

pythonPackages.pyTelegramBotAPI: Init at 3.6.6

view details

schneefux

commit sha a0e2310364c5c10c9655903fa51b88a39e0b2ffe

shaarli-material: Mark as broken

view details

Alexander Bakker

commit sha 93c5503c2e3fbfba815806afea20828fd6540d54

zenpower: init at 0.1.5

view details

Jörg Thalheim

commit sha 4d7ae1e646a1be33cb96dfadfe296989c7f984b3

hplip: 3.19.6 -> 3.19.12

view details

Bignaux Ronan

commit sha 4d8cb42faeaf068819c3bf20ad233bb61353520f

kmahjongg: init at 19.08.3

view details

Oleksii Filonenko

commit sha cb132f981f9cf1259cbb2319441f93ce9c9360ba

tiny: init at 0.5.1

view details

Maarten Hoogendoorn

commit sha 7d14a45b51574f1d679f6d81f3bf04064756d62e

krop: Add wrapQtAppsHook. Closes #77339

view details

zowoq

commit sha 9ce498e301077c5c38091eda047288f7bf688f62

fuse-overlayfs: 0.7.2 -> 0.7.3

view details

Sergey Lukjanov

commit sha eabc138cb95e866a9676be6c2027e484bf1f7d44

iperf3: fix compilation to support authentication creds Service iperf3 defines authorizedUsersFile and rsaPrivateKey to enable authenticated iperf server. It requires iperf to be compiled with openssl. https://nixos.org/nixos/options.html#services.iperf3.authorizedusersfile

view details

Robin Gloster

commit sha 6bf0ed8e02ee21471410fd9563bd29b10905a61a

gitlab: fix asset building for CE We have to specify if we're building CE or EE otherwise at least some JS building was broken, resulting in e.g. broken "boards" pages.

view details

Nikolay Korotkiy

commit sha e9e684c7a4d56ce9f48e4418d7960770d745a3af

gpxsee: 7.18 -> 7.19

view details

Benjamin Hipple

commit sha fd7ae52d5383ee9666e31799d38691ced3d22363

blitz: remove package This is very out of date, is pinned to an old version of boost, and the last update was 2.5 years ago marking it as broken. Since no one has fixed it or upgraded to the least version, it seems a strong indication it's no longer used/wanted/maintained and should be removed.

view details

Marek Fajkus

commit sha c7f5569bd2bd02a3e920230a39ed8d0db03d0e6f

skypeforlinux: 8.55.0.123 -> 8.55.0.141

view details

Will Dietz

commit sha 8e48bafca18dd0fd031282b7c76024b95e86f737

pfetch: fix 'dontbuild' attribute (-> "dontBuild"), touchup installPhase

view details

Will Dietz

commit sha 1ff48dce3a43f533570aa56c9a6d5e826dc51dc9

pfetch: use stdenvNoCC for smaller build-time closure

view details

Oleksii Filonenko

commit sha 35c4234afcd19d7be81ddc4bea582254fa401d2f

nnn: 2.8.1 -> 2.9

view details

Oleksii Filonenko

commit sha 9828c5753c65d5a38f4db3b1d04ef780d153828e

nnn: add filalex77 to maintainers

view details

R. RyanTM

commit sha d829a669193353fd0409bf6fcc9bf3c2e388d9a8

pantheon.elementary-code: 3.1.1 -> 3.2.0

view details

R. RyanTM

commit sha bab1e3fe6540e7bd4456875ccf954cc5b4c31b69

grilo: 0.3.10 -> 0.3.11

view details

Will Dietz

commit sha 5c4bebfd667d132752224cebbc7b94278ff13c61

fpart: fts (fix w/musl)

view details

push time in a month

pull request commentNixOS/nixpkgs

computecpp: init at 1.2.0

Right now it does not find the gcc/stdlibc++ headers:

I'll look into fixing this, thanks.

davidtwco

comment created time in a month

push eventdavidtwco/zulip

Tim Abbott

commit sha 0ce508693f78c6f949b85d03606c7b633141b8c1

docs: Fix broken link to stable releases. Apparently, our ReadTheDocs configuration is now requiring the trailing / here; it should have been present before anyway.

view details

Tim Abbott

commit sha fa26475fcfd7aee1343a22b10b1a8c8e9a64a5f7

docs: Deal with a few broken links.

view details

Vishnu Ks

commit sha a03765bbe247e7a2f5bb74335c5ec061e6c20ccb

bugdown: Extract out function for getting openapi example value.

view details

Vishnu Ks

commit sha cb64fc8732b8fdd2593beaa77c3808b136df9790

bugdown: Show example value for path params in curl example.

view details

Vishnu KS

commit sha 9bc3594f759f2bbd9ada46772032f16a61af819c

docs: Make get-raw-message use curl example system.

view details

Vishnu Ks

commit sha 0dccebbe39668c003e0aa1c75aa3a7f1a7f1d625

docs: Make update-message use curl example system.

view details

Vishnu Ks

commit sha ed2e89f167c7ac55aec97b03d9623c8c34098701

docs: Make delete-message use curl example system.

view details

Vishnu Ks

commit sha 19ee518f2e2b0900e36594091fccdcb12d06a968

docs: Make get-message-history use curl example system.

view details

Vishnu Ks

commit sha f0b099dbc0d63ac81017dbd25b9d4015ebf46685

docs: Make update-message-flags use curl example system.

view details

Vishnu Ks

commit sha 3f9835ed07c2e74f329a881ccc6d3f7642d41500

docs: Make mark-as-read-bulk use curl example system.

view details

Vishnu Ks

commit sha c35ef2d3907ca302cb89dcea33b6a53bb3d9606c

bugdown: Add option to include only selected fields in generate_curl_example.

view details

Vishnu Ks

commit sha 9442422da12fd34ef4a410f6f7c7bf2164917536

docs: Make get-all-streams use curl example system.

view details

Vishnu Ks

commit sha 94d31e9d4f8a457ccc061bc29fbff91bb0fca857

docs: Make get-subscribed-streams use curl example system.

view details

Vishnu Ks

commit sha 06883dc4b2659f665622f55caed7688aec0981ef

docs: Make add-subscriptions use curl example system.

view details

Vishnu Ks

commit sha 89d82ab827842f2f75a9cc7bf0b762b79f8484a7

openapi: Improve description of subscriptions in /users/me/subscriptions.

view details

Vishnu Ks

commit sha 4364e31d699a8e39a34f49af23fee8266f6ef71a

docs: Make update-subscription-properties use curl example system.

view details

Vishnu Ks

commit sha ad16c55c777235072ef555b4b8223ae7931f6661

docs: Make remove-subscriptions use curl example system.

view details

Vishnu KS

commit sha bd6b41cb9d0eab3a8671301af621693d9a174487

tests: Remove unused variable in test_curl_examples.

view details

Vishnu Ks

commit sha 13bdfc0ef81bdd1644288d900ea460a98413402b

docs: Make get-stream-topics use curl example system.

view details

Vishnu Ks

commit sha 04cc121b77e6d339aaa32000ff41f7a07200af7d

docs: Make mute-topics.md use curl example system.

view details

push time in a month

push eventdavidtwco/personal-website

David Wood

commit sha 40524ef2e0e45bfd44142a31c46531980ac8ab77

Add new OSS contribution.

view details

push time in a month

delete branch davidtwco/nixpkgs

delete branch : starship-0.33.1

delete time in a month

push eventdavidtwco/personal-website

David Wood

commit sha 6db94e2219861a8cc9c24d72947384672c6050fe

Add new OSS contribution.

view details

push time in a month

delete branch davidtwco/nixpkgs

delete branch : mdcat-0.15.0

delete time in a month

PR opened NixOS/nixpkgs

starship: 0.33.0 -> 0.33.1
Motivation for this change

v0.33.1 of Starship was released.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
+3 -3

0 comment

1 changed file

pr created time in a month

create barnchdavidtwco/nixpkgs

branch : starship-0.33.1

created branch time in a month

push eventdavidtwco/nixpkgs

Ivan Kozik

commit sha 8ecf18caa3789b2b574b416dfc58fba222b311ff

usbmuxd: 2019-03-05 -> 2019-11-11

view details

Ivan Kozik

commit sha 4866073c1f2422600bb02bcbcc7fd5e616aee061

libimobiledevice: 2019-04-04 -> 2019-11-29

view details

Michael Roitzsch

commit sha 5c01936d7d2b6904476c79342261cbb4ef62db11

docker-machine-xhyve: update repository location The zchee repository now redirects to machine-drivers.

view details

Gabriel Gonzalez

commit sha 183a99734f666b6bd508f4c81e887dbc746fec69

Add `pkgs.lib.renderOptions` This adds a new utility to intelligently convert Nix records to command line options to reduce boilerplate for simple use cases and to also reduce the likelihood of malformed command lines

view details

Gabriel Gonzalez

commit sha 8c6a05c8c99819dbd85d555cb50596637d57df44

Rename `renderOptions` to `encodeGNUCommandLine` ... as suggested by @edolstra

view details

Gabriel Gonzalez

commit sha 693096d283763ce71fcd2002d965c07546aaafda

Make behavior of `encodeGNUCommandLine` customizable ... based on feedback from @edolstra

view details

Gabriel Gonzalez

commit sha 5edd4dd44c5f3de1886744aeac49bd396c24f966

Use a more realistic example that exercises all encodings ... as suggested by @roberth This also caught a bug in rendering lists, which this change also fixes

view details

Michael Roitzsch

commit sha 475bf6d2a5f3ba2e4c3d2b31b6e54f26e1aa7163

docker-machine-xhyve: 0.3.3 -> 0.4.0 remove explicit dependencies, upstream vendorizes them properly

view details

Michael Roitzsch

commit sha 08ecf22b0332de05b6b2290ef4bdac2e2ce10f34

docker-machine-xhyve: support lib9p shared file system The lib9p library for host-guest file sharing in xhyve needs to be built separately.

view details

Michael Roitzsch

commit sha 338386b95d881175ec5e27dda07daccec525f84c

docker-machine-xhyve: fix file mode inconsistencies File modes are not properly translated from L9P to host values. Instead, they are assumed to be identical, which is wrong on macOS. https://github.com/machine-drivers/docker-machine-driver-xhyve/pull/225

view details

R. RyanTM

commit sha 36b5802a8beb975be4d39afcd760b24722db502d

libsixel: 1.8.2 -> 1.8.4

view details

Jan Tojnar

commit sha 730c92d9e223537a0279a3db6d03283757444680

libplist: disable python by default Introduced in 6449435b04cb608389e3d1df653fed857633b724, only Python 2 is supported and it does not seem to be used by anything.

view details

Jan Tojnar

commit sha 4cb22aa377fc688bf58f9d433652820f95e7e90d

gst_all_1.gst-validate: switch to python 3

view details

Jan Tojnar

commit sha 544ae9608258c149a1751ac04b4ad7fbb84b49a3

gst_all_1.gst-editing-services: switch to python 3 Also remove no longer needed perl.

view details

Jan Tojnar

commit sha c691baf85fbcf0dd47174e82e59b03bbf58a1df8

strongswan: switch to python 3

view details

Jan Tojnar

commit sha 8b6d76525ea92156504aa76764d9a0962bb2eb58

libnl: disable python support by default Nothing much seems to be using it and we do not want Python 2 in our closure.

view details

Jan Tojnar

commit sha 23ec74b1b25d7743f02c0ceabac442a4fdad0e62

dtc: disable Python support by default It does not seem to be used by anything and we want to get rid of Python 2 from closure.

view details

Jan Tojnar

commit sha e9cdcde6ea3cac061c70f808a2a87ca4388cb52b

gst_all_1.gst-plugins-ugly: switch to python 3

view details

Jan Tojnar

commit sha c72e388b7f5c0968c28e0b35922b89fc34fb6242

gn: switch to python 3

view details

Jan Tojnar

commit sha e4bd8a6faba6cbd1e4ebb0617a1727cfea1ada19

htop: switch to python 3

view details

push time in a month

pull request commentrust-lang/rust

Address inconsistency in using "is" with "declared here"

I’m afraid I don’t have a strong opinion here either. I would prefer consistency but don’t particularly mind which option. I do think that places where we’re saying the X is Y read slightly stranger than X is Y to me, otherwise X is Y reads fine.

varkor

comment created time in a month

issue commentrust-lang/rust

async/await regression regarding borrows across yields

Unassigning myself since #65345 has landed.

valff

comment created time in a month

PR opened NixOS/nixpkgs

mdcat: 0.14.0 -> 0.15.0
Motivation for this change

Update mdcat to 0.15.0.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
+7 -5

0 comment

1 changed file

pr created time in a month

create barnchdavidtwco/nixpkgs

branch : mdcat-0.15.0

created branch time in a month

push eventdavidtwco/nixpkgs

markuskowa

commit sha 1c552615744a3206ecba7d8e0f3fbafb6b4d947c

Merge pull request #75526 from robertodr/more-mkl Add GNU threading and Fortran libraries to MKL package

view details

Michael Weiss

commit sha 1c7c1e052956e11f362359a134a130dfa427c31f

rav1e: 0.2.0 -> 0.2.1 Changelog: https://github.com/xiph/rav1e/releases/tag/v0.2.1

view details

markuskowa

commit sha 947043ab94a004b584e141c9096ed66c8393067f

Merge pull request #76949 from markuskowa/upd-texmaker texmaker: 5.0.3 -> 5.0.4

view details

zimbatm

commit sha 48f461d8c3234fc32e99f6253fd01f441c8ac3a6

Merge pull request #76916 from danielfullmer/zerotierone-cross zerotierone: fix cross compilation

view details

Robert Scott

commit sha 7766de0a5355b46a189d54bfe9e2aa1c2f30c60f

unicorn-emu: enable for darwin/unix

view details

Robert Scott

commit sha 8b3e1e72a7fa91e9f35350ef55b3adb97b255292

pythonPackages.unicorn: redesign to become a wrapper package around unicorn-emu this allows us to easily keep the two in sync and gives a more flexible result, also add self as co-maintainer.

view details

Elis Hirwing

commit sha 4c9e280001518328ae3be74cf80cb7b6e3017952

Merge pull request #76698 from fnords/protonmail-bridge-1.2.3-1-bump protonmail-bridge: 1.2.2-1 -> 1.2.3-1

view details

Danylo Hlynskyi

commit sha cef68c4580f1d5bb648d0c7ce969f696fa1a2459

nixos/nginx: don't hide nginx config errors on nixos-rebuild --switch with reload enabled (#76179) nixos/nginx: don't hide nginx config errors on nixos-rebuild --switch with reload enabled Closes https://github.com/NixOS/nixpkgs/issues/73455

view details

Louis Bettens

commit sha d49737836a4f2f74212552b404cf7e97bbd976a4

nixos/gnunet: Add types to the options

view details

Robert Scott

commit sha 951fb0472af179c6d9c93e1bb26f8ccdc04a0766

pythonPackages.pybind11: fix for clang default clang is still not happy with c++17's sized and aligned deallocations

view details

Louis Bettens

commit sha caa9ce1caac4b6e0e91f5693195345bfcb1be583

nixos/tsocks: Add types to the options

view details

Jason Felice

commit sha 0283016f37de418b08553c55b767ca76dd667b00

parinfer-rust: 0.3.1 -> 0.4.2

view details

Léo Gaspard

commit sha 8440abe7e6f8f85eca9fd8ad9f8471971202c905

Merge pull request #60262 from kierdavis/ckb-next-0.4.0 ckb-next: 0.3.2 -> 0.4.2

view details

Arnout Engelen

commit sha 43ef3a8d003fd64477b2eabb41e617e23e10a05f

lib/modules: clarify error message of 'assigning to top-level attribute' If I understand correctly, the problem isn't so much that you're assigning to that top-level attribute, but that the assignment to the attribute (or any child of the attribute) introduces the 'config' object and prevents 'lifting' all settings to a generated 'config' object.

view details

Timo Kaufmann

commit sha 58edcdc6baba122cfb1c04c6ba6680486c28adfa

ntl: 11.4.2 -> 11.4.3 Upstream[1]: > I uploaded NTL 11.4.3 to https://www.shoup.net/ntl/ > This fixes an embarrassing build problem in 11.4.2. [1] https://groups.google.com/forum/#!topic/sage-devel/V5zHWIpRIJo

view details

Mario Rodas

commit sha eeac7d48d239c28eb6b6e5ea0c23c63fcdeb5304

Merge pull request #76963 from marsam/fix-libmad-darwin libmad: fix build on darwin

view details

Mario Rodas

commit sha 3cd4047f37425f914577e29b547470161a75c668

Merge pull request #76964 from marsam/update-onefetch onefetch: 2.1.0 -> 2.2.0

view details

Mario Rodas

commit sha 97dca00890e57d92d97529e869f8062c2abcee20

Merge pull request #76956 from marsam/update-flexget flexget: 2.21.25 -> 3.0.31

view details

symphorien

commit sha 54b0ab0ac63702b9bd7882eb53fd4b202df64949

Update nixos/tests/ihatemoney.nix Co-Authored-By: Léo Gaspard <github@leo.gaspard.ninja>

view details

symphorien

commit sha b8b9e7be6dc1e5e7c45040cf0702be0db42121c8

Update nixos/tests/ihatemoney.nix Co-Authored-By: Léo Gaspard <github@leo.gaspard.ninja>

view details

push time in a month

starteddtolnay/star-history

started time in a month

pull request commentrust-lang/rust

Selectively disable sanitizer instrumentation

Is there an RFC for this that is being implemented? I've not been able to find one and this feels like it would be the type of thing that requires one?

cc @rust-lang/lang

tmiasko

comment created time in a month

push eventdavidtwco/veritas

David Wood

commit sha 8f820e8ab7bf478778531733dbafbd363628c2d1

Enable virtualbox to be enabled explicitly.

view details

push time in a month

push eventdavidtwco/veritas

David Wood

commit sha 6990ecb71716b1554046704a9580c8b84944eccc

Update `sources.nix` from niv.

view details

push time in a month

startedliuchengxu/vista.vim

started time in a month

more