profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ZenGround0/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

ipfs/ipfs-cluster 1016

Pinset orchestration for IPFS

drand/drand 383

🎲 A Distributed Randomness Beacon Daemon - Go implementation

filecoin-project/FIPs 115

The Filecoin Improvement Proposal repository

ipfs/go-ipfs-keystore 8

go-ipfs-keystore provides an interface and implementation of key storage for IPFS

therealyingtong/RollupNC 5

non-custodial exchange build with rollup

ZenGround0/ent 4

Herd filecoin state trees for upgrade migrations

shippy/wm4m 1

Watch me for me. Rails/Pebble mental health hack.

push eventfilecoin-project/specs-actors

Aayush Rajasekaran

commit sha 55d30b231a9c91b6bc93d365d9f88ac3331dad9e

Remove cc upgrade (#1473) (#1520) * Remove cc upgrade * Disable cc upgrades in agent tests and regen determinism vectors Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>

view details

push time in 11 hours

PR merged filecoin-project/specs-actors

Remove cc upgrade

Needs #1519.

Partially addresses #1512, doesn't include the expiry queue cleanup.

+43 -2014

0 comment

14 changed files

arajasek

pr closed time in 11 hours

PullRequestReviewEvent

issue commentfilecoin-project/specs-actors

Remove miners with test sector types from state

Migration testing criteria:

  • Miners with bad proof types need to go away
  • Signature of miners with bad proof types in power actor need to change — claim is removed — total miners miners over conseusns …. is removed
  • Market actor escrow table removes these bad miners
  • Owner address of these bad miners is given the funds belonging to the miner actor
  • Owner address also gets funds put in the market actor escrow table
ZenGround0

comment created time in 11 hours

issue closedfilecoin-project/specs-actors

WIP Actors v6 plan

This is a work in progress issue that will be edited to incorporate inevitably changing priorities and better information

Changes

Stability

Technical debt Optimizations test-vector format extension for more conformance tests Logging Testing

TODO track concrete issues here, most will be carried over from v5 tracking issue, some still need to be filed

Scalability

Miner state size scaling Scaling market actor to many deals

TODO learn about and design solutions, file issues and track here

Features

FIPs for making the network better that require actors changes

TODO shepherd existing FIPs and propose new ones with highest positive impact. File actors issues and track here.

closed time in 12 hours

ZenGround0
PullRequestReviewEvent

Pull request review commentfilecoin-project/specs-actors

Adding MustGet method to adt.Array in order to simplify code

 func (a *Array) Get(k uint64, out cbor.Unmarshaler) (bool, error) { 	} } +// MustGet retrieves array element into the 'out' unmarshaler, returning an error if it +//  failed to get the element or if it did not find the element in the array.+func (a *Array) MustGet(k uint64, out cbor.Unmarshaler) error {+	if found, err := a.root.Get(a.store.Context(), k, out); err != nil {+		return xerrors.Errorf("failed to get index %v in root %v: %w", k, a.root, err)

nit: idiomatically use type specific printing directive if available. Cids have a String method so %s works for them. You are already doing errors the right way with the w: "failed to get index %d in root %s: %w", k, a.root, err)

laudiacay

comment created time in 17 hours

PullRequestReviewEvent

push eventfilecoin-project/specs-actors

c r

commit sha 1cd48d05294cbc6bafdd5897aee673f377dde4df

changing OnEpochTickEnd to CronTick everywhere (#1522)

view details

push time in 17 hours

PR merged filecoin-project/specs-actors

Changing OnEpochTickEnd to CronTick

This fixes the recommendations in issue #721. This is also a serious confusion I had when first engaging with the code base- I didn’t understand that EpochTick and Cron were necessarily the same thing, until @ZenGround0 said (almost 3 weeks into me working on this code!!) “marketcron” and “powercron”- then everything made sense. I think this naming will help. Unsure if this will also require any documentation updating or FIP action.... but it works.

+28 -28

0 comment

8 changed files

laudiacay

pr closed time in 17 hours

PullRequestReviewEvent

issue closedfilecoin-project/specs-actors

Power.OnEpochTickEnd: preempt Miner queries to Power and Reward actors

Each time the Power actor invokes Miner.ConfirmSectorProofsValid, the Miner makes several queries:

https://github.com/filecoin-project/specs-actors/blob/70a18dfa12d7a0bc7981e73c6021c11d7de14cb3/actors/builtin/miner/miner_actor.go#L613-L619

The Power actor should make these queries as part of its OnEpochTickEnd method, and pass them in as additional parameters.

closed time in a day

wadeAlexC

Pull request review commentfilecoin-project/specs-actors

Actors v7

 import ( func TestParallelMigrationCalls(t *testing.T) { 	// Construct simple prior state tree over a synchronized store 	ctx := context.Background()-	log := nv14.TestLogger{TB: t}+	log := nv15.TestLogger{TB: t} 	bs := ipld2.NewSyncBlockStoreInMemory()-	vm := vm5.NewVMWithSingletons(ctx, t, bs)+	vm := vmtest.NewVMWithSingletons(ctx, t, bs)

nit: vm6 is a little better

arajasek

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedfilecoin-project/specs-actors

Fix PoSt Dispute so snap deals upgrades can't be exploited

PoSt disputing relies on immutable SealedCIDs in sector infos between submission of optimistic window post and dispute but the current snap deals construction mutates this field. The consequence is that the PoSt proof covering the snap deals updated sector can always be successfully disputed until the updated sector is first PoSted with the new SealedCID.

A good way to fix this is to add a snapshot of sector infos to the DeadlineInfo. Then during the dispute this sector info tree is read instead of the current one. This is like the PartitionsSnapshot which exists for the same reason.

The migration should be simple. The v7 deadline struct has a new field and it is populated with whatever the current sector info root from the miner state is. Because SealedCid mutations only happen after the upgrade this should be fine.

created time in 2 days

push eventfilecoin-project/specs-actors

c r

commit sha f1c14076869e7eb413fd3cd320d97c19a2ee5009

fixing 1516 (#1517)

view details

push time in 3 days

PR merged filecoin-project/specs-actors

fixing 1516 (oneliner)

#1516

An error message was left in after another PR, but it shouldn’t have been. I opened vim and went to the line and pressed the D key two times 😅

+0 -1

3 comments

1 changed file

laudiacay

pr closed time in 3 days

PullRequestReviewEvent

pull request commentfilecoin-project/specs-actors

fixing 1516 (oneliner)

Rebase against the next branch. We'll deal with getting changes from master to next after this one.

laudiacay

comment created time in 3 days

issue commentfilecoin-project/specs-actors

Add more logs

Is the "why burn/which sector" already done? I'll look into the third one. Yes, thanks

jennijuju

comment created time in 3 days

issue commentfilecoin-project/specs

Spec update for FIP-0020

The code blocks are automatically updated to the new return value because they link directly to specs-actors master branch, so we don't need to change any specs code. This is a good example of how specs-actors really is "the spec".

jennijuju

comment created time in 3 days

issue commentfilecoin-project/specs

Spec update for FIP 0024

Blocked on #1282

jennijuju

comment created time in 3 days

issue openedfilecoin-project/specs

Add spec section for batch balancer

As a follow on from fip 0013 the spec should be updated with a description of the batch balancer its design and impact on basefee. @zixuanzh is probably the best person to scope this work.

created time in 3 days

issue closedfilecoin-project/specs

Spec update for FIP-0020

https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0020.md

closed time in 3 days

jennijuju

issue commentfilecoin-project/specs

Spec update for FIP-0020

The spec doesn't include any info about the withdraw balance exit code. That is covered in specs-actors (which is part of the spec) so no work needs to be done to update this value.

jennijuju

comment created time in 3 days

push eventfilecoin-project/specs

IPFSUnion

commit sha ec291c066ae7807d6f94ab2d5465b99928157768

change sector fault duration from 14 to 42 (#1280) Co-authored-by: majian <majianzgd@qq.com> Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com>

view details

push time in 3 days

push eventIPFSUnion/specs

Aayush Rajasekaran

commit sha a2ed1fddb4cfe25fef905a39336173307e039a57

Clarify spec in light of FIP-0023 (#1281)

view details

ZenGround0

commit sha 82c8f2746d789c75eddb9b0f264bcd3929b3afa3

Merge branch 'master' into master

view details

push time in 3 days