profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/magik6k/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Łukasz Magiera magik6k @protocol Earth https://magik6k.net Coffee-to-Code Bioreactor

filecoin-project/lotus 1699

Implementation of the Filecoin protocol, written in Go

filecoin-project/FIPs 107

The Filecoin Improvement Proposal repository

filecoin-project/go-jsonrpc 26

Low Boilerplate JSON-RPC 2.0 library

filecoin-project/sector-storage 23

A concrete implementation of the specs-storage interface

Digital-MOB-Filecoin/QABot 14

Quality Bot: Periodically makes storage and retrieval deals with each of the top 100 miners, tracking state & success/fail.

filecoin-project/chain-validation 10

(DEPRECATED) See https://github.com/filecoin-project/test-vectors instead. (was: chain validation tools)

filecoin-project/go-storage-miner 7

A Filecoin storage miner

filecoin-project/storage-fsm 6

A finite state machine used for sector storage

filecoin-project/go-multistore 3

Multistore uses go-datastore and namespaces to simulate having multiple storage instances

PullRequestReviewEvent

push eventfilecoin-project/lotus

Łukasz Magiera

commit sha ef03314c6de9041f771a785a191099415e9ddf04

storagemgr: Cleanup workerLk around worker resources

view details

Łukasz Magiera

commit sha 6df17bceb1908683cb83ee40423ab767a6eb399e

Merge pull request #7334 from filecoin-project/chore/sched-worklk storagemgr: Cleanup workerLk around worker resources

view details

push time in 9 hours

delete branch filecoin-project/lotus

delete branch : chore/sched-worklk

delete time in 9 hours

PR merged filecoin-project/lotus

storagemgr: Cleanup workerLk around worker resources

Mostly just untangling some tech debt to make it easier to add better smarts around starting work.

+10 -12

1 comment

3 changed files

magik6k

pr closed time in 9 hours

push eventfilecoin-project/lotus

Łukasz Magiera

commit sha 438d5ce78e401b36c84dde5662c01268c45f65eb

fix a panic in HandleRecoverDealIDs

view details

Łukasz Magiera

commit sha 45dc9697bfca6fb6a18a07f2aef11d4f1605938c

Merge pull request #7336 from filecoin-project/fix/dealcheck-panic fix a panic in HandleRecoverDealIDs

view details

push time in 9 hours

delete branch filecoin-project/lotus

delete branch : fix/dealcheck-panic

delete time in 9 hours

PR merged filecoin-project/lotus

fix a panic in HandleRecoverDealIDs release/backport

The check below is new, but apparently could cause a panic

+5 -0

1 comment

1 changed file

magik6k

pr closed time in 9 hours

PR opened filecoin-project/lotus

fix a panic in HandleRecoverDealIDs release/backport

The check below is new, but apparently could cause a panic

+5 -0

0 comment

1 changed file

pr created time in a day

create barnchfilecoin-project/lotus

branch : fix/dealcheck-panic

created branch time in a day

PR opened filecoin-project/lotus

sealing: Improve scheduling of ready work

Right now if we have a task which is preparing, another task which is behind it that is ready, and there is nothing currently executing we won't start the ready task even though we could. This PR makes that logic smarter.

Might even work tight now; but still some things remain todo:

  • [ ] Make sure that ready-scheduled tasks are executed in correct order (I think this is fine??)
  • [ ] Ready checks for more task types
  • [ ] Run on a miner for a while
  • [ ] Run on some more miner setups

On top of https://github.com/filecoin-project/lotus/pull/7334

+123 -8

0 comment

3 changed files

pr created time in a day

push eventfilecoin-project/lotus

Łukasz Magiera

commit sha ef03314c6de9041f771a785a191099415e9ddf04

storagemgr: Cleanup workerLk around worker resources

view details

Łukasz Magiera

commit sha 033a9252c6aa9ee13484c9f067195ba1ba288fde

wip improve scheduling of ready work

view details

push time in a day

push eventfilecoin-project/lotus

Łukasz Magiera

commit sha ef03314c6de9041f771a785a191099415e9ddf04

storagemgr: Cleanup workerLk around worker resources

view details

push time in a day

create barnchfilecoin-project/lotus

branch : feat/sched-ready-work

created branch time in a day

PR opened filecoin-project/lotus

storagemgr: Cleanup workerLk around worker resources

Mostly just untangling some tech debt to make it easier to add better smarts around starting work.

+10 -12

0 comment

3 changed files

pr created time in a day

create barnchfilecoin-project/lotus

branch : chore/sched-worklk

created branch time in a day

push eventfilecoin-project/lotus

Mike Greenberg

commit sha b681078b064a8d51abf4c8d70e0472b5a2bf78b1

feat(lotus): Ensure vk and srs keys are checked despite TRUST_PARAMS

view details

Łukasz Magiera

commit sha 4fc78bf72037ada0cb3edd0f551172428ddbc9e8

Merge pull request #7327 from filecoin-project/mg/feat/check-params-on-start fix: Enforce verification key integrity check regardless of TRUST_PARAMS=1

view details

push time in a day

delete branch filecoin-project/lotus

delete branch : mg/feat/check-params-on-start

delete time in a day

PR merged filecoin-project/lotus

fix: Enforce verification key integrity check regardless of TRUST_PARAMS=1

closes #6640

See change in https://github.com/filecoin-project/go-paramfetch/pull/17 for details.

+3 -3

3 comments

2 changed files

placer14

pr closed time in a day

issue closedfilecoin-project/lotus

[BUG] `lotus daemon` should refuse to run unless all verification params are present

Describe the bug

During the recent upgrade a number of folks ended up running their nodes with the new aggregate-proof validation param missing. This led to the formation of an uncomfortably long-lived side-chain.

Since the validation set is really small ( less than 300MiB ), we should just check its presence and integrity on every startup, regardless of TRUST_PARAMS or any other escape hatches.

closed time in a day

ribasushi
PullRequestReviewEvent

PR merged filecoin-project/go-paramfetch

fix: Prefer allowlist for managing trustable extensions

Resolves https://github.com/filecoin-project/go-paramfetch/pull/17/files#r708366414

+2 -6

0 comment

1 changed file

placer14

pr closed time in 2 days

push eventfilecoin-project/go-paramfetch

Mike Greenberg

commit sha 3748acde74754a640f1619fdabf9a0a209ab2fc6

fix: Prefer whitelist for managing trustable extensions

view details

Łukasz Magiera

commit sha 5b8f1a20d18f33476ba8d091405942cd65adf925

Merge pull request #18 from filecoin-project/mg/fix/make-trust-ext-whitelist fix: Prefer allowlist for managing trustable extensions

view details

push time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentfilecoin-project/lotus

fix: Enforce verification key integrity check regardless of TRUST_PARAMS=1

 require ( 	github.com/filecoin-project/go-fil-markets v1.12.0 	github.com/filecoin-project/go-jsonrpc v0.1.4-0.20210217175800-45ea43ac2bec 	github.com/filecoin-project/go-padreader v0.0.0-20210723183308-812a16dc01b1-	github.com/filecoin-project/go-paramfetch v0.0.2-0.20210614165157-25a6c7769498+	github.com/filecoin-project/go-paramfetch v0.0.2-0.20210913223022-0cca2e511a58

Nit: use a tagged version

placer14

comment created time in 2 days

PullRequestReviewEvent

push eventfilecoin-project/go-paramfetch

Mike Greenberg

commit sha 0cca2e511a586cb38d88b241691277ffd70fa748

fix: Force VK integrity check regardless of TRUST_PARAMS

view details

Mike Greenberg

commit sha d6035d86eb36a410630d9b60e95d02151945981b

fix: Include SRS files as untrustable

view details

Łukasz Magiera

commit sha 001fff2d68ec010bfadab33dc3786244315ca0c4

Merge pull request #17 from filecoin-project/mg/fix/always-check-verification-keys fix: Force VK integrity check regardless of TRUST_PARAMS

view details

push time in 2 days

PR merged filecoin-project/go-paramfetch

fix: Force VK integrity check regardless of TRUST_PARAMS

part of https://github.com/filecoin-project/lotus/issues/6640

The intention of this change is to ensure that the verification keys are always checked regardless of the state of TRUST_PARAMS to ensure that miners are building on blocks which have been properly verified.

I have also reviewed the logic and don't believe there are pre-mature exits are possible without errors being checked for and should ensure that every entry within paramBytes will be considered at least once and ensure ALL verification keys will be (1) present and (2) have the correct SHA digest. This should satify the requirements of #6640.

+44 -1

0 comment

2 changed files

placer14

pr closed time in 2 days

Pull request review commentfilecoin-project/go-paramfetch

fix: Force VK integrity check regardless of TRUST_PARAMS

 func TestGetParamsParallel(t *testing.T) { 	} 	wg.Wait() }++func TestCheckFileIgnoresNonVKExtension(t *testing.T) {+	const mockParamInfoBytes = `{+			"cid": "Qmxxxxxdoesntexist",+			"digest": "0e0958009936b9d5e515ec97b8cb792d",+			"sector_size": 2048+	}`+	var mockParamInfo paramFile+	if err := json.Unmarshal([]byte(mockParamInfoBytes), &mockParamInfo); err != nil {+		require.NoError(t, err)+	}+	ft := &fetch{}++	err := os.Setenv("TRUST_PARAMS", "1")+	require.NoError(t, err)+	defer func() {+		err := os.Unsetenv("TRUST_PARAMS")+		assert.NoError(t, err)+	}()

should be fine

placer14

comment created time in 2 days

PullRequestReviewEvent