profile
viewpoint
Peng Lyu rebornix Microsoft Seattle https://rebornix.com @Microsoft developer on Visual Studio Code

octref/polacode 5965

📸 Polaroid for your code

auchenberg/vscode-browser-preview 4169

A real browser preview inside your editor that you can debug.

Chillee/VSCodeNeovim 328

A rewrite of VSCodeVim, backed by neovim. Still in development, not meant for use.

microsoft/vscode-sublime-keybindings 195

Sublime Text Keymap extension for VS Code

microsoft/vscode-atom-keybindings 116

Port of Atom Keybindings for VS Code.

rebornix/DotBadge 18

C# port of Shields-style badge library.

rebornix/debugger.html 5

The Firefox debugger that works anywhere :boom:

rebornix/docker-guillotine-sample 3

Docker sample for guillotine, which is currently used by GitHub to shorten URLs

Chillee/Vim 2

:shipit: Vim for Visual Studio Code

issue commentmicrosoft/vscode

ANSI color code in Notebook cell output inadvertently switches to HTML output

Since you are VS Code stable, the jupyter notebook experience is provided by the Python extension so please file issue there.

/extPython

brandon-rhodes

comment created time in 6 hours

issue commentmicrosoft/vscode

Double pasting in a webview with latest insiders

@akbaryahya what you shared above looks bad, thanks for the video, it helps me understand it better. Are you seeing this in latest Insiders all the time? For example, can you reproduce this issue by "F1 -> Reload Window" and then copy/paste immediately?

rchiodo

comment created time in 6 hours

pull request commentmicrosoft/vscode

refactor find widget to support multiple selection find/replace

@jodyheavener thanks for your contribution, the code is great!

jodyheavener

comment created time in 6 hours

PR merged microsoft/vscode

refactor find widget to support multiple selection find/replace

Closes #21792

👋 This PR updates the find widget to support find/replace within multiple selections, where currently only whole-document or a single selection is permitted. The updated widget maintains existing functionality and supports all search options with its new functionality, such as case matching and regular expressions.

Here's a link (.mov) to a video with a full demonstration.

+246 -96

2 comments

11 changed files

jodyheavener

pr closed time in 6 hours

issue closedmicrosoft/vscode

Support find/replace in selection for multiple cursor selections

  • VSCode Version: 1.9.1
  • OS Version: Windows 10

Steps to Reproduce:

  1. Make a multi-cursor selection using Shift + Alt + Left click
  2. Find in selection button is greyed out

example

closed time in 6 hours

Jazcash

push eventmicrosoft/vscode

Jody Heavener

commit sha b9efdab4831b6b69c13e4b15b55d519c65d0e2d4

refactor find widget to support multiple selection find/replace

view details

rebornix

commit sha 1bea03865a7a24e32ca0b7d030656294f0ccbcfa

Merge remote-tracking branch 'origin/master' into pr/jodyheavener/98884

view details

rebornix

commit sha 846dde8de0c9e89da1eade2c8323b7cee13233d5

add more tests.

view details

rebornix

commit sha b1715492030a6849b387b9a8471e4f90e6dfef6f

Merge remote-tracking branch 'origin/master' into rebornix/editor-find-multiple-select

view details

push time in 6 hours

create barnchmicrosoft/vscode

branch : rebornix/editor-find-multiple-select

created branch time in 6 hours

issue commentmicrosoft/vscode

Notebook: clear outputs side effects

@jrieken, @roblourens and me discussed about above challenges and one outcome is we should try to make the metadata minimal and see if it's possible to move execution status related things out of the metadata and merge with outputs as they are all coming from execution.

For example, firstly we move the execution related ones out

export interface NotebookCellMetadata {
	contentEditable?: boolean;
	runnable?: boolean;
	hasExecutionOrder?: boolean;
	breakpointMargin?: boolean;
	inputCollapsed?: boolean;
	outputCollapsed?: boolean;
	custom?: { [key: string]: any };
}

interface IExecutionState {
	executionOrder?: number;
	statusMessage?: string;
	runState?: NotebookCellRunState;
	runStartTime?: number;
	lastRunDuration?: number;
}

and then have a new property for execution results

export interface NotebookCell {
	readonly notebook: NotebookDocument;
	readonly uri: Uri;
	readonly cellKind: CellKind;
	readonly document: TextDocument;
	language: string;
	executionResult: {
		state: IExecutionState;
		outputs: Output[];
	} | undefined;
	metadata: NotebookCellMetadata;
}

The core action "Clear Outputs" will clear the whole executionResult.

No matter which approach we take, the "Clear Outputs" action is opinionated , we may want to explore approaches that allow extensions to control the behavior.

rebornix

comment created time in 10 hours

issue commentmicrosoft/vscode

Add "reason" field to onDidChangeCellOutputs

We can merge it with https://github.com/microsoft/vscode/issues/103713

roblourens

comment created time in 10 hours

IssuesEvent

issue commentmicrosoft/vscode

Editor jumps to random line when clicking into it

@toh-ableton sounds reasonable to me.

toh-ableton

comment created time in 12 hours

issue commentmicrosoft/vscode

Cannot copy code from notebook cell into a script file

Based the reproduce steps, it's a duplicate of https://github.com/microsoft/vscode/issues/102736 (and tracking issue https://github.com/microsoft/vscode-python/issues/11796 in the Python extension). It's already fixed in Insiders and will be available in next stable release.

Dr-Irv

comment created time in 12 hours

issue commentmicrosoft/vscode-python

In a notebook (.ipynb file) paste double pastes.

Can anyone try the latest Insiders (built yesterday) https://code.visualstudio.com/insiders/ and see if you still see such problem? It's going to be the stable release so want to confirm that the problems you are seeing here are resolved.

ddouglas87

comment created time in 12 hours

issue commentmicrosoft/vscode

Double pasting in a webview with latest insiders

This bug still occurs in version (windows 1.48.0-insider) insiders but only happens if you "select text and right click then copy and paste" when I use keyboard "ctrl+c then ctrl+v" it doesn't duplicate, hmm that's quite strange?

@akbaryahya can you elaborate more on this one? How do you "right click then copy and paste"? Currently I'm not seeing any context menu when right click in a python notebook.

rchiodo

comment created time in 13 hours

issue commentmicrosoft/vscode

Can't replace spaces in "selection only"

I'm not able to reproduce this issue, can you help confirm whether it works or not if you toggle the Find In Selection mode with mouse? A screen recording can help troubleshoot.

tifDev

comment created time in a day

issue commentmicrosoft/vscode

Disable Auto Searching while typing

@ultraGentle is kind, it's simply me lost in my tasks and forgot about this issue. Thank you for @ultraGentle 's contribution, the PR is great and merged into master. Later this week it will be shipped in Insiders, and you can set editor.find.cursorMoveOnType to false to turn it off.

KeyC0de

comment created time in a day

pull request commentmicrosoft/vscode

Adds setting to disable cursor movement while typing into Find Widget

Thanks @ultraGentle for your contribution! I tweaked the code a bit and merged into master, should be available in Insiders later this week.

ultraGentle

comment created time in a day

push eventmicrosoft/vscode

rebornix

commit sha 9bd54c15ae0c2017f4ea251e9eb9a88fb38d62c9

:lipstick:

view details

push time in a day

push eventmicrosoft/vscode

Ted Goldman

commit sha b6c9110de28592d3eacb6b6745aa226bdd80e369

format for upstream

view details

Ted Goldman

commit sha 91c1a43f07ec4e42bde51545fc0f40c6684aef04

debounced Find Widget, preventing cursor movement until typing is finished

view details

rebornix

commit sha aa5df52266f4f344d6cca32cf4dde579859624f5

Merge remote-tracking branch 'origin/master' into pr/ultraGentle/94825-6

view details

rebornix

commit sha 5fb45aaf1993cb280465a4f5dcac4436bb2f8fce

cursorMove.

view details

Peng Lyu

commit sha c95626acd0a737d15053bbfc81ae7e794c45348f

Merge pull request #94825 from ultraGentle/master Adds setting to disable cursor movement while typing into Find Widget

view details

push time in a day

PR merged microsoft/vscode

Reviewers
Adds setting to disable cursor movement while typing into Find Widget

This PR fixes #60977 and fixes #70306, both related to disorienting or disruptive cursor movement related to the Find Widget.

Description:

  • Adds a boolean setting to turn cursor movement on/off while typing into the Find Widget.
  • Default is true (on), which results in the current behavior.
  • False (off) results in highlighting-only on type, preventing the undesired/unexpected cursor movement described in 60977 and 70306. Jumping to the next match happens on Enter or on click the prev/next arrows in the widget.

Discussion:

  • The VSC team suggestion was to name the setting "searchOnType," however there is already a setting with that name. I chose "moveOnType."
  • Personally, I would reverse the defaults and simply note the option to switch back in "What's New," but I can understand not wanting to confuse existing users.
  • The VSC team suggested that the setting have three options: off | highlight | move. However, when I tested off, the behavior was just confusing, because it seemed like the Find Widget wasn't doing anything at all. Also, from searching related issues on GitHub, I haven't seen anyone asking for the "off" behavior. I thought it better not to overengineer a confusing 3rd setting that no one asked for.

Further improvements:

  • 70306 is only fixed when the new setting is activated (i.e. false). It could be addressed separately, but there is already a workaround discussed in that thread, and for anyone who doesn't want to do that, there is the option provided by this PR.
  • For this setting to be more easily discovered, I would suggest adding the words "jump" and "scroll" to the description, because those were what folks used when describing the issue (so that's probably what others would search for).

Any feedback is welcome, and I am happy for you to revise as you see fit.
Thanks for considering!

+16 -1

14 comments

3 changed files

ultraGentle

pr closed time in a day

issue closedmicrosoft/vscode

Editor jumps to random line when clicking into it

Issue Type: <b>Bug</b>

  1. Open a repo in VS Code.
  2. "Find in Files" for some string.
  3. Click on a search result so it opens in a new editor window.
  4. Click on a line of code in this new editor window.

Expected results: The cursor is where I clicked. The window never scrolls anywhere.

Actual results: Often enough to be annoying, but not reliably enough to describe it, the editor scrolls to a random location in the file.

I'm sorry that I can't give you more details, but this bug is EXTREMELY annoying. If I could ask for a single thing in VS Code, it would be that you drop everything else you're working on and fix this bug. VS Code is a fantastic product, and I'm sure you have lots of ideas how to make it even better. But for my daily work, the one thing that I need is this bugfix.

VS Code version: Code 1.32.0 (507312a3e3b34b084b467dfd983263bc7c9d87e0, 2019-03-06T18:52:50.880Z) OS version: Darwin x64 18.5.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Xeon(R) W-2191B CPU @ 2.30GHz (36 x 2300)
GPU Status 2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: enabled<br>rasterization: enabled<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled
Load (avg) 1, 2, 2
Memory (System) 32.00GB (2.80GB free)
Process Argv
Screen Reader no
VM 0%

</details><details><summary>Extensions (5)</summary>

Extension Author (truncated) Version
gitlens eam 9.5.1
python ms- 2019.2.5558
cpptools ms- 0.21.0
vsliveshare ms- 0.3.1284
vscode-capnp xmo 1.0.0

</details> <!-- generated by issue reporter -->

closed time in a day

toh-ableton

issue closedmicrosoft/vscode

Disable Auto Searching while typing

Is there a way to disable automatic searching? I work in a 40k+ line document daily and searching through it constantly while typing (going up, down and all around) is a mess. I want Visual Studio Code to start searching only when I press enter/return on the keyboard and quit searching while I am typing what I want to search for! Where is this feature? Thanks in advance.

closed time in a day

KeyC0de

push eventultraGentle/vscode

Daniel Imms

commit sha e9bb126adfa00961008f64267f598bd059695367

Remove eslint disable rule from terminal Part of #101978

view details

Johannes Rieken

commit sha 8f19ff42af714288fe07f421f76960a72d96395c

extract extHost.common.services and have node- and worker-services for specifics

view details

João Moreno

commit sha 5ab5f9662fffff4c43fa903be662c63799b534c7

editor option: overflowWidgetsDomNode

view details

Benjamin Pasero

commit sha 7d8d31a3487cbe6a3cf57282f42a00d2f0b887f8

debt - a few more action2 usages

view details

Martin Aeschlimann

commit sha 33b51eb210d2ae1c67721df3cd5d1ab4b6a6da17

scope inspector: semantic color rules from settings not correctly shown

view details

Martin Aeschlimann

commit sha 9b1773e0135f6e9a1396ddb824d26e0de6a6f689

emmet serverless

view details

Matt Bierner

commit sha a1967ddf135fdcc7ebfef3775bcd83d20dc4ef4f

Remove eslint disable For #101978

view details

Robo

commit sha 9a220aa3b31343b88c0b0cc0fb31ecc30b7fd875

feat: enable sandbox for proxy auth window (#100907) * feat: enable sandbox for proxy auth window * webContents.send uses structured clone algorithm * mv electron-browser/auth.* => electron-sandbox

view details

rebornix

commit sha 3ace0229577acf18512119dfbc7f1c3ece73d438

fix #101937. update theme colors when theme switches.

view details

rebornix

commit sha 92b250837af92195ddfb12088930492ff774d3a8

%s/override/overwrite

view details

rebornix

commit sha dab68ed88523db7e7161f69da791b8c7e87c99c8

add options support in notebook find widget.

view details

Aditya Thakral

commit sha 124cb3e03628b3f4eb0c4135abceb90c61dda3c5

Add navigation role to settings-toc-wrapper (#101966)

view details

SteVen Batten

commit sha 182db07de2745fe3a6369f4ad80ae930e006a99b

fixes #95418 activitybar treated as unit for kb nav

view details

Rob Lourens

commit sha 79fa27d2bd09eaa5b1c6598e0dba0e1b6040914e

Fix bad cell layout after "toggle word wrap" Fix #101940

view details

rebornix

commit sha fcfb0dd32e54f00316ebbcec3ad7527fa73834ee

notebookCellListFocus

view details

rebornix

commit sha 2d5148e73425a6a15b7cc7db04a1e3b2138f9afb

fix #101602. Select text in find input when opening the find widget

view details

rebornix

commit sha c2e6ca623372faca990ca72a97be4cfc1eb449d3

fix #102019.

view details

rebornix

commit sha 7223877c7243c89fcdea3b58450b74c4ba8b4506

:lipstick:

view details

rebornix

commit sha 9df3fcdfa35cc2bac2f2339a581ce548baea605f

use ref when dealing with cell text model.

view details

rebornix

commit sha 6c67fecb32d3bf19ec2aa94db52c9734bd3ae162

:guard: test for join cells.

view details

push time in a day

issue commentmicrosoft/vscode

Cannot Copy Text from HTML Output - Native Notebook Editor

I am on windows.

@claudiaregio thanks for helping figure out the root cause :)

claudiaregio

comment created time in a day

push eventmicrosoft/vscode

rebornix

commit sha 4e18099869e9641dca2974993925aa4d1580bf71

fix #104095. Register undo/redo/copy implementation for windows & linux.

view details

push time in a day

issue closedmicrosoft/vscode

Cannot Copy Text from HTML Output - Native Notebook Editor

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

Cannot copy text from HTML output

Steps to Reproduce:

  1. print any data frame in output (HTML)
  2. try to copy an element from the table and paste in another cell

closed time in a day

claudiaregio

delete branch microsoft/vscode-simple-jupyter-notebook

delete branch : rebornix/adopt-kernel-provider

delete time in a day

push eventmicrosoft/vscode-simple-jupyter-notebook

rebornix

commit sha 90d0ef7536401a5830c5806c5615805f6daca842

update kernel provider.

view details

rebornix

commit sha 9688a9a25a0601b8fc23265b3c58486b1ccf6ae8

resolve comments.

view details

Peng Lyu

commit sha 9333c41425091f519f9dacd95e1e8b433434e5e1

Merge pull request #3 from microsoft/rebornix/adopt-kernel-provider Notebook API update: kernel provider support

view details

push time in a day

PR merged microsoft/vscode-simple-jupyter-notebook

Notebook API update: kernel provider support

This PR updated the notebook proposed api and adopted the new kernel provider and replaced the custom kernel picker. Major changes:

  • Adopt registerNotebookKernelProvider
  • Adopt execution cancellation API

I tested that the kernel selection work as expected but I can't get xeus debugging to work (running a cell is fine, but breakpoint not hit). @connor4312 any idea?

+443 -283

0 comment

6 changed files

rebornix

pr closed time in a day

push eventmicrosoft/vscode-simple-jupyter-notebook

rebornix

commit sha 9688a9a25a0601b8fc23265b3c58486b1ccf6ae8

resolve comments.

view details

push time in a day

issue commentmicrosoft/vscode

Notebook execution hangs even after output completes

The next Insiders from master will have logging for execution and metadata change. Once that's out, @misolori can you set the Developer Log Lever to Debug and then try to reproduce? Once you reproduce the issue, you can share the logs from Output (Window) and then we can troubleshoot.

misolori

comment created time in a day

push eventmicrosoft/vscode

rebornix

commit sha 03467e96ff0d8a00f0ae90017e7f3f14bda27126

re #104262. Add logging for notebook.

view details

rebornix

commit sha 391bca591eda22ce9daead3ca9e8838715335891

re #104262. add log for execution and cancel.

view details

push time in a day

issue closedmicrosoft/vscode

Drag folded cells + undo, redo

Aug-07-2020 10-54-13

  • Follow the steps for the first item in https://github.com/microsoft/vscode/issues/99882
  • Drag the cell under 2, it works
  • Undo, it's correct
  • Redo, now cells are out of order

closed time in a day

roblourens

push eventmicrosoft/vscode

rebornix

commit sha be8947b92d40fa963507c45870328538da39537f

inspect layout

view details

rebornix

commit sha 5cadd5477e047f318f5effbf4c7e25661f35a40f

wrong preview rendering after drag and drop

view details

rebornix

commit sha 9294fd5b944bd37635bc4588b0cf9ac670f582a2

support move multiple cells.

view details

rebornix

commit sha 5e697b348c0336d11a64ce0440aed6c40b104f1c

fix #104397.

view details

push time in a day

issue commentmicrosoft/vscode

Drag folded cells + undo, redo

Fixed via bdfef57b0a02f046c1cd713126f7641a053a3c21

roblourens

comment created time in a day

issue openedmicrosoft/vscode

DND markdown cell to the end of document miss layout

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version:
  • OS Version:

Steps to Reproduce:

  1. Create 6 cells, markdown, code, markdown, code, markdown, code.
  2. Fold the first markdown cell
  3. Drag it to the end of the document
  4. The markdown cell is not layout correctly

dnd-miss-layout

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No

created time in a day

issue commentmicrosoft/vscode

Cannot copy code from notebook cell into a script file

/extPython

Dr-Irv

comment created time in a day

issue closedmicrosoft/vscode

Notebook: markdown cell height not updated correctly

Issue Type: <b>Bug</b>

  • Create two markdown cell and one code cell
    • md ## header 1
    • code repo:microsoft/vscode
    • md ## header 2
  • Collapse the first markdown cell
  • Drag the first markdown cell to the bottom of the document
  • The space between the first cell (## header 2) and the second (## header 1) is way too large

The height of the first list item is larger than the view layout info (get it by Inspect Notebook Layout).

VS Code version: Code - Insiders 1.48.0-insider (2277c8e2a3e1cc630a6397301ba54a1dccd8a60d, 2020-08-07T11:30:13.206Z) OS version: Darwin x64 19.5.0

<!-- generated by issue reporter -->

closed time in a day

rebornix

issue commentmicrosoft/vscode

Notebook: markdown cell height not updated correctly

can't reproduce any more '(

rebornix

comment created time in a day

push eventmicrosoft/vscode

rebornix

commit sha dbdb5bdac6aeeffd23e69bb32b92e1f2bc692ee0

drop below folded markdown cell.

view details

push time in a day

issue commentmicrosoft/vscode

annoying automatic text replacer

@vammex can you confirm if @gjsjohnmurray 's suggestion helps?

vammex

comment created time in 2 days

push eventmicrosoft/vscode-docs

rebornix

commit sha 8813077a9c5e5eab7afa6fa4294a2b845b19d4cb

notebook

view details

push time in 4 days

issue openedmicrosoft/vscode

Notebook: markdown cell height not updated correctly

Issue Type: <b>Bug</b>

  • Create two markdown cell and one code cell
    • md ## header 1
    • code repo:microsoft/vscode
    • md ## header 2
  • Collapse the first markdown cell
  • Drag the first markdown cell to the bottom of the document
  • The space between the first cell (## header 2) and the second (## header 1) is way too large

The height of the first list item is larger than the view layout info (get it by Inspect Notebook Layout).

VS Code version: Code - Insiders 1.48.0-insider (2277c8e2a3e1cc630a6397301ba54a1dccd8a60d, 2020-08-07T11:30:13.206Z) OS version: Darwin x64 19.5.0

<!-- generated by issue reporter -->

created time in 4 days

issue commentmicrosoft/vscode

Notebook execution hangs even after output completes

Considering that the reproduce steps include "run all cells and then clear all output", I think it might be the Python extension not handling the token cancellation well. cc @DonJayamanne

misolori

comment created time in 4 days

push eventmicrosoft/vscode

rebornix

commit sha 58d5e0cad9c99aea892a024a246d522c080a5493

fix #104176. more editing metadata protection.

view details

rebornix

commit sha 65804aeed73f57f9c322812f76eecd8c54a050b4

fix #104170. update layout with preset dimension if it exists.

view details

rebornix

commit sha 0625bc304db589efb62a0bcdc1007187762c7b34

fix #104196. detached overflow widget.

view details

rebornix

commit sha 11c0b607856f5bc5c43c55811b7d96b58ca75a8a

re #104196. bring back list 3d transform.

view details

push time in 4 days

issue closedmicrosoft/vscode

Add Code cell action cropped

See attached screen shot.

capture

The Notebook is already scrolled all the way to the bottom

closed time in 4 days

dbaeumer

issue closedmicrosoft/vscode

Readonly notebooks allow copying and pasting of cells

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.48.0-insider
  • OS Version: Darwin x64 19.6.0 Commit: cfbd1999769f4f08dce29629fb92fdc0fac53829 Date: 2020-08-06T05:40:40.871Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0

Steps to Reproduce:

1.Open a Notebook 2.Ensure the notebook is not editable (notebook and cells all have editable metadata set to false) 3. Cells cannot be added, deleted, edited 4. Copy and cell and paste (it will now insert a new cell below the copied cell)

Found that following three keyboard shortcuts result in notebook being edited:

  • Cut
  • Copy + Paste
  • Undo

@rebornix /cc

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No

closed time in 4 days

DonJayamanne

push eventmicrosoft/vscode

rebornix

commit sha 8ddb5d25e44447092ce9e439919997fca13c4ce0

bump version

view details

push time in 4 days

create barnchmicrosoft/vscode

branch : release/1.48

created branch time in 4 days

IssuesEvent

issue commentmicrosoft/vscode-remote-release

No file based recommendation when workspace extension is installed locally

I'm still not seeing the recommendation, if that's what I should test.

chrmarti

comment created time in 4 days

issue closedmicrosoft/vscode

Integration tests fail but mocha never returns

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=82590&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=f58c00c4-bf13-5e9c-4e42-b9695c0a283b

closed time in 4 days

joaomoreno

issue commentmicrosoft/vscode

Integration tests fail but mocha never returns

The timeout is due to the first failure of the notebook integration test: notebook workflow document runnable metadata is respected.

Verifier, please test:

  • Create a GitHub issue notebook
  • Create a code cell
  • Type in $, the execution button should be visible
  • Continue typing $a=123, the execution button should be gone
joaomoreno

comment created time in 4 days

issue closedmicrosoft/vscode

Test failure: notebook workflow notebook join cells

  1. notebook workflow notebook join cells:

    AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=81396&view=logs&j=800c766b-cf7f-545c-6b0a-ae5b31f2fdcf&t=51b4207b-308f-5f00-05c4-35120a101a46&l=94

closed time in 4 days

bpasero

issue commentmicrosoft/vscode

Test failure: notebook workflow notebook join cells

Verifier:

  • Create a new GitHub issue notebook
  • Create two code cells, first one abc, second one def
  • Join these two cells (Notebook: Join with next/previous cell)
  • Verify if the new cell content is abc\ndef.
bpasero

comment created time in 4 days

PR opened microsoft/vscode-simple-jupyter-notebook

Notebook API update: kernel provider support

This PR updated the notebook proposed api and adopted the new kernel provider and replaced the custom kernel picker. Major changes:

  • Adopt registerNotebookKernelProvider
  • Adopt execution cancellation API

I tested that the kernel selection work as expected but I can't get xeus debugging to work (running a cell is fine, but breakpoint not hit). @connor4312 any idea?

+436 -271

0 comment

5 changed files

pr created time in 5 days

issue closedmicrosoft/vscode

IsPreferred Kernel should be selected one in quickpick

Testing #103883

Is it possible to have the currently active, preferred kernel also show up as the first one or the highlighted one in the quick pick?

recording (3)

closed time in 5 days

sana-ajani

push eventmicrosoft/vscode

rebornix

commit sha 164733eae1620abf250fbb17693e505e95c6b240

fix #104015.

view details

push time in 5 days

issue commentmicrosoft/vscode

Editor: Allow overflowing widgets to be rooted at an external DOM node

@joaomoreno yes sir, I'll adopt this in Notebook next week. Thanks for the new option, it will make the notebook scroll faster.

joaomoreno

comment created time in 5 days

issue openedmicrosoft/vscode

Notebook: adopt overflowWidgetsDomNode for editors

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

Re https://github.com/microsoft/vscode/issues/101128, by moving the editor overflow elements to be out of the notebook cell list view can allow

  • transformOptimization in list view
  • avoid overflow/layer cutoff for editor content widgets.

created time in 5 days

issue commentmicrosoft/vscode

Persist SCM view state when switching between files across different repos

@joaomoreno yes, the proposal looks great to me.

rebornix

comment created time in 5 days

issue commentmicrosoft/vscode

Allow notebook cells that are grouped to be moved together

Since DND is complicated, request @roblourens for verification.

misolori

comment created time in 5 days

issue commentmicrosoft/vscode

Allow notebook cells that are grouped to be moved together

Fixing it the third time. cc @roblourens , apparently I didn't handle the drag direction/point well.

There are four scenarios, say we have 7 cells:

code 0
markdown header 1
code 1
markdown header 2
code 2
markdown header 3
code 3

Scenario 1

  1. Fold Header 1
  2. Drag Header 1
  3. Drop it below Code cell 2, but make sure the cursor is on the bottom half of Code cell 2

dnd-1

Scenario 2

  1. Fold Header 1
  2. Drag Header 1
  3. Drop it above Markdown Header 3, but make sure the cursor is not on Code cell 2

dnd-2

Scenario 3

  1. Fold Header 2
  2. Drag Header 2
  3. Drop it above Markdown Header 1, but make sure the cursor is not on Code cell 0

dnd-3

Scenario 3

  1. Fold Header 2
  2. Drag Header 2
  3. Drop it below Code cell 0, but make sure the cursor is on the bottom half of Code cell 0

dnd-4

misolori

comment created time in 5 days

push eventmicrosoft/vscode

rebornix

commit sha ae56913bf9cf4c9eb744b7d977f1d39facdf5fd6

fix #99882. handle dragging position.

view details

push time in 5 days

issue closedmicrosoft/vscode

Allow notebook cells that are grouped to be moved together

This came up in our user study of the GitHub Issues Notebook where multiple users expected that moving a header cell, with grouped cells underneath, would move all cells. Users also attempted to collapse the header and then try moving that but it only moved the single header

  1. Create a notebook with two headings and nested code cells image
  2. Collapse one heading and attempt to move image
  3. :bug: Only a single cell is moved image

A few ideas that @kieferrm I discussed was to allow moving grouped cells when they are collapsed (Colab does this), and also provide a keyboard shortcut for moving cells when they are expanded. If we move grouped cells by default we run into issues where easily moving a single markdown cell may not be possible.

closed time in 5 days

misolori

issue commentmicrosoft/vscode

Allow notebook cells that are grouped to be moved together

Kapture 2020-08-06 at 11 18 05

doesn't seem to reproduce in latest Insiders

misolori

comment created time in 5 days

issue commentmicrosoft/vscode

Unexpected text copied after switching output mimetype

@bamurtaugh can you confirm if you are still seeing this issue in latest Insiders?

bamurtaugh

comment created time in 5 days

issue commentmicrosoft/vscode

Clickable area to expand should go across entire cell

image

The border made me think it's clickable/actionable.

connor4312

comment created time in 5 days

issue commentmicrosoft/vscode

Bottom border of collapsed cell looks messy

IMHO the bottom border for the collapsed outputs is not intuitive. I'm wondering if we can show a gray italic text "collapsed outputs" cc @misolori ?

connor4312

comment created time in 5 days

issue commentmicrosoft/vscode

Cannot Copy Text from HTML Output - Native Notebook Editor

@claudiaregio thanks, can you please run "Toggle Screencast Mode" and record again? Similar to below

copy

It would also be better if you can share the test file.

claudiaregio

comment created time in 5 days

issue commentmicrosoft/vscode

Cannot Copy Text from HTML Output - Native Notebook Editor

@claudiaregio

I fixed yesterday so it should be in today's Insiders. @claudiaregio can you provide screen recordings to help troubleshoot?

We need recording of "Copied element from HTML output and tried to paste in new cell - failed and pasted code of cell. We had the exact same behavior in the QP." instead of above recording, which indicates the copy/paste is working as expected.

claudiaregio

comment created time in 5 days

issue commentmicrosoft/vscode

Add Code cell action cropped

Based on the results from Inspect Notebook Layout, the height for every cell is calculated correctly (comparing the good one and bad one), but it seems the list view height is miscalculated.

dbaeumer

comment created time in 5 days

push eventmicrosoft/vscode

rebornix

commit sha ec1f0e3277f5fb382b63b5b79324d33fb4cf9b4a

fix #104176.

view details

push time in 5 days

issue closedmicrosoft/vscode

Readonly notebooks allow copying and pasting of cells

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.48.0-insider
  • OS Version: Darwin x64 19.6.0 Commit: cfbd1999769f4f08dce29629fb92fdc0fac53829 Date: 2020-08-06T05:40:40.871Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0

Steps to Reproduce:

1.Open a Notebook 2.Ensure the notebook is not editable (notebook and cells all have editable metadata set to false) 3. Cells cannot be added, deleted, edited 4. Copy and cell and paste (it will now insert a new cell below the copied cell)

Found that following three keyboard shortcuts result in notebook being edited:

  • Cut
  • Copy + Paste
  • Undo

@rebornix /cc

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No

closed time in 5 days

DonJayamanne

issue commentmicrosoft/vscode

Layout breaks on next execution after clearing a collapsed cell output

Similar bug https://github.com/microsoft/vscode/issues/104110 , which we somehow displays the output even if the cell is hidden. We need a better APIs in BacklayerWebview.

connor4312

comment created time in 6 days

push eventmicrosoft/vscode

rebornix

commit sha c74b0c2ae435e6c0d7e6b15f83ea2591ac3db17e

fix #104110.

view details

push time in 6 days

issue closedmicrosoft/vscode

Notebook layout issue when collapsing and adding cells

Kapture 2020-08-05 at 13 28 39

Steps to Reproduce:

  1. Create two sets of a markdown heading with a code cell + output
  2. Collapse first set of cells
  3. Add new cell above collapsed cell
  4. :bug: layout breaks

sample-notebook.zip

closed time in 6 days

misolori

issue closedmicrosoft/vscode

Execution Count Not Always Updated - Native Notebook Editor

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

Users during Python Extension Native Notebooks QP were running cells and the execution count was not being updated. Brackets remained empty with no number.

closed time in 6 days

claudiaregio

issue commentmicrosoft/vscode

Execution Count Not Always Updated - Native Notebook Editor

Shared the same root cause as https://github.com/microsoft/vscode/issues/103892 .

claudiaregio

comment created time in 6 days

issue commentmicrosoft/vscode

Execution Count/Green Check - Native Notebook Editor

The python extension is listening to cell outputs change event and when it's empty, it clears the execution count

Call stack:

t.updateCellModelWithChangesToVSCCell = function(e, t) {
            switch (e.type) {
            case "changeCellOutputs":
                return function(e, t) {
                    if (!e.cells.every(e=>0 === e.outputs.length))
                        return !1;
                    return e.cells.forEach(e=>{
                        e.metadata.runState !== l.NotebookCellRunState.Running && (e.metadata.runState = void 0,
                        e.metadata.executionOrder = void 0),
                        e.metadata.statusMessage = void 0,
                        e.metadata.lastRunDuration = void 0,
                        e.metadata.runStartTime = void 0;
                        const n = a.findMappedNotebookCellModel(e, t.cells)
                          , r = e.metadata.runState !== l.NotebookCellRunState.Running;
                        t.clearCellOutput(n, r),
                        c.updateVSCNotebookCellMetadata(e.metadata, n)
                    }
                    ),
                    !0
                }(e, t);

cc @DonJayamanne

claudiaregio

comment created time in 6 days

issue commentmicrosoft/vscode

Allow notebook cells that are grouped to be moved together

Verifiers, please test both drag cells upwards and downwards.

misolori

comment created time in 6 days

push eventmicrosoft/vscode

rebornix

commit sha f5e60cb0f92833c34f5b6acabf5237758b9769a6

fix #99882.

view details

push time in 6 days

issue closedmicrosoft/vscode

Allow notebook cells that are grouped to be moved together

This came up in our user study of the GitHub Issues Notebook where multiple users expected that moving a header cell, with grouped cells underneath, would move all cells. Users also attempted to collapse the header and then try moving that but it only moved the single header

  1. Create a notebook with two headings and nested code cells image
  2. Collapse one heading and attempt to move image
  3. :bug: Only a single cell is moved image

A few ideas that @kieferrm I discussed was to allow moving grouped cells when they are collapsed (Colab does this), and also provide a keyboard shortcut for moving cells when they are expanded. If we move grouped cells by default we run into issues where easily moving a single markdown cell may not be possible.

closed time in 6 days

misolori

issue commentmicrosoft/vscode

Cannot Copy Text from HTML Output - Native Notebook Editor

I fixed yesterday so it should be in today's Insiders. @claudiaregio can you provide screen recordings to help troubleshoot?

claudiaregio

comment created time in 6 days

issue commentmicrosoft/vscode

Notebook delete cell action should be at the end

We can experiment moving it into the context menu. It scarifies a bit usability for mouse users but it's much less possible to misclick.

misolori

comment created time in 6 days

issue closedmicrosoft/vscode

Test taskDefinition when property

Refs: https://github.com/microsoft/vscode/issues/102477

  • [x] macOS @JacksonKearl
  • [x] linux @weinand
  • [x] windows @rebornix

Complexity: 4

Create Issue


The task definition contribution point now has a when property that allows entire task types to be removed from all task entry points:

    "taskDefinitions": [
      {
        "type": "typescript",
        "required": [
          "tsconfig"
        ],
        "properties": {
          "tsconfig": {
            "type": "string",
            "description": "%taskDefinition.tsconfig.description%"
          },
          "option": {
            "type": "string"
          }
        },
        "when": "shellExecutionTasksSupported"
      }
    ],

There are three suggested values to use with the when property: shellExecutionSupported, processExecutionSupported, and customExecutionSupported. You can start with the task provider sample, or with the one of the built in task providing extension, such as npm.

Verify:

  • That shellExecutionSupported and processExecutionSupported cause the task type to only be available when shell and process are supported.
  • That setting the when property to another context value works
  • That, by default, a task definition without a when is available.
  • That the json description for the when property makes sense.

closed time in 6 days

alexr00

issue openedmicrosoft/vscode

No suggestion for taskDefinition when property

Testing #103835

There is no auto completion for when property.

created time in 6 days

startedsbatten/vscode-theme-builder

started time in 6 days

issue closedmicrosoft/vscode

Dragging group above a title hides the title

Testing https://github.com/microsoft/vscode/issues/99882

Video: https://memes.peet.io/img/20-08-b280da55-dc5b-44f8-b291-c61341541957.webm

  1. Have two groups of titles/content, A and B
  2. Collapse A and drag it above B
  3. B expands and breaks 🐛

closed time in 6 days

connor4312

issue commentmicrosoft/vscode

Dragging group above a title hides the title

fixed via https://github.com/microsoft/vscode/commit/408ad5d67dcc050ec13b2e02cd9a6735a3bbd3d4

connor4312

comment created time in 6 days

issue closedmicrosoft/vscode

Notebook layout issue when collapsing and moving cells

Kapture 2020-08-05 at 13 31 47

Steps to Reproduce:

  1. Fold a cell with a nested code + output
  2. Move cell above another section
  3. :bug: When cell is moved, it is expanded and layout issues appear

closed time in 6 days

misolori

issue commentmicrosoft/vscode

Notebook layout issue when collapsing and moving cells

Already fixed via https://github.com/microsoft/vscode/commit/408ad5d67dcc050ec13b2e02cd9a6735a3bbd3d4

misolori

comment created time in 6 days

issue closedmicrosoft/vscode

Test: Authentication providers - consumer API

Refs: https://github.com/microsoft/vscode/issues/100993

  • [x] macOS @sandy081
  • [x] linux @9at8
  • [x] windows @bamurtaugh
  • [x] windows @eamodio

Complexity: 4

Create Issue


In this iteration, part of the authentication API has been moved to stable, allowing extensions to consume GitHub and Microsoft authentication.

Please test that

  • The API itself is clear, comments are readable and contain enough information, and names make sense.
  • getSession behaves as expected with different options passed into it.
  • Calling getSession causes the authentication provider to activate if it has not done so already; there shouldn't be any issues with accessing a session immediately on startup.
  • onDidChangeSessions is fired on login and logout

closed time in 6 days

RMacfarlane

push eventmicrosoft/vscode

rebornix

commit sha 408ad5d67dcc050ec13b2e02cd9a6735a3bbd3d4

fix #104102.

view details

rebornix

commit sha 3f84c8772e2835957aadc740b7eeece036afa503

move inspect notebook layout into developer category

view details

push time in 6 days

issue closedmicrosoft/vscode

Layout issues with dragging folded cells with outputs

  • Open a github issues notebook
  • Have two markdown header cells at the same or different levels
  • Put a code cell under the second markdown cell, execute it
  • Collapse the second markdown cell
  • Drag it above the first one
  • It becomes expanded with a bad layout

image

closed time in 6 days

roblourens

issue commentmicrosoft/vscode

Layout issues with dragging folded cells with outputs

This is a regression, let's get it fixed this month.

roblourens

comment created time in 6 days

issue commentmicrosoft/vscode

Cell `...` actions should always be available on right click

@roblourens sounds good to me.

joaomoreno

comment created time in 6 days

issue commentmicrosoft/vscode

Cannot Copy Text from HTML Output - Native Notebook Editor

@misolori I saw you played with data frames recently, can you reproduce this issue? I'm not able to reproduce.

claudiaregio

comment created time in 6 days

push eventmicrosoft/vscode

rebornix

commit sha fa9d5f17240251fe74c8d1707fc30b90dba4a827

fix #103993.

view details

push time in 6 days

more