profile
viewpoint

connor4312/cockatiel 912

A resilience and transient-fault-handling library that allows developers to express policies such as Backoff, Retry, Circuit Breaker, Timeout, Bulkhead Isolation, and Fallback. Inspired by .NET Polly.

connor4312/blake3 73

BLAKE3 hashing for JavaScript: native Node bindings (where available) and WebAssembly

connor4312/-sv 3

👏 separated values

Antariano/sputnik 2

node.js and mandrill powered subscription / email manager.

connor4312/bin-vcs 2

Experimental + WIP: version control for binary files with a git-like CLI

connor4312/chromehash 2

A Rust/WebAssembly implementation of the Chrome content hashing algorithm

connor4312/backer 1

GPL Node.js-powered backup daemon.

connor4312/brototype 1

Bro, do you even?

issue openedmicrosoft/vscode-js-debug

Adopt --inspect-publish-uid=http to hide debug spam

Requires at least node 12, and will fail to run on builds lower than that. See: https://github.com/nodejs/node/issues/12665#issuecomment-654770495

created time in 15 minutes

issue commentconnor4312/cockatiel

[Question] Cancel a retry policy

Not right now. Something I've been meaning to do has been allowing you to pass a cancellation token through IPolicy.execute. I'll add that tonight.

conradob

comment created time in an hour

issue commentmicrosoft/vscode

source maps for webpack bundles stop working after a hot rebuild

Okay, thanks for the steps! Before I dive into this more, can you see if this works if you set debug.javascript.usePreview: true? That will use our new debugger, which has different sourcemap handling and will become the default debugger in the upcoming release.

hedgepigdaniel

comment created time in an hour

issue commentmicrosoft/vscode-pull-request-github

Unhandled promise rejection from "has no Github remotes" when in subdirectory

I have two remotes -- one for a pull request from a contributor, and the origin

PS C:\Users\Connor\Documents\Github\vscode-js-debug> git remote show
cbmd
origin
PS C:\Users\Connor\Documents\Github\vscode-js-debug> git remote show origin
* remote origin
  Fetch URL: git@github.com:microsoft/vscode-pwa.git
  Push  URL: git@github.com:microsoft/vscode-pwa.git
connor4312

comment created time in an hour

issue commentmicrosoft/vscode-js-debug

Breakpoints appear to be on wrong lines

If your 1.46 install has a nightly or recent stable version of js-debug, it will have gotten the fix already 🙂

cnshenj

comment created time in 18 hours

IssuesEvent

issue commentmicrosoft/vscode-remote-release

Starting a container from a folder that has spaces in its path fails

I was able to reproduce this on Windows today. This was the full output:

[23 ms] Start: Resolving remote
[26 ms] Setting up container for folder or workspace: e:\Downloads\pot,ato

[136 ms] Start: Run: git rev-parse --show-toplevel
[216 ms] Start: Check Docker is running
[216 ms] Start: Run: docker info
[577 ms] Start: Run: docker ps -q -a --filter label=vsch.local.folder=e:\Downloads\pot,ato --filter label=vsch.quality=insider
[713 ms] Start: Run: docker build -f e:\Downloads\pot,ato\.devcontainer\Dockerfile -t vsc-potato-725b6328c2b39b1e6ab6b24c3cf5df86 --build-arg VARIANT=3.12 e:\Downloads\pot,ato\.devcontainer
Sending build context to Docker daemon  4.608kB
Step 1/2 : ARG VARIANT="3.12"
Step 2/2 : FROM mcr.microsoft.com/vscode/devcontainers/base:0-alpine-${VARIANT}
 ---> 4db1b133e7a2
Successfully built 4db1b133e7a2
Successfully tagged vsc-potato-725b6328c2b39b1e6ab6b24c3cf5df86:latest
SECURITY WARNING: You are building a Docker image from Windows against a non-Win
dows Docker host. All files and directories added to build context will have '-r
wxr-xr-x' permissions. It is recommended to double check and reset permissions f
or sensitive files and directories.
[1112 ms] Start: Run: docker events --format {{json .}} --filter status=start
[1128 ms] Start: Starting container
[1128 ms] Start: Run: docker run -a STDOUT -a STDERR --mount type=bind,"source=e:\Downloads\pot,ato","target=/workspaces/pot,ato",consistency=cached -l vsch.quality=insider -l vsch.remote.devPort=0 -l vsch.local.folder=e:\Downloads\pot,ato --entrypoint /bin/sh vsc-potato-725b6328c2b39b1e6ab6b24c3cf5df86 -c echo Container started ; trap "exit 0" 15; while sleep 1 & wait $!; do :; done
C:\Program Files\Docker\Docker\resources\bin\docker.exe: Error response from dae
mon: status code not OK but 500: {"Message":"Unhandled exception: Filesharing ha
s been cancelled","StackTrace":"   at Docker.ApiServices.Mounting.FileSharing.<D
oShareAsync>d__6.MoveNext() in C:\\workspaces\\stable-2.3.x\\src\\github.com\\do
cker\\pinata\\win\\src\\Docker.ApiServices\\Mounting\\FileSharing.cs:line 0\r\n-
-- End of stack trace from previous location where exception was thrown ---\r\n
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at Sys
tem.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
(Task task)\r\n   at Docker.ApiServices.Mounting.FileSharing.<ShareAsync>d__4.Mo
veNext() in C:\\workspaces\\stable-2.3.x\\src\\github.com\\docker\\pinata\\win\\
src\\Docker.ApiServices\\Mounting\\FileSharing.cs:line 47\r\n--- End of stack tr
ace from previous location where exception was thrown ---\r\n   at System.Runtim
e.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.Compil
erServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n
at Docker.HttpApi.Controllers.FilesharingController.<ShareDirectory>d__2.MoveNex
t() in C:\\workspaces\\stable-2.3.x\\src\\github.com\\docker\\pinata\\win\\src\\
Docker.HttpApi\\Controllers\\FilesharingController.cs:line 21\r\n--- End of stac
k trace from previous location where exception was thrown ---\r\n   at System.Ru
ntime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.Co
mpilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\
n   at System.Threading.Tasks.TaskHelpersExtensions.<CastToObject>d__1`1.MoveNex
t()\r\n--- End of stack trace from previous location where exception was thrown
---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n
  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNoti
fication(Task task)\r\n   at System.Web.Http.Controllers.ApiControllerActionInvo
ker.<InvokeActionAsyncCore>d__1.MoveNext()\r\n--- End of stack trace from previo
us location where exception was thrown ---\r\n   at System.Runtime.ExceptionServ
ices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.Task
Awaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.H
ttp.Controllers.ActionFilterResult.<ExecuteAsync>d__5.MoveNext()\r\n--- End of s
tack trace from previous location where exception was thrown ---\r\n   at System
.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime
.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
\r\n   at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__15.M
oveNext()"}.
See 'C:\Program Files\Docker\Docker\resources\bin\docker.exe run --help'.
[1412 ms] Start: Run: docker ps -q -a --filter label=vsch.local.folder=e:\Downloads\pot,ato --filter label=vsch.quality=insider
[1554 ms] Command failed: docker run -a STDOUT -a STDERR --mount type=bind,"source=e:\Downloads\pot,ato","target=/workspaces/pot,ato",consistency=cached -l vsch.quality=insider -l vsch.remote.devPort=0 -l vsch.local.folder=e:\Downloads\pot,ato --entrypoint /bin/sh vsc-potato-725b6328c2b39b1e6ab6b24c3cf5df86 -c echo Container started ; trap "exit 0" 15; while sleep 1 & wait $!; do :; done
drorata

comment created time in 18 hours

IssuesEvent

issue commentmicrosoft/vscode

Creating an untitled paw draw file will not open the paw draw editor

reopening due to -found tag

rchiodo

comment created time in 18 hours

issue openedmicrosoft/vscode-pull-request-github

Unhandled promise rejection from "has no Github remotes" when in subdirectory

<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Use Help > Report Issue to prefill these. -->

  • Extension version:
  • VSCode Version:
  • OS:
  1. Have a Git folder cloned (with remotes)
  2. Open one of its subdirectories in VS Code
  3. Observe this error in the extension host:
rejected promise not handled within 1 second: Error: file:///c%3A/Users/Connor/Documents/Github/vscode-js-debug has no GitHub remotes
extensionHostProcess.js:976
stack trace: Error: file:///c%3A/Users/Connor/Documents/Github/vscode-js-debug has no GitHub remotes
	at S.<anonymous> (c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:127867)
	at Generator.next (<anonymous>)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:104763
	at new Promise (<anonymous>)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:104511
	at S.getOrigin (c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:127792)
	at Object.<anonymous> (c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1249810)
	at Generator.next (<anonymous>)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1248712
	at new Promise (<anonymous>)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1248460
	at Object.getCurrentUserLogin (c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1249739)
	at Object.<anonymous> (c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1249527)
	at Generator.next (<anonymous>)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1248712
	at new Promise (<anonymous>)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1248460
	at Object.notifySuggestedAccounts (c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1249475)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:1248988
	at l.fire (c:\Users\Connor\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:45:801)
	at c:\Users\Connor\.vscode-insiders\extensions\github.vscode-pull-request-github-insiders-2020.7.8134\media\extension.js:1:114159
	at runMicrotasks (<anonymous>)
	at processTicksAndRejections (internal/process/task_queues.js:85:5)

In this case I opened demos/node within that repository. I do have remotes on that repo.

It doesn't look like this breaks anything obviously, the pull requests and issues view still works. Kind of annoying though 😛

created time in 18 hours

issue commentmicrosoft/vscode

Allow extensions to contribute links to the terminal (aka link providers)

  • The new API could provide the ability to cleanly have multiple actions for a single link. For example, being able to debug a URL via ctrl+click is a nice default, but I could provide a second link for the same text range to open a URL without debugging.
  • :+1: on returning a promise from handleTerminalLink

Because of the change to endIndex being inclusive (breaking) I won't push this to js-debug yet, but you can see my implementation here: https://github.com/microsoft/vscode-js-debug/compare/update-terminal-link-api

Tyriar

comment created time in 19 hours

create barnchmicrosoft/vscode-js-debug

branch : update-terminal-link-api

created branch time in 19 hours

issue commentnodejs/node

Allow to suppress --inspect hint

@jasnell that's the problem -- we'd like the ability to not show that hint.

segrey

comment created time in 19 hours

issue commentmicrosoft/vscode-js-debug

Error: Cannot find module '"/Applications/Visual' when launching `pwa-node` with `npm`

Verification steps:

  1. Use Node 10. nvm or a dev container would work well
  2. Have a launch config as linked where the runtimeExecutable is set to npm, yarn, or pnpm
  3. Verify that you can successfully run and debug scripts
Kristof-Mattei

comment created time in 21 hours

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 5542d20ccf86163e780e7ed19cb1706b53bef3cf

chore: move options to a separate document

view details

Connor Peet

commit sha 543c982ca9de9f9391cc5463065fa329312de3a4

fix: disconnect requiring multiple clicks on pages with nested targets Fixes #557

view details

push time in 21 hours

issue closedmicrosoft/vscode-js-debug

Disconnect needs two clicks

Version: 1.47.0-insider (user setup) Commit: 04545fa88043fd10d1f3edefd26be1b8245b516f Date: 2020-07-02T05:48:37.715Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.19041

Have the following launch config:

{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "pwa-msedge",
            "request": "attach",
            "port": 9222,
            "name": "Attach Edge",
            "targetSelection": "pick",
            "trace": true,
            "urlFilter": "*",
            "webRoot": "${workspaceFolder}"
        }
    ]
}
  • Run Edge with "C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe" --remote-debugging-port=9222
  • open www.spiegel.de
  • run the launch config, pick the page, see that the Call Stack view gets pupullated
  • nagvigate on the page, see that the Call Stack has nodes added
  • click on the disconnect button on the Attach Edge node in the call stack view
  • theAttach Edge node is still there

Also tried with ms-vscode.js-debug-nightly v2020.7.117.

recording (4)

closed time in 21 hours

aeschli

issue commentmicrosoft/vscode

Breakpoints not applied if Node.js project contains inaccessible subdirectory

Thanks for the issue! Fixed in the latest nightly build.

wooque

comment created time in 21 hours

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha eaf08368d9fd7ffb8f08fd8a6da13ad9dd2a3124

fix: handle errors if reading bp directories fail Fixes https://github.com/microsoft/vscode/issues/100018

view details

push time in 21 hours

issue closedmicrosoft/vscode

Breakpoints not applied if Node.js project contains inaccessible subdirectory

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.46.0
  • OS Version: Arch Linux

Steps to Reproduce:

  1. Create dir inside Node.js project with sudo mkdir data && sudo chmod 700 data
  2. Try to add breakpoint to any js file

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

closed time in 21 hours

wooque

delete branch microsoft/vscode-js-debug

delete branch : johnemau/wv-test

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix/bp-races

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix/more-line

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fixPackaging

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/build-vsix

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/browser-multi-attach

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/break-on-load

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/node-e2e-tests

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/formatting

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/continue-on-attach

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix/integrated-terminal-first-launch

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : roblou/fixJunitReporter

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/restart-strategies

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : refactor/remote-chrome

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/guess-outfiles

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : refactor/split-edge-config

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : roblou/tests3

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/await-scripts

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix/bp-in-external

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix/lazy-sm

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : refactor/remove-default-offset

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : webview-debugging

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix_angular

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix/unicode-url-regex

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : cra-auto-launch

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : chore/telemetry-exception-prefixes

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : acorn-parser

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/multi-target-debugging

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : candidate/2020.4.2918

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/open-profile-untitled

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : profiling-breakpoints

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/better-attach-cwd

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : feat/verbose-async-scope-error

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : fix/worker-sessions

delete time in a day

delete branch microsoft/vscode-js-debug

delete branch : test-fixes

delete time in a day

issue commentmicrosoft/vscode-js-debug

Disconnect needs two clicks

Man, that's an ugly call stack!

Thanks for the issue. This is an artifact of compact sessions, I think I was just not able to reproduce it at the time since there were a couple in-flight changes in compaction, but I can do so easily for now.

aeschli

comment created time in a day

delete branch microsoft/vscode-js-debug

delete branch : configurableTimeouts

delete time in a day

push eventmicrosoft/vscode-js-debug

digeff

commit sha a76e01eba1b04312e6d1eaa0a4a0daffa70c0254

Now we can configure the timeouts used for waiting for source-maps

view details

digeff

commit sha 9a253075fc6ae88a4765195b8a77351d3f4aa8e7

Update src/adapter/sources.ts Co-authored-by: Connor Peet <connor@peet.io>

view details

digeff

commit sha a4ebce455ef808ba47943aa431a3610c138e71dd

Update src/adapter/threads.ts Co-authored-by: Connor Peet <connor@peet.io>

view details

digeff

commit sha 16b40e4849040cba2e17d5447145a4b68d543c12

Applied feedback

view details

digeff

commit sha 7038954c1d64b929d835d002495193097aace864

Change variable name

view details

digeff

commit sha eec523787fbeb57fcb982fbb22f723eadc515ea8

Change variable name

view details

Connor Peet

commit sha 9454538730bb32980ff0160e2045c317f72b9297

Now we can configure the timeouts used for waiting for source-maps (#549) * Now we can configure the timeouts used for waiting for source-maps * Update src/adapter/sources.ts Co-authored-by: Connor Peet <connor@peet.io> * Update src/adapter/threads.ts Co-authored-by: Connor Peet <connor@peet.io> * Applied feedback * Change variable name * Change variable name Co-authored-by: Connor Peet <connor@peet.io>

view details

push time in a day

PR merged microsoft/vscode-js-debug

Now we can configure the timeouts used for waiting for source-maps

In VS we were not hitting breakpoints because the 1 sec source-map timeout wasn't enough for the source-maps to be processed.

Added the "cumulative extra timeout" concept, to address this up to 10 seconds. Also made it configurable if it's not enough for all users.

+113 -27

0 comment

8 changed files

digeff

pr closed time in a day

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha d97316f687d163093b9a60f6dae903a6f31d3a8f

fix: don't enable stop profiling when not profiling Fixes #101686

view details

push time in a day

issue commentmicrosoft/vscode-hexeditor

Feature Request: Help. How to integrate this into a debugger

I think the best solution here would be to have some custom bits in the debug adapter to, for example:

  1. Have some "inspect memory" registered for your debug adapter that command that copies the relevant portions of memory to the file. (Or toggles copying, if you wanted it on each step)
  2. Uses the vscode.open API to open the hex editor / default binary editor on that file
  3. If you want to allow editing, watch for when that file is saved to update memory.

With a little more work, you can avoid the filesystem by creating a virtual document (which allows read-only documents) or your own filesystem provider.

This can be accomplished by sending your own custom DAP messages, via the DebugSession.customRequest message / vscode.debug.onDidReceiveDebugSessionCustomEvent.

cc @lramos15

haneefdm

comment created time in a day

issue commentmicrosoft/vscode-chrome-debug

Cannot set breakponint in remote development env (create app using create-react-app)

Thanks for the email, @ThomasCorbin22. It looks like you need to configure your localRoot and remoteRoot. Eyeballing what you have, something like this:

"localRoot": "${workspaceFolder}",
"remoteRoot": "/mnt/c/Users/Thomas/Documents/Personal/Projects/Xccelerate/thomas.corbin/exercises/54-router-debugger/ab",
```

This is needed to be able to convert the paths from 
dev-techmoe

comment created time in a day

issue closedmicrosoft/vscode

Gtihub issues notebooks never open

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

Version: 1.47.0-insider (user setup)
Commit: 04545fa88043fd10d1f3edefd26be1b8245b516f
Date: 2020-07-02T05:48:37.715Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Github issues notebook v0.0.33

Recently I've noticed that a most of the time issue notebooks never load. I'm not sure if this is an issue with vscode or the notebook, no errors in the debug console. If I reload the window with a notebook open it will print an error that "Workbench did not finish loading in 10 seconds". I notice that if I do this it seems that other things don't activate, e.g. there's no problems action in the status bar.

Steps to Reproduce:

  1. Try to open a .github-issues notebook

Does this issue occur when all extensions are disabled?: N/A

Peng requested a --prof-startup: prof-a314.txt

closed time in a day

connor4312

issue commentmicrosoft/vscode

Gtihub issues notebooks never open

It seems to work today, so I'm unable to reproduce it to get more information. Maybe there was a bad build. I will reopen if I run into it again.

connor4312

comment created time in a day

issue commentmicrosoft/vscode-chrome-debug

Cannot set breakponint in remote development env (create app using create-react-app)

This works for me with the new js debugger (e.g. on Insiders). @ThomasCorbin22 can you add trace: true to your launch configuration and share the resulting log with us? The location of the log file on your disk will be written to the Debug Console.

⚠️ This log file will not contain source code, but will contain file paths. You can drop it into https://microsoft.github.io/vscode-pwa-analyzer/index.html to see what it contains. If you'd rather not share the log publicly, you can email it to connor@xbox.com

dev-techmoe

comment created time in a day

issue commentmicrosoft/vscode

Debugging breaks on first line of code

In the log you sent it doesn't looks like the debugger stopped anywhere. Do you still have that issue?

vainamov

comment created time in a day

issue commentmicrosoft/vscode

There's a gap in issue hovers where the hover disappears

May be related to having a high-dpi display on Windows specifically?

connor4312

comment created time in a day

push eventmicrosoft/vscode-docs

Connor Peet

commit sha cbf211363635fdff01e7a6c7169e732e173c3fb1

add js-debug for 1.47

view details

push time in 2 days

issue openedmicrosoft/vscode

Setting sync "too many requests"

Issue Type: <b>Bug</b>

I got the 'too many requests' error from setting sync in what I think is a fairly normal workflow:

  1. Searched for an extension
  2. Installed it in my remote
  3. Used the "add to recommended extensions (workspace) folder"
  4. Reloaded the window
  5. Received the error that settings sync made too many requests

Here's the log from the last several minutes:

<details> <pre> [2020-07-05 15:11:15.451] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:11:16.144] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:11:16.144] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:11:16.151] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:11:16.154] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:11:16.224] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:11:16.224] [userDataSync] [info] Sync done. Took 101ms [2020-07-05 15:12:54.678] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:12:55.052] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:12:55.052] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:12:55.059] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:12:55.063] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:12:55.172] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:12:55.172] [userDataSync] [info] Sync done. Took 152ms [2020-07-05 15:17:55.173] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:17:55.931] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:17:55.931] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:17:55.939] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:17:55.943] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:17:56.016] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:17:56.016] [userDataSync] [info] Sync done. Took 110ms [2020-07-05 15:22:56.017] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:22:56.863] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:22:56.863] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:22:56.871] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:22:56.874] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:22:56.945] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:22:56.945] [userDataSync] [info] Sync done. Took 103ms [2020-07-05 15:27:56.946] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:27:57.774] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:27:57.774] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:27:57.782] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:27:57.786] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:27:57.876] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:27:57.876] [userDataSync] [info] Sync done. Took 125ms [2020-07-05 15:30:59.654] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:00.460] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:00.460] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:00.468] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:00.471] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:31:00.562] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:00.562] [userDataSync] [info] Sync done. Took 127ms [2020-07-05 15:31:22.564] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:22.939] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:22.939] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:22.948] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:24.192] [userDataSync] [info] GlobalState: Updated remote ui state [2020-07-05 15:31:24.201] [userDataSync] [info] GlobalState: Updated last synchronized ui state [2020-07-05 15:31:24.294] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:24.294] [userDataSync] [info] Sync done. Took 1379ms [2020-07-05 15:31:24.294] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:24.668] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:24.668] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:24.675] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:24.678] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:31:24.741] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:24.741] [userDataSync] [info] Sync done. Took 88ms [2020-07-05 15:31:38.282] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:38.654] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:38.654] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:38.662] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:39.850] [userDataSync] [info] GlobalState: Updated remote ui state [2020-07-05 15:31:39.857] [userDataSync] [info] GlobalState: Updated last synchronized ui state [2020-07-05 15:31:39.925] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:39.925] [userDataSync] [info] Sync done. Took 1299ms [2020-07-05 15:31:50.058] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:50.506] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:50.506] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:50.516] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:50.521] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:31:50.588] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:50.588] [userDataSync] [info] Sync done. Took 97ms [2020-07-05 15:32:03.477] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:32:03.988] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:32:03.988] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:32:03.995] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:32:05.158] [userDataSync] [info] GlobalState: Updated remote ui state [2020-07-05 15:32:05.173] [userDataSync] [info] GlobalState: Updated last synchronized ui state [2020-07-05 15:32:05.266] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:32:05.266] [userDataSync] [info] Sync done. Took 1305ms [2020-07-05 15:32:05.266] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:32:05.785] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:32:05.785] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:32:05.791] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:32:05.795] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:32:05.865] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:32:05.865] [userDataSync] [info] Sync done. Took 96ms [2020-07-05 15:32:10.460] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:32:10.844] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:32:10.844] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:32:10.852] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:32:11.076] [userDataSync] [error] RemoteTooManyRequests (UserDataSyncError) : POST request 'https://vscode-sync.trafficmanager.net/v1/resource/globalState' failed because of too many requests (429). at S.request (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:528:815) at async S.write (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:525:84) at async e.updateRemoteUserData (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:436:214) at async e.applyPreview (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:454:478) at async e.doSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:432:852) at async e.performSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:432:8) at async e.sync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:430:431) at async w.doSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:517:206) at async y.doSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:511:638) [2020-07-05 15:32:11.076] [userDataSync] [info] Auto Sync: Disabled because sync is disabled [2020-07-05 15:32:11.077] [userDataSync] [info] Auto sync: Canelled sync that is in progress [2020-07-05 15:32:11.077] [userDataSync] [info] Auto Sync: Stopped [2020-07-05 15:32:11.083] [userDataSync] [info] Did reset the local sync state. [2020-07-05 15:32:11.083] [userDataSync] [info] Auto Sync: Turned off sync because of making too many requests to server </pre> </details>

VS Code version: Code - Insiders 1.47.0-insider (04545fa88043fd10d1f3edefd26be1b8245b516f, 2020-07-02T05:48:37.715Z) OS version: Windows_NT x64 10.0.18363 Remote OS version: Linux x64 4.19.76-linuxkit

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 31.96GB (15.54GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote Dev Container: Wordpress
OS Linux x64 4.19.76-linuxkit
CPUs Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (2 x 3407)
Memory (System) 1.94GB (0.30GB free)
VM 0%

</details> <!-- generated by issue reporter -->

created time in 2 days

issue commentmicrosoft/vscode-js-debug

Console logs occasionally skipped before shutdown

Update on this since there have been a few duplicates: we now use the behavior of the previous debug adapter where we stringify simple messages directly, so those should not be missed. However, if a message includes complex data that we need to send as variables, we can still hit the scenario I described in the linked issue.

JacksonKearl

comment created time in 2 days

issue commentmicrosoft/vscode

Debug doesn't wait until the process ends

Thanks for the issue, this duplicates https://github.com/microsoft/vscode-js-debug/issues/161

JonaVDM

comment created time in 2 days

issue openedIBM/plex

Add SCSS variables to control included fonts

This is a great font!

I'd like to include it in an Electron app. This means bundling the fonts. Unfortunately, the nice way to import fonts is to go through the @ibm/plex/scss/ibm-plex.scss, which will cause every font to be bundled, which has a pretty heavy disk size. There are nested files, but for example I can't import the "light" base font without also importing cyrillic fonts, which I don't need at the moment. And since I'm targeting Electron, I know I don't need .woff fonts, only woff2.

Of course, I could write create webpack rules that stubs the files I don't need via the null-loader, but a more graceful way would be appreciated 🙂

It would be cool if the imported files were configurable via variables. For example, I could say:

$font-formats: woff2; // only import woff2
$font-weights: bold, regular;
$font-sets: base, latin1, latin2;

created time in 2 days

issue commentadazzle/react-data-grid

Problem with Optional chaining and Next.js

I'm also running into this on the latest Canary. I believe Storybook does some magic with passing everything through Babel. However, in general I would not expect that I have to use Babel at runtime to load dependencies -- I've built dozens of apps and never needed to do so 🙂

Downgrading to Canary 16 resolved this.

beegweeg

comment created time in 4 days

issue commentmicrosoft/vscode

pwa-node type in launch.json stopped working on OSX

Thanks, this was reported in https://github.com/microsoft/vscode-js-debug/issues/543. This will be fixed in the next vscode release, or you can grab the latest nightly version.

Zophiel

comment created time in 4 days

issue commentmicrosoft/vscode-js-debug

Persist detached or un-picked tabs

  1. Connect to a browser with multiple tabs open matching your URL filter
  2. Click the disconnect button on the (sub-)sessions for one of the tabs
  3. That tab should be disconnected from. If you navigate the tab, it should not reconnect.
connor4312

comment created time in 4 days

issue closedmicrosoft/vscode-js-debug

Error in the js-debug bootloader

The following error occured during debugging a typescript app:

Debugger attached.
Error in the js-debug bootloader, please report to https://aka.ms/js-dbg-issue: Error [ERR_INSPECTOR_ALREADY_ACTIVATED]: Inspector is already activated. Close it with inspector.close() before activating it again.
    at Object.inspectorOpen [as open] (inspector.js:137:11)
    at /opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js:1:84007
    at /opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js:1:84034
    at Object.<anonymous> (/opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js:1:84330)
    at n (/opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js:1:110)
    at /opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js:1:902
    at Object.<anonymous> (/opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js:1:912)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
/opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js:1
Could not read source map for file:///home/xxx/src/yyy/node_modules/typescript/lib/typescript.js: ENOENT: no such file or directory, open '/home/xxx/src/yyy/node_modules/typescript/lib/typescript.js.map'

Launch config related part:

    {
      "type": "node",
      "request": "launch",
      "name": "scrape ts",
      "cwd": "${workspaceFolder}",
      "args": ["--last", "10"], 
      "runtimeArgs": ["-r", "ts-node/register"],
			"protocol": "inspector",
			"internalConsoleOptions": "openOnSessionStart",
    }

The debugging working despite the mentioned error message.

closed time in 4 days

beci

issue commentmicrosoft/vscode-js-debug

Error in the js-debug bootloader

Thanks, duplicates https://github.com/microsoft/vscode-js-debug/issues/552 and is fixed in yesterday's nightly/build 1.47.2.

beci

comment created time in 4 days

Pull request review commentveler/PaZword

Fixed a vulnerability in the encryption service.

 public async Task<(bool updated, UserDataBundle userDataBundle)> MigrateUserData         /// </summary>         private UserDataBundle Load(string encryptedData)         {-            string jsonData = _encryptionProvider.DecryptString(encryptedData);+            int lastColonPosition = encryptedData.LastIndexOf(':');+            string jsonData = _encryptionProvider.DecryptString(encryptedData.Substring(lastColonPosition + 1));             return _serializationProvider.DeserializeObject<UserDataBundle>(jsonData);         } +        /// <summary>+        /// Migrates from version 1 to 2.+        /// </summary>+        private async Task<UserDataBundle> UpgradeToVersion2Async(string encryptedData)+        {+            // Version 1 can be loaded as version 2.+            // The difference between 1 and 2 is a vulnerability in the encryption engine.+            // To fix it, the data should be decrypted and re-encrypted.+            _logger.LogEvent(Version1ToVersion2EventName, string.Empty);+            const int oldVersion = 1;+            const int newVersion = 2;++            string jsonData = _encryptionProvider.DecryptString(encryptedData);+            UserDataBundle userDataBundle = _serializationProvider.DeserializeObject<UserDataBundle>(jsonData);++            var tasks = new List<Task>();+            for (int i = 0; i < userDataBundle.Accounts.Count; i++)+            {+                Account account = userDataBundle.Accounts[i];+                for (int j = 0; j < account.Data.Count; j++)+                {+                    AccountData accountData = account.Data[j];+                    if (accountData is IUpgradableAccountData upgradableAccountData)+                    {+                        tasks.Add(upgradableAccountData.UpgradeAsync(oldVersion, newVersion));

Don't know if it's a concern here, but if you wanted to limit concurrency, TPL dataflow is a very nice but surprisingly little-known library https://docs.microsoft.com/en-us/dotnet/standard/parallel-programming/dataflow-task-parallel-library

veler

comment created time in 4 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha b4cd3552637f3814d940d2078c31a9b849e37e6c

docs: add issue templates

view details

push time in 5 days

issue commentmicrosoft/vscode-js-debug

[ERR_INSPECTOR_ALREADY_ACTIVATED] Error when start debugging

To verify:

  • Use the very latest Node 14 version
  • Try to debug any Node script through any method.
Hacksign

comment created time in 5 days

issue commentmicrosoft/vscode-js-debug

pwa-node truncates the repl result for strings

We also now bumped it to 100k characters (in case anyone else lands on this issue). But yes it sounds like the clipboard context will do what you want.

hediet

comment created time in 5 days

issue commentmicrosoft/vscode-js-debug

Closing only tabs prevents subsequent browser launches

Via chat:

Do you think that instead of making it the default to close the whole browser, we should make it the default only if a port is not specified?

I would rather not take this approach since that is kind of surprising to an end user who doesn't know how internals work -- that setting a port would toggle the cleanup behavior.

Maybe one approach here would be to keep track of the browser process internally until it closes, even if we aren't attached to it right now, so that we can reattach in the future. Or open the browser in a different user data dir if we detect (not sure how that detection would work) that another browser is currently running on the given data dir.

connor4312

comment created time in 5 days

issue closedmicrosoft/vscode-js-debug

Persist detached or un-picked tabs

We allow picking as of https://github.com/microsoft/vscode-js-debug/issues/437 and #479. However if a target then changes its info, we'll attach to that (if it matches the URL filter). We should remember the 'banned' tabs and never attach to them.

closed time in 5 days

connor4312

issue commentmicrosoft/vscode-js-debug

Persist detached or un-picked tabs

Re-closing for verification since your issue is different. But please do open a separate issue with your launch config. Thanks!

connor4312

comment created time in 5 days

push eventmicrosoft/vscode

Connor Peet

commit sha e38c2d293da8f435d408afaf7f35a20cf3a10d30

debug: final js-debug update for 1.47

view details

push time in 5 days

created tagmicrosoft/vscode-js-debug

tagv1.47.2

The upcoming VS Code JavaScript debugger

created time in 5 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 3e0548b9041017285468777db0c2eec631b98163

1.47.2

view details

push time in 5 days

Pull request review commentmicrosoft/vscode-js-debug

Now we can configure the timeouts used for waiting for source-maps

 export class Thread implements IVariableStoreDelegate {    */   async _handleSourceMapPause(scriptId: string, brokenOn: Cdp.Debugger.Location): Promise<boolean> {     this._pausedForSourceMapScriptId = scriptId;-    const timeout = this._sourceContainer.sourceMapTimeouts().scriptPaused;+    const perScriptTimeout = this._sourceContainer.sourceMapTimeouts().scriptPaused;+    const timeout =+      perScriptTimeout + this._sourceContainer.sourceMapTimeouts().extraCumulativeScriptPaused;+     const script = this._sourceContainer.scriptsById.get(scriptId);     if (!script) {       this._pausedForSourceMapScriptId = undefined;       return false;     } +    const timer = new HrTime();     const result = await Promise.race([       this._getOrStartLoadingSourceMaps(script, brokenOn),       delay(timeout),     ]);++    const wallClockTimeBlockedInMs = timer.elapsed().ms;+    const remainingExtraCumulativeScriptPaused =+      this._sourceContainer.sourceMapTimeouts().extraCumulativeScriptPaused -+      Math.max(wallClockTimeBlockedInMs - perScriptTimeout, 0);+    this._sourceContainer.setSourceMapTimeouts({+      ...this._sourceContainer.sourceMapTimeouts(),+      extraCumulativeScriptPaused: remainingExtraCumulativeScriptPaused,+    });+    this.logger.verbose(LogTag.Internal, `Blocked execution waiting for source-map`, {+      timeSpentWallClockInMs: wallClockTimeBlockedInMs,+      remainingExtraCumulativeScriptPaused: remainingExtraCumulativeScriptPaused,
      remainingExtraCumulativeScriptPaused,
digeff

comment created time in 5 days

Pull request review commentmicrosoft/vscode-js-debug

Now we can configure the timeouts used for waiting for source-maps

 export class Thread implements IVariableStoreDelegate {    */   async _handleSourceMapPause(scriptId: string, brokenOn: Cdp.Debugger.Location): Promise<boolean> {     this._pausedForSourceMapScriptId = scriptId;-    const timeout = this._sourceContainer.sourceMapTimeouts().scriptPaused;+    const perScriptTimeout = this._sourceContainer.sourceMapTimeouts().scriptPaused;+    const timeout =+      perScriptTimeout + this._sourceContainer.sourceMapTimeouts().extraCumulativeScriptPaused;

Clarified in chat

digeff

comment created time in 5 days

issue commentmicrosoft/vscode

Webview is unable to load resources while reconstructing after a reload

I have not seen this in the last few weeks working on webview debugging or reproduce it as I used to be able to, thus marking verified.

akonwi

comment created time in 5 days

issue openedmicrosoft/vscode

There's a gap in issue hovers where the hover disappears

Verifying: https://github.com/microsoft/vscode/issues/101495

Version: 1.47.0-insider (user setup)
Commit: 04545fa88043fd10d1f3edefd26be1b8245b516f
Date: 2020-07-02T05:48:37.715Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

created time in 5 days

Pull request review commentmicrosoft/vscode-js-debug

Now we can configure the timeouts used for waiting for source-maps

 export class Thread implements IVariableStoreDelegate {    */   async _handleSourceMapPause(scriptId: string, brokenOn: Cdp.Debugger.Location): Promise<boolean> {     this._pausedForSourceMapScriptId = scriptId;-    const timeout = this._sourceContainer.sourceMapTimeouts().scriptPaused;+    const perScriptTimeout = this._sourceContainer.sourceMapTimeouts().scriptPaused;+    const timeout =+      perScriptTimeout + this._sourceContainer.sourceMapTimeouts().extraCumulativeScriptPaused;

I make this a single pauseForSourcemap option that defaults to 1000ms rather than adding an extra property that adds on top of the default; easier to reason about.

digeff

comment created time in 5 days

Pull request review commentmicrosoft/vscode-js-debug

Now we can configure the timeouts used for waiting for source-maps

 export type SourceMapTimeouts = {   // won't be missed.   scriptPaused: number; +  // Normally we only give each source-map scriptPaused time to load per sourcemap. extraCumulativeScriptPaused+  // adds some additional time we spend parsing source-maps, but it's spent accross all source-maps in that // // // session
  // adds some additional time we spend parsing source-maps, but it's spent accross all source-maps in that session
digeff

comment created time in 5 days

Pull request review commentmicrosoft/vscode-js-debug

Now we can configure the timeouts used for waiting for source-maps

 const baseConfigurationAttributes: ConfigurationAttributes<IBaseConfiguration> =     description: refString('node.timeout.description'),     default: 10000,   },+  timeoutsInMs: {

Just sourceMapTimeout is fine -- we have other timeouts are the root level

digeff

comment created time in 5 days

issue openedconnor4312/mopidy-azure

asdfasdfsdf

<!-- Edit the body of your new issue then click the ✓ "Create Issue" button in the top right of the editor. The first line will be the issue title. Assignees and Labels follow after a blank line. Leave an empty line before beginning the body of the issue. -->

created time in 5 days

issue commentmicrosoft/vscode-remote-release

Stop container using default timeout

@chrmarti can you add verification steps?

Alaric84

comment created time in 5 days

issue commentmicrosoft/vscode

Nodejs debugger cannot attach child (linux)

Hm, okay, sounds good. If you're looking into it -- https://microsoft.github.io/vscode-pwa-analyzer/index.html is the tool I use to look at logs (you can open the .json.gz file directly). I'll take a shot at getting a setup with a linux vm on this next week.

Ierezell

comment created time in 5 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 7f6c3307a758acf4751651bd8bd26103a93a538d

fix: bad required remaining required property in restart configuration See #522

view details

push time in 5 days

issue commentmicrosoft/vscode-js-debug

Refresh restartPolicy after succesful launch

The restart options are simpler now -- don't nested the object, just have restart: { maxAttempts: 1, delay: 500 }

trubit

comment created time in 5 days

issue commentmicrosoft/vscode-js-debug

Stopping debug doesn't kill Code-OSS

Fixed the setting but also changed the default following some user reports https://github.com/microsoft/vscode-js-debug/issues/555

roblourens

comment created time in 5 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha aec8cf8af59825cede850992a6565b46770bc771

fix: cleanup wholeBrowser by default

view details

push time in 5 days

more