profile
viewpoint
Benjamin Pasero bpasero Microsoft Zurich, Switzerland http://code.visualstudio.com I am a software engineer at Microsoft in Zurich, Switzerland since 2011. Our team started VS Code when it was still called Monaco.

bpasero/debug-electron-vscode 28

Sample repository for being able to debug main and renderer from one debug session

bpasero/atom 1

The hackable text editor

bpasero/electron-gpu 1

Opens chrome://gpu inside a Electron window

bpasero/anymatch 0

:bangbang: Matches strings against configurable strings, globs, regular expressions, and/or functions

bpasero/asp-starter 0

asp-starter

bpasero/atom-quicknavigate 0

Quick Navigate for Atom

bpasero/AzureNpmCertWorkaround 0

Sample to show how to work around NPM issue

bpasero/chokidar 0

An efficient wrapper around node.js fs.watch / fs.watchFile / FSEvents

IssuesEvent

issue commentmicrosoft/vscode

Web: support other encodings than UTF-8

Thanks @gyzerok for driving this from the VSCode side and @ashtuchkin for the iconv-lite side 👍

bpasero

comment created time in 4 hours

push eventmicrosoft/vscode

Fedor Nezhivoi

commit sha 4e4941b8026e7bce596d4696b9e6384cd53f58e7

fix #79275 enable encodings for web (#101706) * fix #79275 enable encodings for web * fix one more place and prettify object * :lipstick: Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>

view details

push time in 4 hours

issue closedmicrosoft/vscode

Web: support other encodings than UTF-8

Ideas: https://github.com/microsoft/vscode/pull/79232

closed time in 4 hours

bpasero

PR merged microsoft/vscode

fix #79275 enable encodings for web

@bpasero truly epic day today as we are finally there after more than a month of work! Big thanks to you for guiding me through this! 🎉

I believe this is the last bit needed to enable encodings.

Contributing to VSCode was very enjoyable both because I love the editor and use it for many years and because it was very interesting to work with the codebase.

During my work I tried to keep changes that are not strictly important for the feature to work to minimum, so you are not overwhelmed by the amount of changes. However I had some ideas about small refactorings which I would like to try out and see your opinion on if result looks good. I guess I feel a bit of ownership now for the code I worked with 😄

A very simple example would be moving SUPPORTED_ENCODINGS to encoding.ts, so all the encoding stuff lives together.

I know that you in VSCode team have to deal with huge amount of issues and PRs every day, so I don't want to create more work for you just for the sake of it. That's why I would like to ask if you are open to the idea of me doing it. And also what would be the best process for it. Can I just open a PR not connected to any issue?

+266 -296

1 comment

7 changed files

gyzerok

pr closed time in 4 hours

pull request commentmicrosoft/vscode

fix #79275 enable encodings for web

@gyzerok

@bpasero truly epic day today as we are finally there after more than a month of work! Big thanks to you for guiding me through this! 🎉

I believe this is the last bit needed to enable encodings.

Great 🚀 . This was by far not a simple task, given complexities with streams etc and also because this code is hit every time a text file is read or written. I am happy how this turned out in the end 👍

Contributing to VSCode was very enjoyable both because I love the editor and use it for many years and because it was very interesting to work with the codebase. During my work I tried to keep changes that are not strictly important for the feature to work to minimum, so you are not overwhelmed by the amount of changes. However I had some ideas about small refactorings which I would like to try out and see your opinion on if result looks good. I guess I feel a bit of ownership now for the code I worked with 😄

Feel free to do more contributions as you see fit, for example we have 2 queries for issues where we are open for contributions:

Especially around web I think there is even a lot more that can be done, even if we are missing these labels feel free to jump on it: https://github.com/Microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Aweb

A very simple example would be moving SUPPORTED_ENCODINGS to encoding.ts, so all the encoding stuff lives together.

Yeah that sounds about right, the only reason it was not there before is because encoding.ts was in base layer. But now that it moved in workbench, I am fine moving it over.

I know that you in VSCode team have to deal with huge amount of issues and PRs every day, so I don't want to create more work for you just for the sake of it. That's why I would like to ask if you are open to the idea of me doing it. And also what would be the best process for it. Can I just open a PR not connected to any issue?

I think it is always good to correlate a PR back to an issue, e.g. in our testing process at the end of the month we use issues to verify new features or bug fixes. Having a PR without an issue would not allow us to follow that process.

Is there an area in particular where you thought about contributing?

gyzerok

comment created time in 4 hours

push eventgyzerok/vscode

Benjamin Pasero

commit sha 3f834704c3b5da652f991faea214fa5b4da42afc

:lipstick:

view details

push time in 5 hours

push eventmicrosoft/vscode

Fedor Nezhivoi

commit sha ce1462776f7ada735ba82ffec28ea774e617a927

remove jschardet typings workaround for #79275 (#101705)

view details

push time in 5 hours

PR merged microsoft/vscode

remove jschardet typings workaround for #79275

Refs: https://github.com/microsoft/vscode/pull/101489#issuecomment-653559366

+1 -5

1 comment

1 changed file

gyzerok

pr closed time in 5 hours

issue commentmicrosoft/vscode

Notebooks: cell background makes it look heavier

One particular issue seems to be that we automatically put focus into the first cell each time you open a notebook.

bpasero

comment created time in 8 hours

issue openedmicrosoft/vscode

Notebooks: cell background makes it look heavier

I just looked at how notebooks used to be in stable and prefer it actually over our current designs with regards to the background color on cell. Compare the initial look of a notebook.

Stable image

Insiders image

Maybe the cell selection background could be optional for people that want it?

created time in 8 hours

issue commentmicrosoft/vscode

Notebooks: have a lot of unneeded margins/paddings?

Thanks that works 👍

bpasero

comment created time in 8 hours

push eventmicrosoft/vscode-docs

Benjamin Pasero

commit sha 7ca931baa47cb5c9e7053b36f7464b1b134cd6bb

mention encodings

view details

push time in 9 hours

pull request commentmicrosoft/vscode

explorer: support for dnd remote resources

I think I got something to work, thanks for the help. Summary:

  • we need to registerSchemesAsPrivileged (scheme: vscode-remote-resource, supportFetchAPI: true)
  • we need to change our CSP in workbench.html to connect-src 'self' https: vscode-remote-resource:;
  • we need to register a file system provider for vscode-remote-resource via fileService.registerProvider(Schemas.vscodeRemoteResource, new FetchFileSystemProvider())
  • in our DND code instead of putting in the vscode-remote URI, we need to call asDomUri instead

This should allow to DND files over from the explorer to copy it into a local explorer.

There is another case where we could use it: when dragging editors around. Currently you cannot drop an editor to a local instance because the URI is vscode-remote and not understood by the local instance.

isidorn

comment created time in 9 hours

issue commentmicrosoft/vscode

Ellipsis in search viewlet shows more UI, not commands

I actually reacted positively to the design in https://github.com/microsoft/vscode/issues/99892#issuecomment-642968531, but maybe we should take the proposals to a UX call to discuss in greater detail.

stevencl

comment created time in 9 hours

issue commentmicrosoft/vscode

Notebooks: have a lot of unneeded margins/paddings?

@roblourens this results in:

Unable to open 'inbox.github-issues': Cannot read property 'backupId' of undefined.
bpasero

comment created time in 9 hours

pull request commentmicrosoft/vscode

fix: remove unsed code on detecting file type

No, unfortunately not. We cannot break because we may get a filenameMatch later in the loop.

simpleapples

comment created time in a day

pull request commentmicrosoft/vscode

fix: remove unsed code on detecting file type

Oh, maybe you are onto something, looks like a break could indeed work...

simpleapples

comment created time in a day

pull request commentmicrosoft/vscode

fix: remove unsed code on detecting file type

Because in that case we still allow the other match.

simpleapples

comment created time in a day

pull request commentmicrosoft/vscode

Fix for #101376

Yes, for example for notifications:

https://github.com/microsoft/vscode/blob/0b65d0385f7d9474ec32e1bb149398db3331949b/src/vs/workbench/browser/workbench.ts#L378

jppm99

comment created time in a day

pull request commentmicrosoft/vscode

fix: remove unsed code on detecting file type

I do not really understand your suggestion, but we cannot simply remove the break statement as the idea was to break the for loop when we found a exact name match?

simpleapples

comment created time in a day

issue commentmicrosoft/vscode

Startup performance regression during June

Also adding @deepak1556 for more insights if he is aware of script loading is slow compared to node.js require.

jrieken

comment created time in a day

issue commentmicrosoft/vscode

Startup performance regression during June

Well, we always did load workbench.js via script tag, even before. One idea that circulated was to concatenate the scripts we need on startup into one before minification and thus only have one script tag instead of 4. This would mean we need a workbench-dev.html and workbench.html for built versions similar to what we have for web too.

jrieken

comment created time in a day

issue commentmicrosoft/vscode

Not possible to define location of argv.json

@hajdamak we are using os.homedir() from node.js in the end which seems to pick up on these environment variables:

  • Posix: HOME
  • Windows: USERPROFILE

Can you not simply change this variable prior to launching VSCode as a workaround? This would even ensure that any code that wants to write into home directory would follow the path you specify.

hajdamak

comment created time in a day

issue commentmicrosoft/vscode

Backups: remove legacy migration code path

Actually I think @aeschli introduced the deprecation for these:

https://github.com/microsoft/vscode/blob/0b65d0385f7d9474ec32e1bb149398db3331949b/src/vs/platform/backup/node/backup.ts#L14-L16

@aeschli can we remove this? Seems around 2 years old from the remote work we did.

bpasero

comment created time in a day

push eventmicrosoft/vscode

Benjamin Pasero

commit sha f3d45264cf474b3f4e3d9fda90bb683d93a46ac4

web :lipstick:

view details

Benjamin Pasero

commit sha 0b65d0385f7d9474ec32e1bb149398db3331949b

dnd - support dirty editor drop that is empty

view details

push time in a day

pull request commentmicrosoft/vscode

Move read and write logic from nativeTextFileService to textFileService for #79275

@gyzerok merged! I guess only missing now is to enable encoding related UI for web 🚀

gyzerok

comment created time in a day

push eventmicrosoft/vscode

Fedor Nezhivoi

commit sha 05613d7a1cb8671a25de49fb5e9314911c342e0b

Move read and write logic from nativeTextFileService to textFileService for #79275 (#100804) * move encoding logic from NativeTextFileService to AbstractTextFileService for #79275 * some cleanup things - just cosmetic * fix tests * review * use correct comparison Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>

view details

push time in a day

PR merged microsoft/vscode

Move read and write logic from nativeTextFileService to textFileService for #79275

Hey @bpasero! Here comes 😄

This PR isn't finished yet. I am opening it to get your early feedback and to ask some questions.

What is blocking

Currently I am blocked by https://github.com/microsoft/vscode/issues/79275#issuecomment-647224220. I've made a PR for iconv-lite to fix the issue and am currently awaiting the resolution.

Also in case iconv-lite author will decide to reject my PR we can still proceed forward by allowing only subset of encodings in the browser for which we can ensure Uint8Array support by test coverage.

Tests

I was looking into how I could run tests for textFileService inside browser as well.

The problem there (as we discussed before) is that we can't load fixtures from files inside browser environment. So I figured I can pre-encode fixtures data and put it inside ts modules. Overall it worked great and even allowed me to discover an issue with jschardet I've missed in my previous PR.

I wrote the tests so that they repeat the same tests for nativeTextFileService exactly with the exception of the environment. So here comes options on which I seek your guidance:

Is loading from file system crucial for us when testing nativeTextFileService?

  1. NO: We can actually remove these tests now and just leave those for textFileService which will run in both environments
  2. YES: We move actual test cases to a separate file, then import it in both native and common tests populating environments differently. In this case test can be written only once.

Personally I like option 1 more. In my opinion we should test that textFileService works, not that the file system works. So in my mind loading fixtures from actual file system is not relevant for this tests.

Other questions

It looks like AbstractTextFileService only uses what is defined in common, but itself is in browser. Is it intentional? Should it be moved to common?

+833 -217

11 comments

11 changed files

gyzerok

pr closed time in a day

PR closed microsoft/vscode

fix: remove unsed code on detecting file type

This RP only remove unused code based on the comment on https://github.com/microsoft/vscode/blob/01d0314308fdf83801c3d7abf43b7a2702ea9263/src/vs/base/common/mime.ts#L172

Besides, it won't cause any functional change after remove the line.

+0 -1

1 comment

1 changed file

simpleapples

pr closed time in a day

pull request commentmicrosoft/vscode

fix: remove unsed code on detecting file type

I do not see how that code is unused, it is an early return. Closing until further info is provided.

simpleapples

comment created time in a day

pull request commentmicrosoft/vscode

:up: jschardet@2.2.1 (#33720)

@gyzerok fyi master is open for 1.48 July work, so feel free to remove that any cast in a new PR.

bpasero

comment created time in a day

push eventmicrosoft/vscode

Benjamin Pasero

commit sha 1fb0d4424da3bcee64f9012ba89edf9619a2e798

:up: jschardet@2.2.1 (#33720) (#101489)

view details

push time in a day

delete branch microsoft/vscode

delete branch : ben/33720

delete time in a day

PR merged microsoft/vscode

:up: jschardet@2.2.1 (#33720)

<!-- Thank you for submitting a Pull Request. Please:

  • Read our Pull Request guidelines: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#pull-requests.
  • Associate an issue with the Pull Request.
  • Ensure that the code is up-to-date with the master branch.
  • Include a description of the proposed changes and how to test them. -->

This PR fixes #33720

+22 -22

3 comments

8 changed files

bpasero

pr closed time in a day

issue closedmicrosoft/vscode

Wrong guess encoding as Windows 1252

Upstream issue: https://github.com/aadsm/jschardet/issues/48

<!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode. -->

<!-- Use Help > Report Issues to prefill these. -->

  • VSCode Version: Version 1.15.1
  • OS Version: Windows 10.0.15063

Steps to Reproduce:

  1. The settings.json of my vscode
    "files.encoding": "utf8",
    "files.autoGuessEncoding": true,
  1. Ceate two txt files, make sure the files are saved as utf-8

test1.txt

Created on: 2017年9月2日
测

test2.txt

Created on: 2017年9月2日
测试
  1. Reopen the files,test1.txt guessed encoding is Windows 1252 and test2.txt guessed encoding is utf-8.

<!-- Launch with code --disable-extensions to check. --> Reproduces without extensions: Yes

closed time in a day

maooyer

issue commentmicrosoft/vscode

Ellipsis in search viewlet shows more UI, not commands

+1 for changing this, away from the "...".

stevencl

comment created time in a day

issue commentmicrosoft/vscode

Migrate to AppCenter for crash reports

Isn't this complete?

JacksonKearl

comment created time in a day

issue closedmicrosoft/vscode

WebView reaches into EditorPart

From https://github.com/microsoft/vscode/pull/82813. Ideally a component does not have to cast to EditorPart but rather rely on some kind of service (like a new IEditorDragAndDropService).

Refs: https://github.com/microsoft/vscode/blob/a46824c2e9f90b13cb400fe149044acfeb97f2c2/src/vs/workbench/contrib/webview/browser/webviewEditor.ts#L185

closed time in a day

bpasero

issue commentmicrosoft/vscode

WebView reaches into EditorPart

I took care of this meanwhile.

bpasero

comment created time in a day

issue closedmicrosoft/vscode

Vscode opens removed file always

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.46.1
  • OS Version: Ubuntu 20.04

Description: Hi, I have a strange problem with vscode. I removed a file from my folder and when I open vscode it opens that removed file all the time. When I open vscode in a specific directory, vscode opens twice, once where I wanted and second with the removed file. If I open normally (without specifying folder or project) that fille will appears in vscode. That file is unsaved (according to vscode) but when I save it, vscode still opens it on start.

It's really hard to reproduce (or even no-reproducible) because I have vscode on Windows 10 and the second laptop with ubuntu 20.04 and this situation does not occur.

I tried to clear cache (from vscode and removed from folders Cache and CachedData

Steps to Reproduce:

  1. Remove file
  2. Open vscode

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

closed time in a day

moleszek

issue commentmicrosoft/vscode

Vscode opens removed file always

Yeah that sounds like the issue, somehow VSCode is not able to remove the backup in /home/moleszek/.config/Code/Backups. Can you manually remove it?

moleszek

comment created time in a day

issue commentmicrosoft/vscode

Make notebook cell focus & indicator themeable

@misolori it looks like the input field is falling out of the cell:

image

Please do not forget to update our docs for the new theme colors and release notes.

misolori

comment created time in a day

issue commentmicrosoft/vscode

Quick outline doesn't focus editor

The quick outline is setting focus to the editor, but it seems that https://github.com/microsoft/vscode/commit/da99f1fe1fc9def6cbe5cbe122de49b3716e2cee is still restoring focus to the previous element.

Imho quick input should check if the focused element is different from where it was before.

jrieken

comment created time in a day

issue commentmicrosoft/vscode

Quick outline doesn't focus editor

This is very likely from https://github.com/microsoft/vscode/issues/93055

jrieken

comment created time in a day

pull request commentmicrosoft/vscode

explorer: support for dnd remote resources

Ok I looked into it a bit more and I think I am stuck. Even though we handle vscode-remote-resource in electron main, it looks like fetch requests are failing:

Fetch API cannot load vscode-remote-resource://127.0.0.1:57060/vscode-remote-resource?path=%2FUsers%2Fbpasero%2FDesktop%2Ftest-ts%2FCHANGELOG.md&tkn=822c5a94-9678-43e3-8155-808278539822. URL scheme must be "http" or "https" for CORS request.

@deepak1556 @mjbvz or @alexdima maybe you could advise. The question is this:

  • we want to support loading remote contents (from a drag and drop operation) in local environments that are NOT connected to the remote
  • we do not want to put the entire contents into the clipboard because files can be very large
  • we think about leveraging asDomUri to get at the contents from that "local" window
  • we currently do not register a file system provider for vscode-remote-resource
  • we could register a FetchFileSystemProvider for this resource to get at the contents
  • however this requires fetch to work for this resource which fails currently
isidorn

comment created time in a day

pull request commentmicrosoft/vscode

explorer: support for dnd remote resources

One thing I realised now is that we do not seem to have any file system provider registered for the vscode-remote-resource. Though we have one for http and https. We seem to simply be rewriting the protocol to http here:

https://github.com/microsoft/vscode/blob/8cd23cf040974c35eed6b337ae45d8f087eec30a/src/vs/code/electron-main/app.ts#L828

So we probably need to do something like that, or use fetch to get at the contents.

isidorn

comment created time in a day

issue commentmicrosoft/vscode

vscode.workspace.getWorkspaceFolder does not check if file exists (or API documentation is not clear)

I suggest we tweak the API docs to not break. Up for grab.

pkruk2

comment created time in a day

issue commentmicrosoft/vscode

Uncaught (in promise) TypeError: Cannot read property 'getFullModelRange' of null"

That was my change to drop sync access to the find clipboard.

bpasero

comment created time in a day

push eventmicrosoft/vscode-docs

Benjamin Pasero

commit sha 605e07dcd728e5d79442139bc02528a119a27b88

minor tweaks

view details

push time in a day

issue closedmicrosoft/vscode

Behavior of detecting the file language

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.46.1
  • OS Version: macOS 10.15.5

Steps to Reproduce:

  1. create a file named dockerfile.go, dockerfile.py or other extensions.
  2. you can see the file is detected as a Dockerfile, but it should be a go file or python file. Screen Shot 2020-07-02 at 3 59 43 PM

Related logic: I found the file detecting logic is here: https://github.com/microsoft/vscode/blob/697b702e47d05fa71f480a2620ab5849f52f55c3/src/vs/base/common/mime.ts#L195-L208 Filename Match has the higher priority than Extension Match, I think it should be reconsidered. Extension Match should have the highest priority.

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No Yes

closed time in a day

simpleapples

issue commentmicrosoft/vscode

Behavior of detecting the file language

Ok, looks like this got fixed somehow I cannot explain why. We can reopen if this comes back next month after we have released.

simpleapples

comment created time in a day

issue commentmicrosoft/vscode

Notebooks: have a lot of unneeded margins/paddings?

@rebornix @misolori is there any way I can see how this used to look in 1.46? How can I run an older notebook UX currently, if possible?

bpasero

comment created time in a day

issue commentmicrosoft/vscode

Notebook: weird drop-shadow border around active cell

This one is tough because the drop shadow is a common trait in other notebooks (collab, nteract, etc.) and it seems like this comes down to personal preference

If in doubt I would go for a consistent design language here and not use shadows to indicate focus. We indicate focus via blue outline everywhere in the UI, so I do not understand why the shadows are used only for notebooks. Imho that is inconsistent design language we should avoid.

bpasero

comment created time in a day

issue commentmicrosoft/vscode

Behavior of detecting the file language

I can reproduce in Code stable, but not Insiders, but have no clue what has changed.

@simpleapples can you try to reproduce with our insiders?

simpleapples

comment created time in a day

issue commentmicrosoft/vscode

Cannot save untitled notebook

@rebornix my steps involve not setting any file extension and you get this error: Unable to open 'Untitled-1': Cannot read property 'kernel' of undefined.

Your steps work fine. I can open a new issue if you want?

chrmarti

comment created time in a day

issue commentmicrosoft/vscode

Panel: hiding all panels not possible and/or weird

@sbatten one thing I wonder: given we have a UI for when the panel is truly empty, why do we not show the panel empty when you clicked "Hide" on the last panel? We now seem to always show at least one entry, but I think we could also show it completely empty?

bpasero

comment created time in a day

issue commentmicrosoft/vscode

Notebooks: have a lot of unneeded margins/paddings?

It is better, thanks for reducing it. I still think there is lots of whitespace, e.g. here:

image

The line around Config: defines the inbox query being in small font having almost 5x the line height as surrounding whitespace.

bpasero

comment created time in a day

issue openedmicrosoft/vscode

Cannot read property 'setViewVisible' of undefined

Found this in my logs running out of sources today:

[1309:0703/071149.079570:INFO:CONSOLE(144)] "%c  ERR color: #f33 Cannot read property 'setViewVisible' of undefined: TypeError: Cannot read property 'setViewVisible' of undefined
    at Workbench.setPanelHidden (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/layout.js:1210:32)
    at Object.hidePart (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/panel/panelPart.js:54:52)
    at CompositeBar.resetActiveComposite (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/compositeBar.js:303:30)
    at CompositeBar.hideComposite (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/compositeBar.js:238:22)
    at PanelPart.hideComposite (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/panel/panelPart.js:227:31)
    at PanelPart.onDidChangeActiveViews (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/panel/panelPart.js:184:22)
    at PanelPart.onDidRegisterPanels (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/panel/panelPart.js:133:22)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/panel/panelPart.js:198:70
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:456:38)
    at PanelRegistry.registerComposite (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/composite.js:203:33)
    at PanelRegistry.registerPanel (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/panel.js:29:19)
    at ViewsService.registerPanel (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsService.js:382:63)
    at ViewsService.registerViewletOrPanel (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsService.js:341:26)
    at ViewsService.onDidRegisterViewContainer (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsService.js:93:18)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsService.js:37:85
    at Array.forEach (<anonymous>)
    at new ViewsService (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsService.js:37:55)
    at InstantiationService._createInstance (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:88:20)
    at InstantiationService._createServiceInstance (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:177:29)
    at InstantiationService._createServiceInstanceWithOwner (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:165:29)
    at InstantiationService._createAndCacheServiceInstance (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:156:43)
    at InstantiationService._getOrCreateServiceInstance (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:113:29)
    at Object.get (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:36:45)
    at Workbench.initLayout (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/layout.js:146:42)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/workbench.js:67:26
    at InstantiationService.invokeFunction (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:43:24)
    at Workbench.startup (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/workbench.js:61:38)
    at DesktopMain.open (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/electron-browser/desktop.main.js:61:52)", source: file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/log/common/log.js (144)

created time in a day

issue commentmicrosoft/vscode

Changing file case is not reflected in breadcrumbs

@JacksonKearl maybe the bot should check if the issue is already verified

bpasero

comment created time in 2 days

issue commentmicrosoft/vscode

Extension recommendations should start earliest in LifecyclePhase.Restored

Actually I just checked and today the extension recommendations service seems to be instantiated already after editors restore, so this is probably fine.

bpasero

comment created time in 2 days

issue openedmicrosoft/vscode

Notebook: status UX feedback

image

Some thoughts:

  • the green checkmark message is not left aligned
  • the input field for the text would benefit from a bit of paddings
  • looks like a different background color is used below the cell which is empty, but not sure what the purpose is?

created time in 2 days

issue closedmicrosoft/vscode

Notebook: zoom is not applied for output?

I am always running with zoom level 2, but the output of notebooks look like they are not getting that info:

image

closed time in 2 days

bpasero

issue commentmicrosoft/vscode

Notebook: zoom is not applied for output?

Nevermind, looks like zooming in also makes the output larger, but weird that the default font size for output does not match the rest of the workbench.

bpasero

comment created time in 2 days

issue openedmicrosoft/vscode

Panel: hiding all panels not possible and/or weird

Steps to Reproduce:

  1. right-click hide on each panel
  2. the last one never hides
  3. however the label seems to disappear?

recording

created time in 2 days

issue commentmicrosoft/vscode

Notebook: zoom is not applied for output?

Or maybe the GH extension decided to hardcode the font size, not sure...

bpasero

comment created time in 2 days

issue openedmicrosoft/vscode

Notebook: zoom is not applied for output?

I am always running with zoom level 2, but the output of notebooks look like they are not getting that info:

image

created time in 2 days

IssuesEvent

issue commentmicrosoft/vscode

reafactoring preview is not a flexiable layout

I find it weird:

  • I can move the references view but when dropped into the sidebar, it does not get active
  • the contents are lost (my refactoring preview)
NewtMa

comment created time in 2 days

issue commentmicrosoft/vscode

Activity bar: menu could offer an action to move it right

Oh just found this:

image

Maybe we should have it also in the activity bar menu.

bpasero

comment created time in 2 days

issue openedmicrosoft/vscode

Activity bar: menu could offer an action to move it right

Talking about this menu:

image

To be consistent with panel:

image

created time in 2 days

IssuesEvent

issue commentmicrosoft/vscode

Extra separator in sync menu

image

Still seeing this in yarn web

joaomoreno

comment created time in 2 days

issue commentmicrosoft/vscode

Cannot save untitled notebook

Btw maybe we could add a "New Untitled Notebook" command.

chrmarti

comment created time in 2 days

IssuesEvent

issue commentmicrosoft/vscode

Cannot save untitled notebook

I can still reproduce this following these steps:

  • new untitled file
  • reopen with "Notebook"
  • this works and I can edit
  • try to save
 ERR Unable to resolve text model content for resource vscode-notebook-cell:/Users/bpasero/Desktop/Untitled-1#0000000: Error: Unable to resolve text model content for resource vscode-notebook-cell:/Users/bpasero/Desktop/Untitled-1#0000000
    at S.resolveTextModelContent (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6045:7)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
    at async S.doCreateReferencedObject (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6043:841)
    at async b.createModelReference (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6045:676)
    at async resolveTextModelRef (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3252:937)
    at async c.resolveTextModel (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3288:866)
chrmarti

comment created time in 2 days

push eventmicrosoft/vscode

Benjamin Pasero

commit sha 051798aac4c4e9bfd502ab9e4ae6871c1d11f6c1

web - fix performance measures

view details

push time in 2 days

push eventmicrosoft/vscode

Benjamin Pasero

commit sha ea2ad328385afe387193de315fc8e40509fd1383

storage - remove unused code

view details

push time in 2 days

issue commentmicrosoft/vscode

Changes view: harder for me to understand "clean" state for a repo

Throwing in another idea: use different background colors for the repos. Compare with our keybindings editor:

image

This gives a nice separation between logical units in the list. Though arguably can only be a light change in background color given we have so many selection colors.

bpasero

comment created time in 2 days

issue commentmicrosoft/vscode

Certain log output channel only show up in the first vscode window

To further debug, check this line which sends the process environment over:

https://github.com/microsoft/vscode/blob/8d699df76bc54aedda370574acd2ccfe945bad96/src/vs/code/electron-main/main.ts#L313

Deleting VSCODE_LOGS from the environment is a hacky workaround, but a proper fix should be made.

eamodio

comment created time in 2 days

issue commentmicrosoft/vscode

Certain log output channel only show up in the first vscode window

@sandy081 again, please move away from using process environment for this purpose, it asks for trouble.

The issue is this:

  • you open a first window and it sets VSCODE_LOGS path accordingly as environment
  • you open a second window from the command line
    • we explicitly want all of process.env of this second window to reach that window because a user might have configured some environments that need to travel to other processes such as extensions
    • the second window is a fresh process and thus will set a VSCODE_LOGS again that is different from the main one
    • the fresh process communicates to the first process and sends over the environment to use
    • that second window opens with the logs folder that is different from the first
eamodio

comment created time in 2 days

issue commentmicrosoft/vscode

Option to specify separator for "Copy Relative Path" action

Maybe "Copy Path" could be the only special case where we would use backslash even if this new setting is configured to use slashes. I agree that an absolute path when copied should use backslash on Windows.

IllusionMH

comment created time in 2 days

issue closedmicrosoft/vscode-remote-release

Remote indicator needs a max length

This is not very good use of screen real estate:

Screenshot 2019-04-25 at 17 26 45

closed time in 2 days

bpasero

issue commentmicrosoft/vscode-remote-release

Remote indicator needs a max length

via https://github.com/microsoft/vscode/pull/87164

bpasero

comment created time in 2 days

pull request commentmicrosoft/vscode

explorer: support for dnd remote resources

@isidorn upon more thinking I had another idea: every remote exposes its resources through a simple HTTP server. We use this for example to be able to load images in markdown preview when shown on remote or for example to load themes when installed inside the remote.

If for each vscode-remote resource you call DOM.asDomUri you will end up with a URI such as:

vscode-remote-resource://127.0.0.1:50595/vscode-remote-resource?path=%2FUsers%2Fbpasero%2FDesktop%2Ftest-ts%2FCHANGELOG.md&tkn=82959925-0713-4e4b-8491-6b9a5c0a3f48

Which every VSCode window can resolve (we register a protocol handler for vscode-remote-resource).

Maybe you should simply introduce a new CodeDataTransfers.REMOTE_FILES: CodeRemoteFiles that includes these resources and then on the receiving side to get at the data, resolve the contents through a HTTP fetch. I am not entirely sure, but maybe we even register a file system provider for vscode-remote-resource (Matt would probably know).

isidorn

comment created time in 2 days

issue closedmicrosoft/vscode

Unable to "Save Workspace As..." deleted workspace

Issue Type: <b>Bug</b>

  1. open Workspace file .
  2. delete the file .
  3. try "Save Workspace As..." .

VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z) OS version: Windows_NT x64 10.0.18363

closed time in 2 days

irvnriir

issue commentmicrosoft/vscode

Unable to "Save Workspace As..." deleted workspace

@sbatten I think this is expected, but I let @sandy081 comment: when the workspace file gets deleted, we probably have a file watcher event that will cause the workspace service to update and then find no more workspace folders. I am not sure we can or should change that because essentially at that point the workspace has no folders anymore. If we think this is an issue, I would suggest to file a separate issue and still leave this one for verification.

irvnriir

comment created time in 2 days

issue commentmicrosoft/vscode

Switching between tabs takes 2 o 3 seconds

Thanks for the profile, but I am not seeing information there that could help understand the issue.

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

oscarlvp

comment created time in 2 days

issue commentmicrosoft/vscode

"Duplicate Workspace in New Window" command creates a different workspace

This is currently the only way we can support it: by creating an "Untitled Workspace". See our docs for more info on that topic.

Milunnn

comment created time in 2 days

issue openedmicrosoft/vscode

References: focus editor on double click

I am not sure we have API in custom tree land for this, but e.g. the explorer focuses the editor when you doubleclick a file.

created time in 3 days

issue commentmicrosoft/vscode

References list shows focus and selection

Hm, this no longer reproduces for me anymore after a window reload, not sure what was going on. I had a notebook open as well...

bpasero

comment created time in 3 days

issue openedmicrosoft/vscode

References list shows focus and selection

Steps to Reproduce:

  1. find references
  2. click on a result

=> 🐛 somehow even though an item is selected, the entire list shows blue outline

image

created time in 3 days

issue commentmicrosoft/vscode

Show editor reopen with in title context menu

If I had to choose I would try to keep the tabs menu small and actually liked the action inside the "...", though arguably less discoverable.

rebornix

comment created time in 3 days

issue commentmicrosoft/vscode

Vscode opens removed file always

That file is unsaved (according to vscode) but when I save it, vscode still opens it on start.

VSCode will always restore files that are not saved, we call this "hot exit". Can you check the log what happens when you save the file or close it without saving?

moleszek

comment created time in 3 days

pull request commentmicrosoft/vscode

feat: add setting to modify copy separator

Let's get some more peoples opinions about the general change: https://github.com/microsoft/vscode/issues/56279#issuecomment-652502935

Nevertheless, having a way to pass in the separator to the label service seems good, even if we decide to only change it for the copy action.

kieranlblack

comment created time in 3 days

issue commentmicrosoft/vscode

Option to specify separator for "Copy Relative Path" action

Quick poll: what if there was simply a setting that puts any path on Windows with slash instead of backslash? Changing this just for the "Copy Path" action seems a bit inconsistent. Would that be OK for people?

IllusionMH

comment created time in 3 days

push eventmicrosoft/vscode

Benjamin Pasero

commit sha 1f31957f810e2507b271de2111e5ba79cc391ca0

contextmenu - do not send functions over ipc (fix #100982)

view details

push time in 3 days

issue closedmicrosoft/vscode

Right Mouse Click is broken

Issue Type: <b>Bug</b>

Right click anywhere in a document and the context menu does not appear. An error is reported in the developer tools console.

image

VS Code version: Code - Exploration 1.47.0-exploration (23d15c61b95620c587e1fbea8bf8cc675a18e7e4, 2020-06-24T17:10:42.684Z) OS version: Darwin x64 19.5.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: enabled<br>opengl: enabled_on<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (5.23GB free)
Process Argv
Screen Reader no
VM 13%

</details>Extensions: none <!-- generated by issue reporter -->

closed time in 3 days

jtsom

issue commentmicrosoft/vscode

Changes view: harder for me to understand "clean" state for a repo

I would probably prefer a look that is in sync with our split views, e.g. a full border:

image

I would even think that bold could work for the first nodes?

bpasero

comment created time in 3 days

issue commentmicrosoft/vscode

Right Mouse Click is broken

Oh I see it now, there is a function sneaking in via options...

jtsom

comment created time in 3 days

more