profile
viewpoint
遗忘
Don Jayamanne DonJayamanne Software engineer with a soft spot for .NET and Node.js. Loves tinkering with Arduino and Raspberry Pi. Lives in a cave.

beeware/vscode-beeware 30

A Visual Studio Code extension with support for BeeWare development

DonJayamanne/awesome-python 1

A curated list of awesome Python frameworks, libraries, software and resources

DonJayamanne/azure-pipelines-template 1

template for your azure pipelines

DonJayamanne/conda 1

OS-agnostic, system-level binary package manager and ecosystem

DonJayamanne/apollo-tooling 0

:pencil2: Tooling for development and production Apollo workflows

DonJayamanne/autoDocstring 0

vscode extension that generates docstrings for python files

DonJayamanne/awesome-jupyter 0

A curated list of awesome Jupyter projects, libraries and resources

DonJayamanne/azure-powershell 0

Microsoft Azure PowerShell

DonJayamanne/BlazorTest 0

A place to test Blazor features

PR closed microsoft/vscode-python

For logging

For #

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+122 -13

2 comments

7 changed files

DonJayamanne

pr closed time in 30 minutes

issue commentmicrosoft/vscode-python

Kernelspec required - Failure to start jupyter server

@vpankaj97 Thanks for reporting this issue, please could you provide the following information:

  • Version of Python used
  • Version of conda used
  • Please provide the contents of your console window (Menu/Command Palette) -> Toggle Developer Tools -> Console Window
  • Output of your Python Output Panel (see below). Screen Shot 2020-07-16 at 08 46 51
vpankaj97

comment created time in 33 minutes

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha 703483dd57f2b5236128b0314ad7dbfad86d1e80

Update renderers to use new Api (#12990) For #12189 Use new API in renderers

view details

push time in 36 minutes

delete branch DonJayamanne/pythonVSCode

delete branch : updateRendererApi

delete time in 36 minutes

PR merged microsoft/vscode-python

Reviewers
Update renderers to use new Api skip news

For #12189 Use new API in renderers

+67 -31

1 comment

7 changed files

DonJayamanne

pr closed time in 36 minutes

Pull request review commentmicrosoft/vscode-python

Update renderers to use new Api

 function renderOutput(tag: HTMLScriptElement) {     try {         const output = JSON.parse(tag.innerHTML) as nbformat.IExecuteResult | nbformat.IDisplayData;         // tslint:disable-next-line: no-console-        console.log(`Rendering mimeType ${mimeType}`);+        console.log(`Rendering mimeType ${mimeType}`, output);          // Create an element to render in, or reuse a previous element.-        if (tag.nextElementSibling instanceof HTMLDivElement) {-            container = tag.nextElementSibling;+        const maybeOldContainer = tag.previousElementSibling;

We clear the output and pass this as the element for rendering for React.

container.innerHTML = ''; ReactDOM.render(React.createElement(CellOutput, { mimeType, output }, null), container);

DonJayamanne

comment created time in 36 minutes

PR opened microsoft/vscode-python

Update renderers to use new Api

For #12189 Use new API in renderers

+67 -31

0 comment

7 changed files

pr created time in 17 hours

create barnchDonJayamanne/pythonVSCode

branch : updateRendererApi

created branch time in 17 hours

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha 1c0cbf4a422ada5b15d6467680c95ca19b99fc29

Use a custom renderer to render png/jpeg (#12978) For #12977

view details

push time in 19 hours

delete branch DonJayamanne/pythonVSCode

delete branch : useCustomRenderer

delete time in 19 hours

PR merged microsoft/vscode-python

Reviewers
Use a custom renderer to render png/jpeg

For #12977

+146 -77

1 comment

10 changed files

DonJayamanne

pr closed time in 19 hours

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 5d83b1489dbfd2ee463c0aade4713c1bf39a8a59

Fixed tests

view details

push time in 19 hours

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 9b6f777cf8da6c5687bc0c03207a595f07253b4d

Comments

view details

Don Jayamanne

commit sha 97903111f3b8915a7eb18f0270713b4bc89006a4

Fixes

view details

Don Jayamanne

commit sha 5b45cd7050cf17908a34c0fafdfb9690b88d48a5

Fix tests

view details

push time in 20 hours

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 1eb5dd6aa63d1e0029e7ff49b1827ce82aba626d

Fixes

view details

push time in 21 hours

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 43a34753f6b3ff168a84680fa29b95fe8c863997

Readability

view details

push time in 21 hours

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha b5298c4a8ef15d08dec1b1b7b9838cb02c29ec2a

Comments

view details

push time in 21 hours

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha ac4689013779d437c910dc0af83fece63ea6353f

Comments with need for metadata in cells

view details

push time in 21 hours

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 134c66afef952676c9ee66f7b30924b9174c23bd

News

view details

Don Jayamanne

commit sha a64e1a2373a00e6f82103665f3ac98777c088450

Fixes

view details

push time in 21 hours

PR opened microsoft/vscode-python

Use a custom renderer to render png/jpeg

For #12977

+96 -56

0 comment

8 changed files

pr created time in 21 hours

issue openedmicrosoft/vscode-python

Use custom renderers to render png/jpeg in notebook

Today we create html to render png/jpeg when we have custom metadata. This way we use VS Code renderers for HTML & images.

However, we end up creating an output of HTML that doesn't exist in the cell, and this is created so that we can use VSC to render the png/jpeg. The down side of this is when diffing it might look as though there's a new output that is in the notebook, but doesn't exist on file.

created time in 21 hours

create barnchDonJayamanne/pythonVSCode

branch : useCustomRenderer

created branch time in 21 hours

delete branch microsoft/vscode-python

delete branch : daateChanges

delete time in a day

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha 40d5dcd6e2c4bc3fee14a3c46c2e1856ccfd2ebb

Display survey for native notebooks on/after 1st August (#12961) (#12975) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

view details

push time in a day

PullRequestEvent

create barnchmicrosoft/vscode-python

branch : daateChanges

created branch time in a day

issue commentmicrosoft/vscode

Add support for multiple cancellations in Notebook `stop` button

g does the response tell you whether the running cell has stopped executing, or how do you determine whether it was "successful"?

We don't get a response indicating it was interrupted. We wait for the original cell execution to stop.

Also, in Jupyter what is the difference between running a notebook vs running a single cell? If the user clicks the "run notebook" button, do you instruct the kernel to execute cells one by one? And will cancellation work any different in that case?

We run one cell at a time. Cancellation here is still the same. If we cancel, then we stop the entire notebook execution (i.e. current & all remaining cells stop running)

Another solution would be to just get rid of the notebook-level cancellation button.

I just treat the notebook level and cell level cancellations as a trigger to cancel current execution. So having this at a notebook level IMHO is good. I.e. I'd like this to continue to exist.

We could have a quick call to discuss if that would be easier for you, sorry for throwing a pile of questions at you.

Anything works for me. No worries, please feel free to ping me on teams.

DonJayamanne

comment created time in a day

issue commentmicrosoft/vscode-python

Native Notebook - Plotly download link does nothing

Hmm, looks like it's broken again in VSCode. There were handling this natively. I'll check this out

rchiodo

comment created time in a day

issue commentmicrosoft/vscode-python

Use pytest hooks for test execution instead of scraping the output

Here you go https://github.com/microsoft/vscode-python/issues/1132 I thought we are doing that today

karrtikr

comment created time in a day

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha b29666a5b139d32c81085b31bb9ed0583efe5a91

Display survey for native notebooks on/after 1st August (#12961) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

view details

push time in 2 days

delete branch DonJayamanne/pythonVSCode

delete branch : changeDateOfSurvey

delete time in 2 days

Pull request review commentmicrosoft/vscode-python

Display survey for native notebooks on/after 1st August

 suite('Data Science - NativeNotebook Survey', () => {         shell = mock<IApplicationShell>();         browser = mock<IBrowserService>();         clock = fakeTimers.install();+        clock.setSystemTime(new Date(2020, 7, 1)); // Survey will work only after 1st August.

No, days are not, start from 1

DonJayamanne

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Display survey for native notebooks on/after 1st August

 suite('Data Science - NativeNotebook Survey', () => {         shell = mock<IApplicationShell>();         browser = mock<IBrowserService>();         clock = fakeTimers.install();+        clock.setSystemTime(new Date(2020, 7, 1)); // Survey will work only after 1st August.

months are 0 based indices in dates. (did mention that earlier when this was brought up https://github.com/microsoft/vscode-python/pull/12961#discussion_r454690622)

DonJayamanne

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Display survey for native notebooks on/after 1st August

 export class NotebookSurveyBanner {         if (!this.enabled || this.disabledInCurrentSession) {             return false;         }+        const currentDate = new Date();+        if (currentDate.getMonth() < 7) {

Won't this be an issue in January? Or am I reading this wrong?

Oops, good pick.

do think that it's 0-11 as I recall. Just needs the year.

Yes months are 0 based indices

DonJayamanne

comment created time in 2 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 17200292d0350ac5064d23b83f393378d1c1ffe2

Update src/client/datascience/notebook/survey.ts Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

view details

push time in 2 days

Pull request review commentmicrosoft/vscode-python

Fixes for persisting trust

 export class NativeEditorStorage implements INotebookStorage {         );     } +    private async loadContents(+        file: Uri,+        contents: string | undefined,+        isInitiallyDirty = false,+        trueContents?: string,+        forVSCodeNotebook?: boolean+    ) {+        const model = await this.generateModel(file, contents, isInitiallyDirty, forVSCodeNotebook);+        // If no contents or untitled, this is a newly created file, so the model should remain trusted+        if (contents !== undefined && !isUntitledFile(file)) {+            /* As an optimization, we don't call trustNotebook for hot exit, since our hot exit backup code gets called by VS+            Code whenever the notebook model changes. This means it's called very often, perhaps even as often as autosave.+            Instead, when loading a file that is dirty, we check if the actual file contents on disk are trusted. If so, we treat+            the dirty contents as trusted as well. */+            const contentsToCheck =+                isInitiallyDirty && trueContents !== undefined

If the file is initiallyDirty shouldn't the notebook be trusted automatically? Cuz after all, the user made the changes, thats how it ended up in the dirty store.

Feels unnecessary when reloading VS Code and opening a dirty notebook with a not trusted prompt.

joyceerhl

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Fixes for persisting trust

 export class NativeEditorStorage implements INotebookStorage {         );     } +    private async loadContents(+        file: Uri,+        contents: string | undefined,+        isInitiallyDirty = false,+        trueContents?: string,+        forVSCodeNotebook?: boolean+    ) {+        const model = await this.generateModel(file, contents, isInitiallyDirty, forVSCodeNotebook);+        // If no contents or untitled, this is a newly created file, so the model should remain trusted+        if (contents !== undefined && !isUntitledFile(file)) {+            /* As an optimization, we don't call trustNotebook for hot exit, since our hot exit backup code gets called by VS+            Code whenever the notebook model changes. This means it's called very often, perhaps even as often as autosave.+            Instead, when loading a file that is dirty, we check if the actual file contents on disk are trusted. If so, we treat+            the dirty contents as trusted as well. */+            const contentsToCheck =+                isInitiallyDirty && trueContents !== undefined+                    ? (await this.generateModel(file, trueContents, isInitiallyDirty, forVSCodeNotebook)).getContent()+                    : model.getContent();+            model.update({+                source: 'user',+                kind: 'updateTrust',+                oldDirty: model.isDirty,+                newDirty: model.isDirty,+                isNotebookTrusted: await this.trustService.isNotebookTrusted(file, contentsToCheck)

Why do we need to perform an update if the notebook is not trusted?

joyceerhl

comment created time in 2 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 0868f780c8bea29b6cdd369ea3289f92c23bf921

Display survey only on/after August

view details

push time in 2 days

create barnchDonJayamanne/pythonVSCode

branch : changeDateOfSurvey

created branch time in 2 days

create barnchDonJayamanne/pythonVSCode

branch : nbActivityBarUI

created branch time in 2 days

PR merged microsoft/vscode-python

Reviewers
Hide editor icons when editor is not a notebook (#12934) skip news

Hide editor icons when editor is not a notebook (#12934)

+3 -3

1 comment

1 changed file

DonJayamanne

pr closed time in 2 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha ecc5c8e047a92c80f4ec11953357f9993bdd6fd6

Hide editor icons when editor is not a notebook (#12934) (#12935)

view details

push time in 2 days

delete branch microsoft/vscode-python

delete branch : thirdSetOfFixes1

delete time in 2 days

issue commentmicrosoft/vscode-python

Altair does not work in new VS code editor

Yup, found this happens because require.js is not registered. Should be an easy enough fix. Screen Shot 2020-07-13 at 15 07 35

rchiodo

comment created time in 3 days

issue commentmicrosoft/vscode-python

Altair does not work in new VS code editor

Works for me will try ur code: Screen Shot 2020-07-13 at 14 41 46

rchiodo

comment created time in 3 days

PR opened microsoft/vscode-python

Hide editor icons when editor is not a notebook (#12934)

Hide editor icons when editor is not a notebook (#12934)

+3 -3

0 comment

1 changed file

pr created time in 3 days

create barnchmicrosoft/vscode-python

branch : thirdSetOfFixes1

created branch time in 3 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha ea4a2fb73679d1f9428627c1bd5aaa2ebbcaff81

Hide editor icons when editor is not a notebook (#12934)

view details

push time in 3 days

delete branch DonJayamanne/pythonVSCode

delete branch : hideIcons

delete time in 3 days

PR merged microsoft/vscode-python

Reviewers
Hide editor icons when editor is not a notebook skip news

Looks like we also need to check resourceLangId

+3 -3

1 comment

1 changed file

DonJayamanne

pr closed time in 3 days

PR opened microsoft/vscode-python

Hide editor icons when editor is not a notebook

Looks like we also need to check resourceLangId

+3 -3

0 comment

1 changed file

pr created time in 3 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha d84dc65a51ca810a53a8136277a71987ab185e07

Hide editor icons when editor is not a notebook

view details

push time in 3 days

create barnchDonJayamanne/pythonVSCode

branch : hideIcons

created branch time in 3 days

Pull request review commentmicrosoft/vscode-python

Disable keydown on native cells in untrusted notebooks

 export class NativeCell extends React.Component<INativeCellProps> {      // tslint:disable-next-line: cyclomatic-complexity max-func-body-length     private keyDownInput = (cellId: string, e: IKeyboardEvent) => {+        if (!this.isNotebookTrusted() && !isCellNavigationKeyboardEvent(e)) {

Please ignore the comment, thats why i striked it out.

joyceerhl

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Disable keydown on native cells in untrusted notebooks

 export class NativeCell extends React.Component<INativeCellProps> {      // tslint:disable-next-line: cyclomatic-complexity max-func-body-length     private keyDownInput = (cellId: string, e: IKeyboardEvent) => {+        if (!this.isNotebookTrusted() && !isCellNavigationKeyboardEvent(e)) {

Shouldn't these be checked only if !this.isFocused()

Cuz if a cell is focused, then k might do something else..

joyceerhl

comment created time in 3 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha f0bad89dd2d52e2a8e5bf54dcd36527fd10e471c

Merge more fixes into july release (#12918) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

view details

push time in 3 days

delete branch microsoft/vscode-python

delete branch : mergeMoreFixesIntoJulyRelease

delete time in 3 days

issue openedmicrosoft/vscode-python

Turn off jedi for Native Notebooks

created time in 3 days

Pull request review commentmicrosoft/vscode-python

Merge more fixes into july release

    ([#12732](https://github.com/Microsoft/vscode-python/issues/12732)) 1. Show a prompt asking user to upgrade Code runner to new version to keep using it when in Deprecate PythonPath experiment.    ([#12764](https://github.com/Microsoft/vscode-python/issues/12764))+1. Opening notebooks in the preview Notebook editor for [Visual Studio Code Insiders](https://code.visualstudio.com/insiders/).+   * Install Python extension in the latest [Visual Studio Code Insiders](https://code.visualstudio.com/insiders/).+   * Wait for `Python Extension` to get activated (e.g. open a `Python` file).+   * Right click on an `*.ipynb (Jupyter Notebook)` file and select `Open in preview Notebook Editor`.

We can get rid of these lines in change log. I can do this later when we make the release as well. Not really blocking.

Thanks, don't want to wait for 1+ hrs for PR to go green

DonJayamanne

comment created time in 3 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha 6804b977ca8323ddb6ef1d3d6495b2beb06fbaf8

Update news entry

view details

push time in 3 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha 1d8e5e6da160ff28acf2da9df0ccbc8874a80cd3

Remove news entry

view details

push time in 3 days

create barnchmicrosoft/vscode-python

branch : mergeMoreFixesIntoJulyRelease

created branch time in 3 days

Pull request review commentmicrosoft/vscode-python

Draft: Interactive window multiples

                 "--ui=tdd",
                 "--recursive",
                 "--colors",
-                //"--grep", "<suite name>",
+                "--grep", "Simple text",

Oops

rchiodo

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Draft: Interactive window multiples

 export class InteractiveWindow extends InteractiveBase implements IInteractiveWi      @captureTelemetry(Telemetry.ScrolledToCell)     public scrollToCell(id: string): void {-        this.postMessage(InteractiveWindowMessages.ScrollToCell, { id }).ignoreErrors();+        this.show(false)+            .then(() => {+                return this.postMessage(InteractiveWindowMessages.ScrollToCell, { id });+            })+            .ignoreErrors();+    }++    public hasCell(id: string): Promise<boolean> {+        let deferred = this.pendingHasCell.get(id);+        if (!deferred) {+            deferred = createDeferred<boolean>();+            this.pendingHasCell.set(id, deferred);+            this.postMessage(InteractiveWindowMessages.HasCell, id).ignoreErrors();+        }+        return deferred.promise;     }      public async getOwningResource(): Promise<Resource> {-        if (this.lastFile) {-            return Uri.file(this.lastFile);+        if (this.owner) {

I wish this function getOwningResource was synchronous, feels its unnecessarily async and more of a design issue. Ie we have an editor and we don't know who owns iw, but how can i editor be created without knowing what it belongs to. Had to bring this, cuz i end up with async code in a few places and this seems to come up in a few places (to be the cause).

Anyways, existing code, hopefully we can refactor this out later.

rchiodo

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Disable keydown on native cells in untrusted notebooks

 export class NativeCell extends React.Component<INativeCellProps> { export function getConnectedNativeCell() {     return connect(null, actionCreators)(NativeCell); }++function isNotWhitelistedCommand(e: IKeyboardEvent) {+    return (+        e.code !== 'Enter' &&+        e.code !== 'NumpadEnter' &&+        e.code !== 'ArrowUp' &&+        e.code !== 'ArrowDown' &&+        e.code !== 'j' &&+        e.code !== 'Escape'

I think its better to check if something is a cell navigation shortcut or a cell edit shortcut. This method is a little confusing for me cuz there are two negations, each if condition and then a negation at the method name level.

Also i know ArrowUp or k means select the previous cell. I.e. ArrowUp is a cell navigation, what k is treated as a non-cell navigation key. That doesn't seem right.

I personally think it would be more readable to have a function call ~isCellNavigationKeyboardEvent than doing the negation in the function and naming it as such.

joyceerhl

comment created time in 3 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha ddbe3bee455f58e0057de093ec218d953a7716cb

Disable Notebook icons when Notebook is not trusted (#12894) For #12893

view details

push time in 3 days

delete branch DonJayamanne/pythonVSCode

delete branch : fixCommands

delete time in 3 days

Pull request review commentmicrosoft/vscode-python

Fix regressions in trusted notebooks

 export class NativeEditor extends InteractiveBase implements INotebookEditor {         if (this.previouslyNotTrusted && this.model?.isTrusted) {             this.previouslyNotTrusted = false;             // Tell UI to update main state-            this.postMessage(InteractiveWindowMessages.TrustNotebookComplete).ignoreErrors();+            await this.postMessage(InteractiveWindowMessages.TrustNotebookComplete);

Why do we need to await?

joyceerhl

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Closing a notebook marked as trusted shouldn't trigger the save modal

 export class NativeEditorNotebookModel extends BaseNotebookModel {          // Dirty state comes from undo. At least VS code will track it that way. However         // skip file changes as we don't forward those to VS code-        if (change.kind !== 'save' && change.kind !== 'saveAs') {+        if (change.kind !== 'save' && change.kind !== 'saveAs' && change.kind !== 'updateTrust') {

Looks like this is one of those where a test would have been good. No need of tests now.

joyceerhl

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Recover from ENOENT due to missing parent dir when trusting notebook

 export class DigestStorage implements IDigestStorage {     public async saveDigest(uri: Uri, signature: string) {         const fileLocation = await this.getFileLocation(uri);         // Since the signature is a hex digest, the character 'z' is being used to delimit the start and end of a single digest-        await this.fs.appendFile(fileLocation, `z${signature}z\n`);+        try {+            await this.fs.appendFile(fileLocation, `z${signature}z\n`);+        } catch (err) {+            // The nbsignatures dir is only initialized on extension activation.+            // If the user deletes it to reset trust, the next attempt to trust+            // an untrusted notebook in the same session will fail because the parent+            // directory does not exist.+            if (isFileNotFoundError(err)) {+                // Gracefully recover from such errors by reinitializing directory and retrying+                await this.initDir();

Why not do this in the getFileLocation. i think its the responsiblity of getFileLocation to do this work. Else when we use this getFileLocation from another method we need to call initDir again.

joyceerhl

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Disable keydown on native cells in untrusted notebooks

 export class NativeCell extends React.Component<INativeCellProps> { export function getConnectedNativeCell() {     return connect(null, actionCreators)(NativeCell); }++function isNotWhitelistedCommand(e: IKeyboardEvent) {

Thanks but when looking at the code it is not obvious, i'd like a better name. E.g. isCellNavigationKeyboardEvent

joyceerhl

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Disable keydown on native cells in untrusted notebooks

 export class NativeCell extends React.Component<INativeCellProps> {      // tslint:disable-next-line: cyclomatic-complexity max-func-body-length     private keyDownInput = (cellId: string, e: IKeyboardEvent) => {+        if (!this.isNotebookTrusted() && isNotWhitelistedCommand(e)) {

Looks like we need a better property. I think what we're after is readonly. I.e. if a cell is readonly, then some keyboard shortcuts cannot be handled & the like.

Cuz the requirement is when a notebook is not trusted, then treat it as readonly, right now, when a notebook is not trusted, then ignore some keys, etc. I know its laet for this change to be made, hence I wouldn't change it now, as it needs to be done across the UI.

joyceerhl

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Disable keydown on native cells in untrusted notebooks

 export class NativeCell extends React.Component<INativeCellProps> { export function getConnectedNativeCell() {     return connect(null, actionCreators)(NativeCell); }++function isNotWhitelistedCommand(e: IKeyboardEvent) {

In what context is a whiteListedCommand used? it mean be anything. is it a list of commands excluded when a notebook is running, disabled, kernel is busy, no kernel, etc.

joyceerhl

comment created time in 3 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha bfa3c82541f0640b16a6668ca11abf58cf050a80

Merge fixes into July release (#12889) Co-authored-by: Timothy Ruscica <35348871+techwithtim@users.noreply.github.com>

view details

push time in 3 days

delete branch microsoft/vscode-python

delete branch : mergeIntoJulyRelease

delete time in 3 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha ad8d4c18f8641f9e28df44f298064b4b6bdee22c

Fixes

view details

Don Jayamanne

commit sha c8199df2b16803c7bc6abd0c7d8cbafc26e08788

News

view details

push time in 6 days

issue openedmicrosoft/vscode-python

VSC Notebook command enablement

  • Hide Trusted icon
  • Disable/hide export when notebook is not trusted
  • Display icons only for Jupyter (our) Notebooks

created time in 6 days

create barnchDonJayamanne/pythonVSCode

branch : fixCommands

created branch time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha aba1d20271963a6fb1ce5932152d3a1dfa5194b4

Add trust feature for VS Code Notebooks (#12818)

view details

Don Jayamanne

commit sha 85ee01c76b098616ba93b8e4600570cb70ddbee5

Update warning message when opening nb in two different editors (#12883)

view details

Timothy Ruscica

commit sha 2eaf364bb1adfa9039d82adf5be7f4ce14d33bfc

Made exporting notebooks cancellable (#12863) * made export cancellable * some small fixes * removed monaco editor import * changed deleting method * made export to temp file first * removed unused action * removed unused types

view details

Janosh Riebesell

commit sha 78d567197d3e544c102b4382923189763a8a79ec

add option to set dataScience.runStartupCommands as array (#12841) * add option to set dataScience.runStartupCommands as array (#12827) * appease hygiene CI with if statement braces :) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> * add news entry * add functional test for runStartupCommands * fix linter issue (hopefully) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

view details

push time in 6 days

issue openedmicrosoft/vscode-python

Display editor icons when notebook is active

Currently we display icons when a cell is active not when a notebook is active.

created time in 6 days

push eventmicrosoft/vscode-python

Timothy Ruscica

commit sha 2dd570b62c262bd0497b79ba9b64a003f5715b44

fixed tests (#12886)

view details

push time in 6 days

create barnchmicrosoft/vscode-python

branch : mergeIntoJulyRelease

created branch time in 6 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha 85ee01c76b098616ba93b8e4600570cb70ddbee5

Update warning message when opening nb in two different editors (#12883)

view details

push time in 6 days

delete branch DonJayamanne/pythonVSCode

delete branch : udpateMessage

delete time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 336842bbb65143892b0f936b389be6a29e78eee2

Ability to export VS Code Native notebooks (#12879)

view details

Don Jayamanne

commit sha 9e4e356063adf81a9adaacea29dbc64f4a1c0330

Fixes to exporting of notebook to html (#12882) Ensure we have file extensions for the source ipynb Ensure we have file extensions for the target html/pdf files Misc cleanup

view details

push time in 6 days

delete branch DonJayamanne/pythonVSCode

delete branch : trustnb

delete time in 6 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha aba1d20271963a6fb1ce5932152d3a1dfa5194b4

Add trust feature for VS Code Notebooks (#12818)

view details

push time in 6 days

PR merged microsoft/vscode-python

Reviewers
Add trust feature for VS Code Notebooks skip news

For #10496

  • Adds support for trusted notebooks

Please review after ignoring white space

+829 -246

1 comment

35 changed files

DonJayamanne

pr closed time in 6 days

PR opened microsoft/vscode-python

Update message

For #12842

+2 -2

0 comment

2 changed files

pr created time in 6 days

more