profile
viewpoint
Phil Estes estesp @IBM Virginia, USA https://estesp.dev Senior developer/technical leader at @IBM. Work on @docker, maintainer for @moby and @containerd. Focus on containers, cloud, Linux OS. CNCF Ambassador.

pull request commentcontainerd/containerd

[release/1.3] Prepare v1.3.1 release

Before we release, we should consider if anything needs to be done re: #3556. It turns out that changes in this area broke registries that did work in 1.2.x and as people upgrade, clusters that used to work can't pull images anymore. It is correct that JFrog has a fix in process, but rolling out registries may take some time.

thaJeztah

comment created time in 8 hours

push eventcontainerd/containerd

Lantao Liu

commit sha 3db1c3b8f406edf9e59714d0c65c2fdb37a18d65

Better support windows binaries. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Phil Estes

commit sha 2a60547b4eb4b37967f4fd4fa589d4d328ff2653

Merge pull request #3823 from Random-Liu/better-support-windows-build Better support windows binaries.

view details

push time in 8 hours

PR merged containerd/containerd

Better support windows binaries.

make clean and make install doesn't work for .exe binaries with linux shell today.

This fixed it. Please note that I'm not a Makefile expert, feel free to propose a better solution. :)

Signed-off-by: Lantao Liu lantaol@google.com

+13 -6

3 comments

2 changed files

Random-Liu

pr closed time in 8 hours

PR opened containerd/containerd

Update name for btrfs headers package

Change noted in #3814 is also needed in our contributed Dockerfile.test. Left the btrfs-progs as an install candidate for potential use for debugging even though not required to compile the daemon.

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

+2 -1

0 comment

1 changed file

pr created time in 3 days

create barnchestesp/containerd

branch : fix-Dockerfile

created branch time in 3 days

push eventcontainerd/containerd

Sebastiaan van Stijn

commit sha 9488dd85eea3076311d6153dba37a26144594c8c

Revert "[release/1.3] pin travis to go 1.12.12" This reverts commit 7f6f2c7d4fbcae8d95b4561107400e0d77701a29. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha f7e59ae1a315f040b52e3aa1de25b185dc6aea31

Update to Golang 1.12.13 go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina where the non-notarized installer and binaries were being rejected by Gatekeeper. Only macOS users who hit this issue need to update. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 15669a1d34e904b4e45c85f763df2098e706ffb0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Phil Estes

commit sha 54658b8831a7382bc79bf0b11ca591951c56aa6b

Merge pull request #3808 from thaJeztah/1.3_backport_bump_golang_1.12.13 [release/1.3 backport] Update to Golang 1.12.13

view details

push time in 3 days

PR merged containerd/containerd

[release/1.3 backport] Update to Golang 1.12.13

backport of https://github.com/containerd/containerd/pull/3806 for the 1.3 release branch

go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina where the non-notarized installer and binaries were being rejected by Gatekeeper. Only macOS users who hit this issue need to update.

+3 -3

4 comments

3 changed files

thaJeztah

pr closed time in 3 days

push eventestesp/playground

Phil Estes

commit sha ae3621a576e181a974c3eb746b008e58bee357eb

Add seccomp example Signed-off-by: Phil Estes <estesp@gmail.com>

view details

push time in 4 days

push eventestesp/playground

Phil Estes

commit sha f7a8f1decbdf2bed4386fcb49a789765d715862e

Demo and examples for talk Signed-off-by: Phil Estes <estesp@gmail.com>

view details

push time in 4 days

push eventestesp/containerd

Michael Crosby

commit sha 0f4374169e10ee6f99a46c27b3ae752c4201e216

Add proto path /usr/include to Protobuild This fixes proto compiles on alpine based systems. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Maksym Pavlenko

commit sha c038a7c4b18d7a3143b5bd75152b250208385300

Merge pull request #3803 from crosbymichael/proto-paths Add proto path /usr/include to Protobuild

view details

Akihiro Suda

commit sha 7f5d900769ad02eb339ff2b8ed191af13d663464

ctr: allow specifying --runc-binary Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Akihiro Suda

commit sha 8f74de9e9e4aecbf5d0fe98af3e2b9c5f7a6cc14

ctr: allow specifying --runc-systemd-cgroup Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Phil Estes

commit sha 1e1285483179a739425dfd8770894a7752f842f2

Merge pull request #3805 from AkihiroSuda/ctr-shim2-runc-flags ctr: add --runc-binary --runc-systemd-cgroup

view details

Sebastiaan van Stijn

commit sha 15669a1d34e904b4e45c85f763df2098e706ffb0

Update to Golang 1.12.13 go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina where the non-notarized installer and binaries were being rejected by Gatekeeper. Only macOS users who hit this issue need to update. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Michael Crosby

commit sha 40ac9239a8b4e5f10d5f5a42293ec650f8ebc70c

Merge pull request #3806 from thaJeztah/bump_golang_1.12.13 Update to Golang 1.12.13

view details

push time in 4 days

push eventcontainerd/cgroups

Michael Crosby

commit sha 7209a8dfde2726fa544906fc061605e43e798b1d

Add v2 io support Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Michael Crosby

commit sha 684eefa15a1bae5f170f96cb7dddfc3c4abf599c

Add mapping to stats struct Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Phil Estes

commit sha 4baafdb2bf451498eae2a8b3620cff8755b4628c

Merge pull request #112 from crosbymichael/io Add v2 io support

view details

push time in 4 days

PR merged containerd/cgroups

Add v2 io support

Signed-off-by: Michael Crosby crosbymichael@gmail.com

+1318 -711

1 comment

8 changed files

crosbymichael

pr closed time in 4 days

push eventcontainerd/containerd

Akihiro Suda

commit sha 7f5d900769ad02eb339ff2b8ed191af13d663464

ctr: allow specifying --runc-binary Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Akihiro Suda

commit sha 8f74de9e9e4aecbf5d0fe98af3e2b9c5f7a6cc14

ctr: allow specifying --runc-systemd-cgroup Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Phil Estes

commit sha 1e1285483179a739425dfd8770894a7752f842f2

Merge pull request #3805 from AkihiroSuda/ctr-shim2-runc-flags ctr: add --runc-binary --runc-systemd-cgroup

view details

push time in 5 days

PR merged containerd/containerd

ctr: add --runc-binary --runc-systemd-cgroup

from https://github.com/containerd/containerd/pull/3799

+31 -2

3 comments

1 changed file

AkihiroSuda

pr closed time in 5 days

Pull request review commentcontainerd/containerd

Support target snapshot references on prepare

 func (s *snapshotter) Close() error { }  // filterInheritedLabels filters the provided labels by removing any key which doesn't have-// a prefix of "containerd.io/snapshot/".+// a prefix of "containerd.io/snapshot/" or is "containerd.io/snapshot.ref" .

for clarity remove the word is so that it reads a prefix of ".." or "..".

dmcgowan

comment created time in 5 days

Pull request review commentcontainerd/containerd

Support target snapshot references on prepare

 func (s *snapshotter) Commit(ctx context.Context, name, key string, opts ...snap  		inheritedOpt := snapshots.WithLabels(filterInheritedLabels(base.Labels)) -		// TODO: Consider doing this outside of transaction to lessen-		// metadata lock time-		return s.Snapshotter.Commit(ctx, nameKey, bkey, inheritedOpt)-	})+		// NOTE: Backend snapshotters should commit fast and reliably to+		// prevent metadata store locking and minimizing rollbacks.+		// This operation should be done in the transaction to minimize the+		// risk of the committed keys becoming out of sync. If this operation+		// succeed and the overall transaction fails then the risk of out of+		// sync data is higher and may require manual cleanup.+		if err := s.Snapshotter.Commit(ctx, nameKey, bkey, inheritedOpt); err != nil {+			if errdefs.IsNotFound(err) {+				log.G(ctx).WithField("snapshotter", s.name).WithField("key", key).WithError(err).Error("uncommittable snapshot: missing in backend, snapshot should be removed")+			}+			// NOTE: Consider handling already exists here from the backend. Currently+			// already exists from the backend may be confusing to the client since it+			// may require the client to re-attempt from prepare. However, if handling+			// here it is not clear what happened with the existing backend key and+			// whether the already prepared snapshot would still be used or must be+			// discarded. It is best that all implementations of the snapshotter+			// interface behave the same, in which case the backend should handle the+			// mapping of duplicates and not error.+			return err+		}+		bname = nameKey++		return nil+	}); err != nil {+		if bname != "" {+			log.G(ctx).WithField("snapshotter", s.name).WithField("key", key).WithField("bname", bname).WithError(err).Error("uncommittable snaphost: transaction failed after commit, snapshot should be removed")

minor typo, but could be confusing when searching for errors: s/snaphost/snapshot/

dmcgowan

comment created time in 5 days

push eventcontainerd/cgroups

Michael Crosby

commit sha 8e6ae5fe16fe1193771e8a14f79bf2f51e92b9f5

Add ToResources func for spec to v2.Resources Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Phil Estes

commit sha 3ecfbc409fb699785831415dd204dc355c738e2b

Merge pull request #111 from crosbymichael/to-res Add ToResources func for spec to v2.Resources

view details

push time in 6 days

PR merged containerd/cgroups

Add ToResources func for spec to v2.Resources

Signed-off-by: Michael Crosby crosbymichael@gmail.com

+55 -0

1 comment

2 changed files

crosbymichael

pr closed time in 6 days

push eventestesp/containerd

Phil Estes

commit sha 76aa4e546ef4d3d8f35e525ebe93ec3ee879662a

Use common identifiers package with less restrictive regex Regular expressions in the namespaces package are redundant with the pre-existing validator in the "identifiers" package; replace this custom usage with the validator in "identifiers" Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Phil Estes

commit sha fdf7a795bce4abb9488f19a9c4f71f944f0ab00c

Clarify requirements for identifiers validation Fix commentary to be clear that the RFC1035 2.3.1 rules are not explicitly enforced by the identifiers regex. Add a test to show the lessened restrictions for digits to follow hyphen and period. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Michael Crosby

commit sha 356702098d777c5f288262fa5c141bb8f05b0572

Merge pull request #3798 from estesp/common-indentifiers Common identifiers validation

view details

Johann Neuhauser

commit sha 4c99c81326f4026fb8c0b8c5e10542205d99c321

mips: -buildmode=pie is not supported for the mips arch Signed-off-by: Johann Neuhauser <johann@it-neuhauser.de>

view details

Michael Crosby

commit sha c80fa7df17ad8979c2e45a3550d561aa1151b85f

Merge pull request #3801 from jneuhauser/arch-mips mips: -buildmode=pie is not supported for the mips arch

view details

push time in 6 days

push eventcontainerd/cgroups

Michael Crosby

commit sha 3239d7b8395519d4951e886a03ac74c79543c04b

Simpler v2 cgroup interface The resource type is changed in this but I would rather have a v2 native Resource type and do a mapping from an OCI spec's resource to the v2.Resource type. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Michael Crosby

commit sha 7bf30d7bf13852d1f2b493817489d37170d2b8a4

Rename playground to cgctl Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Michael Crosby

commit sha 54a40c2af707f9ee43f6fa28f4ab6c0a79789f34

Add basic stats implementation Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Phil Estes

commit sha 82928e855c6c9fa78d1e0767c46e1b05168d623d

Merge pull request #109 from crosbymichael/v2-controller Simpler v2 cgroup interface

view details

push time in 6 days

PR merged containerd/cgroups

Simpler v2 cgroup interface

The resource type is changed in this but I would rather have a v2 native Resource type and do a mapping from an OCI spec's resource to the v2.Resource type.

ref #104

Signed-off-by: Michael Crosby crosbymichael@gmail.com

+569 -1209

5 comments

17 changed files

crosbymichael

pr closed time in 6 days

push eventestesp/playground

Phil Estes

commit sha a6730605952e1ff055fe634a5317a19baf2be164

Add image base examples Add several image base examples including building a static binary with "scratch"/empty container filesystem Signed-off-by: Phil Estes <estesp@gmail.com>

view details

push time in 7 days

push eventestesp/playground

Phil Estes

commit sha dac2a4f7ea246a568966736210b7986cbcb203b6

Clean up repo README and remove contributing guide Signed-off-by: Phil Estes <estesp@gmail.com>

view details

push time in 7 days

push eventcontainerd/cgroups

bpopovschi

commit sha 2843dfa2072234f2b2849be0cae35589c4b19ad2

Added cgroup v2 memory implementation Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

Phil Estes

commit sha 010a0d6a188e2bed91cef77126fd6604a7518cf8

Merge pull request #108 from Zyqsempai/104-added-memory-cgroup2-impl Added cgroup v2 memory implementation

view details

push time in 8 days

PR merged containerd/cgroups

Added cgroup v2 memory implementation

for #104 Added cgroup v2 memory implementation

Signed-off-by: bpopovschi zyqsempai@mail.ru

+1055 -38

4 comments

7 changed files

Zyqsempai

pr closed time in 8 days

Pull request review commentcontainerd/cgroups

Added cgroup v2 memory implementation

+/*+   Copyright The containerd Authors.++   Licensed under the Apache License, Version 2.0 (the "License");+   you may not use this file except in compliance with the License.+   You may obtain a copy of the License at++       http://www.apache.org/licenses/LICENSE-2.0++   Unless required by applicable law or agreed to in writing, software+   distributed under the License is distributed on an "AS IS" BASIS,+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+   See the License for the specific language governing permissions and+   limitations under the License.+*/++package v2++import (+	"bufio"+	"io/ioutil"+	"os"+	"path/filepath"+	"strconv"+	"strings"++	statsv2 "github.com/containerd/cgroups/v2/stats"+	specs "github.com/opencontainers/runtime-spec/specs-go"+)++// NewMemory returns a Memory controller given the root folder of cgroups.+func NewMemory(unifiedMountpoint string) (*memoryController, error) {+	mc := &memoryController{+		unifiedMountpoint: unifiedMountpoint,+	}+	ok, err := mc.Available("/")+	if err != nil {+		return nil, err+	}+	if !ok {+		return nil, ErrCPUNotSupported

This should be ErrMemoryNotSupported

Zyqsempai

comment created time in 8 days

push eventestesp/cgroups

gpanouts

commit sha a31a0ff985237eddf30d9fe30a3643c7da4ae912

Add functionality for retrieving all tasks of a cgroup Signed-off-by: Georgia Panoutsakopoulou <gpanoutsak@gmail.com>

view details

Phil Estes

commit sha c0437c3dd5958f74d7f54e9f5def749850b9d6a1

Merge pull request #67 from gpanouts/get-all-cgroup-tasks Add functionality for retrieving all tasks of a cgroup

view details

Cedric Clerget

commit sha 6b552a86e60e31903d3f8f3f494eda71f562cc54

Fix net_prio typo Signed-off-by: Cedric Clerget <cedric.clerget@gmail.com>

view details

Phil Estes

commit sha 3bc6dde829bc2dc8d4097ce8ad5acc275de3df06

Merge pull request #68 from cclerget/master-net_prio-typo Fix net_prio typo

view details

Gábor Lipták

commit sha b49c4713f3824e81bfa67faddcdde1414171b54e

Correct ineffassign warning Signed-off-by: Gábor Lipták <gliptak@gmail.com>

view details

Cedric Clerget

commit sha 64bade4cea6c438ee51a7a12528225946b42c6ca

Take value instead of pointer value Signed-off-by: Cedric Clerget <cedric.clerget@gmail.com>

view details

Phil Estes

commit sha 10cd53efd916e22b9bdea67223d287684f57f1f4

Merge pull request #70 from gliptak/patch-1 Correct ineffassign warning

view details

JoeWrightss

commit sha f48bd85c9cbc306fada0cebc3a646a1f1fe99afe

Fixs return error message Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io>

view details

Daniel, Dao Quang Minh

commit sha 0f372c6d4a65a49c72b0afbd1aee6214637958bf

Merge pull request #71 from JoeWrightss/patch-1 Fixs return error message

view details

Daniel, Dao Quang Minh

commit sha 65ce98b3dfeb0a9a8fecd7e4ebffb24ad0bfe28f

Merge pull request #69 from cclerget/master-weight-pointer Blkio weight/leafWeight pointer value

view details

Gábor Lipták

commit sha afd5981a16647b45b6dba3a50a88418b576cc17d

Gofmt cgroup_test Signed-off-by: Gábor Lipták <gliptak@gmail.com>

view details

Michael Crosby

commit sha 1152b960fcee041f50df15cdc67c29dbccf801ef

Merge pull request #73 from gliptak/gofmt1 Gofmt cgroup_test

view details

Gábor Lipták

commit sha 2fd912c91be97dc5fb77b444aa2694e6538c662d

Add tests for pids Signed-off-by: Gábor Lipták <gliptak@gmail.com>

view details

Phil Estes

commit sha 39b18af02c4120960f517a3a4c2588fabb61d02c

Merge pull request #72 from gliptak/pids1 Add tests for pids

view details

Michael Crosby

commit sha 4dacf2bc1300b0d7dc1087b8e27712a597890ba3

Check for non-active/supported cgroups Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Michael Crosby

commit sha 4a9f0f7346a74278d670e53b00ba011cd8647448

Add SkipOpts for handling how subsystems are registered This adds a flexible way for subsystems to be skipped or required within the cgroups package. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Michael Crosby

commit sha dbea6f2bd41658b84b00417ceefa416b979cbf10

Merge pull request #77 from crosbymichael/non-active Check for non-active/supported cgroups

view details

Michael Crosby

commit sha 453efe3313d53f746614e80c3d59860c1ca02d3e

Return ErrCgroupDeleted when no subsystems Return the error when 0 subsystems are active signaling that the cgroup has been deleted. Fix for: https://github.com/containerd/containerd/issues/3133 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Derek McGowan

commit sha 4994991857f9b0ae8dc439551e8bebdbb4bf66c1

Merge pull request #79 from crosbymichael/load-none Return ErrCgroupDeleted when no subsystems

view details

ZeroMagic

commit sha 1741ae0c1998a5fcdbb3c8b2a164113a8fabef89

add network stats Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>

view details

push time in 8 days

push eventestesp/containerd

Phil Estes

commit sha 76aa4e546ef4d3d8f35e525ebe93ec3ee879662a

Use common identifiers package with less restrictive regex Regular expressions in the namespaces package are redundant with the pre-existing validator in the "identifiers" package; replace this custom usage with the validator in "identifiers" Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Phil Estes

commit sha fdf7a795bce4abb9488f19a9c4f71f944f0ab00c

Clarify requirements for identifiers validation Fix commentary to be clear that the RFC1035 2.3.1 rules are not explicitly enforced by the identifiers regex. Add a test to show the lessened restrictions for digits to follow hyphen and period. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

push time in 8 days

PR opened containerd/containerd

Common identifiers validation

Fixes #3797

Rather than keep two similar but slightly divergent regular expression validators, I propose we ditch the namespaces validator and use the pre-existing identifiers package in namespaces like it is used elsewhere. Neither validation was actually keeping to RFC 1035 section 2.3.1 rules, so I also clarified the commentary in the identifiers package and added a test to show the validity of numerals following periods.

+8 -160

0 comment

5 changed files

pr created time in 8 days

create barnchestesp/containerd

branch : common-indentifiers

created branch time in 8 days

push eventestesp/containerd

fahedouch

commit sha 7c016b655b54efd5a4bb97a5a3a0f92c0df9c06c

add tests to server_test Signed-off-by: fahedouch <fahed.dorgaa@gmail.com>

view details

Michael Crosby

commit sha f9d8f0e56ee43594ec529c4d28aec7be7343cd36

Merge pull request #3794 from fahedouch/server_test add tests to server_test

view details

Michael Crosby

commit sha 84879b7c48bfbf33984a55054519ee122d7be3a7

Add CGO makefile flag Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

Derek McGowan

commit sha 4d7739527e1d7a328bfc31e905f9825c5b3afefc

Merge pull request #3796 from crosbymichael/cgo Add CGO makefile flag

view details

push time in 8 days

issue commentcontainerd/containerd

Cannot follow hyphens or periods with numbers in namespaces

looks like you are correct that the regex has been simplified to disallow digits after . or -, whereas the RFC permits digits after hyphen. If that is corrected is that sufficient? Digits after . would still be disallowed.

rcgoodfellow

comment created time in 8 days

issue commentcontainerd/containerd

Cannot follow hyphens or periods with numbers in namespaces

This comment explains the source of the rules (a specific RFC for domains): https://github.com/containerd/containerd/blob/master/namespaces/validate.go#L45-L46

Let us know if there is a specific use case where this is burdensome. I assume picking a standing RFC was simply a reasonable starting point for having some semblance of rules for namespace names.

rcgoodfellow

comment created time in 8 days

issue commentcontainerd/project

Adding ttrpc-rust as sub-project

@crosbymichael should we open a separate issue with a formal proposal for a vote? I think other than what we already know about the project, we would want a list of potential maintainers (so far @teawater is the only contributor to the existing project I think?) and agreement to add the boilerplate re: CNCF code of conduct and containerd governance.

teawater

comment created time in 9 days

push eventfahedouch/containerd

fahedouch

commit sha 7c016b655b54efd5a4bb97a5a3a0f92c0df9c06c

add tests to server_test Signed-off-by: fahedouch <fahed.dorgaa@gmail.com>

view details

push time in 9 days

push eventestesp/containerd

Akihiro Suda

commit sha f593efdf0c160037c9f831983f62537285739b03

RELEASES.md: 1.1 EOL v1.1 reached EOL on October 23, 2019 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Michael Crosby

commit sha edb6f2344a3629ada21b0f267e4db87161e859db

Merge pull request #3780 from AkihiroSuda/1.1-eol RELEASES.md: 1.1 EOL

view details

Manuel Rüger

commit sha 5e5584196b3ca6b9ccfd2fa8603a9b7d25746997

Makefile: Drop vndr whitelist Since autocompletions moved to contrib/ in https://github.com/containerd/containerd/pull/3766 Signed-off-by: Manuel Rüger <manuel@rueg.eu>

view details

Michael Crosby

commit sha cedd3cb16c37d266de18dfda1b8aed71b1d998e0

Merge pull request #3782 from mrueg/vndr-autocompl Makefile: Drop vndr whitelist

view details

Tibor Vass

commit sha d12b53a072dd67aad37046bb4437043fe02d0419

ppc64: -buildmode=pie is not supported I needed this patch to compile containerd for ppc64. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Lantao Liu

commit sha 78be736622e3eaf5b1f7c9030a930c0b916453bf

Return not found error if no platform matched. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Michael Crosby

commit sha 62b13256efd11fafd739fc60c5067430574422ec

Merge pull request #3786 from Random-Liu/not-found-error-if-no-platform Return not found error if no platform matched.

view details

Michael Crosby

commit sha 4a1a1bc626830b0a9d0efc8ae154e30d3486d742

Merge pull request #3784 from tiborvass/ppc64 ppc64: -buildmode=pie is not supported

view details

Akihiro Suda

commit sha a2688b972c36bc88407591898fb84f478d3790d2

bring back aufs and zfs Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Phil Estes

commit sha 342ce3e602d13a05b13c7cb642aba5996315e02f

Merge pull request #3789 from AkihiroSuda/vendor-20191030 bring back aufs and zfs

view details

Ameya Gawde

commit sha d21f0f116e29e498eeebf8440e9f43a06cf39cfc

windows process shim installer Signed-off-by: Ameya Gawde <ameya.gawde@docker.com>

view details

Maksym Pavlenko

commit sha 257a7498d00827fbca08078f664cc6b4be27d7aa

Merge pull request #3790 from ameyag/windows-shim-install Windows process shim installer

view details

push time in 12 days

pull request commentcontainerd/containerd

add tests to server_test

Not sure why the new imports came in as they appear to not be used:

GOGC=75 golangci-lint run
services/server/server_test.go:20:2: "context" imported but not used (typecheck)
	"context"
	^
services/server/server_test.go:21:2: "github.com/containerd/containerd/plugin" imported but not used (typecheck)
	"github.com/containerd/containerd/plugin"
	^
Makefile:123: recipe for target 'check' failed
make: *** [check] Error 1
The command "make check" exited with 2.
fahedouch

comment created time in 12 days

startedinlets/inlets

started time in 14 days

push eventcontainerd/containerd

Akihiro Suda

commit sha a2688b972c36bc88407591898fb84f478d3790d2

bring back aufs and zfs Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Phil Estes

commit sha 342ce3e602d13a05b13c7cb642aba5996315e02f

Merge pull request #3789 from AkihiroSuda/vendor-20191030 bring back aufs and zfs

view details

push time in 14 days

PR merged containerd/containerd

bring back aufs and zfs

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

+2517 -9

2 comments

16 changed files

AkihiroSuda

pr closed time in 14 days

pull request commentcontainerd/imgcrypt

Readme file update.

These projects require "Signed-off-by:" lines on the commit; you can probably merge your 2 commits (I'm not sure why the one change ended up as 2 commits) and then git commit --amend -s and it will automatically sign with your name and email address, assuming you have git set up with that info.

Let me know if you need any help merging the commits or simply dropping the "merge" commit.

syedqamar

comment created time in 15 days

Pull request review commentcontainerd/containerd.io

Added aria-label tags for twitter image in home page

         <div class="navbar-item">           <div class="field is-grouped">             <p class="control">-              <a class="button has-background-twitter-blue is-borderless has-text-white" href="{{ $twitterUrl }}">+              <a class="button has-background-twitter-blue is-borderless has-text-white" aria-label="Know more in twitter" href="{{ $twitterUrl }}">                 <span class="icon">                   <i class="fab fa-twitter" aria-hidden="true"></i>                 </span>               </a> -              <a class="button is-borderless has-background-black has-text-white" href="{{ $githubUrl }}">+              <a class="button is-borderless has-background-black has-text-white"  aria-label="Know more in Github" href="{{ $githubUrl }}">

"Visit our project on GitHub"

surya474

comment created time in 16 days

Pull request review commentcontainerd/containerd.io

Added aria-label tags for twitter image in home page

         <div class="navbar-item">           <div class="field is-grouped">             <p class="control">-              <a class="button has-background-twitter-blue is-borderless has-text-white" href="{{ $twitterUrl }}">+              <a class="button has-background-twitter-blue is-borderless has-text-white" aria-label="Know more in twitter" href="{{ $twitterUrl }}">

"Follow us on Twitter"

surya474

comment created time in 16 days

Pull request review commentcontainerd/containerd.io

Added aria-label tags for twitter image in home page

             </span>           </a> -          <a class="button is-borderless has-background-black has-text-white" href="{{ $githubUrl }}">+          <a class="button is-borderless has-background-black has-text-white"  aria-label="Know more in Github" href="{{ $githubUrl }}">

"Visit our project on GitHub"

surya474

comment created time in 16 days

Pull request review commentcontainerd/containerd.io

Added aria-label tags for twitter image in home page

         <hr class="hr has-background-grey">          <div class="buttons">-          <a class="button has-background-twitter-blue is-borderless has-text-white" href="{{ $twitterUrl }}">+          <a class="button has-background-twitter-blue is-borderless has-text-white" aria-label="Know more in twitter" href="{{ $twitterUrl }}">

"Follow us on Twitter"

surya474

comment created time in 16 days

push eventestesp/containerd

Justin Terry (VM)

commit sha 178469e2ae5b7edd9e55601415fe9f494ab22b9a

Update Microsoft/hcsshim vendor Updates Microsoft/hcsshim vendor commit hash to a recent version that now: 1. Supports container stats via the Stats RuntimeV2 gRPC call. 2. Fixes a regression when issuing a resize of the pty after the container has exited which previously in Docker was expected to be a non-error case. 3. Puts in a workaround when using a non-default sandbox size for Windows containers due to a platform bug. This expansion now happens in the go library itself. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>

view details

Justin Terry (VM)

commit sha 37b56cafc63445721c4475eea4e0994de3ed5118

Add ctr metrics support for Windows/LCOW containers Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>

view details

Akihiro Suda

commit sha 966b1b8e30c9ccf7e0f3127da08d4db30133e3bc

Merge pull request #3775 from jterry75/vendor_hcsshim Update Microsoft/hcsshim vendor

view details

Akihiro Suda

commit sha c224edc5c6350026a7d35a09dce638b0f09e6d44

apply: use naive applier when running in UserNS `OverlayConvertWhiteout` calls `mknod c 0 0` which is not allowed when running in a user namespace, even in Ubuntu kernel. Although there is an alternative hacky way to create whiteouts without calling mknod as Moby `overlay2` actually does(see #3762), let's use naive applier when running in UserNS and call it a day. Close #3762 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Lantao Liu

commit sha aaccfcbe2b8792e5fa3711811f3025562485e8bb

Fix `containerd config dump`. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Phil Estes

commit sha f05e19c5c6fa330753b84fe200f887cb3d62df41

Merge pull request #3777 from Random-Liu/fix-containerd-config Fix `containerd config dump`.

view details

Phil Estes

commit sha c59561a08ec1936d4632a6b4868110681216d160

Merge pull request #3763 from AkihiroSuda/disable-mknod00-in-userns apply: use naive applier when running in UserNS

view details

bpopovschi

commit sha e8c14c07c6d9c33df7484bdde4df166627b6b44a

Added filters to snapshots API Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

Derek McGowan

commit sha 66aa1d3ef6f69be075f6acf10123f7e8db9112c2

Add snapshot walk implementations Temporarily remove zfs and aufs until interface update Signed-off-by: Derek McGowan <derek@mcgstyle.net>

view details

Akihiro Suda

commit sha 0c01992f9c8cc2794b3d2b4f2ed0b55a4b91ed9e

Merge pull request #3709 from Zyqsempai/3708-added-filters-to-shapsotters-api Added filters to snapshots API

view details

Lantao Liu

commit sha 20e844a227950952e110cf751a8efeb7dfcbf167

Use logrus trace support. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Phil Estes

commit sha aeec80fca165ab6217cd4c03fa59b1bee9cb0427

Merge pull request #3773 from Random-Liu/use-logrus-trace Use logrus trace support.

view details

push time in 16 days

push eventcontainerd/ttrpc

lifupan

commit sha 2ef8878926f84f015a51f4a68218d101af747b73

ttrpc: fix the issue of marshaling on nil will crash the server Since some type's Marshal() on nil will crash runtime, thus it's should check 'resp' before marshaling on it. If it's nil, return directly to avoid the server crash. Signed-off-by: lifupan <lifupan@gmail.com>

view details

Phil Estes

commit sha cf7f4d5f2d61bb06dd6ff5a039a1cbd6e71d10b1

Merge pull request #51 from lifupan/fixnilresp ttrpc: fix the issue of marshaling on nil will crash the server

view details

push time in 19 days

PR merged containerd/ttrpc

ttrpc: fix the issue of marshaling on nil will crash the server

Since proto.Marshal() on nil will crash runtime, thus it's should check 'resp' before marshaling on it. If it's nil, return directly.

Signed-off-by: lifupan lifupan@gmail.com

+9 -0

12 comments

1 changed file

lifupan

pr closed time in 19 days

push eventcontainerd/containerd

Lantao Liu

commit sha 20e844a227950952e110cf751a8efeb7dfcbf167

Use logrus trace support. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Phil Estes

commit sha aeec80fca165ab6217cd4c03fa59b1bee9cb0427

Merge pull request #3773 from Random-Liu/use-logrus-trace Use logrus trace support.

view details

push time in 19 days

PR merged containerd/containerd

Use logrus trace support.

This PR depends on https://github.com/containerd/cri/pull/1323.

Logrus supports trace level natively now. See https://github.com/sirupsen/logrus/pull/844

Signed-off-by: Lantao Liu lantaol@google.com

+6 -36

4 comments

5 changed files

Random-Liu

pr closed time in 19 days

push eventcontainerd/containerd

Akihiro Suda

commit sha f3c48daf71838b745f9fc5ae4f9f316de4b4aaf5

apply: use naive applier when running in UserNS `OverlayConvertWhiteout` calls `mknod c 0 0` which is not allowed when running in a user namespace, even in Ubuntu kernel. Although there is an alternative hacky way to create whiteouts without calling mknod as Moby `overlay2` actually does(see #3762), let's use naive applier when running in UserNS and call it a day. Close #3762 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit c224edc5c6350026a7d35a09dce638b0f09e6d44) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Phil Estes

commit sha d6f0c29b1b0c50e99197a5c9d4441566c075293e

Merge pull request #3779 from AkihiroSuda/disable-mknod00-in-userns-1.3 [release/1.3] apply: use naive applier when running in UserNS

view details

push time in 19 days

PR merged containerd/containerd

[release/1.3] apply: use naive applier when running in UserNS

Cherry-pick https://github.com/containerd/containerd/pull/3763

+6 -0

2 comments

1 changed file

AkihiroSuda

pr closed time in 19 days

issue commentcontainerd/project

Add non-core project "imgcrypt" to containerd organization

11/13 LGTMs (2 more than required)

@crosbymichael can you work with @stefanberger on the mechanics of the transfer? Thanks!

estesp

comment created time in 19 days

push eventcontainerd/containerd

Akihiro Suda

commit sha c224edc5c6350026a7d35a09dce638b0f09e6d44

apply: use naive applier when running in UserNS `OverlayConvertWhiteout` calls `mknod c 0 0` which is not allowed when running in a user namespace, even in Ubuntu kernel. Although there is an alternative hacky way to create whiteouts without calling mknod as Moby `overlay2` actually does(see #3762), let's use naive applier when running in UserNS and call it a day. Close #3762 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Phil Estes

commit sha c59561a08ec1936d4632a6b4868110681216d160

Merge pull request #3763 from AkihiroSuda/disable-mknod00-in-userns apply: use naive applier when running in UserNS

view details

push time in 19 days

PR merged containerd/containerd

apply: use naive applier when running in UserNS cherry-pick/1.3.x

OverlayConvertWhiteout calls mknod c 0 0 which is not allowed when running in a user namespace, even in Ubuntu kernel.

Although there is an alternative hacky way to create whiteouts without calling mknod as Moby overlay2 actually does(see #3762), let's use naive applier when running in UserNS and call it a day.

Close #3762

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

+6 -0

5 comments

1 changed file

AkihiroSuda

pr closed time in 19 days

issue closedcontainerd/containerd

support or disable direct unpack when running in userns

<!-- If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead. -->

Description

<!-- Briefly describe the problem you are having in a few paragraphs. -->

Direct unpack added in https://github.com/containerd/containerd/pull/3528 (v1.3.0) doesn't work well when running in user namespace:

E1019 19:24:27.024977   21918 remote_runtime.go:200] CreateContainer in sandbox "941524a9dca443253b954cc64183131f5cc89054cd0dd70f4ab342671cd1bf1f" from runtime service failed: rpc error: code = Unknown desc = failed to create containerd container: error unpacking image: failed to extract layer sha256:d635f458a6f8a4f3dd57a597591ab8977588a5a477e0a68027d18612a248906f: failed to convert whiteout file "etc/ca-certificates/.wh..wh..opq": operation not permitted: unknown
E1019 19:24:27.025143   21918 kuberuntime_manager.go:783] container start failed: CreateContainerError: failed to create containerd container: error unpacking image: failed to extract layer sha256:d635f458a6f8a4f3dd57a597591ab8977588a5a477e0a68027d18612a248906f: failed to convert whiteout file "etc/ca-certificates/.wh..wh..opq": operation not permitted: unknown

The error happens because whiteout cannot be created with mknod in user namespace.

Moby implementation supports creating whiteout in a hacky alternative way:

https://github.com/moby/moby/blob/a8b04b17fd37ed797e34bea6534d307929c6337b/pkg/archive/archive_linux.go#L122-L175

// mknodChar0Overlay creates 0,0 char device by mounting overlayfs and unlinking.
// This function can be used for creating 0,0 char device in userns on Ubuntu.
//
// Steps:
// * Mkdir lower,upper,merged,work
// * Create lower/dummy
// * Mount overlayfs
// * Unlink merged/dummy
// * Unmount overlayfs
// * Make sure a 0,0 char device is created as upper/dummy
// * Rename upper/dummy to cleansedOriginalPath

Steps to reproduce the issue:

  • Run containerd/cri in rootless mode

Describe the results you received:

failed to convert whiteout file "etc/ca-certificates/.wh..wh..opq": operation not permitted: unknown

Describe the results you expected:

It should either support or disable direct unpack

Output of containerd --version: 1.3.0

closed time in 19 days

AkihiroSuda

push eventcontainerd/containerd

Lantao Liu

commit sha aaccfcbe2b8792e5fa3711811f3025562485e8bb

Fix `containerd config dump`. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Phil Estes

commit sha f05e19c5c6fa330753b84fe200f887cb3d62df41

Merge pull request #3777 from Random-Liu/fix-containerd-config Fix `containerd config dump`.

view details

push time in 20 days

PR merged containerd/containerd

Fix `containerd config dump`.

This PR:

  1. Updated man file for https://github.com/containerd/containerd/issues/3776;
  2. Add missing Timeouts support in containerd config dump output;

There are still 2 problems:

  1. The import behavior is very confusing. For example, as a user using config.toml, you don't know whether a section is a map or struct underlying. It's impossible for them to tell whether the subsequent config will be merged or overwritten... I understand that we do this because of the limitation of mergo, but we should at least make the behavior consistent, for example all 1st level section will be overwritten directly.
  2. It is hard to maintain future map fields. IIUC, any new map fields added in the config (maybe in a child struct), needs to be taken care in mergeConfig. It seems a bit hard to maintain.

Signed-off-by: Lantao Liu lantaol@google.com

+14 -2

3 comments

3 changed files

Random-Liu

pr closed time in 20 days

push eventcontainerd/ttrpc

Wei Fu

commit sha 47e5e4fdf91bf8ff9a1d39f0323dec42ce0ff20b

.travis: don't call go get if there is go.mod when enable go module, go get will update the required version. It is not supported to run in CI. More info: https://github.com/golang/go/issues/27643. Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Phil Estes

commit sha 5046735d25c3c4d099e698c7eaa75f116278e31c

Merge pull request #55 from fuweid/me-test-vendor-check .travis: don't call go get if there is go.mod

view details

push time in 20 days

PR merged containerd/ttrpc

Reviewers
.travis: don't call go get if there is go.mod

when enable go module, go get will update the required version. It is not supported to run in CI.

More info: golang/go#27643.

Signed-off-by: Wei Fu fuweid89@gmail.com

+5 -3

3 comments

1 changed file

fuweid

pr closed time in 20 days

pull request commentcontainerd/ttrpc

Copy codes and status pkg from grpc

need a revendor to drop dependencies

crosbymichael

comment created time in 20 days

Pull request review commentcontainerd/containerd

Use logrus trace support.

 github.com/cpuguy83/go-md2man v1.0.10 github.com/russross/blackfriday v1.5.2  # cri dependencies-github.com/containerd/cri 0ebf032aac5f6029f95a94e42161e9db7a7e84df # release/1.3++github.com/containerd/cri 6ab2e10869e3e2443ae8d92d3489905bc0c987f5 https://github.com/Random-Liu/cri-containerd # master

I don't think this should be merged until the CRI PR is merged and then this won't have to be a private tree reference. Looks like that can happen soon as the CRI PR is LGTM'ed

Random-Liu

comment created time in 20 days

pull request commentcontainerd/containerd

Update Microsoft/hcsshim vendor

The booleans should be %t according to Golang Fprintf docs:

cmd/ctr/commands/tasks/metrics.go:178:3: printf: Fprintf format %b has arg stats.Memory.VmMemory.SlpActive of wrong type bool (govet)
		fmt.Fprintf(w, "vm.memory.slp_active\t%b\t\n", stats.Memory.VmMemory.SlpActive)
		^
cmd/ctr/commands/tasks/metrics.go:179:3: printf: Fprintf format %b has arg stats.Memory.VmMemory.BalancingEnabled of wrong type bool (govet)
		fmt.Fprintf(w, "vm.memory.balancing_enabled\t%b\t\n", stats.Memory.VmMemory.BalancingEnabled)
		^
cmd/ctr/commands/tasks/metrics.go:180:3: printf: Fprintf format %d has arg stats.Memory.VmMemory.DmOperationInProgress of wrong type bool (govet)
		fmt.Fprintf(w, "vm.memory.dm_operation_in_progress\t%d\t\n", stats.Memory.VmMemory.DmOperationInProgress)
		^
jterry75

comment created time in 20 days

pull request commentcontainerd/ttrpc

Copy codes and status pkg from grpc

This definitely seems like a good thing to do, but our ltag header check is going to get upset about the fileheaders from the gRPC project (which I think should be left in).. hmm.

crosbymichael

comment created time in 20 days

issue commentcontainerd/project

Adding ttrpc-rust as sub-project

Given our governance, it would make sense to have it be its own non-core repo so that it can have its own maintainers who don't need to worry about the rest of the org. core repos.

Also, seems like a project using a different programming language would just be cleaner as its own repo with its own CI, Makefile, scripts, etc. which I assume will not be aligned with the rest of the Golang-focused repos. It can also be tagged and released on its own timeline as well as a separate repo.

teawater

comment created time in 21 days

push eventcontainerd/containerd.io

surya474

commit sha 2f69d40c3e31693ec811694882f80d8bbdf1462f

Added alt tags for images in home page Signed-off-by: surya474 <gantasuryateja474@gmail.com>

view details

Phil Estes

commit sha 54b258251a500b24661c956e2d3a28967364c69c

Merge pull request #44 from surya474/accessibility-alt Added alt tags for images in home page

view details

push time in 21 days

pull request commentcontainerd/containerd

[release/1.3 backport] Update Golang 1.12.12 (CVE-2019-17596)

Need #3772 to fix the CI failure on vndr check

thaJeztah

comment created time in 22 days

PR opened containerd/containerd

Catch up vndr with state of vendor/ dir

Due to a temporarily broken containerd/project script the vendor dir was slightly out of state with what it should have been after the last runc vendor update.

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

+1 -1

0 comment

1 changed file

pr created time in 22 days

create barnchestesp/containerd

branch : update-vndr-1.3

created branch time in 22 days

pull request commentcontainerd/containerd

[release/1.2 backport] Update Golang 1.12.12 (CVE-2019-17596)

Need #3771 so we get the vendor check in CI to not complain anymore

thaJeztah

comment created time in 22 days

PR opened containerd/containerd

[release/1.2] Catch up vndr with state of vendor/ dir

Due to a temporarily broken containerd/project script the vendor dir was slightly out of state with what it should have been after the last runc vendor update.

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

+1 -1

0 comment

1 changed file

pr created time in 22 days

create barnchestesp/containerd

branch : update-vndr

created branch time in 22 days

push eventestesp/containerd

Sebastiaan van Stijn

commit sha 885232b72f0b7ead6ffec76fe0adfda384572b6f

bump google.golang.org/grpc v1.23.1 full diff: https://github.com/grpc/grpc-go/compare/v1.23.0...v1.23.1 - grpc/grpc-go#3018 server: set and advertise max frame size of 16KB - grpc/grpc-go#3017 grpclb: fix deadlock in grpclb connection cache - Before the fix, if the timer to remove a SubConn fires at the same time NewSubConn cancels the timer, it caused a mutex leak and deadlock. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Phil Estes

commit sha 3bf461ae8ebec194e333a54ec0dfc562b741112c

Move autocomplete files to contrib/ Since recent versions of `vndr` are going to remove the autocomplete scripts from the urfave vendored content, we will just move them into `contrib/` and reference them in the documentation from that location. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Akihiro Suda

commit sha 0d8fc0a487f82b922122ca0280fe1ba3d19b3803

Merge pull request #3767 from thaJeztah/bump_grpc bump google.golang.org/grpc v1.23.1

view details

Phil Estes

commit sha 4523ab734aff7fd4abc0b676b767b1026b826278

Merge pull request #3766 from estesp/move-autocomplete Move autocomplete files to contrib/

view details

push time in 22 days

delete branch estesp/containerd

delete branch : move-autocomplete

delete time in 22 days

push eventcontainerd/containerd

Phil Estes

commit sha 3bf461ae8ebec194e333a54ec0dfc562b741112c

Move autocomplete files to contrib/ Since recent versions of `vndr` are going to remove the autocomplete scripts from the urfave vendored content, we will just move them into `contrib/` and reference them in the documentation from that location. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Phil Estes

commit sha 4523ab734aff7fd4abc0b676b767b1026b826278

Merge pull request #3766 from estesp/move-autocomplete Move autocomplete files to contrib/

view details

push time in 22 days

PR merged containerd/containerd

Move autocomplete files to contrib/

Since recent versions of vndr are going to remove the autocomplete scripts from the urfave vendored content, we will just move them into contrib/ and reference them in the documentation from that location.

See #3759 for background

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

+46 -9

3 comments

3 changed files

estesp

pr closed time in 22 days

push eventestesp/playground

Phil Estes

commit sha 79f5bd7f19a152737643fca13e9cc44989a59b20

Hack up playground to be a bash script terminal Signed-off-by: Phil Estes <estesp@gmail.com>

view details

push time in 22 days

push eventestesp/flightassist

Phil Estes

commit sha eeab5de52e8b13eb9664fda1abaef07ed6fa73dd

Update cfenv npm package to fix sec issue Signed-off-by: Phil Estes <estesp@gmail.com>

view details

push time in 22 days

PR merged estesp/flightassist

Fix deps and npm audit

Handles several security alerts that automated GH bot couldn't resolve.

Signed-off-by: Phil Estes estesp@gmail.com

+210 -361

0 comment

2 changed files

estesp

pr closed time in 22 days

delete branch estesp/flightassist

delete branch : update-deps

delete time in 22 days

push eventestesp/flightassist

Phil Estes

commit sha 77f41fc58357f8df62bb48ceef0e47353678a274

Fix deps and npm audit Signed-off-by: Phil Estes <estesp@gmail.com>

view details

Phil Estes

commit sha dbdc78505e5982f9f76cbbe7de293faddd83702e

Merge pull request #9 from estesp/update-deps Fix deps and npm audit

view details

push time in 22 days

PR opened estesp/flightassist

Fix deps and npm audit

Handles several security alerts that automated GH bot couldn't resolve.

Signed-off-by: Phil Estes estesp@gmail.com

+210 -361

0 comment

2 changed files

pr created time in 22 days

create barnchestesp/flightassist

branch : update-deps

created branch time in 22 days

delete branch estesp/flightassist

delete branch : dependabot/npm_and_yarn/extend-3.0.2

delete time in 22 days

push eventestesp/flightassist

dependabot[bot]

commit sha 40cd78eec30cb0d08501fea02b10a6ae95d27672

Bump extend from 3.0.1 to 3.0.2 Bumps [extend](https://github.com/justmoon/node-extend) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/justmoon/node-extend/releases) - [Changelog](https://github.com/justmoon/node-extend/blob/master/CHANGELOG.md) - [Commits](https://github.com/justmoon/node-extend/compare/v3.0.1...v3.0.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Phil Estes

commit sha 4092f310706848b9ee5a839232c059b9e8799264

Merge pull request #8 from estesp/dependabot/npm_and_yarn/extend-3.0.2 Bump extend from 3.0.1 to 3.0.2

view details

push time in 22 days

PR merged estesp/flightassist

Bump extend from 3.0.1 to 3.0.2 dependencies

Bumps extend from 3.0.1 to 3.0.2. <details> <summary>Changelog</summary>

Sourced from extend's changelog.

3.0.2 / 2018-07-19

  • [Fix] Prevent merging __proto__ property (#48)
  • [Dev Deps] update eslint, @ljharb/eslint-config, tape
  • [Tests] up to node v10.7, v9.11, v8.11, v7.10, v6.14, v4.9; use nvm install-latest-npm </details> <details> <summary>Commits</summary>
  • 8d106d2 v3.0.2
  • e97091f [Dev Deps] update tape
  • e841aac [Tests] up to node v10.7
  • 0e68e71 [Fix] Prevent merging proto property
  • a689700 Only apps should have lockfiles
  • f13c1c4 [Dev Deps] update eslint, @ljharb/eslint-config, tape
  • f3570fe [Tests] up to node v10.0, v9.11, v8.11, v7.10, v6.14, v4.9; use...
  • See full diff in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -8

0 comment

1 changed file

dependabot[bot]

pr closed time in 22 days

delete branch estesp/flightassist

delete branch : dependabot/npm_and_yarn/lodash-4.17.15

delete time in 22 days

push eventestesp/flightassist

dependabot[bot]

commit sha 07f068264bb98b5c9533677eaa9876b28c154bfb

Bump lodash from 4.17.5 to 4.17.15 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.5 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.5...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Phil Estes

commit sha e1a290e7bc3558a6cd24c0f601075b65ac5c6b89

Merge pull request #7 from estesp/dependabot/npm_and_yarn/lodash-4.17.15 Bump lodash from 4.17.5 to 4.17.15

view details

push time in 22 days

PR merged estesp/flightassist

Bump lodash from 4.17.5 to 4.17.15 dependencies

Bumps lodash from 4.17.5 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -4

0 comment

1 changed file

dependabot[bot]

pr closed time in 22 days

pull request commentcontainerd/containerd

[release/1.2 backport] Update Golang 1.12.12 (CVE-2019-17596)

We could do this in a separate PR, but this PR reminded me of something I was thinking about re: this topic.

I was thinking we should start setting an explicit Go version in .travis.yml for release branches. As you do in this PR, appveyor and the example Dockerfile have the version explicitly, but .travis.yml floats with the latest release that Travis has enabled in their CI infrastructure. That means we get "automatic" updates for Linux in CI even if we don't explicitly want to move a released version's Golang version.

thaJeztah

comment created time in 22 days

push eventestesp/containerd

Wei Fu

commit sha 074b453ac66797ab93d9570e826ef9c35b079b13

vendor: call vndr to remove useless pkgs and update vendor Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Phil Estes

commit sha 3e3c5fe129e4d25e5ec215439bc7a0986e49f995

Merge pull request #3759 from fuweid/me-update-vendor vendor: call vndr to remove useless pkgs and update vendor

view details

Phil Estes

commit sha 3bf461ae8ebec194e333a54ec0dfc562b741112c

Move autocomplete files to contrib/ Since recent versions of `vndr` are going to remove the autocomplete scripts from the urfave vendored content, we will just move them into `contrib/` and reference them in the documentation from that location. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

push time in 22 days

push eventestesp/containerd

Wei Fu

commit sha 074b453ac66797ab93d9570e826ef9c35b079b13

vendor: call vndr to remove useless pkgs and update vendor Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Phil Estes

commit sha 3e3c5fe129e4d25e5ec215439bc7a0986e49f995

Merge pull request #3759 from fuweid/me-update-vendor vendor: call vndr to remove useless pkgs and update vendor

view details

push time in 22 days

delete branch estesp/project

delete branch : no-contrib-ltag

delete time in 22 days

PR closed containerd/ttrpc

TESTING: check Golang releases re: test failure

Based on the failure seen in #51 test if it's a recent Golang bump

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

+2 -0

3 comments

1 changed file

estesp

pr closed time in 23 days

pull request commentcontainerd/ttrpc

TESTING: check Golang releases re: test failure

@fuweid found the root cause and solved in #53

estesp

comment created time in 23 days

push eventcontainerd/containerd

Wei Fu

commit sha 074b453ac66797ab93d9570e826ef9c35b079b13

vendor: call vndr to remove useless pkgs and update vendor Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Phil Estes

commit sha 3e3c5fe129e4d25e5ec215439bc7a0986e49f995

Merge pull request #3759 from fuweid/me-update-vendor vendor: call vndr to remove useless pkgs and update vendor

view details

push time in 23 days

pull request commentcontainerd/containerd

vendor: call vndr to remove useless pkgs and update vendor

Merging now that we've solved the problem with the git diff invocation--otherwise I think we will have lots of broken CI on the vndr mismatch!

fuweid

comment created time in 23 days

push eventestesp/containerd

Phil Estes

commit sha 168b29376afb469e7c14b9b81b1eb162c8587a1c

Move autocomplete files to contrib/ Since recent versions of `vndr` are going to remove the autocomplete scripts from the urfave vendored content, we will just move them into `contrib/` and reference them in the documentation from that location. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

push time in 23 days

more