profile
viewpoint
Sebastiaan van Stijn thaJeztah thaJeztah Netherlands @docker and @moby maintainer, member of the Moby TSC. Open Source contributions manager @ Docker, Inc. Feeds @GordonTheTurtle with issues and PR's

sirupsen/logrus 13712

Structured, pluggable logging for Go.

docker/swarm 5801

Swarm: a Docker-native clustering system

moby/buildkit 2157

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit

docker/for-mac 1260

Bug reports for Docker Desktop for Mac

docker/for-win 899

Bug reports for Docker Desktop for Windows

docker/go-plugins-helpers 247

Go helper packages to extend the Docker Engine

docker/go-p9p 188

A modern, performant 9P library for Go.

swarmzilla/swarm2k 81

The Docker Swarm 2000 Collaborative Project

docker/gordon-bot 31

Gordon the turtle IRC bot to rebuild Jenkins builds.

delete branch thaJeztah/docker

delete branch : 19.03_backport_lgetxattr_panic

delete time in 6 hours

issue commentmoby/moby

docker stack deploy fails to pull images from docker.pkg.github.com registry

GitHub's registry unfortunately doesn't comply with the distribution specification, and only partially implements the specification. When deploying a stack, of deploying a swarm service, the image used is resolved to its digest (immutable reference), and the service will use that reference/pull the image.

That part of the specification is not implemented by the GitHub registry, causing that warning to be produced.

There's other parts that don't work as well, see https://github.com/containerd/containerd/issues/3291

It might be worth opening a support ticket with GitHub to possibly get fixing this prioritized. Otherwise consider pushing the images to Docker Hub instead?

DrPyser

comment created time in 6 hours

issue commentdocker/cli

device mount fails under remote context in MacOS with 19.03.5 docker CLI

One thing I was considering is that 19.03 does a HEAD /_ping first, and if that fails, falls back to GET /_ping (it's possible that that could be related).

Not sure if the nginx reverse proxy makes a difference (but not excluding that possibility). I was about to spin up a machine and install docker 18.03, then try with a 19.03 client

But you could try running a client in a container on your setup;

docker run -it --rm -v /var/run/docker.sock:/var/run/docker.sock docker:19.03 sh

That should start a container with a docker 19.03 cli, which has direct access to the API using the socket. wondering if that also reproduces the issue if you try to start the container from within there?

sureshsankaran

comment created time in 8 hours

pull request commentdocker/docker-ce

Bump version to 19.03.6.rc1

Note: a bunch of PR's were just merged into docker/engine, so some updates are needed to the changelog (also; we need to make sure the update components script is run before we merge/tag/do anything)

One more PR is pending CI to run; https://github.com/docker/engine/pull/454

arkodg

comment created time in 9 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha fe00613d0686a47519048a190f1138504a2cdedc

bump containerd/cgroups c4b9ac5c7601384c965b9646fc515884e091ebb9 full diff: github.com/containerd/cgroups https://github.com/containerd/cgroups/compare/4994991857f9b0ae8dc439551e8bebdbb4bf66c1...c4b9ac5c7601384c965b9646fc515884e091ebb9 changes included: - containerd/cgroups#81 Add network stats - addresses containerd/cgroups#80 Add network metrics - containerd/cgroups#85 Fix cgroup hugetlb size prefix for kB - addresses kubernetes/kubernetes#77169 Permission denied on hugetlb due to wrong filename - relates to opencontainers/runc#2065 Fix cgroup hugetlb size prefix for kB - containerd/cgroups#88 cgroups: fix MoveTo function fail problem - containerd/cgroups#92 fixed an issue with invalid soft memory limits - containerd/cgroups#93 avoid adding io_serviced and io_service_bytes duplicately - fixes containerd/containerd#3412 collected metric container_blkio_io_serviced_recursive_total: was collected before with the same name and label values Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 0af1099a81861dd0269adad53bdfb387b5c78f39) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 9ab162a73ac9e133a21cffbadd3339cbb5213939

bump containerd/cgroups 5fbad35c2a7e855762d3c60f2e474ffcad0d470a full diff: https://github.com/containerd/cgroups/compare/c4b9ac5c7601384c965b9646fc515884e091ebb9...5fbad35c2a7e855762d3c60f2e474ffcad0d470a - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 27552ceb15bca544820229e574427d4c1d6ef585) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 4d190af804f200fd8def0ebbcc011704374d6494

Rename "v1" to "statsV1" follow-up to 27552ceb15bca544820229e574427d4c1d6ef585, where this was left as a review comment, but the PR was already merged. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 9a7e96b5b7e97e034ce7bb0f1e7788d1bd881c7f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 3fca5878d6bac77aaddb6cfc7267f21861faef04

integration-cli: remove unnescessary conversions (unconvert) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7c40c0a9227089a7e3ee7c23c2bc0685ed133391) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 1f18c73c09baa9b1fb296f7058e97dff32644330

bump Microsoft/hcsshim 2226e083fc390003ae5aa8325c3c92789afa0e7a Adds osversion.Build() utility Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit a5341aaf32d2ea1d7f527fa8f3bd08f4706e4872) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

vikrambirsingh

commit sha 5302429fffd4a1971e11c867e32a6a19b7b66919

TestRunAttachFailedNoLeak: Compare lowercase Fixed failures in TestRunAttachFailedNoLeak caused by case mismatch Signed-off-by: vikrambirsingh <vikrambir.singh@docker.com> (cherry picked from commit c530c9cbb0da177337a90a6651305daa9eb0c42b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Vikram bir Singh

commit sha e2f226b5b41c958fa518f677eb213eb1462f90a8

Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a Among other things, this is required to pull in microsoft/hcsshim#718 Also fixes microsoft/hcsshim#737 which was caught by checks while attempting to bump up hcsshim version. Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com> (cherry picked from commit a7b6c3f0bf5d10c6227a29bac7dd46b9a7a779bc) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6949793bb1bfbc32bd787244e5dc06802b6159be

Merge pull request #429 from thaJeztah/19.03_backport_windows_1903_fixes [19.03 backport] bump hcsshim to fix docker build failing on Windows 1903

view details

push time in 9 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_windows_1903_fixes

delete time in 9 hours

PR merged docker/engine

[19.03 backport] bump hcsshim to fix docker build failing on Windows 1903 impact/changelog

includes:

  • update containerd/cgroups to c4b9ac5c7601384c965b9646fc515884e091ebb9 (taken from https://github.com/moby/moby/pull/39713 bump containerd and dependencies to v1.3.0)
  • https://github.com/moby/moby/pull/40154 bump containerd/cgroups 5fbad35c2a7e855762d3c60f2e474ffcad0d470a
  • https://github.com/moby/moby/pull/40167 Rename "v1" to "statsV1"
  • integration-cli: remove unnescessary conversions (unconvert) (taken from https://github.com/moby/moby/pull/39668 Replace gometalinter with golangci-lint)
  • bump Microsoft/hcsshim 2226e083fc390003ae5aa8325c3c92789afa0e7a (taken from https://github.com/moby/moby/pull/39100 Use Microsoft/hcsshim constants and deprecate pkg/system.GetOsVersion())
  • https://github.com/moby/moby/pull/40250 Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2

hcsshim bump includes:

  • https://github.com/microsoft/hcsshim/pull/718 wclayer: Work around Windows bug when expanding sandbox size
    • fixes https://github.com/microsoft/hcsshim/issues/708 Windows Host Compute Service bug breaks docker (and other) sandboxes bigger than 20G on Windows 1903
    • fixes https://github.com/microsoft/hcsshim/issues/624The hcsshim on Windows 10 1903 always fails to build Docker image
    • fixes/addresses https://github.com/docker/for-win/issues/3884 An error occurred while attempting to build Docker image (especially this comment and the next comments after: https://github.com/docker/for-win/issues/3884#issuecomment-498939672)
    • fixes/addresses https://github.com/docker/for-win/issues/4100 Windows 1903 fails when storage-opt used
    • fixes https://github.com/moby/moby/issues/36831 hcsshim::PrepareLayer failed in Win32: The parameter is incorrect (https://github.com/moby/moby/issues/36831#issuecomment-498612392)
    • fixes https://github.com/Stannieman/audacity-with-asio-builder/issues/5 Docker won't build container
    • fixes https://github.com/MicrosoftDocs/visualstudio-docs/issues/3523 Error when running build with storage-opts set
    • fixes https://github.com/moby/moby/issues/39524 Docker build windows 19.03 --storage-opt size>20G

Note that this is a temporary workaround for a bug in the platform, and will be reverted once that is addressed:

  • https://github.com/microsoft/hcsshim/issues/721 Revert 718 when Windows 19H1 has expand sandbox fix
# taken from https://github.com/moby/moby/pull/39713 bump containerd and dependencies to v1.3.0
git cherry-pick -s -S -x 0af1099a81861dd0269adad53bdfb387b5c78f39

# https://github.com/moby/moby/pull/40154 bump containerd/cgroups 5fbad35c2a7e855762d3c60f2e474ffcad0d470a
git cherry-pick -s -S -x 27552ceb15bca544820229e574427d4c1d6ef585

# https://github.com/moby/moby/pull/40167 Rename "v1" to "statsV1"
git cherry-pick -s -S -x 9a7e96b5b7e97e034ce7bb0f1e7788d1bd881c7f

# taken from https://github.com/moby/moby/pull/39668 Replace gometalinter with golangci-lint
git cherry-pick -s -S -x 7c40c0a9227089a7e3ee7c23c2bc0685ed133391

# taken from https://github.com/moby/moby/pull/39100 Use Microsoft/hcsshim constants and deprecate pkg/system.GetOsVersion(
git cherry-pick -s -S -x a5341aaf32d2ea1d7f527fa8f3bd08f4706e4872

# https://github.com/moby/moby/pull/40250 Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2
git cherry-pick -s -S -x c530c9cbb0da177337a90a6651305daa9eb0c42b \
    a7b6c3f0bf5d10c6227a29bac7dd46b9a7a779bc

Minor conflicts in 27552ceb15bca544820229e574427d4c1d6ef585:

diff --cc libcontainerd/types/types_linux.go
index 0a2daf5777,8cc41052b3..0000000000
--- a/libcontainerd/types/types_linux.go
+++ b/libcontainerd/types/types_linux.go
@@@ -3,8 -3,8 +3,13 @@@ package types // import "github.com/doc
  import (
        "time"

++<<<<<<< HEAD
 +      "github.com/containerd/cgroups"
 +      "github.com/opencontainers/runtime-spec/specs-go"
++=======
+       v1 "github.com/containerd/cgroups/stats/v1"
+       specs "github.com/opencontainers/runtime-spec/specs-go"
++>>>>>>> 27552ceb15... bump containerd/cgroups 5fbad35c2a7e855762d3c60f2e474ffcad0d470a
  )

  // Summary is not used on linux
diff --cc vendor.conf
index dd18920ab2,0be5d884ca..0000000000
--- a/vendor.conf
+++ b/vendor.conf
@@@ -117,10 -117,10 +117,17 @@@ github.com/googleapis/gax-g
  google.golang.org/genproto                          694d95ba50e67b2e363f3483057db5d4910c18f9

  # containerd
++<<<<<<< HEAD
 +github.com/containerd/containerd                    7c1e88399ec0b0b077121d9d5ad97e647b11c870
 +github.com/containerd/fifo                          a9fb20d87448d386e6d50b1f2e1fa70dcf0de43c
 +github.com/containerd/continuity                    aaeac12a7ffcd198ae25440a9dff125c2e2703a7
 +github.com/containerd/cgroups                       c4b9ac5c7601384c965b9646fc515884e091ebb9
++=======
+ github.com/containerd/containerd                    36cf5b690dcc00ff0f34ff7799209050c3d0c59a # v1.3.0
+ github.com/containerd/fifo                          bda0ff6ed73c67bfb5e62bc9c697f146b7fd7f13
+ github.com/containerd/continuity                    f2a389ac0a02ce21c09edd7344677a601970f41c
+ github.com/containerd/cgroups                       5fbad35c2a7e855762d3c60f2e474ffcad0d470a
++>>>>>>> 27552ceb15... bump containerd/cgroups 5fbad35c2a7e855762d3c60f2e474ffcad0d470a
  github.com/containerd/console                       0650fd9eeb50bab4fc99dceb9f2e14cf58f36e7f
  github.com/containerd/go-runc                       e029b79d8cda8374981c64eba71f28ec38e5526f
  github.com/containerd/typeurl                       2a93cfde8c20b23de8eb84a5adbc234ddf7a9e8d
+4056 -1623

2 comments

137 changed files

thaJeztah

pr closed time in 9 hours

push eventmoby/moby

Sebastiaan van Stijn

commit sha 234d5a78fe383881ee952bf4c937eae3c54c7b51

swagger: remove classic swarm "Node" field This field is not part of the Docker API and only used for classic (standalone) swarm. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha b5c22f4fcf387c0a6b532b6440134f36999c528f

TestContainerInspectNode: document test as being for classic swarm Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 78c86927abfd8dfd6cfac98398adbc1dbb27784b

api/types: document classic swarm "Node" field Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 8311d6ba9fe69197912f4bba01eab1a92d92ce08

API: omit classic swarm "SystemStatus" field if empty Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha ac058c1629dcf6912d800c08b8eb6a6c8b67427d

Merge pull request #40340 from thaJeztah/swagger_remove_classic_swarm_node Swagger/API update "standalone" API fields

view details

push time in 9 hours

delete branch thaJeztah/docker

delete branch : swagger_remove_classic_swarm_node

delete time in 9 hours

PR merged moby/moby

Swagger/API update "standalone" API fields area/api area/docs impact/api impact/changelog impact/deprecation status/3-docs-review

closes https://github.com/moby/moby/pull/39821 replaces https://github.com/moby/moby/pull/39821

Update docs/descriptions of fields that are only used by the Swarm standalone API (https://github.com/docker/swarm), and omit the SystemStatus field if it's not set.

+8 -44

4 comments

4 changed files

thaJeztah

pr closed time in 9 hours

PR closed moby/moby

swagger: define ContainerNode for GET /containers/{ID}/json area/api area/docs status/2-code-review

Define ContainerNode in swagger for GET /containers/{ID}/json

- A picture of a cute animal (not mandatory but encouraged)

image

+24 -2

7 comments

1 changed file

grooverdan

pr closed time in 9 hours

pull request commentmoby/moby

Swagger/API update "standalone" API fields

let's merge (I'll probably cherry-pick the docs changes)

thaJeztah

comment created time in 9 hours

PR merged docker/engine

Reviewers
[19.03 backport] LCOW: Fix FROM scratch

backport of https://github.com/moby/moby/pull/39217 for 19.03

+3 -0

2 comments

1 changed file

thaJeztah

pr closed time in 9 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_lcowfromscratch

delete time in 9 hours

push eventdocker/engine

John Howard

commit sha ba28377919de499e50e1beacf200d4daccb3f6ae

LCOW: Fix FROM scratch Signed-off-by: John Howard <jhoward@microsoft.com> (cherry picked from commit 20b11792e8c58348d3f50756251c98f80e027a35) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c030578fe4e2bd948577f19981364f18e2dbe8a1

Merge pull request #240 from thaJeztah/19.03_backport_lcowfromscratch [19.03 backport] LCOW: Fix FROM scratch

view details

push time in 9 hours

pull request commentdocker/engine

[19.03 backport] Fix possible runtime panic in Lgetxattr

kicked it once more, will merge on green

thaJeztah

comment created time in 9 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_health_race

delete time in 10 hours

push eventdocker/engine

Ziheng Liu

commit sha 32206f17d045d137e27bd1d15ed1cb4407abb9fc

Avoid a data race in container/health.go Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com> (cherry picked from commit 53e0c5012637656de1765c330b2549aa7088b853) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha ef7b19365e19722b69276f2c1c36ac2a3840a6cf

Merge pull request #443 from thaJeztah/19.03_backport_health_race [19.03 backport] Avoid a data race in container/health.go

view details

push time in 10 hours

PR merged docker/engine

[19.03 backport] Avoid a data race in container/health.go

backport of https://github.com/moby/moby/pull/39645 Fixes https://github.com/moby/moby/issues/39503

- What I did Use a local variable status instead of s.Health.Status as the return variable of function (Health).String, in order to avoid potential data race.

Besides potential data race, I think the old code has another problem: if s.Health.Status is "", then the old (Health).String will return "", but this is inconsistent with (Health).Status, which will return types.Unhealthy. After my commit, the return value of (Health).String will be consistent with (Health).Status.

- How to verify it All read/write operations to s.Health.Status is protected by s.mu.Lock(), except this one in (Health).String. So I suppose this read operation without critical section would cause data race.

I can only find one usage of (Health).String, as shown below. I think my patch will not affect other behavior of this project.

// String returns a human-readable description of the state
func (s *State) String() string {
	if s.Running {
		...
		if h := s.Health; h != nil {
			return fmt.Sprintf("Up %s (%s)", units.HumanDuration(time.Now().UTC().Sub(s.StartedAt)), h.String())
		}
		...
	}

- Description for the changelog ###Bug fixes - Fix a potential data race in (Health).String. - Now (Health).String will return types.Unhealthy, if s.Health.Status is "".

+1 -1

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha 10df1f55f15948905554822f7d0c270a7335a87f

daemon: don't listen on the same address multiple times Before this change: dockerd -H unix:///run/docker.sock -H unix:///run/docker.sock -H unix:///run/docker.sock ... INFO[2019-07-13T00:02:36.195090937Z] Daemon has completed initialization INFO[2019-07-13T00:02:36.215940441Z] API listen on /run/docker.sock INFO[2019-07-13T00:02:36.215933172Z] API listen on /run/docker.sock INFO[2019-07-13T00:02:36.215990566Z] API listen on /run/docker.sock After this change: dockerd -H unix:///run/docker.sock -H unix:///run/docker.sock -H unix:///run/docker.sock ... INFO[2019-07-13T00:01:37.533579874Z] Daemon has completed initialization INFO[2019-07-13T00:01:37.567045771Z] API listen on /run/docker.sock Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit d470252e8742867797a58933f7b4ba34494af2ed) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c3936abb675e88a62215d7fac9f52b365f273ca6

Merge pull request #441 from thaJeztah/19.03_backport_fix_double_host [19.03 backport] daemon: don't listen on the same address multiple times

view details

push time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_fix_double_host

delete time in 10 hours

PR merged docker/engine

[19.03 backport] daemon: don't listen on the same address multiple times

backport of https://github.com/moby/moby/pull/39514

see https://github.com/moby/moby/pull/39454#issuecomment-511054056

Before this change:

dockerd -H unix:///run/docker.sock -H unix:///run/docker.sock -H unix:///run/docker.sock
...
INFO[2019-07-13T00:02:36.195090937Z] Daemon has completed initialization
INFO[2019-07-13T00:02:36.215940441Z] API listen on /run/docker.sock
INFO[2019-07-13T00:02:36.215933172Z] API listen on /run/docker.sock
INFO[2019-07-13T00:02:36.215990566Z] API listen on /run/docker.sock

After this change:

dockerd -H unix:///run/docker.sock -H unix:///run/docker.sock -H unix:///run/docker.sock
...
INFO[2019-07-13T00:01:37.533579874Z] Daemon has completed initialization
INFO[2019-07-13T00:01:37.567045771Z] API listen on /run/docker.sock

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+6 -0

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

push eventdocker/engine

Arko Dasgupta

commit sha 89c5fbacfda5a863b999eed959b0fa6074265e74

Bump 19.03 libnetwork refpoint [19.03 backport] bridge: Fix hwaddr set race between us and udev Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>

view details

Sebastiaan van Stijn

commit sha 78571e9049b13803d07bada325a6bd1925d96227

Merge pull request #439 from arkodg/19.03 [19.03] Bump 19.03 libnetwork refpoint

view details

push time in 10 hours

PR merged docker/engine

[19.03] Bump 19.03 libnetwork refpoint

full diff: https://github.com/docker/libnetwork/compare/d9a6682a4dbb13b1f0d8216c425fe9ae010a0f23...9fd385be8302dbe1071a3ce124891893ff27f90f

  • https://github.com/docker/libnetwork/pull/2495 [19.03 backport] bridge: Fix hwaddr set race between us and udev
    • backport of https://github.com/docker/libnetwork/pull/2380
+8 -9

0 comment

3 changed files

arkodg

pr closed time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_errdefs_no_recurse

delete time in 10 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha b2694b459fc9653420c2a62d7301fbb61f47727c

errdefs: remove unneeded recursive calls The `statusCodeFromGRPCError` and `statusCodeFromDistributionError` helpers are used by `GetHTTPErrorStatusCode`, which already recurses if the error implements the `Causer` interface. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 32f4fdfb5c8846922302c20fdcab973227eb9bd6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha d2693998a69760922fc4156bd6e866c1e200fe2d

Merge pull request #442 from thaJeztah/19.03_backport_errdefs_no_recurse [19.03 backport] errdefs: remove unneeded recursive calls

view details

push time in 10 hours

PR merged docker/engine

[19.03 backport] errdefs: remove unneeded recursive calls

backport of https://github.com/moby/moby/pull/39526

The statusCodeFromGRPCError and statusCodeFromDistributionError helpers are used by GetHTTPErrorStatusCode, which already recurses if the error implements the Causer interface.

+0 -7

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_fix_unmount_ipc_ignore_enotexist

delete time in 10 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha d17c56f639eadd47eb6ca5a0e064f5205736a9be

Fix "no such file or directory" warning when unmounting IPC mount When cleaning up IPC mounts, the daemon could log a warning if the IPC mount was not found; ``` cleanup: failed to unmount IPC: umount /var/lib/docker/containers/90f408e26e205d30676655a08504dddc0d17f5713c1dd4654cf67ded7d3bbb63/mounts/shm, flags: 0x2: no such file or directory" ``` These warnings are safe to ignore, but can cause some confusion; `container.UnmountIpcMount()` already attempted to suppress these warnings, however, `mount.Unmount()` returns a `mountError`, which nests the original error, therefore detecting failed. This parch uses `errors.Cause()` to get the _underlying_ error to detect if it's a "is not exist". Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 060f387c0b03373ab837f0de039dc061133842f8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6def98ee7d995a121d6aa27655b458944565ae45

Merge pull request #444 from thaJeztah/19.03_backport_fix_unmount_ipc_ignore_enotexist [19.03 backport] Fix "no such file or directory" warning when unmounting IPC mount

view details

push time in 10 hours

PR merged docker/engine

Reviewers
[19.03 backport] Fix "no such file or directory" warning when unmounting IPC mount impact/changelog

backport of https://github.com/moby/moby/pull/39653

Addresses https://github.com/moby/moby/issues/16902#issuecomment-517576013

When cleaning up IPC mounts, the daemon could log a warning if the IPC mount was not found;

cleanup: failed to unmount IPC: umount /var/lib/docker/containers/90f408e26e205d30676655a08504dddc0d17f5713c1dd4654cf67ded7d3bbb63/mounts/shm, flags: 0x2: no such file or directory"

These warnings are safe to ignore, but can cause some confusion; container.UnmountIpcMount() already attempted to suppress these warnings, however, mount.Unmount() returns a mountError, which nests the original error, therefore detecting failed.

This parch uses errors.Cause() to get the underlying error to detect if it's a "is not exist".

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

* Fix "no such file or directory" warnings not being suppressed when unmounting IPC mounts

- A picture of a cute animal (not mandatory but encouraged)

a Desert Hedgehog cub (Paraechinus aethopicus) curled up in a man's hand

image: Wikipedia, CC BY-SA 3.0

+1 -1

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_ctx_upload_cancel

delete time in 10 hours

push eventdocker/engine

Tonis Tiigi

commit sha c0fd6556f2bee8ce89c8fad855b1291a67d724b5

builder-next: close build context upload on cancel Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 2c2cd9b86a2e738b1ccf379971e4a0235ab9c758) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 60220a48b26ca96928efcd6222bc8e4b0d254b1b

Merge pull request #446 from thaJeztah/19.03_backport_ctx_upload_cancel [19.03 backport] builder-next: close build context upload on cancel

view details

push time in 10 hours

PR merged docker/engine

Reviewers
[19.03 backport] builder-next: close build context upload on cancel

backport of https://github.com/moby/moby/pull/39761 fixes https://github.com/moby/buildkit/issues/1138

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+1 -0

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_fix_containerStart_unhandled_error

delete time in 10 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha e6ef2b064176a01314e8eb4b2f177450eb23b55c

daemon:containerStart() fix unhandled error for saveApparmorConfig Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 1250e42a43e5c2dd3efbcbc20c7fa3804c3dc3fb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha efe241644b11a17d8f12a497b465b82a89f809d2

Merge pull request #447 from thaJeztah/19.03_backport_fix_containerStart_unhandled_error [19.03 backport] daemon:containerStart() fix unhandled error for saveApparmorConfig

view details

push time in 10 hours

PR merged docker/engine

[19.03 backport] daemon:containerStart() fix unhandled error for saveApparmorConfig

backport of https://github.com/moby/moby/pull/39828

+1 -1

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_move_windows_gopath_out_of_goroot

delete time in 10 hours

push eventdocker/engine

Vikram bir Singh

commit sha bbd22fb5d90fafe1b9e671bf64ab054b282cbb2a

Move GOPATH out from under the GO source tree Unlike Linux which uses a temp dir as GOPATH, Windows uses c:\go. Among other things, this blocks go get. Moving GOPATH to c:\gopath and updating references in comments and documentation. Currently the change is being scoped narrowly. In the future GOPATH value could be passed as a parameter to the ps1 scripts. Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com> (cherry picked from commit ecf91f0d7f90b2bd9fa048f2a800beaf613ac507) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha b645c8c70e6d8d2e53f3f8e5a53a8a2e55f76462

Merge pull request #449 from thaJeztah/19.03_backport_move_windows_gopath_out_of_goroot [19.03 backport] Move GOPATH out from under the GO source tree

view details

push time in 10 hours

PR merged docker/engine

[19.03 backport] Move GOPATH out from under the GO source tree

backport of https://github.com/moby/moby/pull/39888

Unlike Linux which uses a temp dir as GOPATH, Windows uses c:\go. Among other things, this blocks go get.

Moving GOPATH to c:\gopath and updating references in comments and documentation.

Currently the change is being scoped narrowly. In the future GOPATH value could be passed as a parameter to the ps1 scripts.

+13 -13

0 comment

3 changed files

thaJeztah

pr closed time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_remove_cocky

delete time in 10 hours

push eventdocker/engine

Eli Uriegas

commit sha f13b265b565690b5711bee05fe19f442104f8ba2

Remove cocky from names-generator Could be misinterpreted as something not too kosher Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> (cherry picked from commit 8be39cd27754be73bfcfd3e5a0ee9501a92b4fce) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha dda9b3eced5dfa15b3fb4941db9dcba22eae22be

Merge pull request #440 from thaJeztah/19.03_backport_remove_cocky [19.03 backport] Remove cocky from names-generator

view details

push time in 10 hours

PR merged docker/engine

[19.03 backport] Remove cocky from names-generator

Could be misinterpreted as something not too kosher

backport of https://github.com/moby/moby/pull/39455 fixes https://github.com/moby/moby/issues/39451 Unfortunate name combo

+0 -1

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha 71dec69ef554e889f53dc2909a213dbab7499a84

pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7663aebc12643fdeba5ae7ae790662d37cb5f19d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 8270df208ba52d42bc3311239d56e5c815c45e90

Merge pull request #448 from thaJeztah/19.03_backport_gofmt_pkg_parsers [19.03 backport] pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+)

view details

push time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_gofmt_pkg_parsers

delete time in 10 hours

PR merged docker/engine

[19.03 backport] pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+)

backport of https://github.com/moby/moby/pull/39883 relates to https://github.com/moby/moby/pull/39549

+1 -1

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha cc0416d0ebe529191a1a17e05ff281daad01e691

bump docker-py to 4.1.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 5a703ccb469c1bd2c75d80ed9891c432078db316) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha facfb9e1b0b292b1622f31d57d081948d3bfc00b

Merge pull request #450 from thaJeztah/19.03_backport_bump_docker_py_4.1.0 [19.03 backport] bump docker-py to 4.1.0

view details

push time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_bump_docker_py_4.1.0

delete time in 10 hours

PR merged docker/engine

[19.03 backport] bump docker-py to 4.1.0

backport of https://github.com/moby/moby/pull/40034 relates to https://github.com/docker/engine/pull/437

+1 -1

0 comment

1 changed file

thaJeztah

pr closed time in 10 hours

push eventdocker/engine

skanehira

commit sha 062a45bfa434e552b09a9847c65d35251262f894

fix swagger.yaml #39484 Signed-off-by: skanehira <sho19921005@gmail.com> (cherry picked from commit 3afdc463140d5bfb1cbe458dd7104f1334364587) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Jérémy Leherpeur

commit sha 834f0f19c57342ceea99cb7495fde6b803b2dfd7

Fix indentation in some description Fix the indentation to allow jane-openapi generate to work Signed-off-by: Jeremy Leherpeur <jeremy.leherpeur@yousign.fr> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit cf315bedc5d811b4200e49b477db99928ab28ee7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Jan Chren

commit sha ea5f540fb62632b448b286d22eca41a3956a75a2

Document `message` parameter to `/images/create` This parameter was introduced 4 years ago in b857dadb334fe0660abce4ae73a8b5b5c7f92c33 as part of https://github.com/moby/moby/pull/15711, but has never made it to the API docs. Signed-off-by: Jan Chren (rindeal) <dev.rindeal@gmail.com> (cherry picked from commit 9608dc5470e74f1ee34fd6477547303b31868576) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Daniel Black

commit sha d2aa7e3b3f19885fc44e01e4af79a19134892192

/containers/{id}/json missing Platform To match ContainerJSONBase api/types/types.go Signed-off-by: Daniel Black <daniel@linux.ibm.com> (cherry picked from commit 7b4b940470ee34c96bf434b810e4cd5ca2e68182) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha e4e71dcf6b8eca79de613cba8e41917756ac0b44

swagger: restore bind options information This information was added to an older version of the API documentation (through 164ab2cfc9900a5e9a8037d41faea2bfdf3d64f1 and 5213a0a67ec635a45e640364e8aa9bf5f431625e), but only added in the "docs" branch. This patch copies the information to the swagger file. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 79c877cfa71f7929facda0160bfec12ebed4e0ef) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Hannes Ljungberg

commit sha 37851d8f5bb7a86d8b393632ac00b7e6953ce5bf

Update service networks documentation The previous description stated that an array of names / ids could be passed when the API in reality expects objects in the form of NetworkAttachmentConfig. This is fixed by updating the description and adding a definition for NetworkAttachmentConfig. Signed-off-by: Hannes Ljungberg <hannes@5monkeys.se> (cherry picked from commit 4d09fab232ed282d020afbe1e0935b53379df4ad) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Odin Ugedal

commit sha 9da49d0b993511c4e6e0f8f6192b258805475569

Fix phrasing when referring to the freezer cgroup Signed-off-by: Odin Ugedal <odin@ugedal.com> (cherry picked from commit 9c94e8260a82d6190204654e2285088c749930dc) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 2c571d3a459ba7739a216af59b3fab4760fccde0

swagger: move ContainerState to definitions Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7e0afd4934528d89e09bd850490db6477222df07) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 67ac9ab190998499e9c8ae7ffb312ca221a1a58c

swagger: add missing container Health docs Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 9ae7196775dddeb49be5195e00572a55b3c4658a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Felipe Ruhland

commit sha 1942d3a8b14d79f62a15a0b8482185a283a41ae9

Fix Engine API version history typo Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com> (cherry picked from commit 8107d4485216835a1347839d42cd1f657a9b37d8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha abfed203eb1b64af5b9fab8d5f8d0ac3a9be7f93

Merge pull request #451 from thaJeztah/19.03_backport_swagger_fixes [19.03 backport] assorted swagger / API docs fixes

view details

push time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_backport_swagger_fixes

delete time in 10 hours

PR merged docker/engine

[19.03 backport] assorted swagger / API docs fixes

backports of:

  • https://github.com/moby/moby/pull/39485 fix swagger.yaml #39484
    • relates to moby/moby#39484 Swagger API: container start or stop api response is incorrect
    • closes moby/moby#39253 API: Make response body empty when starting a started container or stopping a stopped container
    • relates to https://github.com/docker-php/docker-php/issues/337 Stopping an already stopped container throws a serializer exception
  • https://github.com/moby/moby/pull/39519 Fix indentation in some description [carry 38654]
    • closes https://github.com/moby/moby/pull/38654
  • https://github.com/moby/moby/pull/39700 Document message parameter to /images/create
    • This parameter was introduced 4 years ago in https://github.com/moby/moby/commit/b857dadb334fe0660abce4ae73a8b5b5c7f92c33 as part of https://github.com/moby/moby/pull/15711, but has never made it to the API docs.
  • https://github.com/moby/moby/pull/39820 Add missing Platform to swagger definition for /containers/{id}/json
  • https://github.com/moby/moby/pull/40341 swagger: restore bind options information
    • This information was added to an older version of the API documentation (through https://github.com/moby/moby/commit/164ab2cfc9900a5e9a8037d41faea2bfdf3d64f1 and https://github.com/moby/moby/commit/5213a0a67ec635a45e640364e8aa9bf5f431625e (https://github.com/moby/moby/pull/27089)), but only added in the "docs" branch.
    • fixes https://github.com/moby/moby/issues/27029
  • https://github.com/moby/moby/pull/39495 Update service networks documentation
  • https://github.com/moby/moby/pull/39759 Fix phrasing when referring to the freezer cgroup
  • https://github.com/moby/moby/pull/40348 Swagger: add missing container Health docs, and add ContainerState as definition
    • fixes https://github.com/moby/moby/issues/40323 Document Health status returned by "docker inspect"
  • https://github.com/moby/moby/pull/39993 Fix Engine API version history typo
+227 -89

0 comment

3 changed files

thaJeztah

pr closed time in 10 hours

push eventdocker/engine

Sebastiaan van Stijn

commit sha 2b05c146ef22f6b36f56bed2af9687b9195f00eb

[19.03] Bump Golang 1.12.15 full diff: https://github.com/golang/go/compare/go1.12.14...go1.12.15 go1.12.15 (released 2020/01/09) includes fixes to the runtime and the net/http package. See the Go 1.12.15 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.12.15+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha e6ba13d3b9d0b48ac25db9d2bb7e432bff239c9e

Merge pull request #452 from thaJeztah/19.03_bump_golang_1.12.15 [19.03] Bump Golang 1.12.15

view details

push time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_bump_golang_1.12.15

delete time in 10 hours

PR merged docker/engine

[19.03] Bump Golang 1.12.15 impact/changelog

full diff: https://github.com/golang/go/compare/go1.12.14...go1.12.15

go1.12.15 (released 2020/01/09) includes fixes to the runtime and the net/http package. See the Go 1.12.15 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.15+label%3ACherryPickApproved

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+4 -4

0 comment

4 changed files

thaJeztah

pr closed time in 10 hours

delete branch docker/compose

delete branch : ndeloof-patch-1

delete time in 11 hours

issue commentdocker/cli

Provide a way to download only the docker-cli

Yes, the Windows binaries were no longer published at some point, because for Windows only Docker for Windows ("Docker Desktop"), for desktop machines, and Docker Enterprise (for Windows Server) were supported.

Changing that (and at least publish client binaries again) is being discussed, but no decision was made yet. You can find "master" builds on https://master.dockerproject.org (but that location is being deprecated, which is where the discussion about this comes in 😅)

DanielHabenicht

comment created time in 12 hours

issue commentdocker/cli

Provide a way to download only the docker-cli

I think the above should work on Windows as well (COPY --from) but of course with modified paths (docker.exe instead of docker)

DanielHabenicht

comment created time in 13 hours

issue commentdocker/cli

Provide a way to download only the docker-cli

For linux, the CLI and Engine (daemon) are separate packages nowadays, so you can install just the docker-ce-cli package; e.g. here's the packages for Ubuntu Xenial; https://download.docker.com/linux/ubuntu/dists/xenial/pool/stable/amd64/

If you want to use add the cli to an image you're building, there's an easy way to do this in your Dockerfile:

FROM <your base image>
COPY --from=docker:19.03 /usr/local/bin/docker /usr/local/bin

The above will pull the official docker:19.03 image from Docker hub, and copy the docker CLI from it to your image.

If you want to be able to specify the version to install at build time, you can use a build-arg. For example:

ARG DOCKER_VERSION=19.03

# create an "alias" because COPY --from does not support expanding variables
FROM docker:${DOCKER_VERSION} AS docker

FROM ubuntu:16.04
COPY --from=docker /usr/local/bin/docker /usr/local/bin

Then to override the default version, (e.g. to install the docker 18.09 cli);

docker build -t foo --build-arg DOCKER_VERSION=18.09 .
DanielHabenicht

comment created time in 13 hours

issue commentmoby/moby

Question regarding completeness of Dockerfile integration tests

I know at some points we parsed/tested every dockerfile on GitHub 😂 ; https://twitter.com/thaJeztah/status/601434642126745601?s=20

https://github.com/moby/moby/pull/12648#issuecomment-104341648

Screenshot 2020-01-23 at 16 46 34

1605200517

comment created time in 13 hours

PR merged docker/cli

Add content trust tests for run command area/testing area/trust status/2-code-review

Signed-off-by: glefloch glfloch@gmail.com

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did I add two tests on trust content for the run command. This intend to partially close #951

- How I did it I migrated code from the pull request removing the testsuite from moby repository ( TestUntrustedRun and TestTrustedRunFromBadTrustServer)

- How to verify it You can verify it by running the e2e testsuite

- Description for the changelog Adding trust test for run command

- A picture of a cute animal (not mandatory but encouraged)

image

+77 -1

5 comments

1 changed file

glefloch

pr closed time in 13 hours

push eventdocker/cli

glefloch

commit sha 348f24cae682e1dc465bfb10e872e8de2a36321d

Add content trust tests for run command Signed-off-by: Guillaume Le Floch <glfloch@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 74fb129a73a348689794781e3ad5d1d2dcca6d7a

Merge pull request #1596 from glefloch/951-run-trust-tests Add content trust tests for run command

view details

push time in 13 hours

issue closeddocker/cli

[quality] content trust tests coverage

While porting DockerTrustSuite from moby/moby, few tests weren't ported (because a bit tricky to achieve as is), see https://github.com/docker/cli/pull/924#discussion_r175119661

This issues is there to track progress on adding test coverage on content trust features, this means unit and e2e tests.

  • [ ] container
  • [ ] image
  • [ ] plugin
  • [ ] services
  • [ ] build

closed time in 13 hours

vdemeester

issue commentmoby/moby

Question regarding completeness of Dockerfile integration tests

The moby/buildkit repository is the canonical place for the Dockerfile specification.

If you're intending to build on kubernetes, you may be interested in @AkihiroSuda's talks about Buildkit on Kubernetes;

  • https://www.slideshare.net/AkihiroSuda/dockercon2019-deploying-rootless-buildkit-on-kubernetes
  • https://www.slideshare.net/AkihiroSuda/kubeconeu-building-images-efficiently-and-securely-on-kubernetes-with-buildkit
1605200517

comment created time in 14 hours

Pull request review commentmoby/buildkit

Add hostname specifying for building

 func Dockerfile2LLB(ctx context.Context, dt []byte, opt ConvertOpt) (*llb.State, 			k, v := parseKeyValue(env) 			d.state = d.state.AddEnv(k, v) 		}+		if val, ok := opt.BuildArgs["HOSTNAME"]; ok {

Should these "special" build-args be namespaces somehow? This could easily conflict with someone having a ARG HOSTNAME in their dockerfile (is that a concern?)

jingxiaolu

comment created time in 14 hours

pull request commenttheupdateframework/notary

Feature/go modules

Thanks for adding that validation!

I noticed the diff in vendoring is quite big; some of that can be attributed to go mod vendoring a slightly different set of files, but it also looks like some dependencies were updated (e.g. I noticed logrus going from 1.4.1 to 1.4.2).

Was this intentional? (Were there modules that enforced the updated version?) Basically; wondering if it's possible to keep this PR narrowed to just the switch to go mod (same version of dependencies, only different tool for dependency management), and keep the updating of dependencies separate (could be either a PR that's merged before or after this one)

marcofranssen

comment created time in 15 hours

Pull request review commentmoby/buildkit

Makefile: specify DOCKER_BUILDKIT when make images

 imageDocker() { 		echo "PREFER_BUILDCTL=1 needs to be set to build images for $PLATFORMS" 		exit 1 	fi+	export DOCKER_BUILDKIT=1 	set -x 	docker build $progressFlag --platform=$PLATFORMS -t $REPO:$TAG . 	docker build $progressFlag --platform=$PLATFORMS -t $REPO:$TAG-rootless --target rootless .

Does the export above persist in the current shell after running this script?

Perhaps instead do

	DOCKER_BUILDKIT=1 docker build $progressFlag --platform=$PLATFORMS -t $REPO:$TAG .
	DOCKER_BUILDKIT=1 docker build $progressFlag --platform=$PLATFORMS -t $REPO:$TAG-rootless --target rootless .
jingxiaolu

comment created time in 15 hours

issue commentmoby/moby

OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "process_linux.go:101: executing setns process caused \"exit status 1\"": unknown

(not related to the issue, but I noticed the warning)

WARNING: API is accessible on http://0.0.0.0:2376 without encryption.
         Access to the remote API is equivalent to root access on the host. Refer
         to the 'Docker daemon attack surface' section in the documentation for
         more information: https://docs.docker.com/engine/security/security/#docker-daemon-attack-surface

Make sure that host is not publicly accessible. If you need to access a remote daemon without publicly exposing its API, you might be interested in the option to use an ssh connection for that, which is supported by Docker 18.09 and up (see https://github.com/docker/cli/pull/1014)

yuklia

comment created time in 15 hours

issue closedmoby/moby

Question regarding completeness of Dockerfile integration tests

Hello moby team,

I have a question - how do you ensure the completeness of the unit/integration tests for Dockerfile?

That is, there should be a great variety of test Dockerfiles to test a mostly large set of possible AND meaningful combinations of tokens?

What I find here though are just a couple of files? Or how do you test this?

https://github.com/moby/moby/tree/master/integration/build/testdata

closed time in 15 hours

1605200517

issue commentmoby/moby

Question regarding completeness of Dockerfile integration tests

Let me close this ticket because it's not really a bug report, but feel free to continue the conversation.

Also if there was a particular reason for your question (e.g. did you run into a problem with a specific Dockerfile), feel free to open a ticket for that!

1605200517

comment created time in 15 hours

pull request commentdocker/cli

Add content trust tests for run command

Oops! Wanted to leave a comment that I did that, but forgot 😊 (I had the branch checked out locally, so thought I'd just as well push the change)

glefloch

comment created time in 16 hours

issue commentdocker/docker.github.io

Unexpected added Dockerfile to image

Hm, yes, I think there wording is a bit confusing;

You can even use the .dockerignore file to exclude the Dockerfile and .dockerignore files. These files are still sent to the daemon because it needs them to do its job. But the ADD and COPY instructions do not copy them to the image.

The second sentence ("But the ADD and ...") means to say "when adding them to .dockerignore, they are still sent to the daemon to perform the build, but ADD and COPY instructions won't copy them to the image.

The markdown source file for that page is located in the docker/cli repository; let me know if you're interested in opening a pull request (otherwise I can open one); https://github.com/docker/cli/blob/master/docs/reference/builder.md

(if you're interested in contributing: note that the docker/cli repository requires the commit message to have a DCO sign-off line; https://github.com/docker/cli/blob/fedbc5861bf7f4ad64438f0c94e1aa7984b54974/CONTRIBUTING.md#sign-your-work)

Smuu

comment created time in 16 hours

issue commentdocker/for-linux

docker-ce package for ARM debian

Thanks!

@arkodg @tiborvass @ehazlett FYI

antony-rheneus

comment created time in 16 hours

delete branch thaJeztah/docker-ce-packaging

delete branch : 19.03_backport_file_permissions

delete time in 17 hours

issue commentdocker/swarmkit

[Feature Request] Allow live-restore in swarm mode cluster.

I think this would be difficult to support/add; even though the containers could be kept running, other parts would still shut-down when upgrading the daemon, which means that (e.g.) swarm managers won't be able to communicate with the worker during that time; as a result, the reconciliation loop would kick in, and managers would reschedule tasks to be deployed on other nodes.

Once the daemon comes back up, the containers that were kept running would still be shut-down (because they've been rescheduled).

live-restore and swarm services both are addressing the same (kind of) problem (but in different ways); live-restore for a single, non-orchestrated system, and swarm services for orchestrated systems (providing high availability through "redundancy" / reconciliation)

BSWANG

comment created time in 20 hours

pull request commenttheupdateframework/notary

Feature/go modules

What if you forget to re-vendor after updating modules?

Yes, the repository should have a vendor check to validate that vendoring is done correctly (looks like there's no check currently? there should be one! 😅). Something like this; https://github.com/containerd/project/blob/b8808e568e74c98eb568f54135fcf6c9c89a3f8e/script/validate/vendor

marcofranssen

comment created time in 20 hours

issue commentdocker/cli

device mount fails under remote context in MacOS with 19.03.5 docker CLI

We should probably make it default to linux if no OSType was found (or when talking to an older API version)

The code to detect the OSType didn't change between v18.09 and v19.03; both use the same; https://github.com/docker/cli/blob/v18.09.0/cli/command/cli.go#L212-L230

Curious though why it's not able to get the API version; the OSType header has been there for a while (latest change in that area was in https://github.com/moby/moby/pull/35151, which was well before 18.03)

Would you be able to perform a GET on the /_ping endpoint for your remote daemon?

(e.g. `curl -v 'https://<your remote host>/_ping') ?

This is what's returned from my local Docker for Mac daemon;

curl -v --unix-socket /var/run/docker.sock 'http://localhost/_ping'

*   Trying /var/run/docker.sock:0...
* Connected to localhost (docker.sock) port 80 (#0)
> GET /_ping HTTP/1.1
> Host: localhost
> User-Agent: curl/7.65.3
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Api-Version: 1.40
< Cache-Control: no-cache, no-store, must-revalidate
< Content-Length: 2
< Content-Type: text/plain; charset=utf-8
< Date: Wed, 22 Jan 2020 22:59:30 GMT
< Docker-Experimental: true
< Ostype: linux
< Pragma: no-cache
< Server: Docker/19.03.5 (linux)
<
* Connection #0 to host localhost left intact
OK
sureshsankaran

comment created time in a day

pull request commentmoby/moby

Add Thomas H. Cormen and Elizebeth Friedman to names generator

@tiborvass @AkihiroSuda ptal

francoraphael

comment created time in a day

pull request commentopencontainers/runc

rootfs: do not permit /proc mounts to non-directories

oh, nevermind; I see the e-mail thread 👍

cyphar

comment created time in a day

pull request commentopencontainers/runc

rootfs: do not permit /proc mounts to non-directories

Will this be tagged as v1.0.0-rc10 ?

cyphar

comment created time in a day

pull request commentdocker/compose

Tag as `x.y.z` without `v` prefix

right, but after tagging, we can create a new release and upload the same binaries there?

ndeloof

comment created time in a day

pull request commentdocker/swarmkit

Fix leaking log subscription contexts

awesome, thanks!

dperny

comment created time in a day

issue commentdocker/compose

v1.25.2 Windows x86_64 checksum file looks busted

TIL; but yes that sounds good

andrewrothstein

comment created time in a day

pull request commentdocker/docker-ce-packaging

[19.03] bump docker app to 0.9.0-beta1

closing this one for now, but we can reopen if needed

eunomie

comment created time in a day

issue closeddocker/cli

Enhancement: "log driver / opts" missing in `docker service inspect` pretty-print

Noticed that the logging-driver and options are not included in the --format=pretty output for a service.

Create a service with a custom logging driver and -options set;

docker service create --log-driver=json-file --log-opt max-file=5 --name loggie nginx:alpine

Inspect the service in JSON format, and notice that the options are set:

docker service inspect --format='{{json .Spec.TaskTemplate.LogDriver}}' loggie
{"Name":"json-file","Options":{"max-file":"5"}}

Inspect the service using the "pretty-print" format, and notice that the logging options are missing:

docker service inspect --format=pretty loggie

ID:		243u3kmrhw62f5ja4gh0gf0mr
Name:		loggie
Service Mode:	Replicated
 Replicas:	1
UpdateStatus:
 State:		completed
 Started:	17 minutes ago
 Completed:	17 minutes ago
 Message:	update completed
Placement:
UpdateConfig:
 Parallelism:	1
 On failure:	pause
 Monitoring Period: 5s
 Max failure ratio: 0
 Update order:      stop-first
RollbackConfig:
 Parallelism:	1
 On failure:	pause
 Monitoring Period: 5s
 Max failure ratio: 0
 Rollback order:    stop-first
ContainerSpec:
 Image:		nginx:alpine@sha256:366c39a589f69a893368d942d9d323893025e8c27a523657ba3a2119dfc66057
 Init:		false
Resources:
Endpoint Mode:	vip

closed time in a day

thaJeztah

issue commentdocker/cli

Enhancement: "log driver / opts" missing in `docker service inspect` pretty-print

can be closed now, as https://github.com/docker/cli/pull/1950 was just merged

thaJeztah

comment created time in a day

PR opened docker/engine

[19.03 backport] Fix possible runtime panic in Lgetxattr

If unix.Lgetxattr returns an error, then sz == -1 which will cause a runtime panic if errno == unix.ERANGE.

backport of https://github.com/moby/moby/pull/40283

+15 -6

0 comment

1 changed file

pr created time in a day

pull request commentdocker/docker-ce-packaging

[19.03 backport] fix file permissions

@silvin-lubecki @StefanScherer @zelahi ptal

thaJeztah

comment created time in 2 days

delete branch thaJeztah/docker-ce-packaging

delete branch : 19.03_backport_eq_fix

delete time in 2 days

push eventdocker/docker-ce-packaging

Xiang Dai

commit sha 9d310a42baee4880fc93a4eff29fab7a2f4b96f6

fix eq issue Signed-off-by: Xiang Dai <764524258@qq.com> (cherry picked from commit bfec9e6e02122f53dc3d1d7fe11334efce201ffe) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 4b2e4cbf81d5cdc11fb6832bd7864e7b85c7c23e

Merge pull request #423 from thaJeztah/19.03_backport_eq_fix [19.03 backport] fix eq issue

view details

push time in 2 days

PR merged docker/docker-ce-packaging

[19.03 backport] fix eq issue

Backport of https://github.com/docker/docker-ce-packaging/pull/397

+3 -3

3 comments

3 changed files

thaJeztah

pr closed time in 2 days

pull request commentdocker/docker-ce-packaging

[19.03 backport] fix eq issue

bringing this one in to reduce the diff with master

thaJeztah

comment created time in 2 days

issue commentdocker/compose

v1.25.2 Windows x86_64 checksum file looks busted

Comparing the current one with an older release;

Compose: 1.25.0 (https://github.com/docker/compose/releases/download/1.25.0/docker-compose-Windows-x86_64.exe.sha256):

a5dde54d360de1972758bcde20f7eeee5a8d13a9a6b1921198c17616eee51f3e  docker-compose-Windows-x86_64.exe

Compose 1.25.2:

D48DA6103D164D13604105A3057F59869FD454F40907068EC7848772F6C1930C *docker-compose-Windows-x86_64.exe

Looks like the current one;

  • is in all-caps (probably not an issue?)
  • has an asterisk (*) in front of the binary name

There's indeed some non-printable characters at the start (BOM header perhaps?), and the file looks to be in UTF-8/UTF-16? (twice the size of the old one)

hexdump -C docker-compose-Windows-x86_64.exe.sha256
00000000  ff fe 44 00 34 00 38 00  44 00 41 00 36 00 31 00  |..D.4.8.D.A.6.1.|
00000010  30 00 33 00 44 00 31 00  36 00 34 00 44 00 31 00  |0.3.D.1.6.4.D.1.|
00000020  33 00 36 00 30 00 34 00  31 00 30 00 35 00 41 00  |3.6.0.4.1.0.5.A.|
00000030  33 00 30 00 35 00 37 00  46 00 35 00 39 00 38 00  |3.0.5.7.F.5.9.8.|
00000040  36 00 39 00 46 00 44 00  34 00 35 00 34 00 46 00  |6.9.F.D.4.5.4.F.|
00000050  34 00 30 00 39 00 30 00  37 00 30 00 36 00 38 00  |4.0.9.0.7.0.6.8.|
00000060  45 00 43 00 37 00 38 00  34 00 38 00 37 00 37 00  |E.C.7.8.4.8.7.7.|
00000070  32 00 46 00 36 00 43 00  31 00 39 00 33 00 30 00  |2.F.6.C.1.9.3.0.|
00000080  43 00 20 00 2a 00 64 00  6f 00 63 00 6b 00 65 00  |C. .*.d.o.c.k.e.|
00000090  72 00 2d 00 63 00 6f 00  6d 00 70 00 6f 00 73 00  |r.-.c.o.m.p.o.s.|
000000a0  65 00 2d 00 57 00 69 00  6e 00 64 00 6f 00 77 00  |e.-.W.i.n.d.o.w.|
000000b0  73 00 2d 00 78 00 38 00  36 00 5f 00 36 00 34 00  |s.-.x.8.6._.6.4.|
000000c0  2e 00 65 00 78 00 65 00  0d 00 0a 00              |..e.x.e.....|
000000cc

Which is not in the old one;

hexdump -C docker-compose-Windows-x86_64.exe.sha256

00000000  61 35 64 64 65 35 34 64  33 36 30 64 65 31 39 37  |a5dde54d360de197|
00000010  32 37 35 38 62 63 64 65  32 30 66 37 65 65 65 65  |2758bcde20f7eeee|
00000020  35 61 38 64 31 33 61 39  61 36 62 31 39 32 31 31  |5a8d13a9a6b19211|
00000030  39 38 63 31 37 36 31 36  65 65 65 35 31 66 33 65  |98c17616eee51f3e|
00000040  20 20 64 6f 63 6b 65 72  2d 63 6f 6d 70 6f 73 65  |  docker-compose|
00000050  2d 57 69 6e 64 6f 77 73  2d 78 38 36 5f 36 34 2e  |-Windows-x86_64.|
00000060  65 78 65 0a                                       |exe.|
00000064
andrewrothstein

comment created time in 2 days

issue commentdocker/compose

v1.25.2 Windows x86_64 checksum file looks busted

ping @ndeloof @ulyssessouza PTAL

andrewrothstein

comment created time in 2 days

pull request commentdocker/compose

Tag as `x.y.z` without `v` prefix

Should we keep this PR for the next release, and for the current one just manually push a tag using the same commit (698e2846a82dbc48c14a017890f826e3d63ab783) ?

ndeloof

comment created time in 2 days

issue commentdocker/compose

Latest release tagged with 'v'

I think we should at least have the non-prefixed tag (same commit, just a new tag pushed).

Having a v prefix is commonly used, but not strictly needed (in fact, for repositories that use SemVer, it's actually non-compliant; unfortunately for repositories using Golang, go mod enforces the v prefix, so for those, the prefix is needed).

lsanders

comment created time in 2 days

delete branch thaJeztah/docker.github.io

delete branch : remove_engine_commands

delete time in 2 days

push eventdocker/docker.github.io

Sebastiaan van Stijn

commit sha f24e2f1b4d55538b0285c29c25b5cb1db8187bf2

Remove "docker engine" subcommands Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha ebc3b502ee941c887fbd2d3d7d1937306c9dcda0

Update yaml files to remove "engine" subcommands Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 7fb9bc05e41aaaa38e4116d3f9cdaf334322ee31

Merge pull request #9984 from thaJeztah/remove_engine_commands Remove "docker engine" commands

view details

push time in 2 days

PR merged docker/docker.github.io

Remove "docker engine" commands Engine Relnotes

relates to https://github.com/docker/cli/issues/2213

These subcommands were created to allow upgrading a Docker Community engine to Docker Enterprise, but never really took off. With the migration of the docker "enterprise" products to Mirantis, we should remove these subcommands as releases may no longer be done in sync in future.

+4 -475

3 comments

14 changed files

thaJeztah

pr closed time in 2 days

more