profile
viewpoint
Sebastiaan van Stijn thaJeztah thaJeztah Netherlands @docker and @moby maintainer, member of the Moby TSC. Open Source contributions manager @ Docker, Inc. Feeds @GordonTheTurtle with issues and PR's

sirupsen/logrus 16036

Structured, pluggable logging for Go.

docker/classicswarm 5820

Swarm Classic: a container clustering system. Not to be confused with Docker Swarm which is at https://github.com/docker/swarmkit

moby/buildkit 2923

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit

docker/for-mac 1408

Bug reports for Docker Desktop for Mac

docker/for-win 1154

Bug reports for Docker Desktop for Windows

docker/go-plugins-helpers 265

Go helper packages to extend the Docker Engine

docker/hub-feedback 189

Feedback and bug reports for the Docker Hub

swarmzilla/swarm2k 81

The Docker Swarm 2000 Collaborative Project

docker/gordon-bot 33

Gordon the turtle IRC bot to rebuild Jenkins builds.

pull request commentdocker/cli

build: print error if BuildKit-specific flags are used without BuildKit enabled

@tiborvass @tonistiigi @silvin-lubecki PTAL

thaJeztah

comment created time in 13 minutes

PR opened docker/cli

build: print error if BuildKit-specific flags are used without BuildKit enabled area/builder kind/enhancement

fixes https://github.com/docker/cli/issues/2680

With this patch, the --progress, --secret, --ssh, and --output flags trigger an error when trying to use without BuildKit enabled;

DOCKER_BUILDKIT=0 docker build --progress=plain .
The --progress flag requires BuildKit to be enabled. Enable BuildKit with DOCKER_BUILDKIT=1

DOCKER_BUILDKIT=0 docker build --output=foo .
The --progress flag requires BuildKit to be enabled. Enable BuildKit with DOCKER_BUILDKIT=1

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+15 -0

0 comment

1 changed file

pr created time in 13 minutes

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 9e35b461e1b6663ed0b97b9876b0aef00f6f9330

build: print error if BuildKit-specific flags are used without BuildKit enabled With this patch, the `--progress`, `--secret`, `--ssh`, and `--output` flags trigger an error when trying to use without BuildKit enabled; DOCKER_BUILDKIT=0 docker build --progress=plain . The --progress flag requires BuildKit to be enabled. Enable BuildKit with DOCKER_BUILDKIT=1 DOCKER_BUILDKIT=0 docker build --output=foo . The --progress flag requires BuildKit to be enabled. Enable BuildKit with DOCKER_BUILDKIT=1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 14 minutes

create barnchthaJeztah/cli

branch : buildkit_output

created branch time in 15 minutes

delete branch thaJeztah/docker.github.io

delete branch : compose_highlighting

delete time in 31 minutes

create barnchthaJeztah/docker.github.io

branch : compose_highlighting

created branch time in 37 minutes

push eventthaJeztah/docker.github.io

Sebastiaan van Stijn

commit sha 9f4db87055d876c239ea96349db43185e2329a22

compose: add WordPress example to TOC Also removes links to individual examples, instead linking to the "compose samples" page. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Amir Keshavarz

commit sha 001e083d671fe89ccffbcd25c6e9dbac0918b518

Add ArvanCloud machine driver

view details

Jason C

commit sha 7e9e551fb81718770c6e5edfe7fd3756041998ab

Update startup-order.md

view details

Ali Akrour

commit sha edbb9f9e7522c100dc3bac71bbb00e712c895f54

Improved Dockerfile compatibility line 28 : modified the regexp to also match if the optional '#' caracter is present to comment the line, like it was by default on my Debian:9 official based image. line 28 : modified the regexp by adding the 'g' end caracter, just for better readability for beginners like me. line 31 : modified the order between option '-i' and the regexp argument, just for better readability for beginners like me.

view details

Melanie Kwon

commit sha f256ba065b78bd1199502ac565df732454635761

Update quickstart Django example Updating example from Django 2.x to Django 3.x

view details

Usha Mandya

commit sha 01779db0762fc3a1547d203cd04174275b2d0a67

Add updated discount code

view details

Sebastiaan van Stijn

commit sha e55bd98dce6549c5dc1c251e5cd1461b7443d050

Merge pull request #11218 from usha-mandya/get-started Add updated discount code

view details

Geetha Rangaswamaiah

commit sha 77b7b73652c95abf4245098332211733577f21f8

Fix compose docs grammatical errors

view details

Usha Mandya

commit sha 9ddc2fc75f6267f8bd4650fe013133c4c9776b47

Merge pull request #11221 from geetha-rangaswamaiah/compose-docs Fix compose docs grammatical errors

view details

Joshua Powers

commit sha 8058df4f7ec9b0d6d77178980ff879a73118406f

Update ubuntu.md Ubuntu 19.10 (Eoan) is EOL.

view details

Usha Mandya

commit sha 4b477cc3725d6f5c511ccd7fa707fe6fa6f6bebe

Merge pull request #11230 from powersj/patch-1 Update ubuntu.md

view details

Sebastiaan van Stijn

commit sha 9af8c568340977ede4d206c40e99674d694bd177

Merge pull request #11176 from alinuxien/patch-1 Improved Dockerfile compatibility and readability

view details

Sebastiaan van Stijn

commit sha 1e0a78bacbd79e2badcf479a285ce1bcda9d1a69

Merge pull request #10992 from satrobit/master Add ArvanCloud machine driver

view details

Mark Schmale

commit sha ce341bd72f40f3eaf8bc79c716c0e6d7a92b72e2

Add note about setup being not viable for production (#11228) * Add note about setup beeing not viable production I think there should at least a small hint that this guide is just intended as a bare-bones development environment and should not at all be rolled into production like this. Relates to #7622 * Minor style updates Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>

view details

Usha Mandya

commit sha 7caa5c08f5793ca1fdb5369e6703287fea758594

Remove troubleshooting and stack overflow section

view details

Usha Mandya

commit sha 1532bb47729ade7eeb3b243060e7316e130712aa

Fix md syntax

view details

Sebastiaan van Stijn

commit sha 413ec52d413f580c6feeb73db92f2ca87bd5c3b1

Merge pull request #11236 from usha-mandya/django-md-fix Fix md syntax

view details

Usha Mandya

commit sha 597df3c9bd2d6d356614f1ef77793f22ce7222ea

Update pricing FAQ URLs Signed-off-by: Usha Mandya <usha.mandya@docker.com>

view details

Kenyon Ralph

commit sha fc40ccf26962d994736cccb90b7aeaab6d210ac2

btrfs-driver.md: remove unneeded use of sudo and cat

view details

Usha Mandya

commit sha 093d2af9866c02ca36294f150ec2598184e757cb

Merge pull request #11238 from usha-mandya/hub-faq-patch Update pricing FAQ URLs

view details

push time in 39 minutes

PR opened docker/cli

Fix buildkit flags not being hidden without buildkit enabled process/cherry-pick status/2-code-review

These annotations use nil as value, which caused the flag-hiding functions to ignore the annotations, and therefore not hiding the flags.

introduced in https://github.com/docker/cli/pull/2424

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+6 -2

0 comment

1 changed file

pr created time in an hour

create barnchthaJeztah/cli

branch : fix_flag_hiding

created branch time in an hour

push eventthaJeztah/cli

Jorge Vallecillo

commit sha e7203bf81b2c7c186341f732169df114f78a4829

Fix 2 typos Consecutive occurrences of 'the' Signed-off-by: Jorge Vallecillo <jorgevallecilloc@gmail.com>

view details

Sebastiaan van Stijn

commit sha e4b7edde09589f6eba85edf446cddea9f85f4209

Merge pull request #2732 from altmas5/fix-typos Fix 2 typos

view details

push time in 2 hours

push eventdocker/cli

Jorge Vallecillo

commit sha e7203bf81b2c7c186341f732169df114f78a4829

Fix 2 typos Consecutive occurrences of 'the' Signed-off-by: Jorge Vallecillo <jorgevallecilloc@gmail.com>

view details

Sebastiaan van Stijn

commit sha e4b7edde09589f6eba85edf446cddea9f85f4209

Merge pull request #2732 from altmas5/fix-typos Fix 2 typos

view details

push time in 2 hours

PR merged docker/cli

Fix 2 typos

- What I did

Removed consecutive occurrences of 'the'

- How I did it

s/the the /the /g

- How to verify it

grep -ir --color 'the the ' cli/

- Description for the changelog

Fixed a small typo included in update_test.go and update.go

+2 -2

1 comment

2 changed files

altmas5

pr closed time in 2 hours

PullRequestReviewEvent

PR opened moby/sys

mountinfo: minor cleanup

just a minor cleanup

+4 -3

0 comment

2 changed files

pr created time in 3 hours

push eventthaJeztah/containerd

Sebastiaan van Stijn

commit sha ecd0b30a9d12ef3f4bc625416d828b45874531b5

vendor: golang.org/x/sys eff7692f900947, containerd/console v1.0.0-14-gbc2a1bd full diff: https://github.com/golang/sys/compare/ed371f2e16b4b305ee99df548828de367527b76b...eff7692f900947b7d782d16af70ca32cc40774f0 Adds openat2 for linux openat2 is a new syscall added to Linux 5.6. It provides a superset of openat(2) functionality, extending it with flags telling the kernel how to resolve the paths. For more info, see https://lwn.net/Articles/803237/ NOTE that this is a second attempt to add the call; the previous one (https://golang.org/cl/227280) was reverted (https://golang.org/cl/227846) due to the test case failure on ARM (https://golang.org/issue/38357). This CL has the test case reworked to be less assumptive to the testing environment. In particular, it first tries if the most simplistic openat2() call succeeds, and skips the test otherwise. It is done that way because CI can be under under different kernels and in various envrionments -- in particular, Docker+seccomp can result in EPERM from a system call (which is not expected otherwise). For previous discussions about the test case, see https://golang.org/cl/227865. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 44eed8ab1c8278d5e799e8c35348149744c0f87f

mount: replace mountinfo handling with moby/sys/mountinfo Trying to reduce duplicated effort in maintaining a mountinfo parser, this patch replaces the local implementation with the implementation in github.com/moby/sys, which is actively maintained and contains various optimizations. There are some small differences in the types used by the moby/sys package, so for now, some conversion is needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 1b3a2ff00c57b516ac7412dbc64400c22f12401b

mount: alias mount.Info to github.com/moby/sys/mountinfo.Info Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c48a1a0f1b8b0a1265085e6a2c592f2660274a4c

mount: mount.PID(), mount.Self(): change signature to return pointers Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 528144f54d6fb8b254ff6906fef9325fa7fd3976

mount.CleanupTempMounts() use github.com/moby/sys/mountinfo Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 hours

push eventthaJeztah/console

Sebastiaan van Stijn

commit sha 15ccc45d904129555b952e397c84314bb38ed436

Remove travis configuration file Now that we have GitHub actions running, the travis configuration file should no longer be needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Mike Brown

commit sha bc2a1bd489d28b51aeaee21ad4ec2bc4b984d896

Merge pull request #43 from thaJeztah/remove_travis Remove travis configuration file

view details

push time in 3 hours

PullRequestReviewEvent

push eventthaJeztah/containerd

ktock

commit sha 309b5e623c579780c69778b7f7b95919bbf992b3

vendor: update containerd/cri 210a86ca5bf6c8ca5f2553272d72c774b21fdec2 This includes the fix for additional labels passed to snapshotter. Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>

view details

Phil Estes

commit sha d6774b639214cf18e02b7a4eeabfea49c96bdf41

Merge pull request #4570 from ktock/vendor-cri vendor: update containerd/cri 210a86ca5bf6c8ca5f2553272d72c774b21fdec2

view details

Mike Brown

commit sha 30615c6fed24457e8b60eecd1e1982c5f27f9fda

testing out k8s prow test move Signed-off-by: Mike Brown <brownwm@us.ibm.com>

view details

Teemu Kallio

commit sha 71fd68a9207e3ec445df135486f829b3e380bf78

devicemapper: seperate implementation pkg from plugin pkg Signed-off-by: Teemu Kallio <teemu.kallio@pm.me>

view details

Phil Estes

commit sha 2575a73307d1716ce6f8e6914dc05524a2096be0

Merge pull request #4573 from teemuteemu/separate-devmapper-plugin Separate devmapper plugin

view details

Siddharth Yadav

commit sha 2354e187c3dfda263de5d8e3754bd47b7abf23d0

aufs: seperate implementation pkg from plugin pkg and revendor Signed-off-by: Siddharth Yadav <sedflix@gmail.com>

view details

Siddharth Yadav

commit sha 96f4ce4a5c24745efc9596975b885be30101a5f4

zfs: seperate implementation pkg from plugin pkg and revendor Signed-off-by: Siddharth Yadav <sedflix@gmail.com>

view details

Phil Estes

commit sha 1484593ee97de47d8cefddf74cbb72b33125d421

Merge pull request #4533 from sedflix/aufs-seperate-plugin feat(snapshot::aufs): config root_path

view details

Derek McGowan

commit sha fc2240915a6c0f3eed67ab00c95ecdb872fa95cf

Merge pull request #4527 from mikebrow/prow-test-pr k8s cri prow build test

view details

Derek McGowan

commit sha 438c87b8e0504623429cb0ed16ca506fb268c6a9

Merge pull request #4534 from sedflix/zfs-root-path zfs: seperate implementation pkg from plugin pkg

view details

Wei Fu

commit sha 4b05d039035b8f62c83e292c6451e0e6dd26930a

runtime/v2: cleanup dead shim before delete bundle The shim delete action needs bundle information to cleanup resources created by shim. If the cleanup dead shim is called after delete bundle, the part of resources maybe leaky. The ttrpc client UserOnCloseWait() can make sure that resources are cleanup before delete bundle, which synchronizes task deletion and cleanup deadshim. It might slow down the task deletion, but it can make sure that resources can be cleanup and avoid EBUSY umount case. For example, the sandbox container like Kata/Firecracker might have mount points over the rootfs. If containerd handles task deletion and cleanup deadshim parallelly, the task deletion will meet EBUSY during umount and fail to cleanup bundle, which makes case worse. And also update cleanupAfterDeadshim, which makes sure that cleanupAfterDeadshim must be called after shim disconnected. In some case, shim fails to call runc-create for some reason, but the runc-create already makes runc-init into ready state. If containerd doesn't call shim deletion, the runc-init process will be leaky and hold the cgroup, which makes pod terminating :(. Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Guanjun Gong

commit sha 0dea724fc0a8ac6599bb0d33aa3792ff1bd3a0aa

NewTask avoid unnecessary cio.NewCreator calls Signed-off-by: Guanjun Gong <gongguanjun@hotmail.com>

view details

Phil Estes

commit sha 68d97331be50877e57bae8d6d0a648e7c62932cf

Merge pull request #4538 from fuweid/update-shim-cleanup runtime/v2: cleanup dead shim before delete bundle

view details

Phil Estes

commit sha 534be84c5dfd78031603d2afde90098cc4347c6b

Merge pull request #4529 from gongguan/creator avoid unnecessary NewCreator calls

view details

Sebastiaan van Stijn

commit sha cf0c89a89e91f741a594049018313fdcb1920dbc

vendor: golang.org/x/sys eff7692f900947b7d782d16af70ca32cc40774f0 full diff: https://github.com/golang/sys/compare/ed371f2e16b4b305ee99df548828de367527b76b...eff7692f900947b7d782d16af70ca32cc40774f0 Adds openat2 for linux openat2 is a new syscall added to Linux 5.6. It provides a superset of openat(2) functionality, extending it with flags telling the kernel how to resolve the paths. For more info, see https://lwn.net/Articles/803237/ NOTE that this is a second attempt to add the call; the previous one (https://golang.org/cl/227280) was reverted (https://golang.org/cl/227846) due to the test case failure on ARM (https://golang.org/issue/38357). This CL has the test case reworked to be less assumptive to the testing environment. In particular, it first tries if the most simplistic openat2() call succeeds, and skips the test otherwise. It is done that way because CI can be under under different kernels and in various envrionments -- in particular, Docker+seccomp can result in EPERM from a system call (which is not expected otherwise). For previous discussions about the test case, see https://golang.org/cl/227865. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 5f821ee31148aeed13b7d3c8a1dff41ebe89b6dd

mount: replace mountinfo handling with moby/sys/mountinfo Trying to reduce duplicated effort in maintaining a mountinfo parser, this patch replaces the local implementation with the implementation in github.com/moby/sys, which is actively maintained and contains various optimizations. There are some small differences in the types used by the moby/sys package, so for now, some conversion is needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 2b7ceeedd0adf54f59b96ab9ad759088da8693d5

mount: alias mount.Info to github.com/moby/sys/mountinfo.Info Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha a28c7e92fb1fed1e6dc994696caee7d0fb32d65d

mount: mount.PID(), mount.Self(): change signature to return pointers Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 4d618fff16b298139c125cbdf2368fd8be7d0098

mount.CleanupTempMounts() use github.com/moby/sys/mountinfo Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 hours

create barnchthaJeztah/sys

branch : minor_cleanup

created branch time in 3 hours

PR opened containerd/containerd

[draft] mount: replace mountinfo handling with moby/sys/mountinfo

Trying to reduce duplicated effort in maintaining a mountinfo parser, this patch replaces the local implementation with the implementation in github.com/moby/sys, which is actively maintained and contains various optimizations.

Using a temporary vendor, pending https://github.com/moby/sys/pull/32 and https://github.com/moby/sys/pull/34

With this change, the only consumer of mount.Self() is containerd/cri. mount.PID() looks to be unused altogether, so both could potentially be removed if containerd/cri is updated.

+866 -861

0 comment

19 changed files

pr created time in 3 hours

create barnchthaJeztah/containerd

branch : use_moby_sys

created branch time in 3 hours

PR opened moby/sys

mountinfo: use idiomatic naming for fields

follow-up to https://github.com/moby/sys/pull/32

I am looking at using these modules in containerd, so that we can reduce the effort of maintaining "mountinfo" implementations.

This change renames the info fields to match the ones used in containerd, which are more "correct" from a Go naming perspective: https://github.com/containerd/containerd/commit/8cd218237b49b41bffa0035393143571ec01b157

This will be a breaking changes for consumers of this package, but we're still pre-v1.0.0, so if we want to make these changes, this is still possible now.

+43 -39

0 comment

13 changed files

pr created time in 4 hours

push eventthaJeztah/sys

Sebastiaan van Stijn

commit sha aba738aa3abb37b972fbacfd82d933417264f9f0

mountinfo: use idiomatic naming for fields I am looking at using these modules in containerd, so that we can reduce the effort of maintaining "mountinfo" implementations. This change renames the info fields to match the ones used in containerd, which are more "correct" from a Go naming perspective: https://github.com/containerd/containerd/commit/8cd218237b49b41bffa0035393143571ec01b157 This will be a breaking changes for consumers of this package, but we're still pre-v1.0.0, so if we want to make these changes, this is still possible now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 4 hours

create barnchthaJeztah/sys

branch : idiomatic_naming

created branch time in 4 hours

pull request commentmoby/sys

mountinfo: add test-cases for double quotes in Linux Mountinfo

@kolyshkin @AkihiroSuda PTAL

thaJeztah

comment created time in 4 hours

push eventthaJeztah/sys

Sebastiaan van Stijn

commit sha ddd8b9ba5d9b904f74ab3c72d6dc80478c370737

Add support for OpenBSD in addition to FreeBSD I am looking at using these modules in containerd, so that we can reduce the effort of maintaining "mountinfo" implementations. The containerd variant of this module currently supports OpenBSD in addition to FreeBSD. This patch bring in changes similar to the ones made in containerd in: https://github.com/containerd/containerd/commit/0828b7aa96b55e36a9594e3b98a3f6800bc0734a Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 4 hours

push eventthaJeztah/sys

Sebastiaan van Stijn

commit sha 327c37ada9965b830d3192e56f566560484cae82

mountinfo: add test-cases for double quotes in Linux Mountinfo This adds tests for handling paths containing double quotes, and is the equivalent of the tests added in containerd/containerd#4325 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 5 hours

pull request commentcontainerd/cri

pkg/server: make ensureRemoveAll() an alias for os.RemoveAll() on Windows

/test pull-cri-containerd-node-e2e

thaJeztah

comment created time in 5 hours

PR opened moby/sys

mountinfo: cope with double quotes in Linux Mountinfo

This adds tests for handling paths containing double quotes, and is the equivalent to the changes made in containerd/containerd#4325 to fix the problem described in containerd/containerd#4257

Signed-off-by: Sebastiaan van Stijn github@gone.nl

+105 -0

0 comment

1 changed file

pr created time in 5 hours

create barnchthaJeztah/sys

branch : mountinfo_quotes

created branch time in 5 hours

PR opened moby/sys

Add support for OpenBSD in addition to FreeBSD

I am looking at using these modules in containerd, so that we can reduce the effort of maintaining "mountinfo" implementations.

The containerd variant of this module currently supports OpenBSD in addition to FreeBSD.

This patch bring in changes similar to the ones made in containerd in:

https://github.com/containerd/containerd/commit/0828b7aa96b55e36a9594e3b98a3f6800bc0734a

+11 -7

0 comment

8 changed files

pr created time in 5 hours

create barnchthaJeztah/sys

branch : mountinfo_bsd

created branch time in 5 hours

pull request commentcontainerd/cri

pkg/server: make ensureRemoveAll() an alias for os.RemoveAll() on Windows

/test pull-cri-containerd-node-e2e

thaJeztah

comment created time in 5 hours

PR opened containerd/cri

pkg/server: make ensureRemoveAll() an alias for os.RemoveAll() on Windows

similar to https://github.com/moby/moby/pull/41478.

The tricks performed by ensureRemoveAll only make sense for Linux and other Unices, so separate it out, and make ensureRemoveAll for Windows just an alias of os.RemoveAll.

@cpuguy83 @AkihiroSuda @kolyshkin

+2 -57

0 comment

1 changed file

pr created time in 6 hours

create barnchthaJeztah/cri

branch : simplify_ensure_removeall_windows

created branch time in 6 hours

Pull request review commentmoby/moby

vendor: bump moby/sys/mountinfo/v0.2.0, moby/sys/mount/v0.1.1

 func (d *Daemon) Info(t testing.TB) types.Info { 	return info } -// cleanupMount unmounts the daemon root directory, or logs a message if-// unmounting failed.-func cleanupMount(t testing.TB, d *Daemon) {-	t.Helper()-	if err := mount.Unmount(d.Root); err != nil {

It happened not to be used in tests that are running on Windows 😞

Likewise, I recall noticing in https://github.com/containerd/cri/pull/1416 that RecursiveUnmount "worked" on Windows, because this slice would always be empty https://github.com/moby/moby/blob/v19.03.13/pkg/mount/mount.go#L142

thaJeztah

comment created time in 6 hours

PullRequestReviewEvent

Pull request review commentmoby/moby

vendor: bump moby/sys/mountinfo/v0.2.0, moby/sys/mount/v0.1.1

 func EnsureRemoveAll(dir string) error { 	exitOnErr := make(map[string]int) 	maxRetry := 50 -	// Attempt to unmount anything beneath this dir first+	// Attempt to unmount anything beneath this dir first. This is a no-op on Windows

Ah 🤦 yes, your PR renamed it to a _unix.go. I'll have to change

thaJeztah

comment created time in 6 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentmoby/buildkit

dockerfile: allow multiple values for ARG

So, if I recall correctly, we didn't do this, because ARG and ENV are very similar, but (unlike ARG) ENV does not enforce = to set a value (similar discussion in https://github.com/moby/moby/pull/17344).

Because of that, the following would be very confusing as they have completely different meanings:

# declare three ARGs: ONE, TWO, and THREE
ARG ONE TWO THREE

# define one ENV (ONE) with value "TWO THREE"
ENV ONE TWO THREE

So, the ARG syntax, by enforcing = to set a value, is more consistent and flexible as it would allow combinations of "declaring" args with and without a value in a single ARG:

ARG ONE=hello

FROM busybox AS stage-foo

# declare three ARGs:
ARG ONE TWO= THREE=world

In the example above;

  • arg ONE doesn't have a value set, and in this case inherits its value from the global ARG ONE
  • arg TWO is explicitly set to an empty string as default value (quotes are optional, so equivalent to ARG TWO="")
  • arg THREE has "world" as default value

Env vars did get some validation to try to prevent some accidental mistakes;

ENV ONE=one TWO two THREE three

Syntax error - can't find = in "TWO". Must be of the form: name=value

But will only produce an error if the first env-var uses an =, so the ARG example above will silently "succeed":

ENV ONE TWO= THREE=world

And produce a single env-var (ONE) with value "TWO= THREE=world"

So not sure what to do with this. I realize ARG and ENV are separate things, but they are so similar that I anticipate users to have them work the same, and trip over the differences.

My ideal would be to use the same syntax for ENV, but changing would be a breaking change, and likely will hit many existing Dockerfiles.

tonistiigi

comment created time in 6 hours

push eventthaJeztah/containerd.io

Sebastiaan van Stijn

commit sha 6d6fcab5b2da42a7a498394a22dd5bff2b3f8c99

Update latest release to 1.3.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Phil Estes

commit sha ed07c41aa08529c2235c0e051adba5fad1554ccc

keep releases.md in sync with containerd/containerd Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Phil Estes

commit sha 76605fc34c8722d9db904147f292532725e984ca

Merge pull request #52 from containerd/dep-updates Automated RELEASES.md sync update

view details

Derek McGowan

commit sha 64a77ad8e5c62a32e2c82ce01c5763551ed4f7c1

Merge pull request #51 from thaJeztah/bump_version Update latest release to 1.3.2

view details

lucperkins

commit sha 0fa3a5346e8ba1b7535093c199d9bad144ed2f6e

Add link checker and fix links Signed-off-by: lucperkins <lucperkins@gmail.com>

view details

lucperkins

commit sha 11cf61ab63e34fc4900a91b3eb343936f94a38e5

Make checker local only and add README instructions Signed-off-by: lucperkins <lucperkins@gmail.com>

view details

Phil Estes

commit sha 0680688fe1e91a38ecf6e479f988d1d6c64deba9

keep releases.md in sync with containerd/containerd Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Michael Crosby

commit sha 168930d52a2a9159417658d44903b0f64bcb7a5e

Merge pull request #55 from containerd/dep-updates Automated RELEASES.md sync update

view details

Phil Estes

commit sha 00b7fb20e89362a700b76d407fb135ee6ec28f43

Remove invalid links when copying in markdown This could become brittle, but for now seems like a reasonable quick fix to not have dead links in the copied-in releases.md from the main containerd repository. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

lucperkins

commit sha f3efd5e4b06aaa228cf459b7ce7e05209b082061

Merge remote-tracking branch 'upstream/master' into lperkins/link-checker

view details

Michael Crosby

commit sha 05f628d41ba48d002da9c24bbbae0f218744755d

Merge pull request #53 from lucperkins/lperkins/link-checker Add link checker

view details

Michael Crosby

commit sha f0343dd1be44fe196d740c030f31d153fef08aee

Merge pull request #54 from estesp/readme-link-fixes Remove invalid links when copying in markdown

view details

Phil Estes

commit sha d87be554b28bc4d9420427ce74e34b55d5c3a07b

Fixup whitespace error generated by sed replacement Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Mike Brown

commit sha 08763f4f3e87caf1fa2e17b5a530dc18926a0a57

Merge pull request #57 from estesp/fix-whitespace Fixup whitespace error generated by sed replacement

view details

Davanum Srinivas

commit sha 8ebf7f397cdbd40454c963ff10dbc97c93762fc6

Update latest release to 1.3.3 Signed-off-by: Davanum Srinivas <davanum@gmail.com>

view details

Michael Crosby

commit sha 855c0c21603617bd06dfc2b4283bf32724c81e4e

Merge pull request #59 from dims/update-latest-release-to-1.3.3 Update latest release to 1.3.3

view details

Phil Estes

commit sha 3302f619bc4d064f770aed1086a3d68b69aad203

Switch to GitHub actions for CI For this repository the only thing we had was a DCO check running in Travis. This moves this step to run as a GitHub Action. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Maksym Pavlenko

commit sha e5e8e4f2144dd42e36ddc79dea9aed8270369f01

Merge pull request #60 from estesp/githubactions Switch to GitHub actions for CI

view details

Phil Estes

commit sha 96872fcd49db397f3124082527685ebecc2bd3fb

Remove travis config Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Wei Fu

commit sha 1c1298a407930c2950fe5c0b9edf7021b453113e

Merge pull request #61 from estesp/remove-travis-config Remove travis config

view details

push time in 7 hours

delete branch thaJeztah/console

delete branch : remove_travis

delete time in 18 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentmoby/moby

Propagate contexts down into containerd

whoop!! green now

@tonistiigi @akihirosuda PTAL

cpuguy83

comment created time in 20 hours

pull request commentcontainerd/console

Remove travis configuration file

can we tag a release after this is merged?

thaJeztah

comment created time in 20 hours

pull request commentcontainerd/console

Remove travis configuration file

@estesp @cpuguy83 ptal

thaJeztah

comment created time in 20 hours

PR opened containerd/console

Remove travis configuration file

Now that we have GitHub actions running, the travis configuration file should no longer be needed.

follow-up to https://github.com/containerd/console/pull/36 and https://github.com/containerd/console/pull/41

+0 -27

0 comment

1 changed file

pr created time in 20 hours

create barnchthaJeztah/console

branch : remove_travis

created branch time in 20 hours

pull request commentmoby/moby

Propagate contexts down into containerd

Kicked CI again, but it continues failing 😞. Wondering if it's a specific machine that's having issues.

cpuguy83

comment created time in 21 hours

PullRequestReviewEvent

pull request commentmoby/moby

Add PIDFile to docker.service unit file to make systemd clean up pid file more reliably

Currently has to be done through Jenkins itself. I'll give it another kick, but I we could ignore the failure on s390x if it continues failing.

qiutongs

comment created time in a day

Pull request review commentmoby/sys

Some refactor and improved GoDoc about Windows support

  package mount -import (-	"fmt"-	"sort"--	"github.com/moby/sys/mountinfo"-)- // Mount will mount filesystem according to the specified configuration. // Options must be specified like the mount or fstab unix commands: // "opt1=val1,opt2=val2". See flags.go for supported option flags.+//+// Mount is not implemented on Windows. func Mount(device, target, mType, options string) error { 	flag, data := parseOptions(options) 	return mount(device, target, mType, uintptr(flag), data) }  // Unmount lazily unmounts a filesystem on supported platforms, otherwise does-// a normal unmount.  If target is not a mount point, no error is returned.+// a normal unmount. If target is not a mount point, no error is returned.+//+// Unmount is not implemented on Windows. func Unmount(target string) error { 	return unmount(target, mntDetach) }  // RecursiveUnmount unmounts the target and all mounts underneath, starting // with the deepest mount first. The argument does not have to be a mount // point itself.+//+// RecursiveUnmount is not implemented on Windows. func RecursiveUnmount(target string) error {

So, alternatively, I guess we could not implement at all on Windows (move this to a _linux.go or _unix.go wdyt?

thaJeztah

comment created time in a day

PullRequestReviewEvent

push eventthaJeztah/sys

Sebastiaan van Stijn

commit sha b4a0e04de382c68b1cd4d978a237e9c2d6c746e5

Some refactor and improved GoDoc about Windows support Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in a day

pull request commentmoby/moby

vendor: bump moby/sys/mountinfo/v0.2.0, moby/sys/mount/v0.1.1

Rebased; pls check if the remaining "stubs" for Windows look ok, or if we should refactor more to not have those in the windows codepath

thaJeztah

comment created time in a day

PullRequestReviewEvent

push eventthaJeztah/docker

Olli Janatuinen

commit sha 66a37b460c839ee7a9aca118840b441764292c97

Windows: Enable more integration tests Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

Olli Janatuinen

commit sha 88126e84a5e356fa9dcda4c71f8eb919e59adfc0

Force Download-File function to use TLS 1.2 Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

Sebastiaan van Stijn

commit sha 4ce3d71c1a08dc21a92864ea7300275ee3677624

Merge pull request #38469 from olljanat/win-more-integration-tests Windows CI: Enable more integration tests

view details

Kir Kolyshkin

commit sha 2502db66d0ddf789aa1d09f739db5f2add80916b

pkg/system: make EnsureRemoveAll unix-specific The tricks performed by EnsureRemoveAll only make sense for Linux and other Unices, so separate it out, and make EnsureRemoveAll for Windows just an alias of os.RemoveAll. This makes sure RecursiveUnmount is not called on Windows. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Sebastiaan van Stijn

commit sha 8c8dad0549a5a33220290a3571d1f46030a2088f

Merge pull request #41477 from olljanat/fix-rs1-ci Windows CI: Force Download-File function to use TLS 1.2 (fix to RS1 CI)

view details

Brian Goff

commit sha a24a71c50f34d53710cccaa4d5e5f62169c5e1dc

Merge pull request #41478 from kolyshkin/ensure-rm-all-win pkg/system: make EnsureRemoveAll unix-specific

view details

Sebastiaan van Stijn

commit sha 65959345a99f1feb35a2c8165bad2b8a2a1956d4

Don't call mount.Unmount(), mount.RecursiveUnmount() on Windows Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 88f2df2d07a5512724f34aef75fe4b834588ab88

vendor: golang.org/x/sys eff7692f900947b7d782d16af70ca32cc40774f0 full diff: https://github.com/golang/sys/compare/196b9ba8737a10c9253b04174f25881e562da5b8...eff7692f900947b7d782d16af70ca32cc40774f0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha f5d72b2768f9b234fe46b234c8253ea909a4407c

vendor: bump moby/sys/mountinfo/v0.2.0, moby/sys/mount/v0.1.1 full diff: https://github.com/moby/sys/compare/mountinfo/v0.1.3...mountinfo/v0.2.0 > Note that this dependency uses submodules, providing "github.com/moby/sys/mount" > and "github.com/moby/sys/mountinfo". Our vendoring tool (vndr) currently doesn't > support submodules, so we vendor the top-level moby/sys repository (which contains > both) and pick the most recent tag, which could be either `mountinfo/vXXX` or > `mount/vXXX`. github.com/moby/sys/mountinfo v0.2.0 -------------------------------------------------------------------------------- Bug fixes: - Fix path unescaping for paths with double quotes Improvements: - Mounted: speed up by adding fast paths using openat2 (Linux-only) and stat - Mounted: relax path requirements (allow relative, non-cleaned paths, symlinks) - Unescape fstype and source fields - Documentation improvements Testing/CI: - Unit tests: exclude darwin - CI: run tests under Fedora 32 to test openat2 - TestGetMounts: fix for Ubuntu build system - Makefile: fix ignoring test failures - CI: add cross build github.com/moby/sys/mount v0.1.1 -------------------------------------------------------------------------------- https://github.com/moby/sys/releases/tag/mount%2Fv0.1.1 Improvements: - RecursiveUnmount: add a fast path (#26) - Unmount: improve doc - fix CI linter warning on Windows Testing/CI: - Unit tests: exclude darwin - Makefile: fix ignoring test failures - CI: add cross build Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in a day

push eventthaJeztah/docker

Olli Janatuinen

commit sha 88126e84a5e356fa9dcda4c71f8eb919e59adfc0

Force Download-File function to use TLS 1.2 Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

Kir Kolyshkin

commit sha 2502db66d0ddf789aa1d09f739db5f2add80916b

pkg/system: make EnsureRemoveAll unix-specific The tricks performed by EnsureRemoveAll only make sense for Linux and other Unices, so separate it out, and make EnsureRemoveAll for Windows just an alias of os.RemoveAll. This makes sure RecursiveUnmount is not called on Windows. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Sebastiaan van Stijn

commit sha 8c8dad0549a5a33220290a3571d1f46030a2088f

Merge pull request #41477 from olljanat/fix-rs1-ci Windows CI: Force Download-File function to use TLS 1.2 (fix to RS1 CI)

view details

Brian Goff

commit sha a24a71c50f34d53710cccaa4d5e5f62169c5e1dc

Merge pull request #41478 from kolyshkin/ensure-rm-all-win pkg/system: make EnsureRemoveAll unix-specific

view details

push time in a day

pull request commentdocker/cli

Add .IPAddresses as formatting option on docker ps

Had this branch on my computer; not sure if we should merge (see discussion on https://github.com/moby/moby/issues/8786), but thought to at least push it to github 😂

thaJeztah

comment created time in a day

PR opened docker/cli

Add .IPAddresses as formatting option on docker ps

fixes https://github.com/moby/moby/issues/8786

This allows showing the IP address for each network that the container is attached to, for example:

docker network create foo
docker run -d --name foo nginx:alpine
docker network connect foo foo

container container ls --format 'table {{.ID}}\\t{{join .IPAddresses ", "}}'
CONTAINER ID   IP ADDRESSES
17e7d1910fc0   bridge:172.17.0.2, foo:172.19.0.2

container container ls --format='{{json .IPAddresses}}' | jq .
[
  "bridge:172.17.0.2",
  "foo:172.19.0.2"
]

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

+88 -23

0 comment

3 changed files

pr created time in a day

create barnchthaJeztah/cli

branch : ps_ip_address_details

created branch time in a day

pull request commentopencontainers/runc

Makefile: fix vendor and verify-dependencies

Yeah, current versions of go should be able to detect the vendor directory when using go build or go test. Can't do a go get and use the vendored dependencies (that still requires a manual git clone). Anyway, that all is a separate discussion.

kolyshkin

comment created time in a day

delete branch thaJeztah/cli

delete branch : use_official_shellsheck_image

delete time in a day

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 00b72960d78a14723f5c2a25e52a168cfecde7af

vendor: docker/docker 7f7e4abb331a2973cfb3223710cc35a3e476b1b3 full diff: https://github.com/docker/docker/compare/f50a40e889fdaeebf14fce1d494f95e60092d21d...7f7e4abb331a2973cfb3223710cc35a3e476b1b3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 33ecbbddaaca6cc1cfc03d4be7dd04516e0fd290

vendor: github.com/containerd/containerd v1.4.1 full diff: https://github.com/containerd/containerd/compare/v1.4.0...v1.4.1 Welcome to the v1.4.1 release of containerd! The first patch release for `containerd` 1.4 includes a fix for v1 shims hanging on exit and exec when the log pipe fills up along with other minor changes. Notable Updates: * Always consume shim logs to prevent logs in the shim from blocking * Fix error deleting v2 bundle directory when removing rootfs returns `ErrNotExist` * Fix metrics monitoring of v2 runtime tasks * Fix incorrect stat for Windows containers * Fix devmapper device deletion on rollback * Update seccomp default profile Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 8822cabc6aa872cf97c5e7c8345d6f779a990bda

Merge pull request #2729 from thaJeztah/bump_engine Updater docker/docker to latest master, containerd v1.4.1

view details

push time in a day

issue commentmoby/moby

docker run: support specifying rootfs directory directly

I'm a bit on the fence if this is more of a debug feature than something to actually expose to mainstream users; it feels like including quite low stuff in the UX. Could something like https://github.com/giuseppe/crfs-plugin be implemented as a graph driver plugin?

/cc @cpuguy83 @tonistiigi

AkihiroSuda

comment created time in a day

pull request commentmoby/moby

Jenkinsfile: add stage for Windows 2004 (SAC)

Rebased, and included the changes from https://github.com/moby/moby/pull/40599 in the new stage in the Jenkinsfile

thaJeztah

comment created time in a day

push eventthaJeztah/docker

Leonardo Taccari

commit sha 3d9120f7449ea00d56729773a9d23d3d7acce65b

Unify same fromStatT() implementation for FreeBSD and NetBSD Suggested by Sebastiaan van Stijn, thanks! Signed-off-by: Leonardo Taccari <leot@NetBSD.org>

view details

limeidan

commit sha 2344b3a9e10aab2f63d792f9b72282129399f98d

fix integration test case TestExternalGraphDriver failed in mips arch Signed-off-by: limeidan <limeidan@loongson.cn>

view details

Sebastiaan van Stijn

commit sha 4ab96db4ab93d23a66f0ae8e63c05e3adff9d94a

vendor: github.com/moby/term 7f0af18e79f2784809e9cef63d0df5aa2c79d76e full diff: https://github.com/moby/term/compare/73f35e472e8f0a3f91347164138ce6bd73b756a9...7f0af18e79f2784809e9cef63d0df5aa2c79d76e - update gotest.tools to v3 - Use unix.Ioctl{Get,Set}Termios on all unix platforms - Make Termios type alias, remove casts vendor: golang.org/x/sys 196b9ba8737a10c9253b04174f25881e562da5b8 full diff: https://github.com/golang/sys/compare/ed371f2e16b4b305ee99df548828de367527b76b...196b9ba8737a10c9253b04174f25881e562da5b8 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Brian Goff

commit sha a07c50dee885e8fb5a836f65ee9880bab51fbcf4

Merge pull request #41445 from meidli/master fix integration test case TestExternalGraphDriver failed in mips arch

view details

Brian Goff

commit sha 72fce23fc4b66e21cc74cb3528899d3d235454b5

Merge pull request #41453 from thaJeztah/bump_moby_term vendor: github.com/moby/term 7f0af18e79f2784809e9cef63d0df5aa2c79d76e

view details

Brian Goff

commit sha f99814d749d722f9ddec30d4ee94651b9b4c7163

Merge pull request #41448 from iamleot/stat_bsd Unify same fromStatT() implementation for FreeBSD and NetBSD

view details

Sebastiaan van Stijn

commit sha 1371a629d53a7c3639f1b12522a3a4021f5644b8

update containerd binary to v1.4.1 full diff: https://github.com/containerd/containerd/compare/v1.4.0...v1.4.1 Welcome to the v1.4.1 release of containerd! The first patch release for `containerd` 1.4 includes a fix for v1 shims hanging on exit and exec when the log pipe fills up along with other minor changes. Notable Updates: * Always consume shim logs to prevent logs in the shim from blocking * Fix error deleting v2 bundle directory when removing rootfs returns `ErrNotExist` * Fix metrics monitoring of v2 runtime tasks * Fix incorrect stat for Windows containers * Fix devmapper device deletion on rollback * Update seccomp default profile Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha af3220884e9a4851435b8e8480dea5a5cb2a1db9

vendor: github.com/containerd/containerd v1.4.1 full diff: https://github.com/containerd/containerd/compare/v1.4.0...v1.4.1 Welcome to the v1.4.1 release of containerd! The first patch release for `containerd` 1.4 includes a fix for v1 shims hanging on exit and exec when the log pipe fills up along with other minor changes. Notable Updates: * Always consume shim logs to prevent logs in the shim from blocking * Fix error deleting v2 bundle directory when removing rootfs returns `ErrNotExist` * Fix metrics monitoring of v2 runtime tasks * Fix incorrect stat for Windows containers * Fix devmapper device deletion on rollback * Update seccomp default profile Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 1ed6589e391f4cea9d984b8cb8d7333d49866dae

vendor: github.com/syndtr/gocapability 42c35b4376354fd554efc7ad35e0b7f94e3a0ffb full diff: https://github.com/syndtr/gocapability/compare/d98352740cb2c55f81556b63d4a1ec64c5a319c2...42c35b4376354fd554efc7ad35e0b7f94e3a0ffb Update Capabilities - Add `CAP_PERFMON` - Add `CAP_BPF` - Add `CAP_CHECKPOINT_RESTORE` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Olli Janatuinen

commit sha 82b5ff8026506017a3b01f7b6e0ece5c226a56bb

Windows CI: Make sure that CI fails on any error - If unit tests fails - If intergration tests fails Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

Sebastiaan van Stijn

commit sha ef6416f3b95570567aa0ee554a496fd5203d5e84

Merge pull request #40599 from olljanat/win-integration-fail-on-error Windows CI: Make sure that CI fails on any error

view details

Brian Goff

commit sha 3956a86b6235038011bd8055b59cd24c182aa4ff

Merge pull request #41450 from thaJeztah/containerd_1.4.1 update containerd vendor and binary to v1.4.1

view details

Tibor Vass

commit sha 7f7e4abb331a2973cfb3223710cc35a3e476b1b3

Merge pull request #41460 from thaJeztah/bump_gocapabilities vendor: github.com/syndtr/gocapability 42c35b4376354fd554efc7ad35e0b7f94e3a0ffb

view details

Stefan Scherer

commit sha 89bec2e26753a6ab9248835b7d663d977a4e324b

Fix collecting the daemon under test logs Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>

view details

Sebastiaan van Stijn

commit sha 9fb324f00be66e27afd4172b509ec5525b588f81

vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b full diff: https://github.com/docker/libnetwork/compare/9e99af28df21367340c95a3863e31808d689c92a...d0951081b35fa4216fc4f0064bf065beeb55a74b - docker/libnetwork#2560 types: remove some dead code - docker/libnetwork#2562 client/mflag: remove use of docker/docker/pkg/homedir - docker/libnetwork#2576 Skip redundant kernel version checks - docker/libnetwork#2583 vendor: update docker to 7ca355652fe0e2f7401d424d65a81dc248360127 and reduce dependency graph Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 7cdced6f4b5a5c2b075c0d971920754664559ff1

vendor.conf: fix tar-split version comment We already updated to v0.11.1, but didn't update the comment itself Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 968133c86c0ae34f0904e83ebfa4472c623c74cc

vendor: opencontainers/go-digest v1.0.0 full diff: https://github.com/opencontainers/go-digest/compare/v1.0.0-rc1...v1.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 1dff568d45aae3a6682dbf7e3803feeddcfce8ea

Merge pull request #41466 from thaJeztah/bump_libnetwork vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b

view details

Tibor Vass

commit sha 2513da195eef09acb56da21d7191aaa3b4ed4b35

Merge pull request #41467 from thaJeztah/bump_go_digest vendor: opencontainers/go-digest v1.0.0

view details

Sebastiaan van Stijn

commit sha 0bad48279efe3e5f56df1c4c8c2e6bc90fbb36e9

Merge pull request #41463 from StefanScherer/win-investigate-cidut-out Windows CI: Fix collecting the logs of the daemon under test

view details

push time in a day

push eventmoby/moby

Olli Janatuinen

commit sha 88126e84a5e356fa9dcda4c71f8eb919e59adfc0

Force Download-File function to use TLS 1.2 Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

Sebastiaan van Stijn

commit sha 8c8dad0549a5a33220290a3571d1f46030a2088f

Merge pull request #41477 from olljanat/fix-rs1-ci Windows CI: Force Download-File function to use TLS 1.2 (fix to RS1 CI)

view details

push time in a day

PR merged moby/moby

Windows CI: Force Download-File function to use TLS 1.2 (fix to RS1 CI) area/testing platform/windows process/cherry-pick

- What I did I noticed that RS1 CI from master have been broken for a while that is because .NET version which RS1 uses does not have TLS 1.2 enabled by default and nuget.org does not have TLS 1.1 enabled anymore.

This PR will set both RS1 and RS5 to use TLS 1.2 only for downloads.

- How I did it Minor change to Download-File PowerShell function function.

- How to verify it Pass CI on RS5 will proof that this does not cause new issues.

- A picture of a cute animal (not mandatory but encouraged) 371695,xcitefun-cute-animals-pictures-41

+1 -0

1 comment

1 changed file

olljanat

pr closed time in a day

PullRequestReviewEvent

push eventthaJeztah/docker

Stefan Scherer

commit sha 89bec2e26753a6ab9248835b7d663d977a4e324b

Fix collecting the daemon under test logs Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>

view details

Sebastiaan van Stijn

commit sha 9fb324f00be66e27afd4172b509ec5525b588f81

vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b full diff: https://github.com/docker/libnetwork/compare/9e99af28df21367340c95a3863e31808d689c92a...d0951081b35fa4216fc4f0064bf065beeb55a74b - docker/libnetwork#2560 types: remove some dead code - docker/libnetwork#2562 client/mflag: remove use of docker/docker/pkg/homedir - docker/libnetwork#2576 Skip redundant kernel version checks - docker/libnetwork#2583 vendor: update docker to 7ca355652fe0e2f7401d424d65a81dc248360127 and reduce dependency graph Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 7cdced6f4b5a5c2b075c0d971920754664559ff1

vendor.conf: fix tar-split version comment We already updated to v0.11.1, but didn't update the comment itself Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 968133c86c0ae34f0904e83ebfa4472c623c74cc

vendor: opencontainers/go-digest v1.0.0 full diff: https://github.com/opencontainers/go-digest/compare/v1.0.0-rc1...v1.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 1dff568d45aae3a6682dbf7e3803feeddcfce8ea

Merge pull request #41466 from thaJeztah/bump_libnetwork vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b

view details

Tibor Vass

commit sha 2513da195eef09acb56da21d7191aaa3b4ed4b35

Merge pull request #41467 from thaJeztah/bump_go_digest vendor: opencontainers/go-digest v1.0.0

view details

Sebastiaan van Stijn

commit sha 0bad48279efe3e5f56df1c4c8c2e6bc90fbb36e9

Merge pull request #41463 from StefanScherer/win-investigate-cidut-out Windows CI: Fix collecting the logs of the daemon under test

view details

Olli Janatuinen

commit sha 66a37b460c839ee7a9aca118840b441764292c97

Windows: Enable more integration tests Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

Sebastiaan van Stijn

commit sha 4ce3d71c1a08dc21a92864ea7300275ee3677624

Merge pull request #38469 from olljanat/win-more-integration-tests Windows CI: Enable more integration tests

view details

push time in a day

push eventmoby/moby

Olli Janatuinen

commit sha 66a37b460c839ee7a9aca118840b441764292c97

Windows: Enable more integration tests Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

Sebastiaan van Stijn

commit sha 4ce3d71c1a08dc21a92864ea7300275ee3677624

Merge pull request #38469 from olljanat/win-more-integration-tests Windows CI: Enable more integration tests

view details

push time in a day

PR merged moby/moby

Reviewers
Windows CI: Enable more integration tests area/testing platform/windows status/2-code-review

- What I did After seeing too many times that any Docker and Windows updates cannot be installed without testing all features which we need I decided fix the root cause, the fact that most of the integration tests are disabled on Windows CI.

So on this PR I enabled those tests what can be enabled with minimal changes to code.

- How I did it I started enabling those tests and figured out the fact that work was actually started already on #37715 but (source: https://github.com/moby/moby/pull/37715#issuecomment-425276677)

However, note that none of the integration tests are actually run with this PR, just the integration-cli tests.

so on #39240 added needed logic to Windows CI that those tests actually run.

Then year 2019 passed and on February I reopened this one and did find out that Windows CI was shown as passed even some tests actually failed so on #40599 I finally fixed that issue.

After getting Windows CI working correctly I noticed that there is acutally much less tests which can be enabled than I was originally thinking because many tests will need more modifications to working on Windows and because of the fact that there is open bugs on Windows #39191 #40998 #41354

- How to verify it Look the CI log:

[2020-09-19T08:22:36.684Z] --- PASS: TestBuildWithRemoveAndForceRemove (0.02s)
[2020-09-19T08:22:36.684Z]     --- PASS: TestBuildWithRemoveAndForceRemove/successful_build_with_no_removal (12.98s)
[2020-09-19T08:22:36.684Z]     --- PASS: TestBuildWithRemoveAndForceRemove/failed_build_with_remove_and_force_remove (13.00s)
[2020-09-19T08:22:36.684Z]     --- PASS: TestBuildWithRemoveAndForceRemove/failed_build_with_no_removal (13.07s)
[2020-09-19T08:22:36.684Z]     --- PASS: TestBuildWithRemoveAndForceRemove/successful_build_with_remove_and_force_remove (16.16s)
[2020-09-19T08:22:36.684Z]     --- PASS: TestBuildWithRemoveAndForceRemove/successful_build_with_remove (8.19s)
[2020-09-19T08:22:36.684Z]     --- PASS: TestBuildWithRemoveAndForceRemove/failed_build_with_remove (8.25s)

[2020-09-19T08:22:46.658Z] === RUN   TestBuildMultiStageParentConfig
[2020-09-19T08:22:48.835Z] --- PASS: TestBuildMultiStageParentConfig (1.83s)

[2020-09-19T08:22:49.801Z] === RUN   TestBuildMultiStageOnBuild
[2020-09-19T08:23:00.120Z] --- PASS: TestBuildMultiStageOnBuild (10.61s)

[2020-09-19T08:23:00.120Z] === RUN   TestBuildMultiStageLayerLeak
[2020-09-19T08:23:10.445Z] --- PASS: TestBuildMultiStageLayerLeak (9.24s)

[2020-09-19T08:23:15.527Z] === RUN   TestCopyFromContainerPathDoesNotExist
[2020-09-19T08:23:15.985Z] --- PASS: TestCopyFromContainerPathDoesNotExist (0.20s)

[2020-09-19T08:23:15.986Z] === RUN   TestCopyToContainerPathDoesNotExist
[2020-09-19T08:23:15.986Z] --- PASS: TestCopyToContainerPathDoesNotExist (0.22s)

[2020-09-19T08:23:18.628Z] === RUN   TestExec
[2020-09-19T08:23:20.166Z] --- PASS: TestExec (1.76s)

[2020-09-19T08:23:23.242Z] === RUN   TestKillContainer/killing_signal
[2020-09-19T08:23:25.522Z] --- PASS: TestKillContainer (3.37s)
[2020-09-19T08:23:25.522Z]     --- PASS: TestKillContainer/no_signal (1.43s)
[2020-09-19T08:23:25.522Z]     --- PASS: TestKillContainer/non_killing_signal (0.00s)
[2020-09-19T08:23:25.522Z]     --- PASS: TestKillContainer/killing_signal (1.90s)

[2020-09-19T08:23:27.059Z] === RUN   TestNetworkLocalhostTCPNat
[2020-09-19T08:23:28.595Z] --- PASS: TestNetworkLocalhostTCPNat (1.85s)

[2020-09-19T08:23:45.081Z] === RUN   TestResize
[2020-09-19T08:23:46.623Z] --- PASS: TestResize (1.51s)

[2020-09-19T08:24:18.770Z] === RUN   TestRemoveImageOrphaning
[2020-09-19T08:24:19.229Z] --- PASS: TestRemoveImageOrphaning (0.68s)

[2020-09-19T08:24:19.688Z] === RUN   TestTagOfficialNames
[2020-09-19T08:24:19.688Z] --- PASS: TestTagOfficialNames (0.08s)

[2020-09-19T08:24:53.629Z] === RUN   TestVolumesCreateAndList
[2020-09-19T08:24:53.629Z] --- PASS: TestVolumesCreateAndList (0.05s)

[2020-09-19T08:24:53.629Z] === RUN   TestVolumesRemove
[2020-09-19T08:24:53.629Z] --- PASS: TestVolumesRemove (0.06s)

- A picture of a cute animal (not mandatory but encouraged) image

+10 -17

5 comments

9 changed files

olljanat

pr closed time in a day

PullRequestReviewEvent

delete branch thaJeztah/criu

delete branch : python3

delete time in a day

pull request commentmoby/moby

Add PIDFile to docker.service unit file to make systemd clean up pid file more reliably

The TestInspect failure is a known flaky test. The s390x failures seem to be some hiccups in the s390 infra (saw then fail around the same time on some other PRs)

qiutongs

comment created time in a day

delete branch thaJeztah/cli

delete branch : bump_engine

delete time in 2 days

pull request commentdocker/cli

Updater docker/docker to latest master, containerd v1.4.1

@silvin-lubecki ptal

thaJeztah

comment created time in 2 days

push eventthaJeztah/docker

Sebastiaan van Stijn

commit sha 96bce41c4128c160b59c80dab9d77eee256ebd54

Don't call mount.Unmount(), mount.RecursiveUnmount() on Windows Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha ff59b1a7b9f4ecdd08eddf254bfdc3520ccf43a1

vendor: golang.org/x/sys eff7692f900947b7d782d16af70ca32cc40774f0 full diff: https://github.com/golang/sys/compare/196b9ba8737a10c9253b04174f25881e562da5b8...eff7692f900947b7d782d16af70ca32cc40774f0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 93950b9d80de671d4e2088937f4923ef1cf7fe7b

vendor: bump moby/sys/mountinfo/v0.2.0, moby/sys/mount/v0.1.1 full diff: https://github.com/moby/sys/compare/mountinfo/v0.1.3...mountinfo/v0.2.0 > Note that this dependency uses submodules, providing "github.com/moby/sys/mount" > and "github.com/moby/sys/mountinfo". Our vendoring tool (vndr) currently doesn't > support submodules, so we vendor the top-level moby/sys repository (which contains > both) and pick the most recent tag, which could be either `mountinfo/vXXX` or > `mount/vXXX`. github.com/moby/sys/mountinfo v0.2.0 -------------------------------------------------------------------------------- Bug fixes: - Fix path unescaping for paths with double quotes Improvements: - Mounted: speed up by adding fast paths using openat2 (Linux-only) and stat - Mounted: relax path requirements (allow relative, non-cleaned paths, symlinks) - Unescape fstype and source fields - Documentation improvements Testing/CI: - Unit tests: exclude darwin - CI: run tests under Fedora 32 to test openat2 - TestGetMounts: fix for Ubuntu build system - Makefile: fix ignoring test failures - CI: add cross build github.com/moby/sys/mount v0.1.1 -------------------------------------------------------------------------------- https://github.com/moby/sys/releases/tag/mount%2Fv0.1.1 Improvements: - RecursiveUnmount: add a fast path (#26) - Unmount: improve doc - fix CI linter warning on Windows Testing/CI: - Unit tests: exclude darwin - Makefile: fix ignoring test failures - CI: add cross build Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 days

push eventthaJeztah/docker

Sebastiaan van Stijn

commit sha 0526148a0adca699ff941d45214387948e33d3a0

Don't call mount.Unmount() on Windows Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 672ca1fb45d6cff0c821c1602553930648c52baf

vendor: golang.org/x/sys eff7692f900947b7d782d16af70ca32cc40774f0 full diff: https://github.com/golang/sys/compare/196b9ba8737a10c9253b04174f25881e562da5b8...eff7692f900947b7d782d16af70ca32cc40774f0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 9240e6785093a411965122cb9aeacbc57b184829

vendor: bump moby/sys/mountinfo/v0.2.0, moby/sys/mount/v0.1.1 full diff: https://github.com/moby/sys/compare/mountinfo/v0.1.3...mountinfo/v0.2.0 > Note that this dependency uses submodules, providing "github.com/moby/sys/mount" > and "github.com/moby/sys/mountinfo". Our vendoring tool (vndr) currently doesn't > support submodules, so we vendor the top-level moby/sys repository (which contains > both) and pick the most recent tag, which could be either `mountinfo/vXXX` or > `mount/vXXX`. github.com/moby/sys/mountinfo v0.2.0 -------------------------------------------------------------------------------- Bug fixes: - Fix path unescaping for paths with double quotes Improvements: - Mounted: speed up by adding fast paths using openat2 (Linux-only) and stat - Mounted: relax path requirements (allow relative, non-cleaned paths, symlinks) - Unescape fstype and source fields - Documentation improvements Testing/CI: - Unit tests: exclude darwin - CI: run tests under Fedora 32 to test openat2 - TestGetMounts: fix for Ubuntu build system - Makefile: fix ignoring test failures - CI: add cross build github.com/moby/sys/mount v0.1.1 -------------------------------------------------------------------------------- https://github.com/moby/sys/releases/tag/mount%2Fv0.1.1 Improvements: - RecursiveUnmount: add a fast path (#26) - Unmount: improve doc - fix CI linter warning on Windows Testing/CI: - Unit tests: exclude darwin - Makefile: fix ignoring test failures - CI: add cross build Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 days

push eventthaJeztah/docker

Stefan Scherer

commit sha 89bec2e26753a6ab9248835b7d663d977a4e324b

Fix collecting the daemon under test logs Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>

view details

Sebastiaan van Stijn

commit sha 9fb324f00be66e27afd4172b509ec5525b588f81

vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b full diff: https://github.com/docker/libnetwork/compare/9e99af28df21367340c95a3863e31808d689c92a...d0951081b35fa4216fc4f0064bf065beeb55a74b - docker/libnetwork#2560 types: remove some dead code - docker/libnetwork#2562 client/mflag: remove use of docker/docker/pkg/homedir - docker/libnetwork#2576 Skip redundant kernel version checks - docker/libnetwork#2583 vendor: update docker to 7ca355652fe0e2f7401d424d65a81dc248360127 and reduce dependency graph Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 7cdced6f4b5a5c2b075c0d971920754664559ff1

vendor.conf: fix tar-split version comment We already updated to v0.11.1, but didn't update the comment itself Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 968133c86c0ae34f0904e83ebfa4472c623c74cc

vendor: opencontainers/go-digest v1.0.0 full diff: https://github.com/opencontainers/go-digest/compare/v1.0.0-rc1...v1.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 1dff568d45aae3a6682dbf7e3803feeddcfce8ea

Merge pull request #41466 from thaJeztah/bump_libnetwork vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b

view details

Tibor Vass

commit sha 2513da195eef09acb56da21d7191aaa3b4ed4b35

Merge pull request #41467 from thaJeztah/bump_go_digest vendor: opencontainers/go-digest v1.0.0

view details

Sebastiaan van Stijn

commit sha 0bad48279efe3e5f56df1c4c8c2e6bc90fbb36e9

Merge pull request #41463 from StefanScherer/win-investigate-cidut-out Windows CI: Fix collecting the logs of the daemon under test

view details

Sebastiaan van Stijn

commit sha 2a77a43d2f8e1b5437402d3c012bcfe2df8e84f3

vendor: golang.org/x/sys eff7692f900947b7d782d16af70ca32cc40774f0 full diff: https://github.com/golang/sys/compare/196b9ba8737a10c9253b04174f25881e562da5b8...eff7692f900947b7d782d16af70ca32cc40774f0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 1fbffd10ed6261a38b372eb606ed5974cfce1ef5

vendor: bump moby/sys/mountinfo/v0.2.0, moby/sys/mount/v0.1.1 full diff: https://github.com/moby/sys/compare/mountinfo/v0.1.3...mountinfo/v0.2.0 > Note that this dependency uses submodules, providing "github.com/moby/sys/mount" > and "github.com/moby/sys/mountinfo". Our vendoring tool (vndr) currently doesn't > support submodules, so we vendor the top-level moby/sys repository (which contains > both) and pick the most recent tag, which could be either `mountinfo/vXXX` or > `mount/vXXX`. github.com/moby/sys/mountinfo v0.2.0 -------------------------------------------------------------------------------- Bug fixes: - Fix path unescaping for paths with double quotes Improvements: - Mounted: speed up by adding fast paths using openat2 (Linux-only) and stat - Mounted: relax path requirements (allow relative, non-cleaned paths, symlinks) - Unescape fstype and source fields - Documentation improvements Testing/CI: - Unit tests: exclude darwin - CI: run tests under Fedora 32 to test openat2 - TestGetMounts: fix for Ubuntu build system - Makefile: fix ignoring test failures - CI: add cross build github.com/moby/sys/mount v0.1.1 -------------------------------------------------------------------------------- https://github.com/moby/sys/releases/tag/mount%2Fv0.1.1 Improvements: - RecursiveUnmount: add a fast path (#26) - Unmount: improve doc - fix CI linter warning on Windows Testing/CI: - Unit tests: exclude darwin - Makefile: fix ignoring test failures - CI: add cross build Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c71a86a220e2ca138680fb459c3ccfd46e4256d2

Don't call mount.Unmount() on Windows Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 days

pull request commentmoby/moby

oci/caps: refactor, remove unused code, and improved error messages

@kolyskin @akihirosuda ptal

thaJeztah

comment created time in 3 days

push eventthaJeztah/docker

Sebastiaan van Stijn

commit sha c349a56997ca800862953f6e01f1440babbc39d3

oci/caps: remove hack for RHEL6 kernels We no longer support these kernels, so we can remove the workaround Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 days

push eventmoby/moby

Stefan Scherer

commit sha 89bec2e26753a6ab9248835b7d663d977a4e324b

Fix collecting the daemon under test logs Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>

view details

Sebastiaan van Stijn

commit sha 0bad48279efe3e5f56df1c4c8c2e6bc90fbb36e9

Merge pull request #41463 from StefanScherer/win-investigate-cidut-out Windows CI: Fix collecting the logs of the daemon under test

view details

push time in 3 days

PR merged moby/moby

Reviewers
Windows CI: Fix collecting the logs of the daemon under test area/testing platform/windows status/2-code-review

- What I did

This PR fixes an issue we discussed in https://github.com/moby/moby/pull/40599. Sometimes the logs of the daemon under test couldn't be found.

- How I did it

I first ran a test to show me the current dir in the script, and indeed in some cases the script was a sub folder, and the Copy-Item silently continues if the target folder doesn't exist.

cidut

- How to verify it

The Windows builds should now always have artifacts with the CIDUT.out / CIDUT.err files in it.

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

cidut 2 tahun

+1 -0

1 comment

1 changed file

StefanScherer

pr closed time in 3 days

PullRequestReviewEvent

push eventthaJeztah/docker

Sebastiaan van Stijn

commit sha 5ec5797e203da936a459758a0564d61bfecabb34

oci/caps: generate list of all capabilities on "init" Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 9d93b60c3cae13cd8b8de65d5c4f7bad0c192371

oci/caps: use map for capabilities to simplify lookup Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha f72ecc5b83b2b29ba0f242f5cd450f8639581507

oci/caps: improve error message for unsupported capabilities A capability can either be invalid, or not supported by the kernel on which we're running. This patch changes the error message produced to reflect if the capability is invalid/unknown, or a known capability, but not supported by the kernel version. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 7ad8c920d30a6e5fd8433b61fedc4d83926693d4

oci/caps: remove unused GetCapability() and ValidateCapabilities() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha d099749d72f587f6337889db5472a6ce9f9b5407

oci/caps: simplify, and remove types that were not needed The `CapabilityMapping` and `Capabilities` types appeared to be only used locally, and added unneeded complexity. This patch removes those types, and simplifies the logic to use a map that maps names to `capability.Cap`s Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 days

pull request commentmoby/sys

Make RecursiveUnmount() a no-op on Windows

@kolyshkin updated, but I noticed that before https://github.com/moby/sys/commit/0c569e07f522050ad1f74457f9bccd5fcd5e1ddb, Unmount() already produced a panic on Windows, so I'm a bit on the fence on updating.

Actually thinking now if we should accept the breaking change and update downstream code or not 🤔 (the package is still pre v1.0, so from that perspective, it should be ok)

thaJeztah

comment created time in 3 days

push eventthaJeztah/sys

Sebastiaan van Stijn

commit sha 8b5e03d76847c10fd653786cab7b0fed05ded227

Make Unmount() and RecursiveUnmount() a no-op on Windows Commit 86f20afa745b2b7fcbf46e65795072e0bc12af79 added a fast-path for Linux, but inadvertendly changed the behavior on Windows, which previously handled RecursiveUnmount() as a no-op, and now panicked. This patch makes RecursiveUnmount() and Unmount() a no-op again on Windows. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 3 days

Pull request review commentmoby/moby

Sterner warnings and deprecation notice for unauthenticated tcp access

 const ( 	DefaultCertFile = "cert.pem" 	// FlagTLSVerify is the flag name for the TLS verification option 	FlagTLSVerify = "tlsverify"+	// FlagTLS is the flag name for the TLS option+	FlagTLS = "tls"+	// The default value used for setting the tls option for tcp connections+	DefaultTLSValue = false

Looks to be only used in this package currently, so we can un-export for now?

cpuguy83

comment created time in 3 days

Pull request review commentmoby/moby

Sterner warnings and deprecation notice for unauthenticated tcp access

 func loadDaemonCliConfig(opts *daemonOptions) (*config.Config, error) { 	// Regardless of whether the user sets it to true or false, if they 	// specify TLSVerify at all then we need to turn on TLS 	if conf.IsValueSet(FlagTLSVerify) {-		conf.TLS = true+		v := true+		conf.TLS = &v+	}++	if conf.TLSVerify == nil && conf.TLS != nil {+		conf.TLSVerify = conf.TLS

This is a change in behavior, correct? (automatically enable verify)

If so, I'm ok with that change, but we'll probably need to mention that explicitly in changelogs

cpuguy83

comment created time in 3 days

Pull request review commentmoby/moby

Sterner warnings and deprecation notice for unauthenticated tcp access

 func newAPIServerConfig(cli *DaemonCli) (*apiserver.Config, error) { 	return serverConfig, nil } +// checkTLSAuthOK checks basically for an explicitly disabled TLS/TLSVerify+// Going forward we do not want to support a scenario where dockerd listens+//   on TCP without either TLS client auth (or an explicit opt-in to disable it)+func checkTLSAuthOK(c *config.Config) bool {+	if c.TLS == nil {+		// Either TLS is enabled by default, in which case TLS verification should be enabled by default, or explicitly disabled+		// Or TLS is disabled by default... in any of these cases, we can just take the default value as to how to proceed+		return DefaultTLSValue

is this shortcut correct? it currently is, but if it changes to true, we won't check tlsverify below 🤔

Should probably be slightly safer to check value of defaulttlsvalue here?

cpuguy83

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentmoby/moby

Windows CI: Enable more integration tests

@akihirosuda @cpuguy83 ptal

olljanat

comment created time in 3 days

Pull request review commentmoby/moby

Windows CI: Enable more integration tests

 func TestKillContainerInvalidSignal(t *testing.T) { }  func TestKillContainer(t *testing.T) {-	skip.If(t, testEnv.OSType == "windows", "TODO Windows: FIXME. No SIGWINCH") 	defer setupTest(t)() 	client := testEnv.APIClient()  	testCases := []struct { 		doc    string 		signal string 		status string+		skipOs string 	}{ 		{ 			doc:    "no signal", 			signal: "", 			status: "exited",+			skipOs: "", 		}, 		{ 			doc:    "non killing signal", 			signal: "SIGWINCH", 			status: "running",+			skipOs: "windows", // Windows does not support SIGWINCH 		}, 		{ 			doc:    "killing signal", 			signal: "SIGTERM", 			status: "exited",+			skipOs: "", 		}, 	}  	for _, tc := range testCases { 		tc := tc 		t.Run(tc.doc, func(t *testing.T) {+			if testEnv.OSType == tc.skipOs {+				return

guess this could even use t.Skip() because it's running as a subtest.

no need to change, unless there's other changes to make

olljanat

comment created time in 3 days

PullRequestReviewEvent
more