profile
viewpoint
Sebastiaan van Stijn thaJeztah thaJeztah Netherlands @docker and @moby maintainer, member of the Moby TSC. Open Source contributions manager @ Docker, Inc. Feeds @GordonTheTurtle with issues and PR's

sirupsen/logrus 14478

Structured, pluggable logging for Go.

docker/classicswarm 5840

Swarm Classic: a container clustering system

moby/buildkit 2418

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit

docker/for-mac 1316

Bug reports for Docker Desktop for Mac

docker/for-win 997

Bug reports for Docker Desktop for Windows

docker/go-plugins-helpers 254

Go helper packages to extend the Docker Engine

docker/hub-feedback 176

Feedback and bug reports for the Docker Hub

swarmzilla/swarm2k 81

The Docker Swarm 2000 Collaborative Project

docker/gordon-bot 31

Gordon the turtle IRC bot to rebuild Jenkins builds.

issue commentmoby/moby

Error: The virtual machine could not be started because a required feature is not installed

Are you seeing the same problem with every Windows image?

I see the example app may need an update as it's still using the old image names (images have been migrated to Microsoft's registry; see https://hub.docker.com/_/microsoft-dotnet-framework-aspnet

aschip

comment created time in 7 hours

issue closedmoby/moby

nfo

<!-- If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.

If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.

For more information about reporting issues, see https://github.com/moby/moby/blob/master/CONTRIBUTING.md#reporting-other-issues


GENERAL SUPPORT INFORMATION

The GitHub issue tracker is for bug reports and feature requests. General support for docker can be found at the following locations:

  • Docker Support Forums - https://forums.docker.com
  • Slack - community.docker.com #general channel
  • Post a question on StackOverflow, using the Docker tag

General support for moby can be found at the following locations:

  • Moby Project Forums - https://forums.mobyproject.org
  • Slack - community.docker.com #moby-project channel
  • Post a question on StackOverflow, using the Moby tag

BUG REPORT INFORMATION

Use the commands below to provide key information from your environment: You do NOT have to include this information if this is a FEATURE REQUEST -->

Description

<!-- Briefly describe the problem you are having in a few paragraphs. -->

Steps to reproduce the issue: 1. 2. 3.

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

Output of docker version:

(paste your output here)

Output of docker info:

(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):

closed time in 7 hours

jmspritze

delete branch thaJeztah/docker

delete branch : revert_bump_bbolt

delete time in 7 hours

PR opened containerd/containerd

CI: Some Go 1.13.10 updates that were missed

This file was still on Go 1.13.8, which caused it to be missed when updating Go 1.13.9 to 1.13.10

+2 -2

0 comment

1 changed file

pr created time in 8 hours

create barnchthaJeztah/containerd

branch : more_go_bumps

created branch time in 8 hours

pull request commentcontainerd/containerd

[release/1.2 backport] sys/mount_linux: use pipe for communicating mount result

opening for consideration, but I'm not sure if there's plans for 1.2.x releases; the original issue was reported on containerd 1.2, so thought it made sense from that perspective

thaJeztah

comment created time in 8 hours

PR opened containerd/containerd

[release/1.2 backport] sys/mount_linux: use pipe for communicating mount result

backport of https://github.com/containerd/containerd/pull/4160

forkAndMountat forks a process to chdir then mount layers. Signals are blocked (using runtime_beforeFork) during fork.

There is a race condition that the child process finishes before the parent process is scheduled and can unblock signal handling. The SIGCHLD signal sent from the finished process may have been delivered to the shim process's reaper thread and caused the parent process fail with ECHLD error.

This patch sets up a pipe for communication between child and parent instead of waiting for child exit status.

Fixes #4009.

+39 -13

0 comment

1 changed file

pr created time in 8 hours

PR opened containerd/containerd

[release/1.2 backport] Bump Golang 1.13.10

backport of https://github.com/containerd/containerd/pull/4145 and https://github.com/containerd/containerd/pull/4169

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

+3 -3

0 comment

3 changed files

pr created time in 8 hours

create barnchthaJeztah/containerd

branch : 1.2_backport_bump_golang_1.13

created branch time in 8 hours

delete branch thaJeztah/containerd

delete branch : 1.3_backport_bump_golang_1.13

delete time in 8 hours

push eventthaJeztah/containerd

Sebastiaan van Stijn

commit sha 7da1e13b5d7c9561f95ba64af1e9baee25dc2a08

Bump Golang 1.13.10 go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Phil Estes

commit sha a31f5e46e09608135d2f51394e6a5349892f6f62

Merge pull request #4169 from thaJeztah/bump_golang_1.13.10 Bump Golang 1.13.10

view details

push time in 8 hours

pull request commentcontainerd/containerd

[release/1.3 backport] vendor: update go-events to fix alignment for 32bit systems

Ah, dang, my mistake; made a whoopsie in vendor.conf; should be fixed now

thaJeztah

comment created time in 8 hours

push eventthaJeztah/containerd

Sebastiaan van Stijn

commit sha 7d413448043b62bf274067a21676f6100c5e3f49

vendor: update go-events to fix alignment for 32bit systems - relates to moby/buildkit 1111 - relates to moby/buildkit 1079 - relates to docker/buildx 129 full diff: https://github.com/docker/go-events/compare/9461782956ad83b30282bf90e31fa6a70c255ba9...e31b211e4f1cd09aa76fe4ac244571fab96ae47f Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 056d60224046ef4ede772633ebdba6c61784be3b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 8 hours

delete branch thaJeztah/containerd

delete branch : bump_golang_1.13.10

delete time in 8 hours

pull request commentdmcgowan/quicktls

Add --with-san flag to allow generating cert with SAN

Thanks!

thaJeztah

comment created time in 9 hours

delete branch thaJeztah/quicktls

delete branch : support_san

delete time in 9 hours

pull request commentdocker/cli

Bump Golang 1.13.10

depends on https://github.com/docker/golang-cross/pull/56

ping @silvin-lubecki ptal

thaJeztah

comment created time in 9 hours

PR opened docker/cli

[19.03 backport] Bump Golang 1.13.10

backport of https://github.com/docker/cli/pull/2430

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

Signed-off-by: Sebastiaan van Stijn github@gone.nl (cherry picked from commit 687539013136fc464c3c9bee6db7cec851773ff4) Signed-off-by: Sebastiaan van Stijn github@gone.nl

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+6 -6

0 comment

6 changed files

pr created time in 9 hours

create barnchthaJeztah/cli

branch : 19.03_backport_bump_golang_1.13.10

created branch time in 9 hours

PR opened docker/cli

Bump Golang 1.13.10 process/cherry-pick status/2-code-review

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

+6 -6

0 comment

6 changed files

pr created time in 9 hours

create barnchthaJeztah/cli

branch : bump_golang_1.13.10

created branch time in 9 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 650c7175802662747f7e34653fb380ca37b11665

TestHistoryContext_CreatedSince: skip on non-UTC environments Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 19bcebd1228bc172522927c5cdfcc76d33e9c07f

test: make sure environment vars are reset after tests The trust tests were not resetting the environment after they ran, which could result in tests following those tests to fail. While at it, I also updated some other tests to use gotest.tools Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6bd09229a5cbe0941d9452a98ee7935c7a193b5f

CI: update notary test certificates Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha ab7a18147fc97eec7c16a34ce59916818b37544b

Merge pull request #2428 from thaJeztah/fix_da_fixtures CI: update notary test certificates

view details

Silvin Lubecki

commit sha 5d6281b876a50818bb707095946d5e6de99f1003

Merge pull request #2427 from thaJeztah/skip_TestHistoryContext_CreatedSince TestHistoryContext_CreatedSince: skip on non-UTC environments

view details

Silvin Lubecki

commit sha ad256ba023442bcf8ed249a1b5df708d0d779de0

Merge pull request #2426 from thaJeztah/fix_test_env test: make sure environment vars are reset after tests

view details

push time in 9 hours

pull request commentcontainerd/containerd

Prepare release 1.3.4

do we want to include https://github.com/containerd/containerd/pull/4170 and https://github.com/containerd/containerd/pull/4171?

mxpv

comment created time in 9 hours

PR opened containerd/containerd

[release/1.3 backport] vendor: update go-events to fix alignment for 32bit systems

backport of https://github.com/containerd/containerd/pull/4153

  • relates to moby/buildkit 1111
  • relates to moby/buildkit 1079
  • relates to docker/buildx 129

full diff: https://github.com/docker/go-events/compare/9461782956ad83b30282bf90e31fa6a70c255ba9...e31b211e4f1cd09aa76fe4ac244571fab96ae47f

Signed-off-by: Sebastiaan van Stijn github@gone.nl (cherry picked from commit 056d60224046ef4ede772633ebdba6c61784be3b) Signed-off-by: Sebastiaan van Stijn github@gone.nl

+3 -3

0 comment

2 changed files

pr created time in 9 hours

create barnchthaJeztah/containerd

branch : 1.3_backport_update_go_events

created branch time in 9 hours

delete branch thaJeztah/containerd

delete branch : update_go_events

delete time in 9 hours

pull request commentcontainerd/containerd

[release/1.3 backport] sys/mount_linux: use pipe for communicating mount result

@estesp @fuweid ptal

thaJeztah

comment created time in 9 hours

PR opened containerd/containerd

[release/1.3 backport] sys/mount_linux: use pipe for communicating mount result

backport of https://github.com/containerd/containerd/pull/4160

forkAndMountat forks a process to chdir then mount layers. Signals are blocked (using runtime_beforeFork) during fork.

There is a race condition that the child process finishes before the parent process is scheduled and can unblock signal handling. The SIGCHLD signal sent from the finished process may have been delivered to the shim process's reaper thread and caused the parent process fail with ECHLD error.

This patch sets up a pipe for communication between child and parent instead of waiting for child exit status.

Fixes #4009.

Signed-off-by: Haitao Li hli@atlassian.com (cherry picked from commit 35c14c6b56d38aaf100fb598c11cd4ffc2928209) Signed-off-by: Sebastiaan van Stijn github@gone.nl

+39 -13

0 comment

1 changed file

pr created time in 9 hours

PR opened containerd/containerd

[release/1.3 backport] Bump Golang 1.13.10

backport of https://github.com/containerd/containerd/pull/4145 and https://github.com/containerd/containerd/pull/4169

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

+3 -3

0 comment

3 changed files

pr created time in 9 hours

pull request commentcontainerd/containerd

Bump Golang 1.13.10

Looks like they're throttling downloads;

WARNING: Url has SSL/TLS available, switching to HTTPS for download
Downloading mingw from 'https://downloads.sourceforge.net/mingw-w64/x86_64-5.3.0-release-posix-seh-rt_v4-rev0.7z'
ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://downloads.sourceforge.net/mingw-w64/x86_64-5.3.0-release-posix-seh-rt_v4-rev0.7z'. Exception calling "GetResponse" with "0" argument(s): "The operation has timed out" 
This package is likely not broken for licensed users - see https://chocolatey.org/docs/features-private-cdn.

This package is likely not broken for licensed users - see https://chocolatey.org/docs/features-private-cdn.

thaJeztah

comment created time in 10 hours

create barnchthaJeztah/containerd

branch : 1.3_backport_bump_golang_1.13

created branch time in 10 hours

PR opened containerd/containerd

Bump Golang 1.13.10

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

+8 -8

0 comment

5 changed files

pr created time in 10 hours

create barnchthaJeztah/containerd

branch : bump_golang_1.13.10

created branch time in 10 hours

push eventthaJeztah/containerd

Sebastiaan van Stijn

commit sha 056d60224046ef4ede772633ebdba6c61784be3b

vendor: update go-events to fix alignment for 32bit systems - relates to moby/buildkit 1111 - relates to moby/buildkit 1079 - relates to docker/buildx 129 full diff: https://github.com/docker/go-events/compare/9461782956ad83b30282bf90e31fa6a70c255ba9...e31b211e4f1cd09aa76fe4ac244571fab96ae47f Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Maksym Pavlenko

commit sha 599547d9cb3148a0d789f1c18efb7f98d2e17231

Make binaries with Github Actions Signed-off-by: Maksym Pavlenko <makpav@amazon.com>

view details

Maksym Pavlenko

commit sha 4175ebf236a647514d04129254e8ea4959c62da5

Move integration tests to Github Actions Signed-off-by: Maksym Pavlenko <makpav@amazon.com>

view details

Maksym Pavlenko

commit sha e598e5e0c61ca7e2f251d8c5d0444de0b4a47275

Add CRI tests Signed-off-by: Maksym Pavlenko <makpav@amazon.com>

view details

Maksym Pavlenko

commit sha 6d4429eddeaff0fa0640f4a51c66fb65702477df

Setup dependencies between jobs Signed-off-by: Maksym Pavlenko <makpav@amazon.com>

view details

Michael Crosby

commit sha 23fc8597dbecb65a1896ada0efde9e63655f0e23

Merge pull request #4157 from mxpv/gh Move builds and integration tests to Github actions

view details

Wei Fu

commit sha d9a1c3f9e474646b13abf6929c75ea6701eb5a02

bugfix: add default host config if not set If there is not specific host config, like ctr does, the resolver will fail to get host path. And this patch is to add default host config if needs. And default config host config should have all caps for pull and push. Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Derek McGowan

commit sha 067aba732e2250575ff25ef662950a27d235ce68

Add test for default setup for host configuration Signed-off-by: Derek McGowan <derek@mcgstyle.net>

view details

Derek McGowan

commit sha 173cbc1ba9646981a3f4e87563e960fc0a928d47

Merge pull request #4155 from fuweid/bugfix-for-default-hostconfig bugfix: add default host config if not set

view details

Akihiro Suda

commit sha 4660e4dbb653b4d83ffbc7b0dd21c9c2d2f10ea3

Merge pull request #4153 from thaJeztah/update_go_events vendor: update go-events to fix alignment for 32bit systems

view details

Maksym Pavlenko

commit sha 0caa2331581ec9e2bc489ceb33fa7280fe6eacad

Rework shim logger shutdown process Signed-off-by: Maksym Pavlenko <makpav@amazon.com>

view details

Phil Estes

commit sha d7c2513ff3bf862cc800d93b4fb7cfac1e1d7102

Update integration test timeout Also few changes to names of workflow jobs. Integration tests can get canceled without full completing at 10 minutes. Make sure we only use checkout v2 action. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Phil Estes

commit sha dc29ce296b21a3e279353068daaca640175320ce

Merge pull request #4163 from estesp/longer-integ-timeout Update integration test timeout

view details

Phil Estes

commit sha f7c2bf544ec746dfe1d3e56005e5bc1dea7473e9

Migrate functions to actions Reduce duplication while we test GH actions Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Davanum Srinivas

commit sha f328f61b813606df4e9924a00feb629ea06a27ef

Update to selinux 1.5.1 Changes are listed here: https://github.com/opencontainers/selinux/compare/v1.3.3...v1.5.1 Not urgent as such, just keep up with eco-system. Signed-off-by: Davanum Srinivas <davanum@gmail.com>

view details

Michael Crosby

commit sha 50faf254d387a91eae73c59f4bf25d88a0c406e9

Merge pull request #4164 from estesp/turn-down-travis Start removal of Travis CI components

view details

Phil Estes

commit sha 660bc71393b1678c71fa33a26bd6fc4ef6e2de26

Merge pull request #4165 from dims/update-to-selinux-1.5.1 Update to selinux 1.5.1

view details

Phil Estes

commit sha 595784954416a482dd8bde138e82305270b825e7

Merge pull request #4162 from mxpv/log-fix Rework shim logger shutdown process

view details

Haitao Li

commit sha 35c14c6b56d38aaf100fb598c11cd4ffc2928209

sys/mount_linux: use pipe for communicating mount result forkAndMountat forks a process to chdir then mount layers. Signals are blocked (using runtime_beforeFork) during fork. There is a race condition that the child process finishes before the parent process is scheduled and can unblock signal handling. The SIGCHLD signal sent from the finished process may have been delivered to the shim process's reaper thread and caused the parent process fail with ECHLD error. This patch sets up a pipe for communication between child and parent instead of waiting for child exit status. Fixes #4009. Signed-off-by: Haitao Li <hli@atlassian.com>

view details

Phil Estes

commit sha 069ce2389a5a5cd0e09993bbeaaadf1630b517a7

Merge pull request #4160 from atlassian-forks/forkmount-use-pipe-instead-wait4 sys/mount_linux: use pipe for communicating mount result

view details

push time in 10 hours

PR opened moby/moby

[19.03 backport] Bump Golang 1.13.10 impact/changelog status/2-code-review

backport of https://github.com/moby/moby/pull/40802

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

+4 -4

0 comment

4 changed files

pr created time in 10 hours

create barnchthaJeztah/docker

branch : 19.03_backport_bump_golang_1.13.10

created branch time in 10 hours

PR opened moby/moby

Bump Golang 1.13.10 process/cherry-pick status/2-code-review

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

+4 -4

0 comment

4 changed files

pr created time in 10 hours

create barnchthaJeztah/docker

branch : bump_golang_1.13.10

created branch time in 10 hours

pull request commentdocker/golang-cross

Update to Go 1.14.0

I'd like to hold off for a bit; we're not yet updating our toolchain to Go 1.14, because there's some regressions / incompatibilities with Go 1.14 related tot the preemptive changes made in that release.

tao12345666333

comment created time in 10 hours

PR opened docker/golang-cross

Bump Golang 1.13.10

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime, os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.13.9...go1.13.10

+1 -1

0 comment

1 changed file

pr created time in 10 hours

create barnchthaJeztah/golang-cross

branch : bump_golang_1.13.10

created branch time in 10 hours

PR opened moby/moby

[19.03 backport] vendor: update go-events to fix alignment for 32bit systems kind/bugfix platform/arm status/2-code-review

backport of https://github.com/moby/moby/pull/40775

  • relates to moby/buildkit 1111
  • relates to moby/buildkit 1079
  • relates to docker/buildx 129

full diff: https://github.com/docker/go-events/compare/9461782956ad83b30282bf90e31fa6a70c255ba9...e31b211e4f1cd09aa76fe4ac244571fab96ae47f

+3 -3

0 comment

2 changed files

pr created time in 10 hours

create barnchthaJeztah/docker

branch : 19.03_backport_update_go_events

created branch time in 10 hours

delete branch thaJeztah/docker

delete branch : update_go_events

delete time in 10 hours

delete branch thaJeztah/docker

delete branch : 19.03_update_buildkit

delete time in 10 hours

PR opened moby/moby

[19.03 backport] api docs: fix broken link on GitHub area/api area/docs status/3-docs-review

backport of https://github.com/moby/moby/pull/40798

The pages that were linked to have moved, so changing the links to point to docs.docker.com instead.

+18 -18

0 comment

7 changed files

pr created time in 10 hours

create barnchthaJeztah/docker

branch : 19.03_backport_api_docs_fix_link

created branch time in 10 hours

push eventthaJeztah/docker

Brian Goff

commit sha 9688ca59b340fb5cc40638d5b0b5f4cc49311df3

Rename newer build_shell target to build These two targets seem interchangeable, just that the old `build` target always built the `final` Dockerfile target even if the source was going to be bind mounted anyway. Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Sebastiaan van Stijn

commit sha e7183dbfe967e70429df8ec458c617d6954f78d4

vendor: update go-events to fix alignment for 32bit systems - relates to moby/buildkit 1111 - relates to moby/buildkit 1079 - relates to docker/buildx 129 full diff: https://github.com/docker/go-events/compare/9461782956ad83b30282bf90e31fa6a70c255ba9...e31b211e4f1cd09aa76fe4ac244571fab96ae47f Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 381c192027384ee8d24bd06572f999864871209c

Revert "vendor: update go.etcd.io/bbolt v1.3.4" This reverts commit f07f320651fbaf4941ad60bf919c6dfed48a3457. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Akihiro Suda

commit sha 5ca47f517953d0016a6d48d1c2d5f5afea54f170

rootless: graduate from experimental Close #40484 Note that the support for cgroup v2 isn't ready for production yet, regardless to rootful or rootless. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Akihiro Suda

commit sha d1304a8c74cab9ad01b76f4f588ceda87bc8cb65

Jenkinsfile: remove redundant DOCKER_EXPERIMENTAL DOCKER_EXPERIMENTAL is already set in the head of the file. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Sebastiaan van Stijn

commit sha a6a47d1a4944799ffbe3657d4dae68e0829a0dc6

Merge pull request #40759 from AkihiroSuda/move-rootless-out-of-experimental rootless: graduate from experimental

view details

Brian Goff

commit sha fe2aca0e39a4d46c93810cf9a48eeed2a2ed3a0f

Only check variant if set on image. This fixes an edge case where some images may not have a variant set just because it didn't used to get set. Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Roman Mazur

commit sha f2c432636bee8ebe93a33f76b40e35dd6e1ed6b1

pkg/authorization: Fix test failures on macOS On macOS, unit tests were failing with root@c4101a75c792:/go/src/github.com/docker/docker/pkg/authorization# go test . --- FAIL: TestAuthZRequestPluginError (0.00s) authz_unix_test.go:295: listen unix authz-test-plugin.sock: bind: file name too long --- FAIL: TestAuthZRequestPlugin (0.00s) authz_unix_test.go:295: listen unix authz-test-plugin.sock: bind: file name too long --- FAIL: TestAuthZResponsePlugin (0.00s) authz_unix_test.go:295: listen unix authz-test-plugin.sock: bind: file name too long time="2020-04-07T10:07:04Z" level=warning msg="Request body is larger than: '1048576' skipping body" --- FAIL: TestMiddlewareWrapHandler (0.00s) authz_unix_test.go:295: listen unix authz-test-plugin.sock: bind: file name too long FAIL FAIL github.com/docker/docker/pkg/authorization 0.120s This change moves the socket creation from a working test directory to a tmp directory, so the path is shorter. Change-type: patch Signed-off-by: Roman Mazur <roman@balena.io>

view details

Nikolay Edigaryev

commit sha c44fb423778e3d40cbc9e309d253067a5b8d4a96

swagger: clarify the meaning of Image field in ContainerInspect endpoint "Container's image" term is rather ambiguous: it can be both a name and an ID. Looking at the sources[1], it's actually an image ID, so bring some clarity. [1]: https://github.com/moby/moby/blob/a6a47d1a4944799ffbe3657d4dae68e0829a0dc6/daemon/inspect.go#L170 Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>

view details

Sebastiaan van Stijn

commit sha e9348898d3f33e193d0bf12031edea1db6584ae1

api docs: fix broken link on GitHub The pages that were linked to have moved, so changing the links to point to docs.docker.com instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Brian Goff

commit sha 36e80cb13b754b758de45b25fe30c7c3b358a0a0

Merge pull request #40793 from roman-mazur/upstream-moby/fix-tests pkg/authorization: Fix test failures on macOS

view details

Kir Kolyshkin

commit sha 9bdf473a7cf3c5a63901bf987d437f1af411bb5e

Merge pull request #40768 from cpuguy83/make_use_build_shell Rename newer build_shell target to build

view details

Sebastiaan van Stijn

commit sha 08e3da51f7fb82715c3db9daf9a51af56cee1236

Merge pull request #40790 from cpuguy83/fix_builder_variant_check Only check variant if set on image.

view details

Kir Kolyshkin

commit sha bd55aebad26d2d406f4f11bfaa4bbc80fcf8aebe

Merge pull request #40798 from thaJeztah/api_docs_fix_link api docs: fix broken link on GitHub

view details

Brian Goff

commit sha 81300a883d9bb434fa07f96d643115a152b7c3e0

Merge pull request #40777 from thaJeztah/revert_bump_bbolt Revert "vendor: update go.etcd.io/bbolt v1.3.4"

view details

Brian Goff

commit sha 40356083c061aa424640330a6fcd02b659c60adc

Merge pull request #40794 from edigaryev/api-clarify-image-field swagger: clarify the meaning of Image field in ContainerInspect endpoint

view details

Brian Goff

commit sha 9c71a2be319371d9ed9ab4429f2f4ddfee732e70

Merge pull request #40775 from thaJeztah/update_go_events vendor: update go-events to fix alignment for 32bit systems

view details

push time in 10 hours

delete branch thaJeztah/docker

delete branch : api_docs_fix_link

delete time in 10 hours

pull request commentdocker/cli

Add script to regenerate test-certificate fixtures

Right now it's to manually update the certificates; we could generate them "on the fly" it we want to (still have to wait for the changes to be merged upstream) 😅

thaJeztah

comment created time in 10 hours

pull request commentdocker/cli

cli: perform feature detection lazily

@silvin-lubecki updated; PTAL

thaJeztah

comment created time in 10 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha e4e3aba07a77283823f4336ccf565b359aed24c8

cli: perform feature detection lazily - Perform feature detection when actually needed, instead of during initializing - Version negotiation is performed either when making an API request, or when (e.g.) running `docker help` (to hide unsupported features) - Use a 2 second timeout when 'pinging' the daemon; this should be sufficient for most cases, and when feature detection failed, the daemon will still perform validation (and produce an error if needed) Before this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m32.919s user 0m0.370s sys 0m0.227s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m32.072s user 0m0.029s sys 0m0.023s After this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m 2.28s user 0m 0.03s sys 0m 0.03s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m 0.13s user 0m 0.02s sys 0m 0.02s Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 10 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 7da559d3f2f8aaa2a5b1d3fd9ea3f8f6a49ab6bf

cli: perform feature detection lazily - Perform feature detection when actually needed, instead of during initializing - Version negotiation is performed either when making an API request, or when (e.g.) running `docker help` (to hide unsupported features) - Use a 2 second timeout when 'pinging' the daemon; this should be sufficient for most cases, and when feature detection failed, the daemon will still perform validation (and produce an error if needed) Before this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m32.919s user 0m0.370s sys 0m0.227s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m32.072s user 0m0.029s sys 0m0.023s After this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m 2.28s user 0m 0.03s sys 0m 0.03s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m 0.13s user 0m 0.02s sys 0m 0.02s Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 10 hours

Pull request review commentdocker/cli

cli: perform feature detection lazily

 type versionDetails interface { 	ServerInfo() command.ServerInfo } -func hideFeatureFlag(f *pflag.Flag, hasFeature bool, annotation string) {-	if hasFeature {+func hideFeatureFlag(f *pflag.Flag, hasFeature func(string) bool, annotation string) {+	if f.Hidden { 		return 	}-	if _, ok := f.Annotations[annotation]; ok {-		f.Hidden = true+	if values, ok := f.Annotations[annotation]; ok {+		var v string+		if len(values) > 0 {+			v = values[0]+		}+		if !hasFeature(v) {+			f.Hidden = true+		} 	} } -func hideFeatureSubCommand(subcmd *cobra.Command, hasFeature bool, annotation string) {-	if hasFeature {+func hideFeatureSubCommand(subcmd *cobra.Command, hasFeature func(string) bool, annotation string) {+	if subcmd.Hidden { 		return 	}-	if _, ok := subcmd.Annotations[annotation]; ok {-		subcmd.Hidden = true+	if v, ok := subcmd.Annotations[annotation]; ok {+		if !hasFeature(v) {+			subcmd.Hidden = true+		} 	} }  func hideUnsupportedFeatures(cmd *cobra.Command, details versionDetails) error {-	clientVersion := details.Client().ClientVersion()-	osType := details.ServerInfo().OSType-	hasExperimental := details.ServerInfo().HasExperimental-	hasExperimentalCLI := details.ClientInfo().HasExperimental-	hasBuildKit, err := command.BuildKitEnabled(details.ServerInfo())-	if err != nil {-		return err-	}+	var (+		hasClientVersion   = func(v string) bool { return versions.LessThan(details.Client().ClientVersion(), v) }

hm, yes it should be reversed here; we need to hide if lower than the version in the annotation.

Let me also rename these versions and reverse the logic because we're now doing if !hasFeature(v) {, which is slightly confusing

thaJeztah

comment created time in 10 hours

Pull request review commentmoby/moby

add zombie check for container when killing it

 func killProcessDirectly(cntr *container.Container) error { 	if status.Err() != nil { 		// Ensure that we don't kill ourselves 		if pid := cntr.GetPID(); pid != 0 {++			// since we can not kill a zombie pid, add zombie check here+			isZombie, err := system.IsProcessZombie(pid)

We thought doing the zombie check was rather heavy for that, so better to first try the regular kill and only for the exceptional case there's a zombie process to do the check

DanielQujun

comment created time in 11 hours

pull request commentmoby/moby

Clean up abruptly terminated layer transactions data

@SamWhited could you have a look at this one?

roman-mazur

comment created time in 11 hours

push eventmoby/moby

Brian Goff

commit sha fe2aca0e39a4d46c93810cf9a48eeed2a2ed3a0f

Only check variant if set on image. This fixes an edge case where some images may not have a variant set just because it didn't used to get set. Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Sebastiaan van Stijn

commit sha 08e3da51f7fb82715c3db9daf9a51af56cee1236

Merge pull request #40790 from cpuguy83/fix_builder_variant_check Only check variant if set on image.

view details

push time in 11 hours

PR merged moby/moby

Only check variant if set on image. area/builder kind/bugfix status/2-code-review

This fixes an edge case where some images may not have a variant set just because it didn't used to get set.

+12 -2

0 comment

1 changed file

cpuguy83

pr closed time in 11 hours

pull request commentmoby/moby

On startup, actually shutdown the container.

This needs a fix for restart policies being disabled on restart

cpuguy83

comment created time in 11 hours

release moby/moby

v19.03.8

released time in 11 hours

pull request commentdocker/docker.github.io

ci: Add GitHub action to upload S3 website configuration

We can simply remove the three folders and add three redirection rules to the new

Right, so that's the tricky bit; there's redirects that are currently in place that redirect to the /ee or /datacenter directory, but due to how Jekyll constructs redirects, those redirects are configured in the target page.

For example, https://docs.docker.com/reference/ucp/3.0/cli/support/ redirects to https://docs.docker.com/datacenter/ucp/3.0/reference/cli/support/

That redirect is defined in https://github.com/docker/docker.github.io/blame/663ea14a3ca321d8f4a257d3b5ca8648ba5aec2d/datacenter/ucp/3.0/reference/cli/support.md#L6

Which means that once that page is removed, the redirect is no longer in place. So for pages that define a redirect, we should either replace them with a "dummy" page that only has the redirect_from page set (so that Jekyll generates the redirect page), or commit the generated redirect HTML's to git

StefanScherer

comment created time in 13 hours

pull request commentdocker-library/official-images

Update golang

Ah! Looked in the wrong repo 😅 ❤️

tianon

comment created time in 13 hours

issue commentdocker/compose

Multiple bash commands

This is quite lame that command: first_command && second_command doesn't work.

Have you tried;

command: "sh -c 'first_command && second_command'"
rosskevin

comment created time in 13 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 650c7175802662747f7e34653fb380ca37b11665

TestHistoryContext_CreatedSince: skip on non-UTC environments Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 19bcebd1228bc172522927c5cdfcc76d33e9c07f

test: make sure environment vars are reset after tests The trust tests were not resetting the environment after they ran, which could result in tests following those tests to fail. While at it, I also updated some other tests to use gotest.tools Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6bd09229a5cbe0941d9452a98ee7935c7a193b5f

CI: update notary test certificates Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha ab7a18147fc97eec7c16a34ce59916818b37544b

Merge pull request #2428 from thaJeztah/fix_da_fixtures CI: update notary test certificates

view details

Silvin Lubecki

commit sha 5d6281b876a50818bb707095946d5e6de99f1003

Merge pull request #2427 from thaJeztah/skip_TestHistoryContext_CreatedSince TestHistoryContext_CreatedSince: skip on non-UTC environments

view details

Silvin Lubecki

commit sha ad256ba023442bcf8ed249a1b5df708d0d779de0

Merge pull request #2426 from thaJeztah/fix_test_env test: make sure environment vars are reset after tests

view details

Sebastiaan van Stijn

commit sha 6b1162fdb6cf3db030b1b0af74a92555b2e49fac

docker build: check experimental --platform on pre-run Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 0c08b36bd5e529c106b7a240b94b0d7e6266bd26

cli: perform feature detection lazily - Perform feature detection when actually needed, instead of during initializing - Version negotiation is performed either when making an API request, or when (e.g.) running `docker help` (to hide unsupported features) - Use a 2 second timeout when 'pinging' the daemon; this should be sufficient for most cases, and when feature detection failed, the daemon will still perform validation (and produce an error if needed) Before this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m32.919s user 0m0.370s sys 0m0.227s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m32.072s user 0m0.029s sys 0m0.023s After this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m 2.28s user 0m 0.03s sys 0m 0.03s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m 0.13s user 0m 0.02s sys 0m 0.02s Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 14 hours

delete branch thaJeztah/cli

delete branch : fix_test_env

delete time in 14 hours

delete branch thaJeztah/cli

delete branch : skip_TestHistoryContext_CreatedSince

delete time in 14 hours

issue commentmoby/buildkit

--progress plain results in truncated output width

opened https://github.com/moby/buildkit/pull/1435 for consideration

eedwards-sk

comment created time in 14 hours

PR opened moby/buildkit

progress: disable truncating by default when using --progress=plain

fixes https://github.com/moby/buildkit/issues/1412

Currently, docker build --progress=plain truncates output, which makes it difficult to debug problems during build (the step that failed may not be the cause of the failure).

For example, in the following build, the output of the RUN echo ... is truncated:

DOCKER_BUILDKIT=1 docker build --no-cache --progress=plain -t foo -<<EOF
FROM busybox
RUN echo "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas ut lorem nec leo euismod vestibulum. Donec tortor nisl, iaculis at vehicula vel, interdum eu orci. Integer velit lacus, congue id magna eu, mollis accumsan augue. Aliquam non venenatis risus, eu posuere libero. Vestibulum ante ipsum primis in faucibus orci luctus." > /somewhere
RUN echo "something went wrong"; exit 1
EOF

#5 [2/3] RUN echo "Lorem ipsum dolor sit amet, consectetur adipiscing elit....
#5 DONE 0.2s

#6 [3/3] RUN echo "something went wrong"; exit 1
#6 0.211 something went wrong
#6 ERROR: executor failed running [/bin/sh -c echo "something went wrong"; exit 1]: runc did not terminate sucessfully
------
 > [3/3] RUN echo "something went wrong"; exit 1:
------
failed to solve with frontend dockerfile.v0: failed to build LLB: executor failed running [/bin/sh -c echo "something went wrong"; exit 1]: runc did not terminate sucessfully

While there is an existing PROGRESS_NO_TRUNC environment variable, I think that this should be the default if the user opted to use --progress=plain (or in situations where no TTY is attached, which could be in CI).

This patch changes the default to disable truncating in those situations, but allowing users to opt-out by setting PROGRESS_NO_TRUNC=0

With this change the same build looks like this:

#5 [2/3] RUN echo "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas ut lorem nec leo euismod vestibulum. Donec tortor nisl, iaculis at vehicula vel, interdum eu orci. Integer velit lacus, congue id magna eu, mollis accumsan augue. Aliquam non venenatis risus, eu posuere libero. Vestibulum ante ipsum primis in faucibus orci luctus." > /somewhere
#5 sha256:b2f0f47d63911ee55e7cf17c81007310e28190b5be84aa1a7869ba90786d5cee
#5 DONE 0.2s

#6 [3/3] RUN echo "something went wrong"; exit 1
#6 sha256:c037b34bb998ae7d30572b489286da14df87e1478adf6d0c5c71c79b84b11bcc
#6 0.293 something went wrong
#6 ERROR: executor failed running [/bin/sh -c echo "something went wrong"; exit 1]: runc did not terminate sucessfully
------
 > [3/3] RUN echo "something went wrong"; exit 1:
------
failed to solve with frontend dockerfile.v0: failed to build LLB: executor failed running [/bin/sh -c echo "something went wrong"; exit 1]: runc did not terminate sucessfully
+3 -3

0 comment

1 changed file

pr created time in 14 hours

create barnchthaJeztah/buildkit

branch : default_no_trunc

created branch time in 14 hours

PR opened docker/cli

Add script to regenerate test-certificate fixtures area/testing process/cherry-pick status/2-code-review

follow-up to https://github.com/docker/cli/pull/2428

depends on https://github.com/dmcgowan/quicktls/pull/3

+8 -0

0 comment

1 changed file

pr created time in 14 hours

delete branch thaJeztah/cli

delete branch : fix_da_fixtures

delete time in 14 hours

create barnchthaJeztah/cli

branch : add_fixture_gen_script

created branch time in 14 hours

push eventthaJeztah/buildkit

Tonis Tiigi

commit sha 146ef63e4af19c3e6913adb53dcbe5e7298ef1d7

llb: update image meta resolver to async callback Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

view details

Tõnis Tiigi

commit sha c44cb42a6937ff3fd27e089e72958ba73a62c100

Merge pull request #1428 from tonistiigi/imagemeta-async llb: update image meta resolver to async callback

view details

Edgar Lee

commit sha 423f5f8a9758c39955e2d6869a66bea71c7728bd

Allow sessions to hijack the connection outside of a solve Signed-off-by: Edgar Lee <edgarl@netflix.com>

view details

Edgar Lee

commit sha d42b8bfc108de700b6ba4f058d9f6c6b53ba1836

Set single export entry outside of session initialization Signed-off-by: Edgar Lee <edgarl@netflix.com>

view details

Tõnis Tiigi

commit sha 226a5db9ad3d3ce6ba9bf10fe6300ee635b70f3b

Merge pull request #1433 from hinshun/session-hijack Allow sessions to hijack the connection outside of a solve

view details

push time in 14 hours

pull request commentmoby/moby

api docs: fix broken link on GitHub

amd64 failure is https://github.com/moby/moby/issues/39352

thaJeztah

comment created time in 14 hours

pull request commentdocker/cli

CI: update notary test certificates

I'll do the script in a follow up; I generated these certificates with a slightly modified version of https://github.com/dmcgowan/quicktls with this patch applied: https://github.com/dmcgowan/quicktls/pull/3;

GO111MODULE=off go get -u github.com/dmcgowan/quicktls
cd e2e/testdata/notary || exit 1
quicktls -org=Docker -with-san notary-server notaryserver evil-notary-server evilnotaryserver localhost 127.0.0.1
cat ca.pem >> notary-server.cert
mv ca.pem root-ca.cert
cp notary-server.cert notary-server.key root-ca.cert ../notary-evil/
thaJeztah

comment created time in 14 hours

pull request commentdmcgowan/quicktls

Add --with-san flag to allow generating cert with SAN

@dmcgowan PTAL

thaJeztah

comment created time in 14 hours

PR opened dmcgowan/quicktls

Add --with-san flag to allow generating cert with SAN

This adds a --with-san flag that, when set, will generate a single certificate with the provided hosts added as Subject Alternative Name (SAN) instead of generating a separate certificate for each host.

For example:

quicktls -with-san domain-one.example.org domain-two.example.org localhost 127.0.0.1

ls -l
total 24
-rw-r--r--  1 sebastiaan  staff  1094 Apr  9 17:14 ca.pem
-rw-r--r--  1 sebastiaan  staff  1208 Apr  9 17:14 domain-one.example.org.cert
-rw-------  1 sebastiaan  staff  1675 Apr  9 17:14 domain-one.example.org.key

openssl x509 -text -noout -in ./domain-one.example.org.cert
...
X509v3 extensions:
    X509v3 Subject Alternative Name:
        DNS:domain-one.example.org, DNS:domain-two.example.org, DNS:localhost, IP Address:127.0.0.1
...
+15 -4

0 comment

1 changed file

pr created time in 14 hours

push eventthaJeztah/quicktls

Sebastiaan van Stijn

commit sha a6ffd69ffcf9fafb5bd62d97ee4fdf7c76cc871c

Add --with-san flag to allow generating cert with SAN This adds a `--with-san` flag that, when set, will generate a single certificate with the provided hosts added as Subject Alternative Name (SAN) instead of generating a separate certificate for each host. For example: quicktls -with-san domain-one.example.org domain-two.example.org localhost 127.0.0.1 ls -l total 24 -rw-r--r-- 1 sebastiaan staff 1094 Apr 9 17:14 ca.pem -rw-r--r-- 1 sebastiaan staff 1208 Apr 9 17:14 domain-one.example.org.cert -rw------- 1 sebastiaan staff 1675 Apr 9 17:14 domain-one.example.org.key openssl x509 -text -noout -in ./domain-one.example.org.cert ... X509v3 extensions: X509v3 Subject Alternative Name: DNS:domain-one.example.org, DNS:domain-two.example.org, DNS:localhost, IP Address:127.0.0.1 ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 14 hours

create barnchthaJeztah/quicktls

branch : support_san

created branch time in 14 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 6bd09229a5cbe0941d9452a98ee7935c7a193b5f

CI: update notary test certificates Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 15 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 39b7081b94527d67f9aa07a96e3bf3b1041fceac

CI: update notary test certificates Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 15 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 48101c495bed2045813f4709068124cef47d6973

CI: update notary test certificates Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 15 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha e75460b03dd9aafdb735b161935c5e9b291b339c

CI: update notary test certificates Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 15 hours

PR opened docker/cli

CI: update notary test certificates

opening as draft, as I want to add a script to do this

+122 -240

0 comment

6 changed files

pr created time in 16 hours

create barnchthaJeztah/cli

branch : fix_da_fixtures

created branch time in 16 hours

issue commentmoby/buildkit

--progress plain results in truncated output width

@eedwards-sk Ok, I forgot there's a PROGRESS_NO_TRUNC=1 env-var you can set to disable truncation;

PROGRESS_NO_TRUNC=1 DOCKER_BUILDKIT=1 docker build --no-cache --progress=plain -t foo -<<EOF
FROM busybox
RUN echo "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas ut lorem nec leo euismod vestibulum. Donec tortor nisl, iaculis at vehicula vel, interdum eu orci. Integer velit lacus, congue id magna eu, mollis accumsan augue. Aliquam non venenatis risus, eu posuere libero. Vestibulum ante ipsum primis in faucibus orci luctus."
EOF

Perhaps that should be enabled by default if --progress=plain (not sure if it's used without --progress=plain though 🤔

eedwards-sk

comment created time in 16 hours

fork thaJeztah/quicktls

A utility to quickly generate TLS certificates with a CA.

fork in 17 hours

issue commentdocker/cli

CI: test-certificates in e2e tests have expired

Oh, actually; that gen.sh was copied, but it's only for the certificates in this directory; https://github.com/docker/cli/tree/8b00c5cfd87ac653e2a1dc4b95df30ca23e1d40d/e2e/image/testdata/notary

thaJeztah

comment created time in 18 hours

issue commentdocker/cli

CI: test-certificates in e2e tests have expired

Looks like they were removed in moby in https://github.com/moby/moby/pull/36838

thaJeztah

comment created time in 18 hours

issue commentdocker/cli

CI: test-certificates in e2e tests have expired

I had a quick look at this; these certificates were added as part of https://github.com/docker/cli/pull/924, which migrated tests from the moby/moby repository, which were later removed there https://github.com/moby/moby/pull/36515

That didn't remove the fixtures though; https://github.com/moby/moby/tree/5433ceb12ead305d8c85e8e27c4b4d842ef88ae0/integration-cli/fixtures/notary

Looking at that directory, there's a gen.sh (https://github.com/moby/moby/blob/5433ceb12ead305d8c85e8e27c4b4d842ef88ae0/integration-cli/fixtures/notary/gen.sh) to generate the certificates, so I think we should copy that to this repository and use it to update fixtures

thaJeztah

comment created time in 18 hours

PR opened moby/moby

Reviewers
Fix TEST_FILTER to work for both "integration" and "integration-cli" area/testing kind/bugfix status/2-code-review

backport of https://github.com/moby/moby/pull/40110

The TEST_FILTER variable allows running a single integration or integration-cli test. However, it failed to work properly for integration-cli tests.

Before:

# Filtering "integration" tests works:
make TEST_FILTER=TestInspectCpusetInConfigPre120 test-integration
...
DONE 1 tests in 18.331s

# But running a single test in "integration-cli" did not:

make TEST_FILTER=TestSwarmNetworkCreateIssue27866 test-integration
...
DONE 0 tests in 17.314s

Trying to manually add the / prefix, didn't work either, because that made the "grep" fail to find which test-suites to run/skip:

make TEST_FILTER=/TestSwarmNetworkCreateIssue27866 test-integration
---> Making bundle: test-integration (in bundles/test-integration)
make: *** [test-integration] Error 1

After:

make TEST_FILTER=TestInspectCpusetInConfigPre120 test-integration
...
DONE 1 tests in 18.331s

make TEST_FILTER=TestSwarmNetworkCreateIssue27866 test-integration
...
DONE 12 tests in 26.527s

Note that the 12 tests is still a bit misleading, because every suite is started (which is counted as a test), but no tests are run. This is still something that could be improved on.

This patch also makes a small modification to the code that's setting integration_api_dirs, and no longer runs go list if not needed.

Signed-off-by: Sebastiaan van Stijn github@gone.nl (cherry picked from commit e7805653b8632aae4f789dbca238e25b16df964d) Signed-off-by: Sebastiaan van Stijn github@gone.nl

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/moby/moby/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+9 -2

0 comment

1 changed file

pr created time in 18 hours

PR opened moby/moby

api docs: fix broken link on GitHub area/api area/docs process/cherry-pick status/3-docs-review

The pages that were linked to have moved, so changing the links to point to docs.docker.com instead.

+18 -18

0 comment

7 changed files

pr created time in 18 hours

create barnchthaJeztah/docker

branch : 19.03_backport_fix_test_filter

created branch time in 18 hours

create barnchthaJeztah/docker

branch : api_docs_fix_link

created branch time in 18 hours

pull request commentdocker/cli

TestHistoryContext_CreatedSince: skip on non-UTC environments

@silvin-lubecki PTAL

thaJeztah

comment created time in 18 hours

PR opened docker/cli

TestHistoryContext_CreatedSince: skip on non-UTC environments area/testing status/2-code-review

This test failed when running on the host on my Mac, due to the date/time format being different

+2 -0

0 comment

1 changed file

pr created time in 18 hours

push eventthaJeztah/cli

Sebastiaan van Stijn

commit sha 19bcebd1228bc172522927c5cdfcc76d33e9c07f

test: make sure environment vars are reset after tests The trust tests were not resetting the environment after they ran, which could result in tests following those tests to fail. While at it, I also updated some other tests to use gotest.tools Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 18 hours

pull request commentdocker/cli

test: make sure environment vars are reset after tests

@silvin-lubecki PTAL

thaJeztah

comment created time in 18 hours

more