profile
viewpoint
Michael Crosby crosbymichael @docker Indianapolis http://crosbymichael.com Building things for others who build things

push eventcrosbymichael/cgroups

Michael Crosby

commit sha 1857c77fd782f55e8189cef1cd2f41cb46663e67

Add Mode() func to check cgroup mount type This function will return the cgroup mode that is mounted on the host system. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

push time in 20 hours

startedschachmat/wego

started time in 20 hours

Pull request review commentcontainerd/containerd

support cgroup2

 import ( 	"github.com/containerd/containerd/runtime/v2/runc/options" 	"github.com/containerd/containerd/runtime/v2/task" 	"github.com/containerd/typeurl"+	libcontainercgroups "github.com/opencontainers/runc/libcontainer/cgroups"

I added https://github.com/containerd/cgroups/pull/127 so we don't have this additional import inside the shims

AkihiroSuda

comment created time in 20 hours

PR opened containerd/cgroups

Add Mode() func to check cgroup mount type

This function will return the cgroup mode that is mounted on the host system.

Signed-off-by: Michael Crosby crosbymichael@gmail.com

+47 -1

0 comment

1 changed file

pr created time in 20 hours

create barnchcrosbymichael/cgroups

branch : v2-check

created branch time in 20 hours

issue commentcontainerd/containerd

where has this bug gone?

@yetanotherlogonfail this should be resolved if you update your docker and containerd on your system. Make sure you restart both daemons after the upgrade and let us know if that resolved the issue for you.

yetanotherlogonfail

comment created time in 21 hours

pull request commentcontainerd/containerd

[release/1.3] Prepare v1.3.1 release

LGTM

thaJeztah

comment created time in 2 days

pull request commentcontainerd/containerd

support cgroup2

I got it to work. you need a couple others like BPF_syscall

AkihiroSuda

comment created time in 2 days

pull request commentcontainerd/containerd

support cgroup2

I just tested this and got containers running under v2 with runc. It's looking good on the runtime side, we just need to map the stats structures so that this isn't a huge burden for users. We also need to figureout what we want to do with the subtree control file whenever we create a directory for a namespace.

AkihiroSuda

comment created time in 2 days

pull request commentcontainerd/containerd

support cgroup2

I dont' like how the stats are handled. We should output the prometheus metrics without any changes. People shouldn't have to have all new metric keys because we start using cgroups v2. We need to make the v2 code to the existing stats structs within containerd

AkihiroSuda

comment created time in 2 days

push eventstellarproject/aports

Michael Crosby

commit sha 8274485b1e6528cd440322bb759c81480e14ea78

kernel config with eBPF support Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

push time in 2 days

pull request commentcontainerd/containerd

support cgroup2

Do you know the kernel configs that I need for the ebpf devices?

Trying this out I get:

ctr: OCI runtime create failed: container_linux.go:346: starting container process caused "process_linux.go:449: container init caused \"process_linux.go:415: setting cgroup config for procHooks process caused \\\"failed to load program: function not implemented\\\"\"": unknown
AkihiroSuda

comment created time in 2 days

pull request commentcontainerd/containerd

support cgroup2

Let me test this on my setup

AkihiroSuda

comment created time in 2 days

push eventcrosbymichael/fm

Michael Crosby

commit sha b5e4c6ca0eaa523ce0759f3d4fb5b9a273e49063

Fix skip line in fm bk

view details

push time in 2 days

pull request commentopencontainers/selinux

Add errors.Wrap to indicate the file relabel failed on

LGTM

rhatdan

comment created time in 2 days

push eventcrosbymichael/fm

Arush Salil

commit sha e60bde6385ae639e7bbf4a5a2efdfd5501fbe6f9

enable go module Signed-off-by: Arush Salil <me@aru.sh>

view details

Michael Crosby

commit sha 1831fb8a3bc229e8883185f0766766b190d7a96a

Merge pull request #3 from arush-sal/add-go-mod enable go module

view details

push time in 2 days

PR merged crosbymichael/fm

enable go module

Enable Go modules and add the following files:

  • go.mod
  • go.sum

Signed-off-by: Arush Salil me@aru.sh

+41 -0

0 comment

2 changed files

arush-sal

pr closed time in 2 days

pull request commentcrosbymichael/fm

add check for editor env variable

thanks!

arush-sal

comment created time in 2 days

push eventcrosbymichael/fm

Arush Salil

commit sha aeb24970bfcaf87645a3fcba819f5f20957e85d1

add check for editor env variable Signed-off-by: Arush Salil <me@aru.sh>

view details

Michael Crosby

commit sha 78698aa776d38701e2b98f1fff9bd2e814134c21

Merge pull request #2 from arush-sal/dev add check for editor env variable

view details

push time in 2 days

PR merged crosbymichael/fm

add check for editor env variable

fix #1

+5 -0

0 comment

1 changed file

arush-sal

pr closed time in 2 days

issue closedcrosbymichael/fm

running editor: fork/exec : no such file or directory

What has happed: If the EDITOR env variable is not set then the binary currently exits with the following error:

➜  ~/go/src/github.com/crosbymichael/fm git:(master) ✗✗✗ ./fm bk
running editor: fork/exec : no such file or directory

What was expected: The current working directory was expected to be opened in an editor or a helpful error message was expected to be printed.

Suggested fix: We should add a check for the EDITOR env variable. And if its not set then instead of just printing the above message and exiting it rather should have printed a more helpful message. Something like:

No default editor set. Please set a default editor of your choice. E.g:
export EDITOR=vim

closed time in 2 days

arush-sal

push eventcontainerd/cgroups

Wei Fu

commit sha 7f48529d150061c82e086ffbdf4a500f6b49278c

v2: follow package import rule and update license statement Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Michael Crosby

commit sha 9e089962ffffaeb9281c22c14bdb77b59852f7a1

Merge pull request #126 from fuweid/gofmt v2: follow package import rule and update license statement

view details

push time in 2 days

PR merged containerd/cgroups

v2: follow package import rule and update license statement

Signed-off-by: Wei Fu fuweid89@gmail.com

+12 -13

2 comments

2 changed files

fuweid

pr closed time in 2 days

pull request commentcontainerd/cgroups

v2: follow package import rule and update license statement

LGTM

fuweid

comment created time in 2 days

push eventcontainerd/containerd

Lantao Liu

commit sha a18acaf2cfdcaff92c673c3ae4c01cbd582af945

Avoid deadlock in unpacker. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Michael Crosby

commit sha 89d3753aa358760cd29a80d9c53cedf1f487df33

Merge pull request #3834 from Random-Liu/cherrypick-#3825-1.3 [release/1.3] Avoid deadlock in unpacker.

view details

push time in 2 days

PR merged containerd/containerd

[release/1.3] Avoid deadlock in unpacker.

Cherrypick #3825 to release/1.3.

Signed-off-by: Lantao Liu lantaol@google.com

+44 -3

3 comments

2 changed files

Random-Liu

pr closed time in 2 days

pull request commentcontainerd/containerd

[release/1.3] Avoid deadlock in unpacker.

LGTM

Random-Liu

comment created time in 2 days

push eventcrosbymichael/fm

Michael Crosby

commit sha d32d057ff221a59e6b329a39a8b6697cd77f49ed

Fallback to cp if rename fails

view details

Michael Crosby

commit sha 502f2bb40f5d0557a41f135913649baa0c385e9b

use err check for copy fallback

view details

push time in 3 days

pull request commentcontainerd/containerd

WIP improve oci test coverage

LGTM

fahedouch

comment created time in 3 days

push eventcontainerd/cgroups

Akihiro Suda

commit sha ca4875604fa29abf6fa0dfd053d61b93369223f8

v2: put Devices to Resources struct as a field, not as a method Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Michael Crosby

commit sha da8ad43b2fb3b257c5b743f44731f7e624b8cd16

Merge pull request #122 from AkihiroSuda/v2-move-dev v2: put Devices to Resources struct as a field, not as a method

view details

push time in 3 days

push eventcontainerd/containerd

Lantao Liu

commit sha 0bb48aef07803d90bcee335a6a17b3ea85597754

Add `--log-file` flag for windows service. Signed-off-by: Lantao Liu <lantaol@google.com>

view details

Michael Crosby

commit sha 31ea7b4ede85f9caa8e86c7997adde60efe1b7e3

Merge pull request #3831 from Random-Liu/add-windows-log-file Add `--log-file` flag for windows service.

view details

push time in 3 days

PR merged containerd/containerd

Add `--log-file` flag for windows service.

Event and tracing are good, but the traditional log file is also very useful, e.g. I can't find an ETW plugin for fluentd yet.

--log-file is what we are doing for kubelet and kube-proxy on windows, too. It is optional, old behavior is kept if the flag is not specified.

@jterry75

Signed-off-by: Lantao Liu lantaol@google.com

+21 -5

7 comments

1 changed file

Random-Liu

pr closed time in 3 days

pull request commentcontainerd/containerd

Add `--log-file` flag for windows service.

LGTM

Random-Liu

comment created time in 3 days

startedwkhtmltopdf/wkhtmltopdf

started time in 3 days

push eventstellarproject/terraos

Joe Abbey

commit sha 110d526c92df1f2e17bf5733fc615fa09cbe52ce

Update README.md

view details

Michael Crosby

commit sha f1bde72a8ebc87e8f47310f03f08f36379d2e5fd

Merge pull request #18 from joeabbey/patch-1 Update README.md

view details

push time in 3 days

PR merged stellarproject/terraos

Update README.md
+1 -1

0 comment

1 changed file

joeabbey

pr closed time in 3 days

startedjitsi/jitsi-meet

started time in 3 days

startedshurcooL/github_flavored_markdown

started time in 3 days

pull request commentcontainerd/cgroups

v2: toggle ancestors of c.path, not c.path itself

LGTM

AkihiroSuda

comment created time in 3 days

pull request commentcontainerd/cgroups

v2: put Devices to Resources struct as a field, not as a method

needs a rebase

AkihiroSuda

comment created time in 3 days

startedMiniKeePass/MiniKeePass

started time in 3 days

issue commentcrosbymichael/fm

running editor: fork/exec : no such file or directory

Go ahead and pr the fix please :)

Michael Crosby

On Nov 18, 2019, at 7:04 AM, Arush Salil notifications@github.com wrote:

let me know if you want me to send a PR for the fix.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

arush-sal

comment created time in 3 days

push eventcrosbymichael/fm

Michael Crosby

commit sha f75ee0c82c832c53af256869a2174c6b4055beea

improve UX Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

view details

push time in 5 days

create barnchcrosbymichael/fm

branch : master

created branch time in 5 days

created repositorycrosbymichael/fm

CLI based file manager

created time in 5 days

issue commentcontainerd/cgroups

v2: ToggleControllers() should toggle ancestors of c.path, not c.path itself

Noooo, map[string]error is a horrible ux, there are better ways to handle this

AkihiroSuda

comment created time in 6 days

pull request commentcontainerd/cgroups

Added ebps support(based on runc implementation)

LGTM

Zyqsempai

comment created time in 6 days

push eventcontainerd/cgroups

Akihiro Suda

commit sha 1c26af6c55f531b70d57f7058796c8e6d6aa6e09

v2: fix parsing pids stat pids stat was not functional due to the whitespace issue Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Akihiro Suda

commit sha c4993aebedaa31fe8435702ddae54ec0a5c0ac9f

v2: fix nil panic on statting disabled controllers Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Michael Crosby

commit sha e56683d3d5a15abdea66d7511b5e16083da2f594

Merge pull request #120 from AkihiroSuda/fix-v2-stats v2: fix issues

view details

push time in 6 days

PR merged containerd/cgroups

v2: fix issues
  • pids stat was not functional due to the whitespace issue
  • nil panic had happened when statting disabled controllers

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

+50 -38

2 comments

1 changed file

AkihiroSuda

pr closed time in 6 days

pull request commentcontainerd/cgroups

v2: fix issues

LGTM

AkihiroSuda

comment created time in 6 days

pull request commentcontainerd/cgroups

Added RDMA controller

LGTM

Zyqsempai

comment created time in 6 days

pull request commentcontainerd/cgroups

Added RDMA controller

will need a rebase after all the previous merges

Zyqsempai

comment created time in 6 days

pull request commentcontainerd/cgroups

Added ebps support(based on runc implementation)

rebase:)

Zyqsempai

comment created time in 6 days

push eventcontainerd/cgroups

Akihiro Suda

commit sha 0339015d72ef1b41b490b3c63b41cdf89a828e78

.travis.yml: add cgroup v2 Vagrant box Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Michael Crosby

commit sha daf52615ff6e6378ce2d2e822949d509cc5816bc

Merge pull request #113 from AkihiroSuda/v2-travis .travis.yml: add cgroup v2 Vagrant box

view details

push time in 6 days

pull request commentcontainerd/cgroups

.travis.yml: add cgroup v2 Vagrant box

LGTM

AkihiroSuda

comment created time in 6 days

PR merged containerd/cgroups

Added OOM notification for Memory controller

Partially Fixes #104

@crosbymichael @AkihiroSuda So this Pr is on of the ideas I have on how we can implement OOM notifications in cGroupv2. So, I see here at least two directions, we can implement Inotify fd check right here and in case if we receive inotify event, create new separate file for oom's only, and return that file fd. On other hand we can delegate it to next layers(containerd etc.) What do you think of this approach? Signed-off-by: bpopovschi zyqsempai@mail.ru

+62 -0

9 comments

1 changed file

Zyqsempai

pr closed time in 6 days

push eventcontainerd/cgroups

bpopovschi

commit sha 9629c6ed18b2cfc13dca1597a8ae15314bdd4733

Added OOM notification for Memory controller Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

bpopovschi

commit sha eb898ed08d0acb48db00b8bd01cc9227b001641b

Added event channel for oom event subscription Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

bpopovschi

commit sha 4aad508d1059e09c03caef3ed781781605ab0020

Added events struct and error channel Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

bpopovschi

commit sha d03d5167784d274aa37013826c6a09ded7d6b978

Remove global var Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

Michael Crosby

commit sha c4474e830f20c7825a2f93915d661e74b62ab12e

Merge pull request #115 from Zyqsempai/104-add-oom-notifications Added OOM notification for Memory controller

view details

push time in 6 days

issue closedcontainerd/cgroups

cgroup2: check list for v2 controller implementations

Urgent (required to get CRI and Moby work)

  • [x] pids: #103
  • [x] cpu: #107
  • [x] memory (memory.stats): #108 @Zyqsempai
  • [ ] memory.current, memory.swap.current, and other memory stat files https://www.kernel.org/doc/Documentation/cgroup-v2.txt : #117
  • [ ] OOM event FD: #115
  • [x] io: #112
  • [ ] devices (BPF): #116

Metrics functions are urgent. Update() functions are not necessary for CRI and Moby.

Non-urgent

  • [ ] NewSystemd() and LoadSystemd()
  • [x] freezer: #103
  • [ ] perf_event
  • [x] cpuset: #111
  • [ ] rdma: #119

closed time in 6 days

AkihiroSuda

pull request commentcontainerd/cgroups

Added OOM notification for Memory controller

LGTM

Zyqsempai

comment created time in 6 days

push eventcontainerd/cgroups

bpopovschi

commit sha 4276e8e73adca3befbc45b77d2fac8a65bee988d

Added current and mas swap and memory usage stats Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

bpopovschi

commit sha 344a8ab471a2dd96068c8963b3e3ce2777c15b98

Remove unused metrics Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

bpopovschi

commit sha 4d88c26a2d0f62baae782ce922975473b41291a6

Simplify stats Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

bpopovschi

commit sha cfc1c23314b641473dd9599a31e604b75adeec8c

Function rename Signed-off-by: bpopovschi <zyqsempai@mail.ru>

view details

Michael Crosby

commit sha 2bd4ae17dfc7244a7bba1485e0fc810423b8e20f

Merge pull request #117 from Zyqsempai/104-add-more-memory-stats Added current and max swap and memory usage stats

view details

push time in 6 days

PR merged containerd/cgroups

Added current and max swap and memory usage stats

Related to #104 Added memory.current, memory.max, memory.swap.current, memory.swap.max stats. Signed-off-by: bpopovschi zyqsempai@mail.ru

+239 -53

6 comments

5 changed files

Zyqsempai

pr closed time in 6 days

pull request commentcontainerd/cgroups

Added current and max swap and memory usage stats

LGTM

Zyqsempai

comment created time in 6 days

startedSwordfish90/cool-retro-term

started time in 7 days

push eventcontainerd/containerd

Brandon Lum

commit sha 856ea30556cfdc01ba3545de087e735413245210

Add client unpack opts Signed-off-by: Brandon Lum <lumjjb@gmail.com>

view details

Michael Crosby

commit sha d7ec45b172d956575dbd195d809172095bc74bbb

Merge pull request #3826 from lumjjb/add_unpack_opt Add client unpack opts

view details

push time in 7 days

PR merged containerd/containerd

Add client unpack opts

Added RemoteOpt to initialize remote context unpack option.

Signed-off-by: Brandon Lum lumjjb@gmail.com

+8 -0

3 comments

1 changed file

lumjjb

pr closed time in 7 days

pull request commentcontainerd/containerd

Add client unpack opts

LGTM

lumjjb

comment created time in 7 days

pull request commentmoby/moby

overlay[2]: rm extra checks in init

LGTM

kolyshkin

comment created time in 7 days

pull request commentcontainerd/cgroups

Added OOM notification for Memory controller

rebase please :)

Zyqsempai

comment created time in 7 days

pull request commentcontainerd/containerd

containerd binaries nightly builds

nice, this looks awesome

mxpv

comment created time in 7 days

push eventcontainerd/containerd

Maksym Pavlenko

commit sha c479156b81882f50ada95e96bf70797fa37ddd6c

Add Github workflow for nightly builds Signed-off-by: Maksym Pavlenko <makpav@amazon.com>

view details

Michael Crosby

commit sha bc62a829acab5ccdf6c0cfc4ec6df165f6de0597

Merge pull request #3827 from mxpv/nightly containerd binaries nightly builds

view details

push time in 7 days

PR merged containerd/containerd

containerd binaries nightly builds

Let's give a try to Github Actions. This PR adds a workflow that will trigger nightly jobs to build containerd binaries (both linux and windows). Job artifacts will be uploaded to Github Storage and available for 90 days.

Here is an example how job execution looks like: https://github.com/mxpv/containerd/commit/23f980b71cf63e99a07446bc35c1e932530c30ee/checks?check_suite_id=307992957

Binaries can be downloaded from the menu at top right corner:

Screen Shot 2019-11-13 at 5 56 42 PM

Signed-off-by: Maksym Pavlenko makpav@amazon.com

+45 -0

4 comments

1 changed file

mxpv

pr closed time in 7 days

pull request commentcontainerd/containerd

containerd binaries nightly builds

LGTM

mxpv

comment created time in 7 days

pull request commentcontainerd/containerd

Avoid deadlock in unpacker.

LGTM

Random-Liu

comment created time in 7 days

pull request commentcontainerd/cgroups

Added ebps support(based on runc implementation)

Can you rebase this one as well?

Zyqsempai

comment created time in 7 days

pull request commentcontainerd/cgroups

Added current and max swap and memory usage stats

Can you rebase on master as well to fix the build? Thanks!

Zyqsempai

comment created time in 7 days

Pull request review commentcontainerd/cgroups

Added current and max swap and memory usage stats

 func (c *Manager) Stat() (*stats.Metrics, error) { 		ThpFaultAlloc:         out["thp_fault_alloc"].(uint64), 		ThpCollapseAlloc:      out["thp_collapse_alloc"].(uint64), 	}+	cur_mem := getStatFileContent(filepath.Join(c.path, "memory.current"))+	max_mem := getStatFileContent(filepath.Join(c.path, "memory.max"))+	cur_swap := getStatFileContent(filepath.Join(c.path, "memory.swap.current"))+	max_swap := getStatFileContent(filepath.Join(c.path, "memory.swap.max"))++	usage := stats.MemoryEntry{+		Usage: cur_mem,

try not to use snake case _ in the go code.

Zyqsempai

comment created time in 7 days

Pull request review commentcontainerd/cgroups

Added current and max swap and memory usage stats

 message MemoryStat { 	uint64 pglazyfreed = 29; 	uint64 thp_fault_alloc = 30; 	uint64 thp_collapse_alloc = 31;+	MemoryEntry usage = 32;

instead of a struct, can we just add these as field? keep the stats flat and simple

Zyqsempai

comment created time in 7 days

Pull request review commentcontainerd/cgroups

Added current and max swap and memory usage stats

 message MemoryStat { 	uint64 pglazyfreed = 29; 	uint64 thp_fault_alloc = 30; 	uint64 thp_collapse_alloc = 31;+	MemoryEntry usage = 32;

no

Zyqsempai

comment created time in 7 days

push eventcontainerd/cgroups

Phil Estes

commit sha d0f61b75b2777e567a0504d584d733b8cc5760df

Set GO111MODULE=on to fix Go 1.11/1.12 builds Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Michael Crosby

commit sha d26e1b37d042d3cd3aaba23b4713f5b8185b9517

Merge pull request #118 from estesp/go-mod-travis Set GO111MODULE=on and use `go mod vendor` to fix Go 1.11/1.12 builds

view details

push time in 7 days

issue commentcontainerd/containerd

missing dependency pigz

It shouldn't be a requirement. This is the ubuntu pkg from ubutnu sources or somewhere else?

pierreozoux

comment created time in 8 days

pull request commentcontainerd/containerd

Better support windows binaries.

LGTM

Random-Liu

comment created time in 9 days

Pull request review commentcontainerd/cgroups

Added OOM notification for Memory controller

 func (c *Manager) freeze(path string, state State) error { 		time.Sleep(1 * time.Millisecond) 	} }++func (c *Manager) OOMEventFD() (uintptr, error) {

I guess while we are working on this, can we go ahead and just make this generic and return all event types. We can use the Event struct to pass the data back to users

Zyqsempai

comment created time in 9 days

Pull request review commentcontainerd/cgroups

Added OOM notification for Memory controller

 const ( 	controllersFile = "cgroup.controllers" ) +var oomEventCount = 0

lets remove the global

Zyqsempai

comment created time in 9 days

issue commentcontainerd/cgroups

cgroup2: check list for v2 controller implementations

@AkihiroSuda i don't want to put out any cgroups code without device support as it's very important to security

AkihiroSuda

comment created time in 9 days

issue commentcontainerd/project

Adding ttrpc-rust as sub-project

You can look at https://github.com/containerd/project/issues/37

teawater

comment created time in 9 days

pull request commentcontainerd/containerd

support cgroup2

I know about it, its not ready yet from the cgroup lib POV

AkihiroSuda

comment created time in 9 days

push eventcontainerd/containerd

Wei Fu

commit sha 128664b6779adb08c7a2a115fe1466264756b1d7

snapshots: return error if readSnapshot fails Signed-off-by: Wei Fu <fuweid89@gmail.com> (cherry picked from commit 843423ec3887eb47ac70308cee9267ef6a1fa435) Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Michael Crosby

commit sha db4537e43de82f7413c14504195d736c11dd93d4

Merge pull request #3821 from fuweid/cherry-pick-3819-1.2 [release/1.2] snapshots: return error if readSnapshot fails

view details

push time in 9 days

PR merged containerd/containerd

[release/1.2] snapshots: return error if readSnapshot fails

Signed-off-by: Wei Fu fuweid89@gmail.com (cherry picked from commit 843423ec3887eb47ac70308cee9267ef6a1fa435) Signed-off-by: Wei Fu fuweid89@gmail.com

from #3819

+1 -1

2 comments

1 changed file

fuweid

pr closed time in 9 days

push eventcontainerd/containerd

Wei Fu

commit sha e19c621d0d41f98f15987181bf4b078cf56ef94d

snapshots: return error if readSnapshot fails Signed-off-by: Wei Fu <fuweid89@gmail.com> (cherry picked from commit 843423ec3887eb47ac70308cee9267ef6a1fa435) Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

Michael Crosby

commit sha b5ede206a4e359b4e80dc8d809bc39b2635e0e08

Merge pull request #3822 from fuweid/cherry-pick-3819-1.3 [release/1.3] snapshots: return error if readSnapshot fails

view details

push time in 9 days

PR merged containerd/containerd

[release/1.3] snapshots: return error if readSnapshot fails

Signed-off-by: Wei Fu fuweid89@gmail.com (cherry picked from commit 843423ec3887eb47ac70308cee9267ef6a1fa435) Signed-off-by: Wei Fu fuweid89@gmail.com

from #3819

+1 -1

3 comments

1 changed file

fuweid

pr closed time in 9 days

startedswaywm/sway

started time in 9 days

push eventcontainerd/containerd

Shiwei Zhang

commit sha 5bf2c6fc25ad321b89f6d6fbad850276871d05f2

Fix panic on reference.Spec.Hostname() Signed-off-by: Shiwei Zhang <shizh@microsoft.com>

view details

Michael Crosby

commit sha 08d4231f57c99796dde5d00b6dae659b6ca93844

Merge pull request #3818 from shizhMSFT/fix_ref Fix panic on reference.Spec.Hostname()

view details

push time in 10 days

more