containerd/ttrpc 192
GRPC for low-memory environments
A transport-agnostic, filesystem metadata manifest system
Implementation of containerd shim using wasm
A release tool for generating detailed release notes
Docker Storage Driver Benchmarks and Tests
Create your PHP extension in C++, in a minute.
Python interface to Amazon Web Services
File system notification for Go
Docker - the open-source application container engine
Universal Command Line Interface for Amazon Web Services
issue commentopencontainers/distribution-spec
Spec seems to be missing cross-repo mounting entirely
Next to regular blob push. Used when initiating a new upload
comment created time in 19 minutes
Pull request review commentopencontainers/distribution-spec
If the manifest is not found in the registry, the response code MUST be `404 Not ##### Pulling Blobs To pull a blob, perform a `GET` request to a url in the following form:-[2a](#Endpoints) `/v2/<name>/blobs/<digest>`+[end-2](#endpoints) `/v2/<name>/blobs/<digest>` `<name>` is the namespace of the repository, and `<digest>` is the blob's digest. -A GET request to an existing blob URL MUST provide the expected blob, with a reponse code that MUST be `200 OK`.+A GET request to an existing blob URL MUST provide the expected blob, with a response code that MUST be `200 OK`. If the blob is not found in the registry, the response code MUST be `404 Not Found`. #### Push-Pushing an image works in the opposite order as a pull: the blobs making up the layers are pushed first, and the-manifest last.+Pushing an artifact typically works in the opposite order as a pull: the blobs making up the artifact are uploaded first, and the+manifest last. However, this order is not required, and you MAY upload content to the registry in any order.
Looks good, but seems it should replace rather than add
comment created time in a day
issue commentopencontainers/distribution-spec
Spec seems to be missing cross-repo mounting entirely
I think the omission is intentional, as mounting isn't fully worked out for 1.0 release.
I don't think that is accurate. Mounting is fully defined and regularly used today, I haven't heard of any aspect of it that was considered to be in-progress.
comment created time in a day
pull request commentopencontainers/go-digest
Replace travis with GH Actions
I might separate the addition of Github actions from the removal of Travis. Since this PR is showing neither running. I'm not sure if other opencontainers projects have moved to actions
comment created time in a day
push eventopencontainers/go-digest
commit sha fd8c1562bf8c524f0551ba45b2c7434b80b7f274
TestParseDigest: add tests for some potential corner-cases Also uses sub-tests, so that all test-cases are ran, even if one fails. Signed-off-by: Sebastiaan van Stijn <[email protected]>
commit sha f08b7a39250c234d83bcbf4c6e46da1576b8a557
Merge pull request #57 from thaJeztah/add_moar_test TestParseDigest: add tests for some potential corner-cases
push time in a day
PR merged opencontainers/go-digest
Also uses sub-tests, so that all test-cases are ran, even if one fails.
pr closed time in a day
push eventcontainerd/continuity
commit sha 5b95d2d4f17b34540302493d356909527f50c785
GH Actions: test against Go 1.15 Signed-off-by: Sebastiaan van Stijn <[email protected]>
commit sha aaa88831d126106ba0ab769e36782be341632b52
Merge pull request #160 from thaJeztah/test_go_1.15 GH Actions: test against Go 1.15
push time in a day
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-node-e2e
comment created time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/retest
comment created time in 3 days
push eventdmcgowan/containerd
commit sha 65df8db2896e6a9f4352bc65bedb4a580b057a66
Remove sudo from installation and cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
push eventdmcgowan/containerd
commit sha 4e0b13544ee9aaa77699d8799b17e99dcffdd407
Update CRI tests to build and push to gcs This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
commit sha 863377a78f953c3fe13e752cf7ab75bbf3b072f1
Remove sudo from installation and cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
push eventdmcgowan/containerd
commit sha 0c0613d73af4bf9b7de3f9e0086fe264e7341cfa
Update CRI tests to build and push to gcs This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
commit sha e1f0951659811852b3bb87e9ee7a6a1bac5c3b9c
Remove sudo from installation and cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
push eventdmcgowan/containerd
commit sha 24bd238fcf3f26b7090d309786b93ae2e1da3abb
Remove sudo from installation and cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
created tagdmcgowan/containerd
An open and reliable container runtime, by Docker
created time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
push eventdmcgowan/containerd
commit sha 724d59b4586ec18d6c0fc045db1da076383dd388
Update CRI tests to build and push to gcs This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
push eventdmcgowan/containerd
commit sha a255f27c9e9a0ac06ce3af8954f3e41557ecadc8
Update CRI tests to build and push to gcs This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
push eventdmcgowan/containerd
commit sha 8f3fb4bbfb37c57c0b849f596edd6ecfeb687f2e
Update CRI tests to build and push to gcs This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
pull request commentcontainerd/containerd
Update CRI tests to build and push to gcs
/test pull-containerd-build
comment created time in 3 days
PR opened containerd/containerd
This enables to the CRI e2e tests to use the build from a PR
WIP: for testing
pr created time in 3 days
push eventdmcgowan/containerd
commit sha f7dbbdc9c784ea6322c5185d4344135bc1c95b84
Update CRI tests to build and push to gcs This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
push eventdmcgowan/containerd
commit sha ec9e3f34399fdda441523723303403e93e62f8da
Update CRI tests to build and push to gcs This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
push time in 3 days
push eventcontainerd/containerd
commit sha 281069cbb57bf73a88b45808c75cf32e22658111
Set 1.2.x end of life date in RELEASES.md The maintainers discussed extending the end of life date for 1.2 to allow time for EOL announcement and migration to 1.3. Signed-off-by: Derek McGowan <[email protected]>
commit sha ce4439a8151f77dc50adb655ab4852ee9c366589
Merge pull request #4582 from dmcgowan/set-1.2-EOL-date Set 1.2.x end of life date to October 15
push time in 4 days
PR merged containerd/containerd
The maintainers discussed extending the end of life date for 1.2 to allow time for EOL announcement and migration to 1.3.
pr closed time in 4 days
PR opened containerd/containerd
The maintainers discussed extending the end of life date for 1.2 to allow time for EOL announcement and migration to 1.3.
pr created time in 4 days
push eventdmcgowan/containerd
commit sha 281069cbb57bf73a88b45808c75cf32e22658111
Set 1.2.x end of life date in RELEASES.md The maintainers discussed extending the end of life date for 1.2 to allow time for EOL announcement and migration to 1.3. Signed-off-by: Derek McGowan <[email protected]>
push time in 4 days
Pull request review commentopencontainers/distribution-spec
For relevant details and a history leading up to this specification, please see Several terms are used frequently in this document and warrant basic definitions: - **Registry**: a service that handles the required APIs defined in this specification-- **Client**: a tool that communicates with registries-- **Push**: the act of uploading blobs and manifests to a registry-- **Pull**: the act of downloading blobs and manifests from a registry-- **Blob**: the binary form of content that is stored by a registry, addressable by a digest-- **Manifest**: a JSON document which defines an artifact. Manifests are defined under the [OCI Image Spec](https://github.com/opencontainers/image-spec/blob/master/manifest.md)-- **Config**: a section in the manifest (and associated blob) which contains artifact metadata-- **Artifact**: one conceptual piece of content stored as blobs with an accompanying manifest containing a config-- **Digest**: a unique identifier created from a cryptographic hash of a blob's content. Digests are defined under the [OCI Image Spec](https://github.com/opencontainers/image-spec/blob/master/descriptor.md)-- **Tag**: a custom, human-readable manifest identifier+- **Client**: a tool that communicates with Registries+- **Push**: the act of uploading Blobs and Manifests to a Registry+- **Pull**: the act of downloading Blobs and Manifests from a Registry+- **Blob**: the binary form of content that is stored by a Registry, addressable by a Digest+- **Manifest**: a JSON document which defines an Artifact. Manifests are defined under the OCI Image Spec ([apdx-2](#appendix))+- **Config**: a section in the Manifest (and associated Blob) which contains Artifact metadata+- **Artifact**: one conceptual piece of content stored as Blobs with an accompanying Manifest containing a Config+- **Digest**: a unique identifier created from a cryptographic hash of a Blob's content. Digests are defined under the OCI Image Spec ([apdx-3](#appendix))+- **Tag**: a custom, human-readable Manifest identifier++## Notational Conventions -## Scope+The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" are to be interpreted as described in [RFC 2119](http://tools.ietf.org/html/rfc2119) (Bradner, S., "Key words for use in RFCs to Indicate Requirement Levels", BCP 14, RFC 2119, March 1997). -This specification covers URL layout and protocols for interaction between a registry and registry client.-Registry implementations MAY implement other API endpoints, but they are not covered by this specification.+## Use Cases -This specification includes the following features:+TODO: more detail on workflows related -- Namespace-oriented URI Layout-- PUSH/PULL registry server for V2 image manifest format-- Resumable layer PUSH support-- V2 Client (Consumer) requirements+### Artifact Verification -### Future+A container engine would like to run verified image named "library/ubuntu", with the tag "latest".+The engine contacts the registry, requesting the manifest for "library/ubuntu:latest".+An untrusted registry returns a manifest.+Before proceeding to download the individual layers, the engine verifies the manifest's signature, ensuring that the content was produced from a trusted source and no tampering has occurred.+After each layer is downloaded, the engine verifies the digest of the layer, ensuring that the content matches that specified by the manifest. -The following is an incomplete list of features, discussed during the process of cutting this specification, which MAY be out of the scope of this specification, MAY be the purview of another specification, or MAY be deferred to a future version:+### Resumable Push -- Authentication and authorization support: While authentication and authorization support will influence this specification, those details MAY be left to a future specification. However, relevant header definitions and error codes are present to provide an indication of what a client MAY encounter.-- Immutable image references-- Multiple architecture support-- Migration from v2compatibility representation+Company X's build servers lose connectivity to a distribution endpoint before completing an artifact layer transfer.+After connectivity returns, the build server attempts to re-upload the artifact.+The registry notifies the build server that the upload has already been partially attempted.+The build server responds by only sending the remaining data to complete the artifact file. -## Conformance-TODO: add general text about artifact validation requirements+### Resumable Pull -### Notational Conventions+Company X is having more connectivity problems but this time in their deployment datacenter.+When downloading an artifact, the connection is interrupted before completion.+The client keeps the partial data and uses http `Range` requests to avoid downloading repeated data. -The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" are to be interpreted as described in [RFC 2119](http://tools.ietf.org/html/rfc2119) (Bradner, S., "Key words for use in RFCs to Indicate Requirement Levels", BCP 14, RFC 2119, March 1997).+### Layer Upload De-duplication++Company Y's build system creates two identical layers from build processes A and B.+Build process A completes uploading the layer before B.+When process B attempts to upload the layer, the registry indicates that its not necessary because the layer is already known.++If process A and B upload the same layer at the same time, both operations will proceed and the first to complete will be stored in the registry (Note: we MAY modify this to prevent dogpile with some locking mechanism).
This note part seems odd to me. Maybe mention that the registry may securely only store one copy of the layer since the computed digests match, even though both upload are accepted.
comment created time in 4 days
Pull request review commentopencontainers/distribution-spec
If the manifest is not found in the registry, the response code MUST be `404 Not ##### Pulling Blobs To pull a blob, perform a `GET` request to a url in the following form:-[2a](#Endpoints) `/v2/<name>/blobs/<digest>`+[end-2](#endpoints) `/v2/<name>/blobs/<digest>` `<name>` is the namespace of the repository, and `<digest>` is the blob's digest. -A GET request to an existing blob URL MUST provide the expected blob, with a reponse code that MUST be `200 OK`.+A GET request to an existing blob URL MUST provide the expected blob, with a response code that MUST be `200 OK`. If the blob is not found in the registry, the response code MUST be `404 Not Found`. #### Push-Pushing an image works in the opposite order as a pull: the blobs making up the layers are pushed first, and the-manifest last.+Pushing an artifact typically works in the opposite order as a pull: the blobs making up the artifact are uploaded first, and the+manifest last. However, this order is not required, and you MAY upload content to the registry in any order.
We should be careful here. If we say the content MAY be uploaded in any order, then should mention that a registry MAY reject manifests referring to content which has not yet been uploaded
comment created time in 4 days
Pull request review commentcontainerd/containerd
Move CRI release logic to Makefile
releases/$(RELEASE).tar.gz: $(BINARIES) @tar -czf releases/$(RELEASE).tar.gz -C releases/$(RELEASE) bin @rm -rf releases/$(RELEASE) -release: $(BINARIES) releases/$(RELEASE).tar.gz+release: releases/$(RELEASE).tar.gz @echo "$(WHALE) $@" @cd releases && sha256sum $(RELEASE).tar.gz >$(RELEASE).tar.gz.sha256sum +ifeq ($(GOOS),windows)+install-cri-deps: $(BINARIES)+ mkdir -p $(CRIDIR)+ DESTDIR=$(CRIDIR) script/setup/install-cni-windows+ cp bin/* $(CRIDIR)+else+install-cri-deps: $(BINARIES)+ @sudo rm -rf ${CRIDIR}+ @sudo install -d ${CRIDIR}/usr/local/bin+ @sudo install -D -m 755 bin/* ${CRIDIR}/usr/local/bin+ @sudo install -d ${CRIDIR}/opt/containerd/cluster+ @sudo cp -r contrib/gce ${CRIDIR}/opt/containerd/cluster/+ @sudo install -d ${CRIDIR}/etc/systemd/system+ @sudo install -m 644 containerd.service ${CRIDIR}/etc/systemd/system+ echo "CONTAINERD_VERSION: '$(VERSION:v%=%)'" | sudo tee ${CRIDIR}/opt/containerd/cluster/version++ DESTDIR=$(CRIDIR) USESUDO=true script/setup/install-runc+ DESTDIR=$(CRIDIR) script/setup/install-cni+ DESTDIR=$(CRIDIR) script/setup/install-critools++ @sudo install -d $(CRIDIR)/bin+ @sudo install $(BINARIES) $(CRIDIR)/bin+endif++ifeq ($(GOOS),windows)+releases/$(CRIRELEASE).tar.gz: install-cri-deps+ @echo "$(WHALE) $@"+ @cd $(CRIDIR) && tar -czf ../../releases/$(CRIRELEASE).tar.gz *++releases/$(CRICNIRELEASE).tar.gz: install-cri-deps+ @echo "$(WHALE) $@"+ @cd $(CRIDIR) && tar -czf ../../releases/$(CRICNIRELEASE).tar.gz *+else+releases/$(CRIRELEASE).tar.gz: install-cri-deps+ @echo "$(WHALE) $@"+ @tar -czf releases/$(CRIRELEASE).tar.gz -C $(CRIDIR) etc/crictl.yaml etc/systemd usr opt/containerd++releases/$(CRICNIRELEASE).tar.gz: install-cri-deps+ @echo "$(WHALE) $@"+ @tar -czf releases/$(CRICNIRELEASE).tar.gz -C $(CRIDIR) etc usr opt+endif++cri-release: releases/$(CRIRELEASE).tar.gz+ @echo "$(WHALE) $@"+ @cd releases && sha256sum $(CRIRELEASE).tar.gz >$(CRIRELEASE).tar.gz.sha256sum++cri-cni-release: releases/$(CRICNIRELEASE).tar.gz+ @echo "$(WHALE) $@"+ @cd releases && sha256sum $(CRICNIRELEASE).tar.gz >$(CRICNIRELEASE).tar.gz.sha256sum+ clean: ## clean up binaries @echo "$(WHALE) $@" @rm -f $(BINARIES)+ @rm -rf _output
Updated here and uses sudo when it exists to remove since it gets created with sudo.
comment created time in 5 days
Pull request review commentcontainerd/containerd
Move CRI release logic to Makefile
BINARIES=$(addprefix bin/,$(COMMANDS)) TESTFLAGS ?= $(TESTFLAGS_RACE) $(EXTRA_TESTFLAGS) TESTFLAGS_PARALLEL ?= 8 -.PHONY: clean all AUTHORS build binaries test integration generate protos checkprotos coverage ci check help install uninstall vendor release mandir install-man genman+CRIDIR=$(ROOTDIR)_output/cri
it does, updated to use join to create the output dir
comment created time in 5 days
push eventdmcgowan/containerd
commit sha f35f21dd0bd507b3caf371fed26e9f51e16c5225
Add CRI release functionality to makefile Signed-off-by: Derek McGowan <[email protected]>
commit sha 241be70250b4cde1b84f5720dec19410c57d4821
Move github releases to use Makefile for cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 5 days
Pull request review commentcontainerd/containerd
Move CRI release logic to Makefile
jobs: name: containerd-binaries-${{ matrix.os }} path: src/github.com/containerd/containerd/*.tar.gz* - - name: Install cri-containerd dependencies+ - name: Make cri-containerd tar shell: bash env: RUNC_FLAVOR: runc- DESTDIR: ${{ github.workspace }}/cri-release run: |- mkdir ${DESTDIR} if [[ "${OS}" == "linux" ]]; then- sudo install -d ${DESTDIR}/usr/local/bin- sudo install -D -m 755 bin/* ${DESTDIR}/usr/local/bin- sudo install -d ${DESTDIR}/opt/containerd/cluster- sudo cp -r contrib/gce ${DESTDIR}/opt/containerd/cluster/- sudo install -d ${DESTDIR}/etc/systemd/system- sudo install -m 644 containerd.service ${DESTDIR}/etc/systemd/system- echo "CONTAINERD_VERSION: '${RELEASE_VER#v}'" | sudo tee ${DESTDIR}/opt/containerd/cluster/version- sudo PATH=$PATH script/setup/install-seccomp
seccomp is an environment dependency for build rather than a package which gets built along with the release. It doesn't make sense to have the makefile install this since it may already be installed in the environment in some other way.
comment created time in 5 days
push eventdmcgowan/containerd
commit sha a08e6929a9c2fb97423a50e5a7cb5fbe565fdf46
Add CRI release functionality to makefile Signed-off-by: Derek McGowan <[email protected]>
commit sha afcc448da23c300521ec3150fda4fa4226b403b6
Move github releases to use Makefile for cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 5 days
PR opened containerd/containerd
Allows building the cri-release package outside of the github action. This is also much simpler than the cri-release which was recently removed as it uses the locally built binaries and scripts which are now in containerd/containerd.
Verified Github release changes at https://github.com/dmcgowan/containerd/runs/1153643111
pr created time in 5 days
push eventdmcgowan/containerd
commit sha df419c5e28c01cc9f912be533111e44d5e5b1819
Add CRI release functionality to makefile Signed-off-by: Derek McGowan <[email protected]>
commit sha eef2262265315bc26b294576ed70166d296cc2b8
Move github releases to use Makefile for cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 5 days
push eventdmcgowan/containerd
commit sha 66d9a1dcff740cab392456481c39f2587d7e0d16
Add CRI release functionality to makefile Signed-off-by: Derek McGowan <[email protected]>
commit sha fe06ea924e1581e4fb48c0c7522d9891013d4f98
Move github releases to use Makefile for cri release Signed-off-by: Derek McGowan <[email protected]>
push time in 5 days
created tagdmcgowan/containerd
An open and reliable container runtime, by Docker
created time in 5 days
PR opened containerd/containerd
Remove related stale cri release files
Paving way to move Github actions cri release logic to Makefile
pr created time in 6 days
PR closed containerd/containerd
This PR add RegisterTCP method for existing services to support gRPC over TCP.
pr closed time in 7 days
pull request commentcontainerd/containerd
add RegisterTCP method for services
See https://github.com/containerd/containerd/issues/1324
If you have an issue with an existing use case, please open an issue describing the problem and solutions can be discussed there. This is intentionally not allowed today, so closing this for now.
comment created time in 7 days
pull request commentcontainerd/containerd
Set resolver to pull the image from next registry
More error handling logic needs to be done here to if expanding the status code which are handled. The logic of the for loop assumes that lastErr == nil at the end meant that either no registries were given or each registry returned a 404. For non-404 cases, lastErr should at least be set and used to indicate the first unexpected registry response.
comment created time in 8 days
issue commentcontainerd/containerd
@advancedwebdeveloper as a community project, we rely on contributions from the community to add support for other tools and projects needed by the community. This sort of change would need to be broken down into the changes which are needed to get it supported. We cannot make a judgement as to whether those changes would be accepted without knowing what they are. I suggest when opening an issue like this you break it down into individual issues which cause gollvm not to work today. Otherwise, at least provide a strong reason for supporting it such that someone else in the community will be motivated to take on the effort. Asking why is not about being skeptical here, it is about having open issues which can be tracked and progressed.
comment created time in 8 days
issue closedcontainerd/containerd
snapshotters: separate implementation pkg from plugin pkg
https://github.com/containerd/containerd/pull/4506 moved the plugin init from github.com/containerd/containerd/snapshots/overlay to "github.com/containerd/containerd/snapshots/overlay/plugin.
We should do this for all the plugins.
- [x] aufs: https://github.com/containerd/containerd/pull/4533
- [x] btrfs
- [X] devicemapper: https://github.com/containerd/containerd/pull/4573
- [x] native
- [X] overlay: https://github.com/containerd/containerd/pull/4506
- [x] zfs: https://github.com/containerd/containerd/pull/4534
closed time in 10 days
AkihiroSuda
push eventcontainerd/containerd
commit sha 96f4ce4a5c24745efc9596975b885be30101a5f4
zfs: seperate implementation pkg from plugin pkg and revendor Signed-off-by: Siddharth Yadav <[email protected]>
commit sha 438c87b8e0504623429cb0ed16ca506fb268c6a9
Merge pull request #4534 from sedflix/zfs-root-path zfs: seperate implementation pkg from plugin pkg
push time in 10 days
PR merged containerd/containerd
It solves a the zfs part of containerd/containerd#4514 and containerd/containerd#4513.
https://github.com/containerd/zfs/pull/31 needs to merged along with this.
Signed-off-by: Siddharth Yadav [email protected]
pr closed time in 10 days
push eventcontainerd/containerd
commit sha 30615c6fed24457e8b60eecd1e1982c5f27f9fda
testing out k8s prow test move Signed-off-by: Mike Brown <[email protected]>
commit sha fc2240915a6c0f3eed67ab00c95ecdb872fa95cf
Merge pull request #4527 from mikebrow/prow-test-pr k8s cri prow build test
push time in 10 days
PR merged containerd/containerd
don't merge test only
Signed-off-by: Mike Brown [email protected]
pr closed time in 10 days
pull request commentkubernetes/test-infra
Add containerd to managed_webhooks
cla should be good now
comment created time in 11 days
PR opened kubernetes/test-infra
Use managed webhooks for containerd/containerd
containerd/cri already has a manually created webhook here. Going forward we only intend to add containerd/containerd and not other under the containerd org.
@dims @dmcgowan @fejta
pr created time in 11 days
create barnchdmcgowan/test-infra
branch : add-containerd-managed-webhook
created branch time in 11 days
PR opened containerd/containerd.io
v1.4.1 is the most recent release
pr created time in 12 days
push eventcontainerd/containerd
commit sha 97d690d20a975bf0ab83d02f94c09483c53cb07a
Prepare v1.4.1 release Signed-off-by: Derek McGowan <[email protected]>
commit sha c623d1b36f09f8ef6536a057bd658b3aa8632828
Merge pull request #4564 from dmcgowan/prepare-1.4.1 Prepare v1.4.1 release
push time in 13 days
PR merged containerd/containerd
Notes preview https://gist.github.com/dmcgowan/4aba9f29890a5576340568cb9480f439
pr closed time in 13 days
pull request commentcontainerd/containerd
Updated, simplified the notable updates
Can we cherry-pick Go 1.15
Let's wait a bit on this on, I think we should be very cautious about updating the major go version in our stable releases. We will need to in 1.4.x at some point though.
comment created time in 13 days
push eventdmcgowan/containerd
commit sha 97d690d20a975bf0ab83d02f94c09483c53cb07a
Prepare v1.4.1 release Signed-off-by: Derek McGowan <[email protected]>
push time in 13 days
Pull request review commentcontainerd/containerd
+# commit to be tagged for new release+commit = "HEAD"++project_name = "containerd"+github_repo = "containerd/containerd"+match_deps = "^github.com/(containerd/[a-zA-Z0-9-]+)$"++# previous release+previous = "v1.4.0"++pre_release = false++preface = """\+The first patch release for `containerd` 1.4 includes a fix for v1 shims hanging+on exit and exec when the log pipe fills up along with other minor changes.++### Notable Updates++* Always consume shim logs to prevent logs in the shim from blocking [containerd/containerd#4546](https://github.com/containerd/containerd/pull/4546)+* Update CNI Dependencies [containerd/containerd#4555](https://github.com/containerd/containerd/pull/4555)
Actually probably just remove this section as I don't see a specific reason it was backported in the first place. Just didn't quite make the cutoff. The dependencies changes should show up at the bottom, I'll see if I can get that fixed.
comment created time in 13 days
Pull request review commentcontainerd/containerd
+# commit to be tagged for new release+commit = "HEAD"++project_name = "containerd"+github_repo = "containerd/containerd"+match_deps = "^github.com/(containerd/[a-zA-Z0-9-]+)$"++# previous release+previous = "v1.4.0"++pre_release = false++preface = """\+The first patch release for `containerd` 1.4 includes a fix for v1 shims hanging+on exit and exec when the log pipe fills up along with other minor changes.++### Notable Updates++* Always consume shim logs to prevent logs in the shim from blocking [containerd/containerd#4546](https://github.com/containerd/containerd/pull/4546)+* Update CNI Dependencies [containerd/containerd#4555](https://github.com/containerd/containerd/pull/4555)+* Ignore `ErrNotExist` when removing rootfs in v2 bundle directory [containerd/containerd#4472](https://github.com/containerd/containerd/pull/4472)+* Fix metrics monitoring of v2 runtime tasks [containerd/containerd#4486](https://github.com/containerd/containerd/pull/4486)+* Fix incorrect stat for Windows containers [containerd/containerd#4468](https://github.com/containerd/containerd/pull/4468)+* Fix devmapper device deletion on rollback [containerd/containerd#4437](https://github.com/containerd/containerd/pull/4437)+* Seccomp default profile updates+ * Add `openat2` (new in Linux 5.6) and `faccessat2` syscalls [containerd/containerd#4481](https://github.com/containerd/containerd/pull/4481)+ * Move the syslog syscall to be gated by CAP_SYS_ADMIN or CAP_SYSLOG [containerd/containerd#4491](https://github.com/containerd/containerd/pull/4491)+ * Add and update profile [containerd/containerd#4492](https://github.com/containerd/containerd/pull/4492)
This section is already bordering lining on too much information, was thinking maybe collapsing even more and just mentioning seccomp default profile updates and having multiple links
comment created time in 13 days
PR opened containerd/containerd
Notes preview https://gist.github.com/dmcgowan/4aba9f29890a5576340568cb9480f439
pr created time in 14 days
pull request commentcontainerd/containerd
Enable client to control labels of schema1 manifests
I don't think this is necessary, schema 1 has been deprecated for awhile now. I think we should stick to reactive changes for schema1, and only make changes when someone demonstrates a strong need for it and situation where their images cannot switch to schema2. If we need this change under that situation, we should avoid adding an exported function to the images package for this and just copy needed code to schema1.
comment created time in 17 days
PR opened containerd/containerd
These fifos fill up if unconsumed, so always consume them.
Backport of #4546
pr created time in 17 days
Pull request review commentcontainerd/containerd
runtime/v2: cleanup dead shim before delete bundle
github.com/containerd/continuity efbc4488d8fe1bdc16bde3b2d299 github.com/containerd/fifo f15a3290365b9d2627d189e619ab4008e0069caf github.com/containerd/go-runc 7016d3ce2328dd2cb1192b2076ebd565c4e8df0c github.com/containerd/nri 0afc7f031eaf9c7d9c1a381b7ab5462e89c998fc-github.com/containerd/ttrpc v1.0.1+github.com/containerd/ttrpc 079556c0a5f85bed5aeeaaf9e9e298af09b30c6c
We should tag this
comment created time in 17 days
push eventcontainerd/containerd
commit sha f247618a3663dfbd6d731647ad2fd48add96c4b8
Report correct stats for windows containers Windows container stats were reporting incorrect metrics for cpu kernel runtime. Signed-off-by: Prashant Bhutani <[email protected]> (cherry picked from commit 35b63c064ff040727e685fdcc188a99de67136b6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
commit sha ea29a60a9e55aa6b09bb27482988f7455498c63e
Merge pull request #4558 from thaJeztah/1.4_backport_winstats [release/1.4 backport] Report correct stats for windows containers
push time in 17 days
PR merged containerd/containerd
backport of https://github.com/containerd/containerd/pull/4468
Windows container stats were reporting incorrect metrics for cpu kernel runtime.
Signed-off-by: Prashant Bhutani [email protected] (cherry picked from commit 35b63c064ff040727e685fdcc188a99de67136b6) Signed-off-by: Sebastiaan van Stijn [email protected]
pr closed time in 17 days
push eventcontainerd/containerd
commit sha cc5d1518fa00f429be4c8d06845bef6348534e14
Update go list to respect build tags This prevents packages with no Go included files due to build constraints being included in the package list. These packages cause the test command to fail with "can't load package build constraints exclude all Go files". Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit 3275a216fd3bc3a86ecf84981323290d1ec5b146) Signed-off-by: Sebastiaan van Stijn <[email protected]>
commit sha db931948050b536732cf024ebe7feacb2910ce1a
Merge pull request #4557 from thaJeztah/1.4_backport_makefile_test_tags [release/1.4 backport] Update go list to respect build tags
push time in 17 days
PR merged containerd/containerd
backport of https://github.com/containerd/containerd/pull/4490
This prevents packages with no Go included files due to build constraints being included in the package list. These packages cause the test command to fail with "can't load package build constraints exclude all Go files".
Signed-off-by: Derek McGowan [email protected] (cherry picked from commit 3275a216fd3bc3a86ecf84981323290d1ec5b146) Signed-off-by: Sebastiaan van Stijn [email protected]
pr closed time in 17 days