profile
viewpoint
Zuhayr Elahi zelahi Docker United States Software Engineer

startedtinyci/tinyci

started time in 3 hours

push eventdocker/docker-ce-packaging

Yves Brissaud

commit sha 69bf86766b3b77bdb6487725d5a526c7c922eab1

bump docker-app to 0.9.0-beta1 Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>

view details

Zuhayr Elahi

commit sha 2725cc366491ff5d7702b603ac779f4bf6ff8604

Merge pull request #407 from eunomie/docker-app-0.9.0-beta-1 bump docker-app to 0.9.0-beta1

view details

push time in a day

Pull request review commentdocker/compose

Show uptime docker compose

 def ps(self, options):                     command,                     container.human_readable_state,                     container.human_readable_ports,+                    container.human_readable_uptime,

Ahh I believe I just missed it. I didn't use the curl command and actually used the values I saw when I did a docker inspect <container_name>. I'll go ahead and fix it so we use Status instead. Thanks for the feedback!! =)

zelahi

comment created time in 6 days

PR opened docker/compose

Fixed broken README link for common use cases

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

<!-- Welcome to the docker-compose issue tracker, and thank you for your interest in contributing to the project! Please make sure you've read the guidelines in CONTRIBUTING.md before submitting your pull request. Contributions that do not comply and contributions with failing tests will not be reviewed! -->

<!-- Please make sure an issue describing the problem the PR is trying to solve exists, or create it before submitting a PR. The maintainers will validate if the issue should be addressed or if it is out of scope for the project. --> Resolves #6926

Just a small link error that should get fixed

+1 -1

0 comment

1 changed file

pr created time in 7 days

create barnchzelahi/compose

branch : fix-readme-link

created branch time in 7 days

pull request commentdocker/docker-install

rootless: support channels (stable/nightly)

Merged. Ty for the PR @AkihiroSuda

AkihiroSuda

comment created time in 8 days

PR merged docker/docker-install

rootless: support channels (stable/nightly)

The default channel is set to "stable".

The latest stable version is currently hardcoded in the script.

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

+27 -7

6 comments

1 changed file

AkihiroSuda

pr closed time in 8 days

push eventdocker/docker-install

Akihiro Suda

commit sha ad81e227deb668bc2d00c9792da53eae07cadbc8

rootless: support channels (stable/nightly) The default channel is set to "stable". The latest stable version is currently hardcoded in the script. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Zuhayr Elahi

commit sha 7eceb48d98eb2bd6288257e077763f9bb7679701

Merge pull request #146 from AkihiroSuda/support-channel rootless: support channels (stable/nightly)

view details

push time in 8 days

Pull request review commentlocalstack/localstack

ADDED an env variable to the docker compose file

-version: '2.1'+version: '3.0'

no problem! If it props again feel free to message and I can try and take a look!

zelahi

comment created time in 15 days

pull request commentlocalstack/localstack

ADDED an env variable to the docker compose file

@whummer not a problem. I addressed all the comments. Let me know if there is anything else you guys might need

zelahi

comment created time in 15 days

Pull request review commentlocalstack/localstack

ADDED an env variable to the docker compose file

-version: '2.1'+version: '3.0'

Done! I didn't realize people were having issues. I am curious to see/hear what they are tho if you happen to have a reference?

zelahi

comment created time in 15 days

push eventzelahi/localstack

Zuhayr Elahi

commit sha 270e79a9bfa7db1aa505feb94b63f968b8f1cb06

Changed localstack version and renamed container_name Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 15 days

push eventzelahi/localstack

Zuhayr Elahi

commit sha aabc42f2b42e0b057f536f0ff4aa78569d155f05

Fixed compose file based on feedback Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 15 days

Pull request review commentlocalstack/localstack

ADDED an env variable to the docker compose file

-version: '2.1'+version: '3.0'  services:   localstack:+    container_name: "${LOCALSTACK_DOCKER_NAME}"

The think with local stack I feel is that everything seems to be running on one container. Also I believe the maintainers may have more insight, but do people tend to run multiple instances of localstack on one machine? I was assuming it might be too resource heavy?

zelahi

comment created time in 16 days

Pull request review commentlocalstack/localstack

ADDED an env variable to the docker compose file

+LOCALSTACK_DOCKER_NAME=localstack

Gotcha ty for the feedback! I'll go ahead and remove this

zelahi

comment created time in 16 days

issue commentlocalstack/localstack

Allow static naming of Local Stack's Docker container.

I apologize if I overstepped on anyone. I submitted a PR to help with this @whummer

brettcooper

comment created time in 16 days

PR opened localstack/localstack

ADDED an env variable to the docker compose file

Addresses #1113

Basically allow for the container to have a name when it is launched. Is it defined as an environment variable. The .env file is there as according to the documentation here: https://docs.docker.com/compose/environment-variables/

Variables listed in the .env file can be read in when the user runs docker-compose up

The last change made is that there is a newer spec for compose files which is shown here: https://docs.docker.com/compose/compose-file/#variable-substitution

So I went ahead and updated the specs for the docker-compose file to a later version

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

Please refer to the contribution guidelines in the README when submitting PRs.

+3 -1

0 comment

2 changed files

pr created time in 16 days

create barnchzelahi/localstack

branch : static-naming-docker-container

created branch time in 16 days

push eventzelahi/localstack

Zuhayr Elahi

commit sha c71e49bf97da3672a614c3325c1db29731b3b259

Fix port range for docker-compose (#1370)

view details

Florian Garcia

commit sha 718bf8228ed942b66e6e745073ad9373f6c19f32

Do not check topic existence for SMS using SNS (#1369)

view details

Waldemar Hummer

commit sha d1f67f8775eb18eb425152df987d2f8c9bd48890

fix CreateDate returned by IAM (#1373)

view details

Waldemar Hummer

commit sha aa27022a2aaaa31e9e53757a27d3b8e57a085b7d

fix response body for presigned URL S3 PUT requests (#1376)

view details

Waldemar Hummer

commit sha cd653d4c3475df335f1c84f16d71826a8525dd8d

Fix account IDs for cloudformation and SNS (#1377)

view details

Waldemar Hummer

commit sha 628b055c3f8c627752f6d510ac0ffbe6e6f511f1

fix command to push Docker image (#1378)

view details

Waldemar Hummer

commit sha 3150542e2c12b1385294e06dec89378c183135ee

add documentation for system architecture (#1379)

view details

Waldemar Hummer

commit sha b918f3282c8f78541992eee76e20951fe68549de

fix Docker bridge IP configuration (#1380)

view details

Mathew Power

commit sha 96041e99d0c4a86e9d61a26d35e6c3088f1459c8

add API Gateway SQS proxy (#1354)

view details

Gilbert Gilb's

commit sha 9c5a37c5630d92108002b9167347fc3d39c0469e

Fix corner-case with `LOCALSTACK_` prefix strip. (#1388)

view details

Waldemar Hummer

commit sha af6332e90aaba9db20ef9ec6ead08ca57728b464

Fix failing build in CI (#1406)

view details

Chad Greenburg

commit sha 1ba2b20a59a457430ad388e93b9cad8e00cbe521

Fix path to test_integration.py in README (#1405) Updating the path to the test_integration.py in the README

view details

Alex Tamoykin

commit sha 23036ef0513664c9f3e3252f22695739e532e114

Add some more UI clients to readme (#1413)

view details

Shane Andrade

commit sha 4cff5d707b6241fb58a37a9503175e00bed5fb6a

Kinesis throttling to return correct response code (#1407)

view details

Bendegúz Ács

commit sha ecb97fabd07f7cbe619992762cf29a2e16d62ec8

Fixed incorrect python executable used to start S3 (#1397)

view details

Bendegúz Ács

commit sha 2e0d398681e4793ca2ff9f880353d703015b1830

Fixed IAM requests sent with wrong account ID to moto (#1399)

view details

Omer Davutoglu

commit sha 1c5ce3bd69e81d24bc4b6502b000aca777be9b19

Parameterize-able CORS Headers (#1420)

view details

Waldemar Hummer

commit sha 214d75a79369f26ab694f8a9e6628873316bc8fc

release version 0.9.6 (#1422)

view details

Waldemar Hummer

commit sha 64bdb7e5fdd5827035fb407cb2ac3a9a2d824783

add API events (#1425)

view details

Waldemar Hummer

commit sha 6df1f039cf3b6c4b486fd0beeaf029cbe2635ac7

customize docker command (#1430)

view details

push time in 16 days

create barnchzelahi/compose

branch : add-err-msg-invalid-version

created branch time in a month

push eventzelahi/compose

Samuel Searles-Bryant

commit sha 672ced8742f517b7d7e17c50edd50f3748575a05

Change Formatter.table method to staticmethod Make this a staticmethod so it's easier to use without needing to init a Formatter object first. Signed-off-by: Samuel Searles-Bryant <samuel.searles-bryant@unipart.io>

view details

Zuhayr Elahi

commit sha 98d7cc8d0c8b884720579ad9a9dc944517fc042d

ADDED a stage for executing License Scans Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Dimitar Dimitrov

commit sha 475f8199f773936e2504c0977b970c2f9f432140

Fixing features broken link Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@docker.com>

view details

Lukas Hettwer

commit sha 32ac6edb862ba6d4f3bb8cb4869d8b2f0b27ca88

Fix --progress arg when run docker-compose build --progress is no longer processed as flag but as argument with value. Signed-off-by: Lukas Hettwer <lukas.hettwer@aboutyou.de> Resolve: [#6913]

view details

Ulysses Souza

commit sha 186aa6e5c3dc84f291f14e138bac75a14030832f

Merge pull request #6914 from lukas9393/6913-progress-arg Fix --progress arg when run docker-compose build

view details

Guillaume LOURS

commit sha 70f8e38b1dbc8d34e1af4274b7e3bc756f521f99

Add automatic labeling of bug, feature & question issues Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>

view details

Nicolas De loof

commit sha 5f2161cad98b60bb12dcfc5f3a207594b89e3fa1

Merge pull request #6912 from cranzy/fixing_broken_link Fixing features broken link

view details

Nicolas De loof

commit sha f9113202e83fcd7f5c91cd8878305357009e8c1e

Add automatic labeling of bug, feature & question issues (#6944) Add automatic labeling of bug, feature & question issues

view details

Nicolas De loof

commit sha 1f16a7929d52283aea7e9c343810c2d0e00017bd

Merge pull request #6864 from samueljsb/formatter_class Change Formatter.table method to staticmethod

view details

Nicolas De loof

commit sha 09acc5febfdf93f48cef5a2950799241d47e477d

[TAR-995] ADDED a stage for executing License Scans (#6875) [TAR-995] ADDED a stage for executing License Scans

view details

Aleksandr Mezin

commit sha 74f892de955759cbcead836780126850be488a36

Add test to verify same file 'extends' optimization Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>

view details

Aleksandr Mezin

commit sha c24b7b6464b302477728b0882d2fb6bf647f2e79

Fix same file 'extends' optimization Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>

view details

Nicolas De loof

commit sha 717284991307dbce9c0ca9c1693f3329493398bb

Fix "extends" same file optimization (#6425) Fix "extends" same file optimization

view details

Stefan Scherer

commit sha 79f29dda2370b7eec9942405d45541f1f569d0f9

Add dependencies for ARM build Signed-off-by: Stefan Scherer <scherer_stefan@icloud.com>

view details

Stefan Scherer

commit sha ce52f597a0f0a509912b91befe59991906391028

Enhance build script for different CPU architectures Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>

view details

Nicolas De loof

commit sha 6fe35498a562bcb1c3079676fc70a688d8cb0ed0

Add dependencies for ARM build (#6908) Add dependencies for ARM build

view details

Jean-Christophe Sirot

commit sha 37be2ad9cd54e61de07a43c14ca768b2d07da851

Remove set -x to make this script less verbose Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>

view details

Chris Crone

commit sha 8ebb1a6f19dad6fd20a071301bb460ee5c60003f

Merge pull request #6949 from jcsirot/fix-pushbin-script-verbosity Remove set -x to make this script less verbose

view details

Guillaume Lours

commit sha 9375c15bad6931be9cfadf198b2932f0079dc03c

Add config file for @probot/stale Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>

view details

Nicolas De loof

commit sha 29af1a84cafa12502486348b3b4edf042ce2a1a4

Merge pull request #6952 from glours/stale_configuration Add config file for @probot/stale

view details

push time in a month

PR opened docker/docker-ce-packaging

[TAR-1174][master] Turn Go11Module=off

Turn Go11Module=off for building on go version 1.13

+32 -8

0 comment

12 changed files

pr created time in a month

push eventzelahi/docker-ce-packaging

Zuhayr Elahi

commit sha c1a42f9f316e8588e082488882b711542a457e9d

Re-order common env variables Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in a month

create barnchzelahi/docker-ce-packaging

branch : go_modules_off

created branch time in a month

push eventzelahi/docker-ce-packaging

Zuhayr Elahi

commit sha c5b1aa84574491f6e5f07ee1a1e5380c0c37d4f8

realpath for plugins directory Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

docker-unir[bot]

commit sha 9ef9298d620163bb80c9e6128e1b05b1eab9c12c

Merge pull request #383 from zelahi/plugins-hard-link Merged with https://github.com/seemethere/unir

view details

Sebastiaan van Stijn

commit sha 7847c12a44ebd74d6342f9de60d112aea9d275cc

bump golang 1.12.10 (CVE-2019-16276) full diff: https://github.com/golang/go/compare/go1.12.9...go1.12.10 ``` Hi gophers, We have just released Go 1.13.1 and Go 1.12.10 to address a recently reported security issue. We recommend that all affected users update to one of these releases (if you're not sure which, choose Go 1.13.1). net/http (through net/textproto) used to accept and normalize invalid HTTP/1.1 headers with a space before the colon, in violation of RFC 7230. If a Go server is used behind an uncommon reverse proxy that accepts and forwards but doesn't normalize such invalid headers, the reverse proxy and the server can interpret the headers differently. This can lead to filter bypasses or request smuggling, the latter if requests from separate clients are multiplexed onto the same upstream connection by the proxy. Such invalid headers are now rejected by Go servers, and passed without normalization to Go client applications. The issue is CVE-2019-16276 and Go issue golang.org/issue/34540. Thanks to Andrew Stucki, Adam Scarr (99designs.com), and Jan Masarik (masarik.sh) for discovering and reporting this issue. Downloads are available at https://golang.org/dl for all supported platforms. Alla prossima, Filippo on behalf of the Go team ``` From the patch: https://github.com/golang/go/commit/6e6f4aaf70c8b1cc81e65a26332aa9409de03ad8 ``` net/textproto: don't normalize headers with spaces before the colon RFC 7230 is clear about headers with a space before the colon, like X-Answer : 42 being invalid, but we've been accepting and normalizing them for compatibility purposes since CL 5690059 in 2012. On the client side, this is harmless and indeed most browsers behave the same to this day. On the server side, this becomes a security issue when the behavior doesn't match that of a reverse proxy sitting in front of the server. For example, if a WAF accepts them without normalizing them, it might be possible to bypass its filters, because the Go server would interpret the header differently. Worse, if the reverse proxy coalesces requests onto a single HTTP/1.1 connection to a Go server, the understanding of the request boundaries can get out of sync between them, allowing an attacker to tack an arbitrary method and path onto a request by other clients, including authentication headers unknown to the attacker. This was recently presented at multiple security conferences: https://portswigger.net/blog/http-desync-attacks-request-smuggling-reborn net/http servers already reject header keys with invalid characters. Simply stop normalizing extra spaces in net/textproto, let it return them unchanged like it does for other invalid headers, and let net/http enforce RFC 7230, which is HTTP specific. This loses us normalization on the client side, but there's no right answer on the client side anyway, and hiding the issue sounds worse than letting the application decide. ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Andrew Hsu

commit sha e47f4337a3d5c6011821dc5f7601fdb0770dabc9

Merge pull request #385 from thaJeztah/bump_golang_1.12.10 bump golang 1.12.10 (CVE-2019-16276)

view details

Tibor Vass

commit sha 41dfc516cd50f570d6184aaad05b4efd4b04f4c3

plugins: pin buildx to v0.3.1 Signed-off-by: Tibor Vass <tibor@docker.com>

view details

docker-unir[bot]

commit sha 1a246e9444614e2b553e8becee1b8da641116631

Merge pull request #387 from tiborvass/buildx-update Merged with https://github.com/seemethere/unir

view details

Sebastiaan van Stijn

commit sha 689992da0be996f2ee74bf896a1eede1e70e0e22

plugins: remove (now) redundant .gitkeep Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Eli Uriegas

commit sha 4f26329b6190dabef36ec1b8a6b45570a3f00c12

plugins: remove (now) redundant .gitkeep (#390) plugins: remove (now) redundant .gitkeep

view details

Andrew Hsu

commit sha 235feeca78b4d032d2cd6ac82b16951520bf84e2

remove fedora 28 because it is eol End of life as of 2019-05-28: https://fedoramagazine.org/fedora-28-end-of-life/ Signed-off-by: Andrew Hsu <andrewhsu@docker.com>

view details

Eli Uriegas

commit sha 416672540b5ea4e79fdd558e0a9f7f3c2db2100f

Merge pull request #394 from andrewhsu/rm28 remove fedora 28 because it is eol

view details

push time in a month

push eventzelahi/compose

Zuhayr Elahi

commit sha fc368775a5da29bf8c77965ff184960dcee76169

UPDATED log message Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in a month

Pull request review commentdocker/compose

Log warning for docker-compose port binding not avaliable

 def start_container(self, container, use_network_aliases=True):         try:             container.start()         except APIError as ex:+            if "driver failed programming external connectivity" in ex.explanation:+                log.warn(+                    "Port is already in use, check the docker-compose file to see if the same" +

Ahh, okay, I can update the message. I was worried a bit about the approach I was taking here

zelahi

comment created time in a month

PR opened docker/compose

Log warning for docker-compose port binding not avaliable

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

<!-- Welcome to the docker-compose issue tracker, and thank you for your interest in contributing to the project! Please make sure you've read the guidelines in CONTRIBUTING.md before submitting your pull request. Contributions that do not comply and contributions with failing tests will not be reviewed! -->

<!-- Please make sure an issue describing the problem the PR is trying to solve exists, or create it before submitting a PR. The maintainers will validate if the issue should be addressed or if it is out of scope for the project. --> Resolves #6708

I added a warning at the bottom to let users know to check the compose file if this error occurs. It seems to only happen when the user runs docker-compose up but I believe this could be potentially how we solve this issue above

+4 -0

0 comment

1 changed file

pr created time in a month

create barnchzelahi/compose

branch : bind-port-error

created branch time in a month

push eventzelahi/compose

ulyssessouza

commit sha eca358e2f0583d6e85aedc58b45aaebfd38e55f0

Fix secret missing warning Signed-off-by: ulyssessouza <ulyssessouza@gmail.com>

view details

Guillaume LOURS

commit sha bc57a1bd542674613f3f1aea39b27a5efd8c73e3

Merge pull request #6925 from ulyssessouza/fix-secrets-warning-message Fix secret missing warning

view details

push time in a month

fork zelahi/hub

A command-line tool that makes git easier to use with GitHub.

https://hub.github.com/

fork in a month

push eventzelahi/tools

Zuhayr Elahi

commit sha da3fe069ec15e0e9eadd5289a0bbe60f1ec3b710

Gave credit where credit is due Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in a month

push eventzelahi/tools

Zuhayr Elahi

commit sha 1ddcce0d402cc3e87c472a489a452d577ae59aa6

Added a github Dockerfile Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in a month

startedtuvtran/project-based-learning

started time in 2 months

PR opened docker/docker-ce-packaging

[19.03] [backport changes] realpath for plugins directory

Cherry-picked from: https://github.com/docker/docker-ce-packaging/pull/383

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

+4 -2

0 comment

2 changed files

pr created time in 2 months

create barnchzelahi/docker-ce-packaging

branch : backport-plugins-dir-change

created branch time in 2 months

push eventzelahi/docker-ce-packaging

Zuhayr Elahi

commit sha c5b1aa84574491f6e5f07ee1a1e5380c0c37d4f8

realpath for plugins directory Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

PR opened docker/docker-ce-packaging

realpath for plugins directory

Used the realpath to get the plugins directory instead of readlink -e, since readlink was not working on mac os x

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

+2 -1

0 comment

1 changed file

pr created time in 2 months

create barnchzelahi/docker-ce-packaging

branch : plugins-hard-link

created branch time in 2 months

push eventzelahi/docker-ce-packaging

zelahi

commit sha 0df1091054f7749b6913d312b1d9a1fdefeddcc4

FIX pathing issue with cli dir

view details

Eli Uriegas

commit sha 356c85b80153eebf269fc6ae2e3dab4132b8d909

FIX pathing issue with cli dir (#368) FIX pathing issue with cli dir

view details

Sebastiaan van Stijn

commit sha 1310e3974e8193745ce70cd74a20ab9d2151b8ac

Pin Golang images to debian stretch variant Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Eli Uriegas

commit sha aab70bec656331cf4292cd2c25ffca6c20b9148a

Pin Golang images to debian stretch variant (#369) Pin Golang images to debian stretch variant

view details

Sebastiaan van Stijn

commit sha 9f5da37431039c9b2b6f2e281a0e4e53402ba148

Bump golang 1.12.8 (CVE-2019-9512, CVE-2019-9514) go1.12.8 (released 2019/08/13) includes security fixes to the net/http and net/url packages. See the Go 1.12.8 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.12.8 - net/http: Denial of Service vulnerabilities in the HTTP/2 implementation net/http and golang.org/x/net/http2 servers that accept direct connections from untrusted clients could be remotely made to allocate an unlimited amount of memory, until the program crashes. Servers will now close connections if the send queue accumulates too many control messages. The issues are CVE-2019-9512 and CVE-2019-9514, and Go issue golang.org/issue/33606. Thanks to Jonathan Looney from Netflix for discovering and reporting these issues. This is also fixed in version v0.0.0-20190813141303-74dc4d7220e7 of golang.org/x/net/http2. net/url: parsing validation issue - url.Parse would accept URLs with malformed hosts, such that the Host field could have arbitrary suffixes that would appear in neither Hostname() nor Port(), allowing authorization bypasses in certain applications. Note that URLs with invalid, not numeric ports will now return an error from url.Parse. The issue is CVE-2019-14809 and Go issue golang.org/issue/29098. Thanks to Julian Hector and Nikolai Krein from Cure53, and Adi Cohen (adico.me) for discovering and reporting this issue. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Andrew Hsu

commit sha 6a383e69416f480a449b4dc0ed2b433aeb6f4e9c

Merge pull request #370 from thaJeztah/bump_golang_1.12.8 Bump golang 1.12.8 (CVE-2019-9512, CVE-2019-9514)

view details

Sebastiaan van Stijn

commit sha 23508567bb64f434ff0a8796ee4d26195678fa80

Dockerfiles: remove unused GO_VERSION Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 3b8cc28c3f75526bcd4875ec8772d8655406e8e2

Makefile: set STATIC_VERSION only if empty Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha fe23576b64a9057a4a2d19ec0c71eb34df1f3fe4

Makefile: use include for common variables Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 2929c9b1e883db452e8b9014aaa3e085211d0ea8

Makefile: realpath engine-, cli-dir Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Eli Uriegas

commit sha d04287fb61feea7d373b0aff5c7d2067cdc06e90

Makefile: use an include file for common variables (#375) Makefile: use an include file for common variables

view details

Eli Uriegas

commit sha 16b78bef699c6db89a312d6f1e7674b91e874364

Dockerfiles: remove unused GO_VERSION (#374) Dockerfiles: remove unused GO_VERSION

view details

Jintao Zhang

commit sha cc3b9fb95181872ec6299e14434ceac1ae2122e1

Bump Golang 1.12.9 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>

view details

Sebastiaan van Stijn

commit sha 77878ffa489e0555bb3bf0dd14f9c3edbc6dad09

RPM spec: remove -ce suffix from distribution_based_engine JSON Noticed this failing in internal e2e tests on CentOS: ``` sudo docker engine activate --license /tmp/docker.lic unable to determine the installed engine version. Specify which engine image to update with --engine-image: open /var/lib/docker-engine/distribution_based_engine.json: no such file or directory ``` Looks lik 09b3ac888d8d6ab625e56a458f6bd6f72b1ba0c2 changed the name of this file from `distribution_based_engine-ce.json` to `distribution_based_engine.json` (without `-ce` suffix) for the `.deb` packages, but did not update the RPM packages accordingly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

docker-unir[bot]

commit sha 90265a754d0a142bafd87a6ec20d8d9cb8a0a586

Merge pull request #377 from tao12345666333/bump-go-1.12.9 Merged with https://github.com/seemethere/unir

view details

Sebastiaan van Stijn

commit sha ffee8a345b3f1fc4d64de1a209f878ba2b860ba6

Pin buildx plugin to v0.3.0, and allow overriding Commit 9a5aabdaff9061343a6a28e809c14164dd04f39f removed the fixed version for this plugin, and changed it to install from "master", which made the build non-reproducible. This patch pins the plugin to a specific tag/release again, but allow overriding by setting the `BUILDX_COMMIT` env-var. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Andrew Hsu

commit sha 10eacb459118085dd70f7af6f1873369c1a9d230

Merge pull request #381 from thaJeztah/buildx_0.3.0 Pin buildx plugin to v0.3.0, and allow overriding

view details

Eli Uriegas

commit sha 940a2973c75b09c8e4052395e6406d546fa9a463

RPM spec: remove -ce suffix from distribution_based_engine JSON (#378) RPM spec: remove -ce suffix from distribution_based_engine JSON

view details

push time in 2 months

pull request commentdocker/app

Jenkinsfile: use --password-stdin

Yup, I re-triggered it. Tho I didn't do anything on the fossa side so I'm curious how it happened

thaJeztah

comment created time in 2 months

PR opened docker/compose

Show uptime docker compose

<!-- Welcome to the docker-compose issue tracker, and thank you for your interest in contributing to the project! Please make sure you've read the guidelines in CONTRIBUTING.md before submitting your pull request. Contributions that do not comply and contributions with failing tests will not be reviewed! -->

<!-- Please make sure an issue describing the problem the PR is trying to solve exists, or create it before submitting a PR. The maintainers will validate if the issue should be addressed or if it is out of scope for the project. --> Resolves #6867

Problem Statement: In this PR, we are reporting the output when the user executes docker-compose ps after launching containers via docker-compose up

Expected Output Screen Shot 2019-09-20 at 2 45 21 PM

Implementation Details I currently used the dateutils library and retrieved the uptimes from the container properties. After doing so, parsed them and displayed it in a human readable format. I added one unit test, but had trouble writing an unit test with the code path using datetime.now(). I didn't see any mocks, but I am open to suggestions and/or okay with reimplementing this without using pyzar and/or dateutils

+53 -0

0 comment

4 changed files

pr created time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha c77e97c419d43eeea736cdd0ff018fd790e5efe6

ADDED calculations for retrieving uptime Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 512ea184ccceb3c3c4e5b2c34ac2330309a2f649

ADDED calculations for retrieving uptime Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

create barnchzelahi/compose

branch : show-uptime-docker-compose

created branch time in 2 months

issue commentdocker/compose

Static check for duplicate port request in compose file

So I wasn't able to reproduce this using docker-run. The files I used for testing are here: https://github.com/zelahi/tools/blob/master/testing/compose-test/docker-compose.yml and these are the following scenarios I tested:

Scenario 1: Compose file has the same port mentioned twice:

Compose file:

version: '3'
services:
  web:
    build: .
    ports:
      - "5000:5000"
      - "5000:5000"
  redis:
    image: "redis:alpine"
  web_2:
    build: .
    ports:
      - "5000:5000"

Command ran: docker-compose run web

Output:

ERROR: The Compose file './docker-compose.yml' is invalid because:
services.web.ports value ['5000:5000', '5000:5000'] has non-unique elements

Scenario 2: Initially brought up web and redis then executed a docker-compose run on web_2:

Compose file:

version: '3'
services:
  web:
    build: .
    ports:
      - "5000:5000"
  redis:
    image: "redis:alpine"
  web_2:
    build: .
    ports:
      - "5000:5000"

Command ran:

     docker-compose run web_2

Output: No error, Everything ran without an issue

Scenario 3: Ran only docker-compose up:

Compose file:

version: '3'
services:
  web:
    build: .
    ports:
      - "5000:5000"
  redis:
    image: "redis:alpine"
  web_2:
    build: .
    ports:
      - "5000:5000"

Command ran: docker-compose up

Output:

ERROR: for web_2  Cannot start service web_2: driver failed programming external connectivity on endpoint compose-test_web_2_1 (46484da229527c513cdd1ab62d1de64dc00dfe37195d826ea8113015f56e54fe): Bind for 0.0.0.0:5000 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.

Scenario 4: Initially ran docker-compose up for web_1 and redis, then web_2

Compose file:

version: '3'
services:
  web:
    build: .
    ports:
      - "5000:5000"
  redis:
    image: "redis:alpine"
  web_2:
    build: .
    ports:
      - "5000:5000"

Command ran:

      docker-compose up web_2```

**Output:**

ERROR: for web_2 Cannot start service web_2: driver failed programming external connectivity on endpoint compose-test_web_2_1 (46484da229527c513cdd1ab62d1de64dc00dfe37195d826ea8113015f56e54fe): Bind for 0.0.0.0:5000 failed: port is already allocated ERROR: Encountered errors while bringing up the project.


So I saw this error with `docker-compose up`, however I'm not sure how to reproduce it when executing a `docker run`?


isaacdorfman

comment created time in 2 months

starteddylanaraps/pure-bash-bible

started time in 2 months

push eventzelahi/tools

Zuhayr Elahi

commit sha 1a3ae01ab18bd5252b496d016db15bdb93db75ba

Added files for testing docker-compose Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha fad3f2f6dba992a11c2459a146695ceb998bc253

remaged jenkins pyenv Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/app

Zuhayr Elahi

commit sha 29f8fee5b098f9691672cfdb7e54b5874ed35cd6

Removed Fossa api key from Jenkinsfile call Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

create barnchzelahi/compose

branch : static-checks-for-ports

created branch time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 98d7cc8d0c8b884720579ad9a9dc944517fc042d

ADDED a stage for executing License Scans Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

PR opened docker/app

Reviewers
[WIP] Utilized public fossa-analyzer image

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/app/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did Utilized the public fossa-analyzer image on hub

- How I did it changed the references and removed calls to dockereng

- How to verify it I ran the fossa-analyze and fossa-test locally

Also double checking it works as expected in the CI

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+2 -4

0 comment

3 changed files

pr created time in 2 months

Pull request review commentdocker/buildx

[TAR-1082] add CI Job for Fossa checks

+fossaCred = [+    $class: 'StringBinding',+    credentialsId: 'fossa-api-key',+    variable: 'FOSSA_API_KEY'+]++hubCred = [+    $class: 'UsernamePasswordMultiBinding',+    usernameVariable: 'REGISTRY_USERNAME',+    passwordVariable: 'REGISTRY_PASSWORD',+    // credentialsId: 'coreeng-hub.docker.com',+    credentialsId: 'orcaeng-hub.docker.com',+]++githubCred = [+    $class: 'StringBinding',+    variable: 'GITHUB_AUTH_TOKEN',+    credentialsId: '3b0aa268-7549-4a0f-8cf4-8d75383bd05f', // 5K API rate limit+]++@Library('jps')+_++pipeline{+  agent {+    node {+      label 'ubuntu-1804-overlay2'+    }+  }+  triggers {+    pollSCM('H * * * *')+  }+  environment{+    FOSSA_API_KEY=credentials('fossa-api-key')+    REGISTRY=credentials('orcaeng-hub.docker.com')+  }+  options{+    disableConcurrentBuilds()+  }+  stages{+    stage("FOSSA Analyze"){+      steps {++        withGithubStatus('FOSSA.scan'){++          sh script: 'docker login -u $REGISTRY_USR -p $REGISTRY_PSW'

You might not need this anymore since we have a public fossa-analyzer docker image

droopy4096

comment created time in 2 months

Pull request review commentdocker/buildx

[TAR-1082] add CI Job for Fossa checks

+REPO_PATH?=docker/buildx+BUILD_ANALYZER?=dockereng/fossa-analyzer

oo also heads up, I just made the fossa-analyzer image public so you can change this to: docker/fossa-analyzer?

droopy4096

comment created time in 2 months

Pull request review commentdocker/buildx

[TAR-1082] add CI Job for Fossa checks

+fossaCred = [+    $class: 'StringBinding',+    credentialsId: 'fossa-api-key',+    variable: 'FOSSA_API_KEY'+]++hubCred = [+    $class: 'UsernamePasswordMultiBinding',+    usernameVariable: 'REGISTRY_USERNAME',+    passwordVariable: 'REGISTRY_PASSWORD',+    // credentialsId: 'coreeng-hub.docker.com',+    credentialsId: 'orcaeng-hub.docker.com',+]++githubCred = [+    $class: 'StringBinding',+    variable: 'GITHUB_AUTH_TOKEN',+    credentialsId: '3b0aa268-7549-4a0f-8cf4-8d75383bd05f', // 5K API rate limit+]++@Library('jps')+_++pipeline{+  agent {+    node {+      label 'ubuntu-1804-overlay2'+    }+  }+  triggers {+    pollSCM('H * * * *')+  }+  environment{+    FOSSA_API_KEY=credentials('fossa-api-key')+    REGISTRY=credentials('orcaeng-hub.docker.com')

I don't think you would need this anymore

droopy4096

comment created time in 2 months

Pull request review commentdocker/buildx

[TAR-1082] add CI Job for Fossa checks

+fossaCred = [+    $class: 'StringBinding',+    credentialsId: 'fossa-api-key',+    variable: 'FOSSA_API_KEY'+]++hubCred = [

Based on comments here: https://github.com/docker/compose/pull/6875#discussion_r323565904,

we want to avoid $class as its legacy and instead follow Nick's suggestion

droopy4096

comment created time in 2 months

Pull request review commentdocker/buildx

[TAR-1082] add CI Job for Fossa checks

+fossaCred = [+    $class: 'StringBinding',+    credentialsId: 'fossa-api-key',+    variable: 'FOSSA_API_KEY'+]++hubCred = [+    $class: 'UsernamePasswordMultiBinding',+    usernameVariable: 'REGISTRY_USERNAME',+    passwordVariable: 'REGISTRY_PASSWORD',+    // credentialsId: 'coreeng-hub.docker.com',+    credentialsId: 'orcaeng-hub.docker.com',+]++githubCred = [+    $class: 'StringBinding',+    variable: 'GITHUB_AUTH_TOKEN',+    credentialsId: '3b0aa268-7549-4a0f-8cf4-8d75383bd05f', // 5K API rate limit+]++@Library('jps')+_++pipeline{+  agent {+    node {+      label 'ubuntu-1804-overlay2'+    }+  }+  triggers {+    pollSCM('H * * * *')

Do you want to run this on a cron?

droopy4096

comment created time in 2 months

create barnchzelahi/app

branch : change-to-public-creds

created branch time in 2 months

push eventzelahi/app

Zuhayr Elahi

commit sha 963997c4979d53167cd6a3a1bff64980768d8e4c

ADDED License scan stage to occur pre-commit in Jenkins Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 770325ba8592a35c30c76e7dcb4e47c3d6b6ea5f

Moved License Scan to Validate stage Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha f1a8f735669e78de43e1774ed8f2c0a976ab52f5

Migrated fossa scans to private Jenkins Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 814df63285d6bd0149ef21062db88ec4287f7688

ADDED hub credentials for downloading fossa-image Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 2b33692de863d3fce11b0ce7a1cad6e0b8ee07c4

Removed dependencies from .fossa file and turned on GOMODULE Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Nicolas De Loof

commit sha 5234af7c364ffbc0146ffae798e36bd6ced18a2f

Configure GOPROXY for direct downloads Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

view details

Nicolas De Loof

commit sha bba98f539747c8203d85800fbc7b753ea9c3701b

Remove support for "single file" app definition Use of such a multi-document yaml file with required ordering is mostly confusing Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

view details

Nicolas De Loof

commit sha b3e8a21c07d905895a2962305a7335c6f9fa526c

linter Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

view details

Nicolas De Loof

commit sha 590a3ddd084526914e6a7e94c3b1c5611d6af08a

cleanup Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

view details

Nicolas De Loof

commit sha be846714099616611b8429ca2eaa32906ecd7cc2

Some more obsolete code Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

view details

Anca Iordache

commit sha 83f43bd48044c9224132e90f681012b9c9bbbd64

APP-179 Simplify templating of docker app (#602) * parameter substitution using string replace instead of compose functions Signed-off-by: Anca Iordache <anca.iordache@docker.com> Co-authored-by: Silvin Lubecki <silvin.lubecki@gmail.com>

view details

Zuhayr Elahi

commit sha c2c17e63f9ff5bb20cdb7b6733f114e8c04946be

REMOVED class for password Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 8c5c7b360d98b89d2e2d7b235adf712842bc1269

MOVED FOSSA_API_KEY to use as credentials instead of in environment block Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 95438afc522717dca4a9857e671201e20f0aca12

Changed to use same creds as public Jenkins Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Chris Crone

commit sha ab21570f8aaf558ff4520c925d255e881ebafb86

Merge pull request #606 from ndeloof/goproxy Configure GOPROXY

view details

Chris Crone

commit sha 93626e0aa7feb0107fb81c14d000e1db701c1281

Merge pull request #598 from zelahi/integrate-fossa-scans-pre-commit [TAR-995 ]ADDED License scan stage to occur pre-commit in Jenkins

view details

Ulysses Souza

commit sha c9eb813930027bfc36426105fc91ce79c4650455

Merge pull request #608 from ndeloof/nosingle Remove support for "single file" app definition

view details

push time in 2 months

Pull request review commentdocker/compose

[TAR-995] ADDED a stage for executing License Scans

+hubCred = [+    $class: 'UsernamePasswordMultiBinding',+    usernameVariable: 'REGISTRY_USERNAME',+    passwordVariable: 'REGISTRY_PASSWORD',+    credentialsId: 'orcaeng-hub.docker.com',+]++pipeline {+    agent any+    stages {+        stage("License Scan") {+            agent {+                label 'ubuntu-1604-aufs-edge'+            }++            steps {+                withCredentials([+                    usernamePassword(credentialsId: 'orcaeng-hub.docker.com', usernameVariable: 'REGISTRY_USERNAME', passwordVariable: 'REGISTRY_PASSWORD'),

@thaJeztah Done! the fossa-analyzer is public on hub so I was able to remove the credentials from this Jenkinsfile. I can go ahead and make the same change on app

zelahi

comment created time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha c497fee475740776327bc6754f832b0f498ba9b7

ADDED a stage for executing License Scans Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 17aabfaf3c39860cbabca1e81b9418a7258a60a0

wrong image Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 00f4933bde8a11849d5570f860afa3b85fc1e9ce

docker login not needed Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 60c35c38908bceef86e0bc5c02ca2b77f13f2bd6

Made fossa-analyzer public Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 12a4b15cad02bf6b4c01f75a42b5d14d78d27d2f

ADDED a stage for executing License Scans Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha ff3d3c3dbe47e387b9cc935254c9d69a2b03b75a

Fixed Jenkinsfile based on feedback Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

Pull request review commentdocker/compose

[TAR-995] ADDED a stage for executing License Scans

+hubCred = [+    $class: 'UsernamePasswordMultiBinding',+    usernameVariable: 'REGISTRY_USERNAME',+    passwordVariable: 'REGISTRY_PASSWORD',+    credentialsId: 'orcaeng-hub.docker.com',+]++pipeline {+    agent any+    stages {+        stage("License Scan") {+            agent {+                label 'ubuntu-1604-aufs-edge'+            }++            steps {+                withCredentials([+                    usernamePassword(credentialsId: 'orcaeng-hub.docker.com', usernameVariable: 'REGISTRY_USERNAME', passwordVariable: 'REGISTRY_PASSWORD'),

okay, I switched it to use creds that were the same as what was on the public Jenkins

zelahi

comment created time in 2 months

push eventzelahi/app

Zuhayr Elahi

commit sha 95438afc522717dca4a9857e671201e20f0aca12

Changed to use same creds as public Jenkins Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 70638a73dc4bdbe22ed10aaa4505debfbe0d2106

Changed creds to match those on public jenkins Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 3d866daec6b8ead6d3201ec6b0e2e4a6f5564797

Removed hubCreds Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

Pull request review commentdocker/compose

[TAR-995] ADDED a stage for executing License Scans

+hubCred = [+    $class: 'UsernamePasswordMultiBinding',+    usernameVariable: 'REGISTRY_USERNAME',+    passwordVariable: 'REGISTRY_PASSWORD',+    credentialsId: 'orcaeng-hub.docker.com',+]++pipeline {+    agent any+    stages {+        stage("License Scan") {+            agent {+                label 'ubuntu-1604-aufs-edge'+            }++            steps {+                withCredentials([+                    usernamePassword(credentialsId: 'orcaeng-hub.docker.com', usernameVariable: 'REGISTRY_USERNAME', passwordVariable: 'REGISTRY_PASSWORD'),

gotcha, that's fair. Let me see if I can dig up credentials for docker hub that is separated from the others

zelahi

comment created time in 2 months

Pull request review commentdocker/app

[TAR-995 ]ADDED License scan stage to occur pre-commit in Jenkins

 pipeline {                         }                     }                 }+                stage("License Scan") {+                    environment {+                        FOSSA_API_KEY=credentials('cb07b147-32a4-4400-aaac-21c3f8c9e62e')

yea, the problem is the api-keys can't do that. As in the fossa api keys aren't specific to a project. The way the api keys are created are either admin or push-only tokens. Admin gives the permissions to do anything and push-only tokens only permit users to push fossa reports upstream.

So its basically a design limitation =(

zelahi

comment created time in 2 months

pull request commentdocker/compose

[TAR-995] ADDED a stage for executing License Scans

@thaJeztah done! Commits have been squashed =)

zelahi

comment created time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha fc088142d07e315a8ff2adb4524cc9f6b9d673b3

ADDED a stage for executing License Scans Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 61d50843390aac95b29492ccbceac5089eff7531

Fixed Jenkinsfile based on feedback Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha d5cb12531f88bdf7d0c00b19c995da16e8b66be7

Fixed Jenkinsfile based on feedback Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

Pull request review commentdocker/compose

[TAR-995] ADDED a stage for executing License Scans

+# Variables for Fossa+BUILD_ANALYZER?=dockereng/fossa-analyzer+FOSSA_OPTS?=--option all-tags:true --option allow-unresolved:true

So according to the doc: By default the fossa-cli will analyze a requirements.txt to determine dependencies

So I don't believe we have to add a strategy unless the dependencies aren't read from the requirements.txt and we want to check the other requirements-*.txt files

zelahi

comment created time in 2 months

Pull request review commentdocker/compose

[TAR-995] ADDED a stage for executing License Scans

+# Variables for Fossa+BUILD_ANALYZER?=dockereng/fossa-analyzer+FOSSA_OPTS?=--option all-tags:true --option allow-unresolved:true++fossa-analyze:+	docker run --rm -e FOSSA_API_KEY=$(FOSSA_API_KEY) \+		-e GO111MODULE=on \

I think it was a strange fossa thing that they made us keep it, but let me see if removing this doesn't break anything

zelahi

comment created time in 2 months

push eventzelahi/app

Zuhayr Elahi

commit sha 8c5c7b360d98b89d2e2d7b235adf712842bc1269

MOVED FOSSA_API_KEY to use as credentials instead of in environment block Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

Pull request review commentdocker/app

[TAR-995 ]ADDED License scan stage to occur pre-commit in Jenkins

 pipeline {                         }                     }                 }+                stage("License Scan") {+                    environment {+                        FOSSA_API_KEY=credentials('cb07b147-32a4-4400-aaac-21c3f8c9e62e')

Gotcha, tho one thing is that FOSSA picks this up from the environment? If we declare it as a credential would it add that as an environment variable as well?

Also I can change the credentialId to be something more human readable

zelahi

comment created time in 2 months

pull request commentdocker/app

[TAR-995 ]ADDED License scan stage to occur pre-commit in Jenkins

@ndeloof just made the changes requested. Thanks for the feedback! Let me know if there is anything else I would need to do =)

zelahi

comment created time in 2 months

push eventzelahi/app

Zuhayr Elahi

commit sha c2c17e63f9ff5bb20cdb7b6733f114e8c04946be

REMOVED class for password Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

Pull request review commentdocker/app

[TAR-995 ]ADDED License scan stage to occur pre-commit in Jenkins

 pipeline {                         }                     }                 }+                stage("License Scan") {+                    environment {+                        FOSSA_API_KEY=credentials('cb07b147-32a4-4400-aaac-21c3f8c9e62e')+                    }+                    agent {+                        label 'ubuntu-1604-aufs-edge'+                    }+                    steps {+                        withCredentials([hubCred]) {

Ahh I just liked the separation as it makes it a bit easier to read

zelahi

comment created time in 2 months

push eventzelahi/app

aiordache

commit sha e5aed11900bbeadb4d436a42a2645c1671388ec7

updated alpine version to 3.10.1 Signed-off-by: aiordache <anca.iordache@docker.com>

view details

aiordache

commit sha a2a67b3bbfe6d9899ff4fc88cbfed4e8e8a12ca9

updated go version to 1.12.9 Signed-off-by: aiordache <anca.iordache@docker.com>

view details

aiordache

commit sha bbcf4fab6a7899aa70cd615698d7f486e007da7f

golang alpine image does not support subminor version Signed-off-by: aiordache <anca.iordache@docker.com>

view details

Chris Crone

commit sha a41ba08878f200f354cbadc5301612ef6b6455ec

Merge pull request #593 from aiordache/bump-alpine Bump alpine

view details

Djordje Lukic

commit sha 384883a30019bfcfe5680d258cdef598d607c261

Add debug logs (#590) * Add more logs Fixed some logs that didn't log the error buffer from the invocation image. * Update cnab-to-oci dependency And pass a logger when pushing and pulling Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

view details

Nicolas De Loof

commit sha 73948fead52e84b1628f87d08e98b2a272ee25c8

os.ModeIrregular used by vendor/github.com/docker/cli/cli/command/utils.go:155 was introduced by go 1.11 https://github.com/golang/go/commit/dfd7f3562645ebd587d7d883bbaa8915fcf8c84b Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

view details

Djordje Lukic

commit sha 6f5f3154d065e4c92f95b755a9a122c9d878d290

Update cnab-to-oci and cnab-go to latest Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

view details

Jean-Christophe Sirot

commit sha 925c394e196252d83d12f6b21d3394f2d676cc89

Merge pull request #595 from ndeloof/master os.ModeIrregular require go 1.11

view details

Ulysses Souza

commit sha f6dc9387a1feeb04b2012f9da10f7bade2c7e52e

Fix env_file retrieval by using app.Path as WorkingDir Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Jean-Christophe Sirot

commit sha a8e078d53a581abec3576783c028cdae9f1bd0b2

Merge pull request #597 from ulyssessouza/nsfod_envfile Fix 'env_file' retrieval by using app.Path as WorkingDir in the render action

view details

Djordje Lukic

commit sha 15c4595296cfb50ff980d1bab39ba9da90021a47

Cleanup unused function Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

view details

Jean-Christophe Sirot

commit sha 8dcf633da08b469b23b8e353040383bf31b1bf99

Merge pull request #596 from rumpl/update-deps Update cnab-to-oci and cnab-go to latest

view details

Djordje Lukic

commit sha 5c2143dee68c4d9e836586e301a75e970b4a1bf7

Only print the bundle if "-o -" is given Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

view details

Jean-Christophe Sirot

commit sha 962230a4e2b822d3e320cf73eb05da6ce58721ea

Merge pull request #599 from rumpl/verbose-stderr Don't print logs when "-o -" flag is set

view details

Anca Iordache

commit sha d99ac99e91322ad306179ca26b5582ffefb32158

Updated status/list output times (added 'ago' at the end) Signed-off-by: Anca Iordache <anca.iordache@docker.com>

view details

Peter Salvatore

commit sha 006aa34745009e5d781a2018d17a318a477374bd

Jenkinsfile tweaks. * Move to a newer agent type which should perform better. * Set default timeout of 1hr in case of stuck jobs. Signed-off-by: Peter Salvatore <peter@psftw.com>

view details

Chris Crone

commit sha 2c66384347921b98f85a27fab42e5fb0dbf3a5ef

Merge pull request #603 from psftw/jenkinsfile-tweaks Jenkinsfile tweaks.

view details

Silvin Lubecki

commit sha 964210ee88958a8409282aea0bfb18df663430db

Merge pull request #600 from aiordache/app_190_inconsistent_output_time APP-190 -- Updated status/list output times (added 'ago' at the end)

view details

Nicolas De loof

commit sha daee95392ed09b9d212b2302fc9dc2c33b37abf2

Remove `completion` command (#607) * Remove `completion` command * Bump cobra dependency for better zsh completion `docker app completion` is not consistent with docker CLI replaced by `--completion` flag (hidden) Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Antonio Gutierrez

commit sha 66856e884c0e7337046b0f0fa359ca17a2a96b53

requirements: update jsonschema dependency Fixes: https://github.com/docker/compose/issues/6347 Signed-off-by: Antonio Gutierrez <chibby0ne@gmail.com>

view details

aiordache

commit sha 60dcf87cc08bef7d45f1b376fe54374c3c1f99a1

update alpine version to 3.10.1 Signed-off-by: aiordache <anca.iordache@docker.com>

view details

Ulysses Souza

commit sha 525bc9ef7a43e4f8a6120386435c8d94fb074820

Merge pull request #6856 from aiordache/bump-alpine update alpine version to 3.10.1

view details

Djordje Lukic

commit sha 4cfa622de88b781448da64578794ec8958fb3cc7

Merge pull request #6631 from chibby0ne/update_jsonschema_dependency requirements: update jsonschema dependency

view details

Nao YONASHIRO

commit sha cacbcccc0c68bfcd33f4707bd388b1441523c521

Add support to CLI build This includes can be enabled by setting the env var `COMPOSE_NATIVE_BUILDER=1`. Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp> Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Nao YONASHIRO

commit sha 862a13b8f3f9eceadef80d47a671247d7ba63669

fix: add build flags Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Nao YONASHIRO

commit sha 81e223d499f5cfd4935f322b2006d4c41067bca0

feat: add --progress flag Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Nao YONASHIRO

commit sha 15e8edca3c6853a7c48cffce9eee00486a8a84c0

feat: add a warning if someone uses the --compress or --parallel flag Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Ulysses Souza

commit sha ee8ca5d6f8d929f52d4ddecef897ff31009f8aea

Rephrase warnings when building with the cli Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha bbdb3cab881692c0785b1bd61217db9822db76f1

Add integration tests to native builder Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Nao YONASHIRO

commit sha 719a1b05818cc0dcb4515dc3a704e468061b2455

fix: use subprocess32 for python2 Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Ulysses Souza

commit sha 9d7ad3bac17a174a85f6d9f4e20d04b2e65b8c66

Add comment on native build and fix typo Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha 0c6fce271e949955693ed86461d8a0e6adcd18d4

Bump runtime debian From `stretch-20190708-slim` to `stretch-20190812-slim` Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha 5add9192ac52a5c72ecc1495aa68cbfeb5a8e863

Rename envvar switch to COMPOSE_DOCKER_CLI_BUILD From `COMPOSE_NATIVE_BUILDER` to `COMPOSE_DOCKER_CLI_BUILD` Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha 2199278b4448c1fbf0637efa42a1ab97dc9b8573

Merge pull request #6865 from ulyssessouza/support-cli-build Add support to CLI build

view details

Chris Crone

commit sha 9973f051ba506eae4a60a5f302c2328667ce9707

Merge pull request #6878 from ulyssessouza/bump-debian Bump runtime debian

view details

Ulysses Souza

commit sha 47d170b06a0f04ca77c4083a151d48a714508a52

Fix race condition on watch_events Avoid to attach to restarting containers and ignore race conditions when trying to attach to already dead containers Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha ecf03fe280816ea6bac51da5c524768ea7c96339

Merge pull request #6882 from ulyssessouza/fix_attach_restarting_container Fix race condition on watch_events

view details

Danil Kister

commit sha a5fbf91b72f1f32fe61b2d7b3e0cd5d53fbf2aac

Prevent KeyError when remote network labels are None. Signed-off-by: Danil Kister <danil.kister@gmail.com>

view details

Silvin Lubecki

commit sha 1566930a70c28a10c724c54bd5b2485afa75aff9

Merge pull request #6862 from deathtracktor/master Fix KeyError when remote network labels are None.

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 8a47b8f034a77b94ac003f5fe51738beb18d11f7

Removed fossa scans from Jenkinsfile Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Nao YONASHIRO

commit sha cacbcccc0c68bfcd33f4707bd388b1441523c521

Add support to CLI build This includes can be enabled by setting the env var `COMPOSE_NATIVE_BUILDER=1`. Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp> Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Nao YONASHIRO

commit sha 862a13b8f3f9eceadef80d47a671247d7ba63669

fix: add build flags Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Nao YONASHIRO

commit sha 81e223d499f5cfd4935f322b2006d4c41067bca0

feat: add --progress flag Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Nao YONASHIRO

commit sha 15e8edca3c6853a7c48cffce9eee00486a8a84c0

feat: add a warning if someone uses the --compress or --parallel flag Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Ulysses Souza

commit sha ee8ca5d6f8d929f52d4ddecef897ff31009f8aea

Rephrase warnings when building with the cli Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha bbdb3cab881692c0785b1bd61217db9822db76f1

Add integration tests to native builder Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Nao YONASHIRO

commit sha 719a1b05818cc0dcb4515dc3a704e468061b2455

fix: use subprocess32 for python2 Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>

view details

Ulysses Souza

commit sha 9d7ad3bac17a174a85f6d9f4e20d04b2e65b8c66

Add comment on native build and fix typo Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha 0c6fce271e949955693ed86461d8a0e6adcd18d4

Bump runtime debian From `stretch-20190708-slim` to `stretch-20190812-slim` Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha 5add9192ac52a5c72ecc1495aa68cbfeb5a8e863

Rename envvar switch to COMPOSE_DOCKER_CLI_BUILD From `COMPOSE_NATIVE_BUILDER` to `COMPOSE_DOCKER_CLI_BUILD` Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>

view details

Ulysses Souza

commit sha 2199278b4448c1fbf0637efa42a1ab97dc9b8573

Merge pull request #6865 from ulyssessouza/support-cli-build Add support to CLI build

view details

Chris Crone

commit sha 9973f051ba506eae4a60a5f302c2328667ce9707

Merge pull request #6878 from ulyssessouza/bump-debian Bump runtime debian

view details

Zuhayr Elahi

commit sha ffef11c51cd4c8d3e95025d58502731ea1e69e4c

ADDED a stage for executing License Scans Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 2b12eb3e4f78bd6574f557f4e2f2f35be965ac83

Redo the parallel syntax Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 20cdc16c9ed57096571392a76cd2865bd5b05c04

Added license scan test in testMatrix Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 82d432dfd51576be818d79dccb749bdd4e7ad260

called the license scan seperately from the testMatrix Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 7933dbda15cb7717624ef50243b11b1321969af1

Ran testMatrix and license scan in parallel Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 5ef49e3261a88b2c898c9e1a048cd1572eae74f1

Trying a syntax thing Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Zuhayr Elahi

commit sha 0d061d84d5babeb3403cf4c23fe3c0f79c05002f

Moved Fossa scans to a seperate Jenkinsfile Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 2 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 98918f710b010986fa5cc0aa360e9abf77fb1463

Trying a syntax thing Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

push eventzelahi/compose

Zuhayr Elahi

commit sha d5b08aebf402f14871d8f28ec3474b460c4b0e41

Ran testMatrix and license scan in parallel Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 0ec9027ee88e30d87f8ec06f056273fc11e11bda

called the license scan seperately from the testMatrix Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

push eventzelahi/compose

Zuhayr Elahi

commit sha c6b72e463681e889c1ea04d0acd25045ad23de61

Added license scan test in testMatrix Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

push eventzelahi/compose

Zuhayr Elahi

commit sha abcadbbb1c3345d6727d47e8d4d6de0423a0e2ab

Redo the parallel syntax Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

push eventzelahi/fossa-cli

Zach

commit sha 94be39b5af3d96cc4bfbb35fba806a9cb077cdab

testing (fossa test) use a test server to test fossa test (#305) * test server

view details

Andrew Gallant

commit sha 4bc1dbc6eb7ea2efed130721e0fb36dbab66ff7d

improve error messages when running commands (#510) * improve error message when running command When running a command, it's helpful to include the command that was executed in the error. This makes it easier for the user to drill down and diagnose problems. * fix stderr capturing This fixes a bug where the stderr of a failed command was never captured, and thus, diagnosing problems when a particular command failed become much harder. The specific issue here was that a stack copy of a `bytes.Buffer` was returned, while handing a pointer to it to the `*exec.Cmd`. Writes to the buffer throgh `*exec.Cmd` would consequently not update the stack copy returned. A regression test is added to ensure that stderr is captured.

view details

Zach

commit sha 1c58d98c3d27bc0e8220f6e33db35f45956e3581

warn error and handle nil typed errors (#512)

view details

Zach

commit sha 638f9f79fac6fd4b4fa2eb575d1faea4c5d04807

fix (ruby errors) change is built check and fix errors (#519) * rollback errors and change build check * automatically mark releases for production

view details

push time in 3 months

push eventzelahi/moby

Sebastiaan van Stijn

commit sha 7f37d99ef50b4046284ecb3c3b290319acf11405

integration-cli: remove redundant "testrequires" The `DockerDaemonSuite.SetUpTest` already checks for Linux and a local daemon; ``` func (s *DockerDaemonSuite) SetUpTest(c *check.C) { testRequires(c, DaemonIsLinux, testEnv.IsLocalDaemon) s.d = daemon.New(c, dockerBinary, dockerdBinary, testdaemon.WithEnvironment(testEnv.Execution)) } ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 651e694508563e6fb3e8f5d7037641cc136b2c44

Prevent panic on network attach In situations where `container.NetworkSettings` was not nil, but `container.NetworkSettings.Networks` was, a panic could occur: ``` 2019-06-10 15:26:50.548309 I | http: panic serving @: assignment to entry in nil map goroutine 1376 [running]: net/http.(*conn).serve.func1(0xc4211068c0) /usr/local/go/src/net/http/server.go:1726 +0xd2 panic(0x558939d7e1e0, 0x55893a0c4410) /usr/local/go/src/runtime/panic.go:502 +0x22d github.com/docker/docker/daemon.(*Daemon).updateNetworkSettings(0xc42090c5a0, 0xc420fb6fc0, 0x55893a101140, 0xc4210e0540, 0xc42112aa80, 0xc4217d77a0, 0x0) /go/src/github.com/docker/docker/daemon/container_operations.go:275 +0x40e github.com/docker/docker/daemon.(*Daemon).updateNetworkConfig(0xc42090c5a0, 0xc420fb6fc0, 0x55893a101140, 0xc4210e0540, 0xc42112aa80, 0x55893a101101, 0xc4210e0540, 0x0) /go/src/github.com/docker/docker/daemon/container_operations.go:683 +0x219 github.com/docker/docker/daemon.(*Daemon).connectToNetwork(0xc42090c5a0, 0xc420fb6fc0, 0xc420e8290f, 0x40, 0xc42112aa80, 0x558937eabd01, 0x0, 0x0) /go/src/github.com/docker/docker/daemon/container_operations.go:728 +0x1cb github.com/docker/docker/daemon.(*Daemon).ConnectToNetwork(0xc42090c5a0, 0xc420fb6fc0, 0xc420e8290f, 0x40, 0xc42112aa80, 0x0, 0x0) /go/src/github.com/docker/docker/daemon/container_operations.go:1046 +0x2b3 github.com/docker/docker/daemon.(*Daemon).ConnectContainerToNetwork(0xc42090c5a0, 0xc4214ca580, 0x40, 0xc420e8290f, 0x40, 0xc42112aa80, 0x2, 0xe600000000000001) /go/src/github.com/docker/docker/daemon/network.go:450 +0xa1 github.com/docker/docker/api/server/router/network.(*networkRouter).postNetworkConnect(0xc42121bbc0, 0x55893a0edee0, 0xc420de7cb0, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600, 0xc420de7980, 0x5589394707cc, 0x5) /go/src/github.com/docker/docker/api/server/router/network/network_routes.go:278 +0x330 github.com/docker/docker/api/server/router/network.(*networkRouter).(github.com/docker/docker/api/server/router/network.postNetworkConnect)-fm(0x55893a0edee0, 0xc420de7cb0, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600, 0xc420de7980, 0x558937fd89dc, 0x558939f2cec0) /go/src/github.com/docker/docker/api/server/router/network/network.go:37 +0x6b github.com/docker/docker/api/server/middleware.ExperimentalMiddleware.WrapHandler.func1(0x55893a0edee0, 0xc420de7cb0, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600, 0xc420de7980, 0x55893a0edee0, 0xc420de7cb0) /go/src/github.com/docker/docker/api/server/middleware/experimental.go:26 +0xda github.com/docker/docker/api/server/middleware.VersionMiddleware.WrapHandler.func1(0x55893a0edee0, 0xc420de7a70, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600, 0xc420de7980, 0x0, 0x0) /go/src/github.com/docker/docker/api/server/middleware/version.go:62 +0x401 github.com/docker/docker/pkg/authorization.(*Middleware).WrapHandler.func1(0x55893a0edee0, 0xc420de7a70, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600, 0xc420de7980, 0x0, 0x558939640868) /go/src/github.com/docker/docker/pkg/authorization/middleware.go:59 +0x7ab github.com/docker/docker/api/server/middleware.DebugRequestMiddleware.func1(0x55893a0edee0, 0xc420de7a70, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600, 0xc420de7980, 0x55893a0edee0, 0xc420de7a70) /go/src/github.com/docker/docker/api/server/middleware/debug.go:53 +0x4b8 github.com/docker/docker/api/server.(*Server).makeHTTPHandler.func1(0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600) /go/src/github.com/docker/docker/api/server/server.go:141 +0x19a net/http.HandlerFunc.ServeHTTP(0xc420e0c0e0, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600) /usr/local/go/src/net/http/server.go:1947 +0x46 github.com/docker/docker/vendor/github.com/gorilla/mux.(*Router).ServeHTTP(0xc420ce5950, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600) /go/src/github.com/docker/docker/vendor/github.com/gorilla/mux/mux.go:103 +0x228 github.com/docker/docker/api/server.(*routerSwapper).ServeHTTP(0xc421078330, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600) /go/src/github.com/docker/docker/api/server/router_swapper.go:29 +0x72 net/http.serverHandler.ServeHTTP(0xc420902f70, 0x55893a0ec2e0, 0xc4207f0e00, 0xc420173600) /usr/local/go/src/net/http/server.go:2697 +0xbe net/http.(*conn).serve(0xc4211068c0, 0x55893a0ede20, 0xc420d81440) /usr/local/go/src/net/http/server.go:1830 +0x653 created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2798 +0x27d ``` I have not been able to reproduce the situation, but preventing a panic should not hurt. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Eli Uriegas

commit sha f5cd8fdd446750a749182f3410adc6f1968053ca

hack: Remove inContainer check, it wasn't useful The inContainer check isn't really useful anymore. Even though it was said that we shouldn't rely on its existence back in 2016, we're now in 2019 and this thing still exists so we should just rely on it now to check whether or not we're in a container. Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>

view details

zelahi

commit sha 0ecd6ab30f875184073df81aaf2ec570664957da

ADDED changes to integrate with our new Jenkins ci Signed-off-by: zelahi <elahi.zuhayr@gmail.com>

view details

Drew Erny

commit sha b79adac339173bf8bb6de6d0a061a97973c4b62b

Fix TestSwarmClusterRotateUnlockKey TestSwarmClusterRotateUnlockKey had been identified as a flaky test. It turns out that the test code was wrong: where we should have been checking the string output of a command, we were instead checking the value of the error. This means that the error case we were expecting was not being matched, and the test was failing when it should have just retried. Signed-off-by: Drew Erny <drew.erny@docker.com>

view details

Sebastiaan van Stijn

commit sha bd983a60bb2a6afad99baa3ecbcc6ac4e4636598

Merge pull request #39592 from zelahi/integrate-with-jsp-jenkinsfile Added changes to integrate with the new Jenkins ci

view details

Tibor Vass

commit sha 917a8b42594317e4b547c4d34a6bc733f32a9974

Merge pull request #39616 from dperny/fix-cluster-rotate-unlock-key Fix TestSwarmClusterRotateUnlockKey

view details

Yong Tang

commit sha 9c92080b133d11d6c2e7cdb4f9bb6f445b7e8ca3

Merge pull request #39589 from thaJeztah/prevent_network_attach_panic Prevent panic on network attach

view details

Brian Goff

commit sha 582591d56bf18355993078539e5464b4e4f630ed

Merge pull request #39569 from thaJeztah/remove_redundant_checks integration-cli: remove redundant "testrequires"

view details

Sebastiaan van Stijn

commit sha 0595c01718b3176b67763a408bff0e7b51e1f323

switch kr/pty to creack/pty v1.1.7 kr/pty was moved to creak/pty and the old location was archived. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Brian Goff

commit sha 7cfd8146dc6089a5f21415dc4c0a609a93c507fe

Merge pull request #39629 from thaJeztah/switch_creack_pty switch kr/pty to creack/pty v1.1.7

view details

Sebastiaan van Stijn

commit sha 6f234db9fef23c591d8376f96db062e7107b658f

bump libnetwork to 09cdcc8c0eab3946c2d70e8f6225b05baf1e90d1 full diff: https://github.com/docker/libnetwork/compare/83d30db53600b9c084d35fb1d560f97f8b34ab24...09cdcc8c0eab3946c2d70e8f6225b05baf1e90d1 changes included: - docker/libnetwork#2416 Fix hardcoded AF_INET for IPv6 address handling - docker/libnetwork#2411 Macvlan network handles netlabel.Internal wrong - fixes docker/libnetwork#2410 Macvlan network handles netlabel.Internal wrong - docker/libnetwork#2414 Allow network with --config-from to be --internal - fixes docker/libnetwork#2413 Network with --config-from does not honor --internal - docker/libnetwork#2351 Use fewer modprobes - relates to moby/moby#38930 Use fewer modprobes - docker/libnetwork#2415 Support dockerd and system restarts for ipvlan and macvlan networks - carry of docker/libnetwork#2295 phantom ip/mac vlan network after a powercycle - fixes docker/libnetwork#1743 Phantom docker network Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Zuhayr Elahi

commit sha 438c7eb606356a5e6a7664bfb79e5072a9db2473

Added information regarding our new Jenkins ci on moby/moby Added link to header Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

Sebastiaan van Stijn

commit sha b1723b37212570128b1b403f878cf0064d857f4a

Dockerfile: add back yamllint This was inadvertedly removed in 7bfe48cc00318f9d4cf388237855012aafac56b0, because it was documented as a dependency for docker-py, but actually used to validate the swagger file. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Kirill Kolyshkin

commit sha 589f1dad8dad7a4124457b2071a8a0f5765ac99a

Merge pull request #39636 from thaJeztah/add_back_yamllint Dockerfile: add back yamllint

view details

Sebastiaan van Stijn

commit sha 928381b2215c9608692e663e6ddfa9e609bc2d6f

Merge pull request #39633 from thaJeztah/bump_libnetwork bump libnetwork to 09cdcc8c0eab3946c2d70e8f6225b05baf1e90d1

view details

Ziheng Liu

commit sha 53e0c5012637656de1765c330b2549aa7088b853

Avoid a data race in container/health.go Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>

view details

Brian Goff

commit sha abece9b56221bd682f723d5049f7cc047cd522ba

Improvements to the test runners 1. Use `go list` to get list of integration dirs to build. This means we do not need to have a valid `.go` in every subdirectory and also filters out other dirs like "bundles" which may have been created. 2. Add option to specify custom flags for integration and integration-cli. This is needed so both suites can be run AND set custom flags... since the cli suite does not support standard go flags. 3. Add options to skip an entire integration suite. Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Andrew Hsu

commit sha 42f0a0db75a921145c7f519f7b550e1392890da2

run unit tests and generate junit report Signed-off-by: Andrew Hsu <andrewhsu@docker.com>

view details

Dominic

commit sha 5f0231bca193320e1a3d785a3ade0e64241fe580

cast Dev and Rdev of Stat_t to uint64 for mips Signed-off-by: Dominic <yindongchao@inspur.com> Signed-off-by: Dominic Yin <yindongchao@inspur.com>

view details

push time in 3 months

PR merged zelahi/moby

Remove withGithubStatus and commented Windows stuff out

Signed-off-by: zelahi elahi.zuhayr@gmail.com

testing PRs

+38 -84

0 comment

2 changed files

zelahi

pr closed time in 3 months

push eventzelahi/compose

Zuhayr Elahi

commit sha 897ddf1c215ae616e4485febe2fa138704d4194e

ADDED a stage for executing License Scans Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

PR opened docker/compose

[WIP][TAR-995] ADDED a stage for executing License Scans

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

<!-- Welcome to the docker-compose issue tracker, and thank you for your interest in contributing to the project! Please make sure you've read the guidelines in CONTRIBUTING.md before submitting your pull request. Contributions that do not comply and contributions with failing tests will not be reviewed! -->

<!-- Please make sure an issue describing the problem the PR is trying to solve exists, or create it before submitting a PR. The maintainers will validate if the issue should be addressed or if it is out of scope for the project. --> Resolves #

This is currently a WIP, but trying to execute a fossa scan and fossa test on PRs to ensure that there are no license issues when contributors submit PRs

+34 -0

0 comment

2 changed files

pr created time in 3 months

create barnchzelahi/compose

branch : integrate-fossa-scan-pre-commit

created branch time in 3 months

push eventzelahi/app

Zuhayr Elahi

commit sha 2b33692de863d3fce11b0ce7a1cad6e0b8ee07c4

Removed dependencies from .fossa file and turned on GOMODULE Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

push eventzelahi/app

Zuhayr Elahi

commit sha 814df63285d6bd0149ef21062db88ec4287f7688

ADDED hub credentials for downloading fossa-image Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

view details

push time in 3 months

more