profile
viewpoint
Silvin Lubecki silvin-lubecki @docker Paris Golang/C++ developper, Docker maintainer, CNAB maintainer, husband and father.

docker/app 1450

Make your Docker Compose applications reusable, and share them on Docker Hub

docker/compose-on-kubernetes 1338

Deploy applications described in Compose onto Kubernetes clusters

cnabio/cnab-to-oci 34

Tool to convert CNAB bundle.json to OCI index

silvin-lubecki/docker-app-workshop-dc19 11

DockerCon 2019 Workshop on docker app

silvin-lubecki/dap-workshop-dceu18 5

Docker Application Package Workshop for DockerCon Europe 2018

Dimrok/app 0

Make your Docker Compose applications reusable, and share them on Docker Hub

mat007/app 0

Make your Docker Compose applications reusable, and share them on Docker Hub

Pull request review commentcnabio/cnab.io

Add compatible registries page

+---+title: Compatible Registries+description: Understanding which OCI registries work with CNAB +---++Cloud Native Application Bundles are new, and support for storing anything+other than container images in a registry is inconsistent. The community has+tested a bunch of registries for compatibility with CNAB and so far here is what+we have found.++Registries that are [OCI compliant][oci-spec] should work with CNAB just fine. CNAB doesn't+have additional requirements beyond that. Each registry below has been verified+using a CNAB tool that uses the [cnab-to-oci] library.+++| Registry | Compatible |+| -------- | --------------- |+| **Azure Container Registry (ACR)** | **Yes** |+| Artifactory | No |+| **Docker Hub** | **Yes** |+| **DigitalOcean Container Registry** | **Yes** |+| Amazon Elastic Container Registry (ECR) | No |+| **Google Cloud Registry (GCR)** | **Yes** |  +| GitHub Packages | No |+| Nexus | No |+| Quay | No |

Question: Should we add also Harbor 2, since they added CNAB support officially?

carolynvs

comment created time in 12 hours

issue commentdocker/cli

Docker client version 19.03.09 doesn't automatically downgrade Docker API version correctly

@ocofaigh this fix is planned for v19.03.10 release yes. I don't have precise ETA for the release but it's in our ASAP list 👍

lokst

comment created time in 12 hours

PR opened docker/cli

[19.03 backport] Fix version old engine 19 03

Backport of #2537

+49 -17

0 comment

3 changed files

pr created time in 5 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha 2d1476c6f006932beacac0a7769e458150316345

Partially revert cf663b526a34f3e7911e6e60138138c2023aa844 as it breaks the version negotiation with an older docker engine. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> (cherry picked from commit 54f766d240f8e8c01bcde6061c877cf6e65e7f3d)

view details

Silvin Lubecki

commit sha 95df3499bb11c092240d51df22b4bd69bae020ba

Add a new Makefile variable to override DockerInDocker engine version we use to run e2e tests Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> (cherry picked from commit 15d6565e49f8bdfc589ff0e0884059a9d790cdc5)

view details

Silvin Lubecki

commit sha 0f59532a1a81e0c23ebab8a30e7cee9e03c91f38

Run e2e tests with different engine version on Jenkins Rewrite Jenkinsfile to new declarative syntax without parallel as the e2e framework is not tailored for than (container name clash, port clash,...) Signed-off-by: Tibor Vass <tibor@docker.com> Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> (cherry picked from commit 74919d056936d351af733ec504dee3f41c978292)

view details

push time in 5 days

PR opened docker/cli

Fix version old engine master

Fixes #2533

- What I did #cf663b5 introduced a regression when the CLI negotiates the API version with an old daemon. This PR reverts it partially and adds regression tests, running all e2e tests against 18.09 daemon.

- Description for the changelog

  • Fix "Docker client version 19.03.09 doesn't automatically downgrade Docker API version correctly"

- A picture of a cute animal (not mandatory but encouraged) image

+48 -28

0 comment

3 changed files

pr created time in 5 days

PR closed docker/cli

[19.03] Fix regression when targeting an old docker engine process/cherry-pick status/2-code-review

Fixes #2533

- What I did #cf663b5 introduced a regression when the CLI negotiates the API version with an old daemon. This PR reverts it partially and adds regression tests, running all e2e tests against 18.09 daemon.

- Description for the changelog

  • Fix "Docker client version 19.03.09 doesn't automatically downgrade Docker API version correctly"

- A picture of a cute animal (not mandatory but encouraged) image

+35 -17

8 comments

3 changed files

silvin-lubecki

pr closed time in 5 days

create barnchsilvin-lubecki/cli

branch : fix-version-old-engine-19-03

created branch time in 5 days

create barnchsilvin-lubecki/cli

branch : fix-version-old-engine-master

created branch time in 5 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha 375f685b3af84ed957cd432cd3e405fa5e1e5147

Run e2e tests with different engine version on Jenkins Rewrite Jenkinsfile to new declarative syntax without parallel as the e2e framework is not tailored for than (container name clash, port clash,...) Signed-off-by: Tibor Vass <tibor@docker.com> Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 6 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha 3ba57a4db64d20622957cc505289409f19f8ceed

Remove parallel from Jenkinsfile, as the e2e framework is not tailored for than (container name clash, port clash,...) Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 6 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha def06c8a4257591cfe1664317939160ccd0cbbbd

Remove parallel from Jenkinsfile, as the e2e framework is not tailored for than (container name clash, port clash,...) Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 6 days

pull request commentdocker/cli

Fix regression when targeting an old docker engine

My bad @tiborvass, of course it makes no sense, it's a mistake 😄 Fixed!

silvin-lubecki

comment created time in 6 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha 1ff6c4247c6444ba6429bf1ad28d4408771cf365

Add a new Makefile variable to override DockerInDocker engine version we use to run e2e tests Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

Silvin Lubecki

commit sha 7c0c916eb2f44d443cf22610a64bd722fe69a9af

Run e2e tests with different engine version on Jenkins Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

Tibor Vass

commit sha 0bd1e424ddd811ac93749cb6274cb191d49a48a9

Rewrite Jenkinsfile to new declarative syntax + parallel Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha bc462cfcdae55ec638898f0fb67e69002ea02518

Revert "Partially revert cf663b526a34f3e7911e6e60138138c2023aa844 as it breaks the version negotiation with an older docker engine." This reverts commit 7b2fac402fc5d723a7879b8b55e3e48f24a9853c. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Silvin Lubecki

commit sha a49524b5fb53c5598098a4ccb31b8b051d52f298

Remove parallel from Jenkinsfile, as the e2e framework is not tailored for than (container name clash, port clash,...) Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 6 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha af4a07430a4e9eeeeb45471d6a10bb69f570f524

Run e2e tests with different engine version on Jenkins Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 6 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha dc364a25ea658112c44b1f2ea34d8c8b0c4bbf08

Run e2e tests in parallel with different engine version on Jenkins Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 6 days

PR opened docker/cli

Fix regression when targeting an old docker engine

Fixes #2533

- What I did #cf663b5 introduced a regression when the CLI negotiates the API version with an old daemon. This PR reverts it partially and adds regression tests, running all e2e tests against 18.09 daemon.

- Description for the changelog

  • Fix "Docker client version 19.03.09 doesn't automatically downgrade Docker API version correctly"

- A picture of a cute animal (not mandatory but encouraged) image

+23 -12

0 comment

3 changed files

pr created time in 6 days

create barnchsilvin-lubecki/cli

branch : fix-version-old-engine

created branch time in 6 days

issue commentdocker/cli

Docker client version 19.03.09 doesn't automatically downgrade Docker API version correctly

Hello @lokst and thank you for filling this issue. I managed to reproduce the bug you found, let me check why we have this regression.

lokst

comment created time in 7 days

PR opened docker/cli

Reviewers
Removing CLI plugins API documentation

- What I did Adding depreciation notice for the CLI Plugins API.

- A picture of a cute animal (not mandatory but encouraged)

image

+7 -125

0 comment

3 changed files

pr created time in 7 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha 459c6082f87750d45c84cd9454f3fa4b6c5580d9

Removing CLI plugins API documentation from official documentation as it is now deprecated. Adding depreciation notice. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 7 days

push eventsilvin-lubecki/cli

Silvin Lubecki

commit sha d58137266b2eeae47878347563a5dbfeaf29677d

Removing CLI plugins API documentation from official documentation as it is now deprecated. Adding depreciation notice. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

view details

push time in 7 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 1ecca982edecdbf61bf1ea93b15f41eca9a9f312

Bump Golang 1.13.11 full diff: https://github.com/golang/go/compare/go1.13.10...go1.13.11 go1.13.11 (released 2020/05/14) includes fixes to the compiler. See the Go 1.13.11 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.13.11+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 8726f7dc959e1abbe3d8418465aa754f3235e9ab

Merge pull request #2531 from thaJeztah/bump_golang_1.13.11 Bump Golang 1.13.11

view details

push time in 7 days

PR merged docker/cli

Bump Golang 1.13.11 process/cherry-pick status/2-code-review

full diff: https://github.com/golang/go/compare/go1.13.10...go1.13.11

go1.13.11 (released 2020/05/14) includes fixes to the compiler. See the Go 1.13.11 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.11+label%3ACherryPickApproved

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+6 -6

0 comment

6 changed files

thaJeztah

pr closed time in 7 days

push eventdocker/golang-cross

Sebastiaan van Stijn

commit sha 724b7b60ff1b511b58079ad62bc394364236a289

Bump Golang 1.13.11 full diff: https://github.com/golang/go/compare/go1.13.10...go1.13.11 go1.13.11 (released 2020/05/14) includes fixes to the compiler. See the Go 1.13.11 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.13.11+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 943734a0140080e40b5adaf586756058a999c0a1

Merge pull request #57 from thaJeztah/bump_golang_1.13.11 Bump Golang 1.13.11

view details

push time in 8 days

PR merged docker/golang-cross

Bump Golang 1.13.11

full diff: https://github.com/golang/go/compare/go1.13.10...go1.13.11

go1.13.11 (released 2020/05/14) includes fixes to the compiler. See the Go 1.13.11 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.11+label%3ACherryPickApproved

+1 -1

1 comment

1 changed file

thaJeztah

pr closed time in 8 days

push eventcnabio/cnab-go

Carolyn Van Slyck

commit sha 8b17c23f777fdad55b977a4a92343a9f6c32b79f

Fix ULID generation * The entropy generator needs to be reused between ULIDs to ensure that each ULID is monotonically increasing. * We should use the monotonic function so that ULIDs generated during the same millisecond can still be sorted. * Use a mutex in ULID since math.Rand is not thread-safe. Signed-off-by: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>

view details

Carolyn Van Slyck

commit sha 12fbb1af0e00217486d980ebce85c68a131383cf

Fix ulid generation unit test... Signed-off-by: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>

view details

Carolyn Van Slyck

commit sha d1883f71d8d4ce96cc9c65d993fe503125489a34

Split ULID into NewULID and MustNewULID Allow the caller to decide which call pattern they want to use. I am in the middle of refactoring all of claims and will use the NewULID (string,error) function so that our library doesn't panic in any essential places like it can possibly do today. Signed-off-by: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>

view details

Silvin Lubecki

commit sha d0bcf6d0603b08050db57450703d24ff2f859626

Merge pull request #207 from carolynvs/fix-ulid Fix ULID generation

view details

push time in 8 days

PR merged cnabio/cnab-go

Fix ULID generation
  • The entropy generator needs to be reused between ULIDs to ensure that each ULID is monotonically increasing.
  • We should use the monotonic function so that ULIDs generated during the same millisecond can still be sorted.
  • Use a mutex in ULID since math.Rand is not thread-safe.

I was seeing in unit tests where I was generating ULIDs back-to-back that they were not sorting correctly. After digging through the issue queue, it turns out the example on the README of the ulid library we use is not appropriate to copy and use. I believe this is what they recommend based on their replies to a few issues.

+107 -9

1 comment

2 changed files

carolynvs

pr closed time in 8 days

Pull request review commentdocker/cli

document deprecation of legacy `~/.dockercfg` config-file

 The table below provides an overview of the current status of deprecated feature  Status     | Feature                                                                                                                            | Deprecated | Remove -----------|------------------------------------------------------------------------------------------------------------------------------------|------------|------------+Deprecated | [Support for the legacy `~/.dockercfg` configuration file for authentication](#support-for-legacy-dockercfg-configuration-files)   | v20.03.0   | -

Isn't it removed instead of deprecated ?

thaJeztah

comment created time in 12 days

issue commentcnabio/cnab-to-oci

Surface error(s) from fixup to API consumers

The current behavior has been implemented by this commit https://github.com/cnabio/cnab-to-oci/commit/534000ad0ca3e0fbcc7b459421c8d25f4bde1a22 As stated in the comment:

 The way `fixupBaseImage` works has been changed. Instead of having a bunch
of `if/else` a list of fixups functions is provided. Those functions are run
one after the other. If the function returns an error, then we "try" with the
next one. If the function returns a flag indicated it's OK, it means the
image has been resolved, directly or using relocation map or after a push.
Conditions (like checking the relocation map or the `pushImages` flag) are
checked inside functions.

The order is the following:

1. try to push by digest if image value is not set
2. try to resolve
3. try to resolve using the relocation map
4. try to push from local image store

It means that it is ok for the functions to fail and fallback to the next one. I just checked the patch your tried https://github.com/cnabio/cnab-to-oci/compare/master...vdice:fix/fixup-return-err but I think it won't work (the Fixup fails only if all the fallbacks have been tried).

So yes there may be multiple way of getting the errors: 1/ wrap all the errors together and return them at the end 2/ connect to the logrus logger and print the debug messages. If I remember correctly that's the way we did it on docker/app: https://github.com/docker/app/blob/master/internal/commands/push.go#L119 https://github.com/docker/app/blob/master/internal/log/log.go#L10:1

vdice

comment created time in 12 days

pull request commentcnabio/cnab-spec

Add parameter sources custom extension

@carolynvs there's a DCO issue with your last "Fix typo" commit 🐱

carolynvs

comment created time in 12 days

Pull request review commentcnabio/cnab-go

Fix ULID generation

 func (c Claim) Validate() error { 	// validate the Result 	return errors.Wrap(c.Result.Validate(), "claim validation failed") }++// ulidMutex guards the generation of ULIDs, because the use of rand+// is not thread-safe.+var ulidMutex sync.Mutex++// ulidEntropy must be set once and reused when generating ULIDs, to guarantee+// that each ULID is monotonically increasing.+var ulidEntropy = ulid.Monotonic(rand.New(rand.NewSource(time.Now().UnixNano())), 0)++// MustNewULID generates a string representation of a ULID and panics on failure+// instead of returning an error.+func MustNewULID() string {+	result, err := NewULID()+	if err != nil {+		panic(err)+	}+	return result+}++// NewULID generates a string representation of a ULID.+func NewULID() (string, error) {+	ulidMutex.Lock()

That doesn't yield increasing ulids unfortunately when called successively within small timeframes.

Indeed 🤦

Because what we are using is borked. 😀

Well I guess your implementation is then the less worst option 😄 But I think we then need make sure that the NewULID and MustNewULID function documentations stated explicitly that they are thread safe and use a global mutex.

carolynvs

comment created time in 12 days

Pull request review commentcnabio/cnab-go

Fix ULID generation

 func (c Claim) Validate() error { 	// validate the Result 	return errors.Wrap(c.Result.Validate(), "claim validation failed") }++// ulidMutex guards the generation of ULIDs, because the use of rand+// is not thread-safe.+var ulidMutex sync.Mutex++// ulidEntropy must be set once and reused when generating ULIDs, to guarantee+// that each ULID is monotonically increasing.+var ulidEntropy = ulid.Monotonic(rand.New(rand.NewSource(time.Now().UnixNano())), 0)++// MustNewULID generates a string representation of a ULID and panics on failure+// instead of returning an error.+func MustNewULID() string {+	result, err := NewULID()+	if err != nil {+		panic(err)+	}+	return result+}++// NewULID generates a string representation of a ULID.+func NewULID() (string, error) {+	ulidMutex.Lock()

I'm a bit concerned with locking everything everytime we update or create a new Claim. The ULID documentation says the following:

Please note that rand.Rand from the math package is not safe for concurrent use. Instantiate one per long living go-routine or use a sync.Pool if you want to avoid the potential contention of a locked rand.Source as its been frequently observed in the package level functions.

What about creating a new instance of rand and entropy each time we need it instead? It may not make sense from a cryptographic point of view, but I think it's not the point here (otherwise we would use cryptographic rand instead?) What about the following ?

func NewULID() (string, error) {
    	now := time.Now()
	entropy := ulid.Monotonic(rand.New(rand.NewSource(now.UnixNano())), 0)
        result, err := ulid.New(ulid.Timestamp(now), entropy)
  	if err != nil {
		return "", errors.Wrap(err, "could not generate a new ULID")
	}
        return result.String(), nil
}
carolynvs

comment created time in 12 days

Pull request review commentcnabio/cnab-spec

Clarify how to verify & inspect in-toto metadata

 In order to download and verify a bundle, a compliant runtime MUST take the foll 1. Download the (thin or thick) bundle itself. This operation can follow the [CNAB Registries Specification][registry-spec] for thin bundles and pull the bundle from an OCI registry, or use other protocols of obtaining it. 1. Compare the observed hashes of the downloaded bundle to the trusted hashes. If they are not equal, the runtime MUST discard the downloaded bundle, report the error, and stop execution. Otherwise, go to the next step. 1. If there is [associated in-toto metadata][metadata-repository] about the bundle, use the [TUF workflow][tuf-workflow] to download in-toto root layout, public keys for the root layout, and link metadata for the bundle, and go to the next step. Otherwise, halt, and return the verified bundle to the user.-1. Call the in-toto runtime to [inspect and verify](https://github.com/in-toto/docs/blob/e9806a000c32dea73f6044a140386f601c7d4e18/in-toto-spec.md#52-verifying-the-final-product) the bundle using the downloaded root layout, public keys for the root layout, link metadata, and the bundle itself. If the verification fails, the runtime MUST discard the downloaded bundle, report the error, and stop execution.  Otherwise, halt, and return the verified bundle to the user.+1. Call the in-toto runtime to [verify and inspect](https://github.com/in-toto/docs/blob/e9806a000c32dea73f6044a140386f601c7d4e18/in-toto-spec.md#52-verifying-the-final-product) the bundle using the downloaded root layout, public keys for the root layout, link metadata, and the bundle itself. The bundle runtime MAY run in-toto directly on the operating system, in a default container image provided by the bundle runtime, or in a custom container image provided by the user. It is up to the bundle developers to ensure that in-toto inspections are as portable as possible. If the verification and inspection of the bundle fails for any reason, the runtime MUST discard the downloaded bundle, report the error, and stop execution.  Otherwise, it MUST halt, and return the verified bundle to the user.

Question:

Otherwise, it MUST halt, and return the verified bundle to the user.

Do we really need to specify that the process needs to halt? 🤔 Why does it need to return the verified bundle? Did the in-toto runtime mutate it? Otherwise it should be the same as the downloaded one?

trishankatdatadog

comment created time in 13 days

Pull request review commentcnabio/cnab-spec

Clarify how to verify & inspect in-toto metadata

 In order to download and verify a bundle, a compliant runtime MUST take the foll 1. Download the (thin or thick) bundle itself. This operation can follow the [CNAB Registries Specification][registry-spec] for thin bundles and pull the bundle from an OCI registry, or use other protocols of obtaining it. 1. Compare the observed hashes of the downloaded bundle to the trusted hashes. If they are not equal, the runtime MUST discard the downloaded bundle, report the error, and stop execution. Otherwise, go to the next step. 1. If there is [associated in-toto metadata][metadata-repository] about the bundle, use the [TUF workflow][tuf-workflow] to download in-toto root layout, public keys for the root layout, and link metadata for the bundle, and go to the next step. Otherwise, halt, and return the verified bundle to the user.-1. Call the in-toto runtime to [inspect and verify](https://github.com/in-toto/docs/blob/e9806a000c32dea73f6044a140386f601c7d4e18/in-toto-spec.md#52-verifying-the-final-product) the bundle using the downloaded root layout, public keys for the root layout, link metadata, and the bundle itself. If the verification fails, the runtime MUST discard the downloaded bundle, report the error, and stop execution.  Otherwise, halt, and return the verified bundle to the user.+1. Call the in-toto runtime to [verify and inspect](https://github.com/in-toto/docs/blob/e9806a000c32dea73f6044a140386f601c7d4e18/in-toto-spec.md#52-verifying-the-final-product) the bundle using the downloaded root layout, public keys for the root layout, link metadata, and the bundle itself. The bundle runtime MAY run in-toto directly on the operating system, in a default container image provided by the bundle runtime, or in a custom container image provided by the user. It is up to the bundle developers to ensure that in-toto inspections are as portable as possible. If the verification and inspection of the bundle fails for any reason, the runtime MUST discard the downloaded bundle, report the error, and stop execution.  Otherwise, it MUST halt, and return the verified bundle to the user.

nit: extra space before Otherwise

trishankatdatadog

comment created time in 13 days

push eventdocker/containerd-packaging

Tibor Vass

commit sha fbe9af00763b1fc2d553977d0670f4317e2061fe

Add checkout.sh to handle tags with shallow clones Commit 9706347c34524feb83d75a7119ea88311b41e668 changed to shallow clones but fetching a tag ref does not download the tag itself. This patch makes sure that the tag (or branch) is downloaded otherwise fallsback to fetching the commit hash as it did before. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Silvin Lubecki

commit sha 62a382c956a3e2f4b53ac70155b5dc2f7c5729d9

Merge pull request #181 from tiborvass/fix-version Add checkout.sh to handle tags with shallow clones

view details

push time in 13 days

PR merged docker/containerd-packaging

Add checkout.sh to handle tags with shallow clones

Commit 9706347c34524feb83d75a7119ea88311b41e668 changed to shallow clones but fetching a tag ref does not download the tag itself. This patch makes sure that the tag (or branch) is downloaded otherwise fallsback to fetching the commit hash as it did before.

Signed-off-by: Tibor Vass tibor@docker.com

Ref #173

+41 -4

0 comment

2 changed files

tiborvass

pr closed time in 13 days

pull request commentdocker/cli

-buildmode=pie is not supported for the mips arch

@XiaodongLoong Do you think we also need to backport that fix on 19.03 ?

XiaodongLoong

comment created time in 13 days

push eventdocker/cli

Xiaodong Liu

commit sha eeafa401549f33c6ac03f85f863406a11b3867ea

-buildmode=pie is not supported for the mips arch reference: https://github.com/containerd/containerd/commit/4c99c81326f4026fb8c0b8c5e10542205d99c321 Signed-off-by: Xiaodong Liu <liuxiaodong@loongson.cn>

view details

Silvin Lubecki

commit sha 5bf109154fa97a8f6e7666b9d0e65e7578a7e935

Merge pull request #2507 from XiaodongLoong/master -buildmode=pie is not supported for the mips arch

view details

push time in 13 days

PR merged docker/cli

-buildmode=pie is not supported for the mips arch status/2-code-review

reference: https://github.com/containerd/containerd/commit/4c99c81326f4026fb8c0b8c5e10542205d99c321

Signed-off-by: liuxiaodong liuxiaodong@loongson.cn

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+11 -1

3 comments

1 changed file

XiaodongLoong

pr closed time in 13 days

PR merged docker/cli

vendor: beorn7/perks v1.0.1 status/2-code-review

full diff: https://github.com/beorn7/perks/compare/e7f67b54abbeac9c40a31de0f81159e4cafebd6a...v1.0.1

adds go module support

+4 -1

1 comment

2 changed files

thaJeztah

pr closed time in 13 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha cf543e1308698173e46bf8e46c5e280911ae7599

vendor: mitchellh/mapstructure v1.0.0 we were only one commit behind v1.0.0, so updating to that version; we can do a follow-up to update to the latest minor release (v1.3.0) full diff: https://github.com/mitchellh/mapstructure/compare/f15292f7a699fcc1a38a80977f80a046874ba8ac...v1.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 950b1020abfc12bf7c19d8f15ad7882f47c5ab65

Merge pull request #2521 from thaJeztah/bump_mapstructure vendor: mitchellh/mapstructure v1.0.0

view details

push time in 13 days

PR merged docker/cli

vendor: mitchellh/mapstructure v1.0.0 process/cherry-pick status/2-code-review

we were only one commit behind v1.0.0, so updating to that version; we can do a follow-up to update to the latest minor release (v1.3.0)

full diff: https://github.com/mitchellh/mapstructure/compare/f15292f7a699fcc1a38a80977f80a046874ba8ac...v1.0.0

+2 -1

1 comment

2 changed files

thaJeztah

pr closed time in 13 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 66dd9f29fa2993caa7c242779e09b9a246f742b6

vendor: beorn7/perks v1.0.1 full diff: https://github.com/beorn7/perks/compare/e7f67b54abbeac9c40a31de0f81159e4cafebd6a...v1.0.1 adds go module support Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha fa0e2038b61d9b4c1e341bab881611f165214f46

Merge pull request #2522 from thaJeztah/bump_perks vendor: beorn7/perks v1.0.1

view details

push time in 13 days

create barnchsilvin-lubecki/cli

branch : clean-plugin-doc

created branch time in 14 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 4d948e468b5c4980db74618d853b2aa10ffdf365

docs: more Markdown touch-ups - replace the "none" code-hint with "console" - some changes in the "experimental" instructions - reformat some notes - reformat / re-indent JSON output to use 2 spaces (for consistency) - split JSON outputs to separate code-block so that it can be highlighted Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 13ee065e954da5bf867a70520bf4d4f998848146

Merge pull request #2519 from thaJeztah/markup_touch_ups docs: more Markdown touch-ups

view details

push time in 14 days

PR merged docker/cli

docs: more Markdown touch-ups kind/docs process/cherry-pick status/3-docs-review
  • replace the "none" code-hint with "console"
  • some changes in the "experimental" instructions
  • reformat some notes
  • reformat / re-indent JSON output to use 2 spaces (for consistency)
  • split JSON outputs to separate code-block so that it can be highlighted
+455 -374

0 comment

15 changed files

thaJeztah

pr closed time in 14 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 0c5f97ed7210474b5dc4d2838b45f7ea8a2354f8

compose: add build.extra_hosts to v3.9 schema This is not currently used by the CLI, but can be used by docker compose to bring parity on this feature with the compose v2.4 schema. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha ce2a9faf1b79b9f12a5e930a53652379f5196b0b

Merge pull request #2517 from thaJeztah/compose_file_build_extra_hosts compose: add build.extra_hosts to v3.9 schema

view details

push time in 14 days

PR merged docker/cli

compose: add build.extra_hosts to v3.9 schema impact/compose-file status/2-code-review

This is not currently used by the CLI, but can be used by docker compose to bring parity on this feature with the compose v2.4 schema.

relates to https://github.com/docker/compose/issues/7323

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+55 -39

1 comment

5 changed files

thaJeztah

pr closed time in 14 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 8434242c743c051a56381c280eeec7518a9662dd

config: don't call homedir on init() This patch changes the package to lazily obtain the user's home- directory on first use, instead of when initializing the package. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 8a30653ed5276179cc4dc0978af13ea2068c7d4e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 1705e47cdf5a5f66a565278b2a13377a3a7f7d3c

Merge pull request #2508 from thaJeztah/19.03_backport_config_dont_init [19.03 backport] config: don't call homedir on init()

view details

push time in 14 days

PR merged docker/cli

[19.03 backport] config: don't call homedir on init() area/context status/2-code-review

This patch changes the package to lazily obtain the user's home-directory on first use, instead of when initializing the package.

backport of https://github.com/docker/cli/pull/2161

+9 -2

0 comment

1 changed file

thaJeztah

pr closed time in 14 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 62a9babca6648c7f1fc76a31184ac3a2e1bdd439

vendor: k8s.io/klog v1.0.0-2-g4ad0115 Temporarily vendoring tip of the release-1.x branch, to address docker context inspect being slow on Windows because this package performs user lookup through `os.Current()` during `init()`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 466c50f939c187824b620ce6b0cc8e57795c310f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha a9a83d2e71386f853a5b184e977f1bb127717a3a

Merge pull request #2516 from thaJeztah/19.03_backport_bump_klog [19.03 backport] vendor: k8s.io/klog v1.0.0-2-g4ad0115

view details

push time in 15 days

PR merged docker/cli

[19.03 backport] vendor: k8s.io/klog v1.0.0-2-g4ad0115 area/context area/kubernetes platform/windows status/2-code-review

backport of https://github.com/docker/cli/pull/2515 for 19.03

NOTE cherry-pick was not clean, because 19.03 uses older versions of kubernetes. I resolved the conflict in vendor.conf, and re-vendored the dependency.

Temporarily vendoring tip of the release-1.x branch, to address docker context inspect being slow on Windows because this package performs user lookup through os.Current() during init().

fixes https://github.com/docker/cli/issues/2420

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

Fix `docker context inspect` being slow on Windows
+196 -72

3 comments

5 changed files

thaJeztah

pr closed time in 15 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 345b0e79e5315d345445ef24555a172f1fce44c7

vendor: pkg/errors v0.9.1 full diff: https://github.com/pkg/errors/compare/v0.8.1...v0.9.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 082a8bd8920dfa1889e3e216a7e5a0e62f0f677b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 9a57ea886934a79c17663ae22640f2288e3a85a1

Update some uses of errors.Cause() to errors.Is() Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit bb7ef2cb3afba7787388cc9d65017b8135393ec8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha ae2012ccedef0981ae448582cd1519dd39fcc2f3

Merge pull request #2518 from thaJeztah/19.03_backport_bump_pkg_errors [19.03 backport] vendor: pkg/errors v0.9.1

view details

push time in 15 days

PR merged docker/cli

[19.03 backport] vendor: pkg/errors v0.9.1 status/2-code-review

backport of https://github.com/docker/cli/pull/2512

+106 -20

0 comment

8 changed files

thaJeztah

pr closed time in 15 days

PR closed docker/docker-ce-packaging

[master] Check built packages

Added scripts to check deb and rpm packages just after building them.

image

+202 -5

3 comments

4 changed files

silvin-lubecki

pr closed time in 15 days

pull request commentdocker/docker-ce-packaging

[master] Check built packages

Closing this one for now

silvin-lubecki

comment created time in 15 days

push eventdocker/cli

Maciej Kalisz

commit sha e06fc01c1bfb860c9ef1db32f5497cac89e8ec76

Update dead link and add missing info on COPY 1. Fix dead URL to [Dockerfile best practices](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#leverage-build-cache). 2. Add missing information about cache invalidation by `COPY`. It works in the same way as in the case of `ADD`. Informing only about the `ADD`s behavior is misleading as one can infer that these two directives differ in this regard. 3. Add missing info on RUN cache invalidation by COPY Signed-off-by: Maciej Kalisz <maciej.d.kalisz@gmail.com> (cherry picked from commit ef414633d6365b84693dc32b8dcc3ef7639d64cc) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha dbc73eafcb8842d5d43d410e2410b0556a0c1b52

docs: fix, and touch-up "docker context" docs Using `/var/run/docker.sock` as docker host is invalid, and causes an error, so adding `unix://` to it. In addition, we document the name of the context to go after the options, so change the order in the examples. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 803b9071e744aa2c97ec691d8653ef3b5ec1880b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 052a71c4d0655c666ecf8f35d3476c2aedea1de4

Merge pull request #2509 from thaJeztah/19.03_backport_docs_fixes [19.03 backport] documentation fixes

view details

push time in 15 days

PR merged docker/cli

[19.03 backport] documentation fixes impact/documentation kind/docs status/3-docs-review

backports of:

  • https://github.com/docker/cli/pull/2192 Update dead link and add missing info on COPY
  • https://github.com/docker/cli/pull/2501 docs: fix, and touch-up "docker context" docs
+96 -51

1 comment

9 changed files

thaJeztah

pr closed time in 15 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha d10e2b9a6d3dba7858ff1b6b827a7c962ef3f4b2

vendor: golang.org/x/sys 85ca7c5b95cdf1e557abb38a283d1e61a5959c31 full diff: https://github.com/golang/sys/compare/d5e6a3e2c0ae16fc7480523ebcb7fd4dd3215489...85ca7c5b95cdf1e557abb38a283d1e61a5959c31 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha f6541cfd80c765e8898a9c1de7dc1b57fdd98940

vendor: moby/term 73f35e472e8f0a3f91347164138ce6bd73b756a9 full diff: https://github.com/moby/term/compare/063f2cd0b49dbb0752774d1cb649998d91424fea...73f35e472e8f0a3f91347164138ce6bd73b756a9 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha f327b97d372a9dfd57679a2a0f5705f7e31e869f

Merge pull request #2511 from thaJeztah/bump_term vendor: moby/term 73f35e472e8f0a3f91347164138ce6bd73b756a9 (and dependencies)

view details

push time in 15 days

PR merged docker/cli

vendor: moby/term 73f35e472e8f0a3f91347164138ce6bd73b756a9 (and dependencies) status/2-code-review
  • vendor: golang.org/x/sys 85ca7c5b95cdf1e557abb38a283d1e61a5959c31
    • full diff: https://github.com/golang/sys/compare/d5e6a3e2c0ae16fc7480523ebcb7fd4dd3215489...85ca7c5b95cdf1e557abb38a283d1e61a5959c31
  • vendor: moby/term 73f35e472e8f0a3f91347164138ce6bd73b756a9
    • full diff: https://github.com/moby/term/compare/063f2cd0b49dbb0752774d1cb649998d91424fea...73f35e472e8f0a3f91347164138ce6bd73b756a9
+14198 -90886

0 comment

80 changed files

thaJeztah

pr closed time in 15 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 082a8bd8920dfa1889e3e216a7e5a0e62f0f677b

vendor: pkg/errors v0.9.1 full diff: https://github.com/pkg/errors/compare/v0.8.1...v0.9.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha bb7ef2cb3afba7787388cc9d65017b8135393ec8

Update some uses of errors.Cause() to errors.Is() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha ae97466ae161df1f657110a3c8903563fcc7fb76

Merge pull request #2512 from thaJeztah/bump_pkg_errors vendor: pkg/errors v0.9.1

view details

push time in 15 days

PR merged docker/cli

vendor: pkg/errors v0.9.1 process/cherry-pick status/2-code-review

full diff: https://github.com/pkg/errors/compare/v0.8.1...v0.9.1

also updated some uses of errors.Cause() to errors.Is()

+106 -20

0 comment

8 changed files

thaJeztah

pr closed time in 15 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 84c0a04097fe824d248e06395b96015e0cc3843a

vendor: Microsoft/hcsshim v0.8.9 full diff: https://github.com/microsoft/hcsshim/compare/v0.8.7...v0.8.9 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 65e139ee4aaf899518c3fdb83f768f37a302182c

Merge pull request #2510 from thaJeztah/bump_hcsshim vendor: Microsoft/hcsshim v0.8.9

view details

push time in 15 days

PR merged docker/cli

vendor: Microsoft/hcsshim v0.8.9 status/2-code-review

full diff: https://github.com/microsoft/hcsshim/compare/v0.8.7...v0.8.9

+745 -349

1 comment

38 changed files

thaJeztah

pr closed time in 15 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 466c50f939c187824b620ce6b0cc8e57795c310f

vendor: k8s.io/klog v1.0.0-2-g4ad0115 Temporarily vendoring tip of the release-1.x branch, to address docker context inspect being slow on Windows because this package performs user lookup through `os.Current()` during `init()`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 73df7bb16a6ce7a53882d8141674225fa67b0cf5

Merge pull request #2515 from thaJeztah/bump_klog vendor: k8s.io/klog v1.0.0-2-g4ad0115

view details

push time in 15 days

PR merged docker/cli

vendor: k8s.io/klog v1.0.0-2-g4ad0115 area/context area/kubernetes platform/windows status/2-code-review

Temporarily vendoring tip of the release-1.x branch, to address docker context inspect being slow on Windows because this package performs user lookup through os.Current() during init().

Addresses https://github.com/docker/cli/issues/2420

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

Fix `docker context inspect` being slow on Windows
+26 -7

2 comments

2 changed files

thaJeztah

pr closed time in 15 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 803b9071e744aa2c97ec691d8653ef3b5ec1880b

docs: fix, and touch-up "docker context" docs Using `/var/run/docker.sock` as docker host is invalid, and causes an error, so adding `unix://` to it. In addition, we document the name of the context to go after the options, so change the order in the examples. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 3080921cd1e9c007b26692e7eb434b8540c9127f

Merge pull request #2501 from thaJeztah/fix_context_reference docs: fix, and touch-up "docker context" docs

view details

push time in 18 days

PR merged docker/cli

docs: fix, and touch-up "docker context" docs kind/docs process/cherry-pick status/3-docs-review

Using /var/run/docker.sock as docker host is invalid, and causes an error, so adding unix:// to it.

In addition, we document the name of the context to go after the options, so change the order in the examples.

@silvin-lubecki PTAL

+85 -48

0 comment

8 changed files

thaJeztah

pr closed time in 18 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 181e60499ff115d9c648f459a2515db16e5a2b04

docker version: add "context" to output This adds the currently selected "docker context" to the output of "docker version", which allows users to see which context is selected to produce the version output, and can be used (for example), to set the prompt to the currently selected context: (in `~/.bashrc`): ```bash function docker_context_prompt() { PS1="context: $(docker version --format='{{.Client.Context}}')> " } PROMPT_COMMAND=docker_context_prompt ``` After reloading the `~/.bashrc`, the prompt now shows the currently selected `docker context`: ```bash $ source ~/.bashrc context: default> docker context create --docker host=unix:///var/run/docker.sock my-context my-context Successfully created context "my-context" context: default> docker context use my-context my-context Current context is now "my-context" context: my-context> docker context use default default Current context is now "default" context: default> ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha bc938e4deac56e7d0e760b7b0fe8a11b77684bdf

docker info: add "context" to output Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 7cd6e893a1dd13808464cd683a9e57d73f6e83b7

Merge pull request #2500 from thaJeztah/version_context Add "context" to "docker version" and "docker info"

view details

push time in 18 days

PR merged docker/cli

Add "context" to "docker version" and "docker info" impact/changelog impact/documentation status/1-design-review

This adds the currently selected "docker context" to the output of docker version (and docker info), which allows users to see which context is selected to produce the version output, and can be used (for example), to set the prompt to the currently selected context:

(in ~/.bashrc):

function docker_context_prompt() {
        PS1="context: $(docker version --format='{{.Client.Context}}')> "
}

PROMPT_COMMAND=docker_context_prompt

After reloading the ~/.bashrc, the prompt now shows the currently selected docker context:

$ source ~/.bashrc
context: default> docker context create --docker host=unix:///var/run/docker.sock my-context
my-context
Successfully created context "my-context"
context: default> docker context use my-context
my-context
Current context is now "my-context"
context: my-context> docker context use default
default
Current context is now "default"
context: default>
+88 -15

3 comments

17 changed files

thaJeztah

pr closed time in 18 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 719169db632cb726644b92d78a1f9f614eead76f

Replace deprecated Cobra command.SetOutput() with command.SetOut() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 3017de7d6231e2517332fa2a9a287abfbbd0c39e

Merge pull request #2502 from thaJeztah/cobra_deprecated_function Replace deprecated Cobra command.SetOutput() with command.SetOut()

view details

push time in 19 days

PR merged docker/cli

Replace deprecated Cobra command.SetOutput() with command.SetOut() status/2-code-review

relates to https://github.com/docker/cli/pull/2488

+138 -138

1 comment

83 changed files

thaJeztah

pr closed time in 19 days

Pull request review commentdocker/cli

Add "context" to "docker version" and "docker info"

 Client:{{if ne .Platform.Name ""}} {{.Platform.Name}}{{end}}  Git commit:	{{.GitCommit}}  Built:	{{.BuildTime}}  OS/Arch:	{{.Os}}/{{.Arch}}+ Context:	{{.Context}}

I wonder if we really need this context in version 🤔 I think that version should mostly print static informations, but context is by nature purely dynamic. That said, it may help the user to understand which daemon she's talking to, so which daemon version are printed. I'm a bit over the fence 🤷

thaJeztah

comment created time in 19 days

PR closed docker/cli

Nothing

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+24 -74

2 comments

6 changed files

FrelDX

pr closed time in 19 days

pull request commentdocker/cli

Nothing

Hello @FrelDX , thank you for opening this PR, but after carefully reviewing it, I think this PR was opened inadvertently, so I will close it now.

FrelDX

comment created time in 19 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha df5cedfc81db32fd325143da07bebae472690935

vendor: spf13/cobra v1.0.0, go-md2man v2.0.0, blackfriday v2.0.1 full diff: https://github.com/spf13/cobra/compare/v0.0.3...v1.0.0 Notable Changes - Fish completion (including support for Go custom completion) - API (urgent): Rename BashCompDirectives to ShellCompDirectives - Remove/replace SetOutput on Command - deprecated - Custom completions coded in Go (instead of Bash) - Partial Revert of 922 - Correct documentation for InOrStdin - Apply formatting to templates - Revert change so help is printed on stdout again - Update md2man to v2.0.0 - update viper to v1.4.0 - Update cmd/root.go example in README.md vendor: update cpuguy83/go-md2man v2.0.0 full diff: https://github.com/cpuguy83/go-md2man/compare/v1.0.8...v2.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha c80f2306e55a26a17f2a903a4924158b08317b35

Merge pull request #2488 from thaJeztah/bump_cobra vendor: spf13/cobra v1.0.0, go-md2man v2.0.0, blackfriday v2.0.1

view details

push time in 21 days

PR merged docker/cli

vendor: spf13/cobra v1.0.0, go-md2man v2.0.0, blackfriday v2.0.1 status/2-code-review

depends on:

  • [x] https://github.com/docker/cli/pull/2487 Implement IPNetSliceValue locally, and un-fork spf13/pflag (to get a clean merge)
  • [x] ~https://github.com/docker/cli/pull/2489 vendor: update cpuguy83/go-md2man v2.0.0~ included in this PR

vendor: update spf13/cobra v1.0.0

full diff: https://github.com/spf13/cobra/compare/v0.0.3...v1.0.0

Announcing v1.0.0 of Cobra. 🎉

Notable Changes

  • Fish completion (including support for Go custom completion)
  • API (urgent): Rename BashCompDirectives to ShellCompDirectives
  • Remove/replace SetOutput on Command - deprecated
  • Custom completions coded in Go (instead of Bash)
  • Partial Revert of 922
  • Correct documentation for InOrStdin
  • Apply formatting to templates
  • Revert change so help is printed on stdout again
  • Update md2man to v2.0.0
  • update viper to v1.4.0
  • Update cmd/root.go example in README.md

vendor: update cpuguy83/go-md2man v2.0.0

full diff: https://github.com/cpuguy83/go-md2man/compare/v1.0.8...v2.0.0

+5174 -3463

3 comments

44 changed files

thaJeztah

pr closed time in 21 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 4f65b65e81fe8166615e629c7b52235513f837ce

vendor konsorten/go-windows-terminal-sequences v1.0.3 full diff: https://github.com/konsorten/go-windows-terminal-sequences/compare/v1.0.2...v1.0.3 Fixes a panic when using logrus on Go 1.14 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha cd7fb33f3f5e7ec34b91d5e860d8aadde1550919

Merge pull request #2477 from thaJeztah/update_terminal_sequences vendor konsorten/go-windows-terminal-sequences v1.0.3

view details

push time in 21 days

PR merged docker/cli

vendor konsorten/go-windows-terminal-sequences v1.0.3 process/cherry-pick status/2-code-review

full diff: https://github.com/konsorten/go-windows-terminal-sequences/compare/v1.0.2...v1.0.3

Fixes a panic when using logrus on Go 1.14

+3 -3

0 comment

3 changed files

thaJeztah

pr closed time in 21 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha dbd2fa5c3c2c3d31390bb87cee08a995d2a25396

vendor: remove unused dependencies from vendor.conf ``` 2020/05/03 21:45:38 WARNING: package github.com/containerd/ttrpc is unused, consider removing it from vendor.conf 2020/05/03 21:45:38 WARNING: package github.com/opencontainers/runtime-spec is unused, consider removing it from vendor.conf 2020/05/03 21:45:38 WARNING: package github.com/syndtr/gocapability is unused, consider removing it from vendor.conf ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha c567dee1a658612ced07c67efbb7949f00c2e9bb

Merge pull request #2490 from thaJeztah/remove_unused_dependencies vendor: remove unused dependencies from vendor.conf

view details

push time in 21 days

PR merged docker/cli

vendor: remove unused dependencies from vendor.conf status/2-code-review

these dependencies were no longer used since https://github.com/docker/cli/commit/0dc9d17a2ecf26067997b7d3cb3243f73cbc5e8d (https://github.com/docker/cli/pull/2447)

2020/05/03 21:45:38 WARNING: package github.com/containerd/ttrpc is unused, consider removing it from vendor.conf
2020/05/03 21:45:38 WARNING: package github.com/opencontainers/runtime-spec is unused, consider removing it from vendor.conf
2020/05/03 21:45:38 WARNING: package github.com/syndtr/gocapability is unused, consider removing it from vendor.conf

Signed-off-by: Sebastiaan van Stijn github@gone.nl

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+0 -3

0 comment

1 changed file

thaJeztah

pr closed time in 21 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 24ade3c13a401fdd70e1ba9fed8bde481d4cac30

vendor: sirupsen/logrus v1.6.0 full diff: https://github.com/sirupsen/logrus/compare/v1.5.0...v1.6.0 - Add flag to disable quotes in TextFormatter - Revert "fix race conditions on entry" - fixes Deadlock during Entry.Infof after upgrade to v1.5.0 - fixes Deadlock when using WithField inside of hook - fixes Overly-aggressive mutex locks Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 9be57cfcbc90f3faa6ebf22ba235c095b10693f0

Merge pull request #2486 from thaJeztah/bump_logrus vendor: sirupsen/logrus v1.6.0

view details

push time in 21 days

PR merged docker/cli

Reviewers
vendor: sirupsen/logrus v1.6.0 status/2-code-review

v1.6.0 was just released to fix some regressions in v1.5.0

full diff: https://github.com/sirupsen/logrus/compare/v1.5.0...v1.6.0

  • Add flag to disable quotes in TextFormatter
  • Revert "fix race conditions on entry"
    • fixes Deadlock during Entry.Infof after upgrade to v1.5.0
    • fixes Deadlock when using WithField inside of hook
    • fixes Overly-aggressive mutex locks
+10 -4

0 comment

4 changed files

thaJeztah

pr closed time in 21 days

push eventdocker/docker-ce-packaging

Sebastiaan van Stijn

commit sha fb44c6edeaf2f957e72c9b86ea625826e4210260

deb: use DEBIAN_FRONTEND=noninteractive for all dockerfiles This was needed for Ubuntu 20.04, but doesn't hurt to use for other versions as well. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha f062a0d867c8ce455d9c826a11f65b32601b39b0

Merge pull request #468 from thaJeztah/deb_noninteractive [master] deb: use DEBIAN_FRONTEND=noninteractive for all dockerfiles

view details

push time in 21 days

PR merged docker/docker-ce-packaging

[master] deb: use DEBIAN_FRONTEND=noninteractive for all dockerfiles

This was needed for Ubuntu 20.04, but doesn't hurt to use for other versions as well.

+8 -0

1 comment

8 changed files

thaJeztah

pr closed time in 21 days

push eventdocker/cli

Tengfei Wang

commit sha 83478fe7cb4334619754236c5e35e228498e5a12

try http for docker manifest --insecure Signed-off-by: Tengfei Wang <tfwang@alauda.io>

view details

Silvin Lubecki

commit sha 9387b99c36d1ca3f335c8d1d57a338150c4e238b

Merge pull request #2376 from davidwtf/master try http for docker manifest --insecure

view details

push time in 21 days

PR merged docker/cli

try http for docker manifest --insecure kind/experimental status/2-code-review

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did fixes #1631

- How I did it Add retry for http when https not work

- How to verify it docker manifest push --insecure 127.0.0.1:5000/test:v1

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+16 -5

3 comments

1 changed file

davidwtf

pr closed time in 21 days

issue closeddocker/cli

Docker manifest push ignoring --insecure

Description

When attempting to push a manifest to an insecure registry, the command fails, indicating an issue with the registry server giving an HTTP response to a HTTPS client. The documentation states that passing the --insecure flag into the push command should fix this, but it does nothing.

Steps to reproduce the issue:

  1. Create a manifest via docker manifest create --insecure 192.168.0.20:5000/my-img:latest 192.168.0.20:5000/my-img-arm:latest 192.168.0.20:5000/my-img-x86:latest
  2. Annotate the manifest via docker manifest annotate 192.168.0.20:5000/my-img:latest 192.168.0.20:5000/my-img-arm:latest --arch arm
  3. Attempt to push manifest via docker -D manifest push --insecure 192.168.0.20:5000/my-img:latest

Describe the results you received:

DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
DEBU[0000] hostDir: /etc/docker/certs.d/192.168.0.20:5000 
failed to configure transport: error pinging v2 registry: Get https://192.168.0.20:5000/v2/: http: server gave HTTP response to HTTPS client

This is the same exact result as when running without --insecure.

Describe the results you expected:

The manifest push succeeds.

Additional information you deem important (e.g. issue happens only occasionally):

I was having issues with manifest create as well until I updated my docker from 18.0.6 to 18.0.9. Docker pull/push with this insecure registry works fine.

Output of docker version:

Client:
 Version:           18.09.1
 API version:       1.39
 Go version:        go1.10.6
 Git commit:        4c52b90
 Built:             Wed Jan  9 19:35:31 2019
 OS/Arch:           linux/amd64
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          18.09.1
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.6
  Git commit:       4c52b90
  Built:            Wed Jan  9 19:02:44 2019
  OS/Arch:          linux/amd64
  Experimental:     true

Output of docker info:

Containers: 64
 Running: 24
 Paused: 0
 Stopped: 40
Images: 1149
Server Version: 18.09.1
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 9754871865f7fe2f4e74d43e2fc7ccd237edcbce
runc version: 96ec2177ae841256168fcf76954f7177af9446eb
init version: fec3683
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.15.0-43-generic
Operating System: Ubuntu 18.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 16
Total Memory: 31.33GiB
Name: my-server
ID: DVZR:G3ZK:DAL5:BUHT:IG3J:LL5R:ITDH:UMCI:WM3Y:KI3X:ERXF:XTKQ
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: true
Insecure Registries:
 192.168.0.20:5000
 127.0.0.0/8
Live Restore Enabled: false
Product License: Community Engine

WARNING: No swap limit support

Additional environment details (AWS, VirtualBox, physical, etc.):

The registry is hosted on the same server that I am attempting to push the manifest from. The registry was version 2.6.2 (didn't work), so I updated to 2.7.1 and the bug remains. Registry hash:

$ docker container inspect registry | jq .[0].Image
"sha256:116995fd662403e7ac3fd9dd698f95a7f9c8c3c321aa34cb7090a8721d68573a"

closed time in 21 days

stephencsnow

push eventdocker/cli

Sebastiaan van Stijn

commit sha 9a58504d3353d2166350b57533d4fb39a73513b9

docs: fix order of flags in usage, and fix missing quote Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha d096339f414ac47eacfd2d9a7da48ea76343e407

docs: update usage output for dockerd (19.03) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 563d666328f1a02f0a69785965d7d94c03e13b9a

Merge pull request #2491 from thaJeztah/update_dockerd_usage docs: update usage output for dockerd (19.03)

view details

push time in 21 days

PR merged docker/cli

docs: update usage output for dockerd (19.03) kind/docs process/cherry-picked status/3-docs-review

Updates the output to reflect the output of flags available in 19.03

+22 -17

1 comment

1 changed file

thaJeztah

pr closed time in 21 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 55a5ab0f0a1b84a0265308b5a2f2b5e535e77dc1

docs: fix order of flags in usage, and fix missing quote Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 9a58504d3353d2166350b57533d4fb39a73513b9) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 65c37227a93b193725b2f73b28850b761ffd526c

docs: update usage output for dockerd (19.03) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit d096339f414ac47eacfd2d9a7da48ea76343e407) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha bef0d567ac506aa52d2d363f8af98c6b8efa3e0f

Merge pull request #2493 from thaJeztah/19.03_backport_update_dockerd_usage [19.03 backport] docs: update usage output for dockerd (19.03)

view details

push time in 21 days

PR merged docker/cli

[19.03 backport] docs: update usage output for dockerd (19.03) kind/docs status/3-docs-review

backport of https://github.com/docker/cli/pull/2491

cherry-pick wasn't fully clean, due to master having some flags documented for 20.03

+22 -17

1 comment

1 changed file

thaJeztah

pr closed time in 21 days

push eventcnabio/cnab-go

Vaughn Dice

commit sha af934e422a86858b721165887e21383eb5b2e608

ref(docker.go): export ApplyConfigurationOptions Signed-off-by: Vaughn Dice <vadice@microsoft.com>

view details

Vaughn Dice

commit sha c46b74fc4e0cf61fef72a0e3bbb8bf420b45546a

ref(docker.go): container config fields on Driver no longer pointers Signed-off-by: Vaughn Dice <vadice@microsoft.com>

view details

Vaughn Dice

commit sha 9b6875f2cf938105a9c49fd60b66919f76fe6d03

keep deep copy logic for container config accessors Signed-off-by: Vaughn Dice <vadice@microsoft.com>

view details

Vaughn Dice

commit sha 5395191c27b9b2ccda76a6f4e6327e32215796ff

add config modification test Signed-off-by: Vaughn Dice <vadice@microsoft.com>

view details

Silvin Lubecki

commit sha 1db08a3212f797f6fce56bfbfb65431eaa1db88e

Merge pull request #206 from vdice/fix/container-config ref(docker.go): container config fields on Driver no longer pointers

view details

push time in 23 days

PR merged cnabio/cnab-go

Reviewers
ref(docker.go): container config fields on Driver no longer pointers
  • update config fields on Driver struct to not be pointers

    • When consuming the latest code for use in Porter (to add tests around Porter's configuration options in this area), I found it problematic that some struct fields were pointers (containerCfg and containerHostCfg). I started to go down the path of creating methods in this library to return default Driver objects (NewDriver() would return a Driver with initialized/empty field references) but then I realized perhaps the code simplifications and ease of use that came with switching the fields to be actual values would be warranted here. What do reviewers think? Is there Golang best practice w/r/t fields in structs being pointers? (Avoid? Only use if initializer method(s) are provided?)
  • export ApplyConfigurationOptions

    • Porter will use this method to apply its configuration options without having to call exec on the driver in unit tests
+52 -26

0 comment

2 changed files

vdice

pr closed time in 23 days

Pull request review commentcnabio/cnab-go

ref(docker.go): container config fields on Driver no longer pointers

 func (d *Driver) exec(op *driver.Operation) (driver.OperationResult, error) { 	return opResult, err } -func (d *Driver) applyConfigurationOptions() error {+// ApplyConfigurationOptions applies the configuration options set on the driver+func (d *Driver) ApplyConfigurationOptions() error {

You are right I forgot this function! Ok to me then :+1:

vdice

comment created time in 23 days

push eventdocker/docker-ce-packaging

Tonis Tiigi

commit sha 50aa8f20fdc94c31c69d0a046e1ac72458fc79d9

buildx: use v0.4.1 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

view details

Silvin Lubecki

commit sha 75041fea28a3f365cae597ee6dbd63089306e7e9

Merge pull request #460 from tonistiigi/buildx-v0.4 [master] buildx: use v0.4.1

view details

push time in 24 days

Pull request review commentcnabio/cnab-go

ref(docker.go): container config fields on Driver no longer pointers

 func (d *Driver) exec(op *driver.Operation) (driver.OperationResult, error) { 	return opResult, err } -func (d *Driver) applyConfigurationOptions() error {+// ApplyConfigurationOptions applies the configuration options set on the driver+func (d *Driver) ApplyConfigurationOptions() error {

Question: I wonder what is the use case in porter to export this function? As dockerConfigurationOptions is not exported so noone can add new options, this function shouldn't be called twice? Or maybe from an API point of view this function should then have a variadic parameter with new options to apply?

vdice

comment created time in 25 days

push eventdocker/cli

Anca Iordache

commit sha 25f04876d16b5ad2f120ca04ed77c71c6373637f

app-214 Load Client info in getter function Signed-off-by: Anca Iordache <anca.iordache@docker.com> Possible approach for client info - split ClientInfo() into ClientInfo() and loadClientInfo() - split ConfigFile() into ConfigFile() and loadConfigFile() - ConfigFile() and ClientInfo() call their corresponding loadXX function if it has not yet been loaded; this allows them to be used before Initialize() was called. - Initialize() *always* (re-)loads the configuration; this makes sure that the correct configuration is used when actually calling commands. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 22a5dad847f53dd5d1bde9a61027d13c0cbce94d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c44c18e088d669612ff724e3c3212eee00a18d0d

docker build: check experimental --platform on pre-run Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit a88a1bea2360506a794d71f2be2a7477f8b4ebbb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha cf663b526a34f3e7911e6e60138138c2023aa844

cli: perform feature detection lazily - Perform feature detection when actually needed, instead of during initializing - Version negotiation is performed either when making an API request, or when (e.g.) running `docker help` (to hide unsupported features) - Use a 2 second timeout when 'pinging' the daemon; this should be sufficient for most cases, and when feature detection failed, the daemon will still perform validation (and produce an error if needed) - context.WithTimeout doesn't currently work with ssh connections (connhelper), so we're only applying this timeout for tcp:// connections, otherwise keep the old behavior. Before this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m32.919s user 0m0.370s sys 0m0.227s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m32.072s user 0m0.029s sys 0m0.023s After this change: time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker help &> /dev/null' real 0m 2.28s user 0m 0.03s sys 0m 0.03s time sh -c 'DOCKER_HOST=tcp://42.42.42.41:4242 docker context ls &> /dev/null' real 0m 0.13s user 0m 0.02s sys 0m 0.02s Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit b39739123b845f872549e91be184cc583f5b387c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Silvin Lubecki

commit sha 39299333681b5c4ad47935b2b3e3717e80ef5495

Merge pull request #2457 from thaJeztah/19.03_backport_lazy_feature_detection [19.03 backport] cli: perform feature detection lazily

view details

push time in 25 days

PR merged docker/cli

[19.03 backport] cli: perform feature detection lazily status/2-code-review

based on top of https://github.com/docker/cli/pull/2456

backports of:

  • https://github.com/docker/cli/pull/2095 APP-214 Load Client info in getter function
  • https://github.com/docker/cli/pull/2424 cli: perform feature detection lazily
+149 -96

0 comment

4 changed files

thaJeztah

pr closed time in 25 days

more