profile
viewpoint

moby/moby 58252

Moby Project - a collaborative project for the container ecosystem to assemble container-based systems

moby/buildkit 2923

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit

iopipe/turtle 152

Turtle - functional composition for building lambda architectures in NodeJS

thyb/contentify 88

The easiest way to manage your online content

docker/gordon-bot 33

Gordon the turtle IRC bot to rebuild Jenkins builds.

docker/go 14

Go packages with small patches autogenerated (used for canonical/json)

icecrime/docker-api 5

Docker Remote API

moby/locker 4

This is a direct pull from https://github.com/moby/moby/tree/master/pkg/locker

aduermael/minecraft-docker-client 3

A simple Minecraft docker client, to visualize and run containers.

push eventmoby/moby

Sebastiaan van Stijn

commit sha 7cdced6f4b5a5c2b075c0d971920754664559ff1

vendor.conf: fix tar-split version comment We already updated to v0.11.1, but didn't update the comment itself Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 968133c86c0ae34f0904e83ebfa4472c623c74cc

vendor: opencontainers/go-digest v1.0.0 full diff: https://github.com/opencontainers/go-digest/compare/v1.0.0-rc1...v1.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 2513da195eef09acb56da21d7191aaa3b4ed4b35

Merge pull request #41467 from thaJeztah/bump_go_digest vendor: opencontainers/go-digest v1.0.0

view details

push time in 4 days

PR merged moby/moby

vendor: opencontainers/go-digest v1.0.0 status/2-code-review

to match the version used in containerd

full diff: https://github.com/opencontainers/go-digest/compare/v1.0.0-rc1...v1.0.0

+49 -43

0 comment

9 changed files

thaJeztah

pr closed time in 4 days

PullRequestReviewEvent

push eventmoby/moby

Sebastiaan van Stijn

commit sha 9fb324f00be66e27afd4172b509ec5525b588f81

vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b full diff: https://github.com/docker/libnetwork/compare/9e99af28df21367340c95a3863e31808d689c92a...d0951081b35fa4216fc4f0064bf065beeb55a74b - docker/libnetwork#2560 types: remove some dead code - docker/libnetwork#2562 client/mflag: remove use of docker/docker/pkg/homedir - docker/libnetwork#2576 Skip redundant kernel version checks - docker/libnetwork#2583 vendor: update docker to 7ca355652fe0e2f7401d424d65a81dc248360127 and reduce dependency graph Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 1dff568d45aae3a6682dbf7e3803feeddcfce8ea

Merge pull request #41466 from thaJeztah/bump_libnetwork vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b

view details

push time in 4 days

PR merged moby/moby

Reviewers
vendor: docker/libnetwork d0951081b35fa4216fc4f0064bf065beeb55a74b area/networking status/2-code-review

full diff: https://github.com/docker/libnetwork/compare/9e99af28df21367340c95a3863e31808d689c92a...d0951081b35fa4216fc4f0064bf065beeb55a74b

  • docker/libnetwork#2560 types: remove some dead code
  • docker/libnetwork#2562 client/mflag: remove use of docker/docker/pkg/homedir
  • docker/libnetwork#2576 Skip redundant kernel version checks
  • docker/libnetwork#2583 vendor: update docker to 7ca355652fe0e2f7401d424d65a81dc248360127 and reduce dependency graph
+70 -111

0 comment

12 changed files

thaJeztah

pr closed time in 4 days

PullRequestReviewEvent

push eventmoby/libnetwork

Sebastiaan van Stijn

commit sha b8d18e71c7153b256ebcee65b748c32b1efe103a

vendor.conf: reformat to match spacing in docker/docker Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha ad652e3a86d525bea8ed54274b2be4e86121e8b3

Replace use of deprecated functions Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 21fd714b38b6043b487a5dee49d92bf56e5630ef

Remove dependency on github.com/docker/docker/opts Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 1e1d807ebb3c0bb41707d15c0311cb64af145227

client/mflag: remove use of docker/docker/pkg/homedir The homedir package was only used to print default values for flags that contained paths inside the user's home-directory in a slightly nicer way (replace `/users/home` with `~`). Given that this is not critical, we can replace this with golang's function, which does not depend on libcontainer. There's still one use of the homedir package in docker/docker/opts, which is used by the dnet binary (but only requires the homedir package when running in rootless mode) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 0afc2b5d46535f401d501c7771c78175b2009f95

replace github.com/docker/docker/locker with github.com/moby/locker Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha a16ccc4a57fd188ec7116c85d31cb9b2a2027332

vendor: github.com/pkg/errors v0.9.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha da0cfd5bd9ad6a2565bcdf2b555eb8ebf39e4281

vendor: gotest.tools v3.0.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6bb77efbcbe867bb445367845f88c4f938e9bdcf

vendor: docker/go-events e31b211e4f1cd09aa76fe4ac244571fab96ae47f Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 7d0bb8294b85ce92b880abcbb9299a98eeb28761

vendor: github.com/gorilla/mux v1.8.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha d8e0bac5a96596c5db7f11e2ebe088f107cc7521

vendor: vishvananda/netns db3c7e526aae966c4ccfa6c8189b693d6ac5d202 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 8f608805f299ef416278956d3f54e322c50863ca

vendor: go.etcd.io/bbolt v1.3.5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 1cf468b503b61d4882175f7667e229753ec9576b

vendor: logrus v1.6.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c9d3d54d688fcd72e419ccf735c32fd91eb8903f

vendor: containerd/cgroups 318312a373405e5e91134d8063d04d59768a1bff Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 5c6943744ff05bf5a4fdf36b71712305c96d1c61

vendor github.com/Microsoft/hcsshim 9dcb42f100215f8d375b4a9265e5bba009217a85 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha a08808a097ef61661115458f2d590468d2cc27e1

vendor: runtime-spec v1.0.3-0.20200728170252-4d89ac9fbff6 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6533087dd8e76705afc2dba85c963a6c4c5da7a8

vendor: github.com/coreos/etcd v3.3.12 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 662113ac1cf1e253671ab1bb5975f59ed6046d45

vendor: golang.org/x/net ab34263943818b32f575efc978a3d24e80b04bd7 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 770081b5bdbef1e786d8e292020c23410d431392

vendor: golang.org/x/sys ed371f2e16b4b305ee99df548828de367527b76b Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha d66ed6b0ca36f406f30436f063d3ebc89fd28ac5

vendor: golang.org/x/sync cd5d95a43a6e21273425c7ae415d3df9ea832eeb Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 21149298bcfca250c8a9f27c1dfe3c9312fe7a1b

vendor: golang.org/x/crypto 75b288015ac94e66e3d6715fb68a9b41bf046ec2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

push time in 5 days

PR closed moby/libnetwork

bump gotest.tools v3.0.2 for compatibility with Go 1.14

full diff: https://github.com/gotestyourself/gotest.tools/compare/v2.3.0...v3.0.2

+179 -75

0 comment

26 changed files

thaJeztah

pr closed time in 5 days

PR closed moby/libnetwork

vendor: update docker and dependencies to 7ca355652fe0e2f7401d424d65a81dc248360127

Updating vendor dependencies to match with downstream docker again, so that CI runs with the same versions of these dependencies; see individual commits for details

+67378 -90632

1 comment

954 changed files

thaJeztah

pr closed time in 5 days

PR merged moby/libnetwork

vendor: update docker to 7ca355652fe0e2f7401d424d65a81dc248360127 and reduce dependency graph

replaces/closes

closes https://github.com/moby/libnetwork/pull/2582 closes https://github.com/moby/libnetwork/pull/2579 closes https://github.com/moby/libnetwork/pull/2564 closes https://github.com/moby/libnetwork/pull/2562 closes https://github.com/moby/libnetwork/pull/2535

+44076 -117141

0 comment

896 changed files

thaJeztah

pr closed time in 5 days

PR closed moby/libnetwork

cast Rdev of Stat_t to uint64 for mips

Signed-off-by: wanghuaiqing wanghuaiqing@loongson.cn

+1106 -316

0 comment

34 changed files

wanghuaiqing2010

pr closed time in 5 days

PR closed moby/libnetwork

Reduce dependency graph
+194 -15565

0 comment

189 changed files

thaJeztah

pr closed time in 5 days

PullRequestReviewEvent

push eventmoby/libnetwork

Sebastiaan van Stijn

commit sha b17744363ebb19fa4960e13a86082e75a3158bb4

types: remove some dead code These errors were not in use, so we can remove them Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 82a1ac7db2e6ed6971fc95ce7b5e8d89cfe4faa9

Merge pull request #2560 from thaJeztah/remove_dead_code types: remove some dead code

view details

push time in 5 days

PR merged moby/libnetwork

types: remove some dead code

These errors were not in use, so we can remove them

+0 -4

3 comments

1 changed file

thaJeztah

pr closed time in 5 days

PullRequestReviewEvent

push eventmoby/libnetwork

Sebastiaan van Stijn

commit sha e6de8aec2fc3cea888f620de490fc6ab83700878

client/mflag: remove use of docker/docker/pkg/homedir The homedir package was only used to print default values for flags that contained paths inside the user's home-directory in a slightly nicer way (replace `/users/home` with `~`). Given that this is not critical, we can replace this with golang's function, which does not depend on libcontainer. There's still one use of the homedir package in docker/docker/opts, which is used by the dnet binary (but only requires the homedir package when running in rootless mode) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha a925e7f61a98c6300a772f34b4e3fb35ec43e474

Merge pull request #2562 from thaJeztah/replace_pkg_homedir client/mflag: remove use of docker/docker/pkg/homedir

view details

push time in 5 days

PR merged moby/libnetwork

client/mflag: remove use of docker/docker/pkg/homedir

relates to https://github.com/moby/libnetwork/pull/2559#discussion_r434545503

The homedir package was only used to print default values for flags that contained paths inside the user's home-directory in a slightly nicer way (replace /users/home with ~).

Given that this is not critical, we can replace this with golang's function, which does not depend on libcontainer.

There's still one use of the homedir package in docker/docker/opts, which is used by the dnet binary (but only requires the homedir package when running in rootless mode);

https://github.com/moby/libnetwork/blob/13a4da01ec396d4bd59cc2108a7d183d7ac7fddd/cmd/dnet/dnet.go#L418-L419

calls out to opts.ParseHost(), which uses homedir.GetRuntimeDir()

https://github.com/moby/libnetwork/blob/7f60f05552dd6f88aa0a36640186fe155c471b82/vendor/github.com/docker/docker/opts/hosts.go#L54-L58

Perhaps we can work around that; will have to look into that.

+9 -4

2 comments

1 changed file

thaJeztah

pr closed time in 5 days

PullRequestReviewEvent

push eventmoby/libnetwork

Sebastiaan van Stijn

commit sha 2ba9404bd728fab810266e2a3c063d408eb5bab4

CircleCI: update to Docker 19.03.12 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 904409421970af5974e08ff1e4e86e49f1de9771

Makefile: enable BuildKit Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 87df7fafd93ce6ab4e8f161cc98b87c68a2f08b6

Merge pull request #2580 from thaJeztah/update_circleci CircleCI: update to Docker 19.03.12, and enable BuildKit

view details

push time in 5 days

PR merged moby/libnetwork

CircleCI: update to Docker 19.03.12, and enable BuildKit

The "stable" option gave Docker 17.09, which is pretty old

+10 -10

3 comments

2 changed files

thaJeztah

pr closed time in 5 days

PullRequestReviewEvent

issue commentmoby/buildkit

dockerfile: rename experimental channel

How about labs ? It's like experimental but not experimental (cannot be confused with other experimental stuff in docker).

tonistiigi

comment created time in 5 days

push eventdocker/docker-ce-packaging

Sebastiaan van Stijn

commit sha 2eec0a256ec6144ad713c55c164d5e039362f7b9

Update minimum containerd.io version to v1.3.0 The engine now defaults to the "io.containerd.runc.v2" shim, which is only available in containerd v1.3.0 and up. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 12d842d6689508d69628c9dd41eff21016b7dcaa

Merge pull request #480 from thaJeztah/bump_containerd_version [master] Update minimum containerd.io version to v1.3.0

view details

push time in 5 days

PR merged docker/docker-ce-packaging

[master] Update minimum containerd.io version to v1.3.0

Relates to https://github.com/moby/moby/pull/41210

The engine now defaults to the "io.containerd.runc.v2" shim, which is only available in containerd v1.3.0 and up.

Opening as draft, because no containerd.io v1.3.x packages are available yet, so verification will likely fail

+2 -2

0 comment

2 changed files

thaJeztah

pr closed time in 5 days

PullRequestReviewEvent

push eventmoby/moby

Sebastiaan van Stijn

commit sha 1ed6589e391f4cea9d984b8cb8d7333d49866dae

vendor: github.com/syndtr/gocapability 42c35b4376354fd554efc7ad35e0b7f94e3a0ffb full diff: https://github.com/syndtr/gocapability/compare/d98352740cb2c55f81556b63d4a1ec64c5a319c2...42c35b4376354fd554efc7ad35e0b7f94e3a0ffb Update Capabilities - Add `CAP_PERFMON` - Add `CAP_BPF` - Add `CAP_CHECKPOINT_RESTORE` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 7f7e4abb331a2973cfb3223710cc35a3e476b1b3

Merge pull request #41460 from thaJeztah/bump_gocapabilities vendor: github.com/syndtr/gocapability 42c35b4376354fd554efc7ad35e0b7f94e3a0ffb

view details

push time in 5 days

PR merged moby/moby

vendor: github.com/syndtr/gocapability 42c35b4376354fd554efc7ad35e0b7f94e3a0ffb impact/changelog status/2-code-review

full diff: https://github.com/syndtr/gocapability/compare/d98352740cb2c55f81556b63d4a1ec64c5a319c2...42c35b4376354fd554efc7ad35e0b7f94e3a0ffb

Update Capabilities

  • Add CAP_PERFMON
  • Add CAP_BPF
  • Add CAP_CHECKPOINT_RESTORE

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

Add support for `CAP_PERFMON`, `CAP_BPF`, and `CAP_CHECKPOINT_RESTORE` on supported kernels

- A picture of a cute animal (not mandatory but encouraged)

+53 -3

1 comment

3 changed files

thaJeztah

pr closed time in 5 days

PullRequestReviewEvent

push eventdocker/docker-ce

Tibor Vass

commit sha 19498650c3ed59dda1ee0659f02acaccd355b882

Bump VERSION to 19.03.13 Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 4484c46d9d1a2d10b8fc662923ad586daeedb04f

Merge pull request #658 from tiborvass/bump_19.03.13 Bump VERSION to 19.03.13

view details

push time in 6 days

PR merged docker/docker-ce

Reviewers
Bump VERSION to 19.03.13

Signed-off-by: Tibor Vass tibor@docker.com

Closes #656

+38 -1

0 comment

2 changed files

tiborvass

pr closed time in 6 days

PR opened docker/docker-ce

Bump VERSION to 19.03.13

Signed-off-by: Tibor Vass tibor@docker.com

Closes #656

+38 -1

0 comment

2 changed files

pr created time in 6 days

push eventtiborvass/docker-ce

Tibor Vass

commit sha 19498650c3ed59dda1ee0659f02acaccd355b882

Bump VERSION to 19.03.13 Signed-off-by: Tibor Vass <tibor@docker.com>

view details

push time in 6 days

create barnchtiborvass/docker-ce

branch : bump_19.03.13

created branch time in 6 days

push eventmoby/moby

Brian Goff

commit sha a958fc3e658683daa3c0eacc17cfa262783e84bb

Fix flakey test for log file rotate. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 5ea5c02c887392be1560e559a3c4d53445cf6505) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Brian Goff

commit sha ec14dc44d13b7cca6f4ac85a094d4d54fe8afad6

Fix log file rotation test. The test was looking for the wrong file name. Since compression happens asyncronously, sometimes the test would succeed and sometimes fail. This change makes sure to wait for the compressed version of the file since we can't know when the compression is going to occur. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit c6d860ace6a856f3a89d89275453271456aec242) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha bd33bbf0497b2327516dc799a5e541b720822a4c

Merge pull request #41314 from thaJeztah/19.03_backport_fix_racey_logger_test [19.03 backport] test-fixes for flaky test: TestCheckCapacityAndRotate

view details

push time in 6 days

PR merged moby/moby

[19.03 backport] test-fixes for flaky test: TestCheckCapacityAndRotate area/testing kind/bugfix status/2-code-review

fixes https://github.com/moby/moby/issues/41138 flaky test: TestCheckCapacityAndRotate

backports of:

  • https://github.com/moby/moby/pull/40969 Fix flakey test for log file rotate
  • https://github.com/moby/moby/pull/41239 Fix log file rotation test

Minor conflict in the imports because 19.03 is not yet on gotest.tools/v3

+21 -10

0 comment

1 changed file

thaJeztah

pr closed time in 6 days

PullRequestReviewEvent

push eventdocker/docker-ce-packaging

Sebastiaan van Stijn

commit sha 17de16ed2f81dc13514b0923b24392851211606c

Bump Golang 1.13.15 full diff: https://github.com/golang/go/compare/go1.13.14...go1.13.15 go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary package. See the Go 1.13.15 milestone on the issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 1e6aaf9d5041afc2e02aae9df2233b9b5194f6a4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 7302fe85cde410e26bc8f0156d90e221d96fdcdf

Merge pull request #493 from thaJeztah/19.03_backport_bump_golang_1.13.15 [19.03 backport] Bump Golang 1.13.15

view details

push time in 7 days

PR merged docker/docker-ce-packaging

[19.03 backport] Bump Golang 1.13.15

backport of https://github.com/docker/docker-ce-packaging/pull/492

full diff: https://github.com/golang/go/compare/go1.13.14...go1.13.15

go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary package. See the Go 1.13.15 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved

+1 -1

0 comment

1 changed file

thaJeztah

pr closed time in 7 days

PullRequestReviewEvent

Pull request review commentmoby/moby

[19.03 backport] test-fixes for flaky test: TestCheckCapacityAndRotate

 func TestCheckCapacityAndRotate(t *testing.T) { 	defer l.Close()  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))--	dStringer := dirStringer{dir}- 	_, err = os.Stat(f.Name() + ".1")-	assert.Assert(t, os.IsNotExist(err), dStringer)+	assert.Assert(t, os.IsNotExist(err), dirStringer{dir})  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))-	_, err = os.Stat(f.Name() + ".1")-	assert.NilError(t, err, dStringer)+	poll.WaitOn(t, checkFileExists(f.Name()+".1.gz"), poll.WithDelay(time.Millisecond), poll.WithTimeout(30*time.Second))  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))-	_, err = os.Stat(f.Name() + ".1")-	assert.NilError(t, err, dStringer)-	_, err = os.Stat(f.Name() + ".2.gz")-	assert.NilError(t, err, dStringer)+	poll.WaitOn(t, checkFileExists(f.Name()+".1.gz"), poll.WithDelay(time.Millisecond), poll.WithTimeout(30*time.Second))

Is it testing the same thing if it's checking for .1.gz instead?

thaJeztah

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentmoby/moby

[19.03 backport] test-fixes for flaky test: TestCheckCapacityAndRotate

 func TestCheckCapacityAndRotate(t *testing.T) { 	defer l.Close()  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))--	dStringer := dirStringer{dir}- 	_, err = os.Stat(f.Name() + ".1")-	assert.Assert(t, os.IsNotExist(err), dStringer)+	assert.Assert(t, os.IsNotExist(err), dirStringer{dir})  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))-	_, err = os.Stat(f.Name() + ".1")-	assert.NilError(t, err, dStringer)+	poll.WaitOn(t, checkFileExists(f.Name()+".1.gz"), poll.WithDelay(time.Millisecond), poll.WithTimeout(30*time.Second))  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))-	_, err = os.Stat(f.Name() + ".1")-	assert.NilError(t, err, dStringer)-	_, err = os.Stat(f.Name() + ".2.gz")-	assert.NilError(t, err, dStringer)+	poll.WaitOn(t, checkFileExists(f.Name()+".1.gz"), poll.WithDelay(time.Millisecond), poll.WithTimeout(30*time.Second))

@cpuguy83 I guess I'm not sure I understand what the .1 was trying to test in the version before this PR.

thaJeztah

comment created time in 7 days

PullRequestReviewEvent

push eventmoby/moby

Sebastiaan van Stijn

commit sha 8cf9d50fc0d001fbbab9134abfc37c24f181d7c1

[19.03] vendor: buildkit v0.6.4-32-gdf89d4dc full diff: https://github.com/moby/buildkit/compare/v0.6.4-28-gda1f4bf1...v0.6.4-32-gdf89d4dc no local changes in the daemon code Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 426396f438c75fa07fa82cee45c0b5d7bf70dc7f

Merge pull request #41451 from thaJeztah/19.03_update_buildkit [19.03] vendor: buildkit v0.6.4-32-gdf89d4dc

view details

push time in 7 days

PR merged moby/moby

[19.03] vendor: buildkit v0.6.4-32-gdf89d4dc area/builder status/2-code-review

full diff: https://github.com/moby/buildkit/compare/v0.6.4-28-gda1f4bf1...v0.6.4-32-gdf89d4dc

no local changes in the daemon code; actual fix is for the CLI: https://github.com/docker/cli/pull/2719

+1 -1

1 comment

1 changed file

thaJeztah

pr closed time in 7 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 36cdb166dc1c4731382152e22ac0d112aa6bc6f5

Bump Golang 1.13.15 full diff: https://github.com/golang/go/compare/go1.13.14...go1.13.15 go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary package. See the Go 1.13.15 milestone on the issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2315975272c59e380f67a99482f92da0ba0e9a68) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha cd8016b6bcc51a51f577bcffb37e6a870f7813f9

Merge pull request #2674 from thaJeztah/19.03_backport_bump_golang_1.13.15 [19.03 backport] Bump Golang 1.13.15

view details

push time in 7 days

PR merged docker/cli

[19.03 backport] Bump Golang 1.13.15 impact/changelog status/2-code-review

backport of https://github.com/docker/cli/pull/2673

full diff: https://github.com/golang/go/compare/go1.13.14...go1.13.15

go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary package. See the Go 1.13.15 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+6 -6

1 comment

6 changed files

thaJeztah

pr closed time in 7 days

PullRequestReviewEvent

push eventmoby/moby

Nikolay Edigaryev

commit sha a4e96a486f32b3f13953510e479f33c32e27326a

swagger: fix MemTotal units in SystemInfo endpoint MemTotal represents bytes, not kilobytes. See Linux[1] and Windows[2] implementations. [1]: https://github.com/moby/moby/blob/f50a40e889fdaeebf14fce1d494f95e60092d21d/pkg/system/meminfo_linux.go#L49 [2]: https://github.com/moby/moby/blob/f50a40e889fdaeebf14fce1d494f95e60092d21d/pkg/system/meminfo_windows.go#L40 Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com> (cherry picked from commit 13e0ba700ad53e6c97e91c8775376a7eff175555) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 406dba269c27c5f0b5f56e83eace4d21848be738

Merge pull request #41446 from thaJeztah/19.03_backport_swagger_fixes [19.03 backport] swagger: fix MemTotal units in SystemInfo endpoint

view details

push time in 7 days

PR merged moby/moby

[19.03 backport] swagger: fix MemTotal units in SystemInfo endpoint area/api area/docs status/3-docs-review

backport of https://github.com/moby/moby/pull/41432

MemTotal represents bytes, not kilobytes. See Linux1 and Windows2 implementations.

Signed-off-by: Nikolay Edigaryev edigaryev@gmail.com (cherry picked from commit 13e0ba700ad53e6c97e91c8775376a7eff175555) Signed-off-by: Sebastiaan van Stijn github@gone.nl

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/moby/moby/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+10 -10

0 comment

10 changed files

thaJeztah

pr closed time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmoby/moby

[19.03 backport] test-fixes for flaky test: TestCheckCapacityAndRotate

 func TestCheckCapacityAndRotate(t *testing.T) { 	defer l.Close()  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))--	dStringer := dirStringer{dir}- 	_, err = os.Stat(f.Name() + ".1")-	assert.Assert(t, os.IsNotExist(err), dStringer)+	assert.Assert(t, os.IsNotExist(err), dirStringer{dir})  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))-	_, err = os.Stat(f.Name() + ".1")-	assert.NilError(t, err, dStringer)+	poll.WaitOn(t, checkFileExists(f.Name()+".1.gz"), poll.WithDelay(time.Millisecond), poll.WithTimeout(30*time.Second))  	assert.NilError(t, l.WriteLogEntry(&logger.Message{Line: []byte("hello world!")}))-	_, err = os.Stat(f.Name() + ".1")-	assert.NilError(t, err, dStringer)-	_, err = os.Stat(f.Name() + ".2.gz")-	assert.NilError(t, err, dStringer)+	poll.WaitOn(t, checkFileExists(f.Name()+".1.gz"), poll.WithDelay(time.Millisecond), poll.WithTimeout(30*time.Second))

@thaJeztah you changed .1 to .1.gz

thaJeztah

comment created time in 7 days

PullRequestReviewEvent

push eventmoby/moby

Evgeniy Makhrov

commit sha 89da709cb784b900145099cc638bbe8e26268ecc

Check for context error that is wrapped in url.Error Signed-off-by: Evgeniy Makhrov <e.makhrov@corp.badoo.com> (cherry picked from commit 8ccb46a521964ab80490318504d6e02ae766a912) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 50b33bd3cd1789847ec62646738f98155f601141

Merge pull request #41312 from thaJeztah/19.03_backport_pass_network_error [19.03 backport] Check for context error that is wrapped in url.Error

view details

push time in 7 days

PR merged moby/moby

[19.03 backport] Check for context error that is wrapped in url.Error kind/bugfix status/2-code-review

backport of https://github.com/moby/moby/pull/41292

+1 -2

1 comment

1 changed file

thaJeztah

pr closed time in 7 days

PullRequestReviewEvent

push eventmoby/moby

Sebastiaan van Stijn

commit sha 9fe291827a4730ef97452919037d349b98e5d85c

Bump Golang 1.13.15 full diff: https://github.com/golang/go/compare/go1.13.14...go1.13.15 go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary package. See the Go 1.13.15 milestone on the issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2a6325e310f7ac4f8a5547dbd42d11a688dac90f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 519462f3df5ca56418e059b14efcac023e79df45

Merge pull request #41334 from thaJeztah/19.03_backport_bump_golang_1.13.15 [19.03 backport] Bump Golang 1.13.15

view details

push time in 7 days

PR merged moby/moby

[19.03 backport] Bump Golang 1.13.15 impact/changelog status/2-code-review

backport of https://github.com/moby/moby/pull/41333

full diff: https://github.com/golang/go/compare/go1.13.14...go1.13.15

go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary package. See the Go 1.13.15 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved

+4 -4

0 comment

4 changed files

thaJeztah

pr closed time in 7 days

PullRequestReviewEvent

push eventmoby/moby

Derek McGowan

commit sha d4c63720e9e477224ef4e66ed843310abf06412b

update containerd binary v1.3.0 full diff: https://github.com/containerd/containerd/compare/v1.2.8..v1.3.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Derek McGowan <derek@mcgstyle.net> (cherry picked from commit 6c94a50f4198fffa44f93d627044f1ca43545081) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Jintao Zhang

commit sha 56d897347dff32c6be23a3936db9fe0545cec0a9

Update containerd to v1.3.1 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> (cherry picked from commit 517946eb470458ec6b29bb0e2d18fe2e57332769) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Jintao Zhang

commit sha 490c45b75682879891e73c7f08ae90e69a98012d

Update containerd to v1.3.2 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> (cherry picked from commit 7f809e1080077469c26d7c9e3d7ef71151aa2faf) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 89a4208757fcf3405a9a96ec0765a099207be7c2

update containerd binary to v1.3.3 full diff: https://github.com/containerd/containerd/compare/v1.3.2...v1.3.3 release notes: https://github.com/containerd/containerd/releases/tag/v1.3.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 27649ee44f841f5804c9aa02ac59091ea2858e36) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Jintao Zhang

commit sha fc8f88dc1454f4f66b20f4d480b5adc164d17df8

update containerd to v1.3.4 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> (cherry picked from commit fbaaca63519004f6c170eecc131c52f44281d424) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Jintao Zhang

commit sha 80cef48453cd4542fe7a5d8477ebcda115db9abb

update containerd to v1.3.5 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> (cherry picked from commit 0e915e5413c5e1554fb20884361cd30b7f0c50fc) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Jintao Zhang

commit sha 9380ec739718bfb5a7d9ca4a412ca212b7346f56

update containerd to v1.3.6 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> (cherry picked from commit 85e3dddccdf74892dac74aa47de8cd2561147e08) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Akihiro Suda

commit sha a15a770e1ba824fd776c59d08a34174fb61af05b

update containerd to v1.3.7 Release note: https://github.com/containerd/containerd/releases/tag/v1.3.7 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit 43d13054c5718800b6f010509fa00c662143ff13) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 64fffefffa4dcd1d0917b93c32b8d8ab1314de6e

Merge pull request #40408 from thaJeztah/19.03_backport_update_containerd_1.3 [19.03 backport] update containerd binary v1.3.7

view details

push time in 7 days

PR merged moby/moby

[19.03 backport] update containerd binary v1.3.7 area/runtime impact/changelog

moved from https://github.com/docker/engine/pull/421

back ports of updating the containerd binaries from:

  • https://github.com/moby/moby/pull/39713 bump containerd and dependencies to v1.3.0
  • https://github.com/moby/moby/pull/40295 Update containerd to v1.3.2
  • https://github.com/moby/moby/pull/40469 update containerd binary to v1.3.3
  • https://github.com/moby/moby/pull/40822 update containerd to v1.3.4
  • https://github.com/moby/moby/pull/41159 update containerd to v1.3.5
  • https://github.com/moby/moby/pull/41169 update containerd to v1.3.6
  • https://github.com/moby/moby/pull/41310 update containerd to v1.3.7

this is to see if integration tests work fine if we would update the existing 19.03 version to the latest containerd

full diff: https://github.com/containerd/containerd/compare/v1.2.13..v1.3.7

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+1 -1

6 comments

1 changed file

thaJeztah

pr closed time in 7 days

PullRequestReviewEvent
MemberEvent

push eventdocker/go-connections

Sebastiaan van Stijn

commit sha c833fcd298093cfad5f02e70f25727ba634f01f3

Revert "Replace syscall.Unlink with os.Remove so that the directory(e.g. /run/docker.sock/) can be deleted" This reverts commit e37f6db96f63ded68813dd97e0ad109dfe9c5fd2. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 09f47925228a97335b2462178c79669712efe44e

Merge pull request #73 from thaJeztah/revert_os_remove Revert "Replace syscall.Unlink with os.Remove so that the directory(eg. /run/docker.sock/) can be deleted"

view details

push time in 11 days

PR merged docker/go-connections

Revert "Replace syscall.Unlink with os.Remove so that the directory(eg. /run/docker.sock/) can be deleted"

This reverts commit e37f6db96f63ded68813dd97e0ad109dfe9c5fd2 (https://github.com/docker/go-connections/pull/72); see the discussion on that PR for background

Signed-off-by: Sebastiaan van Stijn github@gone.nl

+1 -1

2 comments

1 changed file

thaJeztah

pr closed time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventdocker/cli

Sebastiaan van Stijn

commit sha 7edc00d8088795798ae4e82d2e529a9829acfe72

vendor: buildkit 4d1f260e8490ec438ab66e08bb105577aca0ce06 full diff: https://github.com/moby/buildkit/compare/df35e9818d1f9066e616e03f4b8d727c97562e5b...4d1f260e8490ec438ab66e08bb105577aca0ce06 - moby/buildkit#1551 session: track sessions with a group construct - moby/buildkit#1534 secrets: allow providing secrets with env - moby/buildkit#1533 git: support for token authentication - moby/buildkit#1549 progressui: fix logs time formatting Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha cec8723d8ce360dac47ee10f78bf9874a0c05298

Merge pull request #2656 from thaJeztah/bump_buildkit vendor: buildkit 4d1f260e8490ec438ab66e08bb105577aca0ce06

view details

push time in 12 days

PR merged docker/cli

vendor: buildkit 4d1f260e8490ec438ab66e08bb105577aca0ce06 area/builder docs/revisit impact/changelog status/2-code-review

full diff: https://github.com/moby/buildkit/compare/df35e9818d1f9066e616e03f4b8d727c97562e5b...4d1f260e8490ec438ab66e08bb105577aca0ce06

  • moby/buildkit#1551 session: track sessions with a group construct
  • moby/buildkit#1534 secrets: allow providing secrets with env
  • moby/buildkit#1533 git: support for token authentication
  • moby/buildkit#1549 progressui: fix logs time formatting

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

+276 -111

5 comments

13 changed files

thaJeztah

pr closed time in 12 days

PullRequestReviewEvent

push eventdocker/cli

Sebastiaan van Stijn

commit sha 866e4b10a1faceca141350c9f291811e70206c09

opts/UlimitOpt: sort lists by name Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Albin Kerouanton

commit sha a9158bdc50980ba4bb6ff2542fa7285a0b63f5bf

Add ulimits option to docker service create/update/inspect This is related to moby/moby 40639. Signed-off-by: Albin Kerouanton <albin@akerouanton.name> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Albin Kerouanton

commit sha 940907951b5c071319ac9ec44958f03d074fb3d6

Support ulimits in docker stack deploy This is related to moby/moby 40639. Signed-off-by: Albin Kerouanton <albin@akerouanton.name> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 7836597b3d2e5ed65a8109502d794705fde1ed19

Merge pull request #2712 from thaJeztah/carry_2660_ulimits Add ulimits support to docker service and docker stack deploy (carry 2660)

view details

push time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventdocker/containerd-packaging

Daniel Lipovetsky

commit sha 1da2018510317f15f87251c6de27f9b7288cd24c

Use 'runc_nokmem' build tag for RHEL/CentOS 7.x RPMs Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha f436318e595d7c35a5ea374d7e58b182f361d96b

Merge pull request #199 from thaJeztah/carry_196_nokmem Use 'runc_nokmem' build tag for RHEL/CentOS 7.x RPMs

view details

push time in 13 days

PR merged docker/containerd-packaging

Use 'runc_nokmem' build tag for RHEL/CentOS 7.x RPMs

carry of https://github.com/docker/containerd-packaging/pull/196 with review comments applied

closes https://github.com/docker/containerd-packaging/pull/196

+8 -0

0 comment

1 changed file

thaJeztah

pr closed time in 13 days

PR closed docker/containerd-packaging

Use 'runc_nokmem' build tag for RHEL/CentOS 7.x RPMs

https://github.com/docker/containerd-packaging/pull/66 originally did this, but I think the nokmem-related changes were inadvertently removed when the Makefile changed later on.

This again ensures that the "nokmem" build tag is used for RHEL/CentOS 7.x builds.

+6 -0

1 comment

1 changed file

dlipovetsky

pr closed time in 13 days

PullRequestReviewEvent

push eventdocker/containerd-packaging

Sebastiaan van Stijn

commit sha ec61758ad59d073699a69b4afb08cb8029279bc1

release 1.3.7-1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha bd13def0be3056705c919e775d6526b259cf90b8

Merge pull request #198 from thaJeztah/containerd_1.3.7 release 1.3.7-1

view details

push time in 13 days

PullRequestReviewEvent
MemberEvent
PullRequestReviewEvent

push eventdocker/cli

Sebastiaan van Stijn

commit sha 33510e0a68313b5f2398804288a2badd3f89cf19

vendor: bump github.com/fvbommel/sortorder v1.0.1 drops the dependency on github.com/xlab/handysort from go.mod diff: https://github.com/fvbommel/sortorder/compare/v1.0.0...v1.0.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 0db7f2395771a2dd53cc731a2e69a083eeb8bafc

Merge pull request #2697 from thaJeztah/bump_natsort vendor: bump github.com/fvbommel/sortorder v1.0.1

view details

push time in 22 days

PR merged docker/cli

vendor: bump github.com/fvbommel/sortorder v1.0.1 status/2-code-review

drops the dependency on github.com/xlab/handysort from go.mod (https://github.com/fvbommel/sortorder/pull/1)

diff: https://github.com/fvbommel/sortorder/compare/v1.0.0...v1.0.1

+2 -4

1 comment

3 changed files

thaJeztah

pr closed time in 22 days

PullRequestReviewEvent

pull request commentdocker/cli

Refactor / cleanup Dockerfile.dev

Why GO111MODULE=on ?

thaJeztah

comment created time in 22 days

push eventdocker/cli

Sebastiaan van Stijn

commit sha 83eda5313b9910b0bcd4e127550aca1441e04fab

opts: simplify ValidateEnv to use os.LookupEnv os.LookupEnv() was not available yet at the time this was implemented, but now provides the functionality we need, so replacing our custom handling. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 359ae2407d8308b9487ac7e5d432490d1c65c19d

Merge pull request #2679 from thaJeztah/simplify_env_handling opts: simplify ValidateEnv to use os.LookupEnv

view details

push time in 22 days

PR merged docker/cli

opts: simplify ValidateEnv to use os.LookupEnv status/2-code-review

os.LookupEnv() was not available yet at the time this was implemented (https://github.com/docker/docker/commit/9ab73260f8e4662e7321b257c636928892f023cf#diff-cd575165f84eed10d10eb1460b0927b4R434), but now provides the functionality we need, so replacing our custom handling.

<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md

** Make sure all your commits include a signature generated with git commit -s **

For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"

Please provide the following information: -->

- What I did

- How I did it

- How to verify it

- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

- A picture of a cute animal (not mandatory but encouraged)

+113 -52

2 comments

2 changed files

thaJeztah

pr closed time in 22 days

PullRequestReviewEvent

Pull request review commentdocker/go-connections

socket: try removing is socket-location is a directory

 func WithChmod(mask os.FileMode) SockOption {  // NewUnixSocketWithOpts creates a unix socket with the specified options func NewUnixSocketWithOpts(path string, opts ...SockOption) (net.Listener, error) {-	if err := os.Remove(path); err != nil && !os.IsNotExist(err) {-		return nil, err+	// Using syscall.Unlink(), not os.Remove() to prevent deleting the socket if it's in use+	if err := syscall.Unlink(path); err != nil && !os.IsNotExist(err) {+		if err != syscall.EISDIR {

OS X and Linux differ on whether unlink(dir) returns EISDIR,

https://golang.org/src/os/file_unix.go#L289

thaJeztah

comment created time in 24 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventdocker/cli

Sebastiaan van Stijn

commit sha a6c15a5e60cd4a0efbae670b5f80d1aaa8e34b42

Replace vbom.ml/util with fvbommel/sortorder The vanity domain is down, and the project has moved to a new location. vendor check started failing because of this: Collecting initial packages Download dependencies unrecognized import path "vbom.ml/util" (https fetch: Get https://vbom.ml/util?go-get=1: dial tcp: lookup vbom.ml on 169.254.169.254:53: no such host) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 6703919c7149b96b42b8a451bfb335321f70d12e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha bcb1c8486b346d216af118ec1213c668e5daed5a

Merge pull request #2695 from thaJeztah/19.03_backport_fix_vbomml_util [19.03 backport] Replace vbom.ml/util with fvbommel/sortorder

view details

push time in 25 days

PR merged docker/cli

Reviewers
[19.03 backport] Replace vbom.ml/util with fvbommel/sortorder area/testing status/2-code-review

backport of https://github.com/docker/cli/pull/2694

The vanity domain is down, and the project has moved to a new location.

vendor check started failing because of this:

Collecting initial packages
Download dependencies
unrecognized import path "vbom.ml/util" (https fetch: Get https://vbom.ml/util?go-get=1: dial tcp: lookup vbom.ml on 169.254.169.254:53: no such host)
+26 -27

1 comment

21 changed files

thaJeztah

pr closed time in 25 days

PullRequestReviewEvent

push eventdocker/cli

Sebastiaan van Stijn

commit sha 6703919c7149b96b42b8a451bfb335321f70d12e

Replace vbom.ml/util with fvbommel/sortorder The vanity domain is down, and the project has moved to a new location. vendor check started failing because of this: Collecting initial packages Download dependencies unrecognized import path "vbom.ml/util" (https fetch: Get https://vbom.ml/util?go-get=1: dial tcp: lookup vbom.ml on 169.254.169.254:53: no such host) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 8fc038afe76bef6ca17d487330c3a97527bc51c3

Merge pull request #2694 from thaJeztah/fix_vbomml_util Replace vbom.ml/util with fvbommel/sortorder

view details

push time in 25 days

PR merged docker/cli

Reviewers
Replace vbom.ml/util with fvbommel/sortorder area/testing process/cherry-picked status/2-code-review

The vanity domain is down, and the project has moved to a new location.

vendor check started failing because of this:

Collecting initial packages
Download dependencies
unrecognized import path "vbom.ml/util" (https fetch: Get https://vbom.ml/util?go-get=1: dial tcp: lookup vbom.ml on 169.254.169.254:53: no such host)
+29 -29

2 comments

24 changed files

thaJeztah

pr closed time in 25 days

PullRequestReviewEvent
more