profile
viewpoint
Santiago Pastorino spastorino @wyeworks Montevideo, Uruguay https://santiagopastorino.com @wyeworks co-founder, @rust-lang compiler team contributor, @rustlatam organizer and @rails core team alumni.

http-rs/surf 866

Fast and friendly HTTP client framework for async Rust

rust-lang/rustc-dev-guide 689

A guide to how rustc works and how to contribute to it.

rust-lang/compiler-team 167

A home for compiler team planning documents, meeting minutes, and other such things.

rust-lang/cargo-bisect-rustc 63

Bisects rustc, either nightlies or CI artifacts

spastorino/coffee-rails 18

rails/coffee-rails is the official repo

spastorino/exceptron 9

Exceptron comes from the future to make your exceptions rock!

nikomatsakis/rust 7

A work-in-progress programming language; not yet suitable for users

spastorino/bundler 2

Gemfiles are fun

spastorino/arel 1

A Relational Algebra

spastorino/dalli 1

High performance memcached client for Ruby

push eventspastorino/rust

Santiago Pastorino

commit sha 4d2f2eb6affabb3681be4959d2fd80890003ad47

WIP

view details

push time in 3 days

pull request commentrust-lang/rust

Rename Iterator::get_unchecked

@bors r+ rollup=always

matthewjasper

comment created time in 3 days

push eventspastorino/rustc-dev-guide

Santiago Pastorino

commit sha 5e281961dbf2a740cc1801281affdb7a2d54f506

hir_map -> hir()

view details

push time in 3 days

PR opened rust-lang/rustc-dev-guide

Hir map

I believe what's right now in the guide is outdated.

+6 -7

0 comment

2 changed files

pr created time in 3 days

create barnchspastorino/rustc-dev-guide

branch : hir-map

created branch time in 3 days

pull request commentrust-lang/rust

Fix #76803 miscompilation

The PR that was beta-nominated was https://github.com/rust-lang/rust/pull/76837

simonvandel

comment created time in 3 days

pull request commentrust-lang/rust

Rename Iterator::get_unchecked

@bors p=1 as it fixes a P-critical issue.

Waiting for CI to r+

matthewjasper

comment created time in 3 days

PullRequestReviewEvent

issue commentrust-lang/rust

regression: get_unchecked resolves to unstable feature use

Implemented this but @matthewjasper already has a solution too, so leaving it up to them and adjusting the assignee properly.

Mark-Simulacrum

comment created time in 3 days

pull request commentrust-lang/rust

Separate unsized fn params from unsized locals

@Dylan-DPC have rebased this here https://github.com/rust-lang/rust/compare/master...spastorino:separate-unsized-locals2, please let me know if you're going to continue with this, otherwise I can continue.

JohnTitor

comment created time in 4 days

push eventspastorino/rust

Santiago Pastorino

commit sha 8c7dfdeb1e09ee73a0a6b792a83dceae3b3ebee0

Add unsized_fn_params feature

view details

Santiago Pastorino

commit sha 88afaf3a25cde630c1602bc2d5b12c78fc31060f

Add unsized_locals to INCOMPLETE_FEATURES list

view details

Santiago Pastorino

commit sha 693e137141d14bf6bb2cb49c3e9124d9037db2d4

This flag is not really needed in the test

view details

Santiago Pastorino

commit sha c65e9f7796982a1d0fbf126dd5e467c3088d76d2

Make tidy happy

view details

Santiago Pastorino

commit sha b630c97345b163862d98777e7641a60a23305533

Using unsized_local feature is not needed in these tests

view details

Santiago Pastorino

commit sha a0eb7a36e632b41d26dd6e5d6bb14f5696befbc6

Fix unstable-book doc tests

view details

Yuki Okushi

commit sha 5a1c2be0a315381b58a04e2a604ab31850f34888

Fix rebase-fallout and bless tests

view details

Yuki Okushi

commit sha e7ee44225c69183c6f40f49ad9a348238384b4f6

Do not depend on `unsized_locals` except for bootstrap

view details

push time in 4 days

create barnchspastorino/rust

branch : separate-unsized-locals2

created branch time in 4 days

pull request commentrust-lang/rust-forge

Don't ping WG-prioritization as much in weekly meetings

cc @XAMPPRocky

jyn514

comment created time in 4 days

PullRequestReviewEvent

PR opened rust-lang/triagebot

List all beta regressions

r? @Mark-Simulacrum

cc @rust-lang/wg-prioritization

+6 -6

0 comment

2 changed files

pr created time in 4 days

push eventspastorino/rust-forge

Santiago Pastorino

commit sha 110158a6d858934ec81ec48792191df8ab2e5cc8

Remove Unassigned from regressions text

view details

push time in 4 days

create barnchspastorino/triagebot

branch : list-all-beta-regressions

created branch time in 4 days

create barnchspastorino/rust-forge

branch : reorganize-followups

created branch time in 4 days

PullRequestReviewEvent

pull request commentrust-lang/rust

[mir-opt] Disable the `ConsideredEqual` logic in SimplifyBranchSame opt

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

wesleywiser

comment created time in 4 days

pull request commentrust-lang/rust

Issue 72408 nested closures exponential

discussed in T-compiler meeting, declined to backport.

@rustbot modify labels: -beta-nominated

VFLashM

comment created time in 4 days

PR opened rust-lang/rust-forge

Move remove to announce steps to follow ups from previous meeting

r? @XAMPPRocky

cc @rust-lang/wg-prioritization

+2 -13

0 comment

1 changed file

pr created time in 4 days

create barnchspastorino/rust-forge

branch : move-remove-to-announce-procedure

created branch time in 4 days

Pull request review commentrust-lang/rust

Implement const expressions and patterns (RFC 2920)

 impl<'a> Parser<'a> {             let pat = self.parse_pat_with_range_pat(false, None)?;             self.sess.gated_spans.gate(sym::box_patterns, lo.to(self.prev_token.span));             PatKind::Box(pat)+        } else if self.eat_keyword(kw::Const) {

Right, changed to that. It was me distracted :).

spastorino

comment created time in 5 days

PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha 268dccd583b38d5fbc04861aad51a3a1ca4f61e8

Parse inline const patterns

view details

Santiago Pastorino

commit sha 18712dd42a0da7d7d005132e2105f675f7ef9aff

Refactor: extract parse_anon_const fn

view details

push time in 5 days

push eventspastorino/rust

Santiago Pastorino

commit sha 08c9df0889e29783cf8b583121a0c2b1393740c6

Refactor: extract parse_anon_const fn

view details

push time in 5 days

PR opened rust-lang/rust

Implement const expressions and patterns (RFC 2920)

This is work in progress

cc @ecstatic-morse @lcnr @oli-obk @petrochenkov

+107 -24

0 comment

21 changed files

pr created time in 5 days

push eventspastorino/rust

Santiago Pastorino

commit sha cec26a14484c939067da66ecaf3b4e718c5be595

Parse inline const expressions

view details

Santiago Pastorino

commit sha a1a37dcbca6897628c7ebc704c53bd7709e833f8

Parse inline const patterns

view details

push time in 5 days

push eventspastorino/rust

Santiago Pastorino

commit sha 0c57ed7ce51884d2ebebe5c5a0c7376a9396b163

Parse inline const and map to AnonConst

view details

push time in 5 days

Pull request review commentrust-lang/rust-forge

Don't ping WG-prioritization as much in weekly meetings

 Add [Triage Logs](https://github.com/rust-lang/rustc-perf/tree/master/triage#tri [Figure out which working groups' check-ins follow](https://rust-lang.github.io/compiler-team/about/triage-meeting/). Create `[weekly meeting] YYYY-MM-DD #54818` topic in `#t-compiler/meetings` Zulip's stream and send the following messages: +Note: If **WG-prioritization** has a check-in scheduled, do not ping them in the meeting agenda; use `**WG-prioritization**` instead.

I'd remove this because I guess I'd also remove our check-in.

jyn514

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

PR merged rust-lang/rustc-dev-guide

Don't recommend building the compiler for running tests on the standard library

Thought of this while reading https://internals.rust-lang.org/t/contributing-changes-to-std/12829/.

+3 -3

0 comment

1 changed file

jyn514

pr closed time in 5 days

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha 22b096ba2f95daff3bee5ac155589c53180cb57b

Don't recommend building the compiler for running tests on the standard library (#887) Thought of this while reading https://internals.rust-lang.org/t/contributing-changes-to-std/12829/.

view details

push time in 5 days

PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha 55dd1a249371e8baa00a6d52f79a96e2a4860e8c

Parse inline const and map to AnonConst

view details

push time in 6 days

push eventspastorino/rust

Santiago Pastorino

commit sha 690525155e32b9f06e509000e8265b66e9106439

Parse inline const and map to AnonConst

view details

push time in 6 days

push eventspastorino/rust

Santiago Pastorino

commit sha 29bdcd5575614ad9df1ae5c0c026d750aad235db

Parse inline const and map to AnonConst

view details

push time in 6 days

PR closed rust-lang/rust

[WIP] Do not make local copies of inline(always) fns in debug mode S-waiting-on-review

r? @wesleywiser

cc @rust-lang/wg-incr-comp

+13 -6

7 comments

2 changed files

spastorino

pr closed time in 6 days

pull request commentrust-lang/rust

[WIP] Do not make local copies of inline(always) fns in debug mode

Closing in favor of https://github.com/rust-lang/rust/pull/76896

spastorino

comment created time in 6 days

create barnchspastorino/rust

branch : const-exprs-rfc-2920

created branch time in 7 days

push eventspastorino/rust

Santiago Pastorino

commit sha 72559c93e1eb84a7a5fdace9439d2a19b601dd11

Do not make local copies of inline fns in debug mode

view details

push time in 7 days

PullRequestReviewEvent

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha 447064120f284b3cf07829f8dfa332ced70f7bd5

Improve instructions for adding a new test (#881) * Improve instructions for adding a new test - Add a section for library tests - Expand section on rustdoc tests * Address review comments - Say what should be considered a library test - Mention adding error numbers to doc tests - Link to #ui section - Line wrapping * Fix incorrect link It shouldn't have been a link in the first place. Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com> Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>

view details

push time in 9 days

PR merged rust-lang/rustc-dev-guide

Improve instructions for adding a new test waiting-on-review
  • Add a section for library tests
  • Expand section on rustdoc tests

From https://github.com/rust-lang/rust/issues/76268#issuecomment-692867148

+14 -4

3 comments

1 changed file

jyn514

pr closed time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha 5ad917c25eaf351f80d7f2f6e80ad554519979fb

Do not make local copies of inline fns in debug mode

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 35f74f83b005428f0a56423afced3c56e399d8eb

Do not inline in debug builds

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha e747d6b317ed5919894dac6601e00e573224eb97

Do not make local copy of inline(always) fns in debug mode

view details

push time in 10 days

pull request commentrust-lang/team

Add people to the Prioritization WG

:+1: but CI is failing, it seems that JamesPatrickGill and Stupremee are not on the people directory yet.

LeSeulArtichaut

comment created time in 10 days

pull request commentrust-lang/rust

Do not inline in debug builds

@bors try @rust-timer queue

spastorino

comment created time in 10 days

PR opened rust-lang/rust

Do not inline in debug builds

r? @wesleywiser

cc @rust-lang/wg-incr-comp

A different try about https://github.com/rust-lang/rust/pull/76889

+7 -11

0 comment

1 changed file

pr created time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 750d026f9f6561d9aab7019699f4f2617a8fde97

Do not inline in debug builds

view details

push time in 10 days

create barnchspastorino/rust

branch : codegen-inline-fns2

created branch time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha f0e2988a9bbd582f59db283726c8c07f808bf3af

Do not make local copy of inline(always) fns in debug mode

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 4bf6df8867945b233a85f450b10b65be3efddf6e

Do not make local copy of inline(always) fns in debug mode

view details

push time in 10 days

pull request commentrust-lang/rust

Do not make local copy of inline(always) fns in debug mode

@bors try @rust-timer queue

spastorino

comment created time in 10 days

PR opened rust-lang/rust

Do not make local copy of inline(always) fns in debug mode

r? @wesleywiser

cc @rust-lang/wg-incr-comp

+7 -5

0 comment

1 changed file

pr created time in 10 days

create barnchspastorino/rust

branch : codegen-inline-fns1

created branch time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 7ddcdd2431be8bd226fd806d3364c61e422a9512

Do not make local copy of inline(always) fns in debug mode

view details

push time in 10 days

pull request commentrust-lang/rust

Ignore rustc_private items from std docs

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

lzutao

comment created time in 11 days

push eventspastorino/triagebot

Santiago Pastorino

commit sha a36804d30b71b73841632337e0726bb3d853b9ec

Fix agenda empty item lines repetitions

view details

push time in 11 days

PR opened rust-lang/triagebot

Fix agenda empty item lines repetitions

This fixes what we've tried without success on #777 and #807

+17 -59

0 comment

2 changed files

pr created time in 11 days

create barnchspastorino/triagebot

branch : fix-agenda

created branch time in 11 days

issue commentrust-lang/rust

Linker error with wasm target with spaces in install path

@rustbot ping windows

jminer

comment created time in 11 days

push eventspastorino/triagebot

Santiago Pastorino

commit sha 72695a5d8f424885a1f42c513fd7f985a61a38c3

Filter proposed-final-comment-period issues on MCPs

view details

push time in 11 days

PR opened rust-lang/triagebot

Filter pfcp from agenda

r? @Mark-Simulacrum

+33 -69

0 comment

4 changed files

pr created time in 11 days

create barnchspastorino/triagebot

branch : filter-pfcp-from-agenda

created branch time in 11 days

push eventrust-lang/cargo-bisect-rustc

Paolo Barbolini

commit sha b910846dc516f8d2116fc5bfe1b4904df6b6f4f9

Verify that --test-dir is a directory

view details

Santiago Pastorino

commit sha 08d2eed6694dd611c9bd5bb033c154b65ec74879

Merge pull request #110 from paolobarbolini/test-dir Verify that --test-dir is a directory

view details

push time in 11 days

PR merged rust-lang/cargo-bisect-rustc

Verify that --test-dir is a directory

While trying to bisect an issue I copied and pasted cargo bisect-rustc --test-dir=foo --start=2018-05-07 --end=2018-08-04 from TUTORIAL.md and just changed the --start and --end versions.

<details> <summary>Running the command lead to this panic</summary>

thread 'main' panicked at 'failed to run "cargo" "+bisector-nightly-2020-08-17-x86_64-unknown-linux-gnu" "test": Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/paolo/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-bisect-rustc-0.5.2/src/toolchains.rs:335:17 stack backtrace: 0: 0x55fa36cc7da0 - std::backtrace_rs::backtrace::libunwind::trace::h14e81b0c16b543a7 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/../../backtrace/src/backtrace/libunwind.rs:96 1: 0x55fa36cc7da0 - std::backtrace_rs::backtrace::trace_unsynchronized::hc9e39e172835ff32 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/../../backtrace/src/backtrace/mod.rs:66 2: 0x55fa36cc7da0 - std::sys_common::backtrace::_print_fmt::h31994df1c8c77b8f at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/sys_common/backtrace.rs:79 3: 0x55fa36cc7da0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::he74e98acff43ec99 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/sys_common/backtrace.rs:58 4: 0x55fa36cef82c - core::fmt::write::h1857a60b204f1b6a at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/core/src/fmt/mod.rs:1080 5: 0x55fa36cc1147 - std::io::Write::write_fmt::hea6289e6649ff508 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/io/mod.rs:1517 6: 0x55fa36cca690 - std::sys_common::backtrace::_print::h8cc65937fea24014 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/sys_common/backtrace.rs:61 7: 0x55fa36cca690 - std::sys_common::backtrace::print::hff6a0ebb96535e34 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/sys_common/backtrace.rs:48 8: 0x55fa36cca690 - std::panicking::default_hook::{{closure}}::h71b9700c5dda1b1d at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:208 9: 0x55fa36cca3dc - std::panicking::default_hook::h0c46e634c06c69b6 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:227 10: 0x55fa36ccacf3 - std::panicking::rust_panic_with_hook::he52576a0c2093334 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:577 11: 0x55fa36cca8c9 - std::panicking::begin_panic_handler::{{closure}}::h411c800b810762b2 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:484 12: 0x55fa36cc822c - std::sys_common::backtrace::__rust_end_short_backtrace::ha657a272019e6aad at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/sys_common/backtrace.rs:153 13: 0x55fa36cca889 - rust_begin_unwind at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:483 14: 0x55fa36cca83b - std::panicking::begin_panic_fmt::h8679424505ca4cf5 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:437 15: 0x55fa36922a19 - cargo_bisect_rustc::toolchains::Toolchain::run_test::h7da5ba6990a4d173 16: 0x55fa36922e51 - cargo_bisect_rustc::toolchains::Toolchain::test::hbfd4b70a58cb3708 17: 0x55fa36900cfd - cargo_bisect_rustc::install_and_test::h28aa31dd8b5e3d3c 18: 0x55fa368fd5b1 - cargo_bisect_rustc::bisect::h51353250e51c38cb 19: 0x55fa368fb883 - cargo_bisect_rustc::run::h0d1722969490961d 20: 0x55fa3690238d - cargo_bisect_rustc::main::h7978755c698f5942 21: 0x55fa3690f4d3 - std::sys_common::backtrace::__rust_begin_short_backtrace::hedff8ab5fb9a5aeb 22: 0x55fa3690f729 - std::rt::lang_start::{{closure}}::h6d8274c2267b118c 23: 0x55fa36ccb1c1 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h009d20b8a620bf60 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/core/src/ops/function.rs:259 24: 0x55fa36ccb1c1 - std::panicking::try::do_call::h09431c39e2107c90 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:381 25: 0x55fa36ccb1c1 - std::panicking::try::he27cf60b958af343 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panicking.rs:345 26: 0x55fa36ccb1c1 - std::panic::catch_unwind::h7b646b0041dc5591 at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/panic.rs:382 27: 0x55fa36ccb1c1 - std::rt::lang_start_internal::hdad6c98af1e4747e at /rustc/9b4154193e8471f36b1a9e781f1ef7d492fc6a6c/library/std/src/rt.rs:51 28: 0x55fa369024b2 - main 29: 0x7f6f113410b3 - __libc_start_main 30: 0x55fa368f30fe - _start 31: 0x0 - <unknown> </details>

At first glance it wasn't immediately obvious to me what had happened. I thought something broke with cargo.

Looking back on this it was a very silly mistake, but seeing how other folders are already getting checked, it probably makes sense to also check this one!?

+7 -0

0 comment

1 changed file

paolobarbolini

pr closed time in 11 days

push eventrust-lang/cargo-bisect-rustc

Lzu Tao

commit sha d08b429ee101c651bcd956c8fe876295e8ef366f

Use anonymous remote instead

view details

Santiago Pastorino

commit sha 16fd764522c75c48d211495aab6936562f6b0b30

Merge pull request #109 from lzutao/reserved-remote Anonymously fetch from upstream rust repo

view details

push time in 11 days

PR merged rust-lang/cargo-bisect-rustc

Anonymously fetch from upstream rust repo

origin or upstream are commonly used remote names. However they aren't always the right remote with URL points to rustc URL. Their URLs could contain SSH aliases that we don't resolve.

Let's fetch anonymously from https://github.com/rust-lang/rust and use FETCH_HEAD to refer to it.

+6 -3

9 comments

2 changed files

lzutao

pr closed time in 11 days

pull request commentrust-lang/rust-forge

Add team labels to issues filter

@apiraino ouch, I forgot that you placed a PR for this :(.

apiraino

comment created time in 11 days

issue commentrust-lang/rust

btree_map::OccupiedEntry: Send regression

@ssommers can we assign the issue to you given that you've already provided a PR?

bagginslin

comment created time in 12 days

pull request commentrust-lang/triagebot

Avoid empty lines repetitions in FCP templates (take 2)

@Mark-Simulacrum this can be merged now.

apiraino

comment created time in 12 days

create barnchspastorino/rust-forge

branch : fix-prioritization-command

created branch time in 12 days

issue commentrust-lang/rust

Can't cross-build rustc for aarch64-apple-darwin anymore

This looks more like T-infra than T-compiler, I guess I'd leave it up to @Mark-Simulacrum in case they want to prioritize it.

glandium

comment created time in 12 days

PR opened rust-lang/rust-forge

List issues to add team labels when there's no team

r? @XAMPPRocky

+5 -5

0 comment

1 changed file

pr created time in 12 days

create barnchspastorino/rust-forge

branch : issues-with-no-team

created branch time in 12 days

push eventspastorino/rustc-dev-guide

Santiago Pastorino

commit sha 49b2c03d280af7381da7fedfa7e5fffe0da79e84

Complete text about salsa base inputs

view details

Santiago Pastorino

commit sha 25f1b4739f2053b59fa8bd0a02f39ce5bf925efe

Remove EN1

view details

push time in 14 days

create barnchspastorino/rustc-dev-guide

branch : salsa-in-depth

created branch time in 14 days

pull request commentrust-lang/rustc-dev-guide

Suggest system llvm or assertions

Maybe even after https://github.com/rust-lang/rust/pull/76349 we would need to check and unsuggest system llvm?.

mark-i-m

comment created time in 14 days

pull request commentrust-lang/cargo-bisect-rustc

Anonymously fetch from upstream rust repo

@Mark-Simulacrum any other thought before merging?

lzutao

comment created time in 14 days

pull request commentrust-lang/cargo-bisect-rustc

Anonymously fetch from upstream rust repo

@lzutao after merging #108 this one has conflicts now.

lzutao

comment created time in 17 days

push eventrust-lang/cargo-bisect-rustc

Lzu Tao

commit sha 753b5bdb20df1b0d9ca5440a9e1596b12a1b205e

Account for RUST_SRC_URL var at runtime

view details

Santiago Pastorino

commit sha fb41a963c1a5bfa3f0a752817289cd28403384ff

Merge pull request #107 from lzutao/dyn Add support for RUST_SRC_URL var at runtime

view details

push time in 17 days

PR merged rust-lang/cargo-bisect-rustc

Add support for RUST_SRC_URL var at runtime

With this PR, now the ordering to find rustc repo path is:

  • RUST_SRC_URL at runtime
  • rustc.git in current dir at runtime
  • RUST_SRC_URL set at compilation time

Closes #104.

+28 -28

1 comment

2 changed files

lzutao

pr closed time in 17 days

issue closedrust-lang/cargo-bisect-rustc

why RUST_SRC_REPO needs to know at compile time ?

https://github.com/rust-lang/cargo-bisect-rustc/blob/843b96ec3dfa26e7c7d51d3dd589c2f8f0705cae/src/git.rs#L11

If I build cargo-bisect-rustc and copy it to another computer with different directory to rustc, does it make me slowly re-clone rustc ?

closed time in 17 days

lzutao

push eventrust-lang/cargo-bisect-rustc

Lzu Tao

commit sha 28a4be7488041358f347fedb2e4391b0922eb2de

document about building on musl host

view details

Santiago Pastorino

commit sha 4d6fc9f258b2c846008d82c2f062d4855a5b37bc

Merge pull request #106 from lzutao/vendor-ssl Document how to build for musl host

view details

push time in 17 days

PR merged rust-lang/cargo-bisect-rustc

Document how to build for musl host

to help statically builds with musl toolchain.

+9 -1

3 comments

1 changed file

lzutao

pr closed time in 17 days

more