profile
viewpoint
Scott Frederick scottfrederick Pivotal Dallas/Fort Worth TX http://scottfrederick.io/

pivotal/credhub-release 30

BOSH release of CredHub server

krujos/data-lifecycle-service-broker 5

Cloud Foundry Service Broker for managing data lifecycle

scottfrederick/groovy-ddlutils 5

Groovy scripting for Apache DDLUtils

scottfrederick/aspectj-cobertura-example 2

Example of an AspectJ LTW and Cobertura problem

scottfrederick/cf-java-client-sample 1

A sample application for cloudfoundry-client-lib.

scottfrederick/cf-shutdown-hook 1

This app demonstrates graceful shutdown of an app running in Cloud Foundry.

scottfrederick/contacts 1

A Spring sample application

issue commentspring-projects/spring-boot

Improve error message when creating an image with no Docker Daemon available

@mikesmithson This might be a good issue for contribution.

All the connectivity to Docker from the Gradle and Maven plugins should be going through one class. There's some error handling in there, but it's apparently not catching this case.

snicoll

comment created time in 7 hours

issue commentspring-projects/spring-boot

Configure OpenJDK buildpack to use the same Java version as used for compilation

@mikesmithson Yes, you understand the requirements correctly. We'll do this for both the Gradle and Maven plugins.

I'm already well underway on this issue though. Generally if there's a name under assignees on a GitHub issue, that means someone has already started some work on it.

scottfrederick

comment created time in 7 hours

issue commentspring-projects/spring-boot

Enhancements for new LAYERED_JAR layout in spring-boot-maven-plugin

In our company, we are using Openshift, so I guess we cannot use Buildpacks. As far as I know, these are for Cloud Foundry and Heroku mainly. Please correct me if I'm wrong.

In the context of Spring Boot features, "buildpacks" refers to Cloud Native Buildpacks. This is very different from the "legacy" buildpack support in Cloud Foundry and Heroku you might be thinking of, as it is designed around container standards and OCI images. While Cloud Foundry and Heroku initiated and support CNB, Kubernetes-native tools like Tekton are building support for CNB also.

aritzbastida

comment created time in 9 hours

push eventscottfrederick/scripts

Scott Frederick

commit sha 9d4097f18dd0be1b9e6b768a64db918b9c144c99

Updates

view details

push time in 11 hours

push eventscottfrederick/spring-boot

dreis2211

commit sha e1f743a21b7def869936142495cfb84f882c2266

Upgrade CI to Docker 19.03.5 See gh-20157

view details

Stephane Nicoll

commit sha 41b054460bf1a3e4fcdf18eb9ad41919782bf015

Merge pull request #20157 from dreis2211 * pr/20157: Upgrade CI to Docker 19.03.5 Closes gh-20157

view details

Stephane Nicoll

commit sha 32c1dd45a927e7620e4c2b5b5a7cb27fe39dcd21

Revert "Merge pull request #19926 from xak2000" Closes gh-19926

view details

Andy Wilkinson

commit sha c8907d46b40348f47a60055ca4016a6cba95d90c

Fix up-to-date checking of build info properties Closes gh-20135

view details

Stephane Nicoll

commit sha 2147976c178a4eab7ca02ba99cfb53d767e3d8f1

Do not fallback to embedded configuration if a datasource url is set This commit makes sure that a fallback embedded datasource is not created if no suitable connection pool is found and an url has been explicitly registered. This is consistent with EmbeddedDataSourceConfiguration as it is using EmbeddedDatabaseBuilder behind the scenes and the latter does not honour the configured URL anyway. Closes gh-19192

view details

Andy Wilkinson

commit sha 5ae66d4c08ef173a88c4ab5ef0c6a90f99377a61

Start building against Spring Framework 5.1.14 snapshots See gh-20197

view details

Andy Wilkinson

commit sha 29bc5d848e1351f4f7e98cd55d6186650fb7ee35

Start building against Spring Data Lovelace-SR16 snapshots See gh-20198

view details

push time in 12 hours

push eventscottfrederick/spring-boot

Matthias Stock

commit sha adfbbcc0f6237a9fe8e1cae5317bf01a1aaf388e

Simplify validation pattern of EndpointId See gh-19584

view details

Stephane Nicoll

commit sha ae52f2ad438b4e54b56d2a474d63a3581cb48a63

Merge pull request #19584 from matthiasstock * pr/19584: Simplify validation pattern of EndpointId Closes gh-19584

view details

dreis2211

commit sha 2b06f17c695b6e6912c686fee420ac195a1a1c65

Fix links to external types in javadoc See gh-19581

view details

Andy Wilkinson

commit sha 117c2a0ed6fc38c4ed878249c20265924f8cee33

Merge pull request #19581 from dreis2211 * gh-19581: Fix links to external types in javadoc Closes gh-19581

view details

Andy Wilkinson

commit sha 617ebaf3c0322dc59d439f7cf753dbfaf72127a1

Isolate Gradle Plugin build from other Gradle configuration Closes gh-19656

view details

Andy Wilkinson

commit sha d75a58d7892e6160cfcdf8ddbc361c556a07f5c0

Start building against Reactor Californium-SR15 snapshots See gh-19640

view details

Andy Wilkinson

commit sha bcaae99fa959a0d08fb5a2086225a49398bffac1

Start building against Spring AMQP 2.1.13 snapshots See gh-19641

view details

Andy Wilkinson

commit sha 2d995e740a736ae0ec3971b6fbcd1f2bb1a80f77

Start building against Spring Data Lovelace-SR15 snapshots See gh-19642

view details

Andy Wilkinson

commit sha 5e14e33c948b5bca8415fd6b5a2f07f6df084f23

Start building against Micrometer 1.1.10 snapshots See gh-19639

view details

Andy Wilkinson

commit sha b23b69fea338614afac6b43f89223a549ad342ad

Upgrade to Reactor Californium-SR15 Closes gh-19640

view details

Dmytro Nosan

commit sha b7e69890f32c70530e185d655efe58e6c229c77b

Fix retrieval of parent logger in PoolingDataSourceBean See gh-19637

view details

Stephane Nicoll

commit sha e87ed08ef42b7d9aff35706f1d1080f85f13f16c

Merge pull request #19637 from nosan * pr/19637: Fix retrieval of parent logger in PoolingDataSourceBean Closes gh-19637

view details

liuhuan

commit sha 6d8b849361b7eaf20e465fdb7cb4722fb8a58ddb

Make equality checks defensive to null reference See gh-19540

view details

Stephane Nicoll

commit sha 8b8a4ee65ec3e1cec408c13de9bc685f229a93b8

Polish "Make equality checks defensive to null reference" See gh-19540

view details

Stephane Nicoll

commit sha 91fff91025df81641c9b75b098224b96429cefd4

Merge pull request #19540 from jason-liu475 * pr/19540: Polish "Make equality checks defensive to null reference" Make equality checks defensive to null reference Closes gh-19540

view details

Phillip Webb

commit sha faa38c946f957808486c5120872f9aff242eda71

Upgrade to Eclipse 2019.12 Closes gh-19281

view details

Phillip Webb

commit sha 9bd49562feadfd6ed062176f4cbc19c01a04a797

Update copyright year of changed files

view details

Stephane Nicoll

commit sha 717439d3a070aef50820a06cda41824e41697d4b

Upgrade to Spring Framework 5.1.13 Closes gh-19530

view details

Dmytro Nosan

commit sha 9bc68b98770e541d0b54785e26a477bd0df27704

Limit ChronoField values to their range See gh-19595

view details

Madhura Bhave

commit sha 91e459a5d417c4743f899508064183ddd595c64c

Polish "Limit ChronoField values to their range" See gh-19595

view details

push time in 12 hours

push eventspring-projects/spring-boot

Scott Frederick

commit sha 625b40aa90b9dbc4e353ab1e5f307d92bc40500c

Prefer arguments in POM over spring-boot.run.arguments This commit changes the order of precedence for the `arguments` property of the AbstractRunMojo so that values specified in the POM override values provided on the command line using `spring-boot.run.arguments`. This brings the `arguments` property in line with all other Mojo parameters. Fixes gh-20024

view details

Scott Frederick

commit sha 23e781033ca2ad33eb07c92ce1ef9f0bcc676762

Merge branch '2.2.x' Closes gh-20244

view details

push time in 12 hours

issue closedspring-projects/spring-boot

Unlike all other Maven properties, spring-boot.run.arguments on the command line takes precedence over the pom

Description: the spring-boot.run.jvmArguments does not take precedence over the < systemPropertyVariables> map when there is a <jvmArguments> section defined for the spring-boot-maven-plugin.

Documented behavior: According to the https://docs.spring.io/spring-boot/docs/current/maven-plugin/examples/run-system-properties.html when the spring-boot.run.jvmArguments parameter is provided for the spring-boot:run command the parameter takes precedence and overwrites the system properties defined within the <systemPropertyVariables> XML configuration. I would expect that the presence of the jvmArguments section does not influence the documented behavior.

Steps to reproduce: There is a sample application which demonstrates non-documented (faulty?) behavior located at https://github.com/rawfg/maven-jvmargs.

  1. The sample application prints the system properties starting with the xyz and by default there are two system properties configured: one comes from the <jvmArguments> section and the other one comes from the < systemPropertyVariables> section.

  2. When the application is run from the command line via the command:

mvn spring-boot:run -Dspring-boot.run.jvmArguments="-Dxyz.MavenSystemProperty='cmd-system-property'" 

the output is (system properties configured in the pom.xml):

xyz.MavenSystemProperty=maven-system-property
xyz.MavenJvmProperty=maven-jvm-property
  1. When the <jvmArguments> section is commented out the application behaves as it was documented, so running the command:
mvn spring-boot:run -Dspring-boot.run.jvmArguments="-Dxyz.MavenSystemProperty='cmd-system-property'" 

results in the output:

xyz.MavenSystemProperty=cmd-system-property
  1. I tested it with the Spring Boot version 2.2.4 but I've downgraded to the 2.1.7 version and I observed the same outcome.

Expected behavior:

  • -Dspring-boot.run.jvmArguments always works as documented (step 3) or
  • the exception is documented in the https://docs.spring.io/spring-boot/docs/current/maven-plugin/examples/run-system-properties.html

closed time in 12 hours

rawfg

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 625b40aa90b9dbc4e353ab1e5f307d92bc40500c

Prefer arguments in POM over spring-boot.run.arguments This commit changes the order of precedence for the `arguments` property of the AbstractRunMojo so that values specified in the POM override values provided on the command line using `spring-boot.run.arguments`. This brings the `arguments` property in line with all other Mojo parameters. Fixes gh-20024

view details

Scott Frederick

commit sha 23e781033ca2ad33eb07c92ce1ef9f0bcc676762

Merge branch '2.2.x' Closes gh-20244

view details

push time in 12 hours

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha 15cd590f7f6411945e3c2530f4e140641a5ef244

Allow users to opt out of including the layer tools in a layered jar For Maven, the layer configuration is now an additional configuration option instead of a layout type. Closes gh-19866

view details

Madhura Bhave

commit sha c5bce2b99d6c69bee4655f0803a5d3659e6383ae

Fix gradle plugin validation error

view details

Stephane Nicoll

commit sha 6aeff91f50e4f46d66a725b107cca11a07a8b611

Polish

view details

Stephane Nicoll

commit sha 592ae8504386cd96c089fc6835ea42ebc7b708c1

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 26c673a1a4bb435d7753e38b1165e66c89f8f202

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha 5750b8d82670191f7964d14606372e79a258db52

Start building against Reactor Californium-SR16 snapshots See gh-20196

view details

Stephane Nicoll

commit sha 69c81189b6dd4e38d7e4d220fa4db3e0d87eac58

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha ef0d8818469cb97d8ba4ff7568a05ea3c877fba2

Start building against Reactor Dysprosium-SR5 snapshots See gh-20200

view details

Stephane Nicoll

commit sha 4f9d02c5d413595f50789c170fd8be81265f64b8

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha 67d2258e76dd6391b54b360823c66a1739d10c3c

Start building against Spring Framework 5.2.4 snapshots See gh-20199

view details

Stephane Nicoll

commit sha 34f33e8b0d196a8da966a437c3193fcacd260da2

Start building against Spring HATEOAS 1.0.4 snapshots See gh-20232

view details

Stephane Nicoll

commit sha 2095295c4c039f96d01b39c8d0da1edd9072960b

Start building against Spring Data Moore SR5 snapshots See gh-20201

view details

Stephane Nicoll

commit sha 942cd85d76e75c9c64ff78e1d180c399e0af3a9b

Start building against Spring Integration 5.2.4 snapshots See gh-20202

view details

Stephane Nicoll

commit sha effa2a29f2ac8a71943ff572e6294bf0acbea811

Start building against Spring AMQP 2.2.5 snapshots See gh-20106

view details

Stephane Nicoll

commit sha cc3eac898ab0883e80ea9d971454e534b7972a55

Start building against Spring Kafka 2.3.6 snapshots See gh-20203

view details

Stephane Nicoll

commit sha 9b60794935f67712dad3e8198605ded98c351509

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha a039f6328dd7ac4e6dd80ed10983abda2d096e8e

Start building against Spring Framework 5.2.4 snapshots See gh-20240

view details

Stephane Nicoll

commit sha e7c265bc3ddc32768180960eb08d14f38c744ba9

Start building against Spring Data Neumann M4 snapshots See gh-20241

view details

push time in 13 hours

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 625b40aa90b9dbc4e353ab1e5f307d92bc40500c

Prefer arguments in POM over spring-boot.run.arguments This commit changes the order of precedence for the `arguments` property of the AbstractRunMojo so that values specified in the POM override values provided on the command line using `spring-boot.run.arguments`. This brings the `arguments` property in line with all other Mojo parameters. Fixes gh-20024

view details

push time in 13 hours

push eventspring-projects/spring-boot

Scott Frederick

commit sha 625b40aa90b9dbc4e353ab1e5f307d92bc40500c

Prefer arguments in POM over spring-boot.run.arguments This commit changes the order of precedence for the `arguments` property of the AbstractRunMojo so that values specified in the POM override values provided on the command line using `spring-boot.run.arguments`. This brings the `arguments` property in line with all other Mojo parameters. Fixes gh-20024

view details

push time in 13 hours

push eventscottfrederick/spring-boot

Stephane Nicoll

commit sha 6aeff91f50e4f46d66a725b107cca11a07a8b611

Polish

view details

Stephane Nicoll

commit sha 592ae8504386cd96c089fc6835ea42ebc7b708c1

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 5750b8d82670191f7964d14606372e79a258db52

Start building against Reactor Californium-SR16 snapshots See gh-20196

view details

Stephane Nicoll

commit sha 69c81189b6dd4e38d7e4d220fa4db3e0d87eac58

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha ef0d8818469cb97d8ba4ff7568a05ea3c877fba2

Start building against Reactor Dysprosium-SR5 snapshots See gh-20200

view details

Stephane Nicoll

commit sha 67d2258e76dd6391b54b360823c66a1739d10c3c

Start building against Spring Framework 5.2.4 snapshots See gh-20199

view details

Stephane Nicoll

commit sha 34f33e8b0d196a8da966a437c3193fcacd260da2

Start building against Spring HATEOAS 1.0.4 snapshots See gh-20232

view details

Stephane Nicoll

commit sha 2095295c4c039f96d01b39c8d0da1edd9072960b

Start building against Spring Data Moore SR5 snapshots See gh-20201

view details

Stephane Nicoll

commit sha 942cd85d76e75c9c64ff78e1d180c399e0af3a9b

Start building against Spring Integration 5.2.4 snapshots See gh-20202

view details

Stephane Nicoll

commit sha effa2a29f2ac8a71943ff572e6294bf0acbea811

Start building against Spring AMQP 2.2.5 snapshots See gh-20106

view details

Stephane Nicoll

commit sha cc3eac898ab0883e80ea9d971454e534b7972a55

Start building against Spring Kafka 2.3.6 snapshots See gh-20203

view details

push time in 16 hours

create barnchscottfrederick/spring-boot

branch : 2.2.x

created branch time in a day

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha 5ae66d4c08ef173a88c4ab5ef0c6a90f99377a61

Start building against Spring Framework 5.1.14 snapshots See gh-20197

view details

Andy Wilkinson

commit sha 29bc5d848e1351f4f7e98cd55d6186650fb7ee35

Start building against Spring Data Lovelace-SR16 snapshots See gh-20198

view details

Andy Wilkinson

commit sha 319ac968f6c9d2e09c1b7b66ad061720008f9cb7

Merge branch '2.1.x' into 2.2.x

view details

Andy Wilkinson

commit sha 56475c19fb749a26502ef632a0ed8fce9f8df358

Merge branch '2.2.x'

view details

push time in a day

pull request commentspring-projects/spring-boot

reformatting namespace 'ext' from Liquibase databaseChangelog element to fix local test failures

@mikesmithson Is there a chance you have a proxy in between your local machine and https://www.liquibase.org that requires authentication or otherwise might be blocking the connection?

mikesmithson

comment created time in 2 days

issue commentspring-projects/spring-boot

Consider alternatives to hard-coding a default builder image name and tag

The cloudfoundry/cnb builder images are maintained by the CNB Release Engineering team at Pivotal. They agree that supporting multiple builder image lines based on Platform API version, and tagging builder images with a scheme that indicates the Platform API version, is something that they should do for builder consumers. They have created a story in their Pivotal Tracker backlog for this, but haven't committed to a timeline yet.

scottfrederick

comment created time in 2 days

delete branch scottfrederick/spring-boot

delete branch : gh-20019

delete time in 2 days

push eventspring-projects/spring-boot

Scott Frederick

commit sha 8f84dbe3cf7166db38a07440a71735b4375654d8

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

Scott Frederick

commit sha 6017c1ccac5cd8385083e3b4cd3e9efb51f7ceef

Update MongoDB auto-configuration documentation.

view details

push time in 2 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 8f84dbe3cf7166db38a07440a71735b4375654d8

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

Scott Frederick

commit sha 6017c1ccac5cd8385083e3b4cd3e9efb51f7ceef

Update MongoDB auto-configuration documentation.

view details

push time in 2 days

issue closedspring-projects/spring-boot

Harmonize MongoDB sync and reactive client factories

Now that we use the new MongoDB driver, an harmonization between the imperative and reactive variants is possible.

@christophstrobl already started that in his PR but this has some impact on the regular variant that needs to be reviewed.

There is some note about v2 vs. v3 where v3 does not allow you to set host/port which I think isn't accurate. If we manage to harmonize, only one factory could be used to create both clients as a BiFucntion<MongoClientSettings, MongoDriverInformation> can be mapped to MongoClients::create.

closed time in 2 days

snicoll

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 6017c1ccac5cd8385083e3b4cd3e9efb51f7ceef

Update MongoDB auto-configuration documentation.

view details

push time in 2 days

push eventscottfrederick/spring-boot

Mustafa Ulu

commit sha 2760426db0dabed96d49719edd39fd8e15dc1ae0

Polish log4j2 configuration See gh-20225

view details

Stephane Nicoll

commit sha 49c5d23b47b17d9a989714523557a509f4f8d16c

Merge pull request #20225 from mustafau * pr/20225: Polish log4j2 configuration Closes gh-20225

view details

dreis2211

commit sha d55bc5f850e17be6433a11ca532e3bfac8906341

Test the Gradle Plugin against Gradle 6.2 See gh-20222

view details

Stephane Nicoll

commit sha 7b190ecb88e5c30bed71dd64af7459ab3fa03d42

Merge pull request #20222 from dreis2211 * pr/20222: Test the Gradle Plugin against Gradle 6.2 Closes gh-20222

view details

Stephane Nicoll

commit sha 0c76c0acb9b0a97c96ad1b93b6edf59b6cad3d0a

Merge branch '2.2.x'

view details

Johnny Lim

commit sha 8be8a8421dd01ece3c0c3f330352479de0c4a098

Polish See gh-20226

view details

Stephane Nicoll

commit sha d65e06081f3a21727265e98df519ab52b0e11381

Update copyright year of changed files See gh-20226

view details

Stephane Nicoll

commit sha fc3fb7fb449165903ce907d1846cfc653b3a2ef3

Merge pull request #20226 from izeye * pr/20226: Update copyright year of changed files Polish Closes gh-20226

view details

dreis2211

commit sha e34cf8955c9ce969f82941479df58f462e004f7c

Include LICENCE and NOTICE files in shipped jars See gh-20058

view details

Andy Wilkinson

commit sha 8128f3090af9c3701bbdc7d99ff62bf9dd95d268

Polish "Include LICENCE and NOTICE files in shipped jars" See gh-20058

view details

Andy Wilkinson

commit sha d73366570a8cd5f3710b7dc13e1ac33982c13650

Merge pull request #20058 from dreis2211 * gh-20058: Polish "Include LICENCE and NOTICE files in shipped jars" Include LICENCE and NOTICE files in shipped jars Closes gh-20058

view details

Scott Frederick

commit sha 8f84dbe3cf7166db38a07440a71735b4375654d8

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

push time in 2 days

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha aa09058d8c78e429219e12663c4768fea722ba3a

Remove implicit layers support from the layer tools Closes gh-20187

view details

Mustafa Ulu

commit sha 2760426db0dabed96d49719edd39fd8e15dc1ae0

Polish log4j2 configuration See gh-20225

view details

Stephane Nicoll

commit sha 49c5d23b47b17d9a989714523557a509f4f8d16c

Merge pull request #20225 from mustafau * pr/20225: Polish log4j2 configuration Closes gh-20225

view details

dreis2211

commit sha d55bc5f850e17be6433a11ca532e3bfac8906341

Test the Gradle Plugin against Gradle 6.2 See gh-20222

view details

Stephane Nicoll

commit sha 7b190ecb88e5c30bed71dd64af7459ab3fa03d42

Merge pull request #20222 from dreis2211 * pr/20222: Test the Gradle Plugin against Gradle 6.2 Closes gh-20222

view details

Stephane Nicoll

commit sha 0c76c0acb9b0a97c96ad1b93b6edf59b6cad3d0a

Merge branch '2.2.x'

view details

Johnny Lim

commit sha 8be8a8421dd01ece3c0c3f330352479de0c4a098

Polish See gh-20226

view details

Stephane Nicoll

commit sha d65e06081f3a21727265e98df519ab52b0e11381

Update copyright year of changed files See gh-20226

view details

Stephane Nicoll

commit sha fc3fb7fb449165903ce907d1846cfc653b3a2ef3

Merge pull request #20226 from izeye * pr/20226: Update copyright year of changed files Polish Closes gh-20226

view details

dreis2211

commit sha e34cf8955c9ce969f82941479df58f462e004f7c

Include LICENCE and NOTICE files in shipped jars See gh-20058

view details

Andy Wilkinson

commit sha 8128f3090af9c3701bbdc7d99ff62bf9dd95d268

Polish "Include LICENCE and NOTICE files in shipped jars" See gh-20058

view details

Andy Wilkinson

commit sha d73366570a8cd5f3710b7dc13e1ac33982c13650

Merge pull request #20058 from dreis2211 * gh-20058: Polish "Include LICENCE and NOTICE files in shipped jars" Include LICENCE and NOTICE files in shipped jars Closes gh-20058

view details

push time in 2 days

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha aa09058d8c78e429219e12663c4768fea722ba3a

Remove implicit layers support from the layer tools Closes gh-20187

view details

Scott Frederick

commit sha 441b1b46d90532ea5441089de1a322d25bcfa086

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

push time in 2 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha b2567cc14d9e793615f8c4c6949901262d68e143

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

push time in 2 days

push eventscottfrederick/spring-boot

Brian Clozel

commit sha e59d3fbb861560de372f8bd186e199f0c7d5e42a

Clear ProducesRequestCondition cache attribute As of spring-projects/spring-framework#22644, Spring Framework caches the "produces" condition when matching for endpoints in the `HandlerMapping` infrastructure. This has been improved in spring-projects/spring-framework#23091 to prevent side-effects in other implementations. Prior to this commit, the Spring Boot actuator infrastructure for `EndpointHandlerMapping` would not clear the cached attribute, presenting the same issue as Spring Framework's infrastructure. This means that a custom arrangement with custom `HandlerMapping` or `ContentTypeResolver` would not work properly and reuse the cached produced conditions for other, unintented, parts of the handler mapping process. This commit clears the cached data and ensures that other handler mapping implementations are free of that side-effect. Fixes gh-20150

view details

Stephane Nicoll

commit sha 2147976c178a4eab7ca02ba99cfb53d767e3d8f1

Do not fallback to embedded configuration if a datasource url is set This commit makes sure that a fallback embedded datasource is not created if no suitable connection pool is found and an url has been explicitly registered. This is consistent with EmbeddedDataSourceConfiguration as it is using EmbeddedDatabaseBuilder behind the scenes and the latter does not honour the configured URL anyway. Closes gh-19192

view details

Stephane Nicoll

commit sha 1d60184075a4333ed0f58da4b58bb9cf1ba49829

Merge branch '2.1.x' into 2.2.x Closes gh-20217

view details

Stephane Nicoll

commit sha 287d577aeac516de8b21630b76208d276b7b5fca

Merge branch '2.2.x' Closes gh-20218

view details

Stephane Nicoll

commit sha 4ec30e1145d7221338e420b5727693b5fe073716

Add support for SimpleDriverDataSource This commit makes sure that DataSourceBuilder can configure SimpleDriverDataSource by adding an alias for the driver's class name. Closes gh-20220 Co-authored-by: Dmytro Nosan <dimanosan@gmail.com>

view details

hbellahc

commit sha d890f1f6d8c763c527d3795923befa51254f1f19

Document missing reference to DataSourceHealthIndicator See gh-20216

view details

Stephane Nicoll

commit sha d3535ca15f77906555ac6610750d0d3f2fe72394

Merge pull request #20216 from hbellahc * pr/20216: Document missing reference to DataSourceHealthIndicator Closes gh-20216

view details

Stephane Nicoll

commit sha 363edfa00cc9427be545abc1b41f39df82c7b17b

Merge branch '2.2.x' Closes gh-20221

view details

Andy Wilkinson

commit sha d8c309a31080f2db548178558522fc11769dd60c

Update gradlew.bat with Gradle 6.2's changes See gh-20213

view details

push time in 2 days

push eventscottfrederick/spring-boot

Brian Clozel

commit sha e59d3fbb861560de372f8bd186e199f0c7d5e42a

Clear ProducesRequestCondition cache attribute As of spring-projects/spring-framework#22644, Spring Framework caches the "produces" condition when matching for endpoints in the `HandlerMapping` infrastructure. This has been improved in spring-projects/spring-framework#23091 to prevent side-effects in other implementations. Prior to this commit, the Spring Boot actuator infrastructure for `EndpointHandlerMapping` would not clear the cached attribute, presenting the same issue as Spring Framework's infrastructure. This means that a custom arrangement with custom `HandlerMapping` or `ContentTypeResolver` would not work properly and reuse the cached produced conditions for other, unintented, parts of the handler mapping process. This commit clears the cached data and ensures that other handler mapping implementations are free of that side-effect. Fixes gh-20150

view details

Stephane Nicoll

commit sha 2147976c178a4eab7ca02ba99cfb53d767e3d8f1

Do not fallback to embedded configuration if a datasource url is set This commit makes sure that a fallback embedded datasource is not created if no suitable connection pool is found and an url has been explicitly registered. This is consistent with EmbeddedDataSourceConfiguration as it is using EmbeddedDatabaseBuilder behind the scenes and the latter does not honour the configured URL anyway. Closes gh-19192

view details

Stephane Nicoll

commit sha 1d60184075a4333ed0f58da4b58bb9cf1ba49829

Merge branch '2.1.x' into 2.2.x Closes gh-20217

view details

Stephane Nicoll

commit sha 287d577aeac516de8b21630b76208d276b7b5fca

Merge branch '2.2.x' Closes gh-20218

view details

Stephane Nicoll

commit sha 4ec30e1145d7221338e420b5727693b5fe073716

Add support for SimpleDriverDataSource This commit makes sure that DataSourceBuilder can configure SimpleDriverDataSource by adding an alias for the driver's class name. Closes gh-20220 Co-authored-by: Dmytro Nosan <dimanosan@gmail.com>

view details

hbellahc

commit sha d890f1f6d8c763c527d3795923befa51254f1f19

Document missing reference to DataSourceHealthIndicator See gh-20216

view details

Stephane Nicoll

commit sha d3535ca15f77906555ac6610750d0d3f2fe72394

Merge pull request #20216 from hbellahc * pr/20216: Document missing reference to DataSourceHealthIndicator Closes gh-20216

view details

Stephane Nicoll

commit sha 363edfa00cc9427be545abc1b41f39df82c7b17b

Merge branch '2.2.x' Closes gh-20221

view details

Andy Wilkinson

commit sha d8c309a31080f2db548178558522fc11769dd60c

Update gradlew.bat with Gradle 6.2's changes See gh-20213

view details

Scott Frederick

commit sha 45523924ede3ac61bd97957cb2737a24623738a3

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

push time in 2 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 30ff6f92829d2ce51f29be79ef9c8a51eb0706e8

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

push time in 3 days

issue commentspring-projects/spring-boot

Consider alternatives to hard-coding a default builder image name and tag

On further discussion, it would be ideal if Spring Boot could rely on a CNB builder image tagging scheme that not only allows us to use cloudfoundry/cnb images as-is, without re-tagging, but also provides a guarantee of API compatibility for the life of a Boot minor release.

For example, assuming Spring Boot 2.3.0 is released with support for builder lifecycle API v0.5-0.6 and platform API v0.1-0.2, Boot should be able to consume newer builders that contain security updates and CVE remediations while providing API compatibility until 2.3.0 reaches EOL. This might require the team maintaining the CNB builder images tag images in such a way that multiple "branches" of builders can be published simultaneously.

We'll hold off on doing anything with this issue until we have discussions with the CNB team.

scottfrederick

comment created time in 3 days

pull request commentspinnaker/kork

Revert "chore(dependencies): Upgrade Spring Cloud to Hoxton.SR1 (#455)"

I'm not sure why this is happening, given that there's code specifically intended to work around this awkwardness in the Spring Cloud AWS configuration.

I'll see if I can find some time to test again. If anyone else is already diving in, I'm happy to discuss.

marchello2000

comment created time in 3 days

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha 4ac12660c650d233f8a64e324b3d87b5dfd80fe5

Explicitly enable config properties scan in java release scripts This commit also upgrades the Spring Boot version used by the scripts to 2.2.4 which is why the explicit annotation is required. Closes gh-20174

view details

Madhura Bhave

commit sha 0ec1ed4642633902f3d4fcae6f129e928b2ac448

Merge branch '2.2.x' Closes gh-20188

view details

Andy Wilkinson

commit sha bf8ed44453e18a40fe889d55ceb6d7936dedefca

Upgrade to Spring AMQP 2.2.4.RELEASE Closes gh-20106

view details

Andy Wilkinson

commit sha ff4de95b3eecbdba0567a19ff5e0cab83415a51c

Merge branch '2.2.x'

view details

zhangt2333

commit sha e2d87a89d0ab942df53e3029e1fe42411732a81f

Polish See gh-20192

view details

Stephane Nicoll

commit sha 03bee839917ce819b1c4056be4231dd7e815a233

Update copyright date See gh-20192

view details

Stephane Nicoll

commit sha 6fc25a309c1385d08e4ca035d0c3eb554494ef03

Merge pull request #20192 from zhangt2333 * pr/20192: Update copyright date Polish Closes gh-20192

view details

dreis2211

commit sha a9dabe13bb4b1bb53256d9f9802c40dc1e4e5005

Remove redundant useJUnitPlatform declarations See gh-20206

view details

Stephane Nicoll

commit sha 6a0cef8015be10de958f7611558e369b414d238f

Merge pull request #20206 from dreis2211 * pr/20206: Remove redundant useJUnitPlatform declarations Closes gh-20206

view details

Mike Smithson

commit sha 020ae2c7baaed85920336fe67db3b9cccfbfe3d9

Revisit PluginXmlParserTests See gh-20190

view details

Stephane Nicoll

commit sha 3ba411e04d2aab74b0dfd39d7f855d8a2fe726a5

Polish "Revisit PluginXmlParserTests" See gh-20190

view details

Stephane Nicoll

commit sha 5cb24c2584dfb67269552ec5969a64b54d71ab3f

Merge pull request #20190 from mikesmithson * pr/20190: Polish "Revisit PluginXmlParserTests" Revisit PluginXmlParserTests Closes gh-20190

view details

Eddú Meléndez

commit sha 407e237f109dc5a34a724c7cf3f39300baaa4578

Add support for configuring Liquibase tag property See gh-19316

view details

Stephane Nicoll

commit sha 4bcf4245d1d6e7b655b516125d3c89821069bf0c

Polish "Add support for configuring Liquibase tag property" See gh-19316

view details

Stephane Nicoll

commit sha d4c7315369e7e9dce6eb1c77e5f23d1e670247c8

Merge pull request #19316 from eddumelendez * pr/19316: Polish "Add support for configuring Liquibase tag property" Add support for configuring Liquibase tag property Closes gh-19316

view details

dreis2211

commit sha 76d2bc27eb95b2b2e3de7db53758bc441b812ab5

Explicitly set java home in Maven Plugin integration tests See gh-20193

view details

Andy Wilkinson

commit sha dcbbe20d41c46e6373655d03a11bb868ce8621f3

Merge pull request #20193 from dreis2211 * gh-20193: Explicitly set java home in Maven Plugin integration tests Closes gh-20193

view details

dreis2211

commit sha 4f824bf9ad572af675f8cde21c6337de8467891d

Fix duplicate words See gh-20210

view details

Stephane Nicoll

commit sha c53d4f2bf1900697b5a6986ba63a418b7d7717e8

Merge pull request #20210 from dreis2211 * pr/20210: Fix duplicate words Closes gh-20210

view details

Stephane Nicoll

commit sha 16111f126e707fb5064bab6150df7a77f54850ee

Use query-less datasource validation by default This commit changes DataSourceHealthIndicator to validate the connection rather than issuing a query to the database. If a custom validation query is specified, it uses that as before. Closes gh-17582

view details

push time in 3 days

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha 4ac12660c650d233f8a64e324b3d87b5dfd80fe5

Explicitly enable config properties scan in java release scripts This commit also upgrades the Spring Boot version used by the scripts to 2.2.4 which is why the explicit annotation is required. Closes gh-20174

view details

Madhura Bhave

commit sha 0ec1ed4642633902f3d4fcae6f129e928b2ac448

Merge branch '2.2.x' Closes gh-20188

view details

Andy Wilkinson

commit sha bf8ed44453e18a40fe889d55ceb6d7936dedefca

Upgrade to Spring AMQP 2.2.4.RELEASE Closes gh-20106

view details

Andy Wilkinson

commit sha ff4de95b3eecbdba0567a19ff5e0cab83415a51c

Merge branch '2.2.x'

view details

zhangt2333

commit sha e2d87a89d0ab942df53e3029e1fe42411732a81f

Polish See gh-20192

view details

Stephane Nicoll

commit sha 03bee839917ce819b1c4056be4231dd7e815a233

Update copyright date See gh-20192

view details

Stephane Nicoll

commit sha 6fc25a309c1385d08e4ca035d0c3eb554494ef03

Merge pull request #20192 from zhangt2333 * pr/20192: Update copyright date Polish Closes gh-20192

view details

dreis2211

commit sha a9dabe13bb4b1bb53256d9f9802c40dc1e4e5005

Remove redundant useJUnitPlatform declarations See gh-20206

view details

Stephane Nicoll

commit sha 6a0cef8015be10de958f7611558e369b414d238f

Merge pull request #20206 from dreis2211 * pr/20206: Remove redundant useJUnitPlatform declarations Closes gh-20206

view details

Mike Smithson

commit sha 020ae2c7baaed85920336fe67db3b9cccfbfe3d9

Revisit PluginXmlParserTests See gh-20190

view details

Stephane Nicoll

commit sha 3ba411e04d2aab74b0dfd39d7f855d8a2fe726a5

Polish "Revisit PluginXmlParserTests" See gh-20190

view details

Stephane Nicoll

commit sha 5cb24c2584dfb67269552ec5969a64b54d71ab3f

Merge pull request #20190 from mikesmithson * pr/20190: Polish "Revisit PluginXmlParserTests" Revisit PluginXmlParserTests Closes gh-20190

view details

Eddú Meléndez

commit sha 407e237f109dc5a34a724c7cf3f39300baaa4578

Add support for configuring Liquibase tag property See gh-19316

view details

Stephane Nicoll

commit sha 4bcf4245d1d6e7b655b516125d3c89821069bf0c

Polish "Add support for configuring Liquibase tag property" See gh-19316

view details

Stephane Nicoll

commit sha d4c7315369e7e9dce6eb1c77e5f23d1e670247c8

Merge pull request #19316 from eddumelendez * pr/19316: Polish "Add support for configuring Liquibase tag property" Add support for configuring Liquibase tag property Closes gh-19316

view details

dreis2211

commit sha 76d2bc27eb95b2b2e3de7db53758bc441b812ab5

Explicitly set java home in Maven Plugin integration tests See gh-20193

view details

Andy Wilkinson

commit sha dcbbe20d41c46e6373655d03a11bb868ce8621f3

Merge pull request #20193 from dreis2211 * gh-20193: Explicitly set java home in Maven Plugin integration tests Closes gh-20193

view details

dreis2211

commit sha 4f824bf9ad572af675f8cde21c6337de8467891d

Fix duplicate words See gh-20210

view details

Stephane Nicoll

commit sha c53d4f2bf1900697b5a6986ba63a418b7d7717e8

Merge pull request #20210 from dreis2211 * pr/20210: Fix duplicate words Closes gh-20210

view details

Stephane Nicoll

commit sha 16111f126e707fb5064bab6150df7a77f54850ee

Use query-less datasource validation by default This commit changes DataSourceHealthIndicator to validate the connection rather than issuing a query to the database. If a custom validation query is specified, it uses that as before. Closes gh-17582

view details

push time in 3 days

create barnchscottfrederick/spring-boot

branch : gh-20019

created branch time in 3 days

issue commentspring-projects/spring-boot

Modify MongoClientSettings while using auto configuration with mongodb

We have an issue for 2.3.0 (#20019) to bring the auto-configuration for the reactive/async and sync MongoDB into closer alignment, and to reduce the code duplication there, now that the MongoDB drivers provide similar configuration.

heyarny

comment created time in 6 days

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha 09fa8255cdfbabb5189f8c2d819c3b213ff8d867

Upgrade to Tomcat 9.0.31 Closes gh-20167

view details

Andy Wilkinson

commit sha 18576373d0775a6f96900eb419e2b4335eba704c

Upgrade to Spring Session Dragonfruit-M2 Closes gh-20045

view details

Stephane Nicoll

commit sha 32c1dd45a927e7620e4c2b5b5a7cb27fe39dcd21

Revert "Merge pull request #19926 from xak2000" Closes gh-19926

view details

Stephane Nicoll

commit sha 2ede9e63b9473333be406f103aed15df3121b4b5

Merge branch '2.1.x' into 2.2.x Closes gh-20117

view details

Stephane Nicoll

commit sha e3383b614c0e8f045a1aee74dbffe3de5e74f82d

Merge branch '2.2.x'

view details

Dave Syer

commit sha dcaaf9785f29b7aafe8a1377a89d0f013ee70b04

Remove duplicate auto-configuration class See gh-20168

view details

Stephane Nicoll

commit sha fc410f05722357ab155997317a9ecdf274cd2edd

Merge pull request #20168 from dsyer * pr/20168: Remove duplicate auto-configuration class Closes gh-20168

view details

Stephane Nicoll

commit sha a6fdbdcd80c199d40d1455c6c42a8a1b828a9811

Merge branch '2.2.x' Closes gh-20178

view details

Andy Wilkinson

commit sha c8907d46b40348f47a60055ca4016a6cba95d90c

Fix up-to-date checking of build info properties Closes gh-20135

view details

cbono

commit sha 852734b1296a0df108ac1d571072759412853cbf

Add support for configuring Jetty's backing queue See gh-19494

view details

Andy Wilkinson

commit sha d61b035640d4929fc4331aaa66542afdef9b7e27

Merge branch '2.1.x' into 2.2.x Closes gh-20183

view details

Stephane Nicoll

commit sha b56c4f1a4d89542089b538fefe2d95c2a6372edf

Polish "Add support for configuring Jetty's backing queue" See gh-19494

view details

Stephane Nicoll

commit sha f8173eb76dbf38706346947e6d510a48e026f4f9

Merge pull request #19494 from bono007 * pr/19494: Polish "Add support for configuring Jetty's backing queue" Add support for configuring Jetty's backing queue Closes gh-19494

view details

Juzer Ali

commit sha 30f7f9c9c4db53073cd86418dfc46c71f17c87d2

Document sanitized keys and uri sanitization behavior See gh-20169

view details

Stephane Nicoll

commit sha 40d1727cc53f1498c5e902d4e7cc76033a8c9a14

Polish "Document sanitized keys and uri sanitization behavior" See gh-20169

view details

Stephane Nicoll

commit sha 7a114995b38e707ff2de6f1892de6b4747b9a5f2

Merge pull request #20169 from juzerali * pr/20169: Polish "Document sanitized keys and uri sanitization behavior" Document sanitized keys and uri sanitization behavior Closes gh-20169

view details

Stephane Nicoll

commit sha ddeac66ca28860d3a0d8a03e91c1b411ff578c9c

Merge branch '2.2.x' Closes gh-20186

view details

Andy Wilkinson

commit sha b9c2d775a96f1fde45b4a85c695e07b0fb0f7120

Merge branch '2.2.x' Closes gh-20185

view details

Andy Wilkinson

commit sha e065ee7be2b1497cdde634e91a0e30a56dcef996

Merge branch '2.1.x' into 2.2.x Closes gh-20183

view details

Andy Wilkinson

commit sha d1aa8c02f93ae9096b2f7c44e6b0ae06e48b1066

Merge branch '2.2.x'

view details

push time in 7 days

pull request commentcloudfoundry/java-buildpack-auto-reconfiguration

Add java-cfenv reconfiguration jar

It would be nice to have a cleaner solution to the spring.factories file; but I'm not sure what that is. With this implementation, we're stuck updating the file here anytime java-cfenv-boot's version changes.

Why would this file need to change with java-cfenv-boot versions? I don't see anything version-specific in there.

JBP auto-reconfiguration has always supported an intentionally limited set of connection types, so it wouldn't need to change when new connection types are added to java-cfenv-boot.

dyroberts

comment created time in 7 days

pull request commentcloudfoundry/java-buildpack-auto-reconfiguration

Add java-cfenv reconfiguration jar

The cloud properties provided by Connectors were also confusing w.r.t. their similarity to Spring Boot's vcap properties (which came along after Connectors was introduced). I'm in favor of eliminating the cloud properties to reduce this confusion but it could cause pain for users who rely on them currently.

dyroberts

comment created time in 7 days

issue openedspring-projects/spring-boot

Instruct OpenJDK buildpack to use the same Java version as used for compilation

The OpenJDK buildpack can be configured to use a specific JRE or JDK version by providing the environment variable $BP_JAVA_VERSION to the builder.

The spring-boot:build-image Maven goal and bootBuildImage Gradle task should set $BP_JAVA_VERSION to match the target Java version used by the build (e.g. the equivalent of maven.compiler.target or java.version in Maven or targetCompatibility in Gradle).

The OpenJDK buildpack requires versions to be provided as whole numbers with wildcards like 8.* or 11.*. It may be necessary to map Maven or Gradle properties in the form 1.8 to form expected by OpenJDK buildpack.

created time in 7 days

issue openedspring-projects/spring-boot

Consider alternatives to hard-coding a default builder image name and tag

The Spring Boot integration with Cloud Native Buildpacks refers to a builder image by name and tag that is hard-coded. The named builder image is used by default if the user does not provide an image name and tag in the Maven or Gradle configuration.

It is important to pin the default to a known version because later versions of a builder might implement a newer and incompatible version of the builder API. For example,

  • Boot 2.3.0.M1 only supports lifecycle API v0.5 and platform API v0.1. It is pinned to cloudfoundry/cnb:0.0.43-bionic, which is the latest builder that supports those API versions.
  • Boot 2.3.0.M2 supports lifecycle API v0.5-0.6 and platform API v0.1-0.2. It is pinned to cloudfoundry/cnb:0.0.53-bionic, but should be compatible with later builders until the next API changes are implemented.

Instead of hard-coding a cloudfoundry/cnb:0.0.x-bionic image tag containing an ordinal version, we could re-tag the builder image with coordinates like spring-boot/cnb:bionic that pins to a given cloudfoundry/cnb tag, then hard-code Spring Boot to that unversioned image name/tag. A manually-triggered CI process could be used to re-tag a newer builder image after validation that it is API-compatible with Boot.

To provide further control, a spring-boot/cnb mirrored image could use a tag scheme that indicates the API version implemented by the image. The CNB builder team could also change their tagging scheme to include an indication of API version, which could make a spring-boot/cnb mirror unnecessary.

created time in 7 days

push eventscottfrederick/kork

Eric Zimanyi

commit sha 63119d06554fac514e08d97b323f2e6436032e2a

refactor(swagger): Remove groovy dependency from kork-swagger (#515) After submitting the last PR, I realized that there is a way to exclude groovy from Swagger annotations without forcing it as a dependency. In general I'm not a fan of reflection as it makes it really hard to perform static analysis and is hard to maintain. But this may be the one time in my life where it is actually the right solution to the problem.

view details

Scott Frederick

commit sha 51e0197b8e7c0db841619b5b1c533bce2ce207ca

chore(dependencies): Upgrade Spring Cloud to Hoxton.SR1 (#455) Co-authored-by: Rob Zienert <rob@robzienert.com>

view details

push time in 8 days

delete branch scottfrederick/kork

delete branch : spring-cloud-hoxton

delete time in 8 days

issue commentspring-projects/spring-boot

Ensure precedence of Maven command-line properties and POM configuration is consistent

Just to make sure I've understood, that's the opposite of what would align with Boot's configuration precedence in other areas?

Yes, exactly the opposite.

rawfg

comment created time in 8 days

issue commentspring-projects/spring-boot

Update ephemeral builder metadata

Documenting the rationale behind this for future reference:

CNB and pack use this fixed date for all images to optimize build reproducibility. Given the same set of inputs (application bits, builder, buildpacks, etc), two builds should generate identical images down to the image digest (which takes into account all image metadata including Created date and time).

There is an ongoing discussion about making this fixed date/time configurable so users can choose the value and provide a better UX than 40 years ago: https://github.com/buildpacks/rfcs/pull/50.

scottfrederick

comment created time in 8 days

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha f22aeda0cefbc714254b85142c61f9331912a1ee

Upgrade to Spring Kafka 2.4.2.RELEASE Closes gh-20107

view details

Andy Wilkinson

commit sha 9860f9705c84a50a6921da593448b0623c503426

Upgrade to Spring AMQP 2.2.4.RELEASE Closes gh-20105

view details

Andy Wilkinson

commit sha 7970bf243736569bb268d29ff23d747a1c177fa3

Upgrade to Spring Integration 5.3.0.M2 Closes gh-20104

view details

Russell Scheerer

commit sha d61029a37aaba0a66c23631bb587311a74da1284

Fix Spring Boot version reference in spring-boot-starter-parent See gh-20143

view details

Stephane Nicoll

commit sha 90f7a3fd327901a6d7e4f01e2b5c2bcac979ca6a

Merge pull request #20143 from scheerer * pr/20143: Fix Spring Boot version reference in spring-boot-starter-parent Closes gh-20143

view details

Stephane Nicoll

commit sha cd11b74db7cc7f121ac3eedba7c9c309fd382c7d

Remove usage of Infinispan BOM Closes gh-20154

view details

Stephane Nicoll

commit sha db1c9f4058f817a0cace4d0939f1401e42d58da4

Remove plugin management for infinispan-protocol-parser-generator Closes gh-20155

view details

dreis2211

commit sha e1f743a21b7def869936142495cfb84f882c2266

Upgrade CI to Docker 19.03.5 See gh-20157

view details

Stephane Nicoll

commit sha 41b054460bf1a3e4fcdf18eb9ad41919782bf015

Merge pull request #20157 from dreis2211 * pr/20157: Upgrade CI to Docker 19.03.5 Closes gh-20157

view details

dreis2211

commit sha 23bf948101a83e811e53b1c2a22acdb3421f06ea

Upgrade to Asciidoctor Gradle JVM 3.0.0 See gh-19953

view details

Andy Wilkinson

commit sha f2a1840c88e530fe2786ee258046aa2dc0f339bd

Merge pull request #19953 from dreis2211 * gh-19953: Upgrade to Asciidoctor Gradle JVM 3.0.0 Closes gh-19953

view details

Andy Wilkinson

commit sha 8577a39a964a05f37b68ade0fe2f7a132068c794

Upgrade to Spring Asciidoctor Extensions 0.4.1.RELEASE Closes gh-20158

view details

Andy Wilkinson

commit sha 903a4a48e8a426c7bb4c6abf5c6000c1bc2e6810

Fix configuration property references in the reference docs Previously, the configprop macro was being used in the source but the extension that implements the macro was not available to Asciidoctor. This led to the references not being checked at build time and the macro being left as-is in the rendered documentation. This commit updates the dependencies that are available to Asciidoctor to include the extension and the projects which define the configuration properties referenced in the documentation. Closes gh-20149

view details

Stephane Nicoll

commit sha 06c85e96c3c66fc711f246bbb255872d067f99b8

Merge branch '2.1.x' into 2.2.x Closes gh-20159

view details

Stephane Nicoll

commit sha 475169a80e2c4573f86551ede380a339f57da944

Merge branch '2.2.x' Closes gh-20160

view details

Andy Wilkinson

commit sha 68f59a0d4042c8ded24f77b87386f98b60742a67

Move dependency management for JNA into spring-boot-parent Previously, dependency management for JNA was provided by spring-boot-dependencies so it affected users' applications. It was original added for Elasticsearch but is no longer needed for that purpose. We use JNA in spring-boot-buildpack-platform which is used by our Gradle and Maven plugins and should not affect an application's use of JNA. This commit moves management of JNA from spring-boot-dependencies into spring-boot-parent. This means that users' applications will now be free to use whatever version of JNA meets their needs while still controlling the version used for image building via Gradle or Maven. Closes gh-20156

view details

Stephane Nicoll

commit sha 362297a010083b655903aec0c4d1976293c31da8

Fix formatting

view details

Stephane Nicoll

commit sha 738e8b39c7cb096a685ca051a557ffa4c1b185b0

Upgrade to spring javaformat 0.0.20

view details

Stephane Nicoll

commit sha b8ccfbafd00f23b3cbc1993dcbc042a49dbf8458

Upgrade to Spring Boot 2.2.4

view details

Stephane Nicoll

commit sha faaf9a7e0c5b33e190ae7ca18985c1d4f83a9525

Upgrade to SendGrid 4.4.4 Closes gh-20092

view details

push time in 8 days

pull request commentspinnaker/kork

chore(dependencies): Upgrade Spring Cloud to Hoxton.SR1

This should be ready to merge when the build is green.

scottfrederick

comment created time in 8 days

issue commentcloudfoundry/build-system-cnb

Fail to build spring-music

I just tried this and I don't get that error. Can you confirm that you have the very latest from the upstream Spring Music repo, and share the pack command line you are using?

mattysweeps

comment created time in 8 days

issue commentspring-projects/spring-boot

Ensure precedence of Maven command-line properties and POM configuration is consistent

Maven documents the fact that Mojo @Parameters can be set via POM configuration or from system properties (provided the @Parameter has a property attribute) but I can't find the order of precedence documented anywhere. However, testing shows that POM configuration takes precedence over system properties.

spring-boot.run.arguments is the exception to the rule because Boot's Mojo reverses the default Maven order by declaring two separate parameters and resolving them explicitly.

rawfg

comment created time in 8 days

pull request commentspinnaker/kork

chore(dependencies): Upgrade Spring Cloud to Hoxton.SR1

This PR was in limbo while the Boot 2.2 upgrade was rolled back for 1.18 and re-applied after the release. I've re-based it on master, hopefully it will be ready to go.

scottfrederick

comment created time in 9 days

push eventscottfrederick/kork

Rob Fletcher

commit sha 1ce8de0c822e262ad8669e7eee1bc382ebaefe3d

chore(dependencies): new Strikt version (#458) * chore(dependencies): new Strikt version * Update spinnaker-dependencies.gradle

view details

Pierre Delagrave

commit sha 997382e08ba64f89c517496dcb2245c9bef418de

chore(dependencies): Reverting Spring Boot 2.2 upgrade (#459) * chore(dependencies): Reverting Spring Boot 2.2 upgrade Revert "fix(dependencies): Spring Boot 2.2 upgrade issues (#442)" This reverts commit aaf192d1 * chore(dependencies): Reverting Spring Boot 2.2 upgrade Revert "chore(dependencies): Upgrade Spring Boot to 2.2 (#419)" This reverts commit a40ea9dc

view details

Nicolas Cohen

commit sha 2d92e8af3b5f2e7f49e9c28ceb39bbb45e2663f1

feat(archaius): Allow users to disable Archaius (#457) * feat(archaius): Allow users to disable Archaius * Use explicit property reference instead of expression Co-Authored-By: Cameron Fieber <cameron@fieber.ca> * fix import Co-authored-by: Kathryn Lewis <kathryn.lewis@armory.io> Co-authored-by: Cameron Fieber <cameron@fieber.ca>

view details

Cameron Fieber

commit sha 2cc068e8f1aad0e63e04c6e50d8049d0ed865533

refactor(plugins): makes SpinnakerPluginDescriptor a subclass of DefaultPluginDescriptor. (#437) This was largely to implement equals/hashCode but also plays slightly nicer with the expected extension mechanism of PF4J. There is a slightly worse immutability story here, but the base PluginDescriptor is already a fully nullable POJO so I don't think it is too bad to have our new attributes as var as well. Also adds some PluginLoading tests (the original driver for the desire to have an equality test on SpinnakerPluginDescriptor..). These are implemented as a generic TCK as I have a follow-up PR that introduces a new plugin-type that exercises the same set of tests for that type.

view details

Eric Zimanyi

commit sha 66d3391b2c071ea932d972343e6fa32a9452bb91

refactor(artifacts): Make artifact constructors private (#463) The all-arg and no-arg constructors for Artifact and ExpectedArtifact are marked as deprecated, as consumers should be constructing artifacts by using the lombok-generated builder class. Remove the no-arg constructors entirely, and make the all-arg constructors private. The all-arg constructors are used by the inner builder class; had we omitted the explicit AllArgsConstructor annotation, the Builder annotation would have generated a package-private all-args constructor for us. The goal of explicitly adding the annotation is so that we can make the constructor private.

view details

Eric Zimanyi

commit sha 5006e10a74f282bb2f2149a03faa7ac27a9f4488

fix(artifacts): Revert making constructors private (#464) This reverts commit 66d3391b2c071ea932d972343e6fa32a9452bb91. When bumping the services, I realized that deserialization with Jackson is using the all-args constructor implicitly. We need to configure the Artifact and ExpectedArtifact classes to use the builder for deserialization. I will make this change and re-apply later today, but I don't want to leave things broken all day so reverting for now.

view details

Rob Zienert

commit sha 36e39e4e7e73c6b79fd900cf164f63935afbd86b

feat(plugins): Add ability to download plugins with an external process (#462) Prior to this PR, plugins can only be downloaded from unauthenticated HTTP endpoints. This functionality adds the capability of specifying new file downloader strategies, with an initial alternative strategy for running an external process to download a plugin artifact. We will be writing a new default FileDownloader that can be configured for custom certificates, as well as basic auth, and probably other integrations for artifact repositories that need something extra. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Eric Zimanyi

commit sha 91c3cc70b7e8a2573815d288a6578ef054ac4e6c

refactor(artifacts): Make artifact constructors private (#465) The all-arg and no-arg constructors for Artifact and ExpectedArtifact are marked as deprecated, as consumers should be constructing artifacts by using the lombok-generated builder class. Remove the no-arg constructors entirely, and make the all-arg constructors private. The all-arg constructors are used by the inner builder class; had we omitted the explicit AllArgsConstructor annotation, the Builder annotation would have generated a package-private all-args constructor for us. The goal of explicitly adding the annotation is so that we can make the constructor private. As Jackson was depending on the public constructor for deserialization, add the JsonDeserialize and JsonPOJOBuilder annotations that tell Jackson to use the inner builder class when deserializing these classes, and add tests to ensure the deserialization works. (We define the empty inner builder class only so we can add the annotation; lombok will fill in this empty class.)

view details

Eric Zimanyi

commit sha a72ce8e98cbe608b6054b9fb5afca4a88ceed953

fix(artifacts): Properly deserialize unknown keys in artifact (#467) When a serialized artifact has unknown keys, they should be added to the resulting artifact's metadata map upon deserialization. The switch to use a builder for deserialization broke this; fix it and add a test for this case.

view details

Rob Zienert

commit sha 89ef5be9a71e0a70d1400868482cdafbd793b828

feat(kotlin): Adding detekt static code analysis for Kotlin modules (#450) * feat(kotlin): Adding detekt static code analysis * chore(kotlin): Apply detekt fixes

view details

Rob Zienert

commit sha 9328c587237da4685cbfe11ab581152ec3092688

feat(plugins): Support for extracting plugin bundles (#468)

view details

Rob Zienert

commit sha 4f0df3a1c50b392426ed2620c68b95c4062cb2a1

chore(build): Move PR builds to Github actions (#470)

view details

Cameron Fieber

commit sha c019ad9c0922c0bbda8a1e8618d3ff55cf90a16f

fix(build): remove detekt checks that are covered by spotless enforcement (#472)

view details

Cameron Motevasselani

commit sha 199d51942476d657090b0ac5a4065ae054b5d534

fix(plugins): create plugins directory if not present (#471)

view details

Cameron Fieber

commit sha 1cc88245dbcd066904e6349589aae23f38d54cd7

feat(plugins): plugin reference plugin type for local development (#466) This introduces a new plugin type that is registered if pf4j is set to development mode to enable a local plugin development experience. A plugin-ref is a JSON file with a pointer to the actual location of a plugin and a list of the classes and libraries to include when building the PluginClasspath. This allows a runtime experience similar to dropping a fully packaged plugin into the host application, without requiring the packaging and deployment step - aside from a one time generation and copy/link of the plugin-ref file. This changeset includes all the plumbing to make plugin-ref a supported type of plugin, but there is still work to do in tooling and documentation to make the development experience reasonable. With this changeset and the following set of steps, you can work with the host application and the plugin project open in IntelliJ, launch the host application, and debug into the plugin project. To do this you need to: 1. create a plugin-ref file, which is a JSON document: ``` { "pluginPath": "/path/to/plugin", "classesDirs": [ "paths", "with", "code", "e.g. PLUGIN_PROJECT/build/classes/java/main"], "libsDirs": [ "paths", "with", "jars"] } ``` 2. copy or link the plugin-ref file into the host applications plugins directory 3. configure the host-application with the plugin enabled: ``` spinnaker.extensibility: plugins: <my plugin id>: enabled: true ``` 4. run the host application with `pf4j.mode=development` Given that set of steps you can then open the host application project in IntelliJ. You can then add the plugin project as a new project into the same workspace ( on the gradle tab, the `+` button). Then create a Run Configuration for the host application, but edit the Before Launch to do a Build Project instead of just Build. When you have alllll these steps complete, if you run the host application you should see it pick up your plugin-ref, and add your plugin. Additionally you can run in debug mode and you will be able to set breakpoints in your plugin and debug through it.

view details

Rob Zienert

commit sha 1d723bb28f09122d74944e15e2b70f3eafac4cd5

feat(plugins): Moving version requirements parsing from front50 to kork (#473) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Chris Smalley

commit sha 42be711abbae18b9b6f9beaa75647c1f7eac7aca

feat(plugins): Front50UpdateRepository and required configuration (#474) * feat(plugins): Front50UpdateRepository and required configuration * fix(plugins): add docs and switch to use of Kotlin Maps ifEmpty and getOrPut * fix(plugins): Add KotlinModule

view details

Clay McCoy

commit sha bdfc49ccae5d34579708a53de714c5b5681be602

feat(plugins): Added privileged Spring plugin (#475) * feat(plugins): Added privileged Spring plugin This allows plugins to wire themselves into the application’s Spring Context by explicitly registering BeanDefinitions. * add tests for privileged spring plugins

view details

Rob Zienert

commit sha cd32a5bd1932fa947d5516a426eb7fffeabfab8c

chore(plugins): Publicly expose downloadPluginRelease on UpdateManager (#477) This is in support of deck asset proxy work in Gate. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Rob Zienert

commit sha fb2dff130e19818438135ed61f4f38359f51ad6a

refactor(plugins): CanonicalPluginId to support long namespaces (#476) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

push time in 9 days

push eventscottfrederick/kork

Chris Smalley

commit sha 9a493225de080b6b0dc9ba4632db9c2dcd89c600

feat(plugins): Add ExtensionInvocationProxy and InvocationAspect with metric invocation implementation (#448) * feat(plugins): Add ExtensionInvocationProxy and InvocationAspect with metric invocation implementation

view details

sullis

commit sha 7590b678ce33ab7932beb2ce325ff9212d1353fd

testcontainers 1.12.4 (#456)

view details

Rob Zienert

commit sha f0a816f1d1e9219c76acc054572643064a18057f

fix(plugins): Correctly read remote repositories from config (#453)

view details

Rob Fletcher

commit sha 1ce8de0c822e262ad8669e7eee1bc382ebaefe3d

chore(dependencies): new Strikt version (#458) * chore(dependencies): new Strikt version * Update spinnaker-dependencies.gradle

view details

Pierre Delagrave

commit sha 997382e08ba64f89c517496dcb2245c9bef418de

chore(dependencies): Reverting Spring Boot 2.2 upgrade (#459) * chore(dependencies): Reverting Spring Boot 2.2 upgrade Revert "fix(dependencies): Spring Boot 2.2 upgrade issues (#442)" This reverts commit aaf192d1 * chore(dependencies): Reverting Spring Boot 2.2 upgrade Revert "chore(dependencies): Upgrade Spring Boot to 2.2 (#419)" This reverts commit a40ea9dc

view details

Nicolas Cohen

commit sha 2d92e8af3b5f2e7f49e9c28ceb39bbb45e2663f1

feat(archaius): Allow users to disable Archaius (#457) * feat(archaius): Allow users to disable Archaius * Use explicit property reference instead of expression Co-Authored-By: Cameron Fieber <cameron@fieber.ca> * fix import Co-authored-by: Kathryn Lewis <kathryn.lewis@armory.io> Co-authored-by: Cameron Fieber <cameron@fieber.ca>

view details

Cameron Fieber

commit sha 2cc068e8f1aad0e63e04c6e50d8049d0ed865533

refactor(plugins): makes SpinnakerPluginDescriptor a subclass of DefaultPluginDescriptor. (#437) This was largely to implement equals/hashCode but also plays slightly nicer with the expected extension mechanism of PF4J. There is a slightly worse immutability story here, but the base PluginDescriptor is already a fully nullable POJO so I don't think it is too bad to have our new attributes as var as well. Also adds some PluginLoading tests (the original driver for the desire to have an equality test on SpinnakerPluginDescriptor..). These are implemented as a generic TCK as I have a follow-up PR that introduces a new plugin-type that exercises the same set of tests for that type.

view details

Eric Zimanyi

commit sha 66d3391b2c071ea932d972343e6fa32a9452bb91

refactor(artifacts): Make artifact constructors private (#463) The all-arg and no-arg constructors for Artifact and ExpectedArtifact are marked as deprecated, as consumers should be constructing artifacts by using the lombok-generated builder class. Remove the no-arg constructors entirely, and make the all-arg constructors private. The all-arg constructors are used by the inner builder class; had we omitted the explicit AllArgsConstructor annotation, the Builder annotation would have generated a package-private all-args constructor for us. The goal of explicitly adding the annotation is so that we can make the constructor private.

view details

Eric Zimanyi

commit sha 5006e10a74f282bb2f2149a03faa7ac27a9f4488

fix(artifacts): Revert making constructors private (#464) This reverts commit 66d3391b2c071ea932d972343e6fa32a9452bb91. When bumping the services, I realized that deserialization with Jackson is using the all-args constructor implicitly. We need to configure the Artifact and ExpectedArtifact classes to use the builder for deserialization. I will make this change and re-apply later today, but I don't want to leave things broken all day so reverting for now.

view details

Rob Zienert

commit sha 36e39e4e7e73c6b79fd900cf164f63935afbd86b

feat(plugins): Add ability to download plugins with an external process (#462) Prior to this PR, plugins can only be downloaded from unauthenticated HTTP endpoints. This functionality adds the capability of specifying new file downloader strategies, with an initial alternative strategy for running an external process to download a plugin artifact. We will be writing a new default FileDownloader that can be configured for custom certificates, as well as basic auth, and probably other integrations for artifact repositories that need something extra. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Eric Zimanyi

commit sha 91c3cc70b7e8a2573815d288a6578ef054ac4e6c

refactor(artifacts): Make artifact constructors private (#465) The all-arg and no-arg constructors for Artifact and ExpectedArtifact are marked as deprecated, as consumers should be constructing artifacts by using the lombok-generated builder class. Remove the no-arg constructors entirely, and make the all-arg constructors private. The all-arg constructors are used by the inner builder class; had we omitted the explicit AllArgsConstructor annotation, the Builder annotation would have generated a package-private all-args constructor for us. The goal of explicitly adding the annotation is so that we can make the constructor private. As Jackson was depending on the public constructor for deserialization, add the JsonDeserialize and JsonPOJOBuilder annotations that tell Jackson to use the inner builder class when deserializing these classes, and add tests to ensure the deserialization works. (We define the empty inner builder class only so we can add the annotation; lombok will fill in this empty class.)

view details

Eric Zimanyi

commit sha a72ce8e98cbe608b6054b9fb5afca4a88ceed953

fix(artifacts): Properly deserialize unknown keys in artifact (#467) When a serialized artifact has unknown keys, they should be added to the resulting artifact's metadata map upon deserialization. The switch to use a builder for deserialization broke this; fix it and add a test for this case.

view details

Rob Zienert

commit sha 89ef5be9a71e0a70d1400868482cdafbd793b828

feat(kotlin): Adding detekt static code analysis for Kotlin modules (#450) * feat(kotlin): Adding detekt static code analysis * chore(kotlin): Apply detekt fixes

view details

Rob Zienert

commit sha 9328c587237da4685cbfe11ab581152ec3092688

feat(plugins): Support for extracting plugin bundles (#468)

view details

Rob Zienert

commit sha 4f0df3a1c50b392426ed2620c68b95c4062cb2a1

chore(build): Move PR builds to Github actions (#470)

view details

Cameron Fieber

commit sha c019ad9c0922c0bbda8a1e8618d3ff55cf90a16f

fix(build): remove detekt checks that are covered by spotless enforcement (#472)

view details

Cameron Motevasselani

commit sha 199d51942476d657090b0ac5a4065ae054b5d534

fix(plugins): create plugins directory if not present (#471)

view details

Cameron Fieber

commit sha 1cc88245dbcd066904e6349589aae23f38d54cd7

feat(plugins): plugin reference plugin type for local development (#466) This introduces a new plugin type that is registered if pf4j is set to development mode to enable a local plugin development experience. A plugin-ref is a JSON file with a pointer to the actual location of a plugin and a list of the classes and libraries to include when building the PluginClasspath. This allows a runtime experience similar to dropping a fully packaged plugin into the host application, without requiring the packaging and deployment step - aside from a one time generation and copy/link of the plugin-ref file. This changeset includes all the plumbing to make plugin-ref a supported type of plugin, but there is still work to do in tooling and documentation to make the development experience reasonable. With this changeset and the following set of steps, you can work with the host application and the plugin project open in IntelliJ, launch the host application, and debug into the plugin project. To do this you need to: 1. create a plugin-ref file, which is a JSON document: ``` { "pluginPath": "/path/to/plugin", "classesDirs": [ "paths", "with", "code", "e.g. PLUGIN_PROJECT/build/classes/java/main"], "libsDirs": [ "paths", "with", "jars"] } ``` 2. copy or link the plugin-ref file into the host applications plugins directory 3. configure the host-application with the plugin enabled: ``` spinnaker.extensibility: plugins: <my plugin id>: enabled: true ``` 4. run the host application with `pf4j.mode=development` Given that set of steps you can then open the host application project in IntelliJ. You can then add the plugin project as a new project into the same workspace ( on the gradle tab, the `+` button). Then create a Run Configuration for the host application, but edit the Before Launch to do a Build Project instead of just Build. When you have alllll these steps complete, if you run the host application you should see it pick up your plugin-ref, and add your plugin. Additionally you can run in debug mode and you will be able to set breakpoints in your plugin and debug through it.

view details

Rob Zienert

commit sha 1d723bb28f09122d74944e15e2b70f3eafac4cd5

feat(plugins): Moving version requirements parsing from front50 to kork (#473) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Chris Smalley

commit sha 42be711abbae18b9b6f9beaa75647c1f7eac7aca

feat(plugins): Front50UpdateRepository and required configuration (#474) * feat(plugins): Front50UpdateRepository and required configuration * fix(plugins): add docs and switch to use of Kotlin Maps ifEmpty and getOrPut * fix(plugins): Add KotlinModule

view details

push time in 9 days

delete branch scottfrederick/spring-boot

delete branch : gh-20126

delete time in 9 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha e294d26458a198f29f8562771c60081b49ddfceb

Set ephemeral builder container creation to a fixed date This commit fixes the `Created` date and time of the ephemeral builder container image at the Windows epoch plus one second (1980-01-01T00:00:01Z). This date matches the created date of the builder image and influences the created date of the resulting image. Using a fixed date for images ensures that the digest is consistent for all images with the same version. Fixes gh-20126

view details

push time in 9 days

push eventspring-projects/spring-boot

Scott Frederick

commit sha 191dce3f5e7c6aef43f8b9c122758e2aef34cb9b

Set Spring Boot version in ephemeral builder This commit adds a `createdBy` structure to the metadata of the ephemeral builder container image that identifies Spring Boot as the creator of the image, along with the Spring Boot version. See gh-20126

view details

Scott Frederick

commit sha e294d26458a198f29f8562771c60081b49ddfceb

Set ephemeral builder container creation to a fixed date This commit fixes the `Created` date and time of the ephemeral builder container image at the Windows epoch plus one second (1980-01-01T00:00:01Z). This date matches the created date of the builder image and influences the created date of the resulting image. Using a fixed date for images ensures that the digest is consistent for all images with the same version. Fixes gh-20126

view details

push time in 9 days

issue closedspring-projects/spring-boot

Update ephemeral builder metadata

To maintain parity with pack, metadata for the ephemeral builder container should:

  • Include a structure in the container metadata field Config.Labels["io.buildpacks.builder.metadata"] that identifies Spring Boot as the creator along with the Boot version:
"createdBy" : {
  "name" : "Spring Boot",
  "version" : "2.3.0.BUILD-SNAPSHOT"
}
  • Set the container creation date to 1980-01-01T00:00:01Z (Windows epoch + 1 second)

closed time in 9 days

scottfrederick

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 191dce3f5e7c6aef43f8b9c122758e2aef34cb9b

Set Spring Boot version in ephemeral builder This commit adds a `createdBy` structure to the metadata of the ephemeral builder container image that identifies Spring Boot as the creator of the image, along with the Spring Boot version. See gh-20126

view details

Scott Frederick

commit sha e294d26458a198f29f8562771c60081b49ddfceb

Set ephemeral builder container creation to a fixed date This commit fixes the `Created` date and time of the ephemeral builder container image at the Windows epoch plus one second (1980-01-01T00:00:01Z). This date matches the created date of the builder image and influences the created date of the resulting image. Using a fixed date for images ensures that the digest is consistent for all images with the same version. Fixes gh-20126

view details

push time in 9 days

push eventscottfrederick/spring-boot

Stephane Nicoll

commit sha aa56a6f6473e46c1e4d8d8341de7da82fde0faff

Add missing mockito dependency Closes gh-20097

view details

Stephane Nicoll

commit sha c5d38e0b5fb06a7d97d3748e179a02967cf20e3c

Upgrade to AppEngine SDK 1.9.78 Closes gh-20060

view details

Stephane Nicoll

commit sha 730683ce26f3db9efdc467277279e5eb67deefa5

Upgrade to Awaitility 4.0.2 Closes gh-20061

view details

Stephane Nicoll

commit sha f883a6cf26bacf039b6158d13697539911029d9c

Upgrade to Byte Buddy 1.10.7 Closes gh-20062

view details

Stephane Nicoll

commit sha f0ac9e13891e074e06c5be9e8afd81a62a04ddb3

Upgrade to Caffeine 2.8.1 Closes gh-20063

view details

Stephane Nicoll

commit sha f8087a6f2979e30ee7e81596da5dd742f245bac9

Upgrade to Couchbase Client 2.7.12 Closes gh-20065

view details

Stephane Nicoll

commit sha ad8fa8f6a0c745aef722a3b2012bdb1af87690c6

Upgrade to Elasticsearch 7.5.2 Closes gh-20066

view details

Stephane Nicoll

commit sha a7249d20d22cf0ced01cace31f4f528ff7c587d1

Upgrade to Flyway 6.2.2 Closes gh-20067

view details

Stephane Nicoll

commit sha 93d34781fcd293841026a7f6b885db4a953f30ae

Upgrade to Groovy 2.5.9 Closes gh-20068

view details

Stephane Nicoll

commit sha 466dd66c8f27b06358124308435597f23c3dad8c

Upgrade to Hazelcast 3.12.6 Closes gh-20069

view details

Stephane Nicoll

commit sha da7dbf085e486acaaec874d2c5625d122f6b5eaf

Upgrade to Hibernate 5.4.10.Final Closes gh-20070

view details

Stephane Nicoll

commit sha f0d2d320c2260176597bce680cf1107cbb3cf38e

Upgrade to Hibernate Validator 6.1.2.Final Closes gh-20071

view details

Stephane Nicoll

commit sha 95c4f1b0c09e7fed99d77b6c9e0c6aa2ec41de59

Upgrade to HikariCP 3.4.2 Closes gh-20072

view details

Stephane Nicoll

commit sha 616a33367f9c0a8ca5317e3c515a39129c372084

Upgrade to HtmlUnit 2.37.0 Closes gh-20073

view details

Stephane Nicoll

commit sha 7996a32129a26febbd4b01ea8aaa77de0e21a4b9

Upgrade to HttpClient 4.5.11 Closes gh-20074

view details

Stephane Nicoll

commit sha e0cd00e0d3e5343fd39616370872de8c91379d4a

Upgrade to HttpCore 4.4.13 Closes gh-20075

view details

Stephane Nicoll

commit sha acbdf0cd2fe5d10bfb36ff71bc9ffda407ea1440

Upgrade to Jetty EL 8.5.49 Closes gh-20076

view details

Stephane Nicoll

commit sha 3e0515da2fd089ce9a95896b500f74fe119a3cb8

Upgrade to Jetty Reactive HTTPClient 1.1.1 Closes gh-20077

view details

Stephane Nicoll

commit sha 2b9934573384a50490d5cca408f73bbc6ca17470

Upgrade to Johnzon 1.2.3 Closes gh-20078

view details

Stephane Nicoll

commit sha 7dccc10803ff4e7ac494b274ea069f9dd23c1182

Upgrade to jOOQ 3.12.4 Closes gh-20079

view details

push time in 9 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 191dce3f5e7c6aef43f8b9c122758e2aef34cb9b

Set Spring Boot version in ephemeral builder This commit adds a `createdBy` structure to the metadata of the ephemeral builder container image that identifies Spring Boot as the creator of the image, along with the Spring Boot version. See gh-20126

view details

push time in 9 days

push eventscottfrederick/spring-boot

Hans Schulz

commit sha 6828a15d31ac7d1ca1bfd560cfa05c393b3b7128

Handle JSON keys containing a dot from CF environment as a single path segment See gh-18915

view details

Madhura Bhave

commit sha 544dca7f1b8a2adf7921f7c56b86f7abb8f37964

Polish contribution Along with surrounding map keys with dot from VCAP_SERVICES with `[ ]`, this commit also does that for non-alphanumeric and `-` characters so that they are not stripped off later. See gh-18915

view details

Madhura Bhave

commit sha 3917968d2acb67fce6b82eab770f0c74b9f11b6b

Merge pull request #18915 from schulzh * pr/18915: Polish contribution Handle JSON keys containing a dot from CF environment as a single path segment Closes gh-18915

view details

Madhura Bhave

commit sha d1c76995394521760eddada276958a3eb7da69bd

Merge branch '2.1.x' into 2.2.x Closes gh-20129

view details

Madhura Bhave

commit sha c5ffe198afe53b18efa23f78d02c8238a5f39aec

Merge branch '2.2.x' Closes gh-20130

view details

Madhura Bhave

commit sha 747eab020de4e879cbd27e4bd1a2159693380537

Update copyright of changed files

view details

Madhura Bhave

commit sha 3bdd91a1190e378738c2ce32e4034bc251c3e588

Merge branch '2.1.x' into 2.2.x

view details

Madhura Bhave

commit sha a5a2d52ee3942f8a4acc8d2509d50f1566f8307e

Merge branch '2.2.x'

view details

cbono

commit sha e3516059622a09ea2ff439daffaeb87c649d9667

Verify ssl key alias on server startup See gh-19202

view details

Madhura Bhave

commit sha ac91f14f05ccf7d2198f6e313f03a5c73cc1c296

Polish "Verify ssl key alias on server startup" See gh-19202

view details

Madhura Bhave

commit sha 8bce2704454dfa07fce785ba6e51714c3942b236

Merge pull request #19202 from bono007 * pr/19202: Polish "Verify ssl key alias on server startup" Verify ssl key alias on server startup Closes gh-19202

view details

Madhura Bhave

commit sha 98a657fedbd1f16e14cce727bb354f8cdcc18d4d

Merge branch '2.1.x' into 2.2.x Closes gh-20132

view details

Madhura Bhave

commit sha 8d9b1d29886985b476f9614f8e524867cdb25d76

Merge branch '2.2.x' Closes gh-20133

view details

Madhura Bhave

commit sha 97ac6c9de740a09f4b9e4dfe0770599d78552723

Polish

view details

Madhura Bhave

commit sha 4eb71fc424b14f78bc9b8ba678ef613ba8d3e760

Merge branch '2.1.x' into 2.2.x

view details

Madhura Bhave

commit sha fe325c06c210fe525b7e1bfdb5c8bebb708b634b

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha d19920ae39a2d2b42ca17bdedc339db1d05b3a8c

Upgrade to Cassandra Driver 4.4.0 Closes gh-20064

view details

dreis2211

commit sha 450ef36c7237ca4d3218c10dfbc25b08f0c443fa

Exclude jcl-over-slf4j also on Reactive Cassandra starter See gh-20141

view details

Stephane Nicoll

commit sha 1b4a3dfa77371fffd8849b3d5a6c33cf29840892

Merge pull request #20141 from dreis2211 * pr/20141: Exclude jcl-over-slf4j also on Reactive Cassandra starter Closes gh-20141

view details

Andy Wilkinson

commit sha 5fed25bb43a337eac367f347ac893f054844fa5e

Upgrade to Spring HATEOAS 1.1.0.M2 Closes gh-20142

view details

push time in 9 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 4256fe9afa93919b5995e5bd4ceb354bdb259732

Update ephemeral builder container metadata This commit modifies some fields in the container metadata for the ephemeral builder container to match the behavior of the pack CLI. See gh-20126

view details

push time in 9 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 7bc7b5a0ca2a26d06712671e6cae0c8a192ce99a

Update ephemeral builder container metadata This commit modifies some fields in the container metadata for the ephemeral builder container to match the behavior of the pack CLI. See gh-20126

view details

push time in 9 days

create barnchscottfrederick/spring-boot

branch : gh-20126

created branch time in 9 days

issue commentspring-projects/spring-boot

Harmonize build reference documentation structure

+1 for making this consistent. I've tried to switch between the docs by just replacing gradle with maven in the URL, or the reverse, and been surprised when that didn't work (not necessarily at the level of anchors, but at least at the root).

snicoll

comment created time in 10 days

issue openedspring-projects/spring-boot

Update ephemeral builder metadata

To maintain parity with pack, metadata for the ephemeral builder container should:

  • Include a structure in the container metadata field Config.Labels["io.buildpacks.builder.metadata"] that identifies Spring Boot as the creator along with the Boot version:
"createdBy" : {
  "name" : "Spring Boot",
  "version" : "2.3.0.BUILD-SNAPSHOT"
}
  • Zeros out the container creation date

created time in 10 days

issue closedcloudfoundry/java-buildpack-auto-reconfiguration

Auto-reconfiguration problem with Spring Boot 2.3.0.M1

I can't get the auto-reconfiguration to work with the latest Spring Boot version 2.3.0.M1, following symptoms:

  • cloud profile is not set
  • bound relational datasource is not used

I used an empty project created by Spring Boot Initializr: demo-project-2.3.0.M1.zip

For the messages on startup, please see the attached logfile: spring-boot-2.3.0.M1-autoreconfig.txt

closed time in 10 days

anrub

issue commentcloudfoundry/java-buildpack-auto-reconfiguration

Auto-reconfiguration problem with Spring Boot 2.3.0.M1

This issue has been fixed in Spring Boot, and will be available in 2.3.0.M2.

anrub

comment created time in 10 days

issue commentspring-projects/spring-boot

spring-boot.run.jvmArguments system properties issue

A value provided by <jvmArguments> in the POM configuration takes precedence over a value provided by the spring-boot.run.jvmArguments system property. So in the case of your sample app as provided without changes, the -Dspring-boot.run.jvmArguments=-Dxyz.MavenSystemProperty=cmd-system-property will be ignored. When the <jvmArguments> POM configuration is removed, then the spring-boot.run.jvmArguments value is used.

Expected behavior:

  • -Dspring-boot.run.jvmArguments always works as documented (step 3) or
  • the exception is documented in the https://docs.spring.io/spring-boot/docs/current/maven-plugin/examples/run-system-properties.html

This isn't so much an exception as it is an order of precedence. The documentation states that jvmArguments takes precedence over <systemPropertyVariables>, which is always the case. What isn't documented is which manner of providing jvmArguments takes precedence. A quick test shows that the order of precedence isn't consistent between configuration properties like jvmArguments and arguments.

I've marked this for team attention so we can discuss the proper order of precedence between POM configuration and spring-boot.run system properties, talk about adding tests to confirm the proper behavior, and document it.

rawfg

comment created time in 14 days

push eventscottfrederick/spring-boot

med-amine.dahmen

commit sha aee22bfb5120249640c6a5eadc3cc8687c567d01

Make Kubernetes detection slightly more efficient See gh-19002

view details

Stephane Nicoll

commit sha ddb5cc3f9988bf7540de1a722f3022d865fa931d

Polish "Make Kubernetes detection slightly more efficient" See gh-19002

view details

Stephane Nicoll

commit sha ab72237b1b707355c8678dc8b2ef644964131c60

Merge pull request #19002 from medamines1 * pr/19002: Polish "Make Kubernetes detection slightly more efficient" Make Kubernetes detection slightly more efficient Closes gh-19002

view details

Stephane Nicoll

commit sha 6e3636d5ffc8ee51df7c933938f80748bfa70c89

Merge branch '2.2.x' Closes gh-20059

view details

push time in 14 days

issue closedspring-projects/spring-boot

Restore deprecated code with no replacement that Spring Cloud Hoxton needs

Spring Cloud Hoxton is trying to support both 2.2 and 2.3 simultaneously.

#19699 removed some deprecations which will cause problems.

So far the items I've found that do not have replacements are:

  • org.springframework.boot.context.properties.ConfigurationBeanFactoryMetadata.
  • org.springframework.boot.actuate.health.CompositeHealthIndicator
  • org.springframework.boot.actuate.health.HealthAggregator

It was a smaller list than I initially feared. I'll double-check that those are all of them.

closed time in 14 days

spencergibb

issue commentspring-projects/spring-boot

Restore deprecated code with no replacement that Spring Cloud Hoxton needs

@spencergibb I'm going to close this issue based on my testing, feel free to re-open if your builds uncover a problem.

spencergibb

comment created time in 14 days

push eventscottfrederick/spring-boot

cbono

commit sha badc83d368f7c8a67c76ebcf1ea2f5659dda05c4

Add 'uris', 'address' and 'addresses' to keys to sanitize. See gh-19999

view details

Madhura Bhave

commit sha acc453db4a28bf4c7d815f26f1b60aad7b618945

Polish contribution See gh-19999

view details

Madhura Bhave

commit sha 37575d78bf9cdf1d3ed3cac4080b2c2ba402da28

Merge pull request #19999 from bono007 * pr/19999: Polish contribution Add 'uris', 'address' and 'addresses' to keys to sanitize. Closes gh-19999

view details

Madhura Bhave

commit sha eeab9233ccdb23a5bbb2c0a1b79131c534f0d6c5

Merge branch '2.2.x' Closes gh-20056

view details

push time in 14 days

issue closedspring-projects/spring-boot

Upgrade image builder version

Upgrade the version of the CNB builder image to the latest version, supporting lifecycle version 0.6 and platform version 0.2.

closed time in 14 days

scottfrederick

issue commentspring-projects/spring-boot

Upgrade image builder version

Closed via 12c640e13367c3620fcfb582c780ac41c55c9d7e

scottfrederick

comment created time in 14 days

issue openedspring-projects/spring-boot

Upgrade image builder version

Upgrade the version of the CNB builder image to the latest version, supporting lifecycle version 0.6 and platform version 0.2.

created time in 14 days

push eventspring-projects/spring-boot

Scott Frederick

commit sha d07062652e9b539e76c4ea43baf81496dc34ab8b

Add support for CNB platform API v0.2 Cloud Native Buildpacks platform API version 0.2 introduced two breaking changes: the order of invoking the restore and analyze phases was reversed, and the cache phase was removed in favor of distributing caching across other phases. This commit adds support for Cloud Native Buildpacks builders that implement platform API version 0.2, while maintaining compatibility with builders that implement Lifecycle version platform API version 0.1. Closes gh-19829

view details

Scott Frederick

commit sha 12c640e13367c3620fcfb582c780ac41c55c9d7e

Upgrade default image builder version This commit upgrades the default CNB builder image from cloudfoundry/cnb:0.0.43-bionic to cloudfoundry/cnb:0.0.53-bionic. It also adds integration tests for the Maven and Gradle plugins to verify both versions are supported.

view details

push time in 14 days

issue closedspring-projects/spring-boot

Update buildpack support for lifecycle v6

The current code does not yet support v6. We need to port this PR from Go to Java.

closed time in 14 days

philwebb

push eventscottfrederick/spring-boot

Scott Frederick

commit sha d07062652e9b539e76c4ea43baf81496dc34ab8b

Add support for CNB platform API v0.2 Cloud Native Buildpacks platform API version 0.2 introduced two breaking changes: the order of invoking the restore and analyze phases was reversed, and the cache phase was removed in favor of distributing caching across other phases. This commit adds support for Cloud Native Buildpacks builders that implement platform API version 0.2, while maintaining compatibility with builders that implement Lifecycle version platform API version 0.1. Closes gh-19829

view details

Scott Frederick

commit sha 12c640e13367c3620fcfb582c780ac41c55c9d7e

Upgrade default image builder version This commit upgrades the default CNB builder image from cloudfoundry/cnb:0.0.43-bionic to cloudfoundry/cnb:0.0.53-bionic. It also adds integration tests for the Maven and Gradle plugins to verify both versions are supported.

view details

push time in 14 days

issue commentcloudfoundry/spring-boot-cnb

Buildpack fails if Spring Boot app has empty BOOT-INF/lib

While it's unlikely you'd encounter an app like this in the real world, Spring Boot has an integration test for the CNB builder integration that encounters this problem when using newer builders.

scottfrederick

comment created time in 15 days

issue openedcloudfoundry/spring-boot-cnb

Buildpack fails if Spring Boot app has empty BOOT-INF/lib

A trivial application that is packaged as a Spring Boot jar but has no dependencies causes the Spring Boot buildpack to fail.

For example, a project that contains only one source file like this:

package example;

public class Main {
    public static void main(String[] args) {
    }
}

and a Gradle build file:

plugins {
	id 'java'
	id 'org.springframework.boot' version '2.2.4.RELEASE'
}

sourceCompatibility = '1.8'
targetCompatibility = '1.8'

will result in a jar file with these contents:

     0 Thu Feb 06 13:37:28 CST 2020 META-INF/
   217 Thu Feb 06 13:37:28 CST 2020 META-INF/MANIFEST.MF
     0 Mon Jan 20 18:15:20 CST 2020 org/
     0 Mon Jan 20 18:15:20 CST 2020 org/springframework/
     0 Mon Jan 20 18:15:20 CST 2020 org/springframework/boot/
[redacted]
     0 Thu Feb 06 13:37:28 CST 2020 BOOT-INF/
     0 Thu Feb 06 13:37:28 CST 2020 BOOT-INF/classes/
     0 Thu Feb 06 13:37:28 CST 2020 BOOT-INF/classes/example/
   449 Thu Feb 06 13:37:28 CST 2020 BOOT-INF/classes/example/Main.class

Note the absence of a BOOT-INF/lib directory.

When using pack with the builder cloudfoundry/cnb:0.0.51-bionic, this error occurs in the build phase:

[builder] Cloud Foundry Spring Boot Buildpack v1.2.4
[builder]   Spring Boot 2.2.4.RELEASE: Contributing to layer
[builder]     Writing CLASSPATH to shared
[builder]   5 application slices
[builder]   Process types:
[builder]     spring-boot: java -cp $CLASSPATH $JAVA_OPTS example.Main
[builder]     task:        java -cp $CLASSPATH $JAVA_OPTS example.Main
[builder]     web:         java -cp $CLASSPATH $JAVA_OPTS example.Main
[builder]
[builder] Cloud Foundry Spring Boot Buildpack v1.2.4
[builder]   lstat /workspace/BOOT-INF/lib: no such file or directory
[builder] ERROR: failed to build: exit status 103

created time in 15 days

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha bc3ee5b232774ef7180487f97f49a9d0b42052ba

Upgrade to RSocket 1.0.0-RC6 Closes gh-20048

view details

Andy Wilkinson

commit sha 7a9462bd3708d46e842c62dadd097232dd9f9b68

Upgrade to Spring Security 5.3.0.RC1 Closes gh-20046

view details

dreis2211

commit sha 268f696d19b3f873c095d4b07daa9d8c7569cce5

Add missing deployed plugin to modules This commit registers 'org.springframework.boot.deployed' to spring-boot-configuration-metadata and spring-boot-properties-migrator to make sure they are deployed as expected. See gh-20051

view details

Stephane Nicoll

commit sha 20204602392ef83721990224ae7872943c140961

Merge pull request #20051 from dreis2211 * pr/20051: Add missing deployed plugin to modules Closes gh-20051

view details

Russell Scheerer

commit sha 7f23b9dc16b340b8852fdac44ecc6ad5418465d1

Fix variable reference in maven-shade-plugin configuration See gh-20052

view details

Stephane Nicoll

commit sha 0083a59fe25ebe2b3e41321a5823e397b78020b6

Merge pull request #20052 from scheerer * pr/20052: Fix variable reference in maven-shade-plugin configuration Closes gh-20052

view details

Johnny Lim

commit sha 68182797517df49a62258a94d8084c1e22d74b9a

Fix typo See gh-20049

view details

Stephane Nicoll

commit sha a863ef63144b3efa22f6575224c14683f51198ef

Merge pull request #20049 from izeye * pr/20049: Fix typo Closes gh-20049

view details

dreis2211

commit sha c6ee121b0346e1a635b69b4e39f69f373f82d6ae

Set includeantruntime in Ant smoke tests See gh-20047

view details

Stephane Nicoll

commit sha 8204234e3d1a6881cffaf9d75055ce13df418224

Merge pull request #20047 from dreis2211 * pr/20047: Set includeantruntime in Ant smoke tests Closes gh-20047

view details

dreis2211

commit sha 20251ccae4db9f5f1609d7fb37d92234ed384b73

Remove superfluous useJUnit() See gh-20035

view details

Stephane Nicoll

commit sha 4b917c01ba78a8838520a28897e0d59d4c74ee3c

Merge pull request #20035 from dreis2211 * pr/20035: Remove superfluous useJUnit() Closes gh-20035

view details

dreis2211

commit sha 68bff6705e9d7aa6ba82f460c282080ffd7e391d

Use Dropwizard metrics BOM to manage dependencies See gh-20032

view details

Stephane Nicoll

commit sha f5d7e7755051d655132a7d2e0696c3677dfdb223

Polish "Use Dropwizard metrics BOM to manage dependencies" See gh-20032

view details

Stephane Nicoll

commit sha 4add9632def58321263204c7152644b75a75f52c

Merge pull request #20032 from dreis2211 * pr/20032: Polish "Use Dropwizard metrics BOM to manage dependencies" Use Dropwizard metrics BOM to manage dependencies Closes gh-20032

view details

push time in 15 days

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha 3f9d0058adebb02db74e5ad3433c872122fd32c6

Document new Docker-related features Closes gh-19868

view details

Madhura Bhave

commit sha 9382cd4db13fc1b50a34d698c9e48dd8179a2048

Polish wildcard location documentation

view details

Andy Wilkinson

commit sha b6a408ae77f6234ad3942713fd5c1bafa8960068

Upgrade to Spring Asciidoctor Extensions 0.4.0.RELEASE Closes gh-20041

view details

Andy Wilkinson

commit sha 45fd60337dd6068a04958628cf5f89a9b60c9905

Merge branch '2.1.x' into 2.2.x Closes gh-20042

view details

Andy Wilkinson

commit sha 5c2b28cb576ea14adb023e337275108e3a568c95

Merge branch '2.2.x' Closes gh-20043

view details

Andy Wilkinson

commit sha 6abd4f0737f9c51dcafe1dd401c9ec6340d8ddf7

Upgrade to Gradle Enterprise Conventions Plugin 0.0.2 Closes gh-20034

view details

Andy Wilkinson

commit sha 243e42f6fdce32a42a4bbf1f27ba9f7d2f0d0037

Upgrade to Artifactory Resource 0.0.11 Closes gh-20021

view details

Andy Wilkinson

commit sha ab512edb962cfb8f52c2f4aa771fa5d2dd98bf9a

Upgrade to Spring Session Dragonfruit-M1 Closes gh-20045

view details

push time in 16 days

GollumEvent

issue commentspring-projects/spring-boot

Restore deprecated code with no replacement that Spring Cloud Hoxton needs

So it looks like de1a26c and afb6788 fix this then?

Yes, those two commits have hopefully restored everything Cloud needs for compatibility.

spencergibb

comment created time in 16 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 56c5a3de6df517ba3330769b6af5176e4fa7938e

Disambiguate a class in RabbitMQ CLI sample Fixes gh-20003

view details

push time in 17 days

push eventspring-projects/spring-boot

Scott Frederick

commit sha 56c5a3de6df517ba3330769b6af5176e4fa7938e

Disambiguate a class in RabbitMQ CLI sample Fixes gh-20003

view details

push time in 17 days

issue closedspring-projects/spring-boot

spring boot cli - rabbit.groovy fails with error

<!-- Thanks for raising a Spring Boot issue. Please take the time to review the following categories as some of them do not apply here.

🙅 "Please DO NOT Raise an Issue" Cases

  • Question STOP!! Please ask questions about how to use something, or to understand why something isn't working as you expect it to, on Stack Overflow using the spring-boot tag.
  • Security Vulnerability STOP!! Please don't raise security vulnerabilities here. Head over to https://pivotal.io/security to learn how to disclose them responsibly.
  • Managed Dependency Upgrade You DO NOT need to raise an issue for a managed dependency version upgrade as there's a semi-automatic process for checking managed dependencies for new versions before a release. BUT pull requests for upgrades that are more involved than just a version property change are still most welcome.
  • With an Immediate Pull Request An issue will be closed as a duplicate of the immediate pull request, so you don't have to raise an issue if you plan to create a pull request immediately.

🐞 Bug report (please don't include this emoji/text, just add your details) Please provide details of the problem, including the version of Spring Boot that you are using. If possible, please provide a test case or sample application that reproduces the problem. This makes it much easier for us to diagnose the problem and to verify that we have fixed it.

🎁 Enhancement (please don't include this emoji/text, just add your details) Please start by describing the problem that you are trying to solve. There may already be a solution, or there may be a way to solve it that you hadn't considered.

TIP: You can always edit your issue if it isn't formatted correctly. See https://guides.github.com/features/mastering-markdown --> When attempting to run rabbit.groovy with spring cli, it fails with this error

$ spring run rabbit.groovy
startup failed:
file:rabbit.groovy: 29: You cannot create an instance from the abstract interface 'org.springframework.amqp.rabbit.annotation.Queue'.
 @ line 29, column 9.
           new Queue("spring-boot", false)
           ^

1 error

Spring CLI Version

$ spring --version
Spring CLI v2.2.3.RELEASE

closed time in 17 days

rameshvenk

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha ea5dfdec92a25f68509001dcb89c019ef2400ec1

Switch to latest snapshots of the GE conventions plugin See gh-20034

view details

push time in 17 days

issue commentspring-projects/spring-boot

Restore deprecated code with no replacement that Spring Cloud Hoxton needs

@spencergibb The 2.2.x branches of spring-cloud-build, spring-cloud-commons, and spring-cloud-netflix all now build for me with the latest Boot 2.3.0.BUILD-SNAPSHOT. Hopefully that covers any other projects that need these classes restored.

I had to add a direct dependency on spring-boot-starter-validation in a few subprojects to get them to build due to https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.3.0-M1-Release-Notes#validation-starter-no-longer-included-in-web-starters:

  • spring-cloud-commons / spring-cloud-loadbalancer
  • spring-cloud-netflix / spring-cloud-netflix-zuul
  • spring-cloud-netflix / spring-cloud-netflix-sidecar

That should be a backward-compatible change in dependencies.

spencergibb

comment created time in 17 days

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha 0a377647cadad9e6ee52f2d4aab420974075f56c

Import OAuth2 auto-configurations in web slice tests Fixes gh-19823

view details

Dmytro Nosan

commit sha aead3a7c447bce9d9a2452169b79715107fa33a3

Handle message of @ResponseStatus-annotated exception with WebFlux See gh-19901

view details

Stephane Nicoll

commit sha 12b644d73cfea40f5d3a3f05c586112a8fec69ce

Polish contribution See gh-19901

view details

Stephane Nicoll

commit sha 29fb2a3fd2dc1fc30cadf5db77ce034179698f00

Merge pull request #19901 from nosan * pr/19901: Polish contribution Handle message of @ResponseStatus-annotated exception with WebFlux Closes gh-19901

view details

Stephane Nicoll

commit sha fa239a0628cb603db37f33ff6a3c67085c187b55

Merge branch '2.1.x' into 2.2.x Closes gh-20028

view details

Stephane Nicoll

commit sha 6213ff6aaba34ef061885d72103fbf0ff92d970b

Merge branch '2.2.x' Closes gh-20029

view details

babjo

commit sha e323e05eeac70e6f14de71984c7a3ec1e5c4a580

Stop time web metrics when autotime is disabled See gh-19981

view details

Stephane Nicoll

commit sha 10643b770258b503e29a99c2eb3f25b5b35008ea

Polish "Stop time web metrics when autotime is disabled" See gh-19981

view details

Stephane Nicoll

commit sha 68acc41295b832020e64390bc2df3581528742ef

Merge pull request #19981 from babjo * pr/19981: Polish "Stop time web metrics when autotime is disabled" Stop time web metrics when autotime is disabled Closes gh-19981

view details

Stephane Nicoll

commit sha 9aef2bde77ed02691f03827bc516da1da508cd0f

Merge branch '2.2.x' Closes gh-20030

view details

Stephane Nicoll

commit sha d85bdfb23c5c30a9d7659a631e9be0232d432a71

Fix checkstyle violation

view details

Stephane Nicoll

commit sha 1c8732542078eecd722243039a716abbe8cfdf60

Merge branch '2.2.x'

view details

Andy Wilkinson

commit sha 35991d5eab0f3be67adc6bbaf9db743b94585674

Adopt Gradle Enterprise Conventions Plugin Closes gh-20033

view details

push time in 17 days

push eventspring-projects/spring-boot

Scott Frederick

commit sha 60f5bb1636c36beb6b86b1ff9fae4786431ea434

Remove health actuator code deprecated in 2.2 This partially re-applies the deprecation removal from commit https://github.com/spring-projects/spring-boot/commit/df1837a16bc39a9314e34e5e89c76e1ddf56372c, without removing CompositeHealthIndicator, HealthAggregator, and related configuration that is required by Spring Cloud.

view details

push time in 17 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 60f5bb1636c36beb6b86b1ff9fae4786431ea434

Remove health actuator code deprecated in 2.2 This partially re-applies the deprecation removal from commit https://github.com/spring-projects/spring-boot/commit/df1837a16bc39a9314e34e5e89c76e1ddf56372c, without removing CompositeHealthIndicator, HealthAggregator, and related configuration that is required by Spring Cloud.

view details

push time in 17 days

push eventscottfrederick/spring-boot

Madhura Bhave

commit sha e64a145ef0b0ac3a3bf97c41cff67af519ee6a71

Add support for wildcard locations for properties and YAML files Closes gh-19909

view details

push time in 17 days

push eventspring-projects/spring-boot

Scott Frederick

commit sha de1a26cf35b260fdf1133742cce00e64d31d033f

Revert "Remove deprecated HealthIndicator and HealthAggregator 2.2 code" This reverts commit df1837a16bc39a9314e34e5e89c76e1ddf56372c.

view details

push time in 18 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha de1a26cf35b260fdf1133742cce00e64d31d033f

Revert "Remove deprecated HealthIndicator and HealthAggregator 2.2 code" This reverts commit df1837a16bc39a9314e34e5e89c76e1ddf56372c.

view details

push time in 18 days

push eventscottfrederick/spring-boot

Johnny Lim

commit sha e6d5f5a2713d2200e5b418f0fedbdf7a75cdc43b

Polish See gh-19995

view details

Stephane Nicoll

commit sha 9b79208b602301ebb2603b52716e5da8d4682c9e

Upgrade copyright date See gh-19995

view details

Stephane Nicoll

commit sha 7cb13eb16eb93dec16fc08146795c7f28d1e351b

Merge pull request #19995 from izeye * pr/19995: Upgrade copyright date Polish Closes gh-19995

view details

Johnny Lim

commit sha 0ddf8be1510d4d3a9071319ebccb0656152f561f

Polish See gh-20001

view details

Stephane Nicoll

commit sha 199cea206ffe316f60a91122207bcaea613878c9

Merge pull request #20001 from izeye * pr/20001: Polish Closes gh-20001

view details

Andy Wilkinson

commit sha bca98c51261f2670564539670a104a3d1c61913b

Use a RegularFileProperty to configure BootBuildImage's input jar Closes gh-20010

view details

dreis2211

commit sha 56df70b0e742f45daa69e1f6b27360a5f755258a

Use Spring 5 module of Jersey See gh-20009

view details

Stephane Nicoll

commit sha ae169a3617ca3f3ed0f8488a2d3766236b7f043a

Merge pull request #20009 from dreis2211 * pr/20009: Use Spring 5 module of Jersey Closes gh-20009

view details

Johnny Lim

commit sha 6ef288f45b3715621930b132b0fabb24329e376c

Polish samples in doc See gh-20004

view details

Stephane Nicoll

commit sha 03d126cbd58761b65624e6f5dce673ef5cbd1a77

Merge pull request #20004 from izeye * pr/20004: Polish samples in doc Closes gh-20004

view details

Stephane Nicoll

commit sha 52659b1df45d5a1389483a6fac1a1b7fc99eb452

Merge branch '2.2.x' Closes gh-20013

view details

dreis2211

commit sha 326092b69ef5c508da485299da2bca7a5f542489

Upgrade to Ant 1.10.7 See gh-20002

view details

Stephane Nicoll

commit sha df67a0755d5919a9ca22d2533ce3030fe71c15ef

Merge pull request #20002 from dreis2211 * pr/20002: Upgrade to Ant 1.10.7 Closes gh-20002

view details

Stephane Nicoll

commit sha c8a5106cdf4f379b968bcbb45ad2f0f8e83a8911

Upgrade to spring-javaformat 0.0.20 This commit upgrades to spring javaformat 0.0.20 and Checkstyle 8.29. This commit also upgrades to the Checkstyle maven plugin 3.1.0. See gh-20011

view details

Stephane Nicoll

commit sha d5ed61317a4379e9d0e174ca6ea1723fa89e7ffd

Merge branch '2.1.x' into 2.2.x Closes gh-20015

view details

Stephane Nicoll

commit sha cf473eeb65b4b16ee9e371a21055b9739eca4056

Merge branch '2.2.x' Closes gh-20017

view details

Christoph Strobl

commit sha d2d6dbdc00a9be05a59f03430c780bf9884a694a

Upgrade to MongoDB Java Driver 4.0 beta1 See gh-19960

view details

Stephane Nicoll

commit sha c4daff72250a8f301ee602f4fbff558abdbc9629

Polish "Upgrade to MongoDB Java Driver 4.0 beta1" See gh-19960

view details

Stephane Nicoll

commit sha b2c0d1d3d6845083920ab7411344d7ff85fe2206

Merge pull request #19960 from christophstrobl * pr/19960: Polish "Upgrade to MongoDB Java Driver 4.0 beta1" Upgrade to MongoDB Java Driver 4.0 beta1 Closes gh-19960

view details

Stephane Nicoll

commit sha 5833d2c5e8c06b1f0003e6e036a31d5d2687dd28

Fix Embedded Mongo classpath check This commit changes the classpath check condition to verify that the core module of the MongoDB driver is present. Previously, we were only checking for the presence of the sync driver, making embedded support unavailable with the reactive variant. Closes gh-19960

view details

push time in 18 days

push eventscottfrederick/spring-cloud-config

Spencer Gibb

commit sha 72824ba5d580dbd50e7cf47259a8f714426cc629

Makes locateCollection() retryable

view details

buildmaster

commit sha 12d710b466180d76fa61e193004b0976ba08cc4d

Update SNAPSHOT to 2.2.1.RELEASE

view details

buildmaster

commit sha 644a437e36d4871c179233471979fee25860e7b1

Going back to snapshots

view details

buildmaster

commit sha 8a9af959d22b4cc34476a16cd9c6196eb083443d

Bumping versions to 2.2.2.BUILD-SNAPSHOT after release

view details

buildmaster

commit sha 1fe7634903bf80d96ad72ddbc69c75148a95b60e

Bumping versions

view details

Marcin Grzejszczak

commit sha 60b854727131d388f7ee741fc608457c14d86f91

Suggest full property to set for the demo to work with Vault The description shows what you need to do starting from Vault 0.10.0, now the fresh installation of Vault gives you version 1.3.1. Adding the full property name for those that have nothing to do with vault can come in handy. Also I think we should change the default to be `kvVersion=2`.

view details

Spencer Gibb

commit sha 2576c6cf4cd52168bfc0e53a278739c10d9db960

Makes sure origin tracked values are ordered. Moves from regular HashMap to LinkedHashMap to preserve ordering from the config server. fixes gh-1535

view details

Ryan Baxter

commit sha 9d67aa0e452fb6c4b8826419d2c7b03d5f35283c

Use a more robust filter when dealing with multiple keys (#1534) * Use a more robust filter when dealing with multiple keys. Fixes #1533 * Simplifying tests * Creating a variable for the Pattern to avoid creating it everytime

view details

Spencer Gibb

commit sha 707c496e4f03096d156af49aa560cb567db2cde8

Merge branch '2.1.x'

view details

Henryk Konsek

commit sha 3729648e5a66e53a0db2c3c0849ad1b3e33e3f8f

AbstractScmAccessor should apply logic from setBasedir. (#1471)

view details

Henryk Konsek

commit sha 231da25d7908b4637e015634d514a08a988520ad

AbstractScmAccessor should apply logic from setBasedir. (#1471)

view details

Alberto C. Ríos

commit sha 01be10e76caeb6a530b7d4130f4e0afe9c355003

Sharing default application config in CredHub (#1477) Always including application as default so that it can be shared accross all applications to be consistent with other repository implementations. Sharing secrets to the application from default profile. Updated the docs to reflect the changes

view details

Spencer Gibb

commit sha 4c7b8dfc7edaacb76a77e0c6ef9a5cfc200e3d02

Merge branch '2.1.x'

view details

Yi EungJun

commit sha 75f3bbcff115f0e21c841676f8b92f2eb3a8b0b0

Fix perf issue of KeyStoreTextEncryptorLocator (#1496) CipherEnvironmentEncryptor.decrypt() gets a TextEncryptor for each environment property by KeyStoreTextEncryptorLocator.locate() which calls KeyStoreKeyFactory.getKeyPair() to create an instance of RsaSecretEncrptor. Unfortunately KeyStoreKeyFactory.getKeyPair() seems extremely slow for jks files whose format is PKCS12. So we need not to repeat calling the method if possible. Reuse an intance of RsaSecretEncrptor to avoid the performance problem.

view details

buildmaster

commit sha 09aad0d92a09244ffb3bf716d031e3910f838bbd

Bumping versions

view details

Spencer Gibb

commit sha a389b4b43bf5624d48d010e67af84a5c45f36a87

Replaces deprecations

view details

Spencer Gibb

commit sha 82e60cae27479339e1b0c8b8887021aa6d565ee2

Updates to 3.0.0.BUILD-SNAPSHOT

view details

buildmaster

commit sha 1e1bd08daf0455e50a0799626635f586620235d9

Bumping versions

view details

buildmaster

commit sha 2dde8d4f4275af48fb1289468251413ad9831e0e

Bumping versions

view details

buildmaster

commit sha cce7d70b6bc19ffd8c5266f9a3a71eaed998bfed

Bumping versions

view details

push time in 18 days

push eventscottfrederick/spring-cloud-netflix

Ryan Baxter

commit sha f9424231a926f344d2c3c9dbeb165ccb8f404111

Merge pull request #2031 from doernbrackandre/fix_whitespaces_in_retryable_status_codes_list fixes a problem with whitespaces in list of retryable status codes

view details

Ryan Baxter

commit sha 7f7cdccb6b4ac7bddf4015e278cd2253f478a91b

Merge remote-tracking branch 'origin/master' into 2.0.x

view details

André Dörnbrack

commit sha 12a9a2e4851756d5610c93c25fb3ea52c2fbd85e

code cleanup

view details

André Dörnbrack

commit sha 0334c5a2897bec3c31b2d86b45fae132807072c9

Cleanup. Cherry picking #2031.

view details

Dave Syer

commit sha 4783b07407554bd3d5a727ef18fe498623b85acc

Support for multi-valued (batched) events in stream aggregator This allows clients to send batched up events in the same format as before (or to continue to send single events). We can switch the default format to an array in 1.4.x.

view details

Dave Syer

commit sha 1a0428da97766e0b5c034302b5adce31eb0f3bfd

Merge branch '1.3.x'

view details

Dave Syer

commit sha 310f558e9c8286f6fe60f41adb6b8ae9178fe7aa

Merge branch '1.3.x'

view details

Dave Syer

commit sha 63b2916993abcc66541fb6d0924423295ec03d68

Merge branch 'master' into 2.0.x

view details

Dave Syer

commit sha aac7799e3ef0fe3f782caca962b53d7ab31b6c8b

Clean up Zuul context in all tests

view details

Dave Syer

commit sha d39a22945b00266923137a0f33ac475ab439abfb

Merge branch '1.3.x'

view details

Dave Syer

commit sha a7675470ab5a30a63c55bf5b2efe6ffaf467b430

Merge branch 'master' into 2.0.x

view details

Ryan Baxter

commit sha ccae4e4ce26187a36da89aa9ecd52fdd15630d79

Bumping s-c-config version to 1.4.0

view details

Piotr Mionskowski

commit sha 779b026e6b309b4caf3c91cb94f2a94fc420e8e6

Override getThreadPool from HystrixConcurrencyStrategy and delegate to existing strategy if present. Fixes #2035

view details

Ryan Baxter

commit sha 9a878b0fbdd3ec338920caa8a01850782322b1d0

Merge pull request #2044 from bright/override_all_hystrix_concurrency_strategy_methods Override getThreadPool from HystrixConcurrencyStrategy and delegate to

view details

Ryan Baxter

commit sha 5c035768b0b2ed2b1946666e0bc76ee285b644b8

Merge remote-tracking branch 'origin/1.3.x'

view details

Ryan Baxter

commit sha 619580afe55cac51b8517b0badb2bdb20d12e214

Merge remote-tracking branch 'origin/master' into 2.0.x

view details

Ryan Baxter

commit sha 003fefa61d0952ddd1c86434e3106a46bb6913f0

Bumping release version

view details

Ryan Baxter

commit sha 7efa68e8538eba69e351892bf2bc37084020d38c

Merge remote-tracking branch 'origin/1.3.x'

view details

Ryan Baxter

commit sha 02e7594de5dd191e929b211fa159c26052187d75

Bumping s-c-stream to Ditmars

view details

Brandon Atkinson

commit sha 497b95ec645ef7d402269b18b01c8baea3a56cde

Rename *Test.java -> *Tests.java. Fixes #2042

view details

push time in 18 days

issue commentspring-projects/spring-boot

Restore deprecated code with no replacement that Spring Cloud Hoxton needs

Can you point us to the Spring Cloud projects that need CompositeHealthIndicator and HealthAggregator so we can test that we get the necessary classes back in place?

spencergibb

comment created time in 20 days

more