profile
viewpoint
Scott Frederick scottfrederick VMware Dallas/Fort Worth TX http://scottfrederick.io/

pivotal/credhub-release 32

BOSH release of CredHub server

krujos/data-lifecycle-service-broker 5

Cloud Foundry Service Broker for managing data lifecycle

scottfrederick/groovy-ddlutils 5

Groovy scripting for Apache DDLUtils

scottfrederick/aspectj-cobertura-example 2

Example of an AspectJ LTW and Cobertura problem

scottfrederick/cf-java-client-sample 1

A sample application for cloudfoundry-client-lib.

scottfrederick/cf-shutdown-hook 1

This app demonstrates graceful shutdown of an app running in Cloud Foundry.

scottfrederick/contacts 1

A Spring sample application

delete branch scottfrederick/spring-boot

delete branch : gh-18881

delete time in 8 days

push eventspring-projects/spring-boot

Scott Frederick

commit sha 54288678d13e609d7d8b270e3dbbd348ea59bf01

Configure Docker host in build plugins This commit adds the ability to configure the Maven and Gradle plugins to use a remote Docker daemon using build file configuration, as an alternative to setting environment variables to specify remote host connection details. Fixes gh-23400

view details

push time in 8 days

issue closedspring-projects/spring-boot

Configure Docker host in build plugins

The Maven and Gradle plugins will use the values of DOCKER_HOST, DOCKER_TLS_VERIFY, and DOCKER_CERT_PATH environment variables to connect to a remote Docker daemon. These environment variables are convenient when using minikube, but it would also be nice if the connection details could be specified in the build plugin configuration as an alternative to the environment.

With Gradle:

bootBuildImage {
    docker {
        host = "tcp://192.168.99.100:2376"
        tlsVerify = true
        certPath = "/home/user/.minikube/certs"
    }
}

With Maven:

	<plugin>
	    <groupId>org.springframework.boot</groupId>
	    <artifactId>spring-boot-maven-plugin</artifactId>
	    <configuration>
	        <docker>
	            <host>tcp://192.168.99.100:2376</host>
	            <tlsVerify>true</tlsVerify>
	            <certPath>/home/user/.minikube/certs</certPath>
	        </docker>
	    </configuration>
	</plugin>

closed time in 8 days

scottfrederick

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 54288678d13e609d7d8b270e3dbbd348ea59bf01

Configure Docker host in build plugins This commit adds the ability to configure the Maven and Gradle plugins to use a remote Docker daemon using build file configuration, as an alternative to setting environment variables to specify remote host connection details. Fixes gh-23400

view details

push time in 8 days

push eventscottfrederick/spring-boot

dreis2211

commit sha f85fe952fcb943c00e111bc806eff832395a0f33

Upgrade Java 15 CI image to use the Java 15 GA build See gh-23391

view details

Andy Wilkinson

commit sha 90483d343f979214dbda7703ee3639f118bb99d5

Merge pull request #23391 from dreis2211 * gh-23391: Upgrade Java 15 CI image to use the Java 15 GA build Closes gh-23391

view details

Phillip Webb

commit sha 8b8d5ccb10f71312b647291dc8d8956a001806df

Allow trailing whitespace document split marker Refine `OriginTrackedPropertiesLoader` document split detection to be more lenient if there is trailing whitespace. Closes gh-23399

view details

Phillip Webb

commit sha 35673b74724e0a2d7775dc1c637da1f7c16cac11

Add Binder to BootstrapContext Update `ConfigDataEnvironment` so that it adds the initial `Binder` to the `BootstrapContext` for `Bootstrappers` to use. Closes gh-23401

view details

Andy Wilkinson

commit sha 5ec673ff2a391fe41ec4d5702826dcb5ed9458ba

Add anchors to section headers in Gradle plugin docs Fixes gh-23402

view details

Andy Wilkinson

commit sha 3861ef13fbc5aa75512f006a15c02bf751f7bb45

Merge branch '2.2.x' into 2.3.x Closes gh-23406

view details

Andy Wilkinson

commit sha d2fae6e19ec93340ca1780d742533395bfa13da5

Merge branch '2.3.x' Closes gh-23407

view details

Andy Wilkinson

commit sha 95f26c6358efc25ef053a4871831c56089ba8933

Configure Flyway with initSqls for any DataSource configuration Previously, spring.flyway.init-sqls was only applied to Flyway's configuration if Flyway was being configured to create the DataSource. If Flyway was being configured to use an existing DataSource, init-sqls was not applied. This is a hangover from when the init SQLs support was introduced. At that time, Flyway only supported SQL to initialize the connection when it was creating the DataSource. Flyway 5.2 added init SQL support no matter how Flyway's DataSource was configured. This commit updates FlywayAutoConfiguration to always apply the init-sqls property to Flyway's configuration. The property's documentation does not describe the current limitation so this change should align the behaviour with what the documentation leads people to expect. Fixes gh-23392

view details

Andy Wilkinson

commit sha 55bfef9901287515182ad5a4409454cd2ded2077

Merge branch '2.2.x' into 2.3.x Closes gh-23408

view details

Andy Wilkinson

commit sha 1c6e37b2ac9acf4312195c7ef8fec55880790b2f

Merge branch '2.3.x' Closes gh-23409

view details

push time in 8 days

issue openedspring-projects/spring-boot

Configure Docker host in build plugins

The Maven and Gradle plugins will use the values of DOCKER_HOST, DOCKER_TLS_VERIFY, and DOCKER_CERT_PATH environment variables to connect to a remote Docker daemon. These environment variables are convenient when using minikube, but it would also be nice if the connection details could be specified in the build plugin configuration instead of in the environment.

With Gradle:

bootBuildImage {
    docker {
        host = "tcp://192.168.99.100:2376"
        tlsVerify = true
        certPath = "/home/user/.minikube/certs"
    }
}

With Maven:

	<plugin>
	    <groupId>org.springframework.boot</groupId>
	    <artifactId>spring-boot-maven-plugin</artifactId>
	    <configuration>
	        <docker>
	            <host>tcp://192.168.99.100:2376</host>
	            <tlsVerify>true</tlsVerify>
	            <certPath>/home/user/.minikube/certs</certPath>
	        </docker>
	    </configuration>
	</plugin>

created time in 9 days

push eventscottfrederick/spring-boot

Stephane Nicoll

commit sha e5d135c61cd89574395a3bb57262b944044ba468

Upgrade to Spring Kafka 2.3.11 Closes gh-23198

view details

Stephane Nicoll

commit sha a76f5ae03e625e57a0d829aa0a559b5b6fc380af

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha a2be6e08172e1026bab1c90d393e5e43f05c64ea

Upgrade to Spring Kafka 2.5.6 Closes gh-23199

view details

Stephane Nicoll

commit sha 1d66b25b262513a59ab19e5d97b9acf129159c55

Merge branch '2.3.x'

view details

Stephane Nicoll

commit sha 06b842e29c7bbd56c43e06962da8b5e269780d8c

Upgrade to Spring Kafka 2.6.1 Closes gh-23382

view details

Stephane Nicoll

commit sha bb6d86d30b3854340c68506b682aee11777ba0da

Upgrade to Spring Integration 5.4.0-M3 Closes gh-23010

view details

Stephane Nicoll

commit sha f1438f3e677642a2aa777383e6743a14776ec974

Upgrade to Spring Batch 4.3.0-RC1 Closes gh-23189

view details

Stephane Nicoll

commit sha db04672403c6b0e645cdd3f933998222da041d3c

Upgrade to Spring Session Bean-SR12 Closes gh-23185

view details

Stephane Nicoll

commit sha 91c1d52fc10c51b12a583128c249908718c3aa06

Upgrade to Micrometer 1.1.18 Closes gh-23384

view details

Stephane Nicoll

commit sha 3e93a3ec58b8b24109ba5b7ea5a776fe73f8c174

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 29988f1d38f3683e998ecd79eaceeb9c87c77ed3

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 71aa911c61c41ad86d5e32d9be40296aa7cf4d58

Merge branch '2.3.x'

view details

Stephane Nicoll

commit sha 35b33303d0da595cd4f5962b1a5407e13a56791e

Upgrade to Spring Session Corn-SR4 Closes gh-23186

view details

Stephane Nicoll

commit sha ab2115633f79750182ce9194ff5170ae6aa04ce1

Upgrade to Micrometer 1.3.14 Closes gh-23388

view details

Stephane Nicoll

commit sha 0b06457aceda5fb347a1945747ff56034051e0b9

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 3622fd5b04d37e4c3f2b7d211d26014398a46ef8

Upgrade to Spring Session Dragonfruit-SR1 Closes gh-23187

view details

Stephane Nicoll

commit sha 0867b3cf877cbb54f6c82f35bc83a0bc5b3b0a7f

Merge branch '2.3.x'

view details

Stephane Nicoll

commit sha 4d7339d189f1498a1c40c6e5cb6f6138b34cfd1c

Upgrade to Spring Session 2020.0.0-RC1 Closes gh-23188

view details

Stephane Nicoll

commit sha 268904d6ae0714c0917e7a5a65cc20163837a6e0

Upgrade Java 15 version in CI image Closes gh-23379

view details

Phillip Webb

commit sha 6509310fdbf052c0bb181ce07af1029a5feed622

Fix DefaultPropertiesPropertySource package tangle Relocate `DefaultPropertiesPropertySource` to fix a package tangle. Closes gh-23383

view details

push time in 9 days

push eventscottfrederick/spring-boot

Phillip Webb

commit sha 4138e59c33549e15b5d2d4de33c18ece13890fb0

Fix potential JarFileEntries ClassCastException Update `JarFileEntries` so that the interface is obtained rather than the concrete implementation. This allows `JarEntry` values to be used without causing a ClassCastException. Closes gh-19041

view details

Phillip Webb

commit sha b8e6b2ef9402ad53e4db780cf821c45d6d1824c1

Merge branch '2.1.x' into 2.2.x

view details

Phillip Webb

commit sha a249a1a3d15eab101f462344e5e734d43bad0d00

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha a5905c5cb92d025525dc38a3c8186629805d4221

Upgrade to Reactor Californium-SR21 Closes gh-23190

view details

Stephane Nicoll

commit sha a7341b4a46c4abbae4c35366f5c62b512f64e629

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha bc9c6dc005a6c12e374ad0d8608758fe4e34b6b0

Upgrade to Reactor Dysprosium-SR12 Closes gh-23191

view details

Stephane Nicoll

commit sha 09e864fafd94cda0e976c25e6931bf3206ed2b67

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 2ee22d50b4b9942ed9e65f9373e1b6b8f6ccebb7

Upgrade to Reactor Dysprosium-SR12 Closes gh-23192

view details

Andy Wilkinson

commit sha 5d20660c8a026bfd73259488f162f222e739382c

Disable proxyBeanMethods on all management context config classes Fixes gh-23301

view details

Andy Wilkinson

commit sha 53f2966b61531bb5b8115ab3ea00ac3fe9e24cd4

Merge branch '2.2.x' into 2.3.x Closes gh-23305

view details

Stephane Nicoll

commit sha d73ee9d54518d645096c8eeee804c3cf4048b38f

Upgrade to Spring Framework 5.1.18 Closes gh-23181

view details

Stephane Nicoll

commit sha 825ad0037097db0ac354e7bc135f63086c8902e6

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 95a33071ca9c9d1cdde7364fb6b4780c6cc68920

Upgrade to Spring Framework 5.2.9 Closes gh-23182

view details

Stephane Nicoll

commit sha c1b67ab7e8079917a8a0da2179ec50e110226308

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 5517cd06dfe4fc47453f7c87f8d9e3bf62e12243

Upgrade to Spring Framework 5.2.9 Closes gh-23183

view details

Stephane Nicoll

commit sha 94d5e11e7d0acb12853eb0cd5f902febf8a5478c

Upgrade to AppEngine SDK 1.9.82 Closes gh-23307

view details

Stephane Nicoll

commit sha c9f413edfb5b65185e8445f7079db378d67ae7cd

Upgrade to Couchbase Client 3.0.8 Closes gh-23308

view details

Stephane Nicoll

commit sha b1d33a3df9b283d1b2445c24bc2e513458b3a414

Upgrade to Flatten Maven Plugin 1.2.5 Closes gh-23309

view details

Stephane Nicoll

commit sha 9b3148ce3f1118d4f90d3155ca49840f49096cbd

Upgrade to Hazelcast 3.12.9 Closes gh-23310

view details

Stephane Nicoll

commit sha 8738e05f59a3b33f39bd31edf687384053ff56e2

Upgrade to Hibernate 5.4.21.Final Closes gh-23311

view details

push time in 9 days

issue commentspring-projects/spring-boot

Spring boot : Not Able to do junit testing for controller having dependency on service annotated by @Qualifier

Thanks for getting in touch, but there isn't enough information provided to be able to provide much assistance. It isn't clear where the EmailService bean should be getting created in the test setup.

It feels like this is a question that would be better suited to Stack Overflow. As mentioned in the guidelines for contributing, we prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug.

cshekhar786

comment created time in 10 days

issue closedspring-projects/spring-boot

Spring boot : Not Able to do junit testing for controller having dependency on service annotated by @Qualifier

controller class: public class ProfileController{ ...... @Autowired @Qualifier("harmonyService") private EmailService emailService;

... ... .. }

junit test : @ExtendWith(SpringExtension::class) @ActiveProfiles("test,jsonlogs") @WebMvcTest(value = [ProfileController::class]) class ProfileApiApplicationTests {

@Autowired private lateinit var emailService: EmailService

}

Error: Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'profileController': Unsatisfied dependency expressed through field 'emailService'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'com.loyaltyone.account.profileapi.services.EmailService' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true), @org.springframework.beans.factory.annotation.Qualifier(value=harmonyService)} at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:596) at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:90) at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:374) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1378) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:575) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:498) at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320) at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222) at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318) at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)

closed time in 10 days

cshekhar786

issue commentspring-projects/spring-boot

Add a command line option for image.cleanCache when building with Maven

The command-line option for cache cleaning should be added to the Gradle plugin also.

For the Maven plugin, the command-line option should be mvn spring-boot:build-image -Dspring-boot.build-image.cleanCache=[true|false]. For the Gradle plugin, the command-line option would be gradle bootBuildImage --cleanCache=[true|false].

dsyer

comment created time in 10 days

pull request commentspring-projects/spring-boot

Support authentication from Docker daemon to private docker registry.

If I'm understanding it right, this is needed to bootBuildImage push to ECR?

@crimsonvspurple Apologies for missing this question earlier. The bootBuildImage task won't push the resulting image to a Docker registry, it only creates the image in the local Docker daemon. This feature is needed if custom CNB builder or run images are used and those custom images need to be pulled from a private Docker registry.

wmz7year

comment created time in 10 days

pull request commentspring-projects/spring-boot

Support authentication from Docker daemon to private docker registry.

@wmz7year Thank you very much for the contribution. I made some changes in https://github.com/spring-projects/spring-boot/commit/86fa8144f57ecfa59d02400a4ad26cd6fb297fe1 to refactor the code to better match project conventions and to add documentation.

It took a while to test this, because using the identitytoken authentication described in the Docker Engine documentation does not appear to be supported by the Docker registries I was testing against. Any additional testing and feedback anyone can provide with these authentication options would be appreciated.

wmz7year

comment created time in 10 days

push eventspring-projects/spring-boot

姜为

commit sha e8f555e13dba5a29ecde34875aed737b8bee878c

Support authentication to private docker registry This commit adds the ability to configure Docker image registry authentication credentials in the Maven and Gradle plugins. The authentication credentials are passed to the Docker daemon with all daemon API calls, and the daemon forwards the credentials to the image registry when necessary. This makes it possible to use builder and run images stored in a private Docker registry. See gh-22972

view details

Scott Frederick

commit sha 86fa8144f57ecfa59d02400a4ad26cd6fb297fe1

Polish "Support authentication to private Docker registry" See gh-22972

view details

Scott Frederick

commit sha d1338a66f791769c3760fb53662e5b64c5a8ef20

Merge pull request #22972 from wmz7year * gh-22972: Polish "Support authentication to private Docker registry" Support authentication to private docker registry Closes gh-22972

view details

push time in 10 days

push eventscottfrederick/spring-boot

姜为

commit sha e8f555e13dba5a29ecde34875aed737b8bee878c

Support authentication to private docker registry This commit adds the ability to configure Docker image registry authentication credentials in the Maven and Gradle plugins. The authentication credentials are passed to the Docker daemon with all daemon API calls, and the daemon forwards the credentials to the image registry when necessary. This makes it possible to use builder and run images stored in a private Docker registry. See gh-22972

view details

Scott Frederick

commit sha 86fa8144f57ecfa59d02400a4ad26cd6fb297fe1

Polish "Support authentication to private Docker registry" See gh-22972

view details

Scott Frederick

commit sha d1338a66f791769c3760fb53662e5b64c5a8ef20

Merge pull request #22972 from wmz7year * gh-22972: Polish "Support authentication to private Docker registry" Support authentication to private docker registry Closes gh-22972

view details

push time in 10 days

push eventscottfrederick/spring-boot

Stephane Nicoll

commit sha 9a09a3c570bb1a9058074638e79102daa2f3382d

Upgrade to Spring AMQP 2.1.17 Closes gh-23371

view details

Stephane Nicoll

commit sha ae458298b2058916403118633f5d6e776b1649a7

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 9ab8ad6e74fa05c762ff0ce5d257a3e670e6fab5

Upgrade to Spring AMQP 2.2.11 Closes gh-23372

view details

Stephane Nicoll

commit sha aee1be587fb960b28534869f625df1b45c87c55f

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 7a7aef80d9473d0b1acd707deccafab8862f04d8

Upgrade to Spring AMQP 2.2.11 Closes gh-23373

view details

Stephane Nicoll

commit sha 38aba5edb1a74dadd9f8d655c3760420bdadb144

Merge branch '2.3.x'

view details

Stephane Nicoll

commit sha 32bf5b6e89b0d394fb20e6591ff93f698fde57ec

Upgrade to Spring AMQP 2.3.0-M3 Closes gh-23011

view details

Andy Wilkinson

commit sha 106968a1156d0ef274522dec48d8b62d5a2dc717

Upgrade to Spring REST Docs 2.0.5.RELEASE Closes gh-23374

view details

Andy Wilkinson

commit sha e87e52d035fd50ac8b6f82b9d1b9574853de7012

Merge branch '2.1.x' into 2.2.x Closes gh-23375

view details

Andy Wilkinson

commit sha d6586b83544b0c06d88d7b5221fc839d1b6667d4

Merge branch '2.2.x' into 2.3.x Closes gh-23376

view details

Andy Wilkinson

commit sha 5dbf6a38856536b18222e24dcd07a5e9cce00304

Merge branch '2.3.x' Closes gh-23377

view details

Andy Wilkinson

commit sha d3d96f04178de5fab7288391bfa7b5af3a6d3068

Upgrade to Spring REST Docs 2.0.5.RELEASE Closes gh-23374

view details

Andy Wilkinson

commit sha caa417659ee6bf958c3c409a3c359294f77ab001

Merge branch '2.1.x' into 2.2.x

view details

Andy Wilkinson

commit sha d5234a9254c83bba020d1eb6a8af798419fb3924

Merge branch '2.2.x' into 2.3.x

view details

Andy Wilkinson

commit sha c624008638ef2c8d02ef7fcbfe775b76e887395e

Merge branch '2.3.x'

view details

Andy Wilkinson

commit sha 358b9f839a05f2dea3a1893f7cff2e3e13d4bf3c

Remove spring-boot.version property from spring-boot-dependencies The version of Spring Boot should not be modifiable by a property, only being using a different version of spring-boot-dependencies or spring-boot-starter-parent. Fixes gh-23174

view details

Andy Wilkinson

commit sha f0dfff81d4f62dc071d273729984fa902386814c

Merge branch '2.3.x' Closes gh-23378

view details

push time in 10 days

push eventscottfrederick/spring-boot

Phillip Webb

commit sha 4138e59c33549e15b5d2d4de33c18ece13890fb0

Fix potential JarFileEntries ClassCastException Update `JarFileEntries` so that the interface is obtained rather than the concrete implementation. This allows `JarEntry` values to be used without causing a ClassCastException. Closes gh-19041

view details

Phillip Webb

commit sha b8e6b2ef9402ad53e4db780cf821c45d6d1824c1

Merge branch '2.1.x' into 2.2.x

view details

Phillip Webb

commit sha a249a1a3d15eab101f462344e5e734d43bad0d00

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha 433b3574234a5f8e4b72671d7f6902020105d1e4

Merge branch '2.3.x'

view details

Phillip Webb

commit sha c857a743a0b28e13d5f9d3e141c6695e29d6eeea

Rename @ImportConfigurationPropertiesBean Rename `@ImportConfigurationPropertiesBean` to `@ConfigurationPropertiesImport`. Closes gh-23172

view details

Stephane Nicoll

commit sha a5905c5cb92d025525dc38a3c8186629805d4221

Upgrade to Reactor Californium-SR21 Closes gh-23190

view details

Stephane Nicoll

commit sha a7341b4a46c4abbae4c35366f5c62b512f64e629

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha bc9c6dc005a6c12e374ad0d8608758fe4e34b6b0

Upgrade to Reactor Dysprosium-SR12 Closes gh-23191

view details

Stephane Nicoll

commit sha 09e864fafd94cda0e976c25e6931bf3206ed2b67

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 2ee22d50b4b9942ed9e65f9373e1b6b8f6ccebb7

Upgrade to Reactor Dysprosium-SR12 Closes gh-23192

view details

Stephane Nicoll

commit sha c1b1f54714180dcd1dd5adcff7378a6d48f82328

Merge branch '2.3.x'

view details

Stephane Nicoll

commit sha 688b0b76489eab33da36534e1a2500fbbd32a76b

Upgrade to Reactor 2020.0.0-RC1 Closes gh-23065

view details

Stephane Nicoll

commit sha 63268f33fe646339b706439a1d77cb09c27d23f8

Upgrade to RSocket 1.1.0-M2 Closes gh-23214

view details

Andy Wilkinson

commit sha 5d20660c8a026bfd73259488f162f222e739382c

Disable proxyBeanMethods on all management context config classes Fixes gh-23301

view details

Andy Wilkinson

commit sha 53f2966b61531bb5b8115ab3ea00ac3fe9e24cd4

Merge branch '2.2.x' into 2.3.x Closes gh-23305

view details

Andy Wilkinson

commit sha 9d3c718bf31ff90936a4bacb5c27ef3e32291e60

Merge branch '2.3.x' Closes gh-23306

view details

Stephane Nicoll

commit sha d73ee9d54518d645096c8eeee804c3cf4048b38f

Upgrade to Spring Framework 5.1.18 Closes gh-23181

view details

Stephane Nicoll

commit sha 825ad0037097db0ac354e7bc135f63086c8902e6

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 95a33071ca9c9d1cdde7364fb6b4780c6cc68920

Upgrade to Spring Framework 5.2.9 Closes gh-23182

view details

Stephane Nicoll

commit sha c1b67ab7e8079917a8a0da2179ec50e110226308

Merge branch '2.2.x' into 2.3.x

view details

push time in 10 days

issue commentspring-cloud/spring-cloud-config

Config Server - PCF Auth breaks after 24 hours

I think @nebhale created a component that reloads the certificates in a keystore.

That's part of the Java buildpack for CF: https://github.com/cloudfoundry/java-buildpack-security-provider

kamalakarp

comment created time in 12 days

push eventscottfrederick/spring-boot

dreis2211

commit sha 97ec232935b6c9b93b09e9d70fd84c514bd17bd2

Reinstate smoketest.rsocket.SampleRSocketApplicationTests.rSocketEndpoint() See gh-23246

view details

Andy Wilkinson

commit sha 4e5161d5dcaa2f362a774a24774c94aeb3df4421

Merge pull request #23246 from dreis2211 * gh-23246: Reinstate smoketest.rsocket.SampleRSocketApplicationTests.rSocketEndpoint() Closes gh-23246

view details

Stephane Nicoll

commit sha 7c13c01cb6a62b86478aa53d3516ae8aaea48bca

Fix mapping of Cassandra's idle-timeout and heartbeat-interval Previous to this commit the connection idle timeout and heartbeat interval were mapped to seconds whereas Cassandra expects ms for all duration types. This commit fixes the mapping and removes the default duration unit since it should be considered ms like every other duration properties. Closes gh-23249

view details

Stephane Nicoll

commit sha 36d4e95254ef6743b0804f6fc68bf06b3e61e1f9

Merge branch '2.3.x' Closes gh-23251

view details

David Good

commit sha 775f0fa8613c5360bac2159f4c45089733049587

Improve sanitization for list of URI types Prior to this commit, Actuator would sanitize properties values when serializing them on the dedicated endpoint. Keys like "password" or "secret" are entirely sanitized, but other keys like "uri" or "address" are considered as URI types and only the password part of the user info is sanitized. This commit fixes the sanitization process where lists of such URI types would not match the first entries of the list since they're starting with `'['`. This commit improves the regexp matching process to sanitize all URIs within a collection. The documentation is also updated to better underline the processing difference between complete sanitization and selective sanitization for URIs. Fixes gh-23037

view details

Brian Clozel

commit sha 62cb87bd9542b3cb9a30fdcf1841393155ba07e8

Merge branch '2.2.x' into 2.3.x Closes gh-23252

view details

Brian Clozel

commit sha 20eb8d0fc22dbd84e392a50a305c6bbbf7efb21d

Merge branch '2.3.x' Closes gh-23253

view details

anshlykov

commit sha 2527fcac9ccb903de1fa8a6322bb9406b42e871f

Add separate property for Redis read and connection timeout See gh-23137

view details

Stephane Nicoll

commit sha 7a8b7b9fa7fb95f3be779b271c180f825dc8d39c

Polish "Add separate property for Redis read and connection timeout" See gh-23137

view details

Stephane Nicoll

commit sha 26daf3714e34060a2451d4a203fd524729fc3cfd

Merge pull request #23137 from anshlykov * pr/23137: Polish "Add separate property for Redis read and connection timeout" Add separate property for Redis read and connection timeout Closes gh-23137

view details

Stephane Nicoll

commit sha f03ed3b2a7762e915861a43502c03bd203c22bc6

Publish single page doc to /htmlsingle consistently Closes gh-21585

view details

Andy Wilkinson

commit sha 3a4228c432b965166916beeebfd9b850fef8e951

Make it possible to link to individual configuration properties Closes gh-16267

view details

lock14

commit sha d1d953819ac9f0c0ece5160b96899030cabda46c

Allow other "timestamp" types in MVC error model Remove casting "timestamp" to `java.util.Date` in `ErrorMvcAutoConfiguration` as the cast is not necessary and it prevents other types (e.g. `java.time`) from being used. See gh-23256

view details

Phillip Webb

commit sha d8232b3c21836e77655781a55d29baffa08bc8db

Polish 'Allow other "timestamp" types in MVC error model' See gh-23256

view details

Phillip Webb

commit sha 018cc1c84a7e012859a84953d57955906c0f2c21

Merge pull request #23256 from lock14 * pr/23256: Polish 'Allow other "timestamp" types in MVC error model' Allow other "timestamp" types in MVC error model Closes gh-23256

view details

Phillip Webb

commit sha 507fae514128b861cf6c2ada681e0a901f0cea16

Merge branch '2.2.x' into 2.3.x Closes gh-23258

view details

Phillip Webb

commit sha f1d9832282110d2c082bfd96c031227134b3bbd6

Merge branch '2.3.x' Closes gh-23259

view details

Phillip Webb

commit sha f5ae58e8e5662290396a48141bb7b076bc9fe806

Fix deprecation warning See gh-23256

view details

Phillip Webb

commit sha 922b4c04bf4dfe8d8c869852c984f29e383a65f2

Merge branch '2.3.x'

view details

Phillip Webb

commit sha 326a56da01e1e32f3b4b3123983f982b090cc6ad

Support validation of bound map key entries Update `ValidationBindHandler` so that pushed fields that reference map keys can be used. This fixes a regression that was introduced in commit 4483f417 when we switched to a `AbstractBindingResult` that no longer required public getters/setters. Closes gh-20350

view details

push time in 12 days

push eventscottfrederick/spring-boot

Stephane Nicoll

commit sha 7c13c01cb6a62b86478aa53d3516ae8aaea48bca

Fix mapping of Cassandra's idle-timeout and heartbeat-interval Previous to this commit the connection idle timeout and heartbeat interval were mapped to seconds whereas Cassandra expects ms for all duration types. This commit fixes the mapping and removes the default duration unit since it should be considered ms like every other duration properties. Closes gh-23249

view details

David Good

commit sha 775f0fa8613c5360bac2159f4c45089733049587

Improve sanitization for list of URI types Prior to this commit, Actuator would sanitize properties values when serializing them on the dedicated endpoint. Keys like "password" or "secret" are entirely sanitized, but other keys like "uri" or "address" are considered as URI types and only the password part of the user info is sanitized. This commit fixes the sanitization process where lists of such URI types would not match the first entries of the list since they're starting with `'['`. This commit improves the regexp matching process to sanitize all URIs within a collection. The documentation is also updated to better underline the processing difference between complete sanitization and selective sanitization for URIs. Fixes gh-23037

view details

Brian Clozel

commit sha 62cb87bd9542b3cb9a30fdcf1841393155ba07e8

Merge branch '2.2.x' into 2.3.x Closes gh-23252

view details

lock14

commit sha d1d953819ac9f0c0ece5160b96899030cabda46c

Allow other "timestamp" types in MVC error model Remove casting "timestamp" to `java.util.Date` in `ErrorMvcAutoConfiguration` as the cast is not necessary and it prevents other types (e.g. `java.time`) from being used. See gh-23256

view details

Phillip Webb

commit sha d8232b3c21836e77655781a55d29baffa08bc8db

Polish 'Allow other "timestamp" types in MVC error model' See gh-23256

view details

Phillip Webb

commit sha 018cc1c84a7e012859a84953d57955906c0f2c21

Merge pull request #23256 from lock14 * pr/23256: Polish 'Allow other "timestamp" types in MVC error model' Allow other "timestamp" types in MVC error model Closes gh-23256

view details

Phillip Webb

commit sha 507fae514128b861cf6c2ada681e0a901f0cea16

Merge branch '2.2.x' into 2.3.x Closes gh-23258

view details

Phillip Webb

commit sha f5ae58e8e5662290396a48141bb7b076bc9fe806

Fix deprecation warning See gh-23256

view details

Phillip Webb

commit sha 326a56da01e1e32f3b4b3123983f982b090cc6ad

Support validation of bound map key entries Update `ValidationBindHandler` so that pushed fields that reference map keys can be used. This fixes a regression that was introduced in commit 4483f417 when we switched to a `AbstractBindingResult` that no longer required public getters/setters. Closes gh-20350

view details

Phillip Webb

commit sha 5294c348073530b2f175ab31f7f8d111c5ace23b

Merge branch '2.2.x' into 2.3.x Closes gh-23260

view details

mathieufortin01

commit sha 6bf1bd5712230d6b1b238832dbb82e6ff986f600

Ignore Visual Studio Code Files See gh-19041

view details

mathieufortin01

commit sha 4d053e15d8fa58a87b1b1c5da55efb456e547e5e

Fix signed jar performance issues Update Spring Boot nested JarFile support to improve the performance of signed jars. Prior to this commit, `certificates` and `codeSigners` were read by streaming the entire jar whenever the existing values were `null`. Unfortunately, the contract for `getCertificates` and get `getCodeSigners` states that `null` is a valid return value. This meant that full jar streaming would occur whenever either method was called on an entry that had no result. The problem was further exacerbated by the fact that entries might not be cached. See gh-19041

view details

Phillip Webb

commit sha c6a9696dd197fa0f5087fbe9b662226a1b9d771e

Polish 'Fix signed jar performance issues' Update the performance improvements to push certificate loading and storage into the `JarFileEntries` class. This allows us to keep certificates without needing to cache all entry data. We now also keep certificates and code signers in a dedicated class which is set whenever the full jar stream as been read, even if the contained values are `null`. The logic that assumes META-INF entries are not signed has been removed in favor of delegating to the streamed entry results. See gh-19041

view details

Phillip Webb

commit sha 895ff9c72d0a3f983c96e2f336b4ab1cbf50513d

Merge pull request #19041 from mathieufortin01 * pr/19041: Polish 'Fix signed jar performance issues' Fix signed jar performance issues Ignore Visual Studio Code Files Closes gh-19041

view details

Phillip Webb

commit sha a20fdf8e6a3e2b76fedc539923a85c8a1aeb8b99

Merge branch '2.1.x' into 2.2.x Closes gh-23263

view details

Phillip Webb

commit sha 45275e6586ea5d63bf89340fd7b7232788c6907d

Merge branch '2.2.x' into 2.3.x Closes gh-23264

view details

Stephane Nicoll

commit sha 76fd9a530caf7e0f317267d160bf05469b50f5e9

Upgrade to Jackson 2.9.10.20200824 Closes gh-23266

view details

Stephane Nicoll

commit sha fb935ecb8d056a43534d0ad2ee613ecf73be074f

Upgrade to Appengine Sdk 1.9.82 Closes gh-23267

view details

Stephane Nicoll

commit sha e5a9a7ae83c9a159002fbfdf4103bdb943563e8e

Upgrade to Micrometer 1.1.17 Closes gh-23268

view details

Stephane Nicoll

commit sha 6d99776d9dabff6d6f010cb02fe83b97ccc766f7

Upgrade to Netty Tcnative 2.0.34.Final Closes gh-23270

view details

push time in 12 days

pull request commentspring-projects/spring-boot

Support authentication from Docker daemon to private docker registry.

Merging the PR is in progress, with some changes and added documentation.

wmz7year

comment created time in 14 days

issue commentspring-cloud/spring-cloud-connectors

spring-cloud-cloudfoundry-connector 2.0.7.RELEASE can't be used in a modular Java 11 project

@nictas As noted in the README, the Spring Cloud Connectors project is in maintenance mode. The spring-cloud-cloudfoundry-connector module does in fact shadow Jackson libraries. This is one of the problems with maintaining the library and one of the reasons we chose to replace it with the Java CFEnv project. Removing the Jackson shading would break backward compatibility for many users of the library and would require a major version release, which we won't be doing.

If your project used Spring Boot the migration from Connectors to Java CFEnv would be pretty seamless, but it looks like your project is mostly using the lower-level Connectors API to get information and credentials from a service. You should be able to move this over to Java CFEnv using its lower-level API to retrieve the same information.

Patterns using Connectors like:

CloudFactory cloudFactory = new CloudFactory();
Cloud cloud = cloudFactory.getCloud();
ServiceInfo serviceInfo = cloud.getServiceInfo(serviceName);
String value = serviceInfo.getValue();

would be replaced with something like:

CfEnv cfEnv = new CfEnv();
CfCredentials credentials = cfEnv.findCredentialsByName(serviceName);
String value = credentials.getString("value");

I'd be happy to provide any assistance I can with moving the project from Connectors to Java CFEnv so it is better positioned for Java 11 and beyond.

nictas

comment created time in 15 days

issue closedspring-projects/spring-credhub

GetServiceInstanceBindingRequest is missing optional query string parameters

As Open Service Broker specification defines getting (fetching) a service binding

The request provides these query string parameters as useful hints for brokers.

Query-String Field Type Description
service_id string ID of the Service Offering from the catalog. If present, MUST be a non-empty string.
plan_id string ID of the Service Plan from the catalog. If present, MUST be a non-empty string.

Currently the spring implementation does not support this. Could you please suport them? When using credhub as credential storage, broker needs the serviceOfferingName to create the ServiceInstanceCredentialName and it would be helpful to retrieve it from catalog when this parameters would be included in request.

closed time in 15 days

Zavael

issue commentspring-projects/spring-credhub

GetServiceInstanceBindingRequest is missing optional query string parameters

@Zavael This issue appears to be misplaced, as providing parameters to service brokers is the responsibility of the Spring Cloud Open Service Broker project, not Spring CredHub. It looks like the issue has already been raised in Spring Cloud Open Service Broker, and a fix is planned for a future release. If you don't think that issue addresses your needs, please open a new issue in that project.

I'll close this issue in favor of the Spring Cloud OSB issue. Feel free to re-open it with more information if you think there's something else Spring CredHub needs to do.

Zavael

comment created time in 15 days

push eventscottfrederick/spring-boot

Dario Seidl

commit sha 22d03b21dfa2840bc4a4bb641fa7a30e7fd98b1d

Add reference to AOProfiling Spring Boot starter See gh-23161

view details

Stephane Nicoll

commit sha bd9928cc3139e0bc9024f718a830dea9487206c0

Merge pull request #23161 from darioseidl * pr/23161: Add reference to AOProfiling Spring Boot starter Closes gh-23161

view details

Josh Cummings

commit sha 5187c01e39abe6ba8d676fff5585343889f09785

Configure SAML 2.0 Service Provider via Metadata See gh-23045

view details

Stephane Nicoll

commit sha 681abcc18577e2e61dccd64e14ffdee2eeeeb2f0

Polish "Configure SAML 2.0 Service Provider via Metadata" See gh-23045

view details

Stephane Nicoll

commit sha 1926065f3ef26b094b222e125ad3fd411296e2d3

Merge pull request #23045 from jzheaux * pr/23045: Polish "Configure SAML 2.0 Service Provider via Metadata" Configure SAML 2.0 Service Provider via Metadata Closes gh-23045

view details

Andy Wilkinson

commit sha de671035a84ba7592d1cda566ca199362a26cd7b

Upgrade build to Gradle 6.6.1 Closes gh-23168

view details

Andy Wilkinson

commit sha ed1c9f5e4ecbcd48705b2961a8d4118157c8b46d

Merge branch '2.3.x' Closes gh-23169

view details

Brian Clozel

commit sha f50927f7a18d43803da8007871d463a9ab9e6cdf

Start building against Spring Framework 5.3.0.RC1 SNAPSHOTs See gh-23170

view details

Eddú Meléndez

commit sha db8d117d3839701b2b65f8b5fdf6db5f2fe37f6e

Upgrade to Assertj 3.17.2 See gh-23179

view details

Stephane Nicoll

commit sha 1b68efa4783ba0d5b5a4403ebb95551b252add10

Polish "Upgrade to Assertj 3.17.2" See gh-23179

view details

Stephane Nicoll

commit sha e95cc584fd79875a3add4a424b6753a4f92029db

Merge pull request #23179 from eddumelendez * pr/23179: Polish "Upgrade to Assertj 3.17.2" Upgrade to Assertj 3.17.2 Closes gh-23179

view details

Stephane Nicoll

commit sha 4b5a3f4ff95bcd3a0ddb93c0215e2de338949752

Start building against Spring Framework 5.2.9 snapshots See gh-23182

view details

Stephane Nicoll

commit sha d2eeb9524f5abb846964b4f8f3de60d2aeac4944

Merge branch '2.2.x' into 2.3.x See gh-23183

view details

Stephane Nicoll

commit sha f24d6bf273c1fa95902c50ceb1327d584fc5c7b7

Merge branch '2.3.x'

view details

Stephane Nicoll

commit sha 73c039e4b8d54d2cce36315f7d5e2d8960bb6559

Fix use of deprecated methods

view details

Andy Wilkinson

commit sha c948c70c5a0340bbb5a51ccf303e503f2ec7b837

Align EmbeddedDatabaseConnection with DatabaseDriver Fixes gh-23036

view details

Stephane Nicoll

commit sha 648789ef8478053f044659b81bf4cae27dda2af7

Document that buildpacks use non-root users Closes gh-21122

view details

Stephane Nicoll

commit sha defa7c47cd727bb56fcec400ffb04866869ee408

Merge branch '2.3.x' Closes gh-23201

view details

Andy Wilkinson

commit sha d39b1079177a1dcbd2df9d334932dca42bd5a483

Merge branch '2.2.x' into 2.3.x Closes gh-23203

view details

Andy Wilkinson

commit sha 3dfe11e9e37a39104c54158c524fbd4e5d5123bd

Merge branch '2.3.x' Closes gh-23204

view details

push time in 16 days

push eventscottfrederick/spring-boot

Phillip Webb

commit sha 0d80f46cef37d9f4c779373ab5d099c5f478d3f3

Remove node and recursive limits for YAML Update `OriginTrackedYamlLoader` to remove node limits and recursive parsing restrictions. SnakeYAML 1.26 introduced these options in order to protect against the "billion laugh attacks" but since we consider `application.yml` files to be trusted, we don't need these restrictions. Fixes gh-23096

view details

Stephane Nicoll

commit sha a341d005296aafef9f32c0205d19b90445bd1481

Review instructions for running launch script tests with Gradle Closes gh-20606

view details

Stephane Nicoll

commit sha 652561c274e98033730c7c85c2fa852c695bb865

Review checkstyle rule to prevent non BDD mockito imports Closes gh-20902

view details

Andy Wilkinson

commit sha de671035a84ba7592d1cda566ca199362a26cd7b

Upgrade build to Gradle 6.6.1 Closes gh-23168

view details

Stephane Nicoll

commit sha 4b5a3f4ff95bcd3a0ddb93c0215e2de338949752

Start building against Spring Framework 5.2.9 snapshots See gh-23182

view details

Stephane Nicoll

commit sha d2eeb9524f5abb846964b4f8f3de60d2aeac4944

Merge branch '2.2.x' into 2.3.x See gh-23183

view details

Andy Wilkinson

commit sha c948c70c5a0340bbb5a51ccf303e503f2ec7b837

Align EmbeddedDatabaseConnection with DatabaseDriver Fixes gh-23036

view details

Stephane Nicoll

commit sha 648789ef8478053f044659b81bf4cae27dda2af7

Document that buildpacks use non-root users Closes gh-21122

view details

Andy Wilkinson

commit sha d39b1079177a1dcbd2df9d334932dca42bd5a483

Merge branch '2.2.x' into 2.3.x Closes gh-23203

view details

Andy Wilkinson

commit sha 115ea87b14e77d5251411b1b23cf549de5543956

Restore ordering of ErrorPageFilter lost in 49f8943 See gh-19471

view details

Andy Wilkinson

commit sha 116b2472a76c63bf329ac0337c1048652227bcbf

Merge branch '2.2.x' into 2.3.x Closes gh-23200

view details

Stephane Nicoll

commit sha 88e0c280ce52bb792784917f9e2dd102727b4a9a

Start building against Spring Framework 5.0.19 snapshots See gh-23181

view details

Stephane Nicoll

commit sha e35cf5219acee6409c57cb6df6358f590e8618db

Start building against Reactor Californium-SR21 snapshots See gh-23190

view details

Stephane Nicoll

commit sha d2a603591480f3ae30a180b8a09b117fb4f581c8

Start building against Spring Data Lovelace-SR20 snapshots See gh-23194

view details

Stephane Nicoll

commit sha b3960cae865fcf2df62d33a4da83ba473d05d14a

Start building against Spring Data Bean-SR12 snapshots See gh-23185

view details

Andy Wilkinson

commit sha 5f00d91176545c0f1ba8e20784334e540eeca7cc

Restore identifying org.hsqldb.jdbcDriver as embedded See gh-23036

view details

Andy Wilkinson

commit sha 86fc4dea2a910905b3ebd5d235660cfd5fa90c38

Merge branch '2.2.x' into 2.3.x See gh-23203

view details

Stephane Nicoll

commit sha 656f2b375a91693c800d9a17812182c8caa17d33

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha e3635c4848a9f60302e729aca1c5684ac635f84f

Start building against Reactor Dysprosium-SR11 snapshots See gh-23191

view details

Stephane Nicoll

commit sha a8c36b7659aded0f2ef97469a65a79786c87c47a

Start building against Spring Data Moore-SR10 snapshots See gh-23195

view details

push time in 16 days

issue commentspring-projects/spring-boot

Add support for publishing docker images to a repo

Images can be tagged and pushed using the Docker daemon API, letting the daemon do all the work. We're in the process of adding support for authenticating to a registry from the daemon, which should suffice for pushing also.

We've generally tried to maintain parity between the Boot plugins and the pack CLI. pack supports pushing to a registry with a pack build --publish option. I don't think there's much risk of scope creep with just adding a comparable feature to the Boot plugins.

philwebb

comment created time in 23 days

issue commentspring-projects/spring-boot

bootBuildImage stopped working after buildpack version bump?

Closing this issue since it's clear that it is related to Paketo buildpacks and not something that can be addressed by Spring Boot.

jgrgt

comment created time in 23 days

issue closedspring-projects/spring-boot

bootBuildImage stopped working after buildpack version bump?

Sorry to raise an issue about this, but I can't find any documentation that allows me to work around this:

Earlier this week, we were building and deploying spring-boot based docker images just fine, using gradle bootBuildImage --imageName=.... Suddenly our deploys stopped working though. We had just merged support for reactor's BlockHound and got an error that came down to:

Caused by: java.lang.IllegalStateException: No compatible attachment provider is available

I then commented out the BlockHound.install() but now our deploy still triggered an error:

Unrecognized option: -server

I then checked our build logs and noticed that the previous, working builds used:

 > Running creator
    [creator]     ===> DETECTING
    [creator]     5 of 16 buildpacks participating
    [creator]     paketo-buildpacks/bellsoft-liberica 2.13.0
    [creator]     paketo-buildpacks/executable-jar    2.1.1
    [creator]     paketo-buildpacks/apache-tomcat     1.5.0
    [creator]     paketo-buildpacks/dist-zip          1.4.0
    [creator]     paketo-buildpacks/spring-boot       2.5.0

And the new, failing ones use:

 > Running creator
    [creator]     ===> DETECTING
    [creator]     5 of 17 buildpacks participating
    [creator]     paketo-buildpacks/bellsoft-liberica 3.2.0
    [creator]     paketo-buildpacks/executable-jar    3.1.0
    [creator]     paketo-buildpacks/apache-tomcat     2.2.0
    [creator]     paketo-buildpacks/dist-zip          2.2.0
    [creator]     paketo-buildpacks/spring-boot       3.1.0

I'm now assuming that version bump is incompatible with our app? Is there some setting I can change to revert to the old buildpack? Or maybe force it to use a JDK inside (which is what the BlockHound error seems to be about)?

closed time in 23 days

jgrgt

push eventscottfrederick/spring-boot

Phillip Webb

commit sha 8ccf7ee489fccaeafbaf49a210f41d188922b113

Make file detection more resilient across restarts Retain file snapshot state across devtools restarts to help prevent detection failures. Closes gh-19543

view details

Phillip Webb

commit sha 0d80f46cef37d9f4c779373ab5d099c5f478d3f3

Remove node and recursive limits for YAML Update `OriginTrackedYamlLoader` to remove node limits and recursive parsing restrictions. SnakeYAML 1.26 introduced these options in order to protect against the "billion laugh attacks" but since we consider `application.yml` files to be trusted, we don't need these restrictions. Fixes gh-23096

view details

Phillip Webb

commit sha 446dfe4ad79e4e088aa3630b8d7cdba1d0dcf03e

Merge branch '2.3.x' Closes gh-23153

view details

Stephane Nicoll

commit sha ce169c4d51bedfaebd1db2795f4770e646d08b43

Allow to customize how EntityScanner scans entities This commit adds a protected method that lets an override customize the configuration of the ClassPathScanningCandidateComponentProvider used to scan entities. Closes gh-23154

view details

EruDev

commit sha ffc577b499eaebe08a680cc7ad58c4e986bd71b4

Simplify code See gh-23111

view details

Stephane Nicoll

commit sha 5a86162ff30433b8f54851842e0432a479719fd5

Polish "Simplify code" See gh-23111

view details

Stephane Nicoll

commit sha da3f84f306ec9d0aba89215c3bcb66756e77a10b

Merge pull request #23111 from EruDev * pr/23111: Polish "Simplify code" Simplify code Closes gh-23111

view details

Stephane Nicoll

commit sha a341d005296aafef9f32c0205d19b90445bd1481

Review instructions for running launch script tests with Gradle Closes gh-20606

view details

Stephane Nicoll

commit sha 2e4b338704437289fd96c6b721ab316ba4d20564

Merge branch '2.3.x' Closes gh-23155

view details

Stephane Nicoll

commit sha 652561c274e98033730c7c85c2fa852c695bb865

Review checkstyle rule to prevent non BDD mockito imports Closes gh-20902

view details

Stephane Nicoll

commit sha f4c8668afdaaf032d1262a0321222e10858e3ebe

Merge branch '2.3.x' Closes gh-23157

view details

Andy Wilkinson

commit sha 72c6435078f6b3e79bd7556e16176c55d375c1c5

Polish See gh-23157

view details

Pradipta Sarma

commit sha 2627bf896e530783950e0cc8f24398373384d287

Removed some redundant 'else's using early return See gh-22528

view details

Stephane Nicoll

commit sha f8bc656921bda3c8d72f943db13710f7d4c5a6d5

Polish "Removed some redundant 'else's using early return" See gh-22528

view details

Stephane Nicoll

commit sha f1c5f6954426390d37008f23aa8e15874859527d

Merge pull request #22528 from pradipta * pr/22528: Polish "Removed some redundant 'else's using early return" Removed some redundant 'else's using early return Closes gh-22528

view details

Andy Wilkinson

commit sha 2c981d99a29c1c6926f6b1c38c1d9c250fc32d36

Avoid unnecessary reflection in TaskExecutorBuilder Closes gh-23107

view details

push time in 25 days

issue commentspring-projects/spring-boot

Update Paketo builder coordinates to Dockerhub location

Marking this for team attention to discuss what version we should make this change in. It should be safe to change the default builder location in 2.3, but there might be reasons to only change it for 2.4.

We should also review the use of base vs full or tiny, and possibly the stack we're choosing by default. Any change in these builder variants should probably only be done in 2.4.

kvedurmu

comment created time in 25 days

push eventscottfrederick/spring-boot

Scott Frederick

commit sha bc1834bfdf63b8a50065a84a98f4a4fee45742df

Ensure layer digest hashes contain 64 characters This commit ensures that encoded digest hashes for Docker image layers are zero-padded to the required 64 characters length. Fixes gh-23132

view details

Scott Frederick

commit sha b70d0dd5acdc92dafa759126f36017659cb6b6c4

Merge branch '2.3.x' Closes gh-23134

view details

Ralph Goers

commit sha 684b65e80c8c1216d4890e350cadd72768a35f18

Remove ResourceUtils.getURL logging config check Remove `ResourceUtils.getURL` checking from `LoggingApplicationListener` so that logging systems can implement custom location support. Prior to this commit, we checked in the listener if the specified config location could be opened as a URL. This unfortunately prevents Log4J extensions such as `log4j-spring-cloud-config-client` from implementing configurable SSL and credentials support. See gh-22946

view details

Phillip Webb

commit sha 35994b061c379746f5a52f9edab54754446f32f0

Polish 'Remove ResourceUtils.getURL logging config check' Extend `initializeSystem` to search the exception stack for a FileNotFoundException before reporting the error. This allows us to provide a similar stack trace to the one that used to be thrown when we had the `ResourceUtils.getURL` check. See gh-22946

view details

Phillip Webb

commit sha 38db582af14f930d7c5769019dbdb6dddb50a07f

Merge pull request #22946 from rgoers * pr/22946: Polish 'Remove ResourceUtils.getURL logging config check' Remove ResourceUtils.getURL logging config check Closes gh-22946

view details

Phillip Webb

commit sha 84f281fbfd195ce722a1d27dc71e27ad21f23295

Merge branch '2.2.x' into 2.3.x Closes gh-23135

view details

Phillip Webb

commit sha 21897a70972b150cdc1b8310b6f17b0ab43784e5

Merge branch '2.3.x' Closes gh-23136

view details

Phillip Webb

commit sha 611447c4d55171ceac6b861c4520ce6ef7ad9984

Fix checkstyle issue caused by polish commit See gh-22946

view details

Phillip Webb

commit sha 98f432681f6343678e9d14697a6684fc4c0d5a0c

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha bebb4363d6c1294615c9862df233b8493b412839

Merge branch '2.3.x'

view details

Phillip Webb

commit sha 0ddd1b6ce81a24c14518ef715527aa72b524d7eb

Refine global optional config data opt-out Rename the opt-out property and use an enum in case we want to provide additional options in the future. Closes gh-23097

view details

Stephane Nicoll

commit sha 008eee42a13fbd7576c3aec1f63625e19ae24bb0

Add a note about using graceful shutdown from an IDE Closes gh-22959

view details

Stephane Nicoll

commit sha 8bcae12ffc19e703665145d83a3cf343f4c7d9fc

Merge branch '2.3.x' Closes gh-23140

view details

Stephane Nicoll

commit sha 62dbd90d46b067d6d28b7f970d735a2f9931aaad

Document how to add auto-configurations to a test slice Closes gh-22531

view details

Stephane Nicoll

commit sha 1fea6914bcbd3193c34662737a6f1735f11a12c3

Merge branch '2.3.x' Closes gh-23142

view details

Stephane Nicoll

commit sha b80314b44b42c5801b686171a1eb268b1c40bfd6

Document how to customize the jmxPort for Maven integration tests Closes gh-22401

view details

Stephane Nicoll

commit sha e0b41f8192b59efd96d38b2cc923b79b2fc3ff34

Merge branch '2.3.x' Closes gh-23143

view details

Stephane Nicoll

commit sha e74e53fdaf40c4f5c675bf33c28e61540388612a

Clarify how to take full control of ElasticSearch's rest client Closes gh-23074

view details

Stephane Nicoll

commit sha dee3fad8d01ad6ee6ca4307950d3340dcd6eb9d6

Merge branch '2.3.x' Closes gh-23144

view details

Stephane Nicoll

commit sha 8404c4c71ba89e2f44ec598fafb22c5d4d68dda3

Document how to perform tasks after application startup Closes gh-22100

view details

push time in a month

push eventscottfrederick/spring-boot

Scott Frederick

commit sha bc1834bfdf63b8a50065a84a98f4a4fee45742df

Ensure layer digest hashes contain 64 characters This commit ensures that encoded digest hashes for Docker image layers are zero-padded to the required 64 characters length. Fixes gh-23132

view details

Ralph Goers

commit sha 684b65e80c8c1216d4890e350cadd72768a35f18

Remove ResourceUtils.getURL logging config check Remove `ResourceUtils.getURL` checking from `LoggingApplicationListener` so that logging systems can implement custom location support. Prior to this commit, we checked in the listener if the specified config location could be opened as a URL. This unfortunately prevents Log4J extensions such as `log4j-spring-cloud-config-client` from implementing configurable SSL and credentials support. See gh-22946

view details

Phillip Webb

commit sha 35994b061c379746f5a52f9edab54754446f32f0

Polish 'Remove ResourceUtils.getURL logging config check' Extend `initializeSystem` to search the exception stack for a FileNotFoundException before reporting the error. This allows us to provide a similar stack trace to the one that used to be thrown when we had the `ResourceUtils.getURL` check. See gh-22946

view details

Phillip Webb

commit sha 38db582af14f930d7c5769019dbdb6dddb50a07f

Merge pull request #22946 from rgoers * pr/22946: Polish 'Remove ResourceUtils.getURL logging config check' Remove ResourceUtils.getURL logging config check Closes gh-22946

view details

Phillip Webb

commit sha 84f281fbfd195ce722a1d27dc71e27ad21f23295

Merge branch '2.2.x' into 2.3.x Closes gh-23135

view details

Phillip Webb

commit sha 611447c4d55171ceac6b861c4520ce6ef7ad9984

Fix checkstyle issue caused by polish commit See gh-22946

view details

Phillip Webb

commit sha 98f432681f6343678e9d14697a6684fc4c0d5a0c

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 008eee42a13fbd7576c3aec1f63625e19ae24bb0

Add a note about using graceful shutdown from an IDE Closes gh-22959

view details

Stephane Nicoll

commit sha 62dbd90d46b067d6d28b7f970d735a2f9931aaad

Document how to add auto-configurations to a test slice Closes gh-22531

view details

Stephane Nicoll

commit sha b80314b44b42c5801b686171a1eb268b1c40bfd6

Document how to customize the jmxPort for Maven integration tests Closes gh-22401

view details

Stephane Nicoll

commit sha e74e53fdaf40c4f5c675bf33c28e61540388612a

Clarify how to take full control of ElasticSearch's rest client Closes gh-23074

view details

Stephane Nicoll

commit sha 8404c4c71ba89e2f44ec598fafb22c5d4d68dda3

Document how to perform tasks after application startup Closes gh-22100

view details

Stephane Nicoll

commit sha ee914624e619237ee1850b6b8b71986b051e2317

Document buildpacks are configured with target Java version Closes gh-21796

view details

push time in a month

issue commentspring-projects/spring-boot

bootBuildImage runs forever when a custom image name is used and the version contains an illegal character

I've narrowed this down to a complex regular expression that Spring Boot uses to parse an image reference to make sure it's valid before passing it off to downstream APIs. Providing an image reference registry.example.com/example/example-app:1.6.0-dev.2.uncommitted+wip.foo.c75795d to ImageReference#of(String) in a unit test will cause the matcher.matches() call to process for 20+ minutes before returning a false return value. Editing the image reference in small ways like reducing the size of the tag or replacing one of the instances of example in the path reduces the time spent in matcher.matches().

Marking this as a bug in 2.3.x but it may take some time to isolate the interaction between this input and the regular expression.

mxab

comment created time in a month

issue commentspring-projects-experimental/spring-graalvm-native

Upgrade to Spring Boot 2.4.0-M3

See https://github.com/spring-projects/spring-boot/issues/23133 and https://github.com/spring-projects/spring-boot/issues/23134

sdeleuze

comment created time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha bc1834bfdf63b8a50065a84a98f4a4fee45742df

Ensure layer digest hashes contain 64 characters This commit ensures that encoded digest hashes for Docker image layers are zero-padded to the required 64 characters length. Fixes gh-23132

view details

Scott Frederick

commit sha b70d0dd5acdc92dafa759126f36017659cb6b6c4

Merge branch '2.3.x' Closes gh-23134

view details

push time in a month

issue closedspring-projects/spring-boot

Ensure digest hashes are zero padded to 64 characters

Forward port of issue #23132 to 2.4.x.

closed time in a month

scottfrederick

issue closedspring-projects/spring-boot

Ensure digest hashes are zero padded to 64 characters

Split from #23130

public static LayerId ofSha256Digest(byte[] digest) {
	Assert.notNull(digest, "Digest must not be null");
	Assert.isTrue(digest.length == 32, "Digest must be exactly 32 bytes");
	String algorithm = "sha256";
	String hash = String.format("%32x", new BigInteger(1, digest));
	return new LayerId(algorithm + ":" + hash, algorithm, hash);
}

%32x is actually only guaranteed to be at least 32 characters. We need 64. So sometimes we get 63 because the content of the digest has a low leading byte value. This would probably work (because Java Formatter pads with spaces not zeros, and docker wants zeros):

String hash = String.format("%64x", new BigInteger(1, digest)).replace(" ", "0");

closed time in a month

scottfrederick

push eventspring-projects/spring-boot

Scott Frederick

commit sha bc1834bfdf63b8a50065a84a98f4a4fee45742df

Ensure layer digest hashes contain 64 characters This commit ensures that encoded digest hashes for Docker image layers are zero-padded to the required 64 characters length. Fixes gh-23132

view details

push time in a month

issue openedspring-projects/spring-boot

Ensure digest hashes are zero padded to 64 characters

Forward port of issue #23132 to 2.4.x.

created time in a month

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 4f1b4c98aef033a5a7cdf902b0fc63778b284ac6

Fail on Docker image load with empty response In some cases, a call to the Docker image load API will fail but return a 200 OK response status code and an empty response. This commit detects that the response from this call is empty and treats this condition as an error instead of a silent failure. Fixes gh-23130

view details

push time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha 4f1b4c98aef033a5a7cdf902b0fc63778b284ac6

Fail on Docker image load with empty response In some cases, a call to the Docker image load API will fail but return a 200 OK response status code and an empty response. This commit detects that the response from this call is empty and treats this condition as an error instead of a silent failure. Fixes gh-23130

view details

Scott Frederick

commit sha ccabc1a4c9db5655cecd5955c4f1202214756fc9

Merge branch '2.3.x' Closes gh-23133

view details

push time in a month

issue closedspring-projects/spring-boot

Image builder fails silently when there's an error loading the ephemeral image

When the ephemeral build image is loaded into docker it can fail, and we discard the result, so we never know. From DockerApi$ImageApi:

try (Response response = http().post(loadUri, "application/x-tar", archive::writeTo)) {
	jsonStream().get(response.getContent(), LoadImageUpdateEvent.class, listener::onUpdate);
}

The json is discarded and docker is actually sending an error message (with a 200 OK response status, which is admittedly unhelpful). It would suffice in this case to look at the unmarshalled response and check that it had some content (non null "stream" property).

This code in LayerId is responsible for the failure that we found:

public static LayerId ofSha256Digest(byte[] digest) {
	Assert.notNull(digest, "Digest must not be null");
	Assert.isTrue(digest.length == 32, "Digest must be exactly 32 bytes");
	String algorithm = "sha256";
	String hash = String.format("%32x", new BigInteger(1, digest));
	return new LayerId(algorithm + ":" + hash, algorithm, hash);
}

%32x is actually only guaranteed to be at least 32 characters. We need 64. So sometimes we get 63 because the content of the digest has a low leading byte value. This would probably work (because Java Formatter pads with spaces not zeros, and docker wants zeros):

String hash = String.format("%64x", new BigInteger(1, digest)).replace(" ", "0");

closed time in a month

dsyer

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 4f1b4c98aef033a5a7cdf902b0fc63778b284ac6

Fail on Docker image load with empty response In some cases, a call to the Docker image load API will fail but return a 200 OK response status code and an empty response. This commit detects that the response from this call is empty and treats this condition as an error instead of a silent failure. Fixes gh-23130

view details

Scott Frederick

commit sha ccabc1a4c9db5655cecd5955c4f1202214756fc9

Merge branch '2.3.x' Closes gh-23133

view details

push time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha 4f1b4c98aef033a5a7cdf902b0fc63778b284ac6

Fail on Docker image load with empty response In some cases, a call to the Docker image load API will fail but return a 200 OK response status code and an empty response. This commit detects that the response from this call is empty and treats this condition as an error instead of a silent failure. Fixes gh-23130

view details

push time in a month

issue openedspring-projects/spring-boot

Image builder fails silently when there's an error loading the ephemeral image

Forward port of issue #23130 to 2.4.x.

created time in a month

push eventscottfrederick/spring-boot

Phillip Webb

commit sha c613d119f774b6f3bc80c75b1717640f579f35b6

Support binding with multiple constructors Update `DefaultBindConstructorProvider` so that binding to objects with multiple constructors is allowed, as long as there is only one non-public candidate. Closes gh-23117

view details

Phillip Webb

commit sha bc5958c398cfa4b0974238a71e2bf7a9f3081fd7

Polish test method names Polish method names to remove "should".

view details

Phillip Webb

commit sha 960651c15a4d2f6a8f0be73b842f27aa475174a6

Add parent origin support Update the `Origin` interface to include a default `getParent()` method which can be used to get the parent origin. The `TextResourceOrigin` has been updated to implement the method against the source `Resource`. A new `OriginTrackedResource` implementation allows any `Resource` to be decorated and carry an optional `Origin`. Ultimately this will allow us to include parent `Origin` information on properties loaded via a `PropertySourceLoader` without needing any changes to that interface. See gh-23018

view details

Phillip Webb

commit sha 3c1e141aef823f354f5be3961473d70ba719c474

Add parent origin support to config data Allow `ConfigDataLocationResolvers` to access `Origin` information for locations so that they can be used as a parent origin of loaded items. The `ResourceConfigData...` classes have been reworked so that loaded `PropertySources` include the parent origin. See gh-23018

view details

Phillip Webb

commit sha cf8776b83c1bb37306096310f83a0e834ced19ca

Expose originParents on actuator endpoints Update `ConfigurationPropertiesReportEndpoint` and `EnvironmentEndpoint` so that they expose `originParents` when they are available. Closes gh-23018

view details

Martin Chalupa

commit sha 796307a78cf3e2a8d7548d35b75784d2b563ec11

Mark bootArchives configuration as unresolvable See gh-22943

view details

Andy Wilkinson

commit sha 9dc5b88949a1890e85cf853ac9f6850489d52d75

Polish "Mark bootArchives configuration as unresolvable" See gh-22943

view details

Andy Wilkinson

commit sha 8ce2058dc78884a91f2df84209ac7fdf15afd082

Merge pull request #22943 from chali * gh-22943: Polish "Mark bootArchives configuration as unresolvable" Mark bootArchives configuration as unresolvable Closes gh-22943

view details

Andy Wilkinson

commit sha 84a12c843603605364b710b38e97e680b2224f01

Upgrade to Testcontainers 1.14.3 Closes gh-23122

view details

Andy Wilkinson

commit sha 242a23328a62508ca4cf65d309e20116ffe7e59c

Merge branch '2.2.x' into 2.3.x

view details

Andy Wilkinson

commit sha b9a50f2440e2a0495abadbcd6c4ea3674fa4b188

Merge branch '2.3.x'

view details

Andy Wilkinson

commit sha 5cd910c7cedf6bc0320fc4599095adb99036da47

Replace Embedded Mongo with Testcontainers' MongoDB support Closes gh-23090

view details

Andy Wilkinson

commit sha 33ef1b6e5be5162fb90cee62a4bdcf625d26ebcd

Merge branch '2.2.x' into 2.3.x Closes gh-23124

view details

Andy Wilkinson

commit sha 2c166d1a58481b71d40e9d141588a63453413a7d

Merge branch '2.3.x' Closes gh-23125

view details

Andy Wilkinson

commit sha 627ede8bffefc492fa033e10e8892496ad0fdab1

Remove duplicate jackson-datatype-jsr310 dependency Closes gh-23123

view details

Andy Wilkinson

commit sha 3df58b2d8df911eb5573f450e0633d43c9606235

Merge branch '2.2.x' into 2.3.x

view details

Andy Wilkinson

commit sha a46237285477efbb3cb5f876f412d7a658c78a74

Merge branch '2.3.x'

view details

dreis2211

commit sha 51c9dee89929df5dca3ec1cb29d73b6116108d90

Use DynamicPropertySource in MongoDB tests See gh-23127

view details

Andy Wilkinson

commit sha b58264b16a5aafc0b4262eac3b5e5cbf614fbd1f

Merge pull request #23127 from dreis2211 * gh-23127: Use DynamicPropertySource in MongoDB tests Closes gh-23127

view details

Andy Wilkinson

commit sha 9ee2487a6ee243a532251bdfaa302db57ad2d91f

Merge branch '2.3.x' Closes gh-23128

view details

push time in a month

issue commentspring-projects/spring-boot

Image builder fails silently when there's an error loading the ephemeral image

Splitting this into separate issues, with the layer hash covered in #23132.

dsyer

comment created time in a month

issue openedspring-projects/spring-boot

Ensure digest hashes are zero padded

public static LayerId ofSha256Digest(byte[] digest) {
	Assert.notNull(digest, "Digest must not be null");
	Assert.isTrue(digest.length == 32, "Digest must be exactly 32 bytes");
	String algorithm = "sha256";
	String hash = String.format("%32x", new BigInteger(1, digest));
	return new LayerId(algorithm + ":" + hash, algorithm, hash);
}

%32x is actually only guaranteed to be at least 32 characters. We need 64. So sometimes we get 63 because the content of the digest has a low leading byte value. This would probably work (because Java Formatter pads with spaces not zeros, and docker wants zeros):

String hash = String.format("%64x", new BigInteger(1, digest)).replace(" ", "0");

created time in a month

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha 84a12c843603605364b710b38e97e680b2224f01

Upgrade to Testcontainers 1.14.3 Closes gh-23122

view details

Andy Wilkinson

commit sha 242a23328a62508ca4cf65d309e20116ffe7e59c

Merge branch '2.2.x' into 2.3.x

view details

Andy Wilkinson

commit sha 5cd910c7cedf6bc0320fc4599095adb99036da47

Replace Embedded Mongo with Testcontainers' MongoDB support Closes gh-23090

view details

Andy Wilkinson

commit sha 33ef1b6e5be5162fb90cee62a4bdcf625d26ebcd

Merge branch '2.2.x' into 2.3.x Closes gh-23124

view details

Andy Wilkinson

commit sha 627ede8bffefc492fa033e10e8892496ad0fdab1

Remove duplicate jackson-datatype-jsr310 dependency Closes gh-23123

view details

Andy Wilkinson

commit sha 3df58b2d8df911eb5573f450e0633d43c9606235

Merge branch '2.2.x' into 2.3.x

view details

dreis2211

commit sha 51c9dee89929df5dca3ec1cb29d73b6116108d90

Use DynamicPropertySource in MongoDB tests See gh-23127

view details

Andy Wilkinson

commit sha b58264b16a5aafc0b4262eac3b5e5cbf614fbd1f

Merge pull request #23127 from dreis2211 * gh-23127: Use DynamicPropertySource in MongoDB tests Closes gh-23127

view details

Andy Wilkinson

commit sha b6569bb075a23b4c3eac90e3279c0b456cd691ce

Upgrade to Gradle Enterprise Maven Extension 1.6.3 Closes gh-23113

view details

Andy Wilkinson

commit sha e2323fd45c8cb51d83a81c43f04ad213de0c559c

Merge branch '2.1.x' into 2.2.x Closes gh-23129

view details

Andy Wilkinson

commit sha 822f8216496b74434714a7d7a5ecde60cec18237

Merge branch '2.2.x' into 2.3.x

view details

Andy Wilkinson

commit sha 19069147112c04dbd447066a3d407a8fd65ec777

Upgrade to Gradle Enterprise Maven Extension 1.6.3 Closes gh-23113

view details

Andy Wilkinson

commit sha f6f832b4dacab13b5f774341851000ea68b24c7f

Merge branch '2.1.x' into 2.2.x

view details

Andy Wilkinson

commit sha 6186db735a8c37d8e6cd927417c57a7764134467

Merge branch '2.2.x' into 2.3.x

view details

push time in a month

issue commentspring-projects/spring-boot

bootBuildImage runs forever when a custom image name is used and the version contains an illegal character

Thanks for the example app.

I noticed that when I have for example a + in the version the build fails, which is ok I guess.

The Spring Boot Gradle plugin and the Paketo CNB builder that bootBuildImage invokes by default use the same Docker image reference validation rules, which are codified by Docker and do not allow a + in an image tag.

The bootBuildImage task should fail with an error similar to this when provided this image name:

Execution failed for task ':bootBuildImage'.
> Unable to parse image reference "demo:1.6.0-dev.2.uncommitted+wip.foo.c75795d". Image reference must be in the form '[domainHost:port/][path/]name[:tag][@digest]', with 'path' and 'name' containing only [a-z0-9][.][_][-]

If you provide the same image reference to the pack CLI, it will fail with a similar message:

ERROR: failed to build: invalid image name 'demo:1.6.0-dev.2.uncommitted+wip.foo.c75795d': could not parse reference: demo:1.6.0-dev.2.uncommitted+wip.foo.c75795d

the build image job runs forever

I was able to re-create this, but not consistently. When it does appear to hang, Gradle is repeatedly acquiring and releasing a lock on the daemon. Changing imageName from registry.example.com/example/example-app:${version} to registry.example.com/example/demo:${version} seems to eliminate the hanging. We'll keep digging on that.

mxab

comment created time in a month

push eventscottfrederick/spring-boot

Phillip Webb

commit sha 081a7ee28cb5aa7342520d946e68a589378ed154

Throw exception if import locations are not found Update config data processing code so that import locations are mandatory by default. Any import request will now throw a `ConfigDataLocationNotFoundException` if the specified import location cannot be found. For optional imports, the user can use the `optional:` prefix to indicate that the application should continue to start, even if the location does not exist. Closes gh-23032

view details

Phillip Webb

commit sha d0fce0553fc3adcd6f8ed054dbfe6f715445568d

Support extensionless file imports Update `ResourceConfigDataLocationResolver` so that it can import files that have no file extension. Closes gh-22280

view details

spencergibb

commit sha f08f948c3e77a4c63d74fdf0a94ebe9677c98a09

Handle null RSocketServer address when setting port property See gh-23084

view details

Andy Wilkinson

commit sha 6f047c8356043e389718b1534de5582ccedaf81b

Polish "Handle null RSocketServer address when setting port property" See gh-23084

view details

Andy Wilkinson

commit sha eba2bc3c0c0c2405ef188373749606e63591f273

Merge pull request #23084 from spencergibb * gh-23084: Polish "Handle null RSocketServer address when setting port property" Handle null RSocketServer address when setting port property Closes gh-23084

view details

dreis2211

commit sha d8ba7dd4d0b25b42854d629870321afcda8cbbe6

Remove unused methods See gh-23086

view details

Stephane Nicoll

commit sha f42da161362c870eb0feadb5955a2433f0300dc1

Merge pull request #23086 from dreis2211 * pr/23086: Remove unused methods Closes gh-23086

view details

Stephane Nicoll

commit sha 28b938a22993cfcc32c9617ffdf9aed93b261660

Merge branch '2.3.x' Closes gh-23088

view details

Andy Wilkinson

commit sha 4143c31f9c281ac699321d8fe49db3cf4f9a016f

Merge branch '2.2.x' into 2.3.x Closes gh-23087

view details

Andy Wilkinson

commit sha 4320b3a9193d33a1442382b349b71ccb8955fc35

Merge branch '2.3.x' Closes gh-23089

view details

Johnny Lim

commit sha e48af31cedecdae5a62cab1ddab147530084d546

Polish See gh-23081

view details

Stephane Nicoll

commit sha e0ccf54727547366379ba175565584b0ce611379

Merge pull request #23081 from izeye * pr/23081: Polish Closes gh-23081

view details

Andy Wilkinson

commit sha 04540887af1dcf4c38794d08a556b57efbf4057f

Widen timeout and delay to accommodate Windows' imprecision under load Closes gh-23093

view details

Andy Wilkinson

commit sha c74e0be0d2849dbd2a21a330f3a95b019272f631

Merge branch '2.2.x' into 2.3.x Closes gh-23094

view details

Andy Wilkinson

commit sha 6cfd2e3a33c0a9d0d4272148086c5ae436540cdd

Merge branch '2.3.x' Closes gh-23095

view details

Phillip Webb

commit sha c1be5cb5e02870cb0c4c12f2f33e4e4742a843f8

Add limited support for spring.profiles.include Restore support for the `spring.profiles.include` property but only for non-profile specific documents. Closes gh-22944

view details

Phillip Webb

commit sha aa0f20473291e92630e39805f822364b189217a3

Add global optional config data opt-out Support a `spring.config.all-locations-optional` property which can be set to `true` if all config data locations should be considered optional. Closes gh-23097

view details

Phillip Webb

commit sha a2530ad5f173f1825b9c5cb4a8ea1173ecdfba9e

Fix global optional config data opt-out test See gh-23097

view details

Stephane Nicoll

commit sha 1ae120f8c52ea47d0a4c9da203623c8ca58e23f9

Upgrade Ubuntu version in CI images Closes gh-23102

view details

Stephane Nicoll

commit sha fda8990fe9df654fcb4ea9229856074ab2019f0e

Merge branch '2.1.x' into 2.2.x

view details

push time in a month

push eventscottfrederick/spring-boot

Stephane Nicoll

commit sha 1ae120f8c52ea47d0a4c9da203623c8ca58e23f9

Upgrade Ubuntu version in CI images Closes gh-23102

view details

Stephane Nicoll

commit sha fda8990fe9df654fcb4ea9229856074ab2019f0e

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 0032ab6afe27f4da74f17539f6bf7d2b345e0708

Upgrade Ubuntu version in CI images Closes gh-23103

view details

Stephane Nicoll

commit sha 83d96cece85940a598c83b3b4c4b9ad80944bf96

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha 9814a30b511b3db29f59298f3c5c2bd30c88d81e

Upgrade Ubuntu version in CI images Closes gh-23100

view details

push time in a month

push eventscottfrederick/spring-boot

Thomas Kåsene

commit sha 0277dce3dae5c394646d4ce8f502637df716fe41

Added dependency management for nimbus-jose-jwt See gh-22996

view details

Andy Wilkinson

commit sha 858e1948ddd98220f3faaf53b13743fba59d9c6c

Polish "Added dependency management for nimbus-jose-jwt" See gh-22996

view details

Andy Wilkinson

commit sha 82e1eca0adb77252e50ed33ee2ed667a71ba1532

Merge pull request #22996 from ThomasKasene * gh-22996: Polish "Added dependency management for nimbus-jose-jwt" Added dependency management for nimbus-jose-jwt Closes gh-22996

view details

Andy Wilkinson

commit sha 7a5392d6bd909d06d6800de37095a763939d0109

Polish

view details

Andy Wilkinson

commit sha 0b3a1310bde978730b6943d25beeab1b4f1e975d

Align managed version of Nimbus JOSE JWT with Spring Security Closes gh-22996

view details

Andy Wilkinson

commit sha b57b2f0b448b148ab715566f45e41e152965f5f7

Test the Gradle Plugin against 6.5 and 6.6 Closes gh-23075

view details

Andy Wilkinson

commit sha e431010453d8e30368ec5795f8d763c502d6a5f1

Merge branch '2.2.x' into 2.3.x

view details

dreis2211

commit sha 7bf32e9bb16f79539771f9a1875430e10a22fb66

Disallow Apache Commons Lang & Lang3 imports See gh-23071

view details

Stephane Nicoll

commit sha de169ff8c9866d8e56f33f8f6229c4aa673995b1

Merge pull request #23071 from dreis2211 * pr/23071: Disallow Apache Commons Lang & Lang3 imports Closes gh-23071

view details

Stephane Nicoll

commit sha 066471b1d9e3b8b4557e65171ce335ded1c698d9

Merge branch '2.1.x' into 2.2.x Closes gh-23076

view details

Stephane Nicoll

commit sha a149edcfd7c03dc3c5c3db3f57e5c25747205fb6

Merge branch '2.2.x' into 2.3.x Closes gh-23077

view details

Andy Wilkinson

commit sha d133f228e2d063b008a230c9c2d81f8742a554d7

Increase wait times in DevToolsIntegrationTests See gh-22909

view details

spencergibb

commit sha f08f948c3e77a4c63d74fdf0a94ebe9677c98a09

Handle null RSocketServer address when setting port property See gh-23084

view details

Andy Wilkinson

commit sha 6f047c8356043e389718b1534de5582ccedaf81b

Polish "Handle null RSocketServer address when setting port property" See gh-23084

view details

Andy Wilkinson

commit sha eba2bc3c0c0c2405ef188373749606e63591f273

Merge pull request #23084 from spencergibb * gh-23084: Polish "Handle null RSocketServer address when setting port property" Handle null RSocketServer address when setting port property Closes gh-23084

view details

dreis2211

commit sha d8ba7dd4d0b25b42854d629870321afcda8cbbe6

Remove unused methods See gh-23086

view details

Stephane Nicoll

commit sha f42da161362c870eb0feadb5955a2433f0300dc1

Merge pull request #23086 from dreis2211 * pr/23086: Remove unused methods Closes gh-23086

view details

Andy Wilkinson

commit sha 4143c31f9c281ac699321d8fe49db3cf4f9a016f

Merge branch '2.2.x' into 2.3.x Closes gh-23087

view details

Andy Wilkinson

commit sha 04540887af1dcf4c38794d08a556b57efbf4057f

Widen timeout and delay to accommodate Windows' imprecision under load Closes gh-23093

view details

Andy Wilkinson

commit sha c74e0be0d2849dbd2a21a330f3a95b019272f631

Merge branch '2.2.x' into 2.3.x Closes gh-23094

view details

push time in a month

push eventscottfrederick/spring-boot

Thomas Kåsene

commit sha 0277dce3dae5c394646d4ce8f502637df716fe41

Added dependency management for nimbus-jose-jwt See gh-22996

view details

Andy Wilkinson

commit sha 858e1948ddd98220f3faaf53b13743fba59d9c6c

Polish "Added dependency management for nimbus-jose-jwt" See gh-22996

view details

Andy Wilkinson

commit sha 82e1eca0adb77252e50ed33ee2ed667a71ba1532

Merge pull request #22996 from ThomasKasene * gh-22996: Polish "Added dependency management for nimbus-jose-jwt" Added dependency management for nimbus-jose-jwt Closes gh-22996

view details

Andy Wilkinson

commit sha 4fa7b3dc02b08cc0b6d731cbdc1bd2a16d688e85

Merge branch '2.3.x' Closes gh-23072

view details

Andy Wilkinson

commit sha 7a5392d6bd909d06d6800de37095a763939d0109

Polish

view details

Andy Wilkinson

commit sha bdaad5b2dc7b72e0a543ae331038008b4e839122

Merge branch '2.3.x'

view details

Andy Wilkinson

commit sha 0b3a1310bde978730b6943d25beeab1b4f1e975d

Align managed version of Nimbus JOSE JWT with Spring Security Closes gh-22996

view details

Andy Wilkinson

commit sha dbf583bc3c7da5158163fdd7cea2c8ca25524d35

Merge branch '2.3.x'

view details

Andy Wilkinson

commit sha b57b2f0b448b148ab715566f45e41e152965f5f7

Test the Gradle Plugin against 6.5 and 6.6 Closes gh-23075

view details

Andy Wilkinson

commit sha e431010453d8e30368ec5795f8d763c502d6a5f1

Merge branch '2.2.x' into 2.3.x

view details

Andy Wilkinson

commit sha f493740892bd745490ac49c4cf4c6b10549b5429

Merge branch '2.3.x'

view details

dreis2211

commit sha 7bf32e9bb16f79539771f9a1875430e10a22fb66

Disallow Apache Commons Lang & Lang3 imports See gh-23071

view details

Stephane Nicoll

commit sha de169ff8c9866d8e56f33f8f6229c4aa673995b1

Merge pull request #23071 from dreis2211 * pr/23071: Disallow Apache Commons Lang & Lang3 imports Closes gh-23071

view details

Stephane Nicoll

commit sha 066471b1d9e3b8b4557e65171ce335ded1c698d9

Merge branch '2.1.x' into 2.2.x Closes gh-23076

view details

Stephane Nicoll

commit sha a149edcfd7c03dc3c5c3db3f57e5c25747205fb6

Merge branch '2.2.x' into 2.3.x Closes gh-23077

view details

Stephane Nicoll

commit sha 598b7a91376f4a350d617a6f1d9c5acb861a9b42

Merge branch '2.3.x' Closes gh-23078

view details

Stephane Nicoll

commit sha f191b7513df08085164e26cae4c1566ae969c4c9

Polish

view details

Stephane Nicoll

commit sha 085091dbe3423ce3d7436ac07af5259e67c0cc3e

Adapt auto-configurations to back-off in presence of TransactionManager Previous to this commit, an auto-configuration would create a PlatformTransactionManager if none is present and others conditions are met. Spring Framework now has the notion of TransactionManager, a parent interface that gathers both PlatformTransactionManager and ReactiveTransactionManager. Spring Boot should not be in a situation where both managers are defined out-of-the-box. This commit makes sure to back-off if any TransactionManager is available. Closes gh-22851

view details

Andy Wilkinson

commit sha 56ded38f5d6b6cc1d3e7a6bd6d131a7dac33b0c9

Generate default values from Duration and Period .ZERO Closes gh-23082

view details

hoaphan

commit sha 03a8937d5c442dd00108bef795b6b9b5cee209ec

Add a configuration property for KLC's idleBetweenPolls See gh-23048

view details

push time in a month

push eventscottfrederick/spring-boot

Stephane Nicoll

commit sha aed49c06312b9ae7b55ceddab4e95c96aa46f333

Add configuration option for GridFsTemplate's bucket Closes gh-22854

view details

Stephane Nicoll

commit sha 0b13921731c0c312e2b4219eaca4d26accf244cc

Upgrade Java 15 version in CI image Closes gh-23014

view details

Stephane Nicoll

commit sha 019350dae2a222ba338f52f86667af21e1f52655

Upgrade to Kotlin 1.4.0 Closes gh-23024

view details

Stephane Nicoll

commit sha f7ef3445a68e1648a61a4930328f0976e003bbfc

Upgrade to Kotlin Coroutines 1.3.9 Closes gh-23025

view details

Phillip Webb

commit sha 167e31d564ba9aa3993b2a2f62e5daecc7d73b52

Provide a simple Instantiator utility class Make `Instantiator` a public utility class so that it can be used by other parts of the codebase. Closes gh-23029

view details

Phillip Webb

commit sha 22606577810bc47d41ef9ed70f9f9f6b972d69ce

Add BootstrapRegistry for long lived instances Add a simple `BootstrapRegistry` that can be used to store and share object instances across `EnvironmentPostProcessors`. The registry can be injected into the constructor of any `EnvironmentPostProcessor`. Registrations can also perform additional actions when the `ApplicationContext` has been prepared. For example, they could register the the bootstrap instances as beans so that they become available to the application. See gh-22956

view details

Phillip Webb

commit sha d123c924a0e1fbe6b4e8f27baf98b5bfd1a64a86

Add BootstrapRegisty support for config data Expose the `BootstrapRegisty` to both `ConfigDataLocationResolver` and `ConfigDataLoader` implementations. The registry is exposed via the context interfaces and may be used to reuse instances that are expensive to create. It may also be used to ultimately register beans with the `ApplicationContext`. Closes gh-22956

view details

dreis2211

commit sha f7d6f3836830389eff240ee0e49648a1926e80f5

Fix typos in tests See gh-23050

view details

Phillip Webb

commit sha 00cb5bbd86fd44c2ab7e2085ddc08fe385d86192

Merge pull request #23050 from dreis2211 * pr/23050: Fix typos in tests Closes gh-23050

view details

Phillip Webb

commit sha 758df17c7d60e387ead9c65b81f250fd7b00a47c

Allow placeholders to be used in imports Allow `${..}` property placeholders to be used in `spring.config.import` properties. Prior to this commit, placeholders were not resolved when binding the `ConfigDataProperty` instance. Furthermore, binding happened too early for all placeholders to be resolved correctly. The `ConfigDataEnvironmentContributor` class now has two states for imported contributors, `UNBOUND_IMPORT` has the initial unbound state and is eventually replaced with a `BOUND_IMPORT`. Closes gh-23020

view details

Andy Wilkinson

commit sha 7a14477ac60fe4a363fec4c19ef7b1b7c26c520f

Upgrade to Gradle Enterprise Maven Extension 1.6.2 Closes gh-23055

view details

Andy Wilkinson

commit sha 947ba7081ab89e920ce872eb222ec06a10c4fa11

Merge branch '2.1.x' into 2.2.x Closes gh-23056

view details

Andy Wilkinson

commit sha 1f7d8f21802c848ca4d79204435f1a5c9fcb0a91

Merge branch '2.2.x' into 2.3.x

view details

Andy Wilkinson

commit sha a4089041209e83c29f6a8e314526901d16e8f768

Merge branch '2.3.x'

view details

mvanmeerbeck

commit sha cd6945aad299259bc9b9eb76c3aeff8662f47bfc

Add Hyperledger Fabric for Spring Boot Starter See gh-23058

view details

Stephane Nicoll

commit sha 2f7f5f4c8e2a0d61a9eb568f75d31c8280dc97e6

Polish "Add Hyperledger Fabric for Spring Boot Starter" See gh-23058

view details

Stephane Nicoll

commit sha 5b1c484e0d4c53be7c54797435141a273c5e333f

Merge pull request #23058 from mvanmeerbeck * pr/23058: Polish "Add Hyperledger Fabric for Spring Boot Starter" Add Hyperledger Fabric for Spring Boot Starter Closes gh-23058

view details

dreis2211

commit sha 33cd875cb8941fb1bf5ee1efe8df387affea3517

Simplify InputStream assertions See gh-23052

view details

Stephane Nicoll

commit sha 1aa7010c0f0ecf95f2509e2e85c12ad2656ddf6d

Merge pull request #23052 from dreis2211 * pr/23052: Simplify InputStream assertions Closes gh-23052

view details

Ivo Smid

commit sha e8de069e00b2d887bdd5d28e21b3fe1d6ece1798

Add example of custom Actuator operations See gh-23028

view details

push time in a month

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha 7a14477ac60fe4a363fec4c19ef7b1b7c26c520f

Upgrade to Gradle Enterprise Maven Extension 1.6.2 Closes gh-23055

view details

Andy Wilkinson

commit sha 947ba7081ab89e920ce872eb222ec06a10c4fa11

Merge branch '2.1.x' into 2.2.x Closes gh-23056

view details

Andy Wilkinson

commit sha 1f7d8f21802c848ca4d79204435f1a5c9fcb0a91

Merge branch '2.2.x' into 2.3.x

view details

Ivo Smid

commit sha e8de069e00b2d887bdd5d28e21b3fe1d6ece1798

Add example of custom Actuator operations See gh-23028

view details

Stephane Nicoll

commit sha f1455b156a2d84dcfaae14289f9c56cef4f85fb8

Polish "Add example of custom Actuator operations" See gh-23028

view details

Stephane Nicoll

commit sha c2b69d560ae7159b799d5982861dcc7f251e21ca

Merge pull request #23028 from bedla * pr/23028: Polish "Add example of custom Actuator operations" Add example of custom Actuator operations Closes gh-23028

view details

Stephane Nicoll

commit sha 39dc2e7de431f77cb4384c1871a8652125f7feab

Merge branch '2.2.x' into 2.3.x Closes gh-23060

view details

Stephane Nicoll

commit sha 5b0f22e8fe2d18dd76adb0f16200f64b8239d391

Fix unintended import on commons lang Closes gh-23059

view details

Stephane Nicoll

commit sha 0374ed2a0ccca3f05b97fda5d58eced9c42db22a

Merge branch '2.2.x' into 2.3.x Closes gh-23063

view details

push time in a month

issue closedspring-projects/spring-boot

Image building with newer Paketo base-platform-api-0.3 fails

<!-- Thanks for raising a Spring Boot issue. Please take the time to review the following categories as some of them do not apply here.

🙅 "Please DO NOT Raise an Issue" Cases

  • Question STOP!! Please ask questions about how to use something, or to understand why something isn't working as you expect it to, on Stack Overflow using the spring-boot tag.
  • Security Vulnerability STOP!! Please don't raise security vulnerabilities here. Head over to https://pivotal.io/security to learn how to disclose them responsibly.
  • Managed Dependency Upgrade You DO NOT need to raise an issue for a managed dependency version upgrade as there's a semi-automatic process for checking managed dependencies for new versions before a release. BUT pull requests for upgrades that are more involved than just a version property change are still most welcome.
  • With an Immediate Pull Request An issue will be closed as a duplicate of the immediate pull request, so you don't have to raise an issue if you plan to create a pull request immediately.

🐞 Bug report (please don't include this emoji/text, just add your details) Please provide details of the problem, including the version of Spring Boot that you are using. If possible, please provide a test case or sample application that reproduces the problem. This makes it much easier for us to diagnose the problem and to verify that we have fixed it.

🎁 Enhancement (please don't include this emoji/text, just add your details) Please start by describing the problem that you are trying to solve. There may already be a solution, or there may be a way to solve it that you hadn't considered.

TIP: You can always edit your issue if it isn't formatted correctly. See https://guides.github.com/features/mastering-markdown -->

  • Versions

    • spring-boot version: 2.3.3.RELEASE
    • jdk version: 11
    • gradle version: 6.4.1
  • Symptom Task :bootBuildImage FAILED

  • Log

$ ./gradlew bootBuildImage

> Task :bootBuildImage
Building image 'docker.io/library/demo:0.0.1-SNAPSHOT'

 > Pulling builder image 'gcr.io/paketo-buildpacks/builder:base-platform-api-0.3' ..................................................
 > Pulled builder image 'gcr.io/paketo-buildpacks/builder@sha256:14ddeb46d348e06c92c0b99fba68116fd08a41887b60962c63a4330a72809ea2'
 > Pulling run image 'docker.io/paketobuildpacks/run:base-cnb' ..................................................
 > Pulled run image 'paketobuildpacks/run@sha256:61a5832385b8cba83779eeb307d9014090702a23abd5e0b441c5590923c6e6ee'
 > Executing lifecycle version v0.9.1
 > Using build cache volume 'pack-cache-5cbe5692dbc4.build'

 > Running creator

> Task :bootBuildImage FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':bootBuildImage'.
> Docker API call to 'localhost/v1.24/containers/ed99a4920b25eb3d56aae2626aeeac4e1aaac6f0df6faf8469645d7def5d8192/start' failed with status code 400 "Bad Request"

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 5s
4 actionable tasks: 1 executed, 3 up-to-date
  • Expected problem
    • builder and run images have been recently changed.
      • working images

        • builder: 'gcr.io/paketo-buildpacks/builder@sha256:4d77f1f574148ff8f6fcd6ada7bf16559aa9ab080c30cdfc6613cdb235c0fb3b'
        • run: 'gcr.io/paketo-buildpacks/run@sha256:1303a41dfeebb0450640655ad464c66af5c2a500e20ad86d5687f00c4805d971'
      • not working images

        • builder: 'gcr.io/paketo-buildpacks/builder@sha256:14ddeb46d348e06c92c0b99fba68116fd08a41887b60962c63a4330a72809ea2'
        • run: 'gcr.io/paketo-buildpacks/run@sha256:61a5832385b8cba83779eeb307d9014090702a23abd5e0b441c5590923c6e6ee'

closed time in a month

virgo81net

issue commentspring-projects/spring-boot

Image building with newer Paketo base-platform-api-0.3 fails

Paketo has published new builders (e.g. gcr.io/paketo-buildpacks/builder@sha256:793b289414f3ea66540750edf618756916b6102a6a94389822526cd99d033b36) that have the /lifecycle symlink restored, and are compatible with Spring Boot 2.3.x and 2.4.0-Mx releases.

virgo81net

comment created time in a month

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 56bc0eb9e0889c1393ab67ef70b5b8805f6ae311

Use canonical path for CNB builder lifecycle binaries This commit changes the path used to invoke lifecycle binaries in CNB builders from `/lifecycle` to `/cnb/lifecycle` to conform to the CNB spec. This will ensure the build plugin image-building goals and tasks are compatible with future versions of builders that may not support both paths. See gh-23009

view details

push time in a month

delete branch scottfrederick/spring-boot

delete branch : gh-22321-polish

delete time in a month

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 56bc0eb9e0889c1393ab67ef70b5b8805f6ae311

Use canonical path for CNB builder lifecycle binaries This commit changes the path used to invoke lifecycle binaries in CNB builders from `/lifecycle` to `/cnb/lifecycle` to conform to the CNB spec. This will ensure the build plugin image-building goals and tasks are compatible with future versions of builders that may not support both paths. See gh-23009

view details

Scott Frederick

commit sha ee41d71ea856c44cddd9d25c1a2a4cbc4b840422

Merge branch '2.3.x' Closes gh-23016

view details

push time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha 56bc0eb9e0889c1393ab67ef70b5b8805f6ae311

Use canonical path for CNB builder lifecycle binaries This commit changes the path used to invoke lifecycle binaries in CNB builders from `/lifecycle` to `/cnb/lifecycle` to conform to the CNB spec. This will ensure the build plugin image-building goals and tasks are compatible with future versions of builders that may not support both paths. See gh-23009

view details

Scott Frederick

commit sha ee41d71ea856c44cddd9d25c1a2a4cbc4b840422

Merge branch '2.3.x' Closes gh-23016

view details

push time in a month

issue openedspring-projects/spring-boot

New base-platform-api-0.3 or base-cnb images make Task :bootBuildImage be FAILED

Forward port of issue #23009 to 2.4.x.

created time in a month

push eventscottfrederick/spring-boot

Phillip Webb

commit sha 5997cbd21f965bfabcbaabbe8b7b4f411ec247e1

Refine AbstractJarFile method visibility Refine method visibility in an attempt to fix test issues on Java 11+. See gh-22991

view details

Phillip Webb

commit sha 4e76138ebc3d0f88361526218c20856a8350bdf7

Update copyright year of changed files

view details

Phillip Webb

commit sha 60b5de192ca1db8073935b713fa921c7a4fbe5f5

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha ba2ab3363b43c390e7d500f227becd501c54d497

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha aa2580bb514f46455ca11a449e586087975fe359

Merge branch '2.3.x'

view details

Phillip Webb

commit sha 15a0cbc96bb7d54678ae4652cafb25d63e1c393e

Update copyright year of changed files

view details

Phillip Webb

commit sha 2fb08ca48f95ee66e65da53e849e7b97b42892fb

Merge branch '2.3.x'

view details

Phillip Webb

commit sha ea8762c4841240b95264e892c8fc4df655916859

Update copyright year of changed files

view details

Phillip Webb

commit sha 2a137a2d8a680fc28ca58387b508e6090512e0f6

Remove Mockito from JarFileWrapperTests Remove Mockto from JarFileWrapperTests since it seems to be failing on later versions of Java. See gh-22991

view details

Phillip Webb

commit sha c5b12effbfa41e1cdf4eafe3103a4841f4e4f81e

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha cfc053d75e0adeddd1c8400b2a5a8b46c6e80a9f

Merge branch '2.3.x'

view details

Phillip Webb

commit sha f7452b9383c1f27473bcef29610fc75967a06a1d

Ensure LayoutFactory is not passed an empty file Update `Repackager` to ensure that `getLayout` is called before we backup the source file. This restores earlier behavior that some custom `ModuleFactory` implementations were relying on. Closes gh-22995

view details

Phillip Webb

commit sha 899e8e189b5af2e1b9baf0560596a76d471ede54

Merge branch '2.3.x' Closes gh-23001

view details

dreis2211

commit sha 06eb7e977723ffe322d9f6232df09acb0ed4ec19

Mention correct JUnit 5 annotations in Kotlin testing section See gh-23002

view details

Stephane Nicoll

commit sha 47e5db9e439a49e93d8e7d10ae3ad8acadee131d

Merge pull request #23002 from dreis2211 * pr/23002: Mention correct JUnit 5 annotations in Kotlin testing section Closes gh-23002

view details

Stephane Nicoll

commit sha 9a374f7d67b786f42be9fc728e8072602ec9ff01

Merge branch '2.2.x' into 2.3.x Closes gh-23004

view details

Stephane Nicoll

commit sha d04f2583f1f64d91a5745ee9223c7aeb30541d3f

Merge branch '2.3.x' Closes gh-23005

view details

Phillip Webb

commit sha 3fe2005e06db8a0582647b92e83ee4eec5d2259d

Use @AfterEach to close the source jar file Update `JarFileWrapperTests` so that the jar files are closed after each test. See gh-22991

view details

Phillip Webb

commit sha 0dd38a72642e7229d29251f83a499fa35c981371

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha bd5266b9b1f96c69bd3ba3701bbfda54bb73fdc1

Merge branch '2.3.x'

view details

push time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha 56bc0eb9e0889c1393ab67ef70b5b8805f6ae311

Use canonical path for CNB builder lifecycle binaries This commit changes the path used to invoke lifecycle binaries in CNB builders from `/lifecycle` to `/cnb/lifecycle` to conform to the CNB spec. This will ensure the build plugin image-building goals and tasks are compatible with future versions of builders that may not support both paths. See gh-23009

view details

push time in a month

push eventscottfrederick/spring-boot

Phillip Webb

commit sha 5997cbd21f965bfabcbaabbe8b7b4f411ec247e1

Refine AbstractJarFile method visibility Refine method visibility in an attempt to fix test issues on Java 11+. See gh-22991

view details

Phillip Webb

commit sha 4e76138ebc3d0f88361526218c20856a8350bdf7

Update copyright year of changed files

view details

Phillip Webb

commit sha ba2ab3363b43c390e7d500f227becd501c54d497

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha 15a0cbc96bb7d54678ae4652cafb25d63e1c393e

Update copyright year of changed files

view details

Phillip Webb

commit sha 2a137a2d8a680fc28ca58387b508e6090512e0f6

Remove Mockito from JarFileWrapperTests Remove Mockto from JarFileWrapperTests since it seems to be failing on later versions of Java. See gh-22991

view details

Phillip Webb

commit sha c5b12effbfa41e1cdf4eafe3103a4841f4e4f81e

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha f7452b9383c1f27473bcef29610fc75967a06a1d

Ensure LayoutFactory is not passed an empty file Update `Repackager` to ensure that `getLayout` is called before we backup the source file. This restores earlier behavior that some custom `ModuleFactory` implementations were relying on. Closes gh-22995

view details

dreis2211

commit sha 06eb7e977723ffe322d9f6232df09acb0ed4ec19

Mention correct JUnit 5 annotations in Kotlin testing section See gh-23002

view details

Stephane Nicoll

commit sha 47e5db9e439a49e93d8e7d10ae3ad8acadee131d

Merge pull request #23002 from dreis2211 * pr/23002: Mention correct JUnit 5 annotations in Kotlin testing section Closes gh-23002

view details

Stephane Nicoll

commit sha 9a374f7d67b786f42be9fc728e8072602ec9ff01

Merge branch '2.2.x' into 2.3.x Closes gh-23004

view details

Phillip Webb

commit sha 3fe2005e06db8a0582647b92e83ee4eec5d2259d

Use @AfterEach to close the source jar file Update `JarFileWrapperTests` so that the jar files are closed after each test. See gh-22991

view details

Phillip Webb

commit sha 0dd38a72642e7229d29251f83a499fa35c981371

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha 8722c2c5de6b36a1611431ccd1acff9d43dc2240

Close writer after use in ExtractCommandTests Update `ExtractCommandTests` so that the writer is closed after the contents have been written. See gh-22993

view details

Phillip Webb

commit sha 17e2d72bcb48e3c9b034f0837b63bb4bc3b14aa1

Fix Windows path issue in JarFileWrapperTests See gh-22991

view details

Phillip Webb

commit sha 73038267a0d35c5fbd86d364dfde09913bc04f52

Merge branch '2.2.x' into 2.3.x

view details

Phillip Webb

commit sha 8fd9c685a22437a845d43a41ab120b363b0ae796

Reduce HTTP debug logging when building image Update `BuildImageMojo` so that commons HTTP wire logging is configured to ERROR. Without this update, running `mvn -X` will produce a great deal of logging since by default HTTP Client logs all bytes transfered at DEBUG and Maven will enable DEBUG for all logs. Closes gh-22674

view details

push time in a month

issue commentspring-projects/spring-boot

Creating docker images stopped working

Adding '-X' output produced over 50Mb of log data and slowed the build

That issue is being addressed in #22674

kdvolder

comment created time in a month

issue commentspring-projects/spring-boot

New base-platform-api-0.3 or base-cnb images make Task :bootBuildImage be FAILED

Here's what happened:

Spring Boot invokes lifecycle phases in the builder image using a path to executable binaries bundled in the image. The canonical path for lifecycle binaries per the CNB spec is /cnb/lifecycle, but Boot is using an outdated path /lifecycle. The pack CLI that is used to create builder images symlinked /lifecycle to /cnb/lifecycle for backward compatibility.

The /lifecycle symlink creation was removed from pack in version 0.13.0, and any builders that were created and published using this version of pack became incompatible with Spring Boot.

The CNB team will release a 0.13.1 version of pack that restores the /lifecycle symlink in builders. The Paketo builders will be re-built so they include the /lifecycle symlink.

We'll use this issue to update Spring Boot to use the canonical /cnb/lifecycle path in future releases.

virgo81net

comment created time in a month

issue closedspring-projects/spring-boot

Creating docker images stopped working

Suddenly from one day to the next, docker image building stopped working. Project I'm building today worked fine yesterday. As far as I know nothing has changed (though I guess I must be wrong or it wouldn't just stop working).

What I am sure hasn't changed:

  • boot version 2.3.3
  • maven version (from the wrapper in the project)
  • jvm version (no new jvms installed or updated on my machine)

To rule out that this somehow a problem of my own creation I tried again with a brand new project created from initialzr. It is basically just a 'empty' maven boot project with 'web' and 'actuator' dependency using Java 1.8. All other selections in the wizard left at default and boot version 2.3.3, direct from intializr.

To reproduce:

  • get project from start.spring.io (maven, web, actuator, java 1.8, boot 2.3.3)
  • unzip
  • run ./mvnw spring-boot:build-image

Expected result:

  • builds a docker image

Actual result:

The build is aborted with an error about invalid docker api call.

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image (default-cli) on project demo-8: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image failed: Docker API call to 'localhost/v1.24/containers/6ed2d5f635b2ea79d383605cfcc277f2b1ea0d9503824b7e8fe7eb82b9216209/start' failed with status code 400 "Bad Request" -> [Help 1]

Adding -e option produced a stacktrace:

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image (default-cli) on project demo-8: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image failed: Docker API call to 'localhost/v1.24/containers/b99e38e8a3ee949f5ec732aff32cdfcca1d1fb3de60b7d6b70f33ca44d242bb3/start' failed with status code 400 "Bad Request" -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image (default-cli) on project demo-8: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image failed: Docker API call to 'localhost/v1.24/containers/b99e38e8a3ee949f5ec732aff32cdfcca1d1fb3de60b7d6b70f33ca44d242bb3/start' failed with status code 400 "Bad Request"
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:39)
    at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
    at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image failed: Docker API call to 'localhost/v1.24/containers/b99e38e8a3ee949f5ec732aff32cdfcca1d1fb3de60b7d6b70f33ca44d242bb3/start' failed with status code 400 "Bad Request"
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:39)
    at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
    at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61)
Caused by: org.springframework.boot.buildpack.platform.docker.transport.DockerEngineException: Docker API call to 'localhost/v1.24/containers/b99e38e8a3ee949f5ec732aff32cdfcca1d1fb3de60b7d6b70f33ca44d242bb3/start' failed with status code 400 "Bad Request"
    at org.springframework.boot.buildpack.platform.docker.transport.HttpClientTransport.execute (HttpClientTransport.java:136)
    at org.springframework.boot.buildpack.platform.docker.transport.HttpClientTransport.post (HttpClientTransport.java:82)
    at org.springframework.boot.buildpack.platform.docker.DockerApi$ContainerApi.start (DockerApi.java:253)
    at org.springframework.boot.buildpack.platform.build.Lifecycle.run (Lifecycle.java:148)
    at org.springframework.boot.buildpack.platform.build.Lifecycle.execute (Lifecycle.java:113)
    at org.springframework.boot.buildpack.platform.build.Builder.executeLifecycle (Builder.java:122)
    at org.springframework.boot.buildpack.platform.build.Builder.build (Builder.java:71)
    at org.springframework.boot.maven.BuildImageMojo.buildImage (BuildImageMojo.java:144)
    at org.springframework.boot.maven.BuildImageMojo.execute (BuildImageMojo.java:136)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:39)
    at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
    at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61)

Adding '-X' output produced over 50Mb of log data and slowed the build so much that I killed it. The log is also a bit too big to attach here.

Full output below (from normal run without -X or -e):

[INFO] Scanning for projects...
[INFO] 
[INFO] -------------------------< com.example:demo-8 >-------------------------
[INFO] Building demo-8 0.0.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] >>> spring-boot-maven-plugin:2.3.3.RELEASE:build-image (default-cli) > package @ demo-8 >>>
[INFO] 
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ demo-8 ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 0 resource
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ demo-8 ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ demo-8 ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/kdvolder/workspaces-sts/runtime-New_configuration/demo-8/src/test/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ demo-8 ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ demo-8 ---
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.example.demo.Demo8ApplicationTests
11:38:46.603 [main] DEBUG org.springframework.test.context.BootstrapUtils - Instantiating CacheAwareContextLoaderDelegate from class [org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate]
11:38:46.610 [main] DEBUG org.springframework.test.context.BootstrapUtils - Instantiating BootstrapContext using constructor [public org.springframework.test.context.support.DefaultBootstrapContext(java.lang.Class,org.springframework.test.context.CacheAwareContextLoaderDelegate)]
11:38:46.632 [main] DEBUG org.springframework.test.context.BootstrapUtils - Instantiating TestContextBootstrapper for test class [com.example.demo.Demo8ApplicationTests] from class [org.springframework.boot.test.context.SpringBootTestContextBootstrapper]
11:38:46.643 [main] INFO org.springframework.boot.test.context.SpringBootTestContextBootstrapper - Neither @ContextConfiguration nor @ContextHierarchy found for test class [com.example.demo.Demo8ApplicationTests], using SpringBootContextLoader
11:38:46.646 [main] DEBUG org.springframework.test.context.support.AbstractContextLoader - Did not detect default resource location for test class [com.example.demo.Demo8ApplicationTests]: class path resource [com/example/demo/Demo8ApplicationTests-context.xml] does not exist
11:38:46.646 [main] DEBUG org.springframework.test.context.support.AbstractContextLoader - Did not detect default resource location for test class [com.example.demo.Demo8ApplicationTests]: class path resource [com/example/demo/Demo8ApplicationTestsContext.groovy] does not exist
11:38:46.646 [main] INFO org.springframework.test.context.support.AbstractContextLoader - Could not detect default resource locations for test class [com.example.demo.Demo8ApplicationTests]: no resource found for suffixes {-context.xml, Context.groovy}.
11:38:46.647 [main] INFO org.springframework.test.context.support.AnnotationConfigContextLoaderUtils - Could not detect default configuration classes for test class [com.example.demo.Demo8ApplicationTests]: Demo8ApplicationTests does not declare any static, non-private, non-final, nested classes annotated with @Configuration.
11:38:46.678 [main] DEBUG org.springframework.test.context.support.ActiveProfilesUtils - Could not find an 'annotation declaring class' for annotation type [org.springframework.test.context.ActiveProfiles] and class [com.example.demo.Demo8ApplicationTests]
11:38:46.722 [main] DEBUG org.springframework.context.annotation.ClassPathScanningCandidateComponentProvider - Identified candidate component class: file [/home/kdvolder/workspaces-sts/runtime-New_configuration/demo-8/target/classes/com/example/demo/Demo8Application.class]
11:38:46.723 [main] INFO org.springframework.boot.test.context.SpringBootTestContextBootstrapper - Found @SpringBootConfiguration com.example.demo.Demo8Application for test class com.example.demo.Demo8ApplicationTests
11:38:46.789 [main] DEBUG org.springframework.boot.test.context.SpringBootTestContextBootstrapper - @TestExecutionListeners is not present for class [com.example.demo.Demo8ApplicationTests]: using defaults.
11:38:46.789 [main] INFO org.springframework.boot.test.context.SpringBootTestContextBootstrapper - Loaded default TestExecutionListener class names from location [META-INF/spring.factories]: [org.springframework.boot.test.mock.mockito.MockitoTestExecutionListener, org.springframework.boot.test.mock.mockito.ResetMocksTestExecutionListener, org.springframework.boot.test.autoconfigure.restdocs.RestDocsTestExecutionListener, org.springframework.boot.test.autoconfigure.web.client.MockRestServiceServerResetTestExecutionListener, org.springframework.boot.test.autoconfigure.web.servlet.MockMvcPrintOnlyOnFailureTestExecutionListener, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverTestExecutionListener, org.springframework.boot.test.autoconfigure.webservices.client.MockWebServiceServerTestExecutionListener, org.springframework.test.context.web.ServletTestExecutionListener, org.springframework.test.context.support.DirtiesContextBeforeModesTestExecutionListener, org.springframework.test.context.support.DependencyInjectionTestExecutionListener, org.springframework.test.context.support.DirtiesContextTestExecutionListener, org.springframework.test.context.transaction.TransactionalTestExecutionListener, org.springframework.test.context.jdbc.SqlScriptsTestExecutionListener, org.springframework.test.context.event.EventPublishingTestExecutionListener]
11:38:46.799 [main] DEBUG org.springframework.boot.test.context.SpringBootTestContextBootstrapper - Skipping candidate TestExecutionListener [org.springframework.test.context.transaction.TransactionalTestExecutionListener] due to a missing dependency. Specify custom listener classes or make the default listener classes and their required dependencies available. Offending class: [org/springframework/transaction/TransactionDefinition]
11:38:46.800 [main] DEBUG org.springframework.boot.test.context.SpringBootTestContextBootstrapper - Skipping candidate TestExecutionListener [org.springframework.test.context.jdbc.SqlScriptsTestExecutionListener] due to a missing dependency. Specify custom listener classes or make the default listener classes and their required dependencies available. Offending class: [org/springframework/transaction/interceptor/TransactionAttribute]
11:38:46.800 [main] INFO org.springframework.boot.test.context.SpringBootTestContextBootstrapper - Using TestExecutionListeners: [org.springframework.test.context.web.ServletTestExecutionListener@3232a28a, org.springframework.test.context.support.DirtiesContextBeforeModesTestExecutionListener@73e22a3d, org.springframework.boot.test.mock.mockito.MockitoTestExecutionListener@47faa49c, org.springframework.boot.test.autoconfigure.SpringBootDependencyInjectionTestExecutionListener@28f2a10f, org.springframework.test.context.support.DirtiesContextTestExecutionListener@f736069, org.springframework.test.context.event.EventPublishingTestExecutionListener@6da21078, org.springframework.boot.test.mock.mockito.ResetMocksTestExecutionListener@7fee8714, org.springframework.boot.test.autoconfigure.restdocs.RestDocsTestExecutionListener@4229bb3f, org.springframework.boot.test.autoconfigure.web.client.MockRestServiceServerResetTestExecutionListener@56cdfb3b, org.springframework.boot.test.autoconfigure.web.servlet.MockMvcPrintOnlyOnFailureTestExecutionListener@2b91004a, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverTestExecutionListener@20ccf40b, org.springframework.boot.test.autoconfigure.webservices.client.MockWebServiceServerTestExecutionListener@2fb3536e]
11:38:46.804 [main] DEBUG org.springframework.test.context.support.AbstractDirtiesContextTestExecutionListener - Before test class: context [DefaultTestContext@614ca7df testClass = Demo8ApplicationTests, testInstance = [null], testMethod = [null], testException = [null], mergedContextConfiguration = [WebMergedContextConfiguration@4738a206 testClass = Demo8ApplicationTests, locations = '{}', classes = '{class com.example.demo.Demo8Application}', contextInitializerClasses = '[]', activeProfiles = '{}', propertySourceLocations = '{}', propertySourceProperties = '{org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true}', contextCustomizers = set[org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@1fe20588, org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@2ddc8ecb, org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0, org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@647fd8ce, org.springframework.boot.test.autoconfigure.properties.PropertyMappingContextCustomizer@0, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverContextCustomizerFactory$Customizer@3967e60c, org.springframework.boot.test.context.SpringBootTestArgs@1], resourceBasePath = 'src/main/webapp', contextLoader = 'org.springframework.boot.test.context.SpringBootContextLoader', parent = [null]], attributes = map['org.springframework.test.context.web.ServletTestExecutionListener.activateListener' -> true]], class annotated with @DirtiesContext [false] with mode [null].
11:38:46.830 [main] DEBUG org.springframework.test.context.support.TestPropertySourceUtils - Adding inlined properties to environment: {spring.jmx.enabled=false, org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true}

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v2.3.3.RELEASE)

2020-08-19 11:38:46.993  INFO 29826 --- [           main] com.example.demo.Demo8ApplicationTests   : Starting Demo8ApplicationTests on dellicioso with PID 29826 (started by kdvolder in /home/kdvolder/workspaces-sts/runtime-New_configuration/demo-8)
2020-08-19 11:38:46.994  INFO 29826 --- [           main] com.example.demo.Demo8ApplicationTests   : No active profile set, falling back to default profiles: default
2020-08-19 11:38:47.905  INFO 29826 --- [           main] o.s.s.concurrent.ThreadPoolTaskExecutor  : Initializing ExecutorService 'applicationTaskExecutor'
2020-08-19 11:38:48.190  INFO 29826 --- [           main] o.s.b.a.e.web.EndpointLinksResolver      : Exposing 2 endpoint(s) beneath base path '/actuator'
2020-08-19 11:38:48.224  INFO 29826 --- [           main] com.example.demo.Demo8ApplicationTests   : Started Demo8ApplicationTests in 1.386 seconds (JVM running for 2.03)
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.847 s - in com.example.demo.Demo8ApplicationTests
2020-08-19 11:38:48.440  INFO 29826 --- [extShutdownHook] o.s.s.concurrent.ThreadPoolTaskExecutor  : Shutting down ExecutorService 'applicationTaskExecutor'
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ demo-8 ---
[INFO] Building jar: /home/kdvolder/workspaces-sts/runtime-New_configuration/demo-8/target/demo-8-0.0.1-SNAPSHOT.jar
[INFO] 
[INFO] --- spring-boot-maven-plugin:2.3.3.RELEASE:repackage (repackage) @ demo-8 ---
[INFO] Replacing main artifact with repackaged archive
[INFO] 
[INFO] <<< spring-boot-maven-plugin:2.3.3.RELEASE:build-image (default-cli) < package @ demo-8 <<<
[INFO] 
[INFO] 
[INFO] --- spring-boot-maven-plugin:2.3.3.RELEASE:build-image (default-cli) @ demo-8 ---
[INFO] Building image 'docker.io/library/demo-8:0.0.1-SNAPSHOT'
[INFO] 
[INFO]  > Pulling builder image 'gcr.io/paketo-buildpacks/builder:base-platform-api-0.3' 100%
[INFO]  > Pulled builder image 'gcr.io/paketo-buildpacks/builder@sha256:14ddeb46d348e06c92c0b99fba68116fd08a41887b60962c63a4330a72809ea2'
[INFO]  > Pulling run image 'docker.io/paketobuildpacks/run:base-cnb' 100%
[INFO]  > Pulled run image 'paketobuildpacks/run@sha256:61a5832385b8cba83779eeb307d9014090702a23abd5e0b441c5590923c6e6ee'
[INFO]  > Executing lifecycle version v0.9.1
[INFO]  > Using build cache volume 'pack-cache-8bd8923b6b4f.build'
[INFO] 
[INFO]  > Running creator
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.257 s
[INFO] Finished at: 2020-08-19T11:38:52-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image (default-cli) on project demo-8: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.3.RELEASE:build-image failed: Docker API call to 'localhost/v1.24/containers/36ebc3b0c2df4aba5a736df13030278b61c3e7f124b080633ca8dd3cab6b04dc/start' failed with status code 400 "Bad Request" -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException

closed time in a month

kdvolder

issue commentspring-projects/spring-boot

Creating docker images stopped working

Duplicate of #23009

kdvolder

comment created time in a month

issue commentspring-projects/spring-boot

New base-platform-api-0.3 or base-cnb images make Task :bootBuildImage be FAILED

I've can re-create the problem also. It's likely an issue that Paketo needs to address in the builder. I'll ask them to investigate.

virgo81net

comment created time in a month

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 3f80638a368fb3547c443e339aeeba9224b1ac6b

Fail on layertools extract with launch script This commit adds a check to the `layertools extract` command to ensure that the jar file being processed is readable and has a valid directory. Fixes gh-22993

view details

push time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha 3f80638a368fb3547c443e339aeeba9224b1ac6b

Fail on layertools extract with launch script This commit adds a check to the `layertools extract` command to ensure that the jar file being processed is readable and has a valid directory. Fixes gh-22993

view details

Scott Frederick

commit sha 341615d7d02dc1a3d10f503a98eaba1ca854e79d

Merge branch '2.3.x' Closes gh-23000

view details

push time in a month

issue closedspring-projects/spring-boot

Extracting layers with layertools doesn't work with executable JAR files

<!-- Thanks for raising a Spring Boot issue. Please take the time to review the following categories as some of them do not apply here.

🙅 "Please DO NOT Raise an Issue" Cases

  • Question STOP!! Please ask questions about how to use something, or to understand why something isn't working as you expect it to, on Stack Overflow using the spring-boot tag.
  • Security Vulnerability STOP!! Please don't raise security vulnerabilities here. Head over to https://pivotal.io/security to learn how to disclose them responsibly.
  • Managed Dependency Upgrade You DO NOT need to raise an issue for a managed dependency version upgrade as there's a semi-automatic process for checking managed dependencies for new versions before a release. BUT pull requests for upgrades that are more involved than just a version property change are still most welcome.
  • With an Immediate Pull Request An issue will be closed as a duplicate of the immediate pull request, so you don't have to raise an issue if you plan to create a pull request immediately.

🐞 Bug report (please don't include this emoji/text, just add your details) Please provide details of the problem, including the version of Spring Boot that you are using. If possible, please provide a test case or sample application that reproduces the problem. This makes it much easier for us to diagnose the problem and to verify that we have fixed it.

🎁 Enhancement (please don't include this emoji/text, just add your details) Please start by describing the problem that you are trying to solve. There may already be a solution, or there may be a way to solve it that you hadn't considered.

TIP: You can always edit your issue if it isn't formatted correctly. See https://guides.github.com/features/mastering-markdown -->

I'm using Spring Boot 2.3.3.

I've got a project where I'm building a fat JAR using the spring-boot-maven-plugin. I've configured the JAR to be executable and I've explicitly enabled layers. This is my configuration of the spring-boot-maven-plugin:

<plugin>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-maven-plugin</artifactId>
    <configuration>
        <executable>true</executable>
        <layers>
            <enabled>true</enabled>
        </layers>
    </configuration>
    <executions>
        <execution>
            <id>repackage</id>
            <goals>
                <goal>repackage</goal>
            </goals>
        </execution>
    </executions>
</plugin>

After building the project with mvn package, I try to extract the layers java -Djarmode=layertools -jar target/my-project-0.1.0-SNAPSHOT.jar extract --destination dest as described in this blog post on spring.io.

This gives me an empty directory for each of the layers:

$ ls -R dest
dest:
application  dependencies  snapshot-dependencies  spring-boot-loader

dest/application:

dest/dependencies:

dest/snapshot-dependencies:

dest/spring-boot-loader:

I would expect the directories to contain the class files of the different layers instead.

I noticed that this is caused by the JAR file being executable. I debugged through ExtractCommand.java and ZipInputStream#getNextEntry() will always return null for an executable JAR.

I think the options are to either improve the ExtractCommand (and possibly other commands) to work with executable JARs or to give a disclaimer in the documentation that the layertools don't work with executable JARs.

A fix could involve the following steps:

  • Call mark(2) on the FileInputStream to be able to later reset it in case the file is not executable.
  • Read the first two bytes from the FileInputStream and check if they match the "shebang" (#!) magic number (0x23 0x21).
  • In case the file doesn't start with a shebang, reset the input stream.
  • In case the file starts with a shebang, read bytes until the characters \necho 0 are read.
  • Wrap the input stream in a ZipInputStream and read the entries like before.

I know that this implementation won't be that easy, so I'd totally understand if you chose not to support executable JARs.

closed time in a month

pvorb

push eventscottfrederick/spring-boot

Scott Frederick

commit sha 3f80638a368fb3547c443e339aeeba9224b1ac6b

Fail on layertools extract with launch script This commit adds a check to the `layertools extract` command to ensure that the jar file being processed is readable and has a valid directory. Fixes gh-22993

view details

Scott Frederick

commit sha 341615d7d02dc1a3d10f503a98eaba1ca854e79d

Merge branch '2.3.x' Closes gh-23000

view details

push time in a month

issue openedspring-projects/spring-boot

Extracting layers with layertools doesn't work with executable JAR files

Forward port of issue #22993 to 2.4.x.

created time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha 3f80638a368fb3547c443e339aeeba9224b1ac6b

Fail on layertools extract with launch script This commit adds a check to the `layertools extract` command to ensure that the jar file being processed is readable and has a valid directory. Fixes gh-22993

view details

push time in a month

push eventscottfrederick/spring-boot

Phillip Webb

commit sha aac367e9c5e40733421716f2edfb3522f3480119

Attempt to fix memory leak in JarFile class Create a new `JarFileWrapper` class so that we can wrap and existing `JarFile` and offer a version that can be safely closed. Prior to this commit, we provided wrapper functionality in the `JarFile` class itself. Unfortunately, because we override `close` and also create a lot of wrappers this caused memory issues when running on Java 11. With Java 11 `java.util.zip.ZipFile` class uses `FinalizableResource` for any implementation that overrides `close()`. This means that any wrapper classes will not be garbage collected until the JVM finalizer thread runs. Closes gh-22991

view details

Phillip Webb

commit sha 2b1b096faccab2969e42be37925236cb4a8bb474

Merge branch '2.2.x' into 2.3.x Closes gh-22998

view details

push time in a month

push eventscottfrederick/spring-boot

Phillip Webb

commit sha aac367e9c5e40733421716f2edfb3522f3480119

Attempt to fix memory leak in JarFile class Create a new `JarFileWrapper` class so that we can wrap and existing `JarFile` and offer a version that can be safely closed. Prior to this commit, we provided wrapper functionality in the `JarFile` class itself. Unfortunately, because we override `close` and also create a lot of wrappers this caused memory issues when running on Java 11. With Java 11 `java.util.zip.ZipFile` class uses `FinalizableResource` for any implementation that overrides `close()`. This means that any wrapper classes will not be garbage collected until the JVM finalizer thread runs. Closes gh-22991

view details

Phillip Webb

commit sha 2b1b096faccab2969e42be37925236cb4a8bb474

Merge branch '2.2.x' into 2.3.x Closes gh-22998

view details

Phillip Webb

commit sha b60820564ef542c44e343d1634ce69e213a1567c

Merge branch '2.3.x' Closes gh-22999

view details

push time in a month

push eventscottfrederick/spring-boot

Martin Benda

commit sha 02b7ec787e9674411efbefed18ad27660e11779a

Order metrics auto-configurations correctly Update metrics auto-configurations so that they are auto-configured after `CompositeMeterRegistryAutoConfiguration` in order to ensure the `MeterRegistry` bean has been defined. Prior to this commit, metrics auto-configurations that depended on a `MeterRegistry` has `@AutoConfigureAfter(MetricsAutoConfiguration.class)` which is not sufficient since `MetricsAutoConfiguration` does not export a `MeterRegistry`. See gh-21134

view details

Phillip Webb

commit sha 10da59530234dde7b3be914126f4712cd7a7e255

Polish 'Order metrics auto-configurations correctly' See gh-21134

view details

Phillip Webb

commit sha 460fb3ccb88455b2dd7ff292b5e75f5ca3ee8123

Merge pull request #21134 from bendiscz * pr/21134: Polish 'Order metrics auto-configurations correctly' Order metrics auto-configurations correctly Closes gh-21134

view details

Phillip Webb

commit sha ff36f8bab897a336f33a6786209d467e55edf398

Merge branch '2.2.x' into 2.3.x Closes gh-22989

view details

push time in a month

create barnchscottfrederick/spring-boot

branch : gh-22321-polish

created branch time in a month

issue commentspring-projects/spring-boot

Adjust fat jar central directory to account for launch script

A pull request has been created to implement the requested feature in Apache Commons Compress.

scottfrederick

comment created time in a month

issue commentspring-projects/spring-boot

Extracting layers with layertools doesn't work with executable JAR files

This is similar to #22223.

For Spring Boot 2.3.x, we should detect this condition in layertools and give a warning or error like we do for the bootBuildImage task.

For Spring Boot 2.4.x, we're hoping to be able to fix up the jar file properly in #22336.

pvorb

comment created time in a month

push eventscottfrederick/spring-boot

Martin Benda

commit sha 02b7ec787e9674411efbefed18ad27660e11779a

Order metrics auto-configurations correctly Update metrics auto-configurations so that they are auto-configured after `CompositeMeterRegistryAutoConfiguration` in order to ensure the `MeterRegistry` bean has been defined. Prior to this commit, metrics auto-configurations that depended on a `MeterRegistry` has `@AutoConfigureAfter(MetricsAutoConfiguration.class)` which is not sufficient since `MetricsAutoConfiguration` does not export a `MeterRegistry`. See gh-21134

view details

Phillip Webb

commit sha 10da59530234dde7b3be914126f4712cd7a7e255

Polish 'Order metrics auto-configurations correctly' See gh-21134

view details

Phillip Webb

commit sha 460fb3ccb88455b2dd7ff292b5e75f5ca3ee8123

Merge pull request #21134 from bendiscz * pr/21134: Polish 'Order metrics auto-configurations correctly' Order metrics auto-configurations correctly Closes gh-21134

view details

Phillip Webb

commit sha ff36f8bab897a336f33a6786209d467e55edf398

Merge branch '2.2.x' into 2.3.x Closes gh-22989

view details

Phillip Webb

commit sha 12bae2ad524bd6625193824c9eb4327fefbaa85a

Merge branch '2.3.x' Closes gh-22990

view details

Phillip Webb

commit sha 9460d74e8ad8c247c3ad9a627ab35aa08df21152

Rename CompositeMeterRegistryAutoConfiguration Rename `CompositeMeterRegistryAutoConfiguration` to `MeterRegistryAutoConfiguration` since it can also create non-composite registries. Closes gh-22988

view details

Stephane Nicoll

commit sha 0b28236e55c8b07b36b51cd98b0f480616018af9

Rename neo4j.version to neo4j-java-driver.version Closes gh-22952

view details

push time in a month

delete branch scottfrederick/spring-boot

delete branch : gh-22223

delete time in a month

delete branch scottfrederick/spring-boot

delete branch : gh-22321

delete time in a month

push eventspring-projects/spring-boot

Scott Frederick

commit sha b7fdf8fe87da1c01ff6aca041170a02f11280a1a

Preserve user-provided values in MongoClientSettings Prior to this commit, values from MongoProperties would always overwrite matching fields in MongoClientSettings. This commit preserves all values in MongoClientSettings if the client app provides the MongoClientSettings bean, and only overwrites from MongoProperties if no MongoClientSettings bean is provided. Fixes gh-22321

view details

push time in a month

issue closedspring-projects/spring-boot

MongoClientFactorySupport overrides existing uuidRepresentation with MongoProperties default value

Original Bug Report: DATAMONGO-2561

I have MongoClientSettings bean defined in my configuration with STANTARD uuid representation. After migration to spring 2.3.0 this value is always overridden by MongoProperties.uuidRepresentation. MongoProperties.uuidRepresentation is a field with default value JAVA_LEGACY and even when spring.data.mongodb.uuidRepresentation property is not defined, the default value is used instead of one defined in MongoClientSettings.

MongoClientFactorySupport should check if the source MongoClientSettings passed to createClient already define an uuidRepresentation other than UNDEFINED before applying the default value from MongoProperties that then potentially overrides existing settings.

closed time in a month

christophstrobl

push eventscottfrederick/spring-boot

Scott Frederick

commit sha b7fdf8fe87da1c01ff6aca041170a02f11280a1a

Preserve user-provided values in MongoClientSettings Prior to this commit, values from MongoProperties would always overwrite matching fields in MongoClientSettings. This commit preserves all values in MongoClientSettings if the client app provides the MongoClientSettings bean, and only overwrites from MongoProperties if no MongoClientSettings bean is provided. Fixes gh-22321

view details

push time in a month

push eventscottfrederick/spring-boot

Lopfest

commit sha c49605cd7b6a76168738019a21632bd64b2634ed

Fix include exception handling in DefaultErrorAttributes This commit fixes a problem with the handling of the includeException field in DefaultErrorAttributes. See gh-22750

view details

Scott Frederick

commit sha c2ec46c5b10d17aa0bf0bb638162741738341a69

Polish "Fix include exception handling in DefaultErrorAttributes" See gh-22750

view details

Phillip Webb

commit sha b8a8b85a5890f7b8cf4bdd9c5d76ed88cc910267

Merge pull request #22750 from Lopfest * pr/22750: Polish "Fix include exception handling in DefaultErrorAttributes" Fix include exception handling in DefaultErrorAttributes Closes gh-22750

view details

Phillip Webb

commit sha 9c6f0d8f7ead0791e0c6ae9c84cbd5ad33f0ddf6

Merge branch '2.3.x' Closes gh-22984

view details

push time in a month

push eventscottfrederick/spring-boot

Phillip Webb

commit sha b8a8b85a5890f7b8cf4bdd9c5d76ed88cc910267

Merge pull request #22750 from Lopfest * pr/22750: Polish "Fix include exception handling in DefaultErrorAttributes" Fix include exception handling in DefaultErrorAttributes Closes gh-22750

view details

push time in a month

pull request commentspring-projects/spring-boot

Do not include error exception attribute when not specified

@Lopfest Thank you for your first contribution to Spring Boot. Your change has been merged along with another commit that adds tests to verify the broken behavior before your change and confirm the fix after your change.

Lopfest

comment created time in a month

push eventspring-projects/spring-boot

Lopfest

commit sha c49605cd7b6a76168738019a21632bd64b2634ed

Fix include exception handling in DefaultErrorAttributes This commit fixes a problem with the handling of the includeException field in DefaultErrorAttributes. See gh-22750

view details

Scott Frederick

commit sha c2ec46c5b10d17aa0bf0bb638162741738341a69

Polish "Fix include exception handling in DefaultErrorAttributes" See gh-22750

view details

push time in a month

push eventscottfrederick/spring-boot

Lopfest

commit sha c49605cd7b6a76168738019a21632bd64b2634ed

Fix include exception handling in DefaultErrorAttributes This commit fixes a problem with the handling of the includeException field in DefaultErrorAttributes. See gh-22750

view details

Scott Frederick

commit sha c2ec46c5b10d17aa0bf0bb638162741738341a69

Polish "Fix include exception handling in DefaultErrorAttributes" See gh-22750

view details

push time in a month

push eventscottfrederick/spring-boot

Andy Wilkinson

commit sha 3e35fd480fdb35cfb223c232933998016316872c

Wait longer for server port and improve diagnostics on timeout See gh-22909

view details

Maciej Walkowiak

commit sha 15de956566b0737d3e53a816a6be60ed3e41c759

Fix typo `Assert4J` -> `AssertJ` See gh-22948

view details

Phillip Webb

commit sha 2fe446335a8919cd5033683e55d2097c66ae8c3d

Merge pull request #22948 from maciejwalkowiak * pr/22948: Fix typo `Assert4J` -> `AssertJ` Closes gh-22948

view details

Phillip Webb

commit sha 03d4b89c06960bc855f9173346890861c2ecb875

Merge branch '2.2.x' into 2.3.x Closes gh-22960

view details

Phillip Webb

commit sha 3e939cbabdd8f5bcb0b10b802fce91419dff0930

Polish method order

view details

Phillip Webb

commit sha 89a6f83344dc0217cc658cdecfb2357e4c4a370d

Fix and improve SpringApplicationBuilder javadoc Update SpringApplicationBuilder.properties method javadoc to fix inaccuracies and apply more consistency. Closes gh-22962

view details

Phillip Webb

commit sha 1675b47637fa7600be417120c0af4e0d1ffc9aff

Merge branch '2.2.x' into 2.3.x Closes gh-22964

view details

Phillip Webb

commit sha 3271542d980fc5cb40965612eb183036dc135b0b

Add @Interited to @TypeExcludeFilters Update `@TypeExcludeFilters` so that it is also annotated with `@Inherited`. Closes gh-22939

view details

Phillip Webb

commit sha f75e988450402b3827434c3e04545d833247513b

Merge branch '2.2.x' into 2.3.x Closes gh-22966

view details

Stephane Nicoll

commit sha 6b679b7d64957f64268db0318dfbdbf5c2b1f53b

Polish See gh-22945

view details

Stephane Nicoll

commit sha b1e631e8a6d0ec0b109cfaebe07908050387d15c

Remove trailing whitespaces

view details

Jean-Baptiste Nizet

commit sha 27528fdd07494195ce1d69ec016098fdc47688cc

Fix custom image name example and documentation There is no `artifactId` property in a gradle Project, and the default value uses the project name. See gh-22918

view details

Stephane Nicoll

commit sha d452bbbea81b28b8486adf5dc9d871ebcd0fbe78

Merge pull request #22918 from jnizet * pr/22918: Fix custom image name example and documentation Closes gh-22918

view details

push time in a month

more