profile
viewpoint

joshlong/the-spring-rest-stack 350

the deck to my talk on building more powerful REST APIs

odrotbohm/moduliths 316

Building modular, monolithic applications using Spring Boot

joshlong/spring-doge 55

a look at the application development tour-de-force that is Spring Boot

joshlong/javaconfig-ftw 3

Attached to a talk that Phill Webb and I will give at SpringOne2GX 2013 in Santa Clara, California ([Building Your Java Configuration Muscle Memory](https://springone2gx.com/conference/santa_clara/2013/09/springone/event_schedule)).

philwebb/artifactory-resource 1

Artifactory Concouse Resource

issue commentspring-io/spring-javaformat

IndexOutOfBoundsException with latest Eclipse update

This error only happens when Java 14 support is installed.

philwebb

comment created time in 2 hours

issue openedspring-io/spring-javaformat

IndexOutOfBoundsException with latest Eclipse update

java.lang.IndexOutOfBoundsException: Index: 1272, Size: 1272
	at java.util.ArrayList.rangeCheck(ArrayList.java:657)
	at java.util.ArrayList.get(ArrayList.java:433)
	at io.spring.javaformat.formatter.eclipse.TokenManager.get(TokenManager.java:75)
	at io.spring.javaformat.formatter.eclipse.TokenManager.findIndex(TokenManager.java:168)
	at io.spring.javaformat.formatter.eclipse.SpacePreparator.handleToken(SpacePreparator.java:1098)
	at io.spring.javaformat.formatter.eclipse.SpacePreparator.visit(SpacePreparator.java:178)
	at org.eclipse.jdt.core.dom.TypeDeclaration.accept0(TypeDeclaration.java:430)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:2971)
	at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java:3042)
	at org.eclipse.jdt.core.dom.CompilationUnit.accept0(CompilationUnit.java:258)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:2971)
	at io.spring.javaformat.formatter.eclipse.DefaultCodeFormatter.prepareSpaces(DefaultCodeFormatter.java:412)
	at io.spring.javaformat.formatter.eclipse.DefaultCodeFormatter.prepareFormattedCode(DefaultCodeFormatter.java:229)
	at io.spring.javaformat.formatter.eclipse.DefaultCodeFormatter.format(DefaultCodeFormatter.java:186)
	at io.spring.javaformat.formatter.eclipse.DefaultCodeFormatter.format(DefaultCodeFormatter.java:168)
	at io.spring.javaformat.formatter.Formatter.lambda$format$0(Formatter.java:102)
	at io.spring.javaformat.formatter.Formatter.nlsSafe(Formatter.java:149)
	at io.spring.javaformat.formatter.Formatter.format(Formatter.java:101)
	at io.spring.javaformat.eclipse.formatter.SpringCodeFormatter.format(SpringCodeFormatter.java:39)
	at org.eclipse.jdt.internal.corext.util.CodeFormatterUtil.reformat(CodeFormatterUtil.java:291)
	at org.eclipse.jdt.internal.corext.util.CodeFormatterUtil.reformat(CodeFormatterUtil.java:354)
	at org.eclipse.jdt.internal.corext.fix.CodeFormatFix.createCleanUp(CodeFormatFix.java:74)
	at org.eclipse.jdt.internal.ui.fix.CodeFormatCleanUp.createFix(CodeFormatCleanUp.java:64)
	at org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring.calculateChange(CleanUpRefactoring.java:775)
	at org.eclipse.jdt.internal.corext.fix.CleanUpPostSaveListener.saved(CleanUpPostSaveListener.java:388)
	at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider$5.run(CompilationUnitDocumentProvider.java:1650)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
	at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider.notifyPostSaveListeners(CompilationUnitDocumentProvider.java:1644)
	at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider.commitWorkingCopy(CompilationUnitDocumentProvider.java:1424)
	at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider$4.execute(CompilationUnitDocumentProvider.java:1503)
	at org.eclipse.ui.editors.text.TextFileDocumentProvider$DocumentProviderOperation.run(TextFileDocumentProvider.java:133)
	at org.eclipse.ui.actions.WorkspaceModifyDelegatingOperation.execute(WorkspaceModifyDelegatingOperation.java:71)
	at org.eclipse.ui.actions.WorkspaceModifyOperation.lambda$0(WorkspaceModifyOperation.java:110)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:131)
	at org.eclipse.ui.internal.editors.text.WorkspaceOperationRunner.run(WorkspaceOperationRunner.java:76)
	at org.eclipse.ui.internal.editors.text.WorkspaceOperationRunner.run(WorkspaceOperationRunner.java:66)
	at org.eclipse.ui.editors.text.TextFileDocumentProvider.executeOperation(TextFileDocumentProvider.java:461)
	at org.eclipse.ui.editors.text.TextFileDocumentProvider.saveDocument(TextFileDocumentProvider.java:764)
	at org.eclipse.ui.texteditor.AbstractTextEditor.performSave(AbstractTextEditor.java:5052)
	at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.performSave(CompilationUnitEditor.java:1275)
	at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.doSave(CompilationUnitEditor.java:1329)
	at org.eclipse.ui.texteditor.AbstractTextEditor$TextEditorSavable.doSave(AbstractTextEditor.java:7182)
	at org.eclipse.ui.Saveable.doSave(Saveable.java:213)
	at org.eclipse.ui.internal.SaveableHelper.doSaveModel(SaveableHelper.java:333)
	at org.eclipse.ui.internal.SaveableHelper.lambda$1(SaveableHelper.java:196)
	at org.eclipse.ui.internal.SaveableHelper.lambda$3(SaveableHelper.java:271)
	at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:436)
	at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:352)
	at org.eclipse.ui.internal.WorkbenchWindow.lambda$5(WorkbenchWindow.java:2375)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:72)
	at org.eclipse.ui.internal.WorkbenchWindow.run(WorkbenchWindow.java:2373)
	at org.eclipse.ui.internal.SaveableHelper.runProgressMonitorOperation(SaveableHelper.java:278)
	at org.eclipse.ui.internal.SaveableHelper.runProgressMonitorOperation(SaveableHelper.java:260)
	at org.eclipse.ui.internal.SaveableHelper.saveModels(SaveableHelper.java:207)
	at org.eclipse.ui.internal.SaveableHelper.savePart(SaveableHelper.java:150)
	at org.eclipse.ui.internal.WorkbenchPage.saveSaveable(WorkbenchPage.java:3820)
	at org.eclipse.ui.internal.WorkbenchPage.saveEditor(WorkbenchPage.java:3833)
	at org.eclipse.ui.internal.handlers.SaveHandler.execute(SaveHandler.java:57)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:283)
	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:97)
	at sun.reflect.GeneratedMethodAccessor78.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:58)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:318)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:252)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:173)
	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:156)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:488)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:487)
	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.executeCommand(KeyBindingDispatcher.java:308)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.press(KeyBindingDispatcher.java:584)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.processKeyEvent(KeyBindingDispatcher.java:653)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.filterKeySequenceBindings(KeyBindingDispatcher.java:443)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.access$2(KeyBindingDispatcher.java:386)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher$KeyDownFilter.handleEvent(KeyBindingDispatcher.java:96)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1113)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4382)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1512)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1535)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1520)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1549)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1545)
	at org.eclipse.swt.widgets.Canvas.sendKeyEvent(Canvas.java:522)
	at org.eclipse.swt.widgets.Control.doCommandBySelector(Control.java:1081)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:6205)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
	at org.eclipse.swt.internal.cocoa.NSResponder.interpretKeyEvents(NSResponder.java:59)
	at org.eclipse.swt.widgets.Composite.keyDown(Composite.java:606)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:6037)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:235)
	at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:2150)
	at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:2401)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:6157)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:5407)
	at org.eclipse.swt.widgets.Display.applicationProc(Display.java:5543)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
	at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:117)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3788)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1160)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1049)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:658)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:557)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:154)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:150)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:657)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:594)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1447)

created time in 5 hours

pull request commentspring-projects/spring-boot

Switch Cassandra health indicator to use CqlSession

@adutra Those names sound sensible to me. We can always refine them if we think of something better when we merge.

adutra

comment created time in 5 hours

issue commentspring-projects/spring-boot

Need a way to support `fluent` style properties binding

I'm not keen to make JavaBeanBinder public since it's really intended to be a hidden implementation details of the Binder. Even if it were public, there's currently no way of plugging in alternative DataObjectBinders into the Binder. This is an intentional decision as well since the Binder is quite a complicated piece of code and we want to minimize the number of things that could go wrong with it.

Having said that, supporting fluent properties seems like a nice addition. We should look into what it will take to support them natively.

cloorc

comment created time in 5 hours

issue commentspring-projects/spring-boot

Spring boot starter r2dbc - configuration bug

@ndopj Are you able to share a sample project to save us a bit of time building one from the snippets you provided?

ndopj

comment created time in 6 hours

issue commentspring-projects/spring-boot

java.lang.NoClassDefFoundError: org/LatencyUtils/IntervalEstimator in Springboot 2.3.0

Possibly related to #21507. @yuanpli Are you running your tests in IntelliJ?

yuanpli

comment created time in 7 hours

issue commentspring-projects/spring-boot

Maven layers documentation is incomplete

I wasn't sure how we generated it. I was hoping we could link out to the Javadoc of the class

philwebb

comment created time in 7 hours

issue openedspring-projects/spring-boot

Publish maven/gradle refernce under htmlsingle

For consistency we should really publish under htmlsingle rather than html.

created time in 7 hours

issue commentspring-projects/spring-boot

Provide better error message if Docker is not running

This is related to #21515

philwebb

comment created time in 7 hours

issue commentspring-projects/spring-boot

@DependsOn on method which produce object of class which extend BeanDefinitionRegistryPostProcessor breaks @ConfigurationProperties on method

I've just drafted an answer to your stackoverflow question. I think this is expected behavior since you're trigger early initialization of beanUser via your ClassExtendsBeanDefinitionRegistryPostProcessor.

Bittuw

comment created time in 7 hours

issue closedspring-projects/spring-boot

@DependsOn on method which produce object of class which extend BeanDefinitionRegistryPostProcessor breaks @ConfigurationProperties on method

Stack Overflow question.

I think this is unexpected behavior than @DependsOn chain of ClassExtendsBeanDefinitionRegistryPostProcessor to BeanProperties breaks binding to properties. My sample classes:

@Configuration
class BeanPropertiesConfiguration {

    @Bean("beanProperties")
    @ConfigurationProperties("some.path")
    public BeanProperties basicAuthProperties() {
        return new BeanProperties();
    }
}

@Configuration
class TargetConfiguration {

    @Bean("someBeanUser")
    protected BeanUser beanUser(
            @NonNull  @Qualifier("beanProperties") BeanProperties beanProperties)
    {
        return new BeanUser(beanProperties);
    }

    @Scope(ConfigurableBeanFactory.SCOPE_SINGLETON)
    @Bean("someBeanGenerator")
    //@DependsOn("someOtherBeanUser")  // Uncomment to break
    public ClassExtendsBeanDefinitionRegistryPostProcessor beanGenerator() {
        return new ClassExtendsBeanDefinitionRegistryPostProcessor();
    }

    @Bean("someOtherBeanUser")
    @Scope(ConfigurableBeanFactory.SCOPE_SINGLETON)
    public OtherBeanUser otherBeanUser(@NonNull BeanUser beanUser) {
        return new OtherBeanUser(beanUser);
    }
}

I did't try to start up full context, but for tests with @ContextCofiguration and @ExtendWith(SpringExtension.class), beanProperties object contains null fields. (2.2.6 spring-boot release from maven repo)

closed time in 7 hours

Bittuw

issue commentspring-projects/spring-boot

@DependsOn on method which produce object of class which extend BeanDefinitionRegistryPostProcessor breaks @ConfigurationProperties on method

As mentioned in the guidelines for contributing, we prefer to use GitHub issues only for bugs and enhancements. Since you've already asked this question on stack overflow, let's keep the discussion there.

Bittuw

comment created time in 7 hours

pull request commentspring-projects/spring-boot

Auto-configure Spring Security SessionRegistry

@candrews This one has been flagged for team attention so that we discuss it on one of our calls.

I'm personally not too keen on the lazy bean idea, it's not that common for auto-configurations. In this instant, it would be nice if we could configure SessionManagementConfigurer so that the sessionRegistry must be provided. It feels like the confusion is caused by the fact that getSessionRegistry creates the SessionRegistryImpl for you. If it actually failed and made you configure something, at least you'd be making a conscious choice.

candrews

comment created time in 10 hours

issue closedspring-projects/spring-boot

Lettuce adaptive refresh not working

I am using spring latest version 2.3.1 and lettuce adaptive refresh is not working for me.

I am using 1 Master 2 Slave and 2 sentinel node, i have deployed the application in docker containers, in AWS ec2 ubuntu instance.

When master node dies then i am getting connection time out

io.lettuce.core.RedisCommandTimeoutException: Command timed out after 1 minute(s)
        at io.lettuce.core.ExceptionFactory.createTimeoutException(ExceptionFactory.java:51) ~[lettuce-core-5.3.0.RELEASE.jar!/:5.3.0.RELEASE]
        at io.lettuce.core.protocol.CommandExpiryWriter.lambda$potentiallyExpire$0(CommandExpiryWriter.java:167) ~[lettuce-core-5.3.0.RELEASE.jar!/:5.3.0.RELEASE]
        at io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98) ~[netty-common-4.1.49.Final.jar!/:4.1.49.Final]
        at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:170) ~[netty-common-4.1.49.Final.jar!/:4.1.49.Final]
        at io.netty.util.concurrent.DefaultEventExecutor.run(DefaultEventExecutor.java:66) ~[netty-common-4.1.49.Final.jar!/:4.1.49.Final]
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) ~[netty-common-4.1.49.Final.jar!/:4.1.49.Final]
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.49.Final.jar!/:4.1.49.Final]
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[netty-common-4.1.49.Final.jar!/:4.1.49.Final]
        at java.lang.Thread.run(Thread.java:745) [na:1.8.0_111]

here is the application.yaml file configuration for redis

cache:
    type: redis  
    redis:
      cache-null-values: false
      time-to-live: 100000
      use-key-prefix: true
      
  redis:
    sentinel:
      master: mymaster
      nodes:
        - redis-sentinel:26379
        - redis-sentinel-1:26380
    timeout: 10s
        
        
    lettuce:
      pool:
        max-idle: -1
        max-active: -1
        max-wait: 2s
      cluster:
        refresh:
          adaptive: true
          period: 5s   

closed time in 10 hours

kuldeepsingh99

issue commentspring-projects/spring-boot

Lettuce adaptive refresh not working

Thanks for the report, but I think this is likely to be an issue with the Lettuce driver rather than something in Spring Boot's control. Please raise an issue with the Lettuce team here.

kuldeepsingh99

comment created time in 10 hours

issue commentspring-projects/spring-boot

Consider making StringToPeriodConverter final and package protected

I missed that conversation, is there more context for why the override was required?

snicoll

comment created time in 10 hours

issue commentspring-projects/spring-boot

Creating Image using BuildPacks - Spring Boot 2.3.0

I've opened #21582 to add some documentation to Spring Boot. I must admit, I was a bit confused about the meaning of "Contributes $JAVA_HOME configured to the layer" in the existing Paketo documentation.

arpan2501

comment created time in 11 hours

issue openedspring-projects/spring-boot

Document how JAVA_OPTS can be used with the buildpack

See https://github.com/spring-projects/spring-boot/issues/21483#issuecomment-634170647

created time in 11 hours

issue commentspring-projects/spring-boot

Consider making StringToPeriodConverter final and package protected

If our converter is not a straightforward call, we should consider...

My feeling is that the converters are generally not designed to be subclasses or extended so we should keep them package private and not offer any public API. At least, not until someone specifically asks us to.

snicoll

comment created time in 12 hours

issue commentspring-projects/spring-boot

Consider making StringToPeriodConverter final and package protected

I think for now we should risk making this one package private in 2.3.1. The chances of anyone extending it yet are pretty slim.

snicoll

comment created time in 13 hours

issue commentspring-projects/spring-boot

Creating Image using BuildPacks - Spring Boot 2.3.0

@arpan2501 I know the older buildpack used to support JAVA_OPTS but I can't find documentation for the new one.

Perhaps @nebhale can help.

arpan2501

comment created time in a day

issue commentspring-projects/spring-boot

NPE when shutting down long running web request

Ahh, I remember now. We've seen this before in #16407.

philwebb

comment created time in a day

issue commentspring-projects/spring-boot

Add a note for the moved Elasticsearch auto configuration and RestClientCustomizer in the release notes

Sorry about that, we'll update the docs. I've also opened #21572 to see if we can't reintroduce it in a deprecated form.

filiphr

comment created time in a day

issue commentspring-projects/spring-boot

Possible typo WebClient docs

Good spot! Thanks for reporting the issue.

fadelgaber

comment created time in a day

issue commentspring-projects/spring-boot

Unable to have custom RequestMappingHandlerMapping

@michaelkrog Thanks, I've spun out #21571. We can continue the discussion there since this issue is getting quite long.

wwadge

comment created time in a day

issue openedspring-projects/spring-boot

Custom registrations with Spring Boot 2.x

Continuing the discussion from #5004

@michaelkrog Could you create a new issue with a sample project showing the problem


Sure.. https://github.com/michaelkrog/spring-boot-webmvc-versioning-demo

Maybe there is a better way to do this, that I don't know of. But what I am trying to do is to add multiple (versioned) controllers with same RequestMapping. Only difference between them is a custom annotation that via a Semver range defines what api-version it belongs to.

ControllerV1_0: https://github.com/michaelkrog/spring-boot-webmvc-versioning-demo/blob/master/src/main/java/com/example/demo/ControllerV1_0.java

ControllerV1_1: https://github.com/michaelkrog/spring-boot-webmvc-versioning-demo/blob/master/src/main/java/com/example/demo/ControllerV1_1.java

ApiRequestMapping (Custom RequestMappingHandlerMapping): https://github.com/michaelkrog/spring-boot-webmvc-versioning-demo/blob/master/src/main/java/com/example/demo/ApiVersionedRequestMapping.java

I can choose the version I want served via Api-Version header fx. curl http://server/version -H 'Api-Version:1.0.0' (ControllerV1_0) curl http://server/version -H 'Api-Version:1.1.0' (ControllerV1_1)

If I register my Custom RequestMappingHandlerMapping via WebRegistrations, then I get a second RequestMappingHandlerMapping instantiated, and the first one created by DelegatingWebMvcConfiguration will complain that my RequestMapping's are ambiguous, because it doesnt know about my custom RequestCondition.

created time in a day

issue commentspring-projects/spring-boot

DevelopmentOnly configuration not picking up devtools version info from Gradle Java Platform

@asaikali Do you have a sample project that we can use to save us trying to recreate something from the snippets?

asaikali

comment created time in a day

issue commentspring-projects/spring-boot

Document how to use Gradle Java Platform Plugin as an alternative to the spring boot dependency plugin

We should also add a smoke test if it's brittle.

asaikali

comment created time in a day

issue openedspring-projects/spring-boot

NPE when shutting down long running web request

To reproduce add a Thread.sleep to a MVC+Actuator app then force close it from the command line.

java.lang.NullPointerException: null
	at org.springframework.boot.actuate.metrics.web.servlet.LongTaskTimingHandlerInterceptor.stopLongTaskTimers(LongTaskTimingHandlerInterceptor.java:123) ~[spring-boot-actuator-2.3.0.RELEASE.jar!/:2.3.0.RELEASE]
	at org.springframework.boot.actuate.metrics.web.servlet.LongTaskTimingHandlerInterceptor.afterCompletion(LongTaskTimingHandlerInterceptor.java:79) ~[spring-boot-actuator-2.3.0.RELEASE.jar!/:2.3.0.RELEASE]
	at org.springframework.web.servlet.HandlerExecutionChain.triggerAfterCompletion(HandlerExecutionChain.java:179) ~[spring-webmvc-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.servlet.DispatcherServlet.triggerAfterCompletion(DispatcherServlet.java:1427) ~[spring-webmvc-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1060) ~[spring-webmvc-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:943) ~[spring-webmvc-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006) ~[spring-webmvc-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:898) ~[spring-webmvc-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:634) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883) ~[spring-webmvc-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:741) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) ~[tomcat-embed-websocket-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100) ~[spring-web-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93) ~[spring-web-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:93) ~[spring-boot-actuator-2.3.0.RELEASE.jar!/:2.3.0.RELEASE]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201) ~[spring-web-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:541) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:373) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1590) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) ~[na:na]
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) ~[na:na]
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) ~[tomcat-embed-core-9.0.35.jar!/:9.0.35]
	at java.base/java.lang.Thread.run(Thread.java:832) ~[na:na]

created time in 2 days

issue openedspring-projects/spring-boot

Maven plugin help is missing

We used to publish META-INF/maven/org.springframework.boot/spring-boot-maven-plugin/plugin-help.xml (Generated by maven-plugin-tools 3.6). It's missing since we switched to Gradle.

created time in 2 days

issue openedspring-projects/spring-boot

Maven layers documentation is incomplete

The following isn't really that helpful:

https://docs.spring.io/spring-boot/docs/current/maven-plugin/reference/html/#goals-build-image-parameters-details-layers

We could also do with a link from "Building OCI Images" to "Layered Jars" since it's hidden in the ToC.

created time in 2 days

issue openedspring-projects/spring-boot

Provide better error message if Docker is not running

The current error message could be improved

$ mvn spring-boot:build-image

...
Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.0.RELEASE:build-image failed: Docker API call to 'localhost/v1.24/images/create?fromImage=gcr.io%2Fpaketo-buildpacks%2Fbuilder%3Abase-platform-api-0.3' failed with status code 500 "com.sun.jna.LastErrorException: [2] No such file or directory"

created time in 2 days

issue openedspring-projects/spring-boot

Print the java version being used on startup

The frequency of JDK releases would make this useful information to have.

created time in 2 days

issue commentspring-projects/spring-boot

ValidationBindHandler with @ConfigurationProperties

@gituserjava No need to @ mention us, we're already subscribed to this tracker.

gituserjava

comment created time in 3 days

push eventphilwebb/spring-data-commons

Oliver Gierke

commit sha 38a41139fcd08546e8ae528a22ee35614a085ba6

DATACMNS-809 - Polishing. Removed DefaultPersistentPropertyAccessorFactory as it only delegates to the class generating one. Tweaked AbstractMappingContext to actually use the latter in the first place. Introduced BeanWrapperPropertyAccessorFactory to implement the default behavior of using a BeanWrapper and initialize BasicPersistentEntity to avoid a null clause in getPersistentPropertyAccessor(…). Removed getPersistentPropertyAccessorFactory and rather rely on ReflectionTestUtils in tests to avoid additional API being exposed. Original pull request: #159.

view details

John Blum

commit sha 08e8f158450fcb659f9acc31701e4c07696756d6

DATACMNS-853 - Added test case reproducing the issue. Reproduce issue accessing persistent properties from interface-based entities using the ClassGeneratingPropertyAccessorFactory. Related tickets: DATACMNS-809. Original pull request: #161. Related pull request: #160.

view details

Mark Paluch

commit sha db5259292cb38977b08cab208dcebbab93a1469c

DATACMNS-853 - Support interface entity types using generated property accessors. Property accessors (getter and setter) defined on an interface require a different instruction opcode for invoking methods. We now distinguish whether a property accessor is defined on an interface and use either INVOKEINTERFACE or INVOKEVIRTUAL otherwise. Related tickets: DATACMNS-809. Original pull request: #161. Related pull request: #160.

view details

Oliver Gierke

commit sha f29cbf5752fb455399486ff5d217d7a155c710ec

DATACMNS-853 - Polishing. Simplified test case. Formatting in ClassGeneratingPropertyAccessorFactory. Related tickets: DATACMNS-809. Original pull request: #161. Related pull request: #160.

view details

Oliver Gierke

commit sha 9db6278e7775335535cca97506bee605fde13746

DATACMNS-855 - Prevent memory leak in SyntheticParameterizedType. Added proper equals(…) and hashCode() methods to SyntheticParameterizedType to make sure instances created for the same type information and type parameters are considered equal.

view details

Oliver Gierke

commit sha fa7ab50c5fd3cb6d84ab25771f26925a4a806645

DATACMNS-855 - Fixed generic type lookup in SyntheticParamterizedType. The translation of the list of actual type parameters into an array now uses the loop index correctly. Previously, it always used the first type parameter.

view details

Oliver Gierke

commit sha c51f55346faf09e6ceedd6f3a2287bb63e50f5ce

DATACMNS-858 - Fixed JavaDoc for CrudMethods.getDeleteMethod(). We're now correctly stating that we're preferring the delete method that takes the entity as argument over the one taking the id to match what's actually implemented.

view details

Oliver Gierke

commit sha 87566df432b7eda166bac4a7cd66bcdf63268a0d

DATACMNS-858 - Polishing. Some JavaDoc and formatting.

view details

Terje Strand

commit sha e0fc7deb053fb94d87bba1a8df88359f09820aeb

DATACMNS-854 - Allow custom implementation of repository methods with generics. Add additional check for detecting customized method where method contains generics. Overriding methods without generics already works, this patch simply makes the behavior consistent. Original pull request: #162.

view details

Oliver Gierke

commit sha 3a36ed55dd0c35733f7af20fd89b7a1181b79d6b

DATACMNS-854 - Polishing. Simplified conditional expressions in DefaultRepositoryInformation. Reordered test method to reflect natural order of adding. Original pull request: #162.

view details

Oliver Gierke

commit sha bdc61a044f70165e149201b4c70c649d9403cf89

DATACMNS-859, DATACMNS-860 - Improvements to ResourceProcessor. ResourceProcessor supports Streams now and adds a map(…) step to apply projections. Also, the ProjectingConverter falls back to use a default ConversionService instance to make use of the object mapping functionality implemented in ObjectToObjectConverter, i.e. the ability to just map an object returned from the store to a DTO in case that latter exposes a constructor or factory methods taking the source instance as parameter. Related tickets: DATAJPA-903.

view details

Oliver Gierke

commit sha 1bedfe4f4a09722548ccf925767b75f1dc1816bf

DATACMNS-856, DATACMNS-685 - Made ToEntityConverter.matches(…) less offensive. ToEntityConverter.matches(…) now doesn't throw an exception anymore as it might be picked up by classpath scanning an the exception previously thrown causing the entire conversion attempt to abort. We're now rather inspecting the ToEntityConverter in case the target type is a repository managed one and the ToIdConverter otherwise.

view details

Mikael Klamra

commit sha 046f0408d168e300556e4c3450849afcdae96356

DATACMNS-831 - AbstractMappingContext.addPersistentEntity(…) now acquires necessary read lock. The lookup for already available PersistentEntity instances now acquires a read lock to shield the execution from partially equipped PersistentEntity instances currently in creation from another thread. Original pull request: #157.

view details

Oliver Gierke

commit sha 5b5daaf39764373a5b0e2c0d54796785b5a1427b

DATACMNS-831 - Polishing. Formatting. Fixed copyright header and author. Added missing assertions in AbstractMappingContext.addPersistentEntity(…). Original pull request: #157.

view details

Oliver Gierke

commit sha e414cd6801a83e76b987db3cc78a882558a44e7b

DATACMNS-862 - ReturnedInterface now considers interfaces implemented by the domain type. We now check whether the interface return type is implemented by the domain type and opt out of all projection efforts if so.

view details

Oliver Gierke

commit sha 65bfd5b33a35e6619398e59571fb01bc1404900b

DATACMNS-743 - Optimizations in TypeDiscoverer getProperty(…) in case if invalid property names. We now also cache a failed property lookup so that we can return null on a subsequent call for the same invalid property name right away and don't have to reattempt the lookup unnecessarily.

view details

Oliver Gierke

commit sha 241d18a2127ade4b66d11f75f50e50b717270f61

DATACMNS-863 - Fixed parameter type lookup for wrapper types. When repository parameters use wrapper types (e.g. Optional) the Parameter instance for that parameter now returns the component type.

view details

Oliver Gierke

commit sha d4c0aa70ba8129d9d57f0306aaa48324cf729210

DATACMNS-866 - Improved error message in invalid invocations of BasicPersistentEntity.getPropertyAccessor(…). We now explicitly report the given object's type and the one expected in case of a mismatch when BasicPersistentEntity.getPropertyAccessor(…) is invoked.

view details

John Blum

commit sha 1d880f2e08c89200919c25344549d78936e897f9

DATACMNS-868 - Assert JDK 6 compatibility in ResultProcessor. Turned the previously anonymous inner class that applies result processing to a JDK 8 Stream into a dedicated inner class to avoid JDK types being loaded on older JDKs. The previous way was causing issues due to the JVM trying to resolve the Function interface when loading the ResultProcessor class. Original pull request: #163.

view details

Pascal Grün

commit sha ce2e788374aa493a171a69ccdaf5e9abaad2020f

DATACMNS-869 - Fix Javadoc for parametric types of Pair. Original pull request: #164.

view details

push time in 3 days

push eventphilwebb/spring-data-commons

Phillip Webb

commit sha 6d384faf98fa0c2591287c2dd1cf3a31cd0d569f

Drop @soundtrack comments Using regex \ \*\ @soundtrack.*\n

view details

Phillip Webb

commit sha a0d4aaf56308c16a3d9158a7083a592da4dc83be

Remove (non-Javadoc) comments Using regex: \s*/\*\s*\* \(non-Javadoc\)\s*\* @see \S+\s*\*/

view details

Phillip Webb

commit sha f871d9bc8545667f79a5c8c81ae664c6025358b7

Rename LOGGER to logger Search and replace because loggers are static final but not a CONST

view details

Phillip Webb

commit sha 12ac3bc38bfbf5129bb559d2323d0f0648dc8b03

Don't use `___` as variable name

view details

Phillip Webb

commit sha e44a76d6fd38c54b3709d010b8a0000e78f34101

Use method references in favor of lambdas Mostly found with eclipse cleanup action

view details

Phillip Webb

commit sha 213da8ef2956505906808035c21492885da482e4

Use this for field access Applied with cleanup action.

view details

Phillip Webb

commit sha 8d58fb426a9a9e7534b53fa82272914714c3f0af

Format POM file

view details

Phillip Webb

commit sha c2ca851475c89db0a5c0db889654871ac3f6e4de

Add spring-javaformat plugin

view details

Phillip Webb

commit sha dc9ece278acd3874057b4759542a10030ab951b1

Add generates source folder to Eclipse

view details

Phillip Webb

commit sha e51bbb6122b18e959dc832ed9e3c5a7d2d2ea835

Format source code

view details

Phillip Webb

commit sha 2729140f4e29872052efd7f0f5707dc0a1dc0be8

Organize imports

view details

Phillip Webb

commit sha 2cd8cd70b8b47afbdc1c2d32d75ff6a33568e738

Apply source cleanup from spring-javaformat eclipse plugin

view details

Phillip Webb

commit sha 6c23a2143b46b470e13c14fce4576b2d34673ab4

Remove whitespace inside methods Manually update the code to remove all whitespace inside the methods to help with visual scanning of code.

view details

Phillip Webb

commit sha 4157ea9cee8989dbfd556e15bebfd062b077fd58

Remove remaining non-Javadoc comments Search for 'non-Javadoc' and manually remove the comments.

view details

Phillip Webb

commit sha 3792da42491cbc9334700652fceebe45d2edd2c7

Remove trailing "//" Search for regex '//$' and replace with nothing.

view details

Phillip Webb

commit sha 3e16ebb684dc1ad7c129a6fd4cc6d94dea6c8fa4

Reformat code

view details

Phillip Webb

commit sha 39a0971b2bff22b6f27c4209d37b54e5f20c5958

Only use @Author tag on top level classes Search for '@Author' and manually find those with higher line numbers.

view details

Phillip Webb

commit sha 1779b7f9b91d1a70fc454f317a4e7e0b4ac08ced

Use camelCase for static caches Search for "CACHE" and rename variables to be camel case. Although the value are "static final" they are not constants.

view details

Phillip Webb

commit sha a0354b136c07995e81eae488095cc334c97c036d

Rename LOG to logger Rename all `LOG` static finals to `logger` for consistency with Spring Framework.

view details

Phillip Webb

commit sha a2bf09f50ab1bcf73b51f8c12cbf574f6c0536d2

Consistently use commons logging Replace SLF4J with commons logging.

view details

push time in 5 days

push eventphilwebb/spring-data-commons

Mark Paluch

commit sha 7db7e1b19ac14bc4230305da7ed38a53ad0c9bfc

DATACMNS-1730 - Update releasetrain reference documentation with spring-data-bom artifact.

view details

Phillip Webb

commit sha 71b1d67aab2c794859726dda833f0633e5c71a4c

Drop @soundtrack comments Using regex \ \*\ @soundtrack.*\n

view details

Phillip Webb

commit sha 3675c414ce9392212aa986c8d2af885918bd85be

Remove (non-Javadoc) comments Using regex: \s*/\*\s*\* \(non-Javadoc\)\s*\* @see \S+\s*\*/

view details

Phillip Webb

commit sha 809ed46fb3020382df0530a7588fdf40656676a2

Rename LOGGER to logger Search and replace because loggers are static final but not a CONST

view details

Phillip Webb

commit sha 7aa643d02e9a3c47cf84fe09f786e3f97f64dcca

Don't use `___` as variable name

view details

Phillip Webb

commit sha 3ab8342a81d1bcec2bf4865b984ad3adaec3d652

Use method references in favor of lambdas Mostly found with eclipse cleanup action

view details

Phillip Webb

commit sha 3eff5675a75cc13c63eacc681b555a21bb932feb

Use this for field access Applied with cleanup action.

view details

Phillip Webb

commit sha f3ba49de024ffc388a82617c828f33af3668254f

Format POM file

view details

Phillip Webb

commit sha 7d24ac56d984d383784f80dca796f95f2b244b95

Add spring-javaformat plugin

view details

Phillip Webb

commit sha 80c7e43aa7fb549ff196c9acca590fb5615517a4

Add generates source folder to Eclipse

view details

Phillip Webb

commit sha dc7e36a2000a9ec721c19600780c0055bf0e5c09

Format source code

view details

Phillip Webb

commit sha 5a795e8f46a643c7abd0101fadb73aea8c04fae7

Organize imports

view details

Phillip Webb

commit sha 5f2daf49fe99744dd85fa98ecfeedfc18cbccf7b

Apply source cleanup from spring-javaformat eclipse plugin

view details

Phillip Webb

commit sha be20aedc91f187efebf2f9490f60dfa2f5b23def

Remove whitespace inside methods Manually update the code to remove all whitespace inside the methods to help with visual scanning of code.

view details

Phillip Webb

commit sha 62d7580fb6860ee1d559f8effac62328b992e36d

Remove remaining non-Javadoc comments Search for 'non-Javadoc' and manually remove the comments.

view details

Phillip Webb

commit sha 826427049d11e2e1bc01e7fe06e7f8f0cccade80

Remove trailing "//" Search for regex '//$' and replace with nothing.

view details

Phillip Webb

commit sha fcf8d0f8ed484ceaad2e0521da47cc7d47f1ab58

Reformat code

view details

Phillip Webb

commit sha 12bc799bb7eb993d4a2295b1bbce9cff531e5e2e

Only use @Author tag on top level classes Search for '@Author' and manually find those with higher line numbers.

view details

Phillip Webb

commit sha 40aef49aa94612317f0a8695b505ef71c4b4da4f

Use camelCase for static caches Search for "CACHE" and rename variables to be camel case. Although the value are "static final" they are not constants.

view details

Phillip Webb

commit sha bad705231c83af3a40c6b72936c781b5d984f420

Rename LOG to logger Rename all `LOG` static finals to `logger` for consistency with Spring Framework.

view details

push time in 5 days

push eventphilwebb/spring-data-commons

Phillip Webb

commit sha cf21591e72a3190bcfd1c57101fb6e1cfe835850

Format POM file

view details

Phillip Webb

commit sha c249fbf25b54f56459d76109ab1d9f124c797d84

Add spring-javaformat plugin

view details

Phillip Webb

commit sha b89ac62dd89d2d8681a6dd3a2e0246cb1f4c8241

Add generates source folder to Eclipse

view details

Phillip Webb

commit sha 11671aa79b3abf12cee687e7fa9966311b78a856

Format source code

view details

Phillip Webb

commit sha 142e8d5991020f972f38e0ada7c948401dbdd448

Organize imports

view details

Phillip Webb

commit sha 9b748ab12abc5d7deb5d15f64ad5e549c50ab083

Apply source cleanup from spring-javaformat eclipse plugin

view details

Phillip Webb

commit sha 8abc4387302ed938eca4627e7267529d54299fea

Remove whitespace inside methods Manually update the code to remove all whitespace inside the methods to help with visual scanning of code.

view details

Phillip Webb

commit sha dc08401f5b8dfb1d5f5d103e6646509512481e78

Remove remaining non-Javadoc comments Search for 'non-Javadoc' and manually remove the comments.

view details

Phillip Webb

commit sha 0b419324a9876da883efc6ef05a93b82f4084e6e

Remove trailing "//" Search for regex '//$' and replace with nothing.

view details

Phillip Webb

commit sha d8166018ae3239de6fd615458a030b087c439f67

Reformat code

view details

Phillip Webb

commit sha 56d5b901f64f4bfb4977516370e8bfa44e97c31a

Only use @Author tag on top level classes Search for '@Author' and manually find those with higher line numbers.

view details

Phillip Webb

commit sha 920c705052c8ca417d78b14e46593626a33f9bfb

Use camelCase for static caches Search for "CACHE" and rename variables to be camel case. Although the value are "static final" they are not constants.

view details

Phillip Webb

commit sha d3bef934a252f0f08a6d867d54b3e9582894e54d

Rename LOG to logger Rename all `LOG` static finals to `logger` for consistency with Spring Framework.

view details

Phillip Webb

commit sha 1fe7aee6cc9974f08ffb395b4c91b8f488f6b20a

Consistently use commons logging Replace SLF4J with commons logging.

view details

Phillip Webb

commit sha 6d5dd9c28977b2e1428a89e07c55229927c7d251

Replace '…' with '...' Use the longer form version of '…' to prevent possible rendering issues.

view details

Phillip Webb

commit sha f32cb5a42af01c10833602168350b2f4dbbf8e94

Inline some log messages Inline constants used for log message.

view details

Phillip Webb

commit sha 9e0e54ced63574e6156da16f3533074ae1b07ab7

Replace 'that' with 'other' Update code to use "other" rather than "that" for equals and compareTo methods.

view details

Phillip Webb

commit sha 93e5b183b9f07765005a41aeb28a038b19256218

Drop Java 8 check

view details

Phillip Webb

commit sha b3ae7534164a6802db56465fe950a43b2e795562

Replace anonymous class with static initializer

view details

Phillip Webb

commit sha 065ed379c2249baa468dc238a3604ccc9e454846

Import `Function` and use short-form in code

view details

push time in 5 days

issue openedspring-io/spring-javaformat

Ensure whitespace after header

created time in 6 days

issue commentspring-projects/spring-boot

Support for read-only docker containers

We discussed this issue on our weekly call today and have decided to open #21519 to look into our own use of temporary files. We don't think we can guarantee that all applications can run in an immutable container, but we can review our own code to make sure we're not making things worse.

osiegmar

comment created time in 7 days

issue openedspring-projects/spring-boot

Review use of File.createTempFile

See #8578 for background

We currently have a few places in Spring Boot where we create temporary folders without the ability to opt-out. We should review these for users that wish to create immutable containers.

We can't make any guarantees that it will always possible to run an immutable container, we can only ensure that Spring Boot itself can run without creating temporary files. For example, we could update UndertowServletWebServerFactory so that it doesn't call deployment.setTempDir, but we can't guarantee that DeploymentInfo.requireTempPath() isn't called when the container runs (e.g. because of multi-part uploads).

created time in 7 days

push eventphilwebb/spring-data-commons

Phillip Webb

commit sha f76df89cfb01e51c74bed847343d062d980de56b

Remove whitespace inside methods Manually update the code to remove all whitespace inside the methods to help with visual scanning of code.

view details

Phillip Webb

commit sha 0cde97f214ef817975231afca90ebf95586c2190

Remove remaining non-Javadoc comments Search for 'non-Javadoc' and manually remove the comments.

view details

Phillip Webb

commit sha dbb44a1aab2d82142a04b80f6f70c7e92e0b70c7

Remove trailing "//" Search for regex '//$' and replace with nothing.

view details

Phillip Webb

commit sha 7e79b06d4eeb1fee4596deb121c505b27524e24b

Reformat code

view details

Phillip Webb

commit sha cfa47ba217cc5d240b621a2c86f47b539b9505c1

Only use @Author tag on top level classes Search for '@Author' and manually find those with higher line numbers.

view details

Phillip Webb

commit sha 18ac421c688ed15bd858d59aeeecd9bde6599892

Use camelCase for static caches Search for "CACHE" and rename variables to be camel case. Although the value are "static final" they are not constants.

view details

Phillip Webb

commit sha e09e4db9c9bb9f1aafdef363236dca473328fd95

Rename LOG to logger Rename all `LOG` static finals to `logger` for consistency with Spring Framework.

view details

Phillip Webb

commit sha 702825189f3be92081177e4b186dbe6e116c74d0

Consistently use commons logging Replace SLF4J with commons logging.

view details

Phillip Webb

commit sha 5fbe330c0c592da188a223522433193385627d76

Replace '…' with '...' Use the longer form version of '…' to prevent possible rendering issues.

view details

Phillip Webb

commit sha 9940de87c541927e5e49c83c4cf37f3648559aa1

Inline some log messages Inline constants used for log message.

view details

Phillip Webb

commit sha e507d7c64f9686833ebd6dc5cc174b531f880e80

Replace 'that' with 'other' Update code to use "other" rather than "that" for equals and compareTo methods.

view details

Phillip Webb

commit sha d7db70e278154da5d05dc6a1f719a1f7a6845b19

Drop Java 8 check

view details

Phillip Webb

commit sha c4a9cc38b1bc60596c11c4e3b9a168f002bcdb01

Replace anonymous class with static initializer

view details

Phillip Webb

commit sha 121cc6281f8ab9a999408f64b44812f3f97061aa

Import `Function` and use short-form in code

view details

Phillip Webb

commit sha 73a6c22ce48283f3d6e44bd3291342c435332477

Move field annotations Change field annotations so that they are on the line above the field.

view details

Phillip Webb

commit sha afb7b169dde0afff7ec7a2e1f7687fb3a362debf

Remove whitespace inside test methods Manually update the code to remove all whitespace inside test methods to help with visual scanning of code.

view details

Phillip Webb

commit sha 97ffb62eb009790961f4238585e6f77a106c24c5

Don't abuse '@see' tags

view details

Phillip Webb

commit sha 3d3f2e41bb965001bbb111bc224996c180a98715

Add checkstyle in ignored form

view details

Phillip Webb

commit sha dc731043cf87449f55f17ba18f8a23b804eeff63

Bump to snapshot

view details

Phillip Webb

commit sha ee9fb6ff3a084a6dc642a6621e2be8b05f5d4223

Fixup exceptions

view details

push time in 7 days

push eventspring-io/spring-javaformat

Phillip Webb

commit sha 620c58ca52c80d9f6a6ff30e682cdec282b4542c

Allow static import of HamcrestCondition Closes gh-193

view details

push time in 7 days

push eventphilwebb/spring-data-commons

Phillip Webb

commit sha 39cd31e757d3bc28852c85daa9911e9a7680dfed

Add generates source folder to Eclipse

view details

Phillip Webb

commit sha 5ba13272344632748f5c891421d4f988c22dff34

Format source code

view details

Phillip Webb

commit sha 7b3b67dbd403054458cb17550f1005f5637a4cc6

Organize imports

view details

Phillip Webb

commit sha f60b0619c948b229e96902c89e0fc715ce986c10

Apply source cleanup from spring-javaformat eclipse plugin

view details

Phillip Webb

commit sha 1554d645ba277eaeeef3ff8790adb358bd920e20

Remove whitespace inside methods Manually update the code to remove all whitespace inside the methods to help with visual scanning of code.

view details

Phillip Webb

commit sha 40e216d13350552d20d12868af0ab4bd250382a4

Remove remaining non-Javadoc comments Search for 'non-Javadoc' and manually remove the comments.

view details

Phillip Webb

commit sha 9c5b7d2f378ace96a63d2cec9449e1ef403d3c9a

Remove trailing "//" Search for regex '//$' and replace with nothing.

view details

Phillip Webb

commit sha 2260aab46e35a89014858dcddb48084dc954d328

Reformat code

view details

Phillip Webb

commit sha 3cad21e393413e086176a25a31bbf81858a0b336

Only use @Author tag on top level classes Search for '@Author' and manually find those with higher line numbers.

view details

Phillip Webb

commit sha 927adc6eca81cc1aa6f1091c9e907e1306180bc2

Use camelCase for static caches Search for "CACHE" and rename variables to be camel case. Although the value are "static final" they are not constants.

view details

Phillip Webb

commit sha 35e735047766123e84d6215153abe77547dbb5dd

Rename LOG to logger Rename all `LOG` static finals to `logger` for consistency with Spring Framework.

view details

Phillip Webb

commit sha 66de7ed20c8c2a6cdaf214ae50d32515a6089341

Consistently use commons logging Replace SLF4J with commons logging.

view details

Phillip Webb

commit sha e34792a763b3b4e8fda906f27809b3ef95174cf1

Replace '…' with '...' Use the longer form version of '…' to prevent possible rendering issues.

view details

Phillip Webb

commit sha e13f68d64974d2481bc89ded5198cd835bef2fb6

Inline some log messages Inline constants used for log message.

view details

Phillip Webb

commit sha f23a44fb0873f4d8a41189e78d47a1ee840ff38a

Replace 'that' with 'other' Update code to use "other" rather than "that" for equals and compareTo methods.

view details

Phillip Webb

commit sha 593e36175a50fd8f84d31f60028c11ef66751523

Drop Java 8 check

view details

Phillip Webb

commit sha f0ffaec487a8054fe1ac4b098ec66386d7c32802

Replace anonymous class with static initializer

view details

Phillip Webb

commit sha cf7752e5d4ecb5efbde199885d0c4fa32a491151

Import `Function` and use short-form in code

view details

Phillip Webb

commit sha f8758e4c5ca06ea6dbf1f28591a5656b57ac396b

Move field annotations Change field annotations so that they are on the line above the field.

view details

Phillip Webb

commit sha 28d40252f7e9a2fe3595bc2be2c3b713bd9055c8

Remove whitespace inside test methods Manually update the code to remove all whitespace inside test methods to help with visual scanning of code.

view details

push time in 7 days

push eventspring-io/spring-javaformat

Phillip Webb

commit sha 41dbc79fb967da76bd786c69677acfbd99450e0a

Allow AssertJ assumptions static import Closes gh-192

view details

push time in 7 days

issue commentspring-io/spring-javaformat

Ban lombok imports

I've not implemented the check yet, but it will be easy to suppress it.

philwebb

comment created time in 7 days

issue openedspring-io/spring-javaformat

Ban lombok imports

We should update checkstyle to ban lombok imports.

created time in 7 days

push eventspring-io/spring-javaformat

Phillip Webb

commit sha 330f0f3b1057d364a930eb5545ddc2df0f7387d0

Update copyright header

view details

Phillip Webb

commit sha 65606a38ad6c30b9fc4daf2366a48889baf4f9bc

Update copyright year of changed files

view details

Phillip Webb

commit sha 76c81975e465005bc61ee0031bd25eb31f35564c

Polish

view details

Phillip Webb

commit sha f56a526dba5504c413cb3a269a40e9a7868599f1

Ban certain javadoc tags Closes gh-190

view details

Phillip Webb

commit sha 3ef4fc658632a14051edf87d515e36a2f37bfc19

Update checkstyle and maven plugin version Closes gh-187

view details

push time in 7 days

issue closedspring-io/spring-javaformat

Ban certain javadoc tags

We could do with a quick way to ban tags such as @soundtrack

closed time in 7 days

philwebb

issue openedspring-io/spring-javaformat

Ban certain javadoc tags

We could do with a quick way to ban tags such as @soundtrack

created time in 7 days

push eventspring-io/spring-javaformat

Phillip Webb

commit sha 5fa277b8cdea03dff9c5ce8ecdd21449ed49b064

Check for o_O as exception message Closes gh-189

view details

push time in 8 days

issue closedspring-io/spring-javaformat

Check for o_O as exception message

A few projects use o_O now and again rather than the Spring convention of ex.

closed time in 8 days

philwebb

issue openedspring-io/spring-javaformat

Check for o_O as exception message

A few projects use o_O now and again rather than the Spring convention of ex.

created time in 8 days

create barnchphilwebb/spring-data-commons

branch : formatting

created branch time in 8 days

push eventspring-io/spring-javaformat

Phillip Webb

commit sha 732558c222ea002d2bdad2d198ce2d6404341136

Exclude generated-test-sources Closes gh-188

view details

push time in 8 days

issue closedspring-io/spring-javaformat

Exclude generated-test-sources

Currently only the generated-sources folder is excluded, we need to also exclude test sources.

closed time in 8 days

philwebb

issue openedspring-io/spring-javaformat

Exclude generated-test-sources

Currently only the generated-sources folder is excluded, we need to also exclude test sources.

created time in 8 days

issue openedspring-io/spring-javaformat

Check for "(non-Javadoc)" comments

Eclipse adds them but from what I can tell they're just noise.

created time in 8 days

push eventpivotal-legacy/homebrew-tap

Phillip Webb

commit sha 844439b0a0cd617a20872dd9b0d1c76e0e7426e0

Upgrade to Spring Boot 2.3.0.RELEASE

view details

push time in 12 days

issue closedspring-io/github-release-notes-generator

Escape @ in issue titles

An issue title that includes an annotation will be written directly to the release notes. This might link to a user. We could backtick them automatically.

closed time in 12 days

philwebb

release spring-projects/spring-boot

v2.3.0.RELEASE

released time in 12 days

issue commentspring-io/github-release-notes-generator

Escape @ in issue titles

I just edited https://github.com/spring-projects/spring-boot/releases/tag/v2.2.7.RELEASE. Perhaps we're on an old version.

philwebb

comment created time in 12 days

issue openedspring-io/github-release-notes-generator

Escape @ in issue titles

An issue title that includes an annotation will be written directly to the release notes. This might link to a user. We could backtick them automatically.

created time in 12 days

issue commentspring-projects/spring-boot

Reinstate release scripts POM

Accidentally deleted in merge commit 9a1a2ca6130417dd2f742ed2f92f12d77e7234ce due to me thinking we didn't need any POMs

mbhave

comment created time in 12 days

push eventspring-projects/spring-boot

Phillip Webb

commit sha 8eec9cf32f6d354eceabf05a1967066405a2ae4b

Restore release scripts POM Closes gh-21460

view details

push time in 12 days

issue closedspring-projects/spring-boot

Reinstate release scripts POM

It got deleted accidentally looks like.

closed time in 12 days

mbhave

push eventspring-projects/spring-boot

Phillip Webb

commit sha c7023c5b17800f1f020d39b7a7d2792efcb1e69f

Increase bintray timeout

view details

push time in 12 days

issue openedliquibase/liquibase

XSDs are not resolved from the jar when referenced via HTTPS

<!--- This environment context section helps us quickly review your PR. Please take a minute to fill-out this information. -->

Environment

Java 8.

Liquibase Version: 3.8

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.> Spring Boot

Database Vendor & Version: N/A

Operating System Type & Version: MacOS

Description

If a migration XML file refers to the liqubase XSD using https, the local jar packaged version is not used. That can cause issues if liquibase.org is down.

Steps To Reproduce

Use a liquibase XML with the following header without a network connection:

<?xml version="1.0" encoding="UTF-8"?>
<databaseChangeLog
        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext"
        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog https://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.8.xsd
        http://www.liquibase.org/xml/ns/dbchangelog-ext https://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd">

Actual Behavior

XSD resolution fails because https://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.8.xsd cannot be read.

Expected/Desired Behavior

The locally packaged XSD is used.

Additional Context

The StandardNamespaceDetails class could be updated to include https as well as http URLs.

created time in 12 days

push eventspring-projects/spring-boot

Phillip Webb

commit sha eb3b0f82a38f3f184f5f8dcf01eda361fcd4e541

Use http liquibase XSDs Update the lquibase test to use `http://` rather than `https://` so that it can be resolved from the local jar.

view details

push time in 12 days

issue closedspring-projects/spring-boot

spring boot OutputCaptureRule throws "No system captures found" in spock 2.0 tests.

Java 11.0.6, Dependencies:

testImplementation('org.spockframework:spock-core:2.0-M2-groovy-3.0')
testImplementation('org.springframework.boot:spring-boot-test: 2.2.7.RELEASE')
class OutputCaptureTest extends Specification {

    @Rule
    OutputCaptureRule capture = new OutputCaptureRule()

    def "test output"() {
        when:
        println "hello"

        then:
        capture.toString().contains("hello")
    }
}

Exception:

Condition failed with Exception:

capture.toString().contains("hello")
|       java.lang.IllegalStateException: No system captures found. Please check your output capture registration.
|       	at org.springframework.util.Assert.state(Assert.java:73)
|       	at org.springframework.boot.test.system.OutputCapture.get(OutputCapture.java:129)
|       	at org.springframework.boot.test.system.OutputCapture.getAll(OutputCapture.java:100)
|       	at org.springframework.boot.test.system.OutputCapture.toString(OutputCapture.java:90)
|       	at org.springframework.boot.test.system.OutputCaptureRule.toString(OutputCaptureRule.java:110)
|       	at com.me.OutputCaptureTest.test output(OutputCaptureTest.groovy:17)
org.springframework.boot.test.system.OutputCaptureRule@5705a8db (renderer threw IllegalStateException)

closed time in 12 days

Dhivyaa21

issue commentspring-projects/spring-boot

spring boot OutputCaptureRule throws "No system captures found" in spock 2.0 tests.

It looks like Spock isn't executing that JUnit rule. You can try debugging your tests with a breakpoint on OutputCaptureRule.apply to confirm. I'm afraid you'll need to get help from the Spock community if that's the case.

Dhivyaa21

comment created time in 12 days

issue commentspring-projects/spring-boot

Configure SameSite attribute on session Cookies for Servlet-based applications

@natevaughan Please don't add "bump" comments to this tracker, it causes notifications for everyone watching this repo and it won't make us get to the issue any quicker.

bclozel

comment created time in 12 days

issue commentspring-io/spring-javaformat

Use the eclipse preference api instead of writing files

Thanks for the suggestion. I don't think I ever tried to use the preferences API, I think I just did some copy/paste of some old code that I had. It would be nice to migrate if it offers better performance.

antonio-vazquez-araujo

comment created time in 13 days

push eventspring-projects/spring-boot

Dmytro Nosan

commit sha a4104ab096b4a1f3f41995dec435b8435dc5473c

Add @WebServiceClientTest slice test support Add `@WebServiceClientTest` and related test auto-configuration to allow slice testing of Spring Web Service client applications. See gh-17274

view details

Phillip Webb

commit sha 194c9fac64a48dd612bf17ebd052bdfd45cbde97

Polish 'Add @WebServiceClientTest slice test support' See gh-17274

view details

Phillip Webb

commit sha a2187bbd054c5c4707250dcde0db6a8cc86a977a

Merge pull request #17274 from nosan * gh-17274: Polish 'Add @WebServiceClientTest slice test support' Add @WebServiceClientTest slice test support Closes gh-17274

view details

push time in 13 days

PR closed spring-projects/spring-boot

Add @WebServiceClientTest annotation that can be used when testing `SOAP` clients. type: enhancement

Add a slice @WebServiceClientTest annotation that can be used when testing SOAP clients.

The implementation is quite similar to @RestClientTest but for WebServiceTemplateBuilder. PR is not ready yet, it is just a concept of how it could be.

Here is a small example of usage:

@WebServiceClientTest(ExampleWebServiceClient.class)
class WebServiceClientIntegrationTests {

	@Autowired
	private MockWebServiceServers servers;

	@Autowired
	private ExampleWebServiceClient client;

	@Test
	void mockServerCall() {
		this.servers.expect(RequestMatchers.payload(new StringSource("<request/>"))).andRespond(
				ResponseCreators.withPayload(new StringSource("<response><status>200</status></response>")));
		assertThat(this.client.test()).extracting(Response::getStatus).isEqualTo(200);
	}

	@Test
	void mockServerCall1() {
		this.servers.expect(RequestMatchers.connectionTo("https://example1"))
				.andRespond(ResponseCreators.withPayload(new StringSource("<response/>")));
		assertThatExceptionOfType(SourceAssertionError.class).isThrownBy(this.client::test)
				.withMessageContaining("Unexpected connection expected");
	}
}

If you are interested in this feature I will add more tests and documentation.

Also, pay attention to https://github.com/spring-projects/spring-boot/compare/master...nosan:webservice-client-test?expand=1#diff-a0ae2b770ccb1b5cc0b45d9966df843aR66 it would be nice to have reset() functionality in MockWebServiceServer class. Is it possible to add?

Let me know what you think and thanks in advance.

P.S. Work-in-Progress

+1082 -2

14 comments

24 changed files

nosan

pr closed time in 13 days

push eventspring-projects/spring-boot

Phillip Webb

commit sha d7c7ca31f3f378a01e371a5d48068dd2d31b7d82

Upgrade to spring-javaformat 0.0.22 Closes gh-21446

view details

Phillip Webb

commit sha 5eabb0400cd11867f282d45ac9c5a8c66d38b5b4

Merge branch '2.1.x' into 2.2.x Closes gh-21447

view details

Phillip Webb

commit sha 9a1a2ca6130417dd2f742ed2f92f12d77e7234ce

Merge branch '2.2.x' Closes gh-21448

view details

push time in 13 days

issue closedspring-projects/spring-boot

Upgrade to spring-javaformat 0.0.22

Forward port of issue #21446 to 2.3.0.

closed time in 13 days

philwebb

issue closedspring-projects/spring-boot

Upgrade to spring-javaformat 0.0.22

Forward port of issue #21446 to 2.2.8.

closed time in 13 days

philwebb

issue closedspring-projects/spring-boot

Upgrade to spring-javaformat 0.0.22

<!-- Thanks for raising a Spring Boot issue. Please take the time to review the following categories as some of them do not apply here.

🙅 "Please DO NOT Raise an Issue" Cases

  • Question STOP!! Please ask questions about how to use something, or to understand why something isn't working as you expect it to, on Stack Overflow using the spring-boot tag.
  • Security Vulnerability STOP!! Please don't raise security vulnerabilities here. Head over to https://pivotal.io/security to learn how to disclose them responsibly.
  • Managed Dependency Upgrade You DO NOT need to raise an issue for a managed dependency version upgrade as there's a semi-automatic process for checking managed dependencies for new versions before a release. BUT pull requests for upgrades that are more involved than just a version property change are still most welcome.
  • With an Immediate Pull Request An issue will be closed as a duplicate of the immediate pull request, so you don't have to raise an issue if you plan to create a pull request immediately.

🐞 Bug report (please don't include this emoji/text, just add your details) Please provide details of the problem, including the version of Spring Boot that you are using. If possible, please provide a test case or sample application that reproduces the problem. This makes it much easier for us to diagnose the problem and to verify that we have fixed it.

🎁 Enhancement (please don't include this emoji/text, just add your details) Please start by describing the problem that you are trying to solve. There may already be a solution, or there may be a way to solve it that you hadn't considered.

TIP: You can always edit your issue if it isn't formatted correctly. See https://guides.github.com/features/mastering-markdown -->

closed time in 13 days

philwebb

push eventspring-projects/spring-boot

Phillip Webb

commit sha d7c7ca31f3f378a01e371a5d48068dd2d31b7d82

Upgrade to spring-javaformat 0.0.22 Closes gh-21446

view details

Phillip Webb

commit sha 5eabb0400cd11867f282d45ac9c5a8c66d38b5b4

Merge branch '2.1.x' into 2.2.x Closes gh-21447

view details

push time in 13 days

push eventspring-projects/spring-boot

Phillip Webb

commit sha d7c7ca31f3f378a01e371a5d48068dd2d31b7d82

Upgrade to spring-javaformat 0.0.22 Closes gh-21446

view details

push time in 13 days

issue openedspring-projects/spring-boot

Upgrade to spring-javaformat 0.0.22

Forward port of issue #21446 to 2.3.0.

created time in 13 days

issue openedspring-projects/spring-boot

Upgrade to spring-javaformat 0.0.22

Forward port of issue #21446 to 2.2.8.

created time in 13 days

issue closedspring-projects/spring-boot

Run structure 101 check

<!-- Thanks for raising a Spring Boot issue. Please take the time to review the following categories as some of them do not apply here.

🙅 "Please DO NOT Raise an Issue" Cases

  • Question STOP!! Please ask questions about how to use something, or to understand why something isn't working as you expect it to, on Stack Overflow using the spring-boot tag.
  • Security Vulnerability STOP!! Please don't raise security vulnerabilities here. Head over to https://pivotal.io/security to learn how to disclose them responsibly.
  • Managed Dependency Upgrade You DO NOT need to raise an issue for a managed dependency version upgrade as there's a semi-automatic process for checking managed dependencies for new versions before a release. BUT pull requests for upgrades that are more involved than just a version property change are still most welcome.
  • With an Immediate Pull Request An issue will be closed as a duplicate of the immediate pull request, so you don't have to raise an issue if you plan to create a pull request immediately.

🐞 Bug report (please don't include this emoji/text, just add your details) Please provide details of the problem, including the version of Spring Boot that you are using. If possible, please provide a test case or sample application that reproduces the problem. This makes it much easier for us to diagnose the problem and to verify that we have fixed it.

🎁 Enhancement (please don't include this emoji/text, just add your details) Please start by describing the problem that you are trying to solve. There may already be a solution, or there may be a way to solve it that you hadn't considered.

TIP: You can always edit your issue if it isn't formatted correctly. See https://guides.github.com/features/mastering-markdown -->

closed time in 13 days

philwebb

issue commentspring-projects/spring-boot

Run structure 101 check

No lead level tangles detected.

philwebb

comment created time in 13 days

issue openedspring-projects/spring-boot

Upgrade to spring-javaformat 0.0.22

<!-- Thanks for raising a Spring Boot issue. Please take the time to review the following categories as some of them do not apply here.

🙅 "Please DO NOT Raise an Issue" Cases

  • Question STOP!! Please ask questions about how to use something, or to understand why something isn't working as you expect it to, on Stack Overflow using the spring-boot tag.
  • Security Vulnerability STOP!! Please don't raise security vulnerabilities here. Head over to https://pivotal.io/security to learn how to disclose them responsibly.
  • Managed Dependency Upgrade You DO NOT need to raise an issue for a managed dependency version upgrade as there's a semi-automatic process for checking managed dependencies for new versions before a release. BUT pull requests for upgrades that are more involved than just a version property change are still most welcome.
  • With an Immediate Pull Request An issue will be closed as a duplicate of the immediate pull request, so you don't have to raise an issue if you plan to create a pull request immediately.

🐞 Bug report (please don't include this emoji/text, just add your details) Please provide details of the problem, including the version of Spring Boot that you are using. If possible, please provide a test case or sample application that reproduces the problem. This makes it much easier for us to diagnose the problem and to verify that we have fixed it.

🎁 Enhancement (please don't include this emoji/text, just add your details) Please start by describing the problem that you are trying to solve. There may already be a solution, or there may be a way to solve it that you hadn't considered.

TIP: You can always edit your issue if it isn't formatted correctly. See https://guides.github.com/features/mastering-markdown -->

created time in 13 days

create barnchphilwebb/spring-boot

branch : gh-17274

created branch time in 13 days

push eventspring-io/spring-javaformat

Phillip Webb

commit sha 5749fae9b17d73bc7dcdb468be4ed41793e875aa

Allow static webservices test imports Closes gh-183

view details

push time in 13 days

issue closedspring-io/spring-javaformat

Allow static webservices test imports

To align with MVC matchers, we should allow static import for:

org.springframework.ws.test.client.RequestMatchers
org.springframework.ws.test.client.ResponseCreators

closed time in 13 days

philwebb

issue openedspring-io/spring-javaformat

Allow static webservices test imports

To align with MVC matchers, we should allow static import for:

org.springframework.ws.test.client.RequestMatchers
org.springframework.ws.test.client.ResponseCreators

created time in 13 days

issue openedspring-projects/spring-boot

Eclipse doesn't import docs example java source

It's currently hard to write asciidoc example code in eclipse because the /src... folders aren't imported and there's no classpath.

created time in 13 days

more