profile
viewpoint

spring-projects-experimental/spring-graalvm-native 660

Incubator for Spring Boot native application support

christophstrobl/spring-data-solr-showcase 89

Sample Spring MVC Application demonstrating usage of Spring Data Solr.

mp911de/microbenchmark-runner 59

JUnit extensions to launch JMH benchmarks from your IDE during development

springone2gx2015/whats-new-in-spring-data 20

Sample code for the "What's new in Spring Data?" session at SpringOne 2015

SpringOnePlatform2016/whats-new-in-spring-data 15

Sample code for the "What's new in Spring Data?" session at SpringOne 2016

christophstrobl/mongodb-bookstore 13

SpringBoot application outlining usage of different MongoDB Data Models for atomic operations / transactions. Referring to and extending the MongoDB Model Data for Atomic Operations example.

christophstrobl/going-reactive-with-spring-data 6

Demo application for reactive data access with Spring Data and Spring Framework 5.

christophstrobl/spring-data-reactive-demo 2

Spring Data Ractive Demo application for non blocking data access.

create barnchspring-projects/spring-data-mongodb

branch : issue/DATAMONGO-2633

created branch time in 13 hours

create barnchspring-projects/spring-data-mongodb

branch : issue/DATAMONGO-2623

created branch time in 14 hours

PR closed spring-projects/spring-data-commons

DATACMNS-1762 - Support Optional wrapping for projection getters

We now support nullable wrappers for projection interfaces. Getters are inspected whether their return type is a supported nullable wrapper. If so, then the value can be wrapped into that type. Null values default in that case to their corresponding empty wrapper representation.

class Customer {

	Long id;
	String firstname, lastname;
	Address address;
}

interface CustomerProjection {

	Optional<String> getFirstname();

	Optional<AddressExcerpt> getAddress();
}


Customer customer = new Customer();
customer.firstname = "Walter";

CustomerProjection projection = …;

assertThat(projection.getFirstname()).hasValue("Walter");


customer.firstname = null;
assertThat(projection.getFirstname()).isEmpty();

Also, extracted NullableWrapperConverters from QueryExecutionConverters and removed ReactiveWrappers from QueryExecutionConverters.


We should reconsider the package for NullableWrapperConverters as further extensions (Iterable -> Streamable) might be future enhancements.

Related ticket: DATACMNS-1762 Previous pull request: #457.

+979 -345

1 comment

16 changed files

mp911de

pr closed time in 4 days

delete branch spring-projects/spring-data-commons

delete branch : issue/DATACMNS-1762

delete time in 4 days

push eventspring-projects/spring-data-commons

Mark Paluch

commit sha 9ced611ea5f8ec551ba080c26448f57fc0b4cd2e

DATACMNS-1762 - Remove ReactiveWrappers support from from QueryExecutionConverters. ReactiveWrappers doesn't belong in there in the first place so we're removing ReactiveWrappers support from QueryExecutionConverters so ReactiveWrappers is used from parts that need to be reactive-aware. Original Pull Request: #459

view details

Mark Paluch

commit sha 04f59f130717b245d700aff6de37186da8a33bca

DATACMNS-1762 - Extract NullableWrapperConverters from QueryExecutionConverters. Nullable wrappers such as Java 8 Optional, Guava Optional, Scala Option and Vavr Option are now handled in NullableWrapperConverters and are no longer coupled to QueryExecutionConverters so that this functionality can be reused. Original Pull Request: #459

view details

Mark Paluch

commit sha bd3992dfc56cc53e3be4a6d7ea106594fd7d81e5

DATACMNS-1762 - Support Optional wrapping for projection getters. We now support nullable wrappers for projection interfaces. Getters are inspected whether their return type is a supported nullable wrapper. If so, then the value can be wrapped into that type. Null values default in that case to their corresponding empty wrapper representation. Original Pull Request: #459

view details

Wim Deblauwe

commit sha 97df0fa899886cb02b4c00c6f67b8f1f7ab6ecc7

DATACMNS-1762 - Add tests for projections returning Optional. Original Pull Request: #459

view details

Christoph Strobl

commit sha f261220372d01e931f45e85a0bc1acd324a210b4

DATACMNS-1762 - Polishing. Update JavaDoc, remove unused imports and reduce method visibility. Original Pull Request: #459

view details

push time in 4 days

push eventchristophstrobl/spring-graalvm-native

Christoph Strobl

commit sha f16d6f450672b23b77a007984c1c2409aa5d8b2a

move to snapshot build

view details

Christoph Strobl

commit sha f3f608e25a8b5f3035ae38ee8a01072bf53db71e

Add hints for newly introduced RestControllerImportSelector

view details

push time in 4 days

PR opened spring-projects/spring-data-rest

DATAREST-1567 - Replace component scan with @Bean methods.

We replaced the component scan in RespositoryRestMvcConfiguration with dedicated bean methods. This allows us to be more explicit in resolving required components, which is required for better support of GraalVM native image.

Relates to: spring-projects-experimental/spring-graalvm-native#192

+228 -24

0 comment

17 changed files

pr created time in 5 days

push eventspring-projects/spring-data-rest

Christoph Strobl

commit sha 7e73ded49bb7149f85b78e5dd7945c11b64da810

DATAREST-1567 - Replace component scan with explicit bean methods. We replaced the component scan in RespositoryRestMvcConfiguration with dedicated bean methods. This allows us to be more explicit in resolving required components, which is required for better support of GraalVM native image.

view details

push time in 5 days

create barnchspring-projects/spring-data-rest

branch : issue/DATAREST-1567

created branch time in 5 days

push eventchristophstrobl/spring-graalvm-native

Dave Syer

commit sha 8d927f40078c4ec426009f9ba44e459eef9da4ec

Organize imports

view details

Dave Syer

commit sha 5578e504951149f2d2f7cd934de42fd1b79b1add

Mess around with petclinics

view details

Sébastien Deleuze

commit sha f77679ecb2cf098f917622b2b4bbc4410248050d

Revert "Mess around with petclinics" This reverts commit 5578e504951149f2d2f7cd934de42fd1b79b1add.

view details

Andy Clement

commit sha 8923603d4d49a182735beb5d9fbe9207bee852e3

Fix #286 - NPE with activating XML

view details

Andy Clement

commit sha 635baf0fe642c9af8c831c57682d1f8aa317a72f

Fix petclinic samples

view details

Andy Clement

commit sha 57250cafa7817c2d73aaf9e4840a680abbcbdc83

Improvements to actuator hints

view details

Dave Syer

commit sha 8cc2fc1fc9cc023e2e10e7b34bfe78b6537f1057

Ensure EnvironmentPorstProcessors get called

view details

Dave Syer

commit sha 88289361d7b0ed10895916de7df4ae436a80751a

Add LogLevelHints to support binding to logging.level.*

view details

Sébastien Deleuze

commit sha 8a8ea9b84c243e2200f4cc79c2ec08bf4412dffb

Upgrade to Spring Boot 2.4.0-M3 Closes gh-252

view details

Sébastien Deleuze

commit sha b8e3d254b670f33526210ad45f56117de166ddf4

Polishing

view details

Andy Clement

commit sha a146ff2f25fe7bfac8aeb7c1f0460c373ae0ff9c

work in progress enhancements to analysis algorithm As configurations are walked it now tracks how they were reached, which helps determining if discarding is possible. Also reworked handling of @Bean methods.

view details

Andy Clement

commit sha 7cf125ff15488d14ebd393649f229c078b3068fc

Include text names when scraping @COC annotations

view details

Andy Clement

commit sha d090e43cdc36da16b6a443da7a1a66e72e51cb06

polish

view details

Andy Clement

commit sha fd2ff6d1e70c0480923b9e09dc2a406834fcfd1b

more actuator improvements

view details

Andy Clement

commit sha eeb0f5949d742e5a316160dcf13fcdb5a8fa9ff8

Basic support for method level configuration exclusion

view details

Dave Syer

commit sha 13c46833beb5ea31fb1db1474353cded4a95451e

Add test containers test to function-aws sample

view details

Dave Syer

commit sha 65c095568790923c989cbc90a998d9564fccf7f1

Attempt to make container test work in VSCode

view details

Dave Syer

commit sha 6c18d7cdb35de3df03d94e3f13eaf0ce75a86165

Back to String->String

view details

Dave Syer

commit sha 5079af842d3740989b0068d159a7b835d8f091ee

Use test containers only for integration test

view details

Christoph Strobl

commit sha fe0e651de4890708bd814deeda87dc1b3e095dc4

Add Spring Data Elasticsearch hints and sample Provide native image hints that add required proxy and reflection for Spring Data Elasticsearch Repositories. Provide a Map based Substitution for the org.apache.http.impl.client.BasicAuthCache used by the Elasticsearch REST Client. Move Reactive Spring Data hints to dedicated class to be used by TypeInfo imports. Update docker configuration to include and start Elasticsearch server. Closes gh-277

view details

push time in 5 days

PR opened spring-projects/spring-data-mongodb

DATAMONGO-2622 - Add support for $unionWith aggregation stage.

We now support the $unionWith aggregation stage via the UnionWithOperation that performs a union of two collections by combining pipeline results, potentially containing duplicates, into a single result set that is handed over to the next stage. In order to remove duplicates it is possible to append a GroupOperation right after UnionWithOperation. If the UnionWithOperation uses a pipeline to process documents, field names within the pipeline will be treated as is. In order to map domain type property names to actual field names (considering potential @Field annotations) make sure the enclosing aggregation is a TypedAggregation and provide the target type for the $unionWith stage via mapFieldsTo(Class).

+370 -11

0 comment

11 changed files

pr created time in 11 days

create barnchspring-projects/spring-data-mongodb

branch : issue/DATAMONGO-2622

created branch time in 11 days

issue openedspring-projects-experimental/spring-graalvm-native

spring.xml.ignore=false causes NullPointerException in TypeSystem

Adding the -Dpring.xml.ignore=false causes a NPE in o.s.graalvm.type.TypeSystem.findActiveDefaultHints(TypeSystem.java:679) at build time.

Without the flag xml support is disabled, which leads to an UnsupportedOperationException: XML support disabled on startup.

Sample Project: spring-graalvm-native-samples/data-rest

Full Stack Trace:

Excluding 95 auto-configurations from spring.factories file
WARNING: unable to trim META-INF/spring.factories (for example to disable unused auto configurations) because an existing resource-config is directly including it: /home/cstrobl/spring-graalvm-native/spring-graalvm-native-samples/spring-data-rest/target/native-image/BOOT-INF/classes/META-INF/native-image/resource-config.json
Fatal error:java.lang.NullPointerException
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:598)
	at java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1005)
	at com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:480)
	at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:349)
	at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:508)
	at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:114)
Caused by: java.lang.NullPointerException
	at org.springframework.graalvm.type.TypeSystem.findActiveDefaultHints(TypeSystem.java:679)
	at org.springframework.graalvm.support.ResourcesHandler.handleConstantHints(ResourcesHandler.java:169)
	at org.springframework.graalvm.support.ResourcesHandler.register(ResourcesHandler.java:131)
	at org.springframework.graalvm.support.SpringFeature.beforeAnalysis(SpringFeature.java:107)
	at com.oracle.svm.hosted.NativeImageGenerator.lambda$runPointsToAnalysis$7(NativeImageGenerator.java:693)
	at com.oracle.svm.hosted.FeatureHandler.forEachFeature(FeatureHandler.java:70)
	at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:693)
	at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:555)
	at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:468)
	at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:163)
Error: Image build request failed with exit status 1
com.oracle.svm.driver.NativeImage$NativeImageError: Image build request failed with exit status 1
	at com.oracle.svm.driver.NativeImage.showError(NativeImage.java:1558)
	at com.oracle.svm.driver.NativeImage.build(NativeImage.java:1308)
	at com.oracle.svm.driver.NativeImage.performBuild(NativeImage.java:1269)
	at com.oracle.svm.driver.NativeImage.main(NativeImage.java:1228)

created time in 11 days

push eventchristophstrobl/spring-graalvm-native

Christoph Strobl

commit sha 539479749f5afb1701355ab37242cf83448cba88

NPE when using spring.xml.ignore=false fails due to -Dspring.xml.ignore=false

view details

push time in 11 days

push eventchristophstrobl/spring-graalvm-native

Andy Clement

commit sha fce0351ac23c8cf8c81d6b98cfbbaa14e61b71a9

Fix standalone CLR agent project

view details

Sébastien Deleuze

commit sha f8fe0e5e5e65d1aac6b401f345898d2db5ae0d8a

Remove messages sample

view details

Sébastien Deleuze

commit sha ba884f8967413585a2f2826cd92c9abf89f3a07d

Use Maven plugin and Paketo buildpack in logger sample See gh-165

view details

Sébastien Deleuze

commit sha bea7f95d974ce240a08c7f01add9305cf693410c

Use Maven plugin and Paketo buildpack in jpa sample See gh-165

view details

Sébastien Deleuze

commit sha fe56180eaa0c82db646b00ba74e24412d10cf15b

Use Maven plugin and Paketo buildpack in grpc sample See gh-165

view details

Sébastien Deleuze

commit sha 76440104ceb8176516179ab03f0110d40907d137

Use Maven plugin and Paketo buildpack in function-netty-fun sample See gh-165

view details

Sébastien Deleuze

commit sha 4bc50c36a441542e7510a369b9ff728525142c05

Use Maven plugin and Paketo buildpack in function-netty sample See gh-165

view details

Sébastien Deleuze

commit sha a2183341fdf30aa85b3c67e9f9e9304874e67a46

Use Maven plugin and Paketo buildpack in features sample See gh-165

view details

Sébastien Deleuze

commit sha 48c9f3313fb8b5e4c87f102131c7664be65a9cfe

Use Maven plugin and Paketo buildpack in data-redis sample See gh-165

view details

Sébastien Deleuze

commit sha 3c67393ae81c7beccc0df41e9b0bac16f2f72413

Remove standaline commandlinerunner-agent sample

view details

Sébastien Deleuze

commit sha 2a977fa4e3de6c9da5d9c1ceeda9a286a19126b1

Add missing files

view details

Sébastien Deleuze

commit sha accfdaec4e81b4cc43a35d6f6a1e1720d64df100

Use Maven plugin and Paketo buildpack in commandlinerunner-jafu sample See gh-165

view details

Sébastien Deleuze

commit sha 979d7649d3591a27e93437719cff6100cff456d9

Use Maven plugin and Paketo buildpack in commandlinerunner sample See gh-165

view details

Sébastien Deleuze

commit sha 511ded5adba0292698d69f8234bef1abfae8eb1c

Use Maven plugin and Paketo buildpack in boot-features sample See gh-165

view details

Sébastien Deleuze

commit sha b71eef0919478484455d8b3b72e441321ce1fa06

Use Maven plugin and Paketo buildpack in batch-io sample See gh-165

view details

Christoph Strobl

commit sha 5f595acd67ddb4baa7eb401e032d1f2a659acc7e

Remove Substitutions avoiding Spring Data runtime class generation. Spring Data Commons 2.4.0-M2 contains flags that guard class generation when running native image code. Therefore substitutions for the ClassGeneratingEntityIstantiator and ClassGeneratingPropertyAccessorFactory can be removed.

view details

Sébastien Deleuze

commit sha 90a8a45e36e7e995c0dd3dd2e5d6597d4e072fa7

Use Maven plugin and Paketo buildpack in batch sample See gh-165

view details

Sébastien Deleuze

commit sha 1569289120978faf9a27ef4000e9fcf8d93c720b

Remove Batch samples for now They are in https://github.com/spring-projects-experimental/spring-graalvm-native/tree/batch-samples, see related gh-203 issue.

view details

Sébastien Deleuze

commit sha 590ceb714aed419ae1306d880e2d04a838afea3b

Use Maven plugin and Paketo buildpack in actuator-webmvc sample See gh-165

view details

Sébastien Deleuze

commit sha 45f723d86e6690ad7e9cd01364ed383473fc2e1d

Use Maven plugin and Paketo buildpack in actuator-webflux sample Closes gh-165

view details

push time in 11 days

push eventspring-projects/spring-data-redis

Mark Paluch

commit sha 9fbb477057803cb84bc8b7b9512c9dcd67a6f21b

DATAREDIS-1046 - Upgrade to Redis 6 in CI docker images.

view details

Christoph Strobl

commit sha 1a025fea464ac119cf97de6737a8b00e447fa3d6

DATAREDIS-1215 - Upgrade to Lettuce 6.0-RC2.

view details

Christoph Strobl

commit sha 3a5c4fe23adabd03a3cb28542724f75379ed983f

DATAREDIS-1196 - Prepare issue branch.

view details

Christoph Strobl

commit sha cf2b1a28ac4cdfa23cf2b6c229c1eb0abb014f7f

DATAREDIS-1196 - Add lPos command to RedisListCommands.

view details

Christoph Strobl

commit sha 4916bc5a76b7d2fe70e6fd50e04c97a19c625b47

DATAREDIS-1196 - Add indexOf to (Bound)ListOperations and DefaultRedisList.

view details

Christoph Strobl

commit sha 5ea658f4defe3d57346ce7b4ad613c5890c9e8ae

DATAREDIS-1196 - Add lPos command to ReactiveListCommands.

view details

Christoph Strobl

commit sha d8754adfba5086b22fdbe0466a00bb00524ba4c5

DATAREDIS-1196 - Add lPos to ReactiveListOperations

view details

Christoph Strobl

commit sha 97b5acf9ab545bac06ef0ad4e1663fae97d24550

DATAREDIS-1196 - Guard Tests that require Redis 6.0.6+

view details

Christoph Strobl

commit sha 7cdc0f5eee5829928c89a6a60396a4f7c8cec48f

DATAREDIS-1196 - Adapt to Lettuce 6.0-RC2 changes

view details

push time in 13 days

push eventspring-projects/spring-data-redis

Christoph Strobl

commit sha 1a025fea464ac119cf97de6737a8b00e447fa3d6

DATAREDIS-1215 - Upgrade to Lettuce 6.0-RC2.

view details

push time in 13 days

push eventspring-projects/spring-data-redis

Christoph Strobl

commit sha fd52bd83cc05141af998a392cda3fc463d97af51

DATAREDIS-1216 - Upgrade to Lettuce 5.3.4.

view details

push time in 13 days

PR opened spring-projects/spring-data-redis

DATAREDIS-1196 - Add support for LPOS.

We now support LPOS via the imperative and reactive list commands. (Reactive)ListOperations support a minimal set of LPOS variants (indexOf & lastIndexOf) to back the corresponding DefaultRedisList methods.

Some of the tests (those using the RANK option) are still ignored because the require lettuce-io/lettuce-core#1410.

+730 -12

0 comment

23 changed files

pr created time in 13 days

create barnchspring-projects/spring-data-redis

branch : issue/DATAREDIS-1196

created branch time in 13 days

issue openedlettuce-io/lettuce-core

LPOS command sends FIRST instead of RANK

LPosArgs uses FIRST instead of RANK causing a syntax error

"RPUSH" "mylist" "a" "b" "c" "1" "2" "3" "c" "c"
"LPOS" "mylist" "c" "COUNT" "2" "FIRST" "-1"
> ERR syntax error
"LPOS" "mylist" "c" "COUNT" "2" "RANK" "-1"
> [7,6]

Please rename LPosArgs.first to LPosArgs.rank and send the RANK option if present.

Commit https://github.com/redis/redis/commit/a5a3a7bbc61203398ecc1d5b52c76214f5672776 changed the option name.

created time in 14 days

push eventspring-projects/spring-data-mongodb

Christoph Strobl

commit sha 71a077a59918ce69be42c02b68bb86ff636a50aa

DATAMONGO-2618 - Fix visibility of ReplaceRootDocumentOperation.

view details

push time in 14 days

push eventspring-projects/spring-data-mongodb

Christoph Strobl

commit sha 29bf4f72f36cd5335afff3198fe9d9fbe31613df

DATAMONGO-2618 - Fix visibility of ReplaceRootDocumentOperation.

view details

push time in 14 days

push eventspring-projects/spring-data-mongodb

Christoph Strobl

commit sha 85783e535451e0d5e917208894009141bfb7a7c1

DATAMONGO-2618 - Fix visibility of ReplaceRootDocumentOperation.

view details

push time in 14 days

push eventspring-projects/spring-data-mongodb

Christoph Strobl

commit sha 1a134aa4440461f6e4d5ea624dcad5085df46c15

DATAMONGO-2618 - Fix visibility of ReplaceRootDocumentOperation.

view details

push time in 14 days

push eventchristophstrobl/spring-graalvm-native

Dave Syer

commit sha 1276753ba2deb15474a649c3c6eba5dc69591f70

Add additional hint to support /configprops Fixes #271

view details

Dave Syer

commit sha ebbaed629a42ea0557ad8ac8eed956585d58a85f

Add cloud sample

view details

Dave Syer

commit sha 4d5910c2fb7ec3c50d7d7244505752302530b665

Tidy README

view details

Dave Syer

commit sha e394d5dce5606356a0c6ff287ecfebb1d14d08b2

Migrate JSON to @Hints for Spring Cloud /features

view details

Dave Syer

commit sha 6ea66977060667ffa4f33b7df2fff9b2e35c9468

Fix cloud sample to register HTTP Url prefix

view details

Dave Syer

commit sha a4658c6245fc979e0b0c6e6a5a5f53152905a2ce

Ensure config client can deserialize properties

view details

Dave Syer

commit sha 3a2b965a739ab7bc172ae1cd2805e082fb511a7b

Generate some JSON

view details

Dave Syer

commit sha 96f395f22b5529ece09d07d04cba7c0e78fea007

Fix tools scripts

view details

Sébastien Deleuze

commit sha d954ccc65311dd47df0289ede7c39defba794f06

Add SpringOne 2020 talk to the README

view details

Sébastien Deleuze

commit sha d50150dc139aaf9c2f185209f3788b3e7af6cf3d

Specify version in the documentation badge

view details

Sébastien Deleuze

commit sha f4cc68383b3788c3c00203e32a383838ca937537

Remove build badge until oracle/graal#2748 is fixed

view details

Mykola Papenko

commit sha 6511cf2725a20943432a78c2827f60011c97e923

Update README.adoc Fix a typo, add a few comas, make a sentence more concise, and stuff like that; mostly thanks to Grammarly.

view details

Andy Clement

commit sha 803d8c64ff3db01bcb8514e7131cefd0ead9e444

Merge pull request #278 from mykelangelo/patch-5 Update README.adoc

view details

Dave Syer

commit sha 45c28c51c35ac748ea428b6397e5be49d2a8e18b

Remove listener no longer present in Spring Init

view details

Sébastien Deleuze

commit sha 99621d9f3b24cd3a7b532b90acc32145de1efc2a

Upgrade to Spring Boot 2.4.0-SNAPSHOT See gh-252

view details

Andy Clement

commit sha 185222e4cfeb9e0ecbed68e15bea68735357b2a9

Go into nested classes of components Fixes #275

view details

Andy Clement

commit sha 64e605fb93c623397bf2322997e892c677e5e980

Refactoring and small set of Postgresql hints Moving code from ResourcesHandler to TypeSystem - more to come, part of making ResourcesHandler easier to understand. Postgresql hints fix my standalone sample, sample not yet in the codebase.

view details

Andy Clement

commit sha 7068837fb84d8291b68a9ae9f9f8de8ffbe64867

polish

view details

Christoph Strobl

commit sha 69803f52f51e215bc8f524a525b074ee0b0e9d42

Add Spring Data Elasticsearch hints and sample Provide native image hints that add required proxy and reflection for Spring Data Elasticsearch Repositories. Provide a Map based Substitution for the org.apache.http.impl.client.BasicAuthCache used by the Elasticsearch REST Client. Move Reactive Spring Data hints to dedicated class to be used by TypeInfo imports. Update docker configuration to include and start Elasticsearch server.

view details

push time in 15 days

Pull request review commentspring-projects-experimental/spring-graalvm-native

Add Spring Data Elasticsearch hints and sample

 import org.springframework.boot.autoconfigure.data.cassandra.CassandraRepositoriesAutoConfiguration; import org.springframework.boot.autoconfigure.data.couchbase.CouchbaseReactiveRepositoriesAutoConfiguration; import org.springframework.boot.autoconfigure.data.couchbase.CouchbaseRepositoriesAutoConfiguration;+import org.springframework.boot.autoconfigure.data.elasticsearch.ElasticsearchRepositoriesAutoConfiguration;+import org.springframework.boot.autoconfigure.data.elasticsearch.ReactiveElasticsearchRepositoriesAutoConfiguration; import org.springframework.boot.autoconfigure.data.mongo.MongoReactiveRepositoriesAutoConfiguration; import org.springframework.boot.autoconfigure.data.mongo.MongoRepositoriesAutoConfiguration; import org.springframework.core.io.support.PropertiesLoaderSupport; import org.springframework.graalvm.extension.NativeImageConfiguration; import org.springframework.graalvm.extension.NativeImageHint; import org.springframework.graalvm.extension.TypeInfo; -@NativeImageHint(trigger = CassandraReactiveRepositoriesAutoConfiguration.class, typeInfos= {-		@TypeInfo(types= {ConditionalOnRepositoryType.class, OnRepositoryTypeCondition.class,RepositoryType.class})+@NativeImageHint(trigger = CassandraReactiveRepositoriesAutoConfiguration.class, typeInfos = {+		@TypeInfo(types = {ConditionalOnRepositoryType.class, OnRepositoryTypeCondition.class, RepositoryType.class}) })-@NativeImageHint(trigger = CassandraRepositoriesAutoConfiguration.class, typeInfos= {-		@TypeInfo(types= {ConditionalOnRepositoryType.class, OnRepositoryTypeCondition.class,RepositoryType.class})+@NativeImageHint(trigger = CassandraRepositoriesAutoConfiguration.class, typeInfos = {+		@TypeInfo(types = {ConditionalOnRepositoryType.class, OnRepositoryTypeCondition.class, RepositoryType.class})

thanks @aclement - checked without the hints and everything worked. Will undo the changes and open another PR that takes care of removing hints for the other store modules.

christophstrobl

comment created time in 17 days

PullRequestReviewEvent

PR closed spring-projects/spring-data-redis

DATAREDIS-1197 - Upgrade to Lettuce 6.0 RC1.

Adopt to API changes.


Related ticket: DATAREDIS-1197.

+50 -57

0 comment

10 changed files

mp911de

pr closed time in 17 days

delete branch spring-projects/spring-data-redis

delete branch : issue/DATAREDIS-1197

delete time in 17 days

PR closed spring-projects/spring-data-redis

DATAREDIS-1145, DATAREDIS-1046 - Add ACL support and Sentinel authentication for Jedis

Upgrade to Redis 6 for tests. Introduce support for username in configurations that support authentication.

Depends on #554.

+572 -116

0 comment

27 changed files

mp911de

pr closed time in 17 days

delete branch spring-projects/spring-data-redis

delete branch : issue/DATAREDIS-1046

delete time in 17 days

push eventspring-projects/spring-data-redis

Mark Paluch

commit sha da5bab1fb28cd1e0abf659912c212447fc0a5a91

DATAREDIS-1197 - Upgrade to Lettuce 6.0 RC1. Adopt to API changes. Original Pull Request: #554

view details

Mark Paluch

commit sha d97c5df13072a5740d530253a1b0f06e16f0100a

DATAREDIS-1046 - Use ACL authentication when username is configured. Upgrade to Redis 6 for tests. Introduce support for username in configurations that support authentication. Original Pull Request: #558

view details

Mark Paluch

commit sha 717a196da0a16dbb95c214542a57f80e3fcb9bba

DATAREDIS-1145 - Support Sentinel password for Jedis. We now support password-protected Sentinel configurations when using Jedis. Original Pull Request: #558

view details

Christoph Strobl

commit sha bdbba085dac3469f4c32bb9d4b1d4996b78bb043

DATAREDIS-1046 - Polishing. Guard tests to allow execution against single node instance for quick dev turnaround and replace usage of Optional with null and @Nullable annotations. Original Pull Request: #558

view details

push time in 17 days

pull request commentspring-projects-experimental/spring-graalvm-native

Add Spring Data Elasticsearch hints and sample

@sdeleuze Please have a look at the Elasticsearch setup in the Docker and build files. Thank you!

christophstrobl

comment created time in 19 days

PR opened spring-projects-experimental/spring-graalvm-native

Add Spring Data Elasticsearch hints and sample

Provide native image hints that add required proxy and reflection for Spring Data Elasticsearch Repositories.

Provide a Map based substitution for the org.apache.http.impl.client.BasicAuthCache used by the Elasticsearch RestClient.

Move Reactive Spring Data hints to dedicated class, so they can be used by TypeInfo imports.

Update docker configuration to include and start Elasticsearch server.

+1439 -18

0 comment

24 changed files

pr created time in 19 days

create barnchchristophstrobl/spring-graalvm-native

branch : issue/data-elastic

created branch time in 19 days

create barnchchristophstrobl/spring-graalvm-native

branch : issue/266

created branch time in 21 days

PR opened spring-projects-experimental/spring-graalvm-native

#265 - Add Spring Data JDBC sample

Provide native image hints, that add required proxy and reflection configuration, for Spring Data JDBC Repositories. The added sample uses an embedded H2 and does some basic operations taken from the Spring Data examples repository.

Closes: #265

+1421 -0

0 comment

23 changed files

pr created time in 21 days

push eventchristophstrobl/spring-graalvm-native

Christoph Strobl

commit sha 05e9e1d9a3bfbc1c792e120bbc2238e87a86a7ad

#265 - Add Spring Data JDBC sample Provide native image hints that add required proxy and reflection for Spring Data JDBC Repositories. The added sample uses an embedded H2 and does some basic operations taken from the Spring Data examples repository.

view details

push time in 21 days

create barnchchristophstrobl/spring-graalvm-native

branch : issue/265

created branch time in 21 days

pull request commentspring-projects/spring-data-redis

DATAREDIS-1207 - Fix LettuceStreamCommands.xRevRange Range conversion.

Thank you @jankovd! Merged to main line and back ported to 2.3.x and 2.2.x.

jankovd

comment created time in a month

PR closed spring-projects/spring-data-redis

DATAREDIS-1210 - fix StreamReadOptions toString method

original StreamReadOptions toString method build String with another StreamReadOptions (formed by autoAcknowledge() ) inside, which cause StringBuilder append be called infinitely, and cause StackOverflowError. fix it by change toString return string to

"StreamReadOptions{" + "block=" + block + ", count=" + count + ", noack=" + noack + ", blocking=" + isBlocking() + '}'

+7 -2

1 comment

2 changed files

zkz2004

pr closed time in a month

pull request commentspring-projects/spring-data-redis

DATAREDIS-1210 - fix StreamReadOptions toString method

Thank you @zkz2004! Merged to main line.

zkz2004

comment created time in a month

push eventspring-projects/spring-data-redis

Dejan Jankov

commit sha a64271e95d754d12aada18ca0030bd483357ae8c

DATAREDIS-1207 - Fix LettuceStreamCommands.xRevRange Range conversion. LettuceStreamCommands.xRevRange converts Ranges with a StringCodec that produces Boundary<ByteBuffer>, while Lettuce expects the range's Boundary to include strings. The conversion worked well only in cases where the Range was unbounded (- or +), and failed with ClassCastException on the consuming site for other cases. Original pull request: #556

view details

push time in a month

push eventspring-projects/spring-data-redis

Dejan Jankov

commit sha df2b8b175c732bf03b0e1e1dce9e5519424648ce

DATAREDIS-1207 - Fix LettuceStreamCommands.xRevRange Range conversion. LettuceStreamCommands.xRevRange converts Ranges with a StringCodec that produces Boundary<ByteBuffer>, while Lettuce expects the range's Boundary to include strings. The conversion worked well only in cases where the Range was unbounded (- or +), and failed with ClassCastException on the consuming site for other cases. Original pull request: #556

view details

Christoph Strobl

commit sha ac16d4bb3f2da0e425de799ddcaf7184d46fc5b5

DATAREDIS-1207 - Fix LettuceStreamCommands.xPending Range conversion.. Original Pull Request: #556

view details

push time in a month

push eventspring-projects/spring-data-redis

kazhang

commit sha 9b87d3f080bf638a85fc9281b1e1b5a097f30d81

DATAREDIS-1210 - Fix loop in StreamReadOptions toString(). Original Pull Request: #557

view details

Dejan Jankov

commit sha 0ee04a7dc617fe96faef059c54ee5424cd687b86

DATAREDIS-1207 - Fix LettuceStreamCommands.xRevRange Range conversion. LettuceStreamCommands.xRevRange converts Ranges with a StringCodec that produces Boundary<ByteBuffer>, while Lettuce expects the range's Boundary to include strings. The conversion worked well only in cases where the Range was unbounded (- or +), and failed with ClassCastException on the consuming site for other cases. Original pull request: #556

view details

Christoph Strobl

commit sha 51ea73afc68ab9f0fc9b074b7b2420fe6f4bdd8e

DATAREDIS-1207 - Fix LettuceStreamCommands.xPending Range conversion.. Original Pull Request: #556

view details

push time in a month

pull request commentspring-projects/spring-data-mongodb

DATAMONGO-2613 - ArrayJsonSchemaObject incorrectly mapped to Document

Thank you @mkurcius. Merged to main line and back ported to 3.0.x, 2.2.x and 2.1.x.

mkurcius

comment created time in a month

push eventspring-projects/spring-data-mongodb

Michal Kurcius

commit sha 25840d61fc29eb3f1858b936a2601f4451663de2

DATAMONGO-2613 - Fix single element ArrayJsonSchemaObject to document mapping. Now toDocument calls toDocument on items correctly. Original Pull Request: #883

view details

push time in a month

push eventspring-projects/spring-data-mongodb

Michal Kurcius

commit sha ee79b9939bf54eb62518f9e13d6643a3c434f9d0

DATAMONGO-2613 - Fix single element ArrayJsonSchemaObject to document mapping. Now toDocument calls toDocument on items correctly. Original Pull Request: #883

view details

push time in a month

push eventspring-projects/spring-data-mongodb

Michal Kurcius

commit sha 433b012b9148b15232d32b07859efc0d9dcff430

DATAMONGO-2613 - Fix single element ArrayJsonSchemaObject to document mapping. Now toDocument calls toDocument on items correctly. Original Pull Request: #883

view details

push time in a month

push eventspring-projects/spring-data-mongodb

Michal Kurcius

commit sha b388659c3fa9cd0b85a38937c130a6a611734d06

DATAMONGO-2613 - Fix single element ArrayJsonSchemaObject to document mapping. Now toDocument calls toDocument on items correctly. Original Pull Request: #883

view details

Christoph Strobl

commit sha c9c005400cbae07c3e660b1efe76bf401a9af4e5

DATAMONGO-2613 - Polishing. Use the opportunity to remove public modifiers from touched test class. Original Pull Request: #883

view details

push time in a month

PR opened spring-projects/spring-data-examples

Add example for (reactive) Repository Metrics

Add example project (MongoDB based) to show how to collect repository method invocation metrics.

+945 -0

0 comment

16 changed files

pr created time in a month

create barnchspring-projects/spring-data-examples

branch : issue/585

created branch time in a month

create barnchchristophstrobl/spring-graalvm-native

branch : issue/192

created branch time in a month

PR opened spring-projects-experimental/spring-graalvm-native

Remove Substitutions avoiding Spring Data runtime class generation.

Spring Data Commons 2.4.0-M2 contains flags that guard class generation when running native image code. Therefore substitutions for the ClassGeneratingEntityIstantiator and ClassGeneratingPropertyAccessorFactory can be removed.

Closes: #209

+0 -45

0 comment

2 changed files

pr created time in a month

create barnchchristophstrobl/spring-graalvm-native

branch : issue/209

created branch time in a month

issue openedspring-projects/spring-security

Provide a ReactiveSecurityEvaluationContextExtension via spring-security-data

Expected Behavior

Add a ReactiveSecurityEvaluationContextExtension (similar to the existing SecurityEvaluationContextExtension) that provides access to the Authentication object obtained from a Reactor Context, so that it can be used within SpEL expressions of annotated Spring Data queries.

@Query("select m from Message m where m.to.id = ?#{ principal?.id }")
Flux<Message> findInbox();

Context

Spring Data Commons 2.4.0.M2 now contains the required SPI (ReactiveEvaluationContextExtension) to implement reactive SpEL evaluation extensions. (see: DATACMNS-1108)

created time in 2 months

PR closed spring-projects/spring-data-redis

DATAREDIS-1190 - Cluster rename now correctly overwrites existing keys

rename(…) behavior in cluster-mode is now aligned with standalone Redis behavior that overwrites the target key if it already exists and the renamed key uses a different slot. Previously, the underlying restore command was called without the replace option which caused BUSYKEY failures.


Related ticket: DATAREDIS-1190.

+34 -4

0 comment

7 changed files

mp911de

pr closed time in 2 months

delete branch spring-projects/spring-data-redis

delete branch : issue/DATAREDIS-1190

delete time in 2 months

push eventspring-projects/spring-data-redis

Mark Paluch

commit sha 1709d195236be43a0d84e9b2673a473cf72f98de

DATAREDIS-1190 - Cluster rename now correctly overwrites existing keys. rename(…) behavior in cluster-mode is now aligned with standalone Redis behavior that overwrites the target key if it already exists and the renamed key uses a different slot. Previously, the underlying restore command was called without the replace option which caused BUSYKEY failures. Original Pull Request: #555

view details

push time in 2 months

push eventspring-projects/spring-data-redis

Mark Paluch

commit sha be8c40b1eb54ba4b8d29587cfe317c039cccb604

DATAREDIS-1190 - Cluster rename now correctly overwrites existing keys. rename(…) behavior in cluster-mode is now aligned with standalone Redis behavior that overwrites the target key if it already exists and the renamed key uses a different slot. Previously, the underlying restore command was called without the replace option which caused BUSYKEY failures. Original Pull Request: #555

view details

push time in 2 months

push eventspring-projects/spring-data-redis

Mark Paluch

commit sha 5c6b0c3fb3e92eef8a38614bc46340cdfa617caa

DATAREDIS-1190 - Cluster rename now correctly overwrites existing keys. rename(…) behavior in cluster-mode is now aligned with standalone Redis behavior that overwrites the target key if it already exists and the renamed key uses a different slot. Previously, the underlying restore command was called without the replace option which caused BUSYKEY failures. Original Pull Request: #555

view details

push time in 2 months

push eventspring-projects/spring-data-redis

Mark Paluch

commit sha e37f2f08eee0175514c59a56ce6e1a1fdcb16e89

DATAREDIS-1190 - Cluster rename now correctly overwrites existing keys. rename(…) behavior in cluster-mode is now aligned with standalone Redis behavior that overwrites the target key if it already exists and the renamed key uses a different slot. Previously, the underlying restore command was called without the replace option which caused BUSYKEY failures. Original Pull Request: #555

view details

Mark Paluch

commit sha fe2c48be1db3bfc1b147a8079c469ba0b670a4c1

DATAREDIS-1190 - Polishing. Make clean after make test to reset potential state-changing configuration updates. Original Pull Request: #555

view details

push time in 2 months

PR closed spring-projects/spring-data-commons

DATACMNS-1763, DATACMNS-1764 - Allow registration of QueryMethod invocation listeners.

We now allow for registering RepositoryMethodInvocationListeners to notify listeners upon repository method invocations (query methods and repository fragments). Listeners are notified upon method completion reporting the repository interface, the invoked methods, duration, outcome and arguments.

+1352 -522

0 comment

18 changed files

mp911de

pr closed time in 2 months

delete branch spring-projects/spring-data-commons

delete branch : issue/DATACMNS-1764

delete time in 2 months

push eventspring-projects/spring-data-commons

Mark Paluch

commit sha e77947f0a5eaa026fb8e3bb8ed700394e0ab78d1

DATACMNS-1763 - Allow registration of QueryMethod invocation listeners. We now allow for registering RepositoryMethodInvocationListeners to notify listeners upon repository method invocations (query methods and repository fragments). Listeners are notified upon method completion reporting the repository interface, the invoked methods, duration, outcome and arguments. Original Pull Request: #455

view details

Mark Paluch

commit sha 35a3d3cde951558c3a912c3f91dcd0f7f218a7a4

DATACMNS-1764 - Allow registration of RepositoryFactory customizers. Original Pull Request: #455

view details

Christoph Strobl

commit sha b667dfa779193e7e3157e031761bea47afe163f8

DATACMNS-1764 - Capture reactive invocation on per subscription basis. Original Pull Request: #455

view details

push time in 2 months

create barnchspring-projects/spring-data-examples

branch : issue/578

created branch time in 2 months

push eventspring-projects/spring-data-commons

Kyrylo Merzlikin

commit sha 2a44d2394ce64155c53a82e61776a6994cfb3eb9

DATACMNS-1754 - Support implementation lookup for nested repositories and fragments. Problem: while repository and fragment interfaces are discovered correctly (provided that considerNestedRepositories=true), their implementations are not found/registered despite proper class naming. Cause: DefaultImplementationLookupConfiguration works in such way that for nested interface (i.e. one whose class name includes name of the enclosing class) expected implementation class name is built including that enclosing class name. In the same time actual implementation class names are always "localized" (i.e. stripped from enclosing class name, if any) before matching. This makes matching implementation classes against nested interface impossible. Solution: when building expected implementation class name, use "local" interface class name, so that it can match any implementation class that follows naming convention "SimpleInterfaceName" + "ImplemenetationPostfix". Original pull request: #460.

view details

Mark Paluch

commit sha e72470993deaac31f8f8af043e7c48aeb8af7869

DATACMNS-1754 - Polishing. Revert bean name change so all nested repository interface components (repository bean, fragment bean, legacy custom implementation bean) remain prefixed with their enclosing type name. Adopt tests. Add test for RepositoryBeanDefinitionRegistrar. Extend documentation. Original pull request: #460.

view details

Mark Paluch

commit sha 67712cc5ec7479b196e410c36e6f30299a9a9f8b

DATACMNS-1764 - Prepare issue branch.

view details

Mark Paluch

commit sha 3f13b18d5d2757211e6be060f65a89bd2a174df8

DATACMNS-1763 - Allow registration of QueryMethod invocation listeners. We now allow for registering RepositoryMethodInvocationListeners to notify listeners upon repository method invocations (query methods and repository fragments). Listeners are notified upon method completion reporting the repository interface, the invoked methods, duration, outcome and arguments.

view details

Mark Paluch

commit sha b3a167c83fa7d7fd547032dedd5b2e22b1a3bd16

DATACMNS-1764 - Allow registration of RepositoryFactory customizers.

view details

Christoph Strobl

commit sha 3195795f537070ae1484a1e955b6b581e9b40405

DATACMNS-1764 - Capture reactive invocation on per subscription basis.

view details

Christoph Strobl

commit sha 1037d3150dccc901901ed9fb0835437db38abdb4

DATACMNS-1764 - Add tests for colelcting invocation on Kotlin suspend functions.

view details

push time in 2 months

push eventspring-projects/spring-data-commons

Mark Paluch

commit sha e19bdb8fc49fa37fda78352995cdac444ea971da

DATACMNS-1758 - Revert optimizations from DATACMNS-1698. We ensure that each EntityCallback retrieval operates on its own List to not share the retrieved callback list with other threads.

view details

Christoph Strobl

commit sha ff0a8f77e81ff198fad06867bcb9d344a465046b

DATACMNS-1767 - Disable ClassGeneratingEntityInstantiator when running native-image. Always fall back to reflection when the system property for org.graalvm.nativeimage.imagecode is set. This is required because on the fly code generation is not supported in this case. Original pull request: #456.

view details

Mark Paluch

commit sha 00d77d03cdb6d480cc711f8ab06ed62472f12a4f

DATACMNS-1767 - Polishing. Reformat code. Use reflection for property access when running within a native image. Original pull request: #456.

view details

Réda Housni Alaoui

commit sha 889ae01c7cb94590915958e8df33759037a8cd9e

DATACMNS-1663 - Support domain events for deletions. Domain events are now also published on calls to CrudRepository.delete(…) and ….deleteAll(…). Original pull request: #436.

view details

Oliver Drotbohm

commit sha f6630a5dd584148830bf68b59956ff4ba0172888

DATACMNS-1663 - Polishing. A few refactorings for more readable code in the publishing method interceptor. Tweaks to the reference documentation to include the CrudRepository methods that now also publish the events. Original pull request: #436.

view details

Mark Paluch

commit sha ebcea509b88e2f75c2f32541d27a2c1e87cb563a

DATACMNS-1768 - Reuse bean state in InstantiationAwarePropertyAccessor when setting multiple properties. We now reuse the new bean in InstantiationAwarePropertyAccessor when setting properties. Previously, we used the initial bean state as the bean was held by a delegate PersistentPropertyAccessor which caused only the last set property to be visible.

view details

Mark Paluch

commit sha 0c37484b193e4e79fde72caaab82c7b18e97d5c5

DATACMNS-1768 - Polishing. Reduce test visibility. Remove forEach detour through stream().

view details

Mark Paluch

commit sha d3af4a79e4c9ebadda92e7cd118ebf4d892de02f

DATACMNS-1231 - Add reactive auditing infrastructure. We now provide a reactive variant for auditing with ReactiveAuditingHandler and ReactiveIsNewAwareAuditingHandler. Extracted common auditing functionality into AuditingHandlerSupport which serves as base class for AuditingHandler and ReactiveAuditingHandler. Original Pull Request: #458

view details

Christoph Strobl

commit sha d4e94109dfddea12f65cbb151f82b43eaac4d4de

DATACMNS-1231 - Introduce dedicated Auditor value object. Original Pull Request: #458

view details

Mark Paluch

commit sha 2355e9dcf32657419acabdefe3ab5611829d723f

DATACMNS-1771 - Upgrade to Vavr 0.10.3.

view details

Mark Paluch

commit sha 13c03e9d17bc983241f3e70166293412c0816bf7

DATACMNS-1772 - Remove SpringDataAnnotationBeanNameGenerator and use BeanNameGenerator directly. We now invoke BeanNameGenerator directly without additional indirections. Previously, SpringDataAnnotationBeanNameGenerator was calling BeanNameGenerator using null for BeanDefinitionRegistry which caused downstream null dereference.

view details

Mark Paluch

commit sha b1ec2a3c036767bcb43428aa16e7db4b9f7798a2

DATACMNS-1740 - Updated changelog.

view details

Mark Paluch

commit sha 18ded821f5fff58cc7e481763d797d9b051d4047

DATACMNS-1741 - Updated changelog.

view details

Mark Paluch

commit sha 8a9033fdd5640c7c310b7cfe3157e46ad4b31c46

DATACMNS-1742 - Updated changelog.

view details

Mark Paluch

commit sha 1c354f6d4ee590e35e94855debfecbc96b23dae3

DATACMNS-1108 - Add support for Reactive SpEL Context retrieval. We now support reactive EvaluationContext retrieval in conjunction with ReactiveEvaluationContextExtensions. Reactive SpEL Context extensions may access Reactor's Context and provide contextual details during SpEL evaluation. Original Pull Request: #454

view details

Mark Paluch

commit sha edcf1a0562475ffc603cbe31de032a3e21d80732

DATACMNS-1108 - Prefer regular methods in ReflectionUtils.findRequiredMethod(…). findRequiredMethod(…) now prefers regular methods over synthetic/bridge methods. This refinement is required for newer Java versions that create synthetic bridge methods using the interface's return type. For SpEL extension introspection we're looking for the most specific return type that may be declared in the extension. Original Pull Request: #454

view details

Mark Paluch

commit sha 0671862ed8e95993f1eb37fafecd29fa7e3feaf6

DATACMNS-1108 - Add repository configuration infrastructure. Add config infrastructure for ReactiveQueryMethodEvaluationContextProvider. Original Pull Request: #454

view details

Mark Paluch

commit sha e9901e7df8cce12072d95351a82a34ff9f5f3b93

DATACMNS-1108 - Polishing. Original Pull Request: #454

view details

Christoph Strobl

commit sha fb15a9647d9da3f4df20748b1b8de0570e4a2579

DATACMNS-1108 - Polishing. Move loop to Set lookup, update Javadoc and remove unused imports. Original Pull Request: #454

view details

Mark Paluch

commit sha e56dcdb461a8e30b8e12e6807efa6d4ca2ab6092

DATACMNS-1726 - Remove Lombok from compile scope. Use Java ServiceLoader to identify annotation processors.

view details

push time in 2 months

push eventspring-projects/spring-data-commons

Christoph Strobl

commit sha ad6b174bafa5dbb33dbe891242bb195b5a9951e6

DATACMNS-1780 - PersistentEntities allows in flight metadata creation if the associated mapping context can be identified. Use a more lenient approach, that allows metadata creation, when looking up persistent entities. This allows eg. a configured AuditingHandler to kick in without having to register an initial entity set in first place.

view details

push time in 2 months

push eventspring-projects/spring-data-mongodb

Christoph Strobl

commit sha c6f12ef0e27fafefee95d4e273e0f2ecfb4cb36f

DATAMONGO-2602 - Upgrade MongoDB drivers to 4.1.0

view details

push time in 2 months

PR opened spring-projects/spring-data-commons

DATACMNS-1780 - PersistentEntities allows in flight metadata creation if the associated mapping context can be identified

Use a more lenient approach, that allows metadata creation, when looking up persistent entities. This allows eg. a configured AuditingHandler to kick in without having to register an initial entity set in first place.

+62 -2

0 comment

5 changed files

pr created time in 2 months

push eventspring-projects/spring-data-commons

Christoph Strobl

commit sha 77d65691a84606f006e71096d4469c24c934300c

DATACMNS-1780 - PersistentEntities allows in flight metadata creation if the associated mapping context can be identified. Use a more lenient approach, that allows metadata creation, when looking up persistent entities. This allows eg. a configured AuditingHandler to kick in without having to register an initial entity set in first place.

view details

push time in 2 months

create barnchspring-projects/spring-data-commons

branch : issue/DATACMNS-1780

created branch time in 2 months

create barnchspring-projects/spring-data-mongodb

branch : issue/DATAMONGO-2557

created branch time in 2 months

PR closed spring-projects/spring-data-mongodb

DATAMONGO-1894 - Use reactive SpEL extensions for SpEL evaluation in query execution.

We now support reactive SpEL EvaluationContextExtension (ReactiveEvaluationContextExtension) when running string-based, reactive query methods.


Related ticket: DATAMONGO-1894 Depends on: spring-projects/spring-data-commons#454

+646 -215

0 comment

33 changed files

mp911de

pr closed time in 2 months

delete branch spring-projects/spring-data-mongodb

delete branch : issue/DATAMONGO-1894

delete time in 2 months

push eventspring-projects/spring-data-mongodb

Christoph Strobl

commit sha 00aaf2145bb22d7f5d3aadbf6e7401056520d0a8

DATAMONGO-2591 - Upgrade MongoDB drivers to 4.1.0-rc0.

view details

Mark Paluch

commit sha 66fae82798acd4d989394ffd92c6a991b3a6a9cb

DATAMONGO-1894 - Use reactive SpEL extensions for SpEL evaluation in query execution. Original Pull Request: #874

view details

Mark Paluch

commit sha 41607b10d07e8c989705f7371aeb9bca4547b28f

DATAMONGO-1894 - Introduce cached ExpressionParser. Original Pull Request: #874

view details

Christoph Strobl

commit sha 873fffa202db778dfb27b2bd48b2375f4b46f853

DATAMONGO-1894 - Polishing. Remove superfluous Optional wrappers and unify SpEL dependency resolution. Original Pull Request: #874

view details

push time in 2 months

PR closed spring-projects/spring-data-commons

DATACMNS-1108 - Add support for reactive SpEL extensions

We now support reactive SpEL extensions through ReactiveEvaluationContextExtension so that reactive query methods can make use of extensions that participate in the reactive flow.


Related ticket: DATACMNS-1108

+1500 -154

0 comment

21 changed files

mp911de

pr closed time in 2 months

delete branch spring-projects/spring-data-commons

delete branch : issue/DATACMNS-1108a

delete time in 2 months

push eventspring-projects/spring-data-commons

Mark Paluch

commit sha 1c354f6d4ee590e35e94855debfecbc96b23dae3

DATACMNS-1108 - Add support for Reactive SpEL Context retrieval. We now support reactive EvaluationContext retrieval in conjunction with ReactiveEvaluationContextExtensions. Reactive SpEL Context extensions may access Reactor's Context and provide contextual details during SpEL evaluation. Original Pull Request: #454

view details

Mark Paluch

commit sha edcf1a0562475ffc603cbe31de032a3e21d80732

DATACMNS-1108 - Prefer regular methods in ReflectionUtils.findRequiredMethod(…). findRequiredMethod(…) now prefers regular methods over synthetic/bridge methods. This refinement is required for newer Java versions that create synthetic bridge methods using the interface's return type. For SpEL extension introspection we're looking for the most specific return type that may be declared in the extension. Original Pull Request: #454

view details

Mark Paluch

commit sha 0671862ed8e95993f1eb37fafecd29fa7e3feaf6

DATACMNS-1108 - Add repository configuration infrastructure. Add config infrastructure for ReactiveQueryMethodEvaluationContextProvider. Original Pull Request: #454

view details

Mark Paluch

commit sha e9901e7df8cce12072d95351a82a34ff9f5f3b93

DATACMNS-1108 - Polishing. Original Pull Request: #454

view details

Christoph Strobl

commit sha fb15a9647d9da3f4df20748b1b8de0570e4a2579

DATACMNS-1108 - Polishing. Move loop to Set lookup, update Javadoc and remove unused imports. Original Pull Request: #454

view details

push time in 2 months

PR closed spring-projects/spring-data-redis

DATAREDIS-1173 - Close connection unsubscribes from all channels incorrectly.

The LettuceSubscription doClose method calls doUnsubscribe with an empty byte array, which results in a call to Redis of:

UNSUBSCRIBE "" This command will unsubscribe from a channel with the name "" However, we believe the intended behavior is to unsubscribe from all channels, which can be done by not sending any argument to doUnsubscribe, resulting in a call to Redis of:

UNSUBSCRIBE We wrote a failing and passing test showing the problem. We could not find a way to expose the issue by calling doClose on the subscription (because doClose also releases the connection), so we had to call unsubscribe directly. We are not sure where this belongs in your testing pyramid.

Co-authored-by: Sarah Abbey sabbey@pivotal.io Co-authored-by: Murtuza Boxwala mboxwala@pivotal.io Co-authored-by: Jens Deppe jdeppe@vmware.com

+51 -2

2 comments

2 changed files

sabbeyPivotal

pr closed time in 2 months

pull request commentspring-projects/spring-data-redis

DATAREDIS-1173 - Close connection unsubscribes from all channels incorrectly.

Thanks for the fix. Back ported to 2.1.x, 2.2.x and 2.3.x

sabbeyPivotal

comment created time in 2 months

push eventspring-projects/spring-data-redis

Sarah

commit sha 17b0fbcc63c6d41928f91fbc75d8f0bd7a427577

DATAREDIS-1173 - Fix channel unsubscribe on close. Original Pull Request: #540

view details

Mark Paluch

commit sha e4fd036d8162206e9c360d1ff02cf2a5eba40560

DATAREDIS-1173 - Correctly unsubscribe from patterns/channels through LettuceSubscription. doPUnsubscribe(…) and doUnsubscribe(…) now consider the all flag to unsubscribe from all subscribed patterns/channels. Previously, both methods didn't consider all and were invoked with an empty byte array which unsubscribed from an empty pattern/channel name and left subscriptions active. Original Pull Request: #549

view details

Mark Paluch

commit sha d054e2e5deb20ac62ad4bbe0725d9d78f24d665d

DATAREDIS-1173 - Polishing. Add Override annotations and Javadoc. Reformat test. Original Pull Request: #549

view details

push time in 2 months

PR closed spring-projects/spring-data-redis

DATAREDIS-1173 - Correctly unsubscribe from patterns/channels through LettuceSubscription

doPUnsubscribe(…) and doUnsubscribe(…) now consider the all flag to unsubscribe from all subscribed patterns/channels. Previously, both methods didn't consider all and were invoked with an empty byte array which unsubscribed from an empty pattern/channel name and left subscriptions active.


Related ticket: DATAREDIS-1173 Should be forward/backported to all maintained versions.

+261 -106

1 comment

5 changed files

mp911de

pr closed time in 2 months

delete branch spring-projects/spring-data-redis

delete branch : issue/DATAREDIS-1173

delete time in 2 months

push eventspring-projects/spring-data-redis

Sarah

commit sha aa20c4ede3ac6bd80f47656e32e6396602c12403

DATAREDIS-1173 - Fix channel unsubscribe on close. Original Pull Request: #540

view details

Mark Paluch

commit sha 27c3d0962d7936b4c0a1b431cd8a05b5a1a80755

DATAREDIS-1173 - Correctly unsubscribe from patterns/channels through LettuceSubscription. doPUnsubscribe(…) and doUnsubscribe(…) now consider the all flag to unsubscribe from all subscribed patterns/channels. Previously, both methods didn't consider all and were invoked with an empty byte array which unsubscribed from an empty pattern/channel name and left subscriptions active. Original Pull Request: #549

view details

Mark Paluch

commit sha 164bdc97fbd51d92d87a0ea81a7fd68fc64d07da

DATAREDIS-1173 - Polishing. Add Override annotations and Javadoc. Reformat test. Original Pull Request: #549

view details

push time in 2 months

push eventspring-projects/spring-data-redis

Sarah

commit sha 43569fb10454b8ca30141f7c4319e81b4e75bcec

DATAREDIS-1173 - Fix channel unsubscribe on close. Original Pull Request: #540

view details

Mark Paluch

commit sha 4ab8983b92c48ca8e0f20714cdfa75db0fb34540

DATAREDIS-1173 - Correctly unsubscribe from patterns/channels through LettuceSubscription. doPUnsubscribe(…) and doUnsubscribe(…) now consider the all flag to unsubscribe from all subscribed patterns/channels. Previously, both methods didn't consider all and were invoked with an empty byte array which unsubscribed from an empty pattern/channel name and left subscriptions active. Original Pull Request: #549

view details

Mark Paluch

commit sha 2a166779282a1b6f254a10b5e4e279dd7be62ed5

DATAREDIS-1173 - Polishing. Add Override annotations and Javadoc. Reformat test. Original Pull Request: #549

view details

push time in 2 months

push eventspring-projects/spring-data-redis

Sarah

commit sha f819440db4f00016803e0a8711dcb5b907cf53c0

DATAREDIS-1173 - Fix channel unsubscribe on close. Original Pull Request: #540

view details

Mark Paluch

commit sha de234507e9a3b0e9ecae4118d568b48e59af9b90

DATAREDIS-1173 - Correctly unsubscribe from patterns/channels through LettuceSubscription. doPUnsubscribe(…) and doUnsubscribe(…) now consider the all flag to unsubscribe from all subscribed patterns/channels. Previously, both methods didn't consider all and were invoked with an empty byte array which unsubscribed from an empty pattern/channel name and left subscriptions active. Original Pull Request: #549

view details

push time in 2 months

more