profile
viewpoint

ChromeDevTools/awesome-chrome-devtools 4112

Awesome tooling and resources in the Chrome DevTools & DevTools Protocol ecosystem

pbakaus/scroller 3753

Accelerated panning and zooming for HTML and Canvas

GoogleChromeLabs/ProjectVisBug 3730

FireBug for designers › Edit any webpage, in any state https://a.nerdy.dev/gimme-visbug

ampproject/amp-wp 1556

Enable AMP on your WordPress site, the WordPress way.

pbakaus/viewporter 594

Meta viewport done right.

ampproject/ampstart 416

AMP Start source code and templates .

ampproject/amp.dev 363

The AMP Project Website.

pbakaus/domvas 346

Domvas implements the missing piece that connects the DOM and Canvas.

pbakaus/transformie 184

Transformie is a javascript plugin that comes in less than 5k that you embed into web pages and that brings you CSS Transforms by mapping the native IE Filter API to CSS trandforms as proposed by Webkit.

issue commentgoogle/web-stories-wp

Add confirm dialog when trashing a story

Most app and editor separate managing and creating. I would like remove the Move to trash button from the Document settings and allow managing stories only in the dashboard. @pbakaus If you're good with this?

yep. @o-fernandez chime in if you have thoughts here as well. I always found it supremely strange behavior in Google Docs, for instance..

swissspidy

comment created time in 4 days

issue commentgoogle/web-stories-wp

Changing font family can result in "multiple" for font weight

/cc @o-fernandez

My vote goes to allowing 'faux bold' (system level bolding) as fallback for when there's no bold variant.

miina

comment created time in 5 days

issue closedgoogle/web-stories-wp

Background img does not respect containment boundaries at center position

Bug Description

When the background layer is dragged and perfectly centered, it ignores the containment/boundaries of the page.

Expected Behaviour

Background should always be covering the page.

Steps to Reproduce

Drag the background img, and position exactly in the center. For more pronounced effect, drag your cursor to the bottom of the page.

Screenshots

Screen Shot 2020-02-22 at 7 56 55 PM


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

closed time in 5 days

pbakaus

issue commentgoogle/web-stories-wp

Background img does not respect containment boundaries at center position

Can't repro anymore, let's close for now.

pbakaus

comment created time in 5 days

issue commentgoogle/web-stories-wp

UI settings don't persist between reloads

+1. We can start with localStorage (I wouldn't do sessionStorage for now, as I predict users might want some level of persistence per browser).

pbakaus

comment created time in 14 days

issue commentgoogle/web-stories-wp

Scrollbars should auto-hide (respect OS level settings)

@swissspidy nah, @samitron7 is actually the one who keeps bugging me about this :)

pbakaus

comment created time in 14 days

issue commentgoogle/web-stories-wp

Font Picker: Search fonts

I think this is great as first step (popularity from Google fonts).

jauyong

comment created time in 14 days

issue openedgoogle/web-stories-wp

Scrollbars should auto-hide (respect OS level settings)

Bug Description

Currently, the custom styled scrollbars are not auto-hidden on Mac OS when a trackpad is used (default behavior). This is due to the fact that styling them overrides the automatic switching. I did some research and Filament Group found a way to do this, see https://www.filamentgroup.com/lab/scrollbars/

Expected Behaviour

Scrollbars should only show on scroll when a trackpad is used with the following setting in MacOS "Show scrollbars":

image

Steps to Reproduce

Open the editor. Click on a text element. Observe an always visible scrollbar in e.g. the design panel.

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

created time in 16 days

pull request commentgoogle/web-stories-wp

[WIP] Minimum element sizes

+1. Let's please optimize for getting this merged. We can address edge cases further down the road.

merapi

comment created time in 16 days

pull request commentgoogle/web-stories-wp

[WIP] Minimum element sizes

Definitely B.

merapi

comment created time in 17 days

Pull request review commentgoogle/web-stories-wp

Allow changing number values with up/down keys

 function Numeric({   const [dot, setDot] = useState(false);   const ref = useRef(); +  const handleUpDown = useCallback(+    ({ key, altKey }) => {+      if (isMultiple) {+        return;+      }++      let newValue;+      const diff = Big(float && altKey ? 0.1 : 1);+      if (key === 'ArrowUp') {+        // Increment value+        newValue = Big(value).plus(diff);+      } else if (key === 'ArrowDown') {+        // Decrement value+        newValue = Big(value).minus(diff);+      }+      onChange(parseFloat(newValue.toString()));+    },+    [onChange, value, isMultiple, float]+  );++  useKeyDownEffect(+    ref,+    { key: ['up', 'alt+up', 'down', 'alt+down'], editable: true },

I modeled this after Chrome DevTools, where shift increments in 10, and alt increments 0.1. But I'm OK either way.

winterDroid

comment created time in 17 days

pull request commentgoogle/web-stories-wp

Templates: Added static Wellbeing template

re: font: Heard back from Google Fonts team, the relevant blocking bug is https://github.com/google/fonts/issues/23 and it looks like it's getting prioritized (yay!).

mariano-formidable

comment created time in 18 days

pull request commentgoogle/web-stories-wp

Templates: Added static Wellbeing template

Since we cannot upload SVGs to the media library, we would need to bundle these shapes as part of the plugin, adding them to the currently hardcoded list of masks, no?

I wasn't sure if I should just be adding in new shapes to the shape library willy nilly, but now that I think of it, these shapes are pivotal for this template and they are unique compared to the existing ones (meaning you can just stretch/scale/transform the existing shape to make these new ones)... so okay, I'll figure out how to add them to the hardcoded list and update this template to use them.

Yes, perfect. I think the Figma actually outlines all shapes per template that would appear in the shape library, @samitron7 to comment on it.

mariano-formidable

comment created time in 18 days

pull request commentgoogle/web-stories-wp

Templates: Added static Wellbeing template

@pbakaus @mariano-formidable Source Serif Pro is only available in 400 (regular), 600, and 700 on Google Fonts. Figma uses 300. In the editor we currently only show available font weights. Should we perhaps change that and show all? Not sure how browsers would display that font in 300. Perhaps they won't do anything, which could be weird UX.

That's super strange...I just opened a thread with the fonts team to find out what's going on there.

mariano-formidable

comment created time in 18 days

issue commentgoogle/web-stories-wp

Color Picker - Remove Conic Gradient

OK! I'll say that this was my go-to example to demonstrate a cool gradient, but @samitron7 disagrees, and I don't care too strongly :) Fine by me.

jauyong

comment created time in 18 days

pull request commentgoogle/web-stories-wp

Templates: Added static Wellbeing template

1.) The design calls for Source Serif Pro at a lighter font-weight than the editor supports (for this font). So, lots of of the titles will appear thicker in the generated template than in the designs.

Why do we not support the lighter font-weight? Is it just not available on Google Fonts, or are we somehow not making it available in the editor?

2.) We cannot upload custom SVGs so instead of using the shapes found in the Wellbeing design, I used the available shapes found in the editor and molded them as best I could to match the design.

Why can't we upload custom SVGs? I know we have a problem calculating the size for ones uploaded to the media gallery, but why can't we make it work for templates?

Getting the template shapes into the shape panel is important /cc @samitron7 (but possibly for the v2 PR).

3.) Finally, the editor doesn't support transparent shapes with borders so I couldn't create the thing outlines that appear throughout the design.

Do you have an example for this? Is this one of those features that we should add partial support for so that it can display in the editor, but you can't modify?

mariano-formidable

comment created time in 18 days

issue commentgoogle/web-stories-wp

Custom calendar implementation

My point was that replacing the current picker is urgent (P0), customizing the styles is not (P2 or so), which is why I requested the split. Of course, if it is a matter of minutes, makes sense to do it in one PR.

miina

comment created time in 19 days

issue commentgoogle/web-stories-wp

Font Picker: Search fonts

+1. I'd do popular fonts after launch.

jauyong

comment created time in 19 days

pull request commentgoogle/web-stories-wp

Allow changing number values with up/down keys

For float values, its value will first be rounded up/down to an integer and afterwards incremented / decrements. @samitron7 @pbakaus does that make sense?

I would personally apply the Chrome DevTools philosophy here:

  1. Up/down on a float changes just the integer-part, so you go from 1.5 to 2.5 and so on
  2. Alt+up/down on a float increments the first fractional part, so you go from 1.5 to 1.6 and so on
winterDroid

comment created time in 20 days

issue commentgoogle/web-stories-wp

Font Picker: Search and Popular fonts

^ @samitron7

jauyong

comment created time in 21 days

issue closedgoogle/web-stories-wp

Switch to pointer events everywhere

Feature Description

In preparation for tablets


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

closed time in 23 days

jauyong

issue commentgoogle/web-stories-wp

Switch to pointer events everywhere

Closing this as this isn't super actionable on its own. We'll revisit when we ship Ipad support.

jauyong

comment created time in 23 days

issue closedgoogle/web-stories-wp

Unwanted Letterboxing

Bug Description

Images that span the whole page in the editor are shown with letterboxing in preview. Obviously the user could set the image as a background for this purpose, but it should still match Possibly due to the new aspect ratio?

Expected Behaviour

Editor should match preview

Steps to Reproduce

  1. Add an image to the page
  2. Stretch the image to fill the page (do not set as background or use fill)
  3. save and preview the story

Screenshots

Editor: image

Preview (Notice white padding / letterboxing): image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

closed time in 23 days

jauyong

issue commentgoogle/web-stories-wp

Unwanted Letterboxing

This is fixed now that the new auto overflowing safe zone is implemented.

jauyong

comment created time in 23 days

issue commentgoogle/web-stories-wp

Clarify edge cases of using bold markup and bold font weights

@o-fernandez could you make sure the spec fixed if needed here?

dvoytenko

comment created time in 23 days

issue closedgoogle/web-stories-wp

The user should be able to rotate (change the direction) of a Fill or Background image

Feature Description

<!-- Please describe clear and concisely which problem the feature would solve or which publisher needs it would address. -->

If the image in the Media Library is on the side / incorrect direction, it's not possible to change that for a background/Fill image.

Note: Undo-Redo arrows were the ones that caught the eye when automatically started looking for a place to rotate the image.

how_to-rotate


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

closed time in 23 days

miina

issue commentgoogle/web-stories-wp

The user should be able to rotate (change the direction) of a Fill or Background image

I'll close this for now, due to Sam's comment and as there's now an easy workaround (foreground rotated video or image), due to the new way we handle the safe zone / bleed.

miina

comment created time in 23 days

issue commentgoogle/web-stories-wp

Color Picker - Remove Conic Gradient

Can you paste the discussion inline here? I'd love to understand the reasoning here. /cc @samitron7

jauyong

comment created time in 24 days

issue openedgoogle/web-stories-wp

Media gallery weirdly drops lots of items when a video is used as background

Bug Description

Somehow the media gallery wipes out all videos but one when a background video is used.

Expected Behaviour

Media...should stay in the media gallery..

Steps to Reproduce

  1. Click on "Video" filter in media tab
  2. Drag any image into the background of the current page
  3. Observe how all videos but one in the media tab vanish.

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! --> image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

created time in 24 days

pull request commentgoogle/web-stories-wp

[TEMPLATE] Fitness

Nice! Haven't looked at the actual code closely, but I noticed that the text is cut off at the top in the screenshot...any idea why?

littlemilkstudio

comment created time in 24 days

issue commentgoogle/web-stories-wp

Should not be able to copy/paste the background layer

I'd say it can "replace" the background layer in the page it is pasted. So, if pasted on the same page, do nothing (in essence). If pasted in another page, replace that page's background. At least that'd match my expectation.

ah yes, haven't considered that..that makes a lot of sense!

pbakaus

comment created time in 24 days

issue openedgoogle/web-stories-wp

Should not be able to copy/paste the background layer

Bug Description

fun bug: I can copy the background and then paste it a couple of times to have unlimited background layers

Expected Behaviour

Copy/pasting the background layer / page should do one the following instead:

  1. Not do anything (MVP)
  2. Insert the picture in non-full-bleed state (maybe?)
  3. Duplicate the page (that would be pretty cool, but curious what @samitron7 and @o-fernandez think).

Steps to Reproduce

<!-- Please provide detailed steps on how to reproduce the bug. -->

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

created time in 24 days

issue openedgoogle/web-stories-wp

Scroll wheel in edit mode does not zoom the image/video

Bug Description

Scroll wheel in edit mode does not zoom the image/video

Expected Behaviour

Scroll wheel in edit mode should zoom the image/video.

Steps to Reproduce

<!-- Please provide detailed steps on how to reproduce the bug. -->

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

created time in 24 days

issue openedgoogle/web-stories-wp

Arrow keys in edit mode move the outer element, not the mask

Bug Description

Arrow keys in edit mode move the outer element, not the mask

Expected Behaviour

Arrow keys in edit mode should reposition the inner image/video, not the outer element.

Steps to Reproduce

<!-- Please provide detailed steps on how to reproduce the bug. -->

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

created time in 24 days

issue openedgoogle/web-stories-wp

Edit mode slider has no visible focus state

Bug Description

The edit mode slider has no visible focus state. This is important for accessibility.

image

Expected Behaviour

There should be a visible focus state when the slider is in focus.

Steps to Reproduce

<!-- Please provide detailed steps on how to reproduce the bug. -->

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

created time in 24 days

pull request commentgoogle/web-stories-wp

Universal fullbleed and safezone

@wassgha hey Wassim, what's the latest here? This looks ready to merge with the exception of merge conflicts, or is there more work to be done?

wassgha

comment created time in 24 days

pull request commentgoogle/web-stories-wp

Do not include `@wordpress/element` script in bundle

thanks, this sounds like a good plan.

swissspidy

comment created time in a month

push eventgoogle/web-stories-wp

Diego Varese

commit sha 9a032e7647c645ef178742f3e4ab155b9e5115a8

Change the way videoAccessibility.js resolves an empty string in the text input. Currently we default to the resource if the poster/title/alt strings are falsey. This is obviously a problem for an empty string (which is a valid value for the title and alt fields). To fix this, fallback to the resource only for undefined (which is the value that is returned when no changes have been made via the inspector). Additionally, when calling pushUpdate default to null if it's an empty string. Unfortunately having an empty string will result in incorrect logic in updateProperties.js as it ignores the update when in commit mode.

view details

Diego Varese

commit sha 98abe2be146e07d006dc398b75509925ab6f27fc

Update output.js In video/output.js, only default to the resource when it's undefined.

view details

Diego Varese

commit sha 85d4028b5d8ff2a730939d65bd1da961a41eb8a6

Update output.js Add a test to video/output.js for the fallback logic.

view details

Diego Varese

commit sha 978c2b6470f8a6890cb6063a248c446e41ce8982

Merge branch 'master' into diegovar-rampup

view details

Diego Varese

commit sha 800a6ad942ff82e2d063e6b497ffa34870402503

apply fixes

view details

Diego Varese

commit sha 566f51381234f4a16d9b6852500a3fc4eed3f451

Add image changes

view details

Pascal Birchler

commit sha 58ceb0128cdecac8e76600793aaef680854b6b03

Merge branch 'master' into diegovar-rampup

view details

Paul Bakaus

commit sha 69c92d8e7bcd5e7c3c4c3b8ef26902cdc8fd4cb2

Merge pull request #1340 from google/diegovar-rampup Fix fallback logic for image and video element accessibility and title fields

view details

push time in a month

delete branch google/web-stories-wp

delete branch : diegovar-rampup

delete time in a month

PR merged google/web-stories-wp

Reviewers
Fix fallback logic for image and video element accessibility and title fields Type: Bug cla: yes

This fixes #1128 (the issue where the alt and title tags cannot be set to an empty string in the inspector).

I believe this is a stop-gap fix. A more comprehensive fix for the meaning of null/emptyString/undefined for properties in general needs to be thought out.

+111 -50

4 comments

6 changed files

diegovar

pr closed time in a month

issue closedgoogle/web-stories-wp

Unable to clear alt text, video and image elements

Bug Description

I am unable to clear the alt / title accessibility fields on the video element. When I empty the field, either by using the delete key or cross, it refills with default value again.

Expected Behaviour

User should be able to clear field.

Steps to Reproduce

See video.

Screenshots

https://youtu.be/DEq9MiOyjI4

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

closed time in a month

spacedmonkey

push eventgoogle/web-stories-wp

Diego Varese

commit sha f5210f720c7731531f8d57e0a1b7f38279df561e

hide link panel when an element is fill Before, the link input was disabled when selecting an image of type fill. This changes the behaviour to hide the link panel if one of the selected elements is filling the screen. Note this allows applying a link to multiple photos/videos.

view details

Pascal Birchler

commit sha 0124f992ef325f557df16ccda7f521a761c55d73

Merge branch 'master' into remove-link-panel-fill

view details

Paul Bakaus

commit sha ddb405c3b7a3c78164ae5a366e008841965bd621

Merge pull request #1355 from google/remove-link-panel-fill hide link panel when an element is fill

view details

push time in a month

delete branch google/web-stories-wp

delete branch : remove-link-panel-fill

delete time in a month

PR merged google/web-stories-wp

Reviewers
hide link panel when an element is fill cla: yes

Summary

Before, the link input was disabled when selecting an image of type fill.

This changes the behaviour to hide the link panel if one of the selected elements is filling the screen. Note this allows applying a link to multiple photos/videos.

Fixes #1184

+3 -4

2 comments

2 changed files

diegovar

pr closed time in a month

issue closedgoogle/web-stories-wp

Remove Link Option on Full Bleed Media

Bug Description

Images that are the background / fill / full bleed should not have the option to set a link

Expected Behaviour

The Link section in the design panel should not show up at all for images that are:

  1. set as background
  2. Uses the "Fill" functionality
  3. Is stretched manually to be full bleed

Steps to Reproduce

<!-- Please provide detailed steps on how to reproduce the bug. -->

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Auto-Save

@o-fernandez it'd be great if you could take this on and make sure the product definition/needs for both 1.0 and beyond is clear. You might use my prev spec on the topic as foundation. Does that work for you?

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Auto-Save

@miina so, WP expects you to effectively press "save" button manually from time to time to explicitely save the state? otherwise shows this? If that's like it works, I'm torn - I kinda like the simplicity of conflating auto-save and regular save. Thoughts, @samitron7 and @o-fernandez?

jauyong

comment created time in a month

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 655ec9aca12bdc08fa40ed98d6e574fd8ac0668d

Fix useLoadStory to load the publish date in UTC time

view details

Paul Bakaus

commit sha 6a49620ecf8e1045039970191132e2a96983ff5c

Merge pull request #1297 from cvolzke4/fix/1216-publish-date-utc Fix useLoadStory to load the publish date in UTC time

view details

push time in a month

issue commentampproject/amphtml

Allow `clip-path` in AMP (web-only)

Amazing, thank you Greg!!

wassgha

comment created time in a month

issue commentgoogle/web-stories-wp

Stories need to appear in the default loop / WP homepage feed

What are people thoughts on this ?

Would we create a new post with an embedded version ?

To a expand on the idea, when a story is created, also create a new post ( post with post type of post), that has the same name. The content this post, would have the embedded story block.

It is a little wasteful to create a secondary post for each story, but may work around a lot of the limitation of WP.

That's the plan, actually :)

pbakaus

comment created time in a month

issue commentgoogle/web-stories-wp

Should not be able to save story without title

Yes, but we should encourage it. Sam has mocks for this soon. /cc @samitron7

spacedmonkey

comment created time in a month

MemberEvent
MemberEvent
MemberEvent

issue commentgoogle/web-stories-wp

Optimize template assets

@jauyong stable for now.

swissspidy

comment created time in a month

issue commentgoogle/web-stories-wp

Optimize template assets

These should be offloaded to a CDN. We should not even 'download' them into the media gallery - we fully expect and recommend authors to switch them out anyway.

swissspidy

comment created time in a month

MemberEvent

issue commentgoogle/web-stories-wp

Stories need to appear in the default loop / WP homepage feed

  • If a story appears on the homepage, should it also appear in other places like

    • Search
    • Category archive
    • Tag archive
    • Author archive
    • Date based archives ( www.example.com/2019/01/01 )
    • Next and previous links in post pages.
  • Should stories appear in the post REST API endpoint? For those doing headless WP.

  • Is there a figma design for what a story looks like on a home page?

  • What about themes that use excerpts on archive / home page?

Ideally all of this, but I'm scared to patch the loop to include it as custom post type in everything as I don't think themes are well prepared for it. Hence, the MVP being a Gutenberg block, and an optional but suggested post creation workflow.. ideas here are welcome though!

pbakaus

comment created time in a month

issue commentgoogle/web-stories-wp

Page grid: clicking on the page should select it in the canvas

Also isn't working for me.

dvoytenko

comment created time in a month

issue commentgoogle/web-stories-wp

Links on text selection

@wassgha yes! /cc @barklund and @dvoytenko

wassgha

comment created time in a month

issue commentgoogle/web-stories-wp

Stories need to appear in the default loop / WP homepage feed

I think this should be an opt in feature. Displaying stories on the home page / archive pages may have unknown side effects and may break sites. Other CPT do not do this and forcing stories may upset some users.

A custom block and a widget to embed stories is a good way to get stories out their corner...

Yep, we will most likely make it an explicit user choice (the creation of a new post with story embedded).

pbakaus

comment created time in a month

Pull request review commentgoogle/web-stories-wp

Exit editmode with both `esc` and `tab`

 function EditLayerForElement({ element }) {    const focusCanvas = useFocusCanvas(); -  useKeyDownEffect(ref, { key: 'esc', editable: true }, () => clearEditing(), [+  const key = ['esc', 'tab'];

I think the main question is whether there's another way to get to the scale slider using the keyboard...if not, then I think it makes sense to revert course and not modify this behavior (so we treat edit mode as a state that captures focus, and you always need esc to get out of it).

barklund

comment created time in a month

issue commentgoogle/web-stories-wp

Font Picker: Final implementation w/ inline font previews

@tomasdev that's great to hear, thanks for the confirmation that that strategy works! OK, we'll focus on a virtual scroller then, which will dynamically load the current set of fonts when they're visible.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Font Picker: Final implementation w/ inline font previews

You can use https://developers.google.com/fonts/docs/getting_started#optimizing_your_font_requests to get fonts subsetted to only the characters you need, and https://developers.google.com/fonts/docs/developer_api to get a list of the public library :)

thanks @davelab6! These are very helpful, and we're already using both :) Our concrete questions is more around how to render a preview of all fonts in a way that isn't super slow to load or crashes the browser...we have a few options:

  1. convert font name previews to actual images (to not have to load fonts)
  2. load all multi hundred subsetted fonts (might crash browser?? IDK)
  3. convert subsetted fonts to svgs and use those (similar to 1)

Any thoughts on that?

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Dashboard: Custom sort options added to stories API

Actually Sam and I killed "last opened". That should make it easier ;)

BrittanyIRL

comment created time in a month

issue commentgoogle/web-stories-wp

Font Picker: Final implementation w/ inline font previews

@dvoytenko I think we should try this!

One more optimization is to skip the base64 step and concat the binary woff/woff2 files into a single binary that we then split again based on some safe byte delimiter.

I'm fairly concerned about the memory overhead of having hundreds of fonts, albeit tiny, loaded into the editor at the same time, but we should try it out and see how it performs.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Change pattern for background media overlay

@pbakaus do we want to persist this overlay color between background elements and associate the information with the page overall? If I e.g. add a background element, add an overlay to it, change the color to blue and then replace the background element with another image, do we want to keep information on the new background image including a) that it has an overlay at all and/or b) the exact overlay including type and color (and color stops if gradient)?

Or do we simply associate the background overlay information directly with the element in question, so that if the element is removed (or replaced or unset as background), all overlay information is lost.

It should be associated with the page, not background media, as I think it would be fairly annoying to drag another image into the background after you carefully designed a nice overlay gradient, only for it to be wiped away then.

barklund

comment created time in a month

issue commentgoogle/web-stories-wp

Unwanted Letterboxing

This will be much more obvious, and much easier to fix when we implement the auto-overflowing safe zone.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Stories need to appear in the default loop / WP homepage feed

All of this sounds good to me, but I want to bring in another thing we need: From the story editor, there should be an affordance to create a new post after publishing the story, in which case we should generate a standard post (not a custom post) prefilled with the correct gutenblock for the story, and then directly open it for edit.

/cc @samitron7 for thoughts

pbakaus

comment created time in a month

issue commentgoogle/web-stories-wp

History: Unsetting background media breaks the history

I'd rate this P0 because there's an element of data loss here.

miina

comment created time in a month

issue commentgoogle/web-stories-wp

Preview of the published story

@miina all of this sounds great. Let's do it! Thanks!

dvoytenko

comment created time in a month

issue commentgoogle/web-stories-wp

Change pattern for background media overlay

Yep, description LGTM. Removing myself from the ticket for now, I think this can be implemented.

barklund

comment created time in a month

Pull request review commentgoogle/web-stories-wp

Replace boolean system to bind Bold in text element by Font Weight.

 function TextDisplay({             <BackgroundSpan               {...props}               dangerouslySetInnerHTML={{-                __html: draftMarkupToContent(content, bold),+                __html: content,

To be safe, yes, let's use the list above, and also font-family and height. So for the time being, these are the global (element level) properties:

  • line height
  • alignment
  • fill
  • text color
  • padding
  • font family
  • font size

but @o-fernandez is also working it into the spec as I write (thanks!).

obetomuniz

comment created time in a month

issue commentgoogle/web-stories-wp

Preview of the published story

SGTM!

dvoytenko

comment created time in a month

issue commentgoogle/web-stories-wp

Media Library - Hover/Focus States and Actions

What's the status here? I see @samitron7 assigned but AFAIK the designs exist?

spacedmonkey

comment created time in a month

issue closedgoogle/web-stories-wp

Call To Action Links

As an editor I want to be able to add CTA links to a page

Feature Brief - Product spec: Links

Acceptance Criteria

  1. The Stories Format supports 2 types of CTA: 1-tap (Annotated) and 2-tap (Bottom Of The Page) links
  2. You can only have one special element on the top grid layer. This means you: Can only have a 1-Tap CTA OR a page attachment but not both on a page Can have 2-Tap links with either a 1-Tap link OR a page attachment on the same page Can have as many 2-Tap links on the page as you want
  3. 1-click links, we only allow one CTA layer per page, but that layer can contain multiple 1-click links
  4. 2-Tap First tap opens a tooltip to expose a link out icon which when tap on takes you to the desired location.
  5. 1-tap You can think of 1-Tap CTA as a grouping of links that must reside in a container on the bottom 20% of the page.

See the Design for more details

Task list:

  • [x] Initial link implementation with 2-tap only
  • [x] Fetch page description and image (requires server-side code) + loading state indicators
  • [x] Ability to change the description and image
  • [x] Visual guide for 2-tap / 1-tap + automatic conversion
  • [x] URL Validation
  • [x] Navigation & system layer safe zone
  • [x] Instruction modal
  • [ ] Keyboard shortcuts
  • [ ] Interaction with drop targets
  • [ ] Inline text links

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Call To Action Links

Closing this for now, due to de-prioritization of 1-tap links.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Design Panel - Element Alignment

This isn't working correctly. Too many buttons are disabled for single elements (for single elements, they should align against the page). /cc @samitron7

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Design Panel - Video

Please close or modify so that it's clear what the actual work here is, from the title alone.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Design Panel - Shape

Please close or rename to make clear what the actual work is.

jauyong

comment created time in a month

issue closedgoogle/web-stories-wp

Dashboard - My Stories

Feature description

Displays all user created stories, with support for pagination, ability to click into stories to preview and edit

Feature Brief - Epic: Dashboard


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • <!-- One or more bullet points for acceptance criteria. -->

Implementation brief

  • <!-- One or more bullet points for how to technically resolve the issue. For significant Implementation Design, it is ok use a Google document accessible by anyone. -->

QA testing instructions

  • <!-- One or more bullet points to describe how to test the implementation in QA. -->

Demo

  • <!-- A video or screenshots demoing the implementation. -->

Changelog entry

  • <!-- One sentence summarizing the PR, to be used in the changelog. -->

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Dashboard - My Stories

Another ticket so large that it is not actionable or useful. Closing for now. Let's file smaller, doable tickets.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Finalize title input (make wider, center on large screens)

What's the UX still required to finish this?

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Implement multi-resolution preview as pre-publish step

Split into two issues, other issue is now at https://github.com/google/web-stories-wp/issues/1163

jauyong

comment created time in a month

issue openedgoogle/web-stories-wp

Add page preview that 'plays' a page in the editor

Feature Description

Implement the in-page preview that plays back a page in the editor. Has a spec but no UX yet.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

created time in a month

issue closedgoogle/web-stories-wp

Page - Templates

Feature description

Allows users to quickly create a new story from scratch, or start with one of the 10+ included templates


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • <!-- One or more bullet points for acceptance criteria. -->

Implementation brief

  • <!-- One or more bullet points for how to technically resolve the issue. For significant Implementation Design, it is ok use a Google document accessible by anyone. -->

QA testing instructions

  • <!-- One or more bullet points to describe how to test the implementation in QA. -->

Demo

  • <!-- A video or screenshots demoing the implementation. -->

Changelog entry

  • <!-- One sentence summarizing the PR, to be used in the changelog. -->

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Page - Templates

Closing this ticket as it is not actionable. Please file smaller, actionable issues.

jauyong

comment created time in a month

issue closedgoogle/web-stories-wp

Page: Overview

Combination page that shows: Recent created stories, quick access to templates and quick access to "new story" flow

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Page: Overview

Closing this ticket as it is not actionable. Please file smaller, actionable issues.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Page Attachments

Note that this is now in the critical path for launch, so I elevated it. This is due to the deprecation of 1-tap links.

jauyong

comment created time in a month

issue closedgoogle/web-stories-wp

Design Panel - Animation

As an editor I want to be able to use animations on elements in my story

Acceptance Criteria 1.

Design

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Design Panel - Animation

Closing this ticket as it is not actionable.

jauyong

comment created time in a month

issue closedgoogle/web-stories-wp

Design Panel - Image

This ticket is for image specific features not covered by the panel-focused issues: #279 #280 #282 #283 #284

Acceptance Criteria

  1. ?
  2. The relevant tooltips are shown on hover

Feature Brief - Epic: Selection & In-place Editing

Design

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Design Panel - Image

Closing this ticket as it is not actionable.

jauyong

comment created time in a month

issue closedgoogle/web-stories-wp

Design Panel - Text

This ticket is for text specific features not covered by the panel-focused issues: #279 #280 #282 #283 #284

Acceptance Criteria

  1. ?

Feature Brief - Epic: Selection & In-place Editing

Design

closed time in a month

jauyong

issue commentgoogle/web-stories-wp

Design Panel - Text

Closing this ticket as it is really not actionable.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Fix default background color for generated stories

Let's not block on @samitron7 please, and make it white for now. She's swamped, if she disagrees then we can reopen.

barklund

comment created time in a month

issue commentgoogle/web-stories-wp

Ability to paste rich text into the editor (and have it auto-convert to an element if no element is selected)

@samitron7 I think this might warrant some Figma love for the final feature..your flow should describe what happens when I paste rich text from Google Docs, or a block of HTML with an image in it etc.

jauyong

comment created time in a month

issue commentgoogle/web-stories-wp

Paste to Upload

This seems like a weirdly big issue, I think a bunch of these things are done? @jauyong and @spacedmonkey can you please close and file more specific follow ups for the outstanding work?

jauyong

comment created time in a month

pull request commentgoogle/web-stories-wp

[WIP] Minimum element sizes

@merapi friendly ping, what's the status here? I see comments from @dvoytenko from 8 days ago.

merapi

comment created time in a month

more