profile
viewpoint
Mariano Martinez III mariano-formidable Formidable Seattle, WA

google/web-stories-wp 173

Web Stories WordPress plugin

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 190d0378450850bf1364eb1db81340f54ae57932

Update pageToken to have opaque semantics in common/reducer.js

view details

Clinton Volzke

commit sha d51c0c3543ff1c3bda3cb58ab8457ab08c51d6ec

Write tests for common media reducer

view details

Clinton Volzke

commit sha e27ceb7ecd5828aa0815bd022e9b501866a9b020

Pull media action functions out to common

view details

Clinton Volzke

commit sha 43e43136a61dc7fe08849ab5e6f87cf0951538f2

Add provider discriminator to common/reducer.js and actions

view details

Clinton Volzke

commit sha b9137235f18c5a8e9f096b0163f7293ba344821e

Write tests for common media reducer

view details

Clinton Volzke

commit sha c5cfaff7795da760dad7e6c8c0bd6086ee880c54

Merge branch 'task/2512-write-tests-reducer' into task/2428-actions-to-common

view details

Clinton Volzke

commit sha ca32ea88e140f8afb1bab4fbf39e520d8aad5596

Write tests for common media reducer

view details

Clinton Volzke

commit sha b67255987f0c03bfacfaf13ef4fd7a13d1b39a88

Merge branch 'task/2512-write-tests-reducer' into task/2428-actions-to-common

view details

Clinton Volzke

commit sha f064605c9bf1b7b3e302d044b34c71f83a42168d

Merge branch 'task/2428-actions-to-common' into task/2829-media-provider-discriminator

view details

Clinton Volzke

commit sha 227318d3bee34c94d71c8d5f85f7b56ee1508026

Remove unnecessary usages of 'act' from tests

view details

Clinton Volzke

commit sha 546d6345ad531b7ff3ab9367bd0675f92066e9a1

Merge branch 'task/2512-write-tests-reducer' into task/2428-actions-to-common

view details

Clinton Volzke

commit sha 98906cf12e95b0d04827f1395d25417e4621be47

Merge branch 'task/2428-actions-to-common' into task/2829-media-provider-discriminator

view details

Clinton Volzke

commit sha eac66a7b0bc71fceac0f078531a2ab815c4a4f54

Add test for local discriminator

view details

Clinton Volzke

commit sha 3c73ff931ace37b6edb2eca04b5684f16a23ef45

Pull out reducer type constants to local and common folders

view details

Clinton Volzke

commit sha cb1a5379a4a38276b1573148f948e6836e638818

Address review feedback

view details

Clinton Volzke

commit sha 60987c82acb0da984a6d72e357019dbe8694bf91

Merge branch 'task/2829-media-provider-discriminator' into task/2428-reducer-types-to-common

view details

Clinton Volzke

commit sha d8d027f76230de53259ce6117dba9fa35adc7cf9

Use common media reducer for media3p providers

view details

Clinton Volzke

commit sha f21b0600e5203623c8bb61c97e5ebc910ea778d2

Add selectedProvider to media3p state

view details

Clinton Volzke

commit sha 78c72af186e6c9120a84494524d04337ad765a61

Add useMedia3p and useMedia3pProvider context consumer hooks

view details

Clinton Volzke

commit sha 5937cae3607e9f2e45f53b567ffaa15b41547136

Remove 'local' provider specific attributes from fetchMediaSuccess

view details

push time in 3 hours

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 458870fc9bbc79164c9afc55fb18b89cb8f9839b

Updated Fitness link to have description

view details

push time in 3 hours

Pull request review commentgoogle/web-stories-wp

Dashboard: Updated Wellbeing template, improved blob imports

           "type": "shape",           "basedOn": "70cd1c38-9462-47f4-9a12-c9585c16acc4",           "id": "95a2a69d-7946-4fd2-97ad-7cd47fe87e04",-          "link": null+          "link": {+            "url": "http://example.com/",+            "icon": null,+            "desc": "Example Domain"

I also hooked up the links on page 4 of the Wellbeing template.

mariano-formidable

comment created time in 20 hours

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha a25edb43829480c9dd52410ddf61a3fb088d84f5

Added links to Wellbeing template

view details

push time in 20 hours

PR opened google/web-stories-wp

[WIP] Dashboard: Added links to DIY, Fashion, and Fitness

Summary

<!-- A brief description of what this PR does. -->

Relevant Technical Choices

<!-- Please describe your changes. -->

To-do

<!-- A list of things that need to be addressed in this PR or follow-up changes. -->

User-facing changes

<!-- Please describe your changes. -->

Testing Instructions

<!-- How can the changes in this PR be verified? Relevant for QA and user acceptance testing. -->


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #

+85 -1364

0 comment

3 changed files

pr created time in 20 hours

create barnchgoogle/web-stories-wp

branch : task/add-links-to-templates

created branch time in 20 hours

PR opened google/web-stories-wp

[WIP] Dashboard: Updated Wellbeing template, improved blob imports

Summary

<!-- A brief description of what this PR does. -->

Relevant Technical Choices

<!-- Please describe your changes. -->

To-do

<!-- A list of things that need to be addressed in this PR or follow-up changes. -->

User-facing changes

<!-- Please describe your changes. -->

Testing Instructions

<!-- How can the changes in this PR be verified? Relevant for QA and user acceptance testing. -->


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #

+232 -297

0 comment

2 changed files

pr created time in a day

create barnchgoogle/web-stories-wp

branch : task/update-wellbeing-blobs

created branch time in a day

Pull request review commentgoogle/web-stories-wp

Dashboard: Settings UI

+/*+ * Copyright 2020 Google LLC+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *     https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++/**+ * WordPress dependencies+ */+import { __ } from '@wordpress/i18n';++/**+ * Internal dependencies+ */+import {+  SettingForm,+  FileUploadHelperText,+  FinePrintHelperText,+  UploadContainer,+  SettingHeading,+} from '../components';++const TEXT = {+  sectionHeading: __('Publisher Logo', 'web-stories'),+  context: __(+    'Upload your logos here and they will become available to any stories you create.',+    'web-stories'+  ),+  instructions: __(+    'Click on upload or drag a jpg, png, or static gif in the box above. Avoid vector files, such as svg or eps. Logos should be at least 96x96 pixels and a perfect square. The background should not be transparent.',+    'web-stories'+  ),+  submit: __('Upload', 'web-stories'),+};

Super nit, I'm not sure anything should change but just wanted to call it out for you to make the executive decision, but generally our constants are all uppercase so instead of TEXT.sectionHeading it would be TEXT.SECTION_HEADING. But because this is a local const using immediately below its definition, I think it's okay to be more casual about it 🤔

BrittanyIRL

comment created time in a day

Pull request review commentgoogle/web-stories-wp

Dashboard: Settings UI

+/*+ * Copyright 2020 Google LLC+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *     https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++/**+ * WordPress dependencies+ */+import { __ } from '@wordpress/i18n';++/**+ * Internal dependencies+ */+import {+  SettingForm,+  FileUploadHelperText,+  FinePrintHelperText,+  UploadContainer,+  SettingHeading,+} from '../components';++const TEXT = {+  sectionHeading: __('Publisher Logo', 'web-stories'),+  context: __(+    'Upload your logos here and they will become available to any stories you create.',+    'web-stories'+  ),+  instructions: __(+    'Click on upload or drag a jpg, png, or static gif in the box above. Avoid vector files, such as svg or eps. Logos should be at least 96x96 pixels and a perfect square. The background should not be transparent.',+    'web-stories'+  ),+  submit: __('Upload', 'web-stories'),+};+function PublisherLogoSettings() {+  return (+    <SettingForm>+      <SettingHeading htmlFor="publisherLogo">+        {TEXT.sectionHeading}+      </SettingHeading>+      <div>+        <FileUploadHelperText>{TEXT.context}</FileUploadHelperText>+        <UploadContainer>+          <p>{'Upload Placeholder'}</p>

How come "Upload Placeholder" isn't part of the TEXT const?

BrittanyIRL

comment created time in a day

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 33ef52e9908eac13b8948340fb4fe9509d280383

Slight update

view details

push time in 6 days

Pull request review commentgoogle/web-stories-wp

Dashboard: Updated Cooking template to use shapes instead of images when possible.

 const CLIP_PATHS = {   [MaskTypes.GRID_3]: `M 0.002772 , 0.002772 H 0.000000 v 1.712860 l 0.994457 -0.002772 h 0.002772 l 0.002772 -1.710089 V 0.000000 L 0.002772 , 0.002772 z  M 0.994457 , 0.005543 l -0.000277 , 0.161585 H 0.005543 V 0.008315 L 0.994457 , 0.005543 z  M 0.005543 , 1.710089 V 0.172672 h 0.988636 L 0.991685 , 1.707317 L 0.005543 , 1.710089 z`,   [MaskTypes.GRID_4]: `M 1.000000 , 1.712784 H 0.000000 V 0.000000 h 1.000000 L 1.000000 , 1.712784 L 1.000000 , 1.712784 z  M 0.005534 , 1.707250 h 0.988932 V 0.005534 H 0.005534 V 1.707250 z`,   [MaskTypes.GRID_5]: `M 1.000000 , 1.718490 H 0.000000 V 0.000000 h 0.999722 v 1.718490 H 1.000000 z  M 0.005552 , 1.712937 h 0.988617 V 0.250416 H 0.005552 V 1.712937 z  M 0.005552 , 0.244864 h 0.988617 V 0.005552 H 0.005552 V 0.244864 z`,-  [MaskTypes.GRID_6]: `M 1.000000 , 1.719444 H 0.000000 V 0.000000 h 1.000000 V 1.719444 z  M 0.005556 , 1.713889 h 0.988889 v -0.166667 H 0.005556 V 1.713889 z  M 0.184167 , 1.541667 H 0.994444 v -0.162500 H 0.184167 V 1.541667 z  M 0.005556 , 1.541667 h 0.173056 v -0.162500 H 0.005556 V 1.541667 z  M 0.184167 , 1.373611 H 0.994444 V 1.211111 H 0.184167 V 1.373611 z  M 0.005556 , 1.373611 h 0.173056 V 1.211111 H 0.005556 V 1.373611 z  M 0.184167 , 1.205556 H 0.994444 v -0.162500 H 0.184167 V 1.205556 z  M 0.005556 , 1.205556 h 0.173056 v -0.162500 H 0.005556 V 1.205556 z  M 0.184167 , 1.037500 H 0.994444 V 0.875000 H 0.184167 V 1.037500 z  M 0.005556 , 1.037500 h 0.173056 V 0.875000 H 0.005556 V 1.037500 z  M 0.184167 , 0.869444 H 0.994444 v -0.162500 H 0.184167 V 0.869444 z  M 0.005556 , 0.869444 h 0.173056 v -0.162500 H 0.005556 V 0.869444 z  M 0.184167 , 0.701111 H 0.994444 v -0.162500 H 0.184167 V 0.701111 z  M 0.005556 , 0.701111 h 0.173056 v -0.162500 H 0.005556 V 0.701111 z  M 0.184167 , 0.533056 H 0.994444 v -0.162500 H 0.184167 V 0.533056 z  M 0.005556 , 0.533056 h 0.173056 v -0.162500 H 0.005556 V 0.533056 z  M 0.184167 , 0.365000 H 0.994444 V 0.005556 H 0.184167 V 0.365000 z  M 0.005556 , 0.365000 h 0.173056 V 0.005556 H 0.005556 V 0.365000 z`,+  [MaskTypes.GRID_6]: `M 1.000000 , 1.719444 H 0.000000 V 0.000000 h 1.000000 V 1.719444 z  M 0.005556 , 1.713889 h 0.988889 v -0.166667 H 0.005556 V 1.713889 z  M 0.183889 , 1.541667 H 0.994444 v -0.162500 H 0.183889 V 1.541667 z  M 0.005556 , 1.541667 h 0.172778 v -0.162500 H 0.005556 V 1.541667 z  M 0.183889 , 1.373611 H 0.994444 V 1.211111 H 0.183889 V 1.373611 z  M 0.005556 , 1.373611 h 0.172778 V 1.211111 H 0.005556 V 1.373611 z  M 0.183889 , 1.205556 H 0.994444 v -0.162500 H 0.183889 V 1.205556 z  M 0.005556 , 1.205556 h 0.172778 v -0.162500 H 0.005556 V 1.205556 z  M 0.183889 , 1.037500 H 0.994444 V 0.875000 H 0.183889 V 1.037500 z  M 0.005556 , 1.037500 h 0.172778 V 0.875000 H 0.005556 V 1.037500 z  M 0.183889 , 0.869444 H 0.994444 v -0.162778 H 0.183889 V 0.869444 z  M 0.005556 , 0.869444 h 0.172778 v -0.162778 H 0.005556 V 0.869444 z  M 0.183889 , 0.701111 H 0.994444 v -0.162500 H 0.183889 V 0.701111 z  M 0.005556 , 0.701111 h 0.172778 v -0.162500 H 0.005556 V 0.701111 z  M 0.183889 , 0.533056 H 0.994444 v -0.162500 H 0.183889 V 0.533056 z  M 0.005556 , 0.533056 h 0.172778 v -0.162500 H 0.005556 V 0.533056 z  M 0.005556 , 0.365000 h 0.988889 V 0.005556 H 0.005556 V 0.365000 z`,

Updated GRID_6, removed a rouge line it didn't need.

mariano-formidable

comment created time in 6 days

Pull request review commentgoogle/web-stories-wp

Dashboard: Updated Cooking template to use shapes instead of images when possible.

 function TemplateDetails() {               <DetailViewNavBar                 ctaText={__('Use template', 'web-stories')}                 handleBookmarkClick={-                  enableBookmarks && handleBookmarkClickSelected+                  enableBookmarks ? handleBookmarkClickSelected : null

Small update so we don't get proptype warnings about handleBookmarkClick expecting a function but received a boolean when enableBookmarks is false.

mariano-formidable

comment created time in 6 days

PR opened google/web-stories-wp

Dashboard: Updated Cooking template to use shapes instead of images when possible.

Summary

This PR updates the Cooking template to use our new fancy SVG grids and arrows in place of the images (for arrows) and tons of line rectangles (for the grid) we had before.

The template should render like it did before, it's just more efficiently made.

User-facing changes

  • Should be a transparent change, Cooking template should render as it did before.

Testing Instructions

1.) Go to "Explore Templates". 2.) Click to "View" the Cooking template. 3.) Ensure each page renders like the screenshots below.

Screenshots

+486 -3124

0 comment

3 changed files

pr created time in 6 days

create barnchgoogle/web-stories-wp

branch : task/update-cooking-grids

created branch time in 6 days

issue commentgoogle/web-stories-wp

Add links to product anchors in all templates

@samitron7 Should we link to anything in specific (for each template)? When we had dummy links before, we were just linking to google.com, is that okay?

samitron7

comment created time in 6 days

IssuesEvent

delete branch google/web-stories-wp

delete branch : task/apply-916-wellness

delete time in 7 days

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 0c734799179f39bf24d276b960363654b9d36ba9

Dashboard: Applied design updates to Wellbeing template

view details

Mariano Martinez III

commit sha 088b9e32e169c9526604eb919ccb01ad08e33b90

Fixed style issues

view details

Mariano Martinez III

commit sha c1a8181e9385abb7783c5513226a347b2443962e

Fixed shapes in wellbeing

view details

Mariano Martinez III

commit sha bb5132c4c593bd2e1bbf524971a33a31fa2d0b69

Merge pull request #2659 from google/task/apply-916-wellness Dashboard: Applied design updates to Wellbeing template

view details

push time in 7 days

PR merged google/web-stories-wp

Reviewers
Dashboard: Applied design updates to Wellbeing template Group: Templates Type: Enhancement cla: yes

Summary

This PR applies the new design updates to the Wellbeing template.

User-facing changes

Layout and text sizes have been update on the Wellbeing template based off the recommendations found in this figma design doc.

Todo

  • I couldn't figure out a way to import the outline blob and the editor currently doesn't support outlining shapes so I couldn't place the outlines anywhere.
  • I also couldn't figure out a way to import the long narrow arrow SVG either, so I'm gonna get some help to get it imported in another PR.

Testing Instructions

1.) Go to "Explore Templates". 2.) Hover over the Wellbeing template and click on "View". 3.) Take a look at each template page in the detail view for Wellbeing. Make sure images are showing up and the layout appears as shown in the figma updates.


Fixes #2477

Screenshots from Editor

+1422 -2673

4 comments

2 changed files

mariano-formidable

pr closed time in 7 days

issue closedgoogle/web-stories-wp

Templates: Update Wellbeing template to 9:16

Use this Figma doc to apply 9:16 updates to the existing Wellness template: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=766%3A61

closed time in 7 days

mariano-formidable

pull request commentgoogle/web-stories-wp

Dashboard: Applied design updates to Wellbeing template

@googlebot I consent

mariano-formidable

comment created time in 7 days

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 7a4e1446348b2f9bb8ab0fff68cd3bb89cdfecca

Bump @babel/preset-env from 7.10.3 to 7.10.4 (#2867)

view details

Mariano Martinez III

commit sha b5a1f4a2e17cfbd0c35242ec8fc101b9e4a83eb3

Dashboard: Fixed button placement and swapped watch in Fitness template

view details

Mariano Martinez III

commit sha f2f54d692dcf250d9e41687e93f2c97eda4f36be

Merge pull request #2880 from google/fix/update-fitness-template Dashboard: Fixed button placement and swapped watch in Fitness template

view details

Mariano Martinez III

commit sha 0c734799179f39bf24d276b960363654b9d36ba9

Dashboard: Applied design updates to Wellbeing template

view details

Mariano Martinez III

commit sha 088b9e32e169c9526604eb919ccb01ad08e33b90

Fixed style issues

view details

Mariano Martinez III

commit sha c1a8181e9385abb7783c5513226a347b2443962e

Fixed shapes in wellbeing

view details

push time in 7 days

issue commentgoogle/web-stories-wp

Templates: Update Fitness template to 9:16

@samitron7 I've fixed both issues you found. The template is ready for re-UAT.

mariano-formidable

comment created time in 7 days

IssuesEvent

delete branch google/web-stories-wp

delete branch : fix/update-fitness-template

delete time in 7 days

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha b5a1f4a2e17cfbd0c35242ec8fc101b9e4a83eb3

Dashboard: Fixed button placement and swapped watch in Fitness template

view details

Mariano Martinez III

commit sha f2f54d692dcf250d9e41687e93f2c97eda4f36be

Merge pull request #2880 from google/fix/update-fitness-template Dashboard: Fixed button placement and swapped watch in Fitness template

view details

push time in 7 days

PR merged google/web-stories-wp

Reviewers
Dashboard: Fixed button placement and swapped watch in Fitness template cla: yes

Summary

This PR makes some quick fixes to the Fitness template.

The following updates were made:

1.) The "Buy Now" button and above text was moved towards the center so they're not right up against the edge:

2.) Swapped out the Apple watch with a fitbit:

User-facing changes

  • Small text changes.

Testing Instructions

1.) Go to "Explore Templates" 2.) Click on "View" for "Fitness" template and check that pages 5 and 6 appear as the images above.

Fixes #2473

+76 -17

2 comments

3 changed files

mariano-formidable

pr closed time in 7 days

issue closedgoogle/web-stories-wp

Templates: Update Fitness template to 9:16

Use this Figma doc to apply 9:16 updates to the existing Fitness template: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=766%3A61

closed time in 7 days

mariano-formidable

PR opened google/web-stories-wp

Dashboard: Fixed button placement and swapped watch in Fitness template

Summary

This PR makes some quick fixes to the Fitness template.

The following updates were made:

1.) The "Buy Now" button and above text was moved towards the center so they're not right up against the edge:

2.) Swapped out the Apple watch with a fitbit:

User-facing changes

  • Small text changes.

Testing Instructions

1.) Go to "Explore Templates" 2.) Click on "View" for "Fitness" template and check that pages 5 and 6 appear as the images above.

Fixes #2473

+76 -17

0 comment

3 changed files

pr created time in 7 days

issue commentgoogle/web-stories-wp

Templates: Update Wellbeing template to 9:16

Okay the pages should be fixed!

mariano-formidable

comment created time in 7 days

create barnchgoogle/web-stories-wp

branch : fix/update-fitness-template

created branch time in 7 days

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 0d94101d61f751f30070a45d8d874926f7955e93

Exclude web-stories.php from coverage

view details

Pascal Birchler

commit sha 099ffd30d2d2d82f41bc51d93d84bbf998ef5a8a

Exclude uninstall.php from coverage

view details

Pascal Birchler

commit sha 41ab3f9b87a3355d7ffd353ca0c663ef9e4fd703

Move templates to folders

view details

Pascal Birchler

commit sha 99c88b9ea89c08493e11ba06fe04e48ff11edede

Exclude templates folder from coverage

view details

Pascal Birchler

commit sha 872cf995480f12e62d702aa9976ca615844ddf02

Update codecov config

view details

Pascal Birchler

commit sha f23f7ac62d352b381dec0a214e2dee2036d5b595

Merge branch 'master' into fix/328-exclude-from-coverage

view details

Clinton Volzke

commit sha 0bddd5e1cf9d98027f70dbe1043941b1f47f6cc8

Add useLocalMedia() hook that returns useMedia().local

view details

Clinton Volzke

commit sha ba8205346cdde384b3cdbcbbb9ae7fbb16fa4e9d

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Pascal Birchler

commit sha 68510b8e18ccedee5e84f25eba17ab07541c40f8

Add tests for Updater class

view details

Pascal Birchler

commit sha 0887bc296be8539358318364daaf83b79a653962

Lint fixes

view details

Pascal Birchler

commit sha 241408426d7d22a7a6e289443852bfdd7c80e302

Add more assertions

view details

Pascal Birchler

commit sha a5f39dc1c913ac5bce020ce4605b9ce97b4132cc

Multisite test

view details

Brittany Feenstra

commit sha fbd6d8f644283311e6a43e62e78b88cb4f7b9599

update stories per request to 24 per page to reduce load time. Separate constants for per page request counts for users and stories. We need all the users to get proper display for stories, we do not need all the stories. 24 should be a happy medium for users with huge monitors and the average laptop or tablet user.

view details

Miina Sikk

commit sha 919743038e69e38e98771995162dd5ba793abf96

Fix color presets opacity detection.

view details

Brittany Feenstra

commit sha 28107a5c66417abc943a224ea4fb0090d5edf731

Merge pull request #2789 from google/task/per-page-query-updates Dashboard: Update stories per request count to speed up time to first interaction

view details

Brittany Feenstra

commit sha 3c6916621e6a75bd352e29e59f185a5cbdc61cc0

updating template descriptions and adding i18n wrapper

view details

Clinton Volzke

commit sha 7019176e1c9a0cb08934cb465340c25ff52bd898

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Joanna Lee

commit sha ba1ff6902dfef98fceca02ba5b0c47b91f890e3e

Added flag for using a row-based gallery (#2821) This gallery will be used in the Uploaded Media tab.

view details

Clinton Volzke

commit sha fa615b895d17036ac148d766574f22c5061ecb7c

Add test for useLocalMedia

view details

Clinton Volzke

commit sha fed9e85b4b7f9e1d1f9a1359955ca26606559d85

Merge pull request #2805 from google/task/2610-add-useLocalMedia

view details

push time in 7 days

IssuesEvent

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 2e8680c6cc9d0999ea567705ec929f91e92f1a69

Dashboard: Updated Beauty template

view details

Mariano Martinez III

commit sha 48bac842c6faecd5f7a79082c97183ed8788d404

Fixed template grid after merge from master

view details

Mariano Martinez III

commit sha 139a84e429850129869beefd20d43823a6213ace

Merge pull request #2606 from google/2476-template-beauty-aspect Templates: Update Beauty Template Aspect Ratio to 9:16

view details

push time in 7 days

delete branch google/web-stories-wp

delete branch : 2476-template-beauty-aspect

delete time in 7 days

PR merged google/web-stories-wp

Reviewers
Templates: Update Beauty Template Aspect Ratio to 9:16 Group: Templates Type: Enhancement cla: yes

Summary

Updates Beauty template to new aspect ratio and fixes other critiques put in latest template design pass for fashion.

Designs & Critiques: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=772%3A540

Relevant Technical Choices

NA

To-do

  • Still waiting for grid SVG assets to replace grid pngs on here so they can support custom colors

User-facing changes

  • Beauty template styles

Testing Instructions

Go to explore templates and view the beauty template. Each page should now match these designs: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=772%3A540


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #2476

Screenshots

<details> <summary>Click to expand</summary> Screen Shot 2020-06-18 at 3 08 58 PM Screen Shot 2020-06-18 at 3 08 52 PM Screen Shot 2020-06-18 at 3 08 42 PM Screen Shot 2020-06-18 at 3 08 34 PM Screen Shot 2020-06-18 at 3 08 28 PM Screen Shot 2020-06-18 at 3 08 21 PM Screen Shot 2020-06-18 at 3 08 15 PM Screen Shot 2020-06-18 at 3 08 08 PM Screen Shot 2020-06-18 at 3 08 00 PM </details>

+2877 -3029

5 comments

2 changed files

littlemilkstudio

pr closed time in 7 days

issue closedgoogle/web-stories-wp

Templates: Update Beauty template to 9:16

Use this Figma doc to apply 9:16 updates to the existing Beauty template: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=766%3A61

closed time in 7 days

mariano-formidable
IssuesEvent

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha dc7cca55bde55fecc8f75eb9d50dcc343eb1916b

Dashboard: Fixed text typos in templates

view details

Mariano Martinez III

commit sha 99ba1510990bc4756a373b5704fcda2e7d2db5ac

Remove extra spacing

view details

Mariano Martinez III

commit sha 1938804f181b3f373832568b69f77c74f7a653a4

Merge pull request #2860 from google/task/final-text-check-templates Dashboard: Fixed text typos in templates

view details

push time in 7 days

delete branch google/web-stories-wp

delete branch : task/final-text-check-templates

delete time in 7 days

PR merged google/web-stories-wp

Reviewers
Dashboard: Fixed text typos in templates Group: Templates Type: Bug cla: yes

Summary

This PR fixes some typos and removes celebrity quotes with anonymous ones. The templates updated are Entertainmnet, Fashion, and Travel.

User-facing changes

  • Small text changes the affect templates.

Testing Instructions

1.) Go to "Explore Templates". 2.) Click on "View" for the Entertainment, Fashion, and Travel templates. 3.) Make sure the page in the screenshots below match what you see in your browser:


Fixes #2854

Screenshots

Travel - Page 2 (removed Anthony Bourdain quote):

Entertainment - Page 7 (Fixed typo, changed "We'll take your" to "We'll take you"):

Fashion - Page 2 (Remove Anna Wintour quote):

Fashion - Page 5 (Changed side text from "Cardin" to "Kepler"):

+102 -117

2 comments

3 changed files

mariano-formidable

pr closed time in 7 days

issue closedgoogle/web-stories-wp

Double check all templates for release readiness

Check images and text copy to ensure it's all ready for Beta release.

closed time in 7 days

o-fernandez
IssuesEvent

push eventgoogle/web-stories-wp

Maxwell Yinger

commit sha 9c1353fb0a8dddeab0f9d5f527923159049b57ed

initial fitness update

view details

Maxwell Yinger

commit sha bc3d5a9cd1b29da89228415bdd165b55562bdadd

add proper bg pictures

view details

Mariano Martinez III

commit sha e1c0d8ecfb7c90a284aa9bcce874d09e8b1d7743

Removed hidden chars from fitness template

view details

Mariano Martinez III

commit sha b77e570bd28ada8d7c523f35fa08046de0e2ce35

Merge pull request #2628 from google/2473-template-fitness-aspect Templates: Update Fitness Template Aspect Ratio to 9:16

view details

push time in 7 days

delete branch google/web-stories-wp

delete branch : 2473-template-fitness-aspect

delete time in 7 days

PR merged google/web-stories-wp

Reviewers
Templates: Update Fitness Template Aspect Ratio to 9:16 Group: Templates Type: Enhancement cla: yes

Summary

Updates Fitness template to new aspect ratio and fixes other critiques put in latest template design pass for fitness.

Designs & Critiques: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=766%3A61

Relevant Technical Choices

NA

To-do

~Still need a couple background images that have the color/blend-mode baked in. made notes of this in figma~

User-facing changes

Fitness template update

Testing Instructions

Go to explore templates and view the Fitness template. Each page should now match these designs: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=766%3A61


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #2473

Screenshots

<details> <summary>Click to expand</summary> Screen Shot 2020-06-19 at 3 16 48 PM Screen Shot 2020-06-19 at 3 16 01 PM Screen Shot 2020-06-19 at 3 16 40 PM Screen Shot 2020-06-19 at 3 16 07 PM Screen Shot 2020-06-19 at 3 16 13 PM Screen Shot 2020-06-19 at 3 16 21 PM Screen Shot 2020-06-19 at 3 16 28 PM Screen Shot 2020-06-19 at 3 16 34 PM </details>

+1276 -2149

8 comments

1 changed file

littlemilkstudio

pr closed time in 7 days

issue closedgoogle/web-stories-wp

Templates: Update Fitness template to 9:16

Use this Figma doc to apply 9:16 updates to the existing Fitness template: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=766%3A61

closed time in 7 days

mariano-formidable

push eventgoogle/web-stories-wp

Brittany Feenstra

commit sha 3c6916621e6a75bd352e29e59f185a5cbdc61cc0

updating template descriptions and adding i18n wrapper

view details

Brittany Feenstra

commit sha 529f17aed22b67b6cd9cfa547f5d84e958c16db2

Update assets/src/dashboard/templates/index.js Co-authored-by: Pascal Birchler <pascalb@google.com>

view details

Brittany Feenstra

commit sha b2f4418c035ccc24b9a66bfbdc214c90ad2973d9

Update assets/src/dashboard/templates/index.js Co-authored-by: Pascal Birchler <pascalb@google.com>

view details

Pascal Birchler

commit sha a63b3b055a598bd454ddc840e3c3ae6e16b3a0a5

Update eslint patch

view details

Brittany Feenstra

commit sha 080d2efb93064d7b8e44543c5102aa1e84135175

Merge pull request #2818 from google/task/2687-template-copy-updates Dashboard: Update template descriptions

view details

Mariano Martinez III

commit sha 8e18bda4180bf07f9a192847feb774655055ccf4

Added new shapes and showInLibrary flag to hide/show masks

view details

Mariano Martinez III

commit sha 7ce796916f4b7516e02cd039ed41d35d750f0b15

Merge pull request #2760 from google/1895-add-shapes-shapepanel Shapes: Add new shapes to library

view details

Jonny Harris

commit sha d8df912992b30584033e100bddb15e43b8ea0ddf

Ignore namespace file from coverage (#2856)

view details

Mariano Martinez III

commit sha 2e8680c6cc9d0999ea567705ec929f91e92f1a69

Dashboard: Updated Beauty template

view details

Mariano Martinez III

commit sha 48bac842c6faecd5f7a79082c97183ed8788d404

Fixed template grid after merge from master

view details

push time in 7 days

push eventgoogle/web-stories-wp

Brittany Feenstra

commit sha 3c6916621e6a75bd352e29e59f185a5cbdc61cc0

updating template descriptions and adding i18n wrapper

view details

Brittany Feenstra

commit sha 529f17aed22b67b6cd9cfa547f5d84e958c16db2

Update assets/src/dashboard/templates/index.js Co-authored-by: Pascal Birchler <pascalb@google.com>

view details

Brittany Feenstra

commit sha b2f4418c035ccc24b9a66bfbdc214c90ad2973d9

Update assets/src/dashboard/templates/index.js Co-authored-by: Pascal Birchler <pascalb@google.com>

view details

Pascal Birchler

commit sha a63b3b055a598bd454ddc840e3c3ae6e16b3a0a5

Update eslint patch

view details

Brittany Feenstra

commit sha 080d2efb93064d7b8e44543c5102aa1e84135175

Merge pull request #2818 from google/task/2687-template-copy-updates Dashboard: Update template descriptions

view details

Mariano Martinez III

commit sha 8e18bda4180bf07f9a192847feb774655055ccf4

Added new shapes and showInLibrary flag to hide/show masks

view details

Mariano Martinez III

commit sha 7ce796916f4b7516e02cd039ed41d35d750f0b15

Merge pull request #2760 from google/1895-add-shapes-shapepanel Shapes: Add new shapes to library

view details

Jonny Harris

commit sha d8df912992b30584033e100bddb15e43b8ea0ddf

Ignore namespace file from coverage (#2856)

view details

Maxwell Yinger

commit sha 9c1353fb0a8dddeab0f9d5f527923159049b57ed

initial fitness update

view details

Maxwell Yinger

commit sha bc3d5a9cd1b29da89228415bdd165b55562bdadd

add proper bg pictures

view details

Mariano Martinez III

commit sha e1c0d8ecfb7c90a284aa9bcce874d09e8b1d7743

Removed hidden chars from fitness template

view details

push time in 7 days

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 99ba1510990bc4756a373b5704fcda2e7d2db5ac

Remove extra spacing

view details

push time in 7 days

PR opened google/web-stories-wp

Reviewers
Dashboard: Fixed text typos in templates

Summary

This PR fixes some typos and removes celebrity quotes with anonymous ones. The templates updated are Entertainmnet, Fashion, and Travel.

User-facing changes

  • Small text changes the affect templates.

Testing Instructions

1.) Go to "Explore Templates". 2.) Click on "View" for the Entertainment, Fashion, and Travel templates. 3.) Make sure the page in the screenshots below match what you see in your browser:


Fixes #2854

Screenshots

Travel - Page 2 (removed Anthony Bourdain quote):

Entertainment - Page 7 (Fixed typo, changed "We'll take your" to "We'll take you"):

Fashion - Page 2 (Remove Anna Wintour quote):

Fashion - Page 5 (Changed side text from "Cardin" to "Kepler"):

+102 -117

0 comment

3 changed files

pr created time in 7 days

create barnchgoogle/web-stories-wp

branch : task/final-text-check-templates

created branch time in 7 days

issue closedgoogle/web-stories-wp

Templates - Add SVGs to shape panel

This task is to go through each template and add the relevant SVGs documented here: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates

under shapes & bring them into the shape panel in the editor: image

closed time in 7 days

littlemilkstudio

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 8e18bda4180bf07f9a192847feb774655055ccf4

Added new shapes and showInLibrary flag to hide/show masks

view details

Mariano Martinez III

commit sha 7ce796916f4b7516e02cd039ed41d35d750f0b15

Merge pull request #2760 from google/1895-add-shapes-shapepanel Shapes: Add new shapes to library

view details

push time in 7 days

delete branch google/web-stories-wp

delete branch : 1895-add-shapes-shapepanel

delete time in 7 days

PR merged google/web-stories-wp

Reviewers
Shapes: Add new shapes to library Elements: Shape Type: Enhancement cla: yes

Summary

Goes through and normalizes and formats svgs in templates to be normalized clip paths.

Relevant Technical Choices

Had to add an altered icon path so large shapes with small small stroke widths were visible

To-do

Go through templates and replace any placeholder pngs with these shapes.

User-facing changes

Adds new shapes to shapes panel: image

Testing Instructions

Create a new template or alter and existing one and add all new shapes to the template and make sure they work and are visible.


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #1895

+263 -11

17 comments

3 changed files

littlemilkstudio

pr closed time in 7 days

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 0d94101d61f751f30070a45d8d874926f7955e93

Exclude web-stories.php from coverage

view details

Pascal Birchler

commit sha 099ffd30d2d2d82f41bc51d93d84bbf998ef5a8a

Exclude uninstall.php from coverage

view details

Pascal Birchler

commit sha 41ab3f9b87a3355d7ffd353ca0c663ef9e4fd703

Move templates to folders

view details

Pascal Birchler

commit sha 99c88b9ea89c08493e11ba06fe04e48ff11edede

Exclude templates folder from coverage

view details

Pascal Birchler

commit sha 872cf995480f12e62d702aa9976ca615844ddf02

Update codecov config

view details

Pascal Birchler

commit sha f23f7ac62d352b381dec0a214e2dee2036d5b595

Merge branch 'master' into fix/328-exclude-from-coverage

view details

Clinton Volzke

commit sha 0bddd5e1cf9d98027f70dbe1043941b1f47f6cc8

Add useLocalMedia() hook that returns useMedia().local

view details

Clinton Volzke

commit sha ba8205346cdde384b3cdbcbbb9ae7fbb16fa4e9d

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Pascal Birchler

commit sha 68510b8e18ccedee5e84f25eba17ab07541c40f8

Add tests for Updater class

view details

Pascal Birchler

commit sha 0887bc296be8539358318364daaf83b79a653962

Lint fixes

view details

Pascal Birchler

commit sha 241408426d7d22a7a6e289443852bfdd7c80e302

Add more assertions

view details

Pascal Birchler

commit sha a5f39dc1c913ac5bce020ce4605b9ce97b4132cc

Multisite test

view details

Miina Sikk

commit sha 919743038e69e38e98771995162dd5ba793abf96

Fix color presets opacity detection.

view details

Brittany Feenstra

commit sha 3c6916621e6a75bd352e29e59f185a5cbdc61cc0

updating template descriptions and adding i18n wrapper

view details

Clinton Volzke

commit sha 7019176e1c9a0cb08934cb465340c25ff52bd898

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Joanna Lee

commit sha ba1ff6902dfef98fceca02ba5b0c47b91f890e3e

Added flag for using a row-based gallery (#2821) This gallery will be used in the Uploaded Media tab.

view details

Clinton Volzke

commit sha fa615b895d17036ac148d766574f22c5061ecb7c

Add test for useLocalMedia

view details

Clinton Volzke

commit sha fed9e85b4b7f9e1d1f9a1359955ca26606559d85

Merge pull request #2805 from google/task/2610-add-useLocalMedia

view details

Brittany Feenstra

commit sha 7692fff80cedf8865abadd142de74a9e8f97f564

Dashboard: Honor scrollbar system preferences while maintaining layout dimensions (#2755)

view details

Max Yinger

commit sha ab1d84f74ed6860310a000a97b7b862daac1edbd

Templates: Update Fashion Template Aspect Ratio to 9:16 (#2577) Co-authored-by: Mariano Martinez III <mariano.martinez@formidable.com>

view details

push time in 7 days

issue commentgoogle/web-stories-wp

Templates: Update Fitness template to 9:16

Okay, I fixed the hidden character problem across all the pages that they appeared 👍

mariano-formidable

comment created time in 7 days

issue commentgoogle/web-stories-wp

Templates: Update Beauty template to 9:16

Okay, the broken image should be fixed!

mariano-formidable

comment created time in 7 days

pull request commentgoogle/web-stories-wp

Templates: Update Beauty Template Aspect Ratio to 9:16

@googlebot I consent.

littlemilkstudio

comment created time in 7 days

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 0d94101d61f751f30070a45d8d874926f7955e93

Exclude web-stories.php from coverage

view details

Pascal Birchler

commit sha 099ffd30d2d2d82f41bc51d93d84bbf998ef5a8a

Exclude uninstall.php from coverage

view details

Pascal Birchler

commit sha 41ab3f9b87a3355d7ffd353ca0c663ef9e4fd703

Move templates to folders

view details

Pascal Birchler

commit sha 99c88b9ea89c08493e11ba06fe04e48ff11edede

Exclude templates folder from coverage

view details

Pascal Birchler

commit sha 872cf995480f12e62d702aa9976ca615844ddf02

Update codecov config

view details

Pascal Birchler

commit sha f23f7ac62d352b381dec0a214e2dee2036d5b595

Merge branch 'master' into fix/328-exclude-from-coverage

view details

Clinton Volzke

commit sha 0bddd5e1cf9d98027f70dbe1043941b1f47f6cc8

Add useLocalMedia() hook that returns useMedia().local

view details

Clinton Volzke

commit sha ba8205346cdde384b3cdbcbbb9ae7fbb16fa4e9d

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Pascal Birchler

commit sha 68510b8e18ccedee5e84f25eba17ab07541c40f8

Add tests for Updater class

view details

Pascal Birchler

commit sha 0887bc296be8539358318364daaf83b79a653962

Lint fixes

view details

Pascal Birchler

commit sha 241408426d7d22a7a6e289443852bfdd7c80e302

Add more assertions

view details

Pascal Birchler

commit sha a5f39dc1c913ac5bce020ce4605b9ce97b4132cc

Multisite test

view details

Miina Sikk

commit sha 919743038e69e38e98771995162dd5ba793abf96

Fix color presets opacity detection.

view details

Clinton Volzke

commit sha 7019176e1c9a0cb08934cb465340c25ff52bd898

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Joanna Lee

commit sha ba1ff6902dfef98fceca02ba5b0c47b91f890e3e

Added flag for using a row-based gallery (#2821) This gallery will be used in the Uploaded Media tab.

view details

Clinton Volzke

commit sha fa615b895d17036ac148d766574f22c5061ecb7c

Add test for useLocalMedia

view details

Clinton Volzke

commit sha fed9e85b4b7f9e1d1f9a1359955ca26606559d85

Merge pull request #2805 from google/task/2610-add-useLocalMedia

view details

Brittany Feenstra

commit sha 7692fff80cedf8865abadd142de74a9e8f97f564

Dashboard: Honor scrollbar system preferences while maintaining layout dimensions (#2755)

view details

Max Yinger

commit sha ab1d84f74ed6860310a000a97b7b862daac1edbd

Templates: Update Fashion Template Aspect Ratio to 9:16 (#2577) Co-authored-by: Mariano Martinez III <mariano.martinez@formidable.com>

view details

Pascal Birchler

commit sha 1776fcb8531c20d10a20faa474ba0321b08085e2

Text Presets: Fix default values (#2781)

view details

push time in 7 days

pull request commentgoogle/web-stories-wp

Templates: Update Fitness Template Aspect Ratio to 9:16

@googlebot I constent

littlemilkstudio

comment created time in 7 days

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 0d94101d61f751f30070a45d8d874926f7955e93

Exclude web-stories.php from coverage

view details

Pascal Birchler

commit sha 099ffd30d2d2d82f41bc51d93d84bbf998ef5a8a

Exclude uninstall.php from coverage

view details

Pascal Birchler

commit sha 41ab3f9b87a3355d7ffd353ca0c663ef9e4fd703

Move templates to folders

view details

Pascal Birchler

commit sha 99c88b9ea89c08493e11ba06fe04e48ff11edede

Exclude templates folder from coverage

view details

Pascal Birchler

commit sha 872cf995480f12e62d702aa9976ca615844ddf02

Update codecov config

view details

Pascal Birchler

commit sha f23f7ac62d352b381dec0a214e2dee2036d5b595

Merge branch 'master' into fix/328-exclude-from-coverage

view details

Clinton Volzke

commit sha 0bddd5e1cf9d98027f70dbe1043941b1f47f6cc8

Add useLocalMedia() hook that returns useMedia().local

view details

Clinton Volzke

commit sha ba8205346cdde384b3cdbcbbb9ae7fbb16fa4e9d

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Pascal Birchler

commit sha 68510b8e18ccedee5e84f25eba17ab07541c40f8

Add tests for Updater class

view details

Pascal Birchler

commit sha 0887bc296be8539358318364daaf83b79a653962

Lint fixes

view details

Pascal Birchler

commit sha 241408426d7d22a7a6e289443852bfdd7c80e302

Add more assertions

view details

Pascal Birchler

commit sha a5f39dc1c913ac5bce020ce4605b9ce97b4132cc

Multisite test

view details

Brittany Feenstra

commit sha fbd6d8f644283311e6a43e62e78b88cb4f7b9599

update stories per request to 24 per page to reduce load time. Separate constants for per page request counts for users and stories. We need all the users to get proper display for stories, we do not need all the stories. 24 should be a happy medium for users with huge monitors and the average laptop or tablet user.

view details

Miina Sikk

commit sha 919743038e69e38e98771995162dd5ba793abf96

Fix color presets opacity detection.

view details

Brittany Feenstra

commit sha 28107a5c66417abc943a224ea4fb0090d5edf731

Merge pull request #2789 from google/task/per-page-query-updates Dashboard: Update stories per request count to speed up time to first interaction

view details

Clinton Volzke

commit sha 7019176e1c9a0cb08934cb465340c25ff52bd898

Merge branch 'master' into task/2610-add-useLocalMedia

view details

Joanna Lee

commit sha ba1ff6902dfef98fceca02ba5b0c47b91f890e3e

Added flag for using a row-based gallery (#2821) This gallery will be used in the Uploaded Media tab.

view details

Clinton Volzke

commit sha fa615b895d17036ac148d766574f22c5061ecb7c

Add test for useLocalMedia

view details

Clinton Volzke

commit sha fed9e85b4b7f9e1d1f9a1359955ca26606559d85

Merge pull request #2805 from google/task/2610-add-useLocalMedia

view details

Brittany Feenstra

commit sha 7692fff80cedf8865abadd142de74a9e8f97f564

Dashboard: Honor scrollbar system preferences while maintaining layout dimensions (#2755)

view details

push time in 7 days

Pull request review commentgoogle/web-stories-wp

Dashboard: Update template descriptions

 export default function ({ assetsURL }) {         { label: 'Light Grey', color: '#d8d8d8' },         { label: 'White', color: '#fff' },       ],-      description:-        'In lorem est, aliquam tempus justo nec, tincidunt aliquet diam. Fusce ut nisl ex. Nam mollis dolor non arcu.',+      description: __(+        'With a warm color palette and soothing shapes, the Wellbeing template works best for web stories covering mindfulness, lifestyle health and related exercise and activities like Yoga, Spa treatments and the likes.',

I believe it should be "... and the like" (the expression ends with a singular "like" if I recall correctly).

BrittanyIRL

comment created time in 8 days

Pull request review commentgoogle/web-stories-wp

Dashboard: Update template descriptions

 export default function ({ assetsURL }) {         { label: 'White', color: '#fff' },         { label: 'Brown', color: '#eadfd6' },       ],-      description:-        'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus consectetur mauris sodales magna elementum maximus.',+      description: __(+        'The modern and bright Beauty template lends itself well as foundation for stories covering make up, beauty products, shopping guides, instructions & tutorials and more.',

Should it be "...lends itself well as a foundation for..." (there should be an "a" before foundation, right?)

BrittanyIRL

comment created time in 8 days

Pull request review commentgoogle/web-stories-wp

Shapes: Add new shapes to library

 function ShapesPane(props) {       )}       <Section title={__('Basic shapes', 'web-stories')}>         <SectionContent>-          {MASKS.map((mask) => (-            <ShapePreview mask={mask} key={mask.type} />+          {MASKS.filter((mask) => mask.showInLibrary).map((mask) => (

@dvoytenko Okay, now only masks with showInLibrary as true will appear in the shapes panel. This is how the shapes panel looks now (all the new ones are hidden): image

Does this work?

littlemilkstudio

comment created time in 8 days

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha bf08bd889d2011fbfe562bea505c760b042016fd

Added showInLibrary filter so we can toggle when mask/shapes should appear in library

view details

push time in 8 days

pull request commentgoogle/web-stories-wp

Shapes: Add new shapes to library

@dvoytenko @samitron7 Yeah, I can make a boolean to hide the masks from appearing in the panel, so user's won't be able to use them and we won't have the beta pressure to figure out all the correct UX stuff.

littlemilkstudio

comment created time in 8 days

pull request commentgoogle/web-stories-wp

Shapes: Add new shapes to library

@googlebot I agree

littlemilkstudio

comment created time in 8 days

pull request commentgoogle/web-stories-wp

Shapes: Add new shapes to library

FYI, I'm taking over this PR because Max is on PTO for this entire week.

@dvoytenko I've removed the older shapes that you mentioned (the blobs that are still there are part of the Wellness template).

@samitron7 I'm going to move this PR into QA to get it merged, and I'm going to create another ticket to allow us to tag shapes with isMask (or something like that as Dima mentioned) so we can enable/disable the masking on any shapes that we need.

littlemilkstudio

comment created time in 8 days

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 2c258edd459e8f6dbe07b05921cbe4463c07fdaa

Create media3p reducer folder structure

view details

Brittany Feenstra

commit sha 32ab3042530f09a8696df947357fed186c4591d9

clean up template detail nav bar to be reusable for story details as well

view details

Brittany Feenstra

commit sha d38a807d0d8398ddb57f7a49aaf2f7ec82356759

check if click handler for bookmarking is present before rendering button for bookmarking

view details

Brittany Feenstra

commit sha 002865b81c82bb6812681b165f765ddf5897baa1

keep flag and use a callback :)

view details

Clinton Volzke

commit sha cfb61910d2ade5036a81be3fa1c507e2b3075a07

Merge branch 'task/2424-move-local-reducer' into task/2427-media-reducer-folders

view details

Clinton Volzke

commit sha ff19b6a086210daf25d5fff361aac9952809eeb1

Add test for media3p/reducer.js

view details

Clinton Volzke

commit sha 2656d0cf867200416978d87717504d1f8399449e

Move state initial values to use reducer function defaults

view details

Clinton Volzke

commit sha 927c5e8bf5e3f9fe0542d2b68a4c1324140536b4

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha 06eb30bd2c75af76c03fa272531652263ad7420d

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha a2f3cde316877652de46b66113eb4e1325507271

Create media3p state folder structure

view details

Dima Voytenko

commit sha 8d6ea80ef4c05d01fd885f4521ba1985091c426c

Karma: enable coverage reports (#2583) * Karma: enable coverage reports * Update webpack.config.test.cjs Co-authored-by: Pascal Birchler <pascalb@google.com> * reorder deps * try project/flag config * try separating, take 2 * splitting, take 3 * splitting take 4 * splitting take 6 Co-authored-by: Pascal Birchler <pascalb@google.com>

view details

Pascal Birchler

commit sha d5139474b2f64528bb9ec65095e6ca4ab5caaae3

Make dialog appearance more coherent (#2734)

view details

dependabot-preview[bot]

commit sha 6ca501f35c4fe16f90dd27e2d70faee07af8979d

Bump @wordpress/data from 4.20.0 to 4.21.0 (#2771) Bumps [@wordpress/data](https://github.com/WordPress/gutenberg/tree/HEAD/packages/data) from 4.20.0 to 4.21.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/master/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/data@4.21.0/packages/data) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Mariano Martinez III

commit sha cfa40a921257cb68cdb9c64a6837174a24db52e4

Dashboard: Applied design updates to Entertainment template

view details

Mariano Martinez III

commit sha da49f8bddc1639533e85d7961f5ed4caacd5c018

Fixed text animation

view details

Mariano Martinez III

commit sha 6b403b507c340693f7a8724efee22a9d64092689

Fixed some typos

view details

Mariano Martinez III

commit sha eab8e65698e5be310cf305a445966ce6198991ea

Fixed style issues

view details

Mariano Martinez III

commit sha 3a569badce0d40483c004be6ec4381fede75238b

Fixed images

view details

Dillon Mulroy

commit sha 3c22ea01bc22707cb0a9345e3b53edf6f5c527fe

Dashboard: Initial Karma integration + setup (#2647) * refactor webpack.config.test to export and object with both js projects webpack config, create karma.dashboard-config.cjs * rename edit-story karma config, add karma config for dashboard, add npm run script for dashboard karma * add karma _init to dashboard * move _init.js to the top level karma folder to share for both edit-story and dashboard, update webpack configs to pick up init.js * initial fixture work * add initia ApiProviderFixture * finish initial stub of ApiProviderFixture * Stub the ApiProvider in the fixture class * Wip * mock/stub getAllFonts * add initial basic karma test * update basic test * update npm scripts * move events fixture to shared karma folder * update github action * re add events file * update npm script and eslint * rename karma configs * remove commented code * relocate shareable karma code * split karma tests and remove snapshotting from dashboard * update .distignore * update gh action names * update folder structure * updat path * cherry pick webpack test config from other branch * update run cmd * typo * add code coverage * rename code cove dirs * bump browserNoActivityTimeout * typos

view details

Dima Voytenko

commit sha 182161b5ec90e6b91fa1c7836bbfe54806c59c07

Re-enable carousel integration tests (#2708) * Re-enable carousel integration tests * review fixes

view details

push time in 8 days

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha e2df34f3b1b45196223bf569bee189c2873bd139

Removed blobs not associated with templates and calculated ratio values

view details

push time in 8 days

PR closed google/web-stories-wp

[WIP] Dashboard: Completed animations for Entertainment template cla: yes

Summary

<!-- A brief description of what this PR does. -->

Relevant Technical Choices

<!-- Please describe your changes. -->

To-do

<!-- A list of things that need to be addressed in this PR or follow-up changes. -->

User-facing changes

<!-- Please describe your changes. -->

Testing Instructions

<!-- How can the changes in this PR be verified? Relevant for QA and user acceptance testing. -->


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #

+1181 -606

3 comments

3 changed files

mariano-formidable

pr closed time in 8 days

pull request commentgoogle/web-stories-wp

[WIP] Dashboard: Completed animations for Entertainment template

These animations were included with the PR for #2479

mariano-formidable

comment created time in 8 days

push eventgoogle/web-stories-wp

Brittany Feenstra

commit sha fbd6d8f644283311e6a43e62e78b88cb4f7b9599

update stories per request to 24 per page to reduce load time. Separate constants for per page request counts for users and stories. We need all the users to get proper display for stories, we do not need all the stories. 24 should be a happy medium for users with huge monitors and the average laptop or tablet user.

view details

Brittany Feenstra

commit sha 28107a5c66417abc943a224ea4fb0090d5edf731

Merge pull request #2789 from google/task/per-page-query-updates Dashboard: Update stories per request count to speed up time to first interaction

view details

Maxwell Yinger

commit sha 2a96396b1e272ba0b0ff1e4ba2dd9e6f4dd87183

wip

view details

Maxwell Yinger

commit sha c3e4358aca5a4ef56e495af930c3e72af9c7b84b

beauty template updated

view details

Maxwell Yinger

commit sha ee4cdeca2c6567a2f98cb684eb4e5be05fe7dd2e

added beauty grid to shapes panel

view details

Maxwell Yinger

commit sha 8e61df4213c3921335133021be2e4643fc345ccd

update beauty template to use grid svgs

view details

Maxwell Yinger

commit sha 9ea4eba8e329792dee94c28279253762462b5e17

remove trailing space from path def

view details

push time in 8 days

issue commentgoogle/web-stories-wp

Templates: Update DIY template to 9:16

It looks like you were reviewing the Fitness template, but this story is to update the DIY. The cover image for DIY is this: image

mariano-formidable

comment created time in 8 days

issue commentgoogle/web-stories-wp

Templates: Update Fashion template to 9:16

The social icons have been removed, and a 4th image added. However, because QA isn't updated with new images unless they're merged into master first, the 4th image on the final page of the template might appear broken during your test, but it is working and will appear when merged: image

mariano-formidable

comment created time in 8 days

issue closedgoogle/web-stories-wp

Animations: Add animations to ENTERTAINMENT template to match designs

The animation process for a template is as follows:

  • Applying animations in the animation editor /story-anim-tool
  • Alter its static layout if needed to accommodate the animation
  • If template requires a new animation part that doesn't already exist
    • Create ticket for missing animation part
    • Add animation part to code base
    • Go back to template and apply newly created animation part
    • Continue with template animations

Reference the figma designs: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=1%3A8

And reference the movie clips from this folder: https://drive.google.com/drive/folders/1E0nLATcplhGNzgteOymx3s2SyA-cc7_M

closed time in 8 days

mariano-formidable

issue commentgoogle/web-stories-wp

Animations: Add animations to ENTERTAINMENT template to match designs

The animations were merged in with #2474

mariano-formidable

comment created time in 8 days

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 158bdbd59f0141d86952d265344d2a2212cc0187

Fixed final page of template

view details

push time in 8 days

pull request commentgoogle/web-stories-wp

Templates: Update Fashion Template Aspect Ratio to 9:16

@googlebot I agree

littlemilkstudio

comment created time in 8 days

issue commentgoogle/web-stories-wp

Templates: Update Fitness template to 9:16

The missing images have been merged into master, so they should start appearing in the QA environment.

mariano-formidable

comment created time in 8 days

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 2c258edd459e8f6dbe07b05921cbe4463c07fdaa

Create media3p reducer folder structure

view details

Brittany Feenstra

commit sha 32ab3042530f09a8696df947357fed186c4591d9

clean up template detail nav bar to be reusable for story details as well

view details

Brittany Feenstra

commit sha d38a807d0d8398ddb57f7a49aaf2f7ec82356759

check if click handler for bookmarking is present before rendering button for bookmarking

view details

Brittany Feenstra

commit sha 002865b81c82bb6812681b165f765ddf5897baa1

keep flag and use a callback :)

view details

Clinton Volzke

commit sha cfb61910d2ade5036a81be3fa1c507e2b3075a07

Merge branch 'task/2424-move-local-reducer' into task/2427-media-reducer-folders

view details

Clinton Volzke

commit sha ff19b6a086210daf25d5fff361aac9952809eeb1

Add test for media3p/reducer.js

view details

Clinton Volzke

commit sha 2656d0cf867200416978d87717504d1f8399449e

Move state initial values to use reducer function defaults

view details

Clinton Volzke

commit sha 927c5e8bf5e3f9fe0542d2b68a4c1324140536b4

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha 06eb30bd2c75af76c03fa272531652263ad7420d

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha a2f3cde316877652de46b66113eb4e1325507271

Create media3p state folder structure

view details

Mariano Martinez III

commit sha cfa40a921257cb68cdb9c64a6837174a24db52e4

Dashboard: Applied design updates to Entertainment template

view details

Mariano Martinez III

commit sha da49f8bddc1639533e85d7961f5ed4caacd5c018

Fixed text animation

view details

Mariano Martinez III

commit sha 6b403b507c340693f7a8724efee22a9d64092689

Fixed some typos

view details

Mariano Martinez III

commit sha eab8e65698e5be310cf305a445966ce6198991ea

Fixed style issues

view details

Mariano Martinez III

commit sha 3a569badce0d40483c004be6ec4381fede75238b

Fixed images

view details

Dillon Mulroy

commit sha 3c22ea01bc22707cb0a9345e3b53edf6f5c527fe

Dashboard: Initial Karma integration + setup (#2647) * refactor webpack.config.test to export and object with both js projects webpack config, create karma.dashboard-config.cjs * rename edit-story karma config, add karma config for dashboard, add npm run script for dashboard karma * add karma _init to dashboard * move _init.js to the top level karma folder to share for both edit-story and dashboard, update webpack configs to pick up init.js * initial fixture work * add initia ApiProviderFixture * finish initial stub of ApiProviderFixture * Stub the ApiProvider in the fixture class * Wip * mock/stub getAllFonts * add initial basic karma test * update basic test * update npm scripts * move events fixture to shared karma folder * update github action * re add events file * update npm script and eslint * rename karma configs * remove commented code * relocate shareable karma code * split karma tests and remove snapshotting from dashboard * update .distignore * update gh action names * update folder structure * updat path * cherry pick webpack test config from other branch * update run cmd * typo * add code coverage * rename code cove dirs * bump browserNoActivityTimeout * typos

view details

Dima Voytenko

commit sha 182161b5ec90e6b91fa1c7836bbfe54806c59c07

Re-enable carousel integration tests (#2708) * Re-enable carousel integration tests * review fixes

view details

dependabot-preview[bot]

commit sha 10477ad980034d42a62085f95762109750a8e167

Bump browserslist from 4.12.1 to 4.12.2 (#2790) Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.12.1 to 4.12.2. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/master/CHANGELOG.md) - [Commits](https://github.com/browserslist/browserslist/compare/4.12.1...4.12.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 50836cb53fe17cc1e31deb7a287e6b7de244c2b4

Bump @ampproject/toolbox-optimizer from 2.5.4 to 2.5.5 (#2791) Bumps [@ampproject/toolbox-optimizer](https://github.com/ampproject/amp-toolbox/tree/HEAD/packages/optimizer) from 2.5.4 to 2.5.5. - [Release notes](https://github.com/ampproject/amp-toolbox/releases) - [Changelog](https://github.com/ampproject/amp-toolbox/blob/main/CHANGELOG.md) - [Commits](https://github.com/ampproject/amp-toolbox/commits/v2.5.5/packages/optimizer) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Brittany Feenstra

commit sha 45be10015ce49e19957acdfdb5be1740686e55fa

Merge pull request #2756 from google/task/refactor-detail-nav Dashboard: Refactor detail nav bar to reuse for stories

view details

push time in 8 days

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 2c258edd459e8f6dbe07b05921cbe4463c07fdaa

Create media3p reducer folder structure

view details

Brittany Feenstra

commit sha 32ab3042530f09a8696df947357fed186c4591d9

clean up template detail nav bar to be reusable for story details as well

view details

Brittany Feenstra

commit sha d38a807d0d8398ddb57f7a49aaf2f7ec82356759

check if click handler for bookmarking is present before rendering button for bookmarking

view details

Brittany Feenstra

commit sha 002865b81c82bb6812681b165f765ddf5897baa1

keep flag and use a callback :)

view details

Clinton Volzke

commit sha cfb61910d2ade5036a81be3fa1c507e2b3075a07

Merge branch 'task/2424-move-local-reducer' into task/2427-media-reducer-folders

view details

Clinton Volzke

commit sha ff19b6a086210daf25d5fff361aac9952809eeb1

Add test for media3p/reducer.js

view details

Clinton Volzke

commit sha 2656d0cf867200416978d87717504d1f8399449e

Move state initial values to use reducer function defaults

view details

Clinton Volzke

commit sha 927c5e8bf5e3f9fe0542d2b68a4c1324140536b4

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha 06eb30bd2c75af76c03fa272531652263ad7420d

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha a2f3cde316877652de46b66113eb4e1325507271

Create media3p state folder structure

view details

Dima Voytenko

commit sha 8d6ea80ef4c05d01fd885f4521ba1985091c426c

Karma: enable coverage reports (#2583) * Karma: enable coverage reports * Update webpack.config.test.cjs Co-authored-by: Pascal Birchler <pascalb@google.com> * reorder deps * try project/flag config * try separating, take 2 * splitting, take 3 * splitting take 4 * splitting take 6 Co-authored-by: Pascal Birchler <pascalb@google.com>

view details

Pascal Birchler

commit sha d5139474b2f64528bb9ec65095e6ca4ab5caaae3

Make dialog appearance more coherent (#2734)

view details

dependabot-preview[bot]

commit sha 6ca501f35c4fe16f90dd27e2d70faee07af8979d

Bump @wordpress/data from 4.20.0 to 4.21.0 (#2771) Bumps [@wordpress/data](https://github.com/WordPress/gutenberg/tree/HEAD/packages/data) from 4.20.0 to 4.21.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/master/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/data@4.21.0/packages/data) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Mariano Martinez III

commit sha cfa40a921257cb68cdb9c64a6837174a24db52e4

Dashboard: Applied design updates to Entertainment template

view details

Mariano Martinez III

commit sha da49f8bddc1639533e85d7961f5ed4caacd5c018

Fixed text animation

view details

Mariano Martinez III

commit sha 6b403b507c340693f7a8724efee22a9d64092689

Fixed some typos

view details

Mariano Martinez III

commit sha eab8e65698e5be310cf305a445966ce6198991ea

Fixed style issues

view details

Mariano Martinez III

commit sha 3a569badce0d40483c004be6ec4381fede75238b

Fixed images

view details

Dillon Mulroy

commit sha 3c22ea01bc22707cb0a9345e3b53edf6f5c527fe

Dashboard: Initial Karma integration + setup (#2647) * refactor webpack.config.test to export and object with both js projects webpack config, create karma.dashboard-config.cjs * rename edit-story karma config, add karma config for dashboard, add npm run script for dashboard karma * add karma _init to dashboard * move _init.js to the top level karma folder to share for both edit-story and dashboard, update webpack configs to pick up init.js * initial fixture work * add initia ApiProviderFixture * finish initial stub of ApiProviderFixture * Stub the ApiProvider in the fixture class * Wip * mock/stub getAllFonts * add initial basic karma test * update basic test * update npm scripts * move events fixture to shared karma folder * update github action * re add events file * update npm script and eslint * rename karma configs * remove commented code * relocate shareable karma code * split karma tests and remove snapshotting from dashboard * update .distignore * update gh action names * update folder structure * updat path * cherry pick webpack test config from other branch * update run cmd * typo * add code coverage * rename code cove dirs * bump browserNoActivityTimeout * typos

view details

Dima Voytenko

commit sha 182161b5ec90e6b91fa1c7836bbfe54806c59c07

Re-enable carousel integration tests (#2708) * Re-enable carousel integration tests * review fixes

view details

push time in 8 days

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 2c258edd459e8f6dbe07b05921cbe4463c07fdaa

Create media3p reducer folder structure

view details

Brittany Feenstra

commit sha 32ab3042530f09a8696df947357fed186c4591d9

clean up template detail nav bar to be reusable for story details as well

view details

Brittany Feenstra

commit sha d38a807d0d8398ddb57f7a49aaf2f7ec82356759

check if click handler for bookmarking is present before rendering button for bookmarking

view details

Brittany Feenstra

commit sha 002865b81c82bb6812681b165f765ddf5897baa1

keep flag and use a callback :)

view details

Clinton Volzke

commit sha cfb61910d2ade5036a81be3fa1c507e2b3075a07

Merge branch 'task/2424-move-local-reducer' into task/2427-media-reducer-folders

view details

Clinton Volzke

commit sha ff19b6a086210daf25d5fff361aac9952809eeb1

Add test for media3p/reducer.js

view details

Clinton Volzke

commit sha 2656d0cf867200416978d87717504d1f8399449e

Move state initial values to use reducer function defaults

view details

Clinton Volzke

commit sha 927c5e8bf5e3f9fe0542d2b68a4c1324140536b4

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha 06eb30bd2c75af76c03fa272531652263ad7420d

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha a2f3cde316877652de46b66113eb4e1325507271

Create media3p state folder structure

view details

Mariano Martinez III

commit sha cfa40a921257cb68cdb9c64a6837174a24db52e4

Dashboard: Applied design updates to Entertainment template

view details

Mariano Martinez III

commit sha da49f8bddc1639533e85d7961f5ed4caacd5c018

Fixed text animation

view details

Mariano Martinez III

commit sha 6b403b507c340693f7a8724efee22a9d64092689

Fixed some typos

view details

Mariano Martinez III

commit sha eab8e65698e5be310cf305a445966ce6198991ea

Fixed style issues

view details

Mariano Martinez III

commit sha 3a569badce0d40483c004be6ec4381fede75238b

Fixed images

view details

Dillon Mulroy

commit sha 3c22ea01bc22707cb0a9345e3b53edf6f5c527fe

Dashboard: Initial Karma integration + setup (#2647) * refactor webpack.config.test to export and object with both js projects webpack config, create karma.dashboard-config.cjs * rename edit-story karma config, add karma config for dashboard, add npm run script for dashboard karma * add karma _init to dashboard * move _init.js to the top level karma folder to share for both edit-story and dashboard, update webpack configs to pick up init.js * initial fixture work * add initia ApiProviderFixture * finish initial stub of ApiProviderFixture * Stub the ApiProvider in the fixture class * Wip * mock/stub getAllFonts * add initial basic karma test * update basic test * update npm scripts * move events fixture to shared karma folder * update github action * re add events file * update npm script and eslint * rename karma configs * remove commented code * relocate shareable karma code * split karma tests and remove snapshotting from dashboard * update .distignore * update gh action names * update folder structure * updat path * cherry pick webpack test config from other branch * update run cmd * typo * add code coverage * rename code cove dirs * bump browserNoActivityTimeout * typos

view details

Dima Voytenko

commit sha 182161b5ec90e6b91fa1c7836bbfe54806c59c07

Re-enable carousel integration tests (#2708) * Re-enable carousel integration tests * review fixes

view details

dependabot-preview[bot]

commit sha 10477ad980034d42a62085f95762109750a8e167

Bump browserslist from 4.12.1 to 4.12.2 (#2790) Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.12.1 to 4.12.2. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/master/CHANGELOG.md) - [Commits](https://github.com/browserslist/browserslist/compare/4.12.1...4.12.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 50836cb53fe17cc1e31deb7a287e6b7de244c2b4

Bump @ampproject/toolbox-optimizer from 2.5.4 to 2.5.5 (#2791) Bumps [@ampproject/toolbox-optimizer](https://github.com/ampproject/amp-toolbox/tree/HEAD/packages/optimizer) from 2.5.4 to 2.5.5. - [Release notes](https://github.com/ampproject/amp-toolbox/releases) - [Changelog](https://github.com/ampproject/amp-toolbox/blob/main/CHANGELOG.md) - [Commits](https://github.com/ampproject/amp-toolbox/commits/v2.5.5/packages/optimizer) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Brittany Feenstra

commit sha 45be10015ce49e19957acdfdb5be1740686e55fa

Merge pull request #2756 from google/task/refactor-detail-nav Dashboard: Refactor detail nav bar to reuse for stories

view details

push time in 8 days

push eventgoogle/web-stories-wp

Carlos Kelly

commit sha 9c24ffc3f3c642d9d457aa02fb697b5c8b45d2ac

Add Keyboard Events to New Font Picker Remove unused import.

view details

Carlos Kelly

commit sha 7da4a6931689b420c828894468df69122b83c5df

Remove tabbing for navigating fonts.

view details

Carlos Kelly

commit sha 803f2ebf20a408ab9235e711fcef528024392c2e

Added search to font picker.

view details

Carlos Kelly

commit sha 2ab9170d71f0e08b48128433a2cd70bb308f960c

Fixed props and updated input type

view details

Carlos Kelly

commit sha 654ec4ee85aa7f62f44a412b7891bcaf605a1f46

Add aria props and debounce callback.

view details

Carlos Kelly

commit sha ba476d3c577823d011e28c99368e220820cf6902

Remove unused useMemo

view details

Carlos Kelly

commit sha 566155fff734b4106d3ad24e4a505d0c193b6b18

Fix tests for new debounced callback

view details

Carlos Kelly

commit sha d110efa76b0d75b8d849a38e20718f6d3444205e

Add Keyboard Events to New Font Picker Remove unused import.

view details

Carlos Kelly

commit sha 4c631ea51099c874e9d370c7a04ccf349d2ab196

Remove tabbing for navigating fonts.

view details

Carlos Kelly

commit sha a8b197c360144df4cfca287eaf968402b5740df5

Added search to font picker.

view details

Carlos Kelly

commit sha 8904c9eaab044ba75f3629fed0d265553b3878ec

Fixed props and updated input type

view details

Carlos Kelly

commit sha 0e318ad43016965eb6addd0e154cb2e363af3089

Add aria props and debounce callback.

view details

Carlos Kelly

commit sha a5c0fa05f48b8e681e77ab61987c0db9962df152

Fixed font loading, Added Esc test.

view details

Carlos Kelly

commit sha 3d3d667a736571d3c7975d6e07e8ca4ed1c6f904

Focus search input on font picker open.

view details

Carlos Kelly

commit sha 50de7ea492667a6c198bd14fd1e8d79dd5fb6217

Open picker using ArrowDown when focused.

view details

Carlos Kelly

commit sha 7f486b99dd817b2fee1b9c023bb5faca43f131cf

Adding dialog role to prevent double-key events.

view details

Miina Sikk

commit sha 095b146b1c19f678b68cd715010e824c9ed17943

Display whiteout on text and only when it's not Fill.

view details

Miina Sikk

commit sha bb1a1dad6f1460b2f777294b6ebd880552df5cb9

Revert fill logic.

view details

Pascal Birchler

commit sha 16d6de99e50b0dd2b466f66e899a90dce6e03207

Add uninstall.php file

view details

Miina Sikk

commit sha 13a70a54b82cd2a638cf602aca46aece9feec2c0

Merge remote-tracking branch 'origin/master' into fix/1883-edit-mode

view details

push time in 8 days

push eventgoogle/web-stories-wp

Carlos Kelly

commit sha 9c24ffc3f3c642d9d457aa02fb697b5c8b45d2ac

Add Keyboard Events to New Font Picker Remove unused import.

view details

Carlos Kelly

commit sha 7da4a6931689b420c828894468df69122b83c5df

Remove tabbing for navigating fonts.

view details

Carlos Kelly

commit sha 803f2ebf20a408ab9235e711fcef528024392c2e

Added search to font picker.

view details

Carlos Kelly

commit sha 2ab9170d71f0e08b48128433a2cd70bb308f960c

Fixed props and updated input type

view details

Carlos Kelly

commit sha 654ec4ee85aa7f62f44a412b7891bcaf605a1f46

Add aria props and debounce callback.

view details

Carlos Kelly

commit sha ba476d3c577823d011e28c99368e220820cf6902

Remove unused useMemo

view details

Carlos Kelly

commit sha 566155fff734b4106d3ad24e4a505d0c193b6b18

Fix tests for new debounced callback

view details

Carlos Kelly

commit sha d110efa76b0d75b8d849a38e20718f6d3444205e

Add Keyboard Events to New Font Picker Remove unused import.

view details

Carlos Kelly

commit sha 4c631ea51099c874e9d370c7a04ccf349d2ab196

Remove tabbing for navigating fonts.

view details

Carlos Kelly

commit sha a8b197c360144df4cfca287eaf968402b5740df5

Added search to font picker.

view details

Carlos Kelly

commit sha 8904c9eaab044ba75f3629fed0d265553b3878ec

Fixed props and updated input type

view details

Carlos Kelly

commit sha 0e318ad43016965eb6addd0e154cb2e363af3089

Add aria props and debounce callback.

view details

Carlos Kelly

commit sha a5c0fa05f48b8e681e77ab61987c0db9962df152

Fixed font loading, Added Esc test.

view details

Carlos Kelly

commit sha 3d3d667a736571d3c7975d6e07e8ca4ed1c6f904

Focus search input on font picker open.

view details

Carlos Kelly

commit sha 50de7ea492667a6c198bd14fd1e8d79dd5fb6217

Open picker using ArrowDown when focused.

view details

Carlos Kelly

commit sha 7f486b99dd817b2fee1b9c023bb5faca43f131cf

Adding dialog role to prevent double-key events.

view details

Dima Voytenko

commit sha 6ff7f8b342ced1b797226e667756d7f0ed339f98

Test Percy

view details

Miina Sikk

commit sha 095b146b1c19f678b68cd715010e824c9ed17943

Display whiteout on text and only when it's not Fill.

view details

Miina Sikk

commit sha bb1a1dad6f1460b2f777294b6ebd880552df5cb9

Revert fill logic.

view details

Pascal Birchler

commit sha 16d6de99e50b0dd2b466f66e899a90dce6e03207

Add uninstall.php file

view details

push time in 8 days

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 2c258edd459e8f6dbe07b05921cbe4463c07fdaa

Create media3p reducer folder structure

view details

Clinton Volzke

commit sha cfb61910d2ade5036a81be3fa1c507e2b3075a07

Merge branch 'task/2424-move-local-reducer' into task/2427-media-reducer-folders

view details

Clinton Volzke

commit sha ff19b6a086210daf25d5fff361aac9952809eeb1

Add test for media3p/reducer.js

view details

Clinton Volzke

commit sha 2656d0cf867200416978d87717504d1f8399449e

Move state initial values to use reducer function defaults

view details

Clinton Volzke

commit sha 927c5e8bf5e3f9fe0542d2b68a4c1324140536b4

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha 06eb30bd2c75af76c03fa272531652263ad7420d

Move context value provider from MediaProvider to local/useContextValue

view details

Clinton Volzke

commit sha a2f3cde316877652de46b66113eb4e1325507271

Create media3p state folder structure

view details

Mariano Martinez III

commit sha cfa40a921257cb68cdb9c64a6837174a24db52e4

Dashboard: Applied design updates to Entertainment template

view details

Mariano Martinez III

commit sha da49f8bddc1639533e85d7961f5ed4caacd5c018

Fixed text animation

view details

Mariano Martinez III

commit sha 6b403b507c340693f7a8724efee22a9d64092689

Fixed some typos

view details

Mariano Martinez III

commit sha eab8e65698e5be310cf305a445966ce6198991ea

Fixed style issues

view details

Mariano Martinez III

commit sha 3a569badce0d40483c004be6ec4381fede75238b

Fixed images

view details

Mariano Martinez III

commit sha fd8d7263df34bfe637973a084ce4af67ccef51ac

Dashboard: Applied design updates to Cooking template

view details

Mariano Martinez III

commit sha da775a28fecaafe01319209ca7d94f430a17a2ae

Fixed alignment issues

view details

Mariano Martinez III

commit sha 3cf58e0db24c07fc32d1f08a0e2bbe2c45703aaa

Updated versions

view details

dependabot-preview[bot]

commit sha 50591353c19fe74a6d01166676aca779790a9c83

Bump eslint-plugin-import from 2.21.2 to 2.22.0 (#2795)

view details

Clinton Volzke

commit sha e9906e8dd3887405cfccfce2e2396e0762c1096b

Add TODO for providerReducer.js

view details

Clinton Volzke

commit sha 4776c3bb1d511485bde9c2b39891f41ed98bd244

Fix import comment

view details

Clinton Volzke

commit sha d94f390ae071a74f6b21fba581c7e4ac3f7e5ed2

Rename provideContextValue to useContextValueProvider

view details

Clinton Volzke

commit sha ae0c932f81985bcd00cadb7764c92ebb21c188e6

Fix import statement ordering

view details

push time in 8 days

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha 3c283b242de12bbf9f2c63095f5834d481d4b8de

Added new and updated images for templates

view details

Mariano Martinez III

commit sha ee2ac8834c485264f2467fbc030f990a56560705

Merge pull request #2812 from google/task/template-images Dashboard: Added new and updated images for templates

view details

push time in 8 days

delete branch google/web-stories-wp

delete branch : task/template-images

delete time in 8 days

PR merged google/web-stories-wp

Reviewers
Dashboard: Added new and updated images for templates cla: yes

Summary

This PR just adds in all the new and updates images we're using for the latest template updates, this way they can be merged into master so they'll appear properly when QAing our other template PRs.

User-facing changes

  • None
+0 -0

2 comments

18 changed files

mariano-formidable

pr closed time in 8 days

PR opened google/web-stories-wp

Reviewers
Dashboard: Added new and updated images for templates

Summary

This PR just adds in all the new and updates images we're using for the latest template updates, this way they can be merged into master so they'll appear properly when QAing our other template PRs.

User-facing changes

  • None
+0 -0

0 comment

18 changed files

pr created time in 8 days

create barnchgoogle/web-stories-wp

branch : task/template-images

created branch time in 8 days

IssuesEvent

push eventgoogle/web-stories-wp

Mariano Martinez III

commit sha fd8d7263df34bfe637973a084ce4af67ccef51ac

Dashboard: Applied design updates to Cooking template

view details

Mariano Martinez III

commit sha da775a28fecaafe01319209ca7d94f430a17a2ae

Fixed alignment issues

view details

Mariano Martinez III

commit sha 3cf58e0db24c07fc32d1f08a0e2bbe2c45703aaa

Updated versions

view details

Mariano Martinez III

commit sha 363c9bd95f43638a426eab5a689b7c0950e04e54

Merge pull request #2684 from google/task/apply-916-cooking Dashboard: Applied design updates to Cooking template

view details

push time in 8 days

PR merged google/web-stories-wp

Reviewers
Dashboard: Applied design updates to Cooking template cla: yes

Summary

This PR applies the new design updates to the Cooking template.

User-facing changes

Layout and text sizes have been update on the Cooking template based off the recommendations found in this figma design doc.

TODO

  • We don't yet have the SVG grids imported into our shapes panel, so I used lines to manually lay out the grid. In a follow up PR (when the SVG grids are imported), I'll update the template to use the SVG grids.

Testing Instructions

1.) Go to "Explore Templates". 2.) Hover over the Cooking template and click on "View". 3.) Take a look at each template page in the detail view for Cooking. Make sure images are showing up and the layout appears as shown in the figma updates.


Fixes #2472

Screenshots

+1656 -2182

3 comments

4 changed files

mariano-formidable

pr closed time in 8 days

delete branch google/web-stories-wp

delete branch : task/apply-916-cooking

delete time in 8 days

issue closedgoogle/web-stories-wp

Templates: Update Cooking template to 9:16

Use this Figma doc to apply 9:16 updates to the existing Cooking template: https://www.figma.com/file/RTzSw47oi6pEZXEfP2JoBo/Templates?node-id=766%3A61

closed time in 8 days

mariano-formidable
IssuesEvent
more