profile
viewpoint
Pascal Birchler swissspidy @Google Zurich, Switzerland https://pascalbirchler.com Developer Programs Engineer @Google. @WordPress Core Committer. Previously @wearerequired.

ampproject/amp-wp 1559

Enable AMP on your WordPress site, the WordPress way.

google/site-kit-wp 882

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.

GoogleChromeLabs/pwa-wp 376

WordPress feature plugin to bring Progressive Web Apps (PWA) to Core

google/web-stories-wp 132

Web Stories WordPress plugin

GoogleChromeLabs/wp-sitemaps 83

Proposal to integrate basic XML Sitemaps in WordPress Core

obenland/shiny-updates 49

Hide the ugly parts of updating WordPress.

GoogleChromeLabs/wp-native-lazyload 45

WordPress plugin to lazy-load media using the native browser feature.

GoogleChromeLabs/wordpressdev 44

WordPress development environment for core, plugins, and themes, based on Lando.

swissspidy/local-webfont 34

Downloads webfont stylesheets and adds font-display properties

swissspidy/gutenberg-i18n-block 32

Gutenberg block to demo internationalization functionality.

IssuesEvent

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 09000ce4f07af0b34277a2a6e76af9952d5e3667

Media: Fix video poster extraction on Firefox and drag/paste on Safari (#2925) * Fix video poster extraction on Firefox * Use alternative approach * Add comments * Fix for currentTime? Co-authored-by: merapi <marcin@webskill.pl>

view details

push time in 2 minutes

delete branch google/web-stories-wp

delete branch : fix/2923-firefox-posters

delete time in 2 minutes

PR merged google/web-stories-wp

Media: Fix video poster extraction on Firefox and drag/paste on Safari Browser Issues Elements: Video Group: Media Type: Bug cla: yes

Summary

Works around a difference in behavior in Firefox.

Relevant Technical Choices

Browsers can fire the canplay event multiple times. We need to ensure that we only listen to it once, and that we do it at the right time (after seeking forward a little bit). Otherwise the first frame is not yet available, and will be simply transparent, or the first frame will be black.

To-do

<!-- A list of things that need to be addressed in this PR or follow-up changes. -->

User-facing changes

<!-- Please describe your changes. -->

Testing Instructions

  1. Upload a video in Firefox/Chrome/Safari/other
  2. Verify that poster is generated successfully in all browsers.

<!-- Please reference the issue(s) this PR addresses. -->

Fixes #2922 Fixes #2923

+30 -10

20 comments

1 changed file

swissspidy

pr closed time in 2 minutes

issue closedgoogle/web-stories-wp

Safari browser - unable to drag/paste video from desktop to canvas

Bug Description

From Slack/doc: Safari browser - unable to drag video from desktop to canvas https://recordit.co/Q2zwiUIoqH

Expected Behaviour

<!-- Please describe clearly and concisely what the expected behaviour should be. -->

Steps to Reproduce

<!-- Please provide detailed steps on how to reproduce the bug. -->

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->

Additional Context

<!-- Please complete the following information. -->

  • Plugin Version:
  • Operating System:
  • Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

<!-- One or more bullet points for acceptance criteria. -->

Implementation Brief

<!-- One or more bullet points for how to technically implement the feature. -->

closed time in 2 minutes

merapi

issue closedgoogle/web-stories-wp

Poster images are black square in Firefox

Bug Description

When a user uploads a video, the generated poster image is a black image.

Expected Behaviour

The poster image is not a black image.

Steps to Reproduce

  • Upload video.
  • Wait for poster to generate.

Screenshots

Screenshot 2020-07-01 at 22 09 27

Additional Context

<!-- Please complete the following information. -->

  • Plugin Version: 1.0.0-beta1
  • Operating System: 10.15.5
  • Browser: 78.0.1

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

<!-- One or more bullet points for acceptance criteria. -->

Implementation Brief

<!-- One or more bullet points for how to technically implement the feature. -->

closed time in 2 minutes

spacedmonkey

delete branch google/web-stories-wp

delete branch : fix/374-fix-storybook-editor-playground

delete time in 20 minutes

PR closed google/web-stories-wp

Mock getStoryById api for editor playground storybook Status: Stale cla: yes

Summary

Mock getStoryById api for editor playground storybook

To-do

WIP


<!-- Please reference the issue(s) this PR addresses. -->

See #374

+112 -1

3 comments

3 changed files

cvolzke4

pr closed time in 20 minutes

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 48b58b5210f3c8b46d328372c70b4d5c68b654c0

Pull out common reducer.js logic to media/common

view details

Clinton Volzke

commit sha f06f691899e742d4e3c8c04278f0cd4a0f3ec7d4

Rename local media 'pagingNum' to 'pageToken' for consistency between media3p and local

view details

Jonny Harris

commit sha 496212a6ba57d084f9f615617bbe4f516898470d

Fix prop types warning for font preview (#2936)

view details

Clinton Volzke

commit sha 368c4c13b5826180b30bd4e19be8359b4272478a

Merge pull request #2827 from google/task/2428-reducer-to-common Pull out common parts of local/reducer.js to media/common/reducer.js

view details

Clinton Volzke

commit sha 84a3c59e1198cc584115e23ba71c9bde02ce2f8d

Merge pull request #2833 from google/task/2828-rename-pagingnum Rename 'pagingNum' -> 'pageToken' for consistency between local / media3p

view details

Evan Mattson

commit sha 489a21d880d5f98430f13f204006329d912a3620

Fix autoloading for Tests namespace (#2958)

view details

Pascal Birchler

commit sha 3977bdf89dbafbc7304e3ca044c1c3ccc1a9e14a

Prevent flakiness for e2e screenshots

view details

dependabot-preview[bot]

commit sha 36ccb0721f0c787880d77a87264cbb51636cdf5b

Bump @storybook/addon-backgrounds from 6.0.0-beta.38 to 6.0.0-beta.39 (#2941) Bumps [@storybook/addon-backgrounds](https://github.com/storybookjs/storybook/tree/HEAD/addons/backgrounds) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/backgrounds) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 84b872a000fba25428626258b7417e9d09e443fe

Bump @storybook/client-api from 6.0.0-beta.38 to 6.0.0-beta.39 (#2943) Bumps [@storybook/client-api](https://github.com/storybookjs/storybook/tree/HEAD/lib/client-api) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/lib/client-api) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Pascal Birchler

commit sha b91a31d8b161fe5180287528d7dab0c889154fd1

Simplify codecov config

view details

dependabot-preview[bot]

commit sha 1891cf0984fd34fa6e8669bb98ba8be0a4aae63c

Bump puppeteer from 4.0.1 to 5.0.0 (#2948) Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 4.0.1 to 5.0.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v4.0.1...v5.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha cee104f7f4d3bd7da696359599135eaea1413269

Bump @storybook/addon-actions from 6.0.0-beta.38 to 6.0.0-beta.39 (#2937)

view details

dependabot-preview[bot]

commit sha 91b7a7e14eedef8f7847f94dfb84323a10755477

Bump @storybook/addon-storysource from 6.0.0-beta.38 to 6.0.0-beta.39 (#2945) Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/storysource) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha ae89870b583208968dd5604e140dd9c5b5a3b7e4

Bump @storybook/addon-docs from 6.0.0-beta.38 to 6.0.0-beta.39 (#2947) Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/docs) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Pascal Birchler

commit sha b58d8ac0ea5d96e5ad0332f20156d03b67b351e6

Jest: runInBand on CI

view details

Pascal Birchler

commit sha c2d87be439dc0225561bb8a6cf09383e00d58c7d

Merge branch 'master' into try/auto-migrate-templates

view details

push time in 20 minutes

pull request commentgoogle/web-stories-wp

Preload API request for dashboard.

Why doesn't ?_envelope not work? See https://developer.wordpress.org/rest-api/using-the-rest-api/global-parameters/#_envelope and https://developer.wordpress.org/reference/classes/wp_rest_server/envelope_response/ for reference.

Also, story_format is super ambiguous. If there is really no way ?_envelope works, I would want to rename this to _web_stories_envelope or something.

spacedmonkey

comment created time in 21 minutes

pull request commentgoogle/web-stories-wp

POC: Use middleware for all MediaProvider actions

@cvolzke4 Can this be closed?

cvolzke4

comment created time in 27 minutes

delete branch google/web-stories-wp

delete branch : try/react-window-vs

delete time in 28 minutes

PR closed google/web-stories-wp

Reviewers
Add virtual list for Media Group: Media Pod: Media I/O Status: Stale Type: Enhancement Type: Performance cla: yes

Summary

WIP on Issue #1302, please consider performance and subjective feelings on how VL works when you comment on this code (no PropTypes check, etc. yet).

Some background: I recently discovered that we have a significant FPS drop when we fetch a new page in the media library - it's connected to contexts/providers read more.

We have three parts in this PR (some of the code will be removed, one solution for fetching will stay):

  1. Fetch more items (500) with our current code (we will deal with contexts/providers later). That way we will encounter the FPS drop less often, but it will take more time to fetch.
  2. Fetch items locally (in VirtualList) then we can have default max (100) items per page. When data is located close to the VL, frame drop is a lot smaller, we just need to refresh the list on file upload (something like forced refresh from react-redux useSelector hook is needed [based on a simple counter, when updated - it will re-render the list]).
  3. VirtualList itself and its performance while scrolling/fast scrolling with scrollbar. I tried many things here, best results can be achieved with Placeholders while scrolling (~60fps). We can try this solution to make UI nicer - so you will see blurred images instead of solid boxes while fast scrolling.

Random thoughts on performance:

  • loading="lazy" will result in less load but images can be loaded too slowly on fast scroll
  • Your impression of responsiveness is largely based on padding/overscan (how many items, in addition, we render outside of the visible window). This can be adjusted.
+503 -109

1 comment

11 changed files

merapi

pr closed time in 28 minutes

pull request commentgoogle/web-stories-wp

Add virtual list for Media

Closing for now.

merapi

comment created time in 28 minutes

pull request commentgoogle/web-stories-wp

POC: Improve render / state update performance when loading media gallery images

@cvolzke4 Can this be closed and the branch deleted?

cvolzke4

comment created time in 29 minutes

issue commentgoogle/web-stories-wp

Not all fonts are loading

Why is that? Is this an issue/limit with the REST API? Something else?

spacedmonkey

comment created time in 30 minutes

pull request commentgoogle/web-stories-wp

Emit warnings for missing JSDoc comments

Ah, you mean the limit of 50 annotations per PR? Yeah that might cause more important messages (errors) to be hidden.

We could skip warnings from being output on GitHub, no big deal. An alternative would be only enabling these warnings for one area of the code base at the time.

Could we generate js docs, in an IDE. Even if they dont have comments? I know phpstorm can generate phpdocs...

Yes and no.

Auto-generated JSDoc annotations are basically like not having any annotations at all. Especially because the IDE can't add type information (because we don't have any types).

Also, JSDoc comments become more useful if they have clear descriptions.

Auto-generated comments can certainly help initially, but all this can only really be done manually.

swissspidy

comment created time in 41 minutes

pull request commentgoogle/web-stories-wp

Emit warnings for missing JSDoc comments

@spacedmonkey Where are there errors? I only see warnings, and yes they are meant to be fixed - slowly, in multiple PRs, until there are zero warnings left.

swissspidy

comment created time in an hour

Pull request review commentgoogle/web-stories-wp

Load google fonts in a cleaner way.

+<?php+/**+ * Trait Google Fonts+ *+ * @package   Google\Web_Stories\Traits+ * @copyright 2020 Google LLC+ * @license   https://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0+ * @link      https://github.com/google/web-stories-wp+ */++/**+ * Copyright 2020 Google LLC+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *     https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++namespace Google\Web_Stories\Traits;++/**+ * Trait Types+ *+ * @package Google\Web_Stories\Traits+ */+trait Google_Fonts {+	/**+	 * Register font in WordPress.+	 *+	 * @param string $font Name of font.+	 */+	public function register_google_font( $font ) {+		wp_register_style(+			$this->get_font_slug( $font ),+			sprintf( 'https://fonts.googleapis.com/css2?family=%s:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap', $font ),+			[],+			WEBSTORIES_VERSION+		);+	}++	/**+	 * Get font slug.+	 *+	 * @param string $font Font name.+	 *+	 * @return string Slug of font.+	 */+	public function get_font_slug( $font ) {+		return sanitize_title( $font ) . '-google-font';

We might wanna prefix that with web-stories.

Otherwise, if another plugin already registers that font but with a different configuration, this would lead to unexpected behavior.

spacedmonkey

comment created time in an hour

Pull request review commentgoogle/web-stories-wp

Load google fonts in a cleaner way.

+<?php+/**+ * Trait Google Fonts+ *+ * @package   Google\Web_Stories\Traits+ * @copyright 2020 Google LLC+ * @license   https://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0+ * @link      https://github.com/google/web-stories-wp+ */++/**+ * Copyright 2020 Google LLC+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *     https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++namespace Google\Web_Stories\Traits;++/**+ * Trait Types+ *+ * @package Google\Web_Stories\Traits+ */+trait Google_Fonts {+	/**+	 * Register font in WordPress.+	 *+	 * @param string $font Name of font.+	 */+	public function register_google_font( $font ) {+		wp_register_style(+			$this->get_font_slug( $font ),+			sprintf( 'https://fonts.googleapis.com/css2?family=%s:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap', $font ),+			[],+			WEBSTORIES_VERSION+		);+	}++	/**+	 * Get font slug.+	 *+	 * @param string $font Font name.+	 *+	 * @return string Slug of font.+	 */+	public function get_font_slug( $font ) {

A separate method for this is overkill IMHO

spacedmonkey

comment created time in an hour

Pull request review commentgoogle/web-stories-wp

Load google fonts in a cleaner way.

+<?php+/**+ * Trait Google Fonts+ *+ * @package   Google\Web_Stories\Traits+ * @copyright 2020 Google LLC+ * @license   https://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0+ * @link      https://github.com/google/web-stories-wp+ */++/**+ * Copyright 2020 Google LLC+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *     https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++namespace Google\Web_Stories\Traits;++/**+ * Trait Types+ *+ * @package Google\Web_Stories\Traits+ */+trait Google_Fonts {+	/**+	 * Register font in WordPress.+	 *+	 * @param string $font Name of font.+	 */+	public function register_google_font( $font ) {+		wp_register_style(+			$this->get_font_slug( $font ),+			sprintf( 'https://fonts.googleapis.com/css2?family=%s:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap', $font ),

We don't need all font variants on every screen. For example, on the plugin activation notice we probably only need 0,400 - loading everything is unnecessary and bloats things up.

spacedmonkey

comment created time in an hour

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha b58d8ac0ea5d96e5ad0332f20156d03b67b351e6

Jest: runInBand on CI

view details

push time in an hour

PR merged google/web-stories-wp

Reviewers
Bump @storybook/addon-docs from 6.0.0-beta.38 to 6.0.0-beta.39 Dependencies JavaScript cla: yes

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps @storybook/addon-docs from 6.0.0-beta.38 to 6.0.0-beta.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/addon-docs's releases</a>.</em></p> <blockquote> <h2>v6.0.0-beta.39</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/addon-docs's changelog</a>.</em></p> <blockquote> <h2>6.0.0-beta.39 (July 2, 2020)</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ca9e1affe9852f3b2614046f60bf820c61927f28"><code>ca9e1af</code></a> v6.0.0-beta.39</li> <li><a href="https://github.com/storybookjs/storybook/commit/2766dea1066b5a800148e7118668f3d460ef32d9"><code>2766dea</code></a> Args: Rename <code>globalArgs</code> to <code>globals</code></li> <li><a href="https://github.com/storybookjs/storybook/commit/052836099e3d14d0f25eb41a49a6c228ecec6e7e"><code>0528360</code></a> CSF: Forbid duplicate kinds</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/docs">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @swissspidy.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+144 -625

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in an hour

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha ae89870b583208968dd5604e140dd9c5b5a3b7e4

Bump @storybook/addon-docs from 6.0.0-beta.38 to 6.0.0-beta.39 (#2947) Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/docs) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in an hour

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/storybook/addon-docs-6.0.0-beta.39

delete time in an hour

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 91b7a7e14eedef8f7847f94dfb84323a10755477

Bump @storybook/addon-storysource from 6.0.0-beta.38 to 6.0.0-beta.39 (#2945) Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/storysource) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in an hour

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/storybook/addon-storysource-6.0.0-beta.39

delete time in an hour

PR merged google/web-stories-wp

Reviewers
Bump @storybook/addon-storysource from 6.0.0-beta.38 to 6.0.0-beta.39 Dependencies JavaScript cla: yes

Bumps @storybook/addon-storysource from 6.0.0-beta.38 to 6.0.0-beta.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/addon-storysource's releases</a>.</em></p> <blockquote> <h2>v6.0.0-beta.39</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/addon-storysource's changelog</a>.</em></p> <blockquote> <h2>6.0.0-beta.39 (July 2, 2020)</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ca9e1affe9852f3b2614046f60bf820c61927f28"><code>ca9e1af</code></a> v6.0.0-beta.39</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/storysource">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+21 -148

4 comments

2 changed files

dependabot-preview[bot]

pr closed time in an hour

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 1891cf0984fd34fa6e8669bb98ba8be0a4aae63c

Bump puppeteer from 4.0.1 to 5.0.0 (#2948) Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 4.0.1 to 5.0.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v4.0.1...v5.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 2 hours

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/puppeteer-5.0.0

delete time in 2 hours

PR merged google/web-stories-wp

Reviewers
Bump puppeteer from 4.0.1 to 5.0.0 Dependencies JavaScript cla: yes

Bumps puppeteer from 4.0.1 to 5.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/puppeteer/puppeteer/releases">puppeteer's releases</a>.</em></p> <blockquote> <h2>v5.0.0</h2> <h2>Breaking changes</h2> <h3>Removal of <code>page.emulateMedia</code> (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6084">#6084</a>)</h3> <p>This method was deprecated and is now removed from Puppeteer. Swap to <code>page.emulateMediaType</code> which behaves identically.</p> <h3>Removal of <code>require('puppeteer/DeviceDescriptors')</code> (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6043">#6043</a>)</h3> <p>This top level file has been removed from the Puppeteer package. The same data is exposed via <code>puppeteer.devices</code>, so swap to that:</p> <pre lang="js"><code>// before const devices = require('puppeteer/DeviceDescriptors'); <p>// after const puppeteer = require('puppeteer'); const devices = puppeteer.devices </code></pre></p> <h3>Removal of <code>require('puppeteer/Errors')</code> (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6043">#6043</a>)</h3> <p>This top level file has been removed from the Puppeteer package. The same data is exposed via <code>puppeteer.errors</code>, so swap to that:</p> <pre lang="js"><code>// before const errors = require('puppeteer/Errors'); <p>// after const puppeteer = require('puppeteer'); const errors = puppeteer.errors </code></pre></p> <h2>Behind the scenes</h2> <ul> <li> <p>We've continued our drive to migrate to a new documentation system using TSDoc. These docs are available in the <a href="https://github.com/puppeteer/puppeteer/blob/main/new-docs/puppeteer.md"><code>new-docs</code></a> directory on GitHub. These aren't ready for use just yet but we're making great progress. You can track this work in <a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6118">#6118</a>.</p> </li> <li> <p>We've continued improving our TypeScript definitions. Our tests are now migrated to TypeScript (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/5830">#5830</a>) so that we're consuming our own API. Work continues to ship built-in type definitions in a future version. You can track this work in <a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6124">#6124</a>.</p> </li> <li> <p>We've started restructuring Puppeteer to work towards being able to better support an environment agnostic Puppeteer module. You can track this work in <a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6125">#6125</a>.</p> </li> </ul> <h2>Raw notes</h2> <p>85d8dbf - chore: mark v5.0.0 29f7e16 - chore(docs): reduce warnings when generating docs (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6138">#6138</a>) 221d172 - chore: add typecheck command (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6140">#6140</a>) 6474edb - feat(types): add types for <code>$eval</code> (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6135">#6135</a>) 8370ec8 - feat(types): add (and fix) <code>evaluateHandle</code> types (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6130">#6130</a>) 3c0dc45 - chore: update Windows skipped tests. (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6133">#6133</a>)</p> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/puppeteer/puppeteer/commit/6d06adea10572d2667a9d1c5a48193903860341b"><code>6d06ade</code></a> chore: mark v5.0.0 (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6143">#6143</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/29f7e161b1838d2399556cba65fcd161579bfa67"><code>29f7e16</code></a> chore(docs): reduce warnings when generating docs (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6138">#6138</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/221d1728430b8678319d071cb468b1cd49b12b9c"><code>221d172</code></a> chore: add typecheck command (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6140">#6140</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/6474edb9ba5ab6637361198b574dc64529eef26b"><code>6474edb</code></a> feat(types): add types for <code>$eval</code> (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6135">#6135</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/8370ec88ae94fa59d9e9dc0c154e48527d48c9fe"><code>8370ec8</code></a> feat(types): add (and fix) <code>evaluateHandle</code> types (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6130">#6130</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/3c0dc45e477bbd914ce698d1e681b05fc29f85ec"><code>3c0dc45</code></a> chore: update Windows skipped tests. (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6133">#6133</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/9f198626f8a02e53b629739cc14b4f15fe2dcd23"><code>9f19862</code></a> chore(docs): mark JSHandle properties as internal (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6126">#6126</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/8026ca951461a7de97139285da9c0c58fbeb0860"><code>8026ca9</code></a> docs(api): fix overview diagram for pptr.dev (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6128">#6128</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/9d79cc89cb39df675484602e91c7178a18a6456e"><code>9d79cc8</code></a> chore: fix Firefox install checker (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6129">#6129</a>)</li> <li><a href="https://github.com/puppeteer/puppeteer/commit/1f5e333f0059bf3f7d9bba7e5376ebddff591c41"><code>1f5e333</code></a> chore: Don't store revisions in <code>package.json</code> (<a href="https://github-redirect.dependabot.com/puppeteer/puppeteer/issues/6109">#6109</a>)</li> <li>Additional commits viewable in <a href="https://github.com/puppeteer/puppeteer/compare/v4.0.1...v5.0.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @swissspidy.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+5 -4

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in 2 hours

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha b91a31d8b161fe5180287528d7dab0c889154fd1

Simplify codecov config

view details

push time in 2 hours

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 84b872a000fba25428626258b7417e9d09e443fe

Bump @storybook/client-api from 6.0.0-beta.38 to 6.0.0-beta.39 (#2943) Bumps [@storybook/client-api](https://github.com/storybookjs/storybook/tree/HEAD/lib/client-api) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/lib/client-api) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 2 hours

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/storybook/client-api-6.0.0-beta.39

delete time in 2 hours

PR merged google/web-stories-wp

Reviewers
Bump @storybook/client-api from 6.0.0-beta.38 to 6.0.0-beta.39 Dependencies JavaScript cla: yes

Bumps @storybook/client-api from 6.0.0-beta.38 to 6.0.0-beta.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/client-api's releases</a>.</em></p> <blockquote> <h2>v6.0.0-beta.39</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/client-api's changelog</a>.</em></p> <blockquote> <h2>6.0.0-beta.39 (July 2, 2020)</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ca9e1affe9852f3b2614046f60bf820c61927f28"><code>ca9e1af</code></a> v6.0.0-beta.39</li> <li><a href="https://github.com/storybookjs/storybook/commit/2766dea1066b5a800148e7118668f3d460ef32d9"><code>2766dea</code></a> Args: Rename <code>globalArgs</code> to <code>globals</code></li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/lib/client-api">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @swissspidy.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+87 -140

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in 2 hours

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 36ccb0721f0c787880d77a87264cbb51636cdf5b

Bump @storybook/addon-backgrounds from 6.0.0-beta.38 to 6.0.0-beta.39 (#2941) Bumps [@storybook/addon-backgrounds](https://github.com/storybookjs/storybook/tree/HEAD/addons/backgrounds) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/backgrounds) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 2 hours

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/storybook/addon-backgrounds-6.0.0-beta.39

delete time in 2 hours

PR merged google/web-stories-wp

Reviewers
Bump @storybook/addon-backgrounds from 6.0.0-beta.38 to 6.0.0-beta.39 Dependencies JavaScript cla: yes

Bumps @storybook/addon-backgrounds from 6.0.0-beta.38 to 6.0.0-beta.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/addon-backgrounds's releases</a>.</em></p> <blockquote> <h2>v6.0.0-beta.39</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/addon-backgrounds's changelog</a>.</em></p> <blockquote> <h2>6.0.0-beta.39 (July 2, 2020)</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ca9e1affe9852f3b2614046f60bf820c61927f28"><code>ca9e1af</code></a> v6.0.0-beta.39</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/backgrounds">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @swissspidy.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+13 -167

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in 2 hours

created tagGoogleChromeLabs/wp-sitemaps

tagv0.4.2

Proposal to integrate basic XML Sitemaps in WordPress Core

created time in 2 hours

push eventGoogleChromeLabs/wp-sitemaps

Pascal Birchler

commit sha c8c36818811fd7e2d339b86ddded08f532a075e4

Update readme and filter name after core merge (#218)

view details

push time in 2 hours

delete branch GoogleChromeLabs/wp-sitemaps

delete branch : update/readme

delete time in 2 hours

PR merged GoogleChromeLabs/wp-sitemaps

Reviewers
Update readme and filter name after core merge cla: yes

Fixes #216

+29 -21

0 comment

5 changed files

swissspidy

pr closed time in 2 hours

issue closedGoogleChromeLabs/wp-sitemaps

Plugin updates after core merge

  • [ ] Fix wp_sitemaps_enabled filter name
  • [ ] Add note to readme
  • [ ] Fix code samples in readme

closed time in 2 hours

swissspidy

push eventGoogleChromeLabs/wp-sitemaps

dependabot-preview[bot]

commit sha a3b6f3ec40bf8520a800bc240884237b7206ba00

Bump wp-phpunit/wp-phpunit from 5.4.1 to 5.4.2 (#212) Bumps [wp-phpunit/wp-phpunit](https://github.com/wp-phpunit/wp-phpunit) from 5.4.1 to 5.4.2. - [Release notes](https://github.com/wp-phpunit/wp-phpunit/releases) - [Commits](https://github.com/wp-phpunit/wp-phpunit/compare/5.4.1...5.4.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 3 hours

delete branch GoogleChromeLabs/wp-sitemaps

delete branch : dependabot/composer/wp-phpunit/wp-phpunit-5.4.2

delete time in 3 hours

PR merged GoogleChromeLabs/wp-sitemaps

Bump wp-phpunit/wp-phpunit from 5.4.1 to 5.4.2 cla: yes dependencies php

Bumps wp-phpunit/wp-phpunit from 5.4.1 to 5.4.2. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/wp-phpunit/wp-phpunit/compare/5.4.1...5.4.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+22 -15

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 3 hours

pull request commentgoogle/web-stories-wp

Add foundation for plugin activation notice

@spacedmonkey Thanks for the offer! Feel free to go ahead :) Let's leave the Roboto part for a separate PR though. Needs some bigger rework.

swissspidy

comment created time in 4 hours

Pull request review commentgoogle/web-stories-wp

Add foundation for plugin activation notice

 public function register() { 		$this->discovery = new Discovery(); 		add_action( 'init', [ $this->discovery, 'init' ] ); +		// Register activation flag logic outside of 'init' since it hooks into+		// plugin activation.+		$activation_flag = new Activation_Flag();+		$activation_flag->register();++		$activation_notice = new Activation_Notice( $activation_flag );+		$activation_notice->register();

There's a comment above that explains why they should not :)

swissspidy

comment created time in 4 hours

Pull request review commentgoogle/web-stories-wp

Add foundation for plugin activation notice

+<?php+/**+ * Class Activation_Notice.+ *+ * @package   Google\Web_Stories+ * @copyright 2020 Google LLC+ * @license   https://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0+ * @link      https://github.com/google/web-stories-wp+ */++/**+ * Copyright 2020 Google LLC+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *     https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++namespace Google\Web_Stories;++use Google\Web_Stories\Traits\Assets;++/**+ * Class Activation_Notice.+ */+class Activation_Notice {+	/**+	 * Script handle.+	 *+	 * @var string+	 */+	const SCRIPT_HANDLE = 'web-stories-activation-notice';++	use Assets;++	/**+	 * Activation flag instance.+	 *+	 * @var Activation_Flag+	 */+	protected $activation_flag;++	/**+	 * Constructor.+	 *+	 * @param Activation_Flag $activation_flag Activation flag instance.+	 */+	public function __construct(+		Activation_Flag $activation_flag+	) {+		$this->activation_flag = $activation_flag;+	}++	/**+	 * Initializes the plugin activation notice.+	 *+	 * @return void+	 */+	public function register() {+		add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_assets' ] );+		add_action( 'admin_notices', [ $this, 'render_notice' ] );+		add_action( 'network_admin_notices', [ $this, 'render_notice' ] );+	}++	/**+	 * Enqueues assets for the plugin activation notice.+	 *+	 * @param string $hook_suffix The current admin page.+	 * @return void+	 */+	public function enqueue_assets( $hook_suffix ) {+		if ( 'plugins.php' !== $hook_suffix || ! $this->activation_flag->get_activation_flag( is_network_admin() ) ) {+			return;+		}++		/**+		 * Prevent the default WordPress "Plugin Activated" notice from rendering.+		 *+		 * @link https://github.com/WordPress/WordPress/blob/e1996633228749cdc2d92bc04cc535d45367bfa4/wp-admin/plugins.php#L569-L570+		 */+		unset( $_GET['activate'] ); // phpcs:ignore WordPress.Security.NonceVerification, WordPress.VIP.SuperGlobalInputUsage++		wp_enqueue_style(

Great point. I think we really need to take a hard look at this.

We need different Roboto font weights and styles for each case, so it would probably be better to name them differently & keep them separate, instead of registering it globally.

This way, we make sure we only load the CSS we absolutely need for each screen.

swissspidy

comment created time in 4 hours

Pull request review commentgoogle/web-stories-wp

Add foundation for plugin activation notice

+<?php+/**+ * Class Activation_Flag.+ *+ * @package   Google\Web_Stories+ * @copyright 2020 Google LLC+ * @license   https://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0+ * @link      https://github.com/google/web-stories-wp+ */++/**+ * Copyright 2020 Google LLC+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *     https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++namespace Google\Web_Stories;++/**+ * Class Activation_Flag.+ */+class Activation_Flag {+	const OPTION_SHOW_ACTIVATION_NOTICE = 'web_stories_show_activation_notice';++	/**+	 * Registers functionality through WordPress hooks.+	 *+	 * @return void+	 */+	public function register() {+		add_action(+			'web_stories_activation',+			[ $this, 'set_activation_flag' ]+		);++	}++	/**+	 * Sets the flag that the plugin has just been activated.+	 *+	 * @param bool $network_wide Whether the plugin is being activated network-wide.+	 * @return void+	 */+	public function set_activation_flag( $network_wide ) {+		if ( $network_wide ) {+			update_network_option( null, self::OPTION_SHOW_ACTIVATION_NOTICE, '1' );
			update_site_option( self::OPTION_SHOW_ACTIVATION_NOTICE, '1' );
swissspidy

comment created time in 4 hours

push eventGoogleChromeLabs/wp-sitemaps

Pascal Birchler

commit sha 0aa235e624bb09808ebac588c5958cdf1b582a39

Bump version to 0.4.2

view details

push time in 4 hours

issue closedGoogleChromeLabs/wp-sitemaps

Road towards WordPress Core

This thread aims to cover things needed to pave the way for an eventual merge proposal into WordPress core.

Sub-issues will be created as-needed.

The tasks are more or less in desired chronological order:

  • [x] Release version 0.3.0. Including these PRs:
    • [x] #138 - Private sites
    • [x] #150 - Improving rewrite rules
  • [x] Land other outstanding PRS, perhaps for a 0.4.0 release. At the moment there are:
    • [x] #163 - Smarter stylesheet
    • [x] #124 - Test coverage for filters
  • [x] Get issue count to zero.
  • [x] Update all inline documentation to adhere to WordPress coding standards: #173
  • [x] Refactor code base
    • [x] Use core conventions around object type / object subtype names and docs: #174
    • [x] Drop core_sitemaps prefix in functions, hooks, and class file names (In progress).
    • [x] Bail early in core-sitemaps.php if functionality is already built into core (e.g. if functions already exist). (in progress)
  • [ ] Get audit from WordPress security team
  • [x] Cover everything under https://make.wordpress.org/core/handbook/about/release-cycle/features-as-plugins/
  • [x] Create ticket on WordPress Trac - Complete: https://core.trac.wordpress.org/ticket/50117
  • [x] Create pull request towards https://github.com/WordPress/wordpress-develop/ with the sitemaps code & tests
  • [x] Write merge proposal post

closed time in 4 hours

swissspidy

push eventGoogleChromeLabs/wp-sitemaps

Pascal Birchler

commit sha 680c20071267d33f147f3c66324115d726de64db

Apply same changes to GitHub readme

view details

push time in 4 hours

create barnchGoogleChromeLabs/wp-sitemaps

branch : update/readme

created branch time in 4 hours

Pull request review commentgoogle/web-stories-wp

Warn if running plugin from source

 function deactivate( $network_wide ) { register_activation_hook( WEBSTORIES_PLUGIN_FILE, '\Google\Web_Stories\activate' ); register_deactivation_hook( WEBSTORIES_PLUGIN_FILE, '\Google\Web_Stories\deactivate' ); +if (+	! class_exists( '\Google\Web_Stories\Plugin' ) ||+	! file_exists( WEBSTORIES_PLUGIN_DIR_PATH . '/assets/js/edit-story.js' )+) {+	add_action(+		'admin_notices',+		static function () {+			?>+			<div class="notice notice-error">+				<p>+					<strong><?php esc_html_e( 'Web Stories plugin could not be initialized.', 'web-stories' ); ?></strong>+				</p>+				<p>+					<?php+					printf(+						/* translators: %s: build commands. */+						__( 'You appear to be running an incomplete version of the plugin. Please run %s to finish installation.', 'web-stories' ), // phpcs:ignore WordPress.Security.EscapeOutput+						'<code>composer install &amp;&amp; npm install &amp;&amp; npm run build</code>'+					)+					?>+				</p>+			</div>+			<?php+		}+	);++	return;

Need to skip this for tests, because assets/js/edit-story.js does not exist there.

swissspidy

comment created time in 5 hours

PR opened google/web-stories-wp

Reviewers
Warn if running plugin from source Group: WordPress Pod: WP & Infra Type: Enhancement

Summary

Warn users if they forgot to run the build commands.

Helpful if someone just downloads the current master branch as a ZIP file and expects the plugin to "just work".

Relevant Technical Choices

Uses an anonymous function because this cannot really be covered by unit tests and this shouldn't be disabled by others.

To-do

<!-- A list of things that need to be addressed in this PR or follow-up changes. -->

User-facing changes

Screenshot 2020-07-03 at 13 23 19

Testing Instructions

Download the master branch and try to install the plugin on a fresh install, or simply remove the vendor folder to force the admin notice from appearing.


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #1234 See #2961

+29 -0

0 comment

1 changed file

pr created time in 5 hours

create barnchgoogle/web-stories-wp

branch : add/run-from-source-warning

created branch time in 5 hours

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 30af52af93747c714372688a01b6307a59e6c661

Fix JSDoc for createResource

view details

push time in 5 hours

issue commentgoogle/web-stories-wp

Fatal Error

Hi @BagthariyaSumit,

Thanks for your report!

If you download the plugin straight from GitHub, you will only get the source files, not the final build that includes all JavaScript and PHP files to run the editor. That's why you get the error about classes not being found.

To prevent this, please download the ready-to-use version from from https://google.github.io/web-stories-wp/beta/

If you want to install the latest master version instead, follow our Getting Started guide for contributors.

In the meantime, we'll work on making the message a bit clearer for cases like yours. You can follow progress on that in #1234

BagthariyaSumit

comment created time in 5 hours

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 3977bdf89dbafbc7304e3ca044c1c3ccc1a9e14a

Prevent flakiness for e2e screenshots

view details

push time in 5 hours

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 7a222802167f967899d12b6f897a1255e9d8a430

Don’t require jsdoc in test files

view details

Pascal Birchler

commit sha 4d4b1ea9c1d6029fbe5ffa39e4a8ee5081d12b94

Fix jsdoc for testIsKeyPressed

view details

push time in 7 hours

PR opened google/web-stories-wp

Reviewers
Emit warnings for missing JSDoc comments Pod: WP & Infra Skip Changelog Type: Infrastructure

Summary

EmitS warnings for missing JSDoc comments

Relevant Technical Choices

  • Makes eslint-plugin-jsdoc usage explicit
    Before it was implicit via the WordPress ESLint plugin
  • Improve jsdoc in tests folder for demonstration purposes
  • Uses TypeScript mode for JSDoc comments
    This makes it easier to eventually adopt TypeScript (#1715)

To-do

<!-- A list of things that need to be addressed in this PR or follow-up changes. -->

User-facing changes

N/A

Testing Instructions

Run linter


<!-- Please reference the issue(s) this PR addresses. -->

See #1714

+145 -31

0 comment

9 changed files

pr created time in 7 hours

create barnchgoogle/web-stories-wp

branch : add/jsdoc-eslint-config

created branch time in 7 hours

Pull request review commentgoogle/web-stories-wp

Make dev env LAN access easier

 set -e WP_DEBUG=${WP_DEBUG-true} SCRIPT_DEBUG=${SCRIPT_DEBUG-true} WP_VERSION=${WP_VERSION-"latest"}+HOST=${HOST-"localhost"}

Yes, those are env vars. HOST (vs. WP_HOST) might be a bit ambiguous, but if it works, it works 👍

merapi

comment created time in 8 hours

push eventgoogle/web-stories-wp

Evan Mattson

commit sha 489a21d880d5f98430f13f204006329d912a3620

Fix autoloading for Tests namespace (#2958)

view details

push time in 8 hours

PR merged google/web-stories-wp

Reviewers
Fix autoloading for Tests namespace Pod: WP & Infra Type: Code Quality cla: yes

Summary

This PR updates the PSR-4 autoloading path for the Google\Web_Stories\Tests namespace which was previously configured to autoload the tests directory. This is unnecessary as PHPUnit handles the loading of test cases automatically, so autoloading for this namespace should be configured to target the includes directory as the starting point for this namespace.

Relevant Technical Choices

  • Removed manual loading of Private_Access trait in bootstrap.php which is now handled by the autoloader.

To-do

  • N/A

User-facing changes

  • N/A

Testing Instructions

  • Run npm run test:php as usual 😄

<!-- Please reference the issue(s) this PR addresses. -->

Fixes #

+1 -5

1 comment

2 changed files

aaemnnosttv

pr closed time in 8 hours

issue commentgoogle/web-stories-wp

Unable to load stories toast error shows even when I have stories

@jasonbahl While we‘re working on a potential fix in #2952, could you perhaps give this ZIP with the applied change a try? https://github.com/google/web-stories-wp/suites/870754629/artifacts/10121126

jasonbahl

comment created time in 18 hours

issue commentgoogle/web-stories-wp

Modifying Publish Date - Not Appearing In Dashboard

Note that I created #2951 for the behavior I reported above: scheduled stories are not visible in the dashboard at all.

csossi

comment created time in 19 hours

issue openedgoogle/web-stories-wp

Dashboard not listing scheduled stories

Bug Description

Splitting this out from #2823:

If you save a story to be published in the future, it won't be listed anywhere in the dashboard. You can see it in the "All Stories" view though.

Expected Behaviour

The dashboard should list scheduled stories. They have the post status future.

Steps to Reproduce

  1. Create new story
  2. Set publish date to be in the future
  3. Save story
  4. Visit Dashboard

Screenshots

<!-- If applicable, please add screenshots to help explain your problem. Bonus points for videos! -->

Additional Context

<!-- Please complete the following information. -->

  • Plugin Version: 1.0.0-beta.1
  • Operating System:
  • Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

<!-- One or more bullet points for acceptance criteria. -->

Implementation Brief

<!-- One or more bullet points for how to technically implement the feature. -->

created time in 19 hours

issue commentgoogle/web-stories-wp

Unable to load stories toast error shows even when I have stories

Hey Jason,

thanks a lot for your super thorough report and kind words!

We'll look into it as soon as possible. While I cannot reproduce it myself right now, preventing things like page=NaN should hopefully bee an easy thing to address.


Really like how ya'll are using Gutenberg components to create a familiar but unique editing experience

Besides some packages like @wordpress/api-fetch we actually don't use any Gutenberg components or the like - it's all custom :-) We'll definitely share more about the how & why in the future.

jasonbahl

comment created time in 19 hours

Pull request review commentgoogle/web-stories-wp

[WIP] Fixing a number of a11y problems with design panel components

 function DropDown({  DropDown.propTypes = {   value: PropTypes.any.isRequired,-  options: PropTypes.array.isRequired,   onChange: PropTypes.func.isRequired,+  options: PropTypes.array,   disabled: PropTypes.bool,   lightMode: PropTypes.bool,   placeholder: PropTypes.string,   labelledBy: PropTypes.string, }; -DropDown.defaultProps = {

What's the reason for not using defaultProps anymore?

barklund

comment created time in 19 hours

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha e88170aadb0a38bcf4a9f316363f15459cc10858

Run rollup before unit tests

view details

push time in 20 hours

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 4951085626fd0ff514c80622f95a0c853a61f735

Try smaller video

view details

push time in 20 hours

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 52af915f34550495516f79f49695c907ef73336d

Bump @storybook/addon-knobs from 6.0.0-beta.38 to 6.0.0-beta.39 (#2938) Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/knobs) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 259d1385d6e97140c8dd38a36611db0a89aaae9c

Bump @storybook/react from 6.0.0-beta.38 to 6.0.0-beta.39 (#2942) Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/app/react) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/app/react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha ffb5737a847997b6fefd726422e3898ff0aeffbc

Bump @storybook/addon-a11y from 6.0.0-beta.38 to 6.0.0-beta.39 (#2944) Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/a11y) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha afd833d832f3cfbed5953df1c7d85f5b443f8107

Bump @storybook/addon-viewport from 6.0.0-beta.38 to 6.0.0-beta.39 (#2939)

view details

dependabot-preview[bot]

commit sha 9214f6dbc3392abec4542d5392bc1b5dbf089fde

Bump @storybook/client-logger from 6.0.0-beta.38 to 6.0.0-beta.39 (#2940)

view details

Pascal Birchler

commit sha ace0c8fe5cf6d639409bf9d93cbdc4aee7906533

Merge branch 'master' into try/auto-migrate-templates

view details

push time in 20 hours

push eventgoogle/web-stories-wp

Jonny Harris

commit sha 496212a6ba57d084f9f615617bbe4f516898470d

Fix prop types warning for font preview (#2936)

view details

push time in 20 hours

delete branch google/web-stories-wp

delete branch : fix/console-warning-1

delete time in 20 hours

PR merged google/web-stories-wp

Fix prop types warning for font preview Skip Changelog Type: Code Quality cla: yes

Summary

Fixes console error. The present example element do not have type, id etc. Just use textContent prop type.

Relevant Technical Choices

<!-- Please describe your changes. -->

To-do

<!-- A list of things that need to be addressed in this PR or follow-up changes. -->

User-facing changes

<!-- Please describe your changes. -->

Testing Instructions

<!-- How can the changes in this PR be verified? Relevant for QA and user acceptance testing. -->


<!-- Please reference the issue(s) this PR addresses. -->

Fixes #2934

+1 -1

2 comments

1 changed file

spacedmonkey

pr closed time in 20 hours

issue closedgoogle/web-stories-wp

Prop types warning on load

Bug Description

When a user open the browser and opens console. A warning is displayed.

Expected Behaviour

No console errors are displayed.

Steps to Reproduce

<!-- Please provide detailed steps on how to reproduce the bug. -->

Screenshots

checkPropTypes.js:20 Warning: Failed prop type: The prop `element.id` is marked as required in `FontPreview`, but its value is `undefined`.
    in FontPreview (at textPane.js:66)
    in TextPane (at libraryPanes.js:31)
    in LibraryPanes (at libraryLayout.js:67)
    in div (created by libraryLayout__LibraryBackground)
    in libraryLayout__LibraryBackground (at libraryLayout.js:66)
    in section (created by libraryLayout__Layout)
    in libraryLayout__Layout (at libraryLayout.js:62)
    in LibraryLayout (at library.js:28)
    in div (created by dropTarget__Content)
    in dropTarget__Content (at dropTarget.js:112)
    in Unknown (at dropTarget.js:111)
    in div (created by dropTarget__DropTargetComponent)
    in dropTarget__DropTargetComponent (at dropTarget.js:96)
    in UploadDropTarget (at libraryUploadDropTarget.js:47)
    in LibraryUploadDropTarget (at library.js:27)
    in Unknown (at libraryProvider.js:75)
    in LibraryProvider (at library.js:26)
    in Library (at layout/index.js:70)
    in div (created by layout__Area)
    in layout__Area (at layout/index.js:69)
    in section (created by layout__Editor)
    in layout__Editor (at layout/index.js:68)
    in Layout (at app/index.js:71)
    in Unknown (at provider.js:215)
    in DropTargetsProvider (at app/index.js:64)
    in Unknown (at transformProvider.js:80)
    in TransformProvider (at app/index.js:63)
    in Unknown (at mediaProvider.js:37)
    in MediaProvider (at app/index.js:61)
    in Unknown (at fontProvider.js:139)
    in FontProvider (at app/index.js:60)
    in Unknown (at storyProvider.js:136)
    in StoryProvider (at app/index.js:59)
    in Unknown (at snackbarProvider.js:68)
    in SnackbarProvider (at app/index.js:58)
    in Unknown (at historyProvider.js:82)
    in HistoryProvider (at app/index.js:57)
    in Unknown (at apiProvider.js:244)
    in APIProvider (at app/index.js:56)
    in Unknown (at configProvider.js:28)
    in ConfigProvider (at app/index.js:55)
    in ErrorBoundary (at app/index.js:54)
    in ThemeProvider (at app/index.js:53)
    in StyleSheetManager (at app/index.js:52)
    in App (at edit-story/index.js:44)
    in FlagsProvider (at edit-story/index.js:43)

Additional Context

<!-- Please complete the following information. -->

  • Plugin Version:
  • Operating System:
  • Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

<!-- One or more bullet points for acceptance criteria. -->

Implementation Brief

<!-- One or more bullet points for how to technically implement the feature. -->

closed time in 20 hours

spacedmonkey

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 93bb2213698f902934bc34c2ed052cfc2cb309f9

Run rollup before lint check

view details

push time in 20 hours

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/storybook/addon-a11y-6.0.0-beta.39

delete time in a day

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha ffb5737a847997b6fefd726422e3898ff0aeffbc

Bump @storybook/addon-a11y from 6.0.0-beta.38 to 6.0.0-beta.39 (#2944) Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/a11y) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in a day

PR merged google/web-stories-wp

Reviewers
Bump @storybook/addon-a11y from 6.0.0-beta.38 to 6.0.0-beta.39 Dependencies JavaScript cla: yes

Bumps @storybook/addon-a11y from 6.0.0-beta.38 to 6.0.0-beta.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/addon-a11y's releases</a>.</em></p> <blockquote> <h2>v6.0.0-beta.39</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/addon-a11y's changelog</a>.</em></p> <blockquote> <h2>6.0.0-beta.39 (July 2, 2020)</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ca9e1affe9852f3b2614046f60bf820c61927f28"><code>ca9e1af</code></a> v6.0.0-beta.39</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/a11y">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @swissspidy.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+99 -277

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in a day

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 259d1385d6e97140c8dd38a36611db0a89aaae9c

Bump @storybook/react from 6.0.0-beta.38 to 6.0.0-beta.39 (#2942) Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/app/react) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/app/react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in a day

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/storybook/react-6.0.0-beta.39

delete time in a day

PR merged google/web-stories-wp

Reviewers
Bump @storybook/react from 6.0.0-beta.38 to 6.0.0-beta.39 Dependencies JavaScript cla: yes

Bumps @storybook/react from 6.0.0-beta.38 to 6.0.0-beta.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/react's releases</a>.</em></p> <blockquote> <h2>v6.0.0-beta.39</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/react's changelog</a>.</em></p> <blockquote> <h2>6.0.0-beta.39 (July 2, 2020)</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ca9e1affe9852f3b2614046f60bf820c61927f28"><code>ca9e1af</code></a> v6.0.0-beta.39</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/app/react">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @swissspidy.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+113 -305

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in a day

push eventgoogle/web-stories-wp

dependabot-preview[bot]

commit sha 52af915f34550495516f79f49695c907ef73336d

Bump @storybook/addon-knobs from 6.0.0-beta.38 to 6.0.0-beta.39 (#2938) Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.0.0-beta.38 to 6.0.0-beta.39. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/knobs) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in a day

delete branch google/web-stories-wp

delete branch : dependabot/npm_and_yarn/storybook/addon-knobs-6.0.0-beta.39

delete time in a day

PR merged google/web-stories-wp

Reviewers
Bump @storybook/addon-knobs from 6.0.0-beta.38 to 6.0.0-beta.39 Dependencies JavaScript cla: yes

Bumps @storybook/addon-knobs from 6.0.0-beta.38 to 6.0.0-beta.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/addon-knobs's releases</a>.</em></p> <blockquote> <h2>v6.0.0-beta.39</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/addon-knobs's changelog</a>.</em></p> <blockquote> <h2>6.0.0-beta.39 (July 2, 2020)</h2> <h3>Breaking Changes</h3> <ul> <li>CSF: Forbid duplicate kinds (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11369">#11369</a>)</li> <li>Args: Rename <code>globalArgs</code> to <code>globals</code> (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11385">#11385</a>)</li> </ul> <h3>Features</h3> <ul> <li>Args: Disable rows and controls in argTypes (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11388">#11388</a>)</li> <li>Composition: Add auto disable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11364">#11364</a>)</li> <li>CLI: use addon-essentials & args (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11282">#11282</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Build: Add artifacts for e2e CI task (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11365">#11365</a>)</li> <li>Build: Remove cli fixtures in favor of e2e (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/11357">#11357</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ca9e1affe9852f3b2614046f60bf820c61927f28"><code>ca9e1af</code></a> v6.0.0-beta.39</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v6.0.0-beta.39/addons/knobs">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @swissspidy.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+66 -313

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in a day

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 069543f8bcc97b7aa47f5bb0770040ce8f4b778e

Add tests

view details

push time in a day

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 1878a01e06033a4fe3e32781e6e4358be00abf68

Update job id

view details

Pascal Birchler

commit sha 924222bc2d3edc3ef16e903b11762997e9c02f45

Ignore migration file again

view details

Pascal Birchler

commit sha 2b60e160a89e65fa60801df7c90b7c72d62739b0

Run rollup differently

view details

push time in a day

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 1c53f95ba2255abecf83ffb12bc37a4b05cf0c2c

Fix script config

view details

Pascal Birchler

commit sha e463a6b74893ccf891c448c9aa12adea3003dc36

Lint fix

view details

Pascal Birchler

commit sha 6fa7a2a418798f23b1b5994bf248872f0cf6e614

Unignore built file

view details

push time in a day

pull request commentgoogle/web-stories-wp

Preload API request for dashboard.

Ah, so you cannot access the headers when parse: true?

spacedmonkey

comment created time in a day

Pull request review commentgoogle/web-stories-wp

[EXPERIMENTAL] Programmatically migrate templates

 export default function (imageBaseUrl) {             id: 'c05c1df5-86f8-4455-8ef1-c2556787d6b0',           },         ],-        backgroundElementId: 'd07dfc60-f3b6-4295-b687-012dd2cfdf8c',         backgroundOverlay: 'none',         type: 'page',         id: 'edf299b1-e35a-4049-9e66-a08dcee8b936',       },     ],+    version: 19,

Fixed!

swissspidy

comment created time in a day

push eventgoogle/web-stories-wp

Pascal Birchler

commit sha 1dbca80ee59f325c6e0383ade99f795879e81134

Fix docs

view details

Pascal Birchler

commit sha 18c699530ecd58596e10e80cb869471ada671f3d

Remove errant env var

view details

push time in a day

push eventgoogle/web-stories-wp

Clinton Volzke

commit sha 0c63ac07c79a6f7c1d8d609e4b20fbc853bd673f

Remove fetch after upload

view details

Clinton Volzke

commit sha 88c43e4352d6d5370276c6ae1d7ad695886e6abe

Add selectors to useContext calls

view details

Clinton Volzke

commit sha 1104cf408a1dc6c5ff0f2745c49ab1069122fa2f

Fix selector in editLayer.js

view details

Clinton Volzke

commit sha cdf472a4cd8b7f189b13af9e47635d8da5793c52

Move processing and processed from media context state to a ref scoped to uploadVideoPoster

view details

Clinton Volzke

commit sha 47c045dd93d0a2e945b5e19a7e1366d47b921aa3

Undo previous commit that was pushed by mistake

view details

Clinton Volzke

commit sha a9943703044650a39601223164b8b513d00098f3

Merge branch 'master' into fix/1466-add-context-selectors

view details

Clinton Volzke

commit sha 658d719f453a18f6c4c1e406181bee9fc035ea75

Add a test for updating media resources from the upload rpc response

view details

Miina Sikk

commit sha f90f25a58358760594a07a01c7cc86d46302e788

Display only presets for defualt bg page.

view details

Clinton Volzke

commit sha 062bd68694fb36005e96c8ed0d93eee2ec918cdd

Merge branch 'master' into fix/remove-fetch-after-upload

view details

Miina Sikk

commit sha 2b00dfda14e2d583001de712c72b495bef1f1292

Merge remote-tracking branch 'origin/master' into fix/1177-remove-irrelevant-panels

view details

Miina Sikk

commit sha 939ff090298e1bdc69019e2005279c342fdc5417

Use background color on Page directly.

view details

Miina Sikk

commit sha 9ebfd6e9c7e751b269c483462436828f42a42ebf

Merge remote-tracking branch 'origin/master' into fix/1177-remove-irrelevant-panels

view details

Miina Sikk

commit sha 2f9df61a870c051f511a8cba1df3ec1f2146bc85

Fixes from review.

view details

Miina Sikk

commit sha ce33b4c576d35737493baf9b6a67245ca4cd6fa9

Remove redundant code.

view details

Miina Sikk

commit sha 9aac5f79bceedba995b0fe4b6e861a9c0052de2d

Remove unused prop.

view details

Clinton Volzke

commit sha a1f4d1d253f1a665b674dfe7bc1453eccaac2301

Merge branch 'master' into fix/1466-add-context-selectors

view details

Clinton Volzke

commit sha faa56ec85010a78f9e5e7deefb6b1fac2e92b7da

Add new instances of useMedia and useStory.

view details

Miina Sikk

commit sha 00284b7974c0f163bc0b2e178de4764d480677cf

Nits.

view details

Clinton Volzke

commit sha 10961d4d20e24528ab8c05be37729f8e1f4c3c7a

Fix lint error

view details

Clinton Volzke

commit sha 50a278b1d6f02e54f64e62c0329d7125a622fc39

Merge branch 'master' into fix/remove-fetch-after-upload

view details

push time in a day

pull request commentgoogle/web-stories-wp

Preload API request for dashboard.

It is impossible to preload the request. Only parse: true, GET requests can be preloaded. See

That's why I want to set parse: true.

You mentioned that they are currently unparsed:

https://github.com/google/web-stories-wp/blob/fbd6d8f644283311e6a43e62e78b88cb4f7b9599/assets/src/dashboard/app/api/useStoryApi.js#L134

So, what happens if you just change this to parse: true?

spacedmonkey

comment created time in a day

issue commentgoogle/web-stories-wp

Prop types warning on load

Ha! I think it should have been StoryPropTypes.textContent, not StoryPropTypes.elements.text.

spacedmonkey

comment created time in a day

issue commentgoogle/web-stories-wp

Media - External Embeds

@samitron7 First of all, I don't know whether we want to support this functionality or not, but if we want to, there would need to be a way to enter a URL to embed an image. For example, Gutenberg offers this:

Screenshot 2020-07-02 at 17 04 35

jauyong

comment created time in a day

more