profile
viewpoint
Kunal Kushwaha kunalkushwaha Tokyo (Japan) http://kunalkushwaha.github.io/ Cloud and Linux Container Enthusiast

containers/libpod 4814

libpod is a library used to create container pods. Home of Podman.

kunalkushwaha/ctr-powertest 5

container runtime testsuite

kunalkushwaha/coffee 1

Have a coffee break :)

kunalkushwaha/abot 0

Abot makes it easy and fun to build your own digital assistant, and we include everything you need to get started.

kunalkushwaha/afero 0

A FileSystem Abstraction System for Go

kunalkushwaha/authz 0

Docker Authorization Plugin

kunalkushwaha/bucketbench 0

Go-based framework for running benchmarks against Docker, containerd, and runc engine layers

kunalkushwaha/buildkit 0

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit

kunalkushwaha/client-go 0

Go client for kubevirt

created tagkunalkushwaha/kubectl-design

tagv0.0.1

kubectl plugin to generate yaml definition and edit them in your favorite editor

created time in 5 hours

release kunalkushwaha/kubectl-design

v0.0.1

released time in 5 hours

PublicEvent

push eventkunalkushwaha/kubectl-design

Kunal Kushwaha

commit sha 1aea28968a9a11ba59ce9afa408711228eba3d0f

Updated Readme with demo

view details

push time in 6 hours

push eventkunalkushwaha/com.github.kunalkushwaha.weatherindicator

Kunal Kushwaha

commit sha 78a0681eaec08b9bdf885fdecfd33916353f9e10

inital version

view details

push time in 6 days

created repositorykunalkushwaha/com.github.kunalkushwaha.weatherindicator

Elementary Os Hera Weather indicator.

created time in 6 days

startedkubermatic/kubeone

started time in 20 days

startedkubermatic/kubecarrier

started time in 20 days

pull request commentcontainers/storage

new interface for MountImage added

@rhatdan : @sujil02 asked me a few days back regarding this and had explained to him. I thought he is already working on this.

The major blocker on this for merging was test case failure. (https://github.com/containers/storage/pull/438#issuecomment-550970311)

I may not be able to pick it up very soon. So if anyone can pick it up, it will be nice.

kunalkushwaha

comment created time in a month

startedanandpawara/Real_Time_Image_Animation

started time in a month

delete branch kunalkushwaha/ltag

delete branch : add-license-1

delete time in 2 months

delete branch kunalkushwaha/ltag

delete branch : refactoring

delete time in 2 months

delete branch kunalkushwaha/ltag

delete branch : multi-type

delete time in 2 months

created tagkunalkushwaha/ltag

tagv0.2.2

Prepends project files with given template.

created time in 2 months

release kunalkushwaha/ltag

v0.2.2

released time in 2 months

pull request commentkunalkushwaha/ltag

fix symbolic link panic

Thank you @mikebrow for PR.

mikebrow

comment created time in 2 months

push eventkunalkushwaha/ltag

Mike Brown

commit sha 5a99b302ff7cdc8a3fd78f238a1347b2442539e8

fix symbolic link panic Signed-off-by: Mike Brown <brownwm@us.ibm.com>

view details

Kunal Kushwaha

commit sha 1f92d0b1d4d9cdd47f3965f842bcf1e3ac175342

Merge pull request #11 from mikebrow/fix-symbolic-link-error fix symbolic link panic

view details

push time in 2 months

PR merged kunalkushwaha/ltag

fix symbolic link panic

avoids panic when running into a symlink by ignoring the symlink needed for https://github.com/containerd/cri/blob/master/test/e2e

before:

ltag -t "../project/script/validate/template" --excludes "vendor" --check -v
panic: read test/e2e: is a directory

goroutine 1 [running]:
main.main()
	/home/mike/go/src/github.com/kunalkushwaha/ltag/main.go:99 +0xa95

after fix:

ltag -t "../project/script/validate/template" --excludes "vendor" --check -v
_output/containerd

See: https://golang.org/pkg/path/filepath/ "Walk does not follow symbolic links." possibly fixed in 1.14.3 https://github.com/golang/go/commit/7d27e87d35b4c8948a498711cb34c1f73917535b

Signed-off-by: Mike Brown brownwm@us.ibm.com

+4 -0

1 comment

1 changed file

mikebrow

pr closed time in 2 months

push eventkunalkushwaha/libpod

Kunal Kushwaha

commit sha 1dde2730e85706177c9a0e9078c26560a280f074

filter option added to network ls command. filter option helps to filter output based on name or supported plugins by CNI networks. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha ade20f332319ff4df3eaf154f44caaae47d69011

format option added to network inspect command. This helps user to print the inspect output in go template format. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha 087fdda199aaef9f1f0ae1d111e60d22a40ed106

Testcase added for network commands New testcase for network ls --filter and inspect --format added. Also bash completion options updated. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

push time in 2 months

pull request commentcontainers/libpod

`--format` and `--filter` options for `network ls` and `network inspect` command

Got it. I will move the filter code from cli to pkg

kunalkushwaha

comment created time in 2 months

push eventkunalkushwaha/libpod

Giuseppe Scrivano

commit sha 76f8efc0d0d7a697a4821d01f3c5dbf67bf33d8e

spec: fix order for setting rlimits also make sure that the limits we set for rootless are not higher than what we'd set for root containers. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Valentin Rothberg

commit sha e4ab0cfbc6a35d4d99f79f27971671532a90307a

enable rootless mount tests Remove the annotation from the umount command to make mount tests pass and let podman-umount run as a non-root user. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Sascha Grunert

commit sha c21258b70ed91ab5ff8b1d345123fed1011a49c9

Add podman static build We’re now able to build a static podman binary based on a custom nix derivation. This is integrated in cirrus as well, whereas a later target would be to provide a self-contained static binary bundle which can be installed on any Linux x64-bit system. Fixes: https://github.com/containers/libpod/issues/1399 Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

Valentin Rothberg

commit sha 64a12898ad5dfa03e5a4e16776dc0a76357ced05

shm_lock_test: add nil check Fixes: #6164 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha 6a26caf6bf09c5481e14af56bf3e96852bac2680

Merge pull request #6167 from giuseppe/fix-setting-limits spec: fix order for setting rlimits

view details

OpenShift Merge Robot

commit sha 01f747fdc3b601492d496536ced1386172c4e3d8

Merge pull request #6168 from vrothberg/mount-tests enable rootless mount tests

view details

OpenShift Merge Robot

commit sha d473e6e35120ad254a62301a89be26e5ad589752

Merge pull request #5566 from openSUSE/static-binary Add podman static build

view details

OpenShift Merge Robot

commit sha d8c6cc16843efac13b92758b1bf93e9d5897a212

Merge pull request #6169 from vrothberg/fix-6164 shm_lock_test: add nil check

view details

Brent Baude

commit sha fbd0fccf89f994a90fbc8d63e9c90942acdbc201

v2podman image sign this is a straight port to add the podman image sign command. no improvements or refactoring done Signed-off-by: Brent Baude <bbaude@redhat.com>

view details

Ed Santiago

commit sha a82de0e3a039bb23d3a9bdb0a1cb9a56d5cec5df

Some BATS cleanup: run and systemd tests run test: run positive test before negative; and actually implement real negative tests. Also, add confirmation tests for cidfile/pidfile, not just 'exit status is good'. systemd test: enable rootless, and again add actual content testing. Signed-off-by: Ed Santiago <santiago@redhat.com>

view details

OpenShift Merge Robot

commit sha 7837bf3c071f1259bc08d8f9e52ed2b4edbda428

Merge pull request #6176 from edsantiago/bats_more Some BATS cleanup: run and systemd tests

view details

dependabot-preview[bot]

commit sha c4e391ad2e087601a184df6d4b3668d8c166f911

Bump github.com/containers/common from 0.11.1 to 0.11.2 Bumps [github.com/containers/common](https://github.com/containers/common) from 0.11.1 to 0.11.2. - [Release notes](https://github.com/containers/common/releases) - [Commits](https://github.com/containers/common/compare/v0.11.1...v0.11.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

dependabot-preview[bot]

commit sha 164768c3b9d05c2410f4f672a80c631d21b8cd02

Bump github.com/containers/image/v5 from 5.4.3 to 5.4.4 Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.4.3 to 5.4.4. - [Release notes](https://github.com/containers/image/releases) - [Commits](https://github.com/containers/image/compare/v5.4.3...v5.4.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Brent Baude

commit sha a36e8d8eaa94458325afe19d7af7f29bf7fffbcd

add port to podman remote command Signed-off-by: Brent Baude <bbaude@redhat.com>

view details

Sujil02

commit sha 1c6ae73a898222a14b98526339d9985c51f88d35

Adds tunnel routes for system reset. Adds tunnel routes for system reset. Makes forces flag local as options are not propogated down the stack. Adds relevant test cases and swagger docs. Signed-off-by: Sujil02 <sushah@redhat.com>

view details

Sascha Grunert

commit sha 6a87e4b3a6349b55e68faa3f55cf3c5547cd1813

Add netgo build tag to static binary This allows us to system independently resolve DNS requests in static Podman binaries. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

Valentin Rothberg

commit sha 1c3bd95b81e5247b7db3f8333aeb01ea58073fe9

auto-update: support authfiles Support using custom authfiles for auto updates by adding a new `--authfile` flag and passing it down into the backend. Also do some minor fixes in the help text and the man page. Fixes: #6159 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Giuseppe Scrivano

commit sha 45e712a2c651f9baf41e89c94433bcfbfea7173b

rootless: do not set pids limits with cgroupfs and enable events tests. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Giuseppe Scrivano

commit sha 664e0595dda658093f72673d8df8c32760b9845f

test: enable networking test for rootless Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

OpenShift Merge Robot

commit sha 2ad59d311b8c573186574cec6d4dc57bff0c3a53

Merge pull request #6186 from vrothberg/auto-update auto-update: support authfiles

view details

push time in 2 months

push eventkunalkushwaha/libpod

Kunal Kushwaha

commit sha a3797d5bfa7a81d4ff13ff14873ef0d430af266d

filter option added to network ls command. filter option helps to filter output based on name or supported plugins by CNI networks. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha b0a200fa171ff9b2c8de0373e472f199cab26c26

format option added to network inspect command. This helps user to print the inspect output in go template format. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha 01f5ca2a5f721571e0906cfdcc098d54ea4e5772

Testcase added for network commands New testcase for network ls --filter and inspect --format added. Also bash completion options updated. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

push time in 2 months

push eventkunalkushwaha/libpod

Kunal Kushwaha

commit sha 03e0a4dd974f18812360ccda65bb14db3b33b72b

Testcase added for network commands New testcase for network ls --filter and inspect --format added. Also bash completion options updated. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

push time in 2 months

PR opened containers/libpod

`--format` and `--filter` options for `network ls` and `network inspect` command

This PR is for fixing bug #5205 This adds following options to network commands

  • podman network ls --filter option
  • podman network inspect --format option

NOTE: Since the CNI conf file does not have defined structure and is read as read & stored as map of interfaces, its difficult to get similar output as of docker as specified in https://github.com/containers/libpod/issues/5205#issue-565036875. until we create an internal structure. Which may not be good idea, as it may require to sync up with libcni code. Ideally, this structure should be defined in libcni code.

PTAL: @medyagh @afbjorklund, If this helps your use case.

+97 -5

0 comment

5 changed files

pr created time in 2 months

push eventkunalkushwaha/libpod

Christian Felder

commit sha 90d82eb0349850521fcc53a4ddafa08e0785ebf0

Fix typo in pod create Signed-off-by: Christian Felder <c.felder@fz-juelich.de>

view details

Christian Felder

commit sha 91dbdff77e159fb5377cd57733a05c72cbd94c97

Add support for specifying CNI networks in podman play kube Fixes: #5609 Signed-off-by: Christian Felder <c.felder@fz-juelich.de>

view details

Kir Kolyshkin

commit sha c11c5e180a6e00e0093f51b050962ee1e2e30f7a

pkg/spec/initFSMounts: fix > $ ./bin/podman run -v /tmp:/tmp alpine true; echo $? > 0 > $ ./bin/podman run -v /tmp:/tmp:ro alpine true; echo $? > 0 > $ ./bin/podman run -v /tmp:/w0w:ro alpine true; echo $? > Error: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"rootfs_linux.go:58: mounting \\\"/tmp\\\" to rootfs \\\"/home/kir/.local/share/containers/storage/overlay/7636ef3650fc91ee4996ccc026532bb3cff7182c0430db662fffb933e0bcadc9/merged\\\" at \\\"/home/kir/.local/share/containers/storage/overlay/7636ef3650fc91ee4996ccc026532bb3cff7182c0430db662fffb933e0bcadc9/merged/w0w\\\" caused \\\"operation not permitted\\\"\"": OCI runtime permission denied error > 126 The last command is not working because in-container mount point is used to search for a parent mount in /proc/self/mountinfo. And yet the following > $ ./bin/podman run -v /tmp:/run/test:ro alpine true; echo $? > 0 still works fine! Here's why: > $ mount | grep -E '/run |/tmp ' > tmpfs on /run type tmpfs (rw,nosuid,nodev,seclabel,mode=755) > tmpfs on /tmp type tmpfs (rw,nosuid,nodev,seclabel) This is the reason why previous commit modified in-container mount point. Fixes: 0f5ae3c5af Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Sujil02

commit sha 7cbc09971a4d7322a6b29d86ef1d1fcb71f68f04

podmanv2 pod inspect Add the ability to inspect pod in podmanv2 Signed-off-by: Sujil02 <sushah@redhat.com>

view details

Kir Kolyshkin

commit sha f2c42a3958d12b45375aeb2384a3a8a103203c1c

pkg/spec.InitFSMounts: fix mount opts in place ... rather than create a new slice and then make the caller replace the original with the new one. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha e0614367ca27c2e47649e08291e0f1d19d42232e

pkg/spec.InitFSMounts: optimize Instead of getting mount options from /proc/self/mountinfo, which is very costly to read/parse (and can even be unreliable), let's use statfs(2) to figure out the flags we need. [v2: move getting default options to pkg/util, make it linux-specific] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Valentin Rothberg

commit sha 44a515015c3766809089d260917a508bf94a73fd

podmanV2: implement push * Implement `podman-push` and `podman-image-push` for the podmanV2 client. * Tests for `pkg/bindings` are not possible at the time of writing as we don't have a local registry running. * Implement `/images/{name}/push` compat endpoint. Tests are not implemented for this v2 endpoint. It has been tested manually. General note: The auth config extraction from the http header is not implement for push. Since it's not yet supported for other endpoints either, I deferred it to future work. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Kir Kolyshkin

commit sha ce38be795903e3f9d16d3d73a0ccee68c353013e

test/e2e/run_volume_test: only create dir once Remove repeated mountPath directory creation. * For the first two hunks it is the same dir ("secrets") that was already created before. * For the last hunk ("scratchpad") it is not used at all. Add an empty line after Mkdir for cases where dir is used more than once. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha 504f9082ee0b4d68b0cdb4b7b319795cd0e43a63

test/e2e/run_volume_test.go: mv dockerfile decl Move declaration of a dockerfile closer to its use. Since it is used only once, there's no sense in having it declared globally. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha e39cf4cf59169812cff644475ef1ea41e64166c0

test/e2e/run_volume_test: use unique mount point For volume and bind mount tests, use the in-container mount point path that has no common ancestor with any host path (except for root). This might help to uncover bugs like [1]. Even if not, it seems lile a good cleanup regardless. [1] https://github.com/containers/libpod/pull/5676 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Alban Bedel

commit sha 77d19f847a7488ccaccae769cf6b27f880ebe07b

If possible use the pod name when creating a network When creating a network we pass down a name which end up in the K8S_POD_NAME argument to cni plugins. Currently this name is always filled with the container name, so for pods it is the name of the infra container, not really what one would expect. This mess up with the dnsname plugin as it doesn't receive the pod name in K8S_POD_NAME. To fix this pass the pod name when the container is part of a pod, otherwise use the container name like before. Signed-off-by: Alban Bedel <albeu@free.fr> --- v2: Only call GetPod() when a pod id is set

view details

OpenShift Merge Robot

commit sha ccb9e579c48141f70d016adfa9a9d4934bbdf976

Merge pull request #5702 from kolyshkin/test-nitpicks test/e2e/run_volume_test nitpicks

view details

dependabot-preview[bot]

commit sha eb86bfc3441cbd3e0e1932cf5ed983002fc30b73

Bump github.com/containers/common from 0.6.1 to 0.8.0 Bumps [github.com/containers/common](https://github.com/containers/common) from 0.6.1 to 0.8.0. - [Release notes](https://github.com/containers/common/releases) - [Commits](https://github.com/containers/common/compare/v0.6.1...v0.8.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Brent Baude

commit sha 8a16674722ab4a33ce66e57d151b09ac348e8e6d

podmanv2 checkpoint and restore add the ability to checkpoint and restore containers on v2podman Signed-off-by: Brent Baude <bbaude@redhat.com>

view details

OpenShift Merge Robot

commit sha a168dcc39cfa7335610663d4496b712a478abd69

Merge pull request #5700 from containers/dependabot/go_modules/github.com/containers/common-0.8.0 Bump github.com/containers/common from 0.6.1 to 0.8.0

view details

Daniel J Walsh

commit sha 84aa81fabe789c670bc67955a7fb05f7a4e46e67

Pass path environment down to the OCI runtime Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Adrian Reber

commit sha 7660330ae22792d993d0b94c9be8417c7e848cb6

checkpoint: change runtime checkpoint support test Podman was checking if the runtime support checkpointing by running 'runtime checkpoint -h'. That works for runc. crun, however, does not use '-h, --help' for help output but, '-?, --help'. This commit switches both checkpoint support detection from 'runtime checkpoint -h' to 'runtime checkpoint --help'. Podman can now correctly detect if 'crun' also support checkpointing. Signed-off-by: Adrian Reber <areber@redhat.com>

view details

Adrian Reber

commit sha 001fe983dfd6e6ae3f58e1f9bb1f61c189c98f9c

checkpoint: handle XDG_RUNTIME_DIR For (almost) all commands which podman passes on to a OCI runtime XDG_RUNTIME_DIR is set to the same value. This does not happen for the checkpoint command. Using crun to checkpoint a container without this change will lead to crun using XDG_RUNTIME_DIR of the currently logged in user and so it will not find the container Podman wants to checkpoint. This bascially just copies a few lines from on of the other commands to handle 'checkpoint' as all the other commands. Thanks to Giuseppe for helping me with this. For 'restore' it is not needed as restore goes through conmon and for calling conmon Podman already configures XDG_RUNTIME_DIR correctly. Signed-off-by: Adrian Reber <areber@redhat.com>

view details

OpenShift Merge Robot

commit sha a89d62ac3a445a5d76bd72d4b8e1bb9262ba74c6

Merge pull request #5701 from vrothberg/v2-push podmanV2: implement push

view details

OpenShift Merge Robot

commit sha 2d9b9e81a30ac46848587414d34955ad4cb991a7

Merge pull request #5676 from kolyshkin/volume-flags-alt Fix/improve pkg/storage.InitFSMounts

view details

push time in 2 months

issue commentcontainers/libpod

network inspect does not have format

@medyagh Sorry for the delay in this. Due to recent client code (v2 changes), my fix is not mergeable. I am trying to fix this. Shall be able to do it soon.

medyagh

comment created time in 2 months

issue commentcontainers/libpod

network inspect does not have format

Sorry, somehow it skipped from task list. Its half done.. shall make PR soon.

medyagh

comment created time in 2 months

pull request commentcontainers/libpod

image prune skips images with child images.

were fixed previously but now are in the code again.

What is going on here? AFAICT it is not a caching issue on my end.

I am not sure, how that happens. I have updated all of the required changes. PTAL.

kunalkushwaha

comment created time in 3 months

push eventkunalkushwaha/libpod

Kunal Kushwaha

commit sha 9dc9f5cf4cc5d0c688263d5532ece0d3079c6d4a

image prune skips images with child images. While image build process, intermediate images are created. These images are also used as cache images, used in rebuilding same images. This fix the deletion of cache images. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha 1e8e4bb331c7b42bf17e75748a60b91850b2d5fb

note for skipping cache image added. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha d8321363498c349647409dea1b6e15f8cf0ac17a

test case added for image prune cache image test case added for skipping cache images and fixed condition in test case for prune dangling image Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

push time in 3 months

pull request commentcontainers/libpod

image prune skips images with child images.

@mtrmac PTAL. All issues are resolved now.

kunalkushwaha

comment created time in 3 months

issue commentcontainers/libpod

Play kube support for volumes created with `podman volume create`

I can look into this.

frezbo

comment created time in 3 months

push eventkunalkushwaha/kubevirt

Kunal Kushwaha

commit sha 79b10314caa85f824cce44a12b1e3eed0a5a7d7a

support for VMIService added into virt-controller VMIService implementation is part of watch package of virt-controller VMIServiceController watch VMIService CRD and creates headless service with endpoints based of defination. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha b5798f302432c90e2e48d528c0bbb78562912dbd

support for VMIService in virt-operator VMIService CRD creation code added. VMIService creates a headless service, so added into RABC settings. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

push time in 3 months

create barnchkunalkushwaha/libpod

branch : network-inspect

created branch time in 3 months

issue commentcontainers/libpod

play kube doesn't support container args

@athena-metis Please continue. Please free to ping me, if you feel to discuss anything.

athena-metis

comment created time in 3 months

push eventkunalkushwaha/libpod

Robert P. J. Day

commit sha 2e34d06d0f79aafc0237e24666a562d50bbe0251

docs: mention that "podman version" prints out Remote API Version Since "man podman-version" seems to want to list everything printed about the current version, add a reference to Remote API Version for completeness. Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

view details

Chris Evich

commit sha 22904c1799cab6a86080f1dbf2868a4e280f49d1

Cirrus: Log libseccomp package version Signed-off-by: Chris Evich <cevich@redhat.com>

view details

Qi Wang

commit sha abb60fbba2d4e9f4795d5be8a14001e8a72ec7d7

container prune remove state created, configured podman container prune should remove containers with state Created, Configured to be compatible with docker Signed-off-by: Qi Wang <qiwan@redhat.com>

view details

Chris Evich

commit sha 9215eb03316099801dc7600e32affc4e7fa4df67

Cirrus: Disable non-docs release processing Detecting when it's time to upload a release inside Cirrus-CI is really difficult for many automation and human reasons. Disabling it for now until a more robust solution can be implemented Signed-off-by: Chris Evich <cevich@redhat.com>

view details

Brent Baude

commit sha abbbeacd68b4d4973a55a8d7263bd0a27f5c4e8e

apiv2 addition of manifests add endpoints for create, add, remove, inspect, and push. this allows manifests to be managed through the restful interfaces. also added go-bindings and tests Signed-off-by: Brent Baude <bbaude@redhat.com>

view details

Giuseppe Scrivano

commit sha cc57b88f774c0509a8e4e362861b8d2caeb5039a

config: make warning clearer make clearer that the warning could also happen because the logger is set to use systemd. Closes: https://github.com/containers/libpod/issues/5443 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Valentin Rothberg

commit sha a255d7986a1e6795d448979f7662464be4558324

pkg/systemd: add dbus support Move the dbus-connection code from libpod's healthcheck to pkg/systemd to allow for sharing the logic. Needed for the auto-updates work. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Daniel J Walsh

commit sha 8081d9c74552612ad73fef27e5775fcfb371e812

Update containers/storage to v1.16.5 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

OpenShift Merge Robot

commit sha c4a62733aeb6334c755d1deb2ccd0cd7e2d47702

Merge pull request #5520 from giuseppe/make-warning-clearer config: make warning clearer

view details

OpenShift Merge Robot

commit sha 9ef5d28759e6d37c6f5c1f07df4cf676077851dc

Merge pull request #5449 from baude/manifests apiv2 addition of manifests

view details

xcffl

commit sha 68ef7aa4fb10dbe10b58d516fdb4111d6a0e6ce6

Fix path of tmp_dir Signed-off-by: xcffl <xcffl@protonmail.com>

view details

Valentin Rothberg

commit sha f4e873c4e10502dd0a7fb14cc2fd87b12760a318

auto updates Add support to auto-update containers running in systemd units as generated with `podman generate systemd --new`. `podman auto-update` looks up containers with a specified "io.containers.autoupdate" label (i.e., the auto-update policy). If the label is present and set to "image", Podman reaches out to the corresponding registry to check if the image has been updated. We consider an image to be updated if the digest in the local storage is different than the one of the remote image. If an image must be updated, Podman pulls it down and restarts the container. Note that the restarting sequence relies on systemd. At container-creation time, Podman looks up the "PODMAN_SYSTEMD_UNIT" environment variables and stores it verbatim in the container's label. This variable is now set by all systemd units generated by `podman-generate-systemd` and is set to `%n` (i.e., the name of systemd unit starting the container). This data is then being used in the auto-update sequence to instruct systemd (via DBUS) to restart the unit and hence to restart the container. Note that this implementation of auto-updates relies on systemd and requires a fully-qualified image reference to be used to create the container. This enforcement is necessary to know which image to actually check and pull. If we used an image ID, we would not know which image to check/pull anymore. Fixes: #3575 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha 8f1ce4bddd54fe8067cca688430a7099c5f42cd1

Merge pull request #5524 from rhatdan/vendor Update containers/storage to v1.16.5

view details

Matthew Heon

commit sha 83d2686f466e1ea439039c301fcdce53313d3af0

Fix vendoring on master It looks like something snuck in and now make vendor fails on master. This should make things happy. Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

Matthew Heon

commit sha 7c5ffe377213b3c9b84bd87d845756d9457fb2df

Update release notes for v1.8.2-rc1 Signed-off-by: Matthew Heon <matthew.heon@pm.me>

view details

OpenShift Merge Robot

commit sha bcdcfeb3e35ca81e3802a2455e08296d3f894d20

Merge pull request #5529 from mheon/release_notes_182_rc1 [CI:DOCS] Update release notes for v1.8.2-RC1

view details

Brent Baude

commit sha 14186ca28e01a35937eeb61e7168eb8e3161b507

fix timeout file flake this is a temporary fix for the flake that has been troubling us. once conmon is in fedora 30 and 31 stable, we can remove this fix. the images will just need to be rebuilt. Signed-off-by: Brent Baude <bbaude@redhat.com>

view details

Matthew Heon

commit sha d47dc63cf5b4804e5daf81f1e53d26ad7857a1e0

Fix vendoring on master It looks like something snuck in and now make vendor fails on master. This should make things happy. Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

OpenShift Merge Robot

commit sha f3a28de3249032e5d7be14114b126c7bddf3d479

Merge pull request #5528 from mheon/fix_master_vendor Fix vendoring on master

view details

Matthew Heon

commit sha c617484c15db0c0f227cab3c57f36a1585092a31

Bump to v1.8.2-rc1 Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

push time in 3 months

Pull request review commentcontainers/libpod

image prune skips images with child images.

 podman-image-prune - Remove all unused images from the local store you can delete all unused images.  Unused images are dangling images as well as any image that does not have any containers based on it. +The image prune command does not prune any cache image, i.e. intermediate images built during image creation.

Updated it.

kunalkushwaha

comment created time in 3 months

push eventkunalkushwaha/libpod

Kunal Kushwaha

commit sha 5d3a050022a91c49fca344afdb3a5e3e302b63c7

image prune skips images with child images. While image build process, intermediate images are created. These images are also used as cache images, used in rebuilding same images. This fix the deletion of cache images. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha 2149ba3aff453cb2711abea1f027a783f4ac5511

note for skipping cache image added. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

Kunal Kushwaha

commit sha 4c4e934bbc951e048f8e1bd90d600c7235af5076

test case added for image prune cache image test case added for skipping cache images and fixed condition in test case for prune dangling image Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>

view details

push time in 3 months

Pull request review commentcontainers/libpod

image prune skips images with child images.

 podman-image-prune - Remove all unused images from the local store you can delete all unused images.  Unused images are dangling images as well as any image that does not have any containers based on it. +The image prune command does not prune any cache image, i.e. intermediate images built during image creation.

Writing too much explanation like explaining valid image may not look good. Will removing valid will fix it?

kunalkushwaha

comment created time in 3 months

issue commentcontainers/libpod

play kube doesn't support container args

If no one working.. I can pick it up this too.

athena-metis

comment created time in 3 months

Pull request review commentcontainers/libpod

image prune skips images with child images.

 podman-image-prune - Remove all unused images from the local store you can delete all unused images.  Unused images are dangling images as well as any image that does not have any containers based on it. +The image prune command does not prune any cache image, i.e. intermediate images built during image creation.

This is fixed. updated text is

The image prune command does not prune any valid cache image, i.e. intermediate images built during tagged image creation.
kunalkushwaha

comment created time in 3 months

pull request commentkubevirt/kubevirt

[WIP] VMIS support for VirtualMachines.

Got it, currently using the vm-cirros example for the test. I will try with the fedora vmi.

kunalkushwaha

comment created time in 3 months

Pull request review commentcontainers/libpod

image prune skips images with child images.

 func (ir *Runtime) GetPruneImages(all bool, filterFuncs []ImageFilter) ([]*Image 				pruneImages = append(pruneImages, i) 			} 		}++		//skip the cache or intermediate images+		cache, err := i.Intermediate(ctx)+		if err != nil {+			return nil, err+		}+		if cache {+			continue+		}++		if i.Dangling() {+			pruneImages = append(pruneImages, i)

This is also fixed now.

kunalkushwaha

comment created time in 3 months

more