justinclift ( Justin Clift )

Lambdas without parameters at dbhub.py, lines 468, 469

Hi. Nice library!

Was trying to run a query but was not working:

TypeError: <lambda>() takes 0 positional arguments but 1 was given

The piece of code starting at line 463:

        for result_row in res:
            one_row = {}
            for data in result_row:
                result = {
                    0: lambda v: base64.b64decode(v.encode('ascii')) if isinstance(v, str) else None,   # Binary
                    1: lambda: "",                                                                      # Image - just output as an empty string (for now)
                    2: lambda: None,                                                                    # Null
                    3: lambda v: str(v) if isinstance(v, str) else "",                                  # Text
                    4: lambda v: int(v),                                                                # Integer
                    5: lambda v: float(v)                                                               # Float
                }[data['Type']](data['Value'])
                one_row.update({data['Name']: result})
            rows.append(one_row)

Passes a parameter to the anonymous function in cases 1 and 2, but it does not expect any parameter.

Fixed jus adding the parameter that simply is not used:

        for result_row in res:
            one_row = {}
            for data in result_row:
                result = {
                    0: lambda v: base64.b64decode(v.encode('ascii')) if isinstance(v, str) else None,   # Binary
                    1: lambda v: "",                                                                      # Image - just output as an empty string (for now)
                    2: lambda v: None,                                                                    # Null
                    3: lambda v: str(v) if isinstance(v, str) else "",                                  # Text
                    4: lambda v: int(v),                                                                # Integer
                    5: lambda v: float(v)                                                               # Float
                }[data['Type']](data['Value'])
                one_row.update({data['Name']: result})
            rows.append(one_row)

Cheers,

Daniel.

created time in 30 minutes

PR opened sqlitebrowser/sqlitebrowser

Permit dollar signs ($) after the first char in unquoted IDs

DB4S uses its own lexer and parser to process the database's schema for display in the Database Structure tab. This lexer does not permit dollar signs ($) in unquoted identifiers. SQLite's tokenizer, however, permits (and therefore real SQLite databases may have) dollar signs in unquoted identifiers, for compatibility with certain other database systems that also permit these non-standard identifiers. (I tripped over this issue while playing with databases exported from Oracle, which often uses dollar signs in identifiers for special "system" tables and columns.) See:

https://www.sqlite.org/cgi/src/file?name=src/tokenize.c&ci=c5e2de1d24d34589&ln=162-165 https://www.sqlite.org/cgi/src/file?name=src/global.c&ci=fd8b68a474226e3b&ln=113-116

My opinion from the peanut gallery is that it might be better to use SQLite's tokenizer and parser (which could be included inline or something) so as to absolutely assure precise, bug-for-bug compatibility with at least some version of SQLite, but that's not a five-minute drive-by patch, and adding one character to one regex is. This follows what appears to be the practice in this codebase of committing flex's output after making any change to the source; if there's something undesirable about my copy of flex's output, I can leave that out.

+620 -620

1 commit in oldlaptop/sqlitebrowser/tree/permit_dollar_in_ids sqlitebrowser/sqlitebrowser/tree/master

0 comment

3 changed files

pr created time in 10 hours

push eventsqlite/sqlite

drh

commit sha 5d8ade1f67c8a4f3ed516f8e476834659394735a

Remove unnecessary (redundant) variable initialization from sqlite3BtreeInsert() for a small size reduction and performance increase. FossilOrigin-Name: 70d1836474207fa045ff7aa513839c9df26ea6e180eb898b30d89bd5b3833f58

Describe the new feature

Additional info

Is your feature request related to an issue? Please include the issue number.

Does this feature exist in another product or project? Please provide a link.

Do you have a screenshot? Please add screenshots to help explain your idea.

Details for the issue

What did you do?

What did you expect to see?

What did you see instead?

Useful extra information