profile
viewpoint
Josh Marinacci joshmarinacci @MozillaReality Eugene OR http://joshondesign.com/ Mozilla Mixed Reality team

immersive-web/webxr 1919

Repository for the WebXR Device API Specification.

anselm/aterrain 86

Exposes a few features of Cesium to AFrame

joshmarinacci/AppBundler 42

Ant task to bundle desktop Java apps as native executables and doubleclick jars.

joshmarinacci/aminogfx 35

Amino Graphics library for NodeJS on Raspberry Pi

EFForg/spot_the_surveillance 26

Spot the Surveillance is an open-source educational VR tool to help people identify street-level surveillance in their community. As each surveillance device is identified, the user is informed on how the device is used via text and narration. The experience is created with accessibility in mind, so is entirely gaze-based for people with mobility challenges. Audio is also used to assist low-vision users.

joshmarinacci/aminolang 26

OpenGL scene graph gfx api for NodeJS & Browser

joshmarinacci/arduino-data 25

machine readable info about the many Arduino and Arduino compatible boards

joshmarinacci/aminogfx-gl 19

AminoGFX implementation for OpenGL / GLES2

joshmarinacci/appy-style 4

CSS framework for desktop web-apps

joshmarinacci/aminojava 3

The Java port of the Amino scenegraph

pull request commentjoshmarinacci/node-pureimage

Handle bad JPEG data

It looks good. Thank you!

knolleary

comment created time in 19 hours

push eventjoshmarinacci/node-pureimage

Nick O'Leary

commit sha 493db317a9d330200ef024e31eaf1386b4a27314

Catch decode JPEG error

view details

Nick O'Leary

commit sha 3ba8a159a8ee997e46441676de9ee6fb008dd63c

Add unit test for handling bad jpeg data

view details

Josh Marinacci

commit sha d5df46c57f07c537981a42cea11e9106dee7c22a

Merge pull request #113 from knolleary/fix-bad-jpeg Handle bad JPEG data.

view details

push time in 19 hours

PR merged joshmarinacci/node-pureimage

Handle bad JPEG data

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

Description

In testing I found that passing a Buffer with garbage data in to pureimage.decodeJPEGFromStream was causing an Uncaught Exception to be thrown:

29 Oct 15:05:13 - [red] Uncaught Exception:
29 Oct 15:05:13 - Error: SOI not found
    at constructor.parse (/Users/nol/code/node-red/node-red-nodes/utility/annotate-image/node_modules/jpeg-js/lib/decoder.js:628:15)
    at Object.decode (/Users/nol/code/node-red/node-red-nodes/utility/annotate-image/node_modules/jpeg-js/lib/decoder.js:1096:11)
    at Readable.data.on (/Users/nol/code/node-red/node-red-nodes/utility/annotate-image/node_modules/pureimage/src/pureimage.js:108:41)
    at Readable.emit (events.js:198:13)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Having stepped through the code, I can see that when JPEG.decode throws the error there was nothing there to catch it.

This fix adds a try/catch around the call to decode and ensures the enclosing promise is properly rejected with the error.

On the question of tests, from a clean checkout of the master branch, I have one test failing that is unrelated to the change I've made.

  ● drawing gradients › is making a radial gradient

    expect(received).toBe(expected) // Object.is equality

    Expected value to be:
      16711935
    Received:
      8388863
+15 -1

0 comment

2 changed files

knolleary

pr closed time in 19 hours

issue commentjoshmarinacci/node-pureimage

Play nice with Jimp

I've never heard of JIMP. Could you put in a link explaining what it is?

Steve-Mcl

comment created time in 5 days

push eventjoshmarinacci/voxeljs-next

andrewrgarcia

commit sha 10c45534a55e4a12f1e721fc47baea012013aef9

added lift (levitating) player capabilities t for up g for down

view details

andrewrgarcia

commit sha 3769ca49c825cb683aa39fb1a09f6fe00078594e

added lift (levitating) player capabilities t for up g for down

view details

andrewrgarcia

commit sha 3618d63c6a7dd083bc59cba4d9aae2d707bdf5be

test rep

view details

Josh Marinacci

commit sha 92977d71e14c3a76dd02719c0ace284258290269

Merge pull request #38 from andrewrgarcia/master Added player ability to lift (levitate) to example

view details

push time in 19 days

PR merged joshmarinacci/voxeljs-next

Added player ability to lift (levitate) to example

keys "t" and "g" for levitating up and down. I hope my code is not too sloppy. You may pass it if you find it valuable.

+41 -17

2 comments

3 changed files

andrewrgarcia

pr closed time in 19 days

pull request commentjoshmarinacci/voxeljs-next

Added player ability to lift (levitate) to example

Looks great. thanks!

andrewrgarcia

comment created time in 19 days

pull request commentjoshmarinacci/css-tables-demo

Remove white space. html

I think a different merge fixed these issues.

ritikaahirkar

comment created time in a month

pull request commentjoshmarinacci/css-tables-demo

improved docs

thanks!

virendrakini

comment created time in a month

push eventjoshmarinacci/css-tables-demo

virendrakini

commit sha 0717a652149ae1f1b2e905660de3b2ed880169b3

Update README.md

view details

virendrakini

commit sha 3cd22b5bf72451a10d295e026f27bef3b1b9b3aa

Update README.md

view details

Josh Marinacci

commit sha 1eef78d0f4e4621fc5764ac951aefb7582d7c037

Merge pull request #4 from virendrakini/master improved docs

view details

push time in a month

pull request commentjoshmarinacci/css-tables-demo

Update test1.html and remove white spaces

thank you

SheikhTausif

comment created time in a month

push eventjoshmarinacci/css-tables-demo

SheikhTausif

commit sha 02f55cba2d775b77cf80b031195972b42f41630b

Update test1.html

view details

Josh Marinacci

commit sha c604f6e877d5fac141520c7e9085d26e3ec7a4f8

Merge pull request #5 from SheikhTausif/master Update test1.html and remove white spaces

view details

push time in a month

pull request commentjoshmarinacci/css-tables-demo

title name is correct spelling

thanks!

Ravijogdand

comment created time in a month

push eventjoshmarinacci/css-tables-demo

Ravijogdand

commit sha 7614bdb9d8d4f7a5c6acffe00e9b08f3dab2945d

title name is correct spelling

view details

Josh Marinacci

commit sha 0bc34fa6a8bef2b1698436beedbad239530d240d

Merge pull request #6 from Ravijogdand/master title name is correct spelling

view details

push time in a month

push eventjoshmarinacci/jinglesmash-ecs

josh

commit sha c010c3a6637810c937d2d5cb5dddb6bdb29728f2

turn off VR stats

view details

push time in 2 months

issue closedjoshmarinacci/node-pureimage

lineTo does not appear to support rgba

context.lineTo() does not appear to work with rgba properly - the lines are always drawn with 100% opacity (aside from anti-aliasing). Also, the lines are a bit off on the corners - the top corner is expected, but the left, right and bottom corners should look like the expected output image (drawn using Canvas in Safari).

Expected Behaviour

https://codepen.io/anon/pen/xWbBrL expected

  1. Lines drawn should be at 50% opacity (0.5 alpha)
  2. Corners should be correct

Actual Behaviour

https://gist.github.com/rage8885/7ed14eb38c20f6e1678713296d745d3c out

  1. Lines drawn are always at 100% opacity
  2. Corners are not drawn correctly

closed time in 2 months

nicholas-ochoa

issue closedjoshmarinacci/node-pureimage

chart.js/HTMLCanvasElement compatibility

Hi:

I have a little express server where I create some chart.js charts using node-canvas implementation of the canvas API. The thing is, Cairo is a real pain and has a long-standing bug where custom fonts just break in Windows Azure machines... which is what I use.

I tried to switch to this library but with little success. ChartJs contructor takes the following parameters:

constructor(
        context: string | CanvasRenderingContext2D | HTMLCanvasElement | ArrayLike<CanvasRenderingContext2D | HTMLCanvasElement>,
        options: Chart.ChartConfiguration
    );

My try was to just pass the context that I can create via:

var img1 = PImage.make(100,50);
var ctx = img1.getContext('2d');
...
new ChartJS(ctx, options)

but this didn't work since this particular context does not implement CanvasRenderingContext2D.canvas property which is required for chartjs.

What I had done with node-canvas is this:

  const canvas1 = createCanvas(1000, 1000);
    const ctx = canvas1.getContext('2d');
...
 new ChartJS(ctx, options)

It works, since that library actually exposes a CanvasRenderingContext2D.canvas (here) class that implements HTMLCanvasElement methods.

Is there a way to work this out? Maybe it's as easy as just providing a HTMLCanvasElement implementation with already existing methods, and I wouldn't mind patching it myself if this library is kind of compatible already.

Thanks in advance😊😊

closed time in 2 months

jorgecf

issue closedjoshmarinacci/node-pureimage

renderGlyphToBitmap is not defined

https://github.com/joshmarinacci/node-pureimage/blob/4860360ade650e5d6319b3da85061af916a39e09/src/text.js#L100 Seems like after the refactor, this line was left behind.

closed time in 2 months

jssuttles

push eventjoshmarinacci/node-pureimage

josh

commit sha 9be446b07624cf96e5558625e47965859217a68b

0.2.5

view details

josh

commit sha 52b4585809ad5cb9b5b0e763c2624f34bfcc1bf9

since caching is deleted and broken, I've removed all references to it. fixes #85

view details

push time in 2 months

issue commentjoshmarinacci/node-pureimage

renderGlyphToBitmap is not defined

I just nuked the reference to caching, since it clearly doesn't work anyway.

jssuttles

comment created time in 2 months

issue commentjoshmarinacci/node-pureimage

chart.js/HTMLCanvasElement compatibility

I just fixed this. Could you test the latest version: 0.2.5

jorgecf

comment created time in 2 months

push eventjoshmarinacci/node-pureimage

josh

commit sha 27a7b010db757e06a8ea1e2677f9deb7075b5394

implement rect() and add unit test. fix for #100

view details

push time in 2 months

issue closedjoshmarinacci/node-pureimage

3-digit hex values are parsed incorrectly for fillStyle

Expected Behaviour

  1. ctx.fillStyle = '#999'; // should be a grey color

Expected-Picture

Actual Behaviour

  1. ctx.fillStyle = '#999'; // is actually blue-ish

Actual-Picture

Steps To Reproduce

  1. See example snippet, or set ctx.fillStyle to any 3-digit hex value

Any Relevant Code Snippets

#!/usr/bin/env node
'use strict';

const PImage = require('pureimage');
const fs = require('fs');

const canvas = PImage.make(50,50);
const ctx = canvas.getContext('2d');

ctx.fillStyle = '#999';
// ctx.fillStyle = '#999999';
ctx.fillRect(0,0,50,50);

PImage.encodePNGToStream(
    ctx.bitmap,
    fs.createWriteStream('./example.png')
).then(() => console.log('xdg-open ./example.png'));

Platform

OS: Linux Fedora 32 Node Version: v12 NPM Version: N/A PureImage Version: 0.2.4

Any Additional Info

Already fixed it. Wasn't sure if you want a PR for it or if you want to implement the fix yourself. Let me know. Side note, would you want all the defined CSS colors to be in named_colors? I can add them and I have an interest in them being included.

https://github.com/adedomin/node-pureimage/commit/699cf606f6ba002413fedd3446682358ae319de0#

closed time in 2 months

adedomin

push eventjoshmarinacci/node-pureimage

josh

commit sha 4c3ed00c60a6e01f0a04db2678653850403490c5

add unit tests for #107

view details

push time in 2 months

issue closedjoshmarinacci/node-pureimage

Text rendering is slightly pixelated

Is it expected behavior that text rendering is not super sharp? I've tried creating an image in multiple sizes, with multiple font sizes, and with multiple .ttf files from Google Fonts, and the text always appears to be pixelated.

screen shot 2018-01-30 at 1 22 19 pm

Here is my code:

    var fnt = PImage.registerFont('RammettoOne-Regular.ttf', 'RammettoOne');
    fnt.load(function () {
        var img = PImage.make(1500, 1500);
        var ctx = img.getContext('2d');
        ctx.fillStyle = 'rgba(0,0,255, 1.0)';
        ctx.fillRect(0, 0, 1000, 1000);
        ctx.fillStyle = '#ffffff';
        ctx.font = "50pt 'RammettoOne'";
        ctx.fillText("My Trunkshow", 50, 200);

        PImage.encodePNGToStream(img, fs.createWriteStream('out.png')).then(() => {
            response.sendFile('out.png', { root: __dirname });
        }).catch((e) => {
            response.send('Error');
        });
    });

closed time in 3 months

ptsimpso

issue closedjoshmarinacci/node-pureimage

Unit Tests

Can I look at straightening the tests out? I've already started to put something together locally - but (with your approval) I'll continue and start putting a branch (and ultimately) a PR together? :)

closed time in 3 months

robertmain

issue closedjoshmarinacci/voxeljs-next

publicity for the results of sprint 1

post to threejs reddit, voxeldev reddit, threejs#voxels slack, and twitter.

closed time in 3 months

joshmarinacci

issue commentjoshmarinacci/voxeljs-next

NPM Module

I haven't yet, but I was just laid off so I should have more time in the coming weeks. I'll add it to my list.

rbrandonc

comment created time in 3 months

pull request commentmozilla/Spoke

Add Scene Preview Camera Node

Nice work

robertlong

comment created time in 3 months

issue commentmozilla/hubs

Process for diagnosing and bucketing audio issues

add a discussions topic on these issues and link the form to it.

robertlong

comment created time in 3 months

issue commentmozilla/hubs

Experimental Plugin API

We need to have another meeting on how to deploy the plugins.

johnshaughnessy

comment created time in 3 months

PR closed mozilla/hubs

Don't do obsolete audio context related work

An extra React re-render on load and random events firing that nobody was subscribing to.

+8 -21

0 comment

2 changed files

mqp

pr closed time in 3 months

PR closed mozilla/hubs

Big sign-in refactoring

WIP because I still want to clean things up a bit and it's too stupid to merge this without testing carefully every flow.

Goals of this refactoring:

  • Prevent sign-in control flow from constantly jumping back and forth between 2-3 big god files, which makes it impossible to follow (ui-root.js, hub.js, and to a lesser extent scene-entry-manager.js.)
  • Eliminate the unnecessary use of React state and props as an temporary message bus between parts of the sign-in flow.
  • Incidentally fix ~most~ some of the random sign-in bugs by removing all the parts of the process where the bugs were (i.e. corrupting said state and props.)

Note that I intend to completely rework the pinning stuff in a future PR, so this is a relatively temporary state for the pin/unpin code to be in.

+219 -270

6 comments

8 changed files

mqp

pr closed time in 3 months

PR closed mozilla/hubs

Reviewers
Replace jsonschema with a tiny piece of validation logic

This was a pretty heavy dependency (a few dozen minified kilobytes) so it's unreasonable to take it and then barely use any of its features.

(It was actually even bigger than it looked, because it also secretly depended on Webpack polyfilling the Node.js url standard library module.)

+121 -85

7 comments

6 changed files

mqp

pr closed time in 3 months

pull request commentmozilla/hubs

Home Page Plugin API

next step is to figure out the deployment process. @robertlong please link the relevant issue.

robertlong

comment created time in 3 months

issue openedmozilla/hubs

create design for new 2D UI

using everything discussed in last week's meeting. Create Figma doc.

created time in 3 months

issue closedmozilla/hubs

Set up github Discussions

closed time in 3 months

netpro2k

push eventmozilla/hubs

Elgin-Skye McLaren

commit sha 301ce275acd3bb760c7e4892d97907c8e0de8769

add github discussions link in github issues tab

view details

Elgin-Skye McLaren

commit sha 7d02db06e32aeeca974471b8040d9761c1df41de

add new line at end of config.yml

view details

Elgin-Skye McLaren

commit sha 59a8c48bf16b698f57336a4fcb209654712e13c0

add new line at end of config.yml

view details

Josh Marinacci

commit sha 7af4136d6a1bde5249635f0cf2dbb980c2b5ab6d

Merge pull request #2685 from mozilla/github-discussions Create config file to add Github Discussions "Ask question" button to the Github Issues page

view details

push time in 3 months

delete branch mozilla/hubs

delete branch : github-discussions

delete time in 3 months

issue openedmozilla/hubs

figure out proper cross-repo projects in github

created time in 3 months

pull request commentjoshmarinacci/node-pureimage

Add All CSS Named Colors defined

thank you!

adedomin

comment created time in 3 months

push eventjoshmarinacci/node-pureimage

Anthony DeDominic

commit sha ba975575ca986ea11c427082d88833fb153e779d

Add all CSS Named Colors. see: https://drafts.csswg.org/css-color/#named-colors

view details

Anthony DeDominic

commit sha 4b644156b09fafd3c3585dc4f8d95a141b246871

fix NAMED_COLORS lookup to use hasOwnProperty since in would return true for inherited properties/prototypes e.g. ctx.fillStyle = 'constructor'

view details

Josh Marinacci

commit sha 73ad318b4d33efb702032f82d73cd86a2e53d1a4

Merge pull request #110 from adedomin/master Add All CSS Named Colors defined

view details

push time in 3 months

PR merged joshmarinacci/node-pureimage

Add All CSS Named Colors defined

Adds all named CSS Colors Change lookups to NAMED_COLORS to use Object#hasOwnProperty instead of in operator.

<!-- What types of changes does your code introduce? Put an x in all the boxes that apply -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

<!-- Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Description

<!-- Describe your changes here as well and any potential areas of interest you may wish to draw attention to -->

It's helpful to be able to use named colors as I had to change all my palettes from named ones to hex due the lacking defintions. The in operator can return true for inherited properties from Object. With the change, lookups to styles named 'constructor' and others, will now fail.

<!-- PR Template copied(and modified) from: https://github.com/h5bp/html5-boilerplate/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+151 -8

0 comment

2 changed files

adedomin

pr closed time in 3 months

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha 825d282df1555d7e8a0f34916388a9f798944133

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

Smiley43210

commit sha 6ceb1198cf4c563d9292b382e8d04b320a23ed73

Remove outer scoped int variable in favor of local scope

view details

Josh Marinacci

commit sha 6be85edf9d1a69027753f811c788430e2dbbf8e6

Merge pull request #109 from Smiley43210/color-parse Remove outer scoped int variable in colorStringToUint32

view details

push time in 3 months

PR merged joshmarinacci/node-pureimage

Remove outer scoped int variable in colorStringToUint32

Types of changes

<!-- What types of changes does your code introduce? Put an x in all the boxes that apply -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

<!-- Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Description

<!-- Describe your changes here as well and any potential areas of interest you may wish to draw attention to -->

Minor stylistic change that I forgot to make before #108.

<!-- PR Template copied(and modified) from: https://github.com/h5bp/html5-boilerplate/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+3 -5

0 comment

1 changed file

Smiley43210

pr closed time in 3 months

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha cc58c0d49fdb720f22d8bb5f485211d3476327f4

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

push eventjoshmarinacci/appy-comps

dependabot[bot]

commit sha 3204a450e98c9870511118daf9a40df8a6397102

Bump elliptic from 6.5.2 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Josh Marinacci

commit sha 549e28d282419c68bb6345111f04a13a036fec69

Merge pull request #2 from joshmarinacci/dependabot/npm_and_yarn/elliptic-6.5.3 Bump elliptic from 6.5.2 to 6.5.3

view details

push time in 3 months

PR merged joshmarinacci/appy-comps

Bump elliptic from 6.5.2 to 6.5.3 dependencies

Bumps elliptic from 6.5.2 to 6.5.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/elliptic/commit/8647803dc3d90506aa03021737f7b061ba959ae1"><code>8647803</code></a> 6.5.3</li> <li><a href="https://github.com/indutny/elliptic/commit/856fe4d99fe7b6200556e6400b3bf585b1721bec"><code>856fe4d</code></a> signature: prevent malleability and overflows</li> <li>See full diff in <a href="https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

push eventjoshmarinacci/node-pureimage

Smiley43210

commit sha cf535224ec704111e55e259fc3ad96b6ee346d1b

Add support for #rgb, #rgba, and #rrggbbaa color strings

view details

Josh Marinacci

commit sha 31bbc445d18d04bc5f6e4a2a0faa569be77e3899

Merge pull request #108 from Smiley43210/color-parse Add support for #rgb, #rgba, and #rrggbbaa color strings

view details

push time in 3 months

PR merged joshmarinacci/node-pureimage

Add support for #rgb, #rgba, and #rrggbbaa color strings

Types of changes

<!-- What types of changes does your code introduce? Put an x in all the boxes that apply -->

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

<!-- Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Description

<!-- Describe your changes here as well and any potential areas of interest you may wish to draw attention to -->

This PR adds support for colors formatted as #rgb, #rgba, and #rrggbbaa. https://www.w3.org/TR/css-color-4/#hex-notation

<!-- PR Template copied(and modified) from: https://github.com/h5bp/html5-boilerplate/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+39 -5

0 comment

1 changed file

Smiley43210

pr closed time in 3 months

issue commentjoshmarinacci/node-pureimage

3-digit hex values are parsed incorrectly for fillStyle

I would love a PR. Thanks!

adedomin

comment created time in 3 months

issue commentmozilla/hubs

Experiment with a Medium Quality Mode

How will this mode be triggered?

robertlong

comment created time in 3 months

issue commentmozilla/hubs

Videos broken in Safari

Why do you think the cloudflare worker fixes the issue? Does Youtube recognize it's a CDN and serve up the video differently?

emclaren

comment created time in 3 months

issue commentmozilla/hubs

add a /cat command

This would be a good thing to implement as an extension.

jessemaroo

comment created time in 3 months

issue openedmozilla/hubs

Share button is big and confusing

really it's 'invite', not 'share'. Move it to either the hamburger menu or part of the top toolbar. Rename it to 'invite'.

created time in 3 months

issue openedmozilla/hubs

introduce top screen toolbar

Combine the hamburger menu, hud, share menu, object menu, and person menu into a top of the screen toolbar. Move favorites and help buttons into the hamburger menu

created time in 3 months

issue commentmozilla/hubs

Add Movement Sounds when Navigating

consider doing this as an experimental prefs

frastlin

comment created time in 3 months

pull request commentmozilla/hubs

Medium Quality Mode

exciting!

robertlong

comment created time in 3 months

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha acb3656df603512bc3a40a61529cb0e402e9e59f

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

Josh Marinacci

commit sha 8695170a178e8773557963f7ce3d602b217a4e8b

remove versions 7 and 8 of node support from travis

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha 825afcd99332e7deaa395127ec0d8190d3a09268

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

Josh Marinacci

commit sha b610e5242bd4287a4df1acd70d24f35f2931f098

update package json w/ min node version

view details

Josh Marinacci

commit sha 4d6e347274adbcfc0e4f3ec6db2a5e2dae210292

0.2.4

view details

Josh Marinacci

commit sha 2b0050ff0cea35e1773d6600d61f28be1a086e2f

Merge remote-tracking branch 'origin/master'

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha fa708b081dd084c53402456a640fc4bc738c6795

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha 3583963a03a93a52ee9c3ad735ea5d7a25abcd5f

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

dependabot[bot]

commit sha bc2a21b4b11580374e565afcd7ad7e161ab127a6

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Josh Marinacci

commit sha 994a76d71ad119da0213b8175f050683da31ea89

Merge pull request #101 from joshmarinacci/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 3 months

PR merged joshmarinacci/node-pureimage

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

issue commentjoshmarinacci/node-pureimage

Unit Tests

it looks like all of this was done.

robertmain

comment created time in 3 months

issue closedjoshmarinacci/node-pureimage

Use an external drawing library?

Hi all,

A while back I was looking for a canvas/drawing library that doesn't depend on any native code and that could run in both node & browser (webworker). I came across this project but noticed that was severely lacking in (advanced) drawing functionality. Quite normal given the absolutely monumental task of implementing such a thing.

Anyway, in the meantime I discovered Skia (which is actually the library used by browsers to implement their canvas operations), and ported it to wasm. Including a basic set of working bindings.

Purely as a suggestion, perhaps it would be interesting to implement the canvas operations of this project using the skia wasm port as it would most likely yield far better performance, as well as having near all drawing operations already available to you, while still being 100% js compatible/no native code.

closed time in 3 months

Zubnix

issue commentjoshmarinacci/node-pureimage

Use an external drawing library?

we will never delegate to skia or another native drawing api.

Zubnix

comment created time in 3 months

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha 257ec427a30a38add5de81aa98bf9fdc4035780a

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

issue commentjoshmarinacci/node-pureimage

jpeg-js dependency needs updating

fixed. thanks for catching that.

danecreekphotography

comment created time in 3 months

push eventjoshmarinacci/node-pureimage

Josh Marinacci

commit sha b4204f66a17db5b93816f1f445595b25d5dd9e14

update version of jpeg-js fixes https://github.com/joshmarinacci/node-pureimage/issues/105

view details

Josh Marinacci

commit sha 098162f81ab4624351cd6c6300bdd4328ed40007

0.2.3

view details

push time in 3 months

issue closedjoshmarinacci/node-pureimage

jpeg-js dependency needs updating

The version of jpeg-js referenced in this package is subject to a moderate level security vulnerability (https://nvd.nist.gov/vuln/detail/CVE-2020-8175).

The package should be updated to require version 0.4.0 of jpeg-js or higher.

I found this because of a Dependabot warning in github for a project I maintain that uses pureimage.

closed time in 3 months

danecreekphotography

push eventjoshmarinacci/node-pureimage

Deployment Bot (from Travis CI)

commit sha cd5c304acd43b50954a3dab4cc2d031d2161c4a6

Deploy joshmarinacci/node-pureimage to github.com/joshmarinacci/node-pureimage.git:gh-pages

view details

push time in 3 months

issue closedjoshmarinacci/node-pureimage

fillStyle = 'transparent' results in an exception of "unknown style format"

Expected Behaviour

  1. fillStyle = 'transparent' will set it to 0 and not throw

Actual Behaviour

  1. transparent style throws "unknown style format: transparent"

Steps To Reproduce

  1. ctx.fillStyle = 'transparent';

Any Relevant Code Snippets

N/A, see Additional Info

Platform

OS: Linux (Fedora 32) Node Version: v12.16.3 PureImage Version: 0.2.1

Any Additional Info

https://github.com/joshmarinacci/node-pureimage/blob/e67821f94422497dfca049dcee2a8aac8e820164/src/context.js#L1155

https://github.com/joshmarinacci/node-pureimage/blob/e67821f94422497dfca049dcee2a8aac8e820164/src/named_colors.js#L11

I believe the problem is "transparent" maps to 0 which is why the branch in context is always false for a set property of transparent.

closed time in 3 months

adedomin

push eventjoshmarinacci/node-pureimage

Josh Marinacci

commit sha 44eec6ef01e69f6a94ca91b3aad0a8abde5e94c4

0.2.2

view details

push time in 3 months

push eventjoshmarinacci/node-pureimage

Josh Marinacci

commit sha 23b116cb057e792462cc6adcf2979dbda8815be5

fix for https://github.com/joshmarinacci/node-pureimage/issues/106 transparent named color fails because its value is 0 so NAMED_COLORS[str] evaluates to falsey change to if(str in NAMED_COLORS). add unit test.

view details

push time in 3 months

issue commentjoshmarinacci/node-pureimage

fillStyle = 'transparent' results in an exception of "unknown style format"

arg. You're right. I'll add a test and fix it.

adedomin

comment created time in 3 months

more