profile
viewpoint
João Reis joaocgreis @janeasystems Portugal Microsoft Node.js team 🚀✨

JaneaSystems/build 0

Better build and test infra for Node.

joaocgreis/bftools 0

A collection of tools to help programming in brainf*ck, just for fun.

joaocgreis/boxstarter 0

Repeatable, reboot resilient windows environment installations made easy using Chocolatey packages

joaocgreis/choco 0

Chocolatey - the package manager for Windows

joaocgreis/ChocolateyPackages 0

Chocolatey packages maintained by me

joaocgreis/email 0

MX server management for iojs.org (and eventually nodejs.org)

joaocgreis/get-cursor-position 0

🐾 Get the cursor's current position in your terminal.

joaocgreis/gitignore 0

A collection of useful .gitignore templates

joaocgreis/GYP 0

Generate You Projects

push eventJaneaSystems/build

João Reis

commit sha 63fd43129ca7a9ad56db047570953152fbf348ac

fixup! fixup! jenkins: add ARM64 Windows

view details

push time in 11 days

push eventJaneaSystems/build

João Reis

commit sha baa543c6817ade659a42a4b6a1713b849243ae98

fixup! fixup! jenkins: add ARM64 Windows

view details

push time in 11 days

push eventJaneaSystems/build

João Reis

commit sha 3227eb834ab1d21c7d946847a988290c7e7fc752

fixup! jenkins: add ARM64 Windows

view details

push time in 11 days

push eventJaneaSystems/build

João Reis

commit sha 74e1279c5a528f0a31817895d78945ac47f0d9f8

fixup! jenkins: add ARM64 Windows

view details

push time in 12 days

push eventJaneaSystems/build

João Reis

commit sha 977421a0ae58115b86e1195359c2ac18987ea323

jenkins: add ARM64 Windows

view details

push time in 12 days

create barnchJaneaSystems/build

branch : joaocgreis-K7M-arm64

created branch time in 13 days

issue commentnodejs/admin

cleanup chakracore teams and vm repo

I believe the teams can be removed. I just removed the Jenkins jobs, so they are no longer necessary there. They should be easy to bring back if the effort on Node-ChakraCore is to resume.

Trott

comment created time in 13 days

issue closednodejs/build

Remove chakracore CI jobs?

Given that the node-chakracore repository is now archived and that effort has been discontinued, the numerous chakracore related CI jobs can be cleaned up and removed, and the associated @nodejs/node-chakracore and @nodejs/node-chakracore-admins teams can be deleted.

closed time in 13 days

jasnell

issue commentnodejs/build

Remove chakracore CI jobs?

Removed 9 jobs from test and 1 from release. Had to update the backup script to support new and deleted jobs, so many older unrelated changes appear in these commits:

  • https://github.com/nodejs/jenkins-config-test/commit/2fd3bdef1f72cfe4ebc25aa43aceeb502e8398cf
  • https://github.com/nodejs/jenkins-config-release/commit/46ecbe91dad1f0f9809788b7dbcaf32febf5fb80

Confirmed the jobs were removed from disk by Jenkins.

jasnell

comment created time in 13 days

issue commentnodejs/build

Auditing @nodejs/platform-windows

stay

Trott

comment created time in 15 days

push eventjoaocgreis/post-install

João Reis

commit sha 6f4c1df82a124f41ef90b55d2e14a75e91057784

scripts,base: add gimp-plugin-registry

view details

push time in a month

Pull request review commentnodejs/node

win,msi: use x64 node executable when cross-compiling for arm64

 if defined package set stage_package=1  :: assign path to node_exe set "node_exe=%config%\node.exe"+if "%target_arch%"=="arm64" if "%PROCESSOR_ARCHITECTURE%"=="AMD64" (+  if not defined "%x64_node_exe%" set "x64_node_exe=temp-vcbuild\node-x64-cross-compiling.exe"+  if not exist "%x64_node_exe%" (+    echo Downloading x64 node.exe...+    if not exist "temp-vcbuild" mkdir temp-vcbuild+    powershell -c "Invoke-WebRequest -Uri 'https://nodejs.org/dist/latest/win-x64/node.exe' -OutFile 'temp-vcbuild\node-x64-cross-compiling.exe'"+  )+  if not exist "%x64_node_exe%" (+    echo Could not find the Node executable at the given x64_node_exe path. Aborting. +    goto exit
    set exit_code=1
    goto exit

This should leave errorlevel set.

dennisameling

comment created time in a month

Pull request review commentnodejs/node

win,msi: use x64 node executable when cross-compiling for arm64

 if defined package set stage_package=1  :: assign path to node_exe set "node_exe=%config%\node.exe"+if "%target_arch%"=="arm64" if "%PROCESSOR_ARCHITECTURE%"=="AMD64" (+  if not defined "%x64_node_exe%" set "x64_node_exe=temp-vcbuild\node-x64-cross-compiling.exe"+  if not exist "%x64_node_exe%" (+    echo Downloading x64 node.exe...+    if not exist "temp-vcbuild" mkdir temp-vcbuild+    powershell -c "Invoke-WebRequest -Uri 'https://nodejs.org/dist/latest/win-x64/node.exe' -OutFile 'temp-vcbuild\node-x64-cross-compiling.exe'"+  )+  if not exist "%x64_node_exe%" (+    echo Could not find the Node executable at the given x64_node_exe path. Aborting. +    goto exit+  )+  echo Using x64 Node executable because we're cross-compiling for arm64: %x64_node_exe%+  set "node_exe=%x64_node_exe%"

node_exe should always point to the binary being built. Linters, node-gyp, npm, all of that should fail when cross-compiling.

Please use a dedicated variable name, and use it only to run things that are absolutely needed to build a release (only licence2rtf?).

dennisameling

comment created time in a month

issue commentnodejs/build

Node.js jenkins-admins audit

Please keep my access.

AshCripps

comment created time in a month

issue commentnodejs/build

Node.js Build working group audit

active (though not much this month)

AshCripps

comment created time in a month

pull request commentnodejs/node

Allow creating MSI installers for Windows ARM64

@dennisameling thanks for opening this PR and moving ARM64 support forward!

The approach here generally LGTM. We have WiX 3.11 in the machines that build Node, we get it from https://chocolatey.org/packages/wixtoolset. To move forward with ARM64 support I'll have to look into the best way to overcome this, but for now, since ARM64 is experimental, this does not block this PR unless there is some conflict with WiX 3.11 when building the supported architectures.

These files have been in place for a while, and for big changes we should test upgrade scenarios. To avoid that, I'd be more confident landing this if you could remove the unrelated changes you mentioned above, if building still works.

Minor nit, there's a change in the last line of the proj files that would be good to remove as well.

We need to start a test build of the final version of this before landing, to ensure there are no regressions with the current release system.

dennisameling

comment created time in 2 months

pull request commentnodejs/node

win: allow skipping the supported platform check

The last changes here have not been reviewed, it would be good to have a review before landing (or confirmation from one of the reviewers above). Thanks!

joaocgreis

comment created time in 2 months

pull request commentnodejs/node

win: allow skipping the supported platform check

Updated.

@jasnell can you take a look at node.1?

joaocgreis

comment created time in 2 months

push eventJaneaSystems/node

João Reis

commit sha 77eb635286ecf87ba7522f2948f11335726785c5

fixup! win: allow skipping the supported platform check

view details

push time in 2 months

delete branch joaocgreis/post-install

delete branch : master_tmp

delete time in 2 months

push eventjoaocgreis/post-install

João Reis

commit sha 8d7a8947cdfffbe0f514db32700e2ab98c10b47d

readme: add Ubuntu 20.04 LTS

view details

push time in 2 months

push eventjoaocgreis/post-install

João Reis

commit sha 62e7bc4c8170c68791dafbf3d2d4aa8762fce163

scripts,base: install Ansible using Python

view details

João Reis

commit sha 2b9cbd442f82a9fe3fb7a77b2e5261d9825cb3b3

scripts,base: move to OpenJDK, Oracle no longer available

view details

push time in 2 months

create barnchjoaocgreis/post-install

branch : master_tmp

created branch time in 2 months

create barnchjoaocgreis/post-install

branch : ubuntu_20.04

created branch time in 2 months

Pull request review commentlibuv/libuv

win: bump minimum supported version to windows 8

 |---|---|---|---| | GNU/Linux | Tier 1 | Linux >= 2.6.32 with glibc >= 2.12 | | | macOS | Tier 1 | macOS >= 10.7 | |-| Windows | Tier 1 | >= Windows 7 | MSVC 2008 and later are supported |+| Windows | Tier 1 | >= Windows 8 | VS 2015 and later are supported |

The latest update of VS2015 is still supported until 2025. For Node.js, removing support here shouldn't be an issue, as VS2015 is only supported to build addons, not Node itself.

https://support.microsoft.com/en-us/lifecycle/search?alpha=Visual%20Studio%202015%20Update%203

bnoordhuis

comment created time in 2 months

pull request commentnodejs/node

win: allow skipping the supported platform check

@jasnell thanks, updated.

joaocgreis

comment created time in 2 months

push eventJaneaSystems/node

Owen Smith

commit sha 0413accc6b6e2b81784ab959b400236e4588b123

http: set default timeout in agent keepSocketAlive Previous location of setting the timeout would override behaviour of custom HttpAgents' keepSocketAlive. Moving it into the default keepSocketAlive allows it to interoperate with custom agents. Fixes: https://github.com/nodejs/node/issues/33111 PR-URL: https://github.com/nodejs/node/pull/33127 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

白一梓

commit sha e9518254d79645c3c060ea8d7f4898f8e12af9bb

doc: fix the spelling error in stream.md Change `64kb` to `64KB` in `stream.md` PR-URL: https://github.com/nodejs/node/pull/31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Juan José Arboleda

commit sha 26477b82a5fa1db918b4969918859d28bb0d7193

doc: clarify when not to run CI on docs Collaborators won't need to run CI on documentation-only changes. PR-URL: https://github.com/nodejs/node/pull/33101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Kevin Locke

commit sha 7c36ec38f16add6ecfc1a3514514b55c5b610434

doc: add util.types.isArrayBufferView() This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Rich Trott

commit sha 8a2c65a671f0be64493dd7605abc5c95382728d0

tools: bump remark-preset-lint-node to 1.15.0 New version of remark-preset-lint-node includes prohibited string entry accidentally removed in the last version. PR-URL: https://github.com/nodejs/node/pull/33157 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Adrian Estrada

commit sha b0aba53195530a95688c9d5f274f854fd423da5c

src: remove unused v8 Message namespace PR-URL: https://github.com/nodejs/node/pull/33180 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

himself65

commit sha 53eb264cb16f5c1815d4ccfda585b462f9fac92a

doc: fix a typo in crypto.generateKeyPairSync() PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Robert Nagy

commit sha d799c0f17921797eb61088f6740b25b70d54571e

http: simplify sending header unshifting into an empty array is the same as creating a new array. PR-URL: https://github.com/nodejs/node/pull/33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Daniele Belardi

commit sha 8f87d252fa9ff071a8edf941d431b6efd6cb9727

esm: improve commonjs hint on module not found Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/nodejs/node/pull/31906 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Robert Nagy

commit sha 36b4c569eb845635480d8d3b7f3883b125445436

doc: add missing deprecation not PR-URL: https://github.com/nodejs/node/pull/33203 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

bcoe

commit sha bde5f9baf7af4efeec1a0ea1d53b70152e23428f

test: update c8 ignore comment PR-URL: https://github.com/nodejs/node/pull/33151 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Robert Nagy

commit sha 027e1c706d25be75a790eb744835a0ebdc65452f

http: ensure client request emits close If socket creation failed then an error would be emitted on the client request object, but not 'close' nor would destroyed be set to true. PR-URL: https://github.com/nodejs/node/pull/33178 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Ruben Bridgewater

commit sha c81e5f699e80fa5c0a201ae4c34e455c99e52a20

doc: mark assert.CallTracker experimental Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33124 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Julian Duque

commit sha 39ff64756bd5bc7147236b36ee9444ceddb3e6d2

test: add tests for options.fs in fs streams PR-URL: https://github.com/nodejs/node/pull/33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Nikolai Vavilov

commit sha c17dcb32533aa007dfbf507d22c28ef3c7c11c29

doc: fix style and grammer in buffer.md PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

John Leidegren

commit sha 26f150022f9b4d4709c1d4ad450c6f9e9fce8d0e

http: fixes memory retention issue with FreeList and HTTPParser Fixes: https://github.com/nodejs/node/issues/29394 Refs: https://github.com/nodejs/node/pull/33167#issuecomment-622102450 PR-URL: https://github.com/nodejs/node/pull/33190 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Myles Borins

commit sha 1ffd182264dcf02e010aae3dc88406c2db9efcfb

doc: explicitly doc package.exports is breaking If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: https://github.com/then/is-promise/issues/20 PR-URL: https://github.com/nodejs/node/pull/33074 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Michaël Zasso

commit sha f446b2058dcfaf9d4e2f6bdfe555bc4437f41acf

2020-05-05, Version 14.2.0 (Current) Notable changes: * Track function calls with `assert.CallTracker` (experimental). https://github.com/nodejs/node/pull/31982 * Added a `groupIndentation` option to the `Console` constructor. https://github.com/nodejs/node/pull/32964 PR-URL: https://github.com/nodejs/node/pull/33232

view details

Joyee Cheung

commit sha 86fdaa745572a3bec4370ac7bd05d18e6bf64c01

src: retrieve binding data from the context Instead of passing them through the data bound to function templates, store references to them in a list embedded inside the context. This makes the function templates more context-independent, and makes it possible to embed binding data in non-main contexts. Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/33139 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Richard Lau

commit sha a22991b04461a1aa8dd6e1793f26f3b9e6eaaa27

Revert "src: add aliased-buffer-overflow abort test" This reverts commit babeb58c5286c55f00e6dfc48c0b609314bcc381. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 2 months

PR closed nodejs/node

Add cross-compilation support for Windows on Arm V8 Engine build tools windows

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Fixes https://github.com/nodejs/node/issues/32582. CC @richardlau @joaocgreis @jkunkee

This PR fixes the Windows on Arm build of Node.js by applying all the necessary command line flags and workarounds, then adds cross-compilation support for the MSVC backend of node-gyp alongside supporting changes. The way this is implemented is that host GYP targets now end with _host.exe (e.g. mksnapshot_host.exe) and actions are re-written accordingly. In addition to the standard node.sln, a special node_host.sln is also generated with the host-only targets (this because MSBuild doesn't like building solutions with projects targeted at a mix of different architectures).

Current issues

  • Declaring support for cross-compilation means that some host-only projects are generated for x64/x64 too. The current solution is to compile host tools for all architectures, which increases build time and isn't strictly necessary (although a benefit is that somebody will definitely notice if they break cross-compilation in this setup). Possible changes may be needed to remove _host.exe tools before distribution.
  • node-gyp changes will need to be contributed upstream (?) and sent back down here.
Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+109 -45

15 comments

6 changed files

richard-townsend-arm

pr closed time in 3 months

pull request commentnodejs/node

Add cross-compilation support for Windows on Arm

Landed in https://github.com/nodejs/node/compare/d093e788d18...88335512576

@richard-townsend-arm thanks for pushing this forward! The current failure building for ARM64 was caused by https://github.com/nodejs/node/commit/1d6adf7432defeb39b751a19c68335e8afb0d8ee#diff-4fa95c2da0a6e4a70f97811e38ef0ba8R1407 , the V8 update that landed while this PR was open. Do you know why that doesn't fail in V8 upstream (I believe they have ARM64 CI) and how to fix that here?

richard-townsend-arm

comment created time in 3 months

push eventnodejs/node

Richard Townsend

commit sha 66807e995de9a16b1cfe035f76958a178c381854

tools,gyp: add support for MSVC cross-compilation This change means that GYP can now generate two sets of projects: one exclusively for a host x64 machine and one containing a mix of x64 and Arm targets. The names of host targets are fixed up to end with _host.exe, and any actions involving them are fixed up. This allows compilation of Node on an x64 server for a Windows on Arm target. PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>

view details

Richard Townsend

commit sha 883355125766e35126006507d1d8a09c149fc71d

build,win: add support for MSVC cross-compilation * Fixes cases in icutools where commands were issued without .exe * Changes to build scripts * Add /fp:strict flag so that MSVC's floating point behaves correctly * Enables marmasm PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>

view details

push time in 3 months

pull request commentnodejs/node

Add cross-compilation support for Windows on Arm

Rebased to get a fresh CI run (e71e4d365ba to 87f33894d13).

@richard-townsend-arm if this passes CI, I'll land this PR, as the new failure happens only on ARM64.

richard-townsend-arm

comment created time in 3 months

push eventrichard-townsend-arm/node

Jiawen Geng

commit sha 4ad26923f480197b16c11e8b7a493ed81b1326d5

src: refactor Reallocate since it introduced in upstream v8 PR-URL: https://github.com/nodejs/node/pull/33402 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Alba Mendez

commit sha 1dafaf03cb35d51562193afab6e903a10a89d906

tls: fix --tls-keylog option There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because `keylog` events are not emitted on tls.Server, not the socket. This behaviour is counterintuitive and has caused more bugs in the past, so make all sockets (server or client) emit 'keylog'. tls.Server will just re-emit these events. Refs: https://github.com/nodejs/node/pull/30055 PR-URL: https://github.com/nodejs/node/pull/33366 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

James M Snell

commit sha 241ed44a0b06db45c97681c164fc1098e7c9f0d2

src: small modification to NgHeader This is separated out of the QUIC PR. It is not specific to QUIC but provides a new base class that is used there as an abstraction of the actual implementation. This is a purely internal implementation detail that has no outward functional changes (so no need for tests) Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33289 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Gus Caplan

commit sha 5ae5262f448295e314393dad4c491259793cea3f

src: add support for TLA PR-URL: https://github.com/nodejs/node/pull/30370 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

unknown

commit sha 47804933012841f2dc90626bdcc161adf34569a5

doc: add examples for implementing ESM Fixes: https://github.com/nodejs/node/issues/28060 PR-URL: https://github.com/nodejs/node/pull/33168 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>

view details

Ruben Bridgewater

commit sha 80913e655fef0950be61b5fb97261956f9d2c5bb

repl: improve repl preview This aligns the REPL preview with the one used in the Chrome DevTools console. It will now preview the output for the input including the completion suffix as input. When pressing enter while previewing such data, it will automatically insert the suffix before evaluating the input. When pressing escape, that behavior is deactivated until the input is changed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Ruben Bridgewater

commit sha b38d26a1685630eaf0a2aa2a933934e80f0a3f57

repl: show reference errors during preview This aligns the behavior with the one in the Firefox console. It will visualize ReferenceErrors in case the input has no possible completion and no buffered input. That way typos can already be highlighted before being evaluated. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Ruben Bridgewater

commit sha 900daedbfeae1d412c06833379357c9b7c641a71

repl: replace hard coded core module list with actual list This replaces the internally used hard coded Node.js core module list with the actual internal existent modules. That way all modules are automatically picked up instead of having to update the list manually. This currently only applies to the REPL and to the Node.js `eval` functionality (User passed `-e` or `--eval` arguments to Node without `-i` or `--interactive`). Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Ruben Bridgewater

commit sha 4fa7d6e4c4be096b248f00a4d8435027a6e8fda1

test: refactor test/parallel/test-bootstrap-modules.js This simplifies the test a bit by removing duplicated code and by focusing the reader on the passed through module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Ruben Bridgewater

commit sha 50ba066921a2bfee743617f58d42eaeea02d0fca

repl: improve repl autocompletion for require calls This improves the autocompletion for require calls. It had multiple small issues so far. Most important: it won't suggest completions for require statements that are fully written out. Second, it'll detect require calls that have whitespace behind the opening bracket. Third, it makes sure node modules are detected as such instead of only suggesting them as folders. Last, it adds suggestions for input that starts with backticks. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33282 Fixes: https://github.com/nodejs/node/issues/33238 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Ruben Bridgewater

commit sha 24bf1adacc61a96111ae3ad06afba6f9b7f435a7

module: do not check circular dependencies for exported proxies In case the exported module is a proxy that has the `getPrototypeOf` or `setPrototypeOf` trap, skip the circular dependencies check. It would otherwise be triggered by the check itself. Fixes: https://github.com/nodejs/node/issues/33334 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Matteo Collina

commit sha 2d5d77306f6dff9110c1f77fefab25f973415770

Revert "vm: add importModuleDynamically option to compileFunction" This reverts commit 74c393dd93cc0e461e3796fbcc09545fcacdecaf. Fixes: https://github.com/nodejs/node/issues/33166 PR-URL: https://github.com/nodejs/node/pull/33364 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha 23a61eb683bcfb147ca1040e36c70fe366452a77

test: fix test-dns-idna2008 The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: https://github.com/nodejs/node/pull/33367 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Chris Holland

commit sha 441e703b2851be4c0f924907ff3c20cc4bab8588

doc: enhance guides by fixing and making grammar more consistent PR-URL: https://github.com/nodejs/node/pull/33152 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha e9f293750760d59243020d0376edf242c9a26b67

fs: clean up Dir.read() uv_fs_t data before calling into JS A call into JS can schedule another operation on the same `uv_dir_t`. In particular, when the handle is closed from the callback for a directory read operation, there previously was a race condition window: 1. A `dir.read()` operation is submitted to libuv 2. The read operation is finished by libuv, calling `AfterDirRead()` 3. We call into JS 4. JS calls dir.close() 5. libuv posts the close request to a thread in the pool 6. The close request runs, destroying the directory handle 7. `AfterDirRead()` is being exited. Exiting the `FSReqAfterScope` in step 7 attempts to destroy the original uv_fs_t` from step 1, which now points to an `uv_dir_t` that has already been destroyed in step 5. By forcing the `FSReqAfterScope` to clean up before we call into JS, we can be sure that no other operations on the same `uv_dir_t` are submitted concurrently. This addresses issues observed when running with ASAN/valgrind. PR-URL: https://github.com/nodejs/node/pull/33274 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha d3a8a23089af06bb047bf9bad7531fbfc70f6314

fs: forbid concurrent operations on Dir handle libuv does not expect concurrent operations on `uv_dir_t` instances, and will gladly create memory leaks, corrupt data, or crash the process. This patch forbids that, and: - Makes sure that concurrent async operations are run sequentially - Throws an exception if sync operations are attempted during an async operation The assumption here is that a thrown exception is preferable to a potential hard crash. This fully fixes flakiness from `parallel/test-fs-opendir` when run under ASAN. PR-URL: https://github.com/nodejs/node/pull/33274 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha c7eeef568ce5a3714b89689160ec85c017527364

cli: add `--trace-atomics-wait` flag Adds a flag that helps with debugging deadlocks due to incorrectly implemented `Atomics.wait()` calls. PR-URL: https://github.com/nodejs/node/pull/33292 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Anna Henningsen

commit sha dd0980ecc287537a48cd5d6f7f803cd8c681dbdb

worker: call CancelTerminateExecution() before exiting Locker As the comment indicates, this fixes a DCHECK failure, although I don’t quite understand why it is happening in the first place. PR-URL: https://github.com/nodejs/node/pull/33347 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha fe4e4ddc718a359b97f3fc89e5ff44625dcd6e7d

async_hooks: clear async_id_stack for terminations in more places Termination exceptions are similar to uncaught exceptions in that they should clear the async id stack, because no ongoing async callbacks will be brought to completion when execution terminates. Previously, there was a check that made sure that that happened when the termination occurred during the callback itself, but no such check was in place for the case that the termination occurred during microtasks started by them. This commit adds such a check, both for microtasks and the `nextTick` queue. The latter addition doesn’t fix a crash, but still makes sense conceptually. The condition here is also flipped from applying only on Worker threads to also applying on the main thread, and setting the `failed_` flag rather than reading it. The former makes sense because the public C++ `Stop(env)` API can have the same effect as worker thread termination, but on the main thread rather than a Worker thread. PR-URL: https://github.com/nodejs/node/pull/33347 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha e65d189e508056e9ce16377bcc42dc02a64e46c6

test: regression tests for async_hooks + Promise + Worker interaction Add regression tests for the case in which an async_hook is enabled inside a Worker thread and `process.exit()` is called during the async part of an async function. This commit includes multiple tests that seem like they should all crash in a similar way, but interestingly don’t. In particular, it’s surprising that the presence of a statement after `process.exit()` in a function has an effect on the kind of crash that’s being exhibited (V8 DCHECK vs. assertion in our own code) and the circumstances under which it crashes (e.g. the -1 and -2 tests can be “fixed” by reverting 13c5a1629cd025b, although they should have the same behavior as the -3 and -4 tests). PR-URL: https://github.com/nodejs/node/pull/33347 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in 3 months

issue commentmicrosoftarchive/redis

Announcing Memurai Enterprise and Memurai Developer!

Very happy to see Memurai moving forward! This is great news for development on Windows.

rushvel

comment created time in 3 months

issue commentnodejs/node-v8

Compiler error with VS2017

Ran https://ci.nodejs.org/job/node-test-binary-windows-native-suites/3232/ with the binaries that succeeded building in the job above. This does not include VS2017 because of the mix we use but includes VS2015 and it passed. So, this is probably not an issue for building native modules, only Node itself.

We'll have to see if this can be worked around with a simple patch, if not, dropping VS2017 for building Node sounds reasonable.

targos

comment created time in 3 months

pull request commentnodejs/node

Add cross-compilation support for Windows on Arm

I've force pushed from c7e48545d62 to e71e4d365ba.

@richard-townsend-arm I didn't understand the change in configure, if I read it well if the host is x86 or x64 it never defaults to cross-compiling. I think this would be an issue for cross-compiling for the Raspberry Pi Linux, but apparently that job is not running at the moment in CI. I'd much rather leave the logic there as currently is and leave the line in vcbuild that it replaces.

I've rebased and added a fixup commit with my suggestion. The v8 commit is no longer necessary. Does this LGTY?

richard-townsend-arm

comment created time in 3 months

push eventrichard-townsend-arm/node

Joyee Cheung

commit sha 86fdaa745572a3bec4370ac7bd05d18e6bf64c01

src: retrieve binding data from the context Instead of passing them through the data bound to function templates, store references to them in a list embedded inside the context. This makes the function templates more context-independent, and makes it possible to embed binding data in non-main contexts. Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/33139 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Richard Lau

commit sha a22991b04461a1aa8dd6e1793f26f3b9e6eaaa27

Revert "src: add aliased-buffer-overflow abort test" This reverts commit babeb58c5286c55f00e6dfc48c0b609314bcc381. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Richard Lau

commit sha 120d7076d5462f7f664ed0c92be26541e3298a24

Revert "src: add test/abort build tasks" This reverts commit e08ac095690015a8c488e05251e05feb2acc57a0. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha 1dc006ef1990d4dcb67a9521bc643638aeba248b

src: use BaseObjectPtr in StreamReq::Dispose Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379). Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33102 Refs: https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 548439a530c797eb1be877978d5a03f1ee90bc7c

doc: doc and test URLSearchParams discrepancy The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/33037 PR-URL: https://github.com/nodejs/node/pull/33236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Michael Dawson

commit sha 3662b0c2c75b670599c363be8322064a3359e432

doc: update napi_async_init documentation Fixes: https://github.com/nodejs/node/issues/33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This changes the documentation to document what callers should do. We are doing this only in the doc in order to avoid a breaking change in N-API. We could create a new version of the method for which the parametrer is enforced as mandatory but we should only do that once async hooks is no longer experimental. In that case we could deprecate (but not remove this version of the method). Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33181 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

view details

Robert Nagy

commit sha 8607f9ec5c2a488f5df7f9eb3e5f5c7dfa0b492a

stream: make from read one at a time Currently from will eagerly buffer up items which means that errors are also eagerly encountered and items which are buffer when an error occurs will be discarded, which is inconsistent with how generators work. Fixes: https://github.com/nodejs/node/issues/29428 PR-URL: https://github.com/nodejs/node/pull/33201 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Gabriel Schulhof

commit sha e454e9b33f2a3e21d0c36a96d47cf39ce3e42d6c

n-api: add uint32 test for -1 Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for -1. Re: https://github.com/nodejs/node/issues/33117 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

James M Snell

commit sha baba42c38bbda5225e09147fe4a869fa4a4a1110

doc: add warnings about transferring Buffers and ArrayBuffer Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33252 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Andrey Pechkurov

commit sha dab51dddc8b928a67ad35e93ab2b8f6458fdb8c1

doc: remove AsyncWrap mentions from async_hooks.md AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: https://github.com/nodejs/node/pull/33249 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Andrey Pechkurov

commit sha fedb0f4d54e8e68d39f488969d074773f7f95ffb

doc: add troubleshooting guide for AsyncLocalStorage PR-URL: https://github.com/nodejs/node/pull/33248 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Tobias Nießen

commit sha c01544de1f0ed033327861d65ddb5cb94ea1fb94

wasi: prevent syscalls before start PR-URL: https://github.com/nodejs/node/pull/33235 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Simen Bekkhus

commit sha 5424f1b8443c639145fb9d8c76d6d8358a2c1fd8

doc: specify unit of time passed to `fs.utimes` PR-URL: https://github.com/nodejs/node/pull/33230 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Juan José Arboleda

commit sha 3f1e65dd7be9c55a879ec9d7190de5c7401c66e0

doc: fix md issue in src/README.md PR-URL: https://github.com/nodejs/node/pull/33224 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Pranshu Srivastava

commit sha 280c485d36badbe38f4c00126c0b9b83abf923c2

doc: add Uint8Array to `end` and `write` PR-URL: https://github.com/nodejs/node/pull/33217 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

himself65

commit sha f153081d26ea6cb699fff418151de5f469baed52

module: lazy load 'getOptionValue' in initializeLoader This enables loading this module during early bootstrapping. PR-URL: https://github.com/nodejs/node/pull/33212 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Nikolai Vavilov

commit sha dbad1b65155f2ed9b20d034a83758dc7a5c01a21

doc: update Buffer(size) documentation It returns zero-filled memory since v8.0.0. PR-URL: https://github.com/nodejs/node/pull/33198 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Karol Walasek

commit sha d6b19fd5378d53ed1180ad241b8597c4f9c550eb

doc: removed unnecessary util imports from vm examples PR-URL: https://github.com/nodejs/node/pull/33179 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

osher

commit sha d6913dc1f0ce8318b35b8a71e422f01993ad78c4

doc: mention python3-distutils dependency in BUILDING.md Ran into #30189, solved by this comment: https://github.com/nodejs/node/issues/30189#issuecomment-548250793 Refs: https://github.com/nodejs/node/issues/30189 PR-URL: https://github.com/nodejs/node/pull/33174 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

szTheory

commit sha 4d4e3c3674b4f52ce9b59fecdf1f8d5f75112d59

lib: fix grammar in internal/bootstrap/loaders.js PR-URL: https://github.com/nodejs/node/pull/33211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

push time in 3 months

issue commentnodejs/node

Adding globalAgent.maxSockets generate [RSR, ACK] at the end of communications

This reproduces on Windows 10 with Node.js 14.2.0.

kamakuba

comment created time in 3 months

issue closednodejs/node

Download problem on Node Js in version 12.16.2 LTS

  • Version : 12.16.2 LTS
  • Plateforme : Windows 7 32 bits
  • Sous - système : Windows Installer

Hello, I want to report that when I install nodejs and do what we need to do. I do everything and wait for the green bar to fill up. Suddenly, the bar fills up a bit and the status says nothing. It's normal ? Thanks for replying so quickly ;)

bug

closed time in 3 months

Ethann45140

issue commentnodejs/node

Download problem on Node Js in version 12.16.2 LTS

@Ethann45140 thanks for reporting this, but Windows 7 has reached EOL and we no longer offer support for it.

Installer issues are rarely specific to the Node.js installer. More frequently, they are caused by issues with msiexec or the specific Windows installation. You can try to uninstall any older version of Node.js you have installed before installing the new one. Make sure the install location does not exist and has no files left over from any previous installation. Try to disable any antivirus software you might have running for the duration of the installation.

I'll close this, but feel free to comment if you find anything actionable.

Ethann45140

comment created time in 3 months

pull request commentnodejs/node

Add cross-compilation support for Windows on Arm

@richard-townsend-arm I pushed to your branch to make things easier, but I can change it back to 9effddd if you prefer. I changed the first line of the commit messages to follow the Node.js rules, and moved the vcbuild and configure changes to the last commit, so the middle commit is only gyp changes. We usually do this with commits that change dependencies, so it can be easily applied elsewhere or re-floated here if needed.

This looks good and works well for me. I can build x86, x64 and arm64 in my x64 machine. However, the node_host.sln file does not have any projects, it is only the minimal solution boilerplate. All the projects are built as part of the main solution, without errors. Do we really need a separate host sln file?

richard-townsend-arm

comment created time in 3 months

push eventrichard-townsend-arm/node

Anna Henningsen

commit sha ab41b9808edadc034a4da60ab0f71e527d288892

test: move test-process-title to sequential This test can fail when run in parallel with test-process-title-cli, which also sets the process title, which is global state on Windows. Example failure (note that `foo` does not appear in test-process-title but in test-process-title-cli): not ok 1727 parallel/test-process-title --- duration_ms: 0.156 severity: fail exitcode: 1 stack: |- assert.js:103 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + 'foo' - 'd:\\a\\node\\node\\out\\Release\\node.exe' at Object.<anonymous> (d:\a\node\node\test\parallel\test-process-title.js:22:1) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) at internal/main/run_main_module.js:17:47 { generatedMessage: true, code: 'ERR_ASSERTION', actual: 'foo', expected: 'd:\\a\\node\\node\\out\\Release\\node.exe', operator: 'strictEqual' } ... (from https://github.com/nodejs/node/runs/628144750?check_suite_focus=true) PR-URL: https://github.com/nodejs/node/pull/33150 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Anna Henningsen

commit sha 4b2d95804b7c064ff94609f28f69098c8f6d4d31

deps: V8: backport e29c62b74854 Original commit message: [arraybuffer] Clean up BackingStore even if it pointer to nullptr For a zero-length BackingStore allocation, it is valid for the underlying memory to be a null pointer. However, some cleanup is still necessary, since the BackingStore may hold a reference to the allocator itself, which needs to be released when destroying the `BackingStore` instance. Change-Id: I1f168079d39e4592d2fde31fbe5f705586690e85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169646 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67420} Refs: https://github.com/v8/v8/commit/e29c62b7485462c1ce8f4129b26e7f7a4d4b193c PR-URL: https://github.com/nodejs/node/pull/33125 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Anna Henningsen

commit sha d5e1795f5320567a91da9162558dbd95804803c8

test: skip memory usage tests when ASAN is enabled Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: https://github.com/nodejs/node/pull/32776#issuecomment-620407014 PR-URL: https://github.com/nodejs/node/pull/33129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Owen Smith

commit sha 0413accc6b6e2b81784ab959b400236e4588b123

http: set default timeout in agent keepSocketAlive Previous location of setting the timeout would override behaviour of custom HttpAgents' keepSocketAlive. Moving it into the default keepSocketAlive allows it to interoperate with custom agents. Fixes: https://github.com/nodejs/node/issues/33111 PR-URL: https://github.com/nodejs/node/pull/33127 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

白一梓

commit sha e9518254d79645c3c060ea8d7f4898f8e12af9bb

doc: fix the spelling error in stream.md Change `64kb` to `64KB` in `stream.md` PR-URL: https://github.com/nodejs/node/pull/31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Juan José Arboleda

commit sha 26477b82a5fa1db918b4969918859d28bb0d7193

doc: clarify when not to run CI on docs Collaborators won't need to run CI on documentation-only changes. PR-URL: https://github.com/nodejs/node/pull/33101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Kevin Locke

commit sha 7c36ec38f16add6ecfc1a3514514b55c5b610434

doc: add util.types.isArrayBufferView() This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Rich Trott

commit sha 8a2c65a671f0be64493dd7605abc5c95382728d0

tools: bump remark-preset-lint-node to 1.15.0 New version of remark-preset-lint-node includes prohibited string entry accidentally removed in the last version. PR-URL: https://github.com/nodejs/node/pull/33157 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Adrian Estrada

commit sha b0aba53195530a95688c9d5f274f854fd423da5c

src: remove unused v8 Message namespace PR-URL: https://github.com/nodejs/node/pull/33180 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

himself65

commit sha 53eb264cb16f5c1815d4ccfda585b462f9fac92a

doc: fix a typo in crypto.generateKeyPairSync() PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Robert Nagy

commit sha d799c0f17921797eb61088f6740b25b70d54571e

http: simplify sending header unshifting into an empty array is the same as creating a new array. PR-URL: https://github.com/nodejs/node/pull/33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Daniele Belardi

commit sha 8f87d252fa9ff071a8edf941d431b6efd6cb9727

esm: improve commonjs hint on module not found Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/nodejs/node/pull/31906 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Robert Nagy

commit sha 36b4c569eb845635480d8d3b7f3883b125445436

doc: add missing deprecation not PR-URL: https://github.com/nodejs/node/pull/33203 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

bcoe

commit sha bde5f9baf7af4efeec1a0ea1d53b70152e23428f

test: update c8 ignore comment PR-URL: https://github.com/nodejs/node/pull/33151 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Robert Nagy

commit sha 027e1c706d25be75a790eb744835a0ebdc65452f

http: ensure client request emits close If socket creation failed then an error would be emitted on the client request object, but not 'close' nor would destroyed be set to true. PR-URL: https://github.com/nodejs/node/pull/33178 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Ruben Bridgewater

commit sha c81e5f699e80fa5c0a201ae4c34e455c99e52a20

doc: mark assert.CallTracker experimental Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33124 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Julian Duque

commit sha 39ff64756bd5bc7147236b36ee9444ceddb3e6d2

test: add tests for options.fs in fs streams PR-URL: https://github.com/nodejs/node/pull/33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Nikolai Vavilov

commit sha c17dcb32533aa007dfbf507d22c28ef3c7c11c29

doc: fix style and grammer in buffer.md PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

John Leidegren

commit sha 26f150022f9b4d4709c1d4ad450c6f9e9fce8d0e

http: fixes memory retention issue with FreeList and HTTPParser Fixes: https://github.com/nodejs/node/issues/29394 Refs: https://github.com/nodejs/node/pull/33167#issuecomment-622102450 PR-URL: https://github.com/nodejs/node/pull/33190 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Myles Borins

commit sha 1ffd182264dcf02e010aae3dc88406c2db9efcfb

doc: explicitly doc package.exports is breaking If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: https://github.com/then/is-promise/issues/20 PR-URL: https://github.com/nodejs/node/pull/33074 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 3 months

more