profile
viewpoint
João Reis joaocgreis @janeasystems Portugal Microsoft Node.js team 🚀✨

JaneaSystems/build 0

Better build and test infra for Node.

joaocgreis/bftools 0

A collection of tools to help programming in brainf*ck, just for fun.

joaocgreis/boxstarter 0

Repeatable, reboot resilient windows environment installations made easy using Chocolatey packages

joaocgreis/choco 0

Chocolatey - the package manager for Windows

joaocgreis/ChocolateyPackages 0

Chocolatey packages maintained by me

joaocgreis/email 0

MX server management for iojs.org (and eventually nodejs.org)

joaocgreis/get-cursor-position 0

🐾 Get the cursor's current position in your terminal.

joaocgreis/gitignore 0

A collection of useful .gitignore templates

joaocgreis/GYP 0

Generate You Projects

issue closednodejs/node-gyp

node-gyp arm64 node.lib returns HTTP code 403

<!-- Thank you for reporting an issue. The more information you can give us, the better the chance we can fix your problem.

This issue tracker is for issues with node-gyp, if you have an issue installing a specific module, please file an issue on that module's issue tracker (npm issues modulename). -->

  • Node Version: 10
  • Platform: Windows
  • Compiler: Microsoft 2019 Build tools
  • Module: https://www.npmjs.com/package/@felixrieseberg/spellchecker
  • Node-gyp: 5.0.11 and 6.0.0

First off I don't know if it's an issue with node-gyp or another repo.

Anyway it seems that something changed. We can no longer build Electron project. Older version (meaning old checkout git SHA) that used to work no compiles because of the issue.

I can see that the issue is with node.lib where it start fetching ia32, x64 and arm64 then arm64 fails with http response 403.

See below gyp verb on Windows; need to download node.lib...

The response is 403 gyp http 403 https://electronjs.org/headers/v5.0.11/win-arm64/node.lib

Please see the log below.:

<details><summary>Verbose output (from npm or node-gyp):</summary>

rebuilding native dependencies  dependencies=@felixrieseberg/spellchecker@4.0.10, cld@2.5.1, keyboard-layout@2.0.16, node-hid@0.7.9 platform=win32 arch=ia32
  • map async       taskCount=4
  • install prebuilt binary  name=node-hid version=0.7.9 platform=win32 arch=ia32
  • execute command  command='C:\Program Files (x86)\nodejs\node.exe' 'C:\projects\desktop-app\node_modules\prebuild-install\bin.js' --platform=win32 --arch=ia32 --target=5.0.11 --runtime=electron --verbose --force
                     workingDirectory=C:\projects\desktop-app\node_modules\node-hid
  • build native dependency from sources  name=node-hid
                                          version=0.7.9
                                          platform=win32
                                          arch=ia32
                                          reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information)
                                          error=prebuild-install info begin Prebuild-install version 5.3.2
    prebuild-install WARN install prebuilt binaries enforced with --force!
    prebuild-install WARN install prebuilt binaries may be out of date!
    prebuild-install info looking for cached prebuild @ C:\Users\appveyor\AppData\Roaming\npm-cache\_prebuilds\e0d68f-node-hid-v0.7.9-electron-v70-win32-ia32.tar.gz
    prebuild-install http request GET https://github.com/node-hid/node-hid/releases/download/v0.7.9/node-hid-v0.7.9-electron-v70-win32-ia32.tar.gz
    prebuild-install http 404 https://github.com/node-hid/node-hid/releases/download/v0.7.9/node-hid-v0.7.9-electron-v70-win32-ia32.tar.gz
    prebuild-install WARN install No prebuilt binaries found (target=5.0.11 runtime=electron arch=ia32 libc= platform=win32)
    
  • execute command  command='C:\Program Files (x86)\nodejs\node.exe' 'C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js' rebuild --verbose @felixrieseberg/spellchecker@4.0.10 cld@2.5.1 keyboard-layout@2.0.16 node-hid@0.7.9
                     workingDirectory=
  ⨯ cannot execute  cause=exit status 1
                    out=
    > @felixrieseberg/spellchecker@4.0.10 install C:\projects\desktop-app\node_modules\@felixrieseberg\spellchecker
    > node-gyp rebuild
    
    
    C:\projects\desktop-app\node_modules\@felixrieseberg\spellchecker>if not defined npm_config_node_gyp (node "C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild ) 
    
                    errorOut=npm info it worked if it ends with ok
    npm verb cli [ 'C:\\Program Files (x86)\\nodejs\\node.exe',
    npm verb cli   'C:\\Users\\appveyor\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js',
    npm verb cli   'rebuild',
    npm verb cli   '--verbose',
    npm verb cli   '@felixrieseberg/spellchecker@4.0.10',
    npm verb cli   'cld@2.5.1',
    npm verb cli   'keyboard-layout@2.0.16',
    npm verb cli   'node-hid@0.7.9' ]
    npm info using npm@6.12.0
    npm info using node@v10.16.0
    npm info readInstalled object
    npm verb rebuild path, id [ 'C:\\projects\\desktop-app\\node_modules\\@felixrieseberg\\spellchecker',
    npm verb rebuild   '@felixrieseberg/spellchecker@4.0.10' ]
    npm verb rebuild path, id [ 'C:\\projects\\desktop-app\\node_modules\\cld', 'cld@2.5.1' ]
    npm verb rebuild path, id [ 'C:\\projects\\desktop-app\\node_modules\\keyboard-layout',
    npm verb rebuild   'keyboard-layout@2.0.16' ]
    npm verb rebuild path, id [ 'C:\\projects\\desktop-app\\node_modules\\node-hid',
    npm verb rebuild   'node-hid@0.7.9' ]
    npm info build C:\projects\desktop-app\node_modules\@felixrieseberg\spellchecker
    npm info lifecycle @felixrieseberg/spellchecker@4.0.10~preinstall: @felixrieseberg/spellchecker@4.0.10
    npm info linkStuff @felixrieseberg/spellchecker@4.0.10
    npm verb rebuildBundles [ 'nan' ]
    npm info lifecycle @felixrieseberg/spellchecker@4.0.10~install: @felixrieseberg/spellchecker@4.0.10
    gyp info it worked if it ends with ok
    gyp verb cli [ 'C:\\Program Files (x86)\\nodejs\\node.exe',
    gyp verb cli   'C:\\Users\\appveyor\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js',
    gyp verb cli   'rebuild' ]
    gyp info using node-gyp@5.0.5
    gyp info using node@10.16.0 | win32 | ia32
    gyp verb command rebuild []
    gyp verb command clean []
    gyp verb clean removing "build" directory
    gyp verb command configure []
    gyp verb download using dist-url https://electronjs.org/headers
    gyp verb find Python Python is not set from command line or npm configuration
    gyp verb find Python Python is not set from environment variable PYTHON
    gyp verb find Python checking if "python" can be used
    gyp verb find Python - executing "python" to get executable path
    gyp verb find Python - executable path is "C:\Python27\python.exe"
    gyp verb find Python - executing "C:\Python27\python.exe" to get version
    gyp verb find Python - version is "2.7.16"
    gyp info find Python using Python version 2.7.16 found at "C:\Python27\python.exe"
    gyp verb get node dir compiling against --target node version: 5.0.11
    gyp verb command install [ '5.0.11' ]
    gyp verb download using dist-url https://electronjs.org/headers
    gyp verb install input version string "5.0.11"
    gyp verb install installing version: 5.0.11
    gyp verb install --ensure was passed, so won't reinstall if already installed
    gyp verb install version not already installed, continuing with install 5.0.11
    gyp verb ensuring nodedir is created C:\Users\appveyor\.electron-gyp\5.0.11
    gyp verb created nodedir C:\Users\appveyor\.electron-gyp
    gyp http GET https://electronjs.org/headers/v5.0.11/node-v5.0.11-headers.tar.gz
    gyp http 200 https://electronjs.org/headers/v5.0.11/node-v5.0.11-headers.tar.gz
    gyp verb extracted file from tarball node_headers/include/node/common.gypi
    gyp verb extracted file from tarball node_headers/include/node/config.gypi
    gyp verb extracted file from tarball node_headers/include/node/js_native_api.h
    gyp verb extracted file from tarball node_headers/include/node/js_native_api_types.h
    gyp verb extracted file from tarball node_headers/include/node/libplatform/libplatform-export.h
    gyp verb extracted file from tarball node_headers/include/node/libplatform/libplatform.h
    gyp verb extracted file from tarball node_headers/include/node/libplatform/v8-tracing.h
    gyp verb extracted file from tarball node_headers/include/node/node.h
    gyp verb extracted file from tarball node_headers/include/node/node_api.h
    gyp verb extracted file from tarball node_headers/include/node/node_api_types.h
    gyp verb extracted file from tarball node_headers/include/node/node_buffer.h
    gyp verb extracted file from tarball node_headers/include/node/node_object_wrap.h
    gyp verb extracted file from tarball node_headers/include/node/node_version.h
    gyp verb extracted file from tarball node_headers/include/node/uv/aix.h
    gyp verb extracted file from tarball node_headers/include/node/uv/android-ifaddrs.h
    gyp verb extracted file from tarball node_headers/include/node/uv/bsd.h
    gyp verb extracted file from tarball node_headers/include/node/uv/darwin.h
    gyp verb extracted file from tarball node_headers/include/node/uv/errno.h
    gyp verb extracted file from tarball node_headers/include/node/uv/linux.h
    gyp verb extracted file from tarball node_headers/include/node/uv/os390.h
    gyp verb extracted file from tarball node_headers/include/node/uv/posix.h
    gyp verb extracted file from tarball node_headers/include/node/uv/stdint-msvc2008.h
    gyp verb extracted file from tarball node_headers/include/node/uv/sunos.h
    gyp verb extracted file from tarball node_headers/include/node/uv/threadpool.h
    gyp verb extracted file from tarball node_headers/include/node/uv/tree.h
    gyp verb extracted file from tarball node_headers/include/node/uv/unix.h
    gyp verb extracted file from tarball node_headers/include/node/uv/version.h
    gyp verb extracted file from tarball node_headers/include/node/uv/win.h
    gyp verb extracted file from tarball node_headers/include/node/uv.h
    gyp verb extracted file from tarball node_headers/include/node/v8-internal.h
    gyp verb extracted file from tarball node_headers/include/node/v8-platform.h
    gyp verb extracted file from tarball node_headers/include/node/v8-profiler.h
    gyp verb extracted file from tarball node_headers/include/node/v8-testing.h
    gyp verb extracted file from tarball node_headers/include/node/v8-util.h
    gyp verb extracted file from tarball node_headers/include/node/v8-value-serializer-version.h
    gyp verb extracted file from tarball node_headers/include/node/v8-version-string.h
    gyp verb extracted file from tarball node_headers/include/node/v8-version.h
    gyp verb extracted file from tarball node_headers/include/node/v8-wasm-trap-handler-posix.h
    gyp verb extracted file from tarball node_headers/include/node/v8-wasm-trap-handler-win.h
    gyp verb extracted file from tarball node_headers/include/node/v8.h
    gyp verb extracted file from tarball node_headers/include/node/v8config.h
    gyp verb extracted file from tarball node_headers/include/node/zconf.h
    gyp verb extracted file from tarball node_headers/include/node/zlib.h
    gyp verb content checksum node-v5.0.11-headers.tar.gz 04fef9e1f7652930f3262444bb94d30f8890dbac515dde8ce969cd645f531b63
    gyp verb tarball done parsing tarball
    gyp verb on Windows; need to download `node.lib`... 
    gyp verb ia32 node.lib dir C:\Users\appveyor\.electron-gyp\5.0.11\ia32
    gyp verb ia32 node.lib url https://electronjs.org/headers/v5.0.11/win-x86/node.lib
    gyp verb x64 node.lib dir C:\Users\appveyor\.electron-gyp\5.0.11\x64
    gyp verb x64 node.lib url https://electronjs.org/headers/v5.0.11/win-x64/node.lib
    gyp verb arm64 node.lib dir C:\Users\appveyor\.electron-gyp\5.0.11\arm64
    gyp verb arm64 node.lib url https://electronjs.org/headers/v5.0.11/win-arm64/node.lib
    gyp verb check download content checksum, need to download `SHASUMS256.txt`... 
    gyp verb checksum url https://electronjs.org/headers/v5.0.11/SHASUMS256.txt
    gyp http GET https://electronjs.org/headers/v5.0.11/SHASUMS256.txt
    gyp verb streaming ia32 node.lib to: C:\Users\appveyor\.electron-gyp\5.0.11\ia32\node.lib
    gyp http GET https://electronjs.org/headers/v5.0.11/win-x86/node.lib
    gyp verb streaming x64 node.lib to: C:\Users\appveyor\.electron-gyp\5.0.11\x64\node.lib
    gyp http GET https://electronjs.org/headers/v5.0.11/win-x64/node.lib
    gyp verb streaming arm64 node.lib to: C:\Users\appveyor\.electron-gyp\5.0.11\arm64\node.lib
    gyp http GET https://electronjs.org/headers/v5.0.11/win-arm64/node.lib
    gyp http 200 https://electronjs.org/headers/v5.0.11/SHASUMS256.txt
    gyp verb checksum data {"node-v5.0.11.tar.gz":"04fef9e1f7652930f3262444bb94d30f8890dbac515dde8ce969cd645f531b63","node-v5.0.11-headers.tar.gz":"04fef9e1f7652930f3262444bb94d30f8890dbac515dde8ce969cd645f531b63","iojs-v5.0.11.tar.gz":"04fef9e1f7652930f3262444bb94d30f8890dbac515dde8ce969cd645f531b63","iojs-v5.0.11-headers.tar.gz":"04fef9e1f7652930f3262444bb94d30f8890dbac515dde8ce969cd645f531b63","node.lib":"57862b2cdbab4bf0a47d831d3b59179b9a9411d8dc5fdb62fac26c80a6e2dd74","x64/node.lib":"76a2aade3db44e331af54aeac451a39a998324d9b7a2dcf2685707b58983abd2","win-x86/iojs.lib":"57862b2cdbab4bf0a47d831d3b59179b9a9411d8dc5fdb62fac26c80a6e2dd74","win-x64/iojs.lib":"76a2aade3db44e331af54aeac451a39a998324d9b7a2dcf2685707b58983abd2","win-x86/node.lib":"57862b2cdbab4bf0a47d831d3b59179b9a9411d8dc5fdb62fac26c80a6e2dd74","win-x64/node.lib":"76a2aade3db44e331af54aeac451a39a998324d9b7a2dcf2685707b58983abd2"}
    gyp http 403 https://electronjs.org/headers/v5.0.11/win-arm64/node.lib
    gyp WARN install got an error, rolling back install
    gyp verb command remove [ '5.0.11' ]
    gyp verb remove using node-gyp dir: C:\Users\appveyor\.electron-gyp
    gyp verb remove removing target version: 5.0.11
    gyp verb remove removing development files for version: 5.0.11
    gyp http 200 https://electronjs.org/headers/v5.0.11/win-x86/node.lib
    gyp ERR! configure error 
    gyp ERR! stack Error: 403 status code downloading arm64 node.lib
    gyp ERR! stack     at Request.<anonymous> (C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\install.js:335:22)
    gyp ERR! stack     at Request.emit (events.js:203:15)
    gyp ERR! stack     at Request.onRequestResponse (C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\request\request.js:1066:10)
    gyp ERR! stack     at ClientRequest.emit (events.js:198:13)
    gyp ERR! stack     at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:556:21)
    gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
    gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:442:20)
    gyp ERR! stack     at TLSSocket.emit (events.js:198:13)
    gyp ERR! stack     at addChunk (_stream_readable.js:288:12)
    gyp ERR! stack     at readableAddChunk (_stream_readable.js:269:11)
    gyp ERR! System Windows_NT 6.3.9600
    gyp ERR! command "C:\\Program Files (x86)\\nodejs\\node.exe" "C:\\Users\\appveyor\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
    gyp ERR! cwd C:\projects\desktop-app\node_modules\@felixrieseberg\spellchecker
    gyp ERR! node -v v10.16.0
    gyp ERR! node-gyp -v v5.0.5
    gyp ERR! not ok 
    npm verb lifecycle @felixrieseberg/spellchecker@4.0.10~install: unsafe-perm in lifecycle true
    npm verb lifecycle @felixrieseberg/spellchecker@4.0.10~install: PATH: C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\projects\desktop-app\node_modules\@felixrieseberg\spellchecker\node_modules\.bin;C:\projects\desktop-app\node_modules\.bin;C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\projects\desktop-app\node_modules\.bin;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Perl\site\bin;C:\Perl\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program Files\7-Zip;C:\Program Files\Microsoft\Web Platform Installer\;C:\Tools\GitVersion;C:\Tools\PsTools;C:\Program Files\Git LFS;C:\Program Files (x86)\Subversion\bin;C:\Program Files\Microsoft SQL Server\120\Tools\Binn\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\110\Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\;C:\Program Files\Microsoft SQL Server\120\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\ManagementStudio\;C:\Tools\WebDriver;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.4\;C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\PrivateAssemblies\;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI\wbin;C:\Ruby193\bin;C:\Tools\NUnit\bin;C:\Tools\xUnit;C:\Tools\MSpec;C:\Tools\Coverity\bin;C:\Program Files (x86)\CMake\bin;C:\go\bin;C:\Program Files\Java\jdk1.8.0\bin;C:\Python27;C:\Program Files\nodejs;C:\Program Files (x86)\iojs;C:\Program Files\iojs;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\MSBuild\14.0\Bin;C:\Tools\NuGet;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft DNX\Dnvm;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn\;C:\Program Files (x86)\Apache\Maven\bin;C:\Python27\Scripts;C:\Tools\NUnit3;C:\Program Files\Mercurial\;C:\Program Files\dotnet\;C:\Tools\curl\bin;C:\Program Files\Amazon\AWSCLI\;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\SQLDB\DAC\140;C:\Tools\vcpkg;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn\;C:\Program Files\Microsoft SQL Server\140\Tools\Binn\;C:\Program Files\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files\erl9.2\bin;C:\Program Files (x86)\NSIS;C:\Tools\Octopus;C:\Program Files\Git\cmd;C:\Program Files\Git\usr\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\LLVM\bin;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\PowerShell\6\;C:\Program Files (x86)\nodejs\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files (x86)\Yarn\bin\;C:\ProgramData\chocolatey\bin;C:\Users\appveyor\.dotnet\tools;C:\Users\appveyor\AppData\Roaming\npm;C:\Users\appveyor\AppData\Local\Yarn\bin;C:\Program Files\AppVeyor\BuildAgent\
    npm verb lifecycle @felixrieseberg/spellchecker@4.0.10~install: CWD: C:\projects\desktop-app\node_modules\@felixrieseberg\spellchecker
    npm info lifecycle @felixrieseberg/spellchecker@4.0.10~install: Failed to exec install script
    npm verb stack Error: @felixrieseberg/spellchecker@4.0.10 install: `node-gyp rebuild`
    npm verb stack Exit status 1
    npm verb stack     at EventEmitter.<anonymous> (C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\index.js:332:16)
    npm verb stack     at EventEmitter.emit (events.js:198:13)
    npm verb stack     at ChildProcess.<anonymous> (C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
    npm verb stack     at ChildProcess.emit (events.js:198:13)
    npm verb stack     at maybeClose (internal/child_process.js:982:16)
    npm verb stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
    npm verb pkgid @felixrieseberg/spellchecker@4.0.10
    npm verb cwd C:\projects\desktop-app
    npm verb Windows_NT 6.3.9600
    npm verb argv "C:\\Program Files (x86)\\nodejs\\node.exe" "C:\\Users\\appveyor\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "rebuild" "--verbose" "@felixrieseberg/spellchecker@4.0.10" "cld@2.5.1" "keyboard-layout@2.0.16" "node-hid@0.7.9"
    npm verb node v10.16.0
    npm verb npm  v6.12.0
    npm ERR! code ELIFECYCLE
    npm ERR! errno 1
    npm ERR! @felixrieseberg/spellchecker@4.0.10 install: `node-gyp rebuild`
    npm ERR! Exit status 1
    npm ERR! 
    npm ERR! Failed at the @felixrieseberg/spellchecker@4.0.10 install script.
    npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
    npm verb exit [ 1, true ]
    npm timing npm Completed in 4471ms
    
    npm ERR! A complete log of this run can be found in:
    npm ERR!     C:\Users\appveyor\AppData\Roaming\npm-cache\_logs\2019-10-23T20_56_51_214Z-debug.log
    
                    command='C:\Program Files (x86)\nodejs\node.exe' 'C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js' rebuild --verbose @felixrieseberg/spellchecker@4.0.10 cld@2.5.1 keyboard-layout@2.0.16 node-hid@0.7.9
                    workingDir=
  • exited          command=app-builder.exe code=2 pid=2752
npm ERR! code ELIFECYCLE
npm ERR! errno 1

npm ERR! Exit status 1
npm ERR! 

npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\appveyor\AppData\Roaming\npm-cache\_logs\2019-10-23T20_56_51_302Z-debug.log
Command exited with code 1

</details>

<!-- Any further details -->

Thanks in advance

closed time in a day

Nederby

issue commentnodejs/node-gyp

node-gyp arm64 node.lib returns HTTP code 403

The only versions with this problem are 5.0.5 and 6.0.0.

If you encounter this issue please upgrade to 5.0.6 or 6.0.1, which have a fix for this.

Nederby

comment created time in a day

issue commentnodejs/node-gyp

platformio-ide-terminal failed installation on Atom

@matteogithub94 from what I can tell from that log, you need to have Visual Studio installed to compile native code included in the module.

You are using a very old version of Node.js v10 which, among other problems, doesn't support recent versions of Visual Studio and doesn't print helpful messages when errors happen finding Visual Studio. I strongly recommend updating to the latest v10: https://nodejs.org/download/release/latest-v10.x/ .

Please follow the instructions on https://github.com/nodejs/node-gyp#on-windows to install Python and Visual Studio. Note that if you don't upgrade Node.js, you have to install Python 2 instead.

matteogithub94

comment created time in 5 days

create barnchJaneaSystems/TypeScript

branch : joaocgreis-K25-fmap-test

created branch time in 13 days

issue closednodejs/build

Windows permanently-failing-in-CI hosts marked offline

To get CI working, I marked four Windows hosts as offline. They were failing CI tests consistently.

  • test-rackspace-win2008r2_vs2017-x64-1
  • test-azure_msft-win10_vs2019-x64-4
  • test-rackspace-win2012r2_vs2019-x64-2
  • test-azure_msft-win2016_vs2017-x64-3

Not sure what the right thing to do to get them back online is.

closed time in 23 days

Trott

issue commentnodejs/build

Windows permanently-failing-in-CI hosts marked offline

This was apparently caused by an old version of https://github.com/nodejs/node/pull/31505 leaving behind files that could not be removed by git clean.

The PR is now fixed, the computers clean and back online, and windows-fanned back to green.

@Trott thanks for taking the machines offline! Another thing that might or might not help but should be harmless is to run https://ci.nodejs.org/view/All/job/git-clean-windows/ and https://ci.nodejs.org/view/All/job/windows-update-reboot/ with force reboot.

Trott

comment created time in 23 days

issue commentnodejs/build

Tracking Jenkins changes

In the last Windows updates batch, I added a half-step towards tracking. Jobs are still normal jobs, but everything in the Build section is committed to https://github.com/nodejs/build/tree/master/jenkins/scripts. The Build section becomes simply

export SCRIPTS_REPO=nodejs/build
export SCRIPTS_BRANCH=master
curl -L https://raw.githubusercontent.com/${SCRIPTS_REPO}/${SCRIPTS_BRANCH}/jenkins/scripts/JOB_NAME.sh | bash -ex

This makes it simple to switch to a fork for testing, while hopefully giving some motivation to PR more permanent changes properly in the build repo. Another big advantage is reusing scripts across jobs.

The downside is that there is still much left in the job. The proposal here looks good as a step to cover the rest of the job. We won't get commit messages explaining the changes, so having both mechanisms seems like the best option for now.

We have several categories of jobs in Jenkins, and I believe we should treat them differently. For all the jobs under node-test-pull-request I don't think we should use pipelines because of the lack of a good UI. Also, it would perhaps be good to have a policy of opening an issue here for any changes made. However, some other jobs could benefit from flexibility or using pipelines. If someone had the time to work on it, the release job would be a great candidate to rewrite as a pipeline.

richardlau

comment created time in a month

issue commentnodejs/node-gyp

node-gyp ERR! stack Error: `gyp` failed with exit code: 1

Also note that weak does not seem to work with Node.js v12: https://github.com/TooTallNate/node-weak/issues/99

spartaelcid

comment created time in a month

issue commentnodejs/node-gyp

node-gyp ERR! stack Error: `gyp` failed with exit code: 1

@spartaelcid you seem to have installed npm manually, so you also need to update it:

npm install -g npm

The npm you are using now has node-gyp 3.8.0, which does not support Visual Studio 2019.

spartaelcid

comment created time in a month

issue closednodejs/node-gyp

gyp ERR! UNCAUGHT EXCEPTION

Uncaught exception while I'm trying to npm install

  • Node Version: v12.14.1

  • Platform: windows 10 - 64 bit -->

  • Module: npm install

<details><summary>Verbose output (from npm or node-gyp):</summary>

C:\Users\imiljanic\Documents\now-ui-kit>npm install --verbose
npm info it worked if it ends with ok
npm verb cli [
npm verb cli   'C:\\Program Files\\nodejs\\node.exe',
npm verb cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
npm verb cli   'install',
npm verb cli   '--verbose'
npm verb cli ]
npm info using npm@6.13.4
npm info using node@v12.14.1
npm verb npm-session cb040dd843e7c63d
npm info lifecycle now-ui-kit@1.3.0~preinstall: now-ui-kit@1.3.0
npm timing stage:loadCurrentTree Completed in 1521ms
npm timing stage:loadIdealTree:cloneCurrentTree Completed in 15ms
npm timing stage:loadIdealTree:loadShrinkwrap Completed in 190ms
npm http fetch GET 304 https://registry.npmjs.org/gulp-sass 902ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/replace-ext 186ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/chalk 200ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/node-sass 204ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/strip-ansi 334ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/gaze 351ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/ansi-styles 370ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/cross-spawn 376ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/supports-color 401ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/in-publish 389ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/async-foreach 414ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/lodash 423ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/nan 427ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/glob 438ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/node-gyp 370ms (from cache)
npm http fetch GET 200 https://registry.npmjs.org/fstream 18ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/request 279ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/npmlog 342ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/globule 303ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/true-case-path 333ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/sass-graph 349ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/lru-cache 324ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/stdout-stream 365ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/minimatch 354ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/ansi-regex 392ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/graceful-fs 363ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/nopt 227ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/aws4 321ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/tar 332ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/caseless 338ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/semver 366ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/combined-stream 364ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/aws-sign2 394ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/osenv 443ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/forever-agent 394ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/form-data 387ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/har-validator 401ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/is-typedarray 358ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/mime-types 299ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/http-signature 370ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/isstream 336ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/qs 298ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/oauth-sign 323ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/json-stringify-safe 363ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/performance-now 345ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/tunnel-agent 330ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/tough-cookie 374ms (from cache)
npm http fetch GET 200 https://registry.npmjs.org/scss-tokenizer 40ms (from cache)
npm http fetch GET 200 https://registry.npmjs.org/yargs 46ms (from cache)
npm http fetch GET 200 https://registry.npmjs.org/block-stream 53ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/console-control-strings 304ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/gauge 305ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/uuid 347ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/are-we-there-yet 317ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/set-blocking 351ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/pseudomap 311ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/yallist 336ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/readable-stream 355ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/abbrev 336ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/delayed-stream 242ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/asynckit 249ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/os-tmpdir 277ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/har-schema 343ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/assert-plus 332ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/sshpk 327ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/jsprim 345ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/ajv 391ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/psl 307ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/mime-db 332ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/punycode 335ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/js-base64 254ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/source-map 252ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/camelcase 333ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/os-locale 318ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/require-directory 323ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/cliui 367ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/get-caller-file 396ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/string-width 392ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/require-main-filename 413ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/which-module 380ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/y18n 401ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/yargs-parser 382ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/aproba 268ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/string-width 271ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/delegates 226ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/has-unicode 306ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/wide-align 305ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/object-assign 335ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/string_decoder 291ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/isarray 326ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/asn1 315ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/dashdash 346ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/safer-buffer 233ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/ecc-jsbn 236ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/getpass 370ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/jsbn 309ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/tweetnacl 303ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/bcrypt-pbkdf 322ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/extsprintf 316ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/json-schema 332ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/verror 417ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/fast-deep-equal 412ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/fast-json-stable-stringify 373ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/json-schema-traverse 363ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/uri-js 352ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/lcid 338ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/amdefine 346ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/wrap-ansi 320ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/is-fullwidth-code-point 261ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/code-point-at 277ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/is-fullwidth-code-point 156ms (from cache)
npm http fetch GET 304 https://registry.npmjs.org/invert-kv 147ms (from cache)
npm timing stage:loadIdealTree:loadAllDepsIntoIdealTree Completed in 6404ms
npm timing stage:loadIdealTree Completed in 6817ms
npm timing stage:generateActionsToTake Completed in 96ms
npm verb correctMkdir C:\Users\apc.imiljanic\AppData\Roaming\npm-cache\_locks correctMkdir not in flight; initializing
npm verb makeCacheDir UID & GID are irrelevant on win32
npm verb lock using C:\Users\apc.imiljanic\AppData\Roaming\npm-cache\_locks\staging-87fc1d4c25a3e326.lock for C:\Users\imiljanic\Documents\now-ui-kit\node_modules\.staging
npm timing audit submit Completed in 1822ms
npm http fetch POST 200 https://registry.npmjs.org/-/npm/v1/security/audits/quick 1897ms
npm timing audit body Completed in 38ms
npm timing action:extract Completed in 14707ms
npm timing action:finalize Completed in 921ms
npm timing action:refresh-package-json Completed in 2289ms
npm info lifecycle abbrev@1.1.1~preinstall: abbrev@1.1.1
npm info lifecycle amdefine@1.0.1~preinstall: amdefine@1.0.1
npm info lifecycle aproba@1.2.0~preinstall: aproba@1.2.0
npm info lifecycle isarray@1.0.0~preinstall: isarray@1.0.0
npm info lifecycle string_decoder@1.1.1~preinstall: string_decoder@1.1.1
npm info lifecycle readable-stream@2.3.7~preinstall: readable-stream@2.3.7
npm info lifecycle assert-plus@1.0.0~preinstall: assert-plus@1.0.0
npm info lifecycle async-foreach@0.1.3~preinstall: async-foreach@0.1.3
npm info lifecycle asynckit@0.4.0~preinstall: asynckit@0.4.0
npm info lifecycle aws-sign2@0.7.0~preinstall: aws-sign2@0.7.0
npm info lifecycle aws4@1.9.1~preinstall: aws4@1.9.1
npm info lifecycle block-stream@0.0.9~preinstall: block-stream@0.0.9
npm info lifecycle caseless@0.12.0~preinstall: caseless@0.12.0
npm info lifecycle code-point-at@1.1.0~preinstall: code-point-at@1.1.0
npm info lifecycle console-control-strings@1.1.0~preinstall: console-control-strings@1.1.0
npm info lifecycle dashdash@1.14.1~preinstall: dashdash@1.14.1
npm info lifecycle delayed-stream@1.0.0~preinstall: delayed-stream@1.0.0
npm info lifecycle combined-stream@1.0.8~preinstall: combined-stream@1.0.8
npm info lifecycle delegates@1.0.0~preinstall: delegates@1.0.0
npm info lifecycle are-we-there-yet@1.1.5~preinstall: are-we-there-yet@1.1.5
npm info lifecycle extsprintf@1.3.0~preinstall: extsprintf@1.3.0
npm info lifecycle fast-deep-equal@2.0.1~preinstall: fast-deep-equal@2.0.1
npm info lifecycle fast-json-stable-stringify@2.1.0~preinstall: fast-json-stable-stringify@2.1.0
npm info lifecycle forever-agent@0.6.1~preinstall: forever-agent@0.6.1
npm info lifecycle graceful-fs@4.2.3~preinstall: graceful-fs@4.2.3
npm info lifecycle fstream@1.0.12~preinstall: fstream@1.0.12
npm info lifecycle object-assign@4.1.1~preinstall: object-assign@4.1.1
npm info lifecycle get-caller-file@1.0.3~preinstall: get-caller-file@1.0.3
npm info lifecycle getpass@0.1.7~preinstall: getpass@0.1.7
npm info lifecycle ansi-regex@3.0.0~preinstall: ansi-regex@3.0.0
npm info lifecycle ansi-styles@3.2.1~preinstall: ansi-styles@3.2.1
npm info lifecycle replace-ext@1.0.0~preinstall: replace-ext@1.0.0
npm info lifecycle strip-ansi@4.0.0~preinstall: strip-ansi@4.0.0
npm info lifecycle supports-color@5.5.0~preinstall: supports-color@5.5.0
npm info lifecycle chalk@2.4.2~preinstall: chalk@2.4.2
npm info lifecycle har-schema@2.0.0~preinstall: har-schema@2.0.0
npm info lifecycle has-unicode@2.0.1~preinstall: has-unicode@2.0.1
npm info lifecycle in-publish@2.0.0~preinstall: in-publish@2.0.0
npm info lifecycle invert-kv@1.0.0~preinstall: invert-kv@1.0.0
npm info lifecycle is-fullwidth-code-point@1.0.0~preinstall: is-fullwidth-code-point@1.0.0
npm info lifecycle is-typedarray@1.0.0~preinstall: is-typedarray@1.0.0
npm info lifecycle isstream@0.1.2~preinstall: isstream@0.1.2
npm info lifecycle js-base64@2.5.1~preinstall: js-base64@2.5.1
npm info lifecycle jsbn@0.1.1~preinstall: jsbn@0.1.1
npm info lifecycle json-schema@0.2.3~preinstall: json-schema@0.2.3
npm info lifecycle json-schema-traverse@0.4.1~preinstall: json-schema-traverse@0.4.1
npm info lifecycle json-stringify-safe@5.0.1~preinstall: json-stringify-safe@5.0.1
npm info lifecycle lcid@1.0.0~preinstall: lcid@1.0.0
npm info lifecycle mime-db@1.43.0~preinstall: mime-db@1.43.0
npm info lifecycle mime-types@2.1.26~preinstall: mime-types@2.1.26
npm info lifecycle gulp-sass@4.0.2~preinstall: gulp-sass@4.0.2
npm info lifecycle node-sass@4.13.1~preinstall: node-sass@4.13.1
npm info lifecycle sass-graph@2.2.4~preinstall: sass-graph@2.2.4
npm info lifecycle yargs@7.1.0~preinstall: yargs@7.1.0
npm info lifecycle camelcase@3.0.0~preinstall: camelcase@3.0.0
npm info lifecycle yargs-parser@5.0.0~preinstall: yargs-parser@5.0.0
npm info lifecycle camelcase@3.0.0~preinstall: camelcase@3.0.0
npm info lifecycle cross-spawn@3.0.1~preinstall: cross-spawn@3.0.1
npm info lifecycle lru-cache@4.1.5~preinstall: lru-cache@4.1.5
npm info lifecycle yallist@2.1.2~preinstall: yallist@2.1.2
npm info lifecycle y18n@3.2.1~preinstall: y18n@3.2.1
npm info lifecycle cliui@3.2.0~preinstall: cliui@3.2.0
npm info lifecycle wrap-ansi@2.1.0~preinstall: wrap-ansi@2.1.0
npm info lifecycle node-gyp@3.8.0~preinstall: node-gyp@3.8.0
npm info lifecycle npmlog@4.1.2~preinstall: npmlog@4.1.2
npm info lifecycle gauge@2.7.4~preinstall: gauge@2.7.4
npm info lifecycle wide-align@1.1.3~preinstall: wide-align@1.1.3
npm info lifecycle which-module@1.0.0~preinstall: which-module@1.0.0
npm info lifecycle request@2.88.0~preinstall: request@2.88.0
npm info lifecycle http-signature@1.2.0~preinstall: http-signature@1.2.0
npm info lifecycle jsprim@1.4.1~preinstall: jsprim@1.4.1
npm info lifecycle verror@1.10.0~preinstall: verror@1.10.0
npm info lifecycle uuid@3.3.3~preinstall: uuid@3.3.3
npm info lifecycle har-validator@5.1.3~preinstall: har-validator@5.1.3
npm info lifecycle ajv@6.10.2~preinstall: ajv@6.10.2
npm info lifecycle uri-js@4.2.2~preinstall: uri-js@4.2.2
npm info lifecycle sshpk@1.16.1~preinstall: sshpk@1.16.1
npm info lifecycle bcrypt-pbkdf@1.0.2~preinstall: bcrypt-pbkdf@1.0.2
npm info lifecycle tweetnacl@0.14.5~preinstall: tweetnacl@0.14.5
npm info lifecycle tunnel-agent@0.6.0~preinstall: tunnel-agent@0.6.0
npm info lifecycle true-case-path@1.0.3~preinstall: true-case-path@1.0.3
npm info lifecycle glob@7.1.6~preinstall: glob@7.1.6
npm info lifecycle minimatch@3.0.4~preinstall: minimatch@3.0.4
npm info lifecycle tough-cookie@2.4.3~preinstall: tough-cookie@2.4.3
npm info lifecycle punycode@1.4.1~preinstall: punycode@1.4.1
npm info lifecycle tar@2.2.2~preinstall: tar@2.2.2
npm info lifecycle string-width@1.0.2~preinstall: string-width@1.0.2
npm info lifecycle stdout-stream@1.4.1~preinstall: stdout-stream@1.4.1
npm info lifecycle readable-stream@2.3.7~preinstall: readable-stream@2.3.7
npm info lifecycle string_decoder@1.1.1~preinstall: string_decoder@1.1.1
npm info lifecycle isarray@1.0.0~preinstall: isarray@1.0.0
npm info lifecycle set-blocking@2.0.0~preinstall: set-blocking@2.0.0
npm info lifecycle scss-tokenizer@0.2.3~preinstall: scss-tokenizer@0.2.3
npm info lifecycle source-map@0.4.4~preinstall: source-map@0.4.4
npm info lifecycle glob@7.1.6~preinstall: glob@7.1.6
npm info lifecycle minimatch@3.0.4~preinstall: minimatch@3.0.4
npm info lifecycle lodash@4.17.15~preinstall: lodash@4.17.15
npm info lifecycle ecc-jsbn@0.1.2~preinstall: ecc-jsbn@0.1.2
npm info lifecycle asn1@0.2.4~preinstall: asn1@0.2.4
npm info lifecycle safer-buffer@2.1.2~preinstall: safer-buffer@2.1.2
npm info lifecycle require-main-filename@1.0.1~preinstall: require-main-filename@1.0.1
npm info lifecycle require-directory@2.1.1~preinstall: require-directory@2.1.1
npm info lifecycle qs@6.5.2~preinstall: qs@6.5.2
npm info lifecycle punycode@2.1.1~preinstall: punycode@2.1.1
npm info lifecycle psl@1.7.0~preinstall: psl@1.7.0
npm info lifecycle pseudomap@1.0.2~preinstall: pseudomap@1.0.2
npm info lifecycle performance-now@2.1.0~preinstall: performance-now@2.1.0
npm info lifecycle osenv@0.1.5~preinstall: osenv@0.1.5
npm info lifecycle os-tmpdir@1.0.2~preinstall: os-tmpdir@1.0.2
npm info lifecycle os-locale@1.4.0~preinstall: os-locale@1.4.0
npm info lifecycle oauth-sign@0.9.0~preinstall: oauth-sign@0.9.0
npm info lifecycle nopt@3.0.6~preinstall: nopt@3.0.6
npm info lifecycle gaze@1.1.3~preinstall: gaze@1.1.3
npm info lifecycle globule@1.3.0~preinstall: globule@1.3.0
npm info lifecycle glob@7.1.6~preinstall: glob@7.1.6
npm info lifecycle minimatch@3.0.4~preinstall: minimatch@3.0.4
npm info lifecycle lodash@4.17.15~preinstall: lodash@4.17.15
npm info lifecycle semver@5.3.0~preinstall: semver@5.3.0
npm info lifecycle glob@7.1.6~preinstall: glob@7.1.6
npm info lifecycle minimatch@3.0.4~preinstall: minimatch@3.0.4
npm info lifecycle graceful-fs@4.2.3~preinstall: graceful-fs@4.2.3
npm info lifecycle nan@2.14.0~preinstall: nan@2.14.0
npm info lifecycle form-data@2.3.3~preinstall: form-data@2.3.3
npm timing action:preinstall Completed in 1143ms
npm info linkStuff abbrev@1.1.1
npm info linkStuff amdefine@1.0.1
npm info linkStuff aproba@1.2.0
npm info linkStuff isarray@1.0.0
npm info linkStuff string_decoder@1.1.1
npm info linkStuff readable-stream@2.3.7
npm info linkStuff assert-plus@1.0.0
npm info linkStuff async-foreach@0.1.3
npm info linkStuff asynckit@0.4.0
npm info linkStuff aws-sign2@0.7.0
npm info linkStuff aws4@1.9.1
npm info linkStuff block-stream@0.0.9
npm info linkStuff caseless@0.12.0
npm info linkStuff code-point-at@1.1.0
npm info linkStuff console-control-strings@1.1.0
npm info linkStuff dashdash@1.14.1
npm info linkStuff delayed-stream@1.0.0
npm info linkStuff combined-stream@1.0.8
npm info linkStuff delegates@1.0.0
npm info linkStuff are-we-there-yet@1.1.5
npm info linkStuff extsprintf@1.3.0
npm info linkStuff fast-deep-equal@2.0.1
npm info linkStuff fast-json-stable-stringify@2.1.0
npm info linkStuff forever-agent@0.6.1
npm info linkStuff graceful-fs@4.2.3
npm info linkStuff fstream@1.0.12
npm info linkStuff object-assign@4.1.1
npm info linkStuff get-caller-file@1.0.3
npm info linkStuff getpass@0.1.7
npm info linkStuff ansi-regex@3.0.0
npm info linkStuff ansi-styles@3.2.1
npm info linkStuff replace-ext@1.0.0
npm info linkStuff strip-ansi@4.0.0
npm info linkStuff supports-color@5.5.0
npm info linkStuff chalk@2.4.2
npm info linkStuff har-schema@2.0.0
npm info linkStuff has-unicode@2.0.1
npm info linkStuff in-publish@2.0.0
npm verb linkBins [
npm verb linkBins   {
npm verb linkBins     'in-publish': 'in-publish.js',
npm verb linkBins     'in-install': 'in-install.js',
npm verb linkBins     'not-in-publish': 'not-in-publish.js',
npm verb linkBins     'not-in-install': 'not-in-install.js'
npm verb linkBins   },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff invert-kv@1.0.0
npm info linkStuff is-fullwidth-code-point@1.0.0
npm info linkStuff is-typedarray@1.0.0
npm info linkStuff isstream@0.1.2
npm info linkStuff js-base64@2.5.1
npm info linkStuff jsbn@0.1.1
npm info linkStuff json-schema@0.2.3
npm info linkStuff json-schema-traverse@0.4.1
npm info linkStuff json-stringify-safe@5.0.1
npm info linkStuff lcid@1.0.0
npm info linkStuff mime-db@1.43.0
npm info linkStuff mime-types@2.1.26
npm info linkStuff form-data@2.3.3
npm info linkStuff nan@2.14.0
npm info linkStuff graceful-fs@4.2.3
npm info linkStuff minimatch@3.0.4
npm info linkStuff glob@7.1.6
npm info linkStuff semver@5.3.0
npm verb linkBins [
npm verb linkBins   { semver: 'bin/semver' },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-gyp\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff lodash@4.17.15
npm info linkStuff minimatch@3.0.4
npm info linkStuff glob@7.1.6
npm info linkStuff globule@1.3.0
npm info linkStuff gaze@1.1.3
npm info linkStuff nopt@3.0.6
npm verb linkBins [
npm verb linkBins   { nopt: 'bin/nopt.js' },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff oauth-sign@0.9.0
npm info linkStuff os-locale@1.4.0
npm info linkStuff os-tmpdir@1.0.2
npm info linkStuff osenv@0.1.5
npm info linkStuff performance-now@2.1.0
npm info linkStuff pseudomap@1.0.2
npm info linkStuff psl@1.7.0
npm info linkStuff punycode@2.1.1
npm info linkStuff qs@6.5.2
npm info linkStuff require-directory@2.1.1
npm info linkStuff require-main-filename@1.0.1
npm info linkStuff safer-buffer@2.1.2
npm info linkStuff asn1@0.2.4
npm info linkStuff ecc-jsbn@0.1.2
npm info linkStuff lodash@4.17.15
npm info linkStuff minimatch@3.0.4
npm info linkStuff glob@7.1.6
npm info linkStuff source-map@0.4.4
npm info linkStuff scss-tokenizer@0.2.3
npm info linkStuff set-blocking@2.0.0
npm info linkStuff isarray@1.0.0
npm info linkStuff string_decoder@1.1.1
npm info linkStuff readable-stream@2.3.7
npm info linkStuff stdout-stream@1.4.1
npm info linkStuff string-width@1.0.2
npm info linkStuff tar@2.2.2
npm info linkStuff punycode@1.4.1
npm info linkStuff tough-cookie@2.4.3
npm info linkStuff minimatch@3.0.4
npm info linkStuff glob@7.1.6
npm info linkStuff true-case-path@1.0.3
npm info linkStuff tunnel-agent@0.6.0
npm info linkStuff tweetnacl@0.14.5
npm info linkStuff bcrypt-pbkdf@1.0.2
npm info linkStuff sshpk@1.16.1
npm verb linkBins [
npm verb linkBins   {
npm verb linkBins     'sshpk-conv': 'bin/sshpk-conv',
npm verb linkBins     'sshpk-sign': 'bin/sshpk-sign',
npm verb linkBins     'sshpk-verify': 'bin/sshpk-verify'
npm verb linkBins   },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff uri-js@4.2.2
npm info linkStuff ajv@6.10.2
npm info linkStuff har-validator@5.1.3
npm info linkStuff uuid@3.3.3
npm verb linkBins [
npm verb linkBins   { uuid: 'bin/uuid' },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff verror@1.10.0
npm info linkStuff jsprim@1.4.1
npm info linkStuff http-signature@1.2.0
npm info linkStuff request@2.88.0
npm info linkStuff which-module@1.0.0
npm info linkStuff wide-align@1.1.3
npm info linkStuff gauge@2.7.4
npm info linkStuff npmlog@4.1.2
npm info linkStuff node-gyp@3.8.0
npm verb linkBins [
npm verb linkBins   { 'node-gyp': 'bin/node-gyp.js' },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff wrap-ansi@2.1.0
npm info linkStuff cliui@3.2.0
npm info linkStuff y18n@3.2.1
npm info linkStuff yallist@2.1.2
npm info linkStuff lru-cache@4.1.5
npm info linkStuff cross-spawn@3.0.1
npm info linkStuff camelcase@3.0.0
npm info linkStuff yargs-parser@5.0.0
npm info linkStuff camelcase@3.0.0
npm info linkStuff yargs@7.1.0
npm info linkStuff sass-graph@2.2.4
npm verb linkBins [
npm verb linkBins   { sassgraph: 'bin/sassgraph' },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff node-sass@4.13.1
npm verb linkBins [
npm verb linkBins   { 'node-sass': 'bin/node-sass' },
npm verb linkBins   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\.bin',
npm verb linkBins   false
npm verb linkBins ]
npm info linkStuff gulp-sass@4.0.2
npm timing action:build Completed in 1285ms
npm info lifecycle abbrev@1.1.1~install: abbrev@1.1.1
npm info lifecycle amdefine@1.0.1~install: amdefine@1.0.1
npm info lifecycle aproba@1.2.0~install: aproba@1.2.0
npm info lifecycle isarray@1.0.0~install: isarray@1.0.0
npm info lifecycle string_decoder@1.1.1~install: string_decoder@1.1.1
npm info lifecycle readable-stream@2.3.7~install: readable-stream@2.3.7
npm info lifecycle assert-plus@1.0.0~install: assert-plus@1.0.0
npm info lifecycle async-foreach@0.1.3~install: async-foreach@0.1.3
npm info lifecycle asynckit@0.4.0~install: asynckit@0.4.0
npm info lifecycle aws-sign2@0.7.0~install: aws-sign2@0.7.0
npm info lifecycle aws4@1.9.1~install: aws4@1.9.1
npm info lifecycle block-stream@0.0.9~install: block-stream@0.0.9
npm info lifecycle caseless@0.12.0~install: caseless@0.12.0
npm info lifecycle code-point-at@1.1.0~install: code-point-at@1.1.0
npm info lifecycle console-control-strings@1.1.0~install: console-control-strings@1.1.0
npm info lifecycle dashdash@1.14.1~install: dashdash@1.14.1
npm info lifecycle delayed-stream@1.0.0~install: delayed-stream@1.0.0
npm info lifecycle combined-stream@1.0.8~install: combined-stream@1.0.8
npm info lifecycle delegates@1.0.0~install: delegates@1.0.0
npm info lifecycle are-we-there-yet@1.1.5~install: are-we-there-yet@1.1.5
npm info lifecycle extsprintf@1.3.0~install: extsprintf@1.3.0
npm info lifecycle fast-deep-equal@2.0.1~install: fast-deep-equal@2.0.1
npm info lifecycle fast-json-stable-stringify@2.1.0~install: fast-json-stable-stringify@2.1.0
npm info lifecycle forever-agent@0.6.1~install: forever-agent@0.6.1
npm info lifecycle graceful-fs@4.2.3~install: graceful-fs@4.2.3
npm info lifecycle fstream@1.0.12~install: fstream@1.0.12
npm info lifecycle object-assign@4.1.1~install: object-assign@4.1.1
npm info lifecycle get-caller-file@1.0.3~install: get-caller-file@1.0.3
npm info lifecycle getpass@0.1.7~install: getpass@0.1.7
npm info lifecycle ansi-regex@3.0.0~install: ansi-regex@3.0.0
npm info lifecycle ansi-styles@3.2.1~install: ansi-styles@3.2.1
npm info lifecycle replace-ext@1.0.0~install: replace-ext@1.0.0
npm info lifecycle strip-ansi@4.0.0~install: strip-ansi@4.0.0
npm info lifecycle supports-color@5.5.0~install: supports-color@5.5.0
npm info lifecycle chalk@2.4.2~install: chalk@2.4.2
npm info lifecycle har-schema@2.0.0~install: har-schema@2.0.0
npm info lifecycle has-unicode@2.0.1~install: has-unicode@2.0.1
npm info lifecycle in-publish@2.0.0~install: in-publish@2.0.0
npm info lifecycle invert-kv@1.0.0~install: invert-kv@1.0.0
npm info lifecycle is-fullwidth-code-point@1.0.0~install: is-fullwidth-code-point@1.0.0
npm info lifecycle is-typedarray@1.0.0~install: is-typedarray@1.0.0
npm info lifecycle isstream@0.1.2~install: isstream@0.1.2
npm info lifecycle js-base64@2.5.1~install: js-base64@2.5.1
npm info lifecycle jsbn@0.1.1~install: jsbn@0.1.1
npm info lifecycle json-schema@0.2.3~install: json-schema@0.2.3
npm info lifecycle json-schema-traverse@0.4.1~install: json-schema-traverse@0.4.1
npm info lifecycle json-stringify-safe@5.0.1~install: json-stringify-safe@5.0.1
npm info lifecycle lcid@1.0.0~install: lcid@1.0.0
npm info lifecycle mime-db@1.43.0~install: mime-db@1.43.0
npm info lifecycle mime-types@2.1.26~install: mime-types@2.1.26
npm info lifecycle form-data@2.3.3~install: form-data@2.3.3
npm info lifecycle nan@2.14.0~install: nan@2.14.0
npm info lifecycle graceful-fs@4.2.3~install: graceful-fs@4.2.3
npm info lifecycle minimatch@3.0.4~install: minimatch@3.0.4
npm info lifecycle glob@7.1.6~install: glob@7.1.6
npm info lifecycle semver@5.3.0~install: semver@5.3.0
npm info lifecycle lodash@4.17.15~install: lodash@4.17.15
npm info lifecycle minimatch@3.0.4~install: minimatch@3.0.4
npm info lifecycle glob@7.1.6~install: glob@7.1.6
npm info lifecycle globule@1.3.0~install: globule@1.3.0
npm info lifecycle gaze@1.1.3~install: gaze@1.1.3
npm info lifecycle nopt@3.0.6~install: nopt@3.0.6
npm info lifecycle oauth-sign@0.9.0~install: oauth-sign@0.9.0
npm info lifecycle os-locale@1.4.0~install: os-locale@1.4.0
npm info lifecycle os-tmpdir@1.0.2~install: os-tmpdir@1.0.2
npm info lifecycle osenv@0.1.5~install: osenv@0.1.5
npm info lifecycle performance-now@2.1.0~install: performance-now@2.1.0
npm info lifecycle pseudomap@1.0.2~install: pseudomap@1.0.2
npm info lifecycle psl@1.7.0~install: psl@1.7.0
npm info lifecycle punycode@2.1.1~install: punycode@2.1.1
npm info lifecycle qs@6.5.2~install: qs@6.5.2
npm info lifecycle require-directory@2.1.1~install: require-directory@2.1.1
npm info lifecycle require-main-filename@1.0.1~install: require-main-filename@1.0.1
npm info lifecycle safer-buffer@2.1.2~install: safer-buffer@2.1.2
npm info lifecycle asn1@0.2.4~install: asn1@0.2.4
npm info lifecycle ecc-jsbn@0.1.2~install: ecc-jsbn@0.1.2
npm info lifecycle lodash@4.17.15~install: lodash@4.17.15
npm info lifecycle minimatch@3.0.4~install: minimatch@3.0.4
npm info lifecycle glob@7.1.6~install: glob@7.1.6
npm info lifecycle source-map@0.4.4~install: source-map@0.4.4
npm info lifecycle scss-tokenizer@0.2.3~install: scss-tokenizer@0.2.3
npm info lifecycle set-blocking@2.0.0~install: set-blocking@2.0.0
npm info lifecycle isarray@1.0.0~install: isarray@1.0.0
npm info lifecycle string_decoder@1.1.1~install: string_decoder@1.1.1
npm info lifecycle readable-stream@2.3.7~install: readable-stream@2.3.7
npm info lifecycle stdout-stream@1.4.1~install: stdout-stream@1.4.1
npm info lifecycle string-width@1.0.2~install: string-width@1.0.2
npm info lifecycle tar@2.2.2~install: tar@2.2.2
npm info lifecycle punycode@1.4.1~install: punycode@1.4.1
npm info lifecycle tough-cookie@2.4.3~install: tough-cookie@2.4.3
npm info lifecycle minimatch@3.0.4~install: minimatch@3.0.4
npm info lifecycle glob@7.1.6~install: glob@7.1.6
npm info lifecycle true-case-path@1.0.3~install: true-case-path@1.0.3
npm info lifecycle tunnel-agent@0.6.0~install: tunnel-agent@0.6.0
npm info lifecycle tweetnacl@0.14.5~install: tweetnacl@0.14.5
npm info lifecycle bcrypt-pbkdf@1.0.2~install: bcrypt-pbkdf@1.0.2
npm info lifecycle sshpk@1.16.1~install: sshpk@1.16.1
npm info lifecycle uri-js@4.2.2~install: uri-js@4.2.2
npm info lifecycle ajv@6.10.2~install: ajv@6.10.2
npm info lifecycle har-validator@5.1.3~install: har-validator@5.1.3
npm info lifecycle uuid@3.3.3~install: uuid@3.3.3
npm info lifecycle verror@1.10.0~install: verror@1.10.0
npm info lifecycle jsprim@1.4.1~install: jsprim@1.4.1
npm info lifecycle http-signature@1.2.0~install: http-signature@1.2.0
npm info lifecycle request@2.88.0~install: request@2.88.0
npm info lifecycle which-module@1.0.0~install: which-module@1.0.0
npm info lifecycle wide-align@1.1.3~install: wide-align@1.1.3
npm info lifecycle gauge@2.7.4~install: gauge@2.7.4
npm info lifecycle npmlog@4.1.2~install: npmlog@4.1.2
npm info lifecycle node-gyp@3.8.0~install: node-gyp@3.8.0
npm info lifecycle wrap-ansi@2.1.0~install: wrap-ansi@2.1.0
npm info lifecycle cliui@3.2.0~install: cliui@3.2.0
npm info lifecycle y18n@3.2.1~install: y18n@3.2.1
npm info lifecycle yallist@2.1.2~install: yallist@2.1.2
npm info lifecycle lru-cache@4.1.5~install: lru-cache@4.1.5
npm info lifecycle cross-spawn@3.0.1~install: cross-spawn@3.0.1
npm info lifecycle camelcase@3.0.0~install: camelcase@3.0.0
npm info lifecycle yargs-parser@5.0.0~install: yargs-parser@5.0.0
npm info lifecycle camelcase@3.0.0~install: camelcase@3.0.0
npm info lifecycle yargs@7.1.0~install: yargs@7.1.0
npm info lifecycle sass-graph@2.2.4~install: sass-graph@2.2.4
npm info lifecycle node-sass@4.13.1~install: node-sass@4.13.1

> node-sass@4.13.1 install C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass
> node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.13.1/win32-x64-72_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v4.13.1/win32-x64-72_binding.node":

tunneling socket could not be established, statusCode=407

Hint: If github.com is not accessible in your location
      try setting a proxy via HTTP_PROXY, e.g.

      export HTTP_PROXY=http://example.com:1234

or configure npm proxy via

      npm config set proxy http://example.com:8080
npm verb lifecycle node-sass@4.13.1~install: unsafe-perm in lifecycle true
npm verb lifecycle node-sass@4.13.1~install: PATH: C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass\node_modules\.bin;C:\Users\imiljanic\Documents\now-ui-kit\node_modules\.bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program Files\PuTTY\;C:\Program Files (x86)\Yarn\bin\;C:\Program Files\nodejs\;C:\Users\apc.imiljanic\.windows-build-tools\python27\;C:\Users\apc.imiljanic\AppData\Local\Microsoft\WindowsApps;C:\Python27
npm verb lifecycle node-sass@4.13.1~install: CWD: C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass
npm info lifecycle gulp-sass@4.0.2~install: gulp-sass@4.0.2
npm timing action:install Completed in 4441ms
npm info lifecycle abbrev@1.1.1~postinstall: abbrev@1.1.1
npm info lifecycle amdefine@1.0.1~postinstall: amdefine@1.0.1
npm info lifecycle aproba@1.2.0~postinstall: aproba@1.2.0
npm info lifecycle isarray@1.0.0~postinstall: isarray@1.0.0
npm info lifecycle string_decoder@1.1.1~postinstall: string_decoder@1.1.1
npm info lifecycle readable-stream@2.3.7~postinstall: readable-stream@2.3.7
npm info lifecycle assert-plus@1.0.0~postinstall: assert-plus@1.0.0
npm info lifecycle async-foreach@0.1.3~postinstall: async-foreach@0.1.3
npm info lifecycle asynckit@0.4.0~postinstall: asynckit@0.4.0
npm info lifecycle aws-sign2@0.7.0~postinstall: aws-sign2@0.7.0
npm info lifecycle aws4@1.9.1~postinstall: aws4@1.9.1
npm info lifecycle block-stream@0.0.9~postinstall: block-stream@0.0.9
npm info lifecycle caseless@0.12.0~postinstall: caseless@0.12.0
npm info lifecycle code-point-at@1.1.0~postinstall: code-point-at@1.1.0
npm info lifecycle console-control-strings@1.1.0~postinstall: console-control-strings@1.1.0
npm info lifecycle dashdash@1.14.1~postinstall: dashdash@1.14.1
npm info lifecycle delayed-stream@1.0.0~postinstall: delayed-stream@1.0.0
npm info lifecycle combined-stream@1.0.8~postinstall: combined-stream@1.0.8
npm info lifecycle delegates@1.0.0~postinstall: delegates@1.0.0
npm info lifecycle are-we-there-yet@1.1.5~postinstall: are-we-there-yet@1.1.5
npm info lifecycle extsprintf@1.3.0~postinstall: extsprintf@1.3.0
npm info lifecycle fast-deep-equal@2.0.1~postinstall: fast-deep-equal@2.0.1
npm info lifecycle fast-json-stable-stringify@2.1.0~postinstall: fast-json-stable-stringify@2.1.0
npm info lifecycle forever-agent@0.6.1~postinstall: forever-agent@0.6.1
npm info lifecycle graceful-fs@4.2.3~postinstall: graceful-fs@4.2.3
npm info lifecycle fstream@1.0.12~postinstall: fstream@1.0.12
npm info lifecycle object-assign@4.1.1~postinstall: object-assign@4.1.1
npm info lifecycle get-caller-file@1.0.3~postinstall: get-caller-file@1.0.3
npm info lifecycle getpass@0.1.7~postinstall: getpass@0.1.7
npm info lifecycle ansi-regex@3.0.0~postinstall: ansi-regex@3.0.0
npm info lifecycle ansi-styles@3.2.1~postinstall: ansi-styles@3.2.1
npm info lifecycle replace-ext@1.0.0~postinstall: replace-ext@1.0.0
npm info lifecycle strip-ansi@4.0.0~postinstall: strip-ansi@4.0.0
npm info lifecycle supports-color@5.5.0~postinstall: supports-color@5.5.0
npm info lifecycle chalk@2.4.2~postinstall: chalk@2.4.2
npm info lifecycle har-schema@2.0.0~postinstall: har-schema@2.0.0
npm info lifecycle has-unicode@2.0.1~postinstall: has-unicode@2.0.1
npm info lifecycle in-publish@2.0.0~postinstall: in-publish@2.0.0
npm info lifecycle invert-kv@1.0.0~postinstall: invert-kv@1.0.0
npm info lifecycle is-fullwidth-code-point@1.0.0~postinstall: is-fullwidth-code-point@1.0.0
npm info lifecycle is-typedarray@1.0.0~postinstall: is-typedarray@1.0.0
npm info lifecycle isstream@0.1.2~postinstall: isstream@0.1.2
npm info lifecycle js-base64@2.5.1~postinstall: js-base64@2.5.1
npm info lifecycle jsbn@0.1.1~postinstall: jsbn@0.1.1
npm info lifecycle json-schema@0.2.3~postinstall: json-schema@0.2.3
npm info lifecycle json-schema-traverse@0.4.1~postinstall: json-schema-traverse@0.4.1
npm info lifecycle json-stringify-safe@5.0.1~postinstall: json-stringify-safe@5.0.1
npm info lifecycle lcid@1.0.0~postinstall: lcid@1.0.0
npm info lifecycle mime-db@1.43.0~postinstall: mime-db@1.43.0
npm info lifecycle mime-types@2.1.26~postinstall: mime-types@2.1.26
npm info lifecycle form-data@2.3.3~postinstall: form-data@2.3.3
npm info lifecycle nan@2.14.0~postinstall: nan@2.14.0
npm info lifecycle graceful-fs@4.2.3~postinstall: graceful-fs@4.2.3
npm info lifecycle minimatch@3.0.4~postinstall: minimatch@3.0.4
npm info lifecycle glob@7.1.6~postinstall: glob@7.1.6
npm info lifecycle semver@5.3.0~postinstall: semver@5.3.0
npm info lifecycle lodash@4.17.15~postinstall: lodash@4.17.15
npm info lifecycle minimatch@3.0.4~postinstall: minimatch@3.0.4
npm info lifecycle glob@7.1.6~postinstall: glob@7.1.6
npm info lifecycle globule@1.3.0~postinstall: globule@1.3.0
npm info lifecycle gaze@1.1.3~postinstall: gaze@1.1.3
npm info lifecycle nopt@3.0.6~postinstall: nopt@3.0.6
npm info lifecycle oauth-sign@0.9.0~postinstall: oauth-sign@0.9.0
npm info lifecycle os-locale@1.4.0~postinstall: os-locale@1.4.0
npm info lifecycle os-tmpdir@1.0.2~postinstall: os-tmpdir@1.0.2
npm info lifecycle osenv@0.1.5~postinstall: osenv@0.1.5
npm info lifecycle performance-now@2.1.0~postinstall: performance-now@2.1.0
npm info lifecycle pseudomap@1.0.2~postinstall: pseudomap@1.0.2
npm info lifecycle psl@1.7.0~postinstall: psl@1.7.0
npm info lifecycle punycode@2.1.1~postinstall: punycode@2.1.1
npm info lifecycle qs@6.5.2~postinstall: qs@6.5.2
npm info lifecycle require-directory@2.1.1~postinstall: require-directory@2.1.1
npm info lifecycle require-main-filename@1.0.1~postinstall: require-main-filename@1.0.1
npm info lifecycle safer-buffer@2.1.2~postinstall: safer-buffer@2.1.2
npm info lifecycle asn1@0.2.4~postinstall: asn1@0.2.4
npm info lifecycle ecc-jsbn@0.1.2~postinstall: ecc-jsbn@0.1.2
npm info lifecycle lodash@4.17.15~postinstall: lodash@4.17.15
npm info lifecycle minimatch@3.0.4~postinstall: minimatch@3.0.4
npm info lifecycle glob@7.1.6~postinstall: glob@7.1.6
npm info lifecycle source-map@0.4.4~postinstall: source-map@0.4.4
npm info lifecycle scss-tokenizer@0.2.3~postinstall: scss-tokenizer@0.2.3
npm info lifecycle set-blocking@2.0.0~postinstall: set-blocking@2.0.0
npm info lifecycle isarray@1.0.0~postinstall: isarray@1.0.0
npm info lifecycle string_decoder@1.1.1~postinstall: string_decoder@1.1.1
npm info lifecycle readable-stream@2.3.7~postinstall: readable-stream@2.3.7
npm info lifecycle stdout-stream@1.4.1~postinstall: stdout-stream@1.4.1
npm info lifecycle string-width@1.0.2~postinstall: string-width@1.0.2
npm info lifecycle tar@2.2.2~postinstall: tar@2.2.2
npm info lifecycle punycode@1.4.1~postinstall: punycode@1.4.1
npm info lifecycle tough-cookie@2.4.3~postinstall: tough-cookie@2.4.3
npm info lifecycle minimatch@3.0.4~postinstall: minimatch@3.0.4
npm info lifecycle glob@7.1.6~postinstall: glob@7.1.6
npm info lifecycle true-case-path@1.0.3~postinstall: true-case-path@1.0.3
npm info lifecycle tunnel-agent@0.6.0~postinstall: tunnel-agent@0.6.0
npm info lifecycle tweetnacl@0.14.5~postinstall: tweetnacl@0.14.5
npm info lifecycle bcrypt-pbkdf@1.0.2~postinstall: bcrypt-pbkdf@1.0.2
npm info lifecycle sshpk@1.16.1~postinstall: sshpk@1.16.1
npm info lifecycle uri-js@4.2.2~postinstall: uri-js@4.2.2
npm info lifecycle ajv@6.10.2~postinstall: ajv@6.10.2
npm info lifecycle har-validator@5.1.3~postinstall: har-validator@5.1.3
npm info lifecycle uuid@3.3.3~postinstall: uuid@3.3.3
npm info lifecycle verror@1.10.0~postinstall: verror@1.10.0
npm info lifecycle jsprim@1.4.1~postinstall: jsprim@1.4.1
npm info lifecycle http-signature@1.2.0~postinstall: http-signature@1.2.0
npm info lifecycle request@2.88.0~postinstall: request@2.88.0
npm info lifecycle which-module@1.0.0~postinstall: which-module@1.0.0
npm info lifecycle wide-align@1.1.3~postinstall: wide-align@1.1.3
npm info lifecycle gauge@2.7.4~postinstall: gauge@2.7.4
npm info lifecycle npmlog@4.1.2~postinstall: npmlog@4.1.2
npm info lifecycle node-gyp@3.8.0~postinstall: node-gyp@3.8.0
npm info lifecycle wrap-ansi@2.1.0~postinstall: wrap-ansi@2.1.0
npm info lifecycle cliui@3.2.0~postinstall: cliui@3.2.0
npm info lifecycle y18n@3.2.1~postinstall: y18n@3.2.1
npm info lifecycle yallist@2.1.2~postinstall: yallist@2.1.2
npm info lifecycle lru-cache@4.1.5~postinstall: lru-cache@4.1.5
npm info lifecycle cross-spawn@3.0.1~postinstall: cross-spawn@3.0.1
npm info lifecycle camelcase@3.0.0~postinstall: camelcase@3.0.0
npm info lifecycle yargs-parser@5.0.0~postinstall: yargs-parser@5.0.0
npm info lifecycle camelcase@3.0.0~postinstall: camelcase@3.0.0
npm info lifecycle yargs@7.1.0~postinstall: yargs@7.1.0
npm info lifecycle sass-graph@2.2.4~postinstall: sass-graph@2.2.4
npm info lifecycle node-sass@4.13.1~postinstall: node-sass@4.13.1

> node-sass@4.13.1 postinstall C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass
> node scripts/build.js

Building: C:\Program Files\nodejs\node.exe C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-gyp\bin\node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp info it worked if it ends with ok
gyp verb cli [
gyp verb cli   'C:\\Program Files\\nodejs\\node.exe',
gyp verb cli   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-gyp\\bin\\node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose',
gyp verb cli   '--libsass_ext=',
gyp verb cli   '--libsass_cflags=',
gyp verb cli   '--libsass_ldflags=',
gyp verb cli   '--libsass_library='
gyp verb cli ]
gyp info using node-gyp@3.8.0
gyp info using node@12.14.1 | win32 | x64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb check python checking for Python executable "C:\Users\apc.imiljanic\.windows-build-tools\python27\python.exe" in the PATH
gyp verb `which` succeeded C:\Users\apc.imiljanic\.windows-build-tools\python27\python.exe C:\Users\apc.imiljanic\.windows-build-tools\python27\python.exe
gyp verb check python version `C:\Users\apc.imiljanic\.windows-build-tools\python27\python.exe -c "import sys; print "2.7.17
gyp verb check python version .%s.%s" % sys.version_info[:3];"` returned: %j
gyp verb get node dir no --target version specified, falling back to host node version: 12.14.1
gyp verb command install [ '12.14.1' ]
gyp verb install input version string "12.14.1"
gyp verb install installing version: 12.14.1
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version is already installed, need to check "installVersion"
gyp verb got "installVersion" 9
gyp verb needs "installVersion" 9
gyp verb install version is good
gyp verb get node dir target node version installed: 12.14.1
gyp verb build dir attempting to create "build" dir: C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass\build
gyp verb build dir "build" dir needed to be created? C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass\build
gyp verb find vs2017 Found installation at: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
gyp verb find vs2017   - Found Microsoft.VisualStudio.Component.Windows10SDK.18362
gyp verb find vs2017   - Found Microsoft.VisualStudio.Component.VC.Tools.x86.x64
gyp verb find vs2017   - Found Microsoft.VisualStudio.VC.MSBuild.Base
gyp verb find vs2017   - Using this installation with Windows 10 SDK
gyp verb find vs2017 using installation: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
gyp verb build/config.gypi creating config file
gyp verb build/config.gypi writing out config file: C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass\build\config.gypi
gyp verb config.gypi checking for gypi file: C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass\config.gypi
gyp verb common.gypi checking for gypi file: C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass\common.gypi
gyp verb gyp gyp format was not specified; forcing "msvs"
gyp info spawn C:\Users\apc.imiljanic\.windows-build-tools\python27\python.exe
gyp info spawn args [
gyp info spawn args   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-G',
gyp info spawn args   'msvs_version=2015',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-sass\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\apc.imiljanic\\.node-gyp\\12.14.1\\include\\node\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\apc.imiljanic\\.node-gyp\\12.14.1',
gyp info spawn args   '-Dnode_gyp_dir=C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-gyp',
gyp info spawn args   '-Dnode_lib_file=C:\\Users\\apc.imiljanic\\.node-gyp\\12.14.1\\<(target_arch)\\node.lib',
gyp info spawn args   '-Dmodule_root_dir=C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-sass',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-sass\\build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp verb command build []
gyp verb build type Release
gyp verb architecture x64
gyp verb node dev dir C:\Users\apc.imiljanic\.node-gyp\12.14.1
gyp verb found first Solution file build/binding.sln
gyp verb using MSBuild: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\15.0\Bin\MSBuild.exe
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\15.0\Bin\MSBuild.exe
gyp info spawn args [
gyp info spawn args   'build/binding.sln',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64'
gyp info spawn args ]
gyp ERR! UNCAUGHT EXCEPTION
gyp ERR! stack Error: spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\15.0\Bin\MSBuild.exe ENOENT
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:264:19)
gyp ERR! stack     at onErrorNT (internal/child_process.js:456:16)
gyp ERR! stack     at processTicksAndRejections (internal/process/task_queues.js:81:21)
gyp ERR! System Windows_NT 10.0.17763
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\imiljanic\\Documents\\now-ui-kit\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass
gyp ERR! node -v v12.14.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! This is a bug in `node-gyp`.
gyp ERR! Try to update node-gyp and file an Issue if it does not help:
gyp ERR!     <https://github.com/nodejs/node-gyp/issues>
Build failed with error code: 7
npm verb lifecycle node-sass@4.13.1~postinstall: unsafe-perm in lifecycle true
npm verb lifecycle node-sass@4.13.1~postinstall: PATH: C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass\node_modules\.bin;C:\Users\imiljanic\Documents\now-ui-kit\node_modules\.bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program Files\PuTTY\;C:\Program Files (x86)\Yarn\bin\;C:\Program Files\nodejs\;C:\Users\apc.imiljanic\.windows-build-tools\python27\;C:\Users\apc.imiljanic\AppData\Local\Microsoft\WindowsApps;C:\Python27
npm verb lifecycle node-sass@4.13.1~postinstall: CWD: C:\Users\imiljanic\Documents\now-ui-kit\node_modules\node-sass
npm info lifecycle node-sass@4.13.1~postinstall: Failed to exec postinstall script
npm timing action:postinstall Completed in 9274ms
npm verb unlock done using C:\Users\apc.imiljanic\AppData\Roaming\npm-cache\_locks\staging-87fc1d4c25a3e326.lock for C:\Users\imiljanic\Documents\now-ui-kit\node_modules\.staging
npm timing stage:rollbackFailedOptional Completed in 8445ms
npm timing stage:runTopLevelLifecycles Completed in 51311ms
npm WARN now-ui-kit@1.3.0 No repository field.
npm WARN now-ui-kit@1.3.0 license should be a valid SPDX license expression

npm verb stack Error: node-sass@4.13.1 postinstall: `node scripts/build.js`
npm verb stack Exit status 1
npm verb stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\index.js:332:16)
npm verb stack     at EventEmitter.emit (events.js:223:5)
npm verb stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
npm verb stack     at ChildProcess.emit (events.js:223:5)
npm verb stack     at maybeClose (internal/child_process.js:1021:16)
npm verb stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
npm verb pkgid node-sass@4.13.1
npm verb cwd C:\Users\imiljanic\Documents\now-ui-kit
npm verb Windows_NT 10.0.17763
npm verb argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "--verbose"
npm verb node v12.14.1
npm verb npm  v6.13.4
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-sass@4.13.1 postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-sass@4.13.1 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm verb exit [ 1, true ]
npm timing npm Completed in 55916ms

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\apc.imiljanic\AppData\Roaming\npm-cache\_logs\2020-01-16T15_20_55_338Z-debug.log

</details>

Also I tried to update node.js, installed python2, python3 ( added to env variables on pc ), installed windows-build-tools, visual studio compilers, tried to run as admin... but nothing works as expected.

Also I have tried to set npm config proxy, npm config force ssl and my other. Any help about this?

Thanks, Ivan

closed time in a month

diamond95

issue commentnodejs/node-gyp

gyp ERR! UNCAUGHT EXCEPTION

This is a known issue with node-sass: https://github.com/sass/node-sass/issues/2716

This is not an issue with node-gyp, recent versions support VS2019 and this error would not happen.

You might have some luck with this workaround: https://github.com/nodejs/node-gyp/issues/1753#issuecomment-496024604

diamond95

comment created time in a month

pull request commentnodejs/node-v8

v8: include right headers in torque output

It looks like the only thing missing here is src/objects/property-descriptor-object.h.

This fixes building for me: https://github.com/JaneaSystems/node/commit/e9f7149fd9210353f407ebafcf5c12df4dc48ffc

CI: https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/33341/

bnoordhuis

comment created time in a month

create barnchJaneaSystems/node

branch : joaocgreis-K1M-canary-errors

created branch time in a month

PR closed nodejs/node-gyp

lib: ignore VS instances that cause COMExceptions

<!-- Thank you for your pull request. Please review the below requirements.

Contributor guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] npm install && npm test passes Some tests are failing, but they also fail without my change. I assume the CI system will catch actual failures.
  • [ ] tests are included <!-- Bug fixes and new features should include tests --> I see that find-visualstudio has pretty good test coverage, but I didn't see an obvious way to simulate this COM failure
  • [ ] documentation is changed or added Are there user-facing docs for find-visualstudio? I'd be happy to add a blurb about ignoring certain instances.
  • [x] commit message follows commit guidelines
Description of change

I have quite a few instances of VS installed and it looks like Find-VisualStudio.cs enumerates all of them, even when find-visualstudio.js already knows which one it wants (from the environment variable in the developer command prompt). One of them (from 15.7.2, if that's interesting) causes a COMException on the ISetupInstance2.GetPackages call. Ignoring such packages seems harmless and unblocks the rest of the run.

Note: an alternative approach would be to print a JSON blob with an empty packages list and let the caller reject it with an explicit error message.

+8 -1

4 comments

1 changed file

amcasey

pr closed time in a month

pull request commentnodejs/node-gyp

lib: ignore VS instances that cause COMExceptions

Landed in https://github.com/nodejs/node-gyp/commit/1f7e1e93b5116e727d0719dcca87ee38c18042ae

Thanks @amcasey

amcasey

comment created time in a month

push eventnodejs/node-gyp

Andrew Casey

commit sha 1f7e1e93b5116e727d0719dcca87ee38c18042ae

lib: ignore VS instances that cause COMExceptions I have quite a few instances of VS installed and it looks like Find-VisualStudio.cs enumerates all of them, even when find-visualstudio.js already knows which one it wants (from the environment variable in the developer command prompt). One of them (from 15.7.2, if that's interesting) causes a COMException on the ISetupInstance2.GetPackages call. Ignoring such packages seems harmless and unblocks the rest of the run. PR-URL: https://github.com/nodejs/node-gyp/pull/2018 Reviewed-By: João Reis <reis@janeasystems.com>

view details

push time in a month

pull request commentnodejs/node-gyp

lib: ignore VS instances that cause COMExceptions

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/174/ ✔️

The Travis failures are unrelated.

I'll land this early next week (we need to wait at least 48h).

amcasey

comment created time in a month

pull request commentnodejs/node-gyp

lib: ignore VS instances that cause COMExceptions

@amcasey thanks for opening this PR! Ideally we would print an error message mentioning the COM issue, but I'll happily take this as is.

One thing though, I fear this might make any other problem in InstanceJson extremely confusing to debug. Can you catch the COMException explicitly?

amcasey

comment created time in a month

Pull request review commentnodejs/node-gyp

gyp: sync code base with nodejs repo

 def _ConfigFullName(config_name, config_data):   return '%s|%s' % (_ConfigBaseName(config_name, platform_name), platform_name)  -def _ConfigWindowsTargetPlatformVersion(config_data):-  ver = config_data.get('msvs_windows_target_platform_version')-  if not ver or re.match(r'^\d+', ver):-    return ver-  for key in [r'HKLM\Software\Microsoft\Microsoft SDKs\Windows\%s',-              r'HKLM\Software\Wow6432Node\Microsoft\Microsoft SDKs\Windows\%s']:-    sdkdir = MSVSVersion._RegistryGetValue(key % ver, 'InstallationFolder')-    if not sdkdir:-      continue-    version = MSVSVersion._RegistryGetValue(key % ver, 'ProductVersion') or ''-    # find a matching entry in sdkdir\include-    names = sorted([x for x in os.listdir(r'%s\include' % sdkdir) \-                    if x.startswith(version)], reverse = True)-    return names[0]+def _ConfigWindowsTargetPlatformVersion(config_data, version):
def _ConfigWindowsTargetPlatformVersion(config_data, version):
  target_ver = config_data.get('msvs_windows_target_platform_version')
  if target_ver and re.match(r'^\d+', target_ver):
    return target_ver

@targos sorry for the delay getting to this. This PR always fails when using VS2017 (not only Windows 2016). I see msvs_windows_target_platform_version was renamed to msvs_windows_sdk_version. However, the semantics here changed a bit so simply renaming in lib/configure.js does not work. I suggest to bring back the old variable name with old semantics, if this passes in CI. I'm not sure how well this works outside node-gyp/node, but I don't know if that's relevant.

targos

comment created time in a month

issue closednodejs/node-gyp

gyp with Microsoft Visual Studio?

gyp verb node dev dir C:\Users\86185.node-gyp\12.13.1 gyp verb found first Solution file build/binding.sln gyp verb using MSBuild: d:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\15.0\Bin\MSBuild.exe gyp info spawn d:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\15.0\Bin\MSBuild.exe gyp info spawn args [ gyp info spawn args 'build/binding.sln', gyp info spawn args '/nologo', gyp info spawn args '/p:Configuration=Release;Platform=x64' gyp info spawn args ] gyp ERR! UNCAUGHT EXCEPTION gyp ERR! stack Error: spawn d:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\15.0\Bin\MSBuild.exe ENOENT gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:264:19) gyp ERR! stack at onErrorNT (internal/child_process.js:456:16) gyp ERR! stack at processTicksAndRejections (internal/process/task_queues.js:80:21) gyp ERR! System Windows_NT 10.0.17763 gyp ERR! command "D:\dev\nodejs\node.exe" "D:\ProjectData\github\him-vue-netty\him-vue-master\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library=" gyp ERR! cwd D:\ProjectData\github\him-vue-netty\him-vue-master\node_modules\node-sass gyp ERR! node -v v12.13.1 gyp ERR! node-gyp -v v3.8.0 gyp ERR! This is a bug in node-gyp. gyp ERR! Try to update node-gyp and file an Issue if it does not help: gyp ERR! https://github.com/nodejs/node-gyp/issues Build failed with error code: 7 npm WARN babel-loader@8.0.4 requires a peer of @babel/core@^7.0.0 but none is installed. You must install peer dependencies yourself. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules\fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! node-sass@4.9.4 postinstall: node scripts/build.js npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the node-sass@4.9.4 postinstall script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\86185\AppData\Roaming\npm-cache_logs\2020-01-08T10_58_46_421Z-debug.log

closed time in a month

jollitycn

issue commentnodejs/node-gyp

gyp with Microsoft Visual Studio?

This is a know issue with node-sass: https://github.com/sass/node-sass/issues/2716

This is not an issue with node-gyp, recent versions support VS2019 and this error would not happen.

You might have some luck with this workaround: https://github.com/nodejs/node-gyp/issues/1753#issuecomment-496024604

jollitycn

comment created time in a month

issue commentnodejs/node-gyp

node-gyp erroring on Windows

gyp ERR! node-gyp -v v3.8.0

node-gyp 3.8.0 does not support Visual Studio 2019. You need at least node-gyp 5.0.0. It's not clear to me why an old version is being used. Perhaps you have a config variable forcing yarn to use node-gyp 3.8.0.

jonhue

comment created time in a month

pull request commentnodejs/build

chore: Remove Windows 2008 for EOL

This LGTM, but needs to wait for the actual EOL date to land.

This can only land at the same time or after the machines are removed. Need to be removed from Jenkins and also from the secrets.

The core repo should also be updated, though I don't think it's urgent.

nschonni

comment created time in a month

create barnchJaneaSystems/node

branch : joaocgreis-K18-v12.14.1-npm-fmap-build

created branch time in a month

PR closed MicrosoftDocs/windows-uwp

Reviewers
Change the Node.js beginners page to recommend the Windows native installation Change sent to author assessing_(C&L) design/tech do-not-merge uwp/prod

The instructions provided on the beginners page with this change should work in any shell, including WSL.

This also includes a few small fixes, like updating the Node.js LTS version.

cc @mattwojo, let me know if this needs any change or feel free to edit!

Fixes: https://github.com/MicrosoftDocs/windows-uwp/issues/2011

+19 -20

3 comments

2 changed files

joaocgreis

pr closed time in a month

pull request commentMicrosoftDocs/windows-uwp

Change the Node.js beginners page to recommend the Windows native installation

@mattwojo I don't have access to the other PR, but I see it has already landed here including my changes. It looks great, thanks!

I'll close this PR since it would be better to open a new PR for any other change.

joaocgreis

comment created time in a month

Pull request review commentMicrosoftDocs/windows-uwp

Change the Node.js beginners page to recommend the Windows native installation

 Node.js is a JavaScript runtime primarily used for creating web applications. Pu - **Real-time apps (RTAs)**: These are web apps that enable users to receive information as soon as it's published by an author, rather than requiring that the user (or software) check a source periodically for updates. Some example RTAs include instant messaging apps or chat rooms, online multiplayer games that can be played in the browser, online collaboration docs, community storage, video conference apps, etc. - **Data streaming apps**: These are apps (or services) that send data/content as it arrives (or is created) while keeping the connection open to continue downloading further data, content, or components as needed. Some examples include video- and audio-streaming apps. - **REST APIs**: These are interfaces that provide data for someone else's web app to interact with. For example, a Calendar API service could provide dates and times for a concert venue that could be used by someone else's local events website.-- **Server-side rendered apps (SSRs)**: These web apps can run on both the client (in your browser / the front-end) and the server (the back-end) allowing pages that are dynamic to display (generate HTML for) whatever content is known and quickly grab content that is not known as it's available. These are often referred to as “isomorphic” or “universal” applications. SSRs utilize SPA methods in that they don't need to reload every time you use it. SRAs, however, offer a few benefits that may or may not be important to you, like making content on your site appear in Google search results and providing a preview image when links to your app are shared on social media like Twitter or Facebook. The potential drawback being that they require a Node.js server constantly running. In terms of examples, a social networking app that supports events that users will want to appear in search results and social media may benefit from SSR, while an email app may be fine as an SPA. You can also run server-rendered no-SPA apps, which my be something like a WordPress blog. As you can see, things can get complicated, you just need to decide what's important.+- **Server-side rendered apps (SSRs)**: These web apps can run on both the client (in your browser / the front-end) and the server (the back-end) allowing pages that are dynamic to display (generate HTML for) whatever content is known and quickly grab content that is not known as it's available. These are often referred to as “isomorphic” or “universal” applications. SSRs utilize SPA methods in that they don't need to reload every time you use it. SSRs, however, offer a few benefits that may or may not be important to you, like making content on your site appear in Google search results and providing a preview image when links to your app are shared on social media like Twitter or Facebook. The potential drawback being that they require a Node.js server constantly running. In terms of examples, a social networking app that supports events that users will want to appear in search results and social media may benefit from SSR, while an email app may be fine as an SPA. You can also run server-rendered no-SPA apps, which my be something like a WordPress blog. As you can see, things can get complicated, you just need to decide what's important. - **Command line tools**: These allow you to automate repetitive tasks and then distribute your tool across the vast Node.js ecosystem. An example of a command line tool is cURL, which stand for client URL and is used to download content from an internet URL. cURL is often used to install things like Node.js or, in our case, a Node.js version manager. - **Hardware programming**: While not quite as popular as web apps, Node.js is growing in popularity for IoT uses, such as collecting data from sensors, beacons, transmitters, motors, or anything that generates large amounts of data. Node.js can enable data collection, analyzing that data, communicating back and forth between a device and server, and taking action based on the analysis. NPM contains more than 80 packages for Arduino controllers, raspberry pi, Intel IoT Edison, various sensors, and Bluetooth devices.  ## Try using Node.js in VS Code -1. Open your Ubuntu terminal and create a new directory: `mkdir HelloNode`, then enter the directory: `cd HelloNode`+1. Open your terminal and create a new directory: `mkdir HelloNode`, then enter the directory: `cd HelloNode` -2. Create an empty JavaScript file named "app.js": `touch app.js`+2. Open the directory and empty file in VS Code: : `code .`

Thanks for reviewing! The installer downloaded from https://code.visualstudio.com/ offers an option to add to the path, which is enabled by default. So, I think this is good as is, but please let me know if I missed something.

joaocgreis

comment created time in a month

issue commentnodejs/build

Reprovision the linuxone s390x machines

@sam-github it does not work for me (other release servers work though).

AshCripps

comment created time in a month

issue closednodejs/build

Windows CI machine updates

@nodejs/build

I will change and rebuild some/most of the Windows machines we have connected to CI to add VS2019 to the matrix and better balance other versions for the current needs.

I will try to keep node-test-commit-windows-* working all the time, but expect jobs to queue for longer periods when the number of machines is reduced.

I will try to keep other jobs working as well, but please let me know if something is not working as expected.

closed time in 2 months

joaocgreis

PR closed nodejs/build

Windows Updates

This is all already in use by CI, but not yet by the release Jenkins. The release job need to be adjusted while landing this.

Notable changes:

  • VS2019 support
  • Windows now uses the VersionSelectorScript - it is a bit complex as expected, but it manages to filter for building node, building add-ons, and choose what runs where depending on what labels are available while always avoiding invalid combinations
  • Moved most scripts from CI jobs to the build repo - this allows us to reuse parts of the scripts for different jobs, gives us some history for long-term changes, and it is easy to change to a fork for testing if needed
  • Test building in debug mode
  • Test building the MSI
  • Python 3 added to all Windows machines
  • (EDIT) CMake added to all Windows machines
  • Windows moved to the main create worker playbook
  • Some documentation updates

Re-created all Windows machines to balance available versions optimizing for current master.

Refs: https://github.com/nodejs/build/issues/1996

+713 -123

5 comments

28 changed files

joaocgreis

pr closed time in 2 months

pull request commentnodejs/build

Windows Updates

Thanks!

Adapted the jobs on both Jenkins instances.

Landed in https://github.com/nodejs/build/compare/1dd97fa746c3a22a5a09ee8990aff8ed14862091...36202a24f7d19729bea1e0efb0fe7045b2c42dc6

joaocgreis

comment created time in 2 months

push eventnodejs/build

João Reis

commit sha 31c0cbca33bae52366246de0f301ba5f5dcd0c80

jenkins: add Windows to VersionSelectorScript PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 360cd75ac87cbb3d45d3cb7eea232c9d2787b86d

jenkins: add Windows scripts PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha fee9565ed771ae99e87689d9012197e496d163c0

ansible,win: disable SSLv2 and SSLv3 Following Azure security recommendations. PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 5967f5805cd03d2a971724242a82b1cdb8a24b41

ansible,win: don't install MFC and XP compat PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha ea9a1399952b7de7b775a8ab01139f17137927a3

ansible,win: add VS2019 support PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha a98e05e91c0fe2b7764e3d8c0d0549ace21e57cb

ansible,win: add clcache Specific commit and floating PRs known to work. PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 7c3aa84f03b0bc824a6d85d3ec93faaa14103e0f

ansible,win: add Python 3 PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 5e270bebac1f1f78329857be0a24cc1163ad6320

ansible,win: add CMake Refs: https://github.com/nodejs/build/issues/2097 PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 4b5c48fef79ff1ae4c9b9781385426e5d7360680

ansible,win: add update-windows playbook PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha c85f5ca2136782661eedb081fb038493f5471c42

ansible: accept 'password' shortcut PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 20ae609d7c9f2bbc0991985a7f17ebe06521d89f

ansible: move Windows to main create worker playbook PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 76e1f0bcd4ac07ef3e141916d4576fa3da13b6d5

ansible: update Windows inventory PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha ec6030fc516c760d1f8c586baa6a0c932b5f6849

doc,win: update non-ansible-configuration-notes.md PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 377783512b9cd0e330bc9e16d19a282a3e67ca10

doc,win: update Windows supported versions PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 36202a24f7d19729bea1e0efb0fe7045b2c42dc6

doc,win: update node-test-commit-matrix.md PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

push time in 2 months

Pull request review commentnodejs/node

Windows CI job update changes

 if /i "%1"=="noetw"         set noetw=1&goto arg-ok if /i "%1"=="ltcg"          set ltcg=1&goto arg-ok if /i "%1"=="licensertf"    set licensertf=1&goto arg-ok if /i "%1"=="test"          set test_args=%test_args% -J %common_test_suites%&set lint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok-:: test-ci is deprecated-if /i "%1"=="test-ci"       goto arg-ok

@bnoordhuis any reason not to use node-test-commit-windows-fanned instead? node-test-commit-windows has been forgotten for a long time, I'll archive it if there's no objection.

Note that test-ci was a no-op as removed here, running with it only compiled, did not run tests.

joaocgreis

comment created time in 2 months

issue commentnodejs/node-gyp

gyp err uncaught exception

This version should be good. Can you run with --verbose, copy all the output that appears on the console and paste it here?

germanDevguru

comment created time in 2 months

pull request commentnodejs/node-gyp

test: GitHub Actions add Windows to the testing

@cclauss isn't this similar to what happened in Travis, the VS version is more recent than the one supported by our gyp version? If this is the case, a good way to fix is to set the MSVS variables similarly to Travis: https://github.com/nodejs/node-gyp/blob/5a729e86eef11c018d40faa21be1120debe59950/.travis.yml#L106

cclauss

comment created time in 2 months

issue commentnodejs/node-gyp

gyp err uncaught exception

@germanDevguru can you run with --verbose and paste the full output?

This might actually be an issue with node-gyp. This is version 5.0.5 which supports VS2019 and checks that MSBuild is installed, but then can't launch it.

germanDevguru

comment created time in 2 months

pull request commentnodejs/build

Windows Updates

Thanks for the reviews! This needs some work to land, iojs+release needs to have the same changes as the test release job, and the jobs in CI need to be changed to point at master. I'll do it later this week.

joaocgreis

comment created time in 2 months

Pull request review commentnodejs/build

Windows Updates

       params: '/GitAndUnixToolsOnPath'   - name: enable long paths in Git     win_command: 'git config --global core.longpaths true'+  - name: set Git user name+    win_command: 'git config --global user.name "{{inventory_hostname}}"'+  - name: set Git user email+    win_command: 'git config --global user.email "ci@iojs.org"'  # Necessary for junit output in Jenkins jobs - name: install tap2junit-  win_command: 'pip2 install tap2junit'+  win_command: 'pip3 install --upgrade tap2junit'

@rvagg I plan to land this as is, let me know if I missed something.

joaocgreis

comment created time in 2 months

Pull request review commentnodejs/build

Windows Updates

 # Install Visual Studio # -- when: vs == '2013'-  block:-  # TODO: Ensure no other versions are installed-  - name: install Visual Studio 2013-    include_tasks: "partials/vs2013.yml"+- name: install Visual Studio 2013

VS2013 is used to test add-ons for Node.js v8. We should keep the machines available for some time after a Node version goes EOL, but anyway I'd like this to be in the commit history for documentation (we might need to test an old issue or something).

joaocgreis

comment created time in 2 months

push eventJaneaSystems/build

João Reis

commit sha a88ba93b432cb5c2b1e47ea60e4257014fc82c57

fixup! ansible,win: add VS2019 support

view details

push time in 2 months

PR opened MicrosoftDocs/windows-uwp

Change the Node.js beginners page to recommend the Windows native installation

The instructions provided on the beginners page with this change should work in any shell, including WSL.

This also includes a few small fixes, like updating the Node.js LTS version.

cc @mattwojo, let me know if this needs any change or feel free to edit!

Fixes: https://github.com/MicrosoftDocs/windows-uwp/issues/2011

+19 -20

0 comment

2 changed files

pr created time in 2 months

push eventjoaocgreis/windows-uwp

João Reis

commit sha ab0cf5801e23f36401d37b5ae884fef5ba39cfea

Change the Node.js beginners page to recommend the Windows native installation Fixes: https://github.com/MicrosoftDocs/windows-uwp/issues/2011

view details

push time in 2 months

issue commentnodejs/node

Npm is not being updated with node on windows 10

Yes, this happens because npm install -g npm was run. This is expected, when you install npm you take control over the version of npm that you run, same as with all other modules. This has the advantage that any user in the system can update npm for their own account without administrator privileges. Also, it does not make sense for the installer to look for npm installations for any user in any prefix. It is possible that a better solution could be implemented, but it's not likely to be simple.

You can easily fix this by running npm install -g npm to update npm (possibly an even newer version than the one bundled with node). Or run npm uninstall -g npm to revert to the npm installed with node.

AlexSHoffman

comment created time in 2 months

create barnchjoaocgreis/windows-uwp

branch : joaocgreis-JCQ-nodejs-windows

created branch time in 2 months

fork joaocgreis/windows-uwp

Conceptual and overview content for developing Microsoft Universal Windows Platform (UWP) apps

fork in 2 months

fork joaocgreis/gitignore

A collection of useful .gitignore templates

fork in 2 months

push eventJaneaSystems/build

João Reis

commit sha a5edf2472f2f4446d577d7ea6ee250604e86f524

fixup! doc,win: update node-test-commit-matrix.md

view details

push time in 2 months

create barnchJaneaSystems/build

branch : joaocgreis-JBC-windows-updates-0

created branch time in 2 months

Pull request review commentnodejs/build

Windows Updates

       params: '/GitAndUnixToolsOnPath'   - name: enable long paths in Git     win_command: 'git config --global core.longpaths true'+  - name: set Git user name+    win_command: 'git config --global user.name "{{inventory_hostname}}"'+  - name: set Git user email+    win_command: 'git config --global user.email "ci@iojs.org"'  # Necessary for junit output in Jenkins jobs - name: install tap2junit-  win_command: 'pip2 install tap2junit'+  win_command: 'pip3 install --upgrade tap2junit'

Isn't that redundant? tap2junit is invoked by the build scripts, so we have control over what exactly is called. If we have both, that would either just ignore one (the one not first in the path) or call an arbitrary one depending on which one is first in the path. Since tap2junit supports Python 3, I figured we could just go with that.

@cclauss do you know if we need both?

joaocgreis

comment created time in 2 months

Pull request review commentnodejs/build

Windows Updates

+#!/bin/bash -ex++rm -rf src node_version.h.tar || true++source env.properties++set +x+export GIT_SSH_COMMAND="ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -i $JENKINS_TMP_KEY"+set -x++# Retry once+git archive --format=tar --remote="$TEMP_REPO" $TEMP_BRANCH src/node_version.h -o node_version.h.tar ||+git archive --format=tar --remote="$TEMP_REPO" $TEMP_BRANCH src/node_version.h -o node_version.h.tar

I also had issues with http repos, but this works for our temp repo (ssh). This is already being used by node-test-commit-windows-fanned (running in jenkins-workspace).

joaocgreis

comment created time in 2 months

issue commentnodejs/build

Windows CI machine updates

This also happens on the ARM64 machines, which should not be affected by the updates. I believe this is related to a Git for Windows update that happened a few days ago on all machines, between the last good and the first failing job. I replaced grep -P by sed, should be working again.

joaocgreis

comment created time in 2 months

pull request commentnodejs/build

Windows Updates

As I understand it, using CMake from VS is a bit of an hack. Needs to be accessed by full path, so location will change with VS version. Also, it's not present in VS2015. Having it from Chocolatey should be a better option, more so if we start using it to build Node at some point.

joaocgreis

comment created time in 2 months

issue commentnodejs/build

cmake on CITGM infrastructure

Installed CMake on all Windows machines (included in PR https://github.com/nodejs/build/pull/2099).

BridgeAR

comment created time in 2 months

pull request commentnodejs/build

Windows Updates

Added a commit to install CMake (https://github.com/nodejs/build/issues/2097) and rebased.

joaocgreis

comment created time in 2 months

push eventJaneaSystems/build

Ash Cripps

commit sha 9df1fc4544dcfa8b17e4e5098836ac48cef9231d

Reprovision s390x machines (#2083) * ansible: update playbooks for new s390x machines * Remove symbolic link + turn devtoolset install to manual * ansible: Rename every reference of rhel72 -> rhel7

view details

João Reis

commit sha cddccfffc24479789f5744b35fe840b92e3970e6

jenkins: add Windows to VersionSelectorScript

view details

João Reis

commit sha bada110c6cf53300436d432dde9e856ad4072c76

jenkins: add Windows scripts

view details

João Reis

commit sha ef7aba91e1ba64f0e48c4347306c3400287d9a91

ansible,win: disable SSLv2 and SSLv3 Following Azure security recommendations.

view details

João Reis

commit sha ec5b0c91ea4f28ad269a7163ae27e93bc6494ae9

ansible,win: don't install MFC and XP compat

view details

João Reis

commit sha 2a756719c21dd2472d296c1807c8be8aa04b4b45

ansible,win: add VS2019 support

view details

João Reis

commit sha 85aad05746723a1204425f2130e7a60dc0eed35e

ansible,win: add clcache Specific commit and floating PRs known to work.

view details

João Reis

commit sha cb15133fbb26fadf0dc061459efbda71a4183460

ansible,win: add Python 3

view details

João Reis

commit sha de3451644689cabc6f47591fecb9fa54f1002524

ansible,win: add CMake Refs: https://github.com/nodejs/build/issues/2097

view details

João Reis

commit sha 8659b6fad00b1815a33b33c13a23b0e7dab0cdc4

ansible,win: add update-windows playbook

view details

João Reis

commit sha ed98d5c2f7a5db94199cf3b486e991b0b1c3d7cd

ansible: accept 'password' shortcut

view details

João Reis

commit sha ff0c5670a29b41043b6e3d0cc587b83ad734edca

ansible: move Windows to main create worker playbook

view details

João Reis

commit sha 6f1a8f153cbbb6e1b55540de0cb6de805753daa2

ansible: update Windows inventory

view details

João Reis

commit sha a9da63f404a3e6b569735d9a1b32c602ffd9d69e

doc,win: update non-ansible-configuration-notes.md

view details

João Reis

commit sha 7144fc50b4aa070eebf407572cc436bab140c637

doc,win: update Windows supported versions

view details

João Reis

commit sha 88c5ec6349968eebce98193345765158e8311c2a

doc,win: update node-test-commit-matrix.md

view details

push time in 2 months

Pull request review commentnodejs/build

Windows Updates

 Supported versions for building Node.js from source. | v9              | 2015, VCBT2015, 2017                | | v10             | 2017 <sup>[5]</sup>                 | | v11             | 2017                                |+| v12             | 2017, 2019 (flag) <sup>[8]</sup>    |+| v13             | 2017, 2019 <sup>[9]</sup>           |+| v13             | 2017, 2019                          |

Yes, fixed, thanks!

joaocgreis

comment created time in 2 months

push eventJaneaSystems/build

João Reis

commit sha e8669b148b496f378ce1c5366fd78f5457a1408b

fixup! doc,win: update Windows supported versions

view details

push time in 2 months

issue commentnodejs/build

Windows CI machine updates

The issue of failed compile jobs has been fixed by deleting all clcache data when compilation fails. If this starts happening again, we'll probably have to disable clcache completely, unless someone has the bandwidth to investigate further.

joaocgreis

comment created time in 2 months

issue closednodejs/build

Optimize test scripts for CI job for windows

2 things I noticed when working on adding check for cctest.tap failures in CI. We distribute the test cases in 4 groups (%RUN_SUBSET%) and each machine runs individual group. However all the groups run cctest and build the addons. Although not trivial, we can speed up the test job by running cctest on just 1 machine (need to figure out how) and also skip building addons if that group won't be testing test-addons or test-addons-napi unless there was historical reason for not doing it in this way.

closed time in 2 months

kunalspathak

issue commentnodejs/build

Optimize test scripts for CI job for windows

This has been done for some time, and now included in https://github.com/nodejs/build/pull/2099.

kunalspathak

comment created time in 2 months

PR opened nodejs/build

Windows Updates

This is all already in use by CI, but not yet by the release Jenkins. The release job need to be adjusted while landing this.

Notable changes:

  • VS2019 support
  • Windows now uses the VersionSelectorScript - it is a bit complex as expected, but it manages to filter for building node, building add-ons, and choose what runs where depending on what labels are available while always avoiding invalid combinations
  • Moved most scripts from CI jobs to the build repo - this allows us to reuse parts of the scripts for different jobs, gives us some history for long-term changes, and it is easy to change to a fork for testing if needed
  • Test building in debug mode
  • Test building the MSI
  • Python 3 added to all Windows machines
  • Windows moved to the main create worker playbook
  • Some documentation updates

Re-created all Windows machines to balance available versions optimizing for current master.

Refs: https://github.com/nodejs/build/issues/1996

+718 -123

0 comment

28 changed files

pr created time in 2 months

push eventJaneaSystems/build

João Reis

commit sha a553922a1448da5dbb584e6cb8bf004337ebb018

doc,win: update node-test-commit-matrix.md

view details

push time in 2 months

push eventJaneaSystems/build

Richard Lau

commit sha 8fab072b5f8f80fd25968248eab8d4782470743c

jenkins: exclude testing on vs2019 on Node.js < 10 (#2085)

view details

Anna Henningsen

commit sha 0e55cb026ed09d8753c680e0f21722d376b0948d

doc: add myself to build WG member list (#2090) Fixes: https://github.com/nodejs/build/issues/2076

view details

Ash Cripps

commit sha 6bcc28ea91d2c767533869bcc264bb544a839b52

ansible: remove hardcoded cert location for AIX jenkins (#2086)

view details

João Reis

commit sha c6c39df327fecfd56c64e9ce982471c2cde4da6f

jenkins: add Windows to VersionSelectorScript

view details

João Reis

commit sha b146dbb922bf756a226bc5eafab629497191a549

jenkins: add Windows scripts

view details

João Reis

commit sha 7ebc30e6159be8cf98566b9d739085d4a1d37405

ansible,win: disable SSLv2 and SSLv3 Following Azure security recommendations.

view details

João Reis

commit sha 664408cdd8950f88d0b736ef8e5f433ab9a67024

ansible,win: don't install MFC and XP compat

view details

João Reis

commit sha fcd0348e51c982891a73abafa17e12523d651617

ansible,win: add VS2019 support

view details

João Reis

commit sha 35515487044b1fd62ef786d840809b5cb72fd9f7

ansible,win: add clcache Specific commit and floating PRs known to work.

view details

João Reis

commit sha 896770bf89840be801f4f387f811be3a01874c89

ansible,win: add Python 3

view details

João Reis

commit sha afdf1eaf8d64e00640557ff9cd80ca461ec1efe9

ansible,win: add update-windows playbook

view details

João Reis

commit sha 9cd55244994fba991bb4a0cc84d5fbf5512f76de

ansible: accept 'password' shortcut

view details

João Reis

commit sha 4fa8ba1bdff4641f7492a54f651e66e8586efdfe

ansible: move Windows to main create worker playbook

view details

João Reis

commit sha 6f9ab6f055aa51a5ead1cb99fbc24d56f26a2247

ansible: update Windows inventory

view details

João Reis

commit sha 6cd79f709f550fceb4800ceabe5c9b72f4cf9bd5

doc,win: update non-ansible-configuration-notes.md

view details

João Reis

commit sha 9a1387ba95f1785ece04bf37a1ec91d89cc54954

doc,win: update Windows supported versions

view details

João Reis

commit sha acf120300c1f8951659ed27a3194d0800c04d4ff

doc,win: update node-test-commit-matrix.md

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha f1645a41816a334cad26b7b79e6e38a28b444498

jenkins: add Windows scripts

view details

João Reis

commit sha 7e7ef63d4eb652cee8a5887b1654ae61317ddfff

ansible,win: disable SSLv2 and SSLv3 Following Azure security recommendations.

view details

João Reis

commit sha ab4be19a78280ae3b846a3865dc8c0f30e01e1fc

ansible,win: don't install MFC and XP compat

view details

João Reis

commit sha 01c8a94a4a89b02ca0752471e6e4ce658c369ccd

ansible,win: add VS2019 support

view details

João Reis

commit sha 06d7a56838e6193b370e9cab2d5011021f673997

ansible,win: add clcache Specific commit and floating PRs known to work.

view details

João Reis

commit sha db20d7afb407b1235b594767adf918da84d57e55

ansible,win: add Python 3

view details

João Reis

commit sha 830a018cc9a228b2d781e03223c8282a222b3be3

ansible,win: add update-windows playbook

view details

João Reis

commit sha ae96d78034b786edf17db30f343a878a748f6766

ansible: accept 'password' shortcut

view details

João Reis

commit sha 73492c5cf00983acef4e504db399ef24dda723bf

ansible: move Windows to main create worker playbook

view details

João Reis

commit sha 689234c6b0a823e12c7fa4b9fd44e4c3a3b9de10

ansible: update Windows inventory

view details

João Reis

commit sha 2c1aaddf53741d39d3fc7efd62006e10ffabfde5

doc,win: update non-ansible-configuration-notes.md

view details

João Reis

commit sha 465b3db1dca419f26f64c193c7c651f243463ec2

doc,win: update Windows supported versions

view details

João Reis

commit sha eeb9d2e82c1644713aa3ae902994030742a4c362

doc,win: update node-test-commit-matrix.md

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha 12641d4b0155af4c5c8390aec09ee47174aa30a4

Update node-compile-windows.cmd

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha 4d72091cd8baf54d1d4d739341694690fcb3f8eb

Update ci-node-version.sh

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha 556c719b9bc5cdf1631c75ff769c780571ab3111

Update ci-node-version.sh

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha d7b2c66c68cd0f2f2aa5e567a46160f29525ba0c

Update ci-node-version.sh

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha 3cdf26da70d09dbc02f0605f007cf2d0a2e646de

Update ci-node-version.sh

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha 5779b84c91bb5821d0c7a3e4aa1bdbcfad85e21e

Update ci-node-version.sh

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha 12d20877c79b9ff84c9c35df6f22180f0711a7b9

fixup! jenkins: add Windows scripts

view details

push time in 2 months

push eventJaneaSystems/build

João Reis

commit sha aaede0f7e4dd62016dad25604052f6afa25f77a4

fixup! ansible,win: add update-windows playbook

view details

push time in 2 months

pull request commentnodejs/node

v12.14.0 proposal

CI needs https://github.com/nodejs/node/commit/8dd5eec5e28d0afc6f5619476ddefcff8417761b to pass.

Ref: https://github.com/nodejs/node/pull/30937#issuecomment-565573391

MylesBorins

comment created time in 2 months

pull request commentnodejs/node

v10.18.0 proposal

CI needs https://github.com/nodejs/node/commit/c3e386284e4d34d99eecaa0e83bd11917db9a5de to pass.

Ref: https://github.com/nodejs/node/pull/30937#issuecomment-565573391

MylesBorins

comment created time in 2 months

pull request commentnodejs/node

v8.17.0 proposal

CI needs https://github.com/nodejs/node/commit/7770279e4f9e109c8c61f053d01cbb0b3b2927d4 to pass.

Ref: https://github.com/nodejs/node/pull/30937#issuecomment-565573391

MylesBorins

comment created time in 2 months

pull request commentnodejs/node

v13.4.0 proposal

(And for those doing the security release (@nodejs/releasers ?) the security release will probably need to also include the recent commits @joaocgreis has added for the builds to work on Windows on the CI.)

https://github.com/nodejs/node/commit/001d250855091728cff657138fd2059e2066185b is necessary to run CI. If the security release can only have one commit, I don't see a problem with running CI on a temporary branch that floats this commit on top of the release. The same for LTS branches - this cherry-picks cleanly into v12, but v10 and v8 have slightly different commits.

The other commits are not as essential, but the -native job turns yellow instead of red on cctest failures.

MylesBorins

comment created time in 2 months

issue closednodejs/build

Nightly v14.0.0 Windows builds are missing

The past two nightly releases of v14.0.0 have not had Windows binaries.

https://nodejs.org/download/nightly/v14.0.0-nightly20191211855ca736de/ https://nodejs.org/download/nightly/v14.0.0-nightly20191212086c7b41b2/

closed time in 2 months

gabrielschulhof

issue commentnodejs/build

Nightly v14.0.0 Windows builds are missing

@gabrielschulhof thanks for the warning!

The usernames on the Windows release machines changed, I'm assuming that's what caused this. I think it's fixed now, next nightlies should all be there (except canary, which has other issues).

gabrielschulhof

comment created time in 2 months

PR opened nodejs/node

build,win: fix goto exit in vcbuild build lts-watch-v10.x lts-watch-v12.x lts-watch-v8.x windows

In https://github.com/nodejs/node/commit/3b484edce3736cbcba26be1eec512df5282ca5bf I changed vcbuild.bat to exit with an error if cctest fails.

While in many places vcbuild.bat exits immediately with exit /b 1 if an error is found, I missed that in other places it jumps to :exit and expects it exit with error. My change broke this, and this PR should fix it.

This should land in all LTS branches.

cc @nodejs/platform-windows

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -0

0 comment

1 changed file

pr created time in 2 months

create barnchJaneaSystems/node

branch : joaocgreis-JCD-fix-vcbuild-exit

created branch time in 2 months

issue commentnodejs/build

add Joyee to jenkins-admin?

+1

cc @nodejs/jenkins-admins

Trott

comment created time in 2 months

issue openednodejs/node-version-jenkins-plugin

Version set from plugin does not respect rebase parameter

Opening this here mostly to track the issue, this is not likely to have a simple solution.

When a PR is open long enough for a new version of Node.js to be released, the PR HEAD and the master branch will have different Node versions. Since the plugin queries the version before rebasing, NODEJS_MAJOR_VERSION can be different than the actual version being tested. This might cause the job to run on wrong versions or platforms.

A simple workaround is to ask the PR authors to rebase.

created time in 2 months

push eventJaneaSystems/node

João Reis

commit sha 5e4cc4c78b8d8eb22ad14d3457e71ecdc46d40fd

fixup! build,win: support building MSI with VS2019

view details

push time in 2 months

Pull request review commentnodejs/node

build,win: support building MSI with VS2019

 _UpgradeReport_Files/ *.wixobj /tools/msvs/genfiles/ /npm.wxs+/tools/msvs/msi/Release/+/tools/msvs/msi/obj/+/tools/msvs/msi/x64/

It's the Release/ folder. By default, VS uses Release/ for x86 and x64/Release/ for x64.

joaocgreis

comment created time in 2 months

pull request commentnodejs/node

test: fix flaky test-http2-client-upload

The Windows build fails because of a bug in the Windows test job. I'll try to get it fixed, sorry for this. For now, please rebase this PR on current master if you want to run CI.

Flarna

comment created time in 2 months

PR opened nodejs/node

build,win: support building MSI with VS2019 build dont-land-on-v12.x windows

Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible.

cc @nodejs/platform-windows

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+18 -13

0 comment

3 changed files

pr created time in 2 months

create barnchJaneaSystems/node

branch : joaocgreis-JCB-msi-vs2019

created branch time in 2 months

issue commentnodejs/node-gyp

if not defined npm_config_node_gyp error

@NotMichaelsGitHub can you run with --verbose and paste the full output here?

NotMichaelsGitHub

comment created time in 2 months

push eventJaneaSystems/build

Benjamin E. Coe

commit sha 5003c6ecf646d89410cae98bfe0d94a4181c2036

feat: add link to codecov.io (#2073) * feat: add link to codecov.io * chore: address review

view details

Ash Cripps

commit sha 8592b5f9e1201101a70db82b21d17fbac666a5f4

ansible: add new AIX7.1 machines to CI (#2056) * update the ansible vars file for missing packages that used to be added manually * clean up and update aix manual steps for 7.2 and 7.1 * edit select-compiler.sh for aix 7.1

view details

Rod Vagg

commit sha 39cacfead86952db488ef76d88ab0ab3e405b38c

pi: reprovision all Pi's with Raspbian Buster, add docs

view details

João Reis

commit sha 8475d98c1bccb9a987795a7ddfac548ff563b5c8

jenkins: add Windows to VersionSelectorScript

view details

João Reis

commit sha a6092149c6076e343524441f28bd954a51cf1acd

jenkins: add Windows scripts

view details

João Reis

commit sha f35619aaf6300c3aac9cb70fb44f22a70501f470

ansible,win: disable SSLv2 and SSLv3 Following Azure security recommendations.

view details

João Reis

commit sha 4d30d17088c8880e378c654de7ec066ed6c43ed2

ansible,win: don't install MFC and XP compat

view details

João Reis

commit sha b61a293519139b5528a9818bb04785fdee9563c0

ansible,win: add VS2019 support

view details

João Reis

commit sha e3eef55becb40892d8dd196a242fb2d3e211b750

ansible,win: add clcache Specific commit and floating PRs known to work.

view details

João Reis

commit sha 3f8ebb2b5d43f74a22d1ec7668ce1d8b8884ac86

ansible,win: add Python 3

view details

João Reis

commit sha 34b5c6abcaf44f6332c5242af24e354f08b268ae

ansible,win: add update-windows playbook

view details

João Reis

commit sha 22f8abf0a56a8143bfd4344ab5f8d2fa1ed4188b

ansible: accept 'password' shortcut

view details

João Reis

commit sha 1dc88b20d994a75b9ed3c73dfc496e8fcd7f0c73

ansible: move Windows to main create worker playbook

view details

João Reis

commit sha f82342baaf627b407f458b65abb76e494c69b324

ansible: update Windows inventory

view details

João Reis

commit sha f4553163f32e8c67dc588ff8de58645a2e409dc5

doc,win: update non-ansible-configuration-notes.md

view details

João Reis

commit sha 1fc085d00c02a650c3f5066d69e9aa9b149411a5

doc,win: update Windows supported versions

view details

João Reis

commit sha 17fd2d172886af5019021382f5606a7bd8341288

doc,win: update node-test-commit-matrix.md

view details

push time in 2 months

issue commentnodejs/build

N-API testing Windows failures

This is the version of VersionSelectorScript I have at the moment: https://github.com/JaneaSystems/build/blob/joaocgreis-JBC-windows-updates/jenkins/scripts/VersionSelectorScript.groovy - I plan to PR this soon when I have all the details in place.

Since the N-API job uses the test build type, as the labels are now it would only run in VS versions that can build Node, excluding a few that can build add-ons. Is this acceptable? I'm structuring the labels to have the VS version that is used to build add-ons before -COMPILED_BY- and the version that is used to build Node itself after (as in win10-vs2019-COMPILED_BY-vs2019). So, I can add a label like win10-vs2019-COMPILED_BY-ANY to be used by this job. Would this be better?

mhdawson

comment created time in 2 months

issue commentnodejs/build

Request to join the build WG

+1

Happy to help if you need Windows access - secrets are currently outdated as I'm working on the machines but will be done in a few days.

addaleax

comment created time in 2 months

issue closednodejs/build

load_secrets.py slow and leaving cruft

I feel like pulling load_secrets.py out, it only seems to get in the way. I'm hoping the python folks here can address this. Here's my problems:

  1. it's slow, doing a playbooks/write-ssh-config.yml is where it shows the most, it should be a quick operation but it has to go through decrypting and each decrypt is takes a second or so and this compounds. We don't even need secrets for that. I can't see a way to propagate "I DON'T NEED SECRETS" down into the plugin and I bet that it's not even possible.
  2. It leaves cruft, and doesn't seem to do any "caching" even though it's apparently supposed to.

screenshot 2018-12-02 13 02 08

What even is this? Why can't it just create a new host_vars file for hosts that are missing there? Why does it make a new file every time and not reuse it?

All this plugin does is make me want to go and manually insert host_vars file for each of the missing hosts because it gets in the way all the time.

Give me some good reasons not to pull it out.

closed time in 2 months

rvagg

issue commentnodejs/build

load_secrets.py slow and leaving cruft

I believe https://github.com/nodejs/build/pull/1624 fixed this, or at least made it acceptable. Let me know if there are still issues.

rvagg

comment created time in 2 months

push eventJaneaSystems/build

João Reis

commit sha d82b0e468b56acf904338de98addb903ba1fdf90

fixup! jenkins: add Windows scripts

view details

push time in 2 months

issue commentnodejs/node

Test flakiness is in a critical state

Just opened https://github.com/nodejs/node/pull/30848 to mark a few tests as flaky, so we should see less red and more yellow. Getting to see more green is the next step, but it's not as simple so will take longer.

BridgeAR

comment created time in 2 months

pull request commentnodejs/node

test: mark tests as flaky

Please approve this comment for fast-tracking.

This is easy to change back if there's any objection, and would be good to have in master as soon as possible to help reading CI results for other PRs.

joaocgreis

comment created time in 2 months

PR opened nodejs/node

test: mark tests as flaky

Mark a few tests that failed recently in master as flaky. Most of the tests are only marked flaky on Windows, except test-statwatcher that has failures documented for other platforms in its issue.

cc @nodejs/testing @nodejs/platform-windows

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+18 -4

0 comment

3 changed files

pr created time in 2 months

create barnchJaneaSystems/node

branch : joaocgreis-JC8-flaky-tests

created branch time in 2 months

more