profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/dennisameling/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Dennis Ameling (he/him) dennisameling @fits4all Netherlands https://dennisameling.com Owner @fits4all. Try to contribute to open-source projects where possible.

dennisameling/desktop 2

Simple collaboration from your desktop

dennisameling/7zip-bin 0

7-Zip precompiled binaries

dennisameling/angular 0

One framework. Mobile & desktop.

dennisameling/angular-oauth2-oidc 0

Support for OAuth 2 and OpenId Connect (OIDC) in Angular.

dennisameling/api-library 0

Mautic API Library

dennisameling/app-builder 0

Generic helper tool to build app in a distributable format

dennisameling/azure-functions-test 0

Demo NestJS TypeScript app with Azure Functions

dennisameling/azure-storage-php 0

Microsoft Azure Storage Library for PHP

dennisameling/BazingaOAuthServerBundle 0

[Symfony2] A server side implementation of the OAuth 1.0 protocol based on RFC 5849.

startedTheDoctor0/zip-release

started time in 2 days

issue commentdennisameling/Signal-Desktop

Tracking issue for new releases

I still get 404s when trying to download the v5.10.0 release files?

Thanks for reporting that issue, just fixed it in https://github.com/dennisameling/Signal-Desktop/compare/1f45083688996f3f8dbb80deeedd0e2587209872...38a3c03d9e618895bef205db5c4e43e5ce2cffe9 for future releases. The release script was looking for 5 characters between v and multi-arch, but now that 5.10.0 has been released (which is basically 6 characters), that doesn't work anymore 😅 should've tackled that right at the beginning, sorry.

Just updated the URLs for the 5.10.0 release as well 👍🏼

So far no update regarding the code signing certificate

I think submitting those files, while I do really appreciate it, really leads to a dead end unless those files get hundreds or thousands of downloads, or we get an EV certificate. I don't think it's too much of an issue for now. Once users have Signal Desktop Unofficial installed, the updater will "just work" so they won't be bothered by security issues anymore.

dennisameling

comment created time in 5 days

push eventdennisameling/Signal-Desktop

Dennis Ameling (he/him)

commit sha 38a3c03d9e618895bef205db5c4e43e5ce2cffe9

Fix release version handling

view details

push time in 5 days

push eventdennisameling/Signal-Desktop

Dennis Ameling (he/him)

commit sha d4077b7fb4bcaf190e89338203f11e6de13dd2ab

Fix version number handling

view details

push time in 5 days

startedAssemblyScript/assemblyscript

started time in 5 days

startedappcypher/awesome-wasm-langs

started time in 5 days

pull request commentmautic/mautic

Refactor and small optimization for dynamic content html (part 2/2)

Looks like we broke something in this PR in the legacy builder. The default value isn't saved (but the additional filters are):

https://user-images.githubusercontent.com/17739158/126673984-342f2e96-3c09-4626-a546-2471c8def7f4.mp4

Something to look into once we get further into processing Dynamic Content data in the new builder! 🤷🏼

adiux

comment created time in 6 days

push eventadiux/mautic

Dennis Ameling

commit sha ad70b122112a203a7d4a47940b3c47b2f0b54fb7

Fix CS

view details

push time in 6 days

pull request commentmautic/mautic

Refactor and small optimization for dynamic content html (part 2/2)

Yesterday and today we had two issues with Dynamic Content in the new builder:

  • Both Froala and CKEditor would be loaded at the same time, which led to weird behavior (https://github.com/mautic/mautic/issues/10246)
  • After removing Froala and just activating CKEditor, there was a bug where existing Dynamic Content tabs could not be edited, but newly created Dynamic Content tabs worked well ("Variation 2" in the video below is a new tab):

https://user-images.githubusercontent.com/17739158/126669513-c410fd36-f9b2-4c82-8f2c-4a35dea87eaf.mp4

The second problem occurred because the Dynamic Content textarea elements were converted into CKEditor instances on page load already, so before the Email Builder was even open. That caused some sort of conflict because of which those textareas weren't editable, and performance-wise it's not ideal to do all of that on page load already (imagine the email having 10+ Dynamic Content instances...). This behavior was present in the legacy builder already.

Both issues have been fixed in https://github.com/mautic/mautic/pull/10114/commits/6b9405d7acad27280c5036bc2a62fbecccbb27e8 by doing the following:

  • Do not convert the Dynamic Content textarea elements into CKEditor instances on page load anymore (applies to non-legacy builders only)
  • Added new function Mautic.setDynamicContentEditors() which can be called by builders like the GrapesJsBuilder, as soon as the editing modal opens. This turns said textareas into CKEditor instances, which are now correctly editable.
  • It's possible to add new tabs (filters) to Dynamic Content, but we didn't have a way to turn those new tabs into CKEditor instances as well. The new Mautic.dynamicContentAddNewItemListener(callback) and Mautic.dynamicContentAddNewFilterListener(callback) functions can now be leveraged by builders to do anything they want with textareas of newly created Dynamic Content slots or filters. In the case of the GrapesJsBuilder, this means - once again - turning those into CKEditor instances as well
  • When the modal is closed, we destroy the CKEditor instances so that next time users open the same modal, it creates a fresh instance, preventing the issues of not being able to edit that data again.

The result is that users can now edit and create Dynamic Content items with the CKEditor:

https://user-images.githubusercontent.com/17739158/126671236-416b7988-dc91-4d5a-bc73-afa293aa4246.mp4

Note that it's not yet possible to save the contents of Dynamic Content items, @adiux is working on that 😊

adiux

comment created time in 6 days

push eventadiux/mautic

Dennis Ameling

commit sha 6b9405d7acad27280c5036bc2a62fbecccbb27e8

Let builders do what they want with Dynamic Content textareas while maintaining compat with legacy builder

view details

push time in 6 days

issue commentmautic/mautic

CKE Editor is loaded "outside" the container

Can confirm this issue only exists in PR #10114. In the features branch, Froala is loaded only. However, in the features branch the dynamic content is not saved, but I think a different issue was already created for that 👍🏼

image

adiux

comment created time in 6 days

issue commentdennisameling/Signal-Desktop

Tracking issue for new releases

This is an automated message that version 5.10. is now live. Please note that it might take 1-2 hours for the binaries to be uploaded to the server.

Release URL: https://github.com/dennisameling/Signal-Desktop/releases/tag/v5.10.0-multi-arch

dennisameling

comment created time in 6 days

created tagdennisameling/Signal-Desktop

tagv5.10.0-multi-arch

Signal — Private Messenger for Windows, Mac, and Linux

created time in 6 days

push eventdennisameling/Signal-Desktop

Dennis Ameling

commit sha 1f45083688996f3f8dbb80deeedd0e2587209872

Temp fix wrong type

view details

push time in 6 days

push eventdennisameling/Signal-Desktop

Evan Hahn

commit sha 7efa4f1a8a0d9afcc1303a1bb1a19617ca58ccbe

Speed up a link preview fetch test

view details

Evan Hahn

commit sha da27a6ac64f9c87c2bff17642bc4918252748808

Add `array-type` TypeScript ESLint rule

view details

Evan Hahn

commit sha cf06e6638e300aa9482f088a3a2fccadf0fc029a

Update installation instructions in readme

view details

Fedor Indutny

commit sha ddbbe3a6b1b725007597536a39651ae845366920

More protobufjs migration

view details

Fedor Indutny

commit sha e4efa01073dcb8ce43d2b3de0faa736c780df666

Fix attachment downloads for zero cdnId

view details

Evan Hahn

commit sha 831ec98418ea74e7b26578ad764f4084a8428ae8

Audio messages: move countdown under waveform

view details

Evan Hahn

commit sha 9c48a95eb5ae22f26d1df61f1ad05ca9e8f5e8f2

Refactor outbound delivery state

view details

Fedor Indutny

commit sha 455820a9cf9cb78d0cb80da8deaeccc2269070c5

Fix "delete and restart" after database error

view details

Evan Hahn

commit sha 49dcc11a86abf2477192fda98b15b1e098be0bb3

Update sealed sender icon

view details

Evan Hahn

commit sha d4558dc13b0d7cec4fe73cbb36832410d3a771cd

Remove delete button from message details screen

view details

Evan Hahn

commit sha dfb3c2391c51c7cd80c5ebab76c190de27e6f9ed

Make message metadata non-selectable

view details

Fedor Indutny

commit sha 77668c324787067f2b155b0618f4dcd2ad3d4c9b

Close modal when both mouseup/mousedown are inside

view details

Fedor Indutny

commit sha ad217c808d995e8071da310736a1f40a302a9c93

Revert "Refactor outbound delivery state" This reverts commit 9c48a95eb5ae22f26d1df61f1ad05ca9e8f5e8f2.

view details

Fedor Indutny

commit sha 5da5ffe504c815307c0f67a8a93ec386a4c0de5e

Add placeholder migration 36

view details

Fedor Indutny

commit sha 20ea409d9e51e584e30e9773418fa3a204e043a8

Fix logging in util/deprecated.ts

view details

Fedor Indutny

commit sha 570fb182d4f3bdc831e1cc1d8f98ea71ff508b7b

Fully move to protobufjs

view details

Josh Perez

commit sha 0303b6715c366009665e556fb48c0b5335cbeb30

Shorten the submenu hover delay

view details

Fedor Indutny

commit sha a22dcc986f745977691da4f1273ead3b2fab6bcf

Remove libtextsecure/components.js

view details

Fedor Indutny

commit sha 89516655549f579c60d75d3d53c0f317a33bcb33

Clean up conversations with UUID as E164

view details

Josh Perez

commit sha 168b7058f3be88c9fbb7385a63880e1e361157dd

Updates translations

view details

push time in 6 days

push eventadiux/mautic

Dennis Ameling

commit sha f855f791f416b7c7ea8b007edb337fe907884629

Allow calling Mautic.getActiveBuilderName() everywhere

view details

push time in 7 days

push eventadiux/mautic

Dennis Ameling

commit sha 9b715d90194ad61f72e85b25551308499c504c1a

Introduce new Mautic.getActiveBuilderName function

view details

push time in 7 days

issue commentmautic/mautic

Segment-Mails are forced into email queue, even if queueing is not set up

@oltmanns-leuchtfeuer I wasn't able to reproduce this issue by following the steps you indicated.

image

The email gets sent correctly without ending up in the queue:

image

image

Just to confirm, you mean this field in the settings, right?

image

oltmanns-leuchtfeuer

comment created time in 7 days

issue commentgit-for-windows/git

Tracking issue for Windows ARM64 support

For info: the problem that git --version --build-options returned AMD64 as the CPU instead of ARM64 has been fixed in #3327 (CC @rimrul) 👍🏼

My main goal for this week is to get the ARM64 LLVM/Clang build to work, which is not too far away now. As discussed above in this issue, that'd eliminate the need for including Microsoft Visual C++ Redistributable with Git for Windows ARM64. Will post updates here later this week!

dennisameling

comment created time in 8 days

delete branch dennisameling/git

delete branch : fix-host-cpu

delete time in 8 days

PullRequestReviewEvent

issue commentgrimzy/laravel-mysql-spatial

Method for retrieving as original (lat, lng) not (lng, lat)

We're seeing a similar issue with the Point() type.

When using this library's new Point(lat, lng) to insert a new Point into the database, then doing a raw SELECT X(geolocation) AS lat, Y(geolocation) as lng FROM locations, lat and lng are in the wrong order.

X in MySQL means lat and Y in MySQL means lng, so I'm pretty sure that this library is the problem here. For now, we'll do something similar to what @dhcmega has done above, to simply just flip the latitude and longitude.

dhcmega

comment created time in 9 days

push eventdennisameling/git

Dennis Ameling

commit sha 390bf68d1659f6bb87979e5f58db790cf5f68bd2

cmake(): allow setting HOST_CPU for cross-compilation Git's regular Makefile mentions that HOST_CPU should be defined when cross-compiling Git: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/Makefile#L438-L439 This is then used to set the GIT_HOST_CPU variable when compiling Git: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/Makefile#L1337-L1341 Then, when the user runs `git version --build-options`, it returns that value: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/help.c#L658 This commit adds the same functionality to the CMake configuration. Users can now set -DHOST_CPU= to set the target architecture. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>

view details

Dennis Ameling

commit sha cc48a7e0d62bbda2e834d822ab21463f90b1fd69

ci(): add HOST_CPU to CMake command As mentioned in the Makefile and CMakeLists.txt: "When cross-compiling, define HOST_CPU as the canonical name of the CPU on which the built Git will run (for instance "x86_64")" This commit sets the HOST_CPU variable since Git for Windows arm64 is cross-compiled from an amd64 host. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>

view details

push time in 9 days

push eventdennisameling/git

Dennis Ameling

commit sha 4444bff7cc65b517c3400545a95c72a7c30e56a0

cmake(): allow setting HOST_CPU for cross-compilation Git's regular Makefile mentions that HOST_CPU should be defined when cross-compiling Git: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/Makefile#L438-L439 This is then used to set the GIT_HOST_CPU variable when compiling Git: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/Makefile#L1337-L1341 Then, when the user runs `git version --build-options`, it returns that value: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/help.c#L658 This commit adds the same functionality to the CMake configuration. Users can now set -DHOST_CPU= to set the target architecture. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>

view details

Dennis Ameling

commit sha 66f5374b43c4832109eb6056605acd9a555133a8

ci(): add HOST_CPU to CMake command As mentioned in the Makefile and CMakeLists.txt: "When cross-compiling, define HOST_CPU as the canonical name of the CPU on which the built Git will run (for instance "x86_64")" This commit sets the HOST_CPU variable since Git for Windows arm64 is cross-compiled from an amd64 host.

view details

push time in 9 days

PR opened git-for-windows/git

cmake(): allow setting HOST_CPU for cross-compilation

As reported by @rimrul in https://github.com/git-for-windows/git/issues/3083#issuecomment-791978513, git version --build-options returns the wrong CPU when building Git for ARM64 Windows.

Git's regular Makefile mentions that HOST_CPU should be defined when cross-compiling Git: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/Makefile#L438-L439

This is then used to set the GIT_HOST_CPU variable when compiling Git: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/Makefile#L1337-L1341

Then, when the user runs git version --build-options, it returns that value: https://github.com/git-for-windows/git/blob/37796bca76ef4180c39ee508ca3e42c0777ba444/help.c#L658

This commit adds the same functionality to the CMake configuration. Users can now set -DHOST_CPU= to set the target architecture.

+9 -2

0 comment

2 changed files

pr created time in 9 days

create barnchdennisameling/git

branch : fix-host-cpu

created branch time in 9 days

push eventdennisameling/git

Johannes Schindelin

commit sha f511b78df11d8217f5b09caa418fd5e77aa43b03

fixup! README.md: Add a Windows-specific preamble Visual Studio Code _just_ introduced a new, neat feature, where clicking on a badge can open the repository really quickly, without having to clone it (e.g. when fixing typos or things like that). Let's add that badge to our README. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

view details

Johannes Schindelin

commit sha 11896aad4e962b808a254114560ded4178b9db3a

fixup! README.md: Add a Windows-specific preamble We're now using the default branch name `main`. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

view details

Johannes Schindelin

commit sha 89c470c19b287d8983a1535dfb557a83f41986f7

fixup! README.md: Add a Windows-specific preamble This fixes a whitespace problem introduced by yours truly. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

view details

Johannes Schindelin

commit sha 37796bca76ef4180c39ee508ca3e42c0777ba444

Merge pull request #3317 from dscho/open-in-vs-code README: add an "Open in VS Code" badge

view details

push time in 9 days

created tagdennisameling/rom-properties

tagv1.8.0-arm64

ROM Properties Page shell extension

created time in 9 days

push eventdennisameling/rom-properties

David Korth

commit sha 4da7a5105661bff8d983ccd1541490fd1b26642f

[zstd] Updated from 1.4.5 to 1.4.8.

view details

David Korth

commit sha b3859eb3538ee1ade34ab0398ec79e727419814a

NEWS.md: Forgot to commit the CD-ROM 2448-byte sector note from 2020/12/02.

view details

David Korth

commit sha 7d302b51c90eb633466d4469f167975767597b65

[minizip] Updated from v2.10.5 to minizip-ng 3.0.0. As of 3.0.0, the minizip fork is now called minizip-ng. https://github.com/zlib-ng/minizip-ng

view details

David Korth

commit sha 7fad2e50aa3b1cc5d9403d9897f0f2f183188bea

[cmake] CheckNettle2or3.cmake: New macro to check for Nettle and determine its version. Split from librpbase/CMakeLists.txt. [librpbase/tests] CMakeLists.txt: Use CHECK_NETTLE_2_OR_3. Previously, we were checking for the Nettle library, which broke when the library package was changed to NETTLE to fix a warning from CMake 3.17's FIND_PACKAGE() in commit 5645e9f9b558f59fa39bb7b60a0838649c2da291. (Rename FindNettle and FindSeccomp to FindNETTLE and FindSECCOMP.)

view details

David Korth

commit sha c3f4db832c413a2da5bacb5346d0cf4d8df0a590

[zlib] Updated from v1.2.11 to zlib-ng v2.0.0-RC2. https://github.com/zlib-ng/zlib-ng

view details

David Korth

commit sha 083d6ac20a34a16f352e02b06a63d4edb22e9440

cmake/platform.cmake: Fix 32-bit ARM platform detection. Reported by @vaguerant.

view details

David Korth

commit sha 7bcffc8dfcff43f3788d30df8ced1c616d2fd2ea

[cmake] platform.cmake: Detect other 32-bit ARM variants.

view details

David Korth

commit sha 17d33de3250099ad561ee7f0b318e8c0be7d0e42

[zstd] Updated: 1.4.8 -> 1.4.9

view details

David Korth

commit sha 4e740204ccefec86ccbf7114b9cbf5d088324603

[kde] AboutTab, AchievementsTab: Inline the empty pure-virtual functions.

view details

David Korth

commit sha adc3850f5e8b7b42fa471881005f56693735269e

[libromdata] DMG: Fix an inverted condition for the game ID display. Fixes: 04bd2db5a9adff2690fe7bfa14148dc01dbdd3df ([libromdata] Consolidate all "Game ID" strings into the "RomData" context.) Affects: v1.7 - v1.7.3

view details

David Korth

commit sha 7e885ba19a3276a88bb35bf92318d5781ca20468

[rapidjson] rapidjson.h: Set endianness for MSVC/ARM64. Fixes #287: [Feature Request] add cross-compilation support for Windows arm64 Reported by @dennisameling.

view details

David Korth

commit sha e21814a7548b7cdae7b1b1bbc9c1230c1e9297c2

[zstd] zstd.h: Update some function declarations; increment version number. I somehow missed these when updating zstd earlier. It only seemed to break the MinGW-w64 builds, which is odd, since I would have expected this to break every build in cases where we didn't have a system zstd...

view details

David Korth

commit sha 93106530db60a9748c2a5f24cf71f9e37ee90b9b

[libromdata] XboxDisc: Fix an edge case with some XGD3 discs. XGD3 discs that have a video partition with an XGD2 timestamp were being misdetected as XGD2, so the XDVDFS partition could not be found. Affects: "Kinect Rush a Disney Pixar Adventure" (4D5309B6) Fixes #291: Kinect Rush A Disney Pixar Adventure [4D5309B6] not being parsed correctly Reported by @Masamune3210.

view details

David Korth

commit sha 278bad564475eb9e48062515b3eb74ee9a7f881f

NEWS.md: Mention the GitHub issue number for XGD3 misdetection.

view details

David Korth

commit sha 465582c09d2d42e51f3b5d64987d70991fed0b88

[libromdata] XboxDisc: Set d->wave to 0 if it's an XGD3 that was misdetected as XGD2.

view details

David Korth

commit sha 6391ace18e5347c1f5db438052946ad1da6d60e2

[libromdata] AmiiboData: Added Cat Mario and Cat Peach from SMB Wave 5. Database is up to date as of 2021/02/12.

view details

David Korth

commit sha 9460eeaf9b5b928377722a46166550fd675ee30e

[amiibo-data] New amiibo database binary format. amiibo-bin.txt: Description of the binary format. amiibo-data.txt: Amiibo database in text format. The database will be compiled to a binary file using amiiboc. TODO: CMake's cross-compilation functionality is a bit iffy and requires building a host system version of amiiboc in a separate CMake run. Maybe we should convert it to Perl or Python?

view details

David Korth

commit sha 36e50e509688ff8b2c5112fd20d95a830d51af10

[amiibo-data] CMakeLists.txt: Generate amiibo-data.bin. Added some untested CMAKE_CROSSCOMPILING checks.

view details

David Korth

commit sha ab393e82206c6af7fed8796be3f3daaae0b03665

[amiibo-data] amiiboc.cpp: Ensure that 'CS' character series IDs are multiples of 4.

view details

David Korth

commit sha 62a736929b4ed4babb41f30f78a259d88726109f

[amiibo-data] Write the amiibo series table. amiiboc processed the AS commands and assembled it in memory, but never actually wrote it to the .bin file for some reason, and there were no entries in the header for it. Expanded the header to 128 bytes for future expansion.

view details

push time in 9 days