profile
viewpoint
Jiawen Geng gengjiawen Shenzhen, China https://www.gengjiawen.com Software Engineer.

facebook/react-native 89114

A framework for building native apps with React.

cjihrig/uvwasi 87

WASI syscall API built atop libuv

gengjiawen/android-docker 3

Android ndk docker image

gengjiawen/android-circleci-2.0 1

Android builds on circleci 2.0 with emulator inside docker.

gengjiawen/AndroidHelper 1

My android helper

gengjiawen/AsciidoctorRender 1

This is a demo project for how to render asciidoctor using asciidoctor.js

gengjiawen/android-boilerplate 0

Android boilerplate app that showcases architecture and libraries used at ribot

PR opened nodejs/node

test: fix wrong method call

Ref: https://github.com/nodejs/node/pull/34530#discussion_r464917129

+1 -1

0 comment

1 changed file

pr created time in an hour

create barnchgengjiawen/node

branch : bugfix/wrong

created branch time in an hour

Pull request review commentnodejs/node

test: replace flaky pummel regression tests

+// Flags: --expose-gc+'use strict';+const common = require('../common');+const tmpdir = require('../common/tmpdir');+const assert = require('assert');+const path = require('path');++// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/814:+// Make sure that Buffers passed to fs.write() are not garbage-collected+// even when the callback is being reused.++const fs = require('fs');++tmpdir.refresh();+const filename = path.join(tmpdir.path, 'test.txt');+const fd = fs.openSync(filename, 'w');++const size = 16 * 1024;+const writes = 1000;+let done = 0;++const ondone = common.mustCall((err) => {+  assert.ifError(err);+  if (++done < writes) {+    if (done % 25 === 0) global.gc();+    setImmediate(write);+  } else {+    assert.strictEqual(+      fs.readFileSync(filename, 'utf8'),+      'x'.repeat(writes * size));+    fs.closeSync(fd);+  }+}, writes);++write();+function write() {+  const buf = Buffer.alloc(size, 'x');+  fs.write(fd, buf, 0, buf.size, -1, ondone);

Sure.

addaleax

comment created time in 4 hours

Pull request review commentnodejs/node

test: replace flaky pummel regression tests

+// Flags: --expose-gc+'use strict';+const common = require('../common');+const tmpdir = require('../common/tmpdir');+const assert = require('assert');+const path = require('path');++// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/814:+// Make sure that Buffers passed to fs.write() are not garbage-collected+// even when the callback is being reused.++const fs = require('fs');++tmpdir.refresh();+const filename = path.join(tmpdir.path, 'test.txt');+const fd = fs.openSync(filename, 'w');++const size = 16 * 1024;+const writes = 1000;+let done = 0;++const ondone = common.mustCall((err) => {+  assert.ifError(err);+  if (++done < writes) {+    if (done % 25 === 0) global.gc();+    setImmediate(write);+  } else {+    assert.strictEqual(+      fs.readFileSync(filename, 'utf8'),+      'x'.repeat(writes * size));+    fs.closeSync(fd);+  }+}, writes);++write();+function write() {+  const buf = Buffer.alloc(size, 'x');+  fs.write(fd, buf, 0, buf.size, -1, ondone);

@addaleax should this buf.length ?

addaleax

comment created time in 20 hours

push eventnodejs/node

Anna Henningsen

commit sha 0bb70b0a02c2e6d5e6de61f9f9619f379b09a92e

test: replace flaky pummel regression tests These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: https://github.com/nodejs/node/issues/34527 PR-URL: https://github.com/nodejs/node/pull/34530 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

push time in 21 hours

issue closednodejs/node

flaky test-regress-GH-814_2

<!-- Thank you for reporting an issue.

This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help

Please fill in as much of the template below as you're able.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name -->

  • Version: 15.0.0-pre (current master branch)
  • Platform: fedora-last-latest-x64
  • Subsystem: test, fs, libuv

What steps will reproduce the bug?

Run test/pummel/test-regress-GH-814_2.js on fedora-last-latest-x64 in CI.

<!-- Enter details about your bug, preferably a simple code snippet that can be run using node directly without installing third-party dependencies. -->

How often does it reproduce? Is there a required condition?

Not every time. Running https://ci.nodejs.org/job/node-stress-single-test/151/ right now to see how often.

What is the expected behavior?

The test should pass.

<!-- If possible please provide textual output instead of screenshots. -->

What do you see instead?

The test crashes with -9, which I believe means libuv is complaining about a bad file descriptor.

21:31:32 not ok 2805 pummel/test-regress-GH-814_2
21:31:32   ---
21:31:32   duration_ms: 11.27
21:31:32   severity: crashed
21:31:32   exitcode: -9
21:31:32   stack: |-
21:31:32     /home/iojs/node-tmp/.tmp.2804/GH-814_test.txt
21:31:32     
21:31:32   ...

<!-- If possible please provide textual output instead of screenshots. -->

Additional information

Something similar to this was going on with readstream last year and I think @addaleax fixed it. Maybe fs has the same/similar issue, perhaps when explicit fs.close() is not used?

<!-- Tell us anything else you think we should know. -->

closed time in 21 hours

Trott

PR closed nodejs/node

test: replace flaky pummel regression tests CI / flaky test test

These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that.

Replace them with a more modern test. We don’t explicitly try to detect use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us.

Fixes: https://github.com/nodejs/node/issues/34527

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+39 -195

9 comments

3 changed files

addaleax

pr closed time in 21 hours

pull request commentnodejs/node

test: replace flaky pummel regression tests

Landed in 0bb70b0a02c2

addaleax

comment created time in 21 hours

issue closednodejs/node

test-macOS-with-quic broken

../src/quic/node_quic_session.cc:577:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
    crypto::GetValidationErrorReason(env, err).ToLocal(&validationErrorReason);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
../src/quic/node_quic_session.cc:578:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
    crypto::GetValidationErrorCode(env, err).ToLocal(&validationErrorCode);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~
  c++ -o /Users/runner/work/node/node/out/Release/obj.target/libnode/src/quic/node_quic_default_application.o ../src/quic/node_quic_default_application.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-DNODE_ENABLE_LARGE_CODE_PAGES=1' '-DNODE_EXPERIMENTAL_QUIC=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' '-DNGTCP2_STATICLIB' '-DNGHTTP3_STATICLIB' -I../src -I/Users/runner/work/node/node/out/Release/obj/gen -I/Users/runner/work/node/node/out/Release/obj/gen/include -I/Users/runner/work/node/node/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/uvwasi/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/ngtcp2/lib/includes -I../deps/ngtcp2/crypto/includes -I../deps/nghttp3/lib/includes -I../deps/brotli/c/include -I../deps/openssl/openssl/include  -O3 -gdwarf-2 -mmacosx-version-min=10.13 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-labels -W -Wno-unused-parameter -Werror -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/runner/work/node/node/out/Release/.deps//Users/runner/work/node/node/out/Release/obj.target/libnode/src/quic/node_quic_default_application.o.d.raw   -c

https://github.com/nodejs/node/actions/runs/190357710

Seems to have been introduced on https://github.com/nodejs/node/commit/a97b5f9c6acd101ec20d9278a840b2cb6ef94ac9. cc @nodejs/quic

closed time in 2 days

mmarchini

issue commentnodejs/node

test-macOS-with-quic broken

#34541 landed :)

mmarchini

comment created time in 2 days

PR closed nodejs/node

quic: refactor clientHello C++ author ready dont-land-on-v12.x dont-land-on-v14.x lib / src quic

First commit here is from #34533 which needs to land first.

Second commit here is the important one in this PR. This refactors the 'clientHello' event into an async function passed as an quicsocket.listen() option. This function is only ever called once at a very specific point in the QuicServerSession lifecycle, using it as an event is unnecessary. The commit changes the way it works. If appropriate to do so, user code may return a new SecureContext from the function (previously that was done in the OCSP function, which really didn't make sense).

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+389 -248

8 comments

8 changed files

jasnell

pr closed time in 2 days

pull request commentnodejs/node

quic: refactor clientHello

Landed in e5dacc2f8595...6e65f26b73c6

jasnell

comment created time in 2 days

push eventnodejs/node

James M Snell

commit sha 4b0275ab87f3cf60eb990300a5bc2cc05d5f38d5

quic: refactor clientHello Refactor the `'clientHello'` event into a `clientHelloHandler` configuration option and async function. Remove the addContext API as it's not needed. PR-URL: https://github.com/nodejs/node/pull/34541 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

James M Snell

commit sha d96083bad56e97ddef525c2c0db6963d70fd6f6c

quic: introduce QuicCallbackScope Alternative to `CallbackScope` that handles destroying the `QuicSession` in the try_catch cleanup. PR-URL: https://github.com/nodejs/node/pull/34541 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

James M Snell

commit sha 6e65f26b73c67869a3ac5ee2caf0dfd011177d66

quic: use QuicCallbackScope consistently for QuicSession PR-URL: https://github.com/nodejs/node/pull/34541 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

push time in 2 days

push eventgengjiawen/libuv

gengjiawen

commit sha 7cad8a7c1fdeb1bed2d025abfaf1716ac2639b57

build: lock qemu version Fix: #2937

view details

push time in 4 days

push eventgengjiawen/libuv

gengjiawen

commit sha 39a4a4bd1a3f2c20aedcc40261be1faeede7e0f7

build: lock qemu version Fix: #2937

view details

push time in 4 days

issue commentlibuv/libuv

half of qemu bots appear to be broken

Looks ubuntu doesn't keep old version like qemu-user-static_4.2-3ubuntu9_amd64.deb or qemu-user-static_4.2-3ubuntu8_amd64.deb.

vtjnash

comment created time in 4 days

push eventgengjiawen/libuv

gengjiawen

commit sha be00b7778b5b14587c003bc6b05baefea1fdb521

build: lock qemu version Fix: #2937

view details

push time in 4 days

push eventgengjiawen/libuv

gengjiawen

commit sha 2b18f599cceb000f416bc824939b822a0d0c5da7

build: lock qemu version Fix: #2937

view details

push time in 4 days

PR opened libuv/libuv

build: lock qemu version

Fix: #2937

+1 -1

0 comment

1 changed file

pr created time in 4 days

create barnchgengjiawen/libuv

branch : qemu_lock

created branch time in 4 days

startedyue/crossclip

started time in 4 days

issue commentlibuv/libuv

half of qemu bots appear to be broken

Looks like ubuntu update qemu to qemu-user-static_4.2-3ubuntu10_amd64.deb (ci), we may lock qeme version to prevent this issue (like qemu-user-static_4.2-3ubuntu9_amd64.deb).

vtjnash

comment created time in 4 days

push eventgengjiawen/network-demo

gengjiawen

commit sha dd96ac43ec0103134ef17e11663e2aae39d9116e

0730

view details

push time in 6 days

push eventgengjiawen/network-demo

gengjiawen

commit sha dd89c898941d0f6506d582338ebc98213908e786

2

view details

push time in 7 days

issue closednodejs/node

build: clean up tools/v8_gypfiles/toolchain.gypi

The linux_use_gold_flag, linux_use_bundled_gold and linux_use_bundled_binutils flags are unused and can be removed, our build always disables them.

tools/gyp_node.py sets the flags, they can be removed too.

closed time in 7 days

bnoordhuis

push eventnodejs/node

iandrc

commit sha f93e3a39522c2ca37b8e936ecf98dc6e729cf5bc

build: toolchain.gypi and node_gyp.py cleanup Removed `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags from `tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`. Fixes: https://github.com/nodejs/node/issues/34256 PR-URL: https://github.com/nodejs/node/pull/34268 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 7 days

PR closed nodejs/node

build: toolchain.gypi and node_gyp.py cleanup build tools

Removed linux_use_gold_flag, linux_use_bundled_gold and linux_use_bundled_binutils flags from tools/v8_gypfiles/toolchain.gypi and /tools/gyp_node.py.

Fixes: https://github.com/nodejs/node/issues/34256

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+0 -75

6 comments

2 changed files

iandrc

pr closed time in 7 days

pull request commentnodejs/node

build: toolchain.gypi and node_gyp.py cleanup

Landed in f93e3a39522c

iandrc

comment created time in 7 days

pull request commentnodejs/node

build: toolchain.gypi and node_gyp.py cleanup

@bnoordhuis

Is this PR okay? I guess it needs more reviews in order to be landed. Is it correct?

It doesn't need more review, but this pr need to rebase.

iandrc

comment created time in 7 days

issue commentcodeskyblue/gohttpserver

运行问题

Looks like https://github.com/codeskyblue/gohttpserver/blob/85b2bd5dc48413cf32d8c46e388fab665ac8f7f6/build.sh#L31

Why not using in go-bindata-assetfs in docker build too ?

Also, any thought on a new release ?

gengjiawen

comment created time in 8 days

issue openedcodeskyblue/gohttpserver

运行问题

master上面不拷贝assets貌似会出问题,release页面 1.0.5 无此问题

image

created time in 8 days

delete branch gengjiawen/ts-scaffold

delete branch : dependabot/npm_and_yarn/template/types/node-14.0.26

delete time in 8 days

push eventgengjiawen/ts-scaffold

dependabot-preview[bot]

commit sha 2ec998c9ed588de0a3f6ecd7714cd4cb3051928b

Bump @types/node from 14.0.14 to 14.0.26 in /template (#218) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 8 days

PR merged gengjiawen/ts-scaffold

Bump @types/node from 14.0.14 to 14.0.26 in /template dependencies

Bumps @types/node from 14.0.14 to 14.0.26. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 8 days

delete branch gengjiawen/ts-scaffold

delete branch : dependabot/npm_and_yarn/template/typescript-3.9.7

delete time in 8 days

push eventgengjiawen/ts-scaffold

dependabot-preview[bot]

commit sha 259b87eac92b9d30adcce526a32085a3db486f84

Bump typescript from 3.9.6 to 3.9.7 in /template (#212) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.6 to 3.9.7. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v3.9.6...v3.9.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 8 days

PR merged gengjiawen/ts-scaffold

Bump typescript from 3.9.6 to 3.9.7 in /template dependencies

Bumps typescript from 3.9.6 to 3.9.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/TypeScript/releases">typescript's releases</a>.</em></p> <blockquote> <h2>TypeScript 3.9.7</h2> <p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/">release announcement</a>.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.9.0%22+is%3Aclosed+">fixed issues query for Typescript v3.9.0 (Beta)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.9.1%22+is%3Aclosed+">fixed issues query for Typescript v3.9.1 (RC)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.9.2%22+is%3Aclosed+">fixed issues query for Typescript v3.9.2 (Final)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.9.3%22+is%3Aclosed+">fixed issues query for Typescript v3.9.3 (patch release)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.9.5%22+is%3Aclosed+">fixed issues query for Typescript v3.9.5 (patch release)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.9.6%22+is%3Aclosed+">fixed issues query for Typescript v3.9.6 (patch release)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+3.9.7%22+is%3Aclosed+">fixed issues query for Typescript v3.9.7 (patch release)</a>.</li> </ul> <p>(note, 3.9.4 was intentionally skipped due to minor complications in publishing)</p> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> <li><a href="https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-397">Visual Studio 2017/2019</a> (<a href="https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017">Select new version in project options</a>)</li> <li><a href="https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild">NuGet package</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/TypeScript/commit/a7d801176ca6cdfe45162c7d7cc80b2fdd144240"><code>a7d8011</code></a> Bump version to 3.9.7 and LKG</li> <li><a href="https://github.com/microsoft/TypeScript/commit/761a9ed6dba3a010a5c6385d04afcd3e170bd63e"><code>761a9ed</code></a> Cherry-pick PR <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/39599">#39599</a> into release-3.9 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/39601">#39601</a>)</li> <li><a href="https://github.com/microsoft/TypeScript/commit/75d6648f89c3dbc8ec0b600bab51ba458c7ca696"><code>75d6648</code></a> Cherry-pick PR <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/39573">#39573</a> into release-3.9 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/39602">#39602</a>)</li> <li>See full diff in <a href="https://github.com/Microsoft/TypeScript/compare/v3.9.6...v3.9.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 8 days

delete branch gengjiawen/android-demo

delete branch : dependabot/gradle/androidx.core-core-ktx-1.3.1

delete time in 8 days

push eventgengjiawen/android-demo

dependabot-preview[bot]

commit sha fe3453e5b368ea5e3ef852c95f0e858d15dcda88

Bump core-ktx from 1.3.0 to 1.3.1 (#41) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 8 days

PR merged gengjiawen/android-demo

Bump core-ktx from 1.3.0 to 1.3.1 dependencies

Bumps core-ktx from 1.3.0 to 1.3.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 8 days

delete branch gengjiawen/node

delete branch : ci/quic

delete time in 8 days

issue closednodejs/node-addon-examples

Enable github pages for this repo.

@mhdawson Looks like we need to enable gh-pages in Settings Panel (GitHub Pages Section). (I don't have the permission).

Originally posted by @gengjiawen in https://github.com/nodejs/node-addon-examples/pull/149#issuecomment-664098086

cc @nodejs/addon-api

PS: http://www.gengjiawen.com/node-addon-examples (on my fork)

closed time in 8 days

gengjiawen

PR closed nodejs/node

Reviewers
build: add quic to github action meta quic

Fix https://github.com/nodejs/node/issues/33967

<del> Now blocked by https://github.com/nodejs/node/issues/34435. </del>

+21 -6

15 comments

4 changed files

gengjiawen

pr closed time in 8 days

pull request commentnodejs/node

build: add quic to github action

Landed in 1f94b89309bc...7a5fbafe960d

gengjiawen

comment created time in 8 days

push eventnodejs/node

gengjiawen

commit sha ccbd1d5efa4cc6232f2be434c9004d90ac60af72

build: add quic to github action PR-URL: https://github.com/nodejs/node/pull/34336 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

gengjiawen

commit sha 7a5fbafe960d54af88b113afd6c78d2a29420cf9

quic: fix build for macOS PR-URL: https://github.com/nodejs/node/pull/34336 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 8 days

startedshadowsocks/shadowsocks-rust

started time in 9 days

create barnchgengjiawen/node-addon-examples

branch : gh-pages

created branch time in 9 days

issue openednodejs/node-addon-examples

Enable github pages for this repo.

@mhdawson Looks like we need to enable gh-pages in Settings Panel (GitHub Pages Section).

Originally posted by @gengjiawen in https://github.com/nodejs/node-addon-examples/pull/149#issuecomment-664098086

created time in 9 days

pull request commentnodejs/node-addon-examples

Add GitHub Action to rebuild and publish website

@mhdawson Looks like we need to enable gh-pages in Settings Panel (GitHub Pages Section).

jschlight

comment created time in 9 days

issue commentdependabot/dependabot-core

Add support for C++ projects

Support Cmake will be amazing, save lots of work like https://github.com/cjihrig/uvwasi/blob/d3fe61d596873e6b81098ef91a2c881ca9773a4d/CMakeLists.txt#L33

TerensTare

comment created time in 9 days

pull request commentnodejs/node

build: add pummel tests to ci runs

on macOS, not sure flaky

Also assert.js:103
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

false !== true

    at Timeout._onTimeout (/Users/runner/work/node/node/test/pummel/test-timers.js:55:10)
    at listOnTimeout (internal/timers.js:555:17)
    at processTimers (internal/timers.js:498:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: 'strictEqual'
}
Command: out/Release/node /Users/runner/work/node/node/test/pummel/test-timers.js
Trott

comment created time in 9 days

push eventnodejs/node

Richard Lau

commit sha b2c08f279a6569acaa5d81ae2c88600cf16d93e0

build: don't run test-asan workflow on non-master pushes PR-URL: https://github.com/nodejs/node/pull/34509 Refs: https://github.com/nodejs/node/pull/34464 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

push time in 9 days

PR closed nodejs/node

build: don't run test-asan workflow on non-master pushes build fast-track meta

Refs: https://github.com/nodejs/node/pull/34464

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -0

2 comments

1 changed file

richardlau

pr closed time in 9 days

pull request commentnodejs/node

build: don't run test-asan workflow on non-master pushes

Landed in b2c08f279a65

richardlau

comment created time in 9 days

PR opened kentcdodds/cloc

feat: bump cloc to 1.86
+462 -108

0 comment

1 changed file

pr created time in 9 days

push eventgengjiawen/cloc

Jiawen Geng

commit sha 611ff9b5839566bd5e879237c52581b6075d8caa

feat: bump cloc to 1.86

view details

push time in 9 days

fork gengjiawen/cloc

An npm module for distributing cloc by Al Danial

https://github.com/AlDanial/cloc

fork in 9 days

pull request commentnodejs/node

build: add quic to github action

My position is that I want to keep at least one build/test action job without quic enabled since we do not require a Jenkins CI for doc-only changes. I would be okay if that was the one that is part of the "Build from tarball" workflow but it looks like that might get removed (#34440 and #34123).

I would also prefer if the name of the job name of the jobs that were quic enabled included that information (e.g. something like "test-linux / test-linux-with-quic") to indicate it's a non-default build.

Renamed pipeline and add an extra good old pipeline without quic :)

gengjiawen

comment created time in 9 days

create barnchgengjiawen/network-demo

branch : tcp_wip_1

created branch time in 10 days

push eventgengjiawen/node

gengjiawen

commit sha 88b77fafee042a2d532b037777ceb578c720d2d1

quic: fix build for macOS

view details

push time in 10 days

push eventgengjiawen/node

Myles Borins

commit sha da95dd773216a7fe7bf985014f3920893cbdf23d

Revert "module: fix check for package.json at volume root" This reverts commit 51af89fe453738262e2c10c831705a385ec78530. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: https://github.com/nodejs/node/pull/33476 PR-URL: https://github.com/nodejs/node/pull/34403 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Anna Henningsen

commit sha 2c4ebe0426616e6a5016b6d77f6ca72a9548be93

test: use `.then(common.mustCall())` for all async IIFEs This makes sure that all async functions finish as expected. PR-URL: https://github.com/nodejs/node/pull/34363 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 77b68f9a2997e57462b11eff2d554cc1c831af2d

tools: add linting rule for async IIFEs The result of an async IIFE should always be handled in our tests, typically by adding `.then(common.mustCall())` to verify that the async function actually finishes executing at some point. PR-URL: https://github.com/nodejs/node/pull/34363 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ruben Bridgewater

commit sha 2e82982984a595af24ffb260ff22eb0a73b075c7

util: improve getStringWidth performance This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

AshCripps

commit sha 242bfb6bfc21d571ac5eb14b3c7db1ac9bcb9ee8

src: allow setting a dir for all diagnostic output Add a flag that allows for the setting of a directory where all diagnostic output will be written to. e.g. --redirect-warnings Refs: https://github.com/nodejs/node/pull/33010#issuecomment-618544792 PR-URL: https://github.com/nodejs/node/pull/33584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

sapics

commit sha 50bc7adcf70b74526326b2ef1e410a55a4a589e1

lib: simplify assignment PR-URL: https://github.com/nodejs/node/pull/33718 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Jucke

commit sha 0c6ac2deb3f3e11e9d36740107564286a5cbe6a6

doc: fix typos in n-api, tls and worker_threads PR-URL: https://github.com/nodejs/node/pull/34419 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Jucke

commit sha ca60f5fb447e545270ef3c8f6dbf495b64b5ee12

doc: fix line length in worker_threads.md PR-URL: https://github.com/nodejs/node/pull/34419 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Antoine du Hamel

commit sha 01bd8102ef4c66fbdb7e01ed17e976a46bfcf5d9

doc: mark Node.js 13 as End-of-Life Remove the "Current" label for Node.js 13 in the CHANGELOG. PR-URL: https://github.com/nodejs/node/pull/34436 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 00823f29677c2fc6d2c543970cf18769d09b6a31

src: add callback scope for native immediates This ensures that microtasks scheduled by native immediates are run after the tasks are done. In particular, this affects the inspector integration since 6f9f546406820dc. Fixes: https://github.com/nodejs/node/issues/33002 Refs: https://github.com/nodejs/node/pull/32523 PR-URL: https://github.com/nodejs/node/pull/34366 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha ebf2cd164158c051b8a903d495c20b9dd8ba1d0e

doc: add statement of purpose to documentation style guide PR-URL: https://github.com/nodejs/node/pull/34424 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

cjihrig

commit sha 2c05beeb54cef998fc11933936e18094ec3c540f

tools: update ESLint to 7.5.0 Update ESLint to 7.5.0 PR-URL: https://github.com/nodejs/node/pull/34423 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Pekka Nikander

commit sha bdf6827edcaea80dee719cd70647d983a3438b6d

dgram: add IPv6 scope id suffix to received udp6 dgrams Add IPv6 link local scope ID suffix to the rinfo address in those received upd6 datagrams whose source address is a link local address. Add a new test case, test-dgram-udp6-link-local-address, to verify that IPv6 UDP datagrams received from a link-local source address do contain the scope ID suffix in the rinfo address field. When a packet is received from a link-local source address, if the address does not contain the scope ID suffix, it is impossible to reply back to the sender, as the kernel is not able to determine the right network interface to send the packet through and returns with an error. Ref: https://github.com/nodejs/node/issues/1649 PR-URL: https://github.com/nodejs/node/pull/14500 Refs: https://github.com/nodejs/node/issues/1649 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stewart X Addison <sxa@uk.ibm.com>

view details

Pranshu Srivastava

commit sha 78cd10860818725a1197b34a76e8b8cc81f53326

doc: add rexagod to collaborators Fixes: https://github.com/nodejs/node/issues/34121 PR-URL: https://github.com/nodejs/node/pull/34457 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Shelley Vohr

commit sha 5f5b956a1c5614287e185f12a5a99e6216e6feab

src: allow preventing SetPromiseRejectCallback PR-URL: https://github.com/nodejs/node/pull/34387 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Richard Lau

commit sha 95770df2fb487c95ffb6cc3be4d7344e975c0ae8

2020-07-21, Version 10.22.0 'Dubnium' (LTS) Notable changes: - deps: - upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 - upgrade openssl sources to 1.1.1g (Hassaan Pasha) https://github.com/nodejs/node/pull/32982 - n-api: - add `napi_detach_arraybuffer` (legendecas) https://github.com/nodejs/node/pull/29768 PR-URL: https://github.com/nodejs/node/pull/34170

view details

Robert Nagy

commit sha 02c4869beec52d2664c747d520dfe078d2b3c714

stream: fix Duplex._construct race Ensures that _construct has finished before invoking _destroy. The 'constructed' property was not properly set to false for both writable and readable state. Fixes: https://github.com/nodejs/node/issues/34448 PR-URL: https://github.com/nodejs/node/pull/34456 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Shelley Vohr

commit sha 3f455cbddb413caa2f0d1f902d17bc2ea2824a56

build: don't run Actions on non-master pushes PR-URL: https://github.com/nodejs/node/pull/34464 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha feb93c4e8425b4fce96d92b6072c6e8b6cc634fd

src: guard against nullptr deref in TimerWrapHandle::Stop Refs: https://github.com/nodejs/node/pull/34454 PR-URL: https://github.com/nodejs/node/pull/34460 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Myles Borins

commit sha a981c65b9092d9317603ab25ec8b67aec11feffc

2020-07-21, Version 14.6.0 (Current) Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 * upgrade to libuv 1.38.1 (Colin Ihrig) https://github.com/nodejs/node/pull/34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](https://github.com/nodejs/node/pull/33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) https://github.com/nodejs/node/pull/32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) https://github.com/nodejs/node/pull/34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) https://github.com/nodejs/node/pull/34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) https://github.com/nodejs/node/pull/33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) https://github.com/nodejs/node/pull/34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) https://github.com/nodejs/node/pull/34360 * add sxa as collaborator (Stewart X Addison) https://github.com/nodejs/node/pull/34338 * add ruyadorno to collaborators (Ruy Adorno) https://github.com/nodejs/node/pull/34297 PR-URL: https://github.com/nodejs/node/pull/34371

view details

push time in 10 days

issue closedtabrindle/envinfo

envinfo failed on wsl

(node:1763) UnhandledPromiseRejectionWarning: TypeError: e.filter is not a function
    at /home/daniel/.npm/_npx/1763/lib/node_modules/envinfo/dist/envinfo.js:1:73205
    at async Promise.all (index 72)

cc @asklar

closed time in 13 days

gengjiawen

pull request commenttabrindle/envinfo

Add error checking for Windows, fix crash on WSL

cc @tabrindle we need a new release, envinfo broken is most systems, include linux.

asklar

comment created time in 13 days

delete branch gengjiawen/node

delete branch : bugfix/clang

delete time in 13 days

issue openedtabrindle/envinfo

envinfo failed on wsl

(node:1763) UnhandledPromiseRejectionWarning: TypeError: e.filter is not a function
    at /home/daniel/.npm/_npx/1763/lib/node_modules/envinfo/dist/envinfo.js:1:73205
    at async Promise.all (index 72)

cc @asklar

created time in 14 days

delete branch gengjiawen/node-build

delete branch : gengjiawen-patch-1

delete time in 14 days

push eventgengjiawen/node-build

Jiawen Geng

commit sha 0f6909251358c5629462f60f60231f8f6efaae1d

Add ccache (#15)

view details

push time in 14 days

PR merged gengjiawen/node-build

Add ccache
+1 -0

0 comment

1 changed file

gengjiawen

pr closed time in 14 days

create barnchgengjiawen/node-build

branch : gengjiawen-patch-1

created branch time in 14 days

PR opened gengjiawen/node-build

Add ccache
+1 -0

0 comment

1 changed file

pr created time in 14 days

PR closed nodejs/node

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot C++ author ready fast-track lib / src quic

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot

Otherwise the build would fail with ./configure --experimental-quic --ninja as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See https://github.com/nodejs/node/issues/31074.

Fixes: https://github.com/nodejs/node/issues/34435

<del>

Revert "src: refactor TimerWrap lifetime management"

This reverts commit 874460a1d19e149b58428c88890abe4407cd116e.

@addaleax I have no idea why but it seems the TimerWrap lifetime management refactoring 874460a1d19e149b58428c88890abe4407cd116e is also causing the build to fail a bunch of quic tests, crashing with

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x40)
    frame #0: 0x000000010019c3c8 node`node::TimerWrapHandle::Stop() [inlined] node::TimerWrap::Stop(this=0x0000000000000000) at timer_wrap.cc:16:19 [opt]
   13  	}
   14
   15  	void TimerWrap::Stop() {
-> 16  	  if (timer_.data == nullptr) return;
   17  	  uv_timer_stop(&timer_);
   18  	}
   19

So I revereted it as well to make the tests pass </del>

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+10 -0

10 comments

1 changed file

joyeecheung

pr closed time in 14 days

pull request commentnodejs/node

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot

Landed in f4f191bbc26c

joyeecheung

comment created time in 14 days

push eventnodejs/node

Joyee Cheung

commit sha f4f191bbc26c367ed8fa56c2d1297ef437c5f0fb

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See https://github.com/nodejs/node/issues/31074. PR-URL: https://github.com/nodejs/node/pull/34454 Fixes: https://github.com/nodejs/node/issues/34435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

push time in 14 days

issue closednodejs/node

ninja build failed when build with quic

build with:

 ./configure --experimental-quic --ninja
ninja -C out/Release

Result:

[2997/3003] ACTION node: node_mksnapshot_9b7a2d2290b02e76d66661df74749f56
FAILED: gen/node_snapshot.cc 
cd ../../; out/Release/node_mksnapshot out/Release/gen/node_snapshot.cc
double free or corruption (!prev)
Aborted (core dumped)
[2998/3003] LINK cctest
ninja: build stopped: subcommand failed.

Env:

  System:
    OS: Linux 4.4 Ubuntu 20.04 LTS (Focal Fossa)
    Memory: 4.78 GB / 15.67 GB
    Container: Yes
    Shell: 5.0.16 - /bin/bash
  Binaries:
    Node: 14.5.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - /usr/local/bin/npm
  Managers:
    Apt: 2.0.2 - /usr/bin/apt
    Cargo: 1.44.1 - ~/.cargo/bin/cargo
    pip3: 20.1.1 - /usr/local/bin/pip3
  Utilities:
    CMake: 3.17.3 - /usr/local/bin/cmake
    Make: 4.2.1 - /usr/bin/make
    GCC: 9.3.0 - /usr/bin/gcc
    Git: 2.25.1 - /usr/bin/git
    Clang: 10.0.0-4ubuntu1 - /usr/bin/clang
  IDEs:
    Vim: 8.1 - /usr/bin/vim
  Languages:
    Bash: 5.0.16 - /usr/bin/bash
    Perl: 5.30.0 - /usr/bin/perl
    Python: 2.7.18 - /usr/bin/python
    Python3: 3.8.2 - /usr/bin/python3
    R: 3.6.3 - /usr/bin/R
    Rust: 1.44.1 - /root/.cargo/bin/rustc

cc @joyeecheung

closed time in 14 days

gengjiawen

Pull request review commenttabrindle/envinfo

Add error checking for Windows

+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node

Maybe try adding --unhandled-rejections=strict https://github.com/tabrindle/envinfo/blob/369259a458954ef3577063991e87750ce606609a/appveyor.yml#L18

asklar

comment created time in 14 days

Pull request review commenttabrindle/envinfo

Add error checking for Windows

+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node

Maybe not neccessary. We have appveyor for windows build, you can add windows related there.

asklar

comment created time in 14 days

Pull request review commenttabrindle/envinfo

Add error checking for Windows

 module.exports = {   getVisualStudioInfo: () => {     utils.log('trace', 'getVisualStudioInfo');     if (utils.isWindows) {-      return utils-        .run(-          `"${process.env['ProgramFiles(x86)']}/Microsoft Visual Studio/Installer/vswhere.exe" -format json -prerelease`-        )-        .then(jsonText =>-          JSON.parse(jsonText).map(vsInstance => {-            return { Version: vsInstance.installationVersion, DisplayName: vsInstance.displayName };-          })-        )-        .then(x =>-          utils.determineFound(-            'Visual Studio',-            x.map(v => `${v.Version} (${v.DisplayName})`)+      try {

Both try catch can be replaced by Promise.catch ?

asklar

comment created time in 14 days

startedindutny/breakdown

started time in 14 days

pull request commentnodejs/node

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot

Fast track ?

joyeecheung

comment created time in 14 days

pull request commenttabrindle/envinfo

feat: support for Windows SDKs & IDEs

@gengjiawen can you link to where you're seeing this?

nodejs/node/runs/895789747?check_suite_focus=true#step:5:53 I have been introduce envinfo into Node.js github action a while ago.

Thanks for the link. I'm assuming this worked before? I'm not seeing this behavior on my end for what it's worth:

image

Yeap, maybe an edge case on github action.

asklar

comment created time in 14 days

pull request commenttabrindle/envinfo

feat: support for Windows SDKs & IDEs

@gengjiawen can you link to where you're seeing this?

https://github.com/nodejs/node/runs/895789747?check_suite_focus=true#step:5:53

I have been introduce envinfo into Node.js github action a while ago.

asklar

comment created time in 14 days

pull request commenttabrindle/envinfo

feat: support for Windows SDKs & IDEs

Alright I suppose you're right, won't punish you for the shortcomings on how we have tests setup. Looks good to me, thanks for your quick responses!

thanks! :-)

Edge version looks not right on github action. @asklar

    Edge: {}
asklar

comment created time in 14 days

startedoctokit/rest.js

started time in 14 days

push eventgengjiawen/gengjiawen

gengjiawen

commit sha f2aa041f678df4760a9412c88dadc0a239b3bd3a

add wakatime gist

view details

push time in 15 days

startedanuraghazra/github-readme-stats

started time in 15 days

pull request commentnodejs/node

build: add quic to github action

Yes, the binary being tested is built with non-default configuration options.

But tbh it only add extra quic function, not removing anything or bypass test case.

If you insist on this, I can add an extra action to do this, but we will have three more github action.

Second thought ?

gengjiawen

comment created time in 15 days

push eventgengjiawen/gengjiawen

Jiawen Geng

commit sha 852ef797ca77f9f68be2da4f155914edc306af1e

add stats

view details

push time in 15 days

delete branch gengjiawen/android-demo

delete branch : dependabot/gradle/com.android.tools.build-gradle-4.0.1

delete time in 15 days

push eventgengjiawen/android-demo

dependabot-preview[bot]

commit sha 967e8f3490099e0a6839a0be712996c29ccc8bad

Bump gradle from 4.0.0 to 4.0.1 (#40) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 15 days

PR merged gengjiawen/android-demo

Bump gradle from 4.0.0 to 4.0.1 dependencies

Bumps gradle from 4.0.0 to 4.0.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 15 days

pull request commentnodejs/node

build: add quic to github action

I'd like to keep that with the default configuration.

I have not touch the test configuration. Adding experimental-quic has some impact on test case ?

gengjiawen

comment created time in 15 days

create barnchgengjiawen/gengjiawen

branch : master

created branch time in 16 days

push eventgengjiawen/node

gengjiawen

commit sha 6f0b00dfdf341bd6055620702ac4e09d5152681d

build: add quic to github action

view details

push time in 16 days

issue commentnodejs/node

ninja build failed

Debug stacktrace, Full log: https://github.com/gengjiawen/node-github-workflow/runs/889159038#step:6:4392

cd ../../; out/Debug/node_mksnapshot out/Debug/gen/node_snapshot.cc
=================================================================
==6385==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61f00001f708 at pc 0x000001e3ebcd bp 0x7ffec9b8eb20 sp 0x7ffec9b8eb18
WRITE of size 8 at 0x61f00001f708 thread T0
    #0 0x1e3ebcc in v8::PersistentBase<v8::ObjectTemplate>::PersistentBase(v8::ObjectTemplate*) /__w/node-github-workflow/node-github-workflow/node/out/Debug/../../deps/v8/include/v8.h:606:47
    #1 0x1e00e2b in v8::Global<v8::ObjectTemplate>::Global() /__w/node-github-workflow/node-github-workflow/node/out/Debug/../../deps/v8/include/v8.h:756:24
    #2 0x1d9acbf in node::Environment::Environment(node::IsolateData*, v8::Isolate*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, node::EnvSerializeInfo const*, node::EnvironmentFlags::Flags, node::ThreadId) /__w/node-github-workflow/node-github-workflow/node/out/Debug/../../src/env.cc:310:14
    #3 0x1d9c2a4 in node::Environment::Environment(node::IsolateData*, v8::Local<v8::Context>, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, node::EnvSerializeInfo const*, node::EnvironmentFlags::Flags, node::ThreadId) /__w/node-github-workflow/node-github-workflow/node/out/Debug/../../src/env.cc:414:7
    #4 0x1c6f087 in node::SnapshotBuilder::Generate(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) /__w/node-github-workflow/node-github-workflow/node/out/Debug/../../tools/snapshot/snapshot_builder.cc:126:17
    #5 0x1c6c696 in main /__w/node-github-workflow/node-github-workflow/node/out/Debug/../../tools/snapshot/node_mksnapshot.cc:53:9
    #6 0x7fee5f3150b2 in __libc_start_main /build/glibc-YYA7BZ/glibc-2.31/csu/../csu/libc-start.c:308:16
    #7 0xe1912d in _start (/__w/node-github-workflow/node-github-workflow/node/out/Debug/node_mksnapshot+0xe1912d)

0x61f00001f708 is located 0 bytes to the right of 3208-byte region [0x61f00001ea80,0x61f00001f708)
gengjiawen

comment created time in 16 days

pull request commentnodejs/node

src: prefer C++ empty() in boolean expressions

Failed in macOS ? is this a flaky test cc @Trott

Path: parallel/test-macos-app-sandbox
--- stderr ---
assert.js:103
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 0

    at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-macos-app-sandbox.js:41:8)
    at Module._compile (internal/modules/cjs/loader.js:1252:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1273:10)
    at Module.load (internal/modules/cjs/loader.js:1101:32)
    at Function.Module._load (internal/modules/cjs/loader.js:966:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    at internal/main/run_main_module.js:17:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}
tniessen

comment created time in 16 days

pull request commentnodejs/node

build: add quic to github action

My point is this PR changes the existing build/test workflows to add the configuration flag for quic which means we no longer build/test the non-quic (i.e. default) build configuration with actions.

As far as I know, this is a superset of current build and test. And jenkins still run the old good without quic version. Any other potential problem I am not aware of ?

gengjiawen

comment created time in 16 days

push eventgengjiawen/node

Michaël Zasso

commit sha 12478684aab233942e0d5dc24f195930c8a5e59d

deps: update V8 to 8.4.371.19 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Michaël Zasso

commit sha eba5aafae007a859986bb19238ed5d8e97b879f6

build: reset embedder string to "-node.0" PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Michaël Zasso

commit sha b7cf8234100b0527cae325b5470f03dd137e3a94

src: update NODE_MODULE_VERSION to 86 Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.4. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Refael Ackermann

commit sha 95743dcd2501f104ecce104bdc9bf91932bd4b92

deps: V8: un-cherry-pick bd019bd Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=​machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Ujjwal Sharma

commit sha b78847c99acd2f5342a1d40f422a24ab420a127f

deps: patch V8 to run on older XCode versions Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Refael Ackermann

commit sha 34d8c079886efeae41ba190559da98fbd313e3a2

deps: V8: patch register-arm64.h Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Refael Ackermann

commit sha 5682e6eed74a9c9f6b185c0e9472e08345a9d356

deps: V8: forward declaration of `Rtl*FunctionTable` This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Joao Reis

commit sha b1456e3a7bee9733720081843711cc943f031abc

deps: make v8.h compatible with VS2015 There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Michaël Zasso

commit sha 106a4f4be5e07de364083cea5b995a82044faf16

deps: V8: silence irrelevant warnings PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Matheus Marchini

commit sha edaa56bb60eac20554de807cfcd9d873081b0ab6

deps: patch V8 to run on Xcode 8 Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Michaël Zasso

commit sha 32eb50aeec5b37951efc9038972b9fd4a4426488

deps: V8: cherry-pick 9868b2aefa1a Original commit message: Fix SmartOS compilation errors This commit resolves compilation errors on SmartOS that were found while upgrading Node.js. See: https://github.com/nodejs/node/pull/32831 Change-Id: Ia2a2e028ba4f5bfd69c050cab4fb4e13af5eefd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191054 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67793} Refs: https://github.com/v8/v8/commit/9868b2aefa1af2f1a173856b5d31efa4c2ac2833 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Jiawen Geng

commit sha 87933b5885350ef417324704c203ae6da0e88593

deps: V8: fix compilation on VS2017 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Joyee Cheung

commit sha d7905fcc518d18c5719208387432aaaf4df585cd

deps: V8: backport 22014de00115 Original commit message: Reland "[snapshot] rehash JSMap and JSSet during deserialization" This is a reland of 8374feed55a5b3010f2e9593560a2d84f9f6725f. Fixed rehashing of global proxy keys by creating its identity hash early, before the deserialization of the context snapshot. Original change's description: > [snapshot] rehash JSMap and JSSet during deserialization > > To rehash JSMap and JSSet, we simply replace the backing store > with a new one created with the new hash. > > Bug: v8:9187 > Change-Id: I90c25b18b33b7bc2b6ffe1b89fe17aa5f978b517 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143983 > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67663} Bug: v8:9187, v8:10523 Change-Id: I7a0319b1d10ff07644de902fec43e7c2b1dd8da9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2212085 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#67999} Refs: https://github.com/v8/v8/commit/22014de00115dae09ae3d4a6c3a9f178d5495ef2 PR-URL: https://github.com/nodejs/node/pull/33300 Refs: https://github.com/v8/v8/commit/ea0719b8ed087d1f511e78595dcb596faa7638d0 Refs: https://github.com/v8/v8/commit/bb9f0c2b2fe920a717794f3279758846f59f7840 Refs: https://github.com/nodejs/node/issues/17058 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Stephen Belanger

commit sha e432470ed2ea5210cc4b70cedab2aaec6addfbe6

deps: V8: cherry-pick eec10a2fd8fa Original commit message: [promisehook] Add before/after hooks to thenable tasks This will allow Node.js to properly track async context in thenables. Change-Id: If441423789a78307a57ad7e645daabf551cddb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Gus Caplan <me@gus.host> Cr-Commit-Position: refs/heads/master@{#68207} Refs: https://github.com/v8/v8/commit/eec10a2fd8fa4d0e7f5e32dedbd239d938a5dd87 PR-URL: https://github.com/nodejs/node/pull/33778 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

cjihrig

commit sha 03cc3fd47834d383a9e2a72d8993390aeeddc5e2

deps: update V8 postmortem metadata script This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation for V8 8.4. PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Benjamin Coe

commit sha 61c618d54f02f4f5c64330328ba4d96cd18387fa

deps: V8: backport 2d5017a0fc02 Original commit message: [coverage] remove the last continuation range before synthetic return Rather than only removing the continuation range for the last return statement prior to a synthetic return statement, remove the continuation tracking for whatever statement occurs prior to the synthetic return. Bug: v8:10628 Change-Id: Ieb8e393479c9811cf1b9756840bbfdbe7f44a1b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280585 Commit-Queue: Benjamin Coe <bencoe@google.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#68719} Refs: https://github.com/v8/v8/commit/2d5017a0fc0203c9657394e7f86158bac8440ba4 PR-URL: https://github.com/nodejs/node/pull/34272 Refs: https://github.com/bcoe/c8/issues/229 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Ujjwal Sharma

commit sha 03bf4ed0fa1dc0e2c00a5d45111deec6e78ef3fe

tools: update V8 gypfiles for 8.4 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Michaël Zasso

commit sha b1a0efacf2ed5f8d0c0a5066289a9e5e3035acc1

deps: bump minimum icu version to 67 Bump minimum version of ICU needed to build node to 67. Refs: https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

cjihrig

commit sha 9a0aaa610706bfe7aeb2234b085cdcb912403c90

test: remove test/v8-updates/test-postmortem-metadata.js The postmortem metadata test is no longer used to maintain postmortem debugging tools. Since it frequently breaks on V8 updates, it makes more sense to just remove it. PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

cjihrig

commit sha 2abbaddca98d668538d8bba39502803ab050f4c3

test: add WASI test for file resizing This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: https://github.com/nodejs/node/pull/31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 16 days

push eventgengjiawen/node-github-workflow

Jiawen Geng

commit sha 9972f3ab624e93e04ee0bcf43fe697b62114ecc0

add quic build flag

view details

push time in 16 days

pull request commentnodejs/node

src: prefer C++ empty() in boolean expressions

Maybe also add readability-container-size-empty to https://github.com/nodejs/node/blob/a42dcbeb43ab22c0db07c4e0a9eab5e0f44578f4/src/.clang-tidy.

tniessen

comment created time in 16 days

issue commentnodejs/node

ninja build failed

I cannot reproduce without --experimental-quic. @gengjiawen is that option mandatory to fail the build?

I remove the --experimental-quic flag, the build passed. cc @nodejs/quic

gengjiawen

comment created time in 16 days

more