pull request commentdocker/cli
Adding example of != in command list
@thaJeztah Just changed the examples
comment created time in 5 days
push eventdavid-yu/cli
commit sha d9ff1683c8881e2692c7f6f8a6cb17820a616c19
Update image_prune.md
push time in 5 days
pull request commentdocker/cli
Bump compose-on-kubernetes from v0.4.25-alpha1 to v0.5.0-alpha1
@thaJeztah Could you review please?
comment created time in 6 days
pull request commentdocker/cli
Adding example of != in command list
@tiborvass This is the PR that implemented this change: https://github.com/moby/moby/pull/30740/
comment created time in 6 days
PR opened docker/cli
Adding != filter example to command list
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/docker/cli/blob/master/CONTRIBUTING.md
** Make sure all your commits include a signature generated with git commit -s **
For additional information on our contributing process, read our contributing guide https://docs.docker.com/opensource/code/
If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx"
Please provide the following information: -->
- What I did
- How I did it
- How to verify it
- Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->
- A picture of a cute animal (not mandatory but encouraged)
pr created time in 7 days
push eventdavid-yu/cli
commit sha 09f926e28b90c812bbb5eda7a5ce60fb4edddeb3
Adding example of != in command list Adding != filter example to command list
push time in 7 days
PR opened docker/docker.github.io
Removing IBM Z references cc @traci-morrison
<!--Thanks for your contribution. See CONTRIBUTING for this project's contribution guidelines. Remove these comments as you go.
DO NOT edit files and directories listed in _data/not_edited_here.yaml.
These are maintained in upstream repos and changes here will be lost.
Help us merge your changes more quickly by adding details and setting metadata
(such as labels, milestones, and reviewers) over at the right-hand side.-->
Proposed changes
<!--Tell us what you did and why-->
Unreleased project version (optional)
<!--If this change only applies to an unreleased version of a project, note
that here and base your work on the vnext- branch for your project. If
this doesn't apply to this PR, you can remove this whole section.
Set a milestone if appropriate. -->
Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other Github projects -->
pr created time in 15 days
push eventdavid-yu/docker.github.io
commit sha 5d32d52d35c62784cc3c730ad918cfe59cee994d
Removing IBM Z references Removing IBM Z references
push time in 15 days
issue commentkubernetes/kubernetes
Support newer versions of docker: 19.x
Ok thank you, that sounds like a good process we can follow moving forward.
comment created time in 16 days
issue commentkubernetes/kubernetes
Support newer versions of docker: 19.x
Also let me know if there is anything else that is needed to close this issue out. Thanks.
comment created time in 16 days
issue commentkubernetes/kubernetes
Support newer versions of docker: 19.x
Thank you @neolit123. Appreciate the PR, we typically test engines for major versions of Engine that are released like 19.03 with the latest version of Kubernetes that is available at the time. On our next engine, we will re-run the test and submit the results to testgrid. Let me know how I can better coordinate this.
comment created time in 16 days
issue commentkubernetes/kubernetes
Support newer versions of docker: 19.x
Hi folks, David from Docker here, we have run and validated Docker Engine 19.03 for Kubernetes 1.14 back in June, so Docker 19.03 is indeed supported for Kubernetes 1.14 and above: https://testgrid.k8s.io/sig-node-docker#Summary
Let me know how else we can help.
comment created time in 19 days
Pull request review commentmoby/moby
Add support for sending down service Running and Desired task counts
paths: - `label=<service label>` - `mode=["replicated"|"global"]` - `name=<service name>`+ - name: "status"+ in: "query"+ type: "boolean"+ description: "Include service status, with count of running and desired tasks"+ default: false
Thanks for looking into this @dperny
comment created time in a month
PR opened docker/docker.github.io
Missing quote from restore docs
<!--Thanks for your contribution. See CONTRIBUTING for this project's contribution guidelines. Remove these comments as you go.
DO NOT edit files and directories listed in _data/not_edited_here.yaml.
These are maintained in upstream repos and changes here will be lost.
Help us merge your changes more quickly by adding details and setting metadata
(such as labels, milestones, and reviewers) over at the right-hand side.-->
cc @DawnWood-Docker
Proposed changes
<!--Tell us what you did and why-->
Unreleased project version (optional)
<!--If this change only applies to an unreleased version of a project, note
that here and base your work on the vnext- branch for your project. If
this doesn't apply to this PR, you can remove this whole section.
Set a milestone if appropriate. -->
Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other Github projects -->
pr created time in 2 months
push eventdavid-yu/docker.github.io
commit sha 96b73b21ed9ac21007b41d3553a2ede2183f7718
Missing quote Missing quote from restore docs
push time in 2 months
pull request commentmoby/moby
Adding support for memory swap settings for services
Is this ready to merge?
comment created time in 2 months
pull request commentmoby/moby
Add support for sending down service Running and Desired task counts
@thaJeztah Could you re-review as well? Thanks.
comment created time in 2 months
pull request commentmoby/moby
Add support for sending down service Running and Desired task counts
@dperny Is this ready for re-review? cc @thaJeztah @cpuguy83
comment created time in 2 months
Pull request review commentdocker/docker.github.io
Once you do that, you can start managing your UCP nodes: ```bash docker node ls ```++## Use the API to manage your nodes+You can also modify the UCP config through the [/api/ucp/config-toml API](/reference/ucp/3.1/api/).
@traci-morrison This comment needs to be added to the doc. The node update API docs should be part of the UCP API docs.
comment created time in 2 months
pull request commentdocker/docker.github.io
Updating requirements for AWS, Azure
cc @DawnWood-Docker Some slight changes here for cluster pre-requisites
comment created time in 2 months
push eventdavid-yu/docker.github.io
commit sha 59001c6d5e69aec5d0d49937856d9b9447692187
Azure pre-requisites Azure pre-req change
push time in 2 months
PR opened docker/docker.github.io
<!--Thanks for your contribution. See CONTRIBUTING for this project's contribution guidelines. Remove these comments as you go.
DO NOT edit files and directories listed in _data/not_edited_here.yaml.
These are maintained in upstream repos and changes here will be lost.
Help us merge your changes more quickly by adding details and setting metadata
(such as labels, milestones, and reviewers) over at the right-hand side.-->
Refining pre-requisites for AWS and Azure
Proposed changes
<!--Tell us what you did and why-->
Unreleased project version (optional)
<!--If this change only applies to an unreleased version of a project, note
that here and base your work on the vnext- branch for your project. If
this doesn't apply to this PR, you can remove this whole section.
Set a milestone if appropriate. -->
Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other Github projects -->
pr created time in 2 months
push eventdavid-yu/docker.github.io
commit sha edec91e619469fc9ca434404084c9b7670ef94cf
Updating requirements for AWS, Azure
push time in 2 months
pull request commentdocker/docker.github.io
Updating doc with better formatting
Please merge @DawnWood-Docker I don't have permissions
comment created time in 2 months
PR opened docker/docker.github.io
Formatting issues with commands
<!--Thanks for your contribution. See CONTRIBUTING for this project's contribution guidelines. Remove these comments as you go.
DO NOT edit files and directories listed in _data/not_edited_here.yaml.
These are maintained in upstream repos and changes here will be lost.
Help us merge your changes more quickly by adding details and setting metadata
(such as labels, milestones, and reviewers) over at the right-hand side.-->
Proposed changes
Changed formatting for commands cc @DawnWood-Docker
Unreleased project version (optional)
<!--If this change only applies to an unreleased version of a project, note
that here and base your work on the vnext- branch for your project. If
this doesn't apply to this PR, you can remove this whole section.
Set a milestone if appropriate. -->
Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other Github projects -->
pr created time in 2 months
push eventdavid-yu/docker.github.io
commit sha 667d70e226846e3e3bbd97f6786d7fd334ba6f44
Updating doc with better formatting Formatting issues with commands
push time in 2 months
pull request commentdocker/docker.github.io
adding new cluster doc for azure
Thanks @DawnWood-Docker !
comment created time in 2 months
pull request commentdocker/docker.github.io
[wip]adding new cluster doc for azure
@DawnWood-Docker Would it be possible to have the headers of each section be the same as what's in Cluster for AWS? https://docs.docker.com/cluster/aws/ or perhaps the AWS Cluster docs to match what's here?
comment created time in 2 months
pull request commentdocker/docker.github.io
Add install Helm on Docker EE section
We should call it Docker Enterprise and not EE. I am ok with mentioning Helm as part of the Kube CLI docs page, but we should at least move the content over to that page as opposed to assume that kubectl covers the specific ask, just wanted to be clear.
comment created time in 3 months