profile
viewpoint
Bartosz Sosnowski bzoz Janea Systems Poland

bzoz/ed-ltd-seller 12

Find best place to sell LTD near Kirre's Icebox

bzoz/native-hdr-histogram 1

node.js bindings for hdr histogram C implementation

bzoz/PowerToys 1

Windows system utilities to maximize productivity

bzoz/31886_issue_test 0

Test for https://github.com/nodejs/node/issues/31886

bzoz/autocannon 0

fast HTTP benchmarking tool written in Node.js

bzoz/cheerio 0

Fast, flexible, and lean implementation of core jQuery designed specifically for the server.

bzoz/commander.js 0

node.js command-line interfaces made easy

bzoz/csv-parser 0

Streaming csv parser inspired by binary-csv that aims to be faster than everyone else

bzoz/electron 0

:electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS

push eventJaneaSystems/node

Bartosz Sosnowski

commit sha 423b3bc92bb2cf9a9f981c5e1d1e7698e0172e7e

fixup: add logging

view details

push time in 3 hours

issue commentnodejs/node

Chocolatey dependecy will not install using Node.js Win 10 installer

@ralfhauser it will be in the Start menu

vectorkt

comment created time in 18 hours

pull request commentnodejs/node

process: correctly parse Unicode in NODE_OPTIONS

Fixed some nits and rebased.

bzoz

comment created time in 21 hours

push eventJaneaSystems/node

Robert Nagy

commit sha 02c4869beec52d2664c747d520dfe078d2b3c714

stream: fix Duplex._construct race Ensures that _construct has finished before invoking _destroy. The 'constructed' property was not properly set to false for both writable and readable state. Fixes: https://github.com/nodejs/node/issues/34448 PR-URL: https://github.com/nodejs/node/pull/34456 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Shelley Vohr

commit sha 3f455cbddb413caa2f0d1f902d17bc2ea2824a56

build: don't run Actions on non-master pushes PR-URL: https://github.com/nodejs/node/pull/34464 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha feb93c4e8425b4fce96d92b6072c6e8b6cc634fd

src: guard against nullptr deref in TimerWrapHandle::Stop Refs: https://github.com/nodejs/node/pull/34454 PR-URL: https://github.com/nodejs/node/pull/34460 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Myles Borins

commit sha a981c65b9092d9317603ab25ec8b67aec11feffc

2020-07-21, Version 14.6.0 (Current) Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 * upgrade to libuv 1.38.1 (Colin Ihrig) https://github.com/nodejs/node/pull/34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](https://github.com/nodejs/node/pull/33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) https://github.com/nodejs/node/pull/32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) https://github.com/nodejs/node/pull/34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) https://github.com/nodejs/node/pull/34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) https://github.com/nodejs/node/pull/33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) https://github.com/nodejs/node/pull/34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) https://github.com/nodejs/node/pull/34360 * add sxa as collaborator (Stewart X Addison) https://github.com/nodejs/node/pull/34338 * add ruyadorno to collaborators (Ruy Adorno) https://github.com/nodejs/node/pull/34297 PR-URL: https://github.com/nodejs/node/pull/34371

view details

Anna Henningsen

commit sha 08b6335c9c33a0e0af69a85a75b40bd8f6e163c6

events: re-use the same isTrusted getter Creating a new function each time the property descriptor is set comes with performance overhead, since these functions have different identities, even if they contain the same code. Refs: https://twitter.com/tverwaes/status/1285496612618473472 PR-URL: https://github.com/nodejs/node/pull/34459 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

Anna Henningsen

commit sha 687dbd85263f433cc351c6daa83f9296a1d0bb4f

src: do not crash if ToggleAsyncHook fails during termination In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of https://github.com/nodejs/node/issues/34361. Fixes: https://github.com/nodejs/node/issues/34361 PR-URL: https://github.com/nodejs/node/pull/34362 Fixes: https://github.com/nodejs/node/issues/27261 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha b0b52b2023f5cd0df4ae921850815586b4313dca

test: fix flaky test-watch-file PR-URL: https://github.com/nodejs/node/pull/34420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Andrey Pechkurov

commit sha f8eaeb0c8e3196eb9d2ec8fd818c36aa27e31f72

zlib: switch to lazy init for zlib streams PR-URL: https://github.com/nodejs/node/pull/34048 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Harshitha K P

commit sha 07b3aae04e659d3681b9055164f4543c8c59b07a

doc: add HarshithaKP to collaborators Fixes: https://github.com/nodejs/node/issues/34242 PR-URL: https://github.com/nodejs/node/pull/34417 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

Joyee Cheung

commit sha f4f191bbc26c367ed8fa56c2d1297ef437c5f0fb

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See https://github.com/nodejs/node/issues/31074. PR-URL: https://github.com/nodejs/node/pull/34454 Fixes: https://github.com/nodejs/node/issues/34435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Anna Henningsen

commit sha 7603c7e50c3ae453db9702916f740618029020ba

worker: set trackUnmanagedFds to true by default This prevents accidental resource leaks when terminating or exiting Worker that own FDs opened through `fs.open()`. Refs: https://github.com/nodejs/node/pull/34303 PR-URL: https://github.com/nodejs/node/pull/34394 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Ruy Adorno

commit sha bfef588339d49201b83bc0e048a05560b2245fda

doc: add author-ready label ref to onboarding doc The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: https://github.com/nodejs/node/pull/34381 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Shelley Vohr

commit sha 90ee98a7d14829a6c7c6fc6e1700e58c3c25b92d

2020-07-22, Version 12.18.3 'Erbium' (LTS) Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) [#34246](https://github.com/nodejs/node/pull/34246) * update node-inspect to v2.0.0 (Jan Krems) [#33447](https://github.com/nodejs/node/pull/33447) * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](https://github.com/nodejs/node/pull/33521) PR-URL: https://github.com/nodejs/node/pull/34343

view details

Rich Trott

commit sha 3caa2e256bd403e0fb06cfbefc0338462f2c60d9

build: do not run benchmark tests on 'make test' Fixes: https://github.com/nodejs/node/issues/34427 PR-URL: https://github.com/nodejs/node/pull/34434 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha e7ed066782c8223f6c832286cf7e2ed12e18ffe9

test: force resigning of app In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: https://github.com/nodejs/node/pull/33944 PR-URL: https://github.com/nodejs/node/pull/34331 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Anna Henningsen

commit sha a7cf8da63179ea7cb84cb5f62248f72b44d5d049

test: fixup worker + source map test The messaging code uses `Object.defineProperty()`, which accesses `value` on `Object.prototype` by default, so some calls to the getter here would actually be expected. Instead, make the list of accessed properties more specific to the tested source map code to avoid flakiness. Refs: https://twitter.com/addaleax/status/1276289101671608320 Refs: https://github.com/nodejs/node/pull/34057 PR-URL: https://github.com/nodejs/node/pull/34446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 06765d8a438ab8f9e01f7a3162e11b40cb5b8029

test: delete invalid test This test has not been working correctly since at least a555be2e45b2. Since it tests internals, any replacement test might become invalid in a similar way. Refs: https://github.com/nodejs/node/pull/34057 PR-URL: https://github.com/nodejs/node/pull/34445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 16b11cd2adaa5f60382a7f205f893f38a5061fff

events: expand NodeEventTarget functionality Enable `NodeEventTarget` as a base class for `MessagePort`, by enabling special processing of events for Node.js listeners, and removing implicit constructors/private properties so that classes can be made subclasses of `NodeEventTarget` after they are created. PR-URL: https://github.com/nodejs/node/pull/34057 Refs: https://twitter.com/addaleax/status/1276289101671608320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Anna Henningsen

commit sha 459d3a015afbdfda7f2ff214a7f3b62875958fbb

worker: make MessagePort inherit from EventTarget Use `NodeEventTarget` to provide a mixed `EventEmitter`/`EventTarget` API interface. PR-URL: https://github.com/nodejs/node/pull/34057 Refs: https://twitter.com/addaleax/status/1276289101671608320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Rich Trott

commit sha 2c3092088679b355804416eb8afcf6a667a0df40

doc: use sentence-case in quic.md headers For consistency with the rest of our docs and our style guide, use sentence-case rather than headline-case in the headers in quic.md. PR-URL: https://github.com/nodejs/node/pull/34453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 21 hours

pull request commentlibuv/libuv

tcp: fail instantly if local port is unbound

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2005/

bzoz

comment created time in a day

pull request commentlibuv/libuv

tcp: fail instantly if local port is unbound

Updated, PTAL

bzoz

comment created time in a day

push eventJaneaSystems/libuv

Bartosz Sosnowski

commit sha ee36f8f942e57ab0abe9b9259885e36a735c5e0d

fixup: nits

view details

push time in a day

issue commentnodejs/node-gyp

node-gyp build error

What VS version do you have installed with what workloads?

SetWeather

comment created time in a day

issue commentnodejs/node

Chocolatey dependecy will not install using Node.js Win 10 installer

"Unable to connect to the remote server" - was your internet connection up?

There is also this https://github.com/nodejs/node/issues/33140, but your error message does not show that.

vectorkt

comment created time in a day

issue commentnodejs/node

v14.6.0 dll build error

Oh, and manually removing v8_base_without_compiler from node References in VS solves this.

Reveares

comment created time in 2 days

issue commentnodejs/node

v14.6.0 dll build error

Using this patch:

diff --git a/node.gyp b/node.gyp
index 6dd9541cc5..302e9ba269 100644
--- a/node.gyp
+++ b/node.gyp
@@ -823,6 +823,7 @@
             'Dbghelp',
             'Psapi',
             'Ws2_32',
+            'Winmm'
           ],
         }],
         [ 'node_use_etw=="true"', {

will fix this linking error, but it will open another can of worms:

v8_base_without_compiler.lib(basic-block-profiler.obj) : error LNK2005: "public: static class v8::internal::BasicBlockProfiler * __cdecl v8::internal::BasicBlockProfiler::Get(void)" (?Get@BasicBlockProfiler@internal@v8@@SAPEAV123@XZ) already defined in libnode.lib(libnode.dll) [C:\...\node\node.vcxproj]
v8_base_without_compiler.lib(machine-type.obj) : error LNK2005: "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl v8::internal::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,class v8::internal::MachineType)" (??6internal@v8@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV23@VMachineType@01@@Z) already defined in libnode.lib(libnode.dll) [C:\...\node\node.vcxproj]
v8_base_without_compiler.lib(machine-type.obj) : error LNK2005: "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl v8::internal::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,enum v8::internal::MachineRepresentation)" (??6internal@v8@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV23@W4MachineRepresentation@01@@Z) already defined in libnode.lib(libnode.dll) [C:\...\node\node.vcxproj]
v8_base_without_compiler.lib(machine-type.obj) : error LNK2005: "char const * __cdecl v8::internal::MachineReprToString(enum v8::internal::MachineRepresentation)" (?MachineReprToString@internal@v8@@YAPEBDW4MachineRepresentation@12@@Z) already defined in libnode.lib(libnode.dll) [C:\...\node\node.vcxproj]
Reveares

comment created time in 2 days

issue commentnpm/cli

[BUG] Cannot read property 'resolve' of undefined on 64-bit npm installation

@castrojo Sorry, cannot reproduce. Are there maybe some setup instructions that we could follow to try to reproduce it?

castrojo

comment created time in 3 days

issue closednodejs/node

Cannot resolve path through different drivers inside WSL

<!-- Thank you for reporting an issue.

This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help

Please fill in as much of the template below as you're able.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name -->

  • Version: 13.14.0
  • Platform: 64-bit (Windows)
  • Subsystem: Function.Module._resolveFilename

What steps will reproduce the bug?

There is a case where developers hopes to use node in Windows (IDEA) and an embedded linux kernel (Terminal), a.k.a WSL at the same time, in order to run within a same node environment. However, as the StackOverflow question mentioned, node throw an error when resolving path:

# pwd
/mnt/c
# node /mnt/f/test.js
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module '\\wsl$\Ubuntu-20.04\mnt\f\test.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)

For my situation, the Node I installed was in Windows instead of WSL, so that karma can be run via IDEA as it detect process.env to find launchable browsers.

How often does it reproduce? Is there a required condition?

When running a script through Windows drivers like running F:/test.js in C:/ folder in the example above.

What is the expected behavior?

Adapt WSL

What do you see instead?

Node has tried to look up a mixed path.

closed time in 3 days

aleen42

issue commentnodejs/node

Cannot resolve path through different drivers inside WSL

Going to close this, since there was no follow-up. Feel free to reopen with more info.

aleen42

comment created time in 3 days

issue closednodejs/node-gyp

Cant find dll (with out .h and .lib files). absolute path.

<!-- Thank you for reporting an issue!

Remember, this issue tracker is for reporting issues ONLY with node-gyp.

If you have an issue installing a specific module, please file an issue on that module's issue tracker (npm issues modulename). Open issue here only if you are sure this is an issue with node-gyp, not with the module you are trying to build.

Fill out the form below. We probably won't investigate an issue that does not provide the basic information we require.

-->

  • Node Version: <!-- node -v and npm -v -->12.18.2
  • Platform: <!-- uname -a (UNIX), or systeminfo | findstr /B /C:"OS Name" /C:"OS Version" /C:"System Type" (Windows) -->Windows10
  • Compiler: <!-- cc -v (UNIX) or msbuild /version & cl (Windows) -->vs2019
  • Module: <!-- what you tried to build/install -->addons to import dll

<details><summary>Verbose output (from npm or node-gyp):</summary>

no error but dll is null
HMODULE hDLL = LoadLibrary("F:\\mydll.dll");

</details>

<!-- Any further details -->

When i use nodejs addons to import dll. I found it cant find dll and i dont know why.

closed time in 3 days

AndrewFrank-zxy

issue commentnodejs/node-gyp

Cant find dll (with out .h and .lib files). absolute path.

I'll guess that whatever the issue was, it is gone now. Feel free to reopen if you provide more info.

AndrewFrank-zxy

comment created time in 3 days

issue closednodejs/node-gyp

Command failed: node-gyp rebuild --jobs max

  • Node Version: <!-- node -v and npm -v --> node -v v12.18.3 npm -v 6.14.6 node-gyp -v 5.1.0

  • Platform: Windows7

  • Compiler: windows-build-tools 5.2.2 (not sure about this part)

  • Module: opencv4nodejs

<details><summary>Verbose output (from npm or node-gyp):</summary>

ERR! Error: Command failed: node-gyp rebuild --jobs max
gyp http GET https://nodejs.org/download/release/v12.18.3/node-v12.18.3-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v12.18.3/node-v12.18.3-headers.tar.gz
gyp ERR! UNCAUGHT EXCEPTION
gyp ERR! stack TypeError: tar.extract is not a function
gyp ERR! stack     at Request.<anonymous> (F:\nodejs\node_modules\npm\node_modules\node-gyp\lib\install.js:199:22)
gyp ERR! stack     at Request.emit (events.js:327:22)
gyp ERR! stack     at Request.onRequestResponse (F:\nodejs\node_modules\npm\node_modules\request\request.js:1066:10)
gyp ERR! stack     at ClientRequest.emit (events.js:315:20)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:596:27)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:119:17)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:469:22)
gyp ERR! stack     at TLSSocket.emit (events.js:315:20)
gyp ERR! stack     at addChunk (_stream_readable.js:295:12)
gyp ERR! stack     at readableAddChunk (_stream_readable.js:271:9)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "F:\\nodejs\\node.exe" "F:\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--jobs" "max"
gyp ERR! cwd F:\nodejs\node_global\node_modules\opencv4nodejs
gyp ERR! node -v v12.18.3
gyp ERR! node-gyp -v v5.1.0
gyp ERR! This is a bug in `node-gyp`.
gyp ERR! Try to update node-gyp and file an Issue if it does not help:
gyp ERR!     <https://github.com/nodejs/node-gyp/issues>

</details>

<!-- Any further details -->

closed time in 3 days

qsjh898

issue commentnodejs/node-gyp

Command failed: node-gyp rebuild --jobs max

Could not reproduce. I tried installing opencv4nodejs package with Node.js 12.18.3 on Windows 10 and it installed successfully.

Sorry, Windows 7 is no longer supported.

qsjh898

comment created time in 3 days

pull request commentnodejs/node

doc: add Powershell oneliner to get Windows version

It was added in v12.17.0, we could skip it.

saitonakamura

comment created time in 8 days

pull request commentnodejs/node

doc: add Powershell oneliner to get Windows version

@DerekNonGeneric, works on my box:

PS C:\Users\ja> node -v
v14.6.0
PS C:\Users\ja> node -e "const os=require('os'); console.log(os.platform(), os.version(), os.release(), os.arch(), os.freemem(), os.totalmem(), process.arch, process.version)"
win32 Windows 10 Pro 10.0.19041 x64 9104707584 17082380288 x64 v14.6.0

What error do you get?

saitonakamura

comment created time in 9 days

pull request commentnodejs/node

doc: add Powershell oneliner to get Windows version

Why just not use Node to get the data?

node -e "const os=require('os'); console.log(os.platform(), os.version(), os.release(), os.arch(), os.freemem(), os.totalmem(), process.arch, process.version)"

We don't really have "Node is not working at all" issues, and this will get all the data that we need.

saitonakamura

comment created time in 9 days

issue commentnodejs/node

v14.6.0 dll build error

Can reproduce. Also - I can't find a revision that would build the dll successfully, so it looks this is broken for some time now.

/cc @nodejs/platform-windows @nodejs/build-files

Reveares

comment created time in 9 days

issue closednodejs/node-gyp

Recommend users install win32 version of Python rather than Microsoft Store package

<!-- Thank you for reporting an issue!

Remember, this issue tracker is for reporting issues ONLY with node-gyp.

If you have an issue installing a specific module, please file an issue on that module's issue tracker (npm issues modulename). Open issue here only if you are sure this is an issue with node-gyp, not with the module you are trying to build.

Fill out the form below. We probably won't investigate an issue that does not provide the basic information we require.

-->

The issue is about documentation and thus much of the below environment info is not applicable.

  • Node Version: N/A
  • Platform: Windows 10
  • Compiler: N/A
  • Module: N/A

It might be better to recommend installing the win32 version of Python over the Microsoft Store package because of issues with accessing certain shared locations (see "Known Issues" section), most importantly the previously mentioned locations includes %TEMP%

I would be curious to see other people's opinion on which version should be recommended

closed time in 10 days

Toothless204

issue commentnodejs/node-gyp

Recommend users install win32 version of Python rather than Microsoft Store package

@Toothless204 thanks for your suggestion, but as per @cclauss answer, we will stick to the store package.

Toothless204

comment created time in 10 days

issue commentnodejs/node-gyp

Cant find dll (with out .h and .lib files). absolute path.

You are trying to use LoadLibrary from a node native module, right?

If the module is null, use GetLastError to get the error code.

AndrewFrank-zxy

comment created time in 11 days

issue closednodejs/node-gyp

Error installing canvas

Error:

gyp ERR! build error 
gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin\MSBuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\LENOVO LEGION\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Windows_NT 10.0.18362
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\LENOVO LEGION\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "build" "--fallback-to-build" "--module=C:\\Users\\LENOVO LEGION\\Documents\\GitHub\\Elysium\\node_modules\\canvas\\build\\Release\\canvas.node" "--module_name=canvas" "--module_path=C:\\Users\\LENOVO LEGION\\Documents\\GitHub\\Elysium\\node_modules\\canvas\\build\\Release" "--napi_version=6" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v72"
gyp ERR! cwd C:\Users\LENOVO LEGION\Documents\GitHub\Elysium\node_modules\canvas
gyp ERR! node -v v12.18.2
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute 'C:\Program Files\nodejs\node.exe C:\Users\LENOVO LEGION\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js build --fallback-to-build --module=C:\Users\LENOVO LEGION\Documents\GitHub\Elysium\node_modules\canvas\build\Release\canvas.node --module_name=canvas --module_path=C:\Users\LENOVO LEGION\Documents\GitHub\Elysium\node_modules\canvas\build\Release --napi_version=6 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' 
(1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (C:\Users\LENOVO LEGION\Documents\GitHub\Elysium\node_modules\node-pre-gyp\lib\util\compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
node-pre-gyp ERR! System Windows_NT 10.0.18362
node-pre-gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\LENOVO LEGION\\Documents\\GitHub\\Elysium\\node_modules\\node-pre-gyp\\bin\\node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd C:\Users\LENOVO LEGION\Documents\GitHub\Elysium\node_modules\canvas
node-pre-gyp ERR! node -v v12.18.2
node-pre-gyp ERR! node-pre-gyp -v v0.11.0
node-pre-gyp ERR! not ok
Failed to execute 'C:\Program Files\nodejs\node.exe C:\Users\LENOVO LEGION\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js build --fallback-to-build --module=C:\Users\LENOVO LEGION\Documents\GitHub\Elysium\node_modules\canvas\build\Release\canvas.node --module_name=canvas --module_path=C:\Users\LENOVO LEGION\Documents\GitHub\Elysium\node_modules\canvas\build\Release --napi_version=6 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
npm WARN elysium@1.0.0 No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! canvas@2.6.1 install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the canvas@2.6.1 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

closed time in 11 days

Sixxty

issue commentnodejs/node-gyp

Error installing canvas

You have space in the the working directory ("LENOVO LEGION"). Unfortunately, this is not supported.

In future make sure you use the issue template.

Sixxty

comment created time in 11 days

issue closednodejs/node-gyp

win10 + BuildTools 2017 install error

D:\nodejs\brandmamq\nodejs> npm install -g node-expat

node-expat@2.3.18 install C:\Users\28218\AppData\Roaming\npm\node_modules\node-expat node-gyp rebuild

C:\Users\28218\AppData\Roaming\npm\node_modules\node-expat>if not defined npm_config_node_gyp (node "C:\Users\28218\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "C:\Users\28218\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild ) Warning: Missing input files: C:\Users\28218\AppData\Roaming\npm\node_modules\node-expat\build\deps\libexpat......\deps\libexpat\version.c gyp ERR! UNCAUGHT EXCEPTION gyp ERR! stack Error: spawn C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild.exe ENOENT gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19) gyp ERR! stack at onErrorNT (internal/child_process.js:469:16) gyp ERR! stack at processTicksAndRejections (internal/process/task_queues.js:84:21) gyp ERR! System Windows_NT 10.0.18362 gyp ERR! command "D:\Program Files\nodejs\node.exe" "C:\Users\28218\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" gyp ERR! cwd C:\Users\28218\AppData\Roaming\npm\node_modules\node-expat gyp ERR! node -v v12.18.2 gyp ERR! node-gyp -v v5.1.0 gyp ERR! This is a bug in node-gyp. gyp ERR! Try to update node-gyp and file an Issue if it does not help: gyp ERR! https://github.com/nodejs/node-gyp/issues npm ERR! code ELIFECYCLE npm ERR! errno 7 npm ERR! node-expat@2.3.18 install: node-gyp rebuild npm ERR! Exit status 7 npm ERR! npm ERR! Failed at the node-expat@2.3.18 install script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\28218\AppData\Roaming\npm-cache_logs\2020-07-31T06_46_37_681Z-debug.log

closed time in 11 days

wxgang168

issue commentnodejs/node-gyp

win10 + BuildTools 2017 install error

Please use the issue template.

wxgang168

comment created time in 11 days

issue commentnodejs/node

Error "Cannot read property 'resolve' of undefined"

You might try running this from a different folder than the one where Node.js is installed. And also - in the future, copy and paste the text from the console.

lulu5239

comment created time in 21 days

issue commentnodejs/node

Error "Cannot read property 'resolve' of undefined"

Cannot reproduce.

Can you add --verbose to the npm command? Like: npm i npm --verbose? And paste the output as a text here inside triple quotes like this: <pre>

PS C:\Users\ja\Work\test> npm i npm --verbos
npm info it worked if it ends with ok
npm verb cli [
npm verb cli   'C:\\Users\\ja\\AppData\\Local\\nvs\\node\\14.6.0\\x64\\node.exe',
npm verb cli   'C:\\Users\\ja\\AppData\\Local\\nvs\\node\\14.6.0\\x64\\node_modules\\npm\\bin\\npm-cli.js',
npm verb cli   'i',
npm verb cli   'npm',
npm verb cli   '--verbos'
npm verb cli ]
npm info using npm@6.14.6
npm info using node@v14.6.0
npm verb npm-session 4cf5ea06dfa4fb27
npm http fetch GET 304 https://registry.npmjs.org/npm 140ms (from cache)
npm timing stage:loadCurrentTree Completed in 612ms
npm timing stage:loadIdealTree:cloneCurrentTree Completed in 3ms
npm timing stage:loadIdealTree:loadShrinkwrap Completed in 227ms

</pre>

lulu5239

comment created time in 21 days

issue commentnodejs/node-gyp

gyp: binding.gyp not found (cwd: C:\Users\xxxx) while trying to load binding.gyp

@WilliamMega

gyp: binding.gyp not found (cwd: C:) while trying to load binding.gyp

cwd to the directory with the binding.gyp file.

ewallteam

comment created time in 21 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

Newest Node release, Node v14.6.0 contains the fix for this. Give it a spin.

Jan-Kruse

comment created time in 22 days

issue commentnodejs/node

Nodejs installation fails when trying to install visualstudio2017-workload-vctools

There is a free community edition.

You might not have VS2017 installed, but it shares the installation tool with other products. The error message looks like the installer complaining it is not up-to-date. Please check if you don't have anything in C:\Program Files (x86)\Microsoft Visual Studio\Installer or some other VS product in the start menu.

svdHero

comment created time in 22 days

push eventJaneaSystems/node

Bartosz Sosnowski

commit sha f5f8a79431bc8e642fa9ac3dd3bce91095ae862d

fixup: linter

view details

push time in 22 days

issue commentnodejs/node

Nodejs installation fails when trying to install visualstudio2017-workload-vctools

Hm.. now when I look at the log I see this:

2020-07-22T13:15:26 : Error : Failed to get product summaries. [installerId: SetupEngine, error: Please update Visual St
udio Installer before proceeding. at Microsoft.VisualStudio.Setup.UpdateRequiredException: https://download.visualstudio
.microsoft.com/download/pr/067fd8d0-753e-4161-8780-dfa3e577839e/a40b395007864ee750dcc529f537c21c20488629236b01750526dece
23505319/vs_Setup.exe
   at Microsoft.VisualStudio.Setup.ProductsProviderService.GetProductSummaries()]

2020-07-22T13:15:26 : Error : An installed product matching the following parameters cannot be found: installPath:  C:\P
rogram Files (x86)\Microsoft Visual Studio\2017\BuildTools

Do you have maybe other VS products installed? Maybe try running VS Installer - it should be in the start menu or in

"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vs_installer.exe"

If this fails you can try manually installing VS2017.

svdHero

comment created time in 22 days

PR opened nodejs/node

process: correctly parse Unicode in NODE_OPTIONS

Fixes an issue on Windows, where Unicode in NODE_OPTIONS was not parsed correctly.

Fixes: https://github.com/nodejs/node/issues/34399

Reused the code from node_env_var.cc for getting the enviroment variable value. <!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+38 -2

0 comment

2 changed files

pr created time in 22 days

push eventJaneaSystems/node

Bartosz Sosnowski

commit sha b41171c1a1927c8a2d8b4ceb8356981f2fb4df9a

process: correctly parse Unicode in NODE_OPTIONS Fixes an issue on Windows, where Unicode in NODE_OPTIONS was not parsed correctly. Fixes: https://github.com/nodejs/node/issues/34399

view details

push time in 22 days

create barnchJaneaSystems/node

branch : unicode-node-options

created branch time in 22 days

issue commentnodejs/node

Nodejs installation fails when trying to install visualstudio2017-workload-vctools

Tried it, works on my Windows Server 2012 R2 VM. I did get that big JSON error message about connection reliability, but VS2017 was installed anyway.

Could you try running from an elevated prompt:

choco upgrade -y visualstudio2017-workload-vctools

Also, could you check if your system is up-to-date? No pending updates, etc.?

svdHero

comment created time in 22 days

create barnchJaneaSystems/node

branch : backport-v12-33609

created branch time in 23 days

pull request commentnodejs/node

[v14.x backport] Forces Powershell to use tls1.2

CI: https://ci.nodejs.org/job/node-test-pull-request/32440/

bzoz

comment created time in 23 days

PR opened nodejs/node

[v12.x backport] Forces Powershell to use tls1.2

Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey.

Fixes: https://github.com/nodejs/node/issues/33140 PR-URL: https://github.com/nodejs/node/pull/33609 Reviewed-By: Bartosz Sosnowski bartosz@janeasystems.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com Reviewed-By: Tobias Nießen tniessen@tnie.de

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

0 comment

1 changed file

pr created time in 23 days

PR opened nodejs/node

[v14.x backport] Forces Powershell to use tls1.2

Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey.

Fixes: https://github.com/nodejs/node/issues/33140 PR-URL: https://github.com/nodejs/node/pull/33609 Reviewed-By: Bartosz Sosnowski bartosz@janeasystems.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com Reviewed-By: Tobias Nießen tniessen@tnie.de

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

0 comment

1 changed file

pr created time in 23 days

push eventJaneaSystems/node

Bartosz Sosnowski

commit sha 29e6c6318bfda4b5fbed0d2514686c304ccf2c21

Forces Powershell to use tls1.2 Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: https://github.com/nodejs/node/issues/33140 PR-URL: https://github.com/nodejs/node/pull/33609 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

push time in 23 days

create barnchJaneaSystems/node

branch : backport-v14-33609

created branch time in 23 days

pull request commentlibuv/libuv

tcp: fail instantly if local port is unbound

Looks like this only works on Windows 10.0.16299 and later: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1954/

bzoz

comment created time in 23 days

push eventJaneaSystems/libuv

Bartosz Sosnowski

commit sha 6491c739fd615154509dc3a53e5395bf8a0ab058

fixup: only use this on Windows 10.0.16299 or later

view details

push time in 23 days

issue commentnodejs/node

Nodejs installation fails when trying to install visualstudio2017-workload-vctools

Could you run the tools install script again (it should be in the start menu)? This might be just a temporary issue with choco.

svdHero

comment created time in 23 days

issue commentnodejs/node

Nodejs installation fails when trying to install visualstudio2017-workload-vctools

What is your exact windows version (you can run winver to get it)

svdHero

comment created time in 23 days

issue commentmicrosoft/PowerToys

[Settings] Design a mechanism to propagate specific system settings to the Settings app

For some stuff we have things done as separate functions, like https://github.com/microsoft/PowerToys/blob/master/src/common/monitors.h or https://github.com/microsoft/PowerToys/blob/master/src/common/windows_colors.h.

enricogior

comment created time in 24 days

pull request commentnodejs/node

build: fix test-ci-js task in Makefile

On Widows running vcbuild test-ci-js on master works, with one test failing (log here). I don't see it running benchmarks though, only JS tests

Trott

comment created time in 24 days

pull request commentlibuv/libuv

tcp: fail instantly if local port is unbound

Looks like on OS-es older than Win10/Server 2016 the change makes the connect take about 2min before timing out. Updated, now the change only affects supported systems.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1948/

bzoz

comment created time in a month

issue commentnodejs/node

fs.access returns incorrect information

@aleksey-hoffman could you provide the path you are trying to write the file to?

aleksey-hoffman

comment created time in a month

push eventJaneaSystems/libuv

Bartosz Sosnowski

commit sha 7b480c349d28346ca72599499b34aef15e2b3fe9

fixup: only use this on Windows ver >=10

view details

push time in a month

push eventJaneaSystems/libuv

Bartosz Sosnowski

commit sha 22178989abc1e3042dab6670e7182c4aac9e302b

fixup: skip ipv6 test on unsupported platforms

view details

push time in a month

push eventJaneaSystems/libuv

Ben Noordhuis

commit sha 10a9c25a125185968809d65de901d23183df8150

unix: use relaxed loads/stores for clock id This was part of commit c70dd705 ("unix: use relaxed loads/stores for feature checks") and was reviewed as such but I accidentally dropped it in the rebase before the final merge. Fixes: https://github.com/libuv/libuv/issues/2884 PR-URL: https://github.com/libuv/libuv/pull/2886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jameson Nash <vtjnash@gmail.com>

view details

Bartosz Sosnowski

commit sha e789d8995d95e384eede37f820790a82a2ba4473

tcp: fail instantly if local port is unbound On Windows when connecting to an unavailable port, the connect() will retry for 2s, even on loopback devices. This uses a call to WSAIoctl to make the connect() call fail instantly on local connections.

view details

push time in a month

PR opened nodejs/node

module: allowed module location list

Adds --allowed-module-location option that can be used to limit the paths Node.js is allowed to load modules from.

Fixes: https://github.com/nodejs/node/issues/34124

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+109 -0

0 comment

11 changed files

pr created time in a month

create barnchJaneaSystems/node

branch : limit-nodemodules-folders

created branch time in a month

pull request commentnodejs/node

Force Powershell to use tls1.2

Yes, this should also go to v12.x

jschpp

comment created time in a month

issue commentnodejs/node

http2 crash on h2spec check

Also reproduces on Linux.

songdongsheng

comment created time in a month

issue commentnodejs/node-addon-api

Failed in "npm run test"

Can reproduce with neither 12.18.2 and 14.5.0, with VS2019

Please provide:

  • entire --verbose log, put it inside backticks, like so: <pre>
log goes here

</pre> include the command that was used to run the test

  • Node version, system version

Did you:

  • run npm install?
  • run npm config set msvs_version [version you are using here]?
  • install MS Build Tools or Visual Studio?
gzx-miller

comment created time in a month

issue closednodejs/node

Copying then pasting text directly into node REPL freezes it - Windows

As subject says. It only happens with large amounts of text, maybe something in relation to the buffer size?

node version v12.16.2 64 bit Windows 10

  • Subsystem: none

What steps will reproduce the bug?

Open CMD, type "node" press enter to get the node repl. Now copy the below code, then right click in the node console to paste text. It will only paste the first line of code and freeze up node. It becomes completely unresponsive.

How often does it reproduce? Is there a required condition?

Everytime when the copied code seems to be over a certain size. Don't know what that size is but happens no matter what the code is. The sample code provided will replicate the issue.

What is the expected behavior?

All text is pasted and executed line by line like other copy and paste operations.

What do you see instead?

Node locks up after the first line of the copied text

Additional information

Sample code below. Here is a quick vid of node locking up as described above. https://streamable.com/ep7wqt The cursor just flashes but it is unresponsive to key strokes and doesn't do anything else. NOTE; the code has been changed to take out the IP so IF does execute it will error as I just replaced some keywords with random text. Ignore this, the point of it is to show that it won't copy and paste past the first line, it will freeze.

//{"_id":"56aba3108d6d183da42403c2"}
//placeholder
const request = require('request');
var mongoose = require ("mongoose");
var lodash = require ("lodash");
var myFuncs = require("./functions");



var item_urls;
var options = {
    json: true
  };

var test = [] ;
function updateDB (){
    var url = "get stuff";


    request(url, options, (error, res, body) =>{
        if (error) {
            return console.log(error)
          };

          if (!error && res.statusCode == 200) {
            console.log("executing cb1");
            item_urls = body.payload.items;
            myFuncs.fixItemIDs (item_urls);
            var primes = item_urls.filter(item => item.item_name.includes("Strun Wraith Set")); 
            for (item in primes) 
            {
                let url = `https://get more stuff/v1/items/${primes[item].url_name}`;
               // console.log (url);
                request(url, options, (error, res, body) =>{
                    if (error) {
                        return console.log(error)
                      };

                      if (!error && res.statusCode == 200) {

                          console.log(`Getting item ${url}`);
                          test.push(body.payload.item);
                          myFuncs.fixItemIDs (test);
                      }
                    });

            };  
            console.log ("done");          


          };
    });
}

updateDB();

closed time in a month

powershellwhizz

issue commentnodejs/node

Copying then pasting text directly into node REPL freezes it - Windows

Libuv was updated: https://github.com/nodejs/node/pull/34187, it includes the fix for this issue.

powershellwhizz

comment created time in a month

pull request commentbzoz/ed-ltd-seller

Improvement: When init checks for a default redis instance

One more: if you solve those two issues, I'll be happy to merge this. With some effort, first started app instance could fire up the DB, next instances could reuse it. They could share system or station data, but other parts of the app need to be changed, so the best prices tables would be separate.

rafaga

comment created time in a month

PR closed bzoz/ed-ltd-seller

Improvement: When init checks for a default redis instance

The current App doen't check if a running instance of Redis is running if there is one , then uses it.

+8 -3

1 comment

1 changed file

rafaga

pr closed time in a month

pull request commentbzoz/ed-ltd-seller

Improvement: When init checks for a default redis instance

Sorry, this won't work.

First, the app assumes it is the only one connected to the Redis/Memurai instance. When querying the DB for best sell prices it just does: https://github.com/bzoz/ed-ltd-seller/blob/97ad9273c404b12241f8a37f6d2cc1a1b78c7659/lib/memurai_db.js#L144-L147 If two instances were sharing the same DB, both of them would get the same data regardless of their set reference system and distance limit.

Second, is that I don't want to pollute user disks. When we start Redis/Memurai we also disable persistence. If we connect to the default instance, the data we collect will get saved to disk. This uses up disk space, and also we would need to handle that, to not use stale data from a previous run.

rafaga

comment created time in a month

issue commentbzoz/ed-ltd-seller

ED Discovery

What would be the point of the plugin?

Tracking user location - that is possible, maybe in some future version.

DawnTreader

comment created time in a month

issue closedbzoz/ed-ltd-seller

Memurai it is not cross-plataform

Have you considered using another database, because memurai is only for Windows.

closed time in a month

rafaga

issue commentbzoz/ed-ltd-seller

Memurai it is not cross-plataform

Updated the readme and made the app look for Redis on the non-Windows platforms: https://github.com/bzoz/ed-ltd-seller/commit/97ad9273c404b12241f8a37f6d2cc1a1b78c7659

rafaga

comment created time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 97ad9273c404b12241f8a37f6d2cc1a1b78c7659

Make the tool work on other platforms.

view details

push time in a month

created tagbzoz/ed-ltd-seller

tagv0.1.0

Find best place to sell LTD near Kirre's Icebox

created time in a month

release bzoz/ed-ltd-seller

v0.1.0

released time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 86239762b1cd2611f9daaeb5d9cc75cf646eecb2

Update README.md

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha da02338fabf5805576df093dea4f5b7bd0c230c4

Update README.md

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 90b705818b74c50d31b0dcf4dc59d70ee43ec3a3

Update README.md

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 8651d6409b3463bc7056f08c90eef7392b4d88cb

Update README.md

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha e3e35c37714cf145389f06203add713966866600

Update README.md

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 80875cd38c2d3347ac4428be87edc3e472fa11f5

Update screenshots

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha d556bc09d1c8c6ba217ea6d5b01878922f77f2e0

Make getting coords work better with multiple instances of the tracker running

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 0466b439bd8b436e45ca955a6858ee60518e3936

At least update message stats every 2.5s

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 0fb98b87dd96397bafd3480d5b4ffdb923e5de3c

Fix dropMarket

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha dc1c9a28c10cc11058d0065380cb79117e469a71

Update example run scripts

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 2ec785c280670f7ed333747ab693f99b2e420cfb

Update example run scripts

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 27ba15eba0d628ddc74e00aa0a6483f859b2c4a2

Add v0.1.0 screenshots

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 8b7498047d07e45d3c05199814b782eb08d7b89a

Add packet stats and iron out some other kinks

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 3583ad21acda3de7f134611ffade2990d167b260

Use colors for more fancy look

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 2fe97bce5ca144c5f0d3b95dd44d4353b495fe95

Use Table module for a nicer table

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 2ba68db4bd41a0d917beeeab28e5973b7fbdcad3

Take filter as command line arguments

view details

Bartosz Sosnowski

commit sha 9b08e197c961c5861463c0916da5b01db57dc2cc

WIP: track best trade inside one system

view details

Bartosz Sosnowski

commit sha c8ec9eeaf6654eacf78e880d9b64576a8d04b8f2

Make tracking insystem transfers work

view details

Bartosz Sosnowski

commit sha ca1bff44ab23308f87e697e205089582ee80f184

Improve arguments handling and data printing

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha ca1bff44ab23308f87e697e205089582ee80f184

Improve arguments handling and data printing

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha c8ec9eeaf6654eacf78e880d9b64576a8d04b8f2

Make tracking insystem transfers work

view details

push time in a month

create barnchbzoz/ed-ltd-seller

branch : track-transfers

created branch time in a month

issue commentbzoz/ed-ltd-seller

Memurai it is not cross-plataform

Memurai is 100% compatible with Redis, so you can use that on other platforms.

rafaga

comment created time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 6f8a6bddb331815feaa4d62b2f2c57bef7265701

Allow multiple app instances to run simultaneously

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha 32a5e1a12b1fadfbd78aa94d69c92c3370698a73

Extract preloaded systems into a separate app

view details

push time in a month

push eventbzoz/ed-ltd-seller

Bartosz Sosnowski

commit sha b33345cbb06b957bacb3b5b2e820c1026bf62ffb

Point to the release page not to the main branch

view details

push time in a month

created tagbzoz/ed-ltd-seller

tagv0.0.1

Find best place to sell LTD near Kirre's Icebox

created time in a month

release bzoz/ed-ltd-seller

v0.0.1

released time in a month

pull request commentlibuv/libuv

tcp: fail instantly if local port is unbound

Updated & rebased, PTAL. CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1943/

bzoz

comment created time in a month

push eventJaneaSystems/libuv

Ben Noordhuis

commit sha 4685be236b032ec6a60553a99d4365ab25dc368a

darwin: work around clock jumping back in time It was reported that mach_absolute_time() can jump backward in time when the machine is suspended. Use mach_continuous_time() when available to work around that (macOS 10.12 and up.) Fixes: https://github.com/libuv/libuv/issues/2891 PR-URL: https://github.com/libuv/libuv/pull/2894 Reviewed-By: Phil Willoughby <philwill@fb.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

Santiago Gimeno

commit sha 84305d856090ca96af1e10e34a106d2379ba9067

udp: fix write_queue cleanup on sendmmsg error This issue manifested on `connected` udp sockets trying to send datagrams to a non-existent server and returning `ECONNREFUSED` because an ICMP error was received before the actual sending was performed. PR-URL: https://github.com/libuv/libuv/pull/2899 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

David Carlier

commit sha 40bab5ed71dc046eb83eead197f037c44a090cc6

src: build fix for Android pipe2 needs GNU source defined. PR-URL: https://github.com/libuv/libuv/pull/2857 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

cjihrig

commit sha e8b989ea1f7f9d4083511a2caec7791e9abd1871

2020.07.04, Version 1.38.1 (Stable) Changes since version 1.38.0: * test: use last matching qemu version (cjihrig) * win, util: rearrange uv_hrtime (Bartosz Sosnowski) * test: skip signal_multiple_loops test on QEMU (gengjiawen) * build: add android build to CI (gengjiawen) * test: extend fs_event_error_reporting timeout (cjihrig) * build: link libkvm on netbsd only (Alexander Tokmakov) * linux: refactor /proc file reader logic (Ben Noordhuis) * linux: read load average from /proc/loadavg (Ben Noordhuis) * android: remove patch code for below 21 (gengjiawen) * win: fix visual studio 2008 build (Arenoros) * win,tty: fix deadlock caused by inconsistent state (lander0s) * unix: use relaxed loads/stores for feature checks (Ben Noordhuis) * build: don't .gitignore m4/ax_pthread.m4 (Ben Noordhuis) * unix: fix gcc atomics feature check (Ben Noordhuis) * darwin: work around clock jumping back in time (Ben Noordhuis) * udp: fix write_queue cleanup on sendmmsg error (Santiago Gimeno) * src: build fix for Android (David Carlier)

view details

cjihrig

commit sha 5b0398262a3f760340382b2d4fac82a89bb642e6

Add SHA to ChangeLog

view details

cjihrig

commit sha 032f2b1251be842438bfed6e688ef874bf85254c

Now working on version 1.38.2 Fixes: https://github.com/libuv/libuv/issues/2898

view details

Bartosz Sosnowski

commit sha f9b73d76684b067e8a9ee57f7bad7858a55743dc

tcp: fail instantly if local port is unbound On Windows when connecting to an unavailable port, the connect() will retry for 2s, even on loopback devices. This uses a call to WSAIoctl to make the connect() call fail instantly on local connections.

view details

push time in a month

more