profile
viewpoint
Bartosz Sosnowski bzoz Janea Systems Poland

bzoz/native-hdr-histogram 1

node.js bindings for hdr histogram C implementation

bzoz/PowerToys 1

Windows system utilities to maximize productivity

JaneaSystems/glob-args 1

CLI helper for globing arguments

bzoz/31886_issue_test 0

Test for https://github.com/nodejs/node/issues/31886

bzoz/autocannon 0

fast HTTP benchmarking tool written in Node.js

bzoz/cheerio 0

Fast, flexible, and lean implementation of core jQuery designed specifically for the server.

bzoz/commander.js 0

node.js command-line interfaces made easy

bzoz/csv-parser 0

Streaming csv parser inspired by binary-csv that aims to be faster than everyone else

bzoz/electron 0

:electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS

issue closednodejs/node-gyp

Colud not find my_node_addon on Windows

I have checked the npm directory nod_modules and node_gyp folder too but I could not find any folder with name.

closed time in 18 hours

ali-chaudhry

issue commentnodejs/node-gyp

Colud not find my_node_addon on Windows

No follow up, closing.

ali-chaudhry

comment created time in 18 hours

pull request commentnodejs/node-gyp

v7.0.0 Proposal

LGTM!

rvagg

comment created time in 18 hours

issue closednodejs/node-gyp

node-gyp sets plattform toolset to vs120_xp

<!-- Thank you for reporting an issue!

Remember, this issue tracker is for reporting issues ONLY with node-gyp.

If you have an issue installing a specific module, please file an issue on that module's issue tracker (npm issues modulename). Open issue here only if you are sure this is an issue with node-gyp, not with the module you are trying to build.

Fill out the form below. We probably won't investigate an issue that does not provide the basic information we require.

-->

  • Node Version: v12.16.3
  • Platform: OS Name: Microsoft Windows 10 Pro OS Version: 10.0.18363 N/A Build 18363 System Type: x64-based PC
  • Compiler: vs2019, installed the standard way, and vs2017, installed vid node.js dependency install
  • Module: blpapi <details><summary>Verbose output (from npm or node-gyp):</summary>
c:\fstx\20_git\github.com\bloomberg\blpapi-node>node-gyp configure --msvs_version=2017
gyp info it worked if it ends with ok
gyp info using node-gyp@6.1.0
gyp info using node@12.16.3 | win32 | x64
gyp info find Python using Python version 3.8.3 found at "C:\Python38\python.exe"
gyp info find VS using VS2017 (15.9.28307.1146) found at:
gyp info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools"
gyp info find VS run with --verbose for detailed information
gyp info spawn C:\Python38\python.exe
gyp info spawn args [
gyp info spawn args   'C:\\Users\\fstxb\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-I',
gyp info spawn args   'c:\\fstx\\20_git\\github.com\\bloomberg\\blpapi-node\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\fstxb\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\fstxb\\AppData\\Local\\node-gyp\\Cache\\12.16.3\\include\\node\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\fstxb\\AppData\\Local\\node-gyp\\Cache\\12.16.3',
gyp info spawn args   '-Dnode_gyp_dir=C:\\Users\\fstxb\\AppData\\Roaming\\npm\\node_modules\\node-gyp',
gyp info spawn args   '-Dnode_lib_file=C:\\\\Users\\\\fstxb\\\\AppData\\\\Local\\\\node-gyp\\\\Cache\\\\12.16.3\\\\<(target_arch)\\\\node.lib',
gyp info spawn args   '-Dmodule_root_dir=c:\\fstx\\20_git\\github.com\\bloomberg\\blpapi-node',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'c:\\fstx\\20_git\\github.com\\bloomberg\\blpapi-node\\build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
fstx: 2015
gyp info ok

c:\fstx\20_git\github.com\bloomberg\blpapi-node>node-gyp build
gyp info it worked if it ends with ok
gyp info using node-gyp@6.1.0
gyp info using node@12.16.3 | win32 | x64
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild.exe
gyp info spawn args [
gyp info spawn args   'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64'
gyp info spawn args ]
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Platform.targets(
67,5): error MSB8020: The build tools for v120_xp (Platform Toolset = 'v120_xp') cannot be found. To build using the v1
20_xp build tools, please install v120_xp build tools.  Alternatively, you may upgrade to the current Visual Studio too
ls by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [c:\fstx\20_git\g
ithub.com\bloomberg\blpapi-node\build\blpapijs.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\fstxb\AppData\Roaming\npm\node_modules\node-gyp\lib\build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:310:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Windows_NT 10.0.18363
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\fstxb\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "build"
gyp ERR! cwd c:\fstx\20_git\github.com\bloomberg\blpapi-node
gyp ERR! node -v v12.16.3
gyp ERR! node-gyp -v v6.1.0
gyp ERR! not ok

</details>

<!-- Any further details -->


edit by @bzoz: fixed formatting

closed time in 21 hours

fstx

issue commentnodejs/node-gyp

node-gyp sets plattform toolset to vs120_xp

No followup, closing.

fstx

comment created time in 21 hours

PR closed libuv/libuv

win, util: rearrange uv_hrtime

Rearrange math operations in uv_hrtime. This is a workaround for a probable compiler bug in VS2019.

Fixes: https://github.com/libuv/libuv/issues/1633

Big thanks to @saschanaz for substantial help in solving this issue.

+13 -13

4 comments

2 changed files

bzoz

pr closed time in 2 days

pull request commentlibuv/libuv

win, util: rearrange uv_hrtime

Landed in https://github.com/libuv/libuv/commit/796744869669842bd5405a71de8ba60b1556fc24

bzoz

comment created time in 2 days

push eventlibuv/libuv

Bartosz Sosnowski

commit sha 796744869669842bd5405a71de8ba60b1556fc24

win, util: rearrange uv_hrtime Rearrange math operations in uv_hrtime. This is a workaround for a probable compiler bug in VS2019. Fixes: https://github.com/libuv/libuv/issues/1633 PR-URL: https://github.com/libuv/libuv/pull/2866 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

push time in 2 days

issue closedlibuv/libuv

Assertion failed: new_time >= loop->time

  • Version: 1.16.1
  • Platform: Windows 7 64 Bit

Using latest node.js (libuv version 1.16.1) on my machine, causes the following error: Assertion failed: new_time >= loop->time, file src\win\timer.c, line 37

I'm using a non overclocked AMD FX-6300. Yesterday it worked fine, but after a reboot it does not work anymore.

closed time in 2 days

Jan-Kruse

pull request commentlibuv/libuv

win, util: rearrange uv_hrtime

hrtime_frequency_ is usually a multiple of scale, so scaled_freq ends up being an integer.

bzoz

comment created time in 2 days

pull request commentlibuv/libuv

win, util: rearrange uv_hrtime

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1918/

bzoz

comment created time in 2 days

PR opened libuv/libuv

win, util: rearrange uv_hrtime

Rearrange math operations in uv_hrtime. This is a workaround for a probable compiler bug in VS2019.

Fixes: https://github.com/libuv/libuv/issues/1633

Big thanks to @saschanaz for substantial help in solving this issue.

+13 -13

0 comment

2 changed files

pr created time in 2 days

create barnchJaneaSystems/libuv

branch : fix-qpc

created branch time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

Yay!

Can you test this one: https://github.com/bzoz/node/commit/710e1f6b6db681a1771cad1999b5fba53174c90b, its all those commits squashed and rebased onto current Node master. If that works, I'll open a PR.

Jan-Kruse

comment created time in 2 days

create barnchbzoz/node

branch : instrument-libuv-s

created branch time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

Definitely there is something off with the compiler, I'll get that reported to VS people.

In the meantime: maybe using unsigned instead of double for scale will help. Can you test this: https://github.com/bzoz/node/commit/7d904b50d26e3de831a50b6f11544e39647e24f5

Jan-Kruse

comment created time in 2 days

push eventbzoz/node

Bartosz Sosnowski

commit sha 7d904b50d26e3de831a50b6f11544e39647e24f5

use int for scale

view details

push time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

@saschanaz could you give this a spin: https://github.com/bzoz/node/commit/222b1e4d46ccb0d715272d3073cce91bb211fd24

It moves those math ops around, maybe it will help.

Jan-Kruse

comment created time in 2 days

push eventbzoz/node

Bartosz Sosnowski

commit sha 222b1e4d46ccb0d715272d3073cce91bb211fd24

Store freq as int

view details

push time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

Hm.. I'll try to rearrange some bits, I'll let you know when it is done.

BTW, thanks a lot!

Jan-Kruse

comment created time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

Can you try moving the assert(scale != 0); before the call to QPC? IDK, this looks like a compiler bug. We only call hr__time from uv_update_time with 1000 as scale and from uv_hrtime with 1000000000 as scale.

Jan-Kruse

comment created time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

How about this: https://github.com/bzoz/node/commit/e97f150f94574d364740331dc5e3ba9a1ee49996

Just two more asserts. For whatever reason, we end up with 0 on this line: https://github.com/bzoz/node/blob/e97f150f94574d364740331dc5e3ba9a1ee49996/deps/uv/src/win/util.c#L507.

Jan-Kruse

comment created time in 2 days

push eventbzoz/node

Bartosz Sosnowski

commit sha e97f150f94574d364740331dc5e3ba9a1ee49996

assert everything

view details

push time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

Yep, it should not.

Can you test one more: https://github.com/bzoz/node/commit/c57894331d1157b1065f22f18d84c745c7070f9e - it will GetLastError() if the QPC fails.

Jan-Kruse

comment created time in 2 days

push eventbzoz/node

Bartosz Sosnowski

commit sha c57894331d1157b1065f22f18d84c745c7070f9e

fail on QPC fail

view details

push time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

I hope we are getting close: https://github.com/bzoz/node/commit/50901dd2221ff92206fbce7f922c6a99b32829dc

It basically takes the current libuv and changes the assert to an if-statement. It will print the old and the new time value. It might not reproduce, or we might get confirmation that uv__hrtime sometimes returns 0.

Jan-Kruse

comment created time in 2 days

issue closednodejs/node

Pushed a branch to nodejs/node by mistake

I've accidentally pushed https://github.com/nodejs/node/tree/instrument-libuv to nodejs repo instead of my own. My git-fu is to low to fix this, I need help 😕

closed time in 2 days

bzoz

issue commentnodejs/node

Pushed a branch to nodejs/node by mistake

Thanks!

bzoz

comment created time in 2 days

delete branch nodejs/node

delete branch : instrument-libuv

delete time in 2 days

create barnchbzoz/node

branch : instrument-libuv

created branch time in 2 days

issue openednodejs/node

Pushed a branch to nodejs/node by mistake

I've accidentally pushed https://github.com/nodejs/node/tree/instrument-libuv to nodejs repo instead of my own. My git-fu is to low to fix this, I need help 😕

created time in 2 days

create barnchnodejs/node

branch : instrument-libuv

created branch time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

If QueryPerformanceCounter returned 0, the new_time would be uninitialized. Reading its value in the printf would be UB. Can you try this:

void uv_update_time(uv_loop_t* loop) {
  int64_t new_raw = 0;
  uint64_t new_time = uv__hrtime_ex(1000, &new_raw);
  if (new_time < loop->time) {
    fprintf(stderr, "Time error:\n"
                    "\tnew_time:       %lld\n"
                    "\tnew_raw:        %lld\n"
                    "\tloop->time:     %lld\n"
                    "\tloop->raw_time: %lld\n",
            new_time, new_raw, loop->time, loop->raw_time);
    fflush(stderr);
  }
  loop->time = new_time;
  loop->raw_time = new_raw;
}
Jan-Kruse

comment created time in 2 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

Could you maybe remove the GetLastError() and assert(), and flip the condition like this:

void uv_update_time(uv_loop_t* loop) {
  int64_t new_raw;
  uint64_t new_time = uv__hrtime_ex(1000, &new_raw);
  if (!(new_time >= loop->time)) {
    fprintf(stderr, "Time error:\n"
                    "\tnew_time:       %lld\n"
                    "\tnew_raw:        %lld\n"
                    "\tloop->time:     %lld\n"
                    "\tloop->raw_time: %lld\n",
            new_time, new_raw, loop->time, loop->raw_time);
    fflush(stderr);
  }
  loop->time = new_time;
  loop->raw_time = new_raw;
}

(I'm guessing now, maybe its a compiler bug?)

Or maybe you can use the Node master, attach a debugger, and set a conditional breakpoint?

Jan-Kruse

comment created time in 5 days

issue closednodejs/node

fs.stat or fs.lstat throws unknown error on some files (reparse point)

  • Version: v12.16.2
  • Platform: 64 bit Microsoft Windows 10 [Version 10.0.18362.778]
  • Subsystem: fs

What steps will reproduce the bug?

  1. Check if %USERPROFILE%\AppData\Local\Microsoft\WindowsApps exists.
  2. Install https://www.microsoft.com/en-us/p/python-38/9mssztt1n39l
  3. Call fs.statSync("c:\\Users\\kanadig\\AppData\\Local\\Microsoft\\WindowsApps\\python.exe")

How often does it reproduce? Is there a required condition?

This repros 100%, make sure you are calling it on the files under %USERPROFILE%\AppData\Local\Microsoft\WindowsApps\ with 0 size.

What is the expected behavior?

Should not throw exception.

What do you see instead?

> fs.statSync("c:\\Users\\bpasero\\AppData\\Local\\Microsoft\\WindowsApps\\GameBarElevatedFT_Alias.exe")                 
Thrown:                                                                                                                  
{ Error: UNKNOWN: unknown error, stat 'c:\Users\bpasero\AppData\Local\Microsoft\WindowsApps\GameBarElevatedFT_Alias.exe' 
    at Object.statSync (fs.js:855:3)                                                                                     
  errno: -4094,                                                                                                          
  syscall: 'stat',                                                                                                       
  code: 'UNKNOWN',                                                                                                       
  path:                                                                                                                  
   'c:\\Users\\bpasero\\AppData\\Local\\Microsoft\\WindowsApps\\GameBarElevatedFT_Alias.exe' }                           
> fs.lstatSync("c:\\Users\\bpasero\\AppData\\Local\\Microsoft\\WindowsApps\\GameBarElevatedFT_Alias.exe")                
Thrown:                                                                                                                  
{ Error: UNKNOWN: unknown error, lstat 'c:\Users\bpasero\AppData\Local\Microsoft\WindowsApps\GameBarElevatedFT_Alias.exe'
    at Object.lstatSync (fs.js:845:3)                                                                                    
  errno: -4094,                                                                                                          
  syscall: 'lstat',                                                                                                      
  code: 'UNKNOWN',                                                                                                       
  path:                                                                                                                  
   'c:\\Users\\bpasero\\AppData\\Local\\Microsoft\\WindowsApps\\GameBarElevatedFT_Alias.exe' }                           
>     

Additional information

See https://github.com/microsoft/vscode/issues/95828

closed time in 5 days

karthiknadig

issue commentnodejs/node

fs.stat or fs.lstat throws unknown error on some files (reparse point)

Fixed by https://github.com/nodejs/node/pull/33446

karthiknadig

comment created time in 5 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

No, but I guess it changes the timing enough to make the bug not appear. Or its a compiler bug.

Could you maybe remove the raw_time from my patch, to make it as similar to stock libuv as possible and try again?

Jan-Kruse

comment created time in 5 days

issue commentmicrosoft/PowerToys

Shortcut Guide: Black box next to current window preview

To show the active window that will be moved with the arrow keys. A user sees it move when they press those arrows. They also see it move to different displays.

tajetaje

comment created time in 6 days

PR closed nodejs/node

win,fs: use namespaced path in absolute symlinks fs

Use the namespaced (with the \\?\ prefix) paths for symlink targets when the path is absolute. This allows creation of symlinks to files with long filenames.

Fixes: https://github.com/nodejs/node/issues/27795

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+33 -0

7 comments

2 changed files

bzoz

pr closed time in 6 days

create barnchbzoz/node

branch : instrument-libuv-13-11-0

created branch time in 6 days

IssuesEvent

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

@saschanaz the code is here: https://github.com/bzoz/node/tree/instrument-libuv-13-11-0

It will store the raw value returned by QueryPerfomacneCounter and show it when libuv detects the error: https://github.com/bzoz/node/commit/c06043ff11f50b0624a7ad1b8f2dbc96ecbb9e42. Maybe we will be able to see what exact values are causing this.

To build this you need MS Build Tools, NASM and Python. Run:

vcbuild package

This will put Node and npm in the out\Release\node-v13.11.0-win-x64 folder. Dont worry about it complaining about not being able to find 7zip. Just add it to the path and run your repro steps. The output we should see will look like this:

Time error :
        new_time:       157124108
        new_raw:        1571241087588
        loop->time:     157124068
        loop->raw_time: 1571240688624
        GetLastError:   0
Assertion failed: new_time >= loop->time, file src\win\core.c, line 309
Jan-Kruse

comment created time in 6 days

PR opened nodejs/node

fs: unify style in preprocessSymlinkDestination

Removes the else after return to match rest of the style of the function.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -1

0 comment

1 changed file

pr created time in 6 days

create barnchJaneaSystems/node

branch : unfy-preprocesssymlinkdestination-style

created branch time in 6 days

pull request commentnodejs/node

win,fs: use namespaced path in absolute symlinks

Landed in https://github.com/nodejs/node/commit/a4e273baf43910ba9e5c66949e56b919f8614fb9

bzoz

comment created time in 6 days

push eventnodejs/node

Bartosz Sosnowski

commit sha a4e273baf43910ba9e5c66949e56b919f8614fb9

win,fs: use namespaced path in absolute symlinks Use the namespaced (with the \\?\ prefix) paths for symlink targets when the path is absolute. This allows creation of symlinks to files with long filenames. Fixes: https://github.com/nodejs/node/issues/27795 PR-URL: https://github.com/nodejs/node/pull/33351 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 6 days

issue closednodejs/node

symlink is - stateful?

Version: v11.6.0 Platform: Windows 10 (64bit) Subsystem: fs

This is easiest to describe with sample code:

let shortPath = 'c:\\temp\\long pathname test';
undefined
let longPath = 'c:\\temp\\long pathname test\\01234567890123456789012345678901234567890123456789\\01234567890123456789012345678901234567890123456789\\01234567890123456789012345678901234567890123456789\\01234567890123456789012345678901234567890123456789\\01234567890123456789012345678901234567890123456789';
undefined
fs.symlinkSync(path.join(shortPath, 'foobar1.jpg'), path.join(longPath, 'foobar1.jpg'));
undefined
fs.symlinkSync(path.join(longPath, 'foobar2.jpg'), path.join(shortPath, 'foobar2.jpg'));
{ Error: EPERM: operation not permitted, symlink ...}
fs.unlinkSync(path.join(longPath, 'foobar1.jpg'))
undefined
fs.symlinkSync(path.join(shortPath, 'foobar1.jpg'), path.join(longPath, 'foobar1.jpg'));
{ Error: EPERM: operation not permitted, symlink ...}

Now there are a few oddities here a) I can link from a short path to a long one (> MAX_PATH) but not the other way around b) The error reported is EPERM for some reason, not ENAMETOOLONG or EINVAL c) after that error has been reported, even the original call linking from short to long fails

c is the most scary of them because it indicates there is some global internal state that gets flipped and breaks all further calls? How does that make sense?

This is independent of the unlink call btw., this problem also happens if I remove the link outside node or if I use a third file.

closed time in 6 days

TanninOne

pull request commentnodejs/node

win,fs: use namespaced path in absolute symlinks

Resumed CI green

bzoz

comment created time in 6 days

issue commentmicrosoft/PowerToys

Shortcut Guide: Black box next to current window preview

The black box is the outline of your second display. ShortcutGuide shows all connected screens.

tajetaje

comment created time in 6 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

@saschanaz are you willing to run your repo with instrumented Node? I can provide the binary or the instructions on how to build one and a patch that will add some more logging.

Jan-Kruse

comment created time in 6 days

pull request commentnodejs/node

win,fs: use namespaced path in absolute symlinks

Rebased, CI: https://ci.nodejs.org/job/node-test-pull-request/31459/

bzoz

comment created time in 6 days

push eventJaneaSystems/node

Robert Nagy

commit sha b04e88439acca6915ffae4c6b9515ff896ad2cec

http: don't destroy completed request Calling destroy() on a completed ClientRequest, i.e. once 'close' will be emitted should be a noop. Also before emitting 'close' destroyed === true. Fixes: https://github.com/nodejs/node/issues/32851 PR-URL: https://github.com/nodejs/node/pull/33120 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Rich Trott

commit sha 5ded044deaad44ea4b87b321e02190cdb12fe33a

test: fix test-net-throttle Repeat writes until data is queued in memory, rather than assuming that it will happen by a certain point. Fixes: https://github.com/nodejs/node/issues/33135 PR-URL: https://github.com/nodejs/node/pull/33329 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Daniel Bevenius

commit sha 86f8f47cc346c3aa386919b239bd10f58bcfb351

src: fix typo in comment in async_wrap.cc PR-URL: https://github.com/nodejs/node/pull/33350 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Daniel Bevenius

commit sha 12b3e0c1acb937d919fe03f27499a9775ef05bbf

doc: fix typo in n-api.md This commit fixes what I think is a typo, even though the section in question does talk about a environment (env). PR-URL: https://github.com/nodejs/node/pull/33319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Daniel Bevenius

commit sha 8c5d58b5a765981a5309bf4218ed16b7332a5c45

src: use MaybeLocal.ToLocal instead of IsEmpty This commit suggest using MaybeLocal.ToLocal and passing in the Local<Function> fn. The motivation for doing this is that the following MaybeLocal.ToLocalChecked call can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33312 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Michaël Zasso

commit sha cfec30fef3866bc7dfccc6488d8dbd3d9d87772f

deps: update to ICU 67.1 Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1 PR-URL: https://github.com/nodejs/node/pull/33324 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>

view details

rickyes

commit sha aee36a04475a20c13663d1037aa6f175ff368bc7

src: delete unused variables to resolve compile time print warning PR-URL: https://github.com/nodejs/node/pull/33358 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Michaël Zasso

commit sha 1d6adf7432defeb39b751a19c68335e8afb0d8ee

deps: update V8 to 8.3.110.9 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Michaël Zasso

commit sha 37abad4340d4602ced23125b5a409a2aa4a7f57d

build: reset embedder string to "-node.0" PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Michaël Zasso

commit sha 308900faef8b2e5edab5f9737495d2d1b3b54ffe

src: update NODE_MODULE_VERSION to 84 Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Michaël Zasso

commit sha db0ed118d8f39e93063425076dd7d95351d799eb

tools: update V8 gypfiles for V8 8.3 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

cjihrig

commit sha a48928836a930ecdc894e9c684a675bde1508109

deps: update V8 dtrace & postmortem metadata PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Refael Ackermann

commit sha c3866a1b3e9de7b19753d822b313509f43266c42

deps: V8: un-cherry-pick bd019bd Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=​machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Ujjwal Sharma

commit sha 6b5ea2efa23d5e6206ea8db2bba54995c20c6597

deps: patch V8 to run on older XCode versions Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Refael Ackermann

commit sha 55f7ae6386eafa10012e1a7ccf3149becb3b5288

deps: V8: patch register-arm64.h Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Refael Ackermann

commit sha 9dfaf49b84ff13f83dbe9755ac2eb934719792df

deps: V8: forward declaration of `Rtl*FunctionTable` This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Joao Reis

commit sha 32be677f49b6415ce08842fe78288637f300041d

deps: make v8.h compatible with VS2015 There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Michaël Zasso

commit sha e9a6ba0a4c144585f58a78e36692a4f6d0fb82ea

deps: V8: silence irrelevant warnings PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Matheus Marchini

commit sha 54ae041309b0f8934b45b4fd73efcfc1bcb1842b

deps: patch V8 to run on Xcode 8 Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

cjihrig

commit sha 0d50ba5d482a7d5e3f94df3bbc182813d3fb28e4

deps: fix V8 8.3 on SmartOS PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 6 days

issue closednodejs/node

Building LTS v12.x on Windows Fails The system cannot find the file specified."

<!-- Thank you for reporting an issue.

This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help

Please fill in as much of the template below as you're able.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name -->

  • Version: 12.x
  • Platform: Windows
  • Subsystem:

I took the documentation specified in Building.md and converted that into a DockerFile. I had to make some additions to supplement the boxstarter scripts because that ran into errors installing the build tools. To get around that issue I installed those first via npm, following guidelines in this post, then called the boxstarter scripts. This enabled me to get passed that particular problem but now I have a new issue which is detailed below in the console output. I have included a dockerfile to reproduce the issue. Any assistance will be greatly appreciated.

Output of the build

C:\node>.\vcbuild full-icu download-all
Looking for Python
Python 2 found in C:\Python27\\python.exe
Looking for NASM
Looking for Visual Studio 2017
Found MSVS version 15.0
configure  "--download=all" --with-intl=full-icu --dest-cpu=x64
INFO: Using floating patch "tools/icu/patches/64/source/common/putil.cpp" from "tools/icu"
INFO: Using floating patch "tools/icu/patches/64/source/i18n/dtptngen.cpp" from "tools/icu"
Warning: Missing input files:
tools\msvs\genfiles\node_etw_provider.rc
tools\msvs\genfiles\node_etw_provider.h
tools\v8_gypfiles\..\..\deps\v8\src\regexp\regexp-special-case.h
INFO: configure completed successfully
Project files generated.
The system cannot find the file specified.

Dockerfile to reproduce the behaviour

ARG version=ltsc2019
FROM mcr.microsoft.com/windows/servercore:$version

ENV chocolateyUseWindowsCompression false

RUN powershell -Command \
    iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.ps1')); \
    choco feature disable --name showDownloadProgress  

RUN powershell choco install nodejs-lts -y
RUN npm install --global --production windows-build-tools
RUN npm config set msvs_version 2017 -global
RUN npm install --global node-gyp --no-optional
RUN powershell choco install vim -y 


RUN powershell -Command \
    iex ((New-Object System.Net.WebClient).DownloadString('https://boxstarter.org/bootstrapper.ps1')) ; \
    Get-Boxstarter -Force ; \
    Install-BoxstarterPackage https://raw.githubusercontent.com/nodejs/node/master/tools/bootstrap/windows_boxstarter -DisableReboots

RUN powershell git clone https://github.com/nodejs/node.git
RUN powershell  Set-Location -Path C:\Node; git checkout v12.x    

RUN powershell Set-Location -Path C:\Node; .\vcbuild full-icu download-all

closed time in 6 days

jwyglendowski-precisionlender

issue commentnodejs/node

Building LTS v12.x on Windows Fails The system cannot find the file specified."

I'm going to close this, since we have a workaround and this is more an issue with Python/Docker and not with Node. Feel free to reopen if you have further issues.

jwyglendowski-precisionlender

comment created time in 6 days

issue closednodejs/node

'data' event not emitted for every flush

<!-- Thank you for reporting an issue.

This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help

Please fill in as much of the template below as you're able.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name -->

  • Version: v12.14.1
  • Platform: Windows
  • Subsystem: 10

What steps will reproduce the bug?

  1. Create a python script that flushes twice in quick succession and then waits:
import sys;sys.stdout.write("a" * (8192 * 2 + 2));from time import sleep;sleep(3)

Python on windows (or at least on my machine) has a buffer size of 8912 bytes so the above write results in two flushes. You can check the buffer size by running: python -c "import io;print(io.DEFAULT_BUFFER_SIZE)". Also note that the above is a simplified one-liner that reproduces the issue, you can find a full python script with several examples here.

  1. Spawn the python script and listen for data
import { spawn } from "child_process"

const node_process = spawn("python", ["node_buffer_issue_python_script.py"])

node_process.on('error', err => console.error(err))

let numFlushes = 0
node_process.stdout.on('data', (buffer: Buffer) => {
  numFlushes += 1
  const str = buffer.toString()
  console.log(`flush number: ${numFlushes}\
    Buffer length: ${buffer.length}`)
  if (buffer.length < 20) console.log(str)
})

node_process.stdout.on('error', (err) => {
  console.error(err.toString())
})

node_process.stderr.on('data', (err) => {
  console.error(err.toString())
})

/*
Expected result: Many flushes, one for each 8192 bytes
Acutal result: 2 flushes. All of stdout is recieved at once. 4 seconds later comes the done log.

OUTPUT (with python printing 2 ** 29 bytes)
C:\dev\AREPL-backend\personal>ts-node test_node_buffer_python.ts
flush number: 1    Buffer length: 536870912
flush number: 2    Buffer length: 6
done

OUTPUT (with python printing 'a', flushing, printing 'aa', flushing)
C:\dev\AREPL-backend\personal>ts-node test_node_buffer_python.ts
flush number: 1    Buffer length: 3
aaa
flush number: 2    Buffer length: 6
done

OUTPUT (with python printing 'a', flushing, sleeping a tiniest amount, printing 'aa', flushing)
C:\dev\AREPL-backend\personal>ts-node test_node_buffer_python.ts
flush number: 1    Buffer length: 1
a
flush number: 2    Buffer length: 2
aa
flush number: 3    Buffer length: 6
done

*/

I'm not sure if it's related because I have no idea when node flushes stdout but I ran into the same issue when spawning a node child.

How often does it reproduce? Is there a required condition?

This only happens on Windows. On Linux it works as expected, as evidenced by https://repl.it/@almenon/testBufferSize

The other required condition is for flushes to happen within extremely quick succession, as in one flush right after another. Sleeping inbetween flushes results in the 'data' event coming through as expected.

Practically speaking this has resulted in unexpected behavior in AREPL. Presumably other projects with a python subprocess that writes a lot of data in one write run into this problem as well. Python on Windows 10 has a small buffer size of 8912 bytes so it doesn't take that much data to exceed the buffer and cause a flush.

What is the expected behavior?

The node docs for the 'data' event of net.Socket say that 'data' is "Emitted when data is received," in which case I would expect that data is emitted whenever a flush happens in the child process.

What do you see instead?

'data' event is emitted after being received

Additional information

<!-- Tell us anything else you think we should know. -->

closed time in 6 days

Almenon

issue commentnodejs/node

'data' event not emitted for every flush

I don't think there is anything actionable here for Node, as it behaves as expected. Feel free to reopen this issue or create a new one if you find other problems with Node.

Almenon

comment created time in 6 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

Would be nice if someone who was able to reproduce this test with 14.3.0.

Can confirm, built 14.3.0 locally, the issue no longer reproduces.

nicolo-ribaudo

comment created time in 7 days

issue commentnodejs/node

Building LTS v12.x on Windows Fails The system cannot find the file specified."

Adding

ENV PYTHONHTTPSVERIFY 0

disables this verification thingy, and the Node builds.

Complete Dockerfile:

ARG version=ltsc2019
# Use image with preinstalled DotNet 4.8, otherwise VS installer
# complains that the machine needs a reboot:
FROM mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-$version
ENV chocolateyUseWindowsCompression false
ENV PYTHONIOENCODING UTF-8 

SHELL ["cmd", "/s", "/c"]

RUN powershell -Command iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.ps1'))
RUN choco install visualstudio2017buildtools -y
RUN choco install visualstudio2017-workload-vctools -y --params="--add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --add Microsoft.VisualStudio.Component.VC.ATL.ARM64"
RUN choco install nasm -y
RUN choco install git -params /GitAndUnixToolsOnPath -y
RUN choco install python2 -y

RUN git clone https://github.com/nodejs/node.git
WORKDIR c:\\node
RUN git checkout v12.16.3

ENV PYTHONHTTPSVERIFY 0
RUN vcbuild full-icu download-all
jwyglendowski-precisionlender

comment created time in 7 days

issue commentnodejs/node

'data' event not emitted for every flush

TBH, the best answer would be "when it feels like it". Deep down Node looks how many bytes are there in the pipe and then reads them. If for whatever reason Node event loop gets delayed, you will get one data event regardless of how many writes there where. You should not depend on those, you should handle all of the child process output coming at once.

BTW, this has some info on how Node behaves if the stdio is either a pipe (like in this python example) or when it is a TTY on different systems : https://nodejs.org/api/process.html#process_a_note_on_process_i_o.

Almenon

comment created time in 8 days

issue commentnodejs/node

'data' event not emitted for every flush

There is no way for Node to know if/how the data was flushed. The stdio pipe is just a stream of bytes.

Almenon

comment created time in 8 days

issue commentnodejs/node-gyp

node-gyp sets plattform toolset to vs120_xp

Can you test running npm config set msvs_version 2017?

If this does not help, please add --verbose to both node-gyp calls.

fstx

comment created time in 9 days

issue commentmicrosoftarchive/redis

Announcing Memurai Enterprise and Memurai Developer!

That's great news!

rushvel

comment created time in 11 days

issue commentnodejs/node-gyp

Consider using the "py.exe" launcher to find Python 3 as well, not just for Python 2

Some people are using python from the depot-tools, will the py.exe launcher work for them?

DeeDeeG

comment created time in 12 days

issue commentnodejs/node-gyp

npm install fails due to node-gyp errors

@ShubhamB99 could you provide the entire verbose log including the command you are using? Add --verbose to whatever npm command you are using that causes this issue.

@Youkko @TulasiJagan49, @nandas your issues could be completely unrelated. Please provide the entire verbose log and your system configuration - basically fill out the issue template. Fell free to open separate issues.

@nandas VS2019 works just fine with node-gyp, no need to downgrade.

ShubhamB99

comment created time in 13 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

@saschanaz does this issue happen on other Node apps? Can you try maybe running VSCode?

Jan-Kruse

comment created time in 13 days

issue commentlibuv/libuv

win: arithmetic overflow in uv__hrtime()?

https://github.com/libuv/libuv/issues/1633#issuecomment-628147954 - the initial values are not that big, hrtime_freq has the same value as on my box that does not reproduce #1633.

bnoordhuis

comment created time in 13 days

issue closednodejs/node

Installation on Windows 10 Pro results in "Access denied" for "node" and "npm".

<!-- Thank you for reporting an issue.

This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help

Please fill in as much of the template below as you're able.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name --> I attempted an install of node-v12.16.3-x64.msi on Windows 10 Pro. The result is "Access denied" for every attempt to run either "node" or "npm". I notice that the "Access denied" complaint occurs twice in response to npm -v.

  • Version: Result of node -v: Access denied Result of npm -v: Access denied

  • Platform: Windows 10 Pro (64-bit) v1909 OS Build: 18363.592

  • Subsystem: Unknown

What steps will reproduce the bug?

  1. Open command prompt (elevated or plain) or PowerShell
  2. Type "node -v" or "node --version"
  3. Result is "Access denied"
  4. Same results for "npm -v" or "npm --version"

<!-- Enter details about your bug, preferably a simple code snippet that can be run using node directly without installing third-party dependencies. -->

How often does it reproduce? Is there a required condition?

It happens every time. Interestingly, an earlier version worked last fall while this machine was running Windows 7 Pro. I installed v12.13.0-x64 on 21-Oct-2019 and it ran with no problems, but that was on Windows 7 Pro. I was forced to upgrade this machine from Windows 7 Pro to Windows 10 Pro in January. For unrelated reasons, I uninstalled nodejs and attempted to reinstall the newest (v12.16.3-x64) yesterday. That produced the above failure. I then uninstalled that and installed the older version (v12.13.0-x64). The older version fails the same way.

It therefore appears that neither version works on Windows 10 Pro. I have searched for various Windows 10 settings, looking for some sort of permission settings, with no success. My account has admin privileges (I own my machine). I've attempted to frob the account permissions on the install directory (C:\Program Files\nodejs) with no visible change.

This failure happens every time. I can't use nodejs at all on my Windows host system while this is happening.

What is the expected behavior?

I expected to see a version string, such as v12.16.3 instead of Access denied

<!-- If possible please provide textual output instead of screenshots. -->

What do you see instead?

Access denied

<!-- If possible please provide textual output instead of screenshots. -->

Additional information

I have been running nodejs v13.3.0 on a Centos 7 guest VM on the same Windows Host (using a VMWare Workstation Player hypervisor) for some time with no issues. I also run npm v6.14.5 on the same guest VM with no issues. <!-- Tell us anything else you think we should know. --> The first screenshot shows the failing behavior in an elevated command prompt. nodejs_failure

The second screenshot shows successful behavior on an SSH shell connected to a guest VM running on the same Windows 7 host:

nodejs_success

This may well be a permissions/settings issue on my Windows 10 Pro system. If anybody can suggest how to adjust those, I'll eagerly try them and close this accordingly -- perhaps this is a simple nodejs documentation issue.

closed time in 13 days

SomervilleTom

issue commentnodejs/node

Installation on Windows 10 Pro results in "Access denied" for "node" and "npm".

I'm going to close this since it is definitely not an issue with Node.

SomervilleTom

comment created time in 13 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

@saschanaz could you try this: https://gist.github.com/bzoz/52b1d45ce6a27418f31d58956e72e4c0 - it behaves a little more like libuv, it will create threads that write and read files. The output should look like this:

Initial: 1182799683516, freq: 10000000
still running..
still running..

etc.

Could you compile and run it and share the output? It will help in our investigation.

Jan-Kruse

comment created time in 14 days

issue commentlibuv/libuv

win: arithmetic overflow in uv__hrtime()?

Yeah, I saw that too and my first thought was that if the counter starts big we would run into problems.

I guess we should subtract the initial value and move from double anyway. There is no __int128_t in VS, but there are 128-bit things like _mul128 and _udiv128, but that last one is only available since VS2019.

bnoordhuis

comment created time in 14 days

issue commentnodejs/node

Installation on Windows 10 Pro results in "Access denied" for "node" and "npm".

Sorry, but I don't think there is anything we can do. There is defiantly something wrong with your setup. You can try maybe installing node in a separate folder?

SomervilleTom

comment created time in 15 days

PR opened nodejs/node

win,fs: use namespaced path in absolute symlinks

Use the namespaced (with the \\?\ prefix) paths for symlink targets when the path is absolute. This allows creation of symlinks to files with long filenames.

Fixes: https://github.com/nodejs/node/issues/27795

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+32 -0

0 comment

2 changed files

pr created time in 16 days

create barnchJaneaSystems/node

branch : symlink-namespace-abs-path

created branch time in 16 days

issue commentnodejs/node

symlink is - stateful?

Reproduces with v14, similar code in plain libuv (two uv_fs_symlink calls) works as expected.

TanninOne

comment created time in 16 days

issue commentnodejs/node

Installation on Windows 10 Pro results in "Access denied" for "node" and "npm".

And if you doubleclick the node.exe in the File Explorer, does it work?

SomervilleTom

comment created time in 16 days

issue commentlibuv/libuv

There is still a MAX_PATH usage in win/fs.c fs__statfs

The function checks if the buffer needs to be resized to fit paths longer than MAX_PATH: https://github.com/libuv/libuv/blob/55dede5b6f730882d79f994138f0f23a7b28b119/src/win/fs.c#L2737-L2745

I think it is ok the way it is.

lygstate

comment created time in 16 days

issue closednodejs/node-gyp

i got this error

bufferutil@3.0.5 install C:\Users\fletc\JPMC-tech-task-1\JPMC-tech-task-2-PY3\node_modules\bufferutil prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=11.0.0 runtime=node arch=x64 platform=win32)

C:\Users\fletc\JPMC-tech-task-1\JPMC-tech-task-2-PY3\node_modules\bufferutil>if not defined npm_config_node_gyp (node "C:\Users\fletc\AppData\Roaming\nvm\v11.0.0\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "C:\Users\fletc\AppData\Roaming\nvm\v11.0.0\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild ) gyp ERR! UNCAUGHT EXCEPTION gyp ERR! stack Error: spawn D:\visual studio\MSBuild\15.0\Bin\MSBuild.exe ENOENT gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:232:19) gyp ERR! stack at onErrorNT (internal/child_process.js:407:16) gyp ERR! stack at process.internalTickCallback (internal/process/next_tick.js:72:19) gyp ERR! System Windows_NT 10.0.18363 gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\fletc\AppData\Roaming\nvm\v11.0.0\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" gyp ERR! cwd C:\Users\fletc\JPMC-tech-task-1\JPMC-tech-task-2-PY3\node_modules\bufferutil gyp ERR! node -v v11.0.0 gyp ERR! node-gyp -v v3.8.0 gyp ERR! This is a bug in node-gyp. gyp ERR! Try to update node-gyp and file an Issue if it does not help: gyp ERR! https://github.com/nodejs/node-gyp/issues npm WARN bootstrap@4.2.1 requires a peer of jquery@1.9.1 - 3 but none is installed. You must install peer dependencies yourself. npm WARN bootstrap@4.2.1 requires a peer of popper.js@^1.14.6 but none is installed. You must install peer dependencies yourself. npm WARN extract-text-webpack-plugin@3.0.2 requires a peer of webpack@^3.1.0 but none is installed. You must install peer dependencies yourself. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules\fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE npm ERR! errno 7 npm ERR! bufferutil@3.0.5 install: prebuild-install || node-gyp rebuild npm ERR! Exit status 7 npm ERR! npm ERR! Failed at the bufferutil@3.0.5 install script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\fletc\AppData\Roaming\npm-cache_logs\2020-05-10T16_30_15_836Z-debug.log

closed time in 16 days

fletcher200117

issue commentnodejs/node

Installation on Windows 10 Pro results in "Access denied" for "node" and "npm".

Does it also happen if you use the whole path to the Node executable?

SomervilleTom

comment created time in 19 days

issue commentlibuv/libuv

Assertion failed: new_time >= loop->time

@pgrm @Yonom @Sicofonia @paul-at @Pala2812 @doru15 @zilched0 @jansen-teh @saschanaz @kmdavid3 @Parakoos @NNskelly @anarmammad @danielcomes @soraryu @swve @benyaminahmed Could you run the program attached in the zip: qpc-test.zip If you prefer the source code is here: https://gist.github.com/bzoz/b9f942425007a0f834cae2dcc253f1df, I can prepare the instructions on how to get a compiler and built it yourselves if you want.

The program will either do nothing or produce an output like this: image if it does so, sharing those numbers would be a great help.

Jan-Kruse

comment created time in 19 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

Yes, it does not reproduce on Node built with VS2017

nicolo-ribaudo

comment created time in 20 days

issue commentnodejs/node

[Regression in 14.1.0 - Windows] `stdout` is sometimes empty

I can reproduce the issue locally, with Node built locally - both using vcbuild release and plain vcbuild. Can confirm that this is caused by https://github.com/nodejs/node/commit/4143c747fc2b0ead1657a141c4b356c273a6fa3d.

nicolo-ribaudo

comment created time in 20 days

pull request commentnodejs/node-gyp

doc: add Chocolatey instructions for Windows

I'm still -1 on this in this form: https://github.com/nodejs/node-gyp/pull/2061#issuecomment-598262012

kripod

comment created time in 20 days

pull request commentnodejs/node-gyp

doc: add Chocolatey instructions for Windows

I think those commands are for the MSI installer, they don't seem to work with the Windows Store one.

kripod

comment created time in 20 days

pull request commentnodejs/node-gyp

doc: add Chocolatey instructions for Windows

@cclauss I guess @carlo-quinonez meant that you can use choco to install python via automation scripts

kripod

comment created time in 20 days

issue commentlibuv/libuv

win: Optionally customize process-wide error/debug hooks

I guess we could have a uv_configure which could be used to disable setting the error handlers.

bradking

comment created time in 20 days

issue commentnodejs/node-gyp

Error Compiling C++/CLI Module.

Maybe try this: https://github.com/nodejs/node-gyp/issues/568#issuecomment-71979953

StoutOne

comment created time in 20 days

issue commentlibuv/libuv

Compilation problems in windows

CMake will generate proper VS files

FlowerFerry

comment created time in 21 days

issue closednodejs/node-gyp

gyp ERR! configure error during "npm ci" command run

PS E:\GitHub\discover.shared.books-admin-ui> npm ci npm WARN prepare removing existing node_modules/ before installation

fsevents@1.2.12 install E:\GitHub\discover.shared.books-admin-ui\node_modules\fsevents node-gyp rebuild

E:\GitHub\discover.shared.books-admin-ui\node_modules\fsevents>if not defined npm_config_node_gyp (node "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild ) Traceback (most recent call last): File "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\gyp_main.py", line 50, in <module> sys.exit(gyp.script_main()) File "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\pylib\gyp_init_.py", line 554, in script_main return main(sys.argv[1:]) File "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\pylib\gyp_init_.py", line 547, in main return gyp_main(args) File "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\pylib\gyp_init_.py", line 532, in gyp_main generator.GenerateOutput(flat_list, targets, data, params) File "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\pylib\gyp\generator\msvs.py", line 2030, in GenerateOutput sln_projects, project_objects, flat=msvs_version.FlatSolution()) File "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\pylib\gyp\generator\msvs.py", line 1787, in _GatherSolutionFolders return _DictsToFolders('', root, flat) File "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\pylib\gyp\generator\msvs.py", line 1740, in _DictsToFolders for folder, contents in bucket.items(): AttributeError: 'MSVSProject' object has no attribute 'items' gyp ERR! configure error gyp ERR! stack Error: gyp failed with exit code: 1 gyp ERR! stack at ChildProcess.onCpExit (C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\configure.js:351:16) gyp ERR! stack at ChildProcess.emit (events.js:315:20) gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12) gyp ERR! System Windows_NT 10.0.16299 gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\Aliaksandr_Naidzenka\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" gyp ERR! cwd E:\GitHub\discover.shared.books-admin-ui\node_modules\fsevents gyp ERR! node -v v14.0.0 gyp ERR! node-gyp -v v5.1.0 gyp ERR! not ok

closed time in 21 days

AlexanderNaiden

issue commentnodejs/node-gyp

gyp ERR! configure error during "npm ci" command run

This is exactly the same issue as #2058. node-gyp can't possibly control what is inside binding.gyp of the modules you are trying to build.

The fsevents package is now fixed, the solution here is to update the dependencies.

AlexanderNaiden

comment created time in 21 days

issue closednodejs/node-gyp

Issue when building in VS 2019

node 14.0.0 npm 6.14.4 Microsoft Windows 10 Pro 10.0.17763 N/A Build 17763

error gyp ERR! UNCAUGHT EXCEPTION EXEC(0,0): Error : spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\15.0\Bin\MSBuild.exe ENOENT gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:268:19) gyp ERR! stack at onErrorNT (internal/child_process.js:468:16) gyp ERR! stack at processTicksAndRejections (internal/process/task_queues.js:84:21) gyp ERR! System Windows_NT 10.0.17763 gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\rob_s\source\repos\IEvangelist.VideoChat\ClientApp\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library=" gyp ERR! cwd C:\Users\rob_s\source\repos\IEvangelist.VideoChat\ClientApp\node_modules\node-sass gyp ERR! node -v v14.0.0 gyp ERR! node-gyp -v v3.8.0 gyp ERR! This is a bug in node-gyp. gyp ERR! Try to update node-gyp and file an Issue if it does not help: gyp ERR! https://github.com/nodejs/node-gyp/issues EXEC(0,0): Error code: 7

closed time in 21 days

rsapko

issue commentnodejs/node-gyp

npm install fails due to node-gyp errors

What do you get when you run

"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild.exe"

(include the quotes) in the console?

ShubhamB99

comment created time in 21 days

issue commentnodejs/node-gyp

Error Compiling C++/CLI Module.

This should enable /EHa, should make things work:

"msvs_settings": {
        "VCCLCompilerTool": {
          "ExceptionHandling": 2
        }

Add the ExceptionHandling setting to all VCCLCompilerTool

StoutOne

comment created time in 21 days

issue openedlibuv/libuv

docs: uv_library_shutdown formatting

The formatting of the uv_library_shutdown is broken: image

created time in 21 days

issue commentnodejs/node

Windows installation fails with "The request was aborted: Could not create SSL/TLS secure channel."

FWIW, thev1.0 in the path is not the version, it is there probably because of historical reasons:

C:\>c:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Try the new cross-platform PowerShell https://aka.ms/pscore6

PS C:\> $PSVersionTable.PSVersion

Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      18362  752
svdHero

comment created time in a month

pull request commentlibuv/libuv

win: work around QueryPerformanceCounter() turning backwards

I'm +1 on landing this PR. I understand the time-drift concerns, but with the OS outright lying to us, there is nothing we can do about it.

I would assume, that while the QPC might have this time-travel bug, it generally produces a correct timestamp. If not, then there are probably other things that are also broken on such system.

addaleax

comment created time in a month

issue commentlibuv/libuv

win: investigate GetSystemTimePreciseAsFileTime()

Would it be any better? Wouldn't the DST, syncing time, etc. cause the same clock-drift issue we are having with QPC() now, but for almost all users instead of the selected few that have the new Intel CPUs?

On a side note, the underlying Windows issue that is causing all this could also affect GetSystemTimePreciseAsFileTime.

bnoordhuis

comment created time in a month

issue commentnodejs/node

fs.stat or fs.lstat throws unknown error on some files (reparse point)

A fix for this landed in libuv, it should make it way to Node rather soon.

The stat calls will probably still not work though. Those links usualy point to the C:\Program Files\WindowsApps folder that is not normally accessible, even after elevating. lstat should be fine, the added libuv test lstats the%LOCALAPPDATA%\Microsoft\WindowsApps folder.

karthiknadig

comment created time in a month

PR closed libuv/libuv

win, fs: add IO_REPARSE_TAG_APPEXECLINK support

Adds support for IO_REPARSE_TAG_APPEXECLINK reparse points, used by Windows Store.

Ref: https://github.com/nodejs/node/issues/33024

+95 -0

3 comments

5 changed files

bzoz

pr closed time in a month

pull request commentlibuv/libuv

win, fs: add IO_REPARSE_TAG_APPEXECLINK support

Rebased CI green except for unrealted macOS failures: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1893/ Landed in https://github.com/libuv/libuv/commit/e7ebae26247d2fee0a04547eb7f9aa8f78d4a642

bzoz

comment created time in a month

more