profile
viewpoint
Boran Seref boranx Red Hat Brno, Czech Republic http://www.boranseref.com/ developer/SRE @openshift

open-policy-agent/conftest 1336

Write tests against structured configuration data using the Open Policy Agent Rego query language

boranx/dotnetcore-cake-docker-kubernetes 8

Dockerised Scaffold .NET Core WebApi with HATEOAS, Versioning & Swagger, that contains Cake Build Scripts, Kubernetes Deployment yml

boranx/docker-zap-elk 7

Automated Security Tests via Dockerised Owasp-Zap, Results in Kibana

boranx/ansible-aws-windows-kit 5

Generic Ansible Windows kit. Creates dynamic windows instances from AWS EC2. It installs features after the provisioning.

boranx/nginx-ingress-gke-cert-manager 5

My presentation at GDG-Cloud-Istanbul meetup - Ingress #15

boranx/shuriken 4

Shuriken is a simple distributed task executor

boranx/index-checker 3

Elasticsearch index checker validates the indexes within the given time range and document count

boranx/slackins 2

Execute Jenkins Jobs from Slack

boranx/atom-keyboard-shortcuts 0

A list of keyboard shortcuts for the Atom text editor

boranx/cikilop 0

Easy data migration for MongoDB using Python.

push eventboranx/moactl

Victor Kareh

commit sha ba494ff458de69a57ad46f5b5b2175a8f48eb948

verify-oc: Only warn when oc client missing openshift-client is not strictly necessary to use moactl, erroring out is a bad user experience if the user is not intending on using oc. A warning is less aggressive.

view details

Victor Kareh

commit sha 0b89da2eeb14c4a478ce5e5d92148b1086cfbde9

verify-quota: Avoid nil pointer dereferencing When fetching quota for comparison, if the AWS response contains a nil servicequota item, it crashes moactl.

view details

OpenShift Merge Robot

commit sha 878bd787c30f7f428efeffd7cf2e0fe5fb60d661

Merge pull request #107 from vkareh/SDA-2933/fix-possible-npe verify-quota: Avoid nil pointer dereferencing

view details

Victor Kareh

commit sha d52d61ac2227e32f64fc6d69e41993119340429f

Merge pull request #106 from vkareh/verify-oc-not-installed-warn verify-oc: Only warn when oc client missing

view details

Victor Kareh

commit sha 8d3ab3fb3f6a03aa728b3ad68ea97bdc563efd91

versions: Use OpenShift versions that have MOA marketplace images As part of the transition to using the MOA marketplace AMIs, we limit the available OpenShift versions to those that have a corresponding AMI override in the ClusterImageSet.

view details

Victor Kareh

commit sha 72b7c3ae3c390957c0571d5e9bc5c4b74e67f72a

create-cluster: Allow selective override of the paid AMI Since the MOA AMIs are not yet live in the AWS Marketplace, only allowlisted accounts with a valid subscription will be able to use them. Using the new --use-paid-ami flag will tell OCM that it should use the paid MOA image, rather than the default OSD one.

view details

Candace Sheremeta

commit sha 3769f77d84b1c22d22be18f59a21a5bb4c9a5210

Correct typos and incorrect commands in README

view details

OpenShift Merge Robot

commit sha 3ecec11a714a884c23ff1f2b4677ad74a4dc5c28

Merge pull request #101 from vkareh/MOA-75/moa-enabled-versions create-cluster: Allow selective override of the marketplace AMI

view details

Candace Sheremeta

commit sha 9181ca583d5ef7f7ba55f646270e47addfb8ca10

Update README.md

view details

OpenShift Merge Robot

commit sha afcbfbdcfebe5652c22e30981a3700175d581291

Merge pull request #110 from csheremeta/patch-1 Correct typos and incorrect commands in README

view details

Victor Kareh

commit sha 954d0e0129089a3efb6db11d4c60533cb18201fd

versions: Expose channel-group When listing versions or creating a cluster, we can now specify the channel group to use, with a default of 'stable'. Interactive mode now reads the channel group flag and displays the correct list when creating the cluster.

view details

Victor Kareh

commit sha ecb9240fa7a0f721c494a7dd45415f088e8198f8

Merge pull request #112 from vkareh/SDA-2945/channel-groups versions: Expose channel-group

view details

Victor Kareh

commit sha dba0978ae7a13533d08f85b340a73eb508620d44

Use OCM SDK to get token expiration Since new tokens can be generated without an 'exp' claim, we defer to the OCM SDK, which handles token claims correctly.

view details

OpenShift Merge Robot

commit sha 224e7cfc62707a71771c0b45e32434ad540293bf

Merge pull request #114 from vkareh/ocm-sdk-token-exp Use OCM SDK to get token expiration

view details

Victor Kareh

commit sha 0aba25ff376969a4a67be731781a20deff9bcb83

Release v0.0.11 - verify-oc: Only warn when oc client missing - verify-quota: Avoid nil pointer dereferencing - versions: Use OpenShift versions that have MOA marketplace images - create-cluster: Allow selective override of the paid AMI - Correct typos and incorrect commands in README - Update README.md - versions: Expose channel-group - Use OCM SDK to get token expiration

view details

Victor Kareh

commit sha 5b2a1fbb44b4d43c913fdfaf26a795d9297f7b03

Merge pull request #115 from vkareh/release_0_0_11 Release v0.0.11

view details

pvasanth

commit sha 3612c44395f6fd59832167a33cdab9a56364b6cb

Added Detailed Granular Status to match with ocm UI

view details

OpenShift Merge Robot

commit sha f294776c007bd57b5c980971bf9fab5e7dd52a14

Merge pull request #113 from pvasant/AddGranularStatustoMoa Added Detailed Granular Status to match with OCM UI

view details

push time in 15 hours

startedopenshift/moactl

started time in 8 days

push eventboranx/conftest

Lennard Eijsackers

commit sha e483052e3bc091178ea02a3db97c1d6b649509d0

fix: Ensure exceptions are consistenly applied, not only in the multiple objects in a single yaml file case Fixes #353 Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Boran Seref

commit sha 7b3ebbd14a3a84ba1f3fc998c397db61471d46c4

Merge pull request #358 from Blokje5/fix/issue-with-exception-rules Fix: Exceptions not applied against single input

view details

Calle Pettersson

commit sha 5d1e3d8ae8c6071079c69e88f2f70db65c50c5d2

Allow multiple -p flags to merge policy directories (#344) * Allow multiple -p flags to merge policy directories Signed-off-by: Calle Pettersson <calle@cape.nu> * Add docs for --policy Signed-off-by: Calle Pettersson <calle@cape.nu> * Add acceptance test for multiple policy dirs Signed-off-by: Calle Pettersson <calle@cape.nu> * Merge common functionality in policy.ReadFiles/ReadFilesWithTests Signed-off-by: Calle Pettersson <calle@cape.nu> * --update policies go into first policy directory Signed-off-by: Calle Pettersson <calle@cape.nu>

view details

Roberto L. Taborda

commit sha 9dfbdb91ee0ee539ff2c19a7039ddd7599f99709

Ensure successes don't return a msg (#367) Signed-off-by: Roberto L. Taborda <robert@zelinzky.dev>

view details

Lennard Eijsackers

commit sha 6c68ff195105e387b4a193cb3a2ed27aacca4eda

chore: Add a CONTRIBUTING.md document (#365) Fixes #362 Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Anders Eknert

commit sha bbfd1d2333cc30de652aea2c37eb4d8f2b96f78a

Mac OS support and other fixes (#369) Signed-off-by: Anders Eknert <anders@eknert.com>

view details

Lennard Eijsackers

commit sha d9c928eafc8114c5c5544f79a1cdd36907850f3f

Refactor Test Command (#368) Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

KeisukeYamashita

commit sha bc983d74aba38bc97de8122b907028fa488f46a4

Migrate dependabot to github native version 2 (#366) Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

dependabot[bot]

commit sha 2a37ddf944ee1a4b59c72ebb62696661c3a6d7eb

Bump github.com/hashicorp/hcl/v2 from 2.2.0 to 2.6.0 (#375) Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.2.0 to 2.6.0. - [Release notes](https://github.com/hashicorp/hcl/releases) - [Changelog](https://github.com/hashicorp/hcl/blob/v2.6.0/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcl/compare/v2.2.0...v2.6.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha d04158beab15764232b509ea671150762dbeaa3d

Bump github.com/go-ini/ini from 1.51.0 to 1.61.0 (#371) Bumps [github.com/go-ini/ini](https://github.com/go-ini/ini) from 1.51.0 to 1.61.0. - [Release notes](https://github.com/go-ini/ini/releases) - [Commits](https://github.com/go-ini/ini/compare/v1.51.0...v1.61.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 16c1bd88569cb397fa9112318215f7e44fba3188

Bump github.com/hashicorp/go-getter from 1.4.0 to 1.4.1 (#372) Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/hashicorp/go-getter/releases) - [Commits](https://github.com/hashicorp/go-getter/compare/v1.4.0...v1.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

John Reese

commit sha 6e79a2fa7e6b0c8d2bf724076f38b49ed9547ac9

Number of configurations for successes (#376) * Update OPA version Signed-off-by: John Reese <john@reese.dev> * Passing tests Signed-off-by: John Reese <john@reese.dev> * Count successes Signed-off-by: John Reese <john@reese.dev> * Update json tests Signed-off-by: John Reese <john@reese.dev>

view details

John Reese

commit sha 8ce1a237a0b62aaed8ba40a8893d41edf29a4dd8

Move configuration options to options doc (#354) * Move configuration options to options doc Signed-off-by: John Reese <john@reese.dev> * Add additional clarity on configuration ordering Signed-off-by: John Reese <john@reese.dev>

view details

dependabot[bot]

commit sha 62cbd986c43d3ba65f2117f14feedacd35c6657a

Bump github.com/spf13/cobra from 0.0.5 to 0.0.7 (#379) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 0.0.5 to 0.0.7. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](https://github.com/spf13/cobra/compare/0.0.5...0.0.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

John Reese

commit sha 3b618a203d52e29d70d372dc1772bb2a73b0aede

Report error on verify command (#377) Signed-off-by: John Reese <john@reese.dev>

view details

John Reese

commit sha 154e53adc1a234a2a620bdb82ec2bfee31831185

Add additional exit codes (#378) * Add additional exit codes Signed-off-by: John Reese <john@reese.dev> * Add error code test Signed-off-by: John Reese <john@reese.dev>

view details

John Reese

commit sha 125160deacb9c02ce3c098bdf1f3ce7df216026a

Break up output package (#380) Signed-off-by: John Reese <john@reese.dev>

view details

Hendrik Ferber

commit sha 46ec24604d36a34cb6c6f3b338cbc89df3b1f585

fixed gitlab-ci example Signed-off-by: HaveFun83 <blackfon83@googlemail.com>

view details

Gareth Rushgrove

commit sha f74e0eaef3b19456e2f5b5ebafab027a0fd807f8

Merge pull request #382 from HaveFun83/gitlab-ci-fix fixed gitlab-ci example

view details

John Reese

commit sha 66636b203a6c0c46e814507b2b3f694b2e2a64aa

Consolidate evaluation logic into a public package (#381) * Load engine dependencies Signed-off-by: John Reese <john@reese.dev>

view details

push time in 10 days

push eventboranx/moactl

Victor Kareh

commit sha 7ad76aa71c1b42a73f9206d1696b8ed7c459a1cc

login: Ensure token is required When asking the user for the OCM access token, the field should be required and not allow the user through if they do not supply it.

view details

boranx

commit sha ba97dc016d198ea767e0000e29195d98c1365411

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

view details

OpenShift Merge Robot

commit sha b0880d5ff538398899f34991a6d392e685da57d6

Merge pull request #94 from boranx/validate-cf-creds refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

view details

pvasanth

commit sha 12b5312a48445e31e882f479a22ab37cff44efc5

Added Timestamp to created date

view details

OpenShift Merge Robot

commit sha 8b9e95b3871808368f07ad593bc96c6d4ed0901a

Merge pull request #103 from pvasant/SDA-2586/AddTimeStamptoClusterDescribe Added Timestamp to created date

view details

Victor Kareh

commit sha f161c9ec846b617d2f9cfe5697fea5227ff55525

Merge pull request #100 from vkareh/login-token-required login: Ensure token is required

view details

Victor Kareh

commit sha 44397f1126a1b53a5b2b293838a431ea22e27dc9

versions: Allow querying for channel-groups We keep the flag hidden for now, and we hard-code the default to 'stable' when creating clusters. Eventually we will want to expose this to end-users and tell the OCM what channel group to use.

view details

Victor Kareh

commit sha b33283da4f596a031bd6e22d23fbd5c5925ac25d

Merge pull request #102 from vkareh/versions-stable-channel-group versions: Allow querying for channel-groups

view details

Victor Kareh

commit sha 0fa1c2837cdd6fee08be0aeab51579808464a0fe

Release v0.0.10 - reporter: Do not use colors on Windows - list-versions: Add command to list enabled versions - logs: Add progress indicator when waiting for logs - verify-permissions: Do not check ViewBilling policy - Add 'Channel Group' attribute to 'moactl describe cluster' - tests: Fix expected text comparison - Use default region for CloudFormation stack - login: Ensure token is required - refactor(create): add credential check for osdCcsAdmin when cluster starts to be created - Added Timestamp to created date - versions: Allow querying for channel-groups

view details

Victor Kareh

commit sha 0c3136364a3668611db7161324249b4ba300eda4

Merge pull request #105 from vkareh/release_0_0_10 Release v0.0.10

view details

push time in 10 days

push eventboranx/moactl

Victor Kareh

commit sha c93ccf2edc95bfdb311cf611b9aabc89dfcd5ec8

Use default region for CloudFormation stack Since a CloudFormation stack is region-specific, we avoid using the user-set flag and hard-code a default AWS region. This ensures that the stack is queried always from the same region, regardless where the cluster is being created.

view details

OpenShift Merge Robot

commit sha d31ec75a605c04c0692c3730d7090c87f6c8c9eb

Merge pull request #92 from vkareh/SDA-2841/ensure-same-cf-region Use default region for CloudFormation stack

view details

boranx

commit sha ba97dc016d198ea767e0000e29195d98c1365411

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

view details

push time in 18 days

push eventboranx/moactl

Victor Kareh

commit sha c93ccf2edc95bfdb311cf611b9aabc89dfcd5ec8

Use default region for CloudFormation stack Since a CloudFormation stack is region-specific, we avoid using the user-set flag and hard-code a default AWS region. This ensures that the stack is queried always from the same region, regardless where the cluster is being created.

view details

OpenShift Merge Robot

commit sha d31ec75a605c04c0692c3730d7090c87f6c8c9eb

Merge pull request #92 from vkareh/SDA-2841/ensure-same-cf-region Use default region for CloudFormation stack

view details

push time in 18 days

push eventboranx/moactl

boranx

commit sha ca7c771243ed6855ff2a2703e1675c4320dcea6f

refactor(create): add default region

view details

push time in 18 days

fork boranx/osd-utils-cli

CLI for the OSD utilities

fork in 20 days

push eventboranx/moactl

boranx

commit sha 58da1f50d092733b196ead39209d2dc0231f3fc7

fix(verify-permissions): revert code refactors

view details

Victor Kareh

commit sha 6a67ba947a2c5b81c2c373e4122943d82e7c3c17

verify-oc: Ensure no output on error When the oc client is not connected to any cluster, it still outputs the version string, but also exits with an error. Instead of bailing out on the error, we ensure that the version string is empty before we assume that there is no 'oc' tool installed.

view details

Victor Kareh

commit sha ff295831e26fe6ea9993a628178e405d3af7eb37

Merge pull request #88 from vkareh/SDA-2788/fix-version-check verify-oc: Ensure no output on error

view details

Victor Kareh

commit sha d038af1b060412729dd784292a900deec01f6ad5

Release v0.0.8 - verify-oc: Ensure no output on error

view details

Victor Kareh

commit sha 691c77097e9c7aaceb0d3966abd085cdc85d4649

Merge pull request #89 from vkareh/release_0_0_8 Release v0.0.8

view details

jharrington22

commit sha f27197b483860c374232e1bdd9294f3072e2ce45

Update Makefile for CI and remove PR check script

view details

James Harrington

commit sha 387347d0f0b67e15c942e980c82875c04a14b1a6

Merge pull request #81 from boranx/fix/verify-rate-limits Fix/verify rate limits

view details

Victor Kareh

commit sha 3c321c9b89336e16f7c284c76ae4176d15517e81

Merge pull request #25 from jharrington22/update-repo-for-ci Update Makefile for CI and remove PR check script

view details

James Harrington

commit sha 57d29d1a1b05bd72ddaa7b9fec31a186763c90e8

Release 0.0.9

view details

James Harrington

commit sha 15cb01aba7553d6eccc2105da68705da8b706015

Merge pull request #90 from jharrington22/release_0_0_9 Release 0.0.9

view details

Victor Kareh

commit sha 5e660a6c391872a35407b7c75f9355338e3e636a

reporter: Do not use colors on Windows Windows seems to output control characters instead of properly colored output, so we check whether the client is running on Windows and then remove the color codes.

view details

Victor Kareh

commit sha 4d38c70cb97321e27550d86a8ff5a7bb9aa6c8cf

list-versions: Add command to list enabled versions When creating a cluster, the user is able to pass a parameter with the version of OpenShift to use. Unless the user goes through the interactive flow, they won't be able to see which versions are available. This command allows a user to view a list of all enabled versions in the current environment.

view details

OpenShift Merge Robot

commit sha 596b29afba5c6ae235011c2732d6e619e5ea4e7c

Merge pull request #93 from vkareh/SDA-2842/remove-window-colors reporter: Do not use colors on Windows

view details

Victor Kareh

commit sha 47ed5d391ca6ddbad0e51509f3bd0803c800d90f

logs: Add progress indicator when waiting for logs To avoid users being concerned about their cluster not starting install, we add a spinner while we poll the installation logs endpoint. Once the logs are available, we remove the spinner and show the logs instead.

view details

OpenShift Merge Robot

commit sha e4ee9d98790c6cb3eaa59116f452b6890b411efc

Merge pull request #91 from vkareh/SDA-2752/progress-indicator logs: Add progress indicator when waiting for logs

view details

OpenShift Merge Robot

commit sha 8d7cac969f84183481368ff33af0e2e731d9b5c9

Merge pull request #95 from vkareh/SDA-2790/list-versions list-versions: Add command to list enabled versions

view details

Victor Kareh

commit sha c3ea3bbf1edb3e412a9d90ece8faddca1af633e0

verify-permissions: Do not check ViewBilling policy Since billing is recommended, but not required, we should not check during the verify-permission check so as to not block the user if they do not have this policy.

view details

OpenShift Merge Robot

commit sha fe500d1cf954ace97fdc8d58deeddbcc107ec3aa

Merge pull request #97 from vkareh/SDA-2749/remove-billing-permission-check verify-permissions: Do not check ViewBilling policy

view details

Nimrod Shneor

commit sha 75b022a1b3946e83f641dda0e51b9c831293bca1

Add 'Channel Group' attribute to 'moactl describe cluster'

view details

Victor Kareh

commit sha c56d632a55ea5a95fb2688e95f54fbfd79abdda2

tests: Fix expected text comparison

view details

push time in 22 days

push eventboranx/moactl

boranx

commit sha 58da1f50d092733b196ead39209d2dc0231f3fc7

fix(verify-permissions): revert code refactors

view details

Victor Kareh

commit sha 6a67ba947a2c5b81c2c373e4122943d82e7c3c17

verify-oc: Ensure no output on error When the oc client is not connected to any cluster, it still outputs the version string, but also exits with an error. Instead of bailing out on the error, we ensure that the version string is empty before we assume that there is no 'oc' tool installed.

view details

Victor Kareh

commit sha ff295831e26fe6ea9993a628178e405d3af7eb37

Merge pull request #88 from vkareh/SDA-2788/fix-version-check verify-oc: Ensure no output on error

view details

Victor Kareh

commit sha d038af1b060412729dd784292a900deec01f6ad5

Release v0.0.8 - verify-oc: Ensure no output on error

view details

Victor Kareh

commit sha 691c77097e9c7aaceb0d3966abd085cdc85d4649

Merge pull request #89 from vkareh/release_0_0_8 Release v0.0.8

view details

jharrington22

commit sha f27197b483860c374232e1bdd9294f3072e2ce45

Update Makefile for CI and remove PR check script

view details

James Harrington

commit sha 387347d0f0b67e15c942e980c82875c04a14b1a6

Merge pull request #81 from boranx/fix/verify-rate-limits Fix/verify rate limits

view details

Victor Kareh

commit sha 3c321c9b89336e16f7c284c76ae4176d15517e81

Merge pull request #25 from jharrington22/update-repo-for-ci Update Makefile for CI and remove PR check script

view details

James Harrington

commit sha 57d29d1a1b05bd72ddaa7b9fec31a186763c90e8

Release 0.0.9

view details

James Harrington

commit sha 15cb01aba7553d6eccc2105da68705da8b706015

Merge pull request #90 from jharrington22/release_0_0_9 Release 0.0.9

view details

Victor Kareh

commit sha 5e660a6c391872a35407b7c75f9355338e3e636a

reporter: Do not use colors on Windows Windows seems to output control characters instead of properly colored output, so we check whether the client is running on Windows and then remove the color codes.

view details

Victor Kareh

commit sha 4d38c70cb97321e27550d86a8ff5a7bb9aa6c8cf

list-versions: Add command to list enabled versions When creating a cluster, the user is able to pass a parameter with the version of OpenShift to use. Unless the user goes through the interactive flow, they won't be able to see which versions are available. This command allows a user to view a list of all enabled versions in the current environment.

view details

OpenShift Merge Robot

commit sha 596b29afba5c6ae235011c2732d6e619e5ea4e7c

Merge pull request #93 from vkareh/SDA-2842/remove-window-colors reporter: Do not use colors on Windows

view details

Victor Kareh

commit sha 47ed5d391ca6ddbad0e51509f3bd0803c800d90f

logs: Add progress indicator when waiting for logs To avoid users being concerned about their cluster not starting install, we add a spinner while we poll the installation logs endpoint. Once the logs are available, we remove the spinner and show the logs instead.

view details

OpenShift Merge Robot

commit sha e4ee9d98790c6cb3eaa59116f452b6890b411efc

Merge pull request #91 from vkareh/SDA-2752/progress-indicator logs: Add progress indicator when waiting for logs

view details

OpenShift Merge Robot

commit sha 8d7cac969f84183481368ff33af0e2e731d9b5c9

Merge pull request #95 from vkareh/SDA-2790/list-versions list-versions: Add command to list enabled versions

view details

Victor Kareh

commit sha c3ea3bbf1edb3e412a9d90ece8faddca1af633e0

verify-permissions: Do not check ViewBilling policy Since billing is recommended, but not required, we should not check during the verify-permission check so as to not block the user if they do not have this policy.

view details

OpenShift Merge Robot

commit sha fe500d1cf954ace97fdc8d58deeddbcc107ec3aa

Merge pull request #97 from vkareh/SDA-2749/remove-billing-permission-check verify-permissions: Do not check ViewBilling policy

view details

Nimrod Shneor

commit sha 75b022a1b3946e83f641dda0e51b9c831293bca1

Add 'Channel Group' attribute to 'moactl describe cluster'

view details

Victor Kareh

commit sha c56d632a55ea5a95fb2688e95f54fbfd79abdda2

tests: Fix expected text comparison

view details

push time in 22 days

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func (c *awsClient) ValidateCredentials() (bool, error) { 	return true, nil } +// Checks osdCcsAdmin IAM credentials are valid.+// Get stack's key and actually key and compare them+// to get the stack credentials:+// aws cloudformation describe-stack-resource \+// --logical-resource-id osdCcsAdminAccessKeys --stack-name osdCcsAdminIAMUser+func (c *awsClient) ValidateCFUserCredentials() error {+	name := AdminUserName+	accessKeyInput := &iam.ListAccessKeysInput{+		UserName: &name,+	}+	accessKeyList, err := c.iamClient.ListAccessKeys(accessKeyInput)+	if err != nil {+		return err+	}++	OsdCcsAdminStackNamePtr := OsdCcsAdminStackName+	LogicalResourceIDPtr := "osdCcsAdminAccessKeys"+	stackResourceInput := &cloudformation.DescribeStackResourceInput{+		StackName:         &OsdCcsAdminStackNamePtr,+		LogicalResourceId: &LogicalResourceIDPtr,+	}+	resources, err := c.cfClient.DescribeStackResource(stackResourceInput)+	if err != nil {+		return err+	}+	cfAccessKey := resources.StackResourceDetail.PhysicalResourceId++	for _, key := range accessKeyList.AccessKeyMetadata {+		if *key.AccessKeyId == *cfAccessKey && *key.Status == "Active" {+			return nil+		}+	}++	return fmt.Errorf(`+	Invalid CloudFormation stack credentials: %s is not valid +	you can recreate the CloudFormation stack with +	"moactl init --delete-stack && moactl init"+	`, name)+}+

thanks, fixed now

boranx

comment created time in 22 days

PullRequestReviewEvent

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func (c *awsClient) ValidateCredentials() (bool, error) { 	return true, nil } +// Checks osdCcsAdmin IAM credentials are valid.

hey, @NautiluX, appreciate for the review... Yeah you're right, I've fixed that section

boranx

comment created time in 22 days

PullRequestReviewEvent

push eventboranx/moactl

boranx

commit sha 35cd14ef5630f84190323711dc9c9c3840833cab

refactor(create): apply code-review fix: fix the comments for ValidateCFUserCredentials, remove spaces

view details

push time in 22 days

push eventboranx/gcp-project-operator

Panagiotis Georgiadis

commit sha 89e2cbff75cefe2a3baf93b01ff820867c6d7121

Update run command * Update 'run' command [docs] - Flag --local has been deprecated, use 'run local' instead - Flag --namespace is deprecated; use --watch-namespace instead. * Bump the testing coverage image

view details

OpenShift Merge Robot

commit sha b53010958c808f617f2f58384d3303e70ea559fc

Merge pull request #89 from drpaneas/obsolete_command Update run command

view details

Rick Rackow

commit sha e003186829de60961ddc5f13135a38323dadd82d

readme: remove deprecated non-existing section from table of content

view details

OpenShift Merge Robot

commit sha 5357724d72a62cc55a53517ba9861886d197a308

Merge pull request #90 from RiRa12621/master readme: remove deprecated non-existing section from table of content

view details

Rogerio Bastos

commit sha f38db253356bcae07d283bb513303fa403b952a1

OSD-4792 Fix Catalog img build script

view details

OpenShift Merge Robot

commit sha 9ca6b25e68cf599be54307675d9b78557a664367

Merge pull request #91 from rogbas/OSD-4792-update-catalog-img-script OSD-4792 Fix Catalog img build script

view details

push time in 24 days

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func run(cmd *cobra.Command, _ []string) { 		reporter.Errorf("Error getting region: %v", err) 		os.Exit(1) 	}++	// Create the AWS client:+	client, err := aws.NewClient().+		Logger(logger).

ack @vkareh we can add that once #92 has been merged

boranx

comment created time in 24 days

PullRequestReviewEvent

push eventboranx/moactl

boranx

commit sha 8339a396bedca5a155518ac22caedeccc8e4f361

refactor(create): activity check for access key

view details

push time in 25 days

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func (c *awsClient) ValidateCredentials() (bool, error) { 	return true, nil } +// Checks osdCcsAdmin IAM credentials are valid.+// Get stack's key and actually key and compare them+// to get the stack credentials:+// aws cloudformation describe-stack-resource \+// --logical-resource-id osdCcsAdminAccessKeys --stack-name osdCcsAdminIAMUser+func (c *awsClient) ValidateCFUserCredentials() error {+	name := AdminUserName+	accessKeyInput := &iam.ListAccessKeysInput{+		UserName: &name,+	}+	accessKeyList, err := c.iamClient.ListAccessKeys(accessKeyInput)+	if err != nil {+		return err+	}++	OsdCcsAdminStackNamePtr := OsdCcsAdminStackName+	LogicalResourceIDPtr := "osdCcsAdminAccessKeys"+	stackResourceInput := &cloudformation.DescribeStackResourceInput{+		StackName:         &OsdCcsAdminStackNamePtr,+		LogicalResourceId: &LogicalResourceIDPtr,+	}+	resources, err := c.cfClient.DescribeStackResource(stackResourceInput)+	if err != nil {+		return err+	}+	cfAccessKey := resources.StackResourceDetail.PhysicalResourceId++	for _, key := range accessKeyList.AccessKeyMetadata {+		if *key.AccessKeyId == *cfAccessKey {

Because this check will pass even if the credentials for osdCcsAdmin marked as inactive via console

boranx

comment created time in 25 days

PullRequestReviewEvent

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func (c *awsClient) ValidateCredentials() (bool, error) { 	return true, nil } +// Checks osdCcsAdmin IAM credentials are valid.+// Get stack's key and actually key and compare them+// to get the stack credentials:+// aws cloudformation describe-stack-resource \+// --logical-resource-id osdCcsAdminAccessKeys --stack-name osdCcsAdminIAMUser+func (c *awsClient) ValidateCFUserCredentials() error {+	name := AdminUserName+	accessKeyInput := &iam.ListAccessKeysInput{+		UserName: &name,+	}+	accessKeyList, err := c.iamClient.ListAccessKeys(accessKeyInput)+	if err != nil {+		return err+	}++	OsdCcsAdminStackNamePtr := OsdCcsAdminStackName+	LogicalResourceIDPtr := "osdCcsAdminAccessKeys"+	stackResourceInput := &cloudformation.DescribeStackResourceInput{+		StackName:         &OsdCcsAdminStackNamePtr,+		LogicalResourceId: &LogicalResourceIDPtr,+	}+	resources, err := c.cfClient.DescribeStackResource(stackResourceInput)+	if err != nil {+		return err+	}+	cfAccessKey := resources.StackResourceDetail.PhysicalResourceId++	for _, key := range accessKeyList.AccessKeyMetadata {+		if *key.AccessKeyId == *cfAccessKey {

I guess we also need to check the accesskey to see if it is or isn't enabled.

boranx

comment created time in 25 days

PullRequestReviewEvent

push eventboranx/moactl

boranx

commit sha 9a5ea4a11d838af0b89a6e470ccdc224611020a7

refactor(create): fix linting issues

view details

push time in 25 days

push eventboranx/moactl

boranx

commit sha 50a23b51ef55c987178b500ff7780ae291831343

refactor(create): fix linting issues

view details

push time in 25 days

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func (c *awsClient) ValidateCredentials() (bool, error) { 	return true, nil } +// Checks osdCcsAdmin IAM credentials are valid.+// Get stack's key and actualy key and compare them+// stack: aws cloudformation describe-stack-resource --logical-resource-id osdCcsAdminAccessKeys --stack-name osdCcsAdminIAMUser+func (c *awsClient) ValidateCFUserCredentials() error {+	name := AdminUserName+	accessKeyInput := &iam.ListAccessKeysInput{+		UserName: &name,+	}+	accessKeyList, err := c.iamClient.ListAccessKeys(accessKeyInput)+	if err != nil {+		return err+	}++	meta := accessKeyList.AccessKeyMetadata+	keyList := make([]string, len(meta))+	for _, key := range meta {+		keyList = append(keyList, *key.AccessKeyId)+	}++	OsdCcsAdminStackNamePtr := OsdCcsAdminStackName+	LogicalResourceIDPtr := "osdCcsAdminAccessKeys"+	stackResourceInput := &cloudformation.DescribeStackResourceInput{+		StackName:         &OsdCcsAdminStackNamePtr,+		LogicalResourceId: &LogicalResourceIDPtr,+	}+	resources, err := c.cfClient.DescribeStackResource(stackResourceInput)+	if err != nil {+		return err+	}+	cfAccessKey := resources.StackResourceDetail.PhysicalResourceId++	for _, item := range keyList {+		if item == *cfAccessKey {+			return nil+		}+	}++	return fmt.Errorf("credentials are not valid for %s \n you can recreate the CloudFormation stack with `moactl init --delete-stack`", name)

I've changed the message body as requested. I think the permission related concerns are mostly related to OSD-4708 (I might be wrong but it currently exists in our backlog).

boranx

comment created time in 25 days

PullRequestReviewEvent

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func run(cmd *cobra.Command, _ []string) { 		reporter.Errorf("Error getting region: %v", err) 		os.Exit(1) 	}++	// Create the AWS client:+	client, err := aws.NewClient().+		Logger(logger).+		Region(region).

hi, @vkareh thanks for the review! appreciated. Now the region section has been removed.

boranx

comment created time in 25 days

PullRequestReviewEvent

push eventboranx/moactl

boranx

commit sha 1eb48fd9a39fa048fc443e2d027c3c8b96af8817

refactor(create): code review items for #94

view details

push time in 25 days

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func (c *awsClient) ValidateCredentials() (bool, error) { 	return true, nil } +// Checks osdCcsAdmin IAM credentials are valid.+// Get stack's key and actualy key and compare them+// stack: aws cloudformation describe-stack-resource --logical-resource-id osdCcsAdminAccessKeys --stack-name osdCcsAdminIAMUser+func (c *awsClient) ValidateCFUserCredentials() error {+	name := AdminUserName+	accessKeyInput := &iam.ListAccessKeysInput{+		UserName: &name,+	}+	accessKeyList, err := c.iamClient.ListAccessKeys(accessKeyInput)+	if err != nil {+		return err+	}++	meta := accessKeyList.AccessKeyMetadata+	keyList := make([]string, len(meta))+	for _, key := range meta {+		keyList = append(keyList, *key.AccessKeyId)+	}++	OsdCcsAdminStackNamePtr := OsdCcsAdminStackName+	LogicalResourceIDPtr := "osdCcsAdminAccessKeys"+	stackResourceInput := &cloudformation.DescribeStackResourceInput{+		StackName:         &OsdCcsAdminStackNamePtr,+		LogicalResourceId: &LogicalResourceIDPtr,+	}+	resources, err := c.cfClient.DescribeStackResource(stackResourceInput)

is there a better way to get stack's user access key?

boranx

comment created time in a month

PullRequestReviewEvent

Pull request review commentopenshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

 func (c *awsClient) ValidateCredentials() (bool, error) { 	return true, nil } +// Checks osdCcsAdmin IAM credentials are valid.+// Get stack's key and actualy key and compare them+// stack: aws cloudformation describe-stack-resource --logical-resource-id osdCcsAdminAccessKeys --stack-name osdCcsAdminIAMUser+func (c *awsClient) ValidateCFUserCredentials() error {+	name := AdminUserName+	accessKeyInput := &iam.ListAccessKeysInput{+		UserName: &name,+	}+	accessKeyList, err := c.iamClient.ListAccessKeys(accessKeyInput)+	if err != nil {+		return err+	}++	meta := accessKeyList.AccessKeyMetadata+	keyList := make([]string, len(meta))+	for _, key := range meta {+		keyList = append(keyList, *key.AccessKeyId)+	}++	OsdCcsAdminStackNamePtr := OsdCcsAdminStackName+	LogicalResourceIDPtr := "osdCcsAdminAccessKeys"+	stackResourceInput := &cloudformation.DescribeStackResourceInput{

Is there a better way to get the key?

boranx

comment created time in a month

PullRequestReviewEvent

PR opened openshift/moactl

refactor(create): add credential check for osdCcsAdmin when cluster starts to be created

Fixes: OSD-4707

The credential check has been added to cluster create command. Example output when the creds for osdCcsAdmin are being changed manually

 └─ ▶./moactl create cluster -c boran-test
I: Validating AWS credentials for CFUser...
E: Error validating AWS credentials: credentials are not valid for osdCcsAdmin
 you can recreate the CloudFormation stack with `moactl init --delete-stack`
+118 -3

0 comment

4 changed files

pr created time in a month

create barnchboranx/moactl

branch : validate-cf-creds

created branch time in a month

push eventboranx/moactl

Victor Kareh

commit sha 1da3fd18c85077a044a893e05783c7cb393a0655

verify: Add command to verify OpenShift client tools

view details

Victor Kareh

commit sha a326f9842515a35186631e877cd7d0ac6c674fa3

download: Add command to download openshift-client tools

view details

Victor Kareh

commit sha 8daf10af50fef054d2d56b8c26bd1cb5aa05ab9a

create-cluster: Allow user to watch cluster installation logs To provide a single command where the cluster can be created and the logs watched, we add a --watch flag to the `moactl create cluster` command. This calls the `moactl logs install` command in watch mode.

view details

Victor Kareh

commit sha 571e697ca19f9316400997d501089c40438cc91b

delete-cluster: Allow user to watch cluster uninstallation logs To provide a single command where the cluster can be deleted and the logs watched, we add a --watch flag to the `moactl delete cluster` command. This calls the `moactl logs uninstall` command in watch mode.

view details

Victor Kareh

commit sha 62b0a41d3aa515807b2ba27f7ea08b30132610ac

create-cluster: Describe cluster automatically after creation

view details

Victor Kareh

commit sha c450e0129d80ecc4d62b1580c1fc7a9788bc43fb

logs: Detach logs once operation is complete When watching install logs, the logs will automatically terminate when the cluster is either fully installed or an error has occurred. When watching uninstall logs, the logs will automatically terminate when the cluster is either uninstalled or an error has occurred. Logs query every few seconds and check the state of the cluster every time. Without any other status change, log polling will automatically timeout after 1 hour.

view details

Victor Kareh

commit sha 3dfb4ce731a17e21dbb1b8a601f5a8a7baab291f

addons: Hide addons until it's feature-complete Since addons do not support deletion yet, we hide the feature to prevent confusion and unnecessary support tickets.

view details

Victor Kareh

commit sha 84db2984fa441ddec9b93e1e4ab6fafc857f909b

Merge pull request #78 from vkareh/detach-logs-on-ready Log improvements

view details

Victor Kareh

commit sha 9c5fa216b049b121aaecdf30b0a57c8da839792e

Merge pull request #80 from vkareh/hide-addons addons: Hide addons until it's feature-complete

view details

Victor Kareh

commit sha 97dffade03a65a5ca7fb72e7f30183a750571663

addons: Confirm add-on installation Since add-ons cannot be uninstalled, we warn the user and ask for confirmation before installing the add-on.

view details

Victor Kareh

commit sha 9f0f2b6633836e71f06f3322eeb41a0fb2b0c38e

Merge pull request #73 from vkareh/SDA-2598/addon-delete-warning addons: Confirm add-on installation

view details

pvasanth

commit sha 35384d5fd3bda6c8253d8dc45d6c2c8b77f47eb2

Added Detailed Error Message for Throttling

view details

Victor Kareh

commit sha 0fe3195177be91ee629e6d3c81d5f57b676dabb1

Merge pull request #82 from pvasant/AddDetailedErrorMessage Added Detailed Error Message for Throttling

view details

Victor Kareh

commit sha 6292119bbfa8a9fcfdf82045fad8e181fcca31e3

Merge pull request #68 from vkareh/SDA-2671/verify-oc-version Download oc tools

view details

Victor Kareh

commit sha 1f92112973b9f6d3fe3b387c5a1d625c54edd143

Release v0.0.6 - create-cluster: Set compute node defaults based on AZ - create-idp: Allow user to specify IdP name - addons: Add list and describe commands for add-ons - addons: Direct the user to check add-on status after install - aws: Return error if using root account - improve moactl verify quota error messages - Check cloudformation stack exists - Add tests for EnsureOsdCcsAdminUser - create-cluster: Deprecate --name in favor of --cluster-name - describe-cluster: Show AWS account ID used to create cluster - fix long line - Change from ginkgo to to go test - logs: Make command more intuitive - logs: Update SDK client - logs: Add uninstall logs - logs: Add separate install/uninstall logs - logs: Update API endpoints - interactive: Fix function call from broken dependency - addons: Remove global list of add-ons - delete-user: Fix confirmation output - verify: Add command to verify OpenShift client tools - download: Add command to download openshift-client tools - create-cluster: Allow user to watch cluster installation logs - delete-cluster: Allow user to watch cluster uninstallation logs - create-cluster: Describe cluster automatically after creation - logs: Detach logs once operation is complete - logs: Fix help text - addons: Hide addons until it's feature-complete - addons: Confirm add-on installation - Added Detailed Error Message for Throttling

view details

Victor Kareh

commit sha adf30d9e80ac39c3581d626492e94f7543741ec1

Merge pull request #83 from vkareh/release_0_0_6 Release v0.0.6

view details

Victor Kareh

commit sha 706d25138d5ad89cafc938fc63d9e5527619fbe9

create-cluster: List regions using user AWS creds To present an accurate list of what regions are supported by the customer's AWS account, we query the new available_regions API endpoint. We further filter that list based on the selection of multiple availability zones: if the user selected multi-az for their cluster, we narrow down the list to those regions that support it.

view details

Victor Kareh

commit sha c607790efcea29a40656380e07cb4f88a28e11a8

list-regions: Add command to list available regions To view a list of which regions that are supported for OSD are also available on the customer's AWS account, we add a list regions command. It also allows the user to filter based on support for availabilty zone.

view details

Victor Kareh

commit sha 875224ce7be17fc7ae33cd345a1cb047fe5f8440

Merge pull request #85 from vkareh/dynamic-aws-regions Dynamic AWS regions

view details

Victor Kareh

commit sha df32c051ec4420f079cf9e4a8bd96daec51751a9

create-cluster: Ensure region is set when creating AWS client

view details

push time in a month

issue commentopen-policy-agent/conftest

Refactor the Test command

@Blokje5 are you actually working on that or looking for someone to handle that? I'd love to review the PR if you're keen to create one

Blokje5

comment created time in a month

Pull request review commentopenshift/moactl

Fix/verify rate limits

 func (b *ClientBuilder) Build() (Client, error) { 			MaxRetries: aws.Int(25), 			// Set MinThrottleDelay to 1 second 			Retryer: client.DefaultRetryer{+				NumMaxRetries:    5,

what could be the other alternatives? We're making a single request for policy checks so I don't think we can reduce the number of requests at all.

boranx

comment created time in a month

pull request commentopenshift/moactl

Fix/verify rate limits

/unhold

boranx

comment created time in a month

push eventboranx/moactl

boranx

commit sha 58da1f50d092733b196ead39209d2dc0231f3fc7

fix(verify-permissions): revert code refactors

view details

push time in a month

Pull request review commentopenshift/moactl

Fix/verify rate limits

 type SimulateParams struct {  // checkPermissionsUsingQueryClient will use queryClient to query whether the credentials in targetClient can perform // the actions listed in the statementEntries. queryClient will need iam:GetUser and iam:SimulatePrincipalPolicy-func checkPermissionsUsingQueryClient(queryClient, targetClient *awsClient, policyDocument PolicyDocument,+func checkPermissionsUsingQueryClient(client *awsClient, policyDocument PolicyDocument,

mm that's ambiguous because still hasn't been implemented yet so we're creating structures below which are poor in terms of readability. Though, I'll take that suggestion and revert here as well

hasPermissions, err := validatePolicyDocuments(c, c, policyDocuments, sParams)
boranx

comment created time in a month

Pull request review commentopenshift/moactl

Fix/verify rate limits

 func checkPermissionsUsingQueryClient(queryClient, targetClient *awsClient, poli 		} 	} +	resp, err := client.iamClient.SimulatePrincipalPolicy(input)

OK, I'll revert here

boranx

comment created time in a month

Pull request review commentopenshift/moactl

Fix/verify rate limits

 func (b *ClientBuilder) Build() (Client, error) { 			MaxRetries: aws.Int(25), 			// Set MinThrottleDelay to 1 second 			Retryer: client.DefaultRetryer{+				NumMaxRetries:    5,

I've tested it with 2 different accounts. One is my personal and the other what @fahlmant gave me. The retry is not a permanent solution I agree, but still, the number of 400s significantly reduced(I didn't see in the logs any but still can occur..). Having said that, there's no response code that resp contains (resp, err := client.iamClient.SimulatePrincipalPolicy(input)) It only fills the err message with status code when anything happens except 200. Because of that, it's hard to adjust the retry numbers dynamically if continuously 400 happens

boranx

comment created time in a month

pull request commentopenshift/moactl

Fix/verify rate limits

/hold Adding tests for permissions

boranx

comment created time in a month

pull request commentopenshift/moactl

Fix/verify rate limits

for checkPermissionsUsingQueryClient and related functions, there are no tests but I can add! That would be a nice value-adding

boranx

comment created time in a month

PR opened openshift/moactl

Fix/verify rate limits

Fixes: OSD-4671

I've realized a Retryer: client.DefaultRetryer was defined but NumMaxRetries was missing. By default, the value is 0 which means there will be no retry unless we increase the number. Results are looking good, I've tested it in while loop on 5 different tabs, didn't see any 400 but responses may take longer as a result of retry mechanism.

+18 -23

0 comment

3 changed files

pr created time in a month

create barnchboranx/moactl

branch : fix/verify-rate-limits

created branch time in a month

push eventopen-policy-agent/conftest

Lennard Eijsackers

commit sha e483052e3bc091178ea02a3db97c1d6b649509d0

fix: Ensure exceptions are consistenly applied, not only in the multiple objects in a single yaml file case Fixes #353 Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Boran Seref

commit sha 7b3ebbd14a3a84ba1f3fc998c397db61471d46c4

Merge pull request #358 from Blokje5/fix/issue-with-exception-rules Fix: Exceptions not applied against single input

view details

push time in a month

PR merged open-policy-agent/conftest

Fix: Exceptions not applied against single input

Ensure exceptions are consistently applied, not only in the multiple objects within a single yaml case.

Fixes #353

Signed-off-by: Lennard Eijsackers lennardeijsackers92@gmail.com

+29 -10

1 comment

1 changed file

Blokje5

pr closed time in a month

issue closedopen-policy-agent/conftest

Issue with "exception[rules]{}"

I find that this feature could be extremely useful for some of my use cases, so I want to thank you for adding it.

I was testing this with conftest v0.20.0. Given the following information below, I am wondering if this is what the expected behavior is suppose to look like.

Given this rule.rego file:

package main

deny_now[msg] {
  true
  msg := "Deny now!"
}

deny_always[msg] {
  true
  msg := "Deny always!"
}

exception[rules] {
  true
  rules := ["now"]
}

Scenario 1:

Given this test1.yaml file for input:

Kind: Deployment

I get the following results:

conftest test -p ./rule.rego ./test1.yaml
FAIL - ./test1.yaml - Deny now!
FAIL - ./test1.yaml - Deny always!

2 tests, 0 passed, 0 warnings, 2 failures, 0 exceptions

The results I was expecting:

conftest test -p ./rule.rego ./test1.yaml
FAIL - ./test1.yaml - Deny always!
EXCP - ./test1.yaml - data.main.exception[_][_] == "now"

2 tests, 0 passed, 0 warnings, 1 failures, 1 exceptions

Scenario 2:

Given this test2.yaml file for input

Kind: Deployment
---
Kind: DaemonSet

I get the following results:

conftest test -p ./rule.rego ./test2.yaml
FAIL - ./test2.yaml - Deny always!
FAIL - ./test2.yaml - Deny always!
EXCP - ./test2.yaml - data.main.exception[_][_] == "now"
EXCP - ./test2.yaml - data.main.exception[_][_] == "now"

4 tests, 0 passed, 0 warnings, 2 failures, 2 exceptions

This is exactly what I was expecting for scenario 2.

Just wondering if we can make scenario 1 work like scenario 2 when there is no "---" separator in the yaml file?

Thanks!

closed time in a month

josh-reed

push eventboranx/conftest

KeisukeYamashita

commit sha e80768189d2b96bbe5cf2579d94d50465e46c3d1

Add GitLab registry to OCI detector (#351) Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

Boran Seref

commit sha 51d108f2fd45d3c333f9efcb5898dec4c0d439b7

refactor(parse): make parse more testable, modify parserunner (#350) * refactor(parse): make parse testable, add config mock to write top down tests Signed-off-by: boranx <boran.seref@gmail.com> * refactor(parse): pass the address Signed-off-by: boranx <boran.seref@gmail.com> * refactor(parse): remove unnecessary params Signed-off-by: boranx <boran.seref@gmail.com> * refactor(parse): add generate command for config_mock Signed-off-by: boranx <boran.seref@gmail.com>

view details

push time in a month

startedopenshift/machine-api-operator

started time in 2 months

Pull request review commentopen-policy-agent/conftest

add examples for Dockerfile and k8s deployment

 @test "Output results only once" {   run ./conftest test -p examples/kubernetes/policy examples/kubernetes/deployment.yaml   count="${#lines[@]}"-  [ "$count" -eq 5 ]+  [ "$count" -eq 8 ] }  @test "Can verify rego tests" {   run ./conftest verify --policy ./examples/kubernetes/policy-  [ "$status" -eq 0 ]-  [[ "$output" =~ "4 tests, 4 passed" ]]+  [ "$status" -eq 1 ]+  [[ "$output" =~ "4 tests, 3 passed" ]]

same as above

lopeg

comment created time in 2 months

Pull request review commentopen-policy-agent/conftest

add examples for Dockerfile and k8s deployment

  @test "Verify command has trace flag" {     run ./conftest verify --policy ./examples/kubernetes/policy --trace-  [ "$status" -eq 0 ]+  [ "$status" -eq 1 ]

I would expect that those verify tests for Kubernetes policy be passed as they are actually verifying our policies are correct and will be tested against any change.

lopeg

comment created time in 2 months

push eventboranx/openshift-tools

jessesarn

commit sha b95a17919ae4345a8040a26ac01f50720f36e19f

add rhmi_check_rhsso.py tiered access command

view details

jessesarn

commit sha d2506f230f5e2c82cb4f3852632b44ca2d95cef5

pylint fixes

view details

jessesarn

commit sha 952d10a0bb7c67c7ea535c1d0a7e632d572b71c4

force retest

view details

jessesarn

commit sha 125d86b6b83837cc7912d8397f53b7b7b4d7b891

remove trailing line

view details

Alice Hubenko

commit sha a426a3d22e1b807fea25641a6331b9bca0d8e046

OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

Alice Hubenko

commit sha b2119c9a9e6bffed39ae9f3bcba78d5daa2cf897

OSD-3776: fix for script cron-send-project-stats for v3 monitoring. Corrected whitescpace.

view details

Alice Hubenko

commit sha caaf5aab9568cf08d2c4b4a2245f6a1fd1690b00

OSD-3776: fix for script cron-send-project-stats for v3 monitoring. Corrected wrong-import-order.

view details

Christoph Blecker

commit sha 7f8ae120fe953712dca9279bcdc5904b748aaca3

Merge pull request #4339 from aliceh/OSD-3776 OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

Matt Bargenquast

commit sha 2fbdb4fd5dd34c97779e938bb73f1b01f61fffb8

Merge pull request #4337 from jessesarn/devaccess_rhmi_check_rhsso-stg-retry add rhmi_check_rhsso.py tiered access command

view details

Blair Morrison

commit sha 8ad262fd43a98bd21db0935d6f31691f169da627

OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

Blair Morrison

commit sha 575b663c05b35e8f45b009f1df2fe079680c3ca9

Merge pull request #4343 from blrm/fix/OSD-3776 OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

Blair Morrison

commit sha 5470e2567f9962bd820ee87a7c8c40d55918f186

Merge pull request #4344 from blrm/fix/OSD-3776 OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

openshift-ops-bot

commit sha 018b7a691430224a083c47a7a248f982211753a1

Merge prod into stg

view details

push time in 2 months

push eventboranx/openshift-tools

Blair Morrison

commit sha 8ad262fd43a98bd21db0935d6f31691f169da627

OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

Blair Morrison

commit sha 5470e2567f9962bd820ee87a7c8c40d55918f186

Merge pull request #4344 from blrm/fix/OSD-3776 OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

openshift-ops-bot

commit sha cd8caf57762295f8ee0d2c83c284cf3d412a8933

Merge prod into int

view details

push time in 2 months

created tagboranx/openshift-tools

tagopenshift-tools-scripts-0.1.204-1

A public repository of scripts used by OpenShift Operations for various purposes

created time in 2 months

push eventboranx/openshift-tools

Blair Morrison

commit sha 8ad262fd43a98bd21db0935d6f31691f169da627

OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

Blair Morrison

commit sha 5470e2567f9962bd820ee87a7c8c40d55918f186

Merge pull request #4344 from blrm/fix/OSD-3776 OSD-3776: fix for script cron-send-project-stats for v3 monitoring.

view details

Blair Morrison

commit sha 0f07cd092bde5a70dccde82c61124aed7bf22160

Automatic commit of package [openshift-tools-scripts] release [0.1.204-1]. Created by command: /usr/bin/tito tag

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha 74416cbf5ce7f4b36196c9efb2248599aa4b807a

refactor(parse): add generate command for config_mock Signed-off-by: boranx <boran.seref@gmail.com>

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha c93e0ca8ad34b4ee7707da718ada7daf40928934

refactor(parse): add generate command for config_mock

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha f37461bc32771673dac3fb550a300a59fdcea633

refactor(parse): add generate command for config_mock

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha 3dbdede7f0ade2f596698ab0499dc56c680f95c6

refactor(parse): remove unnecessary params Signed-off-by: boranx <boran.seref@gmail.com>

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha 6729878fbd272f6115b12b6c1dc60e1baf9d3ee4

refactor(parse): remove unnecessary params Signed-off-by: boranx <boran.seref@gmail.com>

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha 350904006dac406e1409a9eb56c3275db4b00069

refactor(parse): make parse testable, add config mock to write top down tests Signed-off-by: boranx <boran.seref@gmail.com>

view details

boranx

commit sha 7670ab621bba5e92d8ad42515929f63026167484

refactor(parse): pass the address Signed-off-by: boranx <boran.seref@gmail.com>

view details

boranx

commit sha 742e1f65d31e25b44b76870a15de83f188bee304

refactor(parse): remove unnecessary params Signed-off-by: boranx <boran.seref@gmail.com>

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha c7de6445cf0611a92e243cfb6bb48c513651c9c3

refactor(parse): remove unnecessary params

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha a87d4d95895b9ebff4d9465fe71c5252356d0461

refactor(parse): pass the address

view details

push time in 2 months

PR opened open-policy-agent/conftest

refactor(parse): make parse testable, add config mock to write top down tests

That could be considered the first refactor for parse to eliminate nested functions on that subcommand. The aim is to create common structs for both test and parse since the configuration parsing and marshaling processes are the same.

+332 -197

0 comment

10 changed files

pr created time in 2 months

push eventboranx/conftest

boranx

commit sha 4a5b319592e1efcda6e52606fa6b40b24eff86fe

refactor(parse): make parse testable, add config mock to write top down tests

view details

push time in 2 months

push eventboranx/conftest

boranx

commit sha 9a0751641b7974fbc94b15d9ca6d18a4ca16d8e6

refactor(parse): make parse testable, add config mock to write top down tests

view details

push time in 2 months

create barnchboranx/conftest

branch : refactor-parse

created branch time in 2 months

push eventboranx/gcp-project-operator

Ron Green

commit sha 2e947a7db9aefc9d3dd62d1e5bd05a7dd60a22b9

fix(crd): remove breaking change when applying the on a v3.11 cluster I get: $ oc apply -f deploy/crds/gcp.managed.openshift.io_projectreferences_crd.yaml is invalid: spec.validation.openAPIV3Schema: Invalid value: .... must only have properties, required or description at the root if the status subresource is enabled this issue has been discussed on https://github.com/jetstack/cert-manager/issues/2200 and the solution is removing one generated line

view details

Manuel Dewald

commit sha f98ea017a47bb09894712d509dac2595379beeaa

Refactor ProjectClaim controller * unify subroutines called in Reconcile * match pattern from ProjectClaim reconcilation * move utility functions and result to util package

view details

OpenShift Merge Robot

commit sha fd3f0499eedbc4a6f109a55073b7d7d756f61b3f

Merge pull request #84 from NautiluX/refactor-projectclaim Refactor ProjectClaim controller

view details

OpenShift Merge Robot

commit sha 251d264a42393c94c27218750fad2f18da588e44

Merge pull request #86 from georgettica/rogreen/redeploy_operatorsdk feat(operator-sdk): upgrade operator-sdk to latest

view details

Ravi Trivedi

commit sha 80d29368eed354e4806d9e38b1d62f095db893ba

Changing base image for Dockerfile

view details

OpenShift Merge Robot

commit sha 0561e30a7df584fc11eacfb40ab97dbd7136d07c

Merge pull request #87 from ravitri/change_docker_build_image Changing base image for Dockerfile

view details

Ron Green

commit sha 0e8999baa6ac419da91bcf169e9aef58dcf819d8

fix(log_level): reorganized log levels now log levels are sorted by verbosity, the higher the number the more verbose it is

view details

OpenShift Merge Robot

commit sha 2a3c8f68a7c848b3d2236c88146fd9776b70fd48

Merge pull request #88 from georgettica/rogreen/reorganize-logs fix(log_level): reorganized log levels

view details

push time in 2 months

startedyeya24/promlinter

started time in 2 months

push eventboranx/conftest

Gareth Rushgrove

commit sha b055a7b8a493b396be5588dafcabddc040d88008

Exception docs are published but not linked in the nav Also added a missing input format from v0.20.0 Signed-off-by: Gareth Rushgrove <gareth@morethanseven.net>

view details

Gareth Rushgrove

commit sha 44921f0c642c1507aab7e86f191ce47988ff4d71

Also publish the Docker images to the Open Policy Agent namespace Keep pushing to both the new and old to maintain backwards compatibility. Signed-off-by: Gareth Rushgrove <gareth@morethanseven.net>

view details

Lennard Eijsackers

commit sha 4ec36f90f1d223d33c6262e4665c5895cc93d204

chore: Copy Output to a seperate dir Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Lennard Eijsackers

commit sha 24a45a3858f66850d2bc6fda00c0b2b698cb5e5d

chore: Refactor Verify command into Runner Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Lennard Eijsackers

commit sha 6bddcf3f4e977f2e6668e9d6543b1210f560d4a8

chore: Refactor Parse Command Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Gareth Rushgrove

commit sha d39ab692cc42a69d47c82cc3865686d6aae65f27

Merge pull request #345 from open-policy-agent/new-docker-namespace Also publish the Docker images to the Open Policy Agent namespace

view details

Lennard Eijsackers

commit sha 5c69d2d3a283622b6246ea668424af335d7a751c

Move output to a seperate package and remove old output in internal/commands Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Lennard Eijsackers

commit sha 07ff559a51867205f3cf21d3531eff3274300c93

Fix pipeline by pinning API version Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Gareth Rushgrove

commit sha f174e42373e38244d294f81ddb9c14e611358b46

Merge pull request #346 from open-policy-agent/missing-docs-navigation Exception docs are published but not linked in the nav

view details

Manuel Rüger

commit sha c5a62be45a701120504960fdc06117e77c2f6379

Dockerfile: Lint and prepare for multiarch Signed-off-by: Manuel Rüger <manuel@rueg.eu>

view details

Manuel Rüger

commit sha 78f3ec0335b8b453ddfca93a2228bb58f15cd7ac

.goreleaser: Support arm64 builds Signed-off-by: Manuel Rüger <manuel@rueg.eu>

view details

Manuel Rüger

commit sha b06f7958943f01919f03d69b7f09d68f8f1307a6

docs: Mention arm64 builds Signed-off-by: Manuel Rüger <manuel@rueg.eu>

view details

Gareth Rushgrove

commit sha 6ddeb35e9391181aa7419018015695ae50ff2645

Merge pull request #347 from mrueg/arm Dockerfile improvements, ARM64 binaries

view details

Boran Seref

commit sha d653c17ebce8850f0fbb2d5559b0acdd49adbaab

Merge pull request #327 from Blokje5/chore/refactor_command_logic_into_subpackages Refactor command logic into subpackages for verify and parse commands

view details

push time in 2 months

push eventopen-policy-agent/conftest

Lennard Eijsackers

commit sha 4ec36f90f1d223d33c6262e4665c5895cc93d204

chore: Copy Output to a seperate dir Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Lennard Eijsackers

commit sha 24a45a3858f66850d2bc6fda00c0b2b698cb5e5d

chore: Refactor Verify command into Runner Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Lennard Eijsackers

commit sha 6bddcf3f4e977f2e6668e9d6543b1210f560d4a8

chore: Refactor Parse Command Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Lennard Eijsackers

commit sha 5c69d2d3a283622b6246ea668424af335d7a751c

Move output to a seperate package and remove old output in internal/commands Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Lennard Eijsackers

commit sha 07ff559a51867205f3cf21d3531eff3274300c93

Fix pipeline by pinning API version Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

view details

Boran Seref

commit sha d653c17ebce8850f0fbb2d5559b0acdd49adbaab

Merge pull request #327 from Blokje5/chore/refactor_command_logic_into_subpackages Refactor command logic into subpackages for verify and parse commands

view details

push time in 2 months

PR merged open-policy-agent/conftest

Refactor command logic into subpackages for verify and parse commands

Issue: #316

This PR is WIP to have a discussion point for the related issue. The idea is to seperate CLI specific logic (Flag parsing, output handling) from the actual logic (Parsing input, Querying Rego). Each command will have an associated Runner. The Runner will be responsible for executing the actual logic, while all CLI specific logic remains inside the command file.

+249 -206

5 comments

11 changed files

Blokje5

pr closed time in 2 months

pull request commentopenshift/gcp-project-operator

fix(log_level): reorganized log levels

/lgtm

georgettica

comment created time in 2 months

pull request commentopen-policy-agent/conftest

WIP: Refactor command logic into subpackages

Yeah, works for me. Let's get this PR out of "draft" first

Blokje5

comment created time in 2 months

pull request commentopen-policy-agent/conftest

WIP: Refactor command logic into subpackages

Hi @Blokje5,

The initial(picking verify and parse) implement is OK for me, Thanks for putting this together :+1:
Having said that, we can consider also unifying some structures in the further like:

configurations, err := parser.GetConfigurations(ctx, input, fileList)
if err != nil {
	return "", fmt.Errorf("calling the parser method: %w", err)
}

for test.go and parse.go or moving

marshal(in interface{}) (string, error)

to output.go for better usability. (Those might be considered refactoring for the future) Anyway, from me it lgtm, @jpreese wdyt?

Blokje5

comment created time in 2 months

push eventboranx/conftest

Boran Seref

commit sha 4f382871304290a546ce838dcc90a9bd303874f7

feat(test): add ignore flag for filtering unwanted inputs (#312) * feat(test): add dir-exceptions flag for filtering unwanted inputs Signed-off-by: boranx <boran.seref@gmail.com>

view details

John Reese

commit sha 0b2bc83bffec7f595ceb4882061a3930226a597c

Refactor variable naming Signed-off-by: John Reese <john@reese.dev>

view details

Gareth Rushgrove

commit sha 81920e90aff1347dcf5f94c27950ef3f42343900

Merge pull request #317 from jpreese/variable-naming Update examples to use denylist

view details

Ethan J. Brown

commit sha 4d90463d067742d7641515ae05453a627dcfa2e1

Update opa module to v0.20.5 (#318) Signed-off-by: Iristyle <ethan_j_brown@hotmail.com>

view details

Dan Williams

commit sha 0049efc62b8a68274abb3d7dd170301388aefca1

Allow testing of multiple namespaces (#319) Signed-off-by: Dan Williams <me@deedubs.com>

view details

David Gillies

commit sha 5a78e68702be855200e32cd2dd10828f4c1150b5

Update spf13/viper from 1.5.0 to 1.7.0 Signed-off-by: David Gillies <dgillies@salesforce.com>

view details

Boran Seref

commit sha 2c68d0db46793a01fcb2f213e245f2933ae6c0af

Merge pull request #321 from davewongillies/dgillies/update_viper Update spf13/viper from 1.5.0 to 1.7.0

view details

Gareth Rushgrove

commit sha 66a0afde2093bc3131795502720b821df0805440

Fix badge for Netlify docs deploy (#325) Moving the site over to the new repository caused the old badge to break. Signed-off-by: Gareth Rushgrove <gareth@morethanseven.net>

view details

Aaron Jheng

commit sha 88e8f6f64463a4d371ddfdc22553724df7627868

Use encoding/json for json marshalling (#329) Signed-off-by: Aaron Jheng <wentworth@outlook.com>

view details

toVersus

commit sha 521bf48d21871f91ee80a8679b0dd4336e03ebbe

Fix typo in help message Signed-off-by: toVersus <toversus2357@gmail.com>

view details

Boran Seref

commit sha caaf7fdade35c119d50bbc6b13d638aa46e7712a

Merge pull request #330 from toVersus/typo Fix typo in help message

view details

KeisukeYamashita

commit sha a99c5b3662fb4e4e82f7f3e6c7c9c97a737ace53

Add Jsonnet support Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

KeisukeYamashita

commit sha 7bb8bea9d894b6f003ef46f51b6c8321029b0e2c

Add link for Jsonnet Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

Rémi Lapeyre

commit sha 373141ac822664baf447a8598667f8061464848f

Add support for JUnit (#328) * Add support for JUnit Signed-off-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr> * Use only the first line of the message in the name of the test Signed-off-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr> * Add tests for the JUnit Output Manager Signed-off-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr>

view details

keke

commit sha 65554401e1e879ef4b6d9776f1af7a264f27a800

Add testcase for json parser (#332) Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

KeisukeYamashita

commit sha dd04bb815c31e727ac968b11afb244fc9bc80dbc

Add detech of GCR and ECR Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

KeisukeYamashita

commit sha 677d4b183d85af6db89516adb348ce46f95773eb

Add localhost to detect as OCI registry Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

KeisukeYamashita

commit sha 83f1d81603e300d84465bb9e2b0c77160d1fd59a

Add localhost repository testcase Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

KeisukeYamashita

commit sha 025737406c3e831f08d76e1facce8d18a5bb01f6

Fix typo grc to gcr Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

Boran Seref

commit sha dc9717a94581535592df528ea8578af74bfa3fa7

Merge pull request #331 from KeisukeYamashita/add-jsonnet-support Add support for Jsonnet input

view details

push time in 2 months

issue commentopen-policy-agent/conftest

Request: Support wildcards in --namespace

Also documenting --namespace flag would be neat.

garethahealy

comment created time in 3 months

issue commentopen-policy-agent/conftest

Request: Support wildcards in --namespace

As far as I know, we have recently added that into master: https://github.com/open-policy-agent/conftest/pull/319 However, seems like what you are looking for is applying the namespaces via a Regex pattern. That could be a new feature for us to work on...

I'm wondering folks thoughts on that, @jpreese @Blokje5

garethahealy

comment created time in 3 months

pull request commentopenshift/gcp-project-operator

Refactor ProjectClaim controller

/lgtm

NautiluX

comment created time in 3 months

issue closedopen-policy-agent/conftest

Support Jsonnet input

To expand the potential places where Conftest could be used, it would be good to support jsonnet natively as an input.

closed time in 3 months

enkov

issue commentopen-policy-agent/conftest

Support Jsonnet input

Closing that as the support is now in the master.

enkov

comment created time in 3 months

push eventopen-policy-agent/conftest

KeisukeYamashita

commit sha a99c5b3662fb4e4e82f7f3e6c7c9c97a737ace53

Add Jsonnet support Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

KeisukeYamashita

commit sha 7bb8bea9d894b6f003ef46f51b6c8321029b0e2c

Add link for Jsonnet Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>

view details

Boran Seref

commit sha dc9717a94581535592df528ea8578af74bfa3fa7

Merge pull request #331 from KeisukeYamashita/add-jsonnet-support Add support for Jsonnet input

view details

push time in 3 months

PR merged open-policy-agent/conftest

Add support for Jsonnet input

What

Add Jsonnet support like

$ conftest test -p examples/jsonnet/policy examples/jsonnet/arith.jsonnet

Why

Jsonnet(https://jsonnet.org/) is a data templating language similar to CUE but Jsonnet is not supported while CUE is supported.

Solves https://github.com/open-policy-agent/conftest/issues/180 .

+132 -0

1 comment

9 changed files

KeisukeYamashita

pr closed time in 3 months

pull request commentopenshift/gcp-project-operator

Refactor ProjectClaim controller

I've tested it, that looks good.

NautiluX

comment created time in 3 months

push eventboranx/gcp-project-operator

Ron Green

commit sha d93696c6ee4e48c33decf6ade0e578f9b05af64f

Revert "feat(operator-sdk): upgrade operator-sdk to latest" This reverts commit 916d85592138386e60ceb33e4b692551f80e5206.

view details

OpenShift Merge Robot

commit sha 2cb9c7edd42c78888faafa865dd2fa54b83adb26

Merge pull request #85 from georgettica/rogreen/upgade_failsafe Revert "feat(operator-sdk): upgrade operator-sdk to latest"

view details

push time in 3 months

push eventboranx/gcp-project-operator

Manuel Dewald

commit sha f98cd362635c9e1cbdca3a21d1205d0bd3b5c81c

Refactor Reconcile * Use defined function definition and return value for all operations performed on ProjectReference * Operations can control behavior of the operator * Do not throw errors if GCP service account is not initialized

view details

Manuel Dewald

commit sha f9e21a0d4c14aabbddf976c129338a84bfed079e

Reduce parallel processing * Reduce number of parallel reconciles by returning after updating a CR * Reduce number of API calls to GCP by querying for a list of enabled APIs * Fix repeatedly creating service account keys when compute API is not ready * When secret is created, we can assume service API key is created. No need to create a new key and secret.

view details

root

commit sha 6996cfbe37b4491c6ca91e79fc71294de3bd099b

feat(operator-sdk): upgrade operator-sdk to latest follow manual in https://sdk.operatorframework.io/docs/migration/version-upgrade-guide/ * refactor(k8sclient): seperate classes into different files * refactor(mockgen): change to filename in mockgen * feat(Makefile): add target 'make updatevendor' * fix(projectclaimadapter): correlate struct to interface * fix(go.mod): add go-autorest version * refactor(go.mod): reorder dependencies - now the go.mod is seperated via: > pinned version > copied from other commands > normal dependencies * feat(hack): add script to create resources * fix(projectreference_types): add omitempty to status - this caused the crd generation to make status required - having the status required broke our operator How to Upgrade: --------------- use operator-sdk print-deps to show what the go.mod should look like operator-sdk generate k8s --verbose operator-sdk generate crd --crd-version=v1beta1 chore(openapi): upgrade openapi to upgrade the steps that were taken: - take the code from https://sdk.operatorframework.io/docs/migration/version-upgrade-guide/#v017x - change the input of -h to be `-h <(echo)` or input an empty file - generate with the commands specified 1. Add the line from https://raw.githubusercontent.com/operator-framework/operator-sdk-samples/c76ff2d5ae03528eb229b9382dce410a8b323ed9/go/memcached-operator/go.mod 2. run `go vet ./{pkg,cmd}/...` 3. run `go mod tidy` 4. run `make`

view details

OpenShift Merge Robot

commit sha 208b668fc9e02e1c7d3884e8a33306bd69cf4dec

Merge pull request #79 from georgettica/rogreen/upgrade-operator-sdk feat(operator-sdk): rogreen/upgrade operator sdk

view details

Manuel Dewald

commit sha fddc3397168af7636341b59e2d3aea85141f5aa8

Revert "feat(operator-sdk): rogreen/upgrade operator sdk"

view details

OpenShift Merge Robot

commit sha 76b62d6e4dec50998309ea29eb159a9e63c7088a

Merge pull request #81 from openshift/revert-79-rogreen/upgrade-operator-sdk Revert "feat(operator-sdk): rogreen/upgrade operator sdk"

view details

Drew Anderson

commit sha 4408e6d320ac086dbef036482b6864de2f2c2202

build-service-account.bash Manages the creation and upload of your gcloud serviceaccount keys to the gcp-project-operator in your cluster.

view details

OpenShift Merge Robot

commit sha 27b0bf345a83ac00cb0e0537c40b5879025c228a

Merge pull request #82 from drewandersonnz/build-sa feat(build-service-account): build service account bash

view details

Manuel Dewald

commit sha 6db1ef8da2a56492b68b22b7713a7566f673ea35

Apply review comments

view details

OpenShift Merge Robot

commit sha 98b2cf4f0c2d325e3497b4fde25ed79fabf84ed4

Merge pull request #80 from NautiluX/refactor-projectreference-controller Refactor Reconcile

view details

root

commit sha 916d85592138386e60ceb33e4b692551f80e5206

feat(operator-sdk): upgrade operator-sdk to latest follow manual in https://sdk.operatorframework.io/docs/migration/version-upgrade-guide/ * refactor(k8sclient): seperate classes into different files * refactor(mockgen): change to filename in mockgen * feat(Makefile): add target 'make updatevendor' * fix(projectclaimadapter): correlate struct to interface * fix(go.mod): add go-autorest version * refactor(go.mod): reorder dependencies - now the go.mod is seperated via: > pinned version > copied from other commands > normal dependencies * feat(hack): add script to create resources * fix(projectreference_types): add omitempty to status - this caused the crd generation to make status required - having the status required broke our operator How to Upgrade: --------------- use operator-sdk print-deps to show what the go.mod should look like operator-sdk generate k8s --verbose operator-sdk generate crd --crd-version=v1beta1 chore(openapi): upgrade openapi to upgrade the steps that were taken: - take the code from https://sdk.operatorframework.io/docs/migration/version-upgrade-guide/#v017x - change the input of -h to be `-h <(echo)` or input an empty file - generate with the commands specified 1. Add the line from https://raw.githubusercontent.com/operator-framework/operator-sdk-samples/c76ff2d5ae03528eb229b9382dce410a8b323ed9/go/memcached-operator/go.mod 2. run `go vet ./{pkg,cmd}/...` 3. run `go mod tidy` 4. run `make` (cherry picked from commit 6996cfbe37b4491c6ca91e79fc71294de3bd099b)

view details

OpenShift Merge Robot

commit sha 34151453b0e8e6859449b25f3d6978e079d0d0df

Merge pull request #83 from georgettica/rogreen/redeploy_operatorsdk feat(operator-sdk): upgrade operator-sdk to latest

view details

push time in 3 months

push eventopen-policy-agent/conftest

toVersus

commit sha 521bf48d21871f91ee80a8679b0dd4336e03ebbe

Fix typo in help message Signed-off-by: toVersus <toversus2357@gmail.com>

view details

Boran Seref

commit sha caaf7fdade35c119d50bbc6b13d638aa46e7712a

Merge pull request #330 from toVersus/typo Fix typo in help message

view details

push time in 3 months

PR merged open-policy-agent/conftest

Fix typo in help message

Just found this tiny typo

+1 -1

0 comment

1 changed file

toVersus

pr closed time in 3 months

more