profile
viewpoint
KeisukeYamashita KeisukeYamashita @merpay @mercari Nirvana https://keisukeyamashita.com/about SRE at @merpay @mercari

KeisukeYamashita/biko 28

CLI tool to jump to your browser directly

jphacks/TK_1805 4

OAISO - 居酒屋での注文から決済を一気通貫に管理できるWeb伝票サービス

karszawa/isucon9-qualify 0

その都度ガンバる

KeisukeYamashita/action-lgtm-reaction 0

Action to send LGTM reaction as image when we say LGTM

KeisukeYamashita/agera 0

Reactive Programming for Android

startedarmory/se-spinnaker-config

started time in 2 hours

startedcloudspannerecosystem/autoscaler

started time in 2 hours

fork KeisukeYamashita/backstage

Backstage is an open platform for building developer portals

https://backstage.io

fork in 6 hours

push eventMiro-Ecosystem/terraform-provider-miro

dependabot[bot]

commit sha 0502448933690d2ab467461705bb84924141faf4

Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.0.1 to 2.0.3 Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.0.1 to 2.0.3. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/hashicorp/terraform-plugin-sdk/compare/v2.0.1...v2.0.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

KeisukeYamashita

commit sha 94819f465b15592b75ee7d505e01a51706255d2d

Merge pull request #2 from Miro-Ecosystem/dependabot/go_modules/github.com/hashicorp/terraform-plugin-sdk/v2-2.0.3 Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.0.1 to 2.0.3

view details

push time in 2 days

PR merged Miro-Ecosystem/terraform-provider-miro

Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.0.1 to 2.0.3 dependencies

Bumps github.com/hashicorp/terraform-plugin-sdk/v2 from 2.0.1 to 2.0.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/hashicorp/terraform-plugin-sdk/blob/master/CHANGELOG.md">github.com/hashicorp/terraform-plugin-sdk/v2's changelog</a>.</em></p> <blockquote> <h1>2.0.3 (September 15, 2020)</h1> <p>BUG FIXES</p> <ul> <li>Fixed a bug that would incorrectly mark tests using TestStep.ImportStateVerify as failed if they tested a resource with custom timeouts (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/576">#576</a>)</li> <li>Fixed a bug where errors destroying infrastructure after tests wouldn't be reported (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/581">#581</a>)</li> <li>Fixed a bug where test steps that expected a non-empty plan would fail because they had an empty plan, erroneously (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/580">#580</a>)</li> <li>Fixed a bug where the plan output shown when an unexpected diff was encountered during testing would be shown in JSON instead of a human-readable format (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/584">#584</a>)</li> </ul> <h1>2.0.2 (September 10, 2020)</h1> <p>BUG FIXES</p> <ul> <li>Fixed bug where state is read from the wrong workspace during import tests. (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/552">#552</a>)</li> <li>Fixed bug where the resource could belong to another provider when finding the resource state to check during import tests (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/522">#522</a>)</li> <li>Removed excessive logging when ExpectNonEmptyPlan was successfully matched (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/556">#556</a>)</li> <li>Fixed bug where state from data sources, which can't be imported, would be surfaced during ImportStateVerify (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/555">#555</a>)</li> <li>Fixed bug that ignored ExpectError when testing state imports (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/550">#550</a>)</li> <li>Fixed bug that sometimes prevented TestStep numbers from appearing in error output (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/557">#557</a>)</li> <li>Fixed bug that would ignore <code>TestStep.Destroy</code> when running tests. (<a href="https://github-redirect.dependabot.com/hashicorp/terraform-plugin-sdk/issues/563">#563</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/35d7fcb6c861606651dee1584261138dd71fb61b"><code>35d7fcb</code></a> v2.0.3 [skip ci]</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/cf2154f163853ce54877e32ee399430bdc1ac82c"><code>cf2154f</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/648724a7c4fce937681ef45d37990c973a542b56"><code>648724a</code></a> Restore human-friendly plan output.</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/fb06282c871516021f7f4d670533ac9fe0f7bb9d"><code>fb06282</code></a> Restore pre-binary testing ExpectNonEmptyPlan behavior.</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/8c571eed2089a7e3b203587f8fea7fad30ebdc71"><code>8c571ee</code></a> Check the error on post-test destroy.</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/d5a54b6b1af1e570245fd775625c7bdba1fc061e"><code>d5a54b6</code></a> Add v2 Upgrade Guide and Learn docs to the README</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/e7b9f8e3994322b3302ef4a444a71b1e25e2a578"><code>e7b9f8e</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/cf5a77d0e1e3374f1aa8e314d3738a682b768d09"><code>cf5a77d</code></a> Fix spurious diff from timeouts.</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/a8e5eaf628dcbd66869b9512e81c3495cfac5722"><code>a8e5eaf</code></a> v2.0.2 [skip ci]</li> <li><a href="https://github.com/hashicorp/terraform-plugin-sdk/commit/66b6247a02964d0fd17733585d03dbe307792272"><code>66b6247</code></a> Bump .go-version to 1.14.9.</li> <li>Additional commits viewable in <a href="https://github.com/hashicorp/terraform-plugin-sdk/compare/v2.0.1...v2.0.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+40 -1

0 comment

2 changed files

dependabot[bot]

pr closed time in 2 days

startedmosuka/cete

started time in 2 days

startedactix/actix-web

started time in 7 days

issue commentflutter/flutter

Tables in horizontal scrolled SingleCHildScorllView displays wierd

If I use Row not Table is works. Is there things that I should care when I use Tables?

body: ListView(
          padding: EdgeInsets.symmetric(horizontal: 12, vertical: 24),
          children: <Widget>[
            LayoutBuilder(builder: (context, constraints) {
              return SingleChildScrollView(
                  scrollDirection: Axis.horizontal,
                  child: Row(
                    children: [
                      Container(
                        height: 20,
                        width: 400,
                        color: Colors.red,
                      ),
                      Container(
                        height: 20,
                        width: 400,
                        color: Colors.green,
                      )
                    ],
                  ));
            }),

Sep-14-2020 09-27-52

KeisukeYamashita

comment created time in 10 days

issue commentflutter/flutter

Tables in horizontal scrolled SingleCHildScorllView displays wierd

@Calamity210 Thanks for your reply. Now I have a widget tree like this but it is not scrollable anymore.

   body: ListView(
          children: <Widget>[
            LayoutBuilder(builder: (context, constraints) {
              return SingleChildScrollView(
                  scrollDirection: Axis.horizontal,
                  child: ConstrainedBox(
                    constraints: constraints,
                    child: Table(
                      children: [
                        TableRow(children: [
                          Container(
                            height: 20,
                            width: 100,
                            color: Colors.red,
                          ),
                          Container(
                            height: 20,
                            width: 100,
                            color: Colors.blue,
                          )
                        ]),
                        TableRow(children: [
                          Container(
                            height: 20,
                            width: 100,
                            color: Colors.green,
                          ),
                          Container(
                            height: 20,
                            width: 100,
                            color: Colors.red,
                          )
                        ]),
                        TableRow(children: [
                          Container(
                            height: 20,
                            width: 100,
                            color: Colors.red,
                          ),
                          Container(
                            height: 20,
                            width: 100,
                            color: Colors.red,
                          )
                        ])
                      ],
                    ),
                  ));
            }),

image

Am I missing something?

KeisukeYamashita

comment created time in 10 days

startedMayLau-CbL/flutter_horizontal_data_table

started time in 10 days

issue openedflutter/flutter

Tables in horizontal scrolled SingleCHildScorllView displays wierd

<!-- Thank you for using Flutter!

 If you are looking for support, please check out our documentation
 or consider asking a question on Stack Overflow:
  * https://flutter.dev/
  * https://api.flutter.dev/
  * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

 If you have found a bug or if our documentation doesn't have an answer
 to what you're looking for, then fill out the template below. Please read
 our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

-->

Steps to Reproduce

<!-- You must include full steps to reproduce so that we can reproduce the problem. -->

  1. Implement Table in SingleChildScrollView
SingleChildScrollView(
                scrollDirection: Axis.horizontal,
                child: Table(
                  children: [
                    TableRow(children: [Text('1-1'), Text('1-2')]),
                    TableRow(children: [Text('2-1'), Text('2-2')]),
                    TableRow(children: [Text('3-1'), Text('3-2')])
                  ],
                ))
  1. Run flutter create bug.

Expected results: <!-- what did you want to see? -->

It should look like this.

image

Actual results: <!-- what did you see? -->

It will look like this.

image

created time in 10 days

startedcodemagic-ci-cd/codemagic-docs

started time in 11 days

startedcodemagic-ci-cd/cli-tools

started time in 11 days

startedKagami/go-face

started time in 12 days

startedgcpug/zagane

started time in 13 days

startedCounterfeitLlama/OSX-Keylogger

started time in 13 days

startedbeatsbears/pkl

started time in 13 days

startedcaseyscarborough/keylogger

started time in 13 days

startedadamdecaf/namecheap

started time in 13 days

startednamecheap/flameshot

started time in 13 days

created tagMiro-Ecosystem/go-miro

tag0.1.0

Go written Miro API client

created time in 13 days

push eventMiro-Ecosystem/go-miro

KeisukeYamashita

commit sha f5d957169b1929912e8165a45dd50929c5237b21

Add badge godoc

view details

push time in 13 days

issue closedMiro-Ecosystem/go-miro

Implement all APIs for 0.1.0 release

What

I need to implement all kinds of PRC described in Miro REST API

Todo

  • [x] Boards
    • [x] Create Board
    • [x] Get Board
    • [x] Share Board
    • [x] Update Board
    • [x] Delete Board
    • [x] Get Current User Boards
  • [x] Board User Connections
    • [x] Get Board User Connection
    • [x] Update Board User Connection
    • [x] Delete Board User Connection
  • [x] Teams
    • [x] Get Team
    • [x] Update Team
    • [x] List all Team members
    • [x] Get Team Current User Connections
    • [x] Invite to Team
  • [x] Team User Connections
    • [x] Get Team User Connection
    • [x] Update Team User Connection
    • [x] Delete Team User Connection
  • [x] Pictures
    • [x] Get Picture
    • [x] Create or Update Picture
    • [x] Delete Picture
  • [x] User
    • [x] Get User
    • [x] Get Current User
    • [x] Update Current User
  • [x] Audit Logs
    • [x] Get logs
  • [x] Authorization Info
    • [x] Get Authorization ...

closed time in 13 days

KeisukeYamashita

push eventMiro-Ecosystem/go-miro

KeisukeYamashita

commit sha b3282342cf9019a9c5d43232422733156c82f7b4

Add update current user

view details

KeisukeYamashita

commit sha 5fe80111499dcc11910d00c0d1bc6772820be85b

Remove no need get

view details

KeisukeYamashita

commit sha 117f8ff61295a73f9eefbe0e6f5a86d159e416af

Add team user connections

view details

KeisukeYamashita

commit sha e15858fd646eadde903cf78c423d56ca7eb30916

Add team

view details

KeisukeYamashita

commit sha 1b7bfacfd056e0e47291dee61c2a4a2508fcb795

Upgrade readme for 0.1.0 release

view details

push time in 13 days

push eventMiro-Ecosystem/go-miro

KeisukeYamashita

commit sha 713c9f6d80a49b75c406ede1494dfe3ca52dd41a

add board list

view details

KeisukeYamashita

commit sha 4b4a5ca06a273f004963c9893386197c049778d1

Add audit logs

view details

push time in 13 days

startedsolo-io/wasm-image-spec

started time in 13 days

startedandybrewer/mack

started time in 13 days

startedlinkedin/rest.li

started time in 13 days

push eventMiro-Ecosystem/go-miro

KeisukeYamashita

commit sha 4560acd3b50373c197cedf2acfa7a1b0a88d3645

Update the readme for usage

view details

push time in 14 days

push eventMiro-Ecosystem/go-miro

KeisukeYamashita

commit sha d4de8cf5637007ce2341444c4c2cc3007828560c

Add Picture Delete

view details

KeisukeYamashita

commit sha fc8bba8e7bfdf674b6211f24ce864cd939807ca8

Add Picture upsert

view details

KeisukeYamashita

commit sha 72e2ac804db157f973030d1fb95103204f42e87a

Add user get current

view details

push time in 14 days

issue openedMiro-Ecosystem/go-miro

Implement all API for 0.1.0 release

What

I need to implement all kinds of PRC described in Miro REST API

Todo

  • [ ] Boards
    • [ ] Create Board
    • [ ] Get Board
    • [ ] Share Board
    • [ ] Update Board
    • [ ] Delete Board
    • [ ] Get Current User Boards
  • [ ] Widgets
    • [ ] List All Widgets
    • [ ] Get Widget
    • [ ] Create Widget
    • [ ] Update Widget
    • [ ] Delete Widgets ...

created time in 14 days

created repositorycloudworkflowsecosystem/cloud-run-base64-decoder

created time in 14 days

create barnchcloudworkflowsecosystem/awesome-workflows

branch : master

created branch time in 14 days

created repositorycloudworkflowsecosystem/awesome-workflows

created time in 14 days

startedGoogleCloudPlatform/functions-framework-nodejs

started time in 14 days

pull request commentspinnaker/spin

chrore(gateapi): go format client

Could you please tell me what commands you executed? Perhaps we can modify it so that it can be formatted.

KeisukeYamashita

comment created time in 14 days

startedgoogle/eleventy-high-performance-blog

started time in 14 days

startedIBM/ibm-mongodb-operator

started time in 14 days

startedcircleci/go-ecs-ecr

started time in 14 days

push eventKeisukeYamashita/hyacinth

dependabot[bot]

commit sha 831ccc9916e51de616e400e3d51b3e4d1d13df2a

Bump handlebars from 4.4.5 to 4.7.6 Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.5 to 4.7.6. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.5...v4.7.6) Signed-off-by: dependabot[bot] <support@github.com>

view details

KeisukeYamashita

commit sha 768eb5974bcda9e2d4705f3c2d86a15f6d94d5fb

Merge pull request #7 from KeisukeYamashita/dependabot/npm_and_yarn/handlebars-4.7.6 Bump handlebars from 4.4.5 to 4.7.6

view details

push time in 14 days

PR merged KeisukeYamashita/hyacinth

Bump handlebars from 4.4.5 to 4.7.6 dependencies

Bumps handlebars from 4.4.5 to 4.7.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md">handlebars's changelog</a>.</em></p> <blockquote> <h2>v4.7.6 - April 3rd, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1672">#1672</a> - Switch cmd parser to latest minimist (<a href="https://api.github.com/users/dougwilson">@dougwilson</a></li> </ul> <p>Compatibility notes:</p> <ul> <li>Restored Node.js compatibility</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.5...v4.7.6">Commits</a></p> <h2>v4.7.5 - April 2nd, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><del>Node.js version support has been changed to v6+</del> Reverted in 4.7.6</li> </ul> <p>Compatibility notes:</p> <ul> <li><del>Node.js < v6 is no longer supported</del> Reverted in 4.7.6</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.4...v4.7.5">Commits</a></p> <h2>v4.7.4 - April 1st, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1666">#1666</a> - Replaced minimist with yargs for handlebars CLI (<a href="https://api.github.com/users/aorinevo">@aorinevo</a>, <a href="https://api.github.com/users/AviVahl">@AviVahl</a> & <a href="https://api.github.com/users/fabb">@fabb</a>)</li> </ul> <p>Compatibility notes:</p> <ul> <li>No incompatibilities are to be expected</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.3...v4.7.4">Commits</a></p> <h2>v4.7.3 - February 5th, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1644">#1644</a> - Download links to aws broken on handlebarsjs.com - access denied (<a href="https://api.github.com/users/Tea56">@Tea56</a>)</li> <li>Fix spelling and punctuation in changelog - d78cc73</li> </ul> <p>Bugfixes:</p> <ul> <li>Add Type Definition for Handlebars.VERSION, Fixes <a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1647">#1647</a> - 4de51fe</li> <li>Include Type Definition for runtime.js in Package - a32d05f</li> </ul> <p>Compatibility notes:</p> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/e6ad93ea01bcde1f8ddaa4b4ebe572dd616abfaa"><code>e6ad93e</code></a> v4.7.6</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/2bf4fc6fd3ae3d8f076d628653f284d85faebeb4"><code>2bf4fc6</code></a> Update release notes</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/b64202bc9197307bd785a58693e3820eb9bb41a8"><code>b64202b</code></a> Update release-notes.md</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/c2f1e6203178918569f085e12afdb762cae17fb0"><code>c2f1e62</code></a> Switch cmd parser to latest minimist</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/08e9a11a34c3ad8387a0b85b1334f97cab85191a"><code>08e9a11</code></a> Revert "chore: set Node.js compatibility to v6+"</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/1fd2edee2a12fb228061fcde807905c6b14339c4"><code>1fd2ede</code></a> v4.7.5</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/3c9c2f5cf29cf10f54d5fe4daca6b24b65f0adcf"><code>3c9c2f5</code></a> Update release notes</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/16487a088e13f4d52c6fd6610b9ec71c4a51be8a"><code>16487a0</code></a> chore: downgrade yargs to v14</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/309d2b49a11628d2a8f052c5587e7459968cd705"><code>309d2b4</code></a> chore: set Node.js compatibility to v6+</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/645ac73844918668f9a2f41e49b7cb18ce5abf36"><code>645ac73</code></a> test: fix integration tests</li> <li>Additional commits viewable in <a href="https://github.com/wycats/handlebars.js/compare/v4.4.5...v4.7.6">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~erisds">erisds</a>, a new releaser for handlebars since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+16 -41

0 comment

1 changed file

dependabot[bot]

pr closed time in 14 days

delete branch KeisukeYamashita/hyacinth

delete branch : dependabot/npm_and_yarn/handlebars-4.7.6

delete time in 14 days

startedarno-di-loreto/openapi-map

started time in 14 days

startedlucasepe/crumbs

started time in 15 days

fork KeisukeYamashita/infracost

Cloud cost estimates for Terraform in your CLI and pull requests 💰📉

https://infracost.io

fork in 16 days

startedinfracost/infracost

started time in 16 days

startedFlutterGen/flutter_gen

started time in 16 days

PR opened mercari/fiat

Implement GraphQL Client for GitHub API for scalable Spinnaker authorization

What

I've introduced Apollo Client for fetching GitHub API resources(e.g. Teams, Organization Members) to Spinnaker Fiat.

Background

Previous discussion here https://github.com/spinnaker/spinnaker/issues/5966#issuecomment-683976365.

Currently, we are fetching all GitHub Organization Teams, Teams, and Team members every time. Since the GitHub API Rate limit is 5000 per account per hour, if the Spinnaker introducing organization has more than 5000 or near that, the Spinnaker Fiat will reach it's token's rate limit and the developer will not be able to login to Spinnaker.

Therefore, to Spinnaker to be introduced in big organization with authorization, we want to change how it access to GitHub API.

How will it change?

Let's say there is a GitHub Organization with 3000 teams and 10 members for each team. In current Fiat implementation with HTTP REST client, it will require these accesses to the GitHub API.

  • A: Get OrganizationMembers request: 1 times
  • B: Get OrganizationTeams request: 30 times(including pagination).
  • C: Get TeamsMembership request: 3030 times

So the total is 3061 times. But if there are more than 100 member in each Team or the number of teams increaded, it will soon reach the GitHub API Rate limit. Note that if there are more than 100 objects(e.g. Members, Teams) in a request, the client needs pagination. So,

With GraphQL, the rate limit is per nodes and the limit is 500,000 total nodes(ref: Node limit).

The required access of REST client and the required amount of node are the same but the GitHub API's rate limit is different, GraphQL has 500 times more capacity. Therefore, to make Spinnaker Authorization scalable, it's worth implementing this feature.

+3 -0

0 comment

2 changed files

pr created time in 16 days

create barnchmercari/fiat

branch : introduce-graphql

created branch time in 16 days

startediampawan/FlutterExampleApps

started time in 18 days

startedflutter/samples

started time in 18 days

issue commentspinnaker/spinnaker

Using Pipeline Permissions (useManagedServiceAccounts) in template does not work

Hey serviceaccount needs to be created manually

No, if you enable pipeline permissions, the spinnaker will automatically create a managed service account for you. (Still, it is not working...)

jaygorrell

comment created time in 19 days

push eventKeisukeYamashita/i

dependabot-preview[bot]

commit sha dedcb439593ca1937bc453fbb06d0287aa062e93

Bump github.com/onsi/ginkgo from 1.11.0 to 1.14.1 Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.11.0 to 1.14.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.11.0...v1.14.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

KeisukeYamashita

commit sha a8352ea78a54c80b70d5e3769d50cac03729595b

Merge pull request #49 from KeisukeYamashita/dependabot/go_modules/github.com/onsi/ginkgo-1.14.1 Bump github.com/onsi/ginkgo from 1.11.0 to 1.14.1

view details

push time in 19 days

delete branch KeisukeYamashita/i

delete branch : dependabot/go_modules/github.com/onsi/ginkgo-1.14.1

delete time in 19 days

PR merged KeisukeYamashita/i

Bump github.com/onsi/ginkgo from 1.11.0 to 1.14.1 dependencies

Bumps github.com/onsi/ginkgo from 1.11.0 to 1.14.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/onsi/ginkgo/releases">github.com/onsi/ginkgo's releases</a>.</em></p> <blockquote> <h2>v1.14.1</h2> <h3>Fixes</h3> <ul> <li>Discard exported method declaration when running ginkgo bootstrap (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/558">#558</a>) [f4b0240]</li> </ul> <h2>v1.14.0</h2> <h3>Features</h3> <ul> <li>Defer running top-level container nodes until RunSpecs is called [d44dedf]</li> <li><a href="http://onsi.github.io/ginkgo/#understanding-ginkgos-lifecycle">Document Ginkgo lifecycle</a></li> <li>Add <code>extensions/globals</code> package (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/692">#692</a>) [3295c8f] - this can be helpful in contexts where you are test-driving your test-generation code (see <a href="https://github-redirect.dependabot.com/onsi/ginkgo/pull/692">#692</a>)</li> <li>Print Skip reason in JUnit reporter if one was provided [820dfab]</li> </ul> <h2>v1.13.0</h2> <h3>Features</h3> <ul> <li>Add a version of table.Entry that allows dumping the entry parameters. (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/689">#689</a>) [21eaef2]</li> </ul> <h3>Fixes</h3> <ul> <li>Ensure integration tests pass in an environment sans GOPATH [606fba2]</li> <li>Add books package (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/568">#568</a>) [fc0e44e]</li> <li>doc(readme): installation via "tools package" (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/677">#677</a>) [83bb20e]</li> <li>Solve the undefined: unix.Dup2 compile error on mips64le (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/680">#680</a>) [0624f75]</li> <li>Import package without dot (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/687">#687</a>) [6321024]</li> <li>Fix integration tests to stop require GOPATH (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/686">#686</a>) [a912ec5]</li> </ul> <h2>v1.12.3</h2> <h3>Fixes</h3> <ul> <li>Print correct code location of failing table test (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/666">#666</a>) [c6d7afb]</li> </ul> <h2>v1.12.2</h2> <h3>Fixes</h3> <ul> <li>Update dependencies [ea4a036]</li> </ul> <h2>v1.12.1</h2> <h3>Fixes</h3> <ul> <li>Make unfocus ("blur") much faster (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/674">#674</a>) [8b18061]</li> <li>Fix typo (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/673">#673</a>) [7fdcbe8]</li> <li>Test against 1.14 and remove 1.12 [d5c2ad6]</li> <li>Test if a coverprofile content is empty before checking its latest character (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/670">#670</a>) [14d9fa2]</li> <li>replace tail package with maintained one. this fixes go get errors (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/667">#667</a>) [4ba33d4]</li> <li>improve ginkgo performance - makes progress on <a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/644">#644</a> [a14f98e]</li> <li>fix convert integration tests [1f8ba69]</li> <li>fix typo succesful -> successful (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/663">#663</a>) [1ea49cf]</li> <li>Fix invalid link (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/658">#658</a>) [b886136]</li> <li>convert utility : Include comments from source (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/657">#657</a>) [1077c6d]</li> <li>Explain what BDD means [d79e7fb]</li> <li>skip race detector test on unsupported platform (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/642">#642</a>) [f8ab89d]</li> <li>Use Dup2 from golang.org/x/sys/unix instead of syscallDup (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/638">#638</a>) [5d53c55]</li> <li>Fix missing newline in combined coverage file (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/641">#641</a>) [6a07ea2]</li> <li>check if a spec is run before returning SpecSummary (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/645">#645</a>) [8850000]</li> </ul> <h2>v1.12.0</h2> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md">github.com/onsi/ginkgo's changelog</a>.</em></p> <blockquote> <h2>1.14.1</h2> <h3>Fixes</h3> <ul> <li>Discard exported method declaration when running ginkgo bootstrap (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/558">#558</a>) [f4b0240]</li> </ul> <h2>1.14.0</h2> <h3>Features</h3> <ul> <li>Defer running top-level container nodes until RunSpecs is called [d44dedf]</li> <li><a href="http://onsi.github.io/ginkgo/#understanding-ginkgos-lifecycle">Document Ginkgo lifecycle</a></li> <li>Add <code>extensions/globals</code> package (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/692">#692</a>) [3295c8f] - this can be helpful in contexts where you are test-driving your test-generation code (see <a href="https://github-redirect.dependabot.com/onsi/ginkgo/pull/692">#692</a>)</li> <li>Print Skip reason in JUnit reporter if one was provided [820dfab]</li> </ul> <h2>1.13.0</h2> <h3>Features</h3> <ul> <li>Add a version of table.Entry that allows dumping the entry parameters. (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/689">#689</a>) [21eaef2]</li> </ul> <h3>Fixes</h3> <ul> <li>Ensure integration tests pass in an environment sans GOPATH [606fba2]</li> <li>Add books package (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/568">#568</a>) [fc0e44e]</li> <li>doc(readme): installation via "tools package" (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/677">#677</a>) [83bb20e]</li> <li>Solve the undefined: unix.Dup2 compile error on mips64le (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/680">#680</a>) [0624f75]</li> <li>Import package without dot (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/687">#687</a>) [6321024]</li> <li>Fix integration tests to stop require GOPATH (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/686">#686</a>) [a912ec5]</li> </ul> <h2>1.12.3</h2> <h3>Fixes</h3> <ul> <li>Print correct code location of failing table test (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/666">#666</a>) [c6d7afb]</li> </ul> <h2>1.12.2</h2> <h3>Fixes</h3> <ul> <li>Update dependencies [ea4a036]</li> </ul> <h2>1.12.1</h2> <h3>Fixes</h3> <ul> <li>Make unfocus ("blur") much faster (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/674">#674</a>) [8b18061]</li> <li>Fix typo (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/673">#673</a>) [7fdcbe8]</li> <li>Test against 1.14 and remove 1.12 [d5c2ad6]</li> <li>Test if a coverprofile content is empty before checking its latest character (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/670">#670</a>) [14d9fa2]</li> <li>replace tail package with maintained one. this fixes go get errors (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/667">#667</a>) [4ba33d4]</li> <li>improve ginkgo performance - makes progress on <a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/644">#644</a> [a14f98e]</li> <li>fix convert integration tests [1f8ba69]</li> <li>fix typo succesful -> successful (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/663">#663</a>) [1ea49cf]</li> <li>Fix invalid link (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/658">#658</a>) [b886136]</li> <li>convert utility : Include comments from source (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/657">#657</a>) [1077c6d]</li> <li>Explain what BDD means [d79e7fb]</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/onsi/ginkgo/commit/6d83527acb3f6cda405ce47a475d480117098381"><code>6d83527</code></a> v1.14.1</li> <li><a href="https://github.com/onsi/ginkgo/commit/f49cf5da3a2feb370fdf7c321ffc08b472f7c4d3"><code>f49cf5d</code></a> Update README.md</li> <li><a href="https://github.com/onsi/ginkgo/commit/f4b024089c399256e0fc9fc3878dbab071d69c9f"><code>f4b0240</code></a> Discard exported method declaration when running ginkgo bootstrap (<a href="https://github-redirect.dependabot.com/onsi/ginkgo/issues/558">#558</a>)</li> <li><a href="https://github.com/onsi/ginkgo/commit/1bed1cb69ab4f4f9cc0afbb73e73f9974bfeb89a"><code>1bed1cb</code></a> docs(readme): correct Ginkgo path in tools example</li> <li><a href="https://github.com/onsi/ginkgo/commit/9c254cb251dc962dc20ca91d0279c870095cfcf9"><code>9c254cb</code></a> v1.14.0</li> <li><a href="https://github.com/onsi/ginkgo/commit/749dbe7cd9d95ebb6ee738f00f8dc3fced1b8a5a"><code>749dbe7</code></a> Add test for junit reporter skipped message</li> <li><a href="https://github.com/onsi/ginkgo/commit/4fcfb02597f9d4974e527d77c24c38d3cfbdf760"><code>4fcfb02</code></a> Remove Ω from junit reporter test</li> <li><a href="https://github.com/onsi/ginkgo/commit/820dfab7b2085dc23ac102a3fdfc58b5093b32e1"><code>820dfab</code></a> Print Skip reason in JUnit reporter if one was provided</li> <li><a href="https://github.com/onsi/ginkgo/commit/d85a2555e5acadf1ffa640e45800e2c48ad5a0a3"><code>d85a255</code></a> Update broken cli link in comment</li> <li><a href="https://github.com/onsi/ginkgo/commit/415e0837906ea95ea0c1249ccab9ee32d8af8ca6"><code>415e083</code></a> clean up go mod; perhaps <em>now</em> travis will pass?</li> <li>Additional commits viewable in <a href="https://github.com/onsi/ginkgo/compare/v1.11.0...v1.14.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+36 -9

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 19 days

startednytimes/openapi2proto

started time in 19 days

startedhajimehoshi/wasmserve

started time in 19 days

startedflutter/flutter

started time in 20 days

fork KeisukeYamashita/channelzcli

channelzcli is a command line tool for gRPC channelz service.

fork in 20 days

startedkazegusuri/channelzcli

started time in 20 days

startedfacebook/yoga

started time in 20 days

created tagmercari/terraform-provider-spinnaker

tagv0.2.4

A Spinnaker provider for Terraform

created time in 20 days

push eventmercari/terraform-provider-spinnaker

KeisukeYamashita

commit sha 8f64934b8ab5d8dce627fa4bfaa577c658dfd35c

chore(changelog): update release note for v0.2.4

view details

KeisukeYamashita

commit sha 3dd379c472685e67c161dc9dbfd4842031f1456b

Merge pull request #70 from mercari/update-release-not-for-v0.2.4 Update release notes for v0.2.4

view details

push time in 20 days

delete branch mercari/terraform-provider-spinnaker

delete branch : update-release-not-for-v0.2.4

delete time in 20 days

PR merged mercari/terraform-provider-spinnaker

Reviewers
Update release notes for v0.2.4

WHAT

To release v0.2.4. This contains tiny changes that I've self-reviewed and merged too. PTAL.

WHY

Maintain 🚀

+3 -1

0 comment

1 changed file

KeisukeYamashita

pr closed time in 20 days

push eventKeisukeYamashita/kleat

Maggie Neterval

commit sha 84ba43348b1790c3d6ab8e6e2d9c5477f5700a10

feat(proto): mark AWS and Google canary accounts rootFolder as optional (#95) * feat(test): add tests for canary rootFolder fields Add empty and non-empty rootFolder field to halconfig.yml. The empty rootFolder will be omitted from kayenta.yml, which is not the behavior we want. The next commit will mark rootFolder as optional since we are considering an empty string a valid value distinct from nil. * feat(proto): mark AWS and Google canary accounts rootFolder as optional

view details

Eric Zimanyi

commit sha f274236837817812a1bafeafbd974235eb249269

refactor(proto): Wrap all boolean fields (#96) * refactor(proto): Wrap all boolean fields We've decided that all boolean fields should have presence information. Without this, booleans will not be included in the serialized config if they are 'false'. While this is fine for fields that default to false (for now), it breaks for any field that defaults to true. It also would cause issues if any field were changed in the future to default to true. One of the advantages of kleat is that it only includes fields that are explicitly set by the user in its config, so it is easier to change field defaults, as only users who have explicitly set a field will be overriding the default. But if we store a boolean without presence, it's impossible to ever in the future default it to 'true'. It also might be confusing for users that some fields in their hal config are not in their microservice configs. * fix(core): Remove TODO and add documentation Remove a TODO, and also fix the code which should pass through the value when non-nil (not only when true). Also document how to choose a field type. This also re-wraps the file. I didn't otherwise change anythign above the added section, so didn't break this into commits as it should be easy to see what was re-wrapped vs what was added. * test(orca): Fix broken test I fixed the code so explicitly set false is passed through for pipeline templates, but didn't fix the test.

view details

Eric Zimanyi

commit sha cdf3deeec65ce2a7366f60e2e914edd3078b841f

feat(proto): Wrap string and int32 fields where necessary (#97) * feat(kubernetes): Add missing Kubernetes fields A few fields were missing from KubernetesAccount. Add these. * feat(proto): Wrap string and int32 fields where necessary This commit goes through all string and int32 fields, wrapping them where necessary. The only changes necessary were a few string fields. * fix(proto): Fix two optional fields I said I'd update the two existing optional string fields, but forgot to in the last commit. * style(proto): Fix capitalization Co-authored-by: Maggie Neterval <mneterval@google.com> * fix(core): Recompile protos Co-authored-by: Maggie Neterval <mneterval@google.com>

view details

Eric Zimanyi

commit sha 1754772f46c6c8957cb68e8832e84a2862548eb4

feat(proto): Add unspecified to enum fields (#98) * style(test): Sort halconfig file It's easier to find fields if it's sorted. Also while making trivial changes, format the markdown files with prettier. * feat(security): Remove unused enum This enum was only used by Halyard to track they type of OAuth provider you had configured; it used this to set other fields when you ran hal commands. A while back I updated the documentation on spinnaker.io to show users how to set the required fields themselves (which is useful both for directly editing your hal config with Halyard, or for early adopters of kleat). We can remove this field as it is not used. I'll add a note to the changelog about this. Existing Halyard users would already have had the other fields filled out based on that field when they ran hal commands, so I'm not including this as a breaking change. New users will need to set their config fields themselves using the documentation on spinnaker.io. * feat(proto): Add unspecified to enum fields We want to distinguish unspecified enums from enums set to their default value. Let's do this by making the default value in each enum be a sentinel UNSPECIFIED value. This means that when the field is not specified, it will be deseriazlied as UNSPECIFIED, and will be omitted from re-serialization. Any valid value will be included in serialization.

view details

Eric Zimanyi

commit sha f692d6caaed0da1ece33755bd884dd3e5156fab6

feat(ci): Remove default exclusions from golang-ci (#99) * feat(ci): Remove default exclusions from golang-ci It turns out some things (including commenting exported functions) are turned off by default on golang-ci. (And I've already forgotten to comment three exported functions in the pas few days.) Let's turn off the default exclusions, as we should be starting from a clean slate. If it turns out there is something it flags that we find annoying and don't want to fix, we can figure out how to turn that off individually. I'm making this commit separately as I want to ensure that it catches the errors I think it should, then will fix in a follow-up commit. * style(core): Add some missing comments, and fix package Add comments to the exported functions that are missing comments. Also, I realize that I used the older version of the proto library when writing the helper wrapper functions. This worked because wrappers in the old library just aliases BoolValue to the new library, but let's remove the indirection (and direct dependence on the new library). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Maggie Neterval

commit sha 3c690a996f37ea9241982f49621c82c3cd0bd755

feat(pkg): add monitoring daemon support (#100) Adds monitoring dameon metric stores, hal to monitoring translation, and test converage.

view details

Maggie Neterval

commit sha 8e94facf962b85e916629f9d7c19acd3ca46800e

fix(pkg): Add snake_case json_names to snake_case monitoring protos (#101)

view details

Eric Zimanyi

commit sha 03538e372abacb2bae7ed18541689a23ee98eacf

fix(core): Address ignored fields from test halconfig (#102) * fix(test): Remove unused fields from test halconfig This commit removes fields that are not used by kleat from the test halconfig. * feat(proto): Add some missing protos These are fields that Halyard defaults but doesn not expose commands for editing (though users can still manuall set them). In order to preserve backwards-compatibility for users migrating from Halyard we should still support reading them. Ideally the fields should be defaulted to something sensible in the service, but this will not affect migrating users who already have them specified. * fix(proto): Fix mis-spelled requiredGroupMembership This was incorrectly included as requiredGroupMemberships in a number of protos. * feat(proto): Remove experimental flag As we're not using optional protos, remove the experimental flag as we don't need it anymore. * chore(core): Bump deps and run go mod tidy

view details

Eric Zimanyi

commit sha a6df71e03fda2cedeaca9735fb28db8fdf65b938

feat(stats): Include stats fields in echo config (#103) * test(echo): Refactor echo tests to handle stats changes The stats block has a property that no other field in the hal config has; even when nothing is specified in the input, we still generate some output. This is because one of the blocks in the stats config is the deployment method, which kleat needs to fill in with details about itself. While this is a departure from the usual situation where empty input leads to empty output, it feels like this is the one case where an exception is warranted given that this output needs to be populated by kleat rather than by the user. To make the diff on that change smaller, refactor the tests now to include this default value for the Stats field (currently nil). * refactor(stats): Use a different message for input/output stats While currently the only configurable stats field is whether it is enabled, we'll soon be adding more fields. Some fields will only be in the output (ie, that Spinnaker is being deployed by kleat and the kleat version) and should not be in the input. To allow us to do this, use a different message for the block in the hal config and in the echo config. Another approach would be to use the same message, but have the fields be ignored in the input. I didn't do that as I don't want those documented as they might add confusion, but am definitely open to further thoughts on this. * feat(stats): Add stats protos Add the remaining fields to the stats protos. This commit does not use these new fields yet, but it does lightly refactor the tests to explicitly include some of the fields as nil in the tests (making the diff in the next commit cleaner). * feat(stats): Include stats fields in echo config This commit includes the newly-added stats fields in the generated echo config, and adds some tests on these fields.

view details

Eric Zimanyi

commit sha 28924724b04dbf1547e06983757f4950b73f7043

feat(stats): Pass version to echo config (#104) * refactor(core): Make version fields accessible outside of package This commit pulls the variables to hold build-time information into their own package and exports them (so that consumers don't need to import things from cmd). * feat(stats): Pass version to echo config Pass the version of kleat used to generate the config to the echo config so that it is recorded along with the deployment method.

view details

Eric Zimanyi

commit sha d8ab2402714cd46046dab6c5bda959edffc424da

fix(release): Fix changelog generation (#105) Every kleat release was generating a full changelog of all commits ever made rather than only those since the last release. The reason for this is that we were not fetching tags when cloning the repository, so when go-releaser used 'git describe' to find the last tag, it was not finding one and thus generating a changelog of all commits ever made. This could be fixed by adding a --tags to the unshallow command, but it looks like the github action will fetch tags if you pass depth=0 to it (which means fetch all commits) so let's do that instead. It looks like in the two weeks since we added this config, go-releaser has updated their docs to now suggest adding depth=0 to the checkout command (whereas they previously had the unshallow command that was broken).

view details

Eric Zimanyi

commit sha 01400ce15a8877f2763b02b8568abf5aec8cdf90

feat(travis): Add numberOfJobs and buildResultLimit (#106) These parameters were just added to Halyard, since the time we added Travis support to kleat. Update kleat with them.

view details

Eric Zimanyi

commit sha 0c7699f2ce3ce8e6a708c8ba70c785dafcc3478b

chore(core): Bump dependencies (#107) * chore(core): Bump dependencies go get -u ./... * chore(proto): Bump protoc-gen-go Also while updating the docker file, revert to using the official release of protoc-gen-doc as we don't need optional support anymore. This way we're no longer depending on the version in my fork. * refactor(proto): Remove wrapper package google.golang.org/protobuf v1.25.0 adds new helper functions that obviate the need for the ones that we wrote. Let's remove our layer of indirection and just call the new functions.

view details

Maggie Neterval

commit sha 85d1f3c5a7fe5fe529c71058c878e664ce1da9e6

fix(deck): create empty providers.kubernetes entry if provider is enabled (#108) As explained in this [PR](https://github.com/spinnaker/deck/pull/8381), the Kubernetes provider does not have any statically configured defaults in Deck. However, the registration of the Kubernetes cloud provider in Deck depends on the truthiness of `providers.kubernetes`.

view details

Andrew Z Allen

commit sha 20502686e9634a4faec2a75cbce96cae4ebbea99

Improve help message for generate command (#109) Update the `Use` parameter to include usage per the cobra docs: ``` // Use is the one-line usage message. ``` This makes the output in the "Usage" section to contain a description of the mandatory arguments. Additionally updates the usage example to contain the command name.

view details

Maggie Neterval

commit sha dff87b96846fdcdb700c66840192d28e03629dde

feat(proto): add Travis filteredRepositories field (#111) This field was added to Halyard recently: https://github.com/spinnaker/halyard/pull/1730

view details

German Muzquiz

commit sha aaeb204acecd94b2254a52f824e9ca72fe5082ec

feat(authn/saml): New optional SAML parameter for signing messages (#114) * feat(authn/saml): New optional SAML parameter for signing messages * feat(authn/saml): Added "unspecified" enum entry * feat(authn/saml): Regenerated code

view details

Andrew Z Allen

commit sha 0f542f027cb3c827d02a5df0e6489534e5bb8cce

Create the output directory if it doesn't exist (#113) * Create the output directory if it doesn't exist Fixed: #110 * Update internal/fileio/fileio.go Co-authored-by: Maggie Neterval <mneterval@google.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Eric Zimanyi

commit sha c94067a11bd6d216e2ee20724749e8051887132c

fix(protoc): Run protoc container as invoking user (#115) * style(proto): Add newlines in docker command This will make it easier to see what changed when adding/removing arguments to the command. * refactor(proto): Use mount instead of volume command The mount command is newer and recommended by Docker. It also allows us to mount a volume readonly, which we want to do for the proto directory (which is input only). * refactor(protoc): Use better directories in container It's customary for mounted filesystems to be in /mnt; let's mount our files there instead of directly in the root of the filesystem. Rather than have a top-level staging directory, make this directory in /tmp. Also create it as part of the genproto script so it's automatically owned by whichever user is running the script. * fix(protoc): Fix file permissions in kleat-protobuilder This commit updates the intermediate containers used to fetch protoc and its dependencies to no longer run as root. The first change is to update the 'curl' container to run as a non-root user 'curl' to set the work directory to this user's home directory. After downloading and unzipping the desired files, we run chmod to set the desired permissions, which in many cases are not set to what we want in the tar/zip archive. We want 755 for directories and executable files and 644 for non-executable files, so that only the owner can modify but anyone can use the files when running protoc. When copying the files to the kleat-protobuilder container, explicitly have them owned by root (leaving the permissions as what we set them to after downloading). This matches the way things are normally installed on linux, where root owns the files and is the only user with permission to write, but any user can read/execute the files. In the case of genproto, we'll explicitly follow up with a chmod to ensure it has mode 755 as we can't necessarily control what the user has on their system. As of this commit, we've fixed the permissions so that it is now possible to run the kleat-protobuilder as a non-root user by passing the -u flag to docker, but we're not actually doing that yet, which will follow in an upcoming commit. * fix(protoc): Run protoc container as invoking user This commit adds the -u flag to the docker command running the protocol buffer compilation, so that the container runs with the same uid/gid as the invoking user. This will cause any output files to have this uid/gid (instead of being owned by root as before). I've also created a user 'protoc' in the container and set the user to that user. This is really just a fallback so we're falling back to a non-root user; this will always be overridden by the --user flag that we've added to the docker run command.

view details

Andrew Z Allen

commit sha af4b33c5d8f28c934c7c1178113ee6218416fb22

Add documentation on nested image paths (#116) * Add documentation on nested image paths * Generate protos/docs

view details

push time in 21 days

PR closed spinnaker/kleat

Reviewers
fix(deck): missing default for Kubernetes provider

What

Implemented a default field to Kubernetes Provider for Spinnaker Deck.

Is default field(=property is deck) is read by Deck. If we don't implement this, we have to configure in settings-local.js as below:

window.spinnakerSettings.providers.kubernetes = { defaults: {} }

It would be great if this will be fixed. With Halyard, we don't need to configure this.

Why

  • Solves #136
+131 -41

1 comment

7 changed files

KeisukeYamashita

pr closed time in 21 days

pull request commentspinnaker/kleat

fix(deck): missing default for Kubernetes provider

This only happens in 1.20 release which kleat doesn't support. So, I will close this. Sorry for your confusion.

KeisukeYamashita

comment created time in 21 days

issue commentspinnaker/kleat

Kleat missing default Kubernetes account in Deck's "settings.json"

@maggieneterval Thanks for your kind reply! We were trying to deploy the 1.20.8 stable release. Sorry, I've missed that kleat recommends 1.21+.

I think in this case, only the legacy Kubernetes (v1) provider required these provider defaults, and was only supported through 1.20.

Yeah, exactly... Thank you for taking your time to reply this. I will close this issue & PR.

KeisukeYamashita

comment created time in 21 days

push eventKeisukeYamashita/kleat

KeisukeYamashita

commit sha 05eaad41a6b72e196f0e3a0aef35bf9ddaae75dc

remove deck.enve

view details

push time in 21 days

startedapplike/gosoline

started time in 21 days

push eventKeisukeYamashita/kleat

KeisukeYamashita

commit sha 04f21b3a06d74faf42771c509f1b3e182314608f

fix(deck): missing default provider

view details

push time in 21 days

push eventKeisukeYamashita/kleat

KeisukeYamashita

commit sha 2744ffb9f4f0be78ee4c13292a5ea8be5b7ce01d

fix(testdata): add defaults to kubernetes provider

view details

push time in 21 days

push eventKeisukeYamashita/kleat

KeisukeYamashita

commit sha 5bca840a0af6c8f96143f23ee7abf7a0c3bb23c3

fix(deck): haltodeck test

view details

push time in 21 days

PR opened spinnaker/kleat

Reviewers
fix(deck): missing default for Kubernetes provider

What

Implemented a default field to Kubernetes Provider for Spinnaker Deck.

Why

  • Solves #136
+127 -39

0 comment

4 changed files

pr created time in 21 days

starteddominikh/go-tools

started time in 21 days

push eventmercari/terraform-provider-spinnaker

KeisukeYamashita

commit sha 57031ed3e96564142048b0695ae77a32262ddee9

upgrade spinnnaker_application to v2

view details

KeisukeYamashita

commit sha 0ea077ec4b68692ea4baa577d51490a43fccec46

upgrate canary_config to v2

view details

KeisukeYamashita

commit sha cfb15cf785576c49f66f9e0854138a5c4510ad45

upgrade project to v2

view details

KeisukeYamashita

commit sha 5975e9cc0734fb51824ebff339724792349ecc8c

add descricate message to pipeline & pipeline_template

view details

KeisukeYamashita

commit sha 4b1a7de0b64fba87551b8217dd1ba637df7bd10a

upgrade test to v2 sdk

view details

KeisukeYamashita

commit sha 9728b2fc7aa62d9bcc2c28af416e3daaed330686

Merge branch 'master' into update-plugin-sdk-v2

view details

KeisukeYamashita

commit sha d9f972dcdeea1434f189fe11f75af1fcaf6940dc

Merge pull request #67 from mercari/update-plugin-sdk-v2 Update Terraform plugin sdk v2

view details

push time in 21 days

delete branch mercari/terraform-provider-spinnaker

delete branch : update-plugin-sdk-v2

delete time in 21 days

PR merged mercari/terraform-provider-spinnaker

Reviewers
Update Terraform plugin sdk v2

WHAT

Updated

  • Context functions
  • Add description to all resources

WHY

  • To maintain

Ref

+406 -379

2 comments

22 changed files

KeisukeYamashita

pr closed time in 21 days

issue closedmercari/terraform-provider-spinnaker

Update the terraform-provider-sdk to v2

WHAT

Update the terraform-provider-sdk to v2.

WHY

Maintain this project.

Ref

closed time in 21 days

KeisukeYamashita

push eventmercari/terraform-provider-spinnaker

KeisukeYamashita

commit sha 507085c038a2431c3d47ddae9333044b004c98e7

fix(goreleaser): broken output tgz

view details

KeisukeYamashita

commit sha 2e0a2f5964dc843ff77298c4b504310a8b9cf331

revert heading message

view details

KeisukeYamashita

commit sha ece818e7eb06ac2e799f1a1a456cdd4edce6f464

drop freebsd

view details

KeisukeYamashita

commit sha 2c6d2419c7deddf76c60353296cb8695b3ff4bd1

Merge pull request #69 from mercari/fix-artifact-output Fix broken zip output by goreleaser

view details

KeisukeYamashita

commit sha 9728b2fc7aa62d9bcc2c28af416e3daaed330686

Merge branch 'master' into update-plugin-sdk-v2

view details

push time in 21 days

pull request commentmercari/terraform-provider-spinnaker

Update Terraform plugin sdk v2

Thank you for your review 🙇

KeisukeYamashita

comment created time in 21 days

Pull request review commentmercari/terraform-provider-spinnaker

Update Terraform plugin sdk v2

 func datasourceApplication() *schema.Resource { 				Computed: true, 			}, 		},-		Read: resourceSpinnakerProjectRead,+		ReadContext: resourceSpinnakerApplicationRead,

Yes, it was incorrect 🙇

KeisukeYamashita

comment created time in 21 days

PullRequestReviewEvent

push eventmercari/terraform-provider-spinnaker

KeisukeYamashita

commit sha 507085c038a2431c3d47ddae9333044b004c98e7

fix(goreleaser): broken output tgz

view details

KeisukeYamashita

commit sha 2e0a2f5964dc843ff77298c4b504310a8b9cf331

revert heading message

view details

KeisukeYamashita

commit sha ece818e7eb06ac2e799f1a1a456cdd4edce6f464

drop freebsd

view details

KeisukeYamashita

commit sha 2c6d2419c7deddf76c60353296cb8695b3ff4bd1

Merge pull request #69 from mercari/fix-artifact-output Fix broken zip output by goreleaser

view details

push time in 21 days

delete branch mercari/terraform-provider-spinnaker

delete branch : fix-artifact-output

delete time in 21 days

PR merged mercari/terraform-provider-spinnaker

Fix broken zip output by goreleaser

WHAT

As title.

WHY

Because the release was broken.

+9 -8

1 comment

2 changed files

KeisukeYamashita

pr closed time in 21 days

issue closedmercari/terraform-provider-spinnaker

Fix wrong zip compress format for Terraform registry

WHAT

As title.

How to reproduce

Make sure that you have Terraform version upper than 0.13.0.

$ terraform version
Terraform v0.13.1

And then write a provider block.

terraform {
  required_providers {
    miro = {
      source = "mercari/spinnaker"
    }
  }
}

provider "spinnaker" {
  gate_endpoint = "https://spinnaker.nokisai.com"
}

Run below.

$ terraform init
Initializing the backend...

Initializing provider plugins...
- Finding latest version of mercari/spinnaker...
- Finding latest version of hashicorp/spinnaker...
- Installing mercari/spinnaker v0.2.3...


Error: Failed to install provider

Error while installing mercari/spinnaker v0.2.3: zip: not a valid zip file


Error: Failed to install provider

Error while installing hashicorp/spinnaker: provider registry
registry.terraform.io does not have a provider named
registry.terraform.io/hashicorp/spinnaker

WHY

The pull tgz format from the Terraform Registry is not currect, and not runnable.

closed time in 21 days

KeisukeYamashita

pull request commentmercari/terraform-provider-spinnaker

Fix broken zip output by goreleaser

I will self-review and self-merge because this will not affect anything.

KeisukeYamashita

comment created time in 21 days

startedmongodb/mongo-perf

started time in 22 days

push eventmercari/terraform-provider-spinnaker

KeisukeYamashita

commit sha ece818e7eb06ac2e799f1a1a456cdd4edce6f464

drop freebsd

view details

push time in 22 days

push eventmercari/terraform-provider-spinnaker

KeisukeYamashita

commit sha 2e0a2f5964dc843ff77298c4b504310a8b9cf331

revert heading message

view details

push time in 22 days

PR opened mercari/terraform-provider-spinnaker

Fix broken tgz output by goreleaser

WHAT

As title.

WHY

Because the release was broken.

+10 -11

0 comment

2 changed files

pr created time in 22 days

create barnchmercari/terraform-provider-spinnaker

branch : fix-artifact-output

created branch time in 22 days

push eventcloudworkerecosystem/awesome-workflows

KeisukeYamashita

commit sha d5a9e7d82a30820db7bd3140e2258dd31d2a60f4

Update README.md

view details

push time in 22 days

issue openedmercari/terraform-provider-spinnaker

Fix wrong compress format for Terraform registry

WHAT

As title.

WHY

The pull tgz format from the Terraform Registry is not currect, and not runnable.

created time in 22 days

pull request commentmercari/terraform-provider-spinnaker

Update Terraform plugin sdk v2

@micnncim @dragon3 @Nessex Any updates?

KeisukeYamashita

comment created time in 22 days

issue openedkekeniker/marco

Filter options

What

Add filter options so that this command shows only targets that maches the passes the filter(s).

Why

We want to find specify target.

created time in 22 days

more