profile
viewpoint
Tsubasa Nagasawa toVersus Tokyo Unskilled but lazy programmer in Japan. Gopher/Rustacean/Kubernetes/Knative

tani-yu/dogleash 16

DataDog CLI tool written in golang

toVersus/aws-ssm-operator 2

A Kubernetes operator for AWS SSM Parameter Store

baikonur-oss/terraform-aws-lambda-es-cleaner 0

Terraform module and Lambda for auto-deleting old indices in Elasticsearch

toVersus/agones 0

Dedicated Game Server Hosting and Scaling for Multiplayer Games on Kubernetes

toVersus/ansible-examples 0

A few starter examples of ansible playbooks, to show features and how they work together. See http://galaxy.ansible.com for example roles from the Ansible community for deploying many popular applications.

toVersus/ansible-starter 0

Starter playbook for an Ansible project

toVersus/argo-cd 0

Declarative continuous deployment for Kubernetes.

toVersus/backet 0

Backet is a command line tool to backup the git repositories

toVersus/cargo-generate 0

cargo, make me a project

toVersus/client 0

Knative developer experience, docs, reference Knative CLI implementation

delete branch toVersus/pkg

delete branch : webhook-log-level

delete time in 5 days

Pull request review commentknative/pkg

Remove patch detail for webhook being logged on info

 const ( 	// GitHubCommitID is the key used to represent the GitHub Commit ID where the 	// Knative component was built from in logs 	GitHubCommitID = "commit"++	// AdmissionReviewUID is the key used to represent the admission review+	// request/response UID in logs+	AdmissionReviewUID = "admissionreview/uid"++	// AdmissionReviewAllowed is the key used to represent whether or not+	// the admission request was permitted in logs+	AdmissionReviewAllowed = "admissionreview/allowed"++	// AdmissionReviewResult is the key used to represent extra details into+	// why an admission request was denied in logs+	AdmissionReviewResult = "admissionreview/result"++	// AdmissionReviewPatchType is the key used to represent the type of Patch in logs+	AdmissionReviewPatchType = "admissionreview/patchtype"

Thanks for looking into this. That makes sense. Done.

toVersus

comment created time in 6 days

PullRequestReviewEvent

push eventtoVersus/pkg

toVersus

commit sha cb24359643cf86714843ef6d20b88844dc71f579

Move admission specific logkey to local package

view details

toVersus

commit sha 29698367156ac16c755a963eaf5569619158edb2

Print patch type with patch body on debug log

view details

push time in 6 days

Pull request review commentknative/pkg

Remove patch detail for webhook being logged on info

 func admissionHandler(rootLogger *zap.SugaredLogger, stats StatsReporter, c Admi 			patchType = string(*reviewResponse.PatchType) 		} -		logger.Infof("AdmissionReview for %#v: %s/%s response={ UID: %#v, Allowed: %t, Status: %#v, Patch: %s, PatchType: %s, AuditAnnotations: %#v}",-			review.Request.Kind, review.Request.Namespace, review.Request.Name,-			reviewResponse.UID, reviewResponse.Allowed, reviewResponse.Result, string(reviewResponse.Patch), patchType, reviewResponse.AuditAnnotations)- 		if !reviewResponse.Allowed || reviewResponse.PatchType != nil || response.Response == nil { 			response.Response = reviewResponse 		} 		response.Response.UID = review.Request.UID +		logger = logger.With(

Thank you for pointing it out. Fixed to use sugared version for both places. Done.

toVersus

comment created time in 10 days

PullRequestReviewEvent

Pull request review commentknative/pkg

Remove patch detail for webhook being logged on info

 const ( 	// GitHubCommitID is the key used to represent the GitHub Commit ID where the 	// Knative component was built from in logs 	GitHubCommitID = "commit"++	// AdmissionReviewUID is the key used to represent the admission review+	// request/response UID in logs+	AdmissionReviewUID = "knative.dev/admissionreview/uid"

Agreed. Saving logging data is important for us.

toVersus

comment created time in 10 days

PullRequestReviewEvent

push eventtoVersus/pkg

toVersus

commit sha 0b5bbe47c3da7a6bec5050a1e7a2d8d1fa0f2bd4

Remove knative namespace from admission webhook logkey

view details

toVersus

commit sha 74eccae3b7629726e1ca69de4b1dfb3eb69cde2e

Use loosely-typed key-value pairs for suggered logger in admission wb

view details

push time in 10 days

Pull request review commentknative/pkg

Remove patch detail for webhook being logged on info

 func admissionHandler(rootLogger *zap.SugaredLogger, stats StatsReporter, c Admi 			patchType = string(*reviewResponse.PatchType) 		} -		logger.Infof("AdmissionReview for %#v: %s/%s response={ UID: %#v, Allowed: %t, Status: %#v, Patch: %s, PatchType: %s, AuditAnnotations: %#v}",+		logger.Infof("AdmissionReview for %#v: %s/%s response={ UID: %#v, Allowed: %t, Status: %#v, PatchType: %s, AuditAnnotations: %#v}",

Done. Also remove some admission request info from the message since they have already stored in logging context.

toVersus

comment created time in 11 days

PullRequestReviewEvent

push eventtoVersus/pkg

toVersus

commit sha aa3f03ea226a3e1ded38b0f0e3bfa86de86176b2

Pass admission review info to the fields in structured logging

view details

push time in 11 days

PR opened knative/pkg

Remove patch detail for webhook being logged on info

It might contain the sensitive data, so print it to debug log.

Fixes: #1397

+5 -2

0 comment

1 changed file

pr created time in 12 days

push eventtoVersus/pkg

toVersus

commit sha 4c821586cecbdb47426092426387817cb187e902

Remove patch detail for webhook being logged on info It might contain the sensitive data so print it to debug log

view details

push time in 12 days

create barnchtoVersus/pkg

branch : webhook-log-level

created branch time in 12 days

fork toVersus/agones

Dedicated Game Server Hosting and Scaling for Multiplayer Games on Kubernetes

https://agones.dev

fork in 23 days

startedargoproj-labs/argocd-image-updater

started time in 24 days

push eventtoVersus/pkg

Scott Nichols

commit sha 11fec633e4e3b3e25b7e59f835fec4b0f382469a

Adding Source ducktype. (#566) * Adding Source ducktype. * removing output format for now, revisit if we find more sources and consumers asking for it.

view details

chaodaiG

commit sha 057c0dfb8f56cec704b8d54c1f0517596df78a55

Add cluster creation logic for local users (#569) * Add cluster creation logic for local users * Add unit test * Feedback updates

view details

mattmoor-sockpuppet

commit sha fd4659ef5b5dfa0b1049e9f9f6bd06d699ce49b8

Format markdown (#570) Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)` /assign @mattmoor

view details

Spencer Peterson

commit sha 6a881edeba2058f5845c50d550ce33e62c4b734a

document ParseURL breaking the net/url api (#571)

view details

Spencer Peterson

commit sha 0a0c4972cd7134ce54b1ce6a6de8f189257a64fb

Add Destination constructors (#572) * add helper constructors for destination * flesh out destination constructors and path appending

view details

chaodaiG

commit sha d3c17af1d97a4dd7f0167628df312f1e9889f444

clustermanager: move common helpers and add more helpers (#573) * clustermanager: move common helpers and add more helpers * feedback updates

view details

Matt Moore

commit sha 426561fd098d8c365108b39fb57cf02d162a2c5e

Add support for resolving refs, when linked. (#576) With https://github.com/google/ko/pull/73 we can link the Git ref information into images with: ``` ln -r -s .git/refs ./cmd/foo/kodata ``` If the changeset package gets a `ref: <ref>` entry, it attempts to read that file from `KO_DATA_PATH` next, which lets the changeset work much more effectively.

view details

Victor Agababov

commit sha 7e6f1f48c9c4cdb1a3a09628986e7e706c82ceab

Some cleanups to the changeset code (#577)

view details

chaodaiG

commit sha f90999efb71a250be0832814f153716586e0bfea

Add boskos related helpers for cluster management lib (#575) * Add boskos related helper for cluster management lib * Add boskos in vendor * update boskos usage * add unit test for boskos * feedback updates

view details

Victor Agababov

commit sha 12ee58e32cc8bfaaf88b057be003611e6b7d867d

Fix licence to have spaces and comment to match the function (#580)

view details

Matt Moore

commit sha 9cc6a645418f08721a6103ad8b02f33af78e35d5

Shuffle knative.dev/pkg/tracing code a bit (#581) This moves around the code within the tracing package in preparation for adding support for other exporter options. As the fields changed are all private, this should be a no-op for consumers of this package. The goal of this change is to make it so that no files mention zipkin other than zipkin.go (or tests, which I left alone).

view details

Markus Thömmes

commit sha d6f38dd906b7f0b6fb5471ee6d8678ec92ad0601

Remove reflection from generic store code. (#583)

view details

Matt Moore

commit sha 2a33038155a9b9558a3010b7f640076acca7ae96

Expand the tracing package to support stackdriver. (#582) * Expand the tracing package to support stackdriver. This makes an assortment of changes to support the use of non-Zipkin tracing backends for publishing traces from system components based on config-tracing. The changes to the config are modeled after config-observability, which already has support for prometheus and stackdriver backends for metrics. * Incorporate review feedback. * Incorporate feedback from @mdemirhan downstream

view details

Matt Moore

commit sha 6785699dc3f0a87d6cc0225a547f35d9994b5d94

Revert "Remove reflection from generic store code. (#583)" (#585) This reverts commit d6f38dd906b7f0b6fb5471ee6d8678ec92ad0601.

view details

Dave Protasowski

commit sha c11c79155fa4be834735d1d0cbcafad88b16be69

Add dprotaso to the configmap-approvers (#587)

view details

mattmoor-sockpuppet

commit sha 88bd7e5013a0eb50e59fb07449575f67a614202d

Auto-update dependencies (#588) Produced via: `dep ensure -update knative.dev/test-infra` /assign mattmoor

view details

Chi Zhang

commit sha c8328b620adb1a8454cdc9bafc61e3ee4988c1e8

Move mako code to pkg (#590) * move Mako code from serving to pkg * update dependencies * add analyzer * update deps * fix a few typos

view details

chaodaiG

commit sha 9f6e5334c25aeebd862b19cb6715f9fe5aa56467

Add cluster creation logic with using GKE SDK (#579) * Add cluster creation logic with GKE SDK ` * fix build/test error + code review updates * add tests for acquiring cluster

view details

mattmoor-sockpuppet

commit sha f35268a9f90591330465dccb704404ad3a9c9ddc

Format markdown (#592) Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)` /assign mattmoor

view details

mattmoor-sockpuppet

commit sha 70faaf5b565328c540685189102be9ff9e72fdfa

Auto-update dependencies (#593) Produced via: `dep ensure -update knative.dev/test-infra` /assign mattmoor

view details

push time in a month

delete branch toVersus/conftest

delete branch : typo

delete time in 3 months

push eventtoVersus/conftest

toVersus

commit sha 521bf48d21871f91ee80a8679b0dd4336e03ebbe

Fix typo in help message Signed-off-by: toVersus <toversus2357@gmail.com>

view details

push time in 3 months

PR opened open-policy-agent/conftest

Fix typo in help message

Just found this

+1 -1

0 comment

1 changed file

pr created time in 3 months

create barnchtoVersus/conftest

branch : typo

created branch time in 3 months

fork toVersus/conftest

Write tests against structured configuration data using the Open Policy Agent Rego query language

https://conftest.dev

fork in 3 months

more