profile
viewpoint
Samuel Attard MarshallOfSound @SlackHQ Vancouver, Canada https://www.samuelattard.com I program... When I'm not programming I'm sleeping. When I'm not sleeping I'm programming. See how this works? :D

electron-userland/electron-forge 3890

A complete tool for creating, publishing, and installing modern Electron applications

electron-userland/spectron 1454

🔎 Test Electron apps using ChromeDriver

lgeiger/node-abi 94

:turtle: :rocket: Get the Node.js and Electron ABI for a given target and runtime

gmusic-utils/gmusic-theme.js 23

Generic theming library extracted from Google Play Music Desktop Player

GPMDP/gmusic-mini-player.js 17

Mini player JS transformer for Google Play Music

MarshallOfSound/awesome-electron 8

Useful resources for creating apps with Electron

GPMDP/gpmdp-plugin-now-playing-text-file 5

Creates a text file with the currently playing song. Simple plugin example

codebytere/sentinel 4

Integrated CI testing as a service.

bitdisaster/windows-focus-assist 2

A native node module to read the status of Focus Assist on Windows 10

GPMDP/mpris-service 2

Node.js implementation for the MPRIS D-Bus Interface Specification to create a mediaplayer service. Handles cross-platform installs

push eventelectron/build-tools

Samuel Attard

commit sha f69a76f61956af8fd153121b9f4f8179874076d7

fix: generate headers in correct dir

view details

push time in 2 days

issue commentelectron/build-tools

evm config migration doesn't persist

This is expected behavior, we didn't want to start overwriting peoples configs. Perhaps we should at least tell y'all how to fix it though. Or maybe add e sanitize-config --json so you can do e sanitize-config --json > my-config.json 🤔

cc @codebytere

samuelmaddock

comment created time in 4 days

PullRequestReviewEvent

PR opened electron/electron

Reviewers
feat: add webContents.crashProcess() to forcefully terminate a renderer process

Currently the only way to recover a hung renderer is to close the window or manually call kill ${webContents.getProcessId()} neither of which is ideal. This adds a simple new method that aligns with what Chrome does to make killing a webConents in a hung state super easy.

Notes: Added webContents.crashProcess() to forcefully terminate a renderer process to assist with recovering a hung renderer.

+93 -0

0 comment

5 changed files

pr created time in 4 days

create barnchelectron/electron

branch : crash-wc

created branch time in 4 days

Pull request review commentelectron/electron

fix: order menu items before filtering excess separators

 function sortGroups<T> (groups: {id?: T}[][]) { }  export function sortMenuItems (menuItems: {type?: string, id?: string}[]) {-  const isSeparator = (item: {type?: string}) => item.type === 'separator';-  const separators = menuItems.filter(i => i.type === 'separator');+  const isSeparator = (i: any) => i.type === 'separator' && !i.before && !i.after && !i.beforeGroupContaining && !i.afterGroupContaining;

Done

MarshallOfSound

comment created time in 4 days

PullRequestReviewEvent

push eventelectron/electron

Samuel Attard

commit sha 7921a18d2c3e297c0c2314214aa651b21dfe06a1

fix: order menu items before filtering excess separators

view details

push time in 4 days

push eventelectron/build-tools

Samuel Attard

commit sha f6bbdab35c24a0a942e35fa0bf6321c7c0b9068b

build: add support for Xcode 12.2.0 (#184)

view details

push time in 4 days

delete branch electron/build-tools

delete branch : add-xcode-12-2-0

delete time in 4 days

PR merged electron/build-tools

Reviewers
build: add support for Xcode 12.2.0

For master / 11-x-y compatibility 🤔

+4 -0

0 comment

1 changed file

MarshallOfSound

pr closed time in 4 days

PR opened electron/build-tools

Reviewers
build: add support for Xcode 12.2.0

For master / 11-x-y compatibility 🤔

+4 -0

0 comment

1 changed file

pr created time in 4 days

create barnchelectron/build-tools

branch : add-xcode-12-2-0

created branch time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventelectron/electron

Samuel Attard

commit sha dae60e01d435166011292b1500d97480abe4dff5

build: use newer xCode image (#25564) * build: use newer xCode image * build: log changed file paths

view details

push time in 4 days

delete branch electron/electron

delete branch : MarshallOfSound-patch-1

delete time in 4 days

PR merged electron/electron

build: use newer xCode image fast-track 🚅 target/11-x-y

Circle wants to delete an image we're using, testing out the updated image.

Notes: no-notes

+5 -3

0 comment

2 changed files

MarshallOfSound

pr closed time in 4 days

issue closedelectron/electron

how to use 'ExStyle' in electron

I`m making a program like 'on-screen keyboard' so when my program get focus it should return the focus to the previous window, i found out that there is a code in c# that returns the focus to the previous window:

protected override CreateParams CreateParams
{
    get
    {
        CreateParams param = base.CreateParams;
        param.ExStyle |= 0x08000000;
        return param;
    }

}

how can i use this code in my electron program?

closed time in 4 days

MainSilent

issue commentelectron/electron

how to use 'ExStyle' in electron

GitHub issues are for feature requests and bug reports, questions about using Electron or code assistance requests should be directed to the community or to the Slack Channel.

MainSilent

comment created time in 4 days

pull request commentelectron/electron

build: Wrap bundles using webpack

also, we could probably use production mode instead of development with TerserPlugin and manually disabled source mapping. unless there's a reason for that?

I honestly don't remember why I did that, I think it's because initially we didn't have the minifier. Then we relealized it made everything faster 😆

As long as we can keep our custom terser settings then production mode might make sense here

juliekoubova

comment created time in 4 days

PullRequestReviewEvent

push eventelectron/electron

Samuel Attard

commit sha 2dd7ad268b8409285ef61dd838085d28604b9ad2

build: add --only support to the nan test runner (#25560)

view details

push time in 5 days

delete branch electron/electron

delete branch : nan-only

delete time in 5 days

PR merged electron/electron

build: add --only support to the nan test runner

Found while debugging nan issues on the last roll that it is super hard to run a single nan test in a quick way, this does two things.

  1. --only now works with the nan spec runner
  2. We set -j max on the node-gyp rebuild command to build all the native modules used for testing in seconds instead of minutes

Notes: no-notes

+10 -1

0 comment

1 changed file

MarshallOfSound

pr closed time in 5 days

push eventelectron/electron

Samuel Attard

commit sha 8c0c552330afd99f48d3120fd166219d88a71a5e

build: log changed file paths

view details

push time in 5 days

PR opened electron/electron

build: use newer xCode image

Circle wants to delete an image we're using, testing out the updated image.

Notes: no-notes

+3 -3

0 comment

1 changed file

pr created time in 5 days

create barnchelectron/electron

branch : MarshallOfSound-patch-1

created branch time in 5 days

push eventelectron/electron

Samuel Attard

commit sha d0a276e2a9da3292c913d7b31a3314c28e6df597

fix: order menu items before filtering excess separators

view details

push time in 5 days

PR opened electron/electron

fix: order menu items before filtering excess separators

Previously we removed trailing separators before we re-ordered menu items into positions where the separators would not have been removed. This flips the order of those operations to fix this issue.

Notes: Excess menu item separators are now only removed after item re-ordering is done to avoid accidental removal of needed separators

+29 -3

0 comment

2 changed files

pr created time in 5 days

create barnchelectron/electron

branch : order-before-filter

created branch time in 5 days

push eventelectron/build-tools

Samuel Attard

commit sha 60f81c2226ff4c963d89ec2da96e5d25e1d743e1

feat: add --nan support to 'e test' (#180)

view details

push time in 5 days

delete branch electron/build-tools

delete branch : test-nan

delete time in 5 days

PR merged electron/build-tools

Reviewers
feat: add --nan support to 'e test'

As in title e test --nan now runs the nan test runner. I'm thinking it would be better long term to have e test --runners=main,node,nan instead of three separate runners but that's more complicated work as it needs to be backwards compatible 😆

+62 -37

0 comment

3 changed files

MarshallOfSound

pr closed time in 5 days

PR opened electron/electron

build: update nan dep for tests

Gonna add this to roller so we don't fall behind, no major changes incoming, just some deprecation warnings fixed.

Notes: no-notes

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchelectron/electron

branch : update-nan

created branch time in 5 days

PR opened electron/electron

feat: add --only support to the nan test runner

Found while debugging nan issues on the last roll that it is super hard to run a single nan test in a quick way, this does two things.

  1. --only now works with the nan spec runner
  2. We set -j max on the node-gyp rebuild command to build all the native modules used for testing in seconds instead of minutes

Notes: no-notes

+10 -1

0 comment

1 changed file

pr created time in 5 days

PR opened electron/build-tools

Reviewers
feat: add --nan support to 'e test'

As in title e test --nan now runs the nan test runner. I'm thinking it would be better long term to have e test --runners=main,node,nan instead of three separate runners but that's more complicated work as it needs to be backwards compatible 😆

+62 -37

0 comment

3 changed files

pr created time in 5 days

create barnchelectron/electron

branch : nan-only

created branch time in 5 days

create barnchelectron/build-tools

branch : test-nan

created branch time in 5 days

delete branch electron/electron

delete branch : roller/chromium/master

delete time in 5 days

push eventelectron/electron

Electron Bot

commit sha 69f1731bbbaa5211aefe64f3d155b11ab7bcb327

chore: bump chromium to ec5bc1743792d64724693eb357083 (master) (#24984) * chore: bump chromium in DEPS to cbdeef954dfc34e94c8ca9cf72ad326b4a121158 * chore: bump chromium in DEPS to 29723f905baeab1d4228eef2c31cdb341ebeffe0 * chore: bump chromium in DEPS to 44d6d78e852137fff58c14ed26ab1e803e5bf822 * update patches * chore: bump chromium in DEPS to 8a3a0fccb39d6b8334c9a0496c0d5056e50cdb3f * chore: update patches * refactor: fix PrintBackend::CreateInstance() calls Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2354541 * chore: bump chromium in DEPS to b9ebec3bcb1cabdd1426f367636f54cc98e0500e * chore: remove patches to code that was deleted upstream CL: https://chromium-review.googlesource.com/c/chromium/src/+/2360314 * Remove uses of kCGColorSpaceITUR_2020_PQ_EOTF/HLG CL: https://chromium-review.googlesource.com/c/chromium/src/+/2363950 just garden variety code shear * chore: update patch indices * Move ColorModel to //printing/mojom/print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2355083 sync with printing ColorModel changes: moved to mojo, different naming scheme * chore: bump chromium in DEPS to 56c4b4d2ce5ba941acd2e0fdb5100e8a48847134 * chore: bump chromium in DEPS to 130501f220b684a79dc82c17e236e63ac1f2a093 * Convert PrintHostMsg_DidGetPrintedPagesCount to Mojo https://chromium-review.googlesource.com/c/chromium/src/+/2326857 Update argument list to Print() * chore: update patch indices * DumpAccTree: convert utf16 to utf8 in PropertyFilter https://chromium-review.googlesource.com/c/chromium/src/+/2360218 * chore: bump chromium in DEPS to 3058368c6646e0dc8be6f8ea838b0343428b7998 * chore: bump chromium in DEPS to f51b4e6555364363c61438dac7afd988c8347bfc * chore: bump chromium in DEPS to 2dcc6f8fc23ac41b2499eb69dee0b4017e9d1046 * update patches * chore: bump chromium in DEPS to 2d8e98ecedc7e4905540b053bc1c87e964715be5 * update patches * 2345900: Move content::RecordContentToVisibleTimeRequest struct to mojo https://chromium-review.googlesource.com/c/chromium/src/+/2345900 * update patches * 2345900: Move content::RecordContentToVisibleTimeRequest struct to mojo https://chromium-review.googlesource.com/c/chromium/src/+/2345900 * 2367394: Remove net::LOAD_DO_NOT_SEND_COOKIES and net::LOAD_DO_NOT_SEND_AUTH_DATA. https://chromium-review.googlesource.com/c/chromium/src/+/2367394 * 2373227: [XProto] Consolidate all <X11/*> includes to //ui/gfx/x/x11.h https://chromium-review.googlesource.com/c/chromium/src/+/2373227 * fixup! 2373227: [XProto] Consolidate all <X11/*> includes to //ui/gfx/x/x11.h * chore: bump chromium in DEPS to c090e3f960520cbd2328608b97f87238c76d6143 * update patches * chore: bump chromium in DEPS to 13a25e0a755de9a14271022c595f3d2e29829e1a * chore: bump chromium in DEPS to 6adbb767b012c41efaeab0d1bdbb3eefed0977bc * chore: bump chromium in DEPS to 339ec5455c5932ef1322ea9953a6349b0732199e * chore: bump chromium in DEPS to 20291807c33f7ef4ef4f57d62075e099b027bfe6 * chore: bump chromium in DEPS to 226fbd1b8b17d4ac84fdb9548ef3a1c646878d47 * update patches * fixup disable_color_correct_rendering patch * chore: bump chromium in DEPS to 577c45979cad4359f2e206d68efd9317d3d79315 * update patches * viz: Rename RenderPass to CompositorRenderPass (and related types). https://chromium-review.googlesource.com/c/chromium/src/+/2380730 * chore: bump chromium in DEPS to 37e2ad5303f2c03a1b5d8eda65341bf2561196cd * update patches * add kOmitCookies_Electron * update patch * chore: bump chromium in DEPS to 256e42409ea63a7e71016de07818a983a97db463 * update patches * fix worker script ready hook https://chromium-review.googlesource.com/c/chromium/src/+/2335713 * Fixup printing page ranges patch * [printing] Move PrintMsg_PrintPages_Params to print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2340854 * Add MIME sniffer overloads that take base::StringPieces https://chromium-review.googlesource.com/c/chromium/src/+/2382896 * [printing] Move PrintHostMsg_PreviewIds to print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2379455 * fixup test due to new DCHECK https://chromium-review.googlesource.com/c/chromium/src/+/2333750 * stop sending cookies when useSessionCookies is false * chore: bump chromium in DEPS to dd429dbc556449951ee8160d8a4d61fd95a139d5 * update patches * chore: bump chromium in DEPS to 5202bde3f9f44c2065f5dacf27e7000dd19e4e4d * chore: bump chromium in DEPS to 099e8e07b89da65932431bb0fd51b6f7f5344c19 * chore: bump chromium in DEPS to 104e5da2a43b759732d5b94bfc750b3a9a639653 * chore: bump chromium in DEPS to a4519ce657af25834e355315fd7fefa77b13426a * update patches * Make FileURLLoaderFactory always owned by its |receivers_|. https://chromium-review.googlesource.com/c/chromium/src/+/2337411 * Make FileURLLoaderFactory always owned by its |receivers_|. https://chromium-review.googlesource.com/c/chromium/src/+/2337411 * chore: bump chromium in DEPS to 1b62e9e8c8eaf6b8e3a9c77ee67a4c1bfa6a4d6b * chore: update patches * fixup! Make FileURLLoaderFactory always owned by its |receivers_|. * chore: update patches - mac: Disable CoreServices _CSCheckFix. https://chromium-review.googlesource.com/c/chromium/src/+/2401334 - [XProto] Remove bad DCHECK in x11_error_tracker.cc https://chromium-review.googlesource.com/c/chromium/src/+/2402304 - Move content/browser/frame_host/* over to content/browser/renderer_host/ https://chromium-review.googlesource.com/c/chromium/src/+/2401303 * Refactor WebContentSettingsClient to dedupe AllowXYZ methods https://chromium-review.googlesource.com/c/chromium/src/+/2353552 * Introduce NonNetworkURLLoaderFactoryBase class. https://chromium-review.googlesource.com/c/chromium/src/+/2357559 * [XProto] Remove usage of all Xlib headers https://chromium-review.googlesource.com/c/chromium/src/+/2392140 * fixup! chore: update patches * chore: bump chromium in DEPS to c1df55fbeb8207d036a604f59e4ea4e8ee79930a * chore: update patches * Move content::WebPreferences struct to Blink https://chromium-review.googlesource.com/c/chromium/src/+/2397670 * chore: bump chromium in DEPS to 57a23ec4884fff6c2f8d9b8536131cdc9b551ec2 * Set appid on Pip windows. https://chromium-review.googlesource.com/c/chromium/src/+/2388274 * fixup! Set appid on Pip windows. * fix: add a patch to remove deprecated factory * chore: bump chromium in DEPS to 1a9ddb7ea43955877823d5c4dcbf241b64228635 * fix compilation on windows * chore: bump chromium in DEPS to 234e6c6a77f61ffad9335099d9b13892cf88fd44 * chore: update patches * chore: bump chromium in DEPS to 7631eb0a9f57a8a47d3c28e1d265961b3a4d6b2b * chore: update patches * chore: bump chromium in DEPS to f9c34cd485845b95c2d17a7f55fdf92cda9a1b3a * chore: update patches * chore: implement GetSurveyAPIKey Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2362182 * chore: replace CreateWebUIURLLoader with CreateWebUIURLLoaderFactory Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2358309 * chore: bump chromium in DEPS to 5bdbd2373da884adf41c087be1465fcc344d168c * chore: update node patches for common.gypi * chore: update patches * chore: non_network_url_loader_factory_base was moved Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2357431 * 2415752: Reland "Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink"" Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415752 * chore: bump chromium in DEPS to b943d006a33ec5bc1743792d64724693eb357083 * fix: replace x11::None with x11::Window::None * chore: update patches * chore: update patches * fix: cast x11::Window to int * 2402123: Use end date when deleting http auth cache Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2402123 * 2320268: Migrate DragHostMsg_StartDragging to Mojo Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2320268 * 2401303: Move content/browser/frame_host/* over to content/browser/renderer_host/ https://chromium-review.googlesource.com/c/chromium/src/+/2401303 * chore: fix lint * chore: fix build * Update config.yml Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: Samuel Attard <sattard@slack-corp.com>

view details

push time in 5 days

PR merged electron/electron

chore: bump chromium to ec5bc1743792d64724693eb357083 (master) roller/pause wip ⚒

Updating Chromium to ec5bc1743792d64724693eb357083 (master).

See all changes in 7d4ac110045b7647fa8a81f5f0709..ec5bc1743792d64724693eb357083

<!-- Original-Version: b04584161e07d4ac110045b7647fa8a81f5f0709 -->

Notes: no-notes

+955 -852

0 comment

107 changed files

electron-bot

pr closed time in 5 days

issue closedelectron/electron

Mac Store Rejection Problem

Finally I got the app submitted to the Apple Mac Store, but it's getting rejected with the following Reason:

Specifically, App still launches to no UI; user is unable to use the app. Note: No main window appears on launch, menu and icon on Dock only.

closed time in 5 days

vijayamin83

issue commentelectron/electron

Mac Store Rejection Problem

Duplicate #25528

vijayamin83

comment created time in 5 days

issue closedelectron/electron

> steps to reproduce :

steps to reproduce :


$ mkdir electron-gn && cd electron-gn

$ gclient config --name "src/electron" --unmanaged https://github.com/electron/electron

$ mkdir -p src/electron

$ cd src/electron

$ git clone https://github.com/electron/electron .

$ git checkout 6-0-x

$ cd ../../

$ gclient sync --with_branch_heads --with_tags

patch error :


Applying: patch the ensure_gn_version.py script to work on mac CI

Applying: build: add electron tracing category

Applying: Add ContentGpuClient::PreCreateMessageLoop() callback

Applying: Disable custom libcxx on windows

Applying: fix breakpad symbol generation on linux arm

Applying: build: pull in a fixed compiler for Windows on Arm

Applying: cross_site_document_resource_handler.patch

Applying: frame_host_manager.patch

Applying: crashpad_pid_check.patch

Applying: fix: use WeakPtr to detect deletion

Applying: fix: disabling compositor recycling

Applying: allow new privileges in unsandboxed child processes

error: patch failed: DEPS:172

error: DEPS: patch does not apply

Patch failed at 0085 allow new privileges in unsandboxed child processes

The copy of the patch that failed is found in: .git/rebase-apply/patch

When you have resolved this problem, run "git am --continue".

If you prefer to skip this patch, run "git am --skip" instead.

To restore the original branch and stop patching, run "git am --abort".

Traceback (most recent call last):

  File "src/electron/script/apply_all_patches.py", line 32, in <module>

    main()

  File "src/electron/script/apply_all_patches.py", line 28, in main

    apply_patches(json.load(config_json))

  File "src/electron/script/apply_all_patches.py", line 14, in apply_patches

    committer_name="Electron Scripts", committer_email="scripts@electron")

  File "/home/build/dev/electron-gn/src/electron/script/lib/git.py", line 67, in am

    proc.returncode))

RuntimeError: Command ['git', '-C', u'src', '-c', 'user.name=Electron Scripts', '-c', 'user.email=scripts@electron', '-c', 'commit.gpgsign=false', 'am'] returned 128

Error: Command '/usr/bin/python src/electron/script/apply_all_patches.py src/electron/patches/common/config.json' returned non-zero exit status 1 in /home/build/dev/electron-gn

Hook '/usr/bin/python src/electron/script/apply_all_patches.py src/electron/patches/common/config.json' took 152.44 secs



Originally posted by @hinoryu in https://github.com/electron/electron/issues/20299#issuecomment-688144758

closed time in 6 days

hinoryu

issue commentelectron/electron

> steps to reproduce :

6-0-x is unsupported and we no longer maintain or fix that branch

hinoryu

comment created time in 6 days

issue commentelectron/build-tools

download Dependency squirrel.mac all the time

Those logs are unfortunately misleading, it isn't downloading squirrel.mac, it's downloading all the dependencies of those repos. The initial checkout downloads a lot of stuff and on slower internet connections it can take hours

chengfengliu

comment created time in 6 days

issue closedelectron/build-tools

download Dependency squirrel.mac all the time

[0:11:40] Still working on: [0:11:40] src gclient(555) requirements:Dependency(src/third_party/electron_node).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/nan).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/Mantle).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/ReactiveObjC).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') [0:11:50] Still working on: [0:11:50] src gclient(555) requirements:Dependency(src/third_party/electron_node).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/nan).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/Mantle).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/ReactiveObjC).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') [0:12:00] Still working on: [0:12:00] src gclient(555) requirements:Dependency(src/third_party/electron_node).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/nan).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/Mantle).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/ReactiveObjC).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') [0:12:10] Still working on: [0:12:10] src gclient(555) requirements:Dependency(src/third_party/electron_node).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/nan).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/Mantle).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/ReactiveObjC).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') [0:12:20] Still working on: [0:12:20] src gclient(555) requirements:Dependency(src/third_party/electron_node).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/nan).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac).requirements = ('src', 'src/electron') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/Mantle).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac') gclient(555) requirements:Dependency(src/third_party/squirrel.mac/vendor/ReactiveObjC).requirements = ('src', 'src/electron', 'src/third_party/squirrel.mac')

for 50 minutes

closed time in 6 days

chengfengliu

push eventelectron/electron

Samuel Attard

commit sha 98a6a39b859bdc5e8a68dd2f5e68f548a96f9726

Update config.yml

view details

push time in 8 days

PullRequestReviewEvent

Pull request review commentelectron/electron

chore: bump chromium to ec5bc1743792d64724693eb357083 (master)

 v8::Local<v8::Promise> Session::ClearAuthCache() {       ->GetNetworkContext()       ->ClearHttpAuthCache(           base::Time(),

Sorry I meant functionally, like it would result in the same things being cleared. I think it's a perf optimization though so I'll follow this up with a PR to change all our base::Time() usage in session to use Min()

electron-bot

comment created time in 8 days

PullRequestReviewEvent

push eventelectron/electron

Samuel Attard

commit sha 8b4774af5770b939b01d9027488f7a25bb9e027f

chore: fix build

view details

push time in 8 days

Pull request review commentelectron/electron

chore: bump chromium to ec5bc1743792d64724693eb357083 (master)

 v8::Local<v8::Promise> Session::ClearAuthCache() {       ->GetNetworkContext()       ->ClearHttpAuthCache(           base::Time(),

I feel like in all cases these are equiv and we use base::Time() all over this file. I can change it but I'm pretty sure it's the same.

electron-bot

comment created time in 8 days

PullRequestReviewEvent

issue closedelectron/electron

MAC App Store Submit issues

My apple store application for the MAC OS is getting rejected with the following reason:

Specifically, App still launches to no UI; user is unable to use the app. Note: No main window appears on launch, menu and icon on Dock only.

version of the electron: 9.0.5

How I do check the mas or mas-dev version in my local, what are the setting required in the package.json file?

closed time in 8 days

vijayamin83

issue commentelectron/electron

MAC App Store Submit issues

GitHub issues are for feature requests and bug reports, questions about using Electron or code assistance requests should be directed to the community or to the Slack Channel.

vijayamin83

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventelectron/electron

Samuel Attard

commit sha ae97b87b529c81749f77e135fdddf93e4fcaac28

chore: fix lint

view details

push time in 8 days

push eventelectron/electron

Samuel Attard

commit sha b2f246a48b191c04cf30a734e794ab6d128a1f01

fix: cast x11::Window to int

view details

Samuel Attard

commit sha d00971d0cbcdd8daa165718e09f973307fc53668

2402123: Use end date when deleting http auth cache Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2402123

view details

Samuel Attard

commit sha 4e835d505d6ae5759e7a859220f17e6369420aed

2320268: Migrate DragHostMsg_StartDragging to Mojo Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2320268

view details

Samuel Attard

commit sha bcffa8aeabf808a7e1515f0a504cb0c971bc7875

2401303: Move content/browser/frame_host/* over to content/browser/renderer_host/ https://chromium-review.googlesource.com/c/chromium/src/+/2401303

view details

push time in 8 days

push eventelectron/electron

Charles Kerr

commit sha 70e3aa01821808be311392e4e82bb8ee016e3ddf

refactor: add a wrapper for wrangling uv handles. (#25332) * refactor: add a wrapper for wrangling uv handles. Part 1 of a fix for #25248, #22069. Place the uv_asyncs owned by NodeBindings, ElectronBindings inside a new UvHandle wrapper class which manages uv_handles' need for their closed() callback to be invoked before the handles' memory can be freed. * chore: make lint happy * refactor: use DCHECK_EQ() instead of DCHECK() * refactor: fix oops

view details

Charles Kerr

commit sha 9b08fbefe5bf65a3ac98dbd677f827e73d594fde

chore: remove unused imports in our python scripts (#25406) Seen at https://lgtm.com/projects/g/electron/electron/?mode=list&id=py%2Funused-import and confirmed with manual inspection.

view details

overkill

commit sha 633e5d850374694cbe788216dafb22cee788ebc1

chore: change `== None` to `is None` (#25202) According to LGTM, this change will improve code efficiency. https://lgtm.com/rules/7900090/

view details

Electron Bot

commit sha bc9816b2068b5c2c929dc0412a15786852591fbd

Bump v12.0.0-nightly.20200914

view details

Charles Kerr

commit sha 7f885bd266b525053b8708786e56023bab4e7b9d

chore: remove unused code from our js scripts (#25419)

view details

Jeremy Rose

commit sha 5de7eb36184411cf24753680f6354b5666ad14a3

docs: remove references to remote from docs (#25416)

view details

Jeremy Rose

commit sha 9f4a097e039aef04e3df4ee1f24ce3b817091b5d

feat: remove getMediaSourceIdForWebContents() (#25414) This reverts commit 204f001c5dbb039f12199a28c9aaf022827865f9.

view details

Jeremy Rose

commit sha 87d67a9365e5af6a1bd2b8f449b01ea41c5b4844

refactor: use owner window for BrowserWindow.fromWebContents (#25408)

view details

Samuel Attard

commit sha b1d8057ec92a39763382f52da1d1620253946da8

chore: update dependencies (#25456)

view details

Jeremy Rose

commit sha 459a95aaec0950ca5e23e346e0296f7e838b3748

fix: call node::Stop on exit (#25430)

view details

Electron Bot

commit sha fbf32f697f0d5c5c81224d7d709cdee8f43d1a7f

Bump v12.0.0-nightly.20200915

view details

Samuel Maddock

commit sha 45170fdbd70fa60e2fd1116d46897b41d44eef26

fix(extensions): define platform info to prevent renderer crash (#25357)

view details

Cheng Zhao

commit sha 2091fd7dd9bed0f889a14321a479c965ab45eeae

test: make a few tests hide their windows (#25466)

view details

Cheng Zhao

commit sha e5933c691097a272776330fc05133068316ca43d

fix: ensure ready-to-show event is fired (#25448) * fix: ensure ready-to-show event is fired * test: acutally draw something when capturePage

view details

Shelley Vohr

commit sha fa7a29e84b29941ed6ef79f60dd04fd252b4987c

chore: log hint on renderer crash (#25317)

view details

Electron Bot

commit sha 1ba46a91b6a68bd9ca358f6a4d9f5f7cb0b968c3

Bump v12.0.0-nightly.20200916

view details

Jeremy Rose

commit sha ba55aaa53b26c5aed9d4b3f07a0ba795d33d6c91

fix: check for destroyed webcontents in converter (#25431)

view details

Jeremy Rose

commit sha a200b1560044aef7f0668ab4a22bc6442b130cd1

docs: update menu example to avoid remote (#25291)

view details

Cheng Zhao

commit sha 993eab691fbb126f367d7f890825b26c5bc1141b

fix: disable CORS when webSecurity is disabled (#25463)

view details

Milan Burda

commit sha e0a25cb1e3a624e355739aa9edf2e422d7bfb97a

build: fix build with enable_pdf_viewer=false (#25494)

view details

push time in 8 days

push eventelectron/electron

Samuel Attard

commit sha abb4c515e147bcd5b617f996f704d25b15ecf7d1

chore: update patches

view details

push time in 8 days

push eventelectron/electron

Samuel Attard

commit sha ebe563f5a4ea0444c6cb8a22c7354abd8b9512f8

fix: replace x11::None with x11::Window::None

view details

push time in 8 days

PullRequestReviewEvent

Pull request review commentelectron/electron

fix: NOTREACHED in content::ChildProcessHost::GetChildPath when enable_plugins=false

 #include "electron/buildflags/buildflags.h"  #if BUILDFLAG(ENABLE_PDF_VIEWER)-#include "chrome/browser/pdf/pdf_extension_util.h"+#include "chrome/browser/pdf/pdf_extension_util.h"  // nogncheck

Why are we adding these nognchecks?

miniak

comment created time in 8 days

push eventelectron/electron

bitdisaster

commit sha 2cfa41e6e024559a9f2be187dca6a15acbcd4704

feat: read/write Toast Activator CLSID in shortcuts (#25493) * read/write Toast Activator CLSID * docs * tests * tweaks

view details

push time in 9 days

PR merged electron/electron

feat: read/write Toast Activator CLSID in shortcuts

Description of Change

PArticipating in Action Center on Windows requires a Toast Activaotr CLSID in shortcuts. This PR adds support to read and write the CLSID in shortcuts on Windows.

<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below.

Contributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: added read/write support for Toast Activator CLSID in shortcuts <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/master/README.md#examples -->

+31 -2

0 comment

6 changed files

bitdisaster

pr closed time in 9 days

PullRequestReviewEvent

push eventelectron/electron

Samuel Attard

commit sha d8b6054ae5bb3ea82010364f259c3a30ed108c4c

chore: non_network_url_loader_factory_base was moved Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2357431

view details

Samuel Attard

commit sha 49a9db6879ec7f8754a2a296f8f1ea0c02290420

2415752: Reland "Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink"" Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415752

view details

push time in 9 days

push eventelectron/electron

Samuel Attard

commit sha 90e239b9f331cdf698ac6e732e78cc70005f36f7

chore: update node patches for common.gypi

view details

Samuel Attard

commit sha 47b3b3b6a6b2b353d72ef2bd1103c3c8260b662b

chore: update patches

view details

push time in 9 days

issue commentelectron/electron

contextBridge.exposeInMainWorld triggers property access

contextBridge does not currently support getters and setters. There is a mode where it does (we use it internally for some things) but that mode toggle isnt exposed via the API.

Is there a hard requirement for this to be a getter property instead of a method. Publicly supporting getters and setters will add more API cost but wouldn't be too tricky to expose.

bpasero

comment created time in 9 days

PullRequestReviewEvent

push eventelectron/build-tools

Shelley Vohr

commit sha 90a3e4e5dcf2b0a30772656b7377f50867267f3c

feat: improve Electron fork support (#172) * feat: improve Electron fork support * Support old config

view details

push time in 10 days

delete branch electron/build-tools

delete branch : better-fork-config

delete time in 10 days

PR merged electron/build-tools

Reviewers
feat: improve Electron fork support

Improve support for working on Electron without write access using build-tools.

Previously, one's remotes could get overwritten during sync, and it wasn't clear how to push to a fork in the context of Electron within src. Did you need to clone the fork somehow? Something else? Fairly confusing.

This makes it such that a new user can now run e.g.:

$ e init --fork codebytere/electron --bootstrap testing

And then when inside /src/electron:

$ git remote -v
# origin  https://github.com/electron/electron (fetch)
# origin  https://github.com/electron/electron (push)
# fork    https://github.com/codebytere/electron (fetch)
# fork    https://github.com/codebytere/electron (push)

cc @MarshallOfSound @ckerr

+103 -18

0 comment

6 changed files

codebytere

pr closed time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventelectron/typescript-definitions

Samuel Attard

commit sha 27b28b185d61dadd1970b59f827cb17ec6746d78

fix: support node 14 require function type inference

view details

push time in 10 days

push eventelectron/electron

Samuel Attard

commit sha b40c78003e6e8443a56b705d3e11e0f48a805459

chore: implement GetSurveyAPIKey Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2362182

view details

Samuel Attard

commit sha 998a77c6d0a457c2457eb7aa664676c96197e0b1

chore: replace CreateWebUIURLLoader with CreateWebUIURLLoaderFactory Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2358309

view details

push time in 10 days

push eventelectron/electron

Samuel Attard

commit sha d93f8c124a3b10c6f95ec4b71d916092a60c461a

chore: implement GetSurveyAPIKey Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2362182

view details

push time in 10 days

push eventelectron/electron

Samuel Attard

commit sha f52ad783c074e6dc71af875a1e08f823e0ce9197

chore: implement GetSurveyAPIKey Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2362182

view details

push time in 10 days

Pull request review commentelectron/electron

chore: upgrade to Node.js v14.9.0

 import * as fs from 'fs'; import { Socket } from 'net'; import * as path from 'path'; import * as util from 'util';++// Emit 'exit' event on quit.+import { app } from 'electron/main';

This can't work? The electron import isn't available until reset-search-paths and common/init are called

codebytere

comment created time in 10 days

PullRequestReviewEvent

push eventelectron/electron

Samuel Attard

commit sha 4fa8c990169d45b0bebfb43b8f87a0902b0a01ce

chore: implement GetSurveyAPIKey Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2362182

view details

push time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentelectron/electron

chore: upgrade to Node.js v14.9.0

 shell.writeShortcutLink('/home/user/Desktop/shortcut.lnk', 'update', shell.readS    // Query all cookies.   session.defaultSession.cookies.get({})-    .then((cookies) => {+    .then((cookies: Electron.Cookie[]) => {

Yeah if these aren't being inferred anymore we have a big problem

codebytere

comment created time in 10 days

PullRequestReviewEvent

Pull request review commentelectron/electron

chore: upgrade to Node.js v14.9.0

 handleRemoteCommand('ELECTRON_BROWSER_REQUIRE', function (event, contextId, modu     if (customEvent.defaultPrevented) {       throw new Error(`Blocked remote.require('${moduleName}')`);     } else {-      customEvent.returnValue = process.mainModule!.require(moduleName);+      customEvent.returnValue = (process as any).mainModule.require(moduleName);
      customEvent.returnValue = require.main.require(moduleName);

Should replace with the new thing then?

codebytere

comment created time in 10 days

PullRequestReviewEvent

Pull request review commentelectron/electron

chore: upgrade to Node.js v14.9.0

 process.on('uncaughtException', function (error) { // Emit 'exit' event on quit. const { app } = require('electron'); -app.on('quit', function (event, exitCode) {+app.on('quit', function (_event: Event, exitCode: number) {

This is a symptom of a problem with our TS definitions and depending on @types/node@14 then and should be fixed before this lands

codebytere

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

issue closedelectron/electron

Electron and custom openssl engine

I tried to add a custom PKCS11 private key engine in my electron project to open a TSL socket with my HSM. And it does not work, I get the error:

MQTT connect err: Error [ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED]: Custom engines not supported by this OpenSSL at Object.createSecureContext (_tls_common.js:184:15) at Object.connect (_tls_wrap.js:1576:48) at Object.buildBuilder (C:\Users\henri\git\xot_client\nodejs\xot_client\node_modules\mqtt\lib\connect\tls.js:17:20) at MqttClient.wrapper [as streamBuilder] (C:\Users\henri\git\xot_client\nodejs\xot_client\node_modules\mqtt\lib\connect\index.js:153:36) at MqttClient._setupStream (C:\Users\henri\git\xot_client\nodejs\xot_client\node_modules\mqtt\lib\client.js:298:22) at new MqttClient (C:\Users\henri\git\xot_client\nodejs\xot_client\node_modules\mqtt\lib\client.js:277:8) at Object.connect (C:\Users\henri\git\xot_client\nodejs\xot_client\node_modules\mqtt\lib\connect\index.js:155:16) at XMS.connect (C:\Users\henri\git\xot_client\nodejs\xot_client\dist\backend\XMS.js:88:30) at Tokens.<anonymous> (C:\Users\henri\git\xot_client\nodejs\xot_client\dist\backend\electron.js:355:13) at Tokens.emit (events.js:310:20) { code: 'ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED'

Is this something that could be fixed (recompiling electron with other libs/settings/configuration) or added in newer versions of Electron?

I'm running Electron v10.1.2 and node v12.18.4 And i set the OPENSSL_CONF=./pkcs11.conf with: `openssl_conf = openssl_init

[openssl_init] engines = engine_section

[engine_section] pkcs11 = pkcs11_section

[pkcs11_section] engine_id = pkcs11 dynamic_path = ../../3rd-party/pkcs11.dll MODULE_PATH = ./iidxp11_u32.dll init = 0 ` I have another node js test project without Electron and it works fine.

closed time in 10 days

heol-files

issue commentelectron/electron

Electron and custom openssl engine

Electron does not use openssl, we utilize boringssl instead as a drop in replacement. This config is probably unsupported by boringssl

heol-files

comment created time in 10 days

push eventelectron/electron

Samuel Attard

commit sha 1065c16b036f24a594b979bfe40e5b1662f92cf0

chore: update patches

view details

push time in 10 days

issue commentelectron/build-tools

Create `e lint` to make linting available to users using exclusively build-tools

Can you try e d npm.cmd run lint windows might be tricky

codebytere

comment created time in 10 days

more