profile
viewpoint
Shelley Vohr codebytere msft ¯\_(°_o)_/¯ http://codebyte.re core eng @electron. tsc @nodejs. organizer @queerjs 🏳️‍🌈. often caffeinated. always learning. speaks about things in places sometimes!

codebytere/codebytere.github.io 290

personal website

cjihrig/uvwasi 88

WASI syscall API built atop libuv

codebytere/dotify 32

command line dotfile installation and maintenance tool

codebytere/electron-font-manager 11

Create native cross-platform font dialogs!

codebytere/emoji-mashup-convert 11

Convert images from tweets into Slack-worthy emojis.

codebytere/git-fns 6

My personal collection of custom git functions.

codebytere/electron-prices 3

Simple Electron application that shows the current price of oil, gold, and silver using the STOOQ API.

codebytere/github-issue-parser 3

parse github issue templates

push eventcodebytere/node

Rich Trott

commit sha 79eb529c3e448ebe99508d4f1e07f4823c2326a9

doc: changed "considered experimental" to "experimental" in cli.md Change "no longer considered experimental" to "no longer experimental" in cli.md. PR-URL: https://github.com/nodejs/node/pull/34128 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha f06df175b453e397317f32a7785a7b49198f6f06

doc: change "considered experimental" to "experimental" in n-api.md This changes "considered" experimental" to "experimental" in the n-api.md file and introduces some additional brevity. PR-URL: https://github.com/nodejs/node/pull/34129 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Sam Roberts

commit sha 1aa847f7438407b78cc0d1f9eab96adcfe9ff9df

doc: move sam-github to TSC Emeriti I don't have enough time to remain active in the TSC, so I will step down. PR-URL: https://github.com/nodejs/node/pull/34095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Derek Lewis

commit sha 1dc837ed9a139eaf86d7929e9bee6f0021fc5a3d

doc: add http highlight grammar Prior to this commit, http request message code blocks in Markdown files were not being highlighted correctly. This has been corrected by adding the new grammar to the bundle, removing the CRLFs (`\r\n`) from these code samples, adding a reminder to re-add them, and tuning the syntax theme to support attribute highlighting. PR-URL: https://github.com/nodejs/node/pull/33785 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Rich Trott

commit sha dfeeb3c275cbc2576974d8ca5e89961df2a45944

doc: simplify and clarify ReferenceError material in errors.md "should always be considered" -> "indicate" PR-URL: https://github.com/nodejs/node/pull/34151 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Rich Trott

commit sha 829f521fda0f5add192b10002ce73142655c16a5

doc: remove "considered" in errors.md "would be considered a `TypeError`" -> "would be a `TypeError`". Using "considered" introduces unnecessary ambiguity. Is is not actually a TypeError but merely "considered" one? Why is that? We don't say. Simplify to "is a TypeError". PR-URL: https://github.com/nodejs/node/pull/34152 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Richard Lau

commit sha d08334a489cbd29e4876a0031603ab8b5fef6f89

test: report actual error code on failure Add a custom message to parallel/test-dgram-error-message-address so that the actual error code that doesn't match the allowed errors is output on assertion failure. PR-URL: https://github.com/nodejs/node/pull/34134 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Rich Trott

commit sha 9b8d317d9916dd44b2b3678df05f9daf6eb14c90

test: fix flaky test-http2-invalidheaderfield Separate test cases to avoid side effects and race conditions. Fixes: https://github.com/nodejs/node/issues/34172 PR-URL: https://github.com/nodejs/node/pull/34173 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Anna Henningsen

commit sha 1d7be3253f12c9eafaf0ecec378a657893b30852

crypto: move typechecking for timingSafeEqual into C++ This makes the function more robust against V8 inlining. Fixes: https://github.com/nodejs/node/issues/34073 PR-URL: https://github.com/nodejs/node/pull/34141 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Xu Meng

commit sha 07bbadb2c7f4f7fca41d01839b122a6e2cbb16e2

test: skip some IBM i unsupported test cases Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: https://github.com/libuv/libuv/pull/2782 PR-URL: https://github.com/nodejs/node/pull/34118 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 907829b1a47f86dff9d81168fc1c867540638a4a

doc: simply dns.ADDRCONFIG language PR-URL: https://github.com/nodejs/node/pull/34155 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 2110fadecdd6c97054dcdcbd1208818c185944ff

doc: improve triaging text in issues.md Remove a double negative and many superfluous sentences. The sentiment in the removed material is good, but we already tell people that discussion should be focused, helpful, and professional. Having two extra paragraphs greatly reduces the likelihood that people will read the material. PR-URL: https://github.com/nodejs/node/pull/34164 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

rickyes

commit sha 7f2cf0f8da83d67eac47cf3cb1b8c0a98b518831

doc: add streams to the pipeline function signature PR-URL: https://github.com/nodejs/node/pull/34153 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

rickyes

commit sha a7c6806adc5591ba782cb7c520fb983bc0e25ec1

doc: Add maxTotalSockets option to agent constructor PR-URL: https://github.com/nodejs/node/pull/34013 Refs: https://github.com/nodejs/node/pull/33617 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Derek Lewis

commit sha db3b209e7df254794873be5ac91345dee034e130

doc: clarify esm conditional exports prose This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: https://github.com/nodejs/node/pull/33886 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha ee3243fe3f29f317e910a2424eabd279dec2eb00

src: remove unused fields from IsolateData PR-URL: https://github.com/nodejs/node/pull/34139 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Denys Otrishko

commit sha b4fe76d656d51ead949f2a35c13a221616f78c4c

doc: improve async_hooks asynchronous context example * use writeFile(1) everywhere to log * prettify execution id graph * add clearer explanation for TickObject presence * add causation graph via triggerAsyncId PR-URL: https://github.com/nodejs/node/pull/33730 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

Rodion Abdurakhimov

commit sha d853145277f3070053ed89cbaa91ad9218f3e1ac

doc: fix source link margin to sub-header mark Prior to this commit, [src] link overlapped sharped (#) sub-header link PR-URL: https://github.com/nodejs/node/pull/33664 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Gabriel Schulhof

commit sha cfa3d8fec5d9f6469c8d4ef077b53e0d9007dab9

doc: fix entry for `napi_create_external_buffer` Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: https://github.com/nodejs/node/issues/33471 PR-URL: https://github.com/nodejs/node/pull/34125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anentropic

commit sha 7c9df66485e63c5b03f6344a658f8e0018a928fb

doc: clarify how to read process.stdin document more clearly that stdin will emit multiple readable events PR-URL: https://github.com/nodejs/node/pull/27350 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 7 hours

pull request commentnodejs/node

[v12.x backport] deps: V8: cherry-pick eec10a2fd8fa

@Flarna fixed it up on staging - if you rebase this should be good to go

Flarna

comment created time in 7 hours

push eventnodejs/node

rickyes

commit sha 0197ea4e56d3fe4f81af35a032044d1a3c1ec543

lib: replace charCodeAt with fixed Unicode PR-URL: https://github.com/nodejs/node/pull/32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Ruben Bridgewater

commit sha 524b230143e8824a54739f662b51aa40bad614c3

util: gracefully handle unknown colors This makes sure colors that are unknown won't cause an error. This is especially important in case a library wants to use colors defined by Node.js core, if available and fall back to the default otherwise. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33797 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Stephen Belanger

commit sha 0d79c533ef594f8790b20cba8a433d398ce3c7ef

async_hooks: callback trampoline for MakeCallback PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Stephen Belanger

commit sha ba476326dda2767fb0659196c10c43570a3c7b40

domain: remove native domain code With the async_hooks callback trampoline, domains no longer need any native code. With this, domains can exist in pure JavaScript. PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Fábio Santos

commit sha 0867ab7da59591b81bc9836cab0f1cbd680c2e7c

module: fix error message about importing names from cjs When importing specific names from a CJS module, and renaming them using `as`, the example fix in the error message erroneously contains the keyword `as` in the destructuring variable declaration. Example of this issue: import { parse as acornParse } from "acorn"; ^^^^^ SyntaxError: The requested module 'acorn' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export. For example: import pkg from 'acorn'; const { parse as acornParse } = pkg; PR-URL: https://github.com/nodejs/node/pull/33882 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Pranshu Srivastava

commit sha 75107e23a8259a1ec38add6e468c3218cb514d74

http2: always call callback on Http2ServerResponse#end Fixes: https://github.com/nodejs/node/issues/28001 PR-URL: https://github.com/nodejs/node/pull/33911 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Pragyan Das

commit sha 410b23398de82ca34abf6066f5c2b2c69d5e145e

doc: update WASM code sample - Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: https://github.com/nodejs/node/pull/33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 857ff68485d59fcd08b90c8eea3c8b733d6f4ebe

meta: introduce codeowners again The [Contributor's Survey results](https://github.com/nodejs/TSC/pull/882) highlight the fact that it is often not easy for contributors to know who the right people are to talk to about a proposed change or who to ask for reviews of a given subsystem. We briefly toyed around with codeowners before when GitHub introduced it but just as quickly disabled it because the structure of our repository made it exceedingly difficult to get right. Rather than start with a codeowners for the entire project, I propose that we start with a small experiment focused on specific subsystems. Specifically, codeowners for modules, streams, net/tls, http/http2, and quic (once that lands). We can expand out from there as we see how things go with the minimal starter set. Initially this just enables codeowners for the `quic` subsystem. A couple of points: 1. A codeowner should always be a team, never an individual person 2. Each codeowner team should contain at least one TSC member (to provide coverage for signing off on semver-major changes) 3. PRs touching any code with a codeowner must be signed off by at least one person on the codeowner team PR-URL: https://github.com/nodejs/node/pull/33895 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 322a51e5820661f41e02f6cc321ab94f7570e648

doc: use Class: consistently The docs contain 122 uses of `Class:` in headers and one use of `class:` in headers. This changes that one instance to conform with the other instances. PR-URL: https://github.com/nodejs/node/pull/33978 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 6af2ed3fdc8907a64946e7ee1e8b62f8d3568afd

doc: change "GitHub Repo" to "Code repository" "GitHub Repo & Issue Tracker" changed to "Code repository and issue tracker". PR-URL: https://github.com/nodejs/node/pull/33985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Rich Trott

commit sha 732b80b474cf0886051fbd3277bcabce5bffefce

doc: fix lexical sorting of bottom-references in dns doc The links are sorted in lexical order except for the two RFC links which are reversed. Fix that. PR-URL: https://github.com/nodejs/node/pull/33987 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha d77eaeefb89a51dc611a18b930828e80677e47d7

build: add target specific build_type variable This commit add a target specific variable named 'build_type' to the node and node_g targets. The motivation for doing this is that both targets share the same prerequisites, and the recepies are the same (apart from the build type) so some duplication can be avoided. PR-URL: https://github.com/nodejs/node/pull/33925 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Alba Mendez

commit sha ddc5afdddcb692b93746f5c44088225f04b252a4

doc: warn that tls.connect() doesn't set SNI Add a note warning users that when using tls.connect(), the `servername` option must be set explicitely to enable SNI, otherwise the connection could fail. PR-URL: https://github.com/nodejs/node/pull/33855 Fixes: https://github.com/nodejs/node/issues/28167 Co-authored-by: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

gengjiawen

commit sha 6d5383de3534078ffde7ec58cc04b2ce46e3362b

src: improve indention for upd_wrap.cc PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

gengjiawen

commit sha b9f8034f95d5c1e6f31e98fee61c5647e3e51dbc

test: fix typo in common/index.js PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Shakil-Shahadat

commit sha f29f77f1112883a7723638598bd40f48208b5ce4

doc: update fs.md First class heading is made to look like other headings. PR-URL: https://github.com/nodejs/node/pull/33820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Rich Trott

commit sha 47ea3067d03fdcb2537ef682ba635df06d664abc

doc: revise text in dns module documentation introduction PR-URL: https://github.com/nodejs/node/pull/33986 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Shelley Vohr

commit sha 9b8695fb35e509caf5f8f10da5c12489ffe3ad86

test: account for non-node basename PR-URL: https://github.com/nodejs/node/pull/33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 498dfba33aef6ba9bb628eb4dfac083efc8ae977

doc: use a single space between sentences We mostly have a single space between the punctuation that ends a sentence and the start of the next sentence. Change instances with two spaces to one. PR-URL: https://github.com/nodejs/node/pull/33995 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 06937249d0c7ece4f8a174aa2f6598d7876e0a51

doc: correct default values in http2 docs The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: https://github.com/nodejs/node/pull/33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 7 hours

pull request commentnodejs/node

[v12.x backport] deps: V8: cherry-pick eec10a2fd8fa

ah dang i see the issue - it looks like https://github.com/nodejs/node/commit/7407fc2aeac4fe87cfb8294fa706e0a99451646f didn't make it back to 14 and since it didn't cause issues it somehow never flagged?? so only the tools update is in 14 right now. I can patch the other one back to v12.

Flarna

comment created time in 7 hours

pull request commentnodejs/node

[v12.x backport] tools: enable no-else-return lint rule

@nodejs/releasers would someone mind taking a second look so i don't need to wait another 90hrs to land?

lpinca

comment created time in 8 hours

Pull request review commentelectron/electron

build: tsify asar and move to webpack js2c pipeline

+import { Buffer } from 'buffer';+import * as path from 'path';+import * as util from 'util';++const asar = process._linkedBinding('electron_common_asar');+const v8Util = process._linkedBinding('electron_common_v8_util');++const Module = require('module');++const Promise: PromiseConstructor = global.Promise as any;++const envNoAsar = process.env.ELECTRON_NO_ASAR &&+    process.type !== 'browser' &&+    process.type !== 'renderer';+const isAsarDisabled = () => process.noAsar || envNoAsar;++const internalBinding = (process as any).internalBinding;+delete (process as any).internalBinding;++const nextTick = (functionToCall: Function, args: any[] = []) => {+  process.nextTick(() => functionToCall(...args));+};++// Cache asar archive objects.+const cachedArchives = new Map();++const getOrCreateArchive = (archivePath: string) => {+  const isCached = cachedArchives.has(archivePath);+  if (isCached) {+    return cachedArchives.get(archivePath);+  }++  const newArchive = asar.createArchive(archivePath);+  if (!newArchive) return null;++  cachedArchives.set(archivePath, newArchive);+  return newArchive;+};++// Separate asar package's path from full path.+const splitPath = (archivePathOrBuffer: string | Buffer) => {+  // Shortcut for disabled asar.+  if (isAsarDisabled()) return { isAsar: false };++  // Check for a bad argument type.+  let archivePath = archivePathOrBuffer;+  if (Buffer.isBuffer(archivePathOrBuffer)) {+    archivePath = archivePathOrBuffer.toString();+  }+  if (typeof archivePath !== 'string') return { isAsar: false };++  return asar.splitPath(path.normalize(archivePath));+};++// Convert asar archive's Stats object to fs's Stats object.+let nextInode = 0;++const uid = process.getuid != null ? process.getuid() : 0;+const gid = process.getgid != null ? process.getgid() : 0;++const fakeTime = new Date();+const msec = (date: Date) => (date || fakeTime).getTime();++const asarStatsToFsStats = function (stats: any) {

we can probably type this, no? We know what the object's properties are: https://github.com/electron/electron/blob/602913cb4c98d102548e082c97401415849fe082/shell/common/api/electron_api_asar.cc#L71-L75

MarshallOfSound

comment created time in 2 days

delete branch electron/electron

delete branch : trop/8-x-y-bp-fix-uv_walk-crash-on-web-worker-close-1594231262798

delete time in 2 days

push eventelectron/electron

trop[bot]

commit sha b76256325763896fdf23a4e19a4937eb036d62ea

fix: uv_walk crash on web worker close (#24463) * fix: uv_walk crash on web worker close * Use DCHECK_EQ Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

view details

push time in 2 days

PR merged electron/electron

fix: uv_walk crash on web worker close 8-x-y backport

Backport of #24436

See that PR for details.

Notes: Fixed a termination crash on Web Workers with Node.js integration enabled.

+23 -19

0 comment

2 changed files

trop[bot]

pr closed time in 2 days

push eventelectron/electron

Sam Saccone

commit sha e18f508e664c805c9d5e6796cb190e8c27b3301a

docs: fix incorrect formatting in browser docs. (#24473) Address incorrect typing for isEnabled. The root cause of this was due to missing backticks which caused the docs parser to think that the return type of the `isEnabled` function was null, where it was supposed to be a boolean type. The side effect of this was that the generated typescript typings were incorrect for this function. Fixes #24409

view details

push time in 2 days

PR merged electron/electron

doc: fix incorrect formatting in browser docs. target/10-x-y target/8-x-y target/9-x-y

Description of Change

Fix incorrect formatting in browser documentation.

Missing backticks caused the docs parser to think that the return type of the isEnabled function was null, where it was supposed to be a boolean type.

The side effect of this was that the generated typescript typings were incorrect for this function.

Fixes #24409

Checklist

Release Notes

Notes: Generated typing for win.isEnabled now is set to a boolean.

+1 -1

5 comments

1 changed file

samccone

pr closed time in 2 days

issue closedelectron/electron

BrowserWindow.isEnabled() return void

<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. -->

Preflight Checklist

<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->

  • [ ] I have read the Contributing Guidelines for this project.
  • [ ] I agree to follow the Code of Conduct that this project adheres to.
  • [ ] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • <!-- (output of node_modules/.bin/electron --version) e.g. 4.0.3 --> 9.0.5
  • Operating System:
    • <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 --> mac os 10.15.5
  • Last Known Working Electron version:
    • <!-- (if applicable) e.g. 3.1.0 --> 9.0.5

Expected Behavior

in electron.d.ts, why BrowserWindow.isEnabled() return void.

Actual Behavior

<!-- A clear and concise description of what actually happened. -->

To Reproduce

<!-- Your best chance of getting this bug looked at quickly is to provide an example. -->

<!-- For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report. -->

<!-- If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes. -->

<!-- If you provide a URL, please list the commands required to clone/setup/run your repo e.g.

$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .

-->

Screenshots

<!-- If applicable, add screenshots to help explain your problem. --> image

closed time in 2 days

eisonwoo

push eventnodejs/node

Kirill Shatskiy

commit sha 157e7d8cdf7d102478d6f3168b9e30c5a3f9721c

fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN Fixes: https://github.com/nodejs/node/issues/33348 PR-URL: https://github.com/nodejs/node/pull/33395 Refs: https://github.com/nodejs/node/issues/33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

himself65

commit sha 5efbed0995ddfd4cc7ed16827943cf09aab24982

src: add errorProperties on process.report PR-URL: https://github.com/nodejs/node/pull/28426 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gus Caplan

commit sha 6f507a2f92eb60d5a28cd8a7ca98062c7a4fa7e0

n-api: add version to wasm registration PR-URL: https://github.com/nodejs/node/pull/34045 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

push time in 2 days

push eventnodejs/node

Anna Henningsen

commit sha 1ad73dd997a79b163598a62357ff5d0cc03a30d2

src: handle empty Maybe(Local) in node_util.cc PR-URL: https://github.com/nodejs/node/pull/33867 Refs: https://github.com/nodejs/node/blob/master/src/README.md#checked-conversion Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

wenningplus

commit sha 7a898f359c1fd825fc1dc747f3c0f66f33251067

src: use ToLocal in node_os.cc PR-URL: https://github.com/nodejs/node/pull/33939 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Derek Lewis

commit sha 5a9b8090e71d869567b2e8c8bc1316142fe53be1

doc: add allowed info strings to style guide This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: https://github.com/nodejs/node/pull/33510 Refs: https://github.com/nodejs/node/pull/33507 Refs: https://github.com/nodejs/node/pull/33483 Refs: https://github.com/nodejs/node/pull/33531 Refs: https://github.com/nodejs/node/pull/33542 Refs: https://github.com/nodejs/node/pull/33028 Refs: https://github.com/nodejs/node/pull/33548 Refs: https://github.com/nodejs/node/pull/33486 PR-URL: https://github.com/nodejs/node/pull/34024 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ruben Bridgewater

commit sha dc187fca3f81ea439cc143482eba1e899fbac87f

util: support Combining Diacritical Marks for Symbols This adds support for the "Combining Diacritical Marks for Symbols" unicode group to calculate a zero length width even if Node.js is built without ICU. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33650 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ruben Bridgewater

commit sha 2a1a71b9473848ff9807374d6716f159a571f7da

util: fix width detection for DEL without ICU This makes sure the DEL character (ASCII 127) is detected as a zero width character even if Node.js is not built with ICU. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33650 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

sapics

commit sha ee02d228dc7a2b27b9ca572e956713648c68e26f

src: remove unnecessary calculation in base64.h PR-URL: https://github.com/nodejs/node/pull/33839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Pranshu Srivastava

commit sha c6172659854d7978d53ce61fbe99e22efe8f503a

doc: specify maxHeaderCount alias for maxHeaderListPairs Fixes: https://github.com/nodejs/node/issues/32388 PR-URL: https://github.com/nodejs/node/pull/33519 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Pranshu Srivastava

commit sha 077481bc345800c8c945f8210dcfc6ee1862d263

test: add test for Http2ServerResponse#[writableCorked,cork,uncork] PR-URL: https://github.com/nodejs/node/pull/33956 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Yash Ladha

commit sha 380424171f5a287b2e77ac9bee1bd932c09bc1d7

src: clang_format base_object PR-URL: https://github.com/nodejs/node/pull/33680 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

patr0nus

commit sha 46da8715033d47b28f17d97f1974d044cde65200

src: tolerate EPERM returned from tcsetattr macOS app sandbox makes tcsetattr return EPERM. The CHECK_EQ(0, err) here would fail when a sandboxed Node.js process is exiting. This commit fixes this issue. * test: add test for running in macOS app sandbox Bare-bone command-line executables cannot run directly in the app sandbox. To test that Node.js is able to run in the sandbox (and to test the fix in 317621b4a12562eb75055a67bb2c5556f53fe017), this commit creates a typical Cocoa app bundle, puts the node executable in it and calles Apple's codesign command to enable sandbox. * test: use process.execPath to get path of testing node PR-URL: https://github.com/nodejs/node/pull/33944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 days

push eventnodejs/node

Alba Mendez

commit sha 84a2d9a9158ab46ca0e4b73bcb90eeea0a12e030

doc: warn that tls.connect() doesn't set SNI Add a note warning users that when using tls.connect(), the `servername` option must be set explicitely to enable SNI, otherwise the connection could fail. PR-URL: https://github.com/nodejs/node/pull/33855 Fixes: https://github.com/nodejs/node/issues/28167 Co-authored-by: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

gengjiawen

commit sha cd5af16ae850935d3fd5b080d48c804e8f5a611b

src: improve indention for upd_wrap.cc PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

gengjiawen

commit sha 9521c70e6ab1e30e643dfe3c294d1523e22d0ec4

test: fix typo in common/index.js PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Shakil-Shahadat

commit sha d6d12302c946ae2cee8e5240faacf22c97a033b0

doc: update fs.md First class heading is made to look like other headings. PR-URL: https://github.com/nodejs/node/pull/33820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Rich Trott

commit sha 5dc0443b583d645506618373a06b975b522a2054

doc: revise text in dns module documentation introduction PR-URL: https://github.com/nodejs/node/pull/33986 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Shelley Vohr

commit sha 826df6e7c49c3eda6ce6792e2d91ab55827ed126

test: account for non-node basename PR-URL: https://github.com/nodejs/node/pull/33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha e3f87e544dd97b0c9fbb6bfaf8a358ded5428a22

doc: use a single space between sentences We mostly have a single space between the punctuation that ends a sentence and the start of the next sentence. Change instances with two spaces to one. PR-URL: https://github.com/nodejs/node/pull/33995 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 5d86d84c5db3e92c38dc2458d21b12959242ca31

doc: correct default values in http2 docs The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: https://github.com/nodejs/node/pull/33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha bce5e61f24cff0c3d58776f0007c1f1395109000

doc: use npm team for npm upgrades in collaborator guide The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: https://github.com/nodejs/node/pull/33999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

legendecas

commit sha 91550253b47492d797e18a09dbc0398a4ef48eb0

doc: clarify thread-safe function references PR-URL: https://github.com/nodejs/node/pull/33871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Rich Trott

commit sha 0f64a7a3026ae4013952533f3f5a30188a513d09

tools: remove superfluous regex in tools/doc/json.js Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: https://github.com/nodejs/node/pull/33998 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jamie Davis <davisjam@vt.edu>

view details

Denys Otrishko

commit sha 773fd7a87ec87cd726860c802130652c46b4efe8

fs: fix realpath inode link caching The `fs.realpath` / `fs.realpathSync` cache already seen symbolic links using the inode number which may be longer that max supported JS number (2**53) and will therefore be incorrectly handled by possibly entering infinite loop of calling stat on the same node. This PR changes those functions (where appropriate) to use bigint for inode numbers. Fixes: https://github.com/nodejs/node/issues/33936 PR-URL: https://github.com/nodejs/node/pull/33945 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ben Noordhuis

commit sha 3c61df83914741a120a27b6d90e5102110221bf6

build: configure byte order for mips targets The build defaulted to the byte order of the host system but that can be different from the endianness of the target system. Refs: https://github.com/nodejs/node/issues/33703#issuecomment-644639158 PR-URL: https://github.com/nodejs/node/pull/33898 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Nathan Blair

commit sha 4d15025814bb37801233c4c3d9312a777fece67e

configure: account for CLANG_VENDOR when checking for llvm version Fixes: https://github.com/nodejs/node/issues/29536 PR-URL: https://github.com/nodejs/node/pull/33860 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 days

push eventnodejs/node

Rich Trott

commit sha 082b595623eddf547d1d5a19ef40b09e13bd6c03

tools: update remark-preset-lint-node@1.15.1 to 1.16.0 This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: https://github.com/nodejs/node/pull/33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

rickyes

commit sha c8c2885ae79aaa039bb551593dd63d5d1487c401

lib: replace charCodeAt with fixed Unicode PR-URL: https://github.com/nodejs/node/pull/32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Ruben Bridgewater

commit sha 1c24d8618d0c72d21b40f5847137154524d4ffd5

util: gracefully handle unknown colors This makes sure colors that are unknown won't cause an error. This is especially important in case a library wants to use colors defined by Node.js core, if available and fall back to the default otherwise. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33797 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Stephen Belanger

commit sha 63e5d4d21c7f5938710a03239a292573b12bf272

async_hooks: callback trampoline for MakeCallback PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Stephen Belanger

commit sha 92ce1053a9a0b0bf743fec688e2510a6240f2870

domain: remove native domain code With the async_hooks callback trampoline, domains no longer need any native code. With this, domains can exist in pure JavaScript. PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Fábio Santos

commit sha b5f0fdb248f39688daa9ff46015207b7c086efd3

module: fix error message about importing names from cjs When importing specific names from a CJS module, and renaming them using `as`, the example fix in the error message erroneously contains the keyword `as` in the destructuring variable declaration. Example of this issue: import { parse as acornParse } from "acorn"; ^^^^^ SyntaxError: The requested module 'acorn' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export. For example: import pkg from 'acorn'; const { parse as acornParse } = pkg; PR-URL: https://github.com/nodejs/node/pull/33882 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Pranshu Srivastava

commit sha c60ffe68a7593cde8c0e9023238d6f308c009c48

http2: always call callback on Http2ServerResponse#end Fixes: https://github.com/nodejs/node/issues/28001 PR-URL: https://github.com/nodejs/node/pull/33911 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Pragyan Das

commit sha 5e375e7c90382a710c7a001c9165f81e6a2ff9e3

doc: update WASM code sample - Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: https://github.com/nodejs/node/pull/33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 9cf2841eb0af420b2be5c7b08098d230e76d9f2c

meta: introduce codeowners again The [Contributor's Survey results](https://github.com/nodejs/TSC/pull/882) highlight the fact that it is often not easy for contributors to know who the right people are to talk to about a proposed change or who to ask for reviews of a given subsystem. We briefly toyed around with codeowners before when GitHub introduced it but just as quickly disabled it because the structure of our repository made it exceedingly difficult to get right. Rather than start with a codeowners for the entire project, I propose that we start with a small experiment focused on specific subsystems. Specifically, codeowners for modules, streams, net/tls, http/http2, and quic (once that lands). We can expand out from there as we see how things go with the minimal starter set. Initially this just enables codeowners for the `quic` subsystem. A couple of points: 1. A codeowner should always be a team, never an individual person 2. Each codeowner team should contain at least one TSC member (to provide coverage for signing off on semver-major changes) 3. PRs touching any code with a codeowner must be signed off by at least one person on the codeowner team PR-URL: https://github.com/nodejs/node/pull/33895 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 865b180c4ad268361fc9444fed256c08db5b1255

doc: use Class: consistently The docs contain 122 uses of `Class:` in headers and one use of `class:` in headers. This changes that one instance to conform with the other instances. PR-URL: https://github.com/nodejs/node/pull/33978 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha b7e0b86677d85710144f8c10c8603bc83be2d779

doc: change "GitHub Repo" to "Code repository" "GitHub Repo & Issue Tracker" changed to "Code repository and issue tracker". PR-URL: https://github.com/nodejs/node/pull/33985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Rich Trott

commit sha 97f44cb4080f952403c5aadf20482eef2b8df790

doc: fix lexical sorting of bottom-references in dns doc The links are sorted in lexical order except for the two RFC links which are reversed. Fix that. PR-URL: https://github.com/nodejs/node/pull/33987 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha cbfdf1170c0ea71df70ac98d61e374faaa443817

build: add target specific build_type variable This commit add a target specific variable named 'build_type' to the node and node_g targets. The motivation for doing this is that both targets share the same prerequisites, and the recepies are the same (apart from the build type) so some duplication can be avoided. PR-URL: https://github.com/nodejs/node/pull/33925 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 days

pull request commentnodejs/node

repl: support optional chaining during autocompletion

@BridgeAR should this go back to v12.x? it's a bit conflict heavy, so would you mind opening a manual backport if so? Feel free to remove the label otherwise :)

BridgeAR

comment created time in 2 days

push eventnodejs/node

Pranshu Srivastava

commit sha 3789c28c8967ca4728db34f92021f54994ce62cd

doc: specify default encoding in writable.write Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/33765 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Pranshu Srivastava

commit sha 335f405f1b62a2fba1384925d7ef2654839a5e2a

doc: link readable._read in stream.md Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/33767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 days

pull request commentnodejs/node

deps: V8: cherry-pick eec10a2fd8fa

This doesn't apply to v12.x cleanly - should it go back? Adding a label but feel free to change.

Qard

comment created time in 2 days

issue closedelectron/electron

moveItemToTrash delete files permanently on Linux Ubuntu 20.04

shell.moveItemToTrash delete files permanently on Linux Ubuntu 20.04

electron 8.2.3

closed time in 2 days

vasyl-shumskyi

issue commentelectron/electron

moveItemToTrash delete files permanently on Linux Ubuntu 20.04

Thanks for reaching out! This is intended behavior.

Because we treat our issues list as the team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Electron there are a lot of options.

Check out the Electron community. There are also a bunch of helpful people in this community forum that should be willing to point you in the right direction.

vasyl-shumskyi

comment created time in 2 days

push eventnodejs/node

Anna Henningsen

commit sha 437f387de9d5c072f7b476f1d29566f3e29b2cf7

src: reduce scope of code cache mutex As indicated in the added comment, this can lead to a deadlock otherwise. In the concrete instance in which I encountered this, the relevant nested call is the one to `require('internal/tty')` inside of the `afterInspector()` function for uncaught exception handling. PR-URL: https://github.com/nodejs/node/pull/33980 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Denys Otrishko

commit sha 7744f66e0d62b14137dacb7b4db2f8182483ce81

test: print arguments passed to mustNotCall function Refs: https://github.com/nodejs/node/pull/33949#discussion_r442473532 Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33951 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

sapics

commit sha 578e731321c29755a1f77df65cb4affccd83ae94

querystring: fix stringify for empty array PR-URL: https://github.com/nodejs/node/pull/33918 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 2 days

issue commentelectron/electron

the property of BrowerWindow "transparent" can cause crash!!!

We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.

We will be able to more closely look at your issue once you do so. This issue will be closed in 7 days if the above is not addressed.

Weblianbin

comment created time in 2 days

push eventelectron/build-tools

Shelley Vohr

commit sha d1f1158b164cc33126b110bc3b7cfdeea2219cf3

fix: don't compare number to string (#151) * fix: don't compare number to string * Update src/e-pr.js Co-authored-by: Samuel Attard <sattard@slack-corp.com> Co-authored-by: Samuel Attard <sattard@slack-corp.com>

view details

push time in 2 days

delete branch electron/build-tools

delete branch : fix-e-pr

delete time in 2 days

PR merged electron/build-tools

Reviewers
fix: don't compare number to string

String coercion,,,,,,how does it work,,,,,,,

cc @MarshallOfSound

+1 -1

0 comment

1 changed file

codebytere

pr closed time in 2 days

pull request commentnodejs/node

src: fix FastStringKey equal operator

Backport blocked on https://github.com/nodejs/node/pull/33139

sapics

comment created time in 2 days

push eventnodejs/node

Anna Henningsen

commit sha 91998083550de715ee94a51e89e1fe558dd8e8a6

src: do not track BaseObjects via cleanup hooks Since f59ec2abee, `BaseObject` instances were tracked in heap snapshots through their associated `CleanupHookCallback`s which were stored on the `Environment`; however, this is inaccurate, because: - Edges in heap dumps imply a keeps-alive relationship, but cleanup hooks do not keep the `BaseObject`s that they point to alive. - It loses information about whether `BaseObject` instances are GC roots: Even weak `BaseObject`s are now, practically speaking, showing up as hanging off a GC root when that isn’t actually the case (e.g. in the description of nodejs/node#33468). Thus, this is a partial revert of f59ec2abee. Refs: https://github.com/nodejs/node/issues/33468 Refs: https://github.com/nodejs/node/pull/27018 PR-URL: https://github.com/nodejs/node/pull/33809 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 2 days

push eventelectron/build-tools

Shelley Vohr

commit sha 376c6f28ac485b656aa9ec2652c4cb048a788c3b

Update src/e-pr.js Co-authored-by: Samuel Attard <sattard@slack-corp.com>

view details

push time in 2 days

PR opened electron/build-tools

Reviewers
fix: don't compare number to string

String coercion,,,,,,how does it work,,,,,,,

cc @MarshallOfSound

+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchelectron/build-tools

branch : fix-e-pr

created branch time in 2 days

PR opened electron/electron

fix: always callback error with invalid print settings

Backport of https://github.com/electron/electron/pull/24476.

See that PR for more details.

Notes: Fixed an issue where webContents.print() would sometimes hang with invalid settings.

+60 -9

0 comment

4 changed files

pr created time in 2 days

create barnchelectron/electron

branch : print-settings-cb-9

created branch time in 2 days

PR opened electron/electron

fix: always callback error with invalid print settings

Backport of https://github.com/electron/electron/pull/24476.

See that PR for more details.

Notes: Fixed an issue where webContents.print() would sometimes hang with invalid settings.

+65 -14

0 comment

4 changed files

pr created time in 2 days

create barnchelectron/electron

branch : print-setting-cb-10

created branch time in 2 days

push eventnodejs/node

himself65

commit sha 74843db28c210f0fe25ff232806c97909664611d

src: simplify format in node_file.cc PR-URL: https://github.com/nodejs/node/pull/33660 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Brian White

commit sha 13b693fd5447d7e196767648d9fcfb0d5bd38046

querystring: improve stringify() performance PR-URL: https://github.com/nodejs/node/pull/33669 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

cjihrig

commit sha 54a4a816a43c18fcf3995ad966c17bc8ef0693cc

tools: update ESLint to 7.2.0 Update ESLint to 7.2.0 PR-URL: https://github.com/nodejs/node/pull/33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

view details

Derek Lewis

commit sha 9111fab6638d014e27cd89d9f7a67d667386914e

esm: fix loader hooks doc annotations Prior to this commit, the type annotations on the ESM loader hooks were invalid. This has been corrected and is ensured to be compatible with both the TypeScript and Closure type systems. Notes: https://www.typescriptlang.org/play/index.html?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+kArsgDZQwIrpYDyARgFYCmAxrhTwD2RXFwAeuSAAoe1ZFxE0AnpC5p4uJQEp6cJKgyYAYpSJ8CwigBMuAM0SUauAOJdcRwcjSJcu2PNxqImwsAAVkQTQCbC4AHkxIW09vXAAuSDxCUkgyAD4yemBwcXhPSURsJTNE03NhSBI3Dy8fKWoaABpIIRFxXC6be0cXJuSfLSwoSAJbaQBZHwALADpUIitIqQncyAAGZYBWCYTgYEgAZUiubuErAlwLImWpyEhTyGaMq8hPSEQaGiQACqACUADLYAaCL5oa6yPCRSA0QQkAg8RK-GyiLzEYgkDEtXDPV6vd4AQRoAHdEEoQgEgn8iD9OLxJIJZrhFtckl4sDyUulYpk8fkupSufJIJyuC83md+T5piFhNd2VKuRl8HiQsR1ddcIg2DRrobBAA3LjEkn05BMzCy14KtKQADkaEEVkcXBdHVlZAA3FMCqSzgAROxcZBS6EAOQ9lo4IR5fwBP2lUdBEKtNqZgwcTlc7jGuDatC6PVEEgGdnzIyLhK0gbIQA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520url%250A%2520*%2520%2540param%2520%257BObject%257D%2520context%2520(currently%2520empty)%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultGetFormat%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520format%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520getFormat(url%252C%2520context%252C%2520defaultGetFormat)%2520%257B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520URLs%252C%2520do%2520some%2520custom%2520logic%2520for%2520determining%2520format.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Bformat%253A%2520%253Cstring%253E%257D%252C%2520where%2520the%250A%2520%2520%2520%2520%252F%252F%2520format%2520is%2520one%2520of%2520the%2520strings%2520in%2520the%2520table%2520above.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520format%253A%2520'module'%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520URLs.%250A%2520%2520return%2520defaultGetFormat(url%252C%2520context%252C%2520defaultGetFormat)%253B%250A%257D https://www.typescriptlang.org/play/?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkfSyakVwBVAEoAZAFyQAhAAo8hUpAA+kAK5EAJtSZFq2gJQAaXn1oB7HQVwFr2GQoCCyVAE8APEuIkAfKa8ZBRWwtQAHri8HKgYmABiWrR21hS6DIgaADa4YtTYllkAbtTRgrgayETYWAoACsiWaATY1J6YmshZMj4qZAFkbMDgEfCWyLiQiNjuRLSQDEkpRJCCBcXUijT0TCwmkKG4Ebj76Zk5eeslRlhQBw6THQJCopKQALyQRNlZkBSfh2OAG47oxIPIALKIXAACwAdKgdE15Dc-JAAAxwgCsNw6wGAkAAyk1qPcbMs4Xc+PjIPFxpQSZB6Ygsr8qHRGMxkNhTpYGWhSbQNHgmpAspYSAR5gx6WtCkVfJS+NSCc4sgB3RDuGrlSorRArSwAIwAVnRJpYGJBYaSZcg4pVupBvPhfH4yErlbqqrdlcrHTJnsJxBJIAB+Kl+r7UdWQENbDm7ZD7IOvCRGOEwwRWqSRv0GWPx9k7LkZrN6Mx+sggviDPhgyHQ+GI7TIm6eDHY3GQGnOIiWG3IMnaWz2IielWQADqMKEBxZWV8kAABmdsrl8vLqMv9japsgSBoBcIarQDZAjaS0JYR7ttHDIABJFawlqRmln1qQWwAchqiG0EcVANAdZyHIoWQ0W16TQaFaBhJdQhHZYWUgUZxlwbAJ1WagKh9NcLk3DYExLPZfSjOFKMBSJKyjJDRwcGQAG1KLhajcDY6xkLHHlIB-EDBwAWno5YfwAXVo2sjBrP47hpAARPQWGtPkADkb2oOETRqO0plZJlB0obZORYLC7m9FYCI3K5NmLEzkzJI4aMgKzLi3aTwDIIA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%2520%2520conditions%253A%2520!(Array%253Cstring%253E)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257B!(Promise%253C%257B%2520url%253A%2520string%2520%257D%253E)%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257D https://www.typescriptlang.org/play/?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+kArsgDZQwIrpaaQBmA9smorgFyQ8hUpDIUAxhyK4ApgA9c9OElQZMAMUpFxuAlIoATGW0SUauAOIzcAZQ7VxMpbGTXqRbFgAKyDmgLYMgA8rNj2yI4CAIQAFDYAFigyBgCCyKgAngBClGxsMsiQAD6C+MQkxZAAqsS4ABxpmQCUogB8ZPTA4PLwXLiQiNgZ2uxaOnpEkCTWdg4yMdQ0ADSQktLyuCtGJmaWM+GOLZhQq1J4WOxcPP0UALyn6woA3CcEbJAxALK88QB0qEQDH4Yi1WpAAAy-ACsR0gwGAkDsaBkDwMBF0Ul+J0gcIR6i4gj8KIJiBoNGqACUADLYLYcQnI1aUPB+SA0DgkAjiS6FVxlGQAN3KkFw8RRYTmWJxOPhkBSNAA7ogMp4+e4BpMOAAjABWMh0kA471FKM43CwEoiMgEQSE5SKWty+WQ7Sl0rVyEmx2l0stkUgAHJfsGA0tsaIXjiOjKEQARYwFEX0gByHCMvx1njNAzJhpNhSq1Owbo9k22pnMVlsB3mixWa1kCi2xgre2rcyaLzIQA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520url%250A%2520*%2520%2540param%2520%257B%257B%2520format%253A%2520string%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultGetSource%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520source%253A%2520!(SharedArrayBuffer%2520%257C%2520string%2520%257C%2520Uint8Array)%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520getSource(url%252C%2520context%252C%2520defaultGetSource)%2520%257B%250A%2520%2520const%2520%257B%2520format%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520URLs%252C%2520do%2520some%2520custom%2520logic%2520for%2520retrieving%2520the%2520source.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Bsource%253A%2520%253Cstring%257Cbuffer%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520source%253A%2520'...'%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520URLs.%250A%2520%2520return%2520defaultGetSource(url%252C%2520context%252C%2520defaultGetSource)%253B%250A%257D https://www.typescriptlang.org/play/?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwIQAoDKAFigKYAmAgsqgJ4BCArgGZMnKQA+kAzgC7IBLAHYBzTpACqw3gA4qtAJQBfHgHsGyAMYkoMBCnRZMuyKY0AbAFw9+wkQBoTppquRpEva30GjH0SEoqmqpCvCQAHrwm+qgYmABiDEKavAIhKmQkTIgM5rwAKqhC3C5u+OpaOv6wyCS8GsVYAArIqmgC3CQAPJhqGtrWeESklNSI9Mys7FzeduJSoXJjNAoBAHxKusDgEfCuvJCI3DTJkExJKWlCkPyIxaVo5f0kuNwV2vaQwaERvJ+Z2VyBSKJVcj3eJFWxlM3z4WEgFk+Dw8AUgAF4viEwpEANxQSACJiQXAAWQ8hAAdEUyG1cKs1pAAAwUgCsUMgwGAkHKaBImKEZAEqRCFPxpk5kHirjUvMg0sQ5nMkgASgAZbj-VQyvmaBh8NqQcyqEQCTRnaVoVSCpg0Oa8Qh8t7PUWmcVcijmADu424kFq9WQ1zucoARgArEgpOVE+18h5YJ2VaxdWaiDghyZsDYu13+hpYMWuxMDSAAcgpFdLfldSjxpk2bsgABEsmwblqAHJWkgUsO+0qHRVy2PsYskbg5vOByAAnJ5Qp3UFlCGvCGfb7Yv4zrJz4GLh5PSoKPFKIA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257B!(SharedArrayBuffer%2520%257C%2520string%2520%257C%2520Uint8Array)%257D%2520source%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520url%253A%2520string%252C%250A%2520*%2520%2520%2520format%253A%2520string%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultTransformSource%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520source%253A%2520!(SharedArrayBuffer%2520%257C%2520string%2520%257C%2520Uint8Array)%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520transformSource(source%252C%2520context%252C%2520defaultTransformSource)%2520%257B%250A%2520%2520const%2520%257B%2520url%252C%2520format%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520URLs%252C%2520do%2520some%2520custom%2520logic%2520for%2520modifying%2520the%2520source.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Bsource%253A%2520%253Cstring%257Cbuffer%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520source%253A%2520'...'%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520sources.%250A%2520%2520return%2520defaultTransformSource(source%252C%2520context%252C%2520defaultTransformSource)%253B%250A%257D PR-URL: https://github.com/nodejs/node/pull/33563 Co-authored-by: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

Daniel Bevenius

commit sha 5609b17e2d2c9cc03ce246ee1c5622824d6829c1

doc: move --force-context-aware option in cli.md This commit moves the --force-context-aware option so that the options list is in alphabetical order. PR-URL: https://github.com/nodejs/node/pull/33823 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha ec2452c4af34765d3948aa841728fd1c76eedb2c

src: avoid unnecessary ToLocalChecked calls This commit removes two unnecessary ToLocalChecked calls in StringBytes::Encode. PR-URL: https://github.com/nodejs/node/pull/33824 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha 185657dfd7e4dc65f8ea1be97a90fec9d40ffaac

src: remove unused vector include in string_bytes PR-URL: https://github.com/nodejs/node/pull/33824 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha 5b987c46b77a99d7fea2cdf78bf1d8b3766ea422

src: remove ref to tools/generate_code_cache.js This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md. PR-URL: https://github.com/nodejs/node/pull/33825 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha fd5ab63d961d3cf067ebe00572695414f2cd8366

tools: remove unused vector include in mkdcodecache PR-URL: https://github.com/nodejs/node/pull/33828 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Daniel Bevenius

commit sha ba813dd0dd4696930898c3487533874eb7734eec

tools: prevent js2c from running if nothing changed This commit updates tools/js2c.py to touch the target output file , <(SHARED_INTERMEDIATE_DIR)/node_javascript.cc, even if the content has not changed. This is to "help" the build system so that it can compare the inputs against the output to determine if the gyp action should be run. I believe the issue here is that if js2c.py is updated this can cause the action to be run as the node_javascript.cc target would be older than js2c.py. But when the target is run the timestamp for node_javascript.cc will not be updated (because we have not changed anything that would change the contents of the file) so the js2c.py prerequisite will always be passed and the target always run. Using the update in this commit one would have to touch/modify one of the js files specified in the library_files list, config.gypi, or tools/js2c.py for this action to be run again. PR-URL: https://github.com/nodejs/node/pull/33844 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Mathias Buus

commit sha 2e97d82509f3d3f24263935eb17357c0fa6dc16f

n-api: document nextTick timing in callbacks PR-URL: https://github.com/nodejs/node/pull/33804 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

push time in 2 days

issue closedelectron/electron

Webview Bug

I'm having trouble with webview wheel I'm trying to run this project https://github.com/hokein/electron-sample-apps/tree/master/webview/browser I'm creating a webview of a project that has another webview inside But it's not working Is something missing ? <webview src="./apps/browser/browser.html" webpreferences="nodeIntegration: true, webviewTag: true, allowRunningInsecureContent, javascript = no"> </webview>

1

closed time in 2 days

Slender1808

issue commentelectron/electron

Webview Bug

Thanks for reaching out!

Because we treat our issues list as the team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Electron there are a lot of options. Check out the Electron community. There are also a bunch of helpful people in this community forum that should be willing to point you in the right direction.

Slender1808

comment created time in 2 days

push eventnodejs/node

cjihrig

commit sha 046dee6eb3b42f4cde68f54a3c2733f8e23ee131

doc: update V8 inspector example This commit updates the V8 inspector example to reflect what is currently printed to the console. PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

cjihrig

commit sha 103a9af6736be99031806f590aeb05a59b9975d3

inspector: drop 'chrome-' from inspector url It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

legendecas

commit sha c50bd2f954f3940a869ce627155735da94b75a68

test: fix invalid regular expressions in case test-trace-exit PR-URL: https://github.com/nodejs/node/pull/33769 Fixes: https://github.com/nodejs/node/issues/30516 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Dennis Ameling

commit sha 4388dad537457db5bfdd4dfde13cb964976bd625

win,msi: add arm64 config for windows msi Adds configuration to allow building an MSI installer for Windows ARM64. MSI can be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/33689 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

Michael Dawson

commit sha b5113d0b5327cb900c3cc4629986f598dec79d90

test: temporarily exclude test on arm Refs: https://github.com/nodejs/node/issues/33796 Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33814 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Michael Dawson

commit sha 90ddf0aa2e1bfa09749d7f5e40155d4bf7bec5bf

n-api: ensure scope present for finalization Refs: https://github.com/nodejs/node-addon-api/issues/722 Ensure a scope is on stack during finalization as finalization functions can create JS Objects Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33508 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Derek Lewis

commit sha 4654e2321b7fc4efdb206224b2b09fdfd50d2eb0

doc: fix misc. mislabeled code block info strings Prior to this commit, a handful of misc. code blocks were in need of fixup. Corrections are according to predetermined conventions. Closes: https://github.com/nodejs/node/issues/32938 PR-URL: https://github.com/nodejs/node/pull/33548 Fixes: https://github.com/nodejs/node/issues/32938 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Daniel Bevenius

commit sha f8baeccaaa33260c66fc02f31b2567dc3d9f12aa

doc: use single quotes in --tls-cipher-list Currently, running the example code will produce the following error in bash: $ node --tls-cipher-list="ECDHE-RSA-AES128-GCM-SHA256:!RC4" server.js bash: !RC4: event not found This commit changes the two examples to use single quotes to avoid the shell from trying to interpret '!' as the history command. PR-URL: https://github.com/nodejs/node/pull/33709 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Andrey Pechkurov

commit sha f39ee7d24598fbdcb43adce69f786c6af3ed525a

doc: add snippet for AsyncResource and EE integration PR-URL: https://github.com/nodejs/node/pull/33751 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

Gus Caplan

commit sha c4129f91e814bab893336d839c2a00925d82e61b

vm: allow proxy callbacks to throw Fixes: https://github.com/nodejs/node/issues/33806 PR-URL: https://github.com/nodejs/node/pull/33808 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 86283aaa6afa6cfd2ccf5f489788b4b8c1bfbc44

src: handle missing TracingController everywhere Fixes: https://github.com/nodejs/node/issues/33800 PR-URL: https://github.com/nodejs/node/pull/33815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 days

push eventnodejs/node

Daniel Bevenius

commit sha 4b4fb1381b494e6209b4fb40a39e9b89843245da

src: use Check() instead of FromJust in environment This commit replaces FromJust() calls with Check() in places where the value that FromJust() returns is not used. PR-URL: https://github.com/nodejs/node/pull/33706 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Daniel Bevenius

commit sha d56585ec8d1db2d31843b11af53aa42e35fc02d0

build: add LINT_CPP_FILES to checkimports check This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha 5328089c919e00d99dc6dd0603febf96d2a14e7c

tools: remove unused using declarations code_cache This commit removes the reported unused using declarations from cache_builder.cc PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha abf04b245a11400a84302250ca342b9ccc58fbeb

src,build: add --openssl-default-cipher-list This commit adds a configuration option named openssl-default-cipher-list which takes a colon separated string specifying ciphers that should be used as the default ciphers instead of the ones defined in node_constants. The motivation for this is a use case where Fedora/RHEL would like to be able to specify a default cipher in the format PROFILE=SYSTEM. This would enable Fedora/RHEL to have a system wide security level for all applications. PR-URL: https://github.com/nodejs/node/pull/33708 Refs: https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Daniel Bevenius

commit sha 449d9ec1c55cd34c07a88b8715cdf3e799b411e6

src: add "missing" bash completion options Currently, when using the bash completions for node the normal completions for filenames directories do not work. For example, after finding a node completion and then wanting to use tab completion for a filename in the test directory, it is only possible to get the name of the test directory completed, followed by a space. What is expected is to be able to continue with tab completion for directories. This commit adds options to the complete command to enable default bash completions. PR-URL: https://github.com/nodejs/node/pull/33744 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

sapics

commit sha e07c1c25085ec3f717267018fb2e76fe4611cb50

src: simplify Reindent function in json_utils.cc PR-URL: https://github.com/nodejs/node/pull/33722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

push time in 2 days

push eventelectron/electron

Shelley Vohr

commit sha 6c4017ff45f22e3859ee5801213d6d7982356fac

fix: always callback error with invalid print settings (#24476)

view details

push time in 2 days

delete branch electron/electron

delete branch : fix-printing-micron-problem

delete time in 2 days

PR merged electron/electron

Reviewers
fix: always callback error with invalid print settings target/10-x-y target/9-x-y

Description of Change

Closes https://github.com/electron/electron/issues/24456.

The minimum micron size Chromium accepts is that where (per printing/units.h):

  • kMicronsPerInch - Length of an inch in 0.001mm unit.
  • kPointsPerInch - Length of an inch in CSS's 1pt unit.

Adhere to: (kPointsPerInch / kMicronsPerInch) * size >= 1

Practically, this means microns need to be > 352 microns.

We therefore need to verify this or it will fail with a logging error of:

[77469:0708/232856.127937:ERROR:print_view_manager_base.cc(71)] Invalid printer settings The selected printer is not available or not installed correctly. <br> Check your printer or try selecting another printer.

This also adds in a callback call in the event that print setting validation fails, so there are no silent failures.

cc @zcbenz @jkleinsc @MarshallOfSound

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Fixed an issue where webContents.print() would sometimes hang with invalid settings.

+65 -14

2 comments

4 changed files

codebytere

pr closed time in 2 days

issue closedelectron/electron

Printing hangs with pageSize Object

  • Electron Version: v9.0.1
  • Operating System: Linux 5.7.4-arch1-1

Expected Behavior

I expect it to print.

Actual Behavior

The printing hangs.

To Reproduce

const { remote } = require ('electron');

const { BrowserWindow } = remote;
const win = new BrowserWindow();

win.loadURL('https://google.com');

win.webContents.on('did-finish-load', () => {
  win.webContents.print({ pageSize: { height: 88.6, width: 35.7 } }, (success, error) => {
    if(!success) console.error(error);
  })
})

Here is a fiddle of the error https://gist.github.com/81597c2a1f33779c7083194b4590f55c

closed time in 2 days

TheSinding

pull request commentnodejs/node

build: fix node.gyp config

Backport blocked on https://github.com/nodejs/node/pull/33291

gengjiawen

comment created time in 2 days

push eventcodebytere/node-core-utils

Shelley Vohr

commit sha 3cd93b997ed090eea2f5a28fbbccf90a15659011

spec: add tests for comparisons

view details

push time in 3 days

push eventcodebytere/codebytere

Shelley Vohr

commit sha 7c8220f91326bea8e6ee1e98223f148ac86c452b

chore: update README

view details

push time in 3 days

push eventcodebytere/node-core-utils

Shelley Vohr

commit sha dd48ae2c1ea67e0645acd5415d522e4e75db993e

spec: add tests for comparisons

view details

push time in 3 days

PR opened nodejs/node-core-utils

Reviewers
feat: allow citgm job comparison

Closes https://github.com/nodejs/node-core-utils/issues/352.

Extends ncu-ci cigtm <jobid> to ncu-cu cigtm <jobid> [jobid2], allowing for direct comparisons between two CITGM runs to see if new failures were introduced.

I also did a bit of a refactor here, since there were a million classes in the result parser file and it was getting wildly unwieldy. I tried to do the minimum necessary to make this work but I plan to follow it up with the remainder of the the class split-out work.

Display:

Developer ❯ ncu-ci citgm 2392 2390                                             11:06PM
--------------------------------------------------------------------------------
[1/1] Running CITGM: 2392
--------------------------------------------------------------------------------
✔  Summary data downloaded
✔  Results data downloaded
✔  Summary data downloaded
✔  Results data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/2392/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/v12.x
Commit     [feed95cd4c2c] Working on v12.18.1
Date       2020-06-02 20:27:47 +0200
Author     Michaël Zasso <targos@protonmail.com>
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/2390/
Source     https://github.com/nodejs/node/pull/33811/
Commit     [9a60117875dd] 2020-06-16, Version 12.18.1 'Erbium' (LTS)
Date       2020-06-09 20:23:09 -0700
Author     Shelley Vohr <shelley.vohr@gmail.com>
----------------------------------- Results ------------------------------------
┌────────────────────────┬───────────────────────────┬────────────────────────────┬─────────────────────────┐
│        (index)         │             0             │             1              │            2            │
├────────────────────────┼───────────────────────────┼────────────────────────────┼─────────────────────────┤
│       debian9-64       │ 'express-session-v1.17.1' │ 'yeoman-generator-v4.10.1' │                         │
│     centos7-ppcle      │    'ember-cli-v3.18.0'    │      'multer-v1.4.2'       │ 'torrent-stream-v1.2.0' │
│      rhel7-s390x       │  'torrent-stream-v1.2.0'  │                            │                         │
│   fedora-latest-x64    │    'spawn-wrap-v2.0.0'    │                            │                         │
│     ubuntu1804-64      │                           │                            │                         │
│ fedora-last-latest-x64 │                           │                            │                         │
│     ubuntu1604-64      │                           │                            │                         │
└────────────────────────┴───────────────────────────┴────────────────────────────┴─────────────────────────┘

<details> <summary>Sample JSON Output</summary>

[
  {
    "baseBuild": {
      "source": "https://api.github.com/repos/nodejs/node/git/refs/heads/v12.x",
      "upstream": "https://ci.nodejs.org/job/citgm-smoker/2390/"
    },
    "comparisonBuild": {
      "source": "https://github.com/nodejs/node/pull/33811/",
      "upstream": "https://ci.nodejs.org/job/citgm-smoker/2392/"
    },
    "debian9-64": [
      {
        "name": "express-session-v1.17.1",
        "status": "FAILED"
      },
      {
        "name": "yeoman-generator-v4.10.1",
        "status": "FAILED"
      }
    ],
    "centos7-ppcle": [
      {
        "name": "ember-cli-v3.18.0",
        "status": "FAILED"
      },
      {
        "name": "multer-v1.4.2",
        "status": "FAILED"
      },
      {
        "name": "torrent-stream-v1.2.0",
        "status": "FAILED"
      }
    ],
    "rhel7-s390x": [
      {
        "name": "torrent-stream-v1.2.0",
        "status": "FAILED"
      }
    ],
    "fedora-latest-x64": [
      {
        "name": "spawn-wrap-v2.0.0",
        "status": "FAILED"
      }
    ],
    "ubuntu1804-64": [],
    "fedora-last-latest-x64": [],
    "ubuntu1604-64": []
  }
]

</details>

<details> <summary>Sample Markdown Output</summary>

# CITGM Data for [#2392](https://ci.nodejs.org/job/citgm-smoker/2392/) - [#2390](https://ci.nodejs.org/job/citgm-smoker/2390/)

## New Failures in job [#2390](https://ci.nodejs.org/job/citgm-smoker/2390/)

### debian9-64

* express-session-v1.17.1
* yeoman-generator-v4.10.1

### centos7-ppcle

* ember-cli-v3.18.0
* multer-v1.4.2
* torrent-stream-v1.2.0

### rhel7-s390x

* torrent-stream-v1.2.0

### fedora-latest-x64

* spawn-wrap-v2.0.0

### ubuntu1804-64

None.

### fedora-last-latest-x64

None.

### ubuntu1604-64

None.

</details>

cc @richardlau (since i can't request your review)

+8592 -491

0 comment

15 changed files

pr created time in 3 days

create barnchcodebytere/node-core-utils

branch : allow-citgm-comparison

created branch time in 3 days

push eventcodebytere/node-core-utils

Shelley Vohr

commit sha 158efdf1245bdbbf22d93561f36b802b19da9ebd

docs: improve ncu-ci docs (#453) * docs: improve ncu-ci docs * Fixup malformed ncu-ci walk <type> section

view details

Shelley Vohr

commit sha c1dfbd0f57feb62c813205e2ff748d7d7db7f048

feat: add ncu-ci cigtm <jobid> (#454)

view details

push time in 3 days

push eventelectron/electron

Samuel Attard

commit sha 1dce5f2fceac6f46a23b8dbe467493bfccc65ec9

chore: fix setAlwaysOnTop test The window must be visible for state to be updated properly.

view details

push time in 3 days

delete branch electron/electron

delete branch : roller/chromium/10-x-y

delete time in 3 days

push eventelectron/electron

Electron Bot

commit sha c804212426e81e09472db960e673015382b6ddde

chore: bump chromium in DEPS to 85.0.4183.20 (#24487)

view details

push time in 3 days

PR merged electron/electron

chore: bump chromium to 85.0.4183.20 (10-x-y)

Updating Chromium to 85.0.4183.20.

See all changes in 85.0.4183.19..85.0.4183.20

<!-- Original-Version: 85.0.4183.19 -->

Notes: Updated Chromium to 85.0.4183.20.

+1 -1

0 comment

1 changed file

electron-bot

pr closed time in 3 days

push eventelectron/electron

Samuel Attard

commit sha 653bb602e25672fded6d67ccfdade3ba6a79e7f5

build: remove bad 'when' clause from CI config (#24466)

view details

trop[bot]

commit sha 9ccf1b569b2b88e6c5fd9ab622a6d9c57dd3dc42

fix: clipboard.readBuffer returning empty value (#24468) Co-authored-by: Deepak Mohan <hop2deep@gmail.com>

view details

Shelley Vohr

commit sha cddd637fe68d4111559fb7f2a553de516749906e

fix: uv_walk crash on web worker close

view details

Shelley Vohr

commit sha 4a50ed0de1581629aa2b16dfa858f166b4902b96

Use DCHECK_EQ

view details

push time in 3 days

pull request commentelectron/electron

fix: use default NSVisualEffectState enum case

@MarshallOfSound yes - it's invoked in SetVibrancy. Honestly not sure how to distill this down any better, since it is a detail that's somewhat specific to macOS-specific APIs.

codebytere

comment created time in 3 days

PR merged nodejs/node-core-utils

Reviewers
feat: add ncu-ci cigtm <jobid>

Refs https://github.com/nodejs/node-core-utils/issues/352.

Adds ncu-ci cigtm <jobid>.

Ideally i'll end up adding functionality to compare two CITGM runs, e.g. ncu-ci cigtm <job1id> <job2id> but i think it'll be easier to get this reviewed and merged if it's less massive.

Todo:

  • [x] Tests
  • [x] Formatting
  • [x] Documentation

<details> <summary>Example Markdown Output</summary>

# CITGM Data for [2400](https://ci.nodejs.org/job/citgm-smoker/2400/)

## Statistics for job [2400](https://ci.nodejs.org/job/citgm-smoker/2400/)

|  FAILED  |  SKIPPED  |  PASSED  |  TOTAL  |
| -------- | --------- | -------- | ------- |
| 21       | 233       | 594      | 848     |

## Failures in job [2400](https://ci.nodejs.org/job/citgm-smoker/2400/)

### [debian9-64](https://ci.nodejs.org/job/citgm-smoker/nodes=debian9-64/2400/)

* coffeescript-v2.5.1
* through2-v4.0.2

### [rhel7-s390x](https://ci.nodejs.org/job/citgm-smoker/nodes=rhel7-s390x/2400/)

* through2-v4.0.2

### [fedora-latest-x64](https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/2400/)

* coffeescript-v2.5.1
* through2-v4.0.2

### [ubuntu1604-64](https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1604-64/2400/)

* coffeescript-v2.5.1
* through2-v4.0.2

### [osx1014](https://ci.nodejs.org/job/citgm-smoker/nodes=osx1014/2400/)

* acorn-v7.3.1
* coffeescript-v2.5.1
* clinic-v6.0.2
* ember-cli-v3.19.0
* semver-v7.3.2
* watchify-v3.11.1

### [ubuntu1804-64](https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1804-64/2400/)

* coffeescript-v2.5.1
* through2-v4.0.2

### [fedora-last-latest-x64](https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-last-latest-x64/2400/)

* coffeescript-v2.5.1
* through2-v4.0.2

### [centos7-ppcle](https://ci.nodejs.org/job/citgm-smoker/nodes=centos7-ppcle/2400/)

* coffeescript-v2.5.1
* clinic-v6.0.2
* torrent-stream-v1.2.0
* through2-v4.0.2

</details>

<details> <summary>Example JSON Output</summary>

{
  "source": "https://github.com/nodejs/node/pull/34093/",
  "upstream": "https://ci.nodejs.org/job/citgm-smoker/2400/",
  "passed": 594,
  "total": 848,
  "skipped": 233,
  "failed": 21,
  "debian9-64": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=debian9-64/2400/",
    "modules": [
      {
        "name": "coffeescript-v2.5.1",
        "status": "FAILED"
      },
      {
        "name": "through2-v4.0.2",
        "status": "FAILED"
      }
    ]
  },
  "rhel7-s390x": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=rhel7-s390x/2400/",
    "modules": [
      {
        "name": "through2-v4.0.2",
        "status": "FAILED"
      }
    ]
  },
  "fedora-latest-x64": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/2400/",
    "modules": [
      {
        "name": "coffeescript-v2.5.1",
        "status": "FAILED"
      },
      {
        "name": "through2-v4.0.2",
        "status": "FAILED"
      }
    ]
  },
  "ubuntu1604-64": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1604-64/2400/",
    "modules": [
      {
        "name": "coffeescript-v2.5.1",
        "status": "FAILED"
      },
      {
        "name": "through2-v4.0.2",
        "status": "FAILED"
      }
    ]
  },
  "osx1014": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=osx1014/2400/",
    "modules": [
      {
        "name": "acorn-v7.3.1",
        "status": "FAILED"
      },
      {
        "name": "coffeescript-v2.5.1",
        "status": "FAILED"
      },
      {
        "name": "clinic-v6.0.2",
        "status": "FAILED"
      },
      {
        "name": "ember-cli-v3.19.0",
        "status": "FAILED"
      },
      {
        "name": "semver-v7.3.2",
        "status": "FAILED"
      },
      {
        "name": "watchify-v3.11.1",
        "status": "FAILED"
      }
    ]
  },
  "ubuntu1804-64": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1804-64/2400/",
    "modules": [
      {
        "name": "coffeescript-v2.5.1",
        "status": "FAILED"
      },
      {
        "name": "through2-v4.0.2",
        "status": "FAILED"
      }
    ]
  },
  "fedora-last-latest-x64": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-last-latest-x64/2400/",
    "modules": [
      {
        "name": "coffeescript-v2.5.1",
        "status": "FAILED"
      },
      {
        "name": "through2-v4.0.2",
        "status": "FAILED"
      }
    ]
  },
  "centos7-ppcle": {
    "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=centos7-ppcle/2400/",
    "modules": [
      {
        "name": "coffeescript-v2.5.1",
        "status": "FAILED"
      },
      {
        "name": "clinic-v6.0.2",
        "status": "FAILED"
      },
      {
        "name": "torrent-stream-v1.2.0",
        "status": "FAILED"
      },
      {
        "name": "through2-v4.0.2",
        "status": "FAILED"
      }
    ]
  }
}

</details>

Current output format:

node on git:master ❯ ncu-ci citgm 2400                                         10:58AM
--------------------------------------------------------------------------------
[1/1] Running CITGM: 2400
--------------------------------------------------------------------------------
✔  Summary data downloaded
✔  Results data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/2400/
Source     https://github.com/nodejs/node/pull/34093/
Commit     [9ec07f42864c] 2020-06-30, Version 14.5.0 (Current)
Date       2020-06-29 21:17:56 -0700
Author     Shelley Vohr <shelley.vohr@gmail.com>
---------------------------------- Statistics ----------------------------------
┌─────────┬────────┐
│ (index) │ Values │
├─────────┼────────┤
│ Failed  │   21   │
│ Skipped │  233   │
│ Passed  │  594   │
│  Total  │  848   │
└─────────┴────────┘
----------------------------------- Failures -----------------------------------
┌────────────────────────┬───────────────────────┬───────────────────────┬─────────────────────────┬─────────────────────┬─────────────────┬────────────────────┐
│        (index)         │           0           │           1           │            2            │          3          │        4        │         5          │
├────────────────────────┼───────────────────────┼───────────────────────┼─────────────────────────┼─────────────────────┼─────────────────┼────────────────────┤
│       debian9-64       │ 'coffeescript-v2.5.1' │   'through2-v4.0.2'   │                         │                     │                 │                    │
│      rhel7-s390x       │   'through2-v4.0.2'   │                       │                         │                     │                 │                    │
│   fedora-latest-x64    │ 'coffeescript-v2.5.1' │   'through2-v4.0.2'   │                         │                     │                 │                    │
│     ubuntu1604-64      │ 'coffeescript-v2.5.1' │   'through2-v4.0.2'   │                         │                     │                 │                    │
│        osx1014         │    'acorn-v7.3.1'     │ 'coffeescript-v2.5.1' │     'clinic-v6.0.2'     │ 'ember-cli-v3.19.0' │ 'semver-v7.3.2' │ 'watchify-v3.11.1' │
│     ubuntu1804-64      │ 'coffeescript-v2.5.1' │   'through2-v4.0.2'   │                         │                     │                 │                    │
│ fedora-last-latest-x64 │ 'coffeescript-v2.5.1' │   'through2-v4.0.2'   │                         │                     │                 │                    │
│     centos7-ppcle      │ 'coffeescript-v2.5.1' │    'clinic-v6.0.2'    │ 'torrent-stream-v1.2.0' │  'through2-v4.0.2'  │                 │                    │
└────────────────────────┴───────────────────────┴───────────────────────┴─────────────────────────┴─────────────────────┴─────────────────┴────────────────────┘
+4389 -17

6 comments

8 changed files

codebytere

pr closed time in 3 days

delete branch codebytere/node-core-utils

delete branch : ncu-ci-citgm

delete time in 3 days

push eventnodejs/node-core-utils

Shelley Vohr

commit sha c1dfbd0f57feb62c813205e2ff748d7d7db7f048

feat: add ncu-ci cigtm <jobid> (#454)

view details

push time in 3 days

PR opened electron/electron

Reviewers
fix: default to simplex for printing DuplexMode target/10-x-y target/9-x-y

Description of Change

Linux requires that duplex_mode have a default, which is kSimplex. We need to set that before attempting to convert so that it doesn't fall down into this NOTREACHED() DCHECK failure.

cc @jkleinsc @MarshallOfSound @deepak1556

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Fixed potentially invalid duplex mode settings on Linux.

+2 -1

0 comment

1 changed file

pr created time in 3 days

create barnchelectron/electron

branch : linux-duplex-mode

created branch time in 3 days

push eventelectron/electron

Shelley Vohr

commit sha bb01cd94e91d58eea1722899e331232f7d320e84

Document minimum micron requirements

view details

push time in 3 days

push eventelectron/electron

Shelley Vohr

commit sha acfc9ac5a711750e73b0d2d51ae7916fa876707a

Document minimum micron requirements

view details

push time in 3 days

pull request commentnodejs/node-core-utils

ncu-ci: command to start CI for PRs

I might not have all the context i might need as i'm not a member of @nodejs/build, but if no one else comments then i think we may be fine to go ahead and merge?

mmarchini

comment created time in 3 days

push eventcodebytere/node-core-utils

Shelley Vohr

commit sha 17e93b314367c7ae6125b07f5c02724d38f626e5

Fixup linting

view details

push time in 3 days

push eventelectron/electron

Shelley Vohr

commit sha 4ae53918aaf0fbe7ebe6cc74d185a9f4ed5af2b8

Callback invalid settings vs silently failing

view details

push time in 3 days

push eventcodebytere/node-core-utils

Shelley Vohr

commit sha f883ccc8f73c4a4a4cd40ceb6cdf3f4e147eb674

Add statistics to citgm output

view details

push time in 3 days

Pull request review commentnodejs/node-core-utils

feat: add ncu-ci cigtm <jobid>

 Notifying upstream projects of job completion Finished: SUCCESS ``` +### `ncu-ci citgm <jobid>`++`ncu-ci citgm <jobid>` shows the results of a given citgm-smoker job.++Example:+```+node on git:master ❯ ncu-ci citgm 2400                                         10:25AM+--------------------------------------------------------------------------------+[1/1] Running CITGM: 2400+--------------------------------------------------------------------------------+✔  Header data downloaded+✔  Report data downloaded+----------------------------------- Summary ------------------------------------+Result     FAILURE+URL        https://ci.nodejs.org/job/citgm-smoker/2400/testReport/+Source     https://github.com/nodejs/node/pull/34093/+Commit     [9ec07f42864c] 2020-06-30, Version 14.5.0 (Current)+Date       2020-06-29 21:17:56 -0700+Author     Shelley Vohr <shelley.vohr@gmail.com>+----------------------------------- Failures -----------------------------------+┌────────────────────────┬───────────────────────┬───────────────────────┬─────────────────────────┬─────────────────────┬─────────────────┬────────────────────┐+│        (index)         │           0           │           1           │            2            │          3          │        4        │         5          │

Added a statistics table and also added that selfsame info to the markdown and json outputs (updated in PR body)

codebytere

comment created time in 3 days

push eventcodebytere/node-core-utils

Shelley Vohr

commit sha 2e9e15409c7f7b3c4a001f2fae3cf5794b844be0

Add statistics to citgm output

view details

push time in 3 days

Pull request review commentnodejs/node-core-utils

feat: add ncu-ci cigtm <jobid>

 Notifying upstream projects of job completion Finished: SUCCESS ``` +### `ncu-ci citgm <jobid>`++`ncu-ci citgm <jobid>` shows the results of a given citgm-smoker job.++Example:+```+node on git:master ❯ ncu-ci citgm 2400                                         10:25AM+--------------------------------------------------------------------------------+[1/1] Running CITGM: 2400+--------------------------------------------------------------------------------+✔  Header data downloaded+✔  Report data downloaded+----------------------------------- Summary ------------------------------------+Result     FAILURE+URL        https://ci.nodejs.org/job/citgm-smoker/2400/testReport/+Source     https://github.com/nodejs/node/pull/34093/+Commit     [9ec07f42864c] 2020-06-30, Version 14.5.0 (Current)+Date       2020-06-29 21:17:56 -0700+Author     Shelley Vohr <shelley.vohr@gmail.com>+----------------------------------- Failures -----------------------------------+┌────────────────────────┬───────────────────────┬───────────────────────┬─────────────────────────┬─────────────────────┬─────────────────┬────────────────────┐+│        (index)         │           0           │           1           │            2            │          3          │        4        │         5          │

o great point! i grab those numbers so we can definitely print them out helpfully 🤔

codebytere

comment created time in 3 days

pull request commentelectron/electron

build: update to standard 14

Oh i assumed we swapped when you enabled semicolons - if that's not the case we should at least use the same rules in docs that we do in internal code

MarshallOfSound

comment created time in 3 days

pull request commentnodejs/node-core-utils

feat: add ncu-ci cigtm <jobid>

I'm planning on trying to cut a new release of ncu sometime soon and would love for this to make it in if one of y'all has time to PTAL :)

codebytere

comment created time in 3 days

pull request commentelectron/electron

docs: correct for extensions API deprecation

@railsjack there are a sizable number of review comments unaddressed here that need to be addressed in order for this PR to move forward

railsjack

comment created time in 3 days

PR opened electron/electron

Reviewers
feat: add visible-on-all-workspaces-changed event

Description of Change

Closes https://github.com/electron/electron/issues/24451.

At present, there is not a way to detect when the "visibleOnAllWorkspaces" property changes from outside the app, which are possible by e.g. toggling from the macOS dock. A developer could attempt to poll for changes, but that's somewhat unwieldy when we could instead add an event to more effectively notify developers of changes to this window property.

cc @zcbenz @miniak @deepak1556

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Added avisible-on-all-workspaces-changed event to poll for changes to window workspace visibility.

+34 -0

0 comment

9 changed files

pr created time in 3 days

create barnchelectron/electron

branch : visible-workspace-changed-event

created branch time in 3 days

issue closedelectron/electron

How to make disabled button in electron dialog

I would like to make a disabled button in electron dialog with countdown. And make button active once countdown finished.

So the questions are:

  • Is it possible to make a disabled button in electron dialog?
  • Is it possible to change button text dynamically in dialog?

I know that separate window can be created to represent dialog but I would really want to use operating systems native dialogs in single window process and don’t invoke ipc communication if possible.

Thanks!

closed time in 3 days

vasyl-shumskyi

issue commentelectron/electron

How to make disabled button in electron dialog

@vasyl-shumskyi it's not right now for either unfortunately - system dialogs by and large currently do not have that capability and in the interest of maintaining platform parity it's not something we'll likely do until it becomes possible on a majority of OSes

vasyl-shumskyi

comment created time in 3 days

issue commentelectron/electron

Printing hangs with pageSize Object

@TheSinding what does "won't work" mean in this context? are you seeing errors?

TheSinding

comment created time in 3 days

pull request commentelectron/electron

fix: check minimum micron size on print

@jkleinsc unfortunately we cannot, for a few reasons:

  • Printing infrastructure requires that a given system has a default printer configured, and without that will throw an error to that effect
  • Printing dialogs are process blocking, and so we don't test for successful dialog triggering elsewhere for the same reasons we can't currently test any other dialogs except in that they throw appropriately for bad user input

I tested locally on macOS to ensure that the dialog was appropriately triggered and can try to do so on my Linux machine as well, but i think this is the best we can do for now 😕

codebytere

comment created time in 3 days

push eventcodebytere/node-core-utils

Shelley Vohr

commit sha 489f15960b89e3dc11d5d9cd16ede54fcd4744e2

Fix markdown list formatting

view details

push time in 4 days

pull request commentelectron/electron

chore: bump chromium to 85.0.4183.19 (10-x-y)

Hit pause just so we can get this in tomorrow as we're ~2 weeks behind

electron-bot

comment created time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha 4645809a4d061b088960e00f001788a3a3c91a41

fix: check minimum micron size on print

view details

push time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha 79f7804c8bdde51b8eb7db7c8f89e966b7ee88d7

fix: check minimum micron size or print

view details

push time in 4 days

PR opened electron/electron

Reviewers
fix: check minimum micron size or print

Description of Change

Closes https://github.com/electron/electron/issues/24456.

The minimum micron size Chromium accepts is that where (per printing/units.h):

  • kMicronsPerInch - Length of an inch in 0.001mm unit.
  • kPointsPerInch - Length of an inch in CSS's 1pt unit.

Adhere to: (kPointsPerInch / kMicronsPerInch) * size >= 1

Practically, this means microns need to be > 352 microns.

We therefore need to verify this or it will silently fail with a logging error of:

[77469:0708/232856.127937:ERROR:print_view_manager_base.cc(71)] Invalid printer settings The selected printer is not available or not installed correctly. <br> Check your printer or try selecting another printer.

cc @zcbenz @jkleinsc @MarshallOfSound

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Fixed an issue where webContents.print() would sometimes hang with a custom pageSize.

+21 -6

0 comment

2 changed files

pr created time in 4 days

create barnchelectron/electron

branch : fix-printing-micron-problem

created branch time in 4 days

issue commentelectron/electron

Printing hangs with pageSize Object

@TheSinding i see the error - i'll try to get this patched up soon :)

TheSinding

comment created time in 4 days

pull request commentelectron/electron

doc: fix incorrect formatting in browser docs.

oops my bad, sam's right - accidentally dropped the s in my comment

samccone

comment created time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha eddd97c78d810f3116eabe29be664a1a94d407df

use PrintHostMsg_DidPreviewPage_Params https://chromium-review.googlesource.com/c/chromium/src/+/2257124

view details

push time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha 78fbbed48f7379129fe3b1a78968e63480e38a3b

use PrintHostMsg_DidPreviewPage_Params https://chromium-review.googlesource.com/c/chromium/src/+/2257124

view details

push time in 4 days

pull request commentelectron/electron

doc: fix incorrect formatting in browser documentation.

@samccone owing to a super recent commit the commit itself should be semantic - just change it to doc: fix incorrect formatting in browser documentation and we should be g2g

samccone

comment created time in 4 days

push eventnodejs/node

Derek Lewis

commit sha f1a810880e7c9c77c4f620402ae733788457ca67

doc: normalize C++ code block info strings Prior to this commit, C++ fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standarize on the one with the highest frequency in the doc/api/ dir. Stats: > 'cpp' => 19, > 'C++' => 6, > 'c++' => 3, PR-URL: https://github.com/nodejs/node/pull/33483 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Anna Henningsen

commit sha bfffb977ad2ab7aaf27c0b238513da9cbfed7343

benchmark: fix async-resource benchmark In the benchmark, because it performs asynchronous operations before writing its HTTP replies, the underlying socket can be closed by the peer before the response is written. Since 28e6626ce7020, that means that attempting to `.end()` the HTTP response results in an uncaught exception, breaking the benchmark. Fix that by checking whether the response object has been destroyed or not before attempting to call `.end()`. https://github.com/nodejs/node/issues/33591 PR-URL: https://github.com/nodejs/node/pull/33642 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

antsmartian

commit sha 62edaaefc25fb44ed4a959e42723256577e7871e

stream: fix the spellings PR-URL: https://github.com/nodejs/node/pull/33635 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 94ac13678d87db243ed7b93ea82f6572662a1155

doc: change "pre Node.js v0.10" to "prior to Node.js 0.10" The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: https://github.com/nodejs/node/pull/33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 27e797687f855aa1aba2e4b798b52bb2c742fc7f

doc: remove "currently" from util.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 36a8af7a5e3a234682a1c462ea2f17385664cf13

doc: remove "currently" from addons.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 7595d152865df642db81b27ebba5368aee7ce040

doc: remove "currently" from vm.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha b00996ce351325ac4a37c5104b0eea807aaadd22

doc: remove "currently" from repl.md PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 3b437416d5645e64d3b571a764dfb68917307dab

doc: add formatting for version numbers to doc-style-guide.md PR-URL: https://github.com/nodejs/node/pull/33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Pranshu Srivastava

commit sha d547d1c1bc636acc3953c422d57df837939a7e4e

doc: fix linting in doc-style-guide.md Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: https://github.com/nodejs/node/pull/33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

view details

push time in 4 days

push eventnodejs/node

cjihrig

commit sha 8adfb542eb035f3c567fda2c1bfc9aa66eedc454

wasi: allow WASI stdio to be configured This commit adds stdin, stderr, and stdout options to WASI, which allow the stdio streams to be configured. PR-URL: https://github.com/nodejs/node/pull/33544 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tom Nagle

commit sha 54166356772b2f4d352f7c190acae728a13df5c3

doc: improve buffer.md a tiny bit PR-URL: https://github.com/nodejs/node/pull/33547 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Gus Caplan

commit sha 0a949c3f93dd2567951dff5aee9f844927f3956e

napi: add __wasm32__ guards PR-URL: https://github.com/nodejs/node/pull/33597 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Daniel Bevenius

commit sha 99371ade2a5260966c27c146a1fac82385c92d66

src: use MaybeLocal.ToLocal instead of IsEmpty worker This commit suggest using MaybeLocal.ToLocal and passing in the Local<String> node_opts. It also introduces a variable, arg_v8, of type Local<String> to enable the use of ToLocal. The motivation for doing this is that the following MaybeLocal::ToLocalChecked and MaybeLocal::FromMaybe calls can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33599 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

sapics

commit sha 8dbf3349d0275ec8483dbb829c28c5f701652bbc

doc: fix urls to avoid redirection Replace redirected urls with the final ones. Replace http urls with https ones. PR-URL: https://github.com/nodejs/node/pull/33614 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Lucas Holmquist

commit sha c9cf41d841429a43d637655586ead3d619c2600b

fs: support util.promisify for fs.readv PR-URL: https://github.com/nodejs/node/pull/33590 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha e3beb781e02769131a67b28a3a871981463c4400

src: avoid OOB read in URL parser This is not a big concern, because right now, all (non-test) inputs to the parser are `'\0'`-terminated, but we should be future-proof here and not perform these OOB reads. PR-URL: https://github.com/nodejs/node/pull/33640 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Ben Noordhuis

commit sha eb8d6f5fd8ae7f3bccdba82ef4c2dad1828ac16f

src: simplify MaybeStackBuffer::capacity() PR-URL: https://github.com/nodejs/node/pull/33602 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Xu Meng

commit sha 0982bf423491a217ecba1ae645de7405fc219a67

test: uv_tty_init now returns EINVAL on IBM i Since the PR https://github.com/libuv/libuv/pull/2753 has been landed, we need to revert the code change in PR https://github.com/nodejs/node/pull/32338. PR-URL: https://github.com/nodejs/node/pull/33629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Ben Noordhuis

commit sha 5d3f818e9eb1a1bf333e55325d417fd199e1af15

dns: make dns.Resolver timeout configurable PR-URL: https://github.com/nodejs/node/pull/33472 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

cjihrig

commit sha 1376c3bab29c4d01b9c654f5ccb58d9b35dcf7ee

meta: wrap flaky test template at 80 characters The other issue templates are wrapped at 80 characters. This commit updates the flaky test template to be consistent. PR-URL: https://github.com/nodejs/node/pull/33677 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

cjihrig

commit sha f534ac06bde0f4452fd33cc24d7f62103535c0f2

meta: fix a typo in the flaky test template "occasionally" was spelled incorrectly. PR-URL: https://github.com/nodejs/node/pull/33677 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Sebastien Ahkrin

commit sha 69291e4b7d69bfb65611c8531f7892531b64be74

lib: add Int16Array primordials PR-URL: https://github.com/nodejs/node/pull/31205 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Richard Lau

commit sha 555ba61f227d3b0f97fb63cdd1ef64080036cf5b

build: fix compiling addons with older versions of Node.js `common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: https://github.com/nodejs/node/pull/33688 Refs: https://github.com/nodejs/node/pull/30463 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com>

view details

Rich Trott

commit sha d10fac73a3b26ba1012394f5e86cd63c2b4946d3

doc: add lint disabling comment for collaborator list Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: https://github.com/nodejs/remark-preset-lint-node/pull/96 Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33719 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Nick Schonning

commit sha 35cee03849aa843770036a341a9914d295e89288

doc: remove shell dollar signs without output Related to https://github.com/nodejs/remark-preset-lint-node/pull/94 PR-URL: https://github.com/nodejs/node/pull/33692 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Daniel Bevenius

commit sha 5b8cac8cf5a9821e6792b5eee6590cc29084d06b

src: remove unnecessary ToLocalChecked call PR-URL: https://github.com/nodejs/node/pull/33683 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Daniel Bevenius

commit sha 6f1d38cd8fed9b4a62f6d10c7fdbdf69033452d1

src: use ToLocal in SafeGetenv This commit replaces the IsEmpty call to use ToLocal instead which allows for the following ToLocalChecked function call to be avoided. PR-URL: https://github.com/nodejs/node/pull/33695 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Sagar Jadhav

commit sha d374e764282c7f8fd8c0fcdde1c4c9d36ff9fccf

test: changed function to arrow function Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: https://github.com/nodejs/node/pull/33711 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Rich Trott

commit sha 2f02fbac3ab835400ae17504e73fdb52d110257f

tools: update remark-preset-lint-node from 1.15.0 to 1.15.1 PR-URL: https://github.com/nodejs/node/pull/33727 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 4 days

PR opened electron/electron

Reviewers
fix: use default NSVisualEffectState enum case target/10-x-y target/8-x-y target/9-x-y

Description of Change

Closes https://github.com/electron/electron/issues/16417.

In Apple documentation NSVisualEffectState is an enum with three options detailign how the material appearance should reflect window activity state. We were previously using NSVisualEffectStateActive, meaning that the backdrop would always appear active. This breaks from the default as specified in the first link, which is NSVisualEffectStateFollowsWindowActiveState and means that the backdrop should automatically appear active when the window is active, and inactive when it is not. This thus changes our effect state to the more expected default.

cc @miniak @zcbenz @jkleinsc

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Fixed an issue where the effect state on macOS was not using the appropriate default for NSVisualEffectState.

+1 -1

0 comment

1 changed file

pr created time in 4 days

create barnchelectron/electron

branch : use-default-effect

created branch time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha baea5eab30d9d5415f60f4c6092f38f8c4a63ce8

use PrintHostMsg_DidPreviewPage_Params https://chromium-review.googlesource.com/c/chromium/src/+/2257124

view details

push time in 4 days

pull request commentnodejs/node

src: extract AllocatedBuffer from env.h

@jasnell should this go to v12.x? It looks like it'll need a manual backport if yes but if no just remove the label :)

jasnell

comment created time in 4 days

push eventnodejs/node

Gabriel Schulhof

commit sha ed741ecb1ed75a4305fa6d3f0c5cbcc3258b600b

n-api: remove `napi_env::CallIntoModuleThrow` Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: https://github.com/nodejs/node/pull/33570 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Pranshu Srivastava

commit sha a3b7e5992dba393cbf2e7cf5fc3e5630eb407fe4

http2: use `Object.create(null)` for `getHeaders` refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33188 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Richard Lau

commit sha 11dad02e503ebe72c96e059353bdc17ee3bea8a5

build: fix python-version selection with actions s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python Refs: https://github.com/nodejs/node/pull/32609 PR-URL: https://github.com/nodejs/node/pull/33589 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Shelley Vohr

commit sha 9c69296990b0df51499b7473d30c452d537bc1b9

src: don't use semicolon outside function PR-URL: https://github.com/nodejs/node/pull/33592 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Zeke Sikelianos

commit sha 7dc28ab4d3e27946112f145134f981f89b5ed186

doc: update ```txt ```fandamental and ```raw code blocks These are changed to either ```text or ```console. PR-URL: https://github.com/nodejs/node/pull/33028 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Pranshu Srivastava

commit sha 8def93429ee3759f613c815fbf9a2865d811221c

http2: add type checks for Http2ServerResponse.end Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33146 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Pranshu Srivastava

commit sha 0f0720a66556440473efa01d41ab18b57de4f609

http2: add writable* properties to compat api added writableHighWaterMark, writableLength, and writableFinished properties with test. Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33506 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Ruben Bridgewater

commit sha 76b06e53c6a54f10c500e0bb27f37ebc2ee28ec0

errors: fully inspect errors on exit This makes sure errors are fully inspected during exit. That is important to provide as many debugging information to the user as possible. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33523 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 80782cb2611d72d97fe5758e77df9fba17f52c83

console: remove dead code This check is always truthy. Thus, it's removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33524 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Ruben Bridgewater

commit sha d8365bc71e02b869b6da25b73f4e331132eb50be

console: mark special console properties as non-enumerable This makes sure internal console properties are not visible during default inspection. They are still visible when inspecting the console with `showHidden` set to `true`. These properties are confusing while working with the REPL and easily show up. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33524 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Ruben Bridgewater

commit sha a9c5b3348c5f64a9ca301b4cc7bef3733809c068

console: name console functions appropriately The current name of most of the global console functions is "bound consoleCall". This is changed to the actual functions name e.g., "log" or "error". Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33524 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Ruben Bridgewater

commit sha 543605782d6a269c8376bdae6f410dd1e43e97ff

doc: outline when origin is set to unhandledRejection The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: https://github.com/nodejs/node/issues/32907 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33530 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Derek Lewis

commit sha 4fcbfdc45c795937f3a50986ed1bc59d5c8dc739

doc: normalize JavaScript code block info strings Prior to this commit, JavaScript fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the one with the highest frequency in the doc/api/ dir. Stats: > 'js' => 1091, > 'javascript' => 2, PR-URL: https://github.com/nodejs/node/pull/33531 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Maciej Kacper Jagiełło

commit sha a5ce90c46b2563833456380d96d1b97dc69fa996

build: add --v8-lite-mode flag PR-URL: https://github.com/nodejs/node/pull/33541 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Derek Lewis

commit sha a3b6095db1e22df84256e5ee48aea7fd4c76b1f0

doc: normalize Markdown code block info strings Prior to this commit, Markdown fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the one shown in the CommonMark spec. Refs: https://github.com/commonmark/commonmark-spec/blob/1103710025f340702edcb070be41f9982b6544d5/spec.txt#L131 PR-URL: https://github.com/nodejs/node/pull/33542 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 4 days

pull request commentnodejs/node

tools: fix master branch build for Windows on Arm

@richard-townsend-arm this conflicts in a handful of places - could you please manually backport it to v12.x?

richard-townsend-arm

comment created time in 4 days

push eventnodejs/node

Derek Lewis

commit sha 74a1493441d2521cd05a9e7cb31efecb47ef5935

doc: normalize C code block info strings Prior to this commit, C fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the lowercase variant, which matches the others, is the typical file extension for C files, and is the CSS class used by highlight.js despite representing a minority of appearances in the doc/api/ dir. Stats: > 'C' => 181, > 'c' => 3, Refs: https://github.com/highlightjs/highlight.js/pull/2577 PR-URL: https://github.com/nodejs/node/pull/33507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Derek Lewis

commit sha 7ea6b07b901c1b6c14f64b8b45d86e10dadbced5

doc: normalize shell code block info strings Prior to this commit, shell fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standarize on the one with the highest frequency in the doc/api/ dir. Stats: > 'console' => 54, > 'shell' => 2, PR-URL: https://github.com/nodejs/node/pull/33486 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Ben Bucksch

commit sha 18dc03d6a5cbeaf58cafea4ca6b576cf1ebf5e97

crypto: fix wrong error message When calling `crypto.sign()`, if the `key` parameter object is missing the `key` property, the error message is wrong. Before the fix: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received an instance of Object Expected: TypeError [ERR_INVALID_ARG_TYPE]: The "key.key property" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined This seems like a copy&paste bug. Somebody copied from the end of the function, where this is correct, to here, where it's wrong. PR-URL: https://github.com/nodejs/node/pull/33482 Fixes: https://github.com/nodejs/node/issues/33480 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

view details

Derek Lewis

commit sha cf82adf87fa42ca9e05b748d5795850cb5c5964b

doc: normalize Bash code block info strings Prior to this commit, Bash fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the less-obscure variant. PR-URL: https://github.com/nodejs/node/pull/33510 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Thomas

commit sha bba41bf6e157cd2b39bd67081020c64c6ccab275

build: fix makefile script on windows On Windows there is a program "find.exe" located in C:\Windows\System32, which is usually in the PATH before MSYS version of that program (required for running makefile). The Windows version of the program uses different CLI syntax, which results in errors like "File not found - *node_modules*" This commit specifies the full path to the program, which is also properly handled by MSYS on Windows. PR-URL: https://github.com/nodejs/node/pull/33136 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

himself65

commit sha 05cbd8f6f2b795f621fe6f5c2cabe9cd365da685

src: use const in constant args.Length() PR-URL: https://github.com/nodejs/node/pull/33555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Robert Nagy

commit sha 3032f0f38de76a74dcede09b72a8dfe99d79ded3

test: make flaky test stricter Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: https://github.com/nodejs/node/issues/4066 PR-URL: https://github.com/nodejs/node/pull/33539 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha 103479a0c5ca6202e64b75adfbd47713cb023092

src: use MaybeLocal.ToLocal instead of IsEmpty This commit suggest using MaybeLocal.ToLocal and passing in the Local<Function> fn. The motivation for doing this is that the following MaybeLocal.ToLocalChecked call can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33554 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Richard Lau

commit sha 3d05e3d86162c73c72d019cea4f40c4350eb917b

tools: fix check-imports.py to match on word boundaries `check-imports.py` was missing some unused `using` statements as it was not matching on word boundaries (e.g. `MaybeLocal` was considered a use of `Local`). Fix that and add some unit tests (which required the script to be renamed to drop the `-` so it could be imported into the test script). PR-URL: https://github.com/nodejs/node/pull/33268 Refs: https://github.com/nodejs/node/issues/29226 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Ash Cripps

commit sha b7ea7be2a8f09d1898e0ae2607e16b334e7a4151

meta: add flaky test issue template Add a flaky test issue template to ensure that enough information is provided for investigation PR-URL: https://github.com/nodejs/node/pull/33500 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Daniel Bevenius

commit sha 41d879616fa7177eb9cb127afff56fe9a59b29d8

src: remove unused using declarations This commit removes the unused using declarations reported by lint-cpp. PR-URL: https://github.com/nodejs/node/pull/33268 Refs: https://github.com/nodejs/node/issues/29226 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

push time in 4 days

more