profile
viewpoint
Shelley Vohr codebytere ¯\_(°_o)_/¯ http://codebyte.re core eng @electron @nodejs, misc @tc39, organizer @queerjs. always learning. often caffeinated. speaks about things in places sometimes! 🏳️‍🌈

codebytere/codebytere.github.io 193

personal website

cjihrig/uvwasi 67

WASI syscall API built atop libuv

codebytere/dotify 32

command line dotfile installation and maintenance tool

codebytere/emoji-mashup-convert 11

Convert images from tweets into Slack-worthy emojis.

codebytere/electron-font-manager 9

Create native cross-platform font dialogs!

codebytere/git-fns 6

My personal collection of custom git functions.

codebytere/native-kde-file-open 3

open native file dialog on kde plasma desktop

codebytere/gist-audit-maker 2

track and update Node audit log gists

push eventcodebytere/node

Shelley Vohr

commit sha e39244e78007a7560a3c681d5dbbecc90a3e4934

repl: eager-evaluate input in parens

view details

push time in 5 minutes

push eventcodebytere/node

Shelley Vohr

commit sha 8098e49773c2efe40b57bdb0bbcdb8a4dbe0c8d5

repl: eager-evaluate input in parens

view details

push time in 36 minutes

issue commentnodejs/node

repl: respect util.inspect.defaultOptions

I can try to take a look at this soon :)

bnoordhuis

comment created time in 5 hours

delete branch electron/unreleased

delete branch : dependabot/npm_and_yarn/axios-0.18.1

delete time in 5 hours

push eventelectron/unreleased

dependabot[bot]

commit sha 2484d6b122b667802ea63bd91606f3bded5b9ad8

build(deps): bump axios from 0.18.0 to 0.18.1 (#18) Bumps [axios](https://github.com/axios/axios) from 0.18.0 to 0.18.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.18.1/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.18.0...v0.18.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 5 hours

PR merged electron/unreleased

build(deps): bump axios from 0.18.0 to 0.18.1 dependencies

Bumps axios from 0.18.0 to 0.18.1. <details> <summary>Release notes</summary>

Sourced from axios's releases.

v0.18.1

Security Fix:

  • Destroy stream on exceeding maxContentLength (fixes #1098) (#1485) - Gadzhi Gadzhiev </details> <details> <summary>Changelog</summary>

Sourced from axios's changelog.

0.18.1 (May 31, 2019)

Security Fix:

  • Destroy stream on exceeding maxContentLength (fixes #1098) (#1485) - Gadzhi Gadzhiev </details> <details> <summary>Commits</summary>
  • face016 Releasing 0.18.1
  • 0628763 Update Changelog for release (0.18.1)
  • dc9b29c adjust README to match IE support
  • 16326d5 Remove usages of isOldIE in tests
  • 5a4228b Remove IE10 launcher from karma config
  • 695b5f7 Remove isOldIE check in tests
  • e314ab0 Remove HTTP 1223 handling
  • 7efa822 Remove btoa polyfill tests
  • f3cdcc7 Delete btoa polyfill
  • efc0b58 Remove ie8/9 special CORS treatment and btoa polyfill
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+28 -33

0 comment

1 changed file

dependabot[bot]

pr closed time in 5 hours

push eventelectron/unreleased

Shelley Vohr

commit sha 9c781a345c7eb16dbfb5d91dded14221f9eda211

chore: lint updates

view details

push time in 5 hours

push eventelectron/unreleased

Shelley Vohr

commit sha 6472c25e53bdb25068e6fa8619437682d3d595c4

fix: validate supported branches in queries

view details

push time in 5 hours

push eventelectron/unreleased

Shelley Vohr

commit sha cb52542fd10f28fc9a5e0764951f4579355b033b

fix: validate supported branches in queries

view details

push time in 5 hours

push eventelectron/unreleased

Shelley Vohr

commit sha b5ea5d8341a87beb01184a4fac02e0185c7a96db

fix: validate supported branches in queries

view details

push time in 5 hours

Pull request review commentnodejs/node

src,lib: don't run bootstrapper in CreateEnvironment

 class EnvironmentTest : public EnvironmentTestFixture {   } }; -TEST_F(EnvironmentTest, PreExeuctionPreparation) {-  const v8::HandleScope handle_scope(isolate_);-  const Argv argv;-  Env env {handle_scope, argv};--  v8::Local<v8::Context> context = isolate_->GetCurrentContext();--  const char* run_script = "process.argv0";

@joyeecheung i do see that and would be interested in working on addressing that - would you be amenable to potentially addressing that use case in a follow up and merging this as-is?

codebytere

comment created time in 5 hours

Pull request review commentnodejs/node

repl: eager-evaluate input in parens

 async function tests(options) {      '\x1B[36m[Function: koo]\x1B[39m',      '\x1B[1G\x1B[0Jrepl > \x1B[8G'],     ['a', [1, 2], undefined],+    ["{ b: 1 }['b'] === 1", [2, 6], '\x1B[33mtrue\x1B[39m',

so - test the same logic twice, just once with whitespace at start and one without?

codebytere

comment created time in 6 hours

Pull request review commentnodejs/node

repl: eager-evaluate input in parens

 function REPLServer(prompt,     let awaitPromise = false;     const input = code; -    if (/^\s*{/.test(code) && /}\s*$/.test(code)) {-      // It's confusing for `{ a : 1 }` to be interpreted as a block-      // statement rather than an object literal.  So, we first try-      // to wrap it in parentheses, so that it will be interpreted as-      // an expression.  Note that if the above condition changes,-      // lib/internal/repl/utils.js needs to be changed to match.-      code = `(${code.trim()})\n`;+    // It's confusing for `{ a : 1 }` to be interpreted as a block+    // statement rather than an object literal.  So, we first try+    // to wrap it in parentheses, so that it will be interpreted as+    // an expression.  Note that if the above condition changes,+    // lib/internal/repl/utils.js needs to be changed to match.+    if (code.startsWith('{') && !code.endsWith(';')) {

@BridgeAR what do you mean here? the preview code has:

    // For similar reasons as `defaultEval`, wrap expressions starting with a
    // curly brace with parenthesis.
    if (input.startsWith('{') && !input.endsWith(';')) {
      input = `(${input})`;
    }

which is what i copied over to here 🤔

codebytere

comment created time in 6 hours

delete branch electron/electron

delete branch : trop/8-x-y-bp-fix-pass-safedialogs-preference-to-dialog-properly-1582649446098

delete time in 6 hours

push eventelectron/electron

trop[bot]

commit sha 232ca04edd5854f36368d9be5e43625549604ea7

fix: pass safeDialogs preference properly (#22377) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

view details

push time in 6 hours

PR merged electron/electron

fix: pass safeDialogs preference to dialog properly 8-x-y backport

Backport of #22353

See that PR for details.

Notes: Fixes an issue with safeDialog preferences not being passed properly.

+1 -0

0 comment

1 changed file

trop[bot]

pr closed time in 6 hours

delete branch electron/electron

delete branch : fix-safe-dialogs

delete time in 10 hours

push eventelectron/electron

Shelley Vohr

commit sha c4f272e28f3f92e3991776347e0035ea9e446870

fix: pass safeDialogs preference properly (#22353)

view details

push time in 10 hours

delete branch electron/electron

delete branch : fix-double-warn

delete time in 10 hours

push eventelectron/electron

Shelley Vohr

commit sha 79270e30a60814bd73c05f62499503e328896edf

fix: don't run environment bootstrapper (#22342)

view details

push time in 10 hours

issue closedelectron/electron

safeDialogs option is broken since 7.0.0 (up to 9.0.0-beta.2, at least)

Preflight Checklist

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 9.0.0-beta.2
    • 8.0.1
    • 7.1.13
    • 7.0.0
  • Operating System:
    • Linux xps 5.5.4-arch1-1 #1 SMP PREEMPT Sat, 15 Feb 2020 00:36:29 +0000 x86_64 GNU/Linux (Arch Linux current)
    • macOS 10.15.3
  • Last Known Working Electron version:
    • 6.1.8 -- fine, not affected

Expected Behavior

  • When safeDialogs option is used, I expect to see a "Prevent this app from creating additional dialogs" checkbox on all alerts after the first one, like it happened in Electron 6.1.8.
  • I expect safeDialogs option to do at least something.

Basically, how 6.x behaves.

Actual Behavior

  • That checkbox does not appear on second alert, or on any other subsequent alert (tried about 10).
  • There seems to no observable difference at all between turning that option on or off.

To Reproduce

const { BrowserWindow, app } = require('electron')
app.on('ready', () => {
  const window = new BrowserWindow({
    webPreferences: {
      //partition: 'memory',
      safeDialogs: true,
    }
  })
  window.webContents.loadURL('about:blank') // also could be e.g. https://example.com/
  window.webContents.on('did-finish-load', () => {
    window.webContents.executeJavaScript(`
      document.body.innerText = window.navigator.userAgent // (not required)
      alert(0)
      setTimeout(() => { alert(1) }, 100) // timeout for UA to be shown
    `)
  })
  window.show()
})

Screenshots

v6.1.8 (correct behavior)

Screenshot_20200223_221526

v7.0.0

Screenshot_20200223_222330

v7.1.13

Screenshot_20200223_221938

v8.0.1

Screenshot_20200223_222409

9.0.0-beta.2

Screenshot_20200223_222754

Additional Information

  • Documented here: https://www.electronjs.org/docs/api/browser-window#new-browserwindowoptions
  • This does not seem to be a duplicate of closed #17543, as this affects only versions starting from v7.0.0.
  • This does not seem to be a problem of specific configuration/url/scheme/whatever -- I was not able to make that option work on a recent Electron version with any attempted configuration.

closed time in 10 hours

ChALkeR

PR merged electron/electron

Reviewers
fix: pass safeDialogs preference to dialog properly target/7-1-x target/8-x-y target/9-x-y

Description of Change

Closes https://github.com/electron/electron/issues/22350.

The safeDialog value was not being properly set in the MessageBoxSettings struct. This fixes that.

cc @zcbenz @ckerr

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Fixes an issue with safeDialog preferences not being passed properly.

+1 -0

0 comment

1 changed file

codebytere

pr closed time in 10 hours

issue closedelectron/electron

'warn' event being handled twice

v5.0.10:

> process.emit('warning', new Error('warn'))
(node:55756) Error: warn

v6.1.3+:

> process.emit('warning', new Error('warn'))
(node:55797) Error: warn
(node:55797) Error: warn

I think we're running the setupWarningHandler (and probably other init code) twice during startup.

call sites:

Error: here
    at prepareMainThreadExecution (internal/bootstrap/pre_execution.js:11:11)
    at internal/bootstrap/environment.js:12:1
Error: here
    at prepareMainThreadExecution (internal/bootstrap/pre_execution.js:11:11)
    at internal/main/run_main_module.js:7:1

closed time in 10 hours

nornagon

PR merged electron/electron

Reviewers
fix: don't run environment bootstrapper target/8-x-y target/9-x-y

Description of Change

Closes https://github.com/electron/electron/issues/21907.

In https://github.com/nodejs/node/pull/26788 (v12.0.0), Node.js added a bootstrapper to CreateEnvironment, which would prepare the main thread for execution any time an embedder created a new environment. However, this caused an unfortunate doubling-up effect; Node.js also ran bootstrapping (called prepareMainThreadExecution) for all other execution paths (like the repl, the actual main module, eval, etc). This meant that we'd see weird stuff like

> process.emit('warning', new Error('warn'))
(node:55797) Error: warn
(node:55797) Error: warn

since both execution pathways (env and whatever the actual execution was) were being exercised. To fix this, we can just remove bootstrapping code from CreateEnvironment. This also saves us a bunch of workaround code on our end, like the unsafe env block we had to prevent strange behavior during debugger setup. An upstream PR is open for this against Node.js itself, linked at bottom.

cc @MarshallOfSound @zcbenz @nornagon

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Fixed an issue where some logging would double-print.

+79 -158

1 comment

14 changed files

codebytere

pr closed time in 10 hours

push eventcodebytere/node

Shelley Vohr

commit sha 0f14c550731d1f418764d33ee46712d97ffae469

src: move InternalCallbackScope to StartExecution

view details

push time in 11 hours

issue openedcouds/react-bulma-components

[TypeScript] - can't set Navbar.Item href attribute

The example used in the Storybook doesn't work:

Screen Shot 2020-02-24 at 8 07 46 PM

Happy to open a PR to fix this if i could get a pointer as to your preferred path forward :)

created time in a day

push eventelectron/electron

Sofia Nguy

commit sha cdc13919b2488e73b155b1a650df417f1ca138af

docs: Correct Electron 9 stable date (#22258)

view details

Shelley Vohr

commit sha a87e0f495d32b05a57fd24b66b196a05601d15d7

chore: remove libcc from release not generator (#22271)

view details

Electron Bot

commit sha 57943f4de39885d9b2dc2c251696636441505360

Bump v10.0.0-nightly.20200220

view details

Mark Lee

commit sha 2e6fff885d9a10e07613105973d28903ba53849e

docs: clean up protocol docs (#22262) * docs: clean up protocol docs * Fix capitalization

view details

Samuel Attard

commit sha e7b0a9ca8f937cb351c8205b8541b9fe2342e1b8

feat: add API for receiving logs from service workers (#20624) * feat: add API for receiving logs from service workers * feat: add new serviceWorkerContext APIs * chore: add missing #include's * refactor: rename serviceWorkerContext to serviceWorkers * chore: clean up based on review * chore: remove native_mate * chore: add tests for the service worker module * Update spec-main/api-service-workers-spec.ts Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org> * chore: fix linting * chore: handle renames Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>

view details

Electron Bot

commit sha 686f53c9da2ce56620efc9153e02562c8b6b8524

Bump v10.0.0-nightly.20200221

view details

Syed Umair

commit sha e965703e62de5693a0769226cdda12ef8477733e

fix: typo in crash reporter constructor (#22274)

view details

John Kleinschmidt

commit sha e0c0875d6fc104c799c06dde55b7b10430108f07

docs: update session.clearAuthCache (#22292) * docs: update session.clearAuthCache * Update specs to match doc change.

view details

Jeremy Apthorp

commit sha 8045152e592e115fafa578c09802956336a4cd99

fix: revert {Atom => Electron}Application rename (#22206)

view details

Jeremy Apthorp

commit sha a25d7fa440603020512222c54dd6862d37b02f63

fix: emit will-navigate for sandboxed contents (#22188)

view details

Shelley Vohr

commit sha 50009f66088739593ccea6f8cf1e0819203a310c

chore: allow custom node-spec-runner options (#22315)

view details

Electron Bot

commit sha f1fb5130404d41b012c4140b53618234b3df9168

Bump v10.0.0-nightly.20200222

view details

Electron Bot

commit sha 1502ecf9f71624cb1b2a63c5d169f01558469b7e

Bump v10.0.0-nightly.20200223

view details

Cheng Zhao

commit sha 41931aa5fa83e4b5cbb935e10ce67a5caea37ce0

fix: disable remote layer APIs in MAS build (#20965) * fix: add patch to disable remote layer APIs * fix: use --disable-gpu-memory-buffer-compositor-resources for MAS build

view details

Samuel Maddock

commit sha 68c6d53156f2d74fe936e8000d9937f03cc997f2

feat(extensions): add more properties to extension object (#22244)

view details

Samuel Maddock

commit sha 8cc0435d9c97a7db7feeacf01da0217ec6ffe6bb

fix(extensions): set lowest isolated world id (#22212) * fix(extensions): set lowest isolated world id * refactor: move world IDs into separate header file Several files are including electron_render_frame_observer.h just for the world IDs.

view details

Erick Zhao

commit sha 1848e3f6583dfc994283509ab0b2b38ba682a3dc

feat: Add OtherItemsProxy TouchBar item (#22270) * feat: Add OtherItemsProxy touchbar item * review!

view details

Samuel Attard

commit sha fd46bc653f97aa3e1659c14d279cf9b98b497359

chore: wrap process restart flag in renderer process reuse check (#22334)

view details

Samuel Attard

commit sha 360c1cad1b40676be43ecf353ff6afe7b178f22f

chore: do not override history methods when rendererprocessreuse is enabled (#22335)

view details

Electron Bot

commit sha f965b13d741559f2952c0bbdff9747816996cc99

chore: bump node to v12.16.1 (master) (#22168) * chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch https://github.com/nodejs/node/pull/30862 * Fixup InternalCallbackScope patch https://github.com/nodejs/node/pull/30236 * Fixup GN buildfiles patch https://github.com/nodejs/node/pull/30755 * Fixup low-level hooks patch https://github.com/nodejs/node/pull/30466 * Fixup globals require patch https://github.com/nodejs/node/pull/31643 * Fixup process stream patch https://github.com/nodejs/node/pull/30862 * Fixup js2c modification patch https://github.com/nodejs/node/pull/30755 * Fixup internal fs override patch https://github.com/nodejs/node/pull/30610 * Fixup context-aware warn patch https://github.com/nodejs/node/pull/30336 * Fixup Node.js with ltcg config https://github.com/nodejs/node/pull/29388 * Fixup oaepLabel patch https://github.com/nodejs/node/pull/30917 * Remove redundant ESM test patch https://github.com/nodejs/node/pull/30997 * Remove redundant cli flag patch https://github.com/nodejs/node/pull/30466 * Update filenames.json * Remove macro generation in GN build files https://github.com/nodejs/node/pull/30755 * Fix some compilation errors upstream * Add uvwasi to deps https://github.com/nodejs/node/pull/30258 * Fix BoringSSL incompatibilities * Fixup linked module patch https://github.com/nodejs/node/pull/30274 * Add missing sources to GN uv build https://github.com/libuv/libuv/pull/2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch https://github.com/nodejs/node/pull/30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly https://github.com/nodejs/node/pull/30025 * Disable new esm syntax specs https://github.com/nodejs/node/pull/30219 * Fixup v8 weakref hook spec https://github.com/nodejs/node/pull/29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on https://github.com/nodejs/node/pull/29777, and we don't override prepareStackTrace. * Disable new tls specs https://github.com/nodejs/node/pull/23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

view details

push time in a day

push eventcodebytere/node

Shelley Vohr

commit sha fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3

src: move InternalCallbackScope to StartExecution

view details

push time in a day

push eventelectron/electron

Shelley Vohr

commit sha 8a4b4a60c6a7ce17e8c3f2b6321781110c0ad0ea

fix: dont run environment bootstrapper

view details

Shelley Vohr

commit sha 7564a60a392d935fe1093a9b5f5cfc04dc04e4e3

Uncomment newly-enabled Node.js core specs

view details

push time in a day

push eventelectron/build-tools

Samuel Attard

commit sha 54216a892902c251e80ea987100d2f6a273792a7

fix: handle the configs folder not existing (#108)

view details

push time in a day

delete branch electron/build-tools

delete branch : no-config-handling

delete time in a day

issue closedelectron/build-tools

e show configs throw error if configs not exist

if i have not configs then command e show configs throw error: image

closed time in a day

rvo337

PR opened nodejs/node

src: move InternalCallbackScope to StartExecution

Refs https://github.com/nodejs/node/pull/30467.

As Electron embeds Node.js, we need to mimic NodeMainInstance::Run() as much as possible; however, the externally facing CallbackScope does not allow for skipping async hooks. As such, in order to embed properly without async hook issues we need to expose InternalCallbackScope via patch, which we would rather not do. This PR thus moves that callback scope into StartExecution so that we can decrease our patch surface and avoid having to handle something which should reasonably be handled upstream.

cc @addaleax

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+8 -13

0 comment

3 changed files

pr created time in a day

create barnchcodebytere/node

branch : move-cb-scope

created branch time in a day

push eventelectron/electron

Shelley Vohr

commit sha 02dff2e3a2731ff63a24db02eb06bb7a8e042858

Uncomment newly-enabled Node.js core specs

view details

push time in a day

PR opened nodejs/node

repl: eager-evaluate input in parens

Refs https://github.com/nodejs/node/issues/31820.

This PR updates repl evaluation to eagerly wrap all input in parentheses and adds a regression test using the example given in the above issue. I plan to open a follow-up PR to allow the preview to evaluate the code again unwrapped if the first attempt fails.

cc @BridgeAR @devsnek

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+15 -7

0 comment

2 changed files

pr created time in a day

push eventcodebytere/node

Shelley Vohr

commit sha 2bba06cdbc3f4478b8c99df96b8b10f9e4751d27

repl: eager-evaluate input in parens

view details

push time in a day

create barnchcodebytere/node

branch : fix-repl-eval-issue

created branch time in a day

push eventelectron/electron

Samuel Maddock

commit sha 8cc0435d9c97a7db7feeacf01da0217ec6ffe6bb

fix(extensions): set lowest isolated world id (#22212) * fix(extensions): set lowest isolated world id * refactor: move world IDs into separate header file Several files are including electron_render_frame_observer.h just for the world IDs.

view details

Erick Zhao

commit sha 1848e3f6583dfc994283509ab0b2b38ba682a3dc

feat: Add OtherItemsProxy TouchBar item (#22270) * feat: Add OtherItemsProxy touchbar item * review!

view details

Samuel Attard

commit sha fd46bc653f97aa3e1659c14d279cf9b98b497359

chore: wrap process restart flag in renderer process reuse check (#22334)

view details

Samuel Attard

commit sha 360c1cad1b40676be43ecf353ff6afe7b178f22f

chore: do not override history methods when rendererprocessreuse is enabled (#22335)

view details

Electron Bot

commit sha f965b13d741559f2952c0bbdff9747816996cc99

chore: bump node to v12.16.1 (master) (#22168) * chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch https://github.com/nodejs/node/pull/30862 * Fixup InternalCallbackScope patch https://github.com/nodejs/node/pull/30236 * Fixup GN buildfiles patch https://github.com/nodejs/node/pull/30755 * Fixup low-level hooks patch https://github.com/nodejs/node/pull/30466 * Fixup globals require patch https://github.com/nodejs/node/pull/31643 * Fixup process stream patch https://github.com/nodejs/node/pull/30862 * Fixup js2c modification patch https://github.com/nodejs/node/pull/30755 * Fixup internal fs override patch https://github.com/nodejs/node/pull/30610 * Fixup context-aware warn patch https://github.com/nodejs/node/pull/30336 * Fixup Node.js with ltcg config https://github.com/nodejs/node/pull/29388 * Fixup oaepLabel patch https://github.com/nodejs/node/pull/30917 * Remove redundant ESM test patch https://github.com/nodejs/node/pull/30997 * Remove redundant cli flag patch https://github.com/nodejs/node/pull/30466 * Update filenames.json * Remove macro generation in GN build files https://github.com/nodejs/node/pull/30755 * Fix some compilation errors upstream * Add uvwasi to deps https://github.com/nodejs/node/pull/30258 * Fix BoringSSL incompatibilities * Fixup linked module patch https://github.com/nodejs/node/pull/30274 * Add missing sources to GN uv build https://github.com/libuv/libuv/pull/2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch https://github.com/nodejs/node/pull/30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly https://github.com/nodejs/node/pull/30025 * Disable new esm syntax specs https://github.com/nodejs/node/pull/30219 * Fixup v8 weakref hook spec https://github.com/nodejs/node/pull/29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on https://github.com/nodejs/node/pull/29777, and we don't override prepareStackTrace. * Disable new tls specs https://github.com/nodejs/node/pull/23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

view details

Shelley Vohr

commit sha 13a8d3c242f79de8a3fed5e999bce997acf8714f

fix: dont run environment bootstrapper

view details

Shelley Vohr

commit sha b01ca9d1759d25e4fce405d8eb6f726e82535bbb

Uncomment newly-enabled Node.js core specs

view details

push time in a day

delete branch electron/electron

delete branch : robo/backport_seccomp_bpf_patch

delete time in a day

push eventelectron/electron

Robo

commit sha 4c61f621499f85cb728452d1484984f86f4dee9f

fix: crash in seccomp-bpf sandbox with glibc 2.31 (#22338)

view details

push time in a day

PR merged electron/electron

fix: crash in seccomp-bpf sandbox with glibc 2.31 7-1-x in-flight/6-1-x

Description of Change

Fixes https://github.com/electron/electron/issues/22291

Backports https://chromium-review.googlesource.com/c/chromium/src/+/1935715

Thanks @ChALkeR for the detailed report!

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: fix crash with seccomp-bpf sandbox on linux and glibc 2.31

+147 -0

1 comment

2 changed files

deepak1556

pr closed time in a day

delete branch electron/electron

delete branch : roller/node/master

delete time in a day

push eventelectron/electron

Electron Bot

commit sha f965b13d741559f2952c0bbdff9747816996cc99

chore: bump node to v12.16.1 (master) (#22168) * chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch https://github.com/nodejs/node/pull/30862 * Fixup InternalCallbackScope patch https://github.com/nodejs/node/pull/30236 * Fixup GN buildfiles patch https://github.com/nodejs/node/pull/30755 * Fixup low-level hooks patch https://github.com/nodejs/node/pull/30466 * Fixup globals require patch https://github.com/nodejs/node/pull/31643 * Fixup process stream patch https://github.com/nodejs/node/pull/30862 * Fixup js2c modification patch https://github.com/nodejs/node/pull/30755 * Fixup internal fs override patch https://github.com/nodejs/node/pull/30610 * Fixup context-aware warn patch https://github.com/nodejs/node/pull/30336 * Fixup Node.js with ltcg config https://github.com/nodejs/node/pull/29388 * Fixup oaepLabel patch https://github.com/nodejs/node/pull/30917 * Remove redundant ESM test patch https://github.com/nodejs/node/pull/30997 * Remove redundant cli flag patch https://github.com/nodejs/node/pull/30466 * Update filenames.json * Remove macro generation in GN build files https://github.com/nodejs/node/pull/30755 * Fix some compilation errors upstream * Add uvwasi to deps https://github.com/nodejs/node/pull/30258 * Fix BoringSSL incompatibilities * Fixup linked module patch https://github.com/nodejs/node/pull/30274 * Add missing sources to GN uv build https://github.com/libuv/libuv/pull/2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch https://github.com/nodejs/node/pull/30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly https://github.com/nodejs/node/pull/30025 * Disable new esm syntax specs https://github.com/nodejs/node/pull/30219 * Fixup v8 weakref hook spec https://github.com/nodejs/node/pull/29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on https://github.com/nodejs/node/pull/29777, and we don't override prepareStackTrace. * Disable new tls specs https://github.com/nodejs/node/pull/23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

view details

push time in a day

PR merged electron/electron

chore: bump node to v12.16.1 (master)

Updating Node.js to v12.16.0.

See all changes in v12.15.0..v12.16.0

<!-- Original-Version: v12.15.0 -->

Notes: Updated Node.js to v12.16.0.

+441 -269

1 comment

25 changed files

electron-bot

pr closed time in a day

push eventelectron/electron

Electron Bot

commit sha f1fb5130404d41b012c4140b53618234b3df9168

Bump v10.0.0-nightly.20200222

view details

Electron Bot

commit sha 1502ecf9f71624cb1b2a63c5d169f01558469b7e

Bump v10.0.0-nightly.20200223

view details

Cheng Zhao

commit sha 41931aa5fa83e4b5cbb935e10ce67a5caea37ce0

fix: disable remote layer APIs in MAS build (#20965) * fix: add patch to disable remote layer APIs * fix: use --disable-gpu-memory-buffer-compositor-resources for MAS build

view details

Samuel Maddock

commit sha 68c6d53156f2d74fe936e8000d9937f03cc997f2

feat(extensions): add more properties to extension object (#22244)

view details

Shelley Vohr

commit sha 55934e2fb9b1b39a1a1db933ae7c6270ef5f314c

fix: dont run environment bootstrapper

view details

Shelley Vohr

commit sha a1f5d70d8ed807735d41889d423d17157a14077d

Uncomment newly-enabled Node.js core specs

view details

push time in a day

pull request commentelectron/electron

chore: bump node to v12.16.1 (master)

@MarshallOfSound of the added patches:

fix_use_hex_not_decimal_for_clarity.patch
fix_use_crypto_impls_for_compat.patch
fix_ensure_clocks_header_included_in_impl.patch
fix_remove_implicit_type_conversions.patch
fix_include_io_h_in_uvwasi_for_win.patch
fix_--perf-prof_only_works_on_linux.patch
fix_we_need_to_eager-load_cjs_modules.patch

all except fix_we_need_to_eager-load_cjs_modules.patch have already been upstreamed and merged :)

electron-bot

comment created time in a day

pull request commentelectron/electron

fix: dont run environment bootstrapper

@nornagon oh good reminder - there are a few Node.js tests we had disabled that were actually commented out because of the undesirable behavior. I'll go re-add those and that should serve as a regression test!

codebytere

comment created time in a day

Pull request review commentnodejs/node

src,lib: don't run bootstrapper in CreateEnvironment

 class EnvironmentTest : public EnvironmentTestFixture {   } }; -TEST_F(EnvironmentTest, PreExeuctionPreparation) {-  const v8::HandleScope handle_scope(isolate_);-  const Argv argv;-  Env env {handle_scope, argv};--  v8::Local<v8::Context> context = isolate_->GetCurrentContext();--  const char* run_script = "process.argv0";

I'm not aware of anyone relying on this behavior, but I think I would be surprised to determine that anyone did. It seems to me that any points of divergence between CreateEnvironment exposed externally and CreateMainEnvironment used internally will create behavioral patterns we don't want, and since Electron seeks to mimic Node.js behavior when being run in ELECTRON_RUN_AS_NODE mode as much as possible i'd prefer to prevent them as much as possible.

I do understand the desire to avoid breaking the test; I'm curious though with regard to

Having control over when the pre-execution are run from C++ without writing require('internal/bootstrap/pre_execution') in JS themselves sounds useful to an embedder.

what use cases you see this solving? i'm happy to potentially rework this commit to keep environment but with regard to my earlier comment i personally believe we should avoid CreateEnvironment doing anything that CreateMainEnvironment doesn't also do.

codebytere

comment created time in a day

Pull request review commentelectron/electron

chore: bump node to v12.16.1 (master)

 int NodeMain(int argc, char* argv[]) {       versions.SetReadOnly(ELECTRON_PROJECT_NAME, ELECTRON_VERSION_STRING);     } -    node::LoadEnvironment(env);+    // TODO(codebytere): we should try to handle this upstream.+    {+      node::InternalCallbackScope callback_scope(+          env, v8::Local<v8::Object>(), {1, 0},+          node::InternalCallbackScope::kAllowEmptyResource |+              node::InternalCallbackScope::kSkipAsyncHooks);

I don't think we'll need this - i matched upstream and it looks like those externalities aren't a concern there.

electron-bot

comment created time in a day

Pull request review commentelectron/electron

chore: bump node to v12.16.1 (master)

 int NodeMain(int argc, char* argv[]) {       versions.SetReadOnly(ELECTRON_PROJECT_NAME, ELECTRON_VERSION_STRING);     } -    node::LoadEnvironment(env);+    // TODO(codebytere): we should try to handle this upstream.+    {+      node::InternalCallbackScope callback_scope(+          env, v8::Local<v8::Object>(), {1, 0},

This should match what is being run in node_main_instance; i confirmed this with Anna Henningsen :)

electron-bot

comment created time in a day

push eventelectron/electron

Shelley Vohr

commit sha 43e432417151ddaf9fedc69da679516e769b02bf

Disable new tls specs https://github.com/nodejs/node/pull/23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL.

view details

push time in a day

push eventelectron/electron

Electron Bot

commit sha f1fb5130404d41b012c4140b53618234b3df9168

Bump v10.0.0-nightly.20200222

view details

Electron Bot

commit sha 1502ecf9f71624cb1b2a63c5d169f01558469b7e

Bump v10.0.0-nightly.20200223

view details

Cheng Zhao

commit sha 41931aa5fa83e4b5cbb935e10ce67a5caea37ce0

fix: disable remote layer APIs in MAS build (#20965) * fix: add patch to disable remote layer APIs * fix: use --disable-gpu-memory-buffer-compositor-resources for MAS build

view details

Samuel Maddock

commit sha 68c6d53156f2d74fe936e8000d9937f03cc997f2

feat(extensions): add more properties to extension object (#22244)

view details

Electron Bot

commit sha 6a67d3852430635d857dfffb47f4f7eb4d336a4c

chore: bump node in DEPS to v12.16.0

view details

Shelley Vohr

commit sha 6acaac525e8b47d90f6d792b58b0ab009991ff3c

Fixup asar support setup patch https://github.com/nodejs/node/pull/30862

view details

Shelley Vohr

commit sha 01444e0c278685776c183b60bac282e8136bf69c

Fixup InternalCallbackScope patch https://github.com/nodejs/node/pull/30236

view details

Shelley Vohr

commit sha c5da4f08efa6dc1b45dd7dca39363d685a7260b9

Fixup GN buildfiles patch https://github.com/nodejs/node/pull/30755

view details

Shelley Vohr

commit sha 34ed5d7f3c675fd1a871794ff12096830572fd85

Fixup low-level hooks patch https://github.com/nodejs/node/pull/30466

view details

Shelley Vohr

commit sha 6e4222524dd13426ee6179ce7e8a808a1462833a

Fixup globals require patch https://github.com/nodejs/node/pull/31643

view details

Shelley Vohr

commit sha ddc191aebe94f739621806f0a253528dca3bb5b9

Fixup process stream patch https://github.com/nodejs/node/pull/30862

view details

Shelley Vohr

commit sha 8b6b7696053dc7578a3c8ea1e37683859388f849

Fixup js2c modification patch https://github.com/nodejs/node/pull/30755

view details

Shelley Vohr

commit sha 16f6e9442590205f44f87b4b50407e07c9bca1eb

Fixup internal fs override patch https://github.com/nodejs/node/pull/30610

view details

Shelley Vohr

commit sha 39ef174af1bb6936131170197d62b2833b68ffb8

Fixup context-aware warn patch https://github.com/nodejs/node/pull/30336

view details

Shelley Vohr

commit sha b726509abc8493676d74f535dd7ff03dbbb1a121

Fixup Node.js with ltcg config https://github.com/nodejs/node/pull/29388

view details

Shelley Vohr

commit sha 4b95d0e239ad2f14b0b05b485e871ea69c96cd1d

Fixup oaepLabel patch https://github.com/nodejs/node/pull/30917

view details

Shelley Vohr

commit sha 8d0166c5add7627ac6d8f8275d23acd3d2271b74

Remove redundant ESM test patch https://github.com/nodejs/node/pull/30997

view details

Shelley Vohr

commit sha 25d4d0d73717faa1c65afc200f126caa944a5400

Remove redundant cli flag patch https://github.com/nodejs/node/pull/30466

view details

Shelley Vohr

commit sha 55930790333deb86905b81c831fdd9bab11c28d7

Update filenames.json

view details

Shelley Vohr

commit sha 1eff31e999d7ba04a08edec277433c789ae66d8d

Remove macro generation in GN build files https://github.com/nodejs/node/pull/30755

view details

push time in a day

issue commentelectron/electron

Not able to login to youtube account within webview or BrowserWindow

What other settings do you have on your computer? I just created a new account and was able to log in no problem with your repro.

circleapps

comment created time in a day

push eventelectron/build-tools

Samuel Attard

commit sha 1c74cfbf5d6ae6da0c1801b48db823f08f0a96ab

fix: gn args file uses platform specific line endings (#111)

view details

push time in a day

delete branch electron/build-tools

delete branch : gn-line-endings-win

delete time in a day

issue closedelectron/build-tools

e build always regenerates with gn gen on windows

I think there's a line-endings issue with the comparison we do

closed time in a day

MarshallOfSound

push eventelectron/electron

Shelley Vohr

commit sha e43d713865e44ed9924f978b83beb763ec58025e

Fix async context timer issue

view details

push time in 2 days

push eventelectron/electron

Shelley Vohr

commit sha 76abe85e95e34261a52955d9468b21c7be7aa2ba

Fix async context timer issue

view details

push time in 2 days

delete branch electron/electron

delete branch : dont-gc-custom-tray-popup-menu

delete time in 2 days

delete branch electron/electron

delete branch : actual-out-dir-customization

delete time in 2 days

delete branch electron/electron

delete branch : fix-cb-checked-win

delete time in 2 days

delete branch electron/electron

delete branch : fix-master-release-build

delete time in 2 days

delete branch electron/electron

delete branch : test-v8-ptr-compression

delete time in 2 days

delete branch electron/electron

delete branch : match-node-run-main

delete time in 2 days

push eventelectron/electron

Shelley Vohr

commit sha a0ea9e6cc272bd0d9e6c85abd77533a771ed1146

Fix async context timer issue

view details

push time in 2 days

create barnchelectron/electron

branch : match-node-run-main

created branch time in 2 days

PR opened electron/electron

Reviewers
fix: pass safeDialogs preference to dialog properly target/7-1-x target/8-x-y target/9-x-y

Description of Change

Closes https://github.com/electron/electron/issues/22350.

The safeDialog value was not being properly set in the MessageBoxSettings struct. This fixes that.

cc @zcbenz @ckerr

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: Fixes an issue with safeDialog preferences not being passed properly.

+1 -0

0 comment

1 changed file

pr created time in 2 days

push eventelectron/electron

Shelley Vohr

commit sha dd61acabc56aba5919af9cb7e2caf9892260da68

fix: pass safeDialogs preference properly

view details

push time in 2 days

create barnchelectron/electron

branch : fix-safe-dialogs

created branch time in 2 days

create barnchelectron/electron

branch : null-check-windows

created branch time in 2 days

push eventcodebytere/node

Myles Borins

commit sha 43fb664701d771c00595fa1c152cfca03b10a4fd

doc: fix missing changelog corrections There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch. PR-URL: https://github.com/nodejs/node/pull/31854 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Shelley Vohr

commit sha 31290824de068eb4b282ab74829450b988ae225b

doc: fix notable changes for v13.9.0 PR-URL: https://github.com/nodejs/node/pull/31857 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Robert Nagy

commit sha 7c524fb092b143470795c8ca869de4654c728fe1

doc: fix Writable.write callback description Clarifies a userland invariant until a better solution can be found. Also moves a misplaced sentence from _write to write. Refs: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/node/pull/31765 PR-URL: https://github.com/nodejs/node/pull/31812 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 822101f570478ffa15e4ed0e00cd0d67b9cc789e

meta: move eljefedelrodeodeljefe to emeritus eljefedelrodeodeljefe confirmed in email that moving to emeritus was fine at this time. PR-URL: https://github.com/nodejs/node/pull/31735 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Joyee Cheung

commit sha e6c2277241e542cdf86475d71c5fdc581bd72025

vm: lazily initialize primordials for vm contexts Lazily initialize primordials when cross-context support for builtins is needed to fix the performance regression in context creation. PR-URL: https://github.com/nodejs/node/pull/31738 Fixes: https://github.com/nodejs/node/issues/29842 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Gus Caplan

commit sha b8e41774d4287d128a40f7ecfecf170fe16fe9ed

fs: add fs/promises alias module PR-URL: https://github.com/nodejs/node/pull/31553 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>

view details

Harshitha KP

commit sha 2d3717ad847665de333c85e5239ad4e6a4c0eb95

worker: emit runtime error on loop creation failure Instead of hard asserting throw a runtime error, that is more consumable. Fixes: https://github.com/nodejs/node/issues/31614 PR-URL: https://github.com/nodejs/node/pull/31621 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 1c4e984ed970612f129db2ba6f684311418ed3a2

test: remove common.PORT from test-net-write-callbacks.js Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Rich Trott

commit sha cdac18519fd14df9ece958cf8e29b846f512656e

test: remove flaky designation for test-net-connect-options-port Closes: https://github.com/nodejs/node/issues/23207 PR-URL: https://github.com/nodejs/node/pull/31841 Fixes: https://github.com/nodejs/node/issues/23207 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 82afd85a31ab7c8f931f0bb0b23e76570aceb46d

tools: update lint-md task to lint for possessives of Node.js Add a markdown lint rule to prohibit "Node.js'" and "Node.js's". Instead, of "Node.js' module system", use "the Node.js module system". Refs: https://github.com/nodejs/node/pull/31748#issuecomment-585087745 PR-URL: https://github.com/nodejs/node/pull/31862 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Shelley Vohr

commit sha ae41049a760d55b5dcc20e137a7454e7c70415c4

doc: add note about ssh key to releases PR-URL: https://github.com/nodejs/node/pull/31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Michaël Zasso

commit sha cf0096104752607c7374a7f7297139e60b03c59d

tools: sync gyp code base with node-gyp repo PR-URL: https://github.com/nodejs/node/pull/30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 2f97e973ff540d2ae7de77482c631c06cc99c313

meta: move julianduque to emeritus julianduque confirmed in email that they can be moved to emeritus. PR-URL: https://github.com/nodejs/node/pull/31863 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Vse Mozhet Byt

commit sha 2f23918ca5090417ad0e06be6ecce63553f17985

doc: update stream.pipeline() signature The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: https://github.com/nodejs/node/pull/31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Robert Nagy

commit sha 21bd6679ce150e193cacd4b1b6585928224f255a

stream: fix finished typo https://github.com/nodejs/node/pull/31509 introduced a slight typo. Fortunately this typo does not have big impact due to `isWritableFinished()`. Fixes: https://github.com/nodejs/node/pull/31509#discussion_r381809355 PR-URL: https://github.com/nodejs/node/pull/31881 Fixes: https://github.com/nodejs/node/issues/31509 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Tobias Nießen

commit sha 0e63a079e8f535e1d4f0398400c534b0b5772fa5

crypto: fix ieee-p1363 for createVerify Fixes: https://github.com/nodejs/node/issues/31866 PR-URL: https://github.com/nodejs/node/pull/31876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tobias Nießen

commit sha fa1fc6bf9f257f7365454dc7a28bb4cd4385919f

doc: fix anchor for ERR_TLS_INVALID_CONTEXT PR-URL: https://github.com/nodejs/node/pull/31915 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

simon

commit sha 341c06f0889e5295d7a7a34c3e38296bd2c4ac18

tls: expose SSL_export_keying_material Fixes: https://github.com/nodejs/node/issues/31802 PR-URL: https://github.com/nodejs/node/pull/31814 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ben Noordhuis

commit sha 793cfe54cd26e0eb881eec895df41da62a3049ed

doc,crypto: re-document oaepLabel option Erroneously removed in https://github.com/nodejs/node/pull/29516. Fixes: https://github.com/nodejs/node/issues/31810 Refs: https://github.com/nodejs/node/pull/29516 PR-URL: https://github.com/nodejs/node/pull/31825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 97c8abe2c0df261aacadd5abd9cabfbeef2d5d61

test: remove common.PORT from assorted pummel tests Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: https://github.com/nodejs/node/pull/31897 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

push time in 2 days

push eventnodejs/node

Shelley Vohr

commit sha 72b6cea25d4e43b2db63eeb32417088c5bd93307

cli: --perf-prof only works on Linux PR-URL: https://github.com/nodejs/node/pull/31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

push time in 2 days

delete branch codebytere/node

delete branch : perf-prof-linux

delete time in 2 days

PR closed nodejs/node

Reviewers
cli: --perf-prof only works on Linux

--perf-prof-related flags have been removed in V8 on non-linux devices, and so we should note that in testing here as well as in docs.

See:

  • https://chromium-review.googlesource.com/c/v8/v8/+/1993969
  • https://chromium-review.googlesource.com/c/v8/v8/+/1993978

This broke in Electron, which is how i discovered it.

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+8 -6

7 comments

2 changed files

codebytere

pr closed time in 2 days

pull request commentnodejs/node

cli: --perf-prof only works on Linux

Landed in 72b6cea

codebytere

comment created time in 2 days

push eventelectron/build-tools

Samuel Attard

commit sha ad1a90b11a949876c375541cf7df49e5f41df524

docs: powershell kinda does not work (#100)

view details

push time in 4 days

delete branch electron/build-tools

delete branch : MarshallOfSound-patch-1

delete time in 4 days

issue closedelectron/electron

electron app market suggestion

Hello, Electron Team, My suggestion about electron app market.

  1. https://www.electronjs.org/apps each app is too big. every one download electronjs.exe time by times
  2. electron would change app market into chrome extensions mode https://chrome.google.com/webstore, everyone download one electronjs, they just download app.asar or use npm install packets then download pure app.asar, then user goto electron://apps to start apps

closed time in 4 days

9k01

pull request commentnodejs/node

src,lib: don't run bootstrapper in CreateEnvironment

@gireeshpunathil: https://github.com/nodejs/node/blob/84b8857098b2a846855bb2420f3a1144ef68cce3/src/node.cc#L404-L448

codebytere

comment created time in 4 days

PR opened nodejs/node

Reviewers
src,lib: don't run bootstrapper in CreateEnvironment

Refs https://github.com/electron/electron/pull/22342.

In https://github.com/nodejs/node/pull/26788 (v12.0.0) added a call to prepareMainThreadExecution to CreateEnvironment, which would prepare the main thread for execution any time an embedder created a new environment. However, this caused an unfortunate doubling-up effect, and meant that Electron would see stuff like:

> process.emit('warning', new Error('warn'))
(node:55797) Error: warn
(node:55797) Error: warn

Since both execution pathways (env and whatever the actual execution was) were being exercised. To fix this, I believe we should remove bootstrapping code from CreateEnvironment.

cc @joyeecheung @addaleax

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -54

0 comment

5 changed files

pr created time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha 31fe815f8fc7c8a76c24afe163cced10be69516d

fix: dont run environment bootstrapper

view details

push time in 4 days

create barnchcodebytere/node

branch : createenv-remove-some=bootstrap

created branch time in 4 days

PR opened electron/electron

fix: dont run environment bootstrapper

Description of Change

Closes https://github.com/electron/electron/issues/21907.

In https://github.com/nodejs/node/pull/26788 (v12.0.0), Node.js added a bootstrapper to CreateEnvironment, which would prepare the main thread for execution any time an embedder created a new environment. However, this caused an unfortunate doubling-up effect; Node.js also ran bootstrapping (called prepareMainThreadExecution) for all other execution paths (like the repl, the actual main module, eval, etc). This meant that we'd see weird stuff like:

> process.emit('warning', new Error('warn'))
(node:55797) Error: warn
(node:55797) Error: warn

Since both execution pathways (env and whatever the actual execution was) were being exercised. To fix this, we can just remove bootstrapping code from CreateEnvironment. This also saves us a bunch of workaround code on our end, like the unsafe env block we had to prevent strange behavior during debugger setup. I plan to upstream this to Node.js.

cc @MarshallOfSound @zcbenz

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: <!-- Please add a one-line description for app developers to read in the release notes, or no-notes if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/master/README.md#examples -->

+82 -140

0 comment

14 changed files

pr created time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha c33e8c42697e32d1b29ee7888eae09c0e43a2414

fix: dont run environment bootstrapper

view details

push time in 4 days

create barnchelectron/electron

branch : fix-double-warn

created branch time in 4 days

push eventelectron/electron

John Kleinschmidt

commit sha e0c0875d6fc104c799c06dde55b7b10430108f07

docs: update session.clearAuthCache (#22292) * docs: update session.clearAuthCache * Update specs to match doc change.

view details

Jeremy Apthorp

commit sha 8045152e592e115fafa578c09802956336a4cd99

fix: revert {Atom => Electron}Application rename (#22206)

view details

Jeremy Apthorp

commit sha a25d7fa440603020512222c54dd6862d37b02f63

fix: emit will-navigate for sandboxed contents (#22188)

view details

Shelley Vohr

commit sha 50009f66088739593ccea6f8cf1e0819203a310c

chore: allow custom node-spec-runner options (#22315)

view details

Electron Bot

commit sha 018737bf71c52a8f596b0e658b863dece6daa65a

chore: bump node in DEPS to v12.16.0

view details

Shelley Vohr

commit sha 797e0e93fabf1deca7ed334d29ec660234029c63

Fixup asar support setup patch https://github.com/nodejs/node/pull/30862

view details

Shelley Vohr

commit sha e1469efb4a1023c4846ccc51c29e220bcc87c5ff

Fixup InternalCallbackScope patch https://github.com/nodejs/node/pull/30236

view details

Shelley Vohr

commit sha 459cbee7b9fad3e6ed6dd5bc5eff677564ff4a03

Fixup GN buildfiles patch https://github.com/nodejs/node/pull/30755

view details

Shelley Vohr

commit sha ebbf2d994c366d524e72e4aea5e24c99ca565d6f

Fixup low-level hooks patch https://github.com/nodejs/node/pull/30466

view details

Shelley Vohr

commit sha f62209b5255d7a2cb1b818e9ab6e067b7f95ddd9

Fixup globals require patch https://github.com/nodejs/node/pull/31643

view details

Shelley Vohr

commit sha 0b5cd8b817dd5e59bda2735ca0816a68e575f6ca

Fixup process stream patch https://github.com/nodejs/node/pull/30862

view details

Shelley Vohr

commit sha c43790b1664ad25f09288635190988e6dd4bcb47

Fixup js2c modification patch https://github.com/nodejs/node/pull/30755

view details

Shelley Vohr

commit sha 1507e67855b6ab81476b161ebf4fb8fbed188b02

Fixup internal fs override patch https://github.com/nodejs/node/pull/30610

view details

Shelley Vohr

commit sha a07228e1da147c6797ecae9b905e970d3fb6565a

Fixup context-aware warn patch https://github.com/nodejs/node/pull/30336

view details

Shelley Vohr

commit sha 8299d10ec1342c6ebf1f2fc26fcd8cb899a1e244

Fixup Node.js with ltcg config https://github.com/nodejs/node/pull/29388

view details

Shelley Vohr

commit sha a49defff5a966a4d6626fa6c256fa775070edf9c

Fixup oaepLabel patch https://github.com/nodejs/node/pull/30917

view details

Shelley Vohr

commit sha a257a891371840c63397d937486a1f26cf873fe0

Remove redundant ESM test patch https://github.com/nodejs/node/pull/30997

view details

Shelley Vohr

commit sha 9d7a0f3949657c37e1b1db5b30b3cf3ed2e6e038

Remove redundant cli flag patch https://github.com/nodejs/node/pull/30466

view details

Shelley Vohr

commit sha 7812039a7cf77f4a5ddb69c938094cc35c466346

Update filenames.json

view details

Shelley Vohr

commit sha c976dca32d93ca563ff76edf4214debe30f20b82

Remove macro generation in GN build files https://github.com/nodejs/node/pull/30755

view details

push time in 4 days

delete branch electron/electron

delete branch : customize-node-spec-runner

delete time in 4 days

pull request commentelectron/electron

build: allow custom node-spec-runner options

/trop run backport-to 9-x-y,8-x-y

codebytere

comment created time in 4 days

push eventelectron/electron

Shelley Vohr

commit sha 50009f66088739593ccea6f8cf1e0819203a310c

chore: allow custom node-spec-runner options (#22315)

view details

push time in 4 days

PR merged electron/electron

Reviewers
build: allow custom node-spec-runner options

Description of Change

Allow passing custom options to node-spec-runner. Right now the alternative is just to run:

$ e node [options]

but the issue with that is that it doesn't allow for handling tests that pattern-match to stdout redirects. This allows for use of Node.js's actual spec runner in a less painful way from the Electron dir by allowing the user to pass any number of arguments recognized by Node.js' test runner.

Local testing of failing Node.js tests then becomes much nicer:

$ node script/node-spec-runner.js --verbose test/message/throw_undefined_traced.js

cc @MarshallOfSound

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Release Notes

Notes: none

+43 -4

0 comment

2 changed files

codebytere

pr closed time in 4 days

delete branch electron/electron

delete branch : trop/9-x-y-bp-fix-typo-in-crash-reporter-constructor-1582302778345

delete time in 4 days

push eventelectron/electron

trop[bot]

commit sha 1f3c3eee8313ad814eb1e04950ed3d2976c0ca91

fix: typo in crash reporter constructor (#22322)

view details

push time in 4 days

PR merged electron/electron

fix: typo in crash reporter constructor 9-x-y backport

Backport of #22274

See that PR for details.

Notes: Fixes an issue where TypeError occurred on initializing CrashReporter

+1 -1

0 comment

1 changed file

trop[bot]

pr closed time in 4 days

Pull request review commentelectron/electron

chore: bump node to v12.16.1 (master)

+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001+From: Shelley Vohr <shelley.vohr@gmail.com>+Date: Wed, 12 Feb 2020 15:08:04 -0800+Subject: fix: use crypto impls for compat++BoringSSL does not export DSA_get0_q, ECDSA_SIG_get0_r, or ECDSA_SIG_get0_s. This+patch works around that problem by using the implementations of those functions as+found in the OpenSSL repo. I plan to upstream a version of this.++diff --git a/src/node_crypto.cc b/src/node_crypto.cc+index 41b72d010824234c567586524d22cae6ac849edb..b2403821bb3cab4aa4587fcb757eeb101c8a7e03 100644+--- a/src/node_crypto.cc++++ b/src/node_crypto.cc+@@ -5027,7 +5027,7 @@ static unsigned int GetBytesOfRS(const ManagedEVPPKey& pkey) {+   if (base_id == EVP_PKEY_DSA) {+     DSA* dsa_key = EVP_PKEY_get0_DSA(pkey.get());+     // Both r and s are computed mod q, so their width is limited by that of q.+-    bits = BN_num_bits(DSA_get0_q(dsa_key));++    bits = BN_num_bits(dsa_key->q);

this has been upstreamed and merged 😸

electron-bot

comment created time in 4 days

push eventelectron/electron

Sofia Nguy

commit sha cdc13919b2488e73b155b1a650df417f1ca138af

docs: Correct Electron 9 stable date (#22258)

view details

Shelley Vohr

commit sha a87e0f495d32b05a57fd24b66b196a05601d15d7

chore: remove libcc from release not generator (#22271)

view details

Electron Bot

commit sha 57943f4de39885d9b2dc2c251696636441505360

Bump v10.0.0-nightly.20200220

view details

Mark Lee

commit sha 2e6fff885d9a10e07613105973d28903ba53849e

docs: clean up protocol docs (#22262) * docs: clean up protocol docs * Fix capitalization

view details

Samuel Attard

commit sha e7b0a9ca8f937cb351c8205b8541b9fe2342e1b8

feat: add API for receiving logs from service workers (#20624) * feat: add API for receiving logs from service workers * feat: add new serviceWorkerContext APIs * chore: add missing #include's * refactor: rename serviceWorkerContext to serviceWorkers * chore: clean up based on review * chore: remove native_mate * chore: add tests for the service worker module * Update spec-main/api-service-workers-spec.ts Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org> * chore: fix linting * chore: handle renames Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>

view details

Electron Bot

commit sha 686f53c9da2ce56620efc9153e02562c8b6b8524

Bump v10.0.0-nightly.20200221

view details

Syed Umair

commit sha e965703e62de5693a0769226cdda12ef8477733e

fix: typo in crash reporter constructor (#22274)

view details

Electron Bot

commit sha 7f75f360834c57c8bf93ea3c6e27f539652f898a

chore: bump node in DEPS to v12.16.0

view details

Shelley Vohr

commit sha 55bb7782ec46e365c331730c83a9318ae88562a8

Fixup asar support setup patch https://github.com/nodejs/node/pull/30862

view details

Shelley Vohr

commit sha 7b524b78c6c9ab87fd4feab63aeb2d6a618aa99a

Fixup InternalCallbackScope patch https://github.com/nodejs/node/pull/30236

view details

Shelley Vohr

commit sha d24cf8ba38e7ebc48f8139a06fdbdfb90c9205b8

Fixup GN buildfiles patch https://github.com/nodejs/node/pull/30755

view details

Shelley Vohr

commit sha 8baac43306dfe849d67c807cf548199b98aef29d

Fixup low-level hooks patch https://github.com/nodejs/node/pull/30466

view details

Shelley Vohr

commit sha 6c880650cd8308ae3696f9bab8971db0911843c2

Fixup globals require patch https://github.com/nodejs/node/pull/31643

view details

Shelley Vohr

commit sha 8ed6a715914a47fb1565c4ee9556de36b4b430bb

Fixup process stream patch https://github.com/nodejs/node/pull/30862

view details

Shelley Vohr

commit sha 10bd3eb6cb7db56530dcd5800c3f67ae391164d6

Fixup js2c modification patch https://github.com/nodejs/node/pull/30755

view details

Shelley Vohr

commit sha 9ff4bd60c779dfb72939ad77aebed877acef357a

Fixup internal fs override patch https://github.com/nodejs/node/pull/30610

view details

Shelley Vohr

commit sha b54a5fd61700de796c341c3101e78b1506d01190

Fixup context-aware warn patch https://github.com/nodejs/node/pull/30336

view details

Shelley Vohr

commit sha 0078ca352f28a824b1ebdc09708bf7e3c248203e

Fixup Node.js with ltcg config https://github.com/nodejs/node/pull/29388

view details

Shelley Vohr

commit sha f80adbd70020d6ef8346cc6d5f09a9e10cf1f336

Fixup oaepLabel patch https://github.com/nodejs/node/pull/30917

view details

Shelley Vohr

commit sha 7535cdbbc5712510aa291ac359962b7b12949038

Remove redundant ESM test patch https://github.com/nodejs/node/pull/30997

view details

push time in 4 days

more