profile
viewpoint

donmccurdy/aframe-inspector-plugin-recast 29

A-Frame Inspector plugin for creating navigation meshes.

InfiniteLee/ammo-debug-drawer 19

A three.js implementation of the btIDebugDraw interface in ammo.js

InfiniteLee/buffered-interpolation 10

A class for interpolation of position, rotation, and scale for networked THREE.js objects.

InfiniteLee/cannonjs_playground 1

testing for various cannon.js things

InfiniteLee/aframe 0

:a: web framework for building virtual reality experiences.

InfiniteLee/aframe-physics-extras 0

🔧Cannon API interface components the A-Frame Physics System

InfiniteLee/aframe-physics-system 0

Physics system for A-Frame VR, built on CANNON.js.

InfiniteLee/aframe-super-hands-component 0

👐All-in-one natural hand controller, pointer, and gaze interaction library for A-Frame

InfiniteLee/ammo.js 0

Direct port of the Bullet physics engine to JavaScript using Emscripten

PullRequestReviewEvent

push eventInfiniteLee/three-ammo

Kevin Lee

commit sha a3976a4f66f484ce7eb283ea34a1ffde241ceebb

additional dead code removal

view details

push time in a month

PR opened InfiniteLee/three-ammo

Update order of events in worker tick

Process the messageQueue first, then step the world.

Also some minor cleanup of dead code.

+6 -11

0 comment

2 changed files

pr created time in a month

create barnchInfiniteLee/three-ammo

branch : feature/tick-order

created branch time in a month

MemberEvent

push eventmozilla/hubs

Kevin Lee

commit sha af4fe4f2d56347b109cbc88cb323fac2ccc79246

refactor drawing code to use triangles instead of triangle strips

view details

Kevin Lee

commit sha f8a931259527e6ded757fa2a8cbd1fec5a136118

move deserialize button to the left

view details

Kevin Lee

commit sha 189b2b53ba8db997e34334d903a80f86181581b4

fix minor bug w/ reserializing drawings when a drawing already exists

view details

Kevin Lee

commit sha 27c9155c9dc5b616a20ff202d475e046d681ed4d

fix line removal

view details

Kevin Lee

commit sha f582e0d3dbcc28cdf6936aef810168724fa4a402

revert maxDrawTimeout

view details

Kevin Lee

commit sha 81c086ff455fb514b647f895774b6951379f4449

use indexes

view details

Kevin Lee

commit sha 750f7f1569e5d517d91fff715f4fbf052af1353e

Merge branch 'master' of github.com:mozilla/hubs into feature/drawing-triangles-refactor

view details

Kevin Lee

commit sha f42153e2bb342774564ef3b77ec6b5f4f30ed145

fix drawing serialization

view details

Kevin Lee

commit sha 442d533c2e0f0cabae088731c15f5848e9f1e7b9

get rid of references to drawMode

view details

Kevin Lee

commit sha 0f1759998bda885c10e0a46ad199c447fa3eb3bb

remove unused variable

view details

Kevin Lee

commit sha 037a581791f27847147f408bb428dccdca6e7a2c

Merge branch 'master' of github.com:mozilla/hubs into feature/drawing-triangles-refactor

view details

Kevin Lee

commit sha 963a4ac831d64ade7210f46101ed9e8f2836c062

Merge pull request #2992 from mozilla/feature/drawing-triangles-refactor Refactor Pen Tool to use triangles instead of triangle strips for rendering

view details

push time in a month

delete branch mozilla/hubs

delete branch : feature/drawing-triangles-refactor

delete time in a month

PR merged mozilla/hubs

Refactor Pen Tool to use triangles instead of triangle strips for rendering

Three.js as of r112 has removed drawMode from meshes, thus deprecating support for triangle-strip rendering. This updates networked-drawing and sharedbuffergeometry to use indexed triangles instead.

This also moves the serialize drawing button on the drawing hover menu so that it doesn't overlap with the new media refresh button.

+106 -152

0 comment

4 changed files

InfiniteLee

pr closed time in a month

push eventmozilla/hubs

Robert Long

commit sha 5e3d6c69f4cbcecca1b1844c74308ceadc01f664

Collapsible object info dialog

view details

Robert Long

commit sha ec5a429b883b94daddcf1cd3971762c525824aba

Fix padding on smaller breakpoints.

view details

Robert Long

commit sha a637f85948bbe27aa9b6179677d7b167ea3caf1f

Merge pull request #2775 from mozilla/feature/hide-inspect-ui Add Ability to Hide Object Info UI

view details

Brian Peiris

commit sha 169cf4c123f1c95bbc5dd536e15b7cbb4d3eab88

Fix report issue links. Remove obsolete dialog

view details

Brian Peiris

commit sha c01312e976919c2043c4c85ce26c77f6f8a932f9

Merge pull request #3011 from mozilla/bug/report-issue Fix report issue links. Remove obsolete dialog

view details

Kevin Lee

commit sha 037a581791f27847147f408bb428dccdca6e7a2c

Merge branch 'master' of github.com:mozilla/hubs into feature/drawing-triangles-refactor

view details

push time in a month

push eventmozilla/hubs

Kevin Lee

commit sha 0f1759998bda885c10e0a46ad199c447fa3eb3bb

remove unused variable

view details

push time in 2 months

Pull request review commentmozilla/hubs

Refactor Pen Tool to use triangles instead of triangle strips for rendering

 export default class SharedBufferGeometry {     this.addBuffer();   } -  restartPrimitive() {-    if (this.idx.position >= this.current.attributes.position.count) {-      console.error("maxBufferSize limit exceeded");-    } else if (this.idx.position !== 0) {-      let prev = (this.idx.position - 1) * 3;-      const position = this.current.attributes.position.array;-      this.addVertex(position[prev++], position[prev++], position[prev++]);--      this.idx.color++;-      this.idx.normal++;-    }-  }-   remove(prevIdx, idx) {     // Loop through all the attributes: position, color, normal,...     if (this.idx.position > idx.position) {       for (const key in this.idx) {-        const componentSize = 3;+        const componentSize = key === "index" ? 1 : 3;         let pos = prevIdx[key] * componentSize;         const start = (idx[key] + 1) * componentSize;         const end = this.idx[key] * componentSize;         for (let i = start; i < end; i++) {-          this.current.attributes[key].array[pos++] = this.current.attributes[key].array[i];+          if (key === "index") {+            //index needs to be handled specially+            this.current.index.array[pos++] = this.current.index.array[i] - idx.position - 1;

unlike position, normals or colors, indexes are not accessible on the geometry.attributes property, they're instead accessed via geometry.index directly, or via getIndex() or setIndex()

InfiniteLee

comment created time in 2 months

PullRequestReviewEvent

PR opened mozilla/hubs

switch over to using SAB for physics

This is a PR to be merged in the future when SharedArrayBuffer and Atomics become available across all browsers that Hubs is supporting. This switches over the PhysicsSystem to use SAB instead of transferrables for communication with the physics worker.

+31 -23

0 comment

1 changed file

pr created time in 2 months

create barnchmozilla/hubs

branch : feature/physics-sab

created branch time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 442d533c2e0f0cabae088731c15f5848e9f1e7b9

get rid of references to drawMode

view details

push time in 2 months

PR opened mozilla/hubs

Refactor Pen Tool to use triangles instead of triangle strips for rendering

Three.js as of r112 has removed drawMode from meshes, thus deprecating support for triangle-strip rendering. This updates networked-drawing and sharedbuffergeometry to use indexed triangles instead.

+103 -146

0 comment

3 changed files

pr created time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha f42153e2bb342774564ef3b77ec6b5f4f30ed145

fix drawing serialization

view details

push time in 2 months

push eventmozilla/hubs

John Shaughnessy

commit sha 0cabac6a3e2a8b0b6065a5778eabdeeda054eb60

Fix bug - reactivate the same waypoint

view details

John Shaughnessy

commit sha 3beafd3142c38fced23106fc7d6a184e11a4bef3

Set default quality settings via qs params

view details

jshaughnessy

commit sha 440b56df2b0ff88dc8efdf92e474e79447ebb0a5

Merge pull request #2957 from mozilla/bug/repeat-hash-teleport Fix bug - reactivate the same waypoint

view details

jshaughnessy

commit sha 24cf8cc4dace4e4c82b18a812a39a9add9444b0e

Merge pull request #2959 from mozilla/feature/qs_quality Set default quality settings via qs params

view details

jshaughnessy

commit sha feb4bc5f9157c8d1df4b9e683678ffa231c8d089

Revert "Set default quality settings via qs params"

view details

jshaughnessy

commit sha 9af73bd39eb0f2a1cb2469c0e74cd925ce4fbd27

Merge pull request #2972 from mozilla/revert-2959-feature/qs_quality Revert "Set default quality settings via qs params"

view details

robin

commit sha b686d881c94b2c45079120c0ae1e5463c8f9d1a6

updated admin homepage

view details

robin

commit sha 9db107dfc465a94eadea41e7f88b667aed58800c

fixed typo

view details

robin

commit sha 53024c4c2eaf5450c4e9a09390810162ef1c6245

fixed amazon typo

view details

Brian Peiris

commit sha 294b3ac95a049ac0667fac85ed5743230886105c

Merge pull request #2988 from robin-k-wilson/update-admin-home updated admin homepage

view details

Kevin Lee

commit sha 750f7f1569e5d517d91fff715f4fbf052af1353e

Merge branch 'master' of github.com:mozilla/hubs into feature/drawing-triangles-refactor

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 27c9155c9dc5b616a20ff202d475e046d681ed4d

fix line removal

view details

Kevin Lee

commit sha f582e0d3dbcc28cdf6936aef810168724fa4a402

revert maxDrawTimeout

view details

Kevin Lee

commit sha 81c086ff455fb514b647f895774b6951379f4449

use indexes

view details

push time in 2 months

create barnchmozilla/hubs

branch : feature/drawing-triangles-refactor

created branch time in 2 months

PullRequestReviewEvent

push eventmozilla/hubs

Kevin Lee

commit sha 15258d9919d735e15e2e1487fb9f84dcab487af8

use anchor-hash feature if link is to same room with a specified waypoint

view details

Kevin Lee

commit sha ed4e8ca29608a76e9a095361af004c3f34302332

update label to use name of spawnpoint

view details

Kevin Lee

commit sha 0f3d2b3147c0c35ed069ce3c17cf29acdd85a0c5

get rid of setting location.hash, apparently uneeded; add check in media-loader to see if url is a hash then replace with full url with hash

view details

Kevin Lee

commit sha 36be3a2b3b300e71153bb29c309d7e6d63264b52

update this.data.src

view details

Kevin Lee

commit sha 3ab1e9b0322f1b354e3c971b96219942fa69ebf7

fix typo

view details

Kevin Lee

commit sha d687d9f928285875b5a5a3e5d2ccab6a4242fee0

add window.location.search to the swapped in url

view details

Kevin Lee

commit sha af749b1c33182d69268ec1a362e9dd88a283f847

Merge pull request #2918 from mozilla/feature/anchor-hash-links Improved room links w/ anchor hash

view details

push time in 2 months

delete branch mozilla/hubs

delete branch : feature/anchor-hash-links

delete time in 2 months

PR merged mozilla/hubs

Improved room links w/ anchor hash

As requested in https://github.com/mozilla/hubs/issues/2898, this replaces the button text in anchor hashed room links with "Go To". This also adds a check such that if an anchor hash is pasted by itself (e.g. "#Spawn_Point_1"), the rest of the current room url will be prepended so that it resolves correctly as a room link.

waypoints3

Closes https://github.com/mozilla/hubs/issues/2898

+13 -2

0 comment

2 changed files

InfiniteLee

pr closed time in 2 months

issue closedmozilla/hubs

Support waypoint anchor short-hand links with 'Go To' button

Is your feature request related to a problem? Please describe. It's possible to use the new waypoint anchor feature (#2837) to create a teleporter link that can jump you into a new waypoint without clicking on it as seen in the attached gif. However, right now it uses the full qualified URL for the room, so the button on the link image says "Visit Room", which implies navigating to a new room entirely.

Describe the solution you'd like This is a two-part feature request, but the first part would still help significantly though I'm not entirely sure how feasible it is. It would be awesome to have a different string on the button when it is a teleport link instead of a new room (for example, saying something like 'Go To' or 'Teleport' or 'Go' or even just dropping to 'Visit' instead of 'Visit Room') so that when a user hovered, it would be more clear that it wouldn't necessarily open a new room.

The second part is presumably more complex, but it would be great to just be able to specify the desired anchor point (e.g. #WayPointName ) in a link element (or other custom element) that had the correct button associated with it. I'm not sure it's entirely necessary at this point, but it would great to have this for scenes so the teleport functionality would work even without having to change it for individual rooms. This way, if a link element (or new, custom element) detected that the link was just the waypoint anchor, it would automatically navigate to the waypoint for that specific room if it existed.

Additional context Teleport-Small

closed time in 2 months

misslivirose

push eventmozilla/hubs

Kevin Lee

commit sha 3ae17dc908ce150ea2c5f8fe391028c0d67ecc7a

add preference for changing default language

view details

Kevin Lee

commit sha f73ebd2402623e5191a1c83b51b3fd4e011be1ef

refactor i18n so that it updates locale dynamically on pref change

view details

Kevin Lee

commit sha 47b5da9b257ad30893d83df88c038a25f58e83b7

don't need to shallow copy navigator.languages

view details

Kevin Lee

commit sha d259c0bcd6bcd867f98275397c293e896e05959e

remove debug logging

view details

Kevin Lee

commit sha c541bdafcffb414e38e0b68556566c1e5502a1ae

Revert "don't need to shallow copy navigator.languages" This reverts commit 47b5da9b257ad30893d83df88c038a25f58e83b7.

view details

Kevin Lee

commit sha 377625d2a92e8dfea613538f87d5925fca8c8c20

cleanup + refactor

view details

Kevin Lee

commit sha b67d5f87e30bc6d2451e0c6edef8850fc97469fb

handle message caching better

view details

Kevin Lee

commit sha 0cdbe6d9b73c65a793e50113ea94e4505bea5a36

Merge pull request #2919 from mozilla/feature/i18n-preferences add preference to override browser locale

view details

push time in 2 months

delete branch mozilla/hubs

delete branch : feature/i18n-preferences

delete time in 2 months

PR merged mozilla/hubs

add preference to override browser locale

locale

+120 -68

0 comment

7 changed files

InfiniteLee

pr closed time in 2 months

push eventmozilla/hubs

John Shaughnessy

commit sha 33351de3ced8d88168f5ee45f80c2e50f0d19f93

Render the <Control /> inline, not as a prop

view details

Kevin Lee

commit sha 9660c08eae3f84729b7b8c04cbc67f51fd9623a6

Merge pull request #2938 from mozilla/bug/preferences-do-not-update Fix bug where preference changes are not reflected in the UI

view details

push time in 2 months

delete branch mozilla/hubs

delete branch : bug/preferences-do-not-update

delete time in 2 months

PR merged mozilla/hubs

Fix bug where preference changes are not reflected in the UI

Fix https://github.com/mozilla/hubs/issues/2922

Each individual preference list item was not checking its underlying preference when rerendered because it didn't know that the props for the <Control /> it was passed as a prop needed to change. We were getting away with this because of a side-effect I didn't know about which actually caused the entire PreferenceScreen to be re-created (which meant all of the items were being recreated in its constructor).

This fixes the bug by adding the Control object directly into the render function of PreferenceListItem.

Were we to spend more time in this file, I think we could make this more idiomatic and a bit easier to reason about -- I think I landed on the implementation of the Control function below because I was still not very comfortable with React and jsx. However, this is a highly visible bug, and this code may be changed a lot in the ongoing UI redesign, so I think this quick fix is probably best for now.

+13 -10

0 comment

1 changed file

johnshaughnessy

pr closed time in 2 months

issue closedmozilla/hubs

Preference list checkboxes don't update visuals

Description Clicking on preference checkboxes should immediately update the visuals and the underlying preference in local storage. It appears that clicking the buttons DO update the local storage, but the visuals do not update.

To Reproduce Steps to reproduce the behavior:

  1. Go to preferences page
  2. Click on a checkbox
  3. See error

Screenshots image

Hardware

  • Device: Desktop
  • OS: Linux
  • Browser: Firefox

closed time in 2 months

johnshaughnessy

push eventmozilla/hubs

Kevin Lee

commit sha d687d9f928285875b5a5a3e5d2ccab6a4242fee0

add window.location.search to the swapped in url

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 377625d2a92e8dfea613538f87d5925fca8c8c20

cleanup + refactor

view details

Kevin Lee

commit sha b67d5f87e30bc6d2451e0c6edef8850fc97469fb

handle message caching better

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha c541bdafcffb414e38e0b68556566c1e5502a1ae

Revert "don't need to shallow copy navigator.languages" This reverts commit 47b5da9b257ad30893d83df88c038a25f58e83b7.

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha d259c0bcd6bcd867f98275397c293e896e05959e

remove debug logging

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 47b5da9b257ad30893d83df88c038a25f58e83b7

don't need to shallow copy navigator.languages

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha f73ebd2402623e5191a1c83b51b3fd4e011be1ef

refactor i18n so that it updates locale dynamically on pref change

view details

push time in 2 months

Pull request review commentmozilla/hubs

add preference to override browser locale

 const DEFINITIONS = new Map([   [     CATEGORY_MISC,     [+      {+        key: "locale",+        prefType: PREFERENCE_LIST_ITEM_TYPE.SELECT,+        options: availableLocales,+        defaultString: "browser",+        promptForRefresh: true

The main issue is that i18n.js is a really "dumb" chunk of code that is included in a bunch of other files- but it has the duty of loading the locale files via dynamic imports. It somehow needs to be notified that the locale has been changed via preferences in order to load the newly requested locale. This is typically done elsewhere by listening for statechanged on the parameter store, however since i18n.js is loaded so early, there isn't a reference it can use to the parameter store in order to listen for those events yet.

Assuming the above is solved, the next step is re-rendering the various WrappedIntlProvider trees- but that should be handled automatically as locale-updated will be fired, and that will cause the state on WrappedIntlProvider to get updated, causing a re-render. I'm not sure that key={locale} will do anything more to help with that (maybe that is something from the older versions of react-intl?).

InfiniteLee

comment created time in 2 months

PullRequestReviewEvent

issue commentmozilla/hubs

Preference list checkboxes don't update visuals

Seems to have been caused by this commit: https://github.com/mozilla/hubs/commit/40a355f69794bb3da2317714320385a535c1bcbe

johnshaughnessy

comment created time in 2 months

Pull request review commentmozilla/hubs

Improved room links w/ anchor hash

 AFRAME.registerComponent("media-loader", {         this.showLoaderTimeout = setTimeout(this.showLoader, 100);       } +      //check if url is an anchor hash e.g. #Spawn_Point_1+      if (src.charAt(0) === "#") {+        src = this.data.src = `${window.location.origin}${window.location.pathname}${src}`;

Yea, this was unfortunately necessary because other components specifically refer to this component's data.src

InfiniteLee

comment created time in 2 months

PullRequestReviewEvent

PR opened mozilla/hubs

add preference to override browser locale

locale

+35 -4

0 comment

7 changed files

pr created time in 2 months

create barnchmozilla/hubs

branch : feature/i18n-preferences

created branch time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 3ab1e9b0322f1b354e3c971b96219942fa69ebf7

fix typo

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 36be3a2b3b300e71153bb29c309d7e6d63264b52

update this.data.src

view details

Kevin Lee

commit sha 8577614d83a0862a3a2d8260031443650c528582

Merge branch 'feature/anchor-hash-links' of github.com:mozilla/hubs into dev

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 36be3a2b3b300e71153bb29c309d7e6d63264b52

update this.data.src

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha ed4e8ca29608a76e9a095361af004c3f34302332

update label to use name of spawnpoint

view details

Kevin Lee

commit sha 0f3d2b3147c0c35ed069ce3c17cf29acdd85a0c5

get rid of setting location.hash, apparently uneeded; add check in media-loader to see if url is a hash then replace with full url with hash

view details

Kevin Lee

commit sha 59f3660f3f479188caa072f66fdaece1a5317f2b

Merge branch 'feature/anchor-hash-links' of github.com:mozilla/hubs into dev

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 0f3d2b3147c0c35ed069ce3c17cf29acdd85a0c5

get rid of setting location.hash, apparently uneeded; add check in media-loader to see if url is a hash then replace with full url with hash

view details

push time in 2 months

PR opened mozilla/hubs

Allow navigation with room links w/ anchor hash

As an extension to #2837, this update allows room links (that are pointed to the current room) that contain a waypoint/spawnpoint anchor hash to replace the hash in the url instead of reloading the page with the full url. This enables a simple visual way to teleport to waypoints in a room.

waypoints

+13 -3

0 comment

1 changed file

pr created time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha ed4e8ca29608a76e9a095361af004c3f34302332

update label to use name of spawnpoint

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 9e72c0ccd44f06cf4002eb94c57fb905425c7105

change label

view details

push time in 2 months

push eventmozilla/hubs

Robert Long

commit sha 6fe776358745ed89d2d54104354fba311396cde8

Medium quality mode WIP

view details

Robert Long

commit sha 01a5923c94a3589c9c0b54ac2896b6996eb603b8

Merge branch 'feature/update-shadows-on-scene-load' into feature/medium-quality-mode

view details

Robert Long

commit sha 8f29159ca4c0af74034142261f344f7782dddb47

Add medium quality setting alongside low quality

view details

Robert Long

commit sha a5d024874721f2788184c6e7272ce1f2ed7fa84d

Merge branch 'master' into feature/medium-quality-mode

view details

Robert Long

commit sha bcd22d6ffc5d6549d00147b15dbbd85c8ce1234d

Add support for tangent space normal maps

view details

Robert Long

commit sha 171cf838de94227cd5fa5a466700e36f7cf99c7e

Revert unnecessary changes

view details

Kevin Lee

commit sha 40a355f69794bb3da2317714320385a535c1bcbe

update react-intl pkg; fix how locale is identified; update how translation is picked

view details

Brian Peiris

commit sha 0e9068ba604704877b1a469479a15b4264100920

invite links

view details

Fernando Serrano

commit sha 40173b2e6a90ed7825bcfa0e6f038b384fbf07c7

Fixes #2833 adding support to specify a spawn point name on the url using a anchor (#)

view details

Fernando Serrano

commit sha 4749fd84bd229d00f7196dafc17af50930953ba4

Fix naming on SpawnPoint/Waypoint and move initialSpawnHappened inside the promise

view details

Fernando Serrano

commit sha 0854437659ba8581e64d5a7a7e2f1e07ccc1d4c8

Refactor moveToWaypoint to add instant parameter

view details

Fernando Serrano

commit sha 848ad0e6a04322e2dcaf3a8920ddeaa3a5dff4b9

Animated jumping when using hashtag

view details

Fernando Serrano

commit sha bc28ba3447ac9959edfd4bb33940a7a4ef9f97a4

Use object3d.name instead of className

view details

Fernando Serrano

commit sha 7a506e36d25fa2b29d292d9f468a69423490d252

Add preference for animate waypoint transitions

view details

Brian Peiris

commit sha 34f3aa2894a011aafb39e5199a346a742fdc474e

PR feedback

view details

Kevin Lee

commit sha 6c7bb9dc645546da9b1a96ada5cd0a5e63fbc9f8

Split up locales into individual locale files; update locale code to handle dynamically loading locale files

view details

Kevin Lee

commit sha 063895de5e96896eb3da3cbb38d3516865c1eb44

Merge branch 'master' of github.com:mozilla/hubs into feature/i18n-refactor

view details

Brian Peiris

commit sha 2c2a35e5374b15dff458f4cef72c7c895a5ca692

Merge pull request #2838 from mozilla/feature/invite-links Basic Hub Invites

view details

Brian Peiris

commit sha 3745f83098400857223f936d832e5f9edaa81340

Fix onHubUpdated call

view details

Brian Peiris

commit sha 739dc5841174412d6274fcb1610a83726374c082

Merge branch 'feature/invite-links'

view details

push time in 2 months

create barnchmozilla/hubs

branch : feature/anchor-hash-links

created branch time in 2 months

issue commentmozilla/hubs

Non English User Interfaces

@kaitas @jimver04 @h-nakae With #2879 now released, it is much easier to add locales for Hubs. Please see https://github.com/mozilla/hubs/blob/master/src/assets/locales/README.md for information about how to add new/update existing locales. We would very much appreciate any translations you would like to submit!

kaitas

comment created time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 40a355f69794bb3da2317714320385a535c1bcbe

update react-intl pkg; fix how locale is identified; update how translation is picked

view details

Kevin Lee

commit sha 6c7bb9dc645546da9b1a96ada5cd0a5e63fbc9f8

Split up locales into individual locale files; update locale code to handle dynamically loading locale files

view details

Kevin Lee

commit sha 063895de5e96896eb3da3cbb38d3516865c1eb44

Merge branch 'master' of github.com:mozilla/hubs into feature/i18n-refactor

view details

Kevin Lee

commit sha f4804f8e9c7ca0b536ba8a43af3c0d82b22bfc33

Merge branch 'master' of github.com:mozilla/hubs into feature/i18n-refactor

view details

Kevin Lee

commit sha 5e6c51c69d7381e12ebc747ef051ffeb293435c9

update readme

view details

Kevin Lee

commit sha 7d1b6299688c2a5fd7f64767b449fa8b963af358

Merge branch 'master' of github.com:mozilla/hubs into feature/i18n-refactor

view details

Kevin Lee

commit sha fcc401380bc02d65c89bca03a561cd8b72ff4b7e

add script to sync locale files; update readme; update contributing

view details

Kevin Lee

commit sha 7213278ce46f8aa720dbcd4f9d90707afb0faf9e

add WrappedIntlProvider which allows IntlProvider to be updated when a new locale is loaded

view details

Kevin Lee

commit sha 2aba686da9df36fef6452f63aa962f9afbb4be72

revert changes to admin.js since that uses a different i18n.js

view details

Kevin Lee

commit sha 67e90a7e6ebcd394cec07e1f7b186d349f06a36d

review cleanup

view details

Kevin Lee

commit sha c123c5d4ed7a08a80e0fcae41f4e65171f4f66d7

Merge pull request #2879 from mozilla/feature/i18n-refactor Improved i18n

view details

push time in 2 months

delete branch mozilla/hubs

delete branch : feature/i18n-refactor

delete time in 2 months

PR merged mozilla/hubs

Improved i18n
  • Refactors i18n code to support dynamically loading locale files (so all locales don't need to be bundled at build time)
  • Use navigator.languages correctly if available (don't just grab the first one in the list)
  • Splits up locales into different locale files
  • Add short README for adding new locales
  • Updates react-intl library to latest

See: #2637 Closes #2640 Closes #2373 Unblocks #2639

+1467 -1179

1 comment

35 changed files

InfiniteLee

pr closed time in 2 months

issue closedmozilla/hubs

Non English User Interfaces

I'm working to apply Hubs for commercial servive in Japan. (I cannot tell detail now but I'd like to contribute to this great project soon)

https://github.com/mozilla/hubs/blob/master/CONTRIBUTING.md

Is it possible to implement localized UI messages?

solution Please provide multi-language support for basic UIs. I guess it can override en-us UI messages, is this for multi-language supported? https://github.com/mozilla/hubs/blob/master/src/assets/translations.data.json

Describe alternatives you've considered I don't need to "Switch Language" immediately. It will faciliate to local users who is not familiar in English UIs.

Additional context Multi Language support in my project "Voice Changer". You can switch En/Ja immediately by a button on the top right. https://vr.gree.net/lab/vc/

closed time in 2 months

kaitas

issue closedmozilla/hubs

Download the translations file at runtime

Download the translations file at runtime + select which translation you see and add to local storage for HMC

closed time in 2 months

johnshaughnessy

push eventmozilla/hubs

Kevin Lee

commit sha 67e90a7e6ebcd394cec07e1f7b186d349f06a36d

review cleanup

view details

push time in 2 months

Pull request review commentmozilla/hubs

Improved i18n

 export function HomePage() {   });    return (-    <IntlProvider locale={getLocale()} messages={getMessages()}>-      <Page className={styles.homePage} style={pageStyle}>-        <section>-          <div className={styles.appInfo}>-            <div className={logoStyles}>-              <img src={logoUrl} />-            </div>-            {showDescription && (-              <div className={styles.appDescription}>-                <FormattedMessage id="app-description" />-              </div>-            )}-          </div>-          <div className={styles.ctaButtons}>-            {canCreateRooms && <CreateRoomButton />}-            <PWAButton />+    <Page className={styles.homePage} style={pageStyle}>

It got moved back into index.js where it originally was.

InfiniteLee

comment created time in 2 months

PullRequestReviewEvent

push eventmozilla/hubs

Kevin Lee

commit sha 2aba686da9df36fef6452f63aa962f9afbb4be72

revert changes to admin.js since that uses a different i18n.js

view details

push time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha 7213278ce46f8aa720dbcd4f9d90707afb0faf9e

add WrappedIntlProvider which allows IntlProvider to be updated when a new locale is loaded

view details

push time in 2 months

Pull request review commentmozilla/hubs

Improved i18n

+# Adding Locales++1. Copy an existing locale (e.g. [en.json](en.json)) to a new file using appropriate locale code as filename. (e.g. [zh.json](zh.json))+   * For locales that have duplicate codes (e.g. `zh` and `zh-ch`), edit [locale_config.js](locale_config.js) to define the fallback locale so that the locale file doesn't need to be duplicated.+2. Edit your new locale file with your translations.++# Adding to existing Locales++1. Add your new key and translation to [en.json](en.json).+2. Add the key and translation (either the same english translation from step 1, or the correct language equivalent if available, to the other locale files).

Made a node script sync_locales.js that will sync en.json to any other locale files present in this directory.

InfiniteLee

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentmozilla/hubs

Improved i18n

+# Adding Locales

Added to CONTRIBUTING.md

InfiniteLee

comment created time in 2 months

PullRequestReviewEvent

push eventmozilla/hubs

Kevin Lee

commit sha fcc401380bc02d65c89bca03a561cd8b72ff4b7e

add script to sync locale files; update readme; update contributing

view details

push time in 2 months

pull request commentmozilla/hubs

Improved i18n

lgtm! Glad to have a simple way to add / edit locales. Eventually we might want to lazy load them but we only have two now (not including APP_CONFIGs) so we don't need to do that work yet. It's really good that we have a clear and simple way for people to contribute new locales. Even without a sophisticated system of submission/reviewing correctness, this lets people get started.

Locales are lazy-loaded, via dynamic imports: https://github.com/mozilla/hubs/blob/7d1b6299688c2a5fd7f64767b449fa8b963af358/src/utils/i18n.js#L32

InfiniteLee

comment created time in 2 months

push eventmozilla/hubs

Fernando Serrano

commit sha 40173b2e6a90ed7825bcfa0e6f038b384fbf07c7

Fixes #2833 adding support to specify a spawn point name on the url using a anchor (#)

view details

Fernando Serrano

commit sha 4749fd84bd229d00f7196dafc17af50930953ba4

Fix naming on SpawnPoint/Waypoint and move initialSpawnHappened inside the promise

view details

Fernando Serrano

commit sha 0854437659ba8581e64d5a7a7e2f1e07ccc1d4c8

Refactor moveToWaypoint to add instant parameter

view details

Fernando Serrano

commit sha 848ad0e6a04322e2dcaf3a8920ddeaa3a5dff4b9

Animated jumping when using hashtag

view details

Fernando Serrano

commit sha bc28ba3447ac9959edfd4bb33940a7a4ef9f97a4

Use object3d.name instead of className

view details

Fernando Serrano

commit sha 7a506e36d25fa2b29d292d9f468a69423490d252

Add preference for animate waypoint transitions

view details

Brian Peiris

commit sha aa0744c71f45d742741f4381a987fb3d8f81643f

Null check on hub prop before checking entry_mode

view details

Brian Peiris

commit sha 1773f7b250e69997ce341b820ad8b3d716466ec6

Merge pull request #2882 from mozilla/bug/fix-embeds Fix embedded rooms

view details

Kevin Lee

commit sha e435e76caa1962abe1e137afbdb7d32f38d31266

Merge pull request #2837 from fernandojsg/feature/anchor-spawnpoint Add support to specify a spawn point name on the url with an anchor hash

view details

Kevin Lee

commit sha 7d1b6299688c2a5fd7f64767b449fa8b963af358

Merge branch 'master' of github.com:mozilla/hubs into feature/i18n-refactor

view details

push time in 2 months

push eventmozilla/hubs

Fernando Serrano

commit sha 40173b2e6a90ed7825bcfa0e6f038b384fbf07c7

Fixes #2833 adding support to specify a spawn point name on the url using a anchor (#)

view details

Fernando Serrano

commit sha 4749fd84bd229d00f7196dafc17af50930953ba4

Fix naming on SpawnPoint/Waypoint and move initialSpawnHappened inside the promise

view details

Fernando Serrano

commit sha 0854437659ba8581e64d5a7a7e2f1e07ccc1d4c8

Refactor moveToWaypoint to add instant parameter

view details

Fernando Serrano

commit sha 848ad0e6a04322e2dcaf3a8920ddeaa3a5dff4b9

Animated jumping when using hashtag

view details

Fernando Serrano

commit sha bc28ba3447ac9959edfd4bb33940a7a4ef9f97a4

Use object3d.name instead of className

view details

Fernando Serrano

commit sha 7a506e36d25fa2b29d292d9f468a69423490d252

Add preference for animate waypoint transitions

view details

Kevin Lee

commit sha e435e76caa1962abe1e137afbdb7d32f38d31266

Merge pull request #2837 from fernandojsg/feature/anchor-spawnpoint Add support to specify a spawn point name on the url with an anchor hash

view details

push time in 2 months

PR merged mozilla/hubs

Add support to specify a spawn point name on the url with an anchor hash

It adds support to define the spawn point where you want to start, but it also lets you change it dynamically without refreshing the page. The format is url#[spawn_point_name] for example in the default room you could try:

https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point
https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point_1
https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point_2
https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point_3

If the name of the spawn point doesn't exist it will just follow the standard flow and it will spawn you at a random point.

Fixes #2833

+33 -17

1 comment

4 changed files

fernandojsg

pr closed time in 2 months

issue closedmozilla/hubs

Specify anchor link for spawn points

Is your feature request related to a problem? Please describe. It could be nice to be able to define a preferred spawn point to start for multiple reasons, one of my current use cases is to be able to run benchmarks and testing consistently so the user appears always at the same spot.

Describe the solution you'd like I have a working solution by implementing a occupySpawnPoint(waypoint) to be called before the default tryToOcuppyAnyOf (https://github.com/mozilla/hubs/blob/master/src/systems/waypoint-system.js#L336) if we provide a hash tag and it can be dynamically detected so we can change it at runtime too. If the spawn point name is not found, it will just follow the standard flow and will assign a random point.

Here is a video testing it: https://streamable.com/taxasv

Partially discussed too in https://github.com/mozilla/hubs/issues/2667

closed time in 2 months

fernandojsg

issue commentmozilla/hubs

Note board creation for rooms

Text entered into the chat bar can be "spawned" into an image by clicking the magic wand icon. This can then be pinned like any other media.

24f7012163a03c725e3e63ccf8bd5c06

avirtualworld

comment created time in 2 months

issue commentmozilla/hubs

"+ New Room" selection should be disabled

Assigning P2 because it is just a UI issue- clicking on this when room creation is disabled simply returns you back to the home page.

Charlesc22

comment created time in 2 months

issue commentmozilla/Spoke

Unable to get video content to load

Possible duplicate of #964

jahway603

comment created time in 2 months

issue closedmozilla/hubs

Vimeo videos with sound won't load or stream

90070900-8d587a80-dcec-11ea-820d-4397f8cfa623 Description

Vimeo videos with sound won't stream. Vimeo videos without sound will

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'vimeo.com' choose a video with sound, that has permissions enabled to be embedded and downloaded
  2. Add the video link in Spoke
  3. video shows broken link
  4. Next load of the project in Spoke throws up 'FFMpeg Demuxer' or 'Failed to Init Decoder' error.
  5. Video does not show up in Hubs.

Then try with a video with no audio, and the video will load then you can watch it in Hubs.

Expected behavior Expected video with sound to load in Spoke and Play in Hub

Screenshots If applicable, add screenshots to help explain your problem.

Hardware

  • Device: PC
  • OS: Windows
  • Browser: Firefox

Additional context Have tried various format videos with AAC or MP3 sound etc. No luck. Also not possible to load Vimeo video URLS directly into a Hub room as a 'user'

closed time in 2 months

brunomartelli

issue commentmozilla/hubs

Vimeo videos with sound won't load or stream

Thank you for your report. We will be tracking this issue in the spoke repo via https://github.com/mozilla/Spoke/issues/964

brunomartelli

comment created time in 2 months

issue closedmozilla/Spoke

Vimeo Videos wont load if they have audio

on PC, windows 10 firefox. Steps to reproduce, find a video with sound on Vimeo. Copy the link paste into a Spoke video element.

closed time in 2 months

brunomartelli

issue closedmozilla/Spoke

DEMUXER ERROR COULD NOT OPEN: FFmpegDemuxer: open context failed

Spokes having video issues - this is the error message - Spokes wont let me copy the text vidoe erro .

closed time in 2 months

BonzoMartini

issue commentmozilla/Spoke

DEMUXER ERROR COULD NOT OPEN: FFmpegDemuxer: open context failed

closing, duplicate issue: #964

BonzoMartini

comment created time in 2 months

issue commentmozilla/hubs

Spatial sound appears to be coming from the wrong location

@rawnsley can you mark your scene as remixable so we can look at how it setup in spoke?

rawnsley

comment created time in 2 months

issue commentmozilla/hubs

Links Don't Work Reliably on iOS

Most browsers by default will not open popups if the javascript opening the tab/window was not called in the same callback as a user gesture (e.g. tapping on the screen). Some browsers will prompt to ask if you'd still like to allow the popup in this case, however Safari, by default, suppresses this. You can workaround this on iOS by going to Settings -> Safari and disabling "Block Pop-ups". This should effectively allow links to work.

pop-ups

emclaren

comment created time in 2 months

push eventmozilla/hubs

Brian Peiris

commit sha 0e9068ba604704877b1a469479a15b4264100920

invite links

view details

Brian Peiris

commit sha 34f3aa2894a011aafb39e5199a346a742fdc474e

PR feedback

view details

Brian Peiris

commit sha 2c2a35e5374b15dff458f4cef72c7c895a5ca692

Merge pull request #2838 from mozilla/feature/invite-links Basic Hub Invites

view details

Brian Peiris

commit sha 3745f83098400857223f936d832e5f9edaa81340

Fix onHubUpdated call

view details

Brian Peiris

commit sha 739dc5841174412d6274fcb1610a83726374c082

Merge branch 'feature/invite-links'

view details

Kevin Lee

commit sha f4804f8e9c7ca0b536ba8a43af3c0d82b22bfc33

Merge branch 'master' of github.com:mozilla/hubs into feature/i18n-refactor

view details

Kevin Lee

commit sha 5e6c51c69d7381e12ebc747ef051ffeb293435c9

update readme

view details

push time in 2 months

PR opened mozilla/hubs

Improved i18n
  • Refactors i18n code to support dynamically loading locale files (so all locales don't need to be bundled at build time)
  • Use navigator.languages correctly if available (don't just grab the first one in the list)
  • Splits up locales into different locale files
  • Add short README for adding new locales
  • Updates react-intl library to latest
+1236 -1069

0 comment

30 changed files

pr created time in 2 months

push eventmozilla/hubs

Kevin Lee

commit sha bbc17597bfea3d8619f2abad54e4a3de02f20343

listen for blocking events even when you're not in the room yet

view details

Kevin Lee

commit sha d07acbc035aafb1b3001a83bb64a91301a7b7cc1

Merge branch 'master' of github.com:mozilla/hubs into fix/blocking-lobby-users

view details

Kevin Lee

commit sha 6f76a14132aefe5e90f7417f9952fb760b9ebc33

Merge pull request #2581 from mozilla/fix/blocking-lobby-users Handle being blocked from the lobby correctly

view details

robin

commit sha 1153b1baf8de807296f8592f940c285ac20ea274

add missing occupant data

view details

Robin K Wilson

commit sha 4c9f884208aefe85f609685e41afdda6baabd160

Merge pull request #2794 from robin-k-wilson/fix-missing-data add missing occupant data

view details

Kevin Lee

commit sha 063895de5e96896eb3da3cbb38d3516865c1eb44

Merge branch 'master' of github.com:mozilla/hubs into feature/i18n-refactor

view details

push time in 2 months

create barnchmozilla/hubs

branch : feature/i18n-refactor

created branch time in 2 months

MemberEvent

push eventInfiniteLee/three-ammo

Kevin Lee

commit sha 923c249e05aefd42d6b496991186112698d67855

Update README.md

view details

push time in 3 months

push eventInfiniteLee/three-ammo

Kevin Lee

commit sha 971db77f4e41628d54d9fcd2c3790f581284510e

Update README.md

view details

push time in 3 months

push eventInfiniteLee/three-to-ammo

Kevin Lee

commit sha a15da9afc16b834f6c1906ab94e0ab3071e9ff09

Update README.md

view details

push time in 3 months

push eventmozilla/hubs

Kevin Lee

commit sha bbc17597bfea3d8619f2abad54e4a3de02f20343

listen for blocking events even when you're not in the room yet

view details

Kevin Lee

commit sha d07acbc035aafb1b3001a83bb64a91301a7b7cc1

Merge branch 'master' of github.com:mozilla/hubs into fix/blocking-lobby-users

view details

Kevin Lee

commit sha 6f76a14132aefe5e90f7417f9952fb760b9ebc33

Merge pull request #2581 from mozilla/fix/blocking-lobby-users Handle being blocked from the lobby correctly

view details

push time in 3 months

delete branch mozilla/hubs

delete branch : fix/blocking-lobby-users

delete time in 3 months

PR merged mozilla/hubs

Handle being blocked from the lobby correctly

Previously, users only listened for block/unblock events after they enter the room. This meant that if you were blocked, you would not properly remove the blocker's avatar and would just see a stuck avatar. This just moves the event handlers so they get added even if you're only in the lobby.

This is the client side update needed to support: https://github.com/mozilla/dialog/pull/1

+2 -1

0 comment

1 changed file

InfiniteLee

pr closed time in 3 months

push eventmozilla/hubs

Greg Fodor

commit sha 41f1f673fc25ca884b3bf339bbeda76f367593b8

Set max length on fields

view details

dependabot[bot]

commit sha d1321b956e9e986ae2ccbc1037da4b16f03c0d6a

Bump https-proxy-agent from 2.2.1 to 2.2.4 in /scripts/bot Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.1 to 2.2.4. - [Release notes](https://github.com/TooTallNate/node-https-proxy-agent/releases) - [Commits](https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

Harshil

commit sha 17e0e0774665bebe5bfcb5fc57f12f0ddd8dbffc

changed footer link color fixing #2241

view details

machenmusik

commit sha 35a340b38a866b75442feda5e5a3af009d5d283a

implement useThisCamera preference

view details

Robert Long

commit sha 1ffe131abff00754b870dfb90dc171d4d425e64d

Refactoring landing page react code

view details

Robert Long

commit sha 9256aa2134124abd07eb9220cad4f723d196eddd

Merge branch 'feature/improve-code-splitting' into feature/hubs-root-refactor

view details

Robert Long

commit sha 0c0d62db27188d33bba3a1ce432b4142deed154d

Merge branch 'fix/webpack-issues' into feature/hubs-root-refactor

view details

Robert Long

commit sha 9f19d3ade53665820d99554f903e937569307f58

Refactored landing page

view details

Robert Long

commit sha 4fe49a17367cf17e533f0a00ba6dbc356a271072

Remove react router and build signin/verify pages

view details

Robert Long

commit sha 92a33f0bbc532108b3200b32610ec458158a6eae

Fix default create room config

view details

Robert Long

commit sha 9bdefefbf53678c0ec14764ac32868dadab278ef

Fix home page styling

view details

Robert Long

commit sha c2f037ff3bb2dcbd556244911e87ef72433758ef

Merge package-lock with npx merge-driver

view details

Robert Long

commit sha bccdf86e3f18742b48895949ab4499a9a731bbbe

Merge branch 'master' into feature/react-refactor-1

view details

Robert Long

commit sha f63f50d2112f94c9292c69aa6a1e95168d104a58

Add background image to signin/verify pages

view details

Robert Long

commit sha 8483e1bbac7ce1ddfbe8b56819b368bc377b1a6b

Fix loader

view details

Robert Long

commit sha 994600103a3ebe4e69750302f372bb6c3525b9eb

Fix HomePage redirects

view details

Robert Long

commit sha 380a79fbcba1cacf0d9aadb3ed3af765710bfe9b

Fix email verification requests

view details

Robert Long

commit sha 9bf22b0431d6fb772075cef9de1084c1cc897657

Fix featuredRooms requests

view details

Robert Long

commit sha b51e78a77876265a0f79535013eb2f56ee74b37e

Remove unused Overlay class

view details

Robert Long

commit sha 1cbdfeebe3489d37fe74ae64abd3057def1dcd4e

css fixes

view details

push time in 3 months

issue commentmozilla/hubs

Videos broken in Safari

If you take out youtube-dl as a factor (and run it locally to get the raw url), it appears that youtube videos are only not loading on hubs servers that are using reticulum for cors-proxying (assuming that hubs.mozilla.com and dev.reticulum.io are both using cloudflare). So one potential workaround for hubs cloud users is to use a cloudflare worker.

Any additional reports of this issue should specify if this is happening on hubs.mozilla.com or a hubs cloud server to verify if this is actually the case.

example raw video url (this url may stop working)

hubs.mozilla.com: https://hubs-proxy.com/<video_url> - works on firefox, chrome and safari

dev.reticulum.com: https://cors-proxy-dev.reticulum.io/<video_url> - works on firefox, chrome and safari

hubsloadtesting.com (cloud instance using cloudflare worker): https://hubs-hubsloadtesting-com-cors-proxy.hubsloadtesting.workers.dev/<video_url> - works on firefox, chrome and safari

hups.motziller.com (cloud instance not using cloudflare worker): https://cors-proxy.hups.motziller.com/<video_url> - does not work in safari, but works in firefox and chrome

local reticulum: https://hubs-proxy.local:4000/<video_url> - does not work in safari, but works in firefox and chrome

emclaren

comment created time in 3 months

issue commentmozilla/hubs

Videos broken in Safari

After a bunch of investigation, this appears to actually be two different issues:

  1. safari does not support certain video formats such as .mkv or .webm - we probably should show a proper error message in the case that either of these media formats is detected
  2. Certain videos (that otherwise work if uploaded) when proxied via cloudflare, do not return the correct response code which causes safari to be unable to play the videos. I believe this article documents the issue we are experiencing: https://www.stirtingale.com/guides/2018/10/mp4-not-working-cloudflare

This is a response from a working vimeo video: Screen Shot 2020-07-29 at 6 34 45 PM and this is a response from a non-working youtube video: Screen Shot 2020-07-29 at 6 34 23 PM

According to that article, we may need to disable caching for mp4's that are proxied by cloudfront, which in theory can be done by adding the header cf: { cacheTtl: -1 } to the request cloudflare's documentation, however I'm not sure how to do this nor if this is even a good idea.

emclaren

comment created time in 3 months

more